1 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Now the dictionary is compiled into gdcm lib. This is a default
3 behavior, thus any dic file specified is picked before failback to
4 the one comiled into lib
6 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
7 * Change internals for gdcmDict. Don't use any 'new' any more.
8 This should definitely solve any leak problem, and we should be
9 as fast as before, as long as don't modify too much the dictionary.
11 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
12 * STYLE: ivars should start with a capital letter.
13 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
14 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
16 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
17 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
18 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
19 new 2004 dictionaries added (thanks to JPR).
20 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
21 * CLEANUP_ROUND (15) for gdcmPixelConvert
22 - RLEFrame::NumberFragments is now of type unsigned int
23 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
24 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
27 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
28 * Initial work in gathering all transfer syntax accessors. clearly
29 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
30 ivars, but only one transfersyntax (class) ivar with equivalent method on
33 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
34 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
35 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
36 discussed (plus I didn't like having a 2000 lines patch not commited)
38 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
39 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
40 * CLEANUP_ROUND (14) for gdcmPixelConvert
41 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
42 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
43 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
45 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
46 anymore and hence avoids storing a copy of PixelConvert::Decompressed
47 into File::Pixel_Data.
49 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
50 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
51 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
52 * CLEANUP_ROUND (13) for gdcmPixelConvert
53 Substituted File::ParsePixelData() with PixelConvert::Print() new
55 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
56 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
57 method to those classes.
58 - src/gdcmFile.[cxx|h]:
59 -- Added a ::Print() method.
60 -- PixelConverter is now a reference instead of a member.
61 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
62 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
64 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
65 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
66 collaboration diagram and inheritance diagram should be generated with
68 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
69 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
70 pointlessly wrapped (see
71 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
72 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
73 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
74 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
75 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
76 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
77 -- File::Initialise: PixelConverter setup moved away to
78 PixelConverter::GrabInformationsFromHeader()
79 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
80 interpretation moved away to PixelConverter::BuildRGBImage()
82 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
83 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
84 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
86 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
87 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
88 displayed on Win32 when a brutal abort() occurs (because of uncatched
89 exception). See TODO new entry of this commit for more on this.
90 * TODO added new entry.
91 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
92 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
93 - HandleColor is no longer called from gdcmFile.cxx
94 - gdcmPixelConvert.cxx clean up on method arguments and internal
95 variable names for semantical coherence.
97 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
98 * Finished lossless transition, not only do we now read all lossless jpeg
99 images, without the need of the Cornwell lib, but we do read them properly now
100 * To reduce code (well to avoid code duplication), I defined a common place
101 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
102 redefine symbols. This is not prefect but this the best solution I found for a
103 compilation time jpeg option.
105 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
106 * Update jpeg ijg lib to support lossless jpeg implementation
107 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
109 * Also added a special copyright for dcmtk since we use their bugfixes.
112 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
113 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
114 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
115 matters, as stated in warning note at begining of %include section).
116 * src/gdcmDicomDir*.[cxx|h]: coding style
117 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
118 * src/gdcmJpeg8.cxx: doxygen fix.
119 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
120 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
121 from File:: to PixelConvert::.
123 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
124 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
125 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
126 - more code moved away from File:: to PixelConvert::
127 - fat setup of PixelConverter set in place in File::Initialise.
129 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
130 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
131 namespace at the file system level. So now you should convert your examples
133 gdcmHeader -> gdcm::Header
134 It would be nice if people keep in mind to no open the namespace, since it
135 allows compilation on broken plateform which were defining common symbol in
136 the standart namespace (like LP, Unknown ...)
138 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
139 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
140 The JPEG fragments are now parsed at the same stage than the RLE
141 information. All code related to JPEG is now in gdcmPixelConvert:
142 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
143 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
144 export a gdcmFile:: method. Those are simply global functions
145 (for the time being this is better than having them attach to
146 either gdcmFile:: or gdcmPixelConvert::).
147 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
148 and stores the result in a gdcmJPEGFragmentsInfo.
149 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
150 code (among other stuff) moved away from gdcmFile:; to
153 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
154 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
155 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
156 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
157 clean up of RLE related code.
158 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
159 - src/gdcmRLE.cxx removed
160 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
161 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
162 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
163 * CLEANUP_ROUND (9) for gdcmPixelConvert
164 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
165 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
166 away from gdcmFile:: to gdcmPixelConvert::.
168 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
169 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
170 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
171 This is because Parse7Fe0 used to parse the pixels to compute the
172 length. This task was passed over to FindDocEntryLengthOB() a long
173 time ago, EXCEPT I had forgotten the OW case...
174 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
175 we just recylce the code for parsing RLE fragments and computing
177 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
178 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
179 with the retired Parse7Fe0().
180 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
181 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
183 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
184 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
185 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
186 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
187 - src/CMakeLists.txt: alphabetic order reodering + new entries.
188 * CLEANUP_ROUND (4) for gdcmPixelConvert
189 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
190 to return an unused length.
192 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
193 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
194 this should be cleanner from the plane view. The iostream are erally a pain
195 to use to do simple stuff.
197 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
198 * Redo the compilation of the ijg jpeg library. Now only one source is
199 necesseray. No need to rename file by hand what so ever. CMake handle the
200 copying of the file within different directory, configure header file to
201 modify some symbol. The only addition made to ijg wasd a mangle table so
202 that symbol are different wether we are within 8bits or 12bits.
204 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
205 * Added documentation of vtkgdcmReader on Website:
206 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
207 with it's binary name).
208 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
209 the Website to be more complete.
210 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
211 doxygenated documentation.
212 - Doc/DoxyVtkGdcmReaderExamples.txt added
213 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
214 DoxyVtkGdmReaderExamples.html )
215 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
216 * CLEANUP_ROUND (3) for gdcmPixelConvert
217 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
219 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
220 * CLEANUP_ROUND (2) for gdcmPixelConvert
221 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
223 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
224 * CLEANUP_ROUND for gdcmPixelConvert:
225 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
226 - src/gdcmPixelStuff[h|cxx] removed
227 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
228 - src/CMakeLists.txt changed accordingly
230 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
231 gdcmVersion.py moved to newly created ATTIC related
232 gdcmPython/SetupOldies/ directory.
233 * Autotools clean up:
234 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
235 - autogen.sh configure.in acinclude.m4 python.m4 removed
237 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
238 * src/*.cxx *.h Reference to License.htm fixed to License.html.
239 * Doc/CMakeLists.txt, doxygen.config.in: fix.
240 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
242 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
243 * TODO updated with Mathieu suggestions. I proposed a template for
244 describing TODO entries and used it for new entries.
245 * Added Doc/Website/CodingStyle.html, Developpers.html,
246 DeveloppersPython.html, GdcmDataCvs.html and
247 DownloadVersion0_1.html, DownloadVersion0_3.html.
248 * Some Doc/*.txt Doxygen files (which do not really concern the
249 documentation itself, but the website) moved to html and
250 placed in directory Doc/Website:
251 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
252 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
253 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
254 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
255 * CMakeLists.txt changed accordingly.
256 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
257 DeveloppersPython.html
258 * INSTALL nows refers to Doc/Website/Installation.html
260 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
261 * Added Doc/Website directory, that contains a first raw version
264 2004-09-23 Jean-Pierre Roux
265 * FIX In order not to be poluted any longer by casting problems,
266 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
267 we can now delete[] it safely
268 * VoidArea is now called BinArea (less confusing name),
269 and all the methods called ...VoidArea... are now ... BinArea...
270 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
272 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
273 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
274 clear) TagHT, which is an inherited member of gdcmElementSet. It is
275 up to the destructor of gdcmElementSet to clean up TagHt and it's
278 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
279 * Test/CMakeLists.txt: update to follow gdcmData renamings.
280 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
282 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
283 * ENH: added some utility method that builds a flat dictionnary
284 holding all the Dicom entries contained in the recursive structure
285 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
287 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
288 BuildFlatHashTable() that build a flat dictionary.
289 - src/gdcmElementSet.h: added a new private GetTag() accessor.
290 gdcmDocument is now a friend of gdcmElementSet.
291 - src/gdcmElementSet.cxx: clean up.
292 - Example/FlatHashTablePrint.cxx added.
293 - Example/CmakeLists.txt changed accordingly
295 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
296 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
297 moved away from gdcmDocEntrySet (since this class is an abstract class
298 acting like an interface). SQDepthLevel and BaseTagKey are now
300 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
301 and associated accessors. Doxygenation of the class.
302 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
304 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
305 Use SQDepthLevel accessor instead. ::Print() adapted.
306 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
307 - src/gdcmDocument.cxx changed accordingly.
309 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
310 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
311 - The following is the doxygen comment of the typedef declaration
312 of gdcmagKey in src/gdcmCommon.h:
313 gdcmTagKey is made to old an "universal" (as in URL, Universal
314 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
315 A dicom tag allways has a group and an element, but a set of tags
316 embeded in various (optionally nested) sequences and sharing
317 the same group and element all share the same (group, element)
318 "identifier". Hence the (group, element) cannot be used as an
319 identifier (in gdcm we shall refer to a "TagKey") of a tag.
320 In order to construct a proper tag identifier (i.e. a key) we
321 consider the following definition of a TagKey:
322 - let Group, Element be the string representation of the
323 group and element dicom tag members,
324 - let ItemNumber be the string representation of the integer
325 index of the considered item number of a sequence,
326 Let the key of a tag embeded in a sequence, noted SeqTag, be
328 /ItemNumber#Group|Element
329 where "/", "#" and "|" are characters acting as separators.
330 Then the general form of a gdcmTagKey is given by:
331 Group|Element<SeqTag>
332 where <SeqTag> means NO or many instances of SeqTag.
333 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
336 but the gdcmTagKey of a tag "embeded" is the first item of
337 a sequence, itself nested in the third item of a sequence is the
339 0004|1220/2#0008|0082/0#0008|0090
340 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
341 order to hold the new sequence compatible key. Previously, the
342 GetKey() method would look in the underlying gdcmDictEntry.
343 - src/gdcmDocEntry.cxx:
344 -- constructor now copies the underlying DictEntry key, in the local
346 -- ::Print: displays the member Key, instead of the (group, element).
347 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
348 - src/gdcmDocEntrySet.h:xi
349 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
350 -- now has a new BaseTagKey member.
352 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
353 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
355 This poses the problem with the semantics of the following lines
356 LoadEntryVoidArea(0x0028,0x1201); // R LUT
357 LoadEntryVoidArea(0x0028,0x1202); // G LUT
358 LoadEntryVoidArea(0x0028,0x1203); // B LUT
359 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
360 to the long FIXME note for what the problem is. Nevertheless in
361 order to get things working the dicom dictionary was altered !
362 Please fix things urgently...
363 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
364 information), see above note on moving the member VoidArea. Nevertheless
365 the following entries previously correctly set as US are now inproperly
367 0028 1201 OW IMG Red Palette Color Lookup Table Data
368 0028 1202 OW IMG Green Palette Color Lookup Table Data
369 0028 1203 OW IMG Blue Palette Color Lookup Table Data
370 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
371 of gdcmDocEntry moved to gdcmSeqEntry.
372 * src/gdcmSeqEntry.cxx: STYLE.
374 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
375 * Test/TestAllEntryVerify.cxx minor fix and added comments.
377 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
378 * gdcmPython/testSuite.py: all the test suite in python is now moved
379 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
380 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
381 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
383 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
384 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
385 to avoid inclusion recursion until STL is reached.
386 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
387 mecanism. errno.h is not included in gdcm anymore.
388 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
389 (gdcmFormatError now inherits from gdcmFormatUnexpected).
391 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
392 gdcmData/TestAllEntryVerifyReference.txt
393 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
394 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
395 exception_on_error parameter.
396 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
397 - vtk/vtkGdcmReader.cxx changed accordingly,
398 - Example/*.cxx and Test/*.cxx changed accordingly.
400 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
401 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
402 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
403 enable_sequences removed from gdcmHeader constructor and dependencies.
404 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
405 * gdcmPython/demo/PrintHeader.py: dummy fix.
406 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
407 skip_shadow removed from gdcmHeader constructor and dependencies.
408 * Example/*.cxx and Test/*.cxx changed accordingly.
410 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
411 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
412 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
414 2004-07-21 Jean-Pierre Roux
415 * FIX Now, Parsing and Printing a DICOMDIR do work!
416 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
418 2004-07-20 Jean-Pierre Roux
419 * FIX Some brain damaged headers have Zero-Lenght fields
420 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
422 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
423 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
424 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
425 variable (instance of gdcmDebug) by a definition macro, and the instance
426 is now in static in the gdcmDebug class
427 * src/gdcmSQItem.h : (FIXME) remove an undefined method
428 * Test/PrintAllDocument.cxx : bug fix in the result of the test
430 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
431 * WARNING: ctest now depends more tightly on gdcmData. You should
432 check out gdcmData properly for things to run smoothly...
433 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
434 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
435 we need the pixels not be loaded in order to use the ValEntry
436 that displays position and size).
437 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
438 This is a C++ based equivalent of gdcmPython/testSuite.py that should
439 be deprecated. If you have any doubts about the advantages of a
440 modern scripting language (read Python) versus grass root C++ (i.e.
441 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
442 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
443 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
444 Anyhow, consider documenting the gdcmData images in
445 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
447 * Test/CMakeLists.txt:
448 - now uses TestAllEntryVerify.cxx
449 - specific comments on oldACR00001.ima (now renamed in gdcmData
450 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
451 gdcmData/TestAllEntryVerifyReference.txt
454 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
455 * src/*.[h|cxx] : typedef clean up
456 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
457 - TagKey renamed to gdcmTagKey (for external usage)
458 - VRKey renamed to gdcmVRKey (for external usage)
459 - removal of typedef duplication.
460 - Removed all unecessary inline keyword from class inline definitions.
461 - Some method|function(void) declarations replaced with method|function().
462 * src/jpeg/libijg12/jdhuff12.c:
463 - printf polluting ctest removed.
464 - TAB removal for comminting
466 - TestAllReadCompareDicom.cxx: added a test that compares all the
467 images in gdcmDataImages.h with corresponding images in
468 gdcmData/BaselineDicom/. When baseline images are not present
469 this test creates them.
470 Note: we need to validate each reference image, but before that
471 I'd like to rename them with a more explicit name...
472 - CMakeLists.txt: changed accordingly.
473 * Example/*.cxx: examples now only include gdcm.h (as opposed to
474 including each header needed).
476 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
477 * Test/*.cxx and Example/*.cxx: moved some examples away from the
478 test suite to the Example directory. Are concerned:
483 - TestWriteSimple.cxx
484 * Test/CMakeLists.txt: added some comments on reasons for black listing
485 image gdcmData/oldACR00001.ima
487 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
488 * Test/CmakeList.txt: removed the following from black list (to be coherent
489 with removal from gdcmData):
490 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
491 - gdcm-MR-PHILIPS-16.dcm
493 Added the following because after last cvs update, they cause
494 ctest -R TestReadWriteReadCompare
496 - gdcm-MR-SIEMENS-16-1.acr
498 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
499 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
500 new comments in this file) we temporarily (sigh) move to a weaker
502 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
503 we don't need to black list the following images anymore:
504 - 8BitsUncompressedColor.dcm
506 - US-PAL-8-10x-echo.dcm
507 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
508 fixes and the beautified code ;-)
509 This fixes the bug introduced in version 1.42 (when beautifying)
510 that made the parsing of 8BitsRunLengthColor.dcm unproper.
511 Note: ctest was blind to this bug (this means we need to still
512 improve the test suite). The bug could be detected by using
513 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
515 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
516 and by displaying the (garbage) produced file temp.XDCM...
518 2004-06-29 Jean-Pierre Roux
519 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
520 - replace by uggly but working old code :-(
521 A lot of things should be OK again.
522 It's really urgent to have a test suite that *tests*,
523 to prevent Frog's beautifying sessions to break all the stuff
524 (twice, withing a fortnigh ...)
526 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
527 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
528 redundancy) to added Test/TestReadWriteReadCompare.cxx
529 * Test/CmakeList.txt: because the compare test of
530 Test/TestReadWriteReadCompare.cxx fails, the following images are
531 black listed: - 8BitsUncompressedColor.dcm
533 - US-PAL-8-10x-echo.dcm
534 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
535 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
536 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
537 and ad-hoc kludge. This kludge is now removed, and on encountering
538 such an image (OB field brain damaged) we set errno. Then in
539 ::FindDocLength() we "fix" the length as being ALL what remains
540 in the file (until EOF). We then proceed, hoping for the best...
541 This fixes a SegFault in ShowDicom when trying to write such an
543 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
544 (because TestWriteRead breaks on it, after a non conformal commit?).
545 ctest now runs properly, except for MakeDicomDir (which was allways
546 broken) and the Python related stuff (still not fixed).
548 2004-06-24 Jean-Pierre Roux
549 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
550 FIX : Test/TestReadWrite now iterates on all the file names
551 (instead of infinite loop)
552 ENH : Test/TestWriteRead now iterates on all the file names
554 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
555 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
557 2004-06-24 Jean-Pierre Roux
558 FIX : - now Write drops LUT Descriptors and LUTs (if any)
559 when SamplesPerPixel =3
560 - now Write is no longer confused by
561 'BitsAllocated = 12" and 'BitsStored=12"
562 - "UN" value representation Elements are now written correctly
563 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
564 ENH : - now gdcmHeader has its own Write methods
565 (in order to split the job that has not to be done
568 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
569 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
570 loop on the same image until memory went out.
571 Note: this means we still have gobs of memory loss in PrintDocument
572 * src/gdcmDocument.cxx: fixes problem on parsing on file
573 gdcmData/16BitsJpegLosslessGrayScale.dcm.
575 2004-06-24 Jean-Pierre Roux
576 FIX : Write - All the Sequences and Sequence Item are now written
577 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
578 is added a the end, when necessary.
579 - A lot of brain-damaged images, that were read correctly are
580 now written correctly
581 - length compatible BinEntry are now loaded correctly
582 (even for odd groups)
583 Note : only Explicit Value Representation was checked.
584 (question : is implicit VR really necessary for gdcm ?)
586 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
587 * DEVELOPPER: added a proposition of coding style.
588 * src/gdcmDocEntry.h: removed every inline declaration (for test of
591 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
592 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
593 Use the gdcmDocEntry::Print() and Write() instead.
594 * src/gdcmDocument.cxx: bug fix.
596 2004-06-22 Jean-Pierre Roux
597 FIX : gdcmDocument.cxx
598 - Now we do recognize the JpegLossLess format (there was a misstyping in
599 code 'beautyfication' :-(
600 - Now we automaticaticaly load the Luts, if any
602 2004-06-22 Jean-Pierre Roux
603 In order : to write Sequences, whatever their imbrication level,
604 : to allow user to create his own Sequences
605 a lot of modif where necessary (adding, moving, or virtualising methods)
607 WARNING : save your own sources *before* cvs up !
610 ADD virtual void Write(FILE *fp, FileType filetype);
613 ADD virtual void Write(FILE *fp, FileType filetype);
614 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
617 ADD virtual void Write (FILE *fp, FileType filetype)=0;
618 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
619 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
620 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
621 ADD std::string GetEntryByName(TagName name);
622 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
624 std::string vr = "unkn",
625 std::string fourth = "unkn",
626 std::string name = "unkn");
627 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
628 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
629 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
630 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
631 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
632 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
633 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
634 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
637 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
638 ADD virtual std::string GetEntryByName (TagName tagName);
639 ADD virtual std::string GetEntryVRByName (TagName tagName);
640 REM virtual bool Write(FILE *, FileType);
641 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
642 FILE *_fp, FileType type);
643 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
644 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
645 REM virtual bool WriteEntries(FILE *_fp,FileType type);
646 REM virtual std::string GetEntryByName (std::string tagName);
647 REM virtual std::string GetEntryVRByName (std::string tagName);
648 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
649 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
650 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
652 std::string vr = "unkn",
653 std::string fourth = "unkn",
654 std::string name = "unkn");
655 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
656 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
657 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
658 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
661 ADD virtual void Write(FILE *fp, FileType filetype);
664 ADD virtual void Write(FILE *fp,FileType filetype);
667 ADD virtual void Write(FILE *fp, FileType filetype);
668 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
669 REM std::string GetEntryByNumber(guint16 group, guint16 element);
670 REM std::string GetEntryByName(TagName name);
673 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
675 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
676 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
677 The default constructor invoked by the line
678 gdcmHeader *f1 = new gdcmHeader( header );
679 was gdcmHeader::gdcmHeader(bool) instead of the expected
680 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
681 Hence the parsing wasn't executed... See also below.
682 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
683 as explicit constructor didn't do the trick to fix the above problem.
684 Could anyone explain why ?
685 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
686 properly calls gdcmValEntry::Print() (that was weed out from
687 code related to gdcmBinEntry).
689 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
690 * In order to fix memory leaks:
691 - Test/TestWriteSimple.cxx: added cleaning of free store through
693 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
694 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
695 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
696 (through the call to ::AddDicomDirMeta()) or the destructor
697 would crash when deleting uninitialized ::metaElems].
698 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
699 - src/gdcmDocument.cxx:
700 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
702 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
703 was causing memory leaks.
704 - src/gdcmSQItem.cxx:
705 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
706 cleanly handled with polymophism: sorry but my milage is low).
707 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
708 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
709 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
710 This avoids SegFaulting.
711 - src/gdcmSQItem.h: coding style.
713 - Test/TestWriteSimple still severely sucks. The output image content
714 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
715 damaged when displayed with vtkgdcmViewer.
716 - on memory leaks: TestWriteSimple leaks really less (see entry
717 of 2004-06-18 in Changelog file for the call to valgrind).
718 - on segfaults: ctest now passes all the tests but one (no more
720 * Erroneous leading white fix:
721 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
722 white[s] (as opposed to from >> xxx, that removes it [them].
723 - src/gdcmTS.cxx: ditto.
724 - gdcmPython/testSuite.py: dirty related kludge removed.
725 * src/*: remaining references to gdcmParser removed.
726 * src/*[cxx|h]: added copy[way]left header.
729 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
730 * In order to fix writing of dicom files:
731 - Test/TestWriteSimple.cxx: a simpler example of writing.
732 - Test/CMakeLists.txt changed accordingly.
733 - src/gdcmDocument.cxx:
734 -- The destructor now recursilvely removes potential sequences.
735 -- Bug fix in ::IsJPEG2000()
736 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
737 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
739 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
740 to only declared) and build on top of
741 ::GetDocEntryByNumber(guint16, guint16).
742 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
743 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
744 for usage in destructor and treatement of promotion in
745 ::ReplaceOrCreateByNumber().
746 - src/gdcmSQItem.cxx: destructor should better handle his job.
747 Test/TestWriteSimple now runs (or at least it DOES something).
748 * We can now start hutting memory links. A good starting point is:
749 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
750 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
751 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
753 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
754 * Valgrind note: after Mathieu Malaterre teached me how to read
755 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
757 Using gcc, you can force the STL to use malloc and to free memory as
758 soon as possible by globally disabling memory caching.
759 With 3.2.2 and later, you should export the environment variable
760 GLIBCPP_FORCE_NEW before running your program.
761 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
762 simply vanish (it is still not clear to me, whether this means that
763 STL std::string leaks or if valgrind believes it leaks...).
764 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
765 running bin/gdcmTests makeDicomDir):
766 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
767 - Test/makeDicomDir.cxx now properly traps empty lists and returns
769 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
770 SegFaulting (I drowned in DicomDir related code when trying to
771 understand why the list is empty...).
772 * src/gdcmDocument.h: first BSD license header try.
773 * Doc/License.txt added.
775 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
776 * src/gdcmDocument.[h|cxx]:
777 - Clean up of the Transfer related predicates. They are now all based
778 on new method isGivenTransferSyntax, that (should) handle properly
780 - general clean up, simplification, and coding style.
781 - Specific clean up of Parse7FE0() (umproperly named actually).
782 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
784 2004-06-14 Jean-Pierre Roux
786 - fix the display of Sequence Delimitor (SQDepthLevel pb)
787 - fix the display of SQItem ordinal number
788 - add the GetSQItemByOrdinalNumber method
789 - remove some useless never written private methods
791 2004-06-14 Jean-Pierre Roux
793 - adding a constructor taking a gdcmDocEntry as an input param
794 - ReplaceOrCreateByNumber now returns :
795 a gdcmBinEntry * if a Binary (void *) value is passed as a param
796 a gdcmValEntry * if a string value is passed as a param
798 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
799 according to the param type (no longer sets a gdcmDocEntry)
800 - GetValEntryByNumber, GetBinEntryByNumber added
801 - NewValEntryByNumber and NewBinEntryByNumber added
803 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
805 - GetSQItemNumber and SetSQItemNumber added, to provide
806 a (relative) Item identier inside a given Sequence
807 \warning : some pb remaining around this number
809 - AddEntry now takes the Item Number as a param
811 - adding a constructor taking a gdcmDocEntry as an input param
813 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
814 * Memory leak hunt with the following command:
815 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
816 --show-reachable=yes gdcmTests PrintDocument
817 It looks like many (all?) leaks are due to the STL (or a bad usage
818 of the STL. The lines producing the leaks now have a comment with
819 a "MEMORY LEAK" tag: you can retrieve them with
820 grep "MEMORY LEAK" src/*
821 Here are two typical examples which I can't help fixing:
826 char * test = "babo";
827 name = test; //// <--- valgrind detects 960 bytes lost in
828 //// call to std::string::operator=(char const*)
829 name.clear(); //// Doesn't help !
837 std::cout << "Type a bunch of characters followed by RETURN: ";
838 getline(std::cin, line); //// <--- valgrind dectects a loss
839 //// of 1320 bytes in call to
840 /// std::basic_istream<>& std::getline<>
846 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
847 * src/gdcmHeader.[cxx|h]:
848 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
849 and related, moved away to gdcmDocument.
850 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
851 the corresponding protected accessors of inherited class
852 gdcmDocument, removed ! As a consequence gdcmFile had to be
853 declared friend of class gdcmDocument (see below).
854 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
855 - Clean up of undefined or unused methods.
856 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
857 account the changes to gdcmHeader.h).
858 * src/gdcmDocument.h:
859 - gdcmFile is now a friend class (in order to take into account the
860 changes to gdcmHeader.h).
861 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
862 (see changes to gdcmHeader.h).
863 - Accessors (reading on the form GetEntry*) are now public.
864 - Clean up of undefined or unused methods.
865 * src/gdcmDocument.cxx:
866 - adaptation to changes to gdcmDocument.h
867 - ::OpenFile now writes a verbose message when file cannot be opened.
868 - some std::string properly set to VRKey
869 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
870 references to gdcmDocument.
871 * Test/TestFindTags.cxx: changed accordingly to above changes.
872 * gdcmPython/testSuite.py: adapted to renaming of acr files in
873 cvs repository gdcmData.
875 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
876 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
877 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
878 conflicts with gdcmValEntry::voidArea.
879 * src/gdcmValEntry.cxx: unmatching comment wiped out.
880 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
881 Value representation between StringRepresentable and BinaryRepresentable.
882 * src/gdcmDocument.cxx:
883 - method ParseDES: proper indentation restored and usage of
884 gdcmVR::IsVROfGdcmStringRepresentable wired in.
885 - method LoadDocEntry: the fingerprint left in the SetValue() of
886 unloaded entries (length > MaxSizeLoadEntry) had curiously been
887 removed. Reverting to previous code segment with the proper
888 dynamic_cast< gdcmValEntry* >.
889 Note: this was (partially) breaking the python test suite
890 (gdcmPython/testSuite.py) that made usage of the above
891 fingerprint to check presence of "Pixel Data".
892 * src/gdcmDocEntry.h: coding style.
893 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
894 now taken into account.
895 * gdcmPython/gdcm.i: adaptation to the new internal representation
896 of gdcm (exit gdcmParser, hello gdcmDocument).
897 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
899 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
900 anymore, but instead prints the loaded Python dictionary.
901 * .... alas, the python testSuite is still broken.
903 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
904 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
906 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
907 * src/gdcmUtil.h : export methods
909 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
910 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
912 * Initial addition of automatic python testing
913 * Initial addition of automatic image comparison
915 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
916 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
917 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
919 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
920 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
921 * Test/ShowDicom.cxx : bug fix for msvc compilation
922 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
924 2004-05-04 Jean-Pierre Roux
925 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
926 new concepts (and new classes) :
927 a 'gdcmDocument' is composed of a set of Doc Entries, that are
928 - elementary gdcmDocEntries (former gdcmHeaderEntries)
929 - Sequence Doc Entries (gdcmSeqEntries)
930 a Sequence is composed of Items.
931 Each item is a set of Doc Entries (this is recursive)
932 The non uniqueness of the 'Dicom tag' is due to this recursivity
933 (never taken into account)
934 Our unability to add a new 'entry' in the header
935 at the proper location (neither in the H-Table (map or multimap),
936 nor in the Chained List is also due to this recursivity.
937 Don't try, right now, to use/modify/compile these new sources :
939 We just commit all the stuff, 'as is', in order not to loose it.
941 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
942 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
944 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
945 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
946 file prefix (SetFilePrefix)
948 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
949 * Add a new test: ShowDicom, for now this is just the c++ version of
950 checkRead.sh, later it will be able to compare the image read against a
952 * Replace the DEBUG on the stack with a global entry in cmake interface:
953 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
955 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
956 * Add an example subdir, with a real example on how to read + write a
959 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
960 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
961 * Doc/CMakeLists.txt: the main page is now properly differentiated
962 between the developper and user version.
963 * Doc/doxygen.config.in: dropped search related obsolete flags
964 * src/gdcmParser.h, gdcmHeader.h: doxygenation
966 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
967 * DEVELOPPER: added some helpfull comments for compile/test/install
970 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
971 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
972 src directory, now generated in the build dir.
973 2. Tests as mentionned smarter
975 4. Add a new method in gdcmDict that return the PubDict by name
976 this is interesting for 3rd party lib like ITK,
977 where we could set the institution name / patient name...
979 * ENH: 1. Now the test suite is working for real
980 2. All binaries are now output in the gdcm-bin directory
981 (this was not true before)
983 2004-04-28 Jean-Pierre Roux
984 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
985 SeQuence indented printing of Dicom Header.
986 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
987 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
988 Computation of SQDepthLevel is now part of gdcmHeader constructor
989 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
990 tree-like structure of a Dicom Header.
991 * FIX Test code cleaning
993 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
994 * ENH: Adding automatic testing
995 1. Need a DartConfig.cmake to submit to public
996 2. Add a test driver gdcmTest.cxx
997 3. gdcmTestMain, an helper for the main test driver gdcmTest
998 4. Files in Test don't have a main anymore, this becomes interesting
999 when we add more and more tests, thus dsw don't have to load
1001 * ENH: Adding a GDCM_DATA_ROOT for testing
1002 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1003 one file instead of seven + some small cleanup
1005 2004-04-22 Jean-Pierre Roux
1006 * ENH Minor changes to the Print() methods.
1007 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1008 Header printing. Example given with :
1009 > PrintHeader fileName 2 new
1010 (SQ based tree-like structure still to be done for the Header ...)
1012 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1013 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1014 1. I have added some unsigned where needed
1015 2. Some function parameter not used -> (void)
1016 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1017 4. g++ don't like character '\' in comment
1018 5. #define jpeg_create_decompress jCreaDecompress
1019 this really need to be fixed
1020 6. virtualize destructor of gdcmObject ... leakage
1021 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1022 this also really need to be fixed
1023 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1024 remove compression file
1025 (as we only do decompression, right ?)
1026 * ENH: Change malloc/calloc/free with c++ equivalent
1028 2004-04-21 Jean-Pierre Roux
1029 * FIX gdcmHeaderHelper::GetXSpacing
1030 when a single value is found (bug ?), xpacing is now
1031 defaulted to yspacing
1033 2004-04-19 Jean-Pierre Roux
1034 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1035 * ENH add parameters :
1036 bool exception_on_error = false,
1037 bool enable_sequences = false,
1038 bool ignore_shadow = false
1039 to the gdcmFile constructors to be full gdcmParser compliant
1040 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1041 to allow reading of PAPYRUS 3.0 files
1043 2004-04-06 Jean-Pierre Roux
1044 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1046 2004-04-02 Jean-Pierre Roux
1047 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1048 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1049 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1051 2004-03-30 Jean-Pierre Roux
1052 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1053 for ACR file, written out as DICOM files (hope so...)
1055 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1056 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1057 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1058 moved to base class gdcmParser and only the specialisation is kept
1060 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1061 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1062 already does the job.
1063 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1064 (to be consistent with gdcmParser::WriteEntries).
1066 2004-03-30 Benoit Regrain
1067 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1068 upate of the object's instance. It's passed to 2 in the unfavorable
1069 case : one in the ExecuteInformation, one in the ExecuteData
1071 2004-03-29 Jean-Pierre Roux
1072 * ENH : Check on file type to be written moved
1073 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1074 * FIX : gdcmObject::ResetBoundaries now stops properly
1075 when end-of-list is reached
1076 : gdcmVersion modified (as Benoit Regrain asked)
1078 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1079 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1080 * src/gdcmUtil.cxx: added forgotten iostream include.
1081 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1082 equivalent to ExplicitVR in existing code).
1084 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1085 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1086 now contains all the gdcmGlobal related code.
1087 * minor coding style and doxygenation changes.
1089 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1090 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1091 now contains all the Debug related code.
1092 * minor clean-up of includes in src/*.cxx
1093 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1094 CreateCleanString) removed.
1095 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1096 * Doc/DoxyMainPageUser.txt added.
1097 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1098 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1099 src/gdcmDirList.cxx)
1101 2004-03-24 Jean-Pierre Roux
1102 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1104 2004-03-23 Jean-Pierre Roux
1105 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1106 big endian made volumes
1107 * ENH Now gdcmParser constructor and destructor are protected to forbid
1108 end user to instanciate class gdcmParser
1109 (only gdcmHeader and gdcmDicomDir are meaningfull)
1111 2004-03-22 Benoit Regrain
1112 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1113 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1114 gdcmSerie to gdcmDicomDirSerie
1116 2004-03-19 Jean-Pierre Roux
1117 * ENH Now the tree-like structure describing a DICOMDIR comming from
1118 an already existing DICOMDIR file is consistent with
1119 the home-made tree-like structure build ex-nihilo
1120 or build from the files held (recursively) in a Directory
1121 functions gdcmDicomDir::CheckBoundaries()
1122 gdcmObject::SetBoundaries() added
1124 2004-03-17 Jean-Pierre Roux
1125 * REM (Eric Boix bug) : removal of meaningless
1126 gdcmDicomDirImage::NewImage function.
1127 * FIX now file names and directory name are written properly in the
1129 * FIX now gdcmDicomDir constructor may be call without any trick
1132 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1133 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1134 of gdcmDicomDirImage::NewImage as empty function.
1136 2004-02-28 Jean-Pierre Roux
1137 * ENH add gdcmDicomDir:NewPatient
1138 add gdcmDicomDirPatient:NewStudy
1139 add gdcmDicomDirStudy:NewSerie
1140 add gdcmDicomDirSerie:NewImage
1141 to allow making gdcDicomDir object.
1142 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1143 (as opposite to the gdcmHeader chained list)
1145 2004-02-11 Benoit Regrain
1146 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1147 when using from python
1149 2004-02-10 Benoit Regrain
1150 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1151 * FIX : in gdcmDicomDir when the directory is empty
1152 * ENH : add callback and methods to get the progression of dicomDir
1155 2004-02-06 Jean-Pierre Roux
1156 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1157 - GDCM_META added to gdcmDicomDirType
1158 - class gdcmMeta created
1159 * ENH : - A brief summary is now displayed at the beginning of
1160 'testDicomDir' to help disaster magnitude estimation
1161 * REM : Now useless Test/explDICOMDIR.cxx
1163 2004-02-05 Benoit Regrain
1164 * ENH : add methods in gdcmObject to get the hash table or the list of
1166 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1167 * FIX : wrapping python for TagHeaderEntryHT
1169 2004-02-04 Benoit Regrain
1170 * FIX : even length for some strings when writting the dicom dir
1171 * FIX : sort the images in the dicom dir
1172 * FIX : Bug fix for python use of dicom dir
1173 * ADD : a python demo
1175 2004-02-04 Jean-Pierre Roux
1176 * FIX : Final solution (?) for icone embedded images
1177 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1178 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1179 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1180 gdcmData/gdcm-MR-SIEMENS-16.acr1
1181 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1182 to make full checking easier
1184 2004-02-04 Benoit Regrain
1185 * FIX : WriteEntries : coding style & logic in parameters
1186 * FIX : Set the elements to create the DicomDir in a dictionary file
1188 2004-02-03 Benoit Regrain
1189 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1190 * gdcmDicomDir : add the load of directory
1191 * Bug fix and print add-on
1193 2004-02-03 Jean-Pierre Roux
1194 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1195 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1196 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1197 * FIX gdcmParser.cxx : 'group length' elements are now considered
1198 as integers, even for shadow groups, when file is Implicit VR
1200 2004-02-02 Jean-Pierre Roux
1201 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1203 of the last synonym :-(
1204 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1206 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1207 * FIX taking into account the possible 7fe0,0010 multiplicity
1208 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1209 to allow removal of references to 7fe0,0010, to deal with
1210 ACR-NEMA images, when 0028,0200 is meaningfull
1212 2004-01-31 Jean-Pierre Roux
1213 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1214 no longer writes 'Un' on disk
1215 * FIX SQ elements with actual length are now dealt with corectly
1216 * FIX gdcmFile::WriteBase make the difference, for color images, between
1217 the length (for Palette expanded images)
1218 and Raw Length (non expanded image + Palette)
1219 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1220 (that broke Write). Replaced by UL.
1221 Aware user will reload the field if he
1222 thinks it's necesssary
1224 2004-01-30 Jean-Pierre Roux
1225 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1226 when 'dirty Acr' is found, to be compliant with the new
1227 IsReadable() methods.
1229 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1230 (no DOUBLE images in kosher DICOM,
1231 but so usefull for people that miss them ;-)
1233 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1234 DICOMDIR related utilities (not checked as Windoze compliant)
1236 2004-01-28 Jean-Pierre Roux
1237 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1239 2004-01-27 Jean-Pierre Roux
1240 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1241 to allow skipping the shadow elements, to save memory space.
1242 The TRUE value for this param has to be used
1243 with a FALSE value for the 'enable_sequence' param.
1244 ('public elements' may be embedded in 'shadow Sequences')
1245 * gdcmHeader methods now deal with 'embedded icones images' in the header
1246 (even when an 'icone image sequence' is announced by the
1247 element (0x0088,0x0200), but there is NO icone at all ...
1249 * gdcmHeader sometimes Image Location value doesn't follow
1250 the supposed processor endianity (see gdcmData/cr172241.dcm).
1253 * gdcmHeader add the method
1254 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1255 to get *all* the Header Entries with the same tag.
1256 GetHeaderEntrySameName is probabely *useless*
1257 (no meaning : Name is *not* an identifier within the Dictionnary)
1259 2004-01-26 Benoit Regrain
1260 * Bug fix in the print of hexadecimal representations. Remove long fields
1261 in the print and add a third level of print to print them
1263 2004-01-23 Benoit Regrain
1264 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1265 * Bug fix on test suite after remove the strip made on not string fields
1266 * Split the IsReadable method between gdcmParser which test that the file
1267 is dicom and gdcmHeader which test that it's an image file
1269 2004-01-22 Benoit Regrain
1270 * DicomDir : clean code, add methods, set variables in protected or private
1271 * gdcmUtil : bug fix for the clean string method
1273 2004-01-19 Benoit Regrain
1274 * Add the use of shadow dictionaries
1275 * bug fix and coding style
1277 2004-01-19 Benoit Regrain
1278 * src/gdcmFile.cxx : bug fix concerning the close of file
1279 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1280 * Add the update of header entries using the shadow library
1282 2004-01-19 Benoit Regrain
1283 * removal of file gdcmHeader2.cxx
1284 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1285 inheriting from gdcmParser. This split is to prepare the integration
1286 of dicom dir parsing
1287 * bug fix under python
1289 2004-01-16 Jean-Pierre Roux
1290 * REM removal of class gdcmHeaderEntrySet
1291 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1292 * ADD add file gdcmHeader2.cxx
1293 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1295 2004-01-15 Benoit Regrain
1296 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1297 entries created while parsing the header. Thus, they will be destroyed
1298 when the gdcmDictSet will be destroyed
1299 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1302 2004-01-15 Benoit Regrain
1303 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1304 made a fatal error because of the memory release at the end of program.
1305 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1306 some memory and vtk seems to have some problems with that.
1307 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1309 2004-01-14 Benoit Regrain
1310 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1311 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1312 * src/*.[h|cxx] : make changes due to class name changes
1313 * gdcmPython/demo/*.py : bug fix due to method names
1315 2004-01-13 Benoit Regrain
1316 * src/*.[h|cxx] : coding style
1317 * vtk/*.[h|cxx] : coding style
1319 2004-01-13 Benoit Regrain
1320 * gdcmPython/testSuite.py : test the readable flag of file for tests
1321 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1322 It's lied to the stl compilation by MSVC (windows, always windows...)
1323 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1325 2004-01-12 Benoit Regrain
1326 * src/*.h : add comments
1327 * src/gdcmDictSet.h : set the method BuildDictPath in public
1328 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1329 directly setted in the source code
1330 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1333 2004-01-09 Benoit Regrain
1334 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1335 * setup.py : use a reference to gdcmVERSION
1337 2004-01-07 Benoit Regrain
1338 * Modification to compile with the distutils.
1341 2003-12-10 Benoit Regrain
1342 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1343 can use a gdcmHeaderHelper to load datas
1344 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1345 made in the source code
1347 2003-12-10 Benoit Regrain
1348 * Update Windows projects and .cvsignore files
1350 2003-11-12 Jean-Pierre Roux
1351 * ENH gdcmHeader constructor has one more parameter (default value : false)
1352 that allows the user to 'go inside' the SeQuences only
1354 gdcmElValSet:Print takes it into account
1356 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1357 * ENH: Update gdcmPython/CMakeLists
1358 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1359 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1361 2003-11-10 Jean-Pierre Roux
1362 * FIX : gdcmHeader::LoadElements is now based
1363 on the ListTag listElem member,
1364 not longer on the TagElValueHT tagHt member
1365 * ENH : PrintPubElVal shows (temporarily) both results,
1366 with the tagHt member and the listElem member.
1367 (it's easier to 'see' the problems when using Printheader)
1369 * FIX : old private member LgrElem is now splitted into
1370 ReadLength : Length actually found on disk (updated only
1371 if bug fixing is necessary), for internal
1373 UsableLength : Updated by FixFoundLength, to fix a bug
1374 or to allow Parser going on.
1375 Will allow to re-write a kosher header when a SeQuence
1376 with a length (not 0000) is found
1377 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1378 because gdcmElValSet::Add does not update ListElem
1381 2003-11-07 Jean-Pierre Roux
1382 * FIX misstyping in Transfert Syntax name table
1383 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1384 when they have an actual length (not 0000 nor FFFFF)
1385 (Nobody should care of it, but DICOMDIR explorers)
1387 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1388 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1390 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1391 * ENH: vtkGdcmReader now supports LUT !
1392 (vtkgdcmViewer for now is not able to use them though)
1394 2003-11-05 Jean-Pierre Roux
1395 * in testSuite.py : new files names for checking the package
1396 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1397 that returns the pixel area size to the *aware* (vtk) user
1398 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1400 2003-11-05 Benoit Regrain
1401 * in testSuite.py : Modify the rules for checking the paths
1402 : Explicit error messages
1403 * in __init__.py : Related modif
1405 2003-11-03 Jean-Pierre Roux
1406 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1407 to be used by aware (vtk) users that want to manage
1408 LUT (and no to turn the PALETTE image into an RGB pixels one)
1409 * GetPixelType now returns 8U for 24 Bits images
1410 (vtkGdcmReader compliant)
1412 2003-10-31 Jean-Pierre Roux
1413 * Removal of *all* gdcmData images and add them again
1414 in order to loose the 'history' of un-anonymised images
1416 2003-10-31 Jean-Pierre Roux
1417 * RMV : removal of useless jBitsInJsample.h
1418 for both 8 and 12 Bits JPEG Lossy Libraries
1420 2003-10-31 Jean-Pierre Roux
1421 * ENH : Add the functions gdcmFile::GetImageDataRaw
1422 gdcmFile::GetImageDataIntoVectorRaw
1423 that act as GetImageData and GetImageDataIntoVector
1424 except the making of an RGB Plane from Gray Plane + LUT
1425 Intended to aware (vtk) users who know how to manage
1428 GetLUTRGBA return a R,G,B,A LUT if any
1429 lgrTotaleRaw gives the 'Raw' length
1430 GetImageDataRaw returns the gray Plane
1431 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1432 (They stay Grey, just like with other Dicom viewers :-(
1434 2003-10-30 Jean-Pierre Roux
1435 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1437 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1438 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1439 being coherents dicom files.
1441 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1442 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1444 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1445 * ENH: Two steps is necessary to please VC++ compiler...
1446 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1447 * ENH: Add include dir to medcon lib
1448 * FIX: only one function is being exported for now !
1449 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1451 2003-10-29 Jean-Pierre Roux
1452 * adding gdcmHeader::GetLUTRGBA
1453 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1454 --> Mathieu, the modif u're waiting for is not yet committed
1455 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1457 2003-10-27 Jean-Pierre Roux
1458 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1459 00191113.dcm DermaColorLossLess.dcm
1460 MxTwinLossLess.dcm RadBWLossLess.dcm
1461 * ENH: For version prior to vtkImageViewer2 -r 1.19
1462 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1464 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1465 * Removal of ido stuff in CMakeLists.txt
1467 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1468 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1469 * FIX: remove a call to ->Modified ... see comments
1470 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1472 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1473 * FIX: Problem with path for libvtkgdcmPython
1474 * ENH: Try adding a search script for python site-package
1475 * RMV: Remove some file from medcon lib that are not necessary
1476 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1477 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1478 * FIX: More pragma disable fro VC++,
1479 I don't think I break something as it is also disable in VTK/ITK.
1480 But it fasten debug compilation time.
1482 2003-10-23 Jean-Pierre Roux
1483 * gdcm now deals with 16 Bits Run Length Encoded images
1484 (they are compressed as 2 planes images,
1485 one for the high Bytes, the other for low Bytes)
1487 2003-10-22 Jean-Pierre Roux
1488 * Now CheckRead takes into account :
1489 - the bugged 'Leonardo' Siemens images
1490 - the XA images, sent thru the burning VPRO station
1491 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1494 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1495 * FIX: When copying a Makefile.am to CMakeLists.txt
1496 one should remove the '\'
1498 2003-10-22 Jean-Pierre Roux
1499 * in gdcmData adding a bugged 'Leonardo' Siemens image
1500 (wrong lengths in header)
1501 OK with gdcm, KO with the other viewers :-)
1502 * add a GE dlx XA image, thru the VEPRO burning station
1505 2003-10-21 Jean-Pierre Roux
1506 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1507 for a brutal checking of vtkgdcmViewer compliance
1509 2003-10-21 Jean-Pierre Roux
1510 * add the files for 'xmedcon' Jpeg Lossless library
1511 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1513 2003-10-21 Jean-Pierre Roux
1514 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1516 2003-10-21 Jean-Pierre Roux
1517 * garbage Siemens 'Leonardo' images dealt with
1518 (the patch is easy to remove)
1519 * cosmetic changes to avoid warnings
1521 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1522 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1523 no need to press 'r' now.
1525 2003-10-20 Jean-Pierre Roux
1526 * upgrade of checkRead.sh checkWrite.sh according
1527 to new Jpeg Lossless decompressor
1528 * add US.3405.1.dcm, a genuine RGB medical file ...
1529 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1530 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1532 2003-10-15 Jean-Pierre Roux
1533 * general anonymisation in gdcmData
1534 * adding the 'color files' from
1535 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1536 * adding some well knowed bugged-header images
1537 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1538 waiting for their inclusion in Python testsuite
1540 2003-10-15 Jean-Pierre Roux
1541 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1542 no longer seg faults when file is not found
1544 2003-10-14 Jean-Pierre Roux
1545 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1548 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1549 * TODO: *.in file to genereate a UseGDCM later
1551 2003-10-14 Jean-Pierre Roux
1552 * Some supposed-to-be Dicom Images have no preamble.
1553 OpenFile takes it into account
1554 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1555 * Missing elements added in dicomV3.dic
1556 (just to be affraid : have a look at
1557 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1558 and do it again next year ;->
1560 2003-10-13 Jean-Pierre Roux
1561 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1562 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1563 But there are NOT. It's fixed !
1565 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1566 * FIX: "jpeglib.h" was not found on VC++
1567 * FIX: vtkgdcm was not being installed
1569 2003-10-10 Jean-Pierre Roux
1570 * ENH : OpenFile closes the file if it *really* doesn't look like
1571 an ACR-NEMA / DICOM one.
1572 * FIX : testWrite no longer writes an empty file if the source file
1573 is not gdcm Readable
1574 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1577 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1578 * FIX: CMake generate now documentation
1579 * ENH: out of source doc build !
1580 * ENH: Generate both user and dev documentation
1581 * ENH: Should work on windows too
1582 * ENH: Only one doxygen config.in file is needed
1583 * FIX: make install should be ok now on ùnix plateform
1584 * FIX: PATH to dictionary was wrong (missing /)
1585 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1587 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1588 * vtkGdcmReader is now able to read rgb dicom file.
1589 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1590 * added a gdcmViewer to vtk test, use mouse to control
1591 window level & window width
1593 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1594 * CMake-ification of gdcm, we have now two build system
1595 * FIX: on cygwin Wsock32 doesn't exist
1596 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1598 2003-10-06 Emanuel Ollart
1599 * FIX : compilation process wad broken.
1600 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1602 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1603 * change gdcmViewer -> vtkgdcmViewer
1604 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1606 2003-10-06 Jean-Pierre Roux
1607 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1608 ( e.g : well known GE images with a wrong elem length,
1609 : Philips MRI Images with a wrong Huffman table)
1610 * still to be done : allow the reading of bugged LEONARDO Siemens images
1612 2003-10-03 Jean-Pierre Roux
1613 * Odd length strings are padded with '\0' (not with spaces,
1614 to remain compliant with already defined strings,
1615 like Transfert Syntax UID and others)
1617 2003-10-03 Jean-Pierre Roux
1618 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1619 to allow displaying RGB images (not only by affim ;-)
1621 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1622 * vtkGdcmReader is now able to read rgb dicom file.
1623 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1625 2003-10-03 Jean-Pierre Roux
1626 * A few nasty patches to allow the reading of a lot of nasty images
1627 ( e.g : well known GE images with a wrong elem length,
1628 : Philips MRI Images with a wrong Huffman table)
1629 * still to be done : allow the reading of bugged LEONARDO Siemens images
1631 2003-10-03 Jean-Pierre Roux
1632 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1634 2003-10-03 Jean-Pierre Roux
1635 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1636 to allow displaying RGB images (not only by affim ;-)
1638 2003-10-03 Jean-Pierre Roux
1639 * gdcmFile::GetImageDataIntoVector now
1640 - deals with MultiFrames MultiFragments Run Length Encoded files
1641 - deals with YcBcR (YBR_FULL) files
1642 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1643 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1645 (no sample found :-(
1647 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1648 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1649 Two reasons: - clear things
1650 - third parties acces gdcm through header files, so won't
1651 suffer anymore VC++ complains
1653 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1654 * add argv[1] in testvtkGdcmReader.cxx
1657 2003-09-24 Jean-Pierre Roux
1658 * The lines are now eigthy characters long.for
1659 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1661 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1662 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1663 char* to std::string. Thus, the use of strdup becomes useless. (see
1664 previous commis of Malaterre)
1665 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1666 before the last Malaterre's commit.
1668 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1669 * This commit should fix the Debug building under VC++, the problem
1670 was mainly a mixture of debug and release lib being loaded at startup.
1671 * I also remove a depency to a specific C function: strdup. Because I had
1672 to force the link to msvcrtd (whereas strdup is in libc).
1674 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1675 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1676 located in the gdcmCommon.h file. All use of reference of tha has been
1677 changed to now use the variable GDCM_UNFOUND.
1679 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1681 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1682 Dicom dictionary. The test suite can now be run again. Note:
1683 I'm note very happy with the " (RET)" changes. I believe this
1684 RETAINED comment should be dropped when parsing the dictionary.
1685 - PACKAGER corrected
1687 - AUTHORS updated and now in alphabetical order
1688 * Makefile.am now exports gdcm.dsw for Windoze users.
1690 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1691 * cygwin complains about missing std:: in subdir Test/
1693 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1694 * remove some methods that are now in gdcmHeaderHelper
1696 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1697 * vtkGdcmReader set spacing and origin correctly
1699 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1700 * Fix a few delete/delete[] mismatch
1702 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1703 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1704 interpretation to data given by gdcmHeader. For instance there are
1705 heuristics to get informations (look at different places).
1706 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1707 sorting DICOM images based on different strategies.
1708 * modified Makefiles accordingly.
1710 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1711 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1712 when building in debug mode
1713 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1714 src/win32/gdcmdll.dsp
1715 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1717 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1718 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1721 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1722 * src/win32/libgdcmjpeg12.dsp was not dos format
1723 * src/win32/libgdcmjpeg12.dsp :
1724 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1725 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1727 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1728 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1730 * src/gdcmFile.cxx : bug fix in affectation type
1731 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1732 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1733 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1734 symbols... future problem ?
1736 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1737 * src/win32/libgdcmijpeg12.dsp was missing
1738 * modified gdcm.dsw accordingly
1740 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1741 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1743 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1744 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1745 commit of JPR (before his hollidays to facilitate our work).
1746 * setup.py : bug fix in code. Modifications made while the last commit
1747 of JPR. The code hasn't been tested before the commit... it's so
1748 useless to make that (for best programmer that is JPR) !!!
1750 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1751 * tagged the current version as Version0_3 (i.e. version 0.3)
1753 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1754 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1755 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1756 * *.dsp : modifications to use new libgdcmijpeg8 library
1757 * setup.py : bug fix on VTKPATH variable
1758 * PACKAGER : adding all concerning windows
1760 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1761 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1763 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1764 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1765 test suite reported error.
1766 * PACKAGER file added (describes what a packager must do when
1767 packaging a new release).
1768 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1769 * configure.in: upgraded version number to 0.3.0
1770 * fixing build of rpm (through rpm -ta):
1771 - Doc/Makefile.am exports proper doxygen files
1772 - src/jpeg/libijg8/Makefile.am exports the include files.
1774 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1775 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1776 * src/gdcmHeader.h : formatting code
1778 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1779 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1780 We were obtaining error message from vtk. Now, creation of file list
1781 is made in an internal list to prevent this problem.
1782 Bug fix when output is empty.
1783 Bug fix in update of progress value. Previous commit for this was a bad
1785 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1787 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1788 * src/gdcmHeader.h : added method to get the file name
1789 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1790 files. Added method to remove all files on the input
1791 Added FIXME comment concerning the bad parsing of header made by
1792 ExecuteInformation method (in ExecuteData method)
1794 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1795 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1796 when using make instal.
1797 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1798 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1800 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1801 * setup.py : adding include dir of jpeg lib to compile all sources
1802 * */Win32/*.dsp : JPR fix for windows compilation
1804 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1805 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1807 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1808 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1810 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1811 * setup.py is again effective on un*x (takes into account the
1812 addon of the jpeg library)
1813 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1814 * Doc/Doxy* updated (includes above enhancements)
1815 * INSTALL now points to web documentation
1817 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1818 * src/gdcmHeader.h doesn't make unnecessary reference to
1820 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1822 * src/gdcm*.[cxx|h] :
1823 - to allow compilation with gcc 3.x
1824 -- clean up of STL usage (added explicit usage of std::)
1825 -- small fixes on exceptions.
1826 Note: linking not tested !
1827 - clean of doxygen comments to avoid warnings at documentation
1829 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1830 dependent convertion).
1832 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1833 * Clean up of previous JPR garbage commit (not even commented in the
1835 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1836 - moved all jpeg related files from src to src/jpeg/libijg8, with
1837 addition/modification of Makefile.am and configure.in.
1838 - the testSuite is still brain damage (not guilty).
1840 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1841 * WrapVTK.py : modifications to get correctly vtk source files to
1843 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1844 (FileName -> Filename)
1846 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1847 * vtk/vtkGdcmReader.[cxx/h]:
1848 - UpdateProgress method should now be effective
1849 - removed the limitation on having only images loaded (as opposed
1851 - when building a stack of images/volume, a lesser number of
1852 gdcmHeader and gdcmFile instances should be used (hopefully
1853 accelerating things).
1854 - when building a stack of images/volumes, files which are not
1855 loadable (wrong path-filename, wrong permissions on existing file,
1856 or file not parsable by gdcm) are replaced with a black image
1857 in the stack (for the caller to notice the problem).
1859 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1860 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1862 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1863 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1864 between standard library (std) and vtk library (problems are found
1865 under Windows... thanks Windows !)
1867 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1868 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1870 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1872 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1873 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1875 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1876 * When compiling with distutils (see setup.py) the C++ compiler is
1877 called with different flags than the default ones (with automake).
1878 In order to fix all those warning, I compiled gdcm with the command
1879 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1880 and went for warning fixes:
1881 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1882 up from unused variables.
1883 - vtk/vtkGdcmReader.cxx: potential bug fix.
1884 * src/gdcmHeader.h: Doxygen warning cleanup
1886 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1887 * gdcmPython/gdcm.i:
1888 - typemaps correction to take into account the systematic replacement
1889 of "using namespace std" with std:: prefix e.g. std::list,
1890 std::string... (cf changes of 2003-05-21).
1891 - gdcmGlob global variable of type gdcmGlobal (defined in
1892 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1893 exported to Python a as cvar.
1894 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1895 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1896 gdcmDictSet.GetPubDictTagNames() and
1897 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1898 C++ static methods).
1899 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1900 with the above changes.
1902 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1903 * setup.py, manifest.in : bug fix under linux
1905 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1906 * Modification of setup.py to compile vtk part too. Then, we have 2
1907 wrappers which must work with same distutils. For that, we have a
1908 generic distutils in distusiltsWrapping.py ; with :
1909 - build_extWrap class to wrap generically all extensions,
1910 - ExtensionWrap base class for all wrapping extension that contains
1912 - Wrapper interface which wrap sources
1913 + In WrapSwig.py we have extension and wrapper for Swig
1914 + In WrapVTK.py we have extension and wrapper for VTK
1915 * MANIFEST.in : modifications to consider vtk directory and new python
1916 files for compilation
1918 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1919 * Added python wrappers of vtkGdcmReader vtk class (see the
1920 source in vtk/vtkGdcmReader.cxx) :
1921 - vtk/Makefile.am now builds a library
1922 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1923 python library (as opposed to _gdcm.so wich are the python
1924 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1925 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1927 - configure.in has an additional flag --enable-vtk that needs
1928 to be set to enable compilation of vtk related code, that is:
1929 + vtk/vtkGdcmReader.so and
1930 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1931 + gdcmPython/vtkgdcmPython.so (see above)
1932 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1933 be read when compressed or when HighBit + 1 != BitsStored),
1934 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1935 the usage of the python wrapper of vtkGdcmReader vtk class.
1936 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1937 * src/*.[h] all occurences of stl classes are now prefixed with
1938 std::, and all occurences of "using namespace std;" where removed.
1939 This is to avoid pollution of global namespace in included files.
1940 Apparently vtk does not avoid this pitfall: when using both
1941 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1942 collision of various stl members (principally cout...).
1943 * gdcmPython/testSuite.py now cleanly removes temprory generated
1945 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1946 comply with above changes)
1948 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1949 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1950 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1951 vtk data structure (an image Flip was required).
1952 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1953 * cosmetic changes in documentation.
1955 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1956 * src/gdcmHeader.cxx: the constructor no longer exits when an
1957 unexisting file is given as argument.
1958 * The subdirectory Data (containing all the images used for the
1959 test suite) is not part of this repository anymore. A new module
1960 containing those images is now available at
1961 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1962 with the name gdcmData.
1963 All the python scripts (including the package initialisation file
1964 gdcmPython/__init__.py) were adapated to take this change into
1965 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1967 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1968 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1969 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1970 demo of the usage of this class.
1971 Compilation of this vtk part is only done when using the --enable-vtk
1972 at configure (or autogen.sh) stage.
1974 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1975 * More memory link related corrections and documentation fixes.
1977 - maximum info is obtained with a command of the form:
1978 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1979 --show-reachable=yes PrintHeader
1980 - the remaining reachable blocks seem to come from the STL
1981 allocation scheme through the usage of map and list. It looks
1982 like this memory cannot be freed but it is not a memory leak
1983 (in fact further invocation to the STL would recollect the
1984 unused memory allthough it cannot explicitely be freed).
1985 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1986 of displaying an image parsed with gdcm and displayed with VTK.
1987 Note: some images don't seem to work e.g.
1988 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1989 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1990 Allthough this weakens the semantics, it is a ditch attempt to
1991 make gdcm more thread friendly.
1993 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1994 * Memory link hunt (by using valgrind through the command
1995 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1996 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1997 gdcmHeader::_dicom_vr.
1998 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1999 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2001 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2003 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2004 * src/Makefile.am now exports all the necessary include files at
2008 * UpdateGroupLength replaced by new one
2011 * UpdateGroupLength re-written using H-Table
2012 (named UpdateGroupLengthNew untill checks are over)
2014 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2015 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2016 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2018 - gdcmHeader::GetPubElValSet removed.
2019 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2020 UpdateGroupLength, WriteElements, Write.
2021 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2022 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2023 carried the same semantics.
2024 - src/gdcmHeaderIdo.cxx changed accordingly.
2025 - gdcmFile::WriteBase now regroups all the codes from previous
2026 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2027 - enum FileType moved to gdcmCommon.h
2028 * src/gdcmHeader.cxx AddDefault trashed
2029 * gdcmGetXSize added
2030 * getimageDataSize now calls gdcmGetXSize
2031 * Test/*.cxx changed to agree with above changes
2033 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2034 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2035 (to avoid double call by end user).
2036 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2037 by end user, since gdcmHeader::gdcmHeader now handles it.
2039 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2040 * gdcm/Doc many doxygen changes:
2041 - Doxyfile now has two different versions, DoxyfileUsers that generates
2042 the html.users end users oriented documentation and
2043 DoxyfileDeveloppers that generates the html.developper developper
2044 oriented documentation.
2045 - README changed accordingly
2046 - requirement.txt removed (old design info moved to TODO).
2047 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2048 DoxyMainPage.txt, DoxyPython.txt provide more information.
2049 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2050 be updated by simply regenerating the docs with doxygen and copying
2051 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2052 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2053 all the tests in the form "if (<map>.count() >1)" were removed.
2054 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2055 ill-formed documentation sections.
2056 * src/gdcmHeader.cxx: ditto
2058 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2059 * setup.py fixed for un*x (needed macro for stdint.h)
2060 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2061 un*ces with sh-utils test utility.
2062 * gdcmPython/demo/test.py renamed to PrintHeader.py
2063 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2064 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2065 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2066 * src/gdcm*.cxx JPR's bad inclusion fixed.
2068 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2069 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2070 * gdcmPython/demo/test.py changed accordingly.
2072 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2073 * gdcmPython/Makefile.am fixed linking against libstdc++
2074 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2075 * Swig subdir (historical tests of swig version 1.3.17++) removed
2076 * Test/testChangeEntete.cxx some lines commented out in order to make
2078 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2079 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2081 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2082 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2083 hence the user doesn't need this explicit call.
2084 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2085 i.e. LoadElements() call removed.
2086 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2087 - src/Makefile.am declares the proper flag for g++.
2088 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2089 for adding user defined new tags.
2090 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2091 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2092 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2094 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2095 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2096 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2097 src/Makefile.am : the project should properly compile and install
2098 with the autotools, included the python wrappers part.
2099 * gdcm.spec.in : added a spec file for RPM packaging.
2101 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2102 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2104 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2105 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2106 to exported to the environement (see gdcmPython/testSuite.py
2108 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2109 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2110 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2111 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2112 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2114 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2115 * gdcmPython/__init__.py doesn't crash anymore when running in
2116 in InstallMode or PreInstallMode but with an environement given
2117 value of GDCM_DICT_PATH.
2118 * src/gdcmDictSet.[cxx/h] coding style.
2120 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2121 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2122 * src/gdcm.h general comments moved to TODO, and README
2123 * src/gdcm.h should now be seen as a user commodity (including it
2124 should suffice to fully use gdcm). It is nowhere including within
2125 any of the kernel files src/*.cxx and src/*.h.
2127 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2128 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2129 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2131 * src/gdcm*.cxx only include their corresponding include file
2132 (as opposed to gdcm.h)
2133 * gdcmPython/gdcm.i changed accordingly
2134 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2135 the autogen.sh generated "make snapshot" command to work.
2136 * autogen.sh removed history related references to crea package.
2138 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2139 * distutilsSwigCPlusPlus.py work around some swig portability
2142 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2143 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2144 was done in a last ditch attempt to get setup.py _really_
2145 operationnal. The python/gdcmPython layaout add the advantage
2146 of hidding away the python related distutils specific files
2147 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2148 Alas, the src directory was out of scope (i.e. it's relative
2149 position to setup.py was ../src) which made things impossible to
2150 handle (see previous version of python/setup.py). Crossing fingers...
2152 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2153 * python/setup.py now works on Un*x. (harder than I thougth)
2154 * python/distutilsSwigCPlusPlus.py can now have include files
2155 among the list of sources.
2157 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2158 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2159 * modifications in MSVC projects
2161 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2162 * As stated by the first lines of Test/ExceptionAndPython/README, it
2163 looks like we can move back to original usage of exception within
2164 src/gdcm* and hence remove the errno stuff that was introduced
2165 as a quick and dirty fixture of this problem (added to the TODO).
2166 * Doc/Doxyfile configuration file for Doxygen and corresponding
2167 README file for usage added.
2168 * Test/testWrite.cxx added. This new test comes from a split of
2169 test.cxx that is now reverted to its original purpous i.e.
2170 testing the proper parsing of a Dicom related file.
2171 testWrite.cxx concentrates on testing the IO part of gdcm.
2172 * Test/bug1.cxx (containing a bug on WIn32) added.
2173 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2174 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2175 whose purpose is to publish the content of the TagNames of the
2176 Dicom public dictionnary were not accessible without an
2177 instance of class gdcmHeader.
2178 - those methods are now static methods of gdcmDictSet and hence
2179 require no instances at all to be invocated.
2180 - within gdcmDictSet this change required to change some method
2181 to class methods (i.e. are now static) among which SetDictPath
2182 (renamed to BuildDictPath) and LoadDefaultPubDict.
2183 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2184 the above changes by calling the new method classes of gdcmDictSet.
2185 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2186 the above to be effective.
2187 * python/gdcmPython: in order to wrap properly the above changes
2188 for Python, swig version now needs to be > 1.3.17.
2189 * python/gdcmPython/Makefile fixed to adapt itself to new
2190 configure/make shema introduced by Johan Montagnat (thanks for the
2191 contribution). Alas this Makefile cannot be turned into a proper
2192 Makefile.am without some heavy changes in the configure.in
2193 (for python dectection).
2194 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2195 now avoids publishing the empty entries.
2197 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2198 * python/setup.py : bug fix concerning install under windows
2199 ExtraPath reused :-P
2200 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2202 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2203 * Dicts/dicomV3.dic : remove double spaces !!!
2204 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2205 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2208 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2209 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2210 method. Doxygenation.
2211 * src/gdcm.h clean up of JPR spurious comments.
2213 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2214 * python/distutilsSwigCPlusPlus.py now properly collects the
2215 shadow classes generated by "swig -c++" (gdcm.py in our case)
2216 when using "python setup.py install".
2217 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2218 reexports the working classes.
2219 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2220 by the classical C errno scheme. This is to prevent an obscure
2221 behavior of the python wrappers when importing wxPython.wx prior
2222 to gdcmPython (which ended up in an abort call). An illustration
2223 of this oddity can be found in the Test/ExceptionAndPython
2224 subdir (see the README file). This problem probably due to
2225 an combination of g++ and dynamic loading.
2226 * added Test/ExceptionAndPython (see above)
2228 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2229 * Changed the layout of the python part to avoid bloating main
2230 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2231 i.e. the distutils arsenal. All the python related stuff is
2232 again in a python subdir, but the package itself is now in
2234 * setup.py was cleaned up:
2235 - pythonIncludePath removed
2236 - python setup.py bdist target is now functional.
2237 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2238 collision with other packages). gdcmPython/demo/*.py changed
2241 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2242 * python subdir moved to gdcmPython (preparation of distutils packaging).
2243 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2244 distutils installer is operational.
2245 * - gdcmPython/__init__.py now properly loads the swig generated
2246 shadow classes (from gdcm.py).
2247 - gdcmPython/demo/*.py changed to import the package gdcmPython
2248 instead of gdcmPython/demo/load.py.
2249 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2251 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2252 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2253 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2254 entries within the associated public Dicom dictionary resp. the same
2255 information but sorted by the fourth field (PAT, IMG, DIR) of the
2257 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2258 are now in the "???" group.
2259 - python/gdcm.i changed accordingly,
2260 - python/demo/printGroupedPublicDict.py added, that gives an example
2261 of the above new functionalities in Python.
2263 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2264 * src/gdcm.h, gdcmHeader.cxx:
2265 - historic references to glib's g_malloc and g_free (#defined)
2266 were definitively removed.
2267 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2268 * src/gdcmElValSet.cxx:
2269 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2270 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2271 - GetElValue(string) renamed to GetElValueByName.
2272 - Added GetElementByName(string).
2273 * src/gdcmHeader.cxx: added
2274 - GetPubElValRepByNumber(guint16, guint16)
2275 - GetPubElValRepByName(string)
2276 - GetShaElValRepByNumber(guint16, guint16)
2277 - GetShaElValRepByName(string)
2278 - GetShaElValByNumber(guint16, guint16)
2279 - GetShaElValRepByName(string)
2280 - GetElValRepByNumber(guint16, guint16)
2281 - GetElValRepByName(string)
2282 - GetElValByNumber(guint16, guint16)
2283 - GetElValRepByName(string)
2284 * Doc/requirements.txt added.
2286 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2287 * Test/Makefile building now depends on the one of libgdcm.so
2288 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2289 pixel data) aware which enables finding the address (offset) of
2290 the pixel data of JPEG encoded DICOM files. This leaves only a single
2291 file in the testSuite whose pixel data address (offset) is unknown.
2292 * python/testSuite.py changed accordingly.
2294 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2295 * VC++ has some strong limitations when working with the STL, as stated
2296 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2297 "Also note that some STL containers (map, set, queue, list, deque)
2298 cannot be exported. [...]
2299 Some STL classes contain nested classes. These classes can not
2301 This is caused by a designed limitation that once a template
2302 class is instantiated, it can not be re-instantiated and
2304 Since our usage of map<> is ubiquitous in gdcm, this "designed
2305 limitation" of VC++ is a pitfall.
2306 Hence the Python wrappers of gdcm cannot be incrementally linked
2307 against the c++ dynamic library. The dirty but only workaround is
2308 to forget about incremental link of dynamic libraries and to generate
2309 the Python wrappers library with the inclusions of the underlying C++
2311 The following modifications concern this matter on Win32/VC++:
2312 - wrapping python correct with standalone wrapped dll (don't use separate
2313 dll under windows !!!!)
2314 - python21_d debug mode enabled (ask Frog how to use it :-)
2315 - NO problem with having an STL member of class for example string in C++
2316 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2317 - Python test of dcmlib in Python is ok under windows on a large set
2319 * removed glib references
2320 * typedef's inserted in gdcm.i for correct swig type management
2322 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2323 * python/demo/*.py load.py extracted from test.py. Added explore.py
2324 that only displays required tags and testAll.py that parses all
2325 the files of the testsuite without using unittest.
2326 * python/testSuite.py other additional test on new files added.
2327 * Data/* new test files added accordingly to the testSuite.
2328 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2329 the vr in the file differs from the one of the dictionary.
2331 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2332 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2333 values, but limits itself to values which are below a user specified
2334 size (by default 1024 bytes).
2335 * python/gdcm.i : elements not loaded (because their size is above the
2336 user specified treshold) are exported with their TagKey as key of the
2337 python dictionary. This enables the testsuite to make some checks
2338 on the unloaded elements (since we have their offset and size).
2339 * python/testSuite.py
2340 - now tests for the existence and proper value of the pixel data
2341 - two new examples added.
2342 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2344 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2345 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2346 aware. See the strategy comments in gdcmHeader::FindeLength().
2347 * Test/test.cxx now accepts a filename as first argument.
2348 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2349 * python/testSuite.py changed to integrate test on above files.
2351 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2352 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2353 the vr was also RET.
2354 * python/testSuite.py more tests added.
2356 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2357 * python/testSuite.py unittest test suite added (uses Data)
2358 * Data/* dcm and acr files for the test suite.
2359 * glib dependance removed from un*x version. We now use ISO C99
2360 7.18 Integer types (see stdint.h)
2361 - python/Makefile, src/Makefile src/gdcm.h
2362 * src/ when an explicit vr (like dicom files) suddenly poped an
2363 implicit element we use to mark the underlying DictEntry of the
2364 concerned ElValue with "Implicit". This strategy was damageable
2365 too the public or provite dictionaries, since some of their vr
2366 would be changed. Since Header::FindLength heavily relies on the
2367 detection by Header::FindVR of falsely explicit elements, I
2368 added an extra ImplicitVr member to ElValue (boolean).
2369 The rest of the changes we the necessary adaptations.
2371 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2372 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2374 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2376 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2377 * Adaptation for porting to VC++:
2379 o forced to use std namespace (for string to be known)
2380 o all class use __declspec export style on WIN32
2381 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2382 (in stdlib.h on Win32 but in std:: for gcc)
2383 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2384 variable GDCM_DICT_PATH.
2385 * src/gdcmHeader.cxx verbose comments made discrete.
2387 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2388 * python/gdcm.i: added a typemap that converts a C++ hashing table
2389 to native Python dictionary.
2390 * python/demo/test.py:
2391 - now uses the native dictionary for exploration of gdcmHeader.
2392 - takes an optional filename argument (the file to parse).
2393 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2394 PubElVals hashing table.
2395 * Dicts/dicomV3.dic removed error prone trailing spaces.
2397 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2398 * Python wrapping process moved away from src/Makefile to
2399 newly created python/Makefile (as well as gdcm.i)
2400 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2401 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2402 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2403 from the environement variable GDCM_DICT_PATH (when existing).
2404 * src/gdcmDict::GetTag bug fix.
2406 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2407 * Straightforward temporary fixes for swig to build the python wrappers.
2408 src/Makefile now has a python working entry [by working we mean
2409 that we can import de shadow classes without errors].
2411 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2412 * hashtest.cxx removed (since allready in Test)
2413 * src/gdcmlib.h renamed to src/gdcm.h
2414 * src/dcm.i renamed to src/gdcm.i
2415 * src/Makefile prepared for python wrapping
2417 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2418 * src/gdcmHeader.cxx :
2419 - Parsing of header is now separated from loading of element values
2420 (see gdcmHeader::LoadElements).
2421 - general clean up of hopefully all file access (creation of
2422 ReadInt16 and ReadInt32)
2424 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2425 * src/gdcmHeader.cxx :
2426 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2428 - SetLgrElem renamed to SetLength
2429 - GetLgrElem renamed to GetLength
2430 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2431 * src/gdcmElValSet.cxx fixed both GetElValue methods
2432 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2433 due to IdoDude was cleaned out.
2435 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2436 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2437 concentrates on finding the value representation (when it exists).
2438 RecupLgr now only finds the element value length, and it avoids
2439 returning the unecessary skL (skipped length).
2440 Also, offsetCourant was simply removed (with taille_fich) since
2441 it was redundant with the File position internals (by using
2442 ftell and fseek). This also made skL (see above in RecupLgr) usage
2444 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2445 on the libido specificities which are handled through class
2447 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2450 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2451 * Truckload of changes. Parsing of header is barely functional
2452 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2454 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2455 * src/gdcmHeader.cxx many addons of low level methods
2457 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2458 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2459 and _IdDcmSWAP_LONG.
2461 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2462 * This corresponds to all the changes decided at the meeting of
2463 May 23 2002. Needless to say we are running late...