1 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3 hence the user doesn't need this explicit call.
4 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
5 i.e. LoadElements() call removed.
6 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
7 - src/Makefile.am declares the proper flag for g++.
8 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
9 for adding user defined new tags.
10 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
11 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
12 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
14 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
15 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
16 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
17 src/Makefile.am : the project should properly compile and install
18 with the autotools, included the python wrappers part.
19 * gdcm.spec.in : added a spec file for RPM packaging.
21 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
22 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
24 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
25 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
26 to exported to the environement (see gdcmPython/testSuite.py
28 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
29 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
30 ElValue class renamed to gdcmElValue for obvious consistency reasons.
31 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
32 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
34 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
35 * gdcmPython/__init__.py doesn't crash anymore when running in
36 in InstallMode or PreInstallMode but with an environement given
37 value of GDCM_DICT_PATH.
38 * src/gdcmDictSet.[cxx/h] coding style.
40 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
41 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
42 * src/gdcm.h general comments moved to TODO, and README
43 * src/gdcm.h should now be seen as a user commodity (including it
44 should suffice to fully use gdcm). It is nowhere including within
45 any of the kernel files src/*.cxx and src/*.h.
47 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
48 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
49 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
51 * src/gdcm*.cxx only include their corresponding include file
52 (as opposed to gdcm.h)
53 * gdcmPython/gdcm.i changed accordingly
54 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
55 the autogen.sh generated "make snapshot" command to work.
56 * autogen.sh removed history related references to crea package.
58 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
59 * distutilsSwigCPlusPlus.py work around some swig portability
62 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
63 * Eventually, python/gdcmPython was renamed to gdcmPython. This
64 was done in a last ditch attempt to get setup.py _really_
65 operationnal. The python/gdcmPython layaout add the advantage
66 of hidding away the python related distutils specific files
67 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
68 Alas, the src directory was out of scope (i.e. it's relative
69 position to setup.py was ../src) which made things impossible to
70 handle (see previous version of python/setup.py). Crossing fingers...
72 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
73 * python/setup.py now works on Un*x. (harder than I thougth)
74 * python/distutilsSwigCPlusPlus.py can now have include files
75 among the list of sources.
77 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
78 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
79 * modifications in MSVC projects
81 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
82 * As stated by the first lines of Test/ExceptionAndPython/README, it
83 looks like we can move back to original usage of exception within
84 src/gdcm* and hence remove the errno stuff that was introduced
85 as a quick and dirty fixture of this problem (added to the TODO).
86 * Doc/Doxyfile configuration file for Doxygen and corresponding
87 README file for usage added.
88 * Test/testWrite.cxx added. This new test comes from a split of
89 test.cxx that is now reverted to its original purpous i.e.
90 testing the proper parsing of a Dicom related file.
91 testWrite.cxx concentrates on testing the IO part of gdcm.
92 * Test/bug1.cxx (containing a bug on WIn32) added.
93 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
94 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
95 whose purpose is to publish the content of the TagNames of the
96 Dicom public dictionnary were not accessible without an
97 instance of class gdcmHeader.
98 - those methods are now static methods of gdcmDictSet and hence
99 require no instances at all to be invocated.
100 - within gdcmDictSet this change required to change some method
101 to class methods (i.e. are now static) among which SetDictPath
102 (renamed to BuildDictPath) and LoadDefaultPubDict.
103 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
104 the above changes by calling the new method classes of gdcmDictSet.
105 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
106 the above to be effective.
107 * python/gdcmPython: in order to wrap properly the above changes
108 for Python, swig version now needs to be > 1.3.17.
109 * python/gdcmPython/Makefile fixed to adapt itself to new
110 configure/make shema introduced by Johan Montagnat (thanks for the
111 contribution). Alas this Makefile cannot be turned into a proper
112 Makefile.am without some heavy changes in the configure.in
113 (for python dectection).
114 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
115 now avoids publishing the empty entries.
117 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
118 * python/setup.py : bug fix concerning install under windows
120 * gdcm.dsw : bug fix concerning path for libraries for python !!!
122 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
123 * Dicts/dicomV3.dic : remove double spaces !!!
124 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
125 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
128 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
129 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
130 method. Doxygenation.
131 * src/gdcm.h clean up of JPR spurious comments.
133 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
134 * python/distutilsSwigCPlusPlus.py now properly collects the
135 shadow classes generated by "swig -c++" (gdcm.py in our case)
136 when using "python setup.py install".
137 * python/gdcmPython/__init__.py imports gdcm.py and only manually
138 reexports the working classes.
139 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
140 by the classical C errno scheme. This is to prevent an obscure
141 behavior of the python wrappers when importing wxPython.wx prior
142 to gdcmPython (which ended up in an abort call). An illustration
143 of this oddity can be found in the Test/ExceptionAndPython
144 subdir (see the README file). This problem probably due to
145 an combination of g++ and dynamic loading.
146 * added Test/ExceptionAndPython (see above)
148 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
149 * Changed the layout of the python part to avoid bloating main
150 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
151 i.e. the distutils arsenal. All the python related stuff is
152 again in a python subdir, but the package itself is now in
154 * setup.py was cleaned up:
155 - pythonIncludePath removed
156 - python setup.py bdist target is now functional.
157 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
158 collision with other packages). gdcmPython/demo/*.py changed
160 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
161 * python subdir moved to gdcmPython (preparation of distutils packaging).
162 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
163 distutils installer is operational.
164 * - gdcmPython/__init__.py now properly loads the swig generated
165 shadow classes (from gdcm.py).
166 - gdcmPython/demo/*.py changed to import the package gdcmPython
167 instead of gdcmPython/demo/load.py.
168 - gdcmPython/testSuite.py changed to import the package gdcmPython.
171 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
172 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
173 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
174 entries within the associated public Dicom dictionary resp. the same
175 information but sorted by the fourth field (PAT, IMG, DIR) of the
177 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
178 are now in the "???" group.
179 - python/gdcm.i changed accordingly,
180 - python/demo/printGroupedPublicDict.py added, that gives an example
181 of the above new functionalities in Python.
183 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
184 * src/gdcm.h, gdcmHeader.cxx:
185 - historic references to glib's g_malloc and g_free (#defined)
186 were definitively removed.
187 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
188 * src/gdcmElValSet.cxx:
189 - GetElement(guint32, guint32) renamed to GetElementByNumber.
190 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
191 - GetElValue(string) renamed to GetElValueByName.
192 - Added GetElementByName(string).
193 * src/gdcmHeader.cxx: added
194 - GetPubElValRepByNumber(guint16, guint16)
195 - GetPubElValRepByName(string)
196 - GetShaElValRepByNumber(guint16, guint16)
197 - GetShaElValRepByName(string)
198 - GetShaElValByNumber(guint16, guint16)
199 - GetShaElValRepByName(string)
200 - GetElValRepByNumber(guint16, guint16)
201 - GetElValRepByName(string)
202 - GetElValByNumber(guint16, guint16)
203 - GetElValRepByName(string)
204 * Doc/requirements.txt added.
206 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
207 * Test/Makefile building now depends on the one of libgdcm.so
208 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
209 pixel data) aware which enables finding the address (offset) of
210 the pixel data of JPEG encoded DICOM files. This leaves only a single
211 file in the testSuite whose pixel data address (offset) is unknown.
212 * python/testSuite.py changed accordingly.
214 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
215 * VC++ has some strong limitations when working with the STL, as stated
216 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
217 "Also note that some STL containers (map, set, queue, list, deque)
218 cannot be exported. [...]
219 Some STL classes contain nested classes. These classes can not
221 This is caused by a designed limitation that once a template
222 class is instantiated, it can not be re-instantiated and
224 Since our usage of map<> is ubiquitous in gdcm, this "designed
225 limitation" of VC++ is a pitfall.
226 Hence the Python wrappers of gdcm cannot be incrementally linked
227 against the c++ dynamic library. The dirty but only workaround is
228 to forget about incremental link of dynamic libraries and to generate
229 the Python wrappers library with the inclusions of the underlying C++
231 The following modifications concern this matter on Win32/VC++:
232 - wrapping python correct with standalone wrapped dll (don't use separate
233 dll under windows !!!!)
234 - python21_d debug mode enabled (ask Frog how to use it :-)
235 - NO problem with having an STL member of class for example string in C++
236 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
237 - Python test of dcmlib in Python is ok under windows on a large set
239 * removed glib references
240 * typedef's inserted in gdcm.i for correct swig type management
242 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
243 * python/demo/*.py load.py extracted from test.py. Added explore.py
244 that only displays required tags and testAll.py that parses all
245 the files of the testsuite without using unittest.
246 * python/testSuite.py other additional test on new files added.
247 * Data/* new test files added accordingly to the testSuite.
248 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
249 the vr in the file differs from the one of the dictionary.
251 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
252 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
253 values, but limits itself to values which are below a user specified
254 size (by default 1024 bytes).
255 * python/gdcm.i : elements not loaded (because their size is above the
256 user specified treshold) are exported with their TagKey as key of the
257 python dictionary. This enables the testsuite to make some checks
258 on the unloaded elements (since we have their offset and size).
259 * python/testSuite.py
260 - now tests for the existence and proper value of the pixel data
261 - two new examples added.
262 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
264 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
265 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
266 aware. See the strategy comments in gdcmHeader::FindeLength().
267 * Test/test.cxx now accepts a filename as first argument.
268 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
269 * python/testSuite.py changed to integrate test on above files.
271 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
272 * Dicts/dicomV3.dic removed all the trailing (RET) when the
274 * python/testSuite.py more tests added.
276 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
277 * python/testSuite.py unittest test suite added (uses Data)
278 * Data/* dcm and acr files for the test suite.
279 * glib dependance removed from un*x version. We now use ISO C99
280 7.18 Integer types (see stdint.h)
281 - python/Makefile, src/Makefile src/gdcm.h
282 * src/ when an explicit vr (like dicom files) suddenly poped an
283 implicit element we use to mark the underlying DictEntry of the
284 concerned ElValue with "Implicit". This strategy was damageable
285 too the public or provite dictionaries, since some of their vr
286 would be changed. Since Header::FindLength heavily relies on the
287 detection by Header::FindVR of falsely explicit elements, I
288 added an extra ImplicitVr member to ElValue (boolean).
289 The rest of the changes we the necessary adaptations.
291 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
292 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
294 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
296 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
297 * Adaptation for porting to VC++:
299 o forced to use std namespace (for string to be known)
300 o all class use __declspec export style on WIN32
301 - src/gdcmUtil.cxx new Exit method that wraps the exit call
302 (in stdlib.h on Win32 but in std:: for gcc)
303 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
304 variable GDCM_DICT_PATH.
305 * src/gdcmHeader.cxx verbose comments made discrete.
307 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
308 * python/gdcm.i: added a typemap that converts a C++ hashing table
309 to native Python dictionary.
310 * python/demo/test.py:
311 - now uses the native dictionary for exploration of gdcmHeader.
312 - takes an optional filename argument (the file to parse).
313 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
314 PubElVals hashing table.
315 * Dicts/dicomV3.dic removed error prone trailing spaces.
317 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
318 * Python wrapping process moved away from src/Makefile to
319 newly created python/Makefile (as well as gdcm.i)
320 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
321 * src/gdcmHeader::FindLength only looks for current vr when necessary.
322 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
323 from the environement variable GDCM_DICT_PATH (when existing).
324 * src/gdcmDict::GetTag bug fix.
326 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
327 * Straightforward temporary fixes for swig to build the python wrappers.
328 src/Makefile now has a python working entry [by working we mean
329 that we can import de shadow classes without errors].
331 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
332 * hashtest.cxx removed (since allready in Test)
333 * src/gdcmlib.h renamed to src/gdcm.h
334 * src/dcm.i renamed to src/gdcm.i
335 * src/Makefile prepared for python wrapping
337 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
338 * src/gdcmHeader.cxx :
339 - Parsing of header is now separated from loading of element values
340 (see gdcmHeader::LoadElements).
341 - general clean up of hopefully all file access (creation of
342 ReadInt16 and ReadInt32)
344 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
345 * src/gdcmHeader.cxx :
346 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
348 - SetLgrElem renamed to SetLength
349 - GetLgrElem renamed to GetLength
350 - ~gdcmHeader() made virtual to pesky warning messages at compile.
351 * src/gdcmElValSet.cxx fixed both GetElValue methods
352 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
353 due to IdoDude was cleaned out.
355 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
356 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
357 concentrates on finding the value representation (when it exists).
358 RecupLgr now only finds the element value length, and it avoids
359 returning the unecessary skL (skipped length).
360 Also, offsetCourant was simply removed (with taille_fich) since
361 it was redundant with the File position internals (by using
362 ftell and fseek). This also made skL (see above in RecupLgr) usage
364 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
365 on the libido specificities which are handled through class
367 * Test/implicit_vr.dcm dicom v3 in implicit value representation
370 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
371 * Truckload of changes. Parsing of header is barely functional
372 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
374 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
375 * src/gdcmHeader.cxx many addons of low level methods
377 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
378 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
381 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
382 * This corresponds to all the changes decided at the meeting of
383 May 23 2002. Needless to say we are running late...