1 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
3 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
4 new 2004 dictionaries added (thanks to JPR).
5 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
6 * CLEANUP_ROUND (15) for gdcmPixelConvert
7 - RLEFrame::NumberFragments is now of type unsigned int
8 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
9 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
12 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
13 * Initial work in gathering all transfer syntax accessors. clearly
14 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
15 ivars, but only one transfersyntax (class) ivar with equivalent method on
18 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
19 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
20 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
21 discussed (plus I didn't like having a 2000 lines patch not commited)
23 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
24 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
25 * CLEANUP_ROUND (14) for gdcmPixelConvert
26 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
27 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
28 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
30 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
31 anymore and hence avoids storing a copy of PixelConvert::Decompressed
32 into File::Pixel_Data.
34 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
35 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
36 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
37 * CLEANUP_ROUND (13) for gdcmPixelConvert
38 Substituted File::ParsePixelData() with PixelConvert::Print() new
40 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
41 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
42 method to those classes.
43 - src/gdcmFile.[cxx|h]:
44 -- Added a ::Print() method.
45 -- PixelConverter is now a reference instead of a member.
46 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
47 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
49 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
50 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
51 collaboration diagram and inheritance diagram should be generated with
53 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
54 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
55 pointlessly wrapped (see
56 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
57 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
58 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
59 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
60 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
61 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
62 -- File::Initialise: PixelConverter setup moved away to
63 PixelConverter::GrabInformationsFromHeader()
64 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
65 interpretation moved away to PixelConverter::BuildRGBImage()
67 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
68 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
69 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
71 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
72 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
73 displayed on Win32 when a brutal abort() occurs (because of uncatched
74 exception). See TODO new entry of this commit for more on this.
75 * TODO added new entry.
76 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
77 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
78 - HandleColor is no longer called from gdcmFile.cxx
79 - gdcmPixelConvert.cxx clean up on method arguments and internal
80 variable names for semantical coherence.
82 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
83 * Finished lossless transition, not only do we now read all lossless jpeg
84 images, without the need of the Cornwell lib, but we do read them properly now
85 * To reduce code (well to avoid code duplication), I defined a common place
86 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
87 redefine symbols. This is not prefect but this the best solution I found for a
88 compilation time jpeg option.
90 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
91 * Update jpeg ijg lib to support lossless jpeg implementation
92 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
94 * Also added a special copyright for dcmtk since we use their bugfixes.
97 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
98 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
99 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
100 matters, as stated in warning note at begining of %include section).
101 * src/gdcmDicomDir*.[cxx|h]: coding style
102 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
103 * src/gdcmJpeg8.cxx: doxygen fix.
104 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
105 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
106 from File:: to PixelConvert::.
108 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
109 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
110 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
111 - more code moved away from File:: to PixelConvert::
112 - fat setup of PixelConverter set in place in File::Initialise.
114 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
115 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
116 namespace at the file system level. So now you should convert your examples
118 gdcmHeader -> gdcm::Header
119 It would be nice if people keep in mind to no open the namespace, since it
120 allows compilation on broken plateform which were defining common symbol in
121 the standart namespace (like LP, Unknown ...)
123 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
124 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
125 The JPEG fragments are now parsed at the same stage than the RLE
126 information. All code related to JPEG is now in gdcmPixelConvert:
127 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
128 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
129 export a gdcmFile:: method. Those are simply global functions
130 (for the time being this is better than having them attach to
131 either gdcmFile:: or gdcmPixelConvert::).
132 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
133 and stores the result in a gdcmJPEGFragmentsInfo.
134 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
135 code (among other stuff) moved away from gdcmFile:; to
138 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
139 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
140 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
141 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
142 clean up of RLE related code.
143 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
144 - src/gdcmRLE.cxx removed
145 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
146 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
147 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
148 * CLEANUP_ROUND (9) for gdcmPixelConvert
149 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
150 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
151 away from gdcmFile:: to gdcmPixelConvert::.
153 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
154 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
155 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
156 This is because Parse7Fe0 used to parse the pixels to compute the
157 length. This task was passed over to FindDocEntryLengthOB() a long
158 time ago, EXCEPT I had forgotten the OW case...
159 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
160 we just recylce the code for parsing RLE fragments and computing
162 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
163 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
164 with the retired Parse7Fe0().
165 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
166 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
168 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
169 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
170 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
171 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
172 - src/CMakeLists.txt: alphabetic order reodering + new entries.
173 * CLEANUP_ROUND (4) for gdcmPixelConvert
174 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
175 to return an unused length.
177 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
178 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
179 this should be cleanner from the plane view. The iostream are erally a pain
180 to use to do simple stuff.
182 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
183 * Redo the compilation of the ijg jpeg library. Now only one source is
184 necesseray. No need to rename file by hand what so ever. CMake handle the
185 copying of the file within different directory, configure header file to
186 modify some symbol. The only addition made to ijg wasd a mangle table so
187 that symbol are different wether we are within 8bits or 12bits.
189 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
190 * Added documentation of vtkgdcmReader on Website:
191 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
192 with it's binary name).
193 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
194 the Website to be more complete.
195 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
196 doxygenated documentation.
197 - Doc/DoxyVtkGdcmReaderExamples.txt added
198 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
199 DoxyVtkGdmReaderExamples.html )
200 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
201 * CLEANUP_ROUND (3) for gdcmPixelConvert
202 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
204 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
205 * CLEANUP_ROUND (2) for gdcmPixelConvert
206 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
208 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
209 * CLEANUP_ROUND for gdcmPixelConvert:
210 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
211 - src/gdcmPixelStuff[h|cxx] removed
212 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
213 - src/CMakeLists.txt changed accordingly
215 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
216 gdcmVersion.py moved to newly created ATTIC related
217 gdcmPython/SetupOldies/ directory.
218 * Autotools clean up:
219 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
220 - autogen.sh configure.in acinclude.m4 python.m4 removed
222 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
223 * src/*.cxx *.h Reference to License.htm fixed to License.html.
224 * Doc/CMakeLists.txt, doxygen.config.in: fix.
225 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
227 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
228 * TODO updated with Mathieu suggestions. I proposed a template for
229 describing TODO entries and used it for new entries.
230 * Added Doc/Website/CodingStyle.html, Developpers.html,
231 DeveloppersPython.html, GdcmDataCvs.html and
232 DownloadVersion0_1.html, DownloadVersion0_3.html.
233 * Some Doc/*.txt Doxygen files (which do not really concern the
234 documentation itself, but the website) moved to html and
235 placed in directory Doc/Website:
236 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
237 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
238 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
239 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
240 * CMakeLists.txt changed accordingly.
241 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
242 DeveloppersPython.html
243 * INSTALL nows refers to Doc/Website/Installation.html
245 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
246 * Added Doc/Website directory, that contains a first raw version
249 2004-09-23 Jean-Pierre Roux
250 * FIX In order not to be poluted any longer by casting problems,
251 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
252 we can now delete[] it safely
253 * VoidArea is now called BinArea (less confusing name),
254 and all the methods called ...VoidArea... are now ... BinArea...
255 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
257 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
258 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
259 clear) TagHT, which is an inherited member of gdcmElementSet. It is
260 up to the destructor of gdcmElementSet to clean up TagHt and it's
263 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
264 * Test/CMakeLists.txt: update to follow gdcmData renamings.
265 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
267 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
268 * ENH: added some utility method that builds a flat dictionnary
269 holding all the Dicom entries contained in the recursive structure
270 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
272 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
273 BuildFlatHashTable() that build a flat dictionary.
274 - src/gdcmElementSet.h: added a new private GetTag() accessor.
275 gdcmDocument is now a friend of gdcmElementSet.
276 - src/gdcmElementSet.cxx: clean up.
277 - Example/FlatHashTablePrint.cxx added.
278 - Example/CmakeLists.txt changed accordingly
280 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
281 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
282 moved away from gdcmDocEntrySet (since this class is an abstract class
283 acting like an interface). SQDepthLevel and BaseTagKey are now
285 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
286 and associated accessors. Doxygenation of the class.
287 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
289 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
290 Use SQDepthLevel accessor instead. ::Print() adapted.
291 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
292 - src/gdcmDocument.cxx changed accordingly.
294 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
295 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
296 - The following is the doxygen comment of the typedef declaration
297 of gdcmagKey in src/gdcmCommon.h:
298 gdcmTagKey is made to old an "universal" (as in URL, Universal
299 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
300 A dicom tag allways has a group and an element, but a set of tags
301 embeded in various (optionally nested) sequences and sharing
302 the same group and element all share the same (group, element)
303 "identifier". Hence the (group, element) cannot be used as an
304 identifier (in gdcm we shall refer to a "TagKey") of a tag.
305 In order to construct a proper tag identifier (i.e. a key) we
306 consider the following definition of a TagKey:
307 - let Group, Element be the string representation of the
308 group and element dicom tag members,
309 - let ItemNumber be the string representation of the integer
310 index of the considered item number of a sequence,
311 Let the key of a tag embeded in a sequence, noted SeqTag, be
313 /ItemNumber#Group|Element
314 where "/", "#" and "|" are characters acting as separators.
315 Then the general form of a gdcmTagKey is given by:
316 Group|Element<SeqTag>
317 where <SeqTag> means NO or many instances of SeqTag.
318 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
321 but the gdcmTagKey of a tag "embeded" is the first item of
322 a sequence, itself nested in the third item of a sequence is the
324 0004|1220/2#0008|0082/0#0008|0090
325 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
326 order to hold the new sequence compatible key. Previously, the
327 GetKey() method would look in the underlying gdcmDictEntry.
328 - src/gdcmDocEntry.cxx:
329 -- constructor now copies the underlying DictEntry key, in the local
331 -- ::Print: displays the member Key, instead of the (group, element).
332 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
333 - src/gdcmDocEntrySet.h:xi
334 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
335 -- now has a new BaseTagKey member.
337 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
338 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
340 This poses the problem with the semantics of the following lines
341 LoadEntryVoidArea(0x0028,0x1201); // R LUT
342 LoadEntryVoidArea(0x0028,0x1202); // G LUT
343 LoadEntryVoidArea(0x0028,0x1203); // B LUT
344 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
345 to the long FIXME note for what the problem is. Nevertheless in
346 order to get things working the dicom dictionary was altered !
347 Please fix things urgently...
348 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
349 information), see above note on moving the member VoidArea. Nevertheless
350 the following entries previously correctly set as US are now inproperly
352 0028 1201 OW IMG Red Palette Color Lookup Table Data
353 0028 1202 OW IMG Green Palette Color Lookup Table Data
354 0028 1203 OW IMG Blue Palette Color Lookup Table Data
355 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
356 of gdcmDocEntry moved to gdcmSeqEntry.
357 * src/gdcmSeqEntry.cxx: STYLE.
359 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
360 * Test/TestAllEntryVerify.cxx minor fix and added comments.
362 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
363 * gdcmPython/testSuite.py: all the test suite in python is now moved
364 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
365 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
366 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
368 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
369 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
370 to avoid inclusion recursion until STL is reached.
371 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
372 mecanism. errno.h is not included in gdcm anymore.
373 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
374 (gdcmFormatError now inherits from gdcmFormatUnexpected).
376 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
377 gdcmData/TestAllEntryVerifyReference.txt
378 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
379 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
380 exception_on_error parameter.
381 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
382 - vtk/vtkGdcmReader.cxx changed accordingly,
383 - Example/*.cxx and Test/*.cxx changed accordingly.
385 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
386 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
387 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
388 enable_sequences removed from gdcmHeader constructor and dependencies.
389 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
390 * gdcmPython/demo/PrintHeader.py: dummy fix.
391 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
392 skip_shadow removed from gdcmHeader constructor and dependencies.
393 * Example/*.cxx and Test/*.cxx changed accordingly.
395 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
396 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
397 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
399 2004-07-21 Jean-Pierre Roux
400 * FIX Now, Parsing and Printing a DICOMDIR do work!
401 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
403 2004-07-20 Jean-Pierre Roux
404 * FIX Some brain damaged headers have Zero-Lenght fields
405 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
407 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
408 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
409 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
410 variable (instance of gdcmDebug) by a definition macro, and the instance
411 is now in static in the gdcmDebug class
412 * src/gdcmSQItem.h : (FIXME) remove an undefined method
413 * Test/PrintAllDocument.cxx : bug fix in the result of the test
415 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
416 * WARNING: ctest now depends more tightly on gdcmData. You should
417 check out gdcmData properly for things to run smoothly...
418 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
419 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
420 we need the pixels not be loaded in order to use the ValEntry
421 that displays position and size).
422 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
423 This is a C++ based equivalent of gdcmPython/testSuite.py that should
424 be deprecated. If you have any doubts about the advantages of a
425 modern scripting language (read Python) versus grass root C++ (i.e.
426 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
427 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
428 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
429 Anyhow, consider documenting the gdcmData images in
430 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
432 * Test/CMakeLists.txt:
433 - now uses TestAllEntryVerify.cxx
434 - specific comments on oldACR00001.ima (now renamed in gdcmData
435 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
436 gdcmData/TestAllEntryVerifyReference.txt
439 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
440 * src/*.[h|cxx] : typedef clean up
441 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
442 - TagKey renamed to gdcmTagKey (for external usage)
443 - VRKey renamed to gdcmVRKey (for external usage)
444 - removal of typedef duplication.
445 - Removed all unecessary inline keyword from class inline definitions.
446 - Some method|function(void) declarations replaced with method|function().
447 * src/jpeg/libijg12/jdhuff12.c:
448 - printf polluting ctest removed.
449 - TAB removal for comminting
451 - TestAllReadCompareDicom.cxx: added a test that compares all the
452 images in gdcmDataImages.h with corresponding images in
453 gdcmData/BaselineDicom/. When baseline images are not present
454 this test creates them.
455 Note: we need to validate each reference image, but before that
456 I'd like to rename them with a more explicit name...
457 - CMakeLists.txt: changed accordingly.
458 * Example/*.cxx: examples now only include gdcm.h (as opposed to
459 including each header needed).
461 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
462 * Test/*.cxx and Example/*.cxx: moved some examples away from the
463 test suite to the Example directory. Are concerned:
468 - TestWriteSimple.cxx
469 * Test/CMakeLists.txt: added some comments on reasons for black listing
470 image gdcmData/oldACR00001.ima
472 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
473 * Test/CmakeList.txt: removed the following from black list (to be coherent
474 with removal from gdcmData):
475 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
476 - gdcm-MR-PHILIPS-16.dcm
478 Added the following because after last cvs update, they cause
479 ctest -R TestReadWriteReadCompare
481 - gdcm-MR-SIEMENS-16-1.acr
483 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
484 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
485 new comments in this file) we temporarily (sigh) move to a weaker
487 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
488 we don't need to black list the following images anymore:
489 - 8BitsUncompressedColor.dcm
491 - US-PAL-8-10x-echo.dcm
492 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
493 fixes and the beautified code ;-)
494 This fixes the bug introduced in version 1.42 (when beautifying)
495 that made the parsing of 8BitsRunLengthColor.dcm unproper.
496 Note: ctest was blind to this bug (this means we need to still
497 improve the test suite). The bug could be detected by using
498 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
500 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
501 and by displaying the (garbage) produced file temp.XDCM...
503 2004-06-29 Jean-Pierre Roux
504 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
505 - replace by uggly but working old code :-(
506 A lot of things should be OK again.
507 It's really urgent to have a test suite that *tests*,
508 to prevent Frog's beautifying sessions to break all the stuff
509 (twice, withing a fortnigh ...)
511 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
512 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
513 redundancy) to added Test/TestReadWriteReadCompare.cxx
514 * Test/CmakeList.txt: because the compare test of
515 Test/TestReadWriteReadCompare.cxx fails, the following images are
516 black listed: - 8BitsUncompressedColor.dcm
518 - US-PAL-8-10x-echo.dcm
519 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
520 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
521 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
522 and ad-hoc kludge. This kludge is now removed, and on encountering
523 such an image (OB field brain damaged) we set errno. Then in
524 ::FindDocLength() we "fix" the length as being ALL what remains
525 in the file (until EOF). We then proceed, hoping for the best...
526 This fixes a SegFault in ShowDicom when trying to write such an
528 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
529 (because TestWriteRead breaks on it, after a non conformal commit?).
530 ctest now runs properly, except for MakeDicomDir (which was allways
531 broken) and the Python related stuff (still not fixed).
533 2004-06-24 Jean-Pierre Roux
534 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
535 FIX : Test/TestReadWrite now iterates on all the file names
536 (instead of infinite loop)
537 ENH : Test/TestWriteRead now iterates on all the file names
539 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
540 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
542 2004-06-24 Jean-Pierre Roux
543 FIX : - now Write drops LUT Descriptors and LUTs (if any)
544 when SamplesPerPixel =3
545 - now Write is no longer confused by
546 'BitsAllocated = 12" and 'BitsStored=12"
547 - "UN" value representation Elements are now written correctly
548 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
549 ENH : - now gdcmHeader has its own Write methods
550 (in order to split the job that has not to be done
553 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
554 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
555 loop on the same image until memory went out.
556 Note: this means we still have gobs of memory loss in PrintDocument
557 * src/gdcmDocument.cxx: fixes problem on parsing on file
558 gdcmData/16BitsJpegLosslessGrayScale.dcm.
560 2004-06-24 Jean-Pierre Roux
561 FIX : Write - All the Sequences and Sequence Item are now written
562 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
563 is added a the end, when necessary.
564 - A lot of brain-damaged images, that were read correctly are
565 now written correctly
566 - length compatible BinEntry are now loaded correctly
567 (even for odd groups)
568 Note : only Explicit Value Representation was checked.
569 (question : is implicit VR really necessary for gdcm ?)
571 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
572 * DEVELOPPER: added a proposition of coding style.
573 * src/gdcmDocEntry.h: removed every inline declaration (for test of
576 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
577 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
578 Use the gdcmDocEntry::Print() and Write() instead.
579 * src/gdcmDocument.cxx: bug fix.
581 2004-06-22 Jean-Pierre Roux
582 FIX : gdcmDocument.cxx
583 - Now we do recognize the JpegLossLess format (there was a misstyping in
584 code 'beautyfication' :-(
585 - Now we automaticaticaly load the Luts, if any
587 2004-06-22 Jean-Pierre Roux
588 In order : to write Sequences, whatever their imbrication level,
589 : to allow user to create his own Sequences
590 a lot of modif where necessary (adding, moving, or virtualising methods)
592 WARNING : save your own sources *before* cvs up !
595 ADD virtual void Write(FILE *fp, FileType filetype);
598 ADD virtual void Write(FILE *fp, FileType filetype);
599 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
602 ADD virtual void Write (FILE *fp, FileType filetype)=0;
603 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
604 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
605 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
606 ADD std::string GetEntryByName(TagName name);
607 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
609 std::string vr = "unkn",
610 std::string fourth = "unkn",
611 std::string name = "unkn");
612 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
613 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
614 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
615 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
616 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
617 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
618 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
619 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
622 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
623 ADD virtual std::string GetEntryByName (TagName tagName);
624 ADD virtual std::string GetEntryVRByName (TagName tagName);
625 REM virtual bool Write(FILE *, FileType);
626 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
627 FILE *_fp, FileType type);
628 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
629 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
630 REM virtual bool WriteEntries(FILE *_fp,FileType type);
631 REM virtual std::string GetEntryByName (std::string tagName);
632 REM virtual std::string GetEntryVRByName (std::string tagName);
633 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
634 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
635 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
637 std::string vr = "unkn",
638 std::string fourth = "unkn",
639 std::string name = "unkn");
640 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
641 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
642 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
643 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
646 ADD virtual void Write(FILE *fp, FileType filetype);
649 ADD virtual void Write(FILE *fp,FileType filetype);
652 ADD virtual void Write(FILE *fp, FileType filetype);
653 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
654 REM std::string GetEntryByNumber(guint16 group, guint16 element);
655 REM std::string GetEntryByName(TagName name);
658 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
660 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
661 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
662 The default constructor invoked by the line
663 gdcmHeader *f1 = new gdcmHeader( header );
664 was gdcmHeader::gdcmHeader(bool) instead of the expected
665 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
666 Hence the parsing wasn't executed... See also below.
667 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
668 as explicit constructor didn't do the trick to fix the above problem.
669 Could anyone explain why ?
670 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
671 properly calls gdcmValEntry::Print() (that was weed out from
672 code related to gdcmBinEntry).
674 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
675 * In order to fix memory leaks:
676 - Test/TestWriteSimple.cxx: added cleaning of free store through
678 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
679 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
680 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
681 (through the call to ::AddDicomDirMeta()) or the destructor
682 would crash when deleting uninitialized ::metaElems].
683 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
684 - src/gdcmDocument.cxx:
685 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
687 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
688 was causing memory leaks.
689 - src/gdcmSQItem.cxx:
690 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
691 cleanly handled with polymophism: sorry but my milage is low).
692 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
693 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
694 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
695 This avoids SegFaulting.
696 - src/gdcmSQItem.h: coding style.
698 - Test/TestWriteSimple still severely sucks. The output image content
699 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
700 damaged when displayed with vtkgdcmViewer.
701 - on memory leaks: TestWriteSimple leaks really less (see entry
702 of 2004-06-18 in Changelog file for the call to valgrind).
703 - on segfaults: ctest now passes all the tests but one (no more
705 * Erroneous leading white fix:
706 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
707 white[s] (as opposed to from >> xxx, that removes it [them].
708 - src/gdcmTS.cxx: ditto.
709 - gdcmPython/testSuite.py: dirty related kludge removed.
710 * src/*: remaining references to gdcmParser removed.
711 * src/*[cxx|h]: added copy[way]left header.
714 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
715 * In order to fix writing of dicom files:
716 - Test/TestWriteSimple.cxx: a simpler example of writing.
717 - Test/CMakeLists.txt changed accordingly.
718 - src/gdcmDocument.cxx:
719 -- The destructor now recursilvely removes potential sequences.
720 -- Bug fix in ::IsJPEG2000()
721 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
722 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
724 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
725 to only declared) and build on top of
726 ::GetDocEntryByNumber(guint16, guint16).
727 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
728 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
729 for usage in destructor and treatement of promotion in
730 ::ReplaceOrCreateByNumber().
731 - src/gdcmSQItem.cxx: destructor should better handle his job.
732 Test/TestWriteSimple now runs (or at least it DOES something).
733 * We can now start hutting memory links. A good starting point is:
734 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
735 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
736 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
738 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
739 * Valgrind note: after Mathieu Malaterre teached me how to read
740 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
742 Using gcc, you can force the STL to use malloc and to free memory as
743 soon as possible by globally disabling memory caching.
744 With 3.2.2 and later, you should export the environment variable
745 GLIBCPP_FORCE_NEW before running your program.
746 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
747 simply vanish (it is still not clear to me, whether this means that
748 STL std::string leaks or if valgrind believes it leaks...).
749 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
750 running bin/gdcmTests makeDicomDir):
751 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
752 - Test/makeDicomDir.cxx now properly traps empty lists and returns
754 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
755 SegFaulting (I drowned in DicomDir related code when trying to
756 understand why the list is empty...).
757 * src/gdcmDocument.h: first BSD license header try.
758 * Doc/License.txt added.
760 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
761 * src/gdcmDocument.[h|cxx]:
762 - Clean up of the Transfer related predicates. They are now all based
763 on new method isGivenTransferSyntax, that (should) handle properly
765 - general clean up, simplification, and coding style.
766 - Specific clean up of Parse7FE0() (umproperly named actually).
767 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
769 2004-06-14 Jean-Pierre Roux
771 - fix the display of Sequence Delimitor (SQDepthLevel pb)
772 - fix the display of SQItem ordinal number
773 - add the GetSQItemByOrdinalNumber method
774 - remove some useless never written private methods
776 2004-06-14 Jean-Pierre Roux
778 - adding a constructor taking a gdcmDocEntry as an input param
779 - ReplaceOrCreateByNumber now returns :
780 a gdcmBinEntry * if a Binary (void *) value is passed as a param
781 a gdcmValEntry * if a string value is passed as a param
783 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
784 according to the param type (no longer sets a gdcmDocEntry)
785 - GetValEntryByNumber, GetBinEntryByNumber added
786 - NewValEntryByNumber and NewBinEntryByNumber added
788 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
790 - GetSQItemNumber and SetSQItemNumber added, to provide
791 a (relative) Item identier inside a given Sequence
792 \warning : some pb remaining around this number
794 - AddEntry now takes the Item Number as a param
796 - adding a constructor taking a gdcmDocEntry as an input param
798 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
799 * Memory leak hunt with the following command:
800 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
801 --show-reachable=yes gdcmTests PrintDocument
802 It looks like many (all?) leaks are due to the STL (or a bad usage
803 of the STL. The lines producing the leaks now have a comment with
804 a "MEMORY LEAK" tag: you can retrieve them with
805 grep "MEMORY LEAK" src/*
806 Here are two typical examples which I can't help fixing:
811 char * test = "babo";
812 name = test; //// <--- valgrind detects 960 bytes lost in
813 //// call to std::string::operator=(char const*)
814 name.clear(); //// Doesn't help !
822 std::cout << "Type a bunch of characters followed by RETURN: ";
823 getline(std::cin, line); //// <--- valgrind dectects a loss
824 //// of 1320 bytes in call to
825 /// std::basic_istream<>& std::getline<>
831 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
832 * src/gdcmHeader.[cxx|h]:
833 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
834 and related, moved away to gdcmDocument.
835 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
836 the corresponding protected accessors of inherited class
837 gdcmDocument, removed ! As a consequence gdcmFile had to be
838 declared friend of class gdcmDocument (see below).
839 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
840 - Clean up of undefined or unused methods.
841 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
842 account the changes to gdcmHeader.h).
843 * src/gdcmDocument.h:
844 - gdcmFile is now a friend class (in order to take into account the
845 changes to gdcmHeader.h).
846 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
847 (see changes to gdcmHeader.h).
848 - Accessors (reading on the form GetEntry*) are now public.
849 - Clean up of undefined or unused methods.
850 * src/gdcmDocument.cxx:
851 - adaptation to changes to gdcmDocument.h
852 - ::OpenFile now writes a verbose message when file cannot be opened.
853 - some std::string properly set to VRKey
854 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
855 references to gdcmDocument.
856 * Test/TestFindTags.cxx: changed accordingly to above changes.
857 * gdcmPython/testSuite.py: adapted to renaming of acr files in
858 cvs repository gdcmData.
860 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
861 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
862 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
863 conflicts with gdcmValEntry::voidArea.
864 * src/gdcmValEntry.cxx: unmatching comment wiped out.
865 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
866 Value representation between StringRepresentable and BinaryRepresentable.
867 * src/gdcmDocument.cxx:
868 - method ParseDES: proper indentation restored and usage of
869 gdcmVR::IsVROfGdcmStringRepresentable wired in.
870 - method LoadDocEntry: the fingerprint left in the SetValue() of
871 unloaded entries (length > MaxSizeLoadEntry) had curiously been
872 removed. Reverting to previous code segment with the proper
873 dynamic_cast< gdcmValEntry* >.
874 Note: this was (partially) breaking the python test suite
875 (gdcmPython/testSuite.py) that made usage of the above
876 fingerprint to check presence of "Pixel Data".
877 * src/gdcmDocEntry.h: coding style.
878 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
879 now taken into account.
880 * gdcmPython/gdcm.i: adaptation to the new internal representation
881 of gdcm (exit gdcmParser, hello gdcmDocument).
882 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
884 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
885 anymore, but instead prints the loaded Python dictionary.
886 * .... alas, the python testSuite is still broken.
888 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
889 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
891 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
892 * src/gdcmUtil.h : export methods
894 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
895 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
897 * Initial addition of automatic python testing
898 * Initial addition of automatic image comparison
900 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
901 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
902 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
904 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
905 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
906 * Test/ShowDicom.cxx : bug fix for msvc compilation
907 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
909 2004-05-04 Jean-Pierre Roux
910 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
911 new concepts (and new classes) :
912 a 'gdcmDocument' is composed of a set of Doc Entries, that are
913 - elementary gdcmDocEntries (former gdcmHeaderEntries)
914 - Sequence Doc Entries (gdcmSeqEntries)
915 a Sequence is composed of Items.
916 Each item is a set of Doc Entries (this is recursive)
917 The non uniqueness of the 'Dicom tag' is due to this recursivity
918 (never taken into account)
919 Our unability to add a new 'entry' in the header
920 at the proper location (neither in the H-Table (map or multimap),
921 nor in the Chained List is also due to this recursivity.
922 Don't try, right now, to use/modify/compile these new sources :
924 We just commit all the stuff, 'as is', in order not to loose it.
926 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
927 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
929 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
930 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
931 file prefix (SetFilePrefix)
933 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
934 * Add a new test: ShowDicom, for now this is just the c++ version of
935 checkRead.sh, later it will be able to compare the image read against a
937 * Replace the DEBUG on the stack with a global entry in cmake interface:
938 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
940 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
941 * Add an example subdir, with a real example on how to read + write a
944 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
945 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
946 * Doc/CMakeLists.txt: the main page is now properly differentiated
947 between the developper and user version.
948 * Doc/doxygen.config.in: dropped search related obsolete flags
949 * src/gdcmParser.h, gdcmHeader.h: doxygenation
951 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
952 * DEVELOPPER: added some helpfull comments for compile/test/install
955 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
956 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
957 src directory, now generated in the build dir.
958 2. Tests as mentionned smarter
960 4. Add a new method in gdcmDict that return the PubDict by name
961 this is interesting for 3rd party lib like ITK,
962 where we could set the institution name / patient name...
964 * ENH: 1. Now the test suite is working for real
965 2. All binaries are now output in the gdcm-bin directory
966 (this was not true before)
968 2004-04-28 Jean-Pierre Roux
969 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
970 SeQuence indented printing of Dicom Header.
971 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
972 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
973 Computation of SQDepthLevel is now part of gdcmHeader constructor
974 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
975 tree-like structure of a Dicom Header.
976 * FIX Test code cleaning
978 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
979 * ENH: Adding automatic testing
980 1. Need a DartConfig.cmake to submit to public
981 2. Add a test driver gdcmTest.cxx
982 3. gdcmTestMain, an helper for the main test driver gdcmTest
983 4. Files in Test don't have a main anymore, this becomes interesting
984 when we add more and more tests, thus dsw don't have to load
986 * ENH: Adding a GDCM_DATA_ROOT for testing
987 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
988 one file instead of seven + some small cleanup
990 2004-04-22 Jean-Pierre Roux
991 * ENH Minor changes to the Print() methods.
992 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
993 Header printing. Example given with :
994 > PrintHeader fileName 2 new
995 (SQ based tree-like structure still to be done for the Header ...)
997 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
998 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
999 1. I have added some unsigned where needed
1000 2. Some function parameter not used -> (void)
1001 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1002 4. g++ don't like character '\' in comment
1003 5. #define jpeg_create_decompress jCreaDecompress
1004 this really need to be fixed
1005 6. virtualize destructor of gdcmObject ... leakage
1006 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1007 this also really need to be fixed
1008 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1009 remove compression file
1010 (as we only do decompression, right ?)
1011 * ENH: Change malloc/calloc/free with c++ equivalent
1013 2004-04-21 Jean-Pierre Roux
1014 * FIX gdcmHeaderHelper::GetXSpacing
1015 when a single value is found (bug ?), xpacing is now
1016 defaulted to yspacing
1018 2004-04-19 Jean-Pierre Roux
1019 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1020 * ENH add parameters :
1021 bool exception_on_error = false,
1022 bool enable_sequences = false,
1023 bool ignore_shadow = false
1024 to the gdcmFile constructors to be full gdcmParser compliant
1025 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1026 to allow reading of PAPYRUS 3.0 files
1028 2004-04-06 Jean-Pierre Roux
1029 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1031 2004-04-02 Jean-Pierre Roux
1032 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1033 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1034 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1036 2004-03-30 Jean-Pierre Roux
1037 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1038 for ACR file, written out as DICOM files (hope so...)
1040 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1041 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1042 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1043 moved to base class gdcmParser and only the specialisation is kept
1045 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1046 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1047 already does the job.
1048 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1049 (to be consistent with gdcmParser::WriteEntries).
1051 2004-03-30 Benoit Regrain
1052 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1053 upate of the object's instance. It's passed to 2 in the unfavorable
1054 case : one in the ExecuteInformation, one in the ExecuteData
1056 2004-03-29 Jean-Pierre Roux
1057 * ENH : Check on file type to be written moved
1058 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1059 * FIX : gdcmObject::ResetBoundaries now stops properly
1060 when end-of-list is reached
1061 : gdcmVersion modified (as Benoit Regrain asked)
1063 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1064 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1065 * src/gdcmUtil.cxx: added forgotten iostream include.
1066 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1067 equivalent to ExplicitVR in existing code).
1069 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1070 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1071 now contains all the gdcmGlobal related code.
1072 * minor coding style and doxygenation changes.
1074 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1075 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1076 now contains all the Debug related code.
1077 * minor clean-up of includes in src/*.cxx
1078 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1079 CreateCleanString) removed.
1080 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1081 * Doc/DoxyMainPageUser.txt added.
1082 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1083 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1084 src/gdcmDirList.cxx)
1086 2004-03-24 Jean-Pierre Roux
1087 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1089 2004-03-23 Jean-Pierre Roux
1090 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1091 big endian made volumes
1092 * ENH Now gdcmParser constructor and destructor are protected to forbid
1093 end user to instanciate class gdcmParser
1094 (only gdcmHeader and gdcmDicomDir are meaningfull)
1096 2004-03-22 Benoit Regrain
1097 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1098 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1099 gdcmSerie to gdcmDicomDirSerie
1101 2004-03-19 Jean-Pierre Roux
1102 * ENH Now the tree-like structure describing a DICOMDIR comming from
1103 an already existing DICOMDIR file is consistent with
1104 the home-made tree-like structure build ex-nihilo
1105 or build from the files held (recursively) in a Directory
1106 functions gdcmDicomDir::CheckBoundaries()
1107 gdcmObject::SetBoundaries() added
1109 2004-03-17 Jean-Pierre Roux
1110 * REM (Eric Boix bug) : removal of meaningless
1111 gdcmDicomDirImage::NewImage function.
1112 * FIX now file names and directory name are written properly in the
1114 * FIX now gdcmDicomDir constructor may be call without any trick
1117 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1118 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1119 of gdcmDicomDirImage::NewImage as empty function.
1121 2004-02-28 Jean-Pierre Roux
1122 * ENH add gdcmDicomDir:NewPatient
1123 add gdcmDicomDirPatient:NewStudy
1124 add gdcmDicomDirStudy:NewSerie
1125 add gdcmDicomDirSerie:NewImage
1126 to allow making gdcDicomDir object.
1127 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1128 (as opposite to the gdcmHeader chained list)
1130 2004-02-11 Benoit Regrain
1131 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1132 when using from python
1134 2004-02-10 Benoit Regrain
1135 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1136 * FIX : in gdcmDicomDir when the directory is empty
1137 * ENH : add callback and methods to get the progression of dicomDir
1140 2004-02-06 Jean-Pierre Roux
1141 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1142 - GDCM_META added to gdcmDicomDirType
1143 - class gdcmMeta created
1144 * ENH : - A brief summary is now displayed at the beginning of
1145 'testDicomDir' to help disaster magnitude estimation
1146 * REM : Now useless Test/explDICOMDIR.cxx
1148 2004-02-05 Benoit Regrain
1149 * ENH : add methods in gdcmObject to get the hash table or the list of
1151 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1152 * FIX : wrapping python for TagHeaderEntryHT
1154 2004-02-04 Benoit Regrain
1155 * FIX : even length for some strings when writting the dicom dir
1156 * FIX : sort the images in the dicom dir
1157 * FIX : Bug fix for python use of dicom dir
1158 * ADD : a python demo
1160 2004-02-04 Jean-Pierre Roux
1161 * FIX : Final solution (?) for icone embedded images
1162 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1163 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1164 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1165 gdcmData/gdcm-MR-SIEMENS-16.acr1
1166 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1167 to make full checking easier
1169 2004-02-04 Benoit Regrain
1170 * FIX : WriteEntries : coding style & logic in parameters
1171 * FIX : Set the elements to create the DicomDir in a dictionary file
1173 2004-02-03 Benoit Regrain
1174 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1175 * gdcmDicomDir : add the load of directory
1176 * Bug fix and print add-on
1178 2004-02-03 Jean-Pierre Roux
1179 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1180 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1181 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1182 * FIX gdcmParser.cxx : 'group length' elements are now considered
1183 as integers, even for shadow groups, when file is Implicit VR
1185 2004-02-02 Jean-Pierre Roux
1186 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1188 of the last synonym :-(
1189 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1191 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1192 * FIX taking into account the possible 7fe0,0010 multiplicity
1193 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1194 to allow removal of references to 7fe0,0010, to deal with
1195 ACR-NEMA images, when 0028,0200 is meaningfull
1197 2004-01-31 Jean-Pierre Roux
1198 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1199 no longer writes 'Un' on disk
1200 * FIX SQ elements with actual length are now dealt with corectly
1201 * FIX gdcmFile::WriteBase make the difference, for color images, between
1202 the length (for Palette expanded images)
1203 and Raw Length (non expanded image + Palette)
1204 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1205 (that broke Write). Replaced by UL.
1206 Aware user will reload the field if he
1207 thinks it's necesssary
1209 2004-01-30 Jean-Pierre Roux
1210 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1211 when 'dirty Acr' is found, to be compliant with the new
1212 IsReadable() methods.
1214 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1215 (no DOUBLE images in kosher DICOM,
1216 but so usefull for people that miss them ;-)
1218 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1219 DICOMDIR related utilities (not checked as Windoze compliant)
1221 2004-01-28 Jean-Pierre Roux
1222 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1224 2004-01-27 Jean-Pierre Roux
1225 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1226 to allow skipping the shadow elements, to save memory space.
1227 The TRUE value for this param has to be used
1228 with a FALSE value for the 'enable_sequence' param.
1229 ('public elements' may be embedded in 'shadow Sequences')
1230 * gdcmHeader methods now deal with 'embedded icones images' in the header
1231 (even when an 'icone image sequence' is announced by the
1232 element (0x0088,0x0200), but there is NO icone at all ...
1234 * gdcmHeader sometimes Image Location value doesn't follow
1235 the supposed processor endianity (see gdcmData/cr172241.dcm).
1238 * gdcmHeader add the method
1239 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1240 to get *all* the Header Entries with the same tag.
1241 GetHeaderEntrySameName is probabely *useless*
1242 (no meaning : Name is *not* an identifier within the Dictionnary)
1244 2004-01-26 Benoit Regrain
1245 * Bug fix in the print of hexadecimal representations. Remove long fields
1246 in the print and add a third level of print to print them
1248 2004-01-23 Benoit Regrain
1249 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1250 * Bug fix on test suite after remove the strip made on not string fields
1251 * Split the IsReadable method between gdcmParser which test that the file
1252 is dicom and gdcmHeader which test that it's an image file
1254 2004-01-22 Benoit Regrain
1255 * DicomDir : clean code, add methods, set variables in protected or private
1256 * gdcmUtil : bug fix for the clean string method
1258 2004-01-19 Benoit Regrain
1259 * Add the use of shadow dictionaries
1260 * bug fix and coding style
1262 2004-01-19 Benoit Regrain
1263 * src/gdcmFile.cxx : bug fix concerning the close of file
1264 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1265 * Add the update of header entries using the shadow library
1267 2004-01-19 Benoit Regrain
1268 * removal of file gdcmHeader2.cxx
1269 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1270 inheriting from gdcmParser. This split is to prepare the integration
1271 of dicom dir parsing
1272 * bug fix under python
1274 2004-01-16 Jean-Pierre Roux
1275 * REM removal of class gdcmHeaderEntrySet
1276 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1277 * ADD add file gdcmHeader2.cxx
1278 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1280 2004-01-15 Benoit Regrain
1281 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1282 entries created while parsing the header. Thus, they will be destroyed
1283 when the gdcmDictSet will be destroyed
1284 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1287 2004-01-15 Benoit Regrain
1288 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1289 made a fatal error because of the memory release at the end of program.
1290 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1291 some memory and vtk seems to have some problems with that.
1292 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1294 2004-01-14 Benoit Regrain
1295 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1296 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1297 * src/*.[h|cxx] : make changes due to class name changes
1298 * gdcmPython/demo/*.py : bug fix due to method names
1300 2004-01-13 Benoit Regrain
1301 * src/*.[h|cxx] : coding style
1302 * vtk/*.[h|cxx] : coding style
1304 2004-01-13 Benoit Regrain
1305 * gdcmPython/testSuite.py : test the readable flag of file for tests
1306 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1307 It's lied to the stl compilation by MSVC (windows, always windows...)
1308 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1310 2004-01-12 Benoit Regrain
1311 * src/*.h : add comments
1312 * src/gdcmDictSet.h : set the method BuildDictPath in public
1313 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1314 directly setted in the source code
1315 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1318 2004-01-09 Benoit Regrain
1319 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1320 * setup.py : use a reference to gdcmVERSION
1322 2004-01-07 Benoit Regrain
1323 * Modification to compile with the distutils.
1326 2003-12-10 Benoit Regrain
1327 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1328 can use a gdcmHeaderHelper to load datas
1329 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1330 made in the source code
1332 2003-12-10 Benoit Regrain
1333 * Update Windows projects and .cvsignore files
1335 2003-11-12 Jean-Pierre Roux
1336 * ENH gdcmHeader constructor has one more parameter (default value : false)
1337 that allows the user to 'go inside' the SeQuences only
1339 gdcmElValSet:Print takes it into account
1341 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1342 * ENH: Update gdcmPython/CMakeLists
1343 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1344 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1346 2003-11-10 Jean-Pierre Roux
1347 * FIX : gdcmHeader::LoadElements is now based
1348 on the ListTag listElem member,
1349 not longer on the TagElValueHT tagHt member
1350 * ENH : PrintPubElVal shows (temporarily) both results,
1351 with the tagHt member and the listElem member.
1352 (it's easier to 'see' the problems when using Printheader)
1354 * FIX : old private member LgrElem is now splitted into
1355 ReadLength : Length actually found on disk (updated only
1356 if bug fixing is necessary), for internal
1358 UsableLength : Updated by FixFoundLength, to fix a bug
1359 or to allow Parser going on.
1360 Will allow to re-write a kosher header when a SeQuence
1361 with a length (not 0000) is found
1362 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1363 because gdcmElValSet::Add does not update ListElem
1366 2003-11-07 Jean-Pierre Roux
1367 * FIX misstyping in Transfert Syntax name table
1368 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1369 when they have an actual length (not 0000 nor FFFFF)
1370 (Nobody should care of it, but DICOMDIR explorers)
1372 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1373 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1375 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1376 * ENH: vtkGdcmReader now supports LUT !
1377 (vtkgdcmViewer for now is not able to use them though)
1379 2003-11-05 Jean-Pierre Roux
1380 * in testSuite.py : new files names for checking the package
1381 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1382 that returns the pixel area size to the *aware* (vtk) user
1383 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1385 2003-11-05 Benoit Regrain
1386 * in testSuite.py : Modify the rules for checking the paths
1387 : Explicit error messages
1388 * in __init__.py : Related modif
1390 2003-11-03 Jean-Pierre Roux
1391 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1392 to be used by aware (vtk) users that want to manage
1393 LUT (and no to turn the PALETTE image into an RGB pixels one)
1394 * GetPixelType now returns 8U for 24 Bits images
1395 (vtkGdcmReader compliant)
1397 2003-10-31 Jean-Pierre Roux
1398 * Removal of *all* gdcmData images and add them again
1399 in order to loose the 'history' of un-anonymised images
1401 2003-10-31 Jean-Pierre Roux
1402 * RMV : removal of useless jBitsInJsample.h
1403 for both 8 and 12 Bits JPEG Lossy Libraries
1405 2003-10-31 Jean-Pierre Roux
1406 * ENH : Add the functions gdcmFile::GetImageDataRaw
1407 gdcmFile::GetImageDataIntoVectorRaw
1408 that act as GetImageData and GetImageDataIntoVector
1409 except the making of an RGB Plane from Gray Plane + LUT
1410 Intended to aware (vtk) users who know how to manage
1413 GetLUTRGBA return a R,G,B,A LUT if any
1414 lgrTotaleRaw gives the 'Raw' length
1415 GetImageDataRaw returns the gray Plane
1416 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1417 (They stay Grey, just like with other Dicom viewers :-(
1419 2003-10-30 Jean-Pierre Roux
1420 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1422 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1423 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1424 being coherents dicom files.
1426 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1427 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1429 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1430 * ENH: Two steps is necessary to please VC++ compiler...
1431 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1432 * ENH: Add include dir to medcon lib
1433 * FIX: only one function is being exported for now !
1434 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1436 2003-10-29 Jean-Pierre Roux
1437 * adding gdcmHeader::GetLUTRGBA
1438 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1439 --> Mathieu, the modif u're waiting for is not yet committed
1440 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1442 2003-10-27 Jean-Pierre Roux
1443 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1444 00191113.dcm DermaColorLossLess.dcm
1445 MxTwinLossLess.dcm RadBWLossLess.dcm
1446 * ENH: For version prior to vtkImageViewer2 -r 1.19
1447 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1449 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1450 * Removal of ido stuff in CMakeLists.txt
1452 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1453 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1454 * FIX: remove a call to ->Modified ... see comments
1455 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1457 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1458 * FIX: Problem with path for libvtkgdcmPython
1459 * ENH: Try adding a search script for python site-package
1460 * RMV: Remove some file from medcon lib that are not necessary
1461 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1462 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1463 * FIX: More pragma disable fro VC++,
1464 I don't think I break something as it is also disable in VTK/ITK.
1465 But it fasten debug compilation time.
1467 2003-10-23 Jean-Pierre Roux
1468 * gdcm now deals with 16 Bits Run Length Encoded images
1469 (they are compressed as 2 planes images,
1470 one for the high Bytes, the other for low Bytes)
1472 2003-10-22 Jean-Pierre Roux
1473 * Now CheckRead takes into account :
1474 - the bugged 'Leonardo' Siemens images
1475 - the XA images, sent thru the burning VPRO station
1476 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1479 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1480 * FIX: When copying a Makefile.am to CMakeLists.txt
1481 one should remove the '\'
1483 2003-10-22 Jean-Pierre Roux
1484 * in gdcmData adding a bugged 'Leonardo' Siemens image
1485 (wrong lengths in header)
1486 OK with gdcm, KO with the other viewers :-)
1487 * add a GE dlx XA image, thru the VEPRO burning station
1490 2003-10-21 Jean-Pierre Roux
1491 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1492 for a brutal checking of vtkgdcmViewer compliance
1494 2003-10-21 Jean-Pierre Roux
1495 * add the files for 'xmedcon' Jpeg Lossless library
1496 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1498 2003-10-21 Jean-Pierre Roux
1499 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1501 2003-10-21 Jean-Pierre Roux
1502 * garbage Siemens 'Leonardo' images dealt with
1503 (the patch is easy to remove)
1504 * cosmetic changes to avoid warnings
1506 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1507 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1508 no need to press 'r' now.
1510 2003-10-20 Jean-Pierre Roux
1511 * upgrade of checkRead.sh checkWrite.sh according
1512 to new Jpeg Lossless decompressor
1513 * add US.3405.1.dcm, a genuine RGB medical file ...
1514 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1515 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1517 2003-10-15 Jean-Pierre Roux
1518 * general anonymisation in gdcmData
1519 * adding the 'color files' from
1520 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1521 * adding some well knowed bugged-header images
1522 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1523 waiting for their inclusion in Python testsuite
1525 2003-10-15 Jean-Pierre Roux
1526 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1527 no longer seg faults when file is not found
1529 2003-10-14 Jean-Pierre Roux
1530 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1533 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1534 * TODO: *.in file to genereate a UseGDCM later
1536 2003-10-14 Jean-Pierre Roux
1537 * Some supposed-to-be Dicom Images have no preamble.
1538 OpenFile takes it into account
1539 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1540 * Missing elements added in dicomV3.dic
1541 (just to be affraid : have a look at
1542 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1543 and do it again next year ;->
1545 2003-10-13 Jean-Pierre Roux
1546 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1547 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1548 But there are NOT. It's fixed !
1550 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1551 * FIX: "jpeglib.h" was not found on VC++
1552 * FIX: vtkgdcm was not being installed
1554 2003-10-10 Jean-Pierre Roux
1555 * ENH : OpenFile closes the file if it *really* doesn't look like
1556 an ACR-NEMA / DICOM one.
1557 * FIX : testWrite no longer writes an empty file if the source file
1558 is not gdcm Readable
1559 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1562 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1563 * FIX: CMake generate now documentation
1564 * ENH: out of source doc build !
1565 * ENH: Generate both user and dev documentation
1566 * ENH: Should work on windows too
1567 * ENH: Only one doxygen config.in file is needed
1568 * FIX: make install should be ok now on ùnix plateform
1569 * FIX: PATH to dictionary was wrong (missing /)
1570 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1572 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1573 * vtkGdcmReader is now able to read rgb dicom file.
1574 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1575 * added a gdcmViewer to vtk test, use mouse to control
1576 window level & window width
1578 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1579 * CMake-ification of gdcm, we have now two build system
1580 * FIX: on cygwin Wsock32 doesn't exist
1581 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1583 2003-10-06 Emanuel Ollart
1584 * FIX : compilation process wad broken.
1585 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1587 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1588 * change gdcmViewer -> vtkgdcmViewer
1589 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1591 2003-10-06 Jean-Pierre Roux
1592 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1593 ( e.g : well known GE images with a wrong elem length,
1594 : Philips MRI Images with a wrong Huffman table)
1595 * still to be done : allow the reading of bugged LEONARDO Siemens images
1597 2003-10-03 Jean-Pierre Roux
1598 * Odd length strings are padded with '\0' (not with spaces,
1599 to remain compliant with already defined strings,
1600 like Transfert Syntax UID and others)
1602 2003-10-03 Jean-Pierre Roux
1603 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1604 to allow displaying RGB images (not only by affim ;-)
1606 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1607 * vtkGdcmReader is now able to read rgb dicom file.
1608 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1610 2003-10-03 Jean-Pierre Roux
1611 * A few nasty patches to allow the reading of a lot of nasty images
1612 ( e.g : well known GE images with a wrong elem length,
1613 : Philips MRI Images with a wrong Huffman table)
1614 * still to be done : allow the reading of bugged LEONARDO Siemens images
1616 2003-10-03 Jean-Pierre Roux
1617 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1619 2003-10-03 Jean-Pierre Roux
1620 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1621 to allow displaying RGB images (not only by affim ;-)
1623 2003-10-03 Jean-Pierre Roux
1624 * gdcmFile::GetImageDataIntoVector now
1625 - deals with MultiFrames MultiFragments Run Length Encoded files
1626 - deals with YcBcR (YBR_FULL) files
1627 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1628 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1630 (no sample found :-(
1632 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1633 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1634 Two reasons: - clear things
1635 - third parties acces gdcm through header files, so won't
1636 suffer anymore VC++ complains
1638 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1639 * add argv[1] in testvtkGdcmReader.cxx
1642 2003-09-24 Jean-Pierre Roux
1643 * The lines are now eigthy characters long.for
1644 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1646 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1647 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1648 char* to std::string. Thus, the use of strdup becomes useless. (see
1649 previous commis of Malaterre)
1650 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1651 before the last Malaterre's commit.
1653 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1654 * This commit should fix the Debug building under VC++, the problem
1655 was mainly a mixture of debug and release lib being loaded at startup.
1656 * I also remove a depency to a specific C function: strdup. Because I had
1657 to force the link to msvcrtd (whereas strdup is in libc).
1659 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1660 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1661 located in the gdcmCommon.h file. All use of reference of tha has been
1662 changed to now use the variable GDCM_UNFOUND.
1664 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1666 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1667 Dicom dictionary. The test suite can now be run again. Note:
1668 I'm note very happy with the " (RET)" changes. I believe this
1669 RETAINED comment should be dropped when parsing the dictionary.
1670 - PACKAGER corrected
1672 - AUTHORS updated and now in alphabetical order
1673 * Makefile.am now exports gdcm.dsw for Windoze users.
1675 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1676 * cygwin complains about missing std:: in subdir Test/
1678 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1679 * remove some methods that are now in gdcmHeaderHelper
1681 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1682 * vtkGdcmReader set spacing and origin correctly
1684 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1685 * Fix a few delete/delete[] mismatch
1687 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1688 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1689 interpretation to data given by gdcmHeader. For instance there are
1690 heuristics to get informations (look at different places).
1691 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1692 sorting DICOM images based on different strategies.
1693 * modified Makefiles accordingly.
1695 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1696 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1697 when building in debug mode
1698 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1699 src/win32/gdcmdll.dsp
1700 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1702 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1703 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1706 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1707 * src/win32/libgdcmjpeg12.dsp was not dos format
1708 * src/win32/libgdcmjpeg12.dsp :
1709 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1710 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1712 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1713 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1715 * src/gdcmFile.cxx : bug fix in affectation type
1716 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1717 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1718 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1719 symbols... future problem ?
1721 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1722 * src/win32/libgdcmijpeg12.dsp was missing
1723 * modified gdcm.dsw accordingly
1725 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1726 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1728 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1729 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1730 commit of JPR (before his hollidays to facilitate our work).
1731 * setup.py : bug fix in code. Modifications made while the last commit
1732 of JPR. The code hasn't been tested before the commit... it's so
1733 useless to make that (for best programmer that is JPR) !!!
1735 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1736 * tagged the current version as Version0_3 (i.e. version 0.3)
1738 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1739 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1740 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1741 * *.dsp : modifications to use new libgdcmijpeg8 library
1742 * setup.py : bug fix on VTKPATH variable
1743 * PACKAGER : adding all concerning windows
1745 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1746 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1748 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1749 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1750 test suite reported error.
1751 * PACKAGER file added (describes what a packager must do when
1752 packaging a new release).
1753 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1754 * configure.in: upgraded version number to 0.3.0
1755 * fixing build of rpm (through rpm -ta):
1756 - Doc/Makefile.am exports proper doxygen files
1757 - src/jpeg/libijg8/Makefile.am exports the include files.
1759 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1760 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1761 * src/gdcmHeader.h : formatting code
1763 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1764 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1765 We were obtaining error message from vtk. Now, creation of file list
1766 is made in an internal list to prevent this problem.
1767 Bug fix when output is empty.
1768 Bug fix in update of progress value. Previous commit for this was a bad
1770 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1772 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1773 * src/gdcmHeader.h : added method to get the file name
1774 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1775 files. Added method to remove all files on the input
1776 Added FIXME comment concerning the bad parsing of header made by
1777 ExecuteInformation method (in ExecuteData method)
1779 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1780 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1781 when using make instal.
1782 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1783 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1785 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1786 * setup.py : adding include dir of jpeg lib to compile all sources
1787 * */Win32/*.dsp : JPR fix for windows compilation
1789 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1790 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1792 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1793 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1795 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1796 * setup.py is again effective on un*x (takes into account the
1797 addon of the jpeg library)
1798 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1799 * Doc/Doxy* updated (includes above enhancements)
1800 * INSTALL now points to web documentation
1802 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1803 * src/gdcmHeader.h doesn't make unnecessary reference to
1805 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1807 * src/gdcm*.[cxx|h] :
1808 - to allow compilation with gcc 3.x
1809 -- clean up of STL usage (added explicit usage of std::)
1810 -- small fixes on exceptions.
1811 Note: linking not tested !
1812 - clean of doxygen comments to avoid warnings at documentation
1814 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1815 dependent convertion).
1817 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1818 * Clean up of previous JPR garbage commit (not even commented in the
1820 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1821 - moved all jpeg related files from src to src/jpeg/libijg8, with
1822 addition/modification of Makefile.am and configure.in.
1823 - the testSuite is still brain damage (not guilty).
1825 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1826 * WrapVTK.py : modifications to get correctly vtk source files to
1828 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1829 (FileName -> Filename)
1831 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1832 * vtk/vtkGdcmReader.[cxx/h]:
1833 - UpdateProgress method should now be effective
1834 - removed the limitation on having only images loaded (as opposed
1836 - when building a stack of images/volume, a lesser number of
1837 gdcmHeader and gdcmFile instances should be used (hopefully
1838 accelerating things).
1839 - when building a stack of images/volumes, files which are not
1840 loadable (wrong path-filename, wrong permissions on existing file,
1841 or file not parsable by gdcm) are replaced with a black image
1842 in the stack (for the caller to notice the problem).
1844 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1845 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1847 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1848 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1849 between standard library (std) and vtk library (problems are found
1850 under Windows... thanks Windows !)
1852 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1853 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1855 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1857 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1858 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1860 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1861 * When compiling with distutils (see setup.py) the C++ compiler is
1862 called with different flags than the default ones (with automake).
1863 In order to fix all those warning, I compiled gdcm with the command
1864 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1865 and went for warning fixes:
1866 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1867 up from unused variables.
1868 - vtk/vtkGdcmReader.cxx: potential bug fix.
1869 * src/gdcmHeader.h: Doxygen warning cleanup
1871 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1872 * gdcmPython/gdcm.i:
1873 - typemaps correction to take into account the systematic replacement
1874 of "using namespace std" with std:: prefix e.g. std::list,
1875 std::string... (cf changes of 2003-05-21).
1876 - gdcmGlob global variable of type gdcmGlobal (defined in
1877 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1878 exported to Python a as cvar.
1879 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1880 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1881 gdcmDictSet.GetPubDictTagNames() and
1882 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1883 C++ static methods).
1884 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1885 with the above changes.
1887 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1888 * setup.py, manifest.in : bug fix under linux
1890 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1891 * Modification of setup.py to compile vtk part too. Then, we have 2
1892 wrappers which must work with same distutils. For that, we have a
1893 generic distutils in distusiltsWrapping.py ; with :
1894 - build_extWrap class to wrap generically all extensions,
1895 - ExtensionWrap base class for all wrapping extension that contains
1897 - Wrapper interface which wrap sources
1898 + In WrapSwig.py we have extension and wrapper for Swig
1899 + In WrapVTK.py we have extension and wrapper for VTK
1900 * MANIFEST.in : modifications to consider vtk directory and new python
1901 files for compilation
1903 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1904 * Added python wrappers of vtkGdcmReader vtk class (see the
1905 source in vtk/vtkGdcmReader.cxx) :
1906 - vtk/Makefile.am now builds a library
1907 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1908 python library (as opposed to _gdcm.so wich are the python
1909 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1910 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1912 - configure.in has an additional flag --enable-vtk that needs
1913 to be set to enable compilation of vtk related code, that is:
1914 + vtk/vtkGdcmReader.so and
1915 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1916 + gdcmPython/vtkgdcmPython.so (see above)
1917 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1918 be read when compressed or when HighBit + 1 != BitsStored),
1919 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1920 the usage of the python wrapper of vtkGdcmReader vtk class.
1921 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1922 * src/*.[h] all occurences of stl classes are now prefixed with
1923 std::, and all occurences of "using namespace std;" where removed.
1924 This is to avoid pollution of global namespace in included files.
1925 Apparently vtk does not avoid this pitfall: when using both
1926 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1927 collision of various stl members (principally cout...).
1928 * gdcmPython/testSuite.py now cleanly removes temprory generated
1930 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1931 comply with above changes)
1933 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1934 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1935 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1936 vtk data structure (an image Flip was required).
1937 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1938 * cosmetic changes in documentation.
1940 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1941 * src/gdcmHeader.cxx: the constructor no longer exits when an
1942 unexisting file is given as argument.
1943 * The subdirectory Data (containing all the images used for the
1944 test suite) is not part of this repository anymore. A new module
1945 containing those images is now available at
1946 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1947 with the name gdcmData.
1948 All the python scripts (including the package initialisation file
1949 gdcmPython/__init__.py) were adapated to take this change into
1950 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1952 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1953 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1954 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1955 demo of the usage of this class.
1956 Compilation of this vtk part is only done when using the --enable-vtk
1957 at configure (or autogen.sh) stage.
1959 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1960 * More memory link related corrections and documentation fixes.
1962 - maximum info is obtained with a command of the form:
1963 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1964 --show-reachable=yes PrintHeader
1965 - the remaining reachable blocks seem to come from the STL
1966 allocation scheme through the usage of map and list. It looks
1967 like this memory cannot be freed but it is not a memory leak
1968 (in fact further invocation to the STL would recollect the
1969 unused memory allthough it cannot explicitely be freed).
1970 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1971 of displaying an image parsed with gdcm and displayed with VTK.
1972 Note: some images don't seem to work e.g.
1973 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1974 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1975 Allthough this weakens the semantics, it is a ditch attempt to
1976 make gdcm more thread friendly.
1978 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1979 * Memory link hunt (by using valgrind through the command
1980 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1981 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1982 gdcmHeader::_dicom_vr.
1983 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1984 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1986 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1988 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1989 * src/Makefile.am now exports all the necessary include files at
1993 * UpdateGroupLength replaced by new one
1996 * UpdateGroupLength re-written using H-Table
1997 (named UpdateGroupLengthNew untill checks are over)
1999 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2000 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2001 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2003 - gdcmHeader::GetPubElValSet removed.
2004 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2005 UpdateGroupLength, WriteElements, Write.
2006 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2007 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2008 carried the same semantics.
2009 - src/gdcmHeaderIdo.cxx changed accordingly.
2010 - gdcmFile::WriteBase now regroups all the codes from previous
2011 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2012 - enum FileType moved to gdcmCommon.h
2013 * src/gdcmHeader.cxx AddDefault trashed
2014 * gdcmGetXSize added
2015 * getimageDataSize now calls gdcmGetXSize
2016 * Test/*.cxx changed to agree with above changes
2018 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2019 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2020 (to avoid double call by end user).
2021 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2022 by end user, since gdcmHeader::gdcmHeader now handles it.
2024 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2025 * gdcm/Doc many doxygen changes:
2026 - Doxyfile now has two different versions, DoxyfileUsers that generates
2027 the html.users end users oriented documentation and
2028 DoxyfileDeveloppers that generates the html.developper developper
2029 oriented documentation.
2030 - README changed accordingly
2031 - requirement.txt removed (old design info moved to TODO).
2032 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2033 DoxyMainPage.txt, DoxyPython.txt provide more information.
2034 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2035 be updated by simply regenerating the docs with doxygen and copying
2036 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2037 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2038 all the tests in the form "if (<map>.count() >1)" were removed.
2039 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2040 ill-formed documentation sections.
2041 * src/gdcmHeader.cxx: ditto
2043 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2044 * setup.py fixed for un*x (needed macro for stdint.h)
2045 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2046 un*ces with sh-utils test utility.
2047 * gdcmPython/demo/test.py renamed to PrintHeader.py
2048 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2049 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2050 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2051 * src/gdcm*.cxx JPR's bad inclusion fixed.
2053 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2054 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2055 * gdcmPython/demo/test.py changed accordingly.
2057 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2058 * gdcmPython/Makefile.am fixed linking against libstdc++
2059 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2060 * Swig subdir (historical tests of swig version 1.3.17++) removed
2061 * Test/testChangeEntete.cxx some lines commented out in order to make
2063 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2064 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2066 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2067 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2068 hence the user doesn't need this explicit call.
2069 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2070 i.e. LoadElements() call removed.
2071 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2072 - src/Makefile.am declares the proper flag for g++.
2073 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2074 for adding user defined new tags.
2075 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2076 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2077 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2079 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2080 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2081 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2082 src/Makefile.am : the project should properly compile and install
2083 with the autotools, included the python wrappers part.
2084 * gdcm.spec.in : added a spec file for RPM packaging.
2086 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2087 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2089 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2090 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2091 to exported to the environement (see gdcmPython/testSuite.py
2093 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2094 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2095 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2096 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2097 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2099 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2100 * gdcmPython/__init__.py doesn't crash anymore when running in
2101 in InstallMode or PreInstallMode but with an environement given
2102 value of GDCM_DICT_PATH.
2103 * src/gdcmDictSet.[cxx/h] coding style.
2105 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2106 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2107 * src/gdcm.h general comments moved to TODO, and README
2108 * src/gdcm.h should now be seen as a user commodity (including it
2109 should suffice to fully use gdcm). It is nowhere including within
2110 any of the kernel files src/*.cxx and src/*.h.
2112 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2113 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2114 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2116 * src/gdcm*.cxx only include their corresponding include file
2117 (as opposed to gdcm.h)
2118 * gdcmPython/gdcm.i changed accordingly
2119 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2120 the autogen.sh generated "make snapshot" command to work.
2121 * autogen.sh removed history related references to crea package.
2123 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2124 * distutilsSwigCPlusPlus.py work around some swig portability
2127 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2128 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2129 was done in a last ditch attempt to get setup.py _really_
2130 operationnal. The python/gdcmPython layaout add the advantage
2131 of hidding away the python related distutils specific files
2132 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2133 Alas, the src directory was out of scope (i.e. it's relative
2134 position to setup.py was ../src) which made things impossible to
2135 handle (see previous version of python/setup.py). Crossing fingers...
2137 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2138 * python/setup.py now works on Un*x. (harder than I thougth)
2139 * python/distutilsSwigCPlusPlus.py can now have include files
2140 among the list of sources.
2142 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2143 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2144 * modifications in MSVC projects
2146 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2147 * As stated by the first lines of Test/ExceptionAndPython/README, it
2148 looks like we can move back to original usage of exception within
2149 src/gdcm* and hence remove the errno stuff that was introduced
2150 as a quick and dirty fixture of this problem (added to the TODO).
2151 * Doc/Doxyfile configuration file for Doxygen and corresponding
2152 README file for usage added.
2153 * Test/testWrite.cxx added. This new test comes from a split of
2154 test.cxx that is now reverted to its original purpous i.e.
2155 testing the proper parsing of a Dicom related file.
2156 testWrite.cxx concentrates on testing the IO part of gdcm.
2157 * Test/bug1.cxx (containing a bug on WIn32) added.
2158 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2159 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2160 whose purpose is to publish the content of the TagNames of the
2161 Dicom public dictionnary were not accessible without an
2162 instance of class gdcmHeader.
2163 - those methods are now static methods of gdcmDictSet and hence
2164 require no instances at all to be invocated.
2165 - within gdcmDictSet this change required to change some method
2166 to class methods (i.e. are now static) among which SetDictPath
2167 (renamed to BuildDictPath) and LoadDefaultPubDict.
2168 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2169 the above changes by calling the new method classes of gdcmDictSet.
2170 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2171 the above to be effective.
2172 * python/gdcmPython: in order to wrap properly the above changes
2173 for Python, swig version now needs to be > 1.3.17.
2174 * python/gdcmPython/Makefile fixed to adapt itself to new
2175 configure/make shema introduced by Johan Montagnat (thanks for the
2176 contribution). Alas this Makefile cannot be turned into a proper
2177 Makefile.am without some heavy changes in the configure.in
2178 (for python dectection).
2179 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2180 now avoids publishing the empty entries.
2182 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2183 * python/setup.py : bug fix concerning install under windows
2184 ExtraPath reused :-P
2185 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2187 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2188 * Dicts/dicomV3.dic : remove double spaces !!!
2189 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2190 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2193 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2194 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2195 method. Doxygenation.
2196 * src/gdcm.h clean up of JPR spurious comments.
2198 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2199 * python/distutilsSwigCPlusPlus.py now properly collects the
2200 shadow classes generated by "swig -c++" (gdcm.py in our case)
2201 when using "python setup.py install".
2202 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2203 reexports the working classes.
2204 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2205 by the classical C errno scheme. This is to prevent an obscure
2206 behavior of the python wrappers when importing wxPython.wx prior
2207 to gdcmPython (which ended up in an abort call). An illustration
2208 of this oddity can be found in the Test/ExceptionAndPython
2209 subdir (see the README file). This problem probably due to
2210 an combination of g++ and dynamic loading.
2211 * added Test/ExceptionAndPython (see above)
2213 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2214 * Changed the layout of the python part to avoid bloating main
2215 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2216 i.e. the distutils arsenal. All the python related stuff is
2217 again in a python subdir, but the package itself is now in
2219 * setup.py was cleaned up:
2220 - pythonIncludePath removed
2221 - python setup.py bdist target is now functional.
2222 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2223 collision with other packages). gdcmPython/demo/*.py changed
2226 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2227 * python subdir moved to gdcmPython (preparation of distutils packaging).
2228 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2229 distutils installer is operational.
2230 * - gdcmPython/__init__.py now properly loads the swig generated
2231 shadow classes (from gdcm.py).
2232 - gdcmPython/demo/*.py changed to import the package gdcmPython
2233 instead of gdcmPython/demo/load.py.
2234 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2236 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2237 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2238 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2239 entries within the associated public Dicom dictionary resp. the same
2240 information but sorted by the fourth field (PAT, IMG, DIR) of the
2242 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2243 are now in the "???" group.
2244 - python/gdcm.i changed accordingly,
2245 - python/demo/printGroupedPublicDict.py added, that gives an example
2246 of the above new functionalities in Python.
2248 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2249 * src/gdcm.h, gdcmHeader.cxx:
2250 - historic references to glib's g_malloc and g_free (#defined)
2251 were definitively removed.
2252 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2253 * src/gdcmElValSet.cxx:
2254 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2255 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2256 - GetElValue(string) renamed to GetElValueByName.
2257 - Added GetElementByName(string).
2258 * src/gdcmHeader.cxx: added
2259 - GetPubElValRepByNumber(guint16, guint16)
2260 - GetPubElValRepByName(string)
2261 - GetShaElValRepByNumber(guint16, guint16)
2262 - GetShaElValRepByName(string)
2263 - GetShaElValByNumber(guint16, guint16)
2264 - GetShaElValRepByName(string)
2265 - GetElValRepByNumber(guint16, guint16)
2266 - GetElValRepByName(string)
2267 - GetElValByNumber(guint16, guint16)
2268 - GetElValRepByName(string)
2269 * Doc/requirements.txt added.
2271 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2272 * Test/Makefile building now depends on the one of libgdcm.so
2273 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2274 pixel data) aware which enables finding the address (offset) of
2275 the pixel data of JPEG encoded DICOM files. This leaves only a single
2276 file in the testSuite whose pixel data address (offset) is unknown.
2277 * python/testSuite.py changed accordingly.
2279 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2280 * VC++ has some strong limitations when working with the STL, as stated
2281 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2282 "Also note that some STL containers (map, set, queue, list, deque)
2283 cannot be exported. [...]
2284 Some STL classes contain nested classes. These classes can not
2286 This is caused by a designed limitation that once a template
2287 class is instantiated, it can not be re-instantiated and
2289 Since our usage of map<> is ubiquitous in gdcm, this "designed
2290 limitation" of VC++ is a pitfall.
2291 Hence the Python wrappers of gdcm cannot be incrementally linked
2292 against the c++ dynamic library. The dirty but only workaround is
2293 to forget about incremental link of dynamic libraries and to generate
2294 the Python wrappers library with the inclusions of the underlying C++
2296 The following modifications concern this matter on Win32/VC++:
2297 - wrapping python correct with standalone wrapped dll (don't use separate
2298 dll under windows !!!!)
2299 - python21_d debug mode enabled (ask Frog how to use it :-)
2300 - NO problem with having an STL member of class for example string in C++
2301 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2302 - Python test of dcmlib in Python is ok under windows on a large set
2304 * removed glib references
2305 * typedef's inserted in gdcm.i for correct swig type management
2307 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2308 * python/demo/*.py load.py extracted from test.py. Added explore.py
2309 that only displays required tags and testAll.py that parses all
2310 the files of the testsuite without using unittest.
2311 * python/testSuite.py other additional test on new files added.
2312 * Data/* new test files added accordingly to the testSuite.
2313 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2314 the vr in the file differs from the one of the dictionary.
2316 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2317 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2318 values, but limits itself to values which are below a user specified
2319 size (by default 1024 bytes).
2320 * python/gdcm.i : elements not loaded (because their size is above the
2321 user specified treshold) are exported with their TagKey as key of the
2322 python dictionary. This enables the testsuite to make some checks
2323 on the unloaded elements (since we have their offset and size).
2324 * python/testSuite.py
2325 - now tests for the existence and proper value of the pixel data
2326 - two new examples added.
2327 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2329 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2330 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2331 aware. See the strategy comments in gdcmHeader::FindeLength().
2332 * Test/test.cxx now accepts a filename as first argument.
2333 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2334 * python/testSuite.py changed to integrate test on above files.
2336 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2337 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2338 the vr was also RET.
2339 * python/testSuite.py more tests added.
2341 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2342 * python/testSuite.py unittest test suite added (uses Data)
2343 * Data/* dcm and acr files for the test suite.
2344 * glib dependance removed from un*x version. We now use ISO C99
2345 7.18 Integer types (see stdint.h)
2346 - python/Makefile, src/Makefile src/gdcm.h
2347 * src/ when an explicit vr (like dicom files) suddenly poped an
2348 implicit element we use to mark the underlying DictEntry of the
2349 concerned ElValue with "Implicit". This strategy was damageable
2350 too the public or provite dictionaries, since some of their vr
2351 would be changed. Since Header::FindLength heavily relies on the
2352 detection by Header::FindVR of falsely explicit elements, I
2353 added an extra ImplicitVr member to ElValue (boolean).
2354 The rest of the changes we the necessary adaptations.
2356 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2357 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2359 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2361 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2362 * Adaptation for porting to VC++:
2364 o forced to use std namespace (for string to be known)
2365 o all class use __declspec export style on WIN32
2366 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2367 (in stdlib.h on Win32 but in std:: for gcc)
2368 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2369 variable GDCM_DICT_PATH.
2370 * src/gdcmHeader.cxx verbose comments made discrete.
2372 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2373 * python/gdcm.i: added a typemap that converts a C++ hashing table
2374 to native Python dictionary.
2375 * python/demo/test.py:
2376 - now uses the native dictionary for exploration of gdcmHeader.
2377 - takes an optional filename argument (the file to parse).
2378 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2379 PubElVals hashing table.
2380 * Dicts/dicomV3.dic removed error prone trailing spaces.
2382 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2383 * Python wrapping process moved away from src/Makefile to
2384 newly created python/Makefile (as well as gdcm.i)
2385 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2386 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2387 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2388 from the environement variable GDCM_DICT_PATH (when existing).
2389 * src/gdcmDict::GetTag bug fix.
2391 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2392 * Straightforward temporary fixes for swig to build the python wrappers.
2393 src/Makefile now has a python working entry [by working we mean
2394 that we can import de shadow classes without errors].
2396 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2397 * hashtest.cxx removed (since allready in Test)
2398 * src/gdcmlib.h renamed to src/gdcm.h
2399 * src/dcm.i renamed to src/gdcm.i
2400 * src/Makefile prepared for python wrapping
2402 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2403 * src/gdcmHeader.cxx :
2404 - Parsing of header is now separated from loading of element values
2405 (see gdcmHeader::LoadElements).
2406 - general clean up of hopefully all file access (creation of
2407 ReadInt16 and ReadInt32)
2409 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2410 * src/gdcmHeader.cxx :
2411 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2413 - SetLgrElem renamed to SetLength
2414 - GetLgrElem renamed to GetLength
2415 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2416 * src/gdcmElValSet.cxx fixed both GetElValue methods
2417 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2418 due to IdoDude was cleaned out.
2420 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2421 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2422 concentrates on finding the value representation (when it exists).
2423 RecupLgr now only finds the element value length, and it avoids
2424 returning the unecessary skL (skipped length).
2425 Also, offsetCourant was simply removed (with taille_fich) since
2426 it was redundant with the File position internals (by using
2427 ftell and fseek). This also made skL (see above in RecupLgr) usage
2429 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2430 on the libido specificities which are handled through class
2432 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2435 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2436 * Truckload of changes. Parsing of header is barely functional
2437 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2439 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2440 * src/gdcmHeader.cxx many addons of low level methods
2442 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2443 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2444 and _IdDcmSWAP_LONG.
2446 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2447 * This corresponds to all the changes decided at the meeting of
2448 May 23 2002. Needless to say we are running late...