1 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
4 - comments on the DicomDir::Method related usage added.
5 - now that we use the namespace gdcm, a lot of internal classes do
6 NOT need to be wrapped anymore.
7 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
8 DicomDir::Method) new example added.
10 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
11 * Improve string manipulation. I now inforce the notion of 'DicomString'
12 A DicomString can contain as many \0 as they want
13 and it is *always* of even length.
14 We only support odd length for very rare case.
15 And in the near future this should be removed.
17 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
18 * /binary_write/ gdcm source. Now even on big endian we are writting
19 little endian. This should -heopfully- fix some tests
21 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
22 * Now the dictionary is compiled into gdcm lib. This is a default
23 behavior, thus any dic file specified is picked before failback to
24 the one comiled into lib
26 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
27 * Change internals for gdcmDict. Don't use any 'new' any more.
28 This should definitely solve any leak problem, and we should be
29 as fast as before, as long as don't modify too much the dictionary.
31 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
32 * STYLE: ivars should start with a capital letter.
33 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
34 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
36 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
37 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
38 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
39 new 2004 dictionaries added (thanks to JPR).
40 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
41 * CLEANUP_ROUND (15) for gdcmPixelConvert
42 - RLEFrame::NumberFragments is now of type unsigned int
43 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
44 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
47 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
48 * Initial work in gathering all transfer syntax accessors. clearly
49 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
50 ivars, but only one transfersyntax (class) ivar with equivalent method on
53 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
54 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
55 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
56 discussed (plus I didn't like having a 2000 lines patch not commited)
58 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
59 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
60 * CLEANUP_ROUND (14) for gdcmPixelConvert
61 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
62 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
63 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
65 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
66 anymore and hence avoids storing a copy of PixelConvert::Decompressed
67 into File::Pixel_Data.
69 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
70 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
71 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
72 * CLEANUP_ROUND (13) for gdcmPixelConvert
73 Substituted File::ParsePixelData() with PixelConvert::Print() new
75 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
76 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
77 method to those classes.
78 - src/gdcmFile.[cxx|h]:
79 -- Added a ::Print() method.
80 -- PixelConverter is now a reference instead of a member.
81 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
82 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
84 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
85 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
86 collaboration diagram and inheritance diagram should be generated with
88 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
89 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
90 pointlessly wrapped (see
91 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
92 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
93 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
94 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
95 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
96 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
97 -- File::Initialise: PixelConverter setup moved away to
98 PixelConverter::GrabInformationsFromHeader()
99 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
100 interpretation moved away to PixelConverter::BuildRGBImage()
102 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
103 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
104 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
106 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
107 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
108 displayed on Win32 when a brutal abort() occurs (because of uncatched
109 exception). See TODO new entry of this commit for more on this.
110 * TODO added new entry.
111 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
112 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
113 - HandleColor is no longer called from gdcmFile.cxx
114 - gdcmPixelConvert.cxx clean up on method arguments and internal
115 variable names for semantical coherence.
117 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
118 * Finished lossless transition, not only do we now read all lossless jpeg
119 images, without the need of the Cornwell lib, but we do read them properly now
120 * To reduce code (well to avoid code duplication), I defined a common place
121 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
122 redefine symbols. This is not prefect but this the best solution I found for a
123 compilation time jpeg option.
125 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
126 * Update jpeg ijg lib to support lossless jpeg implementation
127 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
129 * Also added a special copyright for dcmtk since we use their bugfixes.
132 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
133 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
134 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
135 matters, as stated in warning note at begining of %include section).
136 * src/gdcmDicomDir*.[cxx|h]: coding style
137 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
138 * src/gdcmJpeg8.cxx: doxygen fix.
139 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
140 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
141 from File:: to PixelConvert::.
143 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
144 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
145 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
146 - more code moved away from File:: to PixelConvert::
147 - fat setup of PixelConverter set in place in File::Initialise.
149 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
150 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
151 namespace at the file system level. So now you should convert your examples
153 gdcmHeader -> gdcm::Header
154 It would be nice if people keep in mind to no open the namespace, since it
155 allows compilation on broken plateform which were defining common symbol in
156 the standart namespace (like LP, Unknown ...)
158 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
159 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
160 The JPEG fragments are now parsed at the same stage than the RLE
161 information. All code related to JPEG is now in gdcmPixelConvert:
162 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
163 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
164 export a gdcmFile:: method. Those are simply global functions
165 (for the time being this is better than having them attach to
166 either gdcmFile:: or gdcmPixelConvert::).
167 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
168 and stores the result in a gdcmJPEGFragmentsInfo.
169 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
170 code (among other stuff) moved away from gdcmFile:; to
173 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
174 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
175 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
176 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
177 clean up of RLE related code.
178 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
179 - src/gdcmRLE.cxx removed
180 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
181 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
182 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
183 * CLEANUP_ROUND (9) for gdcmPixelConvert
184 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
185 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
186 away from gdcmFile:: to gdcmPixelConvert::.
188 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
189 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
190 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
191 This is because Parse7Fe0 used to parse the pixels to compute the
192 length. This task was passed over to FindDocEntryLengthOB() a long
193 time ago, EXCEPT I had forgotten the OW case...
194 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
195 we just recylce the code for parsing RLE fragments and computing
197 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
198 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
199 with the retired Parse7Fe0().
200 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
201 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
203 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
204 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
205 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
206 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
207 - src/CMakeLists.txt: alphabetic order reodering + new entries.
208 * CLEANUP_ROUND (4) for gdcmPixelConvert
209 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
210 to return an unused length.
212 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
213 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
214 this should be cleanner from the plane view. The iostream are erally a pain
215 to use to do simple stuff.
217 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
218 * Redo the compilation of the ijg jpeg library. Now only one source is
219 necesseray. No need to rename file by hand what so ever. CMake handle the
220 copying of the file within different directory, configure header file to
221 modify some symbol. The only addition made to ijg wasd a mangle table so
222 that symbol are different wether we are within 8bits or 12bits.
224 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
225 * Added documentation of vtkgdcmReader on Website:
226 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
227 with it's binary name).
228 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
229 the Website to be more complete.
230 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
231 doxygenated documentation.
232 - Doc/DoxyVtkGdcmReaderExamples.txt added
233 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
234 DoxyVtkGdmReaderExamples.html )
235 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
236 * CLEANUP_ROUND (3) for gdcmPixelConvert
237 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
239 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
240 * CLEANUP_ROUND (2) for gdcmPixelConvert
241 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
243 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
244 * CLEANUP_ROUND for gdcmPixelConvert:
245 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
246 - src/gdcmPixelStuff[h|cxx] removed
247 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
248 - src/CMakeLists.txt changed accordingly
250 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
251 gdcmVersion.py moved to newly created ATTIC related
252 gdcmPython/SetupOldies/ directory.
253 * Autotools clean up:
254 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
255 - autogen.sh configure.in acinclude.m4 python.m4 removed
257 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
258 * src/*.cxx *.h Reference to License.htm fixed to License.html.
259 * Doc/CMakeLists.txt, doxygen.config.in: fix.
260 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
262 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
263 * TODO updated with Mathieu suggestions. I proposed a template for
264 describing TODO entries and used it for new entries.
265 * Added Doc/Website/CodingStyle.html, Developpers.html,
266 DeveloppersPython.html, GdcmDataCvs.html and
267 DownloadVersion0_1.html, DownloadVersion0_3.html.
268 * Some Doc/*.txt Doxygen files (which do not really concern the
269 documentation itself, but the website) moved to html and
270 placed in directory Doc/Website:
271 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
272 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
273 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
274 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
275 * CMakeLists.txt changed accordingly.
276 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
277 DeveloppersPython.html
278 * INSTALL nows refers to Doc/Website/Installation.html
280 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
281 * Added Doc/Website directory, that contains a first raw version
284 2004-09-23 Jean-Pierre Roux
285 * FIX In order not to be poluted any longer by casting problems,
286 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
287 we can now delete[] it safely
288 * VoidArea is now called BinArea (less confusing name),
289 and all the methods called ...VoidArea... are now ... BinArea...
290 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
292 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
293 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
294 clear) TagHT, which is an inherited member of gdcmElementSet. It is
295 up to the destructor of gdcmElementSet to clean up TagHt and it's
298 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
299 * Test/CMakeLists.txt: update to follow gdcmData renamings.
300 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
302 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
303 * ENH: added some utility method that builds a flat dictionnary
304 holding all the Dicom entries contained in the recursive structure
305 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
307 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
308 BuildFlatHashTable() that build a flat dictionary.
309 - src/gdcmElementSet.h: added a new private GetTag() accessor.
310 gdcmDocument is now a friend of gdcmElementSet.
311 - src/gdcmElementSet.cxx: clean up.
312 - Example/FlatHashTablePrint.cxx added.
313 - Example/CmakeLists.txt changed accordingly
315 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
316 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
317 moved away from gdcmDocEntrySet (since this class is an abstract class
318 acting like an interface). SQDepthLevel and BaseTagKey are now
320 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
321 and associated accessors. Doxygenation of the class.
322 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
324 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
325 Use SQDepthLevel accessor instead. ::Print() adapted.
326 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
327 - src/gdcmDocument.cxx changed accordingly.
329 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
330 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
331 - The following is the doxygen comment of the typedef declaration
332 of gdcmagKey in src/gdcmCommon.h:
333 gdcmTagKey is made to old an "universal" (as in URL, Universal
334 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
335 A dicom tag allways has a group and an element, but a set of tags
336 embeded in various (optionally nested) sequences and sharing
337 the same group and element all share the same (group, element)
338 "identifier". Hence the (group, element) cannot be used as an
339 identifier (in gdcm we shall refer to a "TagKey") of a tag.
340 In order to construct a proper tag identifier (i.e. a key) we
341 consider the following definition of a TagKey:
342 - let Group, Element be the string representation of the
343 group and element dicom tag members,
344 - let ItemNumber be the string representation of the integer
345 index of the considered item number of a sequence,
346 Let the key of a tag embeded in a sequence, noted SeqTag, be
348 /ItemNumber#Group|Element
349 where "/", "#" and "|" are characters acting as separators.
350 Then the general form of a gdcmTagKey is given by:
351 Group|Element<SeqTag>
352 where <SeqTag> means NO or many instances of SeqTag.
353 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
356 but the gdcmTagKey of a tag "embeded" is the first item of
357 a sequence, itself nested in the third item of a sequence is the
359 0004|1220/2#0008|0082/0#0008|0090
360 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
361 order to hold the new sequence compatible key. Previously, the
362 GetKey() method would look in the underlying gdcmDictEntry.
363 - src/gdcmDocEntry.cxx:
364 -- constructor now copies the underlying DictEntry key, in the local
366 -- ::Print: displays the member Key, instead of the (group, element).
367 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
368 - src/gdcmDocEntrySet.h:xi
369 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
370 -- now has a new BaseTagKey member.
372 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
373 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
375 This poses the problem with the semantics of the following lines
376 LoadEntryVoidArea(0x0028,0x1201); // R LUT
377 LoadEntryVoidArea(0x0028,0x1202); // G LUT
378 LoadEntryVoidArea(0x0028,0x1203); // B LUT
379 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
380 to the long FIXME note for what the problem is. Nevertheless in
381 order to get things working the dicom dictionary was altered !
382 Please fix things urgently...
383 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
384 information), see above note on moving the member VoidArea. Nevertheless
385 the following entries previously correctly set as US are now inproperly
387 0028 1201 OW IMG Red Palette Color Lookup Table Data
388 0028 1202 OW IMG Green Palette Color Lookup Table Data
389 0028 1203 OW IMG Blue Palette Color Lookup Table Data
390 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
391 of gdcmDocEntry moved to gdcmSeqEntry.
392 * src/gdcmSeqEntry.cxx: STYLE.
394 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
395 * Test/TestAllEntryVerify.cxx minor fix and added comments.
397 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
398 * gdcmPython/testSuite.py: all the test suite in python is now moved
399 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
400 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
401 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
403 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
404 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
405 to avoid inclusion recursion until STL is reached.
406 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
407 mecanism. errno.h is not included in gdcm anymore.
408 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
409 (gdcmFormatError now inherits from gdcmFormatUnexpected).
411 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
412 gdcmData/TestAllEntryVerifyReference.txt
413 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
414 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
415 exception_on_error parameter.
416 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
417 - vtk/vtkGdcmReader.cxx changed accordingly,
418 - Example/*.cxx and Test/*.cxx changed accordingly.
420 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
421 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
422 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
423 enable_sequences removed from gdcmHeader constructor and dependencies.
424 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
425 * gdcmPython/demo/PrintHeader.py: dummy fix.
426 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
427 skip_shadow removed from gdcmHeader constructor and dependencies.
428 * Example/*.cxx and Test/*.cxx changed accordingly.
430 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
431 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
432 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
434 2004-07-21 Jean-Pierre Roux
435 * FIX Now, Parsing and Printing a DICOMDIR do work!
436 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
438 2004-07-20 Jean-Pierre Roux
439 * FIX Some brain damaged headers have Zero-Lenght fields
440 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
442 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
443 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
444 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
445 variable (instance of gdcmDebug) by a definition macro, and the instance
446 is now in static in the gdcmDebug class
447 * src/gdcmSQItem.h : (FIXME) remove an undefined method
448 * Test/PrintAllDocument.cxx : bug fix in the result of the test
450 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
451 * WARNING: ctest now depends more tightly on gdcmData. You should
452 check out gdcmData properly for things to run smoothly...
453 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
454 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
455 we need the pixels not be loaded in order to use the ValEntry
456 that displays position and size).
457 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
458 This is a C++ based equivalent of gdcmPython/testSuite.py that should
459 be deprecated. If you have any doubts about the advantages of a
460 modern scripting language (read Python) versus grass root C++ (i.e.
461 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
462 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
463 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
464 Anyhow, consider documenting the gdcmData images in
465 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
467 * Test/CMakeLists.txt:
468 - now uses TestAllEntryVerify.cxx
469 - specific comments on oldACR00001.ima (now renamed in gdcmData
470 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
471 gdcmData/TestAllEntryVerifyReference.txt
474 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
475 * src/*.[h|cxx] : typedef clean up
476 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
477 - TagKey renamed to gdcmTagKey (for external usage)
478 - VRKey renamed to gdcmVRKey (for external usage)
479 - removal of typedef duplication.
480 - Removed all unecessary inline keyword from class inline definitions.
481 - Some method|function(void) declarations replaced with method|function().
482 * src/jpeg/libijg12/jdhuff12.c:
483 - printf polluting ctest removed.
484 - TAB removal for comminting
486 - TestAllReadCompareDicom.cxx: added a test that compares all the
487 images in gdcmDataImages.h with corresponding images in
488 gdcmData/BaselineDicom/. When baseline images are not present
489 this test creates them.
490 Note: we need to validate each reference image, but before that
491 I'd like to rename them with a more explicit name...
492 - CMakeLists.txt: changed accordingly.
493 * Example/*.cxx: examples now only include gdcm.h (as opposed to
494 including each header needed).
496 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
497 * Test/*.cxx and Example/*.cxx: moved some examples away from the
498 test suite to the Example directory. Are concerned:
503 - TestWriteSimple.cxx
504 * Test/CMakeLists.txt: added some comments on reasons for black listing
505 image gdcmData/oldACR00001.ima
507 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
508 * Test/CmakeList.txt: removed the following from black list (to be coherent
509 with removal from gdcmData):
510 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
511 - gdcm-MR-PHILIPS-16.dcm
513 Added the following because after last cvs update, they cause
514 ctest -R TestReadWriteReadCompare
516 - gdcm-MR-SIEMENS-16-1.acr
518 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
519 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
520 new comments in this file) we temporarily (sigh) move to a weaker
522 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
523 we don't need to black list the following images anymore:
524 - 8BitsUncompressedColor.dcm
526 - US-PAL-8-10x-echo.dcm
527 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
528 fixes and the beautified code ;-)
529 This fixes the bug introduced in version 1.42 (when beautifying)
530 that made the parsing of 8BitsRunLengthColor.dcm unproper.
531 Note: ctest was blind to this bug (this means we need to still
532 improve the test suite). The bug could be detected by using
533 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
535 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
536 and by displaying the (garbage) produced file temp.XDCM...
538 2004-06-29 Jean-Pierre Roux
539 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
540 - replace by uggly but working old code :-(
541 A lot of things should be OK again.
542 It's really urgent to have a test suite that *tests*,
543 to prevent Frog's beautifying sessions to break all the stuff
544 (twice, withing a fortnigh ...)
546 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
547 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
548 redundancy) to added Test/TestReadWriteReadCompare.cxx
549 * Test/CmakeList.txt: because the compare test of
550 Test/TestReadWriteReadCompare.cxx fails, the following images are
551 black listed: - 8BitsUncompressedColor.dcm
553 - US-PAL-8-10x-echo.dcm
554 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
555 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
556 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
557 and ad-hoc kludge. This kludge is now removed, and on encountering
558 such an image (OB field brain damaged) we set errno. Then in
559 ::FindDocLength() we "fix" the length as being ALL what remains
560 in the file (until EOF). We then proceed, hoping for the best...
561 This fixes a SegFault in ShowDicom when trying to write such an
563 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
564 (because TestWriteRead breaks on it, after a non conformal commit?).
565 ctest now runs properly, except for MakeDicomDir (which was allways
566 broken) and the Python related stuff (still not fixed).
568 2004-06-24 Jean-Pierre Roux
569 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
570 FIX : Test/TestReadWrite now iterates on all the file names
571 (instead of infinite loop)
572 ENH : Test/TestWriteRead now iterates on all the file names
574 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
575 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
577 2004-06-24 Jean-Pierre Roux
578 FIX : - now Write drops LUT Descriptors and LUTs (if any)
579 when SamplesPerPixel =3
580 - now Write is no longer confused by
581 'BitsAllocated = 12" and 'BitsStored=12"
582 - "UN" value representation Elements are now written correctly
583 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
584 ENH : - now gdcmHeader has its own Write methods
585 (in order to split the job that has not to be done
588 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
589 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
590 loop on the same image until memory went out.
591 Note: this means we still have gobs of memory loss in PrintDocument
592 * src/gdcmDocument.cxx: fixes problem on parsing on file
593 gdcmData/16BitsJpegLosslessGrayScale.dcm.
595 2004-06-24 Jean-Pierre Roux
596 FIX : Write - All the Sequences and Sequence Item are now written
597 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
598 is added a the end, when necessary.
599 - A lot of brain-damaged images, that were read correctly are
600 now written correctly
601 - length compatible BinEntry are now loaded correctly
602 (even for odd groups)
603 Note : only Explicit Value Representation was checked.
604 (question : is implicit VR really necessary for gdcm ?)
606 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
607 * DEVELOPPER: added a proposition of coding style.
608 * src/gdcmDocEntry.h: removed every inline declaration (for test of
611 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
612 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
613 Use the gdcmDocEntry::Print() and Write() instead.
614 * src/gdcmDocument.cxx: bug fix.
616 2004-06-22 Jean-Pierre Roux
617 FIX : gdcmDocument.cxx
618 - Now we do recognize the JpegLossLess format (there was a misstyping in
619 code 'beautyfication' :-(
620 - Now we automaticaticaly load the Luts, if any
622 2004-06-22 Jean-Pierre Roux
623 In order : to write Sequences, whatever their imbrication level,
624 : to allow user to create his own Sequences
625 a lot of modif where necessary (adding, moving, or virtualising methods)
627 WARNING : save your own sources *before* cvs up !
630 ADD virtual void Write(FILE *fp, FileType filetype);
633 ADD virtual void Write(FILE *fp, FileType filetype);
634 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
637 ADD virtual void Write (FILE *fp, FileType filetype)=0;
638 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
639 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
640 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
641 ADD std::string GetEntryByName(TagName name);
642 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
644 std::string vr = "unkn",
645 std::string fourth = "unkn",
646 std::string name = "unkn");
647 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
648 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
649 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
650 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
651 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
652 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
653 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
654 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
657 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
658 ADD virtual std::string GetEntryByName (TagName tagName);
659 ADD virtual std::string GetEntryVRByName (TagName tagName);
660 REM virtual bool Write(FILE *, FileType);
661 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
662 FILE *_fp, FileType type);
663 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
664 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
665 REM virtual bool WriteEntries(FILE *_fp,FileType type);
666 REM virtual std::string GetEntryByName (std::string tagName);
667 REM virtual std::string GetEntryVRByName (std::string tagName);
668 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
669 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
670 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
672 std::string vr = "unkn",
673 std::string fourth = "unkn",
674 std::string name = "unkn");
675 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
676 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
677 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
678 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
681 ADD virtual void Write(FILE *fp, FileType filetype);
684 ADD virtual void Write(FILE *fp,FileType filetype);
687 ADD virtual void Write(FILE *fp, FileType filetype);
688 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
689 REM std::string GetEntryByNumber(guint16 group, guint16 element);
690 REM std::string GetEntryByName(TagName name);
693 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
695 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
696 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
697 The default constructor invoked by the line
698 gdcmHeader *f1 = new gdcmHeader( header );
699 was gdcmHeader::gdcmHeader(bool) instead of the expected
700 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
701 Hence the parsing wasn't executed... See also below.
702 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
703 as explicit constructor didn't do the trick to fix the above problem.
704 Could anyone explain why ?
705 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
706 properly calls gdcmValEntry::Print() (that was weed out from
707 code related to gdcmBinEntry).
709 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
710 * In order to fix memory leaks:
711 - Test/TestWriteSimple.cxx: added cleaning of free store through
713 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
714 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
715 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
716 (through the call to ::AddDicomDirMeta()) or the destructor
717 would crash when deleting uninitialized ::metaElems].
718 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
719 - src/gdcmDocument.cxx:
720 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
722 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
723 was causing memory leaks.
724 - src/gdcmSQItem.cxx:
725 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
726 cleanly handled with polymophism: sorry but my milage is low).
727 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
728 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
729 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
730 This avoids SegFaulting.
731 - src/gdcmSQItem.h: coding style.
733 - Test/TestWriteSimple still severely sucks. The output image content
734 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
735 damaged when displayed with vtkgdcmViewer.
736 - on memory leaks: TestWriteSimple leaks really less (see entry
737 of 2004-06-18 in Changelog file for the call to valgrind).
738 - on segfaults: ctest now passes all the tests but one (no more
740 * Erroneous leading white fix:
741 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
742 white[s] (as opposed to from >> xxx, that removes it [them].
743 - src/gdcmTS.cxx: ditto.
744 - gdcmPython/testSuite.py: dirty related kludge removed.
745 * src/*: remaining references to gdcmParser removed.
746 * src/*[cxx|h]: added copy[way]left header.
749 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
750 * In order to fix writing of dicom files:
751 - Test/TestWriteSimple.cxx: a simpler example of writing.
752 - Test/CMakeLists.txt changed accordingly.
753 - src/gdcmDocument.cxx:
754 -- The destructor now recursilvely removes potential sequences.
755 -- Bug fix in ::IsJPEG2000()
756 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
757 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
759 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
760 to only declared) and build on top of
761 ::GetDocEntryByNumber(guint16, guint16).
762 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
763 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
764 for usage in destructor and treatement of promotion in
765 ::ReplaceOrCreateByNumber().
766 - src/gdcmSQItem.cxx: destructor should better handle his job.
767 Test/TestWriteSimple now runs (or at least it DOES something).
768 * We can now start hutting memory links. A good starting point is:
769 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
770 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
771 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
773 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
774 * Valgrind note: after Mathieu Malaterre teached me how to read
775 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
777 Using gcc, you can force the STL to use malloc and to free memory as
778 soon as possible by globally disabling memory caching.
779 With 3.2.2 and later, you should export the environment variable
780 GLIBCPP_FORCE_NEW before running your program.
781 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
782 simply vanish (it is still not clear to me, whether this means that
783 STL std::string leaks or if valgrind believes it leaks...).
784 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
785 running bin/gdcmTests makeDicomDir):
786 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
787 - Test/makeDicomDir.cxx now properly traps empty lists and returns
789 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
790 SegFaulting (I drowned in DicomDir related code when trying to
791 understand why the list is empty...).
792 * src/gdcmDocument.h: first BSD license header try.
793 * Doc/License.txt added.
795 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
796 * src/gdcmDocument.[h|cxx]:
797 - Clean up of the Transfer related predicates. They are now all based
798 on new method isGivenTransferSyntax, that (should) handle properly
800 - general clean up, simplification, and coding style.
801 - Specific clean up of Parse7FE0() (umproperly named actually).
802 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
804 2004-06-14 Jean-Pierre Roux
806 - fix the display of Sequence Delimitor (SQDepthLevel pb)
807 - fix the display of SQItem ordinal number
808 - add the GetSQItemByOrdinalNumber method
809 - remove some useless never written private methods
811 2004-06-14 Jean-Pierre Roux
813 - adding a constructor taking a gdcmDocEntry as an input param
814 - ReplaceOrCreateByNumber now returns :
815 a gdcmBinEntry * if a Binary (void *) value is passed as a param
816 a gdcmValEntry * if a string value is passed as a param
818 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
819 according to the param type (no longer sets a gdcmDocEntry)
820 - GetValEntryByNumber, GetBinEntryByNumber added
821 - NewValEntryByNumber and NewBinEntryByNumber added
823 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
825 - GetSQItemNumber and SetSQItemNumber added, to provide
826 a (relative) Item identier inside a given Sequence
827 \warning : some pb remaining around this number
829 - AddEntry now takes the Item Number as a param
831 - adding a constructor taking a gdcmDocEntry as an input param
833 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
834 * Memory leak hunt with the following command:
835 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
836 --show-reachable=yes gdcmTests PrintDocument
837 It looks like many (all?) leaks are due to the STL (or a bad usage
838 of the STL. The lines producing the leaks now have a comment with
839 a "MEMORY LEAK" tag: you can retrieve them with
840 grep "MEMORY LEAK" src/*
841 Here are two typical examples which I can't help fixing:
846 char * test = "babo";
847 name = test; //// <--- valgrind detects 960 bytes lost in
848 //// call to std::string::operator=(char const*)
849 name.clear(); //// Doesn't help !
857 std::cout << "Type a bunch of characters followed by RETURN: ";
858 getline(std::cin, line); //// <--- valgrind dectects a loss
859 //// of 1320 bytes in call to
860 /// std::basic_istream<>& std::getline<>
866 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
867 * src/gdcmHeader.[cxx|h]:
868 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
869 and related, moved away to gdcmDocument.
870 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
871 the corresponding protected accessors of inherited class
872 gdcmDocument, removed ! As a consequence gdcmFile had to be
873 declared friend of class gdcmDocument (see below).
874 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
875 - Clean up of undefined or unused methods.
876 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
877 account the changes to gdcmHeader.h).
878 * src/gdcmDocument.h:
879 - gdcmFile is now a friend class (in order to take into account the
880 changes to gdcmHeader.h).
881 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
882 (see changes to gdcmHeader.h).
883 - Accessors (reading on the form GetEntry*) are now public.
884 - Clean up of undefined or unused methods.
885 * src/gdcmDocument.cxx:
886 - adaptation to changes to gdcmDocument.h
887 - ::OpenFile now writes a verbose message when file cannot be opened.
888 - some std::string properly set to VRKey
889 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
890 references to gdcmDocument.
891 * Test/TestFindTags.cxx: changed accordingly to above changes.
892 * gdcmPython/testSuite.py: adapted to renaming of acr files in
893 cvs repository gdcmData.
895 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
896 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
897 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
898 conflicts with gdcmValEntry::voidArea.
899 * src/gdcmValEntry.cxx: unmatching comment wiped out.
900 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
901 Value representation between StringRepresentable and BinaryRepresentable.
902 * src/gdcmDocument.cxx:
903 - method ParseDES: proper indentation restored and usage of
904 gdcmVR::IsVROfGdcmStringRepresentable wired in.
905 - method LoadDocEntry: the fingerprint left in the SetValue() of
906 unloaded entries (length > MaxSizeLoadEntry) had curiously been
907 removed. Reverting to previous code segment with the proper
908 dynamic_cast< gdcmValEntry* >.
909 Note: this was (partially) breaking the python test suite
910 (gdcmPython/testSuite.py) that made usage of the above
911 fingerprint to check presence of "Pixel Data".
912 * src/gdcmDocEntry.h: coding style.
913 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
914 now taken into account.
915 * gdcmPython/gdcm.i: adaptation to the new internal representation
916 of gdcm (exit gdcmParser, hello gdcmDocument).
917 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
919 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
920 anymore, but instead prints the loaded Python dictionary.
921 * .... alas, the python testSuite is still broken.
923 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
924 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
926 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
927 * src/gdcmUtil.h : export methods
929 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
930 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
932 * Initial addition of automatic python testing
933 * Initial addition of automatic image comparison
935 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
936 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
937 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
939 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
940 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
941 * Test/ShowDicom.cxx : bug fix for msvc compilation
942 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
944 2004-05-04 Jean-Pierre Roux
945 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
946 new concepts (and new classes) :
947 a 'gdcmDocument' is composed of a set of Doc Entries, that are
948 - elementary gdcmDocEntries (former gdcmHeaderEntries)
949 - Sequence Doc Entries (gdcmSeqEntries)
950 a Sequence is composed of Items.
951 Each item is a set of Doc Entries (this is recursive)
952 The non uniqueness of the 'Dicom tag' is due to this recursivity
953 (never taken into account)
954 Our unability to add a new 'entry' in the header
955 at the proper location (neither in the H-Table (map or multimap),
956 nor in the Chained List is also due to this recursivity.
957 Don't try, right now, to use/modify/compile these new sources :
959 We just commit all the stuff, 'as is', in order not to loose it.
961 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
962 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
964 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
965 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
966 file prefix (SetFilePrefix)
968 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
969 * Add a new test: ShowDicom, for now this is just the c++ version of
970 checkRead.sh, later it will be able to compare the image read against a
972 * Replace the DEBUG on the stack with a global entry in cmake interface:
973 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
975 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
976 * Add an example subdir, with a real example on how to read + write a
979 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
980 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
981 * Doc/CMakeLists.txt: the main page is now properly differentiated
982 between the developper and user version.
983 * Doc/doxygen.config.in: dropped search related obsolete flags
984 * src/gdcmParser.h, gdcmHeader.h: doxygenation
986 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
987 * DEVELOPPER: added some helpfull comments for compile/test/install
990 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
991 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
992 src directory, now generated in the build dir.
993 2. Tests as mentionned smarter
995 4. Add a new method in gdcmDict that return the PubDict by name
996 this is interesting for 3rd party lib like ITK,
997 where we could set the institution name / patient name...
999 * ENH: 1. Now the test suite is working for real
1000 2. All binaries are now output in the gdcm-bin directory
1001 (this was not true before)
1003 2004-04-28 Jean-Pierre Roux
1004 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1005 SeQuence indented printing of Dicom Header.
1006 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1007 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1008 Computation of SQDepthLevel is now part of gdcmHeader constructor
1009 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1010 tree-like structure of a Dicom Header.
1011 * FIX Test code cleaning
1013 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1014 * ENH: Adding automatic testing
1015 1. Need a DartConfig.cmake to submit to public
1016 2. Add a test driver gdcmTest.cxx
1017 3. gdcmTestMain, an helper for the main test driver gdcmTest
1018 4. Files in Test don't have a main anymore, this becomes interesting
1019 when we add more and more tests, thus dsw don't have to load
1021 * ENH: Adding a GDCM_DATA_ROOT for testing
1022 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1023 one file instead of seven + some small cleanup
1025 2004-04-22 Jean-Pierre Roux
1026 * ENH Minor changes to the Print() methods.
1027 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1028 Header printing. Example given with :
1029 > PrintHeader fileName 2 new
1030 (SQ based tree-like structure still to be done for the Header ...)
1032 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1033 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1034 1. I have added some unsigned where needed
1035 2. Some function parameter not used -> (void)
1036 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1037 4. g++ don't like character '\' in comment
1038 5. #define jpeg_create_decompress jCreaDecompress
1039 this really need to be fixed
1040 6. virtualize destructor of gdcmObject ... leakage
1041 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1042 this also really need to be fixed
1043 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1044 remove compression file
1045 (as we only do decompression, right ?)
1046 * ENH: Change malloc/calloc/free with c++ equivalent
1048 2004-04-21 Jean-Pierre Roux
1049 * FIX gdcmHeaderHelper::GetXSpacing
1050 when a single value is found (bug ?), xpacing is now
1051 defaulted to yspacing
1053 2004-04-19 Jean-Pierre Roux
1054 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1055 * ENH add parameters :
1056 bool exception_on_error = false,
1057 bool enable_sequences = false,
1058 bool ignore_shadow = false
1059 to the gdcmFile constructors to be full gdcmParser compliant
1060 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1061 to allow reading of PAPYRUS 3.0 files
1063 2004-04-06 Jean-Pierre Roux
1064 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1066 2004-04-02 Jean-Pierre Roux
1067 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1068 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1069 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1071 2004-03-30 Jean-Pierre Roux
1072 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1073 for ACR file, written out as DICOM files (hope so...)
1075 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1076 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1077 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1078 moved to base class gdcmParser and only the specialisation is kept
1080 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1081 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1082 already does the job.
1083 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1084 (to be consistent with gdcmParser::WriteEntries).
1086 2004-03-30 Benoit Regrain
1087 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1088 upate of the object's instance. It's passed to 2 in the unfavorable
1089 case : one in the ExecuteInformation, one in the ExecuteData
1091 2004-03-29 Jean-Pierre Roux
1092 * ENH : Check on file type to be written moved
1093 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1094 * FIX : gdcmObject::ResetBoundaries now stops properly
1095 when end-of-list is reached
1096 : gdcmVersion modified (as Benoit Regrain asked)
1098 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1099 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1100 * src/gdcmUtil.cxx: added forgotten iostream include.
1101 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1102 equivalent to ExplicitVR in existing code).
1104 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1105 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1106 now contains all the gdcmGlobal related code.
1107 * minor coding style and doxygenation changes.
1109 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1110 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1111 now contains all the Debug related code.
1112 * minor clean-up of includes in src/*.cxx
1113 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1114 CreateCleanString) removed.
1115 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1116 * Doc/DoxyMainPageUser.txt added.
1117 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1118 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1119 src/gdcmDirList.cxx)
1121 2004-03-24 Jean-Pierre Roux
1122 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1124 2004-03-23 Jean-Pierre Roux
1125 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1126 big endian made volumes
1127 * ENH Now gdcmParser constructor and destructor are protected to forbid
1128 end user to instanciate class gdcmParser
1129 (only gdcmHeader and gdcmDicomDir are meaningfull)
1131 2004-03-22 Benoit Regrain
1132 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1133 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1134 gdcmSerie to gdcmDicomDirSerie
1136 2004-03-19 Jean-Pierre Roux
1137 * ENH Now the tree-like structure describing a DICOMDIR comming from
1138 an already existing DICOMDIR file is consistent with
1139 the home-made tree-like structure build ex-nihilo
1140 or build from the files held (recursively) in a Directory
1141 functions gdcmDicomDir::CheckBoundaries()
1142 gdcmObject::SetBoundaries() added
1144 2004-03-17 Jean-Pierre Roux
1145 * REM (Eric Boix bug) : removal of meaningless
1146 gdcmDicomDirImage::NewImage function.
1147 * FIX now file names and directory name are written properly in the
1149 * FIX now gdcmDicomDir constructor may be call without any trick
1152 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1153 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1154 of gdcmDicomDirImage::NewImage as empty function.
1156 2004-02-28 Jean-Pierre Roux
1157 * ENH add gdcmDicomDir:NewPatient
1158 add gdcmDicomDirPatient:NewStudy
1159 add gdcmDicomDirStudy:NewSerie
1160 add gdcmDicomDirSerie:NewImage
1161 to allow making gdcDicomDir object.
1162 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1163 (as opposite to the gdcmHeader chained list)
1165 2004-02-11 Benoit Regrain
1166 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1167 when using from python
1169 2004-02-10 Benoit Regrain
1170 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1171 * FIX : in gdcmDicomDir when the directory is empty
1172 * ENH : add callback and methods to get the progression of dicomDir
1175 2004-02-06 Jean-Pierre Roux
1176 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1177 - GDCM_META added to gdcmDicomDirType
1178 - class gdcmMeta created
1179 * ENH : - A brief summary is now displayed at the beginning of
1180 'testDicomDir' to help disaster magnitude estimation
1181 * REM : Now useless Test/explDICOMDIR.cxx
1183 2004-02-05 Benoit Regrain
1184 * ENH : add methods in gdcmObject to get the hash table or the list of
1186 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1187 * FIX : wrapping python for TagHeaderEntryHT
1189 2004-02-04 Benoit Regrain
1190 * FIX : even length for some strings when writting the dicom dir
1191 * FIX : sort the images in the dicom dir
1192 * FIX : Bug fix for python use of dicom dir
1193 * ADD : a python demo
1195 2004-02-04 Jean-Pierre Roux
1196 * FIX : Final solution (?) for icone embedded images
1197 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1198 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1199 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1200 gdcmData/gdcm-MR-SIEMENS-16.acr1
1201 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1202 to make full checking easier
1204 2004-02-04 Benoit Regrain
1205 * FIX : WriteEntries : coding style & logic in parameters
1206 * FIX : Set the elements to create the DicomDir in a dictionary file
1208 2004-02-03 Benoit Regrain
1209 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1210 * gdcmDicomDir : add the load of directory
1211 * Bug fix and print add-on
1213 2004-02-03 Jean-Pierre Roux
1214 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1215 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1216 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1217 * FIX gdcmParser.cxx : 'group length' elements are now considered
1218 as integers, even for shadow groups, when file is Implicit VR
1220 2004-02-02 Jean-Pierre Roux
1221 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1223 of the last synonym :-(
1224 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1226 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1227 * FIX taking into account the possible 7fe0,0010 multiplicity
1228 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1229 to allow removal of references to 7fe0,0010, to deal with
1230 ACR-NEMA images, when 0028,0200 is meaningfull
1232 2004-01-31 Jean-Pierre Roux
1233 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1234 no longer writes 'Un' on disk
1235 * FIX SQ elements with actual length are now dealt with corectly
1236 * FIX gdcmFile::WriteBase make the difference, for color images, between
1237 the length (for Palette expanded images)
1238 and Raw Length (non expanded image + Palette)
1239 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1240 (that broke Write). Replaced by UL.
1241 Aware user will reload the field if he
1242 thinks it's necesssary
1244 2004-01-30 Jean-Pierre Roux
1245 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1246 when 'dirty Acr' is found, to be compliant with the new
1247 IsReadable() methods.
1249 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1250 (no DOUBLE images in kosher DICOM,
1251 but so usefull for people that miss them ;-)
1253 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1254 DICOMDIR related utilities (not checked as Windoze compliant)
1256 2004-01-28 Jean-Pierre Roux
1257 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1259 2004-01-27 Jean-Pierre Roux
1260 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1261 to allow skipping the shadow elements, to save memory space.
1262 The TRUE value for this param has to be used
1263 with a FALSE value for the 'enable_sequence' param.
1264 ('public elements' may be embedded in 'shadow Sequences')
1265 * gdcmHeader methods now deal with 'embedded icones images' in the header
1266 (even when an 'icone image sequence' is announced by the
1267 element (0x0088,0x0200), but there is NO icone at all ...
1269 * gdcmHeader sometimes Image Location value doesn't follow
1270 the supposed processor endianity (see gdcmData/cr172241.dcm).
1273 * gdcmHeader add the method
1274 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1275 to get *all* the Header Entries with the same tag.
1276 GetHeaderEntrySameName is probabely *useless*
1277 (no meaning : Name is *not* an identifier within the Dictionnary)
1279 2004-01-26 Benoit Regrain
1280 * Bug fix in the print of hexadecimal representations. Remove long fields
1281 in the print and add a third level of print to print them
1283 2004-01-23 Benoit Regrain
1284 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1285 * Bug fix on test suite after remove the strip made on not string fields
1286 * Split the IsReadable method between gdcmParser which test that the file
1287 is dicom and gdcmHeader which test that it's an image file
1289 2004-01-22 Benoit Regrain
1290 * DicomDir : clean code, add methods, set variables in protected or private
1291 * gdcmUtil : bug fix for the clean string method
1293 2004-01-19 Benoit Regrain
1294 * Add the use of shadow dictionaries
1295 * bug fix and coding style
1297 2004-01-19 Benoit Regrain
1298 * src/gdcmFile.cxx : bug fix concerning the close of file
1299 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1300 * Add the update of header entries using the shadow library
1302 2004-01-19 Benoit Regrain
1303 * removal of file gdcmHeader2.cxx
1304 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1305 inheriting from gdcmParser. This split is to prepare the integration
1306 of dicom dir parsing
1307 * bug fix under python
1309 2004-01-16 Jean-Pierre Roux
1310 * REM removal of class gdcmHeaderEntrySet
1311 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1312 * ADD add file gdcmHeader2.cxx
1313 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1315 2004-01-15 Benoit Regrain
1316 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1317 entries created while parsing the header. Thus, they will be destroyed
1318 when the gdcmDictSet will be destroyed
1319 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1322 2004-01-15 Benoit Regrain
1323 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1324 made a fatal error because of the memory release at the end of program.
1325 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1326 some memory and vtk seems to have some problems with that.
1327 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1329 2004-01-14 Benoit Regrain
1330 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1331 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1332 * src/*.[h|cxx] : make changes due to class name changes
1333 * gdcmPython/demo/*.py : bug fix due to method names
1335 2004-01-13 Benoit Regrain
1336 * src/*.[h|cxx] : coding style
1337 * vtk/*.[h|cxx] : coding style
1339 2004-01-13 Benoit Regrain
1340 * gdcmPython/testSuite.py : test the readable flag of file for tests
1341 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1342 It's lied to the stl compilation by MSVC (windows, always windows...)
1343 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1345 2004-01-12 Benoit Regrain
1346 * src/*.h : add comments
1347 * src/gdcmDictSet.h : set the method BuildDictPath in public
1348 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1349 directly setted in the source code
1350 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1353 2004-01-09 Benoit Regrain
1354 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1355 * setup.py : use a reference to gdcmVERSION
1357 2004-01-07 Benoit Regrain
1358 * Modification to compile with the distutils.
1361 2003-12-10 Benoit Regrain
1362 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1363 can use a gdcmHeaderHelper to load datas
1364 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1365 made in the source code
1367 2003-12-10 Benoit Regrain
1368 * Update Windows projects and .cvsignore files
1370 2003-11-12 Jean-Pierre Roux
1371 * ENH gdcmHeader constructor has one more parameter (default value : false)
1372 that allows the user to 'go inside' the SeQuences only
1374 gdcmElValSet:Print takes it into account
1376 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1377 * ENH: Update gdcmPython/CMakeLists
1378 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1379 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1381 2003-11-10 Jean-Pierre Roux
1382 * FIX : gdcmHeader::LoadElements is now based
1383 on the ListTag listElem member,
1384 not longer on the TagElValueHT tagHt member
1385 * ENH : PrintPubElVal shows (temporarily) both results,
1386 with the tagHt member and the listElem member.
1387 (it's easier to 'see' the problems when using Printheader)
1389 * FIX : old private member LgrElem is now splitted into
1390 ReadLength : Length actually found on disk (updated only
1391 if bug fixing is necessary), for internal
1393 UsableLength : Updated by FixFoundLength, to fix a bug
1394 or to allow Parser going on.
1395 Will allow to re-write a kosher header when a SeQuence
1396 with a length (not 0000) is found
1397 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1398 because gdcmElValSet::Add does not update ListElem
1401 2003-11-07 Jean-Pierre Roux
1402 * FIX misstyping in Transfert Syntax name table
1403 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1404 when they have an actual length (not 0000 nor FFFFF)
1405 (Nobody should care of it, but DICOMDIR explorers)
1407 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1408 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1410 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1411 * ENH: vtkGdcmReader now supports LUT !
1412 (vtkgdcmViewer for now is not able to use them though)
1414 2003-11-05 Jean-Pierre Roux
1415 * in testSuite.py : new files names for checking the package
1416 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1417 that returns the pixel area size to the *aware* (vtk) user
1418 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1420 2003-11-05 Benoit Regrain
1421 * in testSuite.py : Modify the rules for checking the paths
1422 : Explicit error messages
1423 * in __init__.py : Related modif
1425 2003-11-03 Jean-Pierre Roux
1426 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1427 to be used by aware (vtk) users that want to manage
1428 LUT (and no to turn the PALETTE image into an RGB pixels one)
1429 * GetPixelType now returns 8U for 24 Bits images
1430 (vtkGdcmReader compliant)
1432 2003-10-31 Jean-Pierre Roux
1433 * Removal of *all* gdcmData images and add them again
1434 in order to loose the 'history' of un-anonymised images
1436 2003-10-31 Jean-Pierre Roux
1437 * RMV : removal of useless jBitsInJsample.h
1438 for both 8 and 12 Bits JPEG Lossy Libraries
1440 2003-10-31 Jean-Pierre Roux
1441 * ENH : Add the functions gdcmFile::GetImageDataRaw
1442 gdcmFile::GetImageDataIntoVectorRaw
1443 that act as GetImageData and GetImageDataIntoVector
1444 except the making of an RGB Plane from Gray Plane + LUT
1445 Intended to aware (vtk) users who know how to manage
1448 GetLUTRGBA return a R,G,B,A LUT if any
1449 lgrTotaleRaw gives the 'Raw' length
1450 GetImageDataRaw returns the gray Plane
1451 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1452 (They stay Grey, just like with other Dicom viewers :-(
1454 2003-10-30 Jean-Pierre Roux
1455 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1457 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1458 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1459 being coherents dicom files.
1461 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1462 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1464 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1465 * ENH: Two steps is necessary to please VC++ compiler...
1466 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1467 * ENH: Add include dir to medcon lib
1468 * FIX: only one function is being exported for now !
1469 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1471 2003-10-29 Jean-Pierre Roux
1472 * adding gdcmHeader::GetLUTRGBA
1473 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1474 --> Mathieu, the modif u're waiting for is not yet committed
1475 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1477 2003-10-27 Jean-Pierre Roux
1478 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1479 00191113.dcm DermaColorLossLess.dcm
1480 MxTwinLossLess.dcm RadBWLossLess.dcm
1481 * ENH: For version prior to vtkImageViewer2 -r 1.19
1482 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1484 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1485 * Removal of ido stuff in CMakeLists.txt
1487 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1488 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1489 * FIX: remove a call to ->Modified ... see comments
1490 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1492 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1493 * FIX: Problem with path for libvtkgdcmPython
1494 * ENH: Try adding a search script for python site-package
1495 * RMV: Remove some file from medcon lib that are not necessary
1496 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1497 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1498 * FIX: More pragma disable fro VC++,
1499 I don't think I break something as it is also disable in VTK/ITK.
1500 But it fasten debug compilation time.
1502 2003-10-23 Jean-Pierre Roux
1503 * gdcm now deals with 16 Bits Run Length Encoded images
1504 (they are compressed as 2 planes images,
1505 one for the high Bytes, the other for low Bytes)
1507 2003-10-22 Jean-Pierre Roux
1508 * Now CheckRead takes into account :
1509 - the bugged 'Leonardo' Siemens images
1510 - the XA images, sent thru the burning VPRO station
1511 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1514 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1515 * FIX: When copying a Makefile.am to CMakeLists.txt
1516 one should remove the '\'
1518 2003-10-22 Jean-Pierre Roux
1519 * in gdcmData adding a bugged 'Leonardo' Siemens image
1520 (wrong lengths in header)
1521 OK with gdcm, KO with the other viewers :-)
1522 * add a GE dlx XA image, thru the VEPRO burning station
1525 2003-10-21 Jean-Pierre Roux
1526 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1527 for a brutal checking of vtkgdcmViewer compliance
1529 2003-10-21 Jean-Pierre Roux
1530 * add the files for 'xmedcon' Jpeg Lossless library
1531 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1533 2003-10-21 Jean-Pierre Roux
1534 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1536 2003-10-21 Jean-Pierre Roux
1537 * garbage Siemens 'Leonardo' images dealt with
1538 (the patch is easy to remove)
1539 * cosmetic changes to avoid warnings
1541 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1542 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1543 no need to press 'r' now.
1545 2003-10-20 Jean-Pierre Roux
1546 * upgrade of checkRead.sh checkWrite.sh according
1547 to new Jpeg Lossless decompressor
1548 * add US.3405.1.dcm, a genuine RGB medical file ...
1549 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1550 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1552 2003-10-15 Jean-Pierre Roux
1553 * general anonymisation in gdcmData
1554 * adding the 'color files' from
1555 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1556 * adding some well knowed bugged-header images
1557 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1558 waiting for their inclusion in Python testsuite
1560 2003-10-15 Jean-Pierre Roux
1561 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1562 no longer seg faults when file is not found
1564 2003-10-14 Jean-Pierre Roux
1565 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1568 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1569 * TODO: *.in file to genereate a UseGDCM later
1571 2003-10-14 Jean-Pierre Roux
1572 * Some supposed-to-be Dicom Images have no preamble.
1573 OpenFile takes it into account
1574 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1575 * Missing elements added in dicomV3.dic
1576 (just to be affraid : have a look at
1577 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1578 and do it again next year ;->
1580 2003-10-13 Jean-Pierre Roux
1581 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1582 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1583 But there are NOT. It's fixed !
1585 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1586 * FIX: "jpeglib.h" was not found on VC++
1587 * FIX: vtkgdcm was not being installed
1589 2003-10-10 Jean-Pierre Roux
1590 * ENH : OpenFile closes the file if it *really* doesn't look like
1591 an ACR-NEMA / DICOM one.
1592 * FIX : testWrite no longer writes an empty file if the source file
1593 is not gdcm Readable
1594 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1597 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1598 * FIX: CMake generate now documentation
1599 * ENH: out of source doc build !
1600 * ENH: Generate both user and dev documentation
1601 * ENH: Should work on windows too
1602 * ENH: Only one doxygen config.in file is needed
1603 * FIX: make install should be ok now on ùnix plateform
1604 * FIX: PATH to dictionary was wrong (missing /)
1605 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1607 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1608 * vtkGdcmReader is now able to read rgb dicom file.
1609 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1610 * added a gdcmViewer to vtk test, use mouse to control
1611 window level & window width
1613 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1614 * CMake-ification of gdcm, we have now two build system
1615 * FIX: on cygwin Wsock32 doesn't exist
1616 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1618 2003-10-06 Emanuel Ollart
1619 * FIX : compilation process wad broken.
1620 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1622 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1623 * change gdcmViewer -> vtkgdcmViewer
1624 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1626 2003-10-06 Jean-Pierre Roux
1627 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1628 ( e.g : well known GE images with a wrong elem length,
1629 : Philips MRI Images with a wrong Huffman table)
1630 * still to be done : allow the reading of bugged LEONARDO Siemens images
1632 2003-10-03 Jean-Pierre Roux
1633 * Odd length strings are padded with '\0' (not with spaces,
1634 to remain compliant with already defined strings,
1635 like Transfert Syntax UID and others)
1637 2003-10-03 Jean-Pierre Roux
1638 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1639 to allow displaying RGB images (not only by affim ;-)
1641 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1642 * vtkGdcmReader is now able to read rgb dicom file.
1643 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1645 2003-10-03 Jean-Pierre Roux
1646 * A few nasty patches to allow the reading of a lot of nasty images
1647 ( e.g : well known GE images with a wrong elem length,
1648 : Philips MRI Images with a wrong Huffman table)
1649 * still to be done : allow the reading of bugged LEONARDO Siemens images
1651 2003-10-03 Jean-Pierre Roux
1652 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1654 2003-10-03 Jean-Pierre Roux
1655 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1656 to allow displaying RGB images (not only by affim ;-)
1658 2003-10-03 Jean-Pierre Roux
1659 * gdcmFile::GetImageDataIntoVector now
1660 - deals with MultiFrames MultiFragments Run Length Encoded files
1661 - deals with YcBcR (YBR_FULL) files
1662 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1663 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1665 (no sample found :-(
1667 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1668 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1669 Two reasons: - clear things
1670 - third parties acces gdcm through header files, so won't
1671 suffer anymore VC++ complains
1673 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1674 * add argv[1] in testvtkGdcmReader.cxx
1677 2003-09-24 Jean-Pierre Roux
1678 * The lines are now eigthy characters long.for
1679 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1681 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1682 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1683 char* to std::string. Thus, the use of strdup becomes useless. (see
1684 previous commis of Malaterre)
1685 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1686 before the last Malaterre's commit.
1688 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1689 * This commit should fix the Debug building under VC++, the problem
1690 was mainly a mixture of debug and release lib being loaded at startup.
1691 * I also remove a depency to a specific C function: strdup. Because I had
1692 to force the link to msvcrtd (whereas strdup is in libc).
1694 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1695 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1696 located in the gdcmCommon.h file. All use of reference of tha has been
1697 changed to now use the variable GDCM_UNFOUND.
1699 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1701 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1702 Dicom dictionary. The test suite can now be run again. Note:
1703 I'm note very happy with the " (RET)" changes. I believe this
1704 RETAINED comment should be dropped when parsing the dictionary.
1705 - PACKAGER corrected
1707 - AUTHORS updated and now in alphabetical order
1708 * Makefile.am now exports gdcm.dsw for Windoze users.
1710 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1711 * cygwin complains about missing std:: in subdir Test/
1713 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1714 * remove some methods that are now in gdcmHeaderHelper
1716 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1717 * vtkGdcmReader set spacing and origin correctly
1719 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1720 * Fix a few delete/delete[] mismatch
1722 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1723 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1724 interpretation to data given by gdcmHeader. For instance there are
1725 heuristics to get informations (look at different places).
1726 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1727 sorting DICOM images based on different strategies.
1728 * modified Makefiles accordingly.
1730 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1731 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1732 when building in debug mode
1733 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1734 src/win32/gdcmdll.dsp
1735 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1737 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1738 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1741 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1742 * src/win32/libgdcmjpeg12.dsp was not dos format
1743 * src/win32/libgdcmjpeg12.dsp :
1744 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1745 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1747 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1748 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1750 * src/gdcmFile.cxx : bug fix in affectation type
1751 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1752 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1753 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1754 symbols... future problem ?
1756 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1757 * src/win32/libgdcmijpeg12.dsp was missing
1758 * modified gdcm.dsw accordingly
1760 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1761 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1763 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1764 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1765 commit of JPR (before his hollidays to facilitate our work).
1766 * setup.py : bug fix in code. Modifications made while the last commit
1767 of JPR. The code hasn't been tested before the commit... it's so
1768 useless to make that (for best programmer that is JPR) !!!
1770 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1771 * tagged the current version as Version0_3 (i.e. version 0.3)
1773 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1774 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1775 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1776 * *.dsp : modifications to use new libgdcmijpeg8 library
1777 * setup.py : bug fix on VTKPATH variable
1778 * PACKAGER : adding all concerning windows
1780 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1781 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1783 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1784 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1785 test suite reported error.
1786 * PACKAGER file added (describes what a packager must do when
1787 packaging a new release).
1788 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1789 * configure.in: upgraded version number to 0.3.0
1790 * fixing build of rpm (through rpm -ta):
1791 - Doc/Makefile.am exports proper doxygen files
1792 - src/jpeg/libijg8/Makefile.am exports the include files.
1794 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1795 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1796 * src/gdcmHeader.h : formatting code
1798 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1799 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1800 We were obtaining error message from vtk. Now, creation of file list
1801 is made in an internal list to prevent this problem.
1802 Bug fix when output is empty.
1803 Bug fix in update of progress value. Previous commit for this was a bad
1805 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1807 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1808 * src/gdcmHeader.h : added method to get the file name
1809 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1810 files. Added method to remove all files on the input
1811 Added FIXME comment concerning the bad parsing of header made by
1812 ExecuteInformation method (in ExecuteData method)
1814 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1815 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1816 when using make instal.
1817 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1818 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1820 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1821 * setup.py : adding include dir of jpeg lib to compile all sources
1822 * */Win32/*.dsp : JPR fix for windows compilation
1824 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1825 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1827 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1828 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1830 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1831 * setup.py is again effective on un*x (takes into account the
1832 addon of the jpeg library)
1833 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1834 * Doc/Doxy* updated (includes above enhancements)
1835 * INSTALL now points to web documentation
1837 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1838 * src/gdcmHeader.h doesn't make unnecessary reference to
1840 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1842 * src/gdcm*.[cxx|h] :
1843 - to allow compilation with gcc 3.x
1844 -- clean up of STL usage (added explicit usage of std::)
1845 -- small fixes on exceptions.
1846 Note: linking not tested !
1847 - clean of doxygen comments to avoid warnings at documentation
1849 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1850 dependent convertion).
1852 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1853 * Clean up of previous JPR garbage commit (not even commented in the
1855 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1856 - moved all jpeg related files from src to src/jpeg/libijg8, with
1857 addition/modification of Makefile.am and configure.in.
1858 - the testSuite is still brain damage (not guilty).
1860 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1861 * WrapVTK.py : modifications to get correctly vtk source files to
1863 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1864 (FileName -> Filename)
1866 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1867 * vtk/vtkGdcmReader.[cxx/h]:
1868 - UpdateProgress method should now be effective
1869 - removed the limitation on having only images loaded (as opposed
1871 - when building a stack of images/volume, a lesser number of
1872 gdcmHeader and gdcmFile instances should be used (hopefully
1873 accelerating things).
1874 - when building a stack of images/volumes, files which are not
1875 loadable (wrong path-filename, wrong permissions on existing file,
1876 or file not parsable by gdcm) are replaced with a black image
1877 in the stack (for the caller to notice the problem).
1879 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1880 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1882 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1883 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1884 between standard library (std) and vtk library (problems are found
1885 under Windows... thanks Windows !)
1887 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1888 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1890 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1892 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1893 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1895 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1896 * When compiling with distutils (see setup.py) the C++ compiler is
1897 called with different flags than the default ones (with automake).
1898 In order to fix all those warning, I compiled gdcm with the command
1899 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1900 and went for warning fixes:
1901 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1902 up from unused variables.
1903 - vtk/vtkGdcmReader.cxx: potential bug fix.
1904 * src/gdcmHeader.h: Doxygen warning cleanup
1906 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1907 * gdcmPython/gdcm.i:
1908 - typemaps correction to take into account the systematic replacement
1909 of "using namespace std" with std:: prefix e.g. std::list,
1910 std::string... (cf changes of 2003-05-21).
1911 - gdcmGlob global variable of type gdcmGlobal (defined in
1912 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1913 exported to Python a as cvar.
1914 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1915 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1916 gdcmDictSet.GetPubDictTagNames() and
1917 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1918 C++ static methods).
1919 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1920 with the above changes.
1922 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1923 * setup.py, manifest.in : bug fix under linux
1925 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1926 * Modification of setup.py to compile vtk part too. Then, we have 2
1927 wrappers which must work with same distutils. For that, we have a
1928 generic distutils in distusiltsWrapping.py ; with :
1929 - build_extWrap class to wrap generically all extensions,
1930 - ExtensionWrap base class for all wrapping extension that contains
1932 - Wrapper interface which wrap sources
1933 + In WrapSwig.py we have extension and wrapper for Swig
1934 + In WrapVTK.py we have extension and wrapper for VTK
1935 * MANIFEST.in : modifications to consider vtk directory and new python
1936 files for compilation
1938 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1939 * Added python wrappers of vtkGdcmReader vtk class (see the
1940 source in vtk/vtkGdcmReader.cxx) :
1941 - vtk/Makefile.am now builds a library
1942 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1943 python library (as opposed to _gdcm.so wich are the python
1944 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1945 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1947 - configure.in has an additional flag --enable-vtk that needs
1948 to be set to enable compilation of vtk related code, that is:
1949 + vtk/vtkGdcmReader.so and
1950 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1951 + gdcmPython/vtkgdcmPython.so (see above)
1952 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1953 be read when compressed or when HighBit + 1 != BitsStored),
1954 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1955 the usage of the python wrapper of vtkGdcmReader vtk class.
1956 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1957 * src/*.[h] all occurences of stl classes are now prefixed with
1958 std::, and all occurences of "using namespace std;" where removed.
1959 This is to avoid pollution of global namespace in included files.
1960 Apparently vtk does not avoid this pitfall: when using both
1961 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1962 collision of various stl members (principally cout...).
1963 * gdcmPython/testSuite.py now cleanly removes temprory generated
1965 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1966 comply with above changes)
1968 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1969 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1970 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1971 vtk data structure (an image Flip was required).
1972 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1973 * cosmetic changes in documentation.
1975 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1976 * src/gdcmHeader.cxx: the constructor no longer exits when an
1977 unexisting file is given as argument.
1978 * The subdirectory Data (containing all the images used for the
1979 test suite) is not part of this repository anymore. A new module
1980 containing those images is now available at
1981 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1982 with the name gdcmData.
1983 All the python scripts (including the package initialisation file
1984 gdcmPython/__init__.py) were adapated to take this change into
1985 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1987 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1988 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1989 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1990 demo of the usage of this class.
1991 Compilation of this vtk part is only done when using the --enable-vtk
1992 at configure (or autogen.sh) stage.
1994 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1995 * More memory link related corrections and documentation fixes.
1997 - maximum info is obtained with a command of the form:
1998 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1999 --show-reachable=yes PrintHeader
2000 - the remaining reachable blocks seem to come from the STL
2001 allocation scheme through the usage of map and list. It looks
2002 like this memory cannot be freed but it is not a memory leak
2003 (in fact further invocation to the STL would recollect the
2004 unused memory allthough it cannot explicitely be freed).
2005 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2006 of displaying an image parsed with gdcm and displayed with VTK.
2007 Note: some images don't seem to work e.g.
2008 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2009 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2010 Allthough this weakens the semantics, it is a ditch attempt to
2011 make gdcm more thread friendly.
2013 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2014 * Memory link hunt (by using valgrind through the command
2015 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2016 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2017 gdcmHeader::_dicom_vr.
2018 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2019 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2021 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2023 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2024 * src/Makefile.am now exports all the necessary include files at
2028 * UpdateGroupLength replaced by new one
2031 * UpdateGroupLength re-written using H-Table
2032 (named UpdateGroupLengthNew untill checks are over)
2034 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2035 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2036 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2038 - gdcmHeader::GetPubElValSet removed.
2039 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2040 UpdateGroupLength, WriteElements, Write.
2041 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2042 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2043 carried the same semantics.
2044 - src/gdcmHeaderIdo.cxx changed accordingly.
2045 - gdcmFile::WriteBase now regroups all the codes from previous
2046 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2047 - enum FileType moved to gdcmCommon.h
2048 * src/gdcmHeader.cxx AddDefault trashed
2049 * gdcmGetXSize added
2050 * getimageDataSize now calls gdcmGetXSize
2051 * Test/*.cxx changed to agree with above changes
2053 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2054 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2055 (to avoid double call by end user).
2056 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2057 by end user, since gdcmHeader::gdcmHeader now handles it.
2059 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2060 * gdcm/Doc many doxygen changes:
2061 - Doxyfile now has two different versions, DoxyfileUsers that generates
2062 the html.users end users oriented documentation and
2063 DoxyfileDeveloppers that generates the html.developper developper
2064 oriented documentation.
2065 - README changed accordingly
2066 - requirement.txt removed (old design info moved to TODO).
2067 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2068 DoxyMainPage.txt, DoxyPython.txt provide more information.
2069 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2070 be updated by simply regenerating the docs with doxygen and copying
2071 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2072 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2073 all the tests in the form "if (<map>.count() >1)" were removed.
2074 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2075 ill-formed documentation sections.
2076 * src/gdcmHeader.cxx: ditto
2078 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2079 * setup.py fixed for un*x (needed macro for stdint.h)
2080 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2081 un*ces with sh-utils test utility.
2082 * gdcmPython/demo/test.py renamed to PrintHeader.py
2083 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2084 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2085 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2086 * src/gdcm*.cxx JPR's bad inclusion fixed.
2088 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2089 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2090 * gdcmPython/demo/test.py changed accordingly.
2092 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2093 * gdcmPython/Makefile.am fixed linking against libstdc++
2094 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2095 * Swig subdir (historical tests of swig version 1.3.17++) removed
2096 * Test/testChangeEntete.cxx some lines commented out in order to make
2098 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2099 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2101 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2102 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2103 hence the user doesn't need this explicit call.
2104 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2105 i.e. LoadElements() call removed.
2106 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2107 - src/Makefile.am declares the proper flag for g++.
2108 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2109 for adding user defined new tags.
2110 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2111 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2112 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2114 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2115 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2116 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2117 src/Makefile.am : the project should properly compile and install
2118 with the autotools, included the python wrappers part.
2119 * gdcm.spec.in : added a spec file for RPM packaging.
2121 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2122 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2124 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2125 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2126 to exported to the environement (see gdcmPython/testSuite.py
2128 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2129 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2130 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2131 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2132 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2134 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2135 * gdcmPython/__init__.py doesn't crash anymore when running in
2136 in InstallMode or PreInstallMode but with an environement given
2137 value of GDCM_DICT_PATH.
2138 * src/gdcmDictSet.[cxx/h] coding style.
2140 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2141 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2142 * src/gdcm.h general comments moved to TODO, and README
2143 * src/gdcm.h should now be seen as a user commodity (including it
2144 should suffice to fully use gdcm). It is nowhere including within
2145 any of the kernel files src/*.cxx and src/*.h.
2147 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2148 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2149 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2151 * src/gdcm*.cxx only include their corresponding include file
2152 (as opposed to gdcm.h)
2153 * gdcmPython/gdcm.i changed accordingly
2154 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2155 the autogen.sh generated "make snapshot" command to work.
2156 * autogen.sh removed history related references to crea package.
2158 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2159 * distutilsSwigCPlusPlus.py work around some swig portability
2162 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2163 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2164 was done in a last ditch attempt to get setup.py _really_
2165 operationnal. The python/gdcmPython layaout add the advantage
2166 of hidding away the python related distutils specific files
2167 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2168 Alas, the src directory was out of scope (i.e. it's relative
2169 position to setup.py was ../src) which made things impossible to
2170 handle (see previous version of python/setup.py). Crossing fingers...
2172 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2173 * python/setup.py now works on Un*x. (harder than I thougth)
2174 * python/distutilsSwigCPlusPlus.py can now have include files
2175 among the list of sources.
2177 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2178 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2179 * modifications in MSVC projects
2181 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2182 * As stated by the first lines of Test/ExceptionAndPython/README, it
2183 looks like we can move back to original usage of exception within
2184 src/gdcm* and hence remove the errno stuff that was introduced
2185 as a quick and dirty fixture of this problem (added to the TODO).
2186 * Doc/Doxyfile configuration file for Doxygen and corresponding
2187 README file for usage added.
2188 * Test/testWrite.cxx added. This new test comes from a split of
2189 test.cxx that is now reverted to its original purpous i.e.
2190 testing the proper parsing of a Dicom related file.
2191 testWrite.cxx concentrates on testing the IO part of gdcm.
2192 * Test/bug1.cxx (containing a bug on WIn32) added.
2193 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2194 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2195 whose purpose is to publish the content of the TagNames of the
2196 Dicom public dictionnary were not accessible without an
2197 instance of class gdcmHeader.
2198 - those methods are now static methods of gdcmDictSet and hence
2199 require no instances at all to be invocated.
2200 - within gdcmDictSet this change required to change some method
2201 to class methods (i.e. are now static) among which SetDictPath
2202 (renamed to BuildDictPath) and LoadDefaultPubDict.
2203 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2204 the above changes by calling the new method classes of gdcmDictSet.
2205 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2206 the above to be effective.
2207 * python/gdcmPython: in order to wrap properly the above changes
2208 for Python, swig version now needs to be > 1.3.17.
2209 * python/gdcmPython/Makefile fixed to adapt itself to new
2210 configure/make shema introduced by Johan Montagnat (thanks for the
2211 contribution). Alas this Makefile cannot be turned into a proper
2212 Makefile.am without some heavy changes in the configure.in
2213 (for python dectection).
2214 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2215 now avoids publishing the empty entries.
2217 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2218 * python/setup.py : bug fix concerning install under windows
2219 ExtraPath reused :-P
2220 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2222 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2223 * Dicts/dicomV3.dic : remove double spaces !!!
2224 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2225 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2228 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2229 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2230 method. Doxygenation.
2231 * src/gdcm.h clean up of JPR spurious comments.
2233 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2234 * python/distutilsSwigCPlusPlus.py now properly collects the
2235 shadow classes generated by "swig -c++" (gdcm.py in our case)
2236 when using "python setup.py install".
2237 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2238 reexports the working classes.
2239 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2240 by the classical C errno scheme. This is to prevent an obscure
2241 behavior of the python wrappers when importing wxPython.wx prior
2242 to gdcmPython (which ended up in an abort call). An illustration
2243 of this oddity can be found in the Test/ExceptionAndPython
2244 subdir (see the README file). This problem probably due to
2245 an combination of g++ and dynamic loading.
2246 * added Test/ExceptionAndPython (see above)
2248 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2249 * Changed the layout of the python part to avoid bloating main
2250 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2251 i.e. the distutils arsenal. All the python related stuff is
2252 again in a python subdir, but the package itself is now in
2254 * setup.py was cleaned up:
2255 - pythonIncludePath removed
2256 - python setup.py bdist target is now functional.
2257 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2258 collision with other packages). gdcmPython/demo/*.py changed
2261 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2262 * python subdir moved to gdcmPython (preparation of distutils packaging).
2263 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2264 distutils installer is operational.
2265 * - gdcmPython/__init__.py now properly loads the swig generated
2266 shadow classes (from gdcm.py).
2267 - gdcmPython/demo/*.py changed to import the package gdcmPython
2268 instead of gdcmPython/demo/load.py.
2269 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2271 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2272 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2273 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2274 entries within the associated public Dicom dictionary resp. the same
2275 information but sorted by the fourth field (PAT, IMG, DIR) of the
2277 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2278 are now in the "???" group.
2279 - python/gdcm.i changed accordingly,
2280 - python/demo/printGroupedPublicDict.py added, that gives an example
2281 of the above new functionalities in Python.
2283 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2284 * src/gdcm.h, gdcmHeader.cxx:
2285 - historic references to glib's g_malloc and g_free (#defined)
2286 were definitively removed.
2287 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2288 * src/gdcmElValSet.cxx:
2289 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2290 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2291 - GetElValue(string) renamed to GetElValueByName.
2292 - Added GetElementByName(string).
2293 * src/gdcmHeader.cxx: added
2294 - GetPubElValRepByNumber(guint16, guint16)
2295 - GetPubElValRepByName(string)
2296 - GetShaElValRepByNumber(guint16, guint16)
2297 - GetShaElValRepByName(string)
2298 - GetShaElValByNumber(guint16, guint16)
2299 - GetShaElValRepByName(string)
2300 - GetElValRepByNumber(guint16, guint16)
2301 - GetElValRepByName(string)
2302 - GetElValByNumber(guint16, guint16)
2303 - GetElValRepByName(string)
2304 * Doc/requirements.txt added.
2306 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2307 * Test/Makefile building now depends on the one of libgdcm.so
2308 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2309 pixel data) aware which enables finding the address (offset) of
2310 the pixel data of JPEG encoded DICOM files. This leaves only a single
2311 file in the testSuite whose pixel data address (offset) is unknown.
2312 * python/testSuite.py changed accordingly.
2314 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2315 * VC++ has some strong limitations when working with the STL, as stated
2316 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2317 "Also note that some STL containers (map, set, queue, list, deque)
2318 cannot be exported. [...]
2319 Some STL classes contain nested classes. These classes can not
2321 This is caused by a designed limitation that once a template
2322 class is instantiated, it can not be re-instantiated and
2324 Since our usage of map<> is ubiquitous in gdcm, this "designed
2325 limitation" of VC++ is a pitfall.
2326 Hence the Python wrappers of gdcm cannot be incrementally linked
2327 against the c++ dynamic library. The dirty but only workaround is
2328 to forget about incremental link of dynamic libraries and to generate
2329 the Python wrappers library with the inclusions of the underlying C++
2331 The following modifications concern this matter on Win32/VC++:
2332 - wrapping python correct with standalone wrapped dll (don't use separate
2333 dll under windows !!!!)
2334 - python21_d debug mode enabled (ask Frog how to use it :-)
2335 - NO problem with having an STL member of class for example string in C++
2336 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2337 - Python test of dcmlib in Python is ok under windows on a large set
2339 * removed glib references
2340 * typedef's inserted in gdcm.i for correct swig type management
2342 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2343 * python/demo/*.py load.py extracted from test.py. Added explore.py
2344 that only displays required tags and testAll.py that parses all
2345 the files of the testsuite without using unittest.
2346 * python/testSuite.py other additional test on new files added.
2347 * Data/* new test files added accordingly to the testSuite.
2348 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2349 the vr in the file differs from the one of the dictionary.
2351 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2352 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2353 values, but limits itself to values which are below a user specified
2354 size (by default 1024 bytes).
2355 * python/gdcm.i : elements not loaded (because their size is above the
2356 user specified treshold) are exported with their TagKey as key of the
2357 python dictionary. This enables the testsuite to make some checks
2358 on the unloaded elements (since we have their offset and size).
2359 * python/testSuite.py
2360 - now tests for the existence and proper value of the pixel data
2361 - two new examples added.
2362 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2364 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2365 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2366 aware. See the strategy comments in gdcmHeader::FindeLength().
2367 * Test/test.cxx now accepts a filename as first argument.
2368 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2369 * python/testSuite.py changed to integrate test on above files.
2371 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2372 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2373 the vr was also RET.
2374 * python/testSuite.py more tests added.
2376 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2377 * python/testSuite.py unittest test suite added (uses Data)
2378 * Data/* dcm and acr files for the test suite.
2379 * glib dependance removed from un*x version. We now use ISO C99
2380 7.18 Integer types (see stdint.h)
2381 - python/Makefile, src/Makefile src/gdcm.h
2382 * src/ when an explicit vr (like dicom files) suddenly poped an
2383 implicit element we use to mark the underlying DictEntry of the
2384 concerned ElValue with "Implicit". This strategy was damageable
2385 too the public or provite dictionaries, since some of their vr
2386 would be changed. Since Header::FindLength heavily relies on the
2387 detection by Header::FindVR of falsely explicit elements, I
2388 added an extra ImplicitVr member to ElValue (boolean).
2389 The rest of the changes we the necessary adaptations.
2391 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2392 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2394 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2396 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2397 * Adaptation for porting to VC++:
2399 o forced to use std namespace (for string to be known)
2400 o all class use __declspec export style on WIN32
2401 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2402 (in stdlib.h on Win32 but in std:: for gcc)
2403 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2404 variable GDCM_DICT_PATH.
2405 * src/gdcmHeader.cxx verbose comments made discrete.
2407 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2408 * python/gdcm.i: added a typemap that converts a C++ hashing table
2409 to native Python dictionary.
2410 * python/demo/test.py:
2411 - now uses the native dictionary for exploration of gdcmHeader.
2412 - takes an optional filename argument (the file to parse).
2413 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2414 PubElVals hashing table.
2415 * Dicts/dicomV3.dic removed error prone trailing spaces.
2417 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2418 * Python wrapping process moved away from src/Makefile to
2419 newly created python/Makefile (as well as gdcm.i)
2420 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2421 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2422 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2423 from the environement variable GDCM_DICT_PATH (when existing).
2424 * src/gdcmDict::GetTag bug fix.
2426 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2427 * Straightforward temporary fixes for swig to build the python wrappers.
2428 src/Makefile now has a python working entry [by working we mean
2429 that we can import de shadow classes without errors].
2431 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2432 * hashtest.cxx removed (since allready in Test)
2433 * src/gdcmlib.h renamed to src/gdcm.h
2434 * src/dcm.i renamed to src/gdcm.i
2435 * src/Makefile prepared for python wrapping
2437 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2438 * src/gdcmHeader.cxx :
2439 - Parsing of header is now separated from loading of element values
2440 (see gdcmHeader::LoadElements).
2441 - general clean up of hopefully all file access (creation of
2442 ReadInt16 and ReadInt32)
2444 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2445 * src/gdcmHeader.cxx :
2446 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2448 - SetLgrElem renamed to SetLength
2449 - GetLgrElem renamed to GetLength
2450 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2451 * src/gdcmElValSet.cxx fixed both GetElValue methods
2452 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2453 due to IdoDude was cleaned out.
2455 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2456 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2457 concentrates on finding the value representation (when it exists).
2458 RecupLgr now only finds the element value length, and it avoids
2459 returning the unecessary skL (skipped length).
2460 Also, offsetCourant was simply removed (with taille_fich) since
2461 it was redundant with the File position internals (by using
2462 ftell and fseek). This also made skL (see above in RecupLgr) usage
2464 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2465 on the libido specificities which are handled through class
2467 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2470 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2471 * Truckload of changes. Parsing of header is barely functional
2472 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2474 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2475 * src/gdcmHeader.cxx many addons of low level methods
2477 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2478 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2479 and _IdDcmSWAP_LONG.
2481 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2482 * This corresponds to all the changes decided at the meeting of
2483 May 23 2002. Needless to say we are running late...