1 2005-06-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Adding potential support for JPEG-LS DICOM files.
4 2005-05-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
5 * Adding potential support for mpeg and jpeg2000 through two new lin
7 - libmpeg2 from the MPEG consortium
8 Also adding intial work to use this lib.
10 2005-04-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * Testing/TestAllReadCompareDicom.cxx : update the test printed results and
14 2005-04-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
15 * FIX : Numerical exception on borland (cannot divide by 0, doh !)
16 But this is a case where we should really signify the user there is
17 few chance the serie is really a serie...
19 2005-04-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * FIX : on X, the python part is correctly installed. All files are
21 installed in gdcm sub-directory
23 2005-04-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * Builder/ : add something to facilitate the RPM creation of gdcm
26 2005-04-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
27 * Fix gdcmDirList::IsDirectory. Apparently borland did not like the ending
29 * Also fix compilation on gcc 3.3.5 does not have ios::failure either ...
31 2005-04-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
32 * vtk/vtkGdcmWriter fix bug when writing spacing. The Y spacing comes first
34 * Fix compilation on gcc 2.96 (which does not have ios::failure)
36 2005-04-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
37 * src/gdcmDictGroupName.[h|cxx] : add a correlation between a group (number)
38 and it's representation name (for the NIH)
40 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
41 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
42 conversion of YBR to RGB pixels. So, now, the conversion is made using
45 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
46 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
47 format) to replace 'at-run' dicom files generated by the
48 TestAllReadCompareDicom test
50 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
51 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
53 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
54 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
56 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
57 * Testing/TestMAkeIcon.cxx : complete the test
59 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memroy leaks
62 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
63 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
66 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
67 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
69 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * Test/ : accelerate tests (it's not very significant accelerations).
71 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
73 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
74 * Testing/TestSequence.cxx : add test for sequences of images... test that
75 we have the same serie or the same study UID
77 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
78 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
80 * src/gdcmDict.h : remove commented code
81 * src/gdcmDocument.cxx : initialize values
82 * src/gdcmFile.cxx : bug fix when reading values
83 * gdcmPython/demo/ : change file names. Remove useless files
85 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
86 * src/gdcmFile.cxx : remove the default array of initialization.
87 The static array contained pointers to non-static values (comming from
88 strings). To have coherences, when creating files, these values can't be
89 static. So, the array can't be static, too ! To simplify, the array have
90 been replaced by repeted lines to insert values in the File
92 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
93 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
94 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
96 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
97 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
98 (Dicom Element) into the Sequence Item
100 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
101 * src/*.cxx : first parss to normalize file organisation
103 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
104 * src/gdcmDirList.[h|cxx] : add method to find a directory
105 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
107 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
108 * Finish cleaning up my JPEG mess. Should be ok now.
109 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
110 contained within the RLE* class(doh!)
112 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
113 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
114 * SerieHeader::AddFileName() creates as many Coherent Files lists
115 (same Serie UID) as it founds different Serie UID
116 amongst the files instead of discarting any file
117 that doesn't match with the first one he found.
118 * SerieHeader::OrderGdcmFileList has now one parameter :
119 the Coherent Files list the user wants to sort
120 * SerieHeader::GetFirstCoherentFileList() |
121 * SerieHeader::GetLastCoherentFileList() | allow to parse
122 the set of Coherent Files lists
123 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
124 compatibility (it returns the *first* Coherent Files list,
125 since there was only one before)
126 * Test/TestSerieHeader gets gdcmData as a default root directory
128 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
129 * Remove friend between DocEntry and File classes
130 * Remove friend between PixelReadConverter and RLEFramesInfo,
133 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
134 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
135 0002|0000. The value was incorrect.
137 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
138 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
140 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
141 * src/gdcmUtil.cxx : compilation fix on Win32
142 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
143 variable, to be easy found. Add methods to change the default UID.
144 Amelioration of the CreateUniqueUID to use the correct default UID.
145 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
148 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
149 * Test/TestVR.cxx : fix memory leaks
151 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
152 * Rewrite the base 256 to base 10 conversion, using string operation only.
153 This allows us to get rid of the problematic 64bits integer type (does not
154 always exist on target platform).
156 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
157 * Add construct and destructor to class gdcm::Debug to close the debug file
159 * Don't let uset to open twice the same file
160 * gdcm has now an official UID prefix,
161 supplied by http://www.medicalconnections.co.uk
162 1.2.826.0.1.3680043.2.1143
163 (Thx to Mathieu for providing URL)
164 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
165 to be able to perform some more tests
166 * gdcm::ContentEntry : Contructors and Destructor are now protected,
167 in order to be sure no user will try to use them.
168 (at user level, only the children classes are meaningfull)
170 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
171 * move RLEInfo & JPEGInfo from Document to File
173 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
174 * FIX : remove so many friend between classes
176 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
177 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
178 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
180 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
181 In order to avoid missbehaviour :
182 . gdcm::DocEntry is now specialized in
183 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
184 - gdcm::ContentEntry (Dicom entry with a 'content')
185 . gdcm::ContentEntry is specialized in
186 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
187 characters value, or integers)
188 - gdcm::BinEntry (Dicom entry with a non strig representable value
189 (user hasn't any longer to thing about the precedence of his dynamic_casts)
191 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
192 * Test/VTKTest*.cxx : bug fix under linux
194 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
195 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
196 use with python. Some methods are moved from Document to ElementSet or
197 DocEntrySet. The equivalent methods to ElementSet have been added to
198 SQItem and are virtual in DocEntrySet. Methods that may have the same code
199 in SQItem and ElementSet is directly placed in DocEntrySet
201 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
202 * Test/VTKTest*.cxx : remove the show variable in each test method because
203 it's useless (the viewer variable replace this variable)
205 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
206 * src/gdcmDocument.cxx : bug fix on potential memory leak
207 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
208 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
209 Add ClearXxx methods to remove all the content of the list or map
210 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
212 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
213 * methods ReplaceOrCreate renamed as Insert
214 (nobody will be any longer confused by 'CreateOrReplace')
216 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
217 * Grealty simplify the JPEg decompression, no need to differenciate based on
218 the JPEG possible type (with/without fragment, with/without multiple frame).
219 Everything is done throught the JPEG IO Suspension mechanism in IJG
221 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
222 * Stage 3 of normalization :
223 in order to avoid any missunderstanding while reading method names :
224 - All the methods xxxEntry now deal with dicom Entries
225 - Methods GetEntry splitted into
228 - Method SetEntry renamed as SetEntryValue
229 - Method SetEntryBinArea let as it was
231 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
232 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
233 - Position correctly the entry points for JPEG2000 and JPEG-LS
234 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
236 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
237 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
238 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
239 with other method names
240 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
241 * Test/TestDicomDirElement.cxx : add new test
243 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
244 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
245 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
246 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
247 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
248 So can't you use __int64 in ostream at all.
250 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
251 * bug fix for compilation on MSVC6
252 * gdcmPython/gdcm.i : rename of classes missed
254 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
255 * Stage 2 of names normalization :
256 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
257 (easy to understand ...)
258 - gdcm::FileHelper replaces old class gdcm::File
260 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
261 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
262 type and not a string. So, there remove problems on the format of the
265 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
266 * Add Example/TestPapyrus.cxx
267 - reads a Papyrus file (gdcm::Header compliant),
268 - gets the pixels of all the images, using low level iterators
269 - writes an multiframes Dicom image.
270 (Just to show it's *possible* to do that)
271 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
274 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
275 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
276 Thus, DicomDirXXX are created with a flad that indicates if the created
277 object is empty or not (when not empty, the DicomDirElement is used to
280 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
281 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
282 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
284 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
285 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
287 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
288 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
289 Remove all access to the hash-tables or lists in the objects.
291 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
292 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
293 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
294 be complient with all the gdcm source code
296 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
297 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
300 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
301 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
304 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
305 * Test/ : rename VTK tests to have a best name for the tests
306 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
307 GetFirstEntry/GetNextEntry use
309 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
310 * In SerieHeader::ImagePositionPatientOrdering()
311 // a Dicom 'Serie' may contain scout views
312 // and images may have differents directions.
313 // -> More than one may have the same 'pos'
314 // Sorting has then NO meaning !
315 Thx to Eduardo Davila for reporting bug.
317 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
318 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
319 test. Now it's on image content and not on the resulting visualisation...
320 might solve the problem on linux when using the OpenGL drivers
322 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
323 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
324 DicomDirSerie, DicomDirImage
325 Dict, DictSet classes :
326 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
327 -remove InitTraversal method.
328 * UPD Test programs + Example programs
330 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
331 * remove useless and never updated keyword \ingroup
332 * Solve pb when structure (list, map, ...) is empty.
333 Thx to Benoit for reporting bug
335 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
336 * Taking into account of 'Transfer Syntax' value
337 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
340 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
341 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
342 is no memory access violation
343 * gdcmPython/demo : add python demos using VTK
345 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
346 * FIX 'Dictionnary' is now spelt 'Dictionary'
347 'wether' is now spelt 'whether'
348 'archieve' is now spelt 'archive' ;-)
350 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
351 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
352 related methods, in order not to expose internal mechanisms
355 * REM methods that exposed internal mechanisms :
356 DicomDir::GetDicomDirPatients()
357 DicomDirPatient::GetDicomDirStudies()
358 DicomDirStudy::GetDicomDirSeries()
359 DicomDirSerie::GetDicomDirImages()
360 * UPD Test programs :
364 * UPD Example program
366 * ADD DictSet methods
370 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
371 * Removed the Print/indent/default parameter mess. There is absolutely no
372 reason to have to methods, moreover with the second taking the ostream as
373 *SECOND* parameter. This was clearly a bad hack to get things compile.
375 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
376 * Complete rewrite of the GetMacAddress code. Now the code is *much*
377 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
378 Unfortunately the main code does not work on SunOS, thus provide a specific
379 code for this platform only (and Win32 of course). Since this seems to be
380 working, change CreateUniqueUID to use GetMACAddress instead of the
381 problematic GctestetIPAddress
383 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
384 * Unfortunately to be able to test gdcmDirList I had to break the API
385 a little. Now the class is not a std::list anymore but has a member
386 std::vector (more ITK compatible). Allow unit testing on Win32 and
389 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
390 * Update SerieHeader to take into account a Serie Instance UID to properly
393 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
394 * ENH - Comment out Mathieu's (dangerous) Super Hack
395 for dealing with BIGENDIAN processors
396 - Move equivalent stuff to BinEntry::WriteContent
397 When necessary, 16 Bits Pixels are swapped in a small buffer
398 and then written. This avoid allocating a huge buffer, in
399 PixelWriteConvertor, and avoid modifying the Pixel Area.
401 Probabely, the same operation will have to be done when we want
402 to write image with Big Endian Transfert Syntax,
403 and we are working on Little Endian Processor
405 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
406 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
408 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
409 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
410 all the dict content.
411 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
413 * Test/TestDict.cxx : add a new test for the dict classes
415 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
416 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
417 file. Debug is yanked if compiled with NDEBUG
419 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
420 * src/gdcmDictSet.h : set the default output to the os variable
421 * src/gdcmDictEntry.[h|cxx] : add the Print method
422 * gdcmPython/demo/ : add a new test
424 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
425 * merging of Test/PrintDicomDir and Test/TestDicomDir
426 * removal of now redundant Test/PrintDicomDir
427 * enhancement of Example/PrintDicomDir
429 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
430 * Now, python test might work on systems
431 * Add the PrintDicomDir test
433 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
434 * FIX : First entry following group 0002 was lost for
435 Explicit Big Endian Transfer Syntax files
436 (group and elem not swaped)
438 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
439 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
440 Big Endian Transfer Syntax supposed the group following 0002
441 begins always by element 0000 (element 0000 is *optional*)
442 To avoid further troubles, let's be pessimistic, and use
443 Document::HandleOutOfGroup0002() method
444 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
445 (related pb not yet solved)
447 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
448 * Bug fix for the python part use
449 * Now, PrintHeader.py pass... but outside the ctest use. shit !
451 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
452 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
454 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
455 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
456 a string and should ask the global TS dict what are the propreties of
459 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
460 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
461 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
462 to swap the Swap Code, at parsing time, when we come out of group 0002
463 and Transfer Syntax is Big Endian
464 We should be able to read now 'true DICOM" Big Endian coded images
465 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
466 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
468 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
469 * Hopefully fix the bug on MacOSX and static global initialization.
470 This is the only -minor- patch I found that both please MacOSX and VS6.
471 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
472 but this would require a lot of change. Another approach would be that Global
473 create those string and GDCM_UNFOUND becomes a pointer to a string (which
474 gdcm::Global would destroy at exit).
476 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
477 * Fix bug on MacOSX with static initialization in a multy threaded
478 environment. static const string in a header file used to be ill
479 initialized provoquing the freeze of any tests. patch should solve this
482 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
483 * According to Benoit's suggestion, and without any objection from anybody
484 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
485 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
486 - method gdcmDicomDirObject::GetEntry() renamed as
487 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
489 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
490 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
491 you debug/warning message just as c++ streams which make them very convinient
492 to use. Once this is stabilize I will change the ostringstrem to be
493 redirected to a file (ofstream).
494 * Properly support C99 extension: __FUNCTION__ which allow us to display
495 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
497 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
498 * Removal of useless and dangerous methods :
499 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
500 GetDocEntryByName, GetEntryByName, GetDictEntryByName
501 * Removal of usless methods :
502 Dict::PrintByName, Dict::GetDictEntryByName
503 * Commenting out of probabely useless methods :
504 Dict::GetDictEntryNames()
505 Dict::GetDictEntryNamesByCategory()
506 DictSet::GetPubDictEntryNames()
507 DictSet::GetPubDictEntryNamesByCategory()
508 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
509 * ENH : Use dicomTS.dic as described in 2004 version
510 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
511 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
512 Add Accessors on VM (Value Multiplicity), and VM related methods
513 * ADD : Add a list of 'Dicom Attribute types', as found in
514 http://medical.nema.org/dicom/2004/04_15PU.PDF
516 * ADD : Add dicomGroupNameAbbreviations.dic
517 should be used to write a method to replace the former
518 Dict::GetDictEntryNamesByCategory()
520 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
521 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
522 to read in the file... and only it ! Length is the efective length of the
523 data in the DocEntry structure
525 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
526 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
527 And now use a static function call instead, with a global variable. i
528 This is much closer to the VTK approach. Hopefully should be bulletproof
529 and easier to use...hopefully
531 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
532 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
534 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
535 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
537 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
538 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
539 ValEntry, BinEntry, SeqEntry creation or replace
541 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
542 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
543 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
545 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
546 when specifying the VR
547 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
548 * src/gdcmDocEntry.cxx : amelioration of print
550 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
551 * ADD : Add the method Util::IsCurrentProcessorBigEndian
552 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
553 * ADD Method Document::ComputeGroupLength
554 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
555 in order to allow further VR modification by user
556 * REM : removal of once-called method File::WriteBase
557 integration of its code in formerly one-line method File::Write
559 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
560 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
561 replace the different values "??", "Unkn", "Unknown".
562 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
563 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
564 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
565 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
567 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
568 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
570 * Set the gdcm::Base class to some Printable classes
572 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
573 * src/gdcmFile.[h|cxx] : add the Print method
574 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
575 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
576 * src/gdcmDocument.h : remove the PrintLevel informations
577 * Example/PrintFile.cxx : use the new gdcm::File::Print
579 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
580 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
581 problems when compiling with the python wrapping
583 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
584 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
585 writting in ImplicitVR
587 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
588 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
589 JPEG decompression, especially when dicom frames are split into several
590 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
591 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
593 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
594 * src/gdcmHeader.cxx : change the initialisation of default header.
595 Now, this header is readable by gdm, e-film, DicomWorks
597 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
598 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
599 Rename Decompressed to Raw
600 * Use the API changes in gdcm::File.
601 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
604 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
605 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
606 each added entry in the header. Replace the 'Planes' field by the 'Number
609 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
610 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
611 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
613 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
614 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
615 At this time, this image isn't readable by e-film... waiting JPR help to
618 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
619 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
620 DocEntry. Now use methods of the Document !
622 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
623 * Test/ShowDicomSeq.cxx : bug fix
625 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
626 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
627 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
628 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
629 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
631 * Test/TestCopyRescaleDicom.cxx : remove unused variable
632 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
633 containing found sequences
635 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
636 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
638 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
639 Some fields in BinEntry must be copied to not seg fault when making the :
640 gdcm::File *copy = new gdcm::File( copyH );
641 and tests are now made on good variables
643 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
644 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
645 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
647 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
648 * Add vtkGdcmWriter example and test
650 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
651 * Test/TestUtil.cxx : reformat the source code
652 * vtk/vtkGdcmReader.cxx : remove and change prints
653 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
655 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
656 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
658 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
659 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
660 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
662 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
663 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
664 by an eof to prevent all bad read of the file... and in this case, the
667 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
668 * Example/Volume2Dicom.cxx : comment unused variables
669 * Test/PrintDicomDir.cxx : comment unused variables
670 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
671 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
672 method that is redondant with AddEntry.
673 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
676 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
677 * Bug fix due my last commit (compilation under Windows).
678 * Example/Volume2Dicom : bug fix in the file and reformatting source code
679 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
681 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
683 - Remove printf / sprintf
684 - include iostream AFTER gdcm so we don't get warnings
685 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
687 - Also remove tons of include from header files, hopefully this should
688 speeup the compilation time, since it was becoming a dog slow.
689 - Remove gdcm.h as it include way too many files and slow down compilation
690 (plus it is not up to date)
691 - remove 'using namespace std' this is BAD !
693 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
694 * Remove memory leaks on the DicomDir
695 * Remove some useless data in DicomDirObject
696 * Add usefull methods in SQItem, to be complient withe the ElementSet
698 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
699 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
701 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
702 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
703 future, with convertion)
704 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
705 and ImageDataSize values. Remove the method to get the PixelReadConverter
706 from the output of the class
708 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
709 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
711 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
712 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
713 and vtkErrorMacro use.
714 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
716 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
717 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
719 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
720 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
721 The string leaves only in the fonction. So when we make a .c_str(), we
722 get the pointeur on the first element, element that will be destroyed
723 immediately after thee instruction.
724 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
725 file has been opened : the test must be made on the content of the
726 pointer and not directly on the pointer !
729 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
730 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
731 the python part recompiles
733 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
734 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
735 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
736 X session is killed (for my computer... it seems to not be identic on
739 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
740 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
741 avoid problems (otherwise, the difference test between the visible image
742 and the reference is incorrect. If the reference is greater than the
743 screen resolution, it's produce errors).
744 Can be used for only one image. Can be used with a visible flag.
745 * vtk/vtkGdcmReader.cxx : remove commented codes.
746 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
747 under windows at compilation
748 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
750 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
752 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
753 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
754 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
755 tests on the image size X, Y, Z
757 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
758 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
759 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
760 between the class name and the file name
762 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
763 * src/ : fix compilation warnings for the Write method (2 different
764 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
765 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
766 variable... create a static method in gdcm::Document to access to
767 this variable content.
769 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
770 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
771 file, to be accessed by other files (like gdcmFile). Remove commented
772 code. Move the change of the header to the gdcmFile, using the
774 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
775 To be sure of that (and simplify calls), the Write of the header now
776 gets a file name and not a file pointer (std::ifstream).
777 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
778 DocEntryArchive. Remove all open of the written file
780 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
781 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
783 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
784 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
785 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
787 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
788 some corresponding methods. Write correctly the file and check before
790 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
791 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
792 is now on RGB data (as before my last commit
793 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
795 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
796 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
797 Add a print information of the type of the entry
798 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
799 It was in the gdcmFile, and all write have been regrouped
800 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
801 Write correctly all dicom files (in decompressed mode only at this time)
802 * Test/ : test on files are now made using Raw data and not color data if
804 * Example/PrintFile.cxx : add more printings
806 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
807 * Amelioration of code, remove some code copy. For the loading of
808 BinEntry (in gdcmDocument), add the test to verify if the file is already
811 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
812 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
813 remove a DocEntry in the header (push an empty DocEntry)
814 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
815 lines. Bug fix in the initialization of the PixelConvert and the
817 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
818 use in TestCopyDicom (now this test can run under windows... but fails)
819 * Test/TestCopyDicom.cxx : amelioration of the test :
820 - test the pixels written
821 - add test points to quickly find where is the error
822 - can set a file name input and output in arguments
823 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
824 amelioration of the test output
826 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
827 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
828 all replaced DocEntry's
829 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
830 Now, each needed DocEntry to modify is duplicated, modified and inserted
831 to the header using DocEntryArchive. Thus, after save, we can restore the
832 header initial state.
834 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
835 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
837 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
838 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
839 correct to copy it. The DictEntry is specified at the DocEntry creation,
840 then, it musn't change in the time.
841 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
842 header correctly. At this time, the change is only made for the first
843 level of the Document. In the future, it might consider sequences.
844 The change is made by replacing a DocEntry by an other that is created
845 outside the class. The old value is kept. When we restore the header
846 status, the added DocEntry is deleted and replaced by the old value.
847 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
848 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
849 set the write type to explicit VR, implicit VR or ACR. Add methods to set
850 the write mode to native, decompressed or RGB (but not used at this time)
852 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
853 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
854 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
856 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
857 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
858 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
860 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
861 set because already copied when copying the BinEntry's of the header
862 * Test/TestAllReadCompareDicom.cxx : remove warnings
864 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
865 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
866 Two problems appear when doing it :
867 - with the gdcmFile : when the GetImageData method is called, the pixels
868 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
869 data (pixels). And each structure destruct the data when it's
870 destructed. So we have two destructions for the same data. To solve it,
871 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
872 data or not. If it doesn't own data, then they will not destroyed by
874 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
875 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
876 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
877 create a double destruction of the same DocEntry's. So, to solve it,
878 the TagHT is simply cleared and the DicomDir* elements are destroyed.
879 * TODO : add an entry concerning memory leaks in the DicomDir
881 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
882 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
883 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
886 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
887 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
888 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
889 after it have been deleted
891 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
892 * FIX: src/* fix the doxygen warnings.
893 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
894 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
895 was erroneously defined with a size of 15 instead of 16. [many thanks
896 to Jean Michel Rouet for pointing out this bug].
898 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
899 1. Finish merging JMR patch for writting DICOM from scratch
900 2. Fix -hopefully- bug with MONOCHROME and space vs null character
901 3. Use const ref when possible
902 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
903 5. A few more comments
904 6. CreateUniqueUID can now be called without parameter"
906 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
907 * ENH: Slightly bigger patch:
908 1. Getting toward full integration of JMR patch for writting dicom from scratch
909 2. Update Test to test part of this patch: CreateUniqueUID
910 3. File was not close properly in gdcmDict
911 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
912 5. Use of const ref instead of copy (speed issue)
913 6. Remove temporary (duplicate) string in TranslateToKey
914 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
915 8. Do not repeat virtual in subclasses
916 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
918 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
919 * Apply first patch toward better string comparison when dealing with broken
920 DICOM files. Essentially the string could be padded with a space instead
921 of a null character as defined by standard
923 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
924 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
925 because never used... and in the same time, that's remove some memory leaks
927 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
928 * src/gdcmFile.cxx : now delete the PixelConvert instance.
929 * In examples and tests : change the type of image data variables from void*
930 to uint8_t*. Remmove all delete on image data variables
932 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
933 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
934 Verify the file pointer value before open the file, and if it's not null,
935 a verbose message is generated.
936 Close correctly the file when the file isn't considered dicom-like. The
937 correctly close is a call to CloseFile.
938 When closing the file pointer, test if its not null to close the file.
939 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
940 file. For an uncompressed image, the copied data correspond in the least
941 case to the image size (calculated) or the image size specified in the
942 header. A verbose is generated if these two size mismatch
944 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
945 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
946 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
947 break under windows (with msvc6 compilation).
949 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
950 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
951 compiling with MSVC6)
953 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
954 * Bugs fix for the Windows build with VC6
955 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
956 needed (only for projects required VTK). If the VTK is included in all
957 projects, there is conflicts with the jpeg lib of vtk when compiling the
958 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
959 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
960 when compiling the gdcm_wrap.cxx file (created by the compilation of the
962 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
963 (like it's already made for the cout use). Otherwise, conflict with the
966 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
967 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
969 - comments on the DicomDir::Method related usage added.
970 - now that we use the namespace gdcm, a lot of internal classes do
971 NOT need to be wrapped anymore.
972 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
973 DicomDir::Method) new example added.
975 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
976 * Improve string manipulation. I now inforce the notion of 'DicomString'
977 A DicomString can contain as many \0 as they want
978 and it is *always* of even length.
979 We only support odd length for very rare case.
980 And in the near future this should be removed.
982 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
983 * /binary_write/ gdcm source. Now even on big endian we are writting
984 little endian. This should -heopfully- fix some tests
986 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
987 * Now the dictionary is compiled into gdcm lib. This is a default
988 behavior, thus any dic file specified is picked before failback to
989 the one comiled into lib
991 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
992 * Change internals for gdcmDict. Don't use any 'new' any more.
993 This should definitely solve any leak problem, and we should be
994 as fast as before, as long as don't modify too much the dictionary.
996 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
997 * STYLE: ivars should start with a capital letter.
998 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
999 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
1001 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1002 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
1003 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
1004 new 2004 dictionaries added (thanks to JPR).
1005 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
1006 * CLEANUP_ROUND (15) for gdcmPixelConvert
1007 - RLEFrame::NumberFragments is now of type unsigned int
1008 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
1009 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
1012 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1013 * Initial work in gathering all transfer syntax accessors. clearly
1014 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
1015 ivars, but only one transfersyntax (class) ivar with equivalent method on
1018 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1019 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
1020 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
1021 discussed (plus I didn't like having a 2000 lines patch not commited)
1023 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1024 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
1025 * CLEANUP_ROUND (14) for gdcmPixelConvert
1026 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
1027 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
1028 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
1029 CloseFile() anymore.
1030 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
1031 anymore and hence avoids storing a copy of PixelConvert::Decompressed
1032 into File::Pixel_Data.
1034 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1035 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
1036 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
1037 * CLEANUP_ROUND (13) for gdcmPixelConvert
1038 Substituted File::ParsePixelData() with PixelConvert::Print() new
1040 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1041 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1042 method to those classes.
1043 - src/gdcmFile.[cxx|h]:
1044 -- Added a ::Print() method.
1045 -- PixelConverter is now a reference instead of a member.
1046 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1047 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1049 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1050 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1051 collaboration diagram and inheritance diagram should be generated with
1053 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1054 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1055 pointlessly wrapped (see
1056 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1057 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1058 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1059 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1060 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1061 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1062 -- File::Initialise: PixelConverter setup moved away to
1063 PixelConverter::GrabInformationsFromHeader()
1064 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1065 interpretation moved away to PixelConverter::BuildRGBImage()
1067 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1068 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1069 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1071 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1072 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1073 displayed on Win32 when a brutal abort() occurs (because of uncatched
1074 exception). See TODO new entry of this commit for more on this.
1075 * TODO added new entry.
1076 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1077 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1078 - HandleColor is no longer called from gdcmFile.cxx
1079 - gdcmPixelConvert.cxx clean up on method arguments and internal
1080 variable names for semantical coherence.
1082 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1083 * Finished lossless transition, not only do we now read all lossless jpeg
1084 images, without the need of the Cornwell lib, but we do read them properly now
1085 * To reduce code (well to avoid code duplication), I defined a common place
1086 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1087 redefine symbols. This is not perfect but this the best solution I found for a
1088 compilation time jpeg option.
1090 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1091 * Update jpeg ijg lib to support lossless jpeg implementation
1092 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1094 * Also added a special copyright for dcmtk since we use their bugfixes.
1097 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1098 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1099 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1100 matters, as stated in warning note at beginning of %include section).
1101 * src/gdcmDicomDir*.[cxx|h]: coding style
1102 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1103 * src/gdcmJpeg8.cxx: doxygen fix.
1104 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1105 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1106 from File:: to PixelConvert::.
1108 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1109 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1110 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1111 - more code moved away from File:: to PixelConvert::
1112 - fat setup of PixelConverter set in place in File::Initialise.
1114 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1115 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1116 namespace at the file system level. So now you should convert your examples
1118 gdcmHeader -> gdcm::Header
1119 It would be nice if people keep in mind to no open the namespace, since it
1120 allows compilation on broken plateform which were defining common symbol in
1121 the standart namespace (like LP, Unknown ...)
1123 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1124 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1125 The JPEG fragments are now parsed at the same stage than the RLE
1126 information. All code related to JPEG is now in gdcmPixelConvert:
1127 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1128 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1129 export a gdcmFile:: method. Those are simply global functions
1130 (for the time being this is better than having them attach to
1131 either gdcmFile:: or gdcmPixelConvert::).
1132 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1133 and stores the result in a gdcmJPEGFragmentsInfo.
1134 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1135 code (among other stuff) moved away from gdcmFile:; to
1138 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1139 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1140 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1141 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1142 clean up of RLE related code.
1143 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1144 - src/gdcmRLE.cxx removed
1145 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1146 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1147 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1148 * CLEANUP_ROUND (9) for gdcmPixelConvert
1149 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1150 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1151 away from gdcmFile:: to gdcmPixelConvert::.
1153 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1154 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1155 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1156 This is because Parse7Fe0 used to parse the pixels to compute the
1157 length. This task was passed over to FindDocEntryLengthOB() a long
1158 time ago, EXCEPT I had forgotten the OW case...
1159 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1160 we just recylce the code for parsing RLE fragments and computing
1162 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1163 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1164 with the retired Parse7Fe0().
1165 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1166 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1168 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1169 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1170 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1171 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1172 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1173 * CLEANUP_ROUND (4) for gdcmPixelConvert
1174 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1175 to return an unused length.
1177 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1178 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1179 this should be cleanner from the plane view. The iostream are erally a pain
1180 to use to do simple stuff.
1182 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1183 * Redo the compilation of the ijg jpeg library. Now only one source is
1184 necesseray. No need to rename file by hand what so ever. CMake handle the
1185 copying of the file within different directory, configure header file to
1186 modify some symbol. The only addition made to ijg wasd a mangle table so
1187 that symbol are different whether we are within 8bits or 12bits.
1189 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1190 * Added documentation of vtkgdcmReader on Website:
1191 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1192 with it's binary name).
1193 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1194 the Website to be more complete.
1195 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1196 doxygenated documentation.
1197 - Doc/DoxyVtkGdcmReaderExamples.txt added
1198 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1199 DoxyVtkGdmReaderExamples.html )
1200 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1201 * CLEANUP_ROUND (3) for gdcmPixelConvert
1202 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1204 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1205 * CLEANUP_ROUND (2) for gdcmPixelConvert
1206 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1208 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1209 * CLEANUP_ROUND for gdcmPixelConvert:
1210 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1211 - src/gdcmPixelStuff[h|cxx] removed
1212 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1213 - src/CMakeLists.txt changed accordingly
1214 * GDCMHOME clean up:
1215 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1216 gdcmVersion.py moved to newly created ATTIC related
1217 gdcmPython/SetupOldies/ directory.
1218 * Autotools clean up:
1219 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1220 - autogen.sh configure.in acinclude.m4 python.m4 removed
1222 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1223 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1224 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1225 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1227 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1228 * TODO updated with Mathieu suggestions. I proposed a template for
1229 describing TODO entries and used it for new entries.
1230 * Added Doc/Website/CodingStyle.html, Developpers.html,
1231 DeveloppersPython.html, GdcmDataCvs.html and
1232 DownloadVersion0_1.html, DownloadVersion0_3.html.
1233 * Some Doc/*.txt Doxygen files (which do not really concern the
1234 documentation itself, but the website) moved to html and
1235 placed in directory Doc/Website:
1236 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1237 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1238 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1239 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1240 * CMakeLists.txt changed accordingly.
1241 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1242 DeveloppersPython.html
1243 * INSTALL nows refers to Doc/Website/Installation.html
1245 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1246 * Added Doc/Website directory, that contains a first raw version
1249 2004-09-23 Jean-Pierre Roux
1250 * FIX In order not to be poluted any longer by casting problems,
1251 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1252 we can now delete[] it safely
1253 * VoidArea is now called BinArea (less confusing name),
1254 and all the methods called ...VoidArea... are now ... BinArea...
1255 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1257 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1258 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1259 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1260 up to the destructor of gdcmElementSet to clean up TagHt and it's
1263 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1264 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1265 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1267 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1268 * ENH: added some utility method that builds a flat dictionary
1269 holding all the Dicom entries contained in the recursive structure
1270 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1271 an example of usage.
1272 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1273 BuildFlatHashTable() that build a flat dictionary.
1274 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1275 gdcmDocument is now a friend of gdcmElementSet.
1276 - src/gdcmElementSet.cxx: clean up.
1277 - Example/FlatHashTablePrint.cxx added.
1278 - Example/CmakeLists.txt changed accordingly
1280 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1281 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1282 moved away from gdcmDocEntrySet (since this class is an abstract class
1283 acting like an interface). SQDepthLevel and BaseTagKey are now
1285 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1286 and associated accessors. Doxygenation of the class.
1287 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1289 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1290 Use SQDepthLevel accessor instead. ::Print() adapted.
1291 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1292 - src/gdcmDocument.cxx changed accordingly.
1294 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1295 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1296 - The following is the doxygen comment of the typedef declaration
1297 of gdcmTagKey in src/gdcmCommon.h:
1298 gdcmTagKey is made to old an "universal" (as in URL, Universal
1299 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1300 A dicom tag always has a group and an element, but a set of tags
1301 embeded in various (optionally nested) sequences and sharing
1302 the same group and element all share the same (group, element)
1303 "identifier". Hence the (group, element) cannot be used as an
1304 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1305 In order to construct a proper tag identifier (i.e. a key) we
1306 consider the following definition of a TagKey:
1307 - let Group, Element be the string representation of the
1308 group and element dicom tag members,
1309 - let ItemNumber be the string representation of the integer
1310 index of the considered item number of a sequence,
1311 Let the key of a tag embeded in a sequence, noted SeqTag, be
1313 /ItemNumber#Group|Element
1314 where "/", "#" and "|" are characters acting as separators.
1315 Then the general form of a gdcmTagKey is given by:
1316 Group|Element<SeqTag>
1317 where <SeqTag> means NO or many instances of SeqTag.
1318 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1321 but the gdcmTagKey of a tag "embeded" is the first item of
1322 a sequence, itself nested in the third item of a sequence is the
1324 0004|1220/2#0008|0082/0#0008|0090
1325 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1326 order to hold the new sequence compatible key. Previously, the
1327 GetKey() method would look in the underlying gdcmDictEntry.
1328 - src/gdcmDocEntry.cxx:
1329 -- constructor now copies the underlying DictEntry key, in the local
1331 -- ::Print: displays the member Key, instead of the (group, element).
1332 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1333 - src/gdcmDocEntrySet.h:xi
1334 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1335 -- now has a new BaseTagKey member.
1337 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1338 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1340 This poses the problem with the semantics of the following lines
1341 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1342 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1343 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1344 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1345 to the long FIXME note for what the problem is. Nevertheless in
1346 order to get things working the dicom dictionary was altered !
1347 Please fix things urgently...
1348 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1349 information), see above note on moving the member VoidArea. Nevertheless
1350 the following entries previously correctly set as US are now inproperly
1352 0028 1201 OW IMG Red Palette Color Lookup Table Data
1353 0028 1202 OW IMG Green Palette Color Lookup Table Data
1354 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1355 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1356 of gdcmDocEntry moved to gdcmSeqEntry.
1357 * src/gdcmSeqEntry.cxx: STYLE.
1359 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1360 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1362 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1363 * gdcmPython/testSuite.py: all the test suite in python is now moved
1364 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1365 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1366 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1368 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1369 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1370 to avoid inclusion recursion until STL is reached.
1371 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1372 mecanism. errno.h is not included in gdcm anymore.
1373 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1374 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1376 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1377 gdcmData/TestAllEntryVerifyReference.txt
1378 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1379 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1380 exception_on_error parameter.
1381 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1382 - vtk/vtkGdcmReader.cxx changed accordingly,
1383 - Example/*.cxx and Test/*.cxx changed accordingly.
1385 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1386 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1387 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1388 enable_sequences removed from gdcmHeader constructor and dependencies.
1389 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1390 * gdcmPython/demo/PrintHeader.py: dummy fix.
1391 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1392 skip_shadow removed from gdcmHeader constructor and dependencies.
1393 * Example/*.cxx and Test/*.cxx changed accordingly.
1395 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1396 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1397 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1399 2004-07-21 Jean-Pierre Roux
1400 * FIX Now, Parsing and Printing a DICOMDIR do work!
1401 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1403 2004-07-20 Jean-Pierre Roux
1404 * FIX Some brain damaged headers have Zero-Lenght fields
1405 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1407 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1408 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1409 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1410 variable (instance of gdcmDebug) by a definition macro, and the instance
1411 is now in static in the gdcmDebug class
1412 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1413 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1415 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1416 * WARNING: ctest now depends more tightly on gdcmData. You should
1417 check out gdcmData properly for things to run smoothly...
1418 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1419 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1420 we need the pixels not be loaded in order to use the ValEntry
1421 that displays position and size).
1422 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1423 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1424 be deprecated. If you have any doubts about the advantages of a
1425 modern scripting language (read Python) versus grass root C++ (i.e.
1426 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1427 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1428 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1429 Anyhow, consider documenting the gdcmData images in
1430 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1432 * Test/CMakeLists.txt:
1433 - now uses TestAllEntryVerify.cxx
1434 - specific comments on oldACR00001.ima (now renamed in gdcmData
1435 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1436 gdcmData/TestAllEntryVerifyReference.txt
1439 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1440 * src/*.[h|cxx] : typedef clean up
1441 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1442 - TagKey renamed to gdcmTagKey (for external usage)
1443 - VRKey renamed to gdcmVRKey (for external usage)
1444 - removal of typedef duplication.
1445 - Removed all unecessary inline keyword from class inline definitions.
1446 - Some method|function(void) declarations replaced with method|function().
1447 * src/jpeg/libijg12/jdhuff12.c:
1448 - printf polluting ctest removed.
1449 - TAB removal for comminting
1451 - TestAllReadCompareDicom.cxx: added a test that compares all the
1452 images in gdcmDataImages.h with corresponding images in
1453 gdcmData/BaselineDicom/. When baseline images are not present
1454 this test creates them.
1455 Note: we need to validate each reference image, but before that
1456 I'd like to rename them with a more explicit name...
1457 - CMakeLists.txt: changed accordingly.
1458 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1459 including each header needed).
1461 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1462 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1463 test suite to the Example directory. Are concerned:
1468 - TestWriteSimple.cxx
1469 * Test/CMakeLists.txt: added some comments on reasons for black listing
1470 image gdcmData/oldACR00001.ima
1472 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1473 * Test/CmakeList.txt: removed the following from black list (to be coherent
1474 with removal from gdcmData):
1475 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1476 - gdcm-MR-PHILIPS-16.dcm
1478 Added the following because after last cvs update, they cause
1479 ctest -R TestReadWriteReadCompare
1481 - gdcm-MR-SIEMENS-16-1.acr
1483 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1484 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1485 new comments in this file) we temporarily (sigh) move to a weaker
1487 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1488 we don't need to black list the following images anymore:
1489 - 8BitsUncompressedColor.dcm
1491 - US-PAL-8-10x-echo.dcm
1492 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1493 fixes and the beautified code ;-)
1494 This fixes the bug introduced in version 1.42 (when beautifying)
1495 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1496 Note: ctest was blind to this bug (this means we need to still
1497 improve the test suite). The bug could be detected by using
1498 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1500 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1501 and by displaying the (garbage) produced file temp.XDCM...
1503 2004-06-29 Jean-Pierre Roux
1504 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1505 - replace by uggly but working old code :-(
1506 A lot of things should be OK again.
1507 It's really urgent to have a test suite that *tests*,
1508 to prevent Frog's beautifying sessions to break all the stuff
1509 (twice, withing a fortnigh ...)
1511 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1512 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1513 redundancy) to added Test/TestReadWriteReadCompare.cxx
1514 * Test/CmakeList.txt: because the compare test of
1515 Test/TestReadWriteReadCompare.cxx fails, the following images are
1516 black listed: - 8BitsUncompressedColor.dcm
1518 - US-PAL-8-10x-echo.dcm
1519 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1520 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1521 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1522 and ad-hoc kludge. This kludge is now removed, and on encountering
1523 such an image (OB field brain damaged) we set errno. Then in
1524 ::FindDocLength() we "fix" the length as being ALL what remains
1525 in the file (until EOF). We then proceed, hoping for the best...
1526 This fixes a SegFault in ShowDicom when trying to write such an
1528 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1529 (because TestWriteRead breaks on it, after a non conformal commit?).
1530 ctest now runs properly, except for MakeDicomDir (which was always
1531 broken) and the Python related stuff (still not fixed).
1533 2004-06-24 Jean-Pierre Roux
1534 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1535 FIX : Test/TestReadWrite now iterates on all the file names
1536 (instead of infinite loop)
1537 ENH : Test/TestWriteRead now iterates on all the file names
1539 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1540 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1542 2004-06-24 Jean-Pierre Roux
1543 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1544 when SamplesPerPixel =3
1545 - now Write is no longer confused by
1546 'BitsAllocated = 12" and 'BitsStored=12"
1547 - "UN" value representation Elements are now written correctly
1548 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1549 ENH : - now gdcmHeader has its own Write methods
1550 (in order to split the job that has not to be done
1553 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1554 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1555 loop on the same image until memory went out.
1556 Note: this means we still have gobs of memory loss in PrintDocument
1557 * src/gdcmDocument.cxx: fixes problem on parsing on file
1558 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1560 2004-06-24 Jean-Pierre Roux
1561 FIX : Write - All the Sequences and Sequence Item are now written
1562 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1563 is added a the end, when necessary.
1564 - A lot of brain-damaged images, that were read correctly are
1565 now written correctly
1566 - length compatible BinEntry are now loaded correctly
1567 (even for odd groups)
1568 Note : only Explicit Value Representation was checked.
1569 (question : is implicit VR really necessary for gdcm ?)
1571 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1572 * DEVELOPPER: added a proposition of coding style.
1573 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1576 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1577 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1578 Use the gdcmDocEntry::Print() and Write() instead.
1579 * src/gdcmDocument.cxx: bug fix.
1581 2004-06-22 Jean-Pierre Roux
1582 FIX : gdcmDocument.cxx
1583 - Now we do recognize the JpegLossLess format (there was a misstyping in
1584 code 'beautyfication' :-(
1585 - Now we automaticaticaly load the Luts, if any
1587 2004-06-22 Jean-Pierre Roux
1588 In order : to write Sequences, whatever their imbrication level,
1589 : to allow user to create his own Sequences
1590 a lot of modif where necessary (adding, moving, or virtualising methods)
1592 WARNING : save your own sources *before* cvs up !
1595 ADD virtual void Write(FILE *fp, FileType filetype);
1598 ADD virtual void Write(FILE *fp, FileType filetype);
1599 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1602 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1603 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1604 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1605 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1606 ADD std::string GetEntryByName(TagName name);
1607 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1609 std::string vr = "unkn",
1610 std::string fourth = "unkn",
1611 std::string name = "unkn");
1612 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1613 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1614 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1615 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1616 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1617 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1618 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1619 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1622 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1623 ADD virtual std::string GetEntryByName (TagName tagName);
1624 ADD virtual std::string GetEntryVRByName (TagName tagName);
1625 REM virtual bool Write(FILE *, FileType);
1626 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1627 FILE *_fp, FileType type);
1628 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1629 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1630 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1631 REM virtual std::string GetEntryByName (std::string tagName);
1632 REM virtual std::string GetEntryVRByName (std::string tagName);
1633 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1634 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1635 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1637 std::string vr = "unkn",
1638 std::string fourth = "unkn",
1639 std::string name = "unkn");
1640 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1641 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1642 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1643 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1646 ADD virtual void Write(FILE *fp, FileType filetype);
1649 ADD virtual void Write(FILE *fp,FileType filetype);
1652 ADD virtual void Write(FILE *fp, FileType filetype);
1653 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1654 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1655 REM std::string GetEntryByName(TagName name);
1658 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1660 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1661 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1662 The default constructor invoked by the line
1663 gdcmHeader *f1 = new gdcmHeader( header );
1664 was gdcmHeader::gdcmHeader(bool) instead of the expected
1665 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1666 Hence the parsing wasn't executed... See also below.
1667 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1668 as explicit constructor didn't do the trick to fix the above problem.
1669 Could anyone explain why ?
1670 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1671 properly calls gdcmValEntry::Print() (that was weed out from
1672 code related to gdcmBinEntry).
1674 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1675 * In order to fix memory leaks:
1676 - Test/TestWriteSimple.cxx: added cleaning of free store through
1678 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1679 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1680 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1681 (through the call to ::AddDicomDirMeta()) or the destructor
1682 would crash when deleting uninitialized ::metaElems].
1683 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1684 - src/gdcmDocument.cxx:
1685 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1686 from dynamic stores.
1687 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1688 was causing memory leaks.
1689 - src/gdcmSQItem.cxx:
1690 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1691 cleanly handled with polymophism: sorry but my milage is low).
1692 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1693 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1694 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1695 This avoids SegFaulting.
1696 - src/gdcmSQItem.h: coding style.
1698 - Test/TestWriteSimple still severely sucks. The output image content
1699 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1700 damaged when displayed with vtkgdcmViewer.
1701 - on memory leaks: TestWriteSimple leaks really less (see entry
1702 of 2004-06-18 in Changelog file for the call to valgrind).
1703 - on segfaults: ctest now passes all the tests but one (no more
1705 * Erroneous leading white fix:
1706 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1707 white[s] (as opposed to from >> xxx, that removes it [them].
1708 - src/gdcmTS.cxx: ditto.
1709 - gdcmPython/testSuite.py: dirty related kludge removed.
1710 * src/*: remaining references to gdcmParser removed.
1711 * src/*[cxx|h]: added copy[way]left header.
1714 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1715 * In order to fix writing of dicom files:
1716 - Test/TestWriteSimple.cxx: a simpler example of writing.
1717 - Test/CMakeLists.txt changed accordingly.
1718 - src/gdcmDocument.cxx:
1719 -- The destructor now recursilvely removes potential sequences.
1720 -- Bug fix in ::IsJPEG2000()
1721 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1722 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1724 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1725 to only declared) and build on top of
1726 ::GetDocEntryByNumber(guint16, guint16).
1727 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1728 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1729 for usage in destructor and treatement of promotion in
1730 ::ReplaceOrCreateByNumber().
1731 - src/gdcmSQItem.cxx: destructor should better handle his job.
1732 Test/TestWriteSimple now runs (or at least it DOES something).
1733 * We can now start hutting memory links. A good starting point is:
1734 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1735 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1736 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1738 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1739 * Valgrind note: after Mathieu Malaterre teached me how to read
1740 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1742 Using gcc, you can force the STL to use malloc and to free memory as
1743 soon as possible by globally disabling memory caching.
1744 With 3.2.2 and later, you should export the environment variable
1745 GLIBCPP_FORCE_NEW before running your program.
1746 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1747 simply vanish (it is still not clear to me, whether this means that
1748 STL std::string leaks or if valgrind believes it leaks...).
1749 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1750 running bin/gdcmTests makeDicomDir):
1751 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1752 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1754 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1755 SegFaulting (I drowned in DicomDir related code when trying to
1756 understand why the list is empty...).
1757 * src/gdcmDocument.h: first BSD license header try.
1758 * Doc/License.txt added.
1760 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1761 * src/gdcmDocument.[h|cxx]:
1762 - Clean up of the Transfer related predicates. They are now all based
1763 on new method isGivenTransferSyntax, that (should) handle properly
1764 the padding problem.
1765 - general clean up, simplification, and coding style.
1766 - Specific clean up of Parse7FE0() (umproperly named actually).
1767 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1769 2004-06-14 Jean-Pierre Roux
1771 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1772 - fix the display of SQItem ordinal number
1773 - add the GetSQItemByOrdinalNumber method
1774 - remove some useless never written private methods
1776 2004-06-14 Jean-Pierre Roux
1778 - adding a constructor taking a gdcmDocEntry as an input param
1779 - ReplaceOrCreateByNumber now returns :
1780 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1781 a gdcmValEntry * if a string value is passed as a param
1783 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1784 according to the param type (no longer sets a gdcmDocEntry)
1785 - GetValEntryByNumber, GetBinEntryByNumber added
1786 - NewValEntryByNumber and NewBinEntryByNumber added
1788 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1790 - GetSQItemNumber and SetSQItemNumber added, to provide
1791 a (relative) Item identier inside a given Sequence
1792 \warning : some pb remaining around this number
1794 - AddEntry now takes the Item Number as a param
1796 - adding a constructor taking a gdcmDocEntry as an input param
1798 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1799 * Memory leak hunt with the following command:
1800 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1801 --show-reachable=yes gdcmTests PrintDocument
1802 It looks like many (all?) leaks are due to the STL (or a bad usage
1803 of the STL. The lines producing the leaks now have a comment with
1804 a "MEMORY LEAK" tag: you can retrieve them with
1805 grep "MEMORY LEAK" src/*
1806 Here are two typical examples which I can't help fixing:
1811 char * test = "babo";
1812 name = test; //// <--- valgrind detects 960 bytes lost in
1813 //// call to std::string::operator=(char const*)
1814 name.clear(); //// Doesn't help !
1822 std::cout << "Type a bunch of characters followed by RETURN: ";
1823 getline(std::cin, line); //// <--- valgrind dectects a loss
1824 //// of 1320 bytes in call to
1825 /// std::basic_istream<>& std::getline<>
1831 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1832 * src/gdcmHeader.[cxx|h]:
1833 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1834 and related, moved away to gdcmDocument.
1835 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1836 the corresponding protected accessors of inherited class
1837 gdcmDocument, removed ! As a consequence gdcmFile had to be
1838 declared friend of class gdcmDocument (see below).
1839 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1840 - Clean up of undefined or unused methods.
1841 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1842 account the changes to gdcmHeader.h).
1843 * src/gdcmDocument.h:
1844 - gdcmFile is now a friend class (in order to take into account the
1845 changes to gdcmHeader.h).
1846 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1847 (see changes to gdcmHeader.h).
1848 - Accessors (reading on the form GetEntry*) are now public.
1849 - Clean up of undefined or unused methods.
1850 * src/gdcmDocument.cxx:
1851 - adaptation to changes to gdcmDocument.h
1852 - ::OpenFile now writes a verbose message when file cannot be opened.
1853 - some std::string properly set to VRKey
1854 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1855 references to gdcmDocument.
1856 * Test/TestFindTags.cxx: changed accordingly to above changes.
1857 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1858 cvs repository gdcmData.
1860 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1861 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1862 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1863 conflicts with gdcmValEntry::voidArea.
1864 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1865 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1866 Value representation between StringRepresentable and BinaryRepresentable.
1867 * src/gdcmDocument.cxx:
1868 - method ParseDES: proper indentation restored and usage of
1869 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1870 - method LoadDocEntry: the fingerprint left in the SetValue() of
1871 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1872 removed. Reverting to previous code segment with the proper
1873 dynamic_cast< gdcmValEntry* >.
1874 Note: this was (partially) breaking the python test suite
1875 (gdcmPython/testSuite.py) that made usage of the above
1876 fingerprint to check presence of "Pixel Data".
1877 * src/gdcmDocEntry.h: coding style.
1878 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1879 now taken into account.
1880 * gdcmPython/gdcm.i: adaptation to the new internal representation
1881 of gdcm (exit gdcmParser, hello gdcmDocument).
1882 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1884 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1885 anymore, but instead prints the loaded Python dictionary.
1886 * .... alas, the python testSuite is still broken.
1888 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1889 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1891 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1892 * src/gdcmUtil.h : export methods
1894 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1895 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1897 * Initial addition of automatic python testing
1898 * Initial addition of automatic image comparison
1900 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1901 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1902 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1904 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1905 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1906 * Test/ShowDicom.cxx : bug fix for msvc compilation
1907 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1909 2004-05-04 Jean-Pierre Roux
1910 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1911 new concepts (and new classes) :
1912 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1913 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1914 - Sequence Doc Entries (gdcmSeqEntries)
1915 a Sequence is composed of Items.
1916 Each item is a set of Doc Entries (this is recursive)
1917 The non uniqueness of the 'Dicom tag' is due to this recursivity
1918 (never taken into account)
1919 Our unability to add a new 'entry' in the header
1920 at the proper location (neither in the H-Table (map or multimap),
1921 nor in the Chained List is also due to this recursivity.
1922 Don't try, right now, to use/modify/compile these new sources :
1923 nothing is finished.
1924 We just commit all the stuff, 'as is', in order not to loose it.
1926 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1927 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1929 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1930 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1931 file prefix (SetFilePrefix)
1933 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1934 * Add a new test: ShowDicom, for now this is just the c++ version of
1935 checkRead.sh, later it will be able to compare the image read against a
1937 * Replace the DEBUG on the stack with a global entry in cmake interface:
1938 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1940 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1941 * Add an example subdir, with a real example on how to read + write a
1944 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1945 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1946 * Doc/CMakeLists.txt: the main page is now properly differentiated
1947 between the developper and user version.
1948 * Doc/doxygen.config.in: dropped search related obsolete flags
1949 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1951 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1952 * DEVELOPPER: added some helpfull comments for compile/test/install
1955 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1956 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1957 src directory, now generated in the build dir.
1958 2. Tests as mentionned smarter
1960 4. Add a new method in gdcmDict that return the PubDict by name
1961 this is interesting for 3rd party lib like ITK,
1962 where we could set the institution name / patient name...
1964 * ENH: 1. Now the test suite is working for real
1965 2. All binaries are now output in the gdcm-bin directory
1966 (this was not true before)
1968 2004-04-28 Jean-Pierre Roux
1969 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1970 SeQuence indented printing of Dicom Header.
1971 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1972 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1973 Computation of SQDepthLevel is now part of gdcmHeader constructor
1974 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1975 tree-like structure of a Dicom Header.
1976 * FIX Test code cleaning
1978 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1979 * ENH: Adding automatic testing
1980 1. Need a DartConfig.cmake to submit to public
1981 2. Add a test driver gdcmTest.cxx
1982 3. gdcmTestMain, an helper for the main test driver gdcmTest
1983 4. Files in Test don't have a main anymore, this becomes interesting
1984 when we add more and more tests, thus dsw don't have to load
1986 * ENH: Adding a GDCM_DATA_ROOT for testing
1987 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1988 one file instead of seven + some small cleanup
1990 2004-04-22 Jean-Pierre Roux
1991 * ENH Minor changes to the Print() methods.
1992 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1993 Header printing. Example given with :
1994 > PrintHeader fileName 2 new
1995 (SQ based tree-like structure still to be done for the Header ...)
1997 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1998 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1999 1. I have added some unsigned where needed
2000 2. Some function parameter not used -> (void)
2001 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
2002 4. g++ don't like character '\' in comment
2003 5. #define jpeg_create_decompress jCreaDecompress
2004 this really need to be fixed
2005 6. virtualize destructor of gdcmObject ... leakage
2006 7. sscanf(g->first.c_str(),"%x",&gr_bid);
2007 this also really need to be fixed
2008 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
2009 remove compression file
2010 (as we only do decompression, right ?)
2011 * ENH: Change malloc/calloc/free with c++ equivalent
2013 2004-04-21 Jean-Pierre Roux
2014 * FIX gdcmHeaderHelper::GetXSpacing
2015 when a single value is found (bug ?), xpacing is now
2016 defaulted to yspacing
2018 2004-04-19 Jean-Pierre Roux
2019 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
2020 * ENH add parameters :
2021 bool exception_on_error = false,
2022 bool enable_sequences = false,
2023 bool ignore_shadow = false
2024 to the gdcmFile constructors to be full gdcmParser compliant
2025 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
2026 to allow reading of PAPYRUS 3.0 files
2028 2004-04-06 Jean-Pierre Roux
2029 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
2031 2004-04-02 Jean-Pierre Roux
2032 * ADD : Test/checksequence.sh, for a general recap on SQ pb
2033 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
2034 for Philips spurious Tag fffe|0000 while rewritting Dicom files
2036 2004-03-30 Jean-Pierre Roux
2037 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
2038 for ACR file, written out as DICOM files (hope so...)
2040 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2041 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2042 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2043 moved to base class gdcmParser and only the specialisation is kept
2045 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2046 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2047 already does the job.
2048 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2049 (to be consistent with gdcmParser::WriteEntries).
2051 2004-03-30 Benoit Regrain
2052 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2053 upate of the object's instance. It's passed to 2 in the unfavorable
2054 case : one in the ExecuteInformation, one in the ExecuteData
2056 2004-03-29 Jean-Pierre Roux
2057 * ENH : Check on file type to be written moved
2058 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2059 * FIX : gdcmObject::ResetBoundaries now stops properly
2060 when end-of-list is reached
2061 : gdcmVersion modified (as Benoit Regrain asked)
2063 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2064 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2065 * src/gdcmUtil.cxx: added forgotten iostream include.
2066 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2067 equivalent to ExplicitVR in existing code).
2069 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2070 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2071 now contains all the gdcmGlobal related code.
2072 * minor coding style and doxygenation changes.
2074 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2075 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2076 now contains all the Debug related code.
2077 * minor clean-up of includes in src/*.cxx
2078 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2079 CreateCleanString) removed.
2080 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2081 * Doc/DoxyMainPageUser.txt added.
2082 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2083 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2084 src/gdcmDirList.cxx)
2086 2004-03-24 Jean-Pierre Roux
2087 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2089 2004-03-23 Jean-Pierre Roux
2090 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2091 big endian made volumes
2092 * ENH Now gdcmParser constructor and destructor are protected to forbid
2093 end user to instanciate class gdcmParser
2094 (only gdcmHeader and gdcmDicomDir are meaningfull)
2096 2004-03-22 Benoit Regrain
2097 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2098 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2099 gdcmSerie to gdcmDicomDirSerie
2101 2004-03-19 Jean-Pierre Roux
2102 * ENH Now the tree-like structure describing a DICOMDIR comming from
2103 an already existing DICOMDIR file is consistent with
2104 the home-made tree-like structure build ex-nihilo
2105 or build from the files held (recursively) in a Directory
2106 functions gdcmDicomDir::CheckBoundaries()
2107 gdcmObject::SetBoundaries() added
2109 2004-03-17 Jean-Pierre Roux
2110 * REM (Eric Boix bug) : removal of meaningless
2111 gdcmDicomDirImage::NewImage function.
2112 * FIX now file names and directory name are written properly in the
2114 * FIX now gdcmDicomDir constructor may be call without any trick
2117 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2118 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2119 of gdcmDicomDirImage::NewImage as empty function.
2121 2004-02-28 Jean-Pierre Roux
2122 * ENH add gdcmDicomDir:NewPatient
2123 add gdcmDicomDirPatient:NewStudy
2124 add gdcmDicomDirStudy:NewSerie
2125 add gdcmDicomDirSerie:NewImage
2126 to allow making gdcDicomDir object.
2127 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2128 (as opposite to the gdcmHeader chained list)
2130 2004-02-11 Benoit Regrain
2131 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2132 when using from python
2134 2004-02-10 Benoit Regrain
2135 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2136 * FIX : in gdcmDicomDir when the directory is empty
2137 * ENH : add callback and methods to get the progression of dicomDir
2140 2004-02-06 Jean-Pierre Roux
2141 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2142 - GDCM_META added to gdcmDicomDirType
2143 - class gdcmMeta created
2144 * ENH : - A brief summary is now displayed at the beginning of
2145 'testDicomDir' to help disaster magnitude estimation
2146 * REM : Now useless Test/explDICOMDIR.cxx
2148 2004-02-05 Benoit Regrain
2149 * ENH : add methods in gdcmObject to get the hash table or the list of
2151 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2152 * FIX : wrapping python for TagHeaderEntryHT
2154 2004-02-04 Benoit Regrain
2155 * FIX : even length for some strings when writting the dicom dir
2156 * FIX : sort the images in the dicom dir
2157 * FIX : Bug fix for python use of dicom dir
2158 * ADD : a python demo
2160 2004-02-04 Jean-Pierre Roux
2161 * FIX : Final solution (?) for icone embedded images
2162 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2163 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2164 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2165 gdcmData/gdcm-MR-SIEMENS-16.acr1
2166 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2167 to make full checking easier
2169 2004-02-04 Benoit Regrain
2170 * FIX : WriteEntries : coding style & logic in parameters
2171 * FIX : Set the elements to create the DicomDir in a dictionary file
2173 2004-02-03 Benoit Regrain
2174 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2175 * gdcmDicomDir : add the load of directory
2176 * Bug fix and print add-on
2178 2004-02-03 Jean-Pierre Roux
2179 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2180 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2181 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2182 * FIX gdcmParser.cxx : 'group length' elements are now considered
2183 as integers, even for shadow groups, when file is Implicit VR
2185 2004-02-02 Jean-Pierre Roux
2186 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2188 of the last synonym :-(
2189 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2191 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2192 * FIX taking into account the possible 7fe0,0010 multiplicity
2193 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2194 to allow removal of references to 7fe0,0010, to deal with
2195 ACR-NEMA images, when 0028,0200 is meaningfull
2197 2004-01-31 Jean-Pierre Roux
2198 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2199 no longer writes 'Un' on disk
2200 * FIX SQ elements with actual length are now dealt with corectly
2201 * FIX gdcmFile::WriteBase make the difference, for color images, between
2202 the length (for Palette expanded images)
2203 and Raw Length (non expanded image + Palette)
2204 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2205 (that broke Write). Replaced by UL.
2206 Aware user will reload the field if he
2207 thinks it's necesssary
2209 2004-01-30 Jean-Pierre Roux
2210 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2211 when 'dirty Acr' is found, to be compliant with the new
2212 IsReadable() methods.
2214 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2215 (no DOUBLE images in kosher DICOM,
2216 but so usefull for people that miss them ;-)
2218 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2219 DICOMDIR related utilities (not checked as Windoze compliant)
2221 2004-01-28 Jean-Pierre Roux
2222 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2224 2004-01-27 Jean-Pierre Roux
2225 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2226 to allow skipping the shadow elements, to save memory space.
2227 The TRUE value for this param has to be used
2228 with a FALSE value for the 'enable_sequence' param.
2229 ('public elements' may be embedded in 'shadow Sequences')
2230 * gdcmHeader methods now deal with 'embedded icones images' in the header
2231 (even when an 'icone image sequence' is announced by the
2232 element (0x0088,0x0200), but there is NO icone at all ...
2234 * gdcmHeader sometimes Image Location value doesn't follow
2235 the supposed processor endianity (see gdcmData/cr172241.dcm).
2238 * gdcmHeader add the method
2239 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2240 to get *all* the Header Entries with the same tag.
2241 GetHeaderEntrySameName is probabely *useless*
2242 (no meaning : Name is *not* an identifier within the Dictionary)
2244 2004-01-26 Benoit Regrain
2245 * Bug fix in the print of hexadecimal representations. Remove long fields
2246 in the print and add a third level of print to print them
2248 2004-01-23 Benoit Regrain
2249 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2250 * Bug fix on test suite after remove the strip made on not string fields
2251 * Split the IsReadable method between gdcmParser which test that the file
2252 is dicom and gdcmHeader which test that it's an image file
2254 2004-01-22 Benoit Regrain
2255 * DicomDir : clean code, add methods, set variables in protected or private
2256 * gdcmUtil : bug fix for the clean string method
2258 2004-01-19 Benoit Regrain
2259 * Add the use of shadow dictionaries
2260 * bug fix and coding style
2262 2004-01-19 Benoit Regrain
2263 * src/gdcmFile.cxx : bug fix concerning the close of file
2264 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2265 * Add the update of header entries using the shadow library
2267 2004-01-19 Benoit Regrain
2268 * removal of file gdcmHeader2.cxx
2269 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2270 inheriting from gdcmParser. This split is to prepare the integration
2271 of dicom dir parsing
2272 * bug fix under python
2274 2004-01-16 Jean-Pierre Roux
2275 * REM removal of class gdcmHeaderEntrySet
2276 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2277 * ADD add file gdcmHeader2.cxx
2278 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2280 2004-01-15 Benoit Regrain
2281 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2282 entries created while parsing the header. Thus, they will be destroyed
2283 when the gdcmDictSet will be destroyed
2284 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2287 2004-01-15 Benoit Regrain
2288 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2289 made a fatal error because of the memory release at the end of program.
2290 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2291 some memory and vtk seems to have some problems with that.
2292 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2294 2004-01-14 Benoit Regrain
2295 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2296 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2297 * src/*.[h|cxx] : make changes due to class name changes
2298 * gdcmPython/demo/*.py : bug fix due to method names
2300 2004-01-13 Benoit Regrain
2301 * src/*.[h|cxx] : coding style
2302 * vtk/*.[h|cxx] : coding style
2304 2004-01-13 Benoit Regrain
2305 * gdcmPython/testSuite.py : test the readable flag of file for tests
2306 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2307 It's lied to the stl compilation by MSVC (windows, always windows...)
2308 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2310 2004-01-12 Benoit Regrain
2311 * src/*.h : add comments
2312 * src/gdcmDictSet.h : set the method BuildDictPath in public
2313 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2314 directly setted in the source code
2315 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2318 2004-01-09 Benoit Regrain
2319 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2320 * setup.py : use a reference to gdcmVERSION
2322 2004-01-07 Benoit Regrain
2323 * Modification to compile with the distutils.
2326 2003-12-10 Benoit Regrain
2327 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2328 can use a gdcmHeaderHelper to load data
2329 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2330 made in the source code
2332 2003-12-10 Benoit Regrain
2333 * Update Windows projects and .cvsignore files
2335 2003-11-12 Jean-Pierre Roux
2336 * ENH gdcmHeader constructor has one more parameter (default value : false)
2337 that allows the user to 'go inside' the SeQuences only
2339 gdcmElValSet:Print takes it into account
2341 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2342 * ENH: Update gdcmPython/CMakeLists
2343 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2344 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2346 2003-11-10 Jean-Pierre Roux
2347 * FIX : gdcmHeader::LoadElements is now based
2348 on the ListTag listElem member,
2349 not longer on the TagElValueHT tagHt member
2350 * ENH : PrintPubElVal shows (temporarily) both results,
2351 with the tagHt member and the listElem member.
2352 (it's easier to 'see' the problems when using Printheader)
2354 * FIX : old private member LgrElem is now splitted into
2355 ReadLength : Length actually found on disk (updated only
2356 if bug fixing is necessary), for internal
2358 UsableLength : Updated by FixFoundLength, to fix a bug
2359 or to allow Parser going on.
2360 Will allow to re-write a kosher header when a SeQuence
2361 with a length (not 0000) is found
2362 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2363 because gdcmElValSet::Add does not update ListElem
2366 2003-11-07 Jean-Pierre Roux
2367 * FIX misstyping in Transfert Syntax name table
2368 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2369 when they have an actual length (not 0000 nor FFFFF)
2370 (Nobody should care of it, but DICOMDIR explorers)
2372 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2373 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2375 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2376 * ENH: vtkGdcmReader now supports LUT !
2377 (vtkgdcmViewer for now is not able to use them though)
2379 2003-11-05 Jean-Pierre Roux
2380 * in testSuite.py : new files names for checking the package
2381 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2382 that returns the pixel area size to the *aware* (vtk) user
2383 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2385 2003-11-05 Benoit Regrain
2386 * in testSuite.py : Modify the rules for checking the paths
2387 : Explicit error messages
2388 * in __init__.py : Related modif
2390 2003-11-03 Jean-Pierre Roux
2391 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2392 to be used by aware (vtk) users that want to manage
2393 LUT (and no to turn the PALETTE image into an RGB pixels one)
2394 * GetPixelType now returns 8U for 24 Bits images
2395 (vtkGdcmReader compliant)
2397 2003-10-31 Jean-Pierre Roux
2398 * Removal of *all* gdcmData images and add them again
2399 in order to loose the 'history' of un-anonymised images
2401 2003-10-31 Jean-Pierre Roux
2402 * RMV : removal of useless jBitsInJsample.h
2403 for both 8 and 12 Bits JPEG Lossy Libraries
2405 2003-10-31 Jean-Pierre Roux
2406 * ENH : Add the functions gdcmFile::GetImageDataRaw
2407 gdcmFile::GetImageDataIntoVectorRaw
2408 that act as GetImageData and GetImageDataIntoVector
2409 except the making of an RGB Plane from Gray Plane + LUT
2410 Intended to aware (vtk) users who know how to manage
2413 GetLUTRGBA return a R,G,B,A LUT if any
2414 lgrTotaleRaw gives the 'Raw' length
2415 GetImageDataRaw returns the gray Plane
2416 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2417 (They stay Grey, just like with other Dicom viewers :-(
2419 2003-10-30 Jean-Pierre Roux
2420 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2422 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2423 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2424 being coherents dicom files.
2426 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2427 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2429 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2430 * ENH: Two steps is necessary to please VC++ compiler...
2431 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2432 * ENH: Add include dir to medcon lib
2433 * FIX: only one function is being exported for now !
2434 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2436 2003-10-29 Jean-Pierre Roux
2437 * adding gdcmHeader::GetLUTRGBA
2438 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2439 --> Mathieu, the modif u're waiting for is not yet committed
2440 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2442 2003-10-27 Jean-Pierre Roux
2443 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2444 00191113.dcm DermaColorLossLess.dcm
2445 MxTwinLossLess.dcm RadBWLossLess.dcm
2446 * ENH: For version prior to vtkImageViewer2 -r 1.19
2447 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2449 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2450 * Removal of ido stuff in CMakeLists.txt
2452 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2453 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2454 * FIX: remove a call to ->Modified ... see comments
2455 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2457 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2458 * FIX: Problem with path for libvtkgdcmPython
2459 * ENH: Try adding a search script for python site-package
2460 * RMV: Remove some file from medcon lib that are not necessary
2461 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2462 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2463 * FIX: More pragma disable fro VC++,
2464 I don't think I break something as it is also disable in VTK/ITK.
2465 But it fasten debug compilation time.
2467 2003-10-23 Jean-Pierre Roux
2468 * gdcm now deals with 16 Bits Run Length Encoded images
2469 (they are compressed as 2 planes images,
2470 one for the high Bytes, the other for low Bytes)
2472 2003-10-22 Jean-Pierre Roux
2473 * Now CheckRead takes into account :
2474 - the bugged 'Leonardo' Siemens images
2475 - the XA images, sent thru the burning VPRO station
2476 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2479 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2480 * FIX: When copying a Makefile.am to CMakeLists.txt
2481 one should remove the '\'
2483 2003-10-22 Jean-Pierre Roux
2484 * in gdcmData adding a bugged 'Leonardo' Siemens image
2485 (wrong lengths in header)
2486 OK with gdcm, KO with the other viewers :-)
2487 * add a GE dlx XA image, thru the VEPRO burning station
2490 2003-10-21 Jean-Pierre Roux
2491 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2492 for a brutal checking of vtkgdcmViewer compliance
2494 2003-10-21 Jean-Pierre Roux
2495 * add the files for 'xmedcon' Jpeg Lossless library
2496 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2498 2003-10-21 Jean-Pierre Roux
2499 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2501 2003-10-21 Jean-Pierre Roux
2502 * garbage Siemens 'Leonardo' images dealt with
2503 (the patch is easy to remove)
2504 * cosmetic changes to avoid warnings
2506 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2507 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2508 no need to press 'r' now.
2510 2003-10-20 Jean-Pierre Roux
2511 * upgrade of checkRead.sh checkWrite.sh according
2512 to new Jpeg Lossless decompressor
2513 * add US.3405.1.dcm, a genuine RGB medical file ...
2514 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2515 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2517 2003-10-15 Jean-Pierre Roux
2518 * general anonymisation in gdcmData
2519 * adding the 'color files' from
2520 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2521 * adding some well knowed bugged-header images
2522 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2523 waiting for their inclusion in Python testsuite
2525 2003-10-15 Jean-Pierre Roux
2526 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2527 no longer seg faults when file is not found
2529 2003-10-14 Jean-Pierre Roux
2530 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2533 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2534 * TODO: *.in file to genereate a UseGDCM later
2536 2003-10-14 Jean-Pierre Roux
2537 * Some supposed-to-be Dicom Images have no preamble.
2538 OpenFile takes it into account
2539 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2540 * Missing elements added in dicomV3.dic
2541 (just to be affraid : have a look at
2542 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2543 and do it again next year ;->
2545 2003-10-13 Jean-Pierre Roux
2546 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2547 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2548 But there are NOT. It's fixed !
2550 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2551 * FIX: "jpeglib.h" was not found on VC++
2552 * FIX: vtkgdcm was not being installed
2554 2003-10-10 Jean-Pierre Roux
2555 * ENH : OpenFile closes the file if it *really* doesn't look like
2556 an ACR-NEMA / DICOM one.
2557 * FIX : testWrite no longer writes an empty file if the source file
2558 is not gdcm Readable
2559 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2562 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2563 * FIX: CMake generate now documentation
2564 * ENH: out of source doc build !
2565 * ENH: Generate both user and dev documentation
2566 * ENH: Should work on windows too
2567 * ENH: Only one doxygen config.in file is needed
2568 * FIX: make install should be ok now on ùnix plateform
2569 * FIX: PATH to dictionary was wrong (missing /)
2570 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2572 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2573 * vtkGdcmReader is now able to read rgb dicom file.
2574 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2575 * added a gdcmViewer to vtk test, use mouse to control
2576 window level & window width
2578 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2579 * CMake-ification of gdcm, we have now two build system
2580 * FIX: on cygwin Wsock32 doesn't exist
2581 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2583 2003-10-06 Emanuel Ollart
2584 * FIX : compilation process wad broken.
2585 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2587 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2588 * change gdcmViewer -> vtkgdcmViewer
2589 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2591 2003-10-06 Jean-Pierre Roux
2592 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2593 ( e.g : well known GE images with a wrong elem length,
2594 : Philips MRI Images with a wrong Huffman table)
2595 * still to be done : allow the reading of bugged LEONARDO Siemens images
2597 2003-10-03 Jean-Pierre Roux
2598 * Odd length strings are padded with '\0' (not with spaces,
2599 to remain compliant with already defined strings,
2600 like Transfert Syntax UID and others)
2602 2003-10-03 Jean-Pierre Roux
2603 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2604 to allow displaying RGB images (not only by affim ;-)
2606 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2607 * vtkGdcmReader is now able to read rgb dicom file.
2608 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2610 2003-10-03 Jean-Pierre Roux
2611 * A few nasty patches to allow the reading of a lot of nasty images
2612 ( e.g : well known GE images with a wrong elem length,
2613 : Philips MRI Images with a wrong Huffman table)
2614 * still to be done : allow the reading of bugged LEONARDO Siemens images
2616 2003-10-03 Jean-Pierre Roux
2617 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2619 2003-10-03 Jean-Pierre Roux
2620 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2621 to allow displaying RGB images (not only by affim ;-)
2623 2003-10-03 Jean-Pierre Roux
2624 * gdcmFile::GetImageDataIntoVector now
2625 - deals with MultiFrames MultiFragments Run Length Encoded files
2626 - deals with YcBcR (YBR_FULL) files
2627 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2628 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2630 (no sample found :-(
2632 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2633 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2634 Two reasons: - clear things
2635 - third parties acces gdcm through header files, so won't
2636 suffer anymore VC++ complains
2638 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2639 * add argv[1] in testvtkGdcmReader.cxx
2642 2003-09-24 Jean-Pierre Roux
2643 * The lines are now eigthy characters long.for
2644 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2646 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2647 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2648 char* to std::string. Thus, the use of strdup becomes useless. (see
2649 previous commis of Malaterre)
2650 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2651 before the last Malaterre's commit.
2653 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2654 * This commit should fix the Debug building under VC++, the problem
2655 was mainly a mixture of debug and release lib being loaded at startup.
2656 * I also remove a depency to a specific C function: strdup. Because I had
2657 to force the link to msvcrtd (whereas strdup is in libc).
2659 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2660 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2661 located in the gdcmCommon.h file. All use of reference of tha has been
2662 changed to now use the variable GDCM_UNFOUND.
2664 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2666 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2667 Dicom dictionary. The test suite can now be run again. Note:
2668 I'm note very happy with the " (RET)" changes. I believe this
2669 RETAINED comment should be dropped when parsing the dictionary.
2670 - PACKAGER corrected
2672 - AUTHORS updated and now in alphabetical order
2673 * Makefile.am now exports gdcm.dsw for Windoze users.
2675 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2676 * cygwin complains about missing std:: in subdir Test/
2678 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2679 * remove some methods that are now in gdcmHeaderHelper
2681 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2682 * vtkGdcmReader set spacing and origin correctly
2684 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2685 * Fix a few delete/delete[] mismatch
2687 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2688 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2689 interpretation to data given by gdcmHeader. For instance there are
2690 heuristics to get informations (look at different places).
2691 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2692 sorting DICOM images based on different strategies.
2693 * modified Makefiles accordingly.
2695 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2696 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2697 when building in debug mode
2698 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2699 src/win32/gdcmdll.dsp
2700 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2702 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2703 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2706 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2707 * src/win32/libgdcmjpeg12.dsp was not dos format
2708 * src/win32/libgdcmjpeg12.dsp :
2709 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2710 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2712 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2713 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2715 * src/gdcmFile.cxx : bug fix in affectation type
2716 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2717 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2718 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2719 symbols... future problem ?
2721 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2722 * src/win32/libgdcmijpeg12.dsp was missing
2723 * modified gdcm.dsw accordingly
2725 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2726 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2728 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2729 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2730 commit of JPR (before his hollidays to facilitate our work).
2731 * setup.py : bug fix in code. Modifications made while the last commit
2732 of JPR. The code hasn't been tested before the commit... it's so
2733 useless to make that (for best programmer that is JPR) !!!
2735 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2736 * tagged the current version as Version0_3 (i.e. version 0.3)
2738 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2739 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2740 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2741 * *.dsp : modifications to use new libgdcmijpeg8 library
2742 * setup.py : bug fix on VTKPATH variable
2743 * PACKAGER : adding all concerning windows
2745 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2746 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2748 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2749 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2750 test suite reported error.
2751 * PACKAGER file added (describes what a packager must do when
2752 packaging a new release).
2753 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2754 * configure.in: upgraded version number to 0.3.0
2755 * fixing build of rpm (through rpm -ta):
2756 - Doc/Makefile.am exports proper doxygen files
2757 - src/jpeg/libijg8/Makefile.am exports the include files.
2759 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2760 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2761 * src/gdcmHeader.h : formatting code
2763 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2764 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2765 We were obtaining error message from vtk. Now, creation of file list
2766 is made in an internal list to prevent this problem.
2767 Bug fix when output is empty.
2768 Bug fix in update of progress value. Previous commit for this was a bad
2770 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2772 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2773 * src/gdcmHeader.h : added method to get the file name
2774 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2775 files. Added method to remove all files on the input
2776 Added FIXME comment concerning the bad parsing of header made by
2777 ExecuteInformation method (in ExecuteData method)
2779 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2780 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2781 when using make instal.
2782 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2783 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2785 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2786 * setup.py : adding include dir of jpeg lib to compile all sources
2787 * */Win32/*.dsp : JPR fix for windows compilation
2789 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2790 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2792 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2793 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2795 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2796 * setup.py is again effective on un*x (takes into account the
2797 addon of the jpeg library)
2798 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2799 * Doc/Doxy* updated (includes above enhancements)
2800 * INSTALL now points to web documentation
2802 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2803 * src/gdcmHeader.h doesn't make unnecessary reference to
2805 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2807 * src/gdcm*.[cxx|h] :
2808 - to allow compilation with gcc 3.x
2809 -- clean up of STL usage (added explicit usage of std::)
2810 -- small fixes on exceptions.
2811 Note: linking not tested !
2812 - clean of doxygen comments to avoid warnings at documentation
2814 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2815 dependent convertion).
2817 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2818 * Clean up of previous JPR garbage commit (not even commented in the
2820 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2821 - moved all jpeg related files from src to src/jpeg/libijg8, with
2822 addition/modification of Makefile.am and configure.in.
2823 - the testSuite is still brain damage (not guilty).
2825 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2826 * WrapVTK.py : modifications to get correctly vtk source files to
2828 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2829 (FileName -> Filename)
2831 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2832 * vtk/vtkGdcmReader.[cxx/h]:
2833 - UpdateProgress method should now be effective
2834 - removed the limitation on having only images loaded (as opposed
2836 - when building a stack of images/volume, a lesser number of
2837 gdcmHeader and gdcmFile instances should be used (hopefully
2838 accelerating things).
2839 - when building a stack of images/volumes, files which are not
2840 loadable (wrong path-filename, wrong permissions on existing file,
2841 or file not parsable by gdcm) are replaced with a black image
2842 in the stack (for the caller to notice the problem).
2844 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2845 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2847 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2848 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2849 between standard library (std) and vtk library (problems are found
2850 under Windows... thanks Windows !)
2852 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2853 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2855 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2857 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2858 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2860 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2861 * When compiling with distutils (see setup.py) the C++ compiler is
2862 called with different flags than the default ones (with automake).
2863 In order to fix all those warning, I compiled gdcm with the command
2864 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2865 and went for warning fixes:
2866 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2867 up from unused variables.
2868 - vtk/vtkGdcmReader.cxx: potential bug fix.
2869 * src/gdcmHeader.h: Doxygen warning cleanup
2871 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2872 * gdcmPython/gdcm.i:
2873 - typemaps correction to take into account the systematic replacement
2874 of "using namespace std" with std:: prefix e.g. std::list,
2875 std::string... (cf changes of 2003-05-21).
2876 - gdcmGlob global variable of type gdcmGlobal (defined in
2877 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2878 exported to Python a as cvar.
2879 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2880 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2881 gdcmDictSet.GetPubDictTagNames() and
2882 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2883 C++ static methods).
2884 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2885 with the above changes.
2887 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2888 * setup.py, manifest.in : bug fix under linux
2890 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2891 * Modification of setup.py to compile vtk part too. Then, we have 2
2892 wrappers which must work with same distutils. For that, we have a
2893 generic distutils in distusiltsWrapping.py ; with :
2894 - build_extWrap class to wrap generically all extensions,
2895 - ExtensionWrap base class for all wrapping extension that contains
2897 - Wrapper interface which wrap sources
2898 + In WrapSwig.py we have extension and wrapper for Swig
2899 + In WrapVTK.py we have extension and wrapper for VTK
2900 * MANIFEST.in : modifications to consider vtk directory and new python
2901 files for compilation
2903 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2904 * Added python wrappers of vtkGdcmReader vtk class (see the
2905 source in vtk/vtkGdcmReader.cxx) :
2906 - vtk/Makefile.am now builds a library
2907 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2908 python library (as opposed to _gdcm.so wich are the python
2909 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2910 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2912 - configure.in has an additional flag --enable-vtk that needs
2913 to be set to enable compilation of vtk related code, that is:
2914 + vtk/vtkGdcmReader.so and
2915 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2916 + gdcmPython/vtkgdcmPython.so (see above)
2917 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2918 be read when compressed or when HighBit + 1 != BitsStored),
2919 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2920 the usage of the python wrapper of vtkGdcmReader vtk class.
2921 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2922 * src/*.[h] all occurences of stl classes are now prefixed with
2923 std::, and all occurences of "using namespace std;" where removed.
2924 This is to avoid pollution of global namespace in included files.
2925 Apparently vtk does not avoid this pitfall: when using both
2926 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2927 collision of various stl members (principally cout...).
2928 * gdcmPython/testSuite.py now cleanly removes temprory generated
2930 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2931 comply with above changes)
2933 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2934 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2935 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2936 vtk data structure (an image Flip was required).
2937 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2938 * cosmetic changes in documentation.
2940 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2941 * src/gdcmHeader.cxx: the constructor no longer exits when an
2942 unexisting file is given as argument.
2943 * The subdirectory Data (containing all the images used for the
2944 test suite) is not part of this repository anymore. A new module
2945 containing those images is now available at
2946 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2947 with the name gdcmData.
2948 All the python scripts (including the package initialisation file
2949 gdcmPython/__init__.py) were adapated to take this change into
2950 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2952 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2953 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2954 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2955 demo of the usage of this class.
2956 Compilation of this vtk part is only done when using the --enable-vtk
2957 at configure (or autogen.sh) stage.
2959 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2960 * More memory link related corrections and documentation fixes.
2962 - maximum info is obtained with a command of the form:
2963 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2964 --show-reachable=yes PrintHeader
2965 - the remaining reachable blocks seem to come from the STL
2966 allocation scheme through the usage of map and list. It looks
2967 like this memory cannot be freed but it is not a memory leak
2968 (in fact further invocation to the STL would recollect the
2969 unused memory allthough it cannot explicitely be freed).
2970 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2971 of displaying an image parsed with gdcm and displayed with VTK.
2972 Note: some images don't seem to work e.g.
2973 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2974 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2975 Allthough this weakens the semantics, it is a ditch attempt to
2976 make gdcm more thread friendly.
2978 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2979 * Memory link hunt (by using valgrind through the command
2980 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2981 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2982 gdcmHeader::_dicom_vr.
2983 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2984 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2986 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2988 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2989 * src/Makefile.am now exports all the necessary include files at
2993 * UpdateGroupLength replaced by new one
2996 * UpdateGroupLength re-written using H-Table
2997 (named UpdateGroupLengthNew untill checks are over)
2999 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3000 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
3001 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
3003 - gdcmHeader::GetPubElValSet removed.
3004 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
3005 UpdateGroupLength, WriteElements, Write.
3006 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
3007 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
3008 carried the same semantics.
3009 - src/gdcmHeaderIdo.cxx changed accordingly.
3010 - gdcmFile::WriteBase now regroups all the codes from previous
3011 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
3012 - enum FileType moved to gdcmCommon.h
3013 * src/gdcmHeader.cxx AddDefault trashed
3014 * gdcmGetXSize added
3015 * getimageDataSize now calls gdcmGetXSize
3016 * Test/*.cxx changed to agree with above changes
3018 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3019 * src/gdcmHeader.h: LoadElements() is not a public method anymore
3020 (to avoid double call by end user).
3021 * Test/*.cxx LoadElements() doesn't need to be called explicitely
3022 by end user, since gdcmHeader::gdcmHeader now handles it.
3024 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3025 * gdcm/Doc many doxygen changes:
3026 - Doxyfile now has two different versions, DoxyfileUsers that generates
3027 the html.users end users oriented documentation and
3028 DoxyfileDeveloppers that generates the html.developper developper
3029 oriented documentation.
3030 - README changed accordingly
3031 - requirement.txt removed (old design info moved to TODO).
3032 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
3033 DoxyMainPage.txt, DoxyPython.txt provide more information.
3034 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
3035 be updated by simply regenerating the docs with doxygen and copying
3036 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
3037 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
3038 all the tests in the form "if (<map>.count() >1)" were removed.
3039 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3040 ill-formed documentation sections.
3041 * src/gdcmHeader.cxx: ditto
3043 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3044 * setup.py fixed for un*x (needed macro for stdint.h)
3045 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3046 un*ces with sh-utils test utility.
3047 * gdcmPython/demo/test.py renamed to PrintHeader.py
3048 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3049 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3050 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3051 * src/gdcm*.cxx JPR's bad inclusion fixed.
3053 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3054 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3055 * gdcmPython/demo/test.py changed accordingly.
3057 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3058 * gdcmPython/Makefile.am fixed linking against libstdc++
3059 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3060 * Swig subdir (historical tests of swig version 1.3.17++) removed
3061 * Test/testChangeEntete.cxx some lines commented out in order to make
3063 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3064 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3066 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3067 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3068 hence the user doesn't need this explicit call.
3069 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3070 i.e. LoadElements() call removed.
3071 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3072 - src/Makefile.am declares the proper flag for g++.
3073 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3074 for adding user defined new tags.
3075 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3076 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3077 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3079 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3080 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3081 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3082 src/Makefile.am : the project should properly compile and install
3083 with the autotools, included the python wrappers part.
3084 * gdcm.spec.in : added a spec file for RPM packaging.
3086 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3087 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3089 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3090 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3091 to exported to the environement (see gdcmPython/testSuite.py
3093 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3094 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3095 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3096 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3097 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3099 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3100 * gdcmPython/__init__.py doesn't crash anymore when running in
3101 in InstallMode or PreInstallMode but with an environment given
3102 value of GDCM_DICT_PATH.
3103 * src/gdcmDictSet.[cxx/h] coding style.
3105 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3106 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3107 * src/gdcm.h general comments moved to TODO, and README
3108 * src/gdcm.h should now be seen as a user commodity (including it
3109 should suffice to fully use gdcm). It is nowhere including within
3110 any of the kernel files src/*.cxx and src/*.h.
3112 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3113 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3114 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3116 * src/gdcm*.cxx only include their corresponding include file
3117 (as opposed to gdcm.h)
3118 * gdcmPython/gdcm.i changed accordingly
3119 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3120 the autogen.sh generated "make snapshot" command to work.
3121 * autogen.sh removed history related references to crea package.
3123 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3124 * distutilsSwigCPlusPlus.py work around some swig portability
3127 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3128 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3129 was done in a last ditch attempt to get setup.py _really_
3130 operationnal. The python/gdcmPython layaout add the advantage
3131 of hidding away the python related distutils specific files
3132 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3133 Alas, the src directory was out of scope (i.e. it's relative
3134 position to setup.py was ../src) which made things impossible to
3135 handle (see previous version of python/setup.py). Crossing fingers...
3137 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3138 * python/setup.py now works on Un*x. (harder than I thougth)
3139 * python/distutilsSwigCPlusPlus.py can now have include files
3140 among the list of sources.
3142 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3143 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3144 * modifications in MSVC projects
3146 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3147 * As stated by the first lines of Test/ExceptionAndPython/README, it
3148 looks like we can move back to original usage of exception within
3149 src/gdcm* and hence remove the errno stuff that was introduced
3150 as a quick and dirty fixture of this problem (added to the TODO).
3151 * Doc/Doxyfile configuration file for Doxygen and corresponding
3152 README file for usage added.
3153 * Test/testWrite.cxx added. This new test comes from a split of
3154 test.cxx that is now reverted to its original purpous i.e.
3155 testing the proper parsing of a Dicom related file.
3156 testWrite.cxx concentrates on testing the IO part of gdcm.
3157 * Test/bug1.cxx (containing a bug on WIn32) added.
3158 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3159 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3160 whose purpose is to publish the content of the TagNames of the
3161 Dicom public dictionary were not accessible without an
3162 instance of class gdcmHeader.
3163 - those methods are now static methods of gdcmDictSet and hence
3164 require no instances at all to be invocated.
3165 - within gdcmDictSet this change required to change some method
3166 to class methods (i.e. are now static) among which SetDictPath
3167 (renamed to BuildDictPath) and LoadDefaultPubDict.
3168 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3169 the above changes by calling the new method classes of gdcmDictSet.
3170 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3171 the above to be effective.
3172 * python/gdcmPython: in order to wrap properly the above changes
3173 for Python, swig version now needs to be > 1.3.17.
3174 * python/gdcmPython/Makefile fixed to adapt itself to new
3175 configure/make shema introduced by Johan Montagnat (thanks for the
3176 contribution). Alas this Makefile cannot be turned into a proper
3177 Makefile.am without some heavy changes in the configure.in
3178 (for python dectection).
3179 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3180 now avoids publishing the empty entries.
3182 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3183 * python/setup.py : bug fix concerning install under windows
3184 ExtraPath reused :-P
3185 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3187 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3188 * Dicts/dicomV3.dic : remove double spaces !!!
3189 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3190 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3193 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3194 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3195 method. Doxygenation.
3196 * src/gdcm.h clean up of JPR spurious comments.
3198 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3199 * python/distutilsSwigCPlusPlus.py now properly collects the
3200 shadow classes generated by "swig -c++" (gdcm.py in our case)
3201 when using "python setup.py install".
3202 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3203 reexports the working classes.
3204 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3205 by the classical C errno scheme. This is to prevent an obscure
3206 behavior of the python wrappers when importing wxPython.wx prior
3207 to gdcmPython (which ended up in an abort call). An illustration
3208 of this oddity can be found in the Test/ExceptionAndPython
3209 subdir (see the README file). This problem probably due to
3210 an combination of g++ and dynamic loading.
3211 * added Test/ExceptionAndPython (see above)
3213 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3214 * Changed the layout of the python part to avoid bloating main
3215 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3216 i.e. the distutils arsenal. All the python related stuff is
3217 again in a python subdir, but the package itself is now in
3219 * setup.py was cleaned up:
3220 - pythonIncludePath removed
3221 - python setup.py bdist target is now functional.
3222 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3223 collision with other packages). gdcmPython/demo/*.py changed
3226 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3227 * python subdir moved to gdcmPython (preparation of distutils packaging).
3228 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3229 distutils installer is operational.
3230 * - gdcmPython/__init__.py now properly loads the swig generated
3231 shadow classes (from gdcm.py).
3232 - gdcmPython/demo/*.py changed to import the package gdcmPython
3233 instead of gdcmPython/demo/load.py.
3234 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3236 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3237 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3238 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3239 entries within the associated public Dicom dictionary resp. the same
3240 information but sorted by the fourth field (PAT, IMG, DIR) of the
3242 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3243 are now in the "???" group.
3244 - python/gdcm.i changed accordingly,
3245 - python/demo/printGroupedPublicDict.py added, that gives an example
3246 of the above new functionalities in Python.
3248 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3249 * src/gdcm.h, gdcmHeader.cxx:
3250 - historic references to glib's g_malloc and g_free (#defined)
3251 were definitively removed.
3252 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3253 * src/gdcmElValSet.cxx:
3254 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3255 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3256 - GetElValue(string) renamed to GetElValueByName.
3257 - Added GetElementByName(string).
3258 * src/gdcmHeader.cxx: added
3259 - GetPubElValRepByNumber(guint16, guint16)
3260 - GetPubElValRepByName(string)
3261 - GetShaElValRepByNumber(guint16, guint16)
3262 - GetShaElValRepByName(string)
3263 - GetShaElValByNumber(guint16, guint16)
3264 - GetShaElValRepByName(string)
3265 - GetElValRepByNumber(guint16, guint16)
3266 - GetElValRepByName(string)
3267 - GetElValByNumber(guint16, guint16)
3268 - GetElValRepByName(string)
3269 * Doc/requirements.txt added.
3271 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3272 * Test/Makefile building now depends on the one of libgdcm.so
3273 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3274 pixel data) aware which enables finding the address (offset) of
3275 the pixel data of JPEG encoded DICOM files. This leaves only a single
3276 file in the testSuite whose pixel data address (offset) is unknown.
3277 * python/testSuite.py changed accordingly.
3279 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3280 * VC++ has some strong limitations when working with the STL, as stated
3281 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3282 "Also note that some STL containers (map, set, queue, list, deque)
3283 cannot be exported. [...]
3284 Some STL classes contain nested classes. These classes can not
3286 This is caused by a designed limitation that once a template
3287 class is instantiated, it can not be re-instantiated and
3289 Since our usage of map<> is ubiquitous in gdcm, this "designed
3290 limitation" of VC++ is a pitfall.
3291 Hence the Python wrappers of gdcm cannot be incrementally linked
3292 against the c++ dynamic library. The dirty but only workaround is
3293 to forget about incremental link of dynamic libraries and to generate
3294 the Python wrappers library with the inclusions of the underlying C++
3296 The following modifications concern this matter on Win32/VC++:
3297 - wrapping python correct with standalone wrapped dll (don't use separate
3298 dll under windows !!!!)
3299 - python21_d debug mode enabled (ask Frog how to use it :-)
3300 - NO problem with having an STL member of class for example string in C++
3301 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3302 - Python test of dcmlib in Python is ok under windows on a large set
3304 * removed glib references
3305 * typedef's inserted in gdcm.i for correct swig type management
3307 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3308 * python/demo/*.py load.py extracted from test.py. Added explore.py
3309 that only displays required tags and testAll.py that parses all
3310 the files of the testsuite without using unittest.
3311 * python/testSuite.py other additional test on new files added.
3312 * Data/* new test files added accordingly to the testSuite.
3313 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3314 the vr in the file differs from the one of the dictionary.
3316 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3317 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3318 values, but limits itself to values which are below a user specified
3319 size (by default 1024 bytes).
3320 * python/gdcm.i : elements not loaded (because their size is above the
3321 user specified treshold) are exported with their TagKey as key of the
3322 python dictionary. This enables the testsuite to make some checks
3323 on the unloaded elements (since we have their offset and size).
3324 * python/testSuite.py
3325 - now tests for the existence and proper value of the pixel data
3326 - two new examples added.
3327 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3329 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3330 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3331 aware. See the strategy comments in gdcmHeader::FindLength().
3332 * Test/test.cxx now accepts a filename as first argument.
3333 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3334 * python/testSuite.py changed to integrate test on above files.
3336 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3337 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3338 the vr was also RET.
3339 * python/testSuite.py more tests added.
3341 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3342 * python/testSuite.py unittest test suite added (uses Data)
3343 * Data/* dcm and acr files for the test suite.
3344 * glib dependance removed from un*x version. We now use ISO C99
3345 7.18 Integer types (see stdint.h)
3346 - python/Makefile, src/Makefile src/gdcm.h
3347 * src/ when an explicit vr (like dicom files) suddenly poped an
3348 implicit element we use to mark the underlying DictEntry of the
3349 concerned ElValue with "Implicit". This strategy was damageable
3350 too the public or provite dictionaries, since some of their vr
3351 would be changed. Since Header::FindLength heavily relies on the
3352 detection by Header::FindVR of falsely explicit elements, I
3353 added an extra ImplicitVr member to ElValue (boolean).
3354 The rest of the changes we the necessary adaptations.
3356 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3357 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3359 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3361 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3362 * Adaptation for porting to VC++:
3364 o forced to use std namespace (for string to be known)
3365 o all class use __declspec export style on WIN32
3366 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3367 (in stdlib.h on Win32 but in std:: for gcc)
3368 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3369 variable GDCM_DICT_PATH.
3370 * src/gdcmHeader.cxx verbose comments made discrete.
3372 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3373 * python/gdcm.i: added a typemap that converts a C++ hashing table
3374 to native Python dictionary.
3375 * python/demo/test.py:
3376 - now uses the native dictionary for exploration of gdcmHeader.
3377 - takes an optional filename argument (the file to parse).
3378 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3379 PubElVals hashing table.
3380 * Dicts/dicomV3.dic removed error prone trailing spaces.
3382 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3383 * Python wrapping process moved away from src/Makefile to
3384 newly created python/Makefile (as well as gdcm.i)
3385 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3386 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3387 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3388 from the environement variable GDCM_DICT_PATH (when existing).
3389 * src/gdcmDict::GetTag bug fix.
3391 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3392 * Straightforward temporary fixes for swig to build the python wrappers.
3393 src/Makefile now has a python working entry [by working we mean
3394 that we can import the shadow classes without errors].
3396 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3397 * hashtest.cxx removed (since already in Test)
3398 * src/gdcmlib.h renamed to src/gdcm.h
3399 * src/dcm.i renamed to src/gdcm.i
3400 * src/Makefile prepared for python wrapping
3402 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3403 * src/gdcmHeader.cxx :
3404 - Parsing of header is now separated from loading of element values
3405 (see gdcmHeader::LoadElements).
3406 - general clean up of hopefully all file access (creation of
3407 ReadInt16 and ReadInt32)
3409 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3410 * src/gdcmHeader.cxx :
3411 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3413 - SetLgrElem renamed to SetLength
3414 - GetLgrElem renamed to GetLength
3415 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3416 * src/gdcmElValSet.cxx fixed both GetElValue methods
3417 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3418 due to IdoDude was cleaned out.
3420 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3421 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3422 concentrates on finding the value representation (when it exists).
3423 RecupLgr now only finds the element value length, and it avoids
3424 returning the unecessary skL (skipped length).
3425 Also, offsetCourant was simply removed (with taille_fich) since
3426 it was redundant with the File position internals (by using
3427 ftell and fseek). This also made skL (see above in RecupLgr) usage
3429 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3430 on the libido specificities which are handled through class
3432 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3435 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3436 * Truckload of changes. Parsing of header is barely functional
3437 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3439 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3440 * src/gdcmHeader.cxx many addons of low level methods
3442 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3443 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3444 and _IdDcmSWAP_LONG.
3446 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3447 * This corresponds to all the changes decided at the meeting of
3448 May 23 2002. Needless to say we are running late...