1 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * Added Doc/Website/CodingStyle.html, Developpers.html,
3 DeveloppersPython.html, GdcmDataCvs.html and
4 DownloadVersion0_1.html, DownloadVersion0_3.html.
5 * Some Doc/*.txt Doxygen files (which do not really concern the
6 documentation itself, but the website) moved to html and
7 placed in directory Doc/Website:
8 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
9 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
10 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
11 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
12 * CMakeLists.txt changed accordingly.
13 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
14 DeveloppersPython.html
15 * INSTALL nows refers to Doc/Website/Installation.html
17 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
18 * Added Doc/Website directory, that contains a first raw version
21 2004-09-23 Jean-Pierre Roux
22 * FIX In order not to be poluted any longer by casting problems,
23 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
24 we can now delete[] it safely
25 * VoidArea is now called BinArea (less confusing name),
26 and all the methods called ...VoidArea... are now ... BinArea...
27 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
29 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
30 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
31 clear) TagHT, which is an inherited member of gdcmElementSet. It is
32 up to the destructor of gdcmElementSet to clean up TagHt and it's
35 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
36 * Test/CMakeLists.txt: update to follow gdcmData renamings.
37 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
39 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
40 * ENH: added some utility method that builds a flat dictionnary
41 holding all the Dicom entries contained in the recursive structure
42 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
44 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
45 BuildFlatHashTable() that build a flat dictionary.
46 - src/gdcmElementSet.h: added a new private GetTag() accessor.
47 gdcmDocument is now a friend of gdcmElementSet.
48 - src/gdcmElementSet.cxx: clean up.
49 - Example/FlatHashTablePrint.cxx added.
50 - Example/CmakeLists.txt changed accordingly
52 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
53 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
54 moved away from gdcmDocEntrySet (since this class is an abstract class
55 acting like an interface). SQDepthLevel and BaseTagKey are now
57 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
58 and associated accessors. Doxygenation of the class.
59 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
61 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
62 Use SQDepthLevel accessor instead. ::Print() adapted.
63 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
64 - src/gdcmDocument.cxx changed accordingly.
66 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
67 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
68 - The following is the doxygen comment of the typedef declaration
69 of gdcmagKey in src/gdcmCommon.h:
70 gdcmTagKey is made to old an "universal" (as in URL, Universal
71 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
72 A dicom tag allways has a group and an element, but a set of tags
73 embeded in various (optionally nested) sequences and sharing
74 the same group and element all share the same (group, element)
75 "identifier". Hence the (group, element) cannot be used as an
76 identifier (in gdcm we shall refer to a "TagKey") of a tag.
77 In order to construct a proper tag identifier (i.e. a key) we
78 consider the following definition of a TagKey:
79 - let Group, Element be the string representation of the
80 group and element dicom tag members,
81 - let ItemNumber be the string representation of the integer
82 index of the considered item number of a sequence,
83 Let the key of a tag embeded in a sequence, noted SeqTag, be
85 /ItemNumber#Group|Element
86 where "/", "#" and "|" are characters acting as separators.
87 Then the general form of a gdcmTagKey is given by:
89 where <SeqTag> means NO or many instances of SeqTag.
90 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
93 but the gdcmTagKey of a tag "embeded" is the first item of
94 a sequence, itself nested in the third item of a sequence is the
96 0004|1220/2#0008|0082/0#0008|0090
97 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
98 order to hold the new sequence compatible key. Previously, the
99 GetKey() method would look in the underlying gdcmDictEntry.
100 - src/gdcmDocEntry.cxx:
101 -- constructor now copies the underlying DictEntry key, in the local
103 -- ::Print: displays the member Key, instead of the (group, element).
104 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
105 - src/gdcmDocEntrySet.h:xi
106 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
107 -- now has a new BaseTagKey member.
109 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
110 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
112 This poses the problem with the semantics of the following lines
113 LoadEntryVoidArea(0x0028,0x1201); // R LUT
114 LoadEntryVoidArea(0x0028,0x1202); // G LUT
115 LoadEntryVoidArea(0x0028,0x1203); // B LUT
116 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
117 to the long FIXME note for what the problem is. Nevertheless in
118 order to get things working the dicom dictionary was altered !
119 Please fix things urgently...
120 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
121 information), see above note on moving the member VoidArea. Nevertheless
122 the following entries previously correctly set as US are now inproperly
124 0028 1201 OW IMG Red Palette Color Lookup Table Data
125 0028 1202 OW IMG Green Palette Color Lookup Table Data
126 0028 1203 OW IMG Blue Palette Color Lookup Table Data
127 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
128 of gdcmDocEntry moved to gdcmSeqEntry.
129 * src/gdcmSeqEntry.cxx: STYLE.
131 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
132 * Test/TestAllEntryVerify.cxx minor fix and added comments.
134 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
135 * gdcmPython/testSuite.py: all the test suite in python is now moved
136 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
137 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
138 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
140 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
141 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
142 to avoid inclusion recursion until STL is reached.
143 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
144 mecanism. errno.h is not included in gdcm anymore.
145 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
146 (gdcmFormatError now inherits from gdcmFormatUnexpected).
148 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
149 gdcmData/TestAllEntryVerifyReference.txt
150 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
151 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
152 exception_on_error parameter.
153 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
154 - vtk/vtkGdcmReader.cxx changed accordingly,
155 - Example/*.cxx and Test/*.cxx changed accordingly.
157 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
158 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
159 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
160 enable_sequences removed from gdcmHeader constructor and dependencies.
161 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
162 * gdcmPython/demo/PrintHeader.py: dummy fix.
163 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
164 skip_shadow removed from gdcmHeader constructor and dependencies.
165 * Example/*.cxx and Test/*.cxx changed accordingly.
167 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
168 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
169 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
171 2004-07-21 Jean-Pierre Roux
172 * FIX Now, Parsing and Printing a DICOMDIR do work!
173 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
175 2004-07-20 Jean-Pierre Roux
176 * FIX Some brain damaged headers have Zero-Lenght fields
177 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
179 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
180 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
181 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
182 variable (instance of gdcmDebug) by a definition macro, and the instance
183 is now in static in the gdcmDebug class
184 * src/gdcmSQItem.h : (FIXME) remove an undefined method
185 * Test/PrintAllDocument.cxx : bug fix in the result of the test
187 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
188 * WARNING: ctest now depends more tightly on gdcmData. You should
189 check out gdcmData properly for things to run smoothly...
190 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
191 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
192 we need the pixels not be loaded in order to use the ValEntry
193 that displays position and size).
194 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
195 This is a C++ based equivalent of gdcmPython/testSuite.py that should
196 be deprecated. If you have any doubts about the advantages of a
197 modern scripting language (read Python) versus grass root C++ (i.e.
198 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
199 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
200 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
201 Anyhow, consider documenting the gdcmData images in
202 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
204 * Test/CMakeLists.txt:
205 - now uses TestAllEntryVerify.cxx
206 - specific comments on oldACR00001.ima (now renamed in gdcmData
207 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
208 gdcmData/TestAllEntryVerifyReference.txt
211 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
212 * src/*.[h|cxx] : typedef clean up
213 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
214 - TagKey renamed to gdcmTagKey (for external usage)
215 - VRKey renamed to gdcmVRKey (for external usage)
216 - removal of typedef duplication.
217 - Removed all unecessary inline keyword from class inline definitions.
218 - Some method|function(void) declarations replaced with method|function().
219 * src/jpeg/libijg12/jdhuff12.c:
220 - printf polluting ctest removed.
221 - TAB removal for comminting
223 - TestAllReadCompareDicom.cxx: added a test that compares all the
224 images in gdcmDataImages.h with corresponding images in
225 gdcmData/BaselineDicom/. When baseline images are not present
226 this test creates them.
227 Note: we need to validate each reference image, but before that
228 I'd like to rename them with a more explicit name...
229 - CMakeLists.txt: changed accordingly.
230 * Example/*.cxx: examples now only include gdcm.h (as opposed to
231 including each header needed).
233 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
234 * Test/*.cxx and Example/*.cxx: moved some examples away from the
235 test suite to the Example directory. Are concerned:
240 - TestWriteSimple.cxx
241 * Test/CMakeLists.txt: added some comments on reasons for black listing
242 image gdcmData/oldACR00001.ima
244 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
245 * Test/CmakeList.txt: removed the following from black list (to be coherent
246 with removal from gdcmData):
247 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
248 - gdcm-MR-PHILIPS-16.dcm
250 Added the following because after last cvs update, they cause
251 ctest -R TestReadWriteReadCompare
253 - gdcm-MR-SIEMENS-16-1.acr
255 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
256 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
257 new comments in this file) we temporarily (sigh) move to a weaker
259 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
260 we don't need to black list the following images anymore:
261 - 8BitsUncompressedColor.dcm
263 - US-PAL-8-10x-echo.dcm
264 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
265 fixes and the beautified code ;-)
266 This fixes the bug introduced in version 1.42 (when beautifying)
267 that made the parsing of 8BitsRunLengthColor.dcm unproper.
268 Note: ctest was blind to this bug (this means we need to still
269 improve the test suite). The bug could be detected by using
270 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
272 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
273 and by displaying the (garbage) produced file temp.XDCM...
275 2004-06-29 Jean-Pierre Roux
276 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
277 - replace by uggly but working old code :-(
278 A lot of things should be OK again.
279 It's really urgent to have a test suite that *tests*,
280 to prevent Frog's beautifying sessions to break all the stuff
281 (twice, withing a fortnigh ...)
283 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
284 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
285 redundancy) to added Test/TestReadWriteReadCompare.cxx
286 * Test/CmakeList.txt: because the compare test of
287 Test/TestReadWriteReadCompare.cxx fails, the following images are
288 black listed: - 8BitsUncompressedColor.dcm
290 - US-PAL-8-10x-echo.dcm
291 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
292 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
293 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
294 and ad-hoc kludge. This kludge is now removed, and on encountering
295 such an image (OB field brain damaged) we set errno. Then in
296 ::FindDocLength() we "fix" the length as being ALL what remains
297 in the file (until EOF). We then proceed, hoping for the best...
298 This fixes a SegFault in ShowDicom when trying to write such an
300 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
301 (because TestWriteRead breaks on it, after a non conformal commit?).
302 ctest now runs properly, except for MakeDicomDir (which was allways
303 broken) and the Python related stuff (still not fixed).
305 2004-06-24 Jean-Pierre Roux
306 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
307 FIX : Test/TestReadWrite now iterates on all the file names
308 (instead of infinite loop)
309 ENH : Test/TestWriteRead now iterates on all the file names
311 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
312 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
314 2004-06-24 Jean-Pierre Roux
315 FIX : - now Write drops LUT Descriptors and LUTs (if any)
316 when SamplesPerPixel =3
317 - now Write is no longer confused by
318 'BitsAllocated = 12" and 'BitsStored=12"
319 - "UN" value representation Elements are now written correctly
320 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
321 ENH : - now gdcmHeader has its own Write methods
322 (in order to split the job that has not to be done
325 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
326 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
327 loop on the same image until memory went out.
328 Note: this means we still have gobs of memory loss in PrintDocument
329 * src/gdcmDocument.cxx: fixes problem on parsing on file
330 gdcmData/16BitsJpegLosslessGrayScale.dcm.
332 2004-06-24 Jean-Pierre Roux
333 FIX : Write - All the Sequences and Sequence Item are now written
334 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
335 is added a the end, when necessary.
336 - A lot of brain-damaged images, that were read correctly are
337 now written correctly
338 - length compatible BinEntry are now loaded correctly
339 (even for odd groups)
340 Note : only Explicit Value Representation was checked.
341 (question : is implicit VR really necessary for gdcm ?)
343 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
344 * DEVELOPPER: added a proposition of coding style.
345 * src/gdcmDocEntry.h: removed every inline declaration (for test of
348 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
349 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
350 Use the gdcmDocEntry::Print() and Write() instead.
351 * src/gdcmDocument.cxx: bug fix.
353 2004-06-22 Jean-Pierre Roux
354 FIX : gdcmDocument.cxx
355 - Now we do recognize the JpegLossLess format (there was a misstyping in
356 code 'beautyfication' :-(
357 - Now we automaticaticaly load the Luts, if any
359 2004-06-22 Jean-Pierre Roux
360 In order : to write Sequences, whatever their imbrication level,
361 : to allow user to create his own Sequences
362 a lot of modif where necessary (adding, moving, or virtualising methods)
364 WARNING : save your own sources *before* cvs up !
367 ADD virtual void Write(FILE *fp, FileType filetype);
370 ADD virtual void Write(FILE *fp, FileType filetype);
371 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
374 ADD virtual void Write (FILE *fp, FileType filetype)=0;
375 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
376 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
377 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
378 ADD std::string GetEntryByName(TagName name);
379 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
381 std::string vr = "unkn",
382 std::string fourth = "unkn",
383 std::string name = "unkn");
384 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
385 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
386 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
387 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
388 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
389 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
390 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
391 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
394 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
395 ADD virtual std::string GetEntryByName (TagName tagName);
396 ADD virtual std::string GetEntryVRByName (TagName tagName);
397 REM virtual bool Write(FILE *, FileType);
398 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
399 FILE *_fp, FileType type);
400 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
401 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
402 REM virtual bool WriteEntries(FILE *_fp,FileType type);
403 REM virtual std::string GetEntryByName (std::string tagName);
404 REM virtual std::string GetEntryVRByName (std::string tagName);
405 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
406 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
407 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
409 std::string vr = "unkn",
410 std::string fourth = "unkn",
411 std::string name = "unkn");
412 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
413 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
414 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
415 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
418 ADD virtual void Write(FILE *fp, FileType filetype);
421 ADD virtual void Write(FILE *fp,FileType filetype);
424 ADD virtual void Write(FILE *fp, FileType filetype);
425 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
426 REM std::string GetEntryByNumber(guint16 group, guint16 element);
427 REM std::string GetEntryByName(TagName name);
430 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
432 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
433 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
434 The default constructor invoked by the line
435 gdcmHeader *f1 = new gdcmHeader( header );
436 was gdcmHeader::gdcmHeader(bool) instead of the expected
437 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
438 Hence the parsing wasn't executed... See also below.
439 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
440 as explicit constructor didn't do the trick to fix the above problem.
441 Could anyone explain why ?
442 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
443 properly calls gdcmValEntry::Print() (that was weed out from
444 code related to gdcmBinEntry).
446 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
447 * In order to fix memory leaks:
448 - Test/TestWriteSimple.cxx: added cleaning of free store through
450 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
451 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
452 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
453 (through the call to ::AddDicomDirMeta()) or the destructor
454 would crash when deleting uninitialized ::metaElems].
455 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
456 - src/gdcmDocument.cxx:
457 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
459 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
460 was causing memory leaks.
461 - src/gdcmSQItem.cxx:
462 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
463 cleanly handled with polymophism: sorry but my milage is low).
464 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
465 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
466 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
467 This avoids SegFaulting.
468 - src/gdcmSQItem.h: coding style.
470 - Test/TestWriteSimple still severely sucks. The output image content
471 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
472 damaged when displayed with vtkgdcmViewer.
473 - on memory leaks: TestWriteSimple leaks really less (see entry
474 of 2004-06-18 in Changelog file for the call to valgrind).
475 - on segfaults: ctest now passes all the tests but one (no more
477 * Erroneous leading white fix:
478 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
479 white[s] (as opposed to from >> xxx, that removes it [them].
480 - src/gdcmTS.cxx: ditto.
481 - gdcmPython/testSuite.py: dirty related kludge removed.
482 * src/*: remaining references to gdcmParser removed.
483 * src/*[cxx|h]: added copy[way]left header.
486 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
487 * In order to fix writing of dicom files:
488 - Test/TestWriteSimple.cxx: a simpler example of writing.
489 - Test/CMakeLists.txt changed accordingly.
490 - src/gdcmDocument.cxx:
491 -- The destructor now recursilvely removes potential sequences.
492 -- Bug fix in ::IsJPEG2000()
493 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
494 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
496 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
497 to only declared) and build on top of
498 ::GetDocEntryByNumber(guint16, guint16).
499 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
500 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
501 for usage in destructor and treatement of promotion in
502 ::ReplaceOrCreateByNumber().
503 - src/gdcmSQItem.cxx: destructor should better handle his job.
504 Test/TestWriteSimple now runs (or at least it DOES something).
505 * We can now start hutting memory links. A good starting point is:
506 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
507 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
508 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
510 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
511 * Valgrind note: after Mathieu Malaterre teached me how to read
512 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
514 Using gcc, you can force the STL to use malloc and to free memory as
515 soon as possible by globally disabling memory caching.
516 With 3.2.2 and later, you should export the environment variable
517 GLIBCPP_FORCE_NEW before running your program.
518 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
519 simply vanish (it is still not clear to me, whether this means that
520 STL std::string leaks or if valgrind believes it leaks...).
521 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
522 running bin/gdcmTests makeDicomDir):
523 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
524 - Test/makeDicomDir.cxx now properly traps empty lists and returns
526 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
527 SegFaulting (I drowned in DicomDir related code when trying to
528 understand why the list is empty...).
529 * src/gdcmDocument.h: first BSD license header try.
530 * Doc/License.txt added.
532 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
533 * src/gdcmDocument.[h|cxx]:
534 - Clean up of the Transfer related predicates. They are now all based
535 on new method isGivenTransferSyntax, that (should) handle properly
537 - general clean up, simplification, and coding style.
538 - Specific clean up of Parse7FE0() (umproperly named actually).
539 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
541 2004-06-14 Jean-Pierre Roux
543 - fix the display of Sequence Delimitor (SQDepthLevel pb)
544 - fix the display of SQItem ordinal number
545 - add the GetSQItemByOrdinalNumber method
546 - remove some useless never written private methods
548 2004-06-14 Jean-Pierre Roux
550 - adding a constructor taking a gdcmDocEntry as an input param
551 - ReplaceOrCreateByNumber now returns :
552 a gdcmBinEntry * if a Binary (void *) value is passed as a param
553 a gdcmValEntry * if a string value is passed as a param
555 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
556 according to the param type (no longer sets a gdcmDocEntry)
557 - GetValEntryByNumber, GetBinEntryByNumber added
558 - NewValEntryByNumber and NewBinEntryByNumber added
560 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
562 - GetSQItemNumber and SetSQItemNumber added, to provide
563 a (relative) Item identier inside a given Sequence
564 \warning : some pb remaining around this number
566 - AddEntry now takes the Item Number as a param
568 - adding a constructor taking a gdcmDocEntry as an input param
570 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
571 * Memory leak hunt with the following command:
572 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
573 --show-reachable=yes gdcmTests PrintDocument
574 It looks like many (all?) leaks are due to the STL (or a bad usage
575 of the STL. The lines producing the leaks now have a comment with
576 a "MEMORY LEAK" tag: you can retrieve them with
577 grep "MEMORY LEAK" src/*
578 Here are two typical examples which I can't help fixing:
583 char * test = "babo";
584 name = test; //// <--- valgrind detects 960 bytes lost in
585 //// call to std::string::operator=(char const*)
586 name.clear(); //// Doesn't help !
594 std::cout << "Type a bunch of characters followed by RETURN: ";
595 getline(std::cin, line); //// <--- valgrind dectects a loss
596 //// of 1320 bytes in call to
597 /// std::basic_istream<>& std::getline<>
603 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
604 * src/gdcmHeader.[cxx|h]:
605 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
606 and related, moved away to gdcmDocument.
607 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
608 the corresponding protected accessors of inherited class
609 gdcmDocument, removed ! As a consequence gdcmFile had to be
610 declared friend of class gdcmDocument (see below).
611 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
612 - Clean up of undefined or unused methods.
613 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
614 account the changes to gdcmHeader.h).
615 * src/gdcmDocument.h:
616 - gdcmFile is now a friend class (in order to take into account the
617 changes to gdcmHeader.h).
618 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
619 (see changes to gdcmHeader.h).
620 - Accessors (reading on the form GetEntry*) are now public.
621 - Clean up of undefined or unused methods.
622 * src/gdcmDocument.cxx:
623 - adaptation to changes to gdcmDocument.h
624 - ::OpenFile now writes a verbose message when file cannot be opened.
625 - some std::string properly set to VRKey
626 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
627 references to gdcmDocument.
628 * Test/TestFindTags.cxx: changed accordingly to above changes.
629 * gdcmPython/testSuite.py: adapted to renaming of acr files in
630 cvs repository gdcmData.
632 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
633 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
634 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
635 conflicts with gdcmValEntry::voidArea.
636 * src/gdcmValEntry.cxx: unmatching comment wiped out.
637 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
638 Value representation between StringRepresentable and BinaryRepresentable.
639 * src/gdcmDocument.cxx:
640 - method ParseDES: proper indentation restored and usage of
641 gdcmVR::IsVROfGdcmStringRepresentable wired in.
642 - method LoadDocEntry: the fingerprint left in the SetValue() of
643 unloaded entries (length > MaxSizeLoadEntry) had curiously been
644 removed. Reverting to previous code segment with the proper
645 dynamic_cast< gdcmValEntry* >.
646 Note: this was (partially) breaking the python test suite
647 (gdcmPython/testSuite.py) that made usage of the above
648 fingerprint to check presence of "Pixel Data".
649 * src/gdcmDocEntry.h: coding style.
650 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
651 now taken into account.
652 * gdcmPython/gdcm.i: adaptation to the new internal representation
653 of gdcm (exit gdcmParser, hello gdcmDocument).
654 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
656 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
657 anymore, but instead prints the loaded Python dictionary.
658 * .... alas, the python testSuite is still broken.
660 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
661 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
663 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
664 * src/gdcmUtil.h : export methods
666 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
667 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
669 * Initial addition of automatic python testing
670 * Initial addition of automatic image comparison
672 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
673 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
674 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
676 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
677 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
678 * Test/ShowDicom.cxx : bug fix for msvc compilation
679 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
681 2004-05-04 Jean-Pierre Roux
682 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
683 new concepts (and new classes) :
684 a 'gdcmDocument' is composed of a set of Doc Entries, that are
685 - elementary gdcmDocEntries (former gdcmHeaderEntries)
686 - Sequence Doc Entries (gdcmSeqEntries)
687 a Sequence is composed of Items.
688 Each item is a set of Doc Entries (this is recursive)
689 The non uniqueness of the 'Dicom tag' is due to this recursivity
690 (never taken into account)
691 Our unability to add a new 'entry' in the header
692 at the proper location (neither in the H-Table (map or multimap),
693 nor in the Chained List is also due to this recursivity.
694 Don't try, right now, to use/modify/compile these new sources :
696 We just commit all the stuff, 'as is', in order not to loose it.
698 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
699 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
701 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
702 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
703 file prefix (SetFilePrefix)
705 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
706 * Add a new test: ShowDicom, for now this is just the c++ version of
707 checkRead.sh, later it will be able to compare the image read against a
709 * Replace the DEBUG on the stack with a global entry in cmake interface:
710 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
712 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
713 * Add an example subdir, with a real example on how to read + write a
716 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
717 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
718 * Doc/CMakeLists.txt: the main page is now properly differentiated
719 between the developper and user version.
720 * Doc/doxygen.config.in: dropped search related obsolete flags
721 * src/gdcmParser.h, gdcmHeader.h: doxygenation
723 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
724 * DEVELOPPER: added some helpfull comments for compile/test/install
727 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
728 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
729 src directory, now generated in the build dir.
730 2. Tests as mentionned smarter
732 4. Add a new method in gdcmDict that return the PubDict by name
733 this is interesting for 3rd party lib like ITK,
734 where we could set the institution name / patient name...
736 * ENH: 1. Now the test suite is working for real
737 2. All binaries are now output in the gdcm-bin directory
738 (this was not true before)
740 2004-04-28 Jean-Pierre Roux
741 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
742 SeQuence indented printing of Dicom Header.
743 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
744 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
745 Computation of SQDepthLevel is now part of gdcmHeader constructor
746 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
747 tree-like structure of a Dicom Header.
748 * FIX Test code cleaning
750 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
751 * ENH: Adding automatic testing
752 1. Need a DartConfig.cmake to submit to public
753 2. Add a test driver gdcmTest.cxx
754 3. gdcmTestMain, an helper for the main test driver gdcmTest
755 4. Files in Test don't have a main anymore, this becomes interesting
756 when we add more and more tests, thus dsw don't have to load
758 * ENH: Adding a GDCM_DATA_ROOT for testing
759 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
760 one file instead of seven + some small cleanup
762 2004-04-22 Jean-Pierre Roux
763 * ENH Minor changes to the Print() methods.
764 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
765 Header printing. Example given with :
766 > PrintHeader fileName 2 new
767 (SQ based tree-like structure still to be done for the Header ...)
769 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
770 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
771 1. I have added some unsigned where needed
772 2. Some function parameter not used -> (void)
773 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
774 4. g++ don't like character '\' in comment
775 5. #define jpeg_create_decompress jCreaDecompress
776 this really need to be fixed
777 6. virtualize destructor of gdcmObject ... leakage
778 7. sscanf(g->first.c_str(),"%x",&gr_bid);
779 this also really need to be fixed
780 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
781 remove compression file
782 (as we only do decompression, right ?)
783 * ENH: Change malloc/calloc/free with c++ equivalent
785 2004-04-21 Jean-Pierre Roux
786 * FIX gdcmHeaderHelper::GetXSpacing
787 when a single value is found (bug ?), xpacing is now
788 defaulted to yspacing
790 2004-04-19 Jean-Pierre Roux
791 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
792 * ENH add parameters :
793 bool exception_on_error = false,
794 bool enable_sequences = false,
795 bool ignore_shadow = false
796 to the gdcmFile constructors to be full gdcmParser compliant
797 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
798 to allow reading of PAPYRUS 3.0 files
800 2004-04-06 Jean-Pierre Roux
801 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
803 2004-04-02 Jean-Pierre Roux
804 * ADD : Test/checksequence.sh, for a general recap on SQ pb
805 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
806 for Philips spurious Tag fffe|0000 while rewritting Dicom files
808 2004-03-30 Jean-Pierre Roux
809 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
810 for ACR file, written out as DICOM files (hope so...)
812 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
813 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
814 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
815 moved to base class gdcmParser and only the specialisation is kept
817 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
818 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
819 already does the job.
820 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
821 (to be consistent with gdcmParser::WriteEntries).
823 2004-03-30 Benoit Regrain
824 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
825 upate of the object's instance. It's passed to 2 in the unfavorable
826 case : one in the ExecuteInformation, one in the ExecuteData
828 2004-03-29 Jean-Pierre Roux
829 * ENH : Check on file type to be written moved
830 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
831 * FIX : gdcmObject::ResetBoundaries now stops properly
832 when end-of-list is reached
833 : gdcmVersion modified (as Benoit Regrain asked)
835 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
836 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
837 * src/gdcmUtil.cxx: added forgotten iostream include.
838 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
839 equivalent to ExplicitVR in existing code).
841 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
842 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
843 now contains all the gdcmGlobal related code.
844 * minor coding style and doxygenation changes.
846 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
847 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
848 now contains all the Debug related code.
849 * minor clean-up of includes in src/*.cxx
850 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
851 CreateCleanString) removed.
852 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
853 * Doc/DoxyMainPageUser.txt added.
854 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
855 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
858 2004-03-24 Jean-Pierre Roux
859 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
861 2004-03-23 Jean-Pierre Roux
862 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
863 big endian made volumes
864 * ENH Now gdcmParser constructor and destructor are protected to forbid
865 end user to instanciate class gdcmParser
866 (only gdcmHeader and gdcmDicomDir are meaningfull)
868 2004-03-22 Benoit Regrain
869 * FIX : src/gdcmDicomDir.cxx : make windows compilable
870 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
871 gdcmSerie to gdcmDicomDirSerie
873 2004-03-19 Jean-Pierre Roux
874 * ENH Now the tree-like structure describing a DICOMDIR comming from
875 an already existing DICOMDIR file is consistent with
876 the home-made tree-like structure build ex-nihilo
877 or build from the files held (recursively) in a Directory
878 functions gdcmDicomDir::CheckBoundaries()
879 gdcmObject::SetBoundaries() added
881 2004-03-17 Jean-Pierre Roux
882 * REM (Eric Boix bug) : removal of meaningless
883 gdcmDicomDirImage::NewImage function.
884 * FIX now file names and directory name are written properly in the
886 * FIX now gdcmDicomDir constructor may be call without any trick
889 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
890 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
891 of gdcmDicomDirImage::NewImage as empty function.
893 2004-02-28 Jean-Pierre Roux
894 * ENH add gdcmDicomDir:NewPatient
895 add gdcmDicomDirPatient:NewStudy
896 add gdcmDicomDirStudy:NewSerie
897 add gdcmDicomDirSerie:NewImage
898 to allow making gdcDicomDir object.
899 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
900 (as opposite to the gdcmHeader chained list)
902 2004-02-11 Benoit Regrain
903 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
904 when using from python
906 2004-02-10 Benoit Regrain
907 * FIX : bug fix in the gdcmDirList for the recursivity in directories
908 * FIX : in gdcmDicomDir when the directory is empty
909 * ENH : add callback and methods to get the progression of dicomDir
912 2004-02-06 Jean-Pierre Roux
913 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
914 - GDCM_META added to gdcmDicomDirType
915 - class gdcmMeta created
916 * ENH : - A brief summary is now displayed at the beginning of
917 'testDicomDir' to help disaster magnitude estimation
918 * REM : Now useless Test/explDICOMDIR.cxx
920 2004-02-05 Benoit Regrain
921 * ENH : add methods in gdcmObject to get the hash table or the list of
923 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
924 * FIX : wrapping python for TagHeaderEntryHT
926 2004-02-04 Benoit Regrain
927 * FIX : even length for some strings when writting the dicom dir
928 * FIX : sort the images in the dicom dir
929 * FIX : Bug fix for python use of dicom dir
930 * ADD : a python demo
932 2004-02-04 Jean-Pierre Roux
933 * FIX : Final solution (?) for icone embedded images
934 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
935 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
936 add groups 6002, 6004, 6006, to allow 'clean' parsing of
937 gdcmData/gdcm-MR-SIEMENS-16.acr1
938 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
939 to make full checking easier
941 2004-02-04 Benoit Regrain
942 * FIX : WriteEntries : coding style & logic in parameters
943 * FIX : Set the elements to create the DicomDir in a dictionary file
945 2004-02-03 Benoit Regrain
946 * gdcmDirList : to parse a hard drive directory in recursive (or not)
947 * gdcmDicomDir : add the load of directory
948 * Bug fix and print add-on
950 2004-02-03 Jean-Pierre Roux
951 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
952 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
953 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
954 * FIX gdcmParser.cxx : 'group length' elements are now considered
955 as integers, even for shadow groups, when file is Implicit VR
957 2004-02-02 Jean-Pierre Roux
958 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
960 of the last synonym :-(
961 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
963 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
964 * FIX taking into account the possible 7fe0,0010 multiplicity
965 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
966 to allow removal of references to 7fe0,0010, to deal with
967 ACR-NEMA images, when 0028,0200 is meaningfull
969 2004-01-31 Jean-Pierre Roux
970 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
971 no longer writes 'Un' on disk
972 * FIX SQ elements with actual length are now dealt with corectly
973 * FIX gdcmFile::WriteBase make the difference, for color images, between
974 the length (for Palette expanded images)
975 and Raw Length (non expanded image + Palette)
976 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
977 (that broke Write). Replaced by UL.
978 Aware user will reload the field if he
979 thinks it's necesssary
981 2004-01-30 Jean-Pierre Roux
982 * gdcmParser::CheckSwap() now defaults the filetype to ACR
983 when 'dirty Acr' is found, to be compliant with the new
984 IsReadable() methods.
986 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
987 (no DOUBLE images in kosher DICOM,
988 but so usefull for people that miss them ;-)
990 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
991 DICOMDIR related utilities (not checked as Windoze compliant)
993 2004-01-28 Jean-Pierre Roux
994 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
996 2004-01-27 Jean-Pierre Roux
997 * gdcmParser constructor has a new boolean param,'ignore_shadow',
998 to allow skipping the shadow elements, to save memory space.
999 The TRUE value for this param has to be used
1000 with a FALSE value for the 'enable_sequence' param.
1001 ('public elements' may be embedded in 'shadow Sequences')
1002 * gdcmHeader methods now deal with 'embedded icones images' in the header
1003 (even when an 'icone image sequence' is announced by the
1004 element (0x0088,0x0200), but there is NO icone at all ...
1006 * gdcmHeader sometimes Image Location value doesn't follow
1007 the supposed processor endianity (see gdcmData/cr172241.dcm).
1010 * gdcmHeader add the method
1011 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1012 to get *all* the Header Entries with the same tag.
1013 GetHeaderEntrySameName is probabely *useless*
1014 (no meaning : Name is *not* an identifier within the Dictionnary)
1016 2004-01-26 Benoit Regrain
1017 * Bug fix in the print of hexadecimal representations. Remove long fields
1018 in the print and add a third level of print to print them
1020 2004-01-23 Benoit Regrain
1021 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1022 * Bug fix on test suite after remove the strip made on not string fields
1023 * Split the IsReadable method between gdcmParser which test that the file
1024 is dicom and gdcmHeader which test that it's an image file
1026 2004-01-22 Benoit Regrain
1027 * DicomDir : clean code, add methods, set variables in protected or private
1028 * gdcmUtil : bug fix for the clean string method
1030 2004-01-19 Benoit Regrain
1031 * Add the use of shadow dictionaries
1032 * bug fix and coding style
1034 2004-01-19 Benoit Regrain
1035 * src/gdcmFile.cxx : bug fix concerning the close of file
1036 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1037 * Add the update of header entries using the shadow library
1039 2004-01-19 Benoit Regrain
1040 * removal of file gdcmHeader2.cxx
1041 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1042 inheriting from gdcmParser. This split is to prepare the integration
1043 of dicom dir parsing
1044 * bug fix under python
1046 2004-01-16 Jean-Pierre Roux
1047 * REM removal of class gdcmHeaderEntrySet
1048 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1049 * ADD add file gdcmHeader2.cxx
1050 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1052 2004-01-15 Benoit Regrain
1053 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1054 entries created while parsing the header. Thus, they will be destroyed
1055 when the gdcmDictSet will be destroyed
1056 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1059 2004-01-15 Benoit Regrain
1060 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1061 made a fatal error because of the memory release at the end of program.
1062 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1063 some memory and vtk seems to have some problems with that.
1064 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1066 2004-01-14 Benoit Regrain
1067 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1068 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1069 * src/*.[h|cxx] : make changes due to class name changes
1070 * gdcmPython/demo/*.py : bug fix due to method names
1072 2004-01-13 Benoit Regrain
1073 * src/*.[h|cxx] : coding style
1074 * vtk/*.[h|cxx] : coding style
1076 2004-01-13 Benoit Regrain
1077 * gdcmPython/testSuite.py : test the readable flag of file for tests
1078 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1079 It's lied to the stl compilation by MSVC (windows, always windows...)
1080 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1082 2004-01-12 Benoit Regrain
1083 * src/*.h : add comments
1084 * src/gdcmDictSet.h : set the method BuildDictPath in public
1085 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1086 directly setted in the source code
1087 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1090 2004-01-09 Benoit Regrain
1091 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1092 * setup.py : use a reference to gdcmVERSION
1094 2004-01-07 Benoit Regrain
1095 * Modification to compile with the distutils.
1098 2003-12-10 Benoit Regrain
1099 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1100 can use a gdcmHeaderHelper to load datas
1101 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1102 made in the source code
1104 2003-12-10 Benoit Regrain
1105 * Update Windows projects and .cvsignore files
1107 2003-11-12 Jean-Pierre Roux
1108 * ENH gdcmHeader constructor has one more parameter (default value : false)
1109 that allows the user to 'go inside' the SeQuences only
1111 gdcmElValSet:Print takes it into account
1113 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1114 * ENH: Update gdcmPython/CMakeLists
1115 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1116 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1118 2003-11-10 Jean-Pierre Roux
1119 * FIX : gdcmHeader::LoadElements is now based
1120 on the ListTag listElem member,
1121 not longer on the TagElValueHT tagHt member
1122 * ENH : PrintPubElVal shows (temporarily) both results,
1123 with the tagHt member and the listElem member.
1124 (it's easier to 'see' the problems when using Printheader)
1126 * FIX : old private member LgrElem is now splitted into
1127 ReadLength : Length actually found on disk (updated only
1128 if bug fixing is necessary), for internal
1130 UsableLength : Updated by FixFoundLength, to fix a bug
1131 or to allow Parser going on.
1132 Will allow to re-write a kosher header when a SeQuence
1133 with a length (not 0000) is found
1134 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1135 because gdcmElValSet::Add does not update ListElem
1138 2003-11-07 Jean-Pierre Roux
1139 * FIX misstyping in Transfert Syntax name table
1140 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1141 when they have an actual length (not 0000 nor FFFFF)
1142 (Nobody should care of it, but DICOMDIR explorers)
1144 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1145 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1147 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1148 * ENH: vtkGdcmReader now supports LUT !
1149 (vtkgdcmViewer for now is not able to use them though)
1151 2003-11-05 Jean-Pierre Roux
1152 * in testSuite.py : new files names for checking the package
1153 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1154 that returns the pixel area size to the *aware* (vtk) user
1155 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1157 2003-11-05 Benoit Regrain
1158 * in testSuite.py : Modify the rules for checking the paths
1159 : Explicit error messages
1160 * in __init__.py : Related modif
1162 2003-11-03 Jean-Pierre Roux
1163 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1164 to be used by aware (vtk) users that want to manage
1165 LUT (and no to turn the PALETTE image into an RGB pixels one)
1166 * GetPixelType now returns 8U for 24 Bits images
1167 (vtkGdcmReader compliant)
1169 2003-10-31 Jean-Pierre Roux
1170 * Removal of *all* gdcmData images and add them again
1171 in order to loose the 'history' of un-anonymised images
1173 2003-10-31 Jean-Pierre Roux
1174 * RMV : removal of useless jBitsInJsample.h
1175 for both 8 and 12 Bits JPEG Lossy Libraries
1177 2003-10-31 Jean-Pierre Roux
1178 * ENH : Add the functions gdcmFile::GetImageDataRaw
1179 gdcmFile::GetImageDataIntoVectorRaw
1180 that act as GetImageData and GetImageDataIntoVector
1181 except the making of an RGB Plane from Gray Plane + LUT
1182 Intended to aware (vtk) users who know how to manage
1185 GetLUTRGBA return a R,G,B,A LUT if any
1186 lgrTotaleRaw gives the 'Raw' length
1187 GetImageDataRaw returns the gray Plane
1188 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1189 (They stay Grey, just like with other Dicom viewers :-(
1191 2003-10-30 Jean-Pierre Roux
1192 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1194 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1195 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1196 being coherents dicom files.
1198 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1199 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1201 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1202 * ENH: Two steps is necessary to please VC++ compiler...
1203 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1204 * ENH: Add include dir to medcon lib
1205 * FIX: only one function is being exported for now !
1206 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1208 2003-10-29 Jean-Pierre Roux
1209 * adding gdcmHeader::GetLUTRGBA
1210 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1211 --> Mathieu, the modif u're waiting for is not yet committed
1212 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1214 2003-10-27 Jean-Pierre Roux
1215 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1216 00191113.dcm DermaColorLossLess.dcm
1217 MxTwinLossLess.dcm RadBWLossLess.dcm
1218 * ENH: For version prior to vtkImageViewer2 -r 1.19
1219 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1221 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1222 * Removal of ido stuff in CMakeLists.txt
1224 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1225 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1226 * FIX: remove a call to ->Modified ... see comments
1227 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1229 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1230 * FIX: Problem with path for libvtkgdcmPython
1231 * ENH: Try adding a search script for python site-package
1232 * RMV: Remove some file from medcon lib that are not necessary
1233 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1234 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1235 * FIX: More pragma disable fro VC++,
1236 I don't think I break something as it is also disable in VTK/ITK.
1237 But it fasten debug compilation time.
1239 2003-10-23 Jean-Pierre Roux
1240 * gdcm now deals with 16 Bits Run Length Encoded images
1241 (they are compressed as 2 planes images,
1242 one for the high Bytes, the other for low Bytes)
1244 2003-10-22 Jean-Pierre Roux
1245 * Now CheckRead takes into account :
1246 - the bugged 'Leonardo' Siemens images
1247 - the XA images, sent thru the burning VPRO station
1248 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1251 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1252 * FIX: When copying a Makefile.am to CMakeLists.txt
1253 one should remove the '\'
1255 2003-10-22 Jean-Pierre Roux
1256 * in gdcmData adding a bugged 'Leonardo' Siemens image
1257 (wrong lengths in header)
1258 OK with gdcm, KO with the other viewers :-)
1259 * add a GE dlx XA image, thru the VEPRO burning station
1262 2003-10-21 Jean-Pierre Roux
1263 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1264 for a brutal checking of vtkgdcmViewer compliance
1266 2003-10-21 Jean-Pierre Roux
1267 * add the files for 'xmedcon' Jpeg Lossless library
1268 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1270 2003-10-21 Jean-Pierre Roux
1271 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1273 2003-10-21 Jean-Pierre Roux
1274 * garbage Siemens 'Leonardo' images dealt with
1275 (the patch is easy to remove)
1276 * cosmetic changes to avoid warnings
1278 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1279 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1280 no need to press 'r' now.
1282 2003-10-20 Jean-Pierre Roux
1283 * upgrade of checkRead.sh checkWrite.sh according
1284 to new Jpeg Lossless decompressor
1285 * add US.3405.1.dcm, a genuine RGB medical file ...
1286 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1287 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1289 2003-10-15 Jean-Pierre Roux
1290 * general anonymisation in gdcmData
1291 * adding the 'color files' from
1292 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1293 * adding some well knowed bugged-header images
1294 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1295 waiting for their inclusion in Python testsuite
1297 2003-10-15 Jean-Pierre Roux
1298 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1299 no longer seg faults when file is not found
1301 2003-10-14 Jean-Pierre Roux
1302 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1305 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1306 * TODO: *.in file to genereate a UseGDCM later
1308 2003-10-14 Jean-Pierre Roux
1309 * Some supposed-to-be Dicom Images have no preamble.
1310 OpenFile takes it into account
1311 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1312 * Missing elements added in dicomV3.dic
1313 (just to be affraid : have a look at
1314 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1315 and do it again next year ;->
1317 2003-10-13 Jean-Pierre Roux
1318 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1319 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1320 But there are NOT. It's fixed !
1322 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1323 * FIX: "jpeglib.h" was not found on VC++
1324 * FIX: vtkgdcm was not being installed
1326 2003-10-10 Jean-Pierre Roux
1327 * ENH : OpenFile closes the file if it *really* doesn't look like
1328 an ACR-NEMA / DICOM one.
1329 * FIX : testWrite no longer writes an empty file if the source file
1330 is not gdcm Readable
1331 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1334 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1335 * FIX: CMake generate now documentation
1336 * ENH: out of source doc build !
1337 * ENH: Generate both user and dev documentation
1338 * ENH: Should work on windows too
1339 * ENH: Only one doxygen config.in file is needed
1340 * FIX: make install should be ok now on ùnix plateform
1341 * FIX: PATH to dictionary was wrong (missing /)
1342 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1344 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1345 * vtkGdcmReader is now able to read rgb dicom file.
1346 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1347 * added a gdcmViewer to vtk test, use mouse to control
1348 window level & window width
1350 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1351 * CMake-ification of gdcm, we have now two build system
1352 * FIX: on cygwin Wsock32 doesn't exist
1353 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1355 2003-10-06 Emanuel Ollart
1356 * FIX : compilation process wad broken.
1357 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1359 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1360 * change gdcmViewer -> vtkgdcmViewer
1361 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1363 2003-10-06 Jean-Pierre Roux
1364 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1365 ( e.g : well known GE images with a wrong elem length,
1366 : Philips MRI Images with a wrong Huffman table)
1367 * still to be done : allow the reading of bugged LEONARDO Siemens images
1369 2003-10-03 Jean-Pierre Roux
1370 * Odd length strings are padded with '\0' (not with spaces,
1371 to remain compliant with already defined strings,
1372 like Transfert Syntax UID and others)
1374 2003-10-03 Jean-Pierre Roux
1375 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1376 to allow displaying RGB images (not only by affim ;-)
1378 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1379 * vtkGdcmReader is now able to read rgb dicom file.
1380 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1382 2003-10-03 Jean-Pierre Roux
1383 * A few nasty patches to allow the reading of a lot of nasty images
1384 ( e.g : well known GE images with a wrong elem length,
1385 : Philips MRI Images with a wrong Huffman table)
1386 * still to be done : allow the reading of bugged LEONARDO Siemens images
1388 2003-10-03 Jean-Pierre Roux
1389 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1391 2003-10-03 Jean-Pierre Roux
1392 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1393 to allow displaying RGB images (not only by affim ;-)
1395 2003-10-03 Jean-Pierre Roux
1396 * gdcmFile::GetImageDataIntoVector now
1397 - deals with MultiFrames MultiFragments Run Length Encoded files
1398 - deals with YcBcR (YBR_FULL) files
1399 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1400 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1402 (no sample found :-(
1404 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1405 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1406 Two reasons: - clear things
1407 - third parties acces gdcm through header files, so won't
1408 suffer anymore VC++ complains
1410 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1411 * add argv[1] in testvtkGdcmReader.cxx
1414 2003-09-24 Jean-Pierre Roux
1415 * The lines are now eigthy characters long.for
1416 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1418 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1419 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1420 char* to std::string. Thus, the use of strdup becomes useless. (see
1421 previous commis of Malaterre)
1422 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1423 before the last Malaterre's commit.
1425 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1426 * This commit should fix the Debug building under VC++, the problem
1427 was mainly a mixture of debug and release lib being loaded at startup.
1428 * I also remove a depency to a specific C function: strdup. Because I had
1429 to force the link to msvcrtd (whereas strdup is in libc).
1431 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1432 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1433 located in the gdcmCommon.h file. All use of reference of tha has been
1434 changed to now use the variable GDCM_UNFOUND.
1436 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1438 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1439 Dicom dictionary. The test suite can now be run again. Note:
1440 I'm note very happy with the " (RET)" changes. I believe this
1441 RETAINED comment should be dropped when parsing the dictionary.
1442 - PACKAGER corrected
1444 - AUTHORS updated and now in alphabetical order
1445 * Makefile.am now exports gdcm.dsw for Windoze users.
1447 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1448 * cygwin complains about missing std:: in subdir Test/
1450 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1451 * remove some methods that are now in gdcmHeaderHelper
1453 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1454 * vtkGdcmReader set spacing and origin correctly
1456 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1457 * Fix a few delete/delete[] mismatch
1459 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1460 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1461 interpretation to data given by gdcmHeader. For instance there are
1462 heuristics to get informations (look at different places).
1463 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1464 sorting DICOM images based on different strategies.
1465 * modified Makefiles accordingly.
1467 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1468 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1469 when building in debug mode
1470 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1471 src/win32/gdcmdll.dsp
1472 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1474 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1475 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1478 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1479 * src/win32/libgdcmjpeg12.dsp was not dos format
1480 * src/win32/libgdcmjpeg12.dsp :
1481 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1482 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1484 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1485 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1487 * src/gdcmFile.cxx : bug fix in affectation type
1488 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1489 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1490 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1491 symbols... future problem ?
1493 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1494 * src/win32/libgdcmijpeg12.dsp was missing
1495 * modified gdcm.dsw accordingly
1497 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1498 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1500 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1501 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1502 commit of JPR (before his hollidays to facilitate our work).
1503 * setup.py : bug fix in code. Modifications made while the last commit
1504 of JPR. The code hasn't been tested before the commit... it's so
1505 useless to make that (for best programmer that is JPR) !!!
1507 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1508 * tagged the current version as Version0_3 (i.e. version 0.3)
1510 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1511 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1512 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1513 * *.dsp : modifications to use new libgdcmijpeg8 library
1514 * setup.py : bug fix on VTKPATH variable
1515 * PACKAGER : adding all concerning windows
1517 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1518 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1520 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1521 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1522 test suite reported error.
1523 * PACKAGER file added (describes what a packager must do when
1524 packaging a new release).
1525 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1526 * configure.in: upgraded version number to 0.3.0
1527 * fixing build of rpm (through rpm -ta):
1528 - Doc/Makefile.am exports proper doxygen files
1529 - src/jpeg/libijg8/Makefile.am exports the include files.
1531 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1532 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1533 * src/gdcmHeader.h : formatting code
1535 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1536 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1537 We were obtaining error message from vtk. Now, creation of file list
1538 is made in an internal list to prevent this problem.
1539 Bug fix when output is empty.
1540 Bug fix in update of progress value. Previous commit for this was a bad
1542 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1544 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1545 * src/gdcmHeader.h : added method to get the file name
1546 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1547 files. Added method to remove all files on the input
1548 Added FIXME comment concerning the bad parsing of header made by
1549 ExecuteInformation method (in ExecuteData method)
1551 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1552 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1553 when using make instal.
1554 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1555 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1557 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1558 * setup.py : adding include dir of jpeg lib to compile all sources
1559 * */Win32/*.dsp : JPR fix for windows compilation
1561 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1562 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1564 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1565 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1567 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1568 * setup.py is again effective on un*x (takes into account the
1569 addon of the jpeg library)
1570 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1571 * Doc/Doxy* updated (includes above enhancements)
1572 * INSTALL now points to web documentation
1574 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1575 * src/gdcmHeader.h doesn't make unnecessary reference to
1577 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1579 * src/gdcm*.[cxx|h] :
1580 - to allow compilation with gcc 3.x
1581 -- clean up of STL usage (added explicit usage of std::)
1582 -- small fixes on exceptions.
1583 Note: linking not tested !
1584 - clean of doxygen comments to avoid warnings at documentation
1586 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1587 dependent convertion).
1589 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1590 * Clean up of previous JPR garbage commit (not even commented in the
1592 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1593 - moved all jpeg related files from src to src/jpeg/libijg8, with
1594 addition/modification of Makefile.am and configure.in.
1595 - the testSuite is still brain damage (not guilty).
1597 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1598 * WrapVTK.py : modifications to get correctly vtk source files to
1600 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1601 (FileName -> Filename)
1603 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1604 * vtk/vtkGdcmReader.[cxx/h]:
1605 - UpdateProgress method should now be effective
1606 - removed the limitation on having only images loaded (as opposed
1608 - when building a stack of images/volume, a lesser number of
1609 gdcmHeader and gdcmFile instances should be used (hopefully
1610 accelerating things).
1611 - when building a stack of images/volumes, files which are not
1612 loadable (wrong path-filename, wrong permissions on existing file,
1613 or file not parsable by gdcm) are replaced with a black image
1614 in the stack (for the caller to notice the problem).
1616 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1617 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1619 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1620 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1621 between standard library (std) and vtk library (problems are found
1622 under Windows... thanks Windows !)
1624 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1625 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1627 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1629 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1630 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1632 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1633 * When compiling with distutils (see setup.py) the C++ compiler is
1634 called with different flags than the default ones (with automake).
1635 In order to fix all those warning, I compiled gdcm with the command
1636 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1637 and went for warning fixes:
1638 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1639 up from unused variables.
1640 - vtk/vtkGdcmReader.cxx: potential bug fix.
1641 * src/gdcmHeader.h: Doxygen warning cleanup
1643 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1644 * gdcmPython/gdcm.i:
1645 - typemaps correction to take into account the systematic replacement
1646 of "using namespace std" with std:: prefix e.g. std::list,
1647 std::string... (cf changes of 2003-05-21).
1648 - gdcmGlob global variable of type gdcmGlobal (defined in
1649 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1650 exported to Python a as cvar.
1651 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1652 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1653 gdcmDictSet.GetPubDictTagNames() and
1654 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1655 C++ static methods).
1656 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1657 with the above changes.
1659 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1660 * setup.py, manifest.in : bug fix under linux
1662 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1663 * Modification of setup.py to compile vtk part too. Then, we have 2
1664 wrappers which must work with same distutils. For that, we have a
1665 generic distutils in distusiltsWrapping.py ; with :
1666 - build_extWrap class to wrap generically all extensions,
1667 - ExtensionWrap base class for all wrapping extension that contains
1669 - Wrapper interface which wrap sources
1670 + In WrapSwig.py we have extension and wrapper for Swig
1671 + In WrapVTK.py we have extension and wrapper for VTK
1672 * MANIFEST.in : modifications to consider vtk directory and new python
1673 files for compilation
1675 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1676 * Added python wrappers of vtkGdcmReader vtk class (see the
1677 source in vtk/vtkGdcmReader.cxx) :
1678 - vtk/Makefile.am now builds a library
1679 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1680 python library (as opposed to _gdcm.so wich are the python
1681 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1682 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1684 - configure.in has an additional flag --enable-vtk that needs
1685 to be set to enable compilation of vtk related code, that is:
1686 + vtk/vtkGdcmReader.so and
1687 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1688 + gdcmPython/vtkgdcmPython.so (see above)
1689 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1690 be read when compressed or when HighBit + 1 != BitsStored),
1691 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1692 the usage of the python wrapper of vtkGdcmReader vtk class.
1693 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1694 * src/*.[h] all occurences of stl classes are now prefixed with
1695 std::, and all occurences of "using namespace std;" where removed.
1696 This is to avoid pollution of global namespace in included files.
1697 Apparently vtk does not avoid this pitfall: when using both
1698 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1699 collision of various stl members (principally cout...).
1700 * gdcmPython/testSuite.py now cleanly removes temprory generated
1702 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1703 comply with above changes)
1705 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1706 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1707 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1708 vtk data structure (an image Flip was required).
1709 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1710 * cosmetic changes in documentation.
1712 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1713 * src/gdcmHeader.cxx: the constructor no longer exits when an
1714 unexisting file is given as argument.
1715 * The subdirectory Data (containing all the images used for the
1716 test suite) is not part of this repository anymore. A new module
1717 containing those images is now available at
1718 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1719 with the name gdcmData.
1720 All the python scripts (including the package initialisation file
1721 gdcmPython/__init__.py) were adapated to take this change into
1722 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1724 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1725 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1726 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1727 demo of the usage of this class.
1728 Compilation of this vtk part is only done when using the --enable-vtk
1729 at configure (or autogen.sh) stage.
1731 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1732 * More memory link related corrections and documentation fixes.
1734 - maximum info is obtained with a command of the form:
1735 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1736 --show-reachable=yes PrintHeader
1737 - the remaining reachable blocks seem to come from the STL
1738 allocation scheme through the usage of map and list. It looks
1739 like this memory cannot be freed but it is not a memory leak
1740 (in fact further invocation to the STL would recollect the
1741 unused memory allthough it cannot explicitely be freed).
1742 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1743 of displaying an image parsed with gdcm and displayed with VTK.
1744 Note: some images don't seem to work e.g.
1745 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1746 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1747 Allthough this weakens the semantics, it is a ditch attempt to
1748 make gdcm more thread friendly.
1750 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1751 * Memory link hunt (by using valgrind through the command
1752 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1753 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1754 gdcmHeader::_dicom_vr.
1755 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1756 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1758 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1760 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1761 * src/Makefile.am now exports all the necessary include files at
1765 * UpdateGroupLength replaced by new one
1768 * UpdateGroupLength re-written using H-Table
1769 (named UpdateGroupLengthNew untill checks are over)
1771 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1772 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1773 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1775 - gdcmHeader::GetPubElValSet removed.
1776 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1777 UpdateGroupLength, WriteElements, Write.
1778 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1779 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1780 carried the same semantics.
1781 - src/gdcmHeaderIdo.cxx changed accordingly.
1782 - gdcmFile::WriteBase now regroups all the codes from previous
1783 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1784 - enum FileType moved to gdcmCommon.h
1785 * src/gdcmHeader.cxx AddDefault trashed
1786 * gdcmGetXSize added
1787 * getimageDataSize now calls gdcmGetXSize
1788 * Test/*.cxx changed to agree with above changes
1790 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1791 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1792 (to avoid double call by end user).
1793 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1794 by end user, since gdcmHeader::gdcmHeader now handles it.
1796 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1797 * gdcm/Doc many doxygen changes:
1798 - Doxyfile now has two different versions, DoxyfileUsers that generates
1799 the html.users end users oriented documentation and
1800 DoxyfileDeveloppers that generates the html.developper developper
1801 oriented documentation.
1802 - README changed accordingly
1803 - requirement.txt removed (old design info moved to TODO).
1804 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1805 DoxyMainPage.txt, DoxyPython.txt provide more information.
1806 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1807 be updated by simply regenerating the docs with doxygen and copying
1808 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1809 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1810 all the tests in the form "if (<map>.count() >1)" were removed.
1811 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1812 ill-formed documentation sections.
1813 * src/gdcmHeader.cxx: ditto
1815 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1816 * setup.py fixed for un*x (needed macro for stdint.h)
1817 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1818 un*ces with sh-utils test utility.
1819 * gdcmPython/demo/test.py renamed to PrintHeader.py
1820 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1821 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1822 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1823 * src/gdcm*.cxx JPR's bad inclusion fixed.
1825 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1826 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1827 * gdcmPython/demo/test.py changed accordingly.
1829 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1830 * gdcmPython/Makefile.am fixed linking against libstdc++
1831 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1832 * Swig subdir (historical tests of swig version 1.3.17++) removed
1833 * Test/testChangeEntete.cxx some lines commented out in order to make
1835 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1836 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1838 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1839 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1840 hence the user doesn't need this explicit call.
1841 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1842 i.e. LoadElements() call removed.
1843 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1844 - src/Makefile.am declares the proper flag for g++.
1845 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1846 for adding user defined new tags.
1847 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1848 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1849 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1851 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1852 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1853 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1854 src/Makefile.am : the project should properly compile and install
1855 with the autotools, included the python wrappers part.
1856 * gdcm.spec.in : added a spec file for RPM packaging.
1858 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1859 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1861 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1862 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1863 to exported to the environement (see gdcmPython/testSuite.py
1865 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1866 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1867 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1868 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1869 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1871 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1872 * gdcmPython/__init__.py doesn't crash anymore when running in
1873 in InstallMode or PreInstallMode but with an environement given
1874 value of GDCM_DICT_PATH.
1875 * src/gdcmDictSet.[cxx/h] coding style.
1877 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1878 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1879 * src/gdcm.h general comments moved to TODO, and README
1880 * src/gdcm.h should now be seen as a user commodity (including it
1881 should suffice to fully use gdcm). It is nowhere including within
1882 any of the kernel files src/*.cxx and src/*.h.
1884 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1885 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1886 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1888 * src/gdcm*.cxx only include their corresponding include file
1889 (as opposed to gdcm.h)
1890 * gdcmPython/gdcm.i changed accordingly
1891 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1892 the autogen.sh generated "make snapshot" command to work.
1893 * autogen.sh removed history related references to crea package.
1895 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1896 * distutilsSwigCPlusPlus.py work around some swig portability
1899 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1900 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1901 was done in a last ditch attempt to get setup.py _really_
1902 operationnal. The python/gdcmPython layaout add the advantage
1903 of hidding away the python related distutils specific files
1904 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1905 Alas, the src directory was out of scope (i.e. it's relative
1906 position to setup.py was ../src) which made things impossible to
1907 handle (see previous version of python/setup.py). Crossing fingers...
1909 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1910 * python/setup.py now works on Un*x. (harder than I thougth)
1911 * python/distutilsSwigCPlusPlus.py can now have include files
1912 among the list of sources.
1914 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1915 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1916 * modifications in MSVC projects
1918 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1919 * As stated by the first lines of Test/ExceptionAndPython/README, it
1920 looks like we can move back to original usage of exception within
1921 src/gdcm* and hence remove the errno stuff that was introduced
1922 as a quick and dirty fixture of this problem (added to the TODO).
1923 * Doc/Doxyfile configuration file for Doxygen and corresponding
1924 README file for usage added.
1925 * Test/testWrite.cxx added. This new test comes from a split of
1926 test.cxx that is now reverted to its original purpous i.e.
1927 testing the proper parsing of a Dicom related file.
1928 testWrite.cxx concentrates on testing the IO part of gdcm.
1929 * Test/bug1.cxx (containing a bug on WIn32) added.
1930 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1931 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1932 whose purpose is to publish the content of the TagNames of the
1933 Dicom public dictionnary were not accessible without an
1934 instance of class gdcmHeader.
1935 - those methods are now static methods of gdcmDictSet and hence
1936 require no instances at all to be invocated.
1937 - within gdcmDictSet this change required to change some method
1938 to class methods (i.e. are now static) among which SetDictPath
1939 (renamed to BuildDictPath) and LoadDefaultPubDict.
1940 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1941 the above changes by calling the new method classes of gdcmDictSet.
1942 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1943 the above to be effective.
1944 * python/gdcmPython: in order to wrap properly the above changes
1945 for Python, swig version now needs to be > 1.3.17.
1946 * python/gdcmPython/Makefile fixed to adapt itself to new
1947 configure/make shema introduced by Johan Montagnat (thanks for the
1948 contribution). Alas this Makefile cannot be turned into a proper
1949 Makefile.am without some heavy changes in the configure.in
1950 (for python dectection).
1951 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1952 now avoids publishing the empty entries.
1954 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1955 * python/setup.py : bug fix concerning install under windows
1956 ExtraPath reused :-P
1957 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1959 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1960 * Dicts/dicomV3.dic : remove double spaces !!!
1961 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1962 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1965 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1966 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1967 method. Doxygenation.
1968 * src/gdcm.h clean up of JPR spurious comments.
1970 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1971 * python/distutilsSwigCPlusPlus.py now properly collects the
1972 shadow classes generated by "swig -c++" (gdcm.py in our case)
1973 when using "python setup.py install".
1974 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1975 reexports the working classes.
1976 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1977 by the classical C errno scheme. This is to prevent an obscure
1978 behavior of the python wrappers when importing wxPython.wx prior
1979 to gdcmPython (which ended up in an abort call). An illustration
1980 of this oddity can be found in the Test/ExceptionAndPython
1981 subdir (see the README file). This problem probably due to
1982 an combination of g++ and dynamic loading.
1983 * added Test/ExceptionAndPython (see above)
1985 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1986 * Changed the layout of the python part to avoid bloating main
1987 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1988 i.e. the distutils arsenal. All the python related stuff is
1989 again in a python subdir, but the package itself is now in
1991 * setup.py was cleaned up:
1992 - pythonIncludePath removed
1993 - python setup.py bdist target is now functional.
1994 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1995 collision with other packages). gdcmPython/demo/*.py changed
1998 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1999 * python subdir moved to gdcmPython (preparation of distutils packaging).
2000 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2001 distutils installer is operational.
2002 * - gdcmPython/__init__.py now properly loads the swig generated
2003 shadow classes (from gdcm.py).
2004 - gdcmPython/demo/*.py changed to import the package gdcmPython
2005 instead of gdcmPython/demo/load.py.
2006 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2008 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2009 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2010 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2011 entries within the associated public Dicom dictionary resp. the same
2012 information but sorted by the fourth field (PAT, IMG, DIR) of the
2014 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2015 are now in the "???" group.
2016 - python/gdcm.i changed accordingly,
2017 - python/demo/printGroupedPublicDict.py added, that gives an example
2018 of the above new functionalities in Python.
2020 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2021 * src/gdcm.h, gdcmHeader.cxx:
2022 - historic references to glib's g_malloc and g_free (#defined)
2023 were definitively removed.
2024 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2025 * src/gdcmElValSet.cxx:
2026 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2027 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2028 - GetElValue(string) renamed to GetElValueByName.
2029 - Added GetElementByName(string).
2030 * src/gdcmHeader.cxx: added
2031 - GetPubElValRepByNumber(guint16, guint16)
2032 - GetPubElValRepByName(string)
2033 - GetShaElValRepByNumber(guint16, guint16)
2034 - GetShaElValRepByName(string)
2035 - GetShaElValByNumber(guint16, guint16)
2036 - GetShaElValRepByName(string)
2037 - GetElValRepByNumber(guint16, guint16)
2038 - GetElValRepByName(string)
2039 - GetElValByNumber(guint16, guint16)
2040 - GetElValRepByName(string)
2041 * Doc/requirements.txt added.
2043 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2044 * Test/Makefile building now depends on the one of libgdcm.so
2045 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2046 pixel data) aware which enables finding the address (offset) of
2047 the pixel data of JPEG encoded DICOM files. This leaves only a single
2048 file in the testSuite whose pixel data address (offset) is unknown.
2049 * python/testSuite.py changed accordingly.
2051 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2052 * VC++ has some strong limitations when working with the STL, as stated
2053 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2054 "Also note that some STL containers (map, set, queue, list, deque)
2055 cannot be exported. [...]
2056 Some STL classes contain nested classes. These classes can not
2058 This is caused by a designed limitation that once a template
2059 class is instantiated, it can not be re-instantiated and
2061 Since our usage of map<> is ubiquitous in gdcm, this "designed
2062 limitation" of VC++ is a pitfall.
2063 Hence the Python wrappers of gdcm cannot be incrementally linked
2064 against the c++ dynamic library. The dirty but only workaround is
2065 to forget about incremental link of dynamic libraries and to generate
2066 the Python wrappers library with the inclusions of the underlying C++
2068 The following modifications concern this matter on Win32/VC++:
2069 - wrapping python correct with standalone wrapped dll (don't use separate
2070 dll under windows !!!!)
2071 - python21_d debug mode enabled (ask Frog how to use it :-)
2072 - NO problem with having an STL member of class for example string in C++
2073 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2074 - Python test of dcmlib in Python is ok under windows on a large set
2076 * removed glib references
2077 * typedef's inserted in gdcm.i for correct swig type management
2079 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2080 * python/demo/*.py load.py extracted from test.py. Added explore.py
2081 that only displays required tags and testAll.py that parses all
2082 the files of the testsuite without using unittest.
2083 * python/testSuite.py other additional test on new files added.
2084 * Data/* new test files added accordingly to the testSuite.
2085 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2086 the vr in the file differs from the one of the dictionary.
2088 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2089 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2090 values, but limits itself to values which are below a user specified
2091 size (by default 1024 bytes).
2092 * python/gdcm.i : elements not loaded (because their size is above the
2093 user specified treshold) are exported with their TagKey as key of the
2094 python dictionary. This enables the testsuite to make some checks
2095 on the unloaded elements (since we have their offset and size).
2096 * python/testSuite.py
2097 - now tests for the existence and proper value of the pixel data
2098 - two new examples added.
2099 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2101 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2102 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2103 aware. See the strategy comments in gdcmHeader::FindeLength().
2104 * Test/test.cxx now accepts a filename as first argument.
2105 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2106 * python/testSuite.py changed to integrate test on above files.
2108 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2109 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2110 the vr was also RET.
2111 * python/testSuite.py more tests added.
2113 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2114 * python/testSuite.py unittest test suite added (uses Data)
2115 * Data/* dcm and acr files for the test suite.
2116 * glib dependance removed from un*x version. We now use ISO C99
2117 7.18 Integer types (see stdint.h)
2118 - python/Makefile, src/Makefile src/gdcm.h
2119 * src/ when an explicit vr (like dicom files) suddenly poped an
2120 implicit element we use to mark the underlying DictEntry of the
2121 concerned ElValue with "Implicit". This strategy was damageable
2122 too the public or provite dictionaries, since some of their vr
2123 would be changed. Since Header::FindLength heavily relies on the
2124 detection by Header::FindVR of falsely explicit elements, I
2125 added an extra ImplicitVr member to ElValue (boolean).
2126 The rest of the changes we the necessary adaptations.
2128 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2129 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2131 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2133 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2134 * Adaptation for porting to VC++:
2136 o forced to use std namespace (for string to be known)
2137 o all class use __declspec export style on WIN32
2138 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2139 (in stdlib.h on Win32 but in std:: for gcc)
2140 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2141 variable GDCM_DICT_PATH.
2142 * src/gdcmHeader.cxx verbose comments made discrete.
2144 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2145 * python/gdcm.i: added a typemap that converts a C++ hashing table
2146 to native Python dictionary.
2147 * python/demo/test.py:
2148 - now uses the native dictionary for exploration of gdcmHeader.
2149 - takes an optional filename argument (the file to parse).
2150 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2151 PubElVals hashing table.
2152 * Dicts/dicomV3.dic removed error prone trailing spaces.
2154 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2155 * Python wrapping process moved away from src/Makefile to
2156 newly created python/Makefile (as well as gdcm.i)
2157 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2158 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2159 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2160 from the environement variable GDCM_DICT_PATH (when existing).
2161 * src/gdcmDict::GetTag bug fix.
2163 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2164 * Straightforward temporary fixes for swig to build the python wrappers.
2165 src/Makefile now has a python working entry [by working we mean
2166 that we can import de shadow classes without errors].
2168 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2169 * hashtest.cxx removed (since allready in Test)
2170 * src/gdcmlib.h renamed to src/gdcm.h
2171 * src/dcm.i renamed to src/gdcm.i
2172 * src/Makefile prepared for python wrapping
2174 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2175 * src/gdcmHeader.cxx :
2176 - Parsing of header is now separated from loading of element values
2177 (see gdcmHeader::LoadElements).
2178 - general clean up of hopefully all file access (creation of
2179 ReadInt16 and ReadInt32)
2181 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2182 * src/gdcmHeader.cxx :
2183 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2185 - SetLgrElem renamed to SetLength
2186 - GetLgrElem renamed to GetLength
2187 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2188 * src/gdcmElValSet.cxx fixed both GetElValue methods
2189 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2190 due to IdoDude was cleaned out.
2192 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2193 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2194 concentrates on finding the value representation (when it exists).
2195 RecupLgr now only finds the element value length, and it avoids
2196 returning the unecessary skL (skipped length).
2197 Also, offsetCourant was simply removed (with taille_fich) since
2198 it was redundant with the File position internals (by using
2199 ftell and fseek). This also made skL (see above in RecupLgr) usage
2201 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2202 on the libido specificities which are handled through class
2204 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2207 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2208 * Truckload of changes. Parsing of header is barely functional
2209 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2211 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2212 * src/gdcmHeader.cxx many addons of low level methods
2214 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2215 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2216 and _IdDcmSWAP_LONG.
2218 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2219 * This corresponds to all the changes decided at the meeting of
2220 May 23 2002. Needless to say we are running late...