1 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * setup.py fixed for un*x (needed macro for stdint.h)
3 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
4 un*ces with sh-utils test utility.
5 * gdcmPython/demo/test.py renamed to PrintHeader.py
6 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
7 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
8 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
9 * src/gdcm*.cxx JPR's bad inclusion fixed.
11 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
12 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
13 * gdcmPython/demo/test.py changed accordingly.
15 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
16 * gdcmPython/Makefile.am fixed linking against libstdc++
17 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
18 * Swig subdir (historical tests of swig version 1.3.17++) removed
19 * Test/testChangeEntete.cxx some lines commented out in order to make
21 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
22 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
24 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
25 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
26 hence the user doesn't need this explicit call.
27 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
28 i.e. LoadElements() call removed.
29 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
30 - src/Makefile.am declares the proper flag for g++.
31 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
32 for adding user defined new tags.
33 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
34 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
35 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
37 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
38 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
39 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
40 src/Makefile.am : the project should properly compile and install
41 with the autotools, included the python wrappers part.
42 * gdcm.spec.in : added a spec file for RPM packaging.
44 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
45 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
47 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
48 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
49 to exported to the environement (see gdcmPython/testSuite.py
51 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
52 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
53 ElValue class renamed to gdcmElValue for obvious consistency reasons.
54 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
55 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
57 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
58 * gdcmPython/__init__.py doesn't crash anymore when running in
59 in InstallMode or PreInstallMode but with an environement given
60 value of GDCM_DICT_PATH.
61 * src/gdcmDictSet.[cxx/h] coding style.
63 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
64 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
65 * src/gdcm.h general comments moved to TODO, and README
66 * src/gdcm.h should now be seen as a user commodity (including it
67 should suffice to fully use gdcm). It is nowhere including within
68 any of the kernel files src/*.cxx and src/*.h.
70 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
71 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
72 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
74 * src/gdcm*.cxx only include their corresponding include file
75 (as opposed to gdcm.h)
76 * gdcmPython/gdcm.i changed accordingly
77 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
78 the autogen.sh generated "make snapshot" command to work.
79 * autogen.sh removed history related references to crea package.
81 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
82 * distutilsSwigCPlusPlus.py work around some swig portability
85 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
86 * Eventually, python/gdcmPython was renamed to gdcmPython. This
87 was done in a last ditch attempt to get setup.py _really_
88 operationnal. The python/gdcmPython layaout add the advantage
89 of hidding away the python related distutils specific files
90 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
91 Alas, the src directory was out of scope (i.e. it's relative
92 position to setup.py was ../src) which made things impossible to
93 handle (see previous version of python/setup.py). Crossing fingers...
95 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
96 * python/setup.py now works on Un*x. (harder than I thougth)
97 * python/distutilsSwigCPlusPlus.py can now have include files
98 among the list of sources.
100 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
101 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
102 * modifications in MSVC projects
104 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
105 * As stated by the first lines of Test/ExceptionAndPython/README, it
106 looks like we can move back to original usage of exception within
107 src/gdcm* and hence remove the errno stuff that was introduced
108 as a quick and dirty fixture of this problem (added to the TODO).
109 * Doc/Doxyfile configuration file for Doxygen and corresponding
110 README file for usage added.
111 * Test/testWrite.cxx added. This new test comes from a split of
112 test.cxx that is now reverted to its original purpous i.e.
113 testing the proper parsing of a Dicom related file.
114 testWrite.cxx concentrates on testing the IO part of gdcm.
115 * Test/bug1.cxx (containing a bug on WIn32) added.
116 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
117 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
118 whose purpose is to publish the content of the TagNames of the
119 Dicom public dictionnary were not accessible without an
120 instance of class gdcmHeader.
121 - those methods are now static methods of gdcmDictSet and hence
122 require no instances at all to be invocated.
123 - within gdcmDictSet this change required to change some method
124 to class methods (i.e. are now static) among which SetDictPath
125 (renamed to BuildDictPath) and LoadDefaultPubDict.
126 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
127 the above changes by calling the new method classes of gdcmDictSet.
128 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
129 the above to be effective.
130 * python/gdcmPython: in order to wrap properly the above changes
131 for Python, swig version now needs to be > 1.3.17.
132 * python/gdcmPython/Makefile fixed to adapt itself to new
133 configure/make shema introduced by Johan Montagnat (thanks for the
134 contribution). Alas this Makefile cannot be turned into a proper
135 Makefile.am without some heavy changes in the configure.in
136 (for python dectection).
137 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
138 now avoids publishing the empty entries.
140 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
141 * python/setup.py : bug fix concerning install under windows
143 * gdcm.dsw : bug fix concerning path for libraries for python !!!
145 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * Dicts/dicomV3.dic : remove double spaces !!!
147 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
148 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
151 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
152 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
153 method. Doxygenation.
154 * src/gdcm.h clean up of JPR spurious comments.
156 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
157 * python/distutilsSwigCPlusPlus.py now properly collects the
158 shadow classes generated by "swig -c++" (gdcm.py in our case)
159 when using "python setup.py install".
160 * python/gdcmPython/__init__.py imports gdcm.py and only manually
161 reexports the working classes.
162 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
163 by the classical C errno scheme. This is to prevent an obscure
164 behavior of the python wrappers when importing wxPython.wx prior
165 to gdcmPython (which ended up in an abort call). An illustration
166 of this oddity can be found in the Test/ExceptionAndPython
167 subdir (see the README file). This problem probably due to
168 an combination of g++ and dynamic loading.
169 * added Test/ExceptionAndPython (see above)
171 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
172 * Changed the layout of the python part to avoid bloating main
173 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
174 i.e. the distutils arsenal. All the python related stuff is
175 again in a python subdir, but the package itself is now in
177 * setup.py was cleaned up:
178 - pythonIncludePath removed
179 - python setup.py bdist target is now functional.
180 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
181 collision with other packages). gdcmPython/demo/*.py changed
183 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
184 * python subdir moved to gdcmPython (preparation of distutils packaging).
185 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
186 distutils installer is operational.
187 * - gdcmPython/__init__.py now properly loads the swig generated
188 shadow classes (from gdcm.py).
189 - gdcmPython/demo/*.py changed to import the package gdcmPython
190 instead of gdcmPython/demo/load.py.
191 - gdcmPython/testSuite.py changed to import the package gdcmPython.
194 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
195 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
196 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
197 entries within the associated public Dicom dictionary resp. the same
198 information but sorted by the fourth field (PAT, IMG, DIR) of the
200 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
201 are now in the "???" group.
202 - python/gdcm.i changed accordingly,
203 - python/demo/printGroupedPublicDict.py added, that gives an example
204 of the above new functionalities in Python.
206 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
207 * src/gdcm.h, gdcmHeader.cxx:
208 - historic references to glib's g_malloc and g_free (#defined)
209 were definitively removed.
210 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
211 * src/gdcmElValSet.cxx:
212 - GetElement(guint32, guint32) renamed to GetElementByNumber.
213 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
214 - GetElValue(string) renamed to GetElValueByName.
215 - Added GetElementByName(string).
216 * src/gdcmHeader.cxx: added
217 - GetPubElValRepByNumber(guint16, guint16)
218 - GetPubElValRepByName(string)
219 - GetShaElValRepByNumber(guint16, guint16)
220 - GetShaElValRepByName(string)
221 - GetShaElValByNumber(guint16, guint16)
222 - GetShaElValRepByName(string)
223 - GetElValRepByNumber(guint16, guint16)
224 - GetElValRepByName(string)
225 - GetElValByNumber(guint16, guint16)
226 - GetElValRepByName(string)
227 * Doc/requirements.txt added.
229 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
230 * Test/Makefile building now depends on the one of libgdcm.so
231 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
232 pixel data) aware which enables finding the address (offset) of
233 the pixel data of JPEG encoded DICOM files. This leaves only a single
234 file in the testSuite whose pixel data address (offset) is unknown.
235 * python/testSuite.py changed accordingly.
237 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
238 * VC++ has some strong limitations when working with the STL, as stated
239 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
240 "Also note that some STL containers (map, set, queue, list, deque)
241 cannot be exported. [...]
242 Some STL classes contain nested classes. These classes can not
244 This is caused by a designed limitation that once a template
245 class is instantiated, it can not be re-instantiated and
247 Since our usage of map<> is ubiquitous in gdcm, this "designed
248 limitation" of VC++ is a pitfall.
249 Hence the Python wrappers of gdcm cannot be incrementally linked
250 against the c++ dynamic library. The dirty but only workaround is
251 to forget about incremental link of dynamic libraries and to generate
252 the Python wrappers library with the inclusions of the underlying C++
254 The following modifications concern this matter on Win32/VC++:
255 - wrapping python correct with standalone wrapped dll (don't use separate
256 dll under windows !!!!)
257 - python21_d debug mode enabled (ask Frog how to use it :-)
258 - NO problem with having an STL member of class for example string in C++
259 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
260 - Python test of dcmlib in Python is ok under windows on a large set
262 * removed glib references
263 * typedef's inserted in gdcm.i for correct swig type management
265 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
266 * python/demo/*.py load.py extracted from test.py. Added explore.py
267 that only displays required tags and testAll.py that parses all
268 the files of the testsuite without using unittest.
269 * python/testSuite.py other additional test on new files added.
270 * Data/* new test files added accordingly to the testSuite.
271 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
272 the vr in the file differs from the one of the dictionary.
274 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
275 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
276 values, but limits itself to values which are below a user specified
277 size (by default 1024 bytes).
278 * python/gdcm.i : elements not loaded (because their size is above the
279 user specified treshold) are exported with their TagKey as key of the
280 python dictionary. This enables the testsuite to make some checks
281 on the unloaded elements (since we have their offset and size).
282 * python/testSuite.py
283 - now tests for the existence and proper value of the pixel data
284 - two new examples added.
285 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
287 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
288 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
289 aware. See the strategy comments in gdcmHeader::FindeLength().
290 * Test/test.cxx now accepts a filename as first argument.
291 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
292 * python/testSuite.py changed to integrate test on above files.
294 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
295 * Dicts/dicomV3.dic removed all the trailing (RET) when the
297 * python/testSuite.py more tests added.
299 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
300 * python/testSuite.py unittest test suite added (uses Data)
301 * Data/* dcm and acr files for the test suite.
302 * glib dependance removed from un*x version. We now use ISO C99
303 7.18 Integer types (see stdint.h)
304 - python/Makefile, src/Makefile src/gdcm.h
305 * src/ when an explicit vr (like dicom files) suddenly poped an
306 implicit element we use to mark the underlying DictEntry of the
307 concerned ElValue with "Implicit". This strategy was damageable
308 too the public or provite dictionaries, since some of their vr
309 would be changed. Since Header::FindLength heavily relies on the
310 detection by Header::FindVR of falsely explicit elements, I
311 added an extra ImplicitVr member to ElValue (boolean).
312 The rest of the changes we the necessary adaptations.
314 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
315 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
317 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
319 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
320 * Adaptation for porting to VC++:
322 o forced to use std namespace (for string to be known)
323 o all class use __declspec export style on WIN32
324 - src/gdcmUtil.cxx new Exit method that wraps the exit call
325 (in stdlib.h on Win32 but in std:: for gcc)
326 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
327 variable GDCM_DICT_PATH.
328 * src/gdcmHeader.cxx verbose comments made discrete.
330 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
331 * python/gdcm.i: added a typemap that converts a C++ hashing table
332 to native Python dictionary.
333 * python/demo/test.py:
334 - now uses the native dictionary for exploration of gdcmHeader.
335 - takes an optional filename argument (the file to parse).
336 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
337 PubElVals hashing table.
338 * Dicts/dicomV3.dic removed error prone trailing spaces.
340 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
341 * Python wrapping process moved away from src/Makefile to
342 newly created python/Makefile (as well as gdcm.i)
343 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
344 * src/gdcmHeader::FindLength only looks for current vr when necessary.
345 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
346 from the environement variable GDCM_DICT_PATH (when existing).
347 * src/gdcmDict::GetTag bug fix.
349 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
350 * Straightforward temporary fixes for swig to build the python wrappers.
351 src/Makefile now has a python working entry [by working we mean
352 that we can import de shadow classes without errors].
354 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
355 * hashtest.cxx removed (since allready in Test)
356 * src/gdcmlib.h renamed to src/gdcm.h
357 * src/dcm.i renamed to src/gdcm.i
358 * src/Makefile prepared for python wrapping
360 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
361 * src/gdcmHeader.cxx :
362 - Parsing of header is now separated from loading of element values
363 (see gdcmHeader::LoadElements).
364 - general clean up of hopefully all file access (creation of
365 ReadInt16 and ReadInt32)
367 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
368 * src/gdcmHeader.cxx :
369 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
371 - SetLgrElem renamed to SetLength
372 - GetLgrElem renamed to GetLength
373 - ~gdcmHeader() made virtual to pesky warning messages at compile.
374 * src/gdcmElValSet.cxx fixed both GetElValue methods
375 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
376 due to IdoDude was cleaned out.
378 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
379 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
380 concentrates on finding the value representation (when it exists).
381 RecupLgr now only finds the element value length, and it avoids
382 returning the unecessary skL (skipped length).
383 Also, offsetCourant was simply removed (with taille_fich) since
384 it was redundant with the File position internals (by using
385 ftell and fseek). This also made skL (see above in RecupLgr) usage
387 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
388 on the libido specificities which are handled through class
390 * Test/implicit_vr.dcm dicom v3 in implicit value representation
393 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
394 * Truckload of changes. Parsing of header is barely functional
395 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
397 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
398 * src/gdcmHeader.cxx many addons of low level methods
400 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
401 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
404 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
405 * This corresponds to all the changes decided at the meeting of
406 May 23 2002. Needless to say we are running late...