1 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * src/gdcmHeader.h: LoadElements() is not a public method anymore
3 (to avoid double call by end user).
4 * Test/*.cxx LoadElements() doesn't need to be called explicitely
5 by end user, since gdcmHeader::gdcmHeader now handles it.
7 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
8 * gdcm/Doc many doxygen changes:
9 - Doxyfile now has two different versions, DoxyfileUsers that generates
10 the html.users end users oriented documentation and
11 DoxyfileDeveloppers that generates the html.developper developper
12 oriented documentation.
13 - README changed accordingly
14 - requirement.txt removed (old design info moved to TODO).
15 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
16 DoxyMainPage.txt, DoxyPython.txt provide more information.
17 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
18 be updated by simply regenerating the docs with doxygen and copying
19 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
20 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
21 all the tests in the form "if (<map>.count() >1)" were removed.
22 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
23 ill-formed documentation sections.
24 * src/gdcmHeader.cxx: ditto
26 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
27 * setup.py fixed for un*x (needed macro for stdint.h)
28 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
29 un*ces with sh-utils test utility.
30 * gdcmPython/demo/test.py renamed to PrintHeader.py
31 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
32 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
33 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
34 * src/gdcm*.cxx JPR's bad inclusion fixed.
36 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
37 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
38 * gdcmPython/demo/test.py changed accordingly.
40 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
41 * gdcmPython/Makefile.am fixed linking against libstdc++
42 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
43 * Swig subdir (historical tests of swig version 1.3.17++) removed
44 * Test/testChangeEntete.cxx some lines commented out in order to make
46 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
47 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
49 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
50 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
51 hence the user doesn't need this explicit call.
52 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
53 i.e. LoadElements() call removed.
54 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
55 - src/Makefile.am declares the proper flag for g++.
56 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
57 for adding user defined new tags.
58 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
59 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
60 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
62 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
63 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
64 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
65 src/Makefile.am : the project should properly compile and install
66 with the autotools, included the python wrappers part.
67 * gdcm.spec.in : added a spec file for RPM packaging.
69 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
72 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
73 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
74 to exported to the environement (see gdcmPython/testSuite.py
76 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
77 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
78 ElValue class renamed to gdcmElValue for obvious consistency reasons.
79 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
80 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
82 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
83 * gdcmPython/__init__.py doesn't crash anymore when running in
84 in InstallMode or PreInstallMode but with an environement given
85 value of GDCM_DICT_PATH.
86 * src/gdcmDictSet.[cxx/h] coding style.
88 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
89 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
90 * src/gdcm.h general comments moved to TODO, and README
91 * src/gdcm.h should now be seen as a user commodity (including it
92 should suffice to fully use gdcm). It is nowhere including within
93 any of the kernel files src/*.cxx and src/*.h.
95 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
96 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
97 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
99 * src/gdcm*.cxx only include their corresponding include file
100 (as opposed to gdcm.h)
101 * gdcmPython/gdcm.i changed accordingly
102 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
103 the autogen.sh generated "make snapshot" command to work.
104 * autogen.sh removed history related references to crea package.
106 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
107 * distutilsSwigCPlusPlus.py work around some swig portability
110 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
111 * Eventually, python/gdcmPython was renamed to gdcmPython. This
112 was done in a last ditch attempt to get setup.py _really_
113 operationnal. The python/gdcmPython layaout add the advantage
114 of hidding away the python related distutils specific files
115 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
116 Alas, the src directory was out of scope (i.e. it's relative
117 position to setup.py was ../src) which made things impossible to
118 handle (see previous version of python/setup.py). Crossing fingers...
120 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
121 * python/setup.py now works on Un*x. (harder than I thougth)
122 * python/distutilsSwigCPlusPlus.py can now have include files
123 among the list of sources.
125 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
126 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
127 * modifications in MSVC projects
129 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
130 * As stated by the first lines of Test/ExceptionAndPython/README, it
131 looks like we can move back to original usage of exception within
132 src/gdcm* and hence remove the errno stuff that was introduced
133 as a quick and dirty fixture of this problem (added to the TODO).
134 * Doc/Doxyfile configuration file for Doxygen and corresponding
135 README file for usage added.
136 * Test/testWrite.cxx added. This new test comes from a split of
137 test.cxx that is now reverted to its original purpous i.e.
138 testing the proper parsing of a Dicom related file.
139 testWrite.cxx concentrates on testing the IO part of gdcm.
140 * Test/bug1.cxx (containing a bug on WIn32) added.
141 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
142 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
143 whose purpose is to publish the content of the TagNames of the
144 Dicom public dictionnary were not accessible without an
145 instance of class gdcmHeader.
146 - those methods are now static methods of gdcmDictSet and hence
147 require no instances at all to be invocated.
148 - within gdcmDictSet this change required to change some method
149 to class methods (i.e. are now static) among which SetDictPath
150 (renamed to BuildDictPath) and LoadDefaultPubDict.
151 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
152 the above changes by calling the new method classes of gdcmDictSet.
153 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
154 the above to be effective.
155 * python/gdcmPython: in order to wrap properly the above changes
156 for Python, swig version now needs to be > 1.3.17.
157 * python/gdcmPython/Makefile fixed to adapt itself to new
158 configure/make shema introduced by Johan Montagnat (thanks for the
159 contribution). Alas this Makefile cannot be turned into a proper
160 Makefile.am without some heavy changes in the configure.in
161 (for python dectection).
162 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
163 now avoids publishing the empty entries.
165 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
166 * python/setup.py : bug fix concerning install under windows
168 * gdcm.dsw : bug fix concerning path for libraries for python !!!
170 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
171 * Dicts/dicomV3.dic : remove double spaces !!!
172 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
173 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
176 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
177 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
178 method. Doxygenation.
179 * src/gdcm.h clean up of JPR spurious comments.
181 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
182 * python/distutilsSwigCPlusPlus.py now properly collects the
183 shadow classes generated by "swig -c++" (gdcm.py in our case)
184 when using "python setup.py install".
185 * python/gdcmPython/__init__.py imports gdcm.py and only manually
186 reexports the working classes.
187 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
188 by the classical C errno scheme. This is to prevent an obscure
189 behavior of the python wrappers when importing wxPython.wx prior
190 to gdcmPython (which ended up in an abort call). An illustration
191 of this oddity can be found in the Test/ExceptionAndPython
192 subdir (see the README file). This problem probably due to
193 an combination of g++ and dynamic loading.
194 * added Test/ExceptionAndPython (see above)
196 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
197 * Changed the layout of the python part to avoid bloating main
198 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
199 i.e. the distutils arsenal. All the python related stuff is
200 again in a python subdir, but the package itself is now in
202 * setup.py was cleaned up:
203 - pythonIncludePath removed
204 - python setup.py bdist target is now functional.
205 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
206 collision with other packages). gdcmPython/demo/*.py changed
208 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
209 * python subdir moved to gdcmPython (preparation of distutils packaging).
210 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
211 distutils installer is operational.
212 * - gdcmPython/__init__.py now properly loads the swig generated
213 shadow classes (from gdcm.py).
214 - gdcmPython/demo/*.py changed to import the package gdcmPython
215 instead of gdcmPython/demo/load.py.
216 - gdcmPython/testSuite.py changed to import the package gdcmPython.
219 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
220 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
221 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
222 entries within the associated public Dicom dictionary resp. the same
223 information but sorted by the fourth field (PAT, IMG, DIR) of the
225 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
226 are now in the "???" group.
227 - python/gdcm.i changed accordingly,
228 - python/demo/printGroupedPublicDict.py added, that gives an example
229 of the above new functionalities in Python.
231 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
232 * src/gdcm.h, gdcmHeader.cxx:
233 - historic references to glib's g_malloc and g_free (#defined)
234 were definitively removed.
235 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
236 * src/gdcmElValSet.cxx:
237 - GetElement(guint32, guint32) renamed to GetElementByNumber.
238 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
239 - GetElValue(string) renamed to GetElValueByName.
240 - Added GetElementByName(string).
241 * src/gdcmHeader.cxx: added
242 - GetPubElValRepByNumber(guint16, guint16)
243 - GetPubElValRepByName(string)
244 - GetShaElValRepByNumber(guint16, guint16)
245 - GetShaElValRepByName(string)
246 - GetShaElValByNumber(guint16, guint16)
247 - GetShaElValRepByName(string)
248 - GetElValRepByNumber(guint16, guint16)
249 - GetElValRepByName(string)
250 - GetElValByNumber(guint16, guint16)
251 - GetElValRepByName(string)
252 * Doc/requirements.txt added.
254 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
255 * Test/Makefile building now depends on the one of libgdcm.so
256 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
257 pixel data) aware which enables finding the address (offset) of
258 the pixel data of JPEG encoded DICOM files. This leaves only a single
259 file in the testSuite whose pixel data address (offset) is unknown.
260 * python/testSuite.py changed accordingly.
262 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
263 * VC++ has some strong limitations when working with the STL, as stated
264 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
265 "Also note that some STL containers (map, set, queue, list, deque)
266 cannot be exported. [...]
267 Some STL classes contain nested classes. These classes can not
269 This is caused by a designed limitation that once a template
270 class is instantiated, it can not be re-instantiated and
272 Since our usage of map<> is ubiquitous in gdcm, this "designed
273 limitation" of VC++ is a pitfall.
274 Hence the Python wrappers of gdcm cannot be incrementally linked
275 against the c++ dynamic library. The dirty but only workaround is
276 to forget about incremental link of dynamic libraries and to generate
277 the Python wrappers library with the inclusions of the underlying C++
279 The following modifications concern this matter on Win32/VC++:
280 - wrapping python correct with standalone wrapped dll (don't use separate
281 dll under windows !!!!)
282 - python21_d debug mode enabled (ask Frog how to use it :-)
283 - NO problem with having an STL member of class for example string in C++
284 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
285 - Python test of dcmlib in Python is ok under windows on a large set
287 * removed glib references
288 * typedef's inserted in gdcm.i for correct swig type management
290 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
291 * python/demo/*.py load.py extracted from test.py. Added explore.py
292 that only displays required tags and testAll.py that parses all
293 the files of the testsuite without using unittest.
294 * python/testSuite.py other additional test on new files added.
295 * Data/* new test files added accordingly to the testSuite.
296 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
297 the vr in the file differs from the one of the dictionary.
299 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
300 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
301 values, but limits itself to values which are below a user specified
302 size (by default 1024 bytes).
303 * python/gdcm.i : elements not loaded (because their size is above the
304 user specified treshold) are exported with their TagKey as key of the
305 python dictionary. This enables the testsuite to make some checks
306 on the unloaded elements (since we have their offset and size).
307 * python/testSuite.py
308 - now tests for the existence and proper value of the pixel data
309 - two new examples added.
310 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
312 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
313 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
314 aware. See the strategy comments in gdcmHeader::FindeLength().
315 * Test/test.cxx now accepts a filename as first argument.
316 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
317 * python/testSuite.py changed to integrate test on above files.
319 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
320 * Dicts/dicomV3.dic removed all the trailing (RET) when the
322 * python/testSuite.py more tests added.
324 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
325 * python/testSuite.py unittest test suite added (uses Data)
326 * Data/* dcm and acr files for the test suite.
327 * glib dependance removed from un*x version. We now use ISO C99
328 7.18 Integer types (see stdint.h)
329 - python/Makefile, src/Makefile src/gdcm.h
330 * src/ when an explicit vr (like dicom files) suddenly poped an
331 implicit element we use to mark the underlying DictEntry of the
332 concerned ElValue with "Implicit". This strategy was damageable
333 too the public or provite dictionaries, since some of their vr
334 would be changed. Since Header::FindLength heavily relies on the
335 detection by Header::FindVR of falsely explicit elements, I
336 added an extra ImplicitVr member to ElValue (boolean).
337 The rest of the changes we the necessary adaptations.
339 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
340 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
342 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
344 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
345 * Adaptation for porting to VC++:
347 o forced to use std namespace (for string to be known)
348 o all class use __declspec export style on WIN32
349 - src/gdcmUtil.cxx new Exit method that wraps the exit call
350 (in stdlib.h on Win32 but in std:: for gcc)
351 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
352 variable GDCM_DICT_PATH.
353 * src/gdcmHeader.cxx verbose comments made discrete.
355 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
356 * python/gdcm.i: added a typemap that converts a C++ hashing table
357 to native Python dictionary.
358 * python/demo/test.py:
359 - now uses the native dictionary for exploration of gdcmHeader.
360 - takes an optional filename argument (the file to parse).
361 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
362 PubElVals hashing table.
363 * Dicts/dicomV3.dic removed error prone trailing spaces.
365 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
366 * Python wrapping process moved away from src/Makefile to
367 newly created python/Makefile (as well as gdcm.i)
368 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
369 * src/gdcmHeader::FindLength only looks for current vr when necessary.
370 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
371 from the environement variable GDCM_DICT_PATH (when existing).
372 * src/gdcmDict::GetTag bug fix.
374 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
375 * Straightforward temporary fixes for swig to build the python wrappers.
376 src/Makefile now has a python working entry [by working we mean
377 that we can import de shadow classes without errors].
379 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
380 * hashtest.cxx removed (since allready in Test)
381 * src/gdcmlib.h renamed to src/gdcm.h
382 * src/dcm.i renamed to src/gdcm.i
383 * src/Makefile prepared for python wrapping
385 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
386 * src/gdcmHeader.cxx :
387 - Parsing of header is now separated from loading of element values
388 (see gdcmHeader::LoadElements).
389 - general clean up of hopefully all file access (creation of
390 ReadInt16 and ReadInt32)
392 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
393 * src/gdcmHeader.cxx :
394 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
396 - SetLgrElem renamed to SetLength
397 - GetLgrElem renamed to GetLength
398 - ~gdcmHeader() made virtual to pesky warning messages at compile.
399 * src/gdcmElValSet.cxx fixed both GetElValue methods
400 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
401 due to IdoDude was cleaned out.
403 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
404 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
405 concentrates on finding the value representation (when it exists).
406 RecupLgr now only finds the element value length, and it avoids
407 returning the unecessary skL (skipped length).
408 Also, offsetCourant was simply removed (with taille_fich) since
409 it was redundant with the File position internals (by using
410 ftell and fseek). This also made skL (see above in RecupLgr) usage
412 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
413 on the libido specificities which are handled through class
415 * Test/implicit_vr.dcm dicom v3 in implicit value representation
418 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
419 * Truckload of changes. Parsing of header is barely functional
420 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
422 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
423 * src/gdcmHeader.cxx many addons of low level methods
425 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
426 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
429 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
430 * This corresponds to all the changes decided at the meeting of
431 May 23 2002. Needless to say we are running late...