1 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
4 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
5 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
7 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
8 * Testing/TestMAkeIcon.cxx : complete the test
10 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memroy leaks
13 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
14 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
17 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
18 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
20 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
21 * Test/ : accelerate tests (it's not very significant accelerations).
22 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
24 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
25 * Testing/TestSequence.cxx : add test for sequences of images... test that
26 we have the same serie or the same study UID
28 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
29 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
31 * src/gdcmDict.h : remove commented code
32 * src/gdcmDocument.cxx : initialize values
33 * src/gdcmFile.cxx : bug fix when reading values
34 * gdcmPython/demo/ : change file names. Remove useless files
36 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
37 * src/gdcmFile.cxx : remove the default array of initialization.
38 The static array contained pointers to non-static values (comming from
39 strings). To have coherences, when creating files, these values can't be
40 static. So, the array can't be static, too ! To simplify, the array have
41 been replaced by repeted lines to insert values in the File
43 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
44 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
45 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
47 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
48 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
49 (Dicom Element) into the Sequence Item
51 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
52 * src/*.cxx : first parss to normalize file organisation
54 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
55 * src/gdcmDirList.[h|cxx] : add method to find a directory
56 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
58 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
59 * Finish cleaning up my JPEG mess. Should be ok now.
60 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
61 contained within the RLE* class(doh!)
63 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
64 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
65 * SerieHeader::AddFileName() creates as many Coherent Files lists
66 (same Serie UID) as it founds different Serie UID
67 amongst the files instead of discarting any file
68 that doesn't match with the first one he found.
69 * SerieHeader::OrderGdcmFileList has now one parameter :
70 the Coherent Files list the user wants to sort
71 * SerieHeader::GetFirstCoherentFileList() |
72 * SerieHeader::GetLastCoherentFileList() | allow to parse
73 the set of Coherent Files lists
74 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
75 compatibility (it returns the *first* Coherent Files list,
76 since there was only one before)
77 * Test/TestSerieHeader gets gdcmData as a default root directory
79 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
80 * Remove friend between DocEntry and File classes
81 * Remove friend between PixelReadConverter and RLEFramesInfo,
84 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
85 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
86 0002|0000. The value was incorrect.
88 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
89 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
91 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * src/gdcmUtil.cxx : compilation fix on Win32
93 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
94 variable, to be easy found. Add methods to change the default UID.
95 Amelioration of the CreateUniqueUID to use the correct default UID.
96 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
99 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
100 * Test/TestVR.cxx : fix memory leaks
102 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
103 * Rewrite the base 256 to base 10 conversion, using string operation only.
104 This allows us to get rid of the problematic 64bits integer type (does not
105 always exist on target platform).
107 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
108 * Add construct and destructor to class gdcm::Debug to close the debug file
110 * Don't let uset to open twice the same file
111 * gdcm has now an official UID prefix,
112 supplied by http://www.medicalconnections.co.uk
113 1.2.826.0.1.3680043.2.1143
114 (Thx to Mathieu for providing URL)
115 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
116 to be able to perform some more tests
117 * gdcm::ContentEntry : Contructors and Destructor are now protected,
118 in order to be sure no user will try to use them.
119 (at user level, only the children classes are meaningfull)
121 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
122 * move RLEInfo & JPEGInfo from Document to File
124 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
125 * FIX : remove so many friend between classes
127 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
128 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
129 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
131 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
132 In order to avoid missbehaviour :
133 . gdcm::DocEntry is now specialized in
134 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
135 - gdcm::ContentEntry (Dicom entry with a 'content')
136 . gdcm::ContentEntry is specialized in
137 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
138 characters value, or integers)
139 - gdcm::BinEntry (Dicom entry with a non strig representable value
140 (user hasn't any longer to thing about the precedence of his dynamic_casts)
142 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
143 * Test/VTKTest*.cxx : bug fix under linux
145 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
147 use with python. Some methods are moved from Document to ElementSet or
148 DocEntrySet. The equivalent methods to ElementSet have been added to
149 SQItem and are virtual in DocEntrySet. Methods that may have the same code
150 in SQItem and ElementSet is directly placed in DocEntrySet
152 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
153 * Test/VTKTest*.cxx : remove the show variable in each test method because
154 it's useless (the viewer variable replace this variable)
156 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
157 * src/gdcmDocument.cxx : bug fix on potential memory leak
158 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
159 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
160 Add ClearXxx methods to remove all the content of the list or map
161 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
163 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
164 * methods ReplaceOrCreate renamed as Insert
165 (nobody will be any longer confused by 'CreateOrReplace')
167 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
168 * Grealty simplify the JPEg decompression, no need to differenciate based on
169 the JPEG possible type (with/without fragment, with/without multiple frame).
170 Everything is done throught the JPEG IO Suspension mechanism in IJG
172 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
173 * Stage 3 of normalization :
174 in order to avoid any missunderstanding while reading method names :
175 - All the methods xxxEntry now deal with dicom Entries
176 - Methods GetEntry splitted into
179 - Method SetEntry renamed as SetEntryValue
180 - Method SetEntryBinArea let as it was
182 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
183 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
184 - Position correctly the entry points for JPEG2000 and JPEG-LS
185 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
187 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
188 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
189 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
190 with other method names
191 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
192 * Test/TestDicomDirElement.cxx : add new test
194 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
195 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
196 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
197 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
198 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
199 So can't you use __int64 in ostream at all.
201 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
202 * bug fix for compilation on MSVC6
203 * gdcmPython/gdcm.i : rename of classes missed
205 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
206 * Stage 2 of names normalization :
207 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
208 (easy to understand ...)
209 - gdcm::FileHelper replaces old class gdcm::File
211 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
212 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
213 type and not a string. So, there remove problems on the format of the
216 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
217 * Add Example/TestPapyrus.cxx
218 - reads a Papyrus file (gdcm::Header compliant),
219 - gets the pixels of all the images, using low level iterators
220 - writes an multiframes Dicom image.
221 (Just to show it's *possible* to do that)
222 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
225 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
226 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
227 Thus, DicomDirXXX are created with a flad that indicates if the created
228 object is empty or not (when not empty, the DicomDirElement is used to
231 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
232 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
233 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
235 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
236 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
238 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
239 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
240 Remove all access to the hash-tables or lists in the objects.
242 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
243 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
244 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
245 be complient with all the gdcm source code
247 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
248 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
251 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
252 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
255 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
256 * Test/ : rename VTK tests to have a best name for the tests
257 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
258 GetFirstEntry/GetNextEntry use
260 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
261 * In SerieHeader::ImagePositionPatientOrdering()
262 // a Dicom 'Serie' may contain scout views
263 // and images may have differents directions.
264 // -> More than one may have the same 'pos'
265 // Sorting has then NO meaning !
266 Thx to Eduardo Davila for reporting bug.
268 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
269 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
270 test. Now it's on image content and not on the resulting visualisation...
271 might solve the problem on linux when using the OpenGL drivers
273 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
274 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
275 DicomDirSerie, DicomDirImage
276 Dict, DictSet classes :
277 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
278 -remove InitTraversal method.
279 * UPD Test programs + Example programs
281 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
282 * remove useless and never updated keyword \ingroup
283 * Solve pb when structure (list, map, ...) is empty.
284 Thx to Benoit for reporting bug
286 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
287 * Taking into account of 'Transfer Syntax' value
288 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
291 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
292 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
293 is no memory access violation
294 * gdcmPython/demo : add python demos using VTK
296 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
297 * FIX 'Dictionnary' is now spelt 'Dictionary'
298 'wether' is now spelt 'whether'
299 'archieve' is now spelt 'archive' ;-)
301 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
302 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
303 related methods, in order not to expose internal mechanisms
306 * REM methods that exposed internal mechanisms :
307 DicomDir::GetDicomDirPatients()
308 DicomDirPatient::GetDicomDirStudies()
309 DicomDirStudy::GetDicomDirSeries()
310 DicomDirSerie::GetDicomDirImages()
311 * UPD Test programs :
315 * UPD Example program
317 * ADD DictSet methods
321 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
322 * Removed the Print/indent/default parameter mess. There is absolutely no
323 reason to have to methods, moreover with the second taking the ostream as
324 *SECOND* parameter. This was clearly a bad hack to get things compile.
326 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
327 * Complete rewrite of the GetMacAddress code. Now the code is *much*
328 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
329 Unfortunately the main code does not work on SunOS, thus provide a specific
330 code for this platform only (and Win32 of course). Since this seems to be
331 working, change CreateUniqueUID to use GetMACAddress instead of the
332 problematic GctestetIPAddress
334 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
335 * Unfortunately to be able to test gdcmDirList I had to break the API
336 a little. Now the class is not a std::list anymore but has a member
337 std::vector (more ITK compatible). Allow unit testing on Win32 and
340 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
341 * Update SerieHeader to take into account a Serie Instance UID to properly
344 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
345 * ENH - Comment out Mathieu's (dangerous) Super Hack
346 for dealing with BIGENDIAN processors
347 - Move equivalent stuff to BinEntry::WriteContent
348 When necessary, 16 Bits Pixels are swapped in a small buffer
349 and then written. This avoid allocating a huge buffer, in
350 PixelWriteConvertor, and avoid modifying the Pixel Area.
352 Probabely, the same operation will have to be done when we want
353 to write image with Big Endian Transfert Syntax,
354 and we are working on Little Endian Processor
356 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
357 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
359 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
360 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
361 all the dict content.
362 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
364 * Test/TestDict.cxx : add a new test for the dict classes
366 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
367 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
368 file. Debug is yanked if compiled with NDEBUG
370 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
371 * src/gdcmDictSet.h : set the default output to the os variable
372 * src/gdcmDictEntry.[h|cxx] : add the Print method
373 * gdcmPython/demo/ : add a new test
375 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
376 * merging of Test/PrintDicomDir and Test/TestDicomDir
377 * removal of now redundant Test/PrintDicomDir
378 * enhancement of Example/PrintDicomDir
380 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
381 * Now, python test might work on systems
382 * Add the PrintDicomDir test
384 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
385 * FIX : First entry following group 0002 was lost for
386 Explicit Big Endian Transfer Syntax files
387 (group and elem not swaped)
389 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
390 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
391 Big Endian Transfer Syntax supposed the group following 0002
392 begins always by element 0000 (element 0000 is *optional*)
393 To avoid further troubles, let's be pessimistic, and use
394 Document::HandleOutOfGroup0002() method
395 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
396 (related pb not yet solved)
398 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
399 * Bug fix for the python part use
400 * Now, PrintHeader.py pass... but outside the ctest use. shit !
402 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
403 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
405 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
406 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
407 a string and should ask the global TS dict what are the propreties of
410 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
411 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
412 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
413 to swap the Swap Code, at parsing time, when we come out of group 0002
414 and Transfer Syntax is Big Endian
415 We should be able to read now 'true DICOM" Big Endian coded images
416 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
417 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
419 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
420 * Hopefully fix the bug on MacOSX and static global initialization.
421 This is the only -minor- patch I found that both please MacOSX and VS6.
422 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
423 but this would require a lot of change. Another approach would be that Global
424 create those string and GDCM_UNFOUND becomes a pointer to a string (which
425 gdcm::Global would destroy at exit).
427 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
428 * Fix bug on MacOSX with static initialization in a multy threaded
429 environment. static const string in a header file used to be ill
430 initialized provoquing the freeze of any tests. patch should solve this
433 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
434 * According to Benoit's suggestion, and without any objection from anybody
435 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
436 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
437 - method gdcmDicomDirObject::GetEntry() renamed as
438 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
440 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
441 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
442 you debug/warning message just as c++ streams which make them very convinient
443 to use. Once this is stabilize I will change the ostringstrem to be
444 redirected to a file (ofstream).
445 * Properly support C99 extension: __FUNCTION__ which allow us to display
446 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
448 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
449 * Removal of useless and dangerous methods :
450 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
451 GetDocEntryByName, GetEntryByName, GetDictEntryByName
452 * Removal of usless methods :
453 Dict::PrintByName, Dict::GetDictEntryByName
454 * Commenting out of probabely useless methods :
455 Dict::GetDictEntryNames()
456 Dict::GetDictEntryNamesByCategory()
457 DictSet::GetPubDictEntryNames()
458 DictSet::GetPubDictEntryNamesByCategory()
459 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
460 * ENH : Use dicomTS.dic as described in 2004 version
461 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
462 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
463 Add Accessors on VM (Value Multiplicity), and VM related methods
464 * ADD : Add a list of 'Dicom Attribute types', as found in
465 http://medical.nema.org/dicom/2004/04_15PU.PDF
467 * ADD : Add dicomGroupNameAbbreviations.dic
468 should be used to write a method to replace the former
469 Dict::GetDictEntryNamesByCategory()
471 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
472 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
473 to read in the file... and only it ! Length is the efective length of the
474 data in the DocEntry structure
476 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
477 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
478 And now use a static function call instead, with a global variable. i
479 This is much closer to the VTK approach. Hopefully should be bulletproof
480 and easier to use...hopefully
482 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
483 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
485 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
486 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
488 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
489 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
490 ValEntry, BinEntry, SeqEntry creation or replace
492 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
493 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
494 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
496 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
497 when specifying the VR
498 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
499 * src/gdcmDocEntry.cxx : amelioration of print
501 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
502 * ADD : Add the method Util::IsCurrentProcessorBigEndian
503 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
504 * ADD Method Document::ComputeGroupLength
505 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
506 in order to allow further VR modification by user
507 * REM : removal of once-called method File::WriteBase
508 integration of its code in formerly one-line method File::Write
510 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
511 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
512 replace the different values "??", "Unkn", "Unknown".
513 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
514 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
515 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
516 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
518 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
519 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
521 * Set the gdcm::Base class to some Printable classes
523 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
524 * src/gdcmFile.[h|cxx] : add the Print method
525 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
526 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
527 * src/gdcmDocument.h : remove the PrintLevel informations
528 * Example/PrintFile.cxx : use the new gdcm::File::Print
530 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
531 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
532 problems when compiling with the python wrapping
534 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
535 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
536 writting in ImplicitVR
538 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
539 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
540 JPEG decompression, especially when dicom frames are split into several
541 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
542 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
544 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
545 * src/gdcmHeader.cxx : change the initialisation of default header.
546 Now, this header is readable by gdm, e-film, DicomWorks
548 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
549 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
550 Rename Decompressed to Raw
551 * Use the API changes in gdcm::File.
552 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
555 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
556 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
557 each added entry in the header. Replace the 'Planes' field by the 'Number
560 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
561 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
562 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
564 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
565 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
566 At this time, this image isn't readable by e-film... waiting JPR help to
569 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
570 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
571 DocEntry. Now use methods of the Document !
573 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
574 * Test/ShowDicomSeq.cxx : bug fix
576 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
577 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
578 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
579 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
580 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
582 * Test/TestCopyRescaleDicom.cxx : remove unused variable
583 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
584 containing found sequences
586 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
587 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
589 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
590 Some fields in BinEntry must be copied to not seg fault when making the :
591 gdcm::File *copy = new gdcm::File( copyH );
592 and tests are now made on good variables
594 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
595 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
596 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
598 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
599 * Add vtkGdcmWriter example and test
601 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
602 * Test/TestUtil.cxx : reformat the source code
603 * vtk/vtkGdcmReader.cxx : remove and change prints
604 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
606 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
607 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
609 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
610 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
611 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
613 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
614 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
615 by an eof to prevent all bad read of the file... and in this case, the
618 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
619 * Example/Volume2Dicom.cxx : comment unused variables
620 * Test/PrintDicomDir.cxx : comment unused variables
621 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
622 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
623 method that is redondant with AddEntry.
624 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
627 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
628 * Bug fix due my last commit (compilation under Windows).
629 * Example/Volume2Dicom : bug fix in the file and reformatting source code
630 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
632 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
634 - Remove printf / sprintf
635 - include iostream AFTER gdcm so we don't get warnings
636 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
638 - Also remove tons of include from header files, hopefully this should
639 speeup the compilation time, since it was becoming a dog slow.
640 - Remove gdcm.h as it include way too many files and slow down compilation
641 (plus it is not up to date)
642 - remove 'using namespace std' this is BAD !
644 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
645 * Remove memory leaks on the DicomDir
646 * Remove some useless data in DicomDirObject
647 * Add usefull methods in SQItem, to be complient withe the ElementSet
649 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
650 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
652 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
653 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
654 future, with convertion)
655 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
656 and ImageDataSize values. Remove the method to get the PixelReadConverter
657 from the output of the class
659 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
660 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
662 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
663 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
664 and vtkErrorMacro use.
665 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
667 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
668 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
670 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
671 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
672 The string leaves only in the fonction. So when we make a .c_str(), we
673 get the pointeur on the first element, element that will be destroyed
674 immediately after thee instruction.
675 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
676 file has been opened : the test must be made on the content of the
677 pointer and not directly on the pointer !
680 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
681 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
682 the python part recompiles
684 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
685 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
686 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
687 X session is killed (for my computer... it seems to not be identic on
690 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
691 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
692 avoid problems (otherwise, the difference test between the visible image
693 and the reference is incorrect. If the reference is greater than the
694 screen resolution, it's produce errors).
695 Can be used for only one image. Can be used with a visible flag.
696 * vtk/vtkGdcmReader.cxx : remove commented codes.
697 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
698 under windows at compilation
699 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
701 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
703 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
704 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
705 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
706 tests on the image size X, Y, Z
708 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
709 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
710 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
711 between the class name and the file name
713 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
714 * src/ : fix compilation warnings for the Write method (2 different
715 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
716 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
717 variable... create a static method in gdcm::Document to access to
718 this variable content.
720 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
721 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
722 file, to be accessed by other files (like gdcmFile). Remove commented
723 code. Move the change of the header to the gdcmFile, using the
725 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
726 To be sure of that (and simplify calls), the Write of the header now
727 gets a file name and not a file pointer (std::ifstream).
728 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
729 DocEntryArchive. Remove all open of the written file
731 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
732 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
734 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
735 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
736 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
738 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
739 some corresponding methods. Write correctly the file and check before
741 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
742 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
743 is now on RGB data (as before my last commit
744 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
746 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
747 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
748 Add a print information of the type of the entry
749 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
750 It was in the gdcmFile, and all write have been regrouped
751 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
752 Write correctly all dicom files (in decompressed mode only at this time)
753 * Test/ : test on files are now made using Raw data and not color data if
755 * Example/PrintFile.cxx : add more printings
757 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
758 * Amelioration of code, remove some code copy. For the loading of
759 BinEntry (in gdcmDocument), add the test to verify if the file is already
762 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
763 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
764 remove a DocEntry in the header (push an empty DocEntry)
765 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
766 lines. Bug fix in the initialization of the PixelConvert and the
768 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
769 use in TestCopyDicom (now this test can run under windows... but fails)
770 * Test/TestCopyDicom.cxx : amelioration of the test :
771 - test the pixels written
772 - add test points to quickly find where is the error
773 - can set a file name input and output in arguments
774 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
775 amelioration of the test output
777 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
778 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
779 all replaced DocEntry's
780 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
781 Now, each needed DocEntry to modify is duplicated, modified and inserted
782 to the header using DocEntryArchive. Thus, after save, we can restore the
783 header initial state.
785 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
786 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
788 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
789 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
790 correct to copy it. The DictEntry is specified at the DocEntry creation,
791 then, it musn't change in the time.
792 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
793 header correctly. At this time, the change is only made for the first
794 level of the Document. In the future, it might consider sequences.
795 The change is made by replacing a DocEntry by an other that is created
796 outside the class. The old value is kept. When we restore the header
797 status, the added DocEntry is deleted and replaced by the old value.
798 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
799 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
800 set the write type to explicit VR, implicit VR or ACR. Add methods to set
801 the write mode to native, decompressed or RGB (but not used at this time)
803 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
804 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
805 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
807 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
808 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
809 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
811 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
812 set because already copied when copying the BinEntry's of the header
813 * Test/TestAllReadCompareDicom.cxx : remove warnings
815 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
816 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
817 Two problems appear when doing it :
818 - with the gdcmFile : when the GetImageData method is called, the pixels
819 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
820 data (pixels). And each structure destruct the data when it's
821 destructed. So we have two destructions for the same data. To solve it,
822 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
823 data or not. If it doesn't own data, then they will not destroyed by
825 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
826 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
827 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
828 create a double destruction of the same DocEntry's. So, to solve it,
829 the TagHT is simply cleared and the DicomDir* elements are destroyed.
830 * TODO : add an entry concerning memory leaks in the DicomDir
832 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
833 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
834 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
837 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
838 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
839 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
840 after it have been deleted
842 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
843 * FIX: src/* fix the doxygen warnings.
844 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
845 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
846 was erroneously defined with a size of 15 instead of 16. [many thanks
847 to Jean Michel Rouet for pointing out this bug].
849 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
850 1. Finish merging JMR patch for writting DICOM from scratch
851 2. Fix -hopefully- bug with MONOCHROME and space vs null character
852 3. Use const ref when possible
853 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
854 5. A few more comments
855 6. CreateUniqueUID can now be called without parameter"
857 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
858 * ENH: Slightly bigger patch:
859 1. Getting toward full integration of JMR patch for writting dicom from scratch
860 2. Update Test to test part of this patch: CreateUniqueUID
861 3. File was not close properly in gdcmDict
862 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
863 5. Use of const ref instead of copy (speed issue)
864 6. Remove temporary (duplicate) string in TranslateToKey
865 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
866 8. Do not repeat virtual in subclasses
867 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
869 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
870 * Apply first patch toward better string comparison when dealing with broken
871 DICOM files. Essentially the string could be padded with a space instead
872 of a null character as defined by standard
874 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
875 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
876 because never used... and in the same time, that's remove some memory leaks
878 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
879 * src/gdcmFile.cxx : now delete the PixelConvert instance.
880 * In examples and tests : change the type of image data variables from void*
881 to uint8_t*. Remmove all delete on image data variables
883 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
884 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
885 Verify the file pointer value before open the file, and if it's not null,
886 a verbose message is generated.
887 Close correctly the file when the file isn't considered dicom-like. The
888 correctly close is a call to CloseFile.
889 When closing the file pointer, test if its not null to close the file.
890 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
891 file. For an uncompressed image, the copied data correspond in the least
892 case to the image size (calculated) or the image size specified in the
893 header. A verbose is generated if these two size mismatch
895 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
896 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
897 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
898 break under windows (with msvc6 compilation).
900 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
901 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
902 compiling with MSVC6)
904 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
905 * Bugs fix for the Windows build with VC6
906 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
907 needed (only for projects required VTK). If the VTK is included in all
908 projects, there is conflicts with the jpeg lib of vtk when compiling the
909 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
910 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
911 when compiling the gdcm_wrap.cxx file (created by the compilation of the
913 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
914 (like it's already made for the cout use). Otherwise, conflict with the
917 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
918 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
920 - comments on the DicomDir::Method related usage added.
921 - now that we use the namespace gdcm, a lot of internal classes do
922 NOT need to be wrapped anymore.
923 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
924 DicomDir::Method) new example added.
926 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
927 * Improve string manipulation. I now inforce the notion of 'DicomString'
928 A DicomString can contain as many \0 as they want
929 and it is *always* of even length.
930 We only support odd length for very rare case.
931 And in the near future this should be removed.
933 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
934 * /binary_write/ gdcm source. Now even on big endian we are writting
935 little endian. This should -heopfully- fix some tests
937 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
938 * Now the dictionary is compiled into gdcm lib. This is a default
939 behavior, thus any dic file specified is picked before failback to
940 the one comiled into lib
942 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
943 * Change internals for gdcmDict. Don't use any 'new' any more.
944 This should definitely solve any leak problem, and we should be
945 as fast as before, as long as don't modify too much the dictionary.
947 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
948 * STYLE: ivars should start with a capital letter.
949 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
950 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
952 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
953 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
954 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
955 new 2004 dictionaries added (thanks to JPR).
956 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
957 * CLEANUP_ROUND (15) for gdcmPixelConvert
958 - RLEFrame::NumberFragments is now of type unsigned int
959 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
960 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
963 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
964 * Initial work in gathering all transfer syntax accessors. clearly
965 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
966 ivars, but only one transfersyntax (class) ivar with equivalent method on
969 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
970 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
971 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
972 discussed (plus I didn't like having a 2000 lines patch not commited)
974 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
975 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
976 * CLEANUP_ROUND (14) for gdcmPixelConvert
977 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
978 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
979 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
981 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
982 anymore and hence avoids storing a copy of PixelConvert::Decompressed
983 into File::Pixel_Data.
985 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
986 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
987 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
988 * CLEANUP_ROUND (13) for gdcmPixelConvert
989 Substituted File::ParsePixelData() with PixelConvert::Print() new
991 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
992 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
993 method to those classes.
994 - src/gdcmFile.[cxx|h]:
995 -- Added a ::Print() method.
996 -- PixelConverter is now a reference instead of a member.
997 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
998 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1000 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1001 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1002 collaboration diagram and inheritance diagram should be generated with
1004 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1005 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1006 pointlessly wrapped (see
1007 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1008 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1009 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1010 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1011 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1012 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1013 -- File::Initialise: PixelConverter setup moved away to
1014 PixelConverter::GrabInformationsFromHeader()
1015 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1016 interpretation moved away to PixelConverter::BuildRGBImage()
1018 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1019 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1020 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1022 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1023 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1024 displayed on Win32 when a brutal abort() occurs (because of uncatched
1025 exception). See TODO new entry of this commit for more on this.
1026 * TODO added new entry.
1027 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1028 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1029 - HandleColor is no longer called from gdcmFile.cxx
1030 - gdcmPixelConvert.cxx clean up on method arguments and internal
1031 variable names for semantical coherence.
1033 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1034 * Finished lossless transition, not only do we now read all lossless jpeg
1035 images, without the need of the Cornwell lib, but we do read them properly now
1036 * To reduce code (well to avoid code duplication), I defined a common place
1037 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1038 redefine symbols. This is not perfect but this the best solution I found for a
1039 compilation time jpeg option.
1041 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1042 * Update jpeg ijg lib to support lossless jpeg implementation
1043 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1045 * Also added a special copyright for dcmtk since we use their bugfixes.
1048 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1049 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1050 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1051 matters, as stated in warning note at beginning of %include section).
1052 * src/gdcmDicomDir*.[cxx|h]: coding style
1053 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1054 * src/gdcmJpeg8.cxx: doxygen fix.
1055 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1056 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1057 from File:: to PixelConvert::.
1059 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1060 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1061 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1062 - more code moved away from File:: to PixelConvert::
1063 - fat setup of PixelConverter set in place in File::Initialise.
1065 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1066 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1067 namespace at the file system level. So now you should convert your examples
1069 gdcmHeader -> gdcm::Header
1070 It would be nice if people keep in mind to no open the namespace, since it
1071 allows compilation on broken plateform which were defining common symbol in
1072 the standart namespace (like LP, Unknown ...)
1074 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1075 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1076 The JPEG fragments are now parsed at the same stage than the RLE
1077 information. All code related to JPEG is now in gdcmPixelConvert:
1078 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1079 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1080 export a gdcmFile:: method. Those are simply global functions
1081 (for the time being this is better than having them attach to
1082 either gdcmFile:: or gdcmPixelConvert::).
1083 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1084 and stores the result in a gdcmJPEGFragmentsInfo.
1085 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1086 code (among other stuff) moved away from gdcmFile:; to
1089 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1090 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1091 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1092 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1093 clean up of RLE related code.
1094 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1095 - src/gdcmRLE.cxx removed
1096 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1097 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1098 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1099 * CLEANUP_ROUND (9) for gdcmPixelConvert
1100 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1101 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1102 away from gdcmFile:: to gdcmPixelConvert::.
1104 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1105 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1106 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1107 This is because Parse7Fe0 used to parse the pixels to compute the
1108 length. This task was passed over to FindDocEntryLengthOB() a long
1109 time ago, EXCEPT I had forgotten the OW case...
1110 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1111 we just recylce the code for parsing RLE fragments and computing
1113 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1114 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1115 with the retired Parse7Fe0().
1116 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1117 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1119 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1120 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1121 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1122 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1123 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1124 * CLEANUP_ROUND (4) for gdcmPixelConvert
1125 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1126 to return an unused length.
1128 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1129 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1130 this should be cleanner from the plane view. The iostream are erally a pain
1131 to use to do simple stuff.
1133 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1134 * Redo the compilation of the ijg jpeg library. Now only one source is
1135 necesseray. No need to rename file by hand what so ever. CMake handle the
1136 copying of the file within different directory, configure header file to
1137 modify some symbol. The only addition made to ijg wasd a mangle table so
1138 that symbol are different whether we are within 8bits or 12bits.
1140 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1141 * Added documentation of vtkgdcmReader on Website:
1142 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1143 with it's binary name).
1144 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1145 the Website to be more complete.
1146 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1147 doxygenated documentation.
1148 - Doc/DoxyVtkGdcmReaderExamples.txt added
1149 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1150 DoxyVtkGdmReaderExamples.html )
1151 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1152 * CLEANUP_ROUND (3) for gdcmPixelConvert
1153 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1155 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1156 * CLEANUP_ROUND (2) for gdcmPixelConvert
1157 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1159 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1160 * CLEANUP_ROUND for gdcmPixelConvert:
1161 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1162 - src/gdcmPixelStuff[h|cxx] removed
1163 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1164 - src/CMakeLists.txt changed accordingly
1165 * GDCMHOME clean up:
1166 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1167 gdcmVersion.py moved to newly created ATTIC related
1168 gdcmPython/SetupOldies/ directory.
1169 * Autotools clean up:
1170 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1171 - autogen.sh configure.in acinclude.m4 python.m4 removed
1173 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1174 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1175 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1176 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1178 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1179 * TODO updated with Mathieu suggestions. I proposed a template for
1180 describing TODO entries and used it for new entries.
1181 * Added Doc/Website/CodingStyle.html, Developpers.html,
1182 DeveloppersPython.html, GdcmDataCvs.html and
1183 DownloadVersion0_1.html, DownloadVersion0_3.html.
1184 * Some Doc/*.txt Doxygen files (which do not really concern the
1185 documentation itself, but the website) moved to html and
1186 placed in directory Doc/Website:
1187 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1188 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1189 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1190 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1191 * CMakeLists.txt changed accordingly.
1192 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1193 DeveloppersPython.html
1194 * INSTALL nows refers to Doc/Website/Installation.html
1196 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1197 * Added Doc/Website directory, that contains a first raw version
1200 2004-09-23 Jean-Pierre Roux
1201 * FIX In order not to be poluted any longer by casting problems,
1202 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1203 we can now delete[] it safely
1204 * VoidArea is now called BinArea (less confusing name),
1205 and all the methods called ...VoidArea... are now ... BinArea...
1206 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1208 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1209 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1210 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1211 up to the destructor of gdcmElementSet to clean up TagHt and it's
1214 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1215 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1216 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1218 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1219 * ENH: added some utility method that builds a flat dictionary
1220 holding all the Dicom entries contained in the recursive structure
1221 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1222 an example of usage.
1223 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1224 BuildFlatHashTable() that build a flat dictionary.
1225 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1226 gdcmDocument is now a friend of gdcmElementSet.
1227 - src/gdcmElementSet.cxx: clean up.
1228 - Example/FlatHashTablePrint.cxx added.
1229 - Example/CmakeLists.txt changed accordingly
1231 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1232 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1233 moved away from gdcmDocEntrySet (since this class is an abstract class
1234 acting like an interface). SQDepthLevel and BaseTagKey are now
1236 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1237 and associated accessors. Doxygenation of the class.
1238 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1240 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1241 Use SQDepthLevel accessor instead. ::Print() adapted.
1242 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1243 - src/gdcmDocument.cxx changed accordingly.
1245 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1246 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1247 - The following is the doxygen comment of the typedef declaration
1248 of gdcmTagKey in src/gdcmCommon.h:
1249 gdcmTagKey is made to old an "universal" (as in URL, Universal
1250 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1251 A dicom tag always has a group and an element, but a set of tags
1252 embeded in various (optionally nested) sequences and sharing
1253 the same group and element all share the same (group, element)
1254 "identifier". Hence the (group, element) cannot be used as an
1255 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1256 In order to construct a proper tag identifier (i.e. a key) we
1257 consider the following definition of a TagKey:
1258 - let Group, Element be the string representation of the
1259 group and element dicom tag members,
1260 - let ItemNumber be the string representation of the integer
1261 index of the considered item number of a sequence,
1262 Let the key of a tag embeded in a sequence, noted SeqTag, be
1264 /ItemNumber#Group|Element
1265 where "/", "#" and "|" are characters acting as separators.
1266 Then the general form of a gdcmTagKey is given by:
1267 Group|Element<SeqTag>
1268 where <SeqTag> means NO or many instances of SeqTag.
1269 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1272 but the gdcmTagKey of a tag "embeded" is the first item of
1273 a sequence, itself nested in the third item of a sequence is the
1275 0004|1220/2#0008|0082/0#0008|0090
1276 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1277 order to hold the new sequence compatible key. Previously, the
1278 GetKey() method would look in the underlying gdcmDictEntry.
1279 - src/gdcmDocEntry.cxx:
1280 -- constructor now copies the underlying DictEntry key, in the local
1282 -- ::Print: displays the member Key, instead of the (group, element).
1283 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1284 - src/gdcmDocEntrySet.h:xi
1285 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1286 -- now has a new BaseTagKey member.
1288 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1289 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1291 This poses the problem with the semantics of the following lines
1292 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1293 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1294 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1295 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1296 to the long FIXME note for what the problem is. Nevertheless in
1297 order to get things working the dicom dictionary was altered !
1298 Please fix things urgently...
1299 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1300 information), see above note on moving the member VoidArea. Nevertheless
1301 the following entries previously correctly set as US are now inproperly
1303 0028 1201 OW IMG Red Palette Color Lookup Table Data
1304 0028 1202 OW IMG Green Palette Color Lookup Table Data
1305 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1306 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1307 of gdcmDocEntry moved to gdcmSeqEntry.
1308 * src/gdcmSeqEntry.cxx: STYLE.
1310 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1311 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1313 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1314 * gdcmPython/testSuite.py: all the test suite in python is now moved
1315 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1316 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1317 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1319 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1320 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1321 to avoid inclusion recursion until STL is reached.
1322 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1323 mecanism. errno.h is not included in gdcm anymore.
1324 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1325 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1327 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1328 gdcmData/TestAllEntryVerifyReference.txt
1329 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1330 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1331 exception_on_error parameter.
1332 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1333 - vtk/vtkGdcmReader.cxx changed accordingly,
1334 - Example/*.cxx and Test/*.cxx changed accordingly.
1336 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1337 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1338 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1339 enable_sequences removed from gdcmHeader constructor and dependencies.
1340 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1341 * gdcmPython/demo/PrintHeader.py: dummy fix.
1342 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1343 skip_shadow removed from gdcmHeader constructor and dependencies.
1344 * Example/*.cxx and Test/*.cxx changed accordingly.
1346 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1347 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1348 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1350 2004-07-21 Jean-Pierre Roux
1351 * FIX Now, Parsing and Printing a DICOMDIR do work!
1352 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1354 2004-07-20 Jean-Pierre Roux
1355 * FIX Some brain damaged headers have Zero-Lenght fields
1356 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1358 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1359 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1360 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1361 variable (instance of gdcmDebug) by a definition macro, and the instance
1362 is now in static in the gdcmDebug class
1363 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1364 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1366 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1367 * WARNING: ctest now depends more tightly on gdcmData. You should
1368 check out gdcmData properly for things to run smoothly...
1369 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1370 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1371 we need the pixels not be loaded in order to use the ValEntry
1372 that displays position and size).
1373 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1374 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1375 be deprecated. If you have any doubts about the advantages of a
1376 modern scripting language (read Python) versus grass root C++ (i.e.
1377 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1378 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1379 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1380 Anyhow, consider documenting the gdcmData images in
1381 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1383 * Test/CMakeLists.txt:
1384 - now uses TestAllEntryVerify.cxx
1385 - specific comments on oldACR00001.ima (now renamed in gdcmData
1386 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1387 gdcmData/TestAllEntryVerifyReference.txt
1390 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1391 * src/*.[h|cxx] : typedef clean up
1392 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1393 - TagKey renamed to gdcmTagKey (for external usage)
1394 - VRKey renamed to gdcmVRKey (for external usage)
1395 - removal of typedef duplication.
1396 - Removed all unecessary inline keyword from class inline definitions.
1397 - Some method|function(void) declarations replaced with method|function().
1398 * src/jpeg/libijg12/jdhuff12.c:
1399 - printf polluting ctest removed.
1400 - TAB removal for comminting
1402 - TestAllReadCompareDicom.cxx: added a test that compares all the
1403 images in gdcmDataImages.h with corresponding images in
1404 gdcmData/BaselineDicom/. When baseline images are not present
1405 this test creates them.
1406 Note: we need to validate each reference image, but before that
1407 I'd like to rename them with a more explicit name...
1408 - CMakeLists.txt: changed accordingly.
1409 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1410 including each header needed).
1412 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1413 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1414 test suite to the Example directory. Are concerned:
1419 - TestWriteSimple.cxx
1420 * Test/CMakeLists.txt: added some comments on reasons for black listing
1421 image gdcmData/oldACR00001.ima
1423 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1424 * Test/CmakeList.txt: removed the following from black list (to be coherent
1425 with removal from gdcmData):
1426 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1427 - gdcm-MR-PHILIPS-16.dcm
1429 Added the following because after last cvs update, they cause
1430 ctest -R TestReadWriteReadCompare
1432 - gdcm-MR-SIEMENS-16-1.acr
1434 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1435 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1436 new comments in this file) we temporarily (sigh) move to a weaker
1438 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1439 we don't need to black list the following images anymore:
1440 - 8BitsUncompressedColor.dcm
1442 - US-PAL-8-10x-echo.dcm
1443 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1444 fixes and the beautified code ;-)
1445 This fixes the bug introduced in version 1.42 (when beautifying)
1446 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1447 Note: ctest was blind to this bug (this means we need to still
1448 improve the test suite). The bug could be detected by using
1449 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1451 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1452 and by displaying the (garbage) produced file temp.XDCM...
1454 2004-06-29 Jean-Pierre Roux
1455 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1456 - replace by uggly but working old code :-(
1457 A lot of things should be OK again.
1458 It's really urgent to have a test suite that *tests*,
1459 to prevent Frog's beautifying sessions to break all the stuff
1460 (twice, withing a fortnigh ...)
1462 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1463 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1464 redundancy) to added Test/TestReadWriteReadCompare.cxx
1465 * Test/CmakeList.txt: because the compare test of
1466 Test/TestReadWriteReadCompare.cxx fails, the following images are
1467 black listed: - 8BitsUncompressedColor.dcm
1469 - US-PAL-8-10x-echo.dcm
1470 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1471 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1472 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1473 and ad-hoc kludge. This kludge is now removed, and on encountering
1474 such an image (OB field brain damaged) we set errno. Then in
1475 ::FindDocLength() we "fix" the length as being ALL what remains
1476 in the file (until EOF). We then proceed, hoping for the best...
1477 This fixes a SegFault in ShowDicom when trying to write such an
1479 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1480 (because TestWriteRead breaks on it, after a non conformal commit?).
1481 ctest now runs properly, except for MakeDicomDir (which was always
1482 broken) and the Python related stuff (still not fixed).
1484 2004-06-24 Jean-Pierre Roux
1485 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1486 FIX : Test/TestReadWrite now iterates on all the file names
1487 (instead of infinite loop)
1488 ENH : Test/TestWriteRead now iterates on all the file names
1490 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1491 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1493 2004-06-24 Jean-Pierre Roux
1494 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1495 when SamplesPerPixel =3
1496 - now Write is no longer confused by
1497 'BitsAllocated = 12" and 'BitsStored=12"
1498 - "UN" value representation Elements are now written correctly
1499 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1500 ENH : - now gdcmHeader has its own Write methods
1501 (in order to split the job that has not to be done
1504 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1505 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1506 loop on the same image until memory went out.
1507 Note: this means we still have gobs of memory loss in PrintDocument
1508 * src/gdcmDocument.cxx: fixes problem on parsing on file
1509 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1511 2004-06-24 Jean-Pierre Roux
1512 FIX : Write - All the Sequences and Sequence Item are now written
1513 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1514 is added a the end, when necessary.
1515 - A lot of brain-damaged images, that were read correctly are
1516 now written correctly
1517 - length compatible BinEntry are now loaded correctly
1518 (even for odd groups)
1519 Note : only Explicit Value Representation was checked.
1520 (question : is implicit VR really necessary for gdcm ?)
1522 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1523 * DEVELOPPER: added a proposition of coding style.
1524 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1527 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1528 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1529 Use the gdcmDocEntry::Print() and Write() instead.
1530 * src/gdcmDocument.cxx: bug fix.
1532 2004-06-22 Jean-Pierre Roux
1533 FIX : gdcmDocument.cxx
1534 - Now we do recognize the JpegLossLess format (there was a misstyping in
1535 code 'beautyfication' :-(
1536 - Now we automaticaticaly load the Luts, if any
1538 2004-06-22 Jean-Pierre Roux
1539 In order : to write Sequences, whatever their imbrication level,
1540 : to allow user to create his own Sequences
1541 a lot of modif where necessary (adding, moving, or virtualising methods)
1543 WARNING : save your own sources *before* cvs up !
1546 ADD virtual void Write(FILE *fp, FileType filetype);
1549 ADD virtual void Write(FILE *fp, FileType filetype);
1550 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1553 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1554 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1555 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1556 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1557 ADD std::string GetEntryByName(TagName name);
1558 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1560 std::string vr = "unkn",
1561 std::string fourth = "unkn",
1562 std::string name = "unkn");
1563 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1564 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1565 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1566 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1567 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1568 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1569 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1570 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1573 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1574 ADD virtual std::string GetEntryByName (TagName tagName);
1575 ADD virtual std::string GetEntryVRByName (TagName tagName);
1576 REM virtual bool Write(FILE *, FileType);
1577 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1578 FILE *_fp, FileType type);
1579 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1580 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1581 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1582 REM virtual std::string GetEntryByName (std::string tagName);
1583 REM virtual std::string GetEntryVRByName (std::string tagName);
1584 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1585 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1586 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1588 std::string vr = "unkn",
1589 std::string fourth = "unkn",
1590 std::string name = "unkn");
1591 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1592 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1593 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1594 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1597 ADD virtual void Write(FILE *fp, FileType filetype);
1600 ADD virtual void Write(FILE *fp,FileType filetype);
1603 ADD virtual void Write(FILE *fp, FileType filetype);
1604 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1605 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1606 REM std::string GetEntryByName(TagName name);
1609 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1611 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1612 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1613 The default constructor invoked by the line
1614 gdcmHeader *f1 = new gdcmHeader( header );
1615 was gdcmHeader::gdcmHeader(bool) instead of the expected
1616 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1617 Hence the parsing wasn't executed... See also below.
1618 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1619 as explicit constructor didn't do the trick to fix the above problem.
1620 Could anyone explain why ?
1621 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1622 properly calls gdcmValEntry::Print() (that was weed out from
1623 code related to gdcmBinEntry).
1625 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1626 * In order to fix memory leaks:
1627 - Test/TestWriteSimple.cxx: added cleaning of free store through
1629 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1630 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1631 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1632 (through the call to ::AddDicomDirMeta()) or the destructor
1633 would crash when deleting uninitialized ::metaElems].
1634 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1635 - src/gdcmDocument.cxx:
1636 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1637 from dynamic stores.
1638 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1639 was causing memory leaks.
1640 - src/gdcmSQItem.cxx:
1641 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1642 cleanly handled with polymophism: sorry but my milage is low).
1643 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1644 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1645 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1646 This avoids SegFaulting.
1647 - src/gdcmSQItem.h: coding style.
1649 - Test/TestWriteSimple still severely sucks. The output image content
1650 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1651 damaged when displayed with vtkgdcmViewer.
1652 - on memory leaks: TestWriteSimple leaks really less (see entry
1653 of 2004-06-18 in Changelog file for the call to valgrind).
1654 - on segfaults: ctest now passes all the tests but one (no more
1656 * Erroneous leading white fix:
1657 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1658 white[s] (as opposed to from >> xxx, that removes it [them].
1659 - src/gdcmTS.cxx: ditto.
1660 - gdcmPython/testSuite.py: dirty related kludge removed.
1661 * src/*: remaining references to gdcmParser removed.
1662 * src/*[cxx|h]: added copy[way]left header.
1665 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1666 * In order to fix writing of dicom files:
1667 - Test/TestWriteSimple.cxx: a simpler example of writing.
1668 - Test/CMakeLists.txt changed accordingly.
1669 - src/gdcmDocument.cxx:
1670 -- The destructor now recursilvely removes potential sequences.
1671 -- Bug fix in ::IsJPEG2000()
1672 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1673 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1675 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1676 to only declared) and build on top of
1677 ::GetDocEntryByNumber(guint16, guint16).
1678 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1679 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1680 for usage in destructor and treatement of promotion in
1681 ::ReplaceOrCreateByNumber().
1682 - src/gdcmSQItem.cxx: destructor should better handle his job.
1683 Test/TestWriteSimple now runs (or at least it DOES something).
1684 * We can now start hutting memory links. A good starting point is:
1685 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1686 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1687 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1689 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1690 * Valgrind note: after Mathieu Malaterre teached me how to read
1691 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1693 Using gcc, you can force the STL to use malloc and to free memory as
1694 soon as possible by globally disabling memory caching.
1695 With 3.2.2 and later, you should export the environment variable
1696 GLIBCPP_FORCE_NEW before running your program.
1697 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1698 simply vanish (it is still not clear to me, whether this means that
1699 STL std::string leaks or if valgrind believes it leaks...).
1700 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1701 running bin/gdcmTests makeDicomDir):
1702 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1703 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1705 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1706 SegFaulting (I drowned in DicomDir related code when trying to
1707 understand why the list is empty...).
1708 * src/gdcmDocument.h: first BSD license header try.
1709 * Doc/License.txt added.
1711 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1712 * src/gdcmDocument.[h|cxx]:
1713 - Clean up of the Transfer related predicates. They are now all based
1714 on new method isGivenTransferSyntax, that (should) handle properly
1715 the padding problem.
1716 - general clean up, simplification, and coding style.
1717 - Specific clean up of Parse7FE0() (umproperly named actually).
1718 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1720 2004-06-14 Jean-Pierre Roux
1722 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1723 - fix the display of SQItem ordinal number
1724 - add the GetSQItemByOrdinalNumber method
1725 - remove some useless never written private methods
1727 2004-06-14 Jean-Pierre Roux
1729 - adding a constructor taking a gdcmDocEntry as an input param
1730 - ReplaceOrCreateByNumber now returns :
1731 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1732 a gdcmValEntry * if a string value is passed as a param
1734 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1735 according to the param type (no longer sets a gdcmDocEntry)
1736 - GetValEntryByNumber, GetBinEntryByNumber added
1737 - NewValEntryByNumber and NewBinEntryByNumber added
1739 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1741 - GetSQItemNumber and SetSQItemNumber added, to provide
1742 a (relative) Item identier inside a given Sequence
1743 \warning : some pb remaining around this number
1745 - AddEntry now takes the Item Number as a param
1747 - adding a constructor taking a gdcmDocEntry as an input param
1749 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1750 * Memory leak hunt with the following command:
1751 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1752 --show-reachable=yes gdcmTests PrintDocument
1753 It looks like many (all?) leaks are due to the STL (or a bad usage
1754 of the STL. The lines producing the leaks now have a comment with
1755 a "MEMORY LEAK" tag: you can retrieve them with
1756 grep "MEMORY LEAK" src/*
1757 Here are two typical examples which I can't help fixing:
1762 char * test = "babo";
1763 name = test; //// <--- valgrind detects 960 bytes lost in
1764 //// call to std::string::operator=(char const*)
1765 name.clear(); //// Doesn't help !
1773 std::cout << "Type a bunch of characters followed by RETURN: ";
1774 getline(std::cin, line); //// <--- valgrind dectects a loss
1775 //// of 1320 bytes in call to
1776 /// std::basic_istream<>& std::getline<>
1782 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1783 * src/gdcmHeader.[cxx|h]:
1784 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1785 and related, moved away to gdcmDocument.
1786 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1787 the corresponding protected accessors of inherited class
1788 gdcmDocument, removed ! As a consequence gdcmFile had to be
1789 declared friend of class gdcmDocument (see below).
1790 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1791 - Clean up of undefined or unused methods.
1792 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1793 account the changes to gdcmHeader.h).
1794 * src/gdcmDocument.h:
1795 - gdcmFile is now a friend class (in order to take into account the
1796 changes to gdcmHeader.h).
1797 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1798 (see changes to gdcmHeader.h).
1799 - Accessors (reading on the form GetEntry*) are now public.
1800 - Clean up of undefined or unused methods.
1801 * src/gdcmDocument.cxx:
1802 - adaptation to changes to gdcmDocument.h
1803 - ::OpenFile now writes a verbose message when file cannot be opened.
1804 - some std::string properly set to VRKey
1805 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1806 references to gdcmDocument.
1807 * Test/TestFindTags.cxx: changed accordingly to above changes.
1808 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1809 cvs repository gdcmData.
1811 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1812 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1813 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1814 conflicts with gdcmValEntry::voidArea.
1815 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1816 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1817 Value representation between StringRepresentable and BinaryRepresentable.
1818 * src/gdcmDocument.cxx:
1819 - method ParseDES: proper indentation restored and usage of
1820 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1821 - method LoadDocEntry: the fingerprint left in the SetValue() of
1822 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1823 removed. Reverting to previous code segment with the proper
1824 dynamic_cast< gdcmValEntry* >.
1825 Note: this was (partially) breaking the python test suite
1826 (gdcmPython/testSuite.py) that made usage of the above
1827 fingerprint to check presence of "Pixel Data".
1828 * src/gdcmDocEntry.h: coding style.
1829 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1830 now taken into account.
1831 * gdcmPython/gdcm.i: adaptation to the new internal representation
1832 of gdcm (exit gdcmParser, hello gdcmDocument).
1833 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1835 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1836 anymore, but instead prints the loaded Python dictionary.
1837 * .... alas, the python testSuite is still broken.
1839 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1840 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1842 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1843 * src/gdcmUtil.h : export methods
1845 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1846 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1848 * Initial addition of automatic python testing
1849 * Initial addition of automatic image comparison
1851 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1852 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1853 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1855 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1856 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1857 * Test/ShowDicom.cxx : bug fix for msvc compilation
1858 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1860 2004-05-04 Jean-Pierre Roux
1861 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1862 new concepts (and new classes) :
1863 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1864 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1865 - Sequence Doc Entries (gdcmSeqEntries)
1866 a Sequence is composed of Items.
1867 Each item is a set of Doc Entries (this is recursive)
1868 The non uniqueness of the 'Dicom tag' is due to this recursivity
1869 (never taken into account)
1870 Our unability to add a new 'entry' in the header
1871 at the proper location (neither in the H-Table (map or multimap),
1872 nor in the Chained List is also due to this recursivity.
1873 Don't try, right now, to use/modify/compile these new sources :
1874 nothing is finished.
1875 We just commit all the stuff, 'as is', in order not to loose it.
1877 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1878 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1880 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1881 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1882 file prefix (SetFilePrefix)
1884 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1885 * Add a new test: ShowDicom, for now this is just the c++ version of
1886 checkRead.sh, later it will be able to compare the image read against a
1888 * Replace the DEBUG on the stack with a global entry in cmake interface:
1889 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1891 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1892 * Add an example subdir, with a real example on how to read + write a
1895 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1896 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1897 * Doc/CMakeLists.txt: the main page is now properly differentiated
1898 between the developper and user version.
1899 * Doc/doxygen.config.in: dropped search related obsolete flags
1900 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1902 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1903 * DEVELOPPER: added some helpfull comments for compile/test/install
1906 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1907 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1908 src directory, now generated in the build dir.
1909 2. Tests as mentionned smarter
1911 4. Add a new method in gdcmDict that return the PubDict by name
1912 this is interesting for 3rd party lib like ITK,
1913 where we could set the institution name / patient name...
1915 * ENH: 1. Now the test suite is working for real
1916 2. All binaries are now output in the gdcm-bin directory
1917 (this was not true before)
1919 2004-04-28 Jean-Pierre Roux
1920 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1921 SeQuence indented printing of Dicom Header.
1922 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1923 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1924 Computation of SQDepthLevel is now part of gdcmHeader constructor
1925 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1926 tree-like structure of a Dicom Header.
1927 * FIX Test code cleaning
1929 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1930 * ENH: Adding automatic testing
1931 1. Need a DartConfig.cmake to submit to public
1932 2. Add a test driver gdcmTest.cxx
1933 3. gdcmTestMain, an helper for the main test driver gdcmTest
1934 4. Files in Test don't have a main anymore, this becomes interesting
1935 when we add more and more tests, thus dsw don't have to load
1937 * ENH: Adding a GDCM_DATA_ROOT for testing
1938 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1939 one file instead of seven + some small cleanup
1941 2004-04-22 Jean-Pierre Roux
1942 * ENH Minor changes to the Print() methods.
1943 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1944 Header printing. Example given with :
1945 > PrintHeader fileName 2 new
1946 (SQ based tree-like structure still to be done for the Header ...)
1948 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1949 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1950 1. I have added some unsigned where needed
1951 2. Some function parameter not used -> (void)
1952 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1953 4. g++ don't like character '\' in comment
1954 5. #define jpeg_create_decompress jCreaDecompress
1955 this really need to be fixed
1956 6. virtualize destructor of gdcmObject ... leakage
1957 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1958 this also really need to be fixed
1959 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1960 remove compression file
1961 (as we only do decompression, right ?)
1962 * ENH: Change malloc/calloc/free with c++ equivalent
1964 2004-04-21 Jean-Pierre Roux
1965 * FIX gdcmHeaderHelper::GetXSpacing
1966 when a single value is found (bug ?), xpacing is now
1967 defaulted to yspacing
1969 2004-04-19 Jean-Pierre Roux
1970 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1971 * ENH add parameters :
1972 bool exception_on_error = false,
1973 bool enable_sequences = false,
1974 bool ignore_shadow = false
1975 to the gdcmFile constructors to be full gdcmParser compliant
1976 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1977 to allow reading of PAPYRUS 3.0 files
1979 2004-04-06 Jean-Pierre Roux
1980 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1982 2004-04-02 Jean-Pierre Roux
1983 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1984 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1985 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1987 2004-03-30 Jean-Pierre Roux
1988 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1989 for ACR file, written out as DICOM files (hope so...)
1991 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1992 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1993 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1994 moved to base class gdcmParser and only the specialisation is kept
1996 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1997 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1998 already does the job.
1999 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2000 (to be consistent with gdcmParser::WriteEntries).
2002 2004-03-30 Benoit Regrain
2003 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2004 upate of the object's instance. It's passed to 2 in the unfavorable
2005 case : one in the ExecuteInformation, one in the ExecuteData
2007 2004-03-29 Jean-Pierre Roux
2008 * ENH : Check on file type to be written moved
2009 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2010 * FIX : gdcmObject::ResetBoundaries now stops properly
2011 when end-of-list is reached
2012 : gdcmVersion modified (as Benoit Regrain asked)
2014 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2015 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2016 * src/gdcmUtil.cxx: added forgotten iostream include.
2017 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2018 equivalent to ExplicitVR in existing code).
2020 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2021 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2022 now contains all the gdcmGlobal related code.
2023 * minor coding style and doxygenation changes.
2025 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2026 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2027 now contains all the Debug related code.
2028 * minor clean-up of includes in src/*.cxx
2029 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2030 CreateCleanString) removed.
2031 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2032 * Doc/DoxyMainPageUser.txt added.
2033 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2034 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2035 src/gdcmDirList.cxx)
2037 2004-03-24 Jean-Pierre Roux
2038 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2040 2004-03-23 Jean-Pierre Roux
2041 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2042 big endian made volumes
2043 * ENH Now gdcmParser constructor and destructor are protected to forbid
2044 end user to instanciate class gdcmParser
2045 (only gdcmHeader and gdcmDicomDir are meaningfull)
2047 2004-03-22 Benoit Regrain
2048 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2049 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2050 gdcmSerie to gdcmDicomDirSerie
2052 2004-03-19 Jean-Pierre Roux
2053 * ENH Now the tree-like structure describing a DICOMDIR comming from
2054 an already existing DICOMDIR file is consistent with
2055 the home-made tree-like structure build ex-nihilo
2056 or build from the files held (recursively) in a Directory
2057 functions gdcmDicomDir::CheckBoundaries()
2058 gdcmObject::SetBoundaries() added
2060 2004-03-17 Jean-Pierre Roux
2061 * REM (Eric Boix bug) : removal of meaningless
2062 gdcmDicomDirImage::NewImage function.
2063 * FIX now file names and directory name are written properly in the
2065 * FIX now gdcmDicomDir constructor may be call without any trick
2068 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2069 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2070 of gdcmDicomDirImage::NewImage as empty function.
2072 2004-02-28 Jean-Pierre Roux
2073 * ENH add gdcmDicomDir:NewPatient
2074 add gdcmDicomDirPatient:NewStudy
2075 add gdcmDicomDirStudy:NewSerie
2076 add gdcmDicomDirSerie:NewImage
2077 to allow making gdcDicomDir object.
2078 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2079 (as opposite to the gdcmHeader chained list)
2081 2004-02-11 Benoit Regrain
2082 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2083 when using from python
2085 2004-02-10 Benoit Regrain
2086 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2087 * FIX : in gdcmDicomDir when the directory is empty
2088 * ENH : add callback and methods to get the progression of dicomDir
2091 2004-02-06 Jean-Pierre Roux
2092 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2093 - GDCM_META added to gdcmDicomDirType
2094 - class gdcmMeta created
2095 * ENH : - A brief summary is now displayed at the beginning of
2096 'testDicomDir' to help disaster magnitude estimation
2097 * REM : Now useless Test/explDICOMDIR.cxx
2099 2004-02-05 Benoit Regrain
2100 * ENH : add methods in gdcmObject to get the hash table or the list of
2102 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2103 * FIX : wrapping python for TagHeaderEntryHT
2105 2004-02-04 Benoit Regrain
2106 * FIX : even length for some strings when writting the dicom dir
2107 * FIX : sort the images in the dicom dir
2108 * FIX : Bug fix for python use of dicom dir
2109 * ADD : a python demo
2111 2004-02-04 Jean-Pierre Roux
2112 * FIX : Final solution (?) for icone embedded images
2113 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2114 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2115 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2116 gdcmData/gdcm-MR-SIEMENS-16.acr1
2117 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2118 to make full checking easier
2120 2004-02-04 Benoit Regrain
2121 * FIX : WriteEntries : coding style & logic in parameters
2122 * FIX : Set the elements to create the DicomDir in a dictionary file
2124 2004-02-03 Benoit Regrain
2125 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2126 * gdcmDicomDir : add the load of directory
2127 * Bug fix and print add-on
2129 2004-02-03 Jean-Pierre Roux
2130 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2131 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2132 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2133 * FIX gdcmParser.cxx : 'group length' elements are now considered
2134 as integers, even for shadow groups, when file is Implicit VR
2136 2004-02-02 Jean-Pierre Roux
2137 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2139 of the last synonym :-(
2140 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2142 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2143 * FIX taking into account the possible 7fe0,0010 multiplicity
2144 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2145 to allow removal of references to 7fe0,0010, to deal with
2146 ACR-NEMA images, when 0028,0200 is meaningfull
2148 2004-01-31 Jean-Pierre Roux
2149 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2150 no longer writes 'Un' on disk
2151 * FIX SQ elements with actual length are now dealt with corectly
2152 * FIX gdcmFile::WriteBase make the difference, for color images, between
2153 the length (for Palette expanded images)
2154 and Raw Length (non expanded image + Palette)
2155 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2156 (that broke Write). Replaced by UL.
2157 Aware user will reload the field if he
2158 thinks it's necesssary
2160 2004-01-30 Jean-Pierre Roux
2161 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2162 when 'dirty Acr' is found, to be compliant with the new
2163 IsReadable() methods.
2165 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2166 (no DOUBLE images in kosher DICOM,
2167 but so usefull for people that miss them ;-)
2169 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2170 DICOMDIR related utilities (not checked as Windoze compliant)
2172 2004-01-28 Jean-Pierre Roux
2173 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2175 2004-01-27 Jean-Pierre Roux
2176 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2177 to allow skipping the shadow elements, to save memory space.
2178 The TRUE value for this param has to be used
2179 with a FALSE value for the 'enable_sequence' param.
2180 ('public elements' may be embedded in 'shadow Sequences')
2181 * gdcmHeader methods now deal with 'embedded icones images' in the header
2182 (even when an 'icone image sequence' is announced by the
2183 element (0x0088,0x0200), but there is NO icone at all ...
2185 * gdcmHeader sometimes Image Location value doesn't follow
2186 the supposed processor endianity (see gdcmData/cr172241.dcm).
2189 * gdcmHeader add the method
2190 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2191 to get *all* the Header Entries with the same tag.
2192 GetHeaderEntrySameName is probabely *useless*
2193 (no meaning : Name is *not* an identifier within the Dictionary)
2195 2004-01-26 Benoit Regrain
2196 * Bug fix in the print of hexadecimal representations. Remove long fields
2197 in the print and add a third level of print to print them
2199 2004-01-23 Benoit Regrain
2200 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2201 * Bug fix on test suite after remove the strip made on not string fields
2202 * Split the IsReadable method between gdcmParser which test that the file
2203 is dicom and gdcmHeader which test that it's an image file
2205 2004-01-22 Benoit Regrain
2206 * DicomDir : clean code, add methods, set variables in protected or private
2207 * gdcmUtil : bug fix for the clean string method
2209 2004-01-19 Benoit Regrain
2210 * Add the use of shadow dictionaries
2211 * bug fix and coding style
2213 2004-01-19 Benoit Regrain
2214 * src/gdcmFile.cxx : bug fix concerning the close of file
2215 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2216 * Add the update of header entries using the shadow library
2218 2004-01-19 Benoit Regrain
2219 * removal of file gdcmHeader2.cxx
2220 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2221 inheriting from gdcmParser. This split is to prepare the integration
2222 of dicom dir parsing
2223 * bug fix under python
2225 2004-01-16 Jean-Pierre Roux
2226 * REM removal of class gdcmHeaderEntrySet
2227 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2228 * ADD add file gdcmHeader2.cxx
2229 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2231 2004-01-15 Benoit Regrain
2232 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2233 entries created while parsing the header. Thus, they will be destroyed
2234 when the gdcmDictSet will be destroyed
2235 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2238 2004-01-15 Benoit Regrain
2239 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2240 made a fatal error because of the memory release at the end of program.
2241 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2242 some memory and vtk seems to have some problems with that.
2243 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2245 2004-01-14 Benoit Regrain
2246 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2247 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2248 * src/*.[h|cxx] : make changes due to class name changes
2249 * gdcmPython/demo/*.py : bug fix due to method names
2251 2004-01-13 Benoit Regrain
2252 * src/*.[h|cxx] : coding style
2253 * vtk/*.[h|cxx] : coding style
2255 2004-01-13 Benoit Regrain
2256 * gdcmPython/testSuite.py : test the readable flag of file for tests
2257 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2258 It's lied to the stl compilation by MSVC (windows, always windows...)
2259 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2261 2004-01-12 Benoit Regrain
2262 * src/*.h : add comments
2263 * src/gdcmDictSet.h : set the method BuildDictPath in public
2264 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2265 directly setted in the source code
2266 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2269 2004-01-09 Benoit Regrain
2270 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2271 * setup.py : use a reference to gdcmVERSION
2273 2004-01-07 Benoit Regrain
2274 * Modification to compile with the distutils.
2277 2003-12-10 Benoit Regrain
2278 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2279 can use a gdcmHeaderHelper to load data
2280 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2281 made in the source code
2283 2003-12-10 Benoit Regrain
2284 * Update Windows projects and .cvsignore files
2286 2003-11-12 Jean-Pierre Roux
2287 * ENH gdcmHeader constructor has one more parameter (default value : false)
2288 that allows the user to 'go inside' the SeQuences only
2290 gdcmElValSet:Print takes it into account
2292 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2293 * ENH: Update gdcmPython/CMakeLists
2294 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2295 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2297 2003-11-10 Jean-Pierre Roux
2298 * FIX : gdcmHeader::LoadElements is now based
2299 on the ListTag listElem member,
2300 not longer on the TagElValueHT tagHt member
2301 * ENH : PrintPubElVal shows (temporarily) both results,
2302 with the tagHt member and the listElem member.
2303 (it's easier to 'see' the problems when using Printheader)
2305 * FIX : old private member LgrElem is now splitted into
2306 ReadLength : Length actually found on disk (updated only
2307 if bug fixing is necessary), for internal
2309 UsableLength : Updated by FixFoundLength, to fix a bug
2310 or to allow Parser going on.
2311 Will allow to re-write a kosher header when a SeQuence
2312 with a length (not 0000) is found
2313 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2314 because gdcmElValSet::Add does not update ListElem
2317 2003-11-07 Jean-Pierre Roux
2318 * FIX misstyping in Transfert Syntax name table
2319 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2320 when they have an actual length (not 0000 nor FFFFF)
2321 (Nobody should care of it, but DICOMDIR explorers)
2323 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2324 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2326 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2327 * ENH: vtkGdcmReader now supports LUT !
2328 (vtkgdcmViewer for now is not able to use them though)
2330 2003-11-05 Jean-Pierre Roux
2331 * in testSuite.py : new files names for checking the package
2332 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2333 that returns the pixel area size to the *aware* (vtk) user
2334 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2336 2003-11-05 Benoit Regrain
2337 * in testSuite.py : Modify the rules for checking the paths
2338 : Explicit error messages
2339 * in __init__.py : Related modif
2341 2003-11-03 Jean-Pierre Roux
2342 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2343 to be used by aware (vtk) users that want to manage
2344 LUT (and no to turn the PALETTE image into an RGB pixels one)
2345 * GetPixelType now returns 8U for 24 Bits images
2346 (vtkGdcmReader compliant)
2348 2003-10-31 Jean-Pierre Roux
2349 * Removal of *all* gdcmData images and add them again
2350 in order to loose the 'history' of un-anonymised images
2352 2003-10-31 Jean-Pierre Roux
2353 * RMV : removal of useless jBitsInJsample.h
2354 for both 8 and 12 Bits JPEG Lossy Libraries
2356 2003-10-31 Jean-Pierre Roux
2357 * ENH : Add the functions gdcmFile::GetImageDataRaw
2358 gdcmFile::GetImageDataIntoVectorRaw
2359 that act as GetImageData and GetImageDataIntoVector
2360 except the making of an RGB Plane from Gray Plane + LUT
2361 Intended to aware (vtk) users who know how to manage
2364 GetLUTRGBA return a R,G,B,A LUT if any
2365 lgrTotaleRaw gives the 'Raw' length
2366 GetImageDataRaw returns the gray Plane
2367 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2368 (They stay Grey, just like with other Dicom viewers :-(
2370 2003-10-30 Jean-Pierre Roux
2371 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2373 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2374 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2375 being coherents dicom files.
2377 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2378 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2380 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2381 * ENH: Two steps is necessary to please VC++ compiler...
2382 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2383 * ENH: Add include dir to medcon lib
2384 * FIX: only one function is being exported for now !
2385 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2387 2003-10-29 Jean-Pierre Roux
2388 * adding gdcmHeader::GetLUTRGBA
2389 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2390 --> Mathieu, the modif u're waiting for is not yet committed
2391 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2393 2003-10-27 Jean-Pierre Roux
2394 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2395 00191113.dcm DermaColorLossLess.dcm
2396 MxTwinLossLess.dcm RadBWLossLess.dcm
2397 * ENH: For version prior to vtkImageViewer2 -r 1.19
2398 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2400 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2401 * Removal of ido stuff in CMakeLists.txt
2403 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2404 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2405 * FIX: remove a call to ->Modified ... see comments
2406 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2408 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2409 * FIX: Problem with path for libvtkgdcmPython
2410 * ENH: Try adding a search script for python site-package
2411 * RMV: Remove some file from medcon lib that are not necessary
2412 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2413 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2414 * FIX: More pragma disable fro VC++,
2415 I don't think I break something as it is also disable in VTK/ITK.
2416 But it fasten debug compilation time.
2418 2003-10-23 Jean-Pierre Roux
2419 * gdcm now deals with 16 Bits Run Length Encoded images
2420 (they are compressed as 2 planes images,
2421 one for the high Bytes, the other for low Bytes)
2423 2003-10-22 Jean-Pierre Roux
2424 * Now CheckRead takes into account :
2425 - the bugged 'Leonardo' Siemens images
2426 - the XA images, sent thru the burning VPRO station
2427 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2430 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2431 * FIX: When copying a Makefile.am to CMakeLists.txt
2432 one should remove the '\'
2434 2003-10-22 Jean-Pierre Roux
2435 * in gdcmData adding a bugged 'Leonardo' Siemens image
2436 (wrong lengths in header)
2437 OK with gdcm, KO with the other viewers :-)
2438 * add a GE dlx XA image, thru the VEPRO burning station
2441 2003-10-21 Jean-Pierre Roux
2442 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2443 for a brutal checking of vtkgdcmViewer compliance
2445 2003-10-21 Jean-Pierre Roux
2446 * add the files for 'xmedcon' Jpeg Lossless library
2447 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2449 2003-10-21 Jean-Pierre Roux
2450 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2452 2003-10-21 Jean-Pierre Roux
2453 * garbage Siemens 'Leonardo' images dealt with
2454 (the patch is easy to remove)
2455 * cosmetic changes to avoid warnings
2457 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2458 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2459 no need to press 'r' now.
2461 2003-10-20 Jean-Pierre Roux
2462 * upgrade of checkRead.sh checkWrite.sh according
2463 to new Jpeg Lossless decompressor
2464 * add US.3405.1.dcm, a genuine RGB medical file ...
2465 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2466 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2468 2003-10-15 Jean-Pierre Roux
2469 * general anonymisation in gdcmData
2470 * adding the 'color files' from
2471 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2472 * adding some well knowed bugged-header images
2473 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2474 waiting for their inclusion in Python testsuite
2476 2003-10-15 Jean-Pierre Roux
2477 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2478 no longer seg faults when file is not found
2480 2003-10-14 Jean-Pierre Roux
2481 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2484 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2485 * TODO: *.in file to genereate a UseGDCM later
2487 2003-10-14 Jean-Pierre Roux
2488 * Some supposed-to-be Dicom Images have no preamble.
2489 OpenFile takes it into account
2490 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2491 * Missing elements added in dicomV3.dic
2492 (just to be affraid : have a look at
2493 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2494 and do it again next year ;->
2496 2003-10-13 Jean-Pierre Roux
2497 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2498 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2499 But there are NOT. It's fixed !
2501 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2502 * FIX: "jpeglib.h" was not found on VC++
2503 * FIX: vtkgdcm was not being installed
2505 2003-10-10 Jean-Pierre Roux
2506 * ENH : OpenFile closes the file if it *really* doesn't look like
2507 an ACR-NEMA / DICOM one.
2508 * FIX : testWrite no longer writes an empty file if the source file
2509 is not gdcm Readable
2510 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2513 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2514 * FIX: CMake generate now documentation
2515 * ENH: out of source doc build !
2516 * ENH: Generate both user and dev documentation
2517 * ENH: Should work on windows too
2518 * ENH: Only one doxygen config.in file is needed
2519 * FIX: make install should be ok now on ùnix plateform
2520 * FIX: PATH to dictionary was wrong (missing /)
2521 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2523 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2524 * vtkGdcmReader is now able to read rgb dicom file.
2525 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2526 * added a gdcmViewer to vtk test, use mouse to control
2527 window level & window width
2529 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2530 * CMake-ification of gdcm, we have now two build system
2531 * FIX: on cygwin Wsock32 doesn't exist
2532 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2534 2003-10-06 Emanuel Ollart
2535 * FIX : compilation process wad broken.
2536 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2538 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2539 * change gdcmViewer -> vtkgdcmViewer
2540 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2542 2003-10-06 Jean-Pierre Roux
2543 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2544 ( e.g : well known GE images with a wrong elem length,
2545 : Philips MRI Images with a wrong Huffman table)
2546 * still to be done : allow the reading of bugged LEONARDO Siemens images
2548 2003-10-03 Jean-Pierre Roux
2549 * Odd length strings are padded with '\0' (not with spaces,
2550 to remain compliant with already defined strings,
2551 like Transfert Syntax UID and others)
2553 2003-10-03 Jean-Pierre Roux
2554 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2555 to allow displaying RGB images (not only by affim ;-)
2557 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2558 * vtkGdcmReader is now able to read rgb dicom file.
2559 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2561 2003-10-03 Jean-Pierre Roux
2562 * A few nasty patches to allow the reading of a lot of nasty images
2563 ( e.g : well known GE images with a wrong elem length,
2564 : Philips MRI Images with a wrong Huffman table)
2565 * still to be done : allow the reading of bugged LEONARDO Siemens images
2567 2003-10-03 Jean-Pierre Roux
2568 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2570 2003-10-03 Jean-Pierre Roux
2571 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2572 to allow displaying RGB images (not only by affim ;-)
2574 2003-10-03 Jean-Pierre Roux
2575 * gdcmFile::GetImageDataIntoVector now
2576 - deals with MultiFrames MultiFragments Run Length Encoded files
2577 - deals with YcBcR (YBR_FULL) files
2578 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2579 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2581 (no sample found :-(
2583 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2584 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2585 Two reasons: - clear things
2586 - third parties acces gdcm through header files, so won't
2587 suffer anymore VC++ complains
2589 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2590 * add argv[1] in testvtkGdcmReader.cxx
2593 2003-09-24 Jean-Pierre Roux
2594 * The lines are now eigthy characters long.for
2595 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2597 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2598 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2599 char* to std::string. Thus, the use of strdup becomes useless. (see
2600 previous commis of Malaterre)
2601 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2602 before the last Malaterre's commit.
2604 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2605 * This commit should fix the Debug building under VC++, the problem
2606 was mainly a mixture of debug and release lib being loaded at startup.
2607 * I also remove a depency to a specific C function: strdup. Because I had
2608 to force the link to msvcrtd (whereas strdup is in libc).
2610 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2611 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2612 located in the gdcmCommon.h file. All use of reference of tha has been
2613 changed to now use the variable GDCM_UNFOUND.
2615 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2617 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2618 Dicom dictionary. The test suite can now be run again. Note:
2619 I'm note very happy with the " (RET)" changes. I believe this
2620 RETAINED comment should be dropped when parsing the dictionary.
2621 - PACKAGER corrected
2623 - AUTHORS updated and now in alphabetical order
2624 * Makefile.am now exports gdcm.dsw for Windoze users.
2626 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2627 * cygwin complains about missing std:: in subdir Test/
2629 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2630 * remove some methods that are now in gdcmHeaderHelper
2632 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2633 * vtkGdcmReader set spacing and origin correctly
2635 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2636 * Fix a few delete/delete[] mismatch
2638 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2639 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2640 interpretation to data given by gdcmHeader. For instance there are
2641 heuristics to get informations (look at different places).
2642 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2643 sorting DICOM images based on different strategies.
2644 * modified Makefiles accordingly.
2646 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2647 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2648 when building in debug mode
2649 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2650 src/win32/gdcmdll.dsp
2651 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2653 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2654 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2657 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2658 * src/win32/libgdcmjpeg12.dsp was not dos format
2659 * src/win32/libgdcmjpeg12.dsp :
2660 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2661 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2663 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2664 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2666 * src/gdcmFile.cxx : bug fix in affectation type
2667 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2668 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2669 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2670 symbols... future problem ?
2672 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2673 * src/win32/libgdcmijpeg12.dsp was missing
2674 * modified gdcm.dsw accordingly
2676 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2677 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2679 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2680 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2681 commit of JPR (before his hollidays to facilitate our work).
2682 * setup.py : bug fix in code. Modifications made while the last commit
2683 of JPR. The code hasn't been tested before the commit... it's so
2684 useless to make that (for best programmer that is JPR) !!!
2686 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2687 * tagged the current version as Version0_3 (i.e. version 0.3)
2689 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2690 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2691 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2692 * *.dsp : modifications to use new libgdcmijpeg8 library
2693 * setup.py : bug fix on VTKPATH variable
2694 * PACKAGER : adding all concerning windows
2696 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2697 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2699 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2700 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2701 test suite reported error.
2702 * PACKAGER file added (describes what a packager must do when
2703 packaging a new release).
2704 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2705 * configure.in: upgraded version number to 0.3.0
2706 * fixing build of rpm (through rpm -ta):
2707 - Doc/Makefile.am exports proper doxygen files
2708 - src/jpeg/libijg8/Makefile.am exports the include files.
2710 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2711 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2712 * src/gdcmHeader.h : formatting code
2714 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2715 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2716 We were obtaining error message from vtk. Now, creation of file list
2717 is made in an internal list to prevent this problem.
2718 Bug fix when output is empty.
2719 Bug fix in update of progress value. Previous commit for this was a bad
2721 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2723 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2724 * src/gdcmHeader.h : added method to get the file name
2725 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2726 files. Added method to remove all files on the input
2727 Added FIXME comment concerning the bad parsing of header made by
2728 ExecuteInformation method (in ExecuteData method)
2730 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2731 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2732 when using make instal.
2733 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2734 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2736 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2737 * setup.py : adding include dir of jpeg lib to compile all sources
2738 * */Win32/*.dsp : JPR fix for windows compilation
2740 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2741 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2743 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2744 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2746 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2747 * setup.py is again effective on un*x (takes into account the
2748 addon of the jpeg library)
2749 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2750 * Doc/Doxy* updated (includes above enhancements)
2751 * INSTALL now points to web documentation
2753 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2754 * src/gdcmHeader.h doesn't make unnecessary reference to
2756 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2758 * src/gdcm*.[cxx|h] :
2759 - to allow compilation with gcc 3.x
2760 -- clean up of STL usage (added explicit usage of std::)
2761 -- small fixes on exceptions.
2762 Note: linking not tested !
2763 - clean of doxygen comments to avoid warnings at documentation
2765 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2766 dependent convertion).
2768 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2769 * Clean up of previous JPR garbage commit (not even commented in the
2771 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2772 - moved all jpeg related files from src to src/jpeg/libijg8, with
2773 addition/modification of Makefile.am and configure.in.
2774 - the testSuite is still brain damage (not guilty).
2776 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2777 * WrapVTK.py : modifications to get correctly vtk source files to
2779 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2780 (FileName -> Filename)
2782 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2783 * vtk/vtkGdcmReader.[cxx/h]:
2784 - UpdateProgress method should now be effective
2785 - removed the limitation on having only images loaded (as opposed
2787 - when building a stack of images/volume, a lesser number of
2788 gdcmHeader and gdcmFile instances should be used (hopefully
2789 accelerating things).
2790 - when building a stack of images/volumes, files which are not
2791 loadable (wrong path-filename, wrong permissions on existing file,
2792 or file not parsable by gdcm) are replaced with a black image
2793 in the stack (for the caller to notice the problem).
2795 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2796 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2798 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2799 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2800 between standard library (std) and vtk library (problems are found
2801 under Windows... thanks Windows !)
2803 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2804 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2806 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2808 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2809 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2811 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2812 * When compiling with distutils (see setup.py) the C++ compiler is
2813 called with different flags than the default ones (with automake).
2814 In order to fix all those warning, I compiled gdcm with the command
2815 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2816 and went for warning fixes:
2817 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2818 up from unused variables.
2819 - vtk/vtkGdcmReader.cxx: potential bug fix.
2820 * src/gdcmHeader.h: Doxygen warning cleanup
2822 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2823 * gdcmPython/gdcm.i:
2824 - typemaps correction to take into account the systematic replacement
2825 of "using namespace std" with std:: prefix e.g. std::list,
2826 std::string... (cf changes of 2003-05-21).
2827 - gdcmGlob global variable of type gdcmGlobal (defined in
2828 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2829 exported to Python a as cvar.
2830 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2831 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2832 gdcmDictSet.GetPubDictTagNames() and
2833 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2834 C++ static methods).
2835 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2836 with the above changes.
2838 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2839 * setup.py, manifest.in : bug fix under linux
2841 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2842 * Modification of setup.py to compile vtk part too. Then, we have 2
2843 wrappers which must work with same distutils. For that, we have a
2844 generic distutils in distusiltsWrapping.py ; with :
2845 - build_extWrap class to wrap generically all extensions,
2846 - ExtensionWrap base class for all wrapping extension that contains
2848 - Wrapper interface which wrap sources
2849 + In WrapSwig.py we have extension and wrapper for Swig
2850 + In WrapVTK.py we have extension and wrapper for VTK
2851 * MANIFEST.in : modifications to consider vtk directory and new python
2852 files for compilation
2854 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2855 * Added python wrappers of vtkGdcmReader vtk class (see the
2856 source in vtk/vtkGdcmReader.cxx) :
2857 - vtk/Makefile.am now builds a library
2858 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2859 python library (as opposed to _gdcm.so wich are the python
2860 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2861 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2863 - configure.in has an additional flag --enable-vtk that needs
2864 to be set to enable compilation of vtk related code, that is:
2865 + vtk/vtkGdcmReader.so and
2866 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2867 + gdcmPython/vtkgdcmPython.so (see above)
2868 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2869 be read when compressed or when HighBit + 1 != BitsStored),
2870 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2871 the usage of the python wrapper of vtkGdcmReader vtk class.
2872 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2873 * src/*.[h] all occurences of stl classes are now prefixed with
2874 std::, and all occurences of "using namespace std;" where removed.
2875 This is to avoid pollution of global namespace in included files.
2876 Apparently vtk does not avoid this pitfall: when using both
2877 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2878 collision of various stl members (principally cout...).
2879 * gdcmPython/testSuite.py now cleanly removes temprory generated
2881 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2882 comply with above changes)
2884 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2885 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2886 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2887 vtk data structure (an image Flip was required).
2888 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2889 * cosmetic changes in documentation.
2891 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2892 * src/gdcmHeader.cxx: the constructor no longer exits when an
2893 unexisting file is given as argument.
2894 * The subdirectory Data (containing all the images used for the
2895 test suite) is not part of this repository anymore. A new module
2896 containing those images is now available at
2897 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2898 with the name gdcmData.
2899 All the python scripts (including the package initialisation file
2900 gdcmPython/__init__.py) were adapated to take this change into
2901 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2903 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2904 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2905 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2906 demo of the usage of this class.
2907 Compilation of this vtk part is only done when using the --enable-vtk
2908 at configure (or autogen.sh) stage.
2910 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2911 * More memory link related corrections and documentation fixes.
2913 - maximum info is obtained with a command of the form:
2914 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2915 --show-reachable=yes PrintHeader
2916 - the remaining reachable blocks seem to come from the STL
2917 allocation scheme through the usage of map and list. It looks
2918 like this memory cannot be freed but it is not a memory leak
2919 (in fact further invocation to the STL would recollect the
2920 unused memory allthough it cannot explicitely be freed).
2921 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2922 of displaying an image parsed with gdcm and displayed with VTK.
2923 Note: some images don't seem to work e.g.
2924 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2925 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2926 Allthough this weakens the semantics, it is a ditch attempt to
2927 make gdcm more thread friendly.
2929 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2930 * Memory link hunt (by using valgrind through the command
2931 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2932 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2933 gdcmHeader::_dicom_vr.
2934 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2935 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2937 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2939 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2940 * src/Makefile.am now exports all the necessary include files at
2944 * UpdateGroupLength replaced by new one
2947 * UpdateGroupLength re-written using H-Table
2948 (named UpdateGroupLengthNew untill checks are over)
2950 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2951 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2952 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2954 - gdcmHeader::GetPubElValSet removed.
2955 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2956 UpdateGroupLength, WriteElements, Write.
2957 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2958 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2959 carried the same semantics.
2960 - src/gdcmHeaderIdo.cxx changed accordingly.
2961 - gdcmFile::WriteBase now regroups all the codes from previous
2962 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2963 - enum FileType moved to gdcmCommon.h
2964 * src/gdcmHeader.cxx AddDefault trashed
2965 * gdcmGetXSize added
2966 * getimageDataSize now calls gdcmGetXSize
2967 * Test/*.cxx changed to agree with above changes
2969 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2970 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2971 (to avoid double call by end user).
2972 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2973 by end user, since gdcmHeader::gdcmHeader now handles it.
2975 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2976 * gdcm/Doc many doxygen changes:
2977 - Doxyfile now has two different versions, DoxyfileUsers that generates
2978 the html.users end users oriented documentation and
2979 DoxyfileDeveloppers that generates the html.developper developper
2980 oriented documentation.
2981 - README changed accordingly
2982 - requirement.txt removed (old design info moved to TODO).
2983 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2984 DoxyMainPage.txt, DoxyPython.txt provide more information.
2985 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2986 be updated by simply regenerating the docs with doxygen and copying
2987 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2988 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2989 all the tests in the form "if (<map>.count() >1)" were removed.
2990 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2991 ill-formed documentation sections.
2992 * src/gdcmHeader.cxx: ditto
2994 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2995 * setup.py fixed for un*x (needed macro for stdint.h)
2996 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2997 un*ces with sh-utils test utility.
2998 * gdcmPython/demo/test.py renamed to PrintHeader.py
2999 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3000 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3001 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3002 * src/gdcm*.cxx JPR's bad inclusion fixed.
3004 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3005 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3006 * gdcmPython/demo/test.py changed accordingly.
3008 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3009 * gdcmPython/Makefile.am fixed linking against libstdc++
3010 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3011 * Swig subdir (historical tests of swig version 1.3.17++) removed
3012 * Test/testChangeEntete.cxx some lines commented out in order to make
3014 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3015 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3017 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3018 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3019 hence the user doesn't need this explicit call.
3020 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3021 i.e. LoadElements() call removed.
3022 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3023 - src/Makefile.am declares the proper flag for g++.
3024 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3025 for adding user defined new tags.
3026 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3027 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3028 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3030 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3031 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3032 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3033 src/Makefile.am : the project should properly compile and install
3034 with the autotools, included the python wrappers part.
3035 * gdcm.spec.in : added a spec file for RPM packaging.
3037 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3038 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3040 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3041 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3042 to exported to the environement (see gdcmPython/testSuite.py
3044 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3045 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3046 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3047 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3048 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3050 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3051 * gdcmPython/__init__.py doesn't crash anymore when running in
3052 in InstallMode or PreInstallMode but with an environment given
3053 value of GDCM_DICT_PATH.
3054 * src/gdcmDictSet.[cxx/h] coding style.
3056 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3057 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3058 * src/gdcm.h general comments moved to TODO, and README
3059 * src/gdcm.h should now be seen as a user commodity (including it
3060 should suffice to fully use gdcm). It is nowhere including within
3061 any of the kernel files src/*.cxx and src/*.h.
3063 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3064 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3065 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3067 * src/gdcm*.cxx only include their corresponding include file
3068 (as opposed to gdcm.h)
3069 * gdcmPython/gdcm.i changed accordingly
3070 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3071 the autogen.sh generated "make snapshot" command to work.
3072 * autogen.sh removed history related references to crea package.
3074 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3075 * distutilsSwigCPlusPlus.py work around some swig portability
3078 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3079 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3080 was done in a last ditch attempt to get setup.py _really_
3081 operationnal. The python/gdcmPython layaout add the advantage
3082 of hidding away the python related distutils specific files
3083 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3084 Alas, the src directory was out of scope (i.e. it's relative
3085 position to setup.py was ../src) which made things impossible to
3086 handle (see previous version of python/setup.py). Crossing fingers...
3088 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3089 * python/setup.py now works on Un*x. (harder than I thougth)
3090 * python/distutilsSwigCPlusPlus.py can now have include files
3091 among the list of sources.
3093 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3094 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3095 * modifications in MSVC projects
3097 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3098 * As stated by the first lines of Test/ExceptionAndPython/README, it
3099 looks like we can move back to original usage of exception within
3100 src/gdcm* and hence remove the errno stuff that was introduced
3101 as a quick and dirty fixture of this problem (added to the TODO).
3102 * Doc/Doxyfile configuration file for Doxygen and corresponding
3103 README file for usage added.
3104 * Test/testWrite.cxx added. This new test comes from a split of
3105 test.cxx that is now reverted to its original purpous i.e.
3106 testing the proper parsing of a Dicom related file.
3107 testWrite.cxx concentrates on testing the IO part of gdcm.
3108 * Test/bug1.cxx (containing a bug on WIn32) added.
3109 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3110 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3111 whose purpose is to publish the content of the TagNames of the
3112 Dicom public dictionary were not accessible without an
3113 instance of class gdcmHeader.
3114 - those methods are now static methods of gdcmDictSet and hence
3115 require no instances at all to be invocated.
3116 - within gdcmDictSet this change required to change some method
3117 to class methods (i.e. are now static) among which SetDictPath
3118 (renamed to BuildDictPath) and LoadDefaultPubDict.
3119 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3120 the above changes by calling the new method classes of gdcmDictSet.
3121 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3122 the above to be effective.
3123 * python/gdcmPython: in order to wrap properly the above changes
3124 for Python, swig version now needs to be > 1.3.17.
3125 * python/gdcmPython/Makefile fixed to adapt itself to new
3126 configure/make shema introduced by Johan Montagnat (thanks for the
3127 contribution). Alas this Makefile cannot be turned into a proper
3128 Makefile.am without some heavy changes in the configure.in
3129 (for python dectection).
3130 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3131 now avoids publishing the empty entries.
3133 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3134 * python/setup.py : bug fix concerning install under windows
3135 ExtraPath reused :-P
3136 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3138 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3139 * Dicts/dicomV3.dic : remove double spaces !!!
3140 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3141 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3144 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3145 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3146 method. Doxygenation.
3147 * src/gdcm.h clean up of JPR spurious comments.
3149 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3150 * python/distutilsSwigCPlusPlus.py now properly collects the
3151 shadow classes generated by "swig -c++" (gdcm.py in our case)
3152 when using "python setup.py install".
3153 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3154 reexports the working classes.
3155 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3156 by the classical C errno scheme. This is to prevent an obscure
3157 behavior of the python wrappers when importing wxPython.wx prior
3158 to gdcmPython (which ended up in an abort call). An illustration
3159 of this oddity can be found in the Test/ExceptionAndPython
3160 subdir (see the README file). This problem probably due to
3161 an combination of g++ and dynamic loading.
3162 * added Test/ExceptionAndPython (see above)
3164 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3165 * Changed the layout of the python part to avoid bloating main
3166 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3167 i.e. the distutils arsenal. All the python related stuff is
3168 again in a python subdir, but the package itself is now in
3170 * setup.py was cleaned up:
3171 - pythonIncludePath removed
3172 - python setup.py bdist target is now functional.
3173 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3174 collision with other packages). gdcmPython/demo/*.py changed
3177 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3178 * python subdir moved to gdcmPython (preparation of distutils packaging).
3179 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3180 distutils installer is operational.
3181 * - gdcmPython/__init__.py now properly loads the swig generated
3182 shadow classes (from gdcm.py).
3183 - gdcmPython/demo/*.py changed to import the package gdcmPython
3184 instead of gdcmPython/demo/load.py.
3185 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3187 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3188 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3189 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3190 entries within the associated public Dicom dictionary resp. the same
3191 information but sorted by the fourth field (PAT, IMG, DIR) of the
3193 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3194 are now in the "???" group.
3195 - python/gdcm.i changed accordingly,
3196 - python/demo/printGroupedPublicDict.py added, that gives an example
3197 of the above new functionalities in Python.
3199 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3200 * src/gdcm.h, gdcmHeader.cxx:
3201 - historic references to glib's g_malloc and g_free (#defined)
3202 were definitively removed.
3203 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3204 * src/gdcmElValSet.cxx:
3205 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3206 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3207 - GetElValue(string) renamed to GetElValueByName.
3208 - Added GetElementByName(string).
3209 * src/gdcmHeader.cxx: added
3210 - GetPubElValRepByNumber(guint16, guint16)
3211 - GetPubElValRepByName(string)
3212 - GetShaElValRepByNumber(guint16, guint16)
3213 - GetShaElValRepByName(string)
3214 - GetShaElValByNumber(guint16, guint16)
3215 - GetShaElValRepByName(string)
3216 - GetElValRepByNumber(guint16, guint16)
3217 - GetElValRepByName(string)
3218 - GetElValByNumber(guint16, guint16)
3219 - GetElValRepByName(string)
3220 * Doc/requirements.txt added.
3222 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3223 * Test/Makefile building now depends on the one of libgdcm.so
3224 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3225 pixel data) aware which enables finding the address (offset) of
3226 the pixel data of JPEG encoded DICOM files. This leaves only a single
3227 file in the testSuite whose pixel data address (offset) is unknown.
3228 * python/testSuite.py changed accordingly.
3230 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3231 * VC++ has some strong limitations when working with the STL, as stated
3232 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3233 "Also note that some STL containers (map, set, queue, list, deque)
3234 cannot be exported. [...]
3235 Some STL classes contain nested classes. These classes can not
3237 This is caused by a designed limitation that once a template
3238 class is instantiated, it can not be re-instantiated and
3240 Since our usage of map<> is ubiquitous in gdcm, this "designed
3241 limitation" of VC++ is a pitfall.
3242 Hence the Python wrappers of gdcm cannot be incrementally linked
3243 against the c++ dynamic library. The dirty but only workaround is
3244 to forget about incremental link of dynamic libraries and to generate
3245 the Python wrappers library with the inclusions of the underlying C++
3247 The following modifications concern this matter on Win32/VC++:
3248 - wrapping python correct with standalone wrapped dll (don't use separate
3249 dll under windows !!!!)
3250 - python21_d debug mode enabled (ask Frog how to use it :-)
3251 - NO problem with having an STL member of class for example string in C++
3252 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3253 - Python test of dcmlib in Python is ok under windows on a large set
3255 * removed glib references
3256 * typedef's inserted in gdcm.i for correct swig type management
3258 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3259 * python/demo/*.py load.py extracted from test.py. Added explore.py
3260 that only displays required tags and testAll.py that parses all
3261 the files of the testsuite without using unittest.
3262 * python/testSuite.py other additional test on new files added.
3263 * Data/* new test files added accordingly to the testSuite.
3264 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3265 the vr in the file differs from the one of the dictionary.
3267 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3268 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3269 values, but limits itself to values which are below a user specified
3270 size (by default 1024 bytes).
3271 * python/gdcm.i : elements not loaded (because their size is above the
3272 user specified treshold) are exported with their TagKey as key of the
3273 python dictionary. This enables the testsuite to make some checks
3274 on the unloaded elements (since we have their offset and size).
3275 * python/testSuite.py
3276 - now tests for the existence and proper value of the pixel data
3277 - two new examples added.
3278 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3280 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3281 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3282 aware. See the strategy comments in gdcmHeader::FindLength().
3283 * Test/test.cxx now accepts a filename as first argument.
3284 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3285 * python/testSuite.py changed to integrate test on above files.
3287 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3288 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3289 the vr was also RET.
3290 * python/testSuite.py more tests added.
3292 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3293 * python/testSuite.py unittest test suite added (uses Data)
3294 * Data/* dcm and acr files for the test suite.
3295 * glib dependance removed from un*x version. We now use ISO C99
3296 7.18 Integer types (see stdint.h)
3297 - python/Makefile, src/Makefile src/gdcm.h
3298 * src/ when an explicit vr (like dicom files) suddenly poped an
3299 implicit element we use to mark the underlying DictEntry of the
3300 concerned ElValue with "Implicit". This strategy was damageable
3301 too the public or provite dictionaries, since some of their vr
3302 would be changed. Since Header::FindLength heavily relies on the
3303 detection by Header::FindVR of falsely explicit elements, I
3304 added an extra ImplicitVr member to ElValue (boolean).
3305 The rest of the changes we the necessary adaptations.
3307 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3308 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3310 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3312 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3313 * Adaptation for porting to VC++:
3315 o forced to use std namespace (for string to be known)
3316 o all class use __declspec export style on WIN32
3317 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3318 (in stdlib.h on Win32 but in std:: for gcc)
3319 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3320 variable GDCM_DICT_PATH.
3321 * src/gdcmHeader.cxx verbose comments made discrete.
3323 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3324 * python/gdcm.i: added a typemap that converts a C++ hashing table
3325 to native Python dictionary.
3326 * python/demo/test.py:
3327 - now uses the native dictionary for exploration of gdcmHeader.
3328 - takes an optional filename argument (the file to parse).
3329 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3330 PubElVals hashing table.
3331 * Dicts/dicomV3.dic removed error prone trailing spaces.
3333 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3334 * Python wrapping process moved away from src/Makefile to
3335 newly created python/Makefile (as well as gdcm.i)
3336 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3337 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3338 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3339 from the environement variable GDCM_DICT_PATH (when existing).
3340 * src/gdcmDict::GetTag bug fix.
3342 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3343 * Straightforward temporary fixes for swig to build the python wrappers.
3344 src/Makefile now has a python working entry [by working we mean
3345 that we can import the shadow classes without errors].
3347 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3348 * hashtest.cxx removed (since already in Test)
3349 * src/gdcmlib.h renamed to src/gdcm.h
3350 * src/dcm.i renamed to src/gdcm.i
3351 * src/Makefile prepared for python wrapping
3353 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3354 * src/gdcmHeader.cxx :
3355 - Parsing of header is now separated from loading of element values
3356 (see gdcmHeader::LoadElements).
3357 - general clean up of hopefully all file access (creation of
3358 ReadInt16 and ReadInt32)
3360 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3361 * src/gdcmHeader.cxx :
3362 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3364 - SetLgrElem renamed to SetLength
3365 - GetLgrElem renamed to GetLength
3366 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3367 * src/gdcmElValSet.cxx fixed both GetElValue methods
3368 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3369 due to IdoDude was cleaned out.
3371 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3372 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3373 concentrates on finding the value representation (when it exists).
3374 RecupLgr now only finds the element value length, and it avoids
3375 returning the unecessary skL (skipped length).
3376 Also, offsetCourant was simply removed (with taille_fich) since
3377 it was redundant with the File position internals (by using
3378 ftell and fseek). This also made skL (see above in RecupLgr) usage
3380 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3381 on the libido specificities which are handled through class
3383 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3386 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3387 * Truckload of changes. Parsing of header is barely functional
3388 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3390 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3391 * src/gdcmHeader.cxx many addons of low level methods
3393 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3394 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3395 and _IdDcmSWAP_LONG.
3397 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3398 * This corresponds to all the changes decided at the meeting of
3399 May 23 2002. Needless to say we are running late...