1 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Testing/TestMAkeIcon.cxx : complete the test
4 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
5 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memroy leaks
7 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
8 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
11 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
12 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
14 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
15 * Test/ : accelerate tests (it's not very significant accelerations).
16 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
18 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
19 * Testing/TestSequence.cxx : add test for sequences of images... test that
20 we have the same serie or the same study UID
22 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
25 * src/gdcmDict.h : remove commented code
26 * src/gdcmDocument.cxx : initialize values
27 * src/gdcmFile.cxx : bug fix when reading values
28 * gdcmPython/demo/ : change file names. Remove useless files
30 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
31 * src/gdcmFile.cxx : remove the default array of initialization.
32 The static array contained pointers to non-static values (comming from
33 strings). To have coherences, when creating files, these values can't be
34 static. So, the array can't be static, too ! To simplify, the array have
35 been replaced by repeted lines to insert values in the File
37 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
38 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
39 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
41 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
42 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
43 (Dicom Element) into the Sequence Item
45 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
46 * src/*.cxx : first parss to normalize file organisation
48 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
49 * src/gdcmDirList.[h|cxx] : add method to find a directory
50 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
52 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
53 * Finish cleaning up my JPEG mess. Should be ok now.
54 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
55 contained within the RLE* class(doh!)
57 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
58 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
59 * SerieHeader::AddFileName() creates as many Coherent Files lists
60 (same Serie UID) as it founds different Serie UID
61 amongst the files instead of discarting any file
62 that doesn't match with the first one he found.
63 * SerieHeader::OrderGdcmFileList has now one parameter :
64 the Coherent Files list the user wants to sort
65 * SerieHeader::GetFirstCoherentFileList() |
66 * SerieHeader::GetLastCoherentFileList() | allow to parse
67 the set of Coherent Files lists
68 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
69 compatibility (it returns the *first* Coherent Files list,
70 since there was only one before)
71 * Test/TestSerieHeader gets gdcmData as a default root directory
73 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
74 * Remove friend between DocEntry and File classes
75 * Remove friend between PixelReadConverter and RLEFramesInfo,
78 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
79 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
80 0002|0000. The value was incorrect.
82 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
83 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
85 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
86 * src/gdcmUtil.cxx : compilation fix on Win32
87 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
88 variable, to be easy found. Add methods to change the default UID.
89 Amelioration of the CreateUniqueUID to use the correct default UID.
90 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
93 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
94 * Test/TestVR.cxx : fix memory leaks
96 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
97 * Rewrite the base 256 to base 10 conversion, using string operation only.
98 This allows us to get rid of the problematic 64bits integer type (does not
99 always exist on target platform).
101 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
102 * Add construct and destructor to class gdcm::Debug to close the debug file
104 * Don't let uset to open twice the same file
105 * gdcm has now an official UID prefix,
106 supplied by http://www.medicalconnections.co.uk
107 1.2.826.0.1.3680043.2.1143
108 (Thx to Mathieu for providing URL)
109 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
110 to be able to perform some more tests
111 * gdcm::ContentEntry : Contructors and Destructor are now protected,
112 in order to be sure no user will try to use them.
113 (at user level, only the children classes are meaningfull)
115 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
116 * move RLEInfo & JPEGInfo from Document to File
118 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
119 * FIX : remove so many friend between classes
121 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
122 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
123 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
125 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
126 In order to avoid missbehaviour :
127 . gdcm::DocEntry is now specialized in
128 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
129 - gdcm::ContentEntry (Dicom entry with a 'content')
130 . gdcm::ContentEntry is specialized in
131 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
132 characters value, or integers)
133 - gdcm::BinEntry (Dicom entry with a non strig representable value
134 (user hasn't any longer to thing about the precedence of his dynamic_casts)
136 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
137 * Test/VTKTest*.cxx : bug fix under linux
139 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
140 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
141 use with python. Some methods are moved from Document to ElementSet or
142 DocEntrySet. The equivalent methods to ElementSet have been added to
143 SQItem and are virtual in DocEntrySet. Methods that may have the same code
144 in SQItem and ElementSet is directly placed in DocEntrySet
146 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
147 * Test/VTKTest*.cxx : remove the show variable in each test method because
148 it's useless (the viewer variable replace this variable)
150 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
151 * src/gdcmDocument.cxx : bug fix on potential memory leak
152 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
153 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
154 Add ClearXxx methods to remove all the content of the list or map
155 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
157 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
158 * methods ReplaceOrCreate renamed as Insert
159 (nobody will be any longer confused by 'CreateOrReplace')
161 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
162 * Grealty simplify the JPEg decompression, no need to differenciate based on
163 the JPEG possible type (with/without fragment, with/without multiple frame).
164 Everything is done throught the JPEG IO Suspension mechanism in IJG
166 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
167 * Stage 3 of normalization :
168 in order to avoid any missunderstanding while reading method names :
169 - All the methods xxxEntry now deal with dicom Entries
170 - Methods GetEntry splitted into
173 - Method SetEntry renamed as SetEntryValue
174 - Method SetEntryBinArea let as it was
176 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
177 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
178 - Position correctly the entry points for JPEG2000 and JPEG-LS
179 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
181 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
182 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
183 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
184 with other method names
185 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
186 * Test/TestDicomDirElement.cxx : add new test
188 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
189 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
190 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
191 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
192 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
193 So can't you use __int64 in ostream at all.
195 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
196 * bug fix for compilation on MSVC6
197 * gdcmPython/gdcm.i : rename of classes missed
199 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
200 * Stage 2 of names normalization :
201 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
202 (easy to understand ...)
203 - gdcm::FileHelper replaces old class gdcm::File
205 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
206 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
207 type and not a string. So, there remove problems on the format of the
210 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
211 * Add Example/TestPapyrus.cxx
212 - reads a Papyrus file (gdcm::Header compliant),
213 - gets the pixels of all the images, using low level iterators
214 - writes an multiframes Dicom image.
215 (Just to show it's *possible* to do that)
216 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
219 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
220 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
221 Thus, DicomDirXXX are created with a flad that indicates if the created
222 object is empty or not (when not empty, the DicomDirElement is used to
225 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
226 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
227 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
229 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
230 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
232 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
233 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
234 Remove all access to the hash-tables or lists in the objects.
236 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
237 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
238 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
239 be complient with all the gdcm source code
241 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
242 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
245 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
246 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
249 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
250 * Test/ : rename VTK tests to have a best name for the tests
251 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
252 GetFirstEntry/GetNextEntry use
254 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
255 * In SerieHeader::ImagePositionPatientOrdering()
256 // a Dicom 'Serie' may contain scout views
257 // and images may have differents directions.
258 // -> More than one may have the same 'pos'
259 // Sorting has then NO meaning !
260 Thx to Eduardo Davila for reporting bug.
262 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
263 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
264 test. Now it's on image content and not on the resulting visualisation...
265 might solve the problem on linux when using the OpenGL drivers
267 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
268 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
269 DicomDirSerie, DicomDirImage
270 Dict, DictSet classes :
271 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
272 -remove InitTraversal method.
273 * UPD Test programs + Example programs
275 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
276 * remove useless and never updated keyword \ingroup
277 * Solve pb when structure (list, map, ...) is empty.
278 Thx to Benoit for reporting bug
280 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
281 * Taking into account of 'Transfer Syntax' value
282 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
285 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
286 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
287 is no memory access violation
288 * gdcmPython/demo : add python demos using VTK
290 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
291 * FIX 'Dictionnary' is now spelt 'Dictionary'
292 'wether' is now spelt 'whether'
293 'archieve' is now spelt 'archive' ;-)
295 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
296 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
297 related methods, in order not to expose internal mechanisms
300 * REM methods that exposed internal mechanisms :
301 DicomDir::GetDicomDirPatients()
302 DicomDirPatient::GetDicomDirStudies()
303 DicomDirStudy::GetDicomDirSeries()
304 DicomDirSerie::GetDicomDirImages()
305 * UPD Test programs :
309 * UPD Example program
311 * ADD DictSet methods
315 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
316 * Removed the Print/indent/default parameter mess. There is absolutely no
317 reason to have to methods, moreover with the second taking the ostream as
318 *SECOND* parameter. This was clearly a bad hack to get things compile.
320 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
321 * Complete rewrite of the GetMacAddress code. Now the code is *much*
322 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
323 Unfortunately the main code does not work on SunOS, thus provide a specific
324 code for this platform only (and Win32 of course). Since this seems to be
325 working, change CreateUniqueUID to use GetMACAddress instead of the
326 problematic GctestetIPAddress
328 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
329 * Unfortunately to be able to test gdcmDirList I had to break the API
330 a little. Now the class is not a std::list anymore but has a member
331 std::vector (more ITK compatible). Allow unit testing on Win32 and
334 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
335 * Update SerieHeader to take into account a Serie Instance UID to properly
338 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
339 * ENH - Comment out Mathieu's (dangerous) Super Hack
340 for dealing with BIGENDIAN processors
341 - Move equivalent stuff to BinEntry::WriteContent
342 When necessary, 16 Bits Pixels are swapped in a small buffer
343 and then written. This avoid allocating a huge buffer, in
344 PixelWriteConvertor, and avoid modifying the Pixel Area.
346 Probabely, the same operation will have to be done when we want
347 to write image with Big Endian Transfert Syntax,
348 and we are working on Little Endian Processor
350 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
351 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
353 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
354 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
355 all the dict content.
356 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
358 * Test/TestDict.cxx : add a new test for the dict classes
360 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
361 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
362 file. Debug is yanked if compiled with NDEBUG
364 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
365 * src/gdcmDictSet.h : set the default output to the os variable
366 * src/gdcmDictEntry.[h|cxx] : add the Print method
367 * gdcmPython/demo/ : add a new test
369 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
370 * merging of Test/PrintDicomDir and Test/TestDicomDir
371 * removal of now redundant Test/PrintDicomDir
372 * enhancement of Example/PrintDicomDir
374 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
375 * Now, python test might work on systems
376 * Add the PrintDicomDir test
378 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
379 * FIX : First entry following group 0002 was lost for
380 Explicit Big Endian Transfer Syntax files
381 (group and elem not swaped)
383 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
384 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
385 Big Endian Transfer Syntax supposed the group following 0002
386 begins always by element 0000 (element 0000 is *optional*)
387 To avoid further troubles, let's be pessimistic, and use
388 Document::HandleOutOfGroup0002() method
389 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
390 (related pb not yet solved)
392 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
393 * Bug fix for the python part use
394 * Now, PrintHeader.py pass... but outside the ctest use. shit !
396 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
397 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
399 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
400 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
401 a string and should ask the global TS dict what are the propreties of
404 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
405 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
406 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
407 to swap the Swap Code, at parsing time, when we come out of group 0002
408 and Transfer Syntax is Big Endian
409 We should be able to read now 'true DICOM" Big Endian coded images
410 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
411 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
413 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
414 * Hopefully fix the bug on MacOSX and static global initialization.
415 This is the only -minor- patch I found that both please MacOSX and VS6.
416 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
417 but this would require a lot of change. Another approach would be that Global
418 create those string and GDCM_UNFOUND becomes a pointer to a string (which
419 gdcm::Global would destroy at exit).
421 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
422 * Fix bug on MacOSX with static initialization in a multy threaded
423 environment. static const string in a header file used to be ill
424 initialized provoquing the freeze of any tests. patch should solve this
427 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
428 * According to Benoit's suggestion, and without any objection from anybody
429 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
430 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
431 - method gdcmDicomDirObject::GetEntry() renamed as
432 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
434 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
435 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
436 you debug/warning message just as c++ streams which make them very convinient
437 to use. Once this is stabilize I will change the ostringstrem to be
438 redirected to a file (ofstream).
439 * Properly support C99 extension: __FUNCTION__ which allow us to display
440 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
442 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
443 * Removal of useless and dangerous methods :
444 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
445 GetDocEntryByName, GetEntryByName, GetDictEntryByName
446 * Removal of usless methods :
447 Dict::PrintByName, Dict::GetDictEntryByName
448 * Commenting out of probabely useless methods :
449 Dict::GetDictEntryNames()
450 Dict::GetDictEntryNamesByCategory()
451 DictSet::GetPubDictEntryNames()
452 DictSet::GetPubDictEntryNamesByCategory()
453 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
454 * ENH : Use dicomTS.dic as described in 2004 version
455 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
456 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
457 Add Accessors on VM (Value Multiplicity), and VM related methods
458 * ADD : Add a list of 'Dicom Attribute types', as found in
459 http://medical.nema.org/dicom/2004/04_15PU.PDF
461 * ADD : Add dicomGroupNameAbbreviations.dic
462 should be used to write a method to replace the former
463 Dict::GetDictEntryNamesByCategory()
465 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
466 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
467 to read in the file... and only it ! Length is the efective length of the
468 data in the DocEntry structure
470 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
471 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
472 And now use a static function call instead, with a global variable. i
473 This is much closer to the VTK approach. Hopefully should be bulletproof
474 and easier to use...hopefully
476 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
477 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
479 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
480 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
482 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
483 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
484 ValEntry, BinEntry, SeqEntry creation or replace
486 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
487 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
488 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
490 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
491 when specifying the VR
492 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
493 * src/gdcmDocEntry.cxx : amelioration of print
495 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
496 * ADD : Add the method Util::IsCurrentProcessorBigEndian
497 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
498 * ADD Method Document::ComputeGroupLength
499 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
500 in order to allow further VR modification by user
501 * REM : removal of once-called method File::WriteBase
502 integration of its code in formerly one-line method File::Write
504 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
505 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
506 replace the different values "??", "Unkn", "Unknown".
507 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
508 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
509 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
510 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
512 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
513 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
515 * Set the gdcm::Base class to some Printable classes
517 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
518 * src/gdcmFile.[h|cxx] : add the Print method
519 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
520 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
521 * src/gdcmDocument.h : remove the PrintLevel informations
522 * Example/PrintFile.cxx : use the new gdcm::File::Print
524 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
525 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
526 problems when compiling with the python wrapping
528 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
529 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
530 writting in ImplicitVR
532 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
533 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
534 JPEG decompression, especially when dicom frames are split into several
535 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
536 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
538 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
539 * src/gdcmHeader.cxx : change the initialisation of default header.
540 Now, this header is readable by gdm, e-film, DicomWorks
542 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
543 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
544 Rename Decompressed to Raw
545 * Use the API changes in gdcm::File.
546 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
549 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
550 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
551 each added entry in the header. Replace the 'Planes' field by the 'Number
554 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
555 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
556 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
558 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
559 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
560 At this time, this image isn't readable by e-film... waiting JPR help to
563 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
564 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
565 DocEntry. Now use methods of the Document !
567 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
568 * Test/ShowDicomSeq.cxx : bug fix
570 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
571 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
572 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
573 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
574 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
576 * Test/TestCopyRescaleDicom.cxx : remove unused variable
577 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
578 containing found sequences
580 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
581 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
583 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
584 Some fields in BinEntry must be copied to not seg fault when making the :
585 gdcm::File *copy = new gdcm::File( copyH );
586 and tests are now made on good variables
588 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
589 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
590 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
592 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
593 * Add vtkGdcmWriter example and test
595 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
596 * Test/TestUtil.cxx : reformat the source code
597 * vtk/vtkGdcmReader.cxx : remove and change prints
598 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
600 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
601 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
603 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
604 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
605 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
607 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
608 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
609 by an eof to prevent all bad read of the file... and in this case, the
612 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
613 * Example/Volume2Dicom.cxx : comment unused variables
614 * Test/PrintDicomDir.cxx : comment unused variables
615 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
616 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
617 method that is redondant with AddEntry.
618 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
621 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
622 * Bug fix due my last commit (compilation under Windows).
623 * Example/Volume2Dicom : bug fix in the file and reformatting source code
624 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
626 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
628 - Remove printf / sprintf
629 - include iostream AFTER gdcm so we don't get warnings
630 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
632 - Also remove tons of include from header files, hopefully this should
633 speeup the compilation time, since it was becoming a dog slow.
634 - Remove gdcm.h as it include way too many files and slow down compilation
635 (plus it is not up to date)
636 - remove 'using namespace std' this is BAD !
638 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
639 * Remove memory leaks on the DicomDir
640 * Remove some useless data in DicomDirObject
641 * Add usefull methods in SQItem, to be complient withe the ElementSet
643 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
644 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
646 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
647 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
648 future, with convertion)
649 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
650 and ImageDataSize values. Remove the method to get the PixelReadConverter
651 from the output of the class
653 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
654 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
656 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
657 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
658 and vtkErrorMacro use.
659 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
661 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
662 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
664 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
665 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
666 The string leaves only in the fonction. So when we make a .c_str(), we
667 get the pointeur on the first element, element that will be destroyed
668 immediately after thee instruction.
669 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
670 file has been opened : the test must be made on the content of the
671 pointer and not directly on the pointer !
674 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
675 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
676 the python part recompiles
678 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
679 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
680 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
681 X session is killed (for my computer... it seems to not be identic on
684 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
685 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
686 avoid problems (otherwise, the difference test between the visible image
687 and the reference is incorrect. If the reference is greater than the
688 screen resolution, it's produce errors).
689 Can be used for only one image. Can be used with a visible flag.
690 * vtk/vtkGdcmReader.cxx : remove commented codes.
691 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
692 under windows at compilation
693 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
695 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
697 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
698 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
699 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
700 tests on the image size X, Y, Z
702 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
703 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
704 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
705 between the class name and the file name
707 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
708 * src/ : fix compilation warnings for the Write method (2 different
709 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
710 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
711 variable... create a static method in gdcm::Document to access to
712 this variable content.
714 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
715 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
716 file, to be accessed by other files (like gdcmFile). Remove commented
717 code. Move the change of the header to the gdcmFile, using the
719 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
720 To be sure of that (and simplify calls), the Write of the header now
721 gets a file name and not a file pointer (std::ifstream).
722 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
723 DocEntryArchive. Remove all open of the written file
725 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
726 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
728 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
729 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
730 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
732 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
733 some corresponding methods. Write correctly the file and check before
735 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
736 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
737 is now on RGB data (as before my last commit
738 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
740 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
741 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
742 Add a print information of the type of the entry
743 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
744 It was in the gdcmFile, and all write have been regrouped
745 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
746 Write correctly all dicom files (in decompressed mode only at this time)
747 * Test/ : test on files are now made using Raw data and not color data if
749 * Example/PrintFile.cxx : add more printings
751 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
752 * Amelioration of code, remove some code copy. For the loading of
753 BinEntry (in gdcmDocument), add the test to verify if the file is already
756 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
757 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
758 remove a DocEntry in the header (push an empty DocEntry)
759 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
760 lines. Bug fix in the initialization of the PixelConvert and the
762 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
763 use in TestCopyDicom (now this test can run under windows... but fails)
764 * Test/TestCopyDicom.cxx : amelioration of the test :
765 - test the pixels written
766 - add test points to quickly find where is the error
767 - can set a file name input and output in arguments
768 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
769 amelioration of the test output
771 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
772 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
773 all replaced DocEntry's
774 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
775 Now, each needed DocEntry to modify is duplicated, modified and inserted
776 to the header using DocEntryArchive. Thus, after save, we can restore the
777 header initial state.
779 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
780 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
782 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
783 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
784 correct to copy it. The DictEntry is specified at the DocEntry creation,
785 then, it musn't change in the time.
786 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
787 header correctly. At this time, the change is only made for the first
788 level of the Document. In the future, it might consider sequences.
789 The change is made by replacing a DocEntry by an other that is created
790 outside the class. The old value is kept. When we restore the header
791 status, the added DocEntry is deleted and replaced by the old value.
792 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
793 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
794 set the write type to explicit VR, implicit VR or ACR. Add methods to set
795 the write mode to native, decompressed or RGB (but not used at this time)
797 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
798 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
799 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
801 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
802 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
803 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
805 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
806 set because already copied when copying the BinEntry's of the header
807 * Test/TestAllReadCompareDicom.cxx : remove warnings
809 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
810 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
811 Two problems appear when doing it :
812 - with the gdcmFile : when the GetImageData method is called, the pixels
813 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
814 data (pixels). And each structure destruct the data when it's
815 destructed. So we have two destructions for the same data. To solve it,
816 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
817 data or not. If it doesn't own data, then they will not destroyed by
819 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
820 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
821 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
822 create a double destruction of the same DocEntry's. So, to solve it,
823 the TagHT is simply cleared and the DicomDir* elements are destroyed.
824 * TODO : add an entry concerning memory leaks in the DicomDir
826 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
827 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
828 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
831 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
832 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
833 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
834 after it have been deleted
836 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
837 * FIX: src/* fix the doxygen warnings.
838 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
839 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
840 was erroneously defined with a size of 15 instead of 16. [many thanks
841 to Jean Michel Rouet for pointing out this bug].
843 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
844 1. Finish merging JMR patch for writting DICOM from scratch
845 2. Fix -hopefully- bug with MONOCHROME and space vs null character
846 3. Use const ref when possible
847 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
848 5. A few more comments
849 6. CreateUniqueUID can now be called without parameter"
851 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
852 * ENH: Slightly bigger patch:
853 1. Getting toward full integration of JMR patch for writting dicom from scratch
854 2. Update Test to test part of this patch: CreateUniqueUID
855 3. File was not close properly in gdcmDict
856 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
857 5. Use of const ref instead of copy (speed issue)
858 6. Remove temporary (duplicate) string in TranslateToKey
859 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
860 8. Do not repeat virtual in subclasses
861 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
863 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
864 * Apply first patch toward better string comparison when dealing with broken
865 DICOM files. Essentially the string could be padded with a space instead
866 of a null character as defined by standard
868 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
869 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
870 because never used... and in the same time, that's remove some memory leaks
872 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
873 * src/gdcmFile.cxx : now delete the PixelConvert instance.
874 * In examples and tests : change the type of image data variables from void*
875 to uint8_t*. Remmove all delete on image data variables
877 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
878 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
879 Verify the file pointer value before open the file, and if it's not null,
880 a verbose message is generated.
881 Close correctly the file when the file isn't considered dicom-like. The
882 correctly close is a call to CloseFile.
883 When closing the file pointer, test if its not null to close the file.
884 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
885 file. For an uncompressed image, the copied data correspond in the least
886 case to the image size (calculated) or the image size specified in the
887 header. A verbose is generated if these two size mismatch
889 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
890 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
891 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
892 break under windows (with msvc6 compilation).
894 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
895 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
896 compiling with MSVC6)
898 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
899 * Bugs fix for the Windows build with VC6
900 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
901 needed (only for projects required VTK). If the VTK is included in all
902 projects, there is conflicts with the jpeg lib of vtk when compiling the
903 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
904 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
905 when compiling the gdcm_wrap.cxx file (created by the compilation of the
907 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
908 (like it's already made for the cout use). Otherwise, conflict with the
911 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
912 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
914 - comments on the DicomDir::Method related usage added.
915 - now that we use the namespace gdcm, a lot of internal classes do
916 NOT need to be wrapped anymore.
917 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
918 DicomDir::Method) new example added.
920 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
921 * Improve string manipulation. I now inforce the notion of 'DicomString'
922 A DicomString can contain as many \0 as they want
923 and it is *always* of even length.
924 We only support odd length for very rare case.
925 And in the near future this should be removed.
927 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
928 * /binary_write/ gdcm source. Now even on big endian we are writting
929 little endian. This should -heopfully- fix some tests
931 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
932 * Now the dictionary is compiled into gdcm lib. This is a default
933 behavior, thus any dic file specified is picked before failback to
934 the one comiled into lib
936 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
937 * Change internals for gdcmDict. Don't use any 'new' any more.
938 This should definitely solve any leak problem, and we should be
939 as fast as before, as long as don't modify too much the dictionary.
941 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
942 * STYLE: ivars should start with a capital letter.
943 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
944 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
946 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
947 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
948 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
949 new 2004 dictionaries added (thanks to JPR).
950 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
951 * CLEANUP_ROUND (15) for gdcmPixelConvert
952 - RLEFrame::NumberFragments is now of type unsigned int
953 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
954 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
957 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
958 * Initial work in gathering all transfer syntax accessors. clearly
959 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
960 ivars, but only one transfersyntax (class) ivar with equivalent method on
963 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
964 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
965 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
966 discussed (plus I didn't like having a 2000 lines patch not commited)
968 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
969 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
970 * CLEANUP_ROUND (14) for gdcmPixelConvert
971 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
972 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
973 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
975 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
976 anymore and hence avoids storing a copy of PixelConvert::Decompressed
977 into File::Pixel_Data.
979 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
980 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
981 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
982 * CLEANUP_ROUND (13) for gdcmPixelConvert
983 Substituted File::ParsePixelData() with PixelConvert::Print() new
985 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
986 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
987 method to those classes.
988 - src/gdcmFile.[cxx|h]:
989 -- Added a ::Print() method.
990 -- PixelConverter is now a reference instead of a member.
991 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
992 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
994 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
995 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
996 collaboration diagram and inheritance diagram should be generated with
998 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
999 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1000 pointlessly wrapped (see
1001 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1002 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1003 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1004 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1005 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1006 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1007 -- File::Initialise: PixelConverter setup moved away to
1008 PixelConverter::GrabInformationsFromHeader()
1009 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1010 interpretation moved away to PixelConverter::BuildRGBImage()
1012 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1013 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1014 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1016 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1017 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1018 displayed on Win32 when a brutal abort() occurs (because of uncatched
1019 exception). See TODO new entry of this commit for more on this.
1020 * TODO added new entry.
1021 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1022 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1023 - HandleColor is no longer called from gdcmFile.cxx
1024 - gdcmPixelConvert.cxx clean up on method arguments and internal
1025 variable names for semantical coherence.
1027 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1028 * Finished lossless transition, not only do we now read all lossless jpeg
1029 images, without the need of the Cornwell lib, but we do read them properly now
1030 * To reduce code (well to avoid code duplication), I defined a common place
1031 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1032 redefine symbols. This is not perfect but this the best solution I found for a
1033 compilation time jpeg option.
1035 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1036 * Update jpeg ijg lib to support lossless jpeg implementation
1037 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1039 * Also added a special copyright for dcmtk since we use their bugfixes.
1042 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1043 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1044 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1045 matters, as stated in warning note at beginning of %include section).
1046 * src/gdcmDicomDir*.[cxx|h]: coding style
1047 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1048 * src/gdcmJpeg8.cxx: doxygen fix.
1049 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1050 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1051 from File:: to PixelConvert::.
1053 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1054 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1055 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1056 - more code moved away from File:: to PixelConvert::
1057 - fat setup of PixelConverter set in place in File::Initialise.
1059 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1060 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1061 namespace at the file system level. So now you should convert your examples
1063 gdcmHeader -> gdcm::Header
1064 It would be nice if people keep in mind to no open the namespace, since it
1065 allows compilation on broken plateform which were defining common symbol in
1066 the standart namespace (like LP, Unknown ...)
1068 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1069 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1070 The JPEG fragments are now parsed at the same stage than the RLE
1071 information. All code related to JPEG is now in gdcmPixelConvert:
1072 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1073 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1074 export a gdcmFile:: method. Those are simply global functions
1075 (for the time being this is better than having them attach to
1076 either gdcmFile:: or gdcmPixelConvert::).
1077 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1078 and stores the result in a gdcmJPEGFragmentsInfo.
1079 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1080 code (among other stuff) moved away from gdcmFile:; to
1083 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1084 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1085 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1086 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1087 clean up of RLE related code.
1088 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1089 - src/gdcmRLE.cxx removed
1090 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1091 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1092 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1093 * CLEANUP_ROUND (9) for gdcmPixelConvert
1094 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1095 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1096 away from gdcmFile:: to gdcmPixelConvert::.
1098 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1099 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1100 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1101 This is because Parse7Fe0 used to parse the pixels to compute the
1102 length. This task was passed over to FindDocEntryLengthOB() a long
1103 time ago, EXCEPT I had forgotten the OW case...
1104 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1105 we just recylce the code for parsing RLE fragments and computing
1107 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1108 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1109 with the retired Parse7Fe0().
1110 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1111 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1113 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1114 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1115 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1116 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1117 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1118 * CLEANUP_ROUND (4) for gdcmPixelConvert
1119 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1120 to return an unused length.
1122 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1123 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1124 this should be cleanner from the plane view. The iostream are erally a pain
1125 to use to do simple stuff.
1127 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1128 * Redo the compilation of the ijg jpeg library. Now only one source is
1129 necesseray. No need to rename file by hand what so ever. CMake handle the
1130 copying of the file within different directory, configure header file to
1131 modify some symbol. The only addition made to ijg wasd a mangle table so
1132 that symbol are different whether we are within 8bits or 12bits.
1134 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1135 * Added documentation of vtkgdcmReader on Website:
1136 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1137 with it's binary name).
1138 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1139 the Website to be more complete.
1140 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1141 doxygenated documentation.
1142 - Doc/DoxyVtkGdcmReaderExamples.txt added
1143 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1144 DoxyVtkGdmReaderExamples.html )
1145 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1146 * CLEANUP_ROUND (3) for gdcmPixelConvert
1147 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1149 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1150 * CLEANUP_ROUND (2) for gdcmPixelConvert
1151 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1153 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1154 * CLEANUP_ROUND for gdcmPixelConvert:
1155 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1156 - src/gdcmPixelStuff[h|cxx] removed
1157 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1158 - src/CMakeLists.txt changed accordingly
1159 * GDCMHOME clean up:
1160 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1161 gdcmVersion.py moved to newly created ATTIC related
1162 gdcmPython/SetupOldies/ directory.
1163 * Autotools clean up:
1164 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1165 - autogen.sh configure.in acinclude.m4 python.m4 removed
1167 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1168 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1169 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1170 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1172 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1173 * TODO updated with Mathieu suggestions. I proposed a template for
1174 describing TODO entries and used it for new entries.
1175 * Added Doc/Website/CodingStyle.html, Developpers.html,
1176 DeveloppersPython.html, GdcmDataCvs.html and
1177 DownloadVersion0_1.html, DownloadVersion0_3.html.
1178 * Some Doc/*.txt Doxygen files (which do not really concern the
1179 documentation itself, but the website) moved to html and
1180 placed in directory Doc/Website:
1181 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1182 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1183 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1184 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1185 * CMakeLists.txt changed accordingly.
1186 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1187 DeveloppersPython.html
1188 * INSTALL nows refers to Doc/Website/Installation.html
1190 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1191 * Added Doc/Website directory, that contains a first raw version
1194 2004-09-23 Jean-Pierre Roux
1195 * FIX In order not to be poluted any longer by casting problems,
1196 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1197 we can now delete[] it safely
1198 * VoidArea is now called BinArea (less confusing name),
1199 and all the methods called ...VoidArea... are now ... BinArea...
1200 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1202 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1203 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1204 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1205 up to the destructor of gdcmElementSet to clean up TagHt and it's
1208 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1209 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1210 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1212 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1213 * ENH: added some utility method that builds a flat dictionary
1214 holding all the Dicom entries contained in the recursive structure
1215 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1216 an example of usage.
1217 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1218 BuildFlatHashTable() that build a flat dictionary.
1219 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1220 gdcmDocument is now a friend of gdcmElementSet.
1221 - src/gdcmElementSet.cxx: clean up.
1222 - Example/FlatHashTablePrint.cxx added.
1223 - Example/CmakeLists.txt changed accordingly
1225 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1226 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1227 moved away from gdcmDocEntrySet (since this class is an abstract class
1228 acting like an interface). SQDepthLevel and BaseTagKey are now
1230 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1231 and associated accessors. Doxygenation of the class.
1232 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1234 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1235 Use SQDepthLevel accessor instead. ::Print() adapted.
1236 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1237 - src/gdcmDocument.cxx changed accordingly.
1239 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1240 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1241 - The following is the doxygen comment of the typedef declaration
1242 of gdcmTagKey in src/gdcmCommon.h:
1243 gdcmTagKey is made to old an "universal" (as in URL, Universal
1244 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1245 A dicom tag always has a group and an element, but a set of tags
1246 embeded in various (optionally nested) sequences and sharing
1247 the same group and element all share the same (group, element)
1248 "identifier". Hence the (group, element) cannot be used as an
1249 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1250 In order to construct a proper tag identifier (i.e. a key) we
1251 consider the following definition of a TagKey:
1252 - let Group, Element be the string representation of the
1253 group and element dicom tag members,
1254 - let ItemNumber be the string representation of the integer
1255 index of the considered item number of a sequence,
1256 Let the key of a tag embeded in a sequence, noted SeqTag, be
1258 /ItemNumber#Group|Element
1259 where "/", "#" and "|" are characters acting as separators.
1260 Then the general form of a gdcmTagKey is given by:
1261 Group|Element<SeqTag>
1262 where <SeqTag> means NO or many instances of SeqTag.
1263 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1266 but the gdcmTagKey of a tag "embeded" is the first item of
1267 a sequence, itself nested in the third item of a sequence is the
1269 0004|1220/2#0008|0082/0#0008|0090
1270 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1271 order to hold the new sequence compatible key. Previously, the
1272 GetKey() method would look in the underlying gdcmDictEntry.
1273 - src/gdcmDocEntry.cxx:
1274 -- constructor now copies the underlying DictEntry key, in the local
1276 -- ::Print: displays the member Key, instead of the (group, element).
1277 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1278 - src/gdcmDocEntrySet.h:xi
1279 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1280 -- now has a new BaseTagKey member.
1282 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1283 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1285 This poses the problem with the semantics of the following lines
1286 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1287 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1288 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1289 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1290 to the long FIXME note for what the problem is. Nevertheless in
1291 order to get things working the dicom dictionary was altered !
1292 Please fix things urgently...
1293 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1294 information), see above note on moving the member VoidArea. Nevertheless
1295 the following entries previously correctly set as US are now inproperly
1297 0028 1201 OW IMG Red Palette Color Lookup Table Data
1298 0028 1202 OW IMG Green Palette Color Lookup Table Data
1299 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1300 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1301 of gdcmDocEntry moved to gdcmSeqEntry.
1302 * src/gdcmSeqEntry.cxx: STYLE.
1304 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1305 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1307 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1308 * gdcmPython/testSuite.py: all the test suite in python is now moved
1309 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1310 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1311 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1313 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1314 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1315 to avoid inclusion recursion until STL is reached.
1316 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1317 mecanism. errno.h is not included in gdcm anymore.
1318 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1319 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1321 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1322 gdcmData/TestAllEntryVerifyReference.txt
1323 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1324 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1325 exception_on_error parameter.
1326 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1327 - vtk/vtkGdcmReader.cxx changed accordingly,
1328 - Example/*.cxx and Test/*.cxx changed accordingly.
1330 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1331 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1332 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1333 enable_sequences removed from gdcmHeader constructor and dependencies.
1334 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1335 * gdcmPython/demo/PrintHeader.py: dummy fix.
1336 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1337 skip_shadow removed from gdcmHeader constructor and dependencies.
1338 * Example/*.cxx and Test/*.cxx changed accordingly.
1340 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1341 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1342 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1344 2004-07-21 Jean-Pierre Roux
1345 * FIX Now, Parsing and Printing a DICOMDIR do work!
1346 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1348 2004-07-20 Jean-Pierre Roux
1349 * FIX Some brain damaged headers have Zero-Lenght fields
1350 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1352 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1353 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1354 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1355 variable (instance of gdcmDebug) by a definition macro, and the instance
1356 is now in static in the gdcmDebug class
1357 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1358 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1360 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1361 * WARNING: ctest now depends more tightly on gdcmData. You should
1362 check out gdcmData properly for things to run smoothly...
1363 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1364 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1365 we need the pixels not be loaded in order to use the ValEntry
1366 that displays position and size).
1367 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1368 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1369 be deprecated. If you have any doubts about the advantages of a
1370 modern scripting language (read Python) versus grass root C++ (i.e.
1371 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1372 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1373 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1374 Anyhow, consider documenting the gdcmData images in
1375 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1377 * Test/CMakeLists.txt:
1378 - now uses TestAllEntryVerify.cxx
1379 - specific comments on oldACR00001.ima (now renamed in gdcmData
1380 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1381 gdcmData/TestAllEntryVerifyReference.txt
1384 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1385 * src/*.[h|cxx] : typedef clean up
1386 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1387 - TagKey renamed to gdcmTagKey (for external usage)
1388 - VRKey renamed to gdcmVRKey (for external usage)
1389 - removal of typedef duplication.
1390 - Removed all unecessary inline keyword from class inline definitions.
1391 - Some method|function(void) declarations replaced with method|function().
1392 * src/jpeg/libijg12/jdhuff12.c:
1393 - printf polluting ctest removed.
1394 - TAB removal for comminting
1396 - TestAllReadCompareDicom.cxx: added a test that compares all the
1397 images in gdcmDataImages.h with corresponding images in
1398 gdcmData/BaselineDicom/. When baseline images are not present
1399 this test creates them.
1400 Note: we need to validate each reference image, but before that
1401 I'd like to rename them with a more explicit name...
1402 - CMakeLists.txt: changed accordingly.
1403 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1404 including each header needed).
1406 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1407 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1408 test suite to the Example directory. Are concerned:
1413 - TestWriteSimple.cxx
1414 * Test/CMakeLists.txt: added some comments on reasons for black listing
1415 image gdcmData/oldACR00001.ima
1417 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1418 * Test/CmakeList.txt: removed the following from black list (to be coherent
1419 with removal from gdcmData):
1420 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1421 - gdcm-MR-PHILIPS-16.dcm
1423 Added the following because after last cvs update, they cause
1424 ctest -R TestReadWriteReadCompare
1426 - gdcm-MR-SIEMENS-16-1.acr
1428 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1429 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1430 new comments in this file) we temporarily (sigh) move to a weaker
1432 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1433 we don't need to black list the following images anymore:
1434 - 8BitsUncompressedColor.dcm
1436 - US-PAL-8-10x-echo.dcm
1437 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1438 fixes and the beautified code ;-)
1439 This fixes the bug introduced in version 1.42 (when beautifying)
1440 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1441 Note: ctest was blind to this bug (this means we need to still
1442 improve the test suite). The bug could be detected by using
1443 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1445 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1446 and by displaying the (garbage) produced file temp.XDCM...
1448 2004-06-29 Jean-Pierre Roux
1449 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1450 - replace by uggly but working old code :-(
1451 A lot of things should be OK again.
1452 It's really urgent to have a test suite that *tests*,
1453 to prevent Frog's beautifying sessions to break all the stuff
1454 (twice, withing a fortnigh ...)
1456 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1457 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1458 redundancy) to added Test/TestReadWriteReadCompare.cxx
1459 * Test/CmakeList.txt: because the compare test of
1460 Test/TestReadWriteReadCompare.cxx fails, the following images are
1461 black listed: - 8BitsUncompressedColor.dcm
1463 - US-PAL-8-10x-echo.dcm
1464 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1465 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1466 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1467 and ad-hoc kludge. This kludge is now removed, and on encountering
1468 such an image (OB field brain damaged) we set errno. Then in
1469 ::FindDocLength() we "fix" the length as being ALL what remains
1470 in the file (until EOF). We then proceed, hoping for the best...
1471 This fixes a SegFault in ShowDicom when trying to write such an
1473 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1474 (because TestWriteRead breaks on it, after a non conformal commit?).
1475 ctest now runs properly, except for MakeDicomDir (which was always
1476 broken) and the Python related stuff (still not fixed).
1478 2004-06-24 Jean-Pierre Roux
1479 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1480 FIX : Test/TestReadWrite now iterates on all the file names
1481 (instead of infinite loop)
1482 ENH : Test/TestWriteRead now iterates on all the file names
1484 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1485 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1487 2004-06-24 Jean-Pierre Roux
1488 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1489 when SamplesPerPixel =3
1490 - now Write is no longer confused by
1491 'BitsAllocated = 12" and 'BitsStored=12"
1492 - "UN" value representation Elements are now written correctly
1493 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1494 ENH : - now gdcmHeader has its own Write methods
1495 (in order to split the job that has not to be done
1498 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1499 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1500 loop on the same image until memory went out.
1501 Note: this means we still have gobs of memory loss in PrintDocument
1502 * src/gdcmDocument.cxx: fixes problem on parsing on file
1503 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1505 2004-06-24 Jean-Pierre Roux
1506 FIX : Write - All the Sequences and Sequence Item are now written
1507 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1508 is added a the end, when necessary.
1509 - A lot of brain-damaged images, that were read correctly are
1510 now written correctly
1511 - length compatible BinEntry are now loaded correctly
1512 (even for odd groups)
1513 Note : only Explicit Value Representation was checked.
1514 (question : is implicit VR really necessary for gdcm ?)
1516 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1517 * DEVELOPPER: added a proposition of coding style.
1518 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1521 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1522 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1523 Use the gdcmDocEntry::Print() and Write() instead.
1524 * src/gdcmDocument.cxx: bug fix.
1526 2004-06-22 Jean-Pierre Roux
1527 FIX : gdcmDocument.cxx
1528 - Now we do recognize the JpegLossLess format (there was a misstyping in
1529 code 'beautyfication' :-(
1530 - Now we automaticaticaly load the Luts, if any
1532 2004-06-22 Jean-Pierre Roux
1533 In order : to write Sequences, whatever their imbrication level,
1534 : to allow user to create his own Sequences
1535 a lot of modif where necessary (adding, moving, or virtualising methods)
1537 WARNING : save your own sources *before* cvs up !
1540 ADD virtual void Write(FILE *fp, FileType filetype);
1543 ADD virtual void Write(FILE *fp, FileType filetype);
1544 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1547 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1548 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1549 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1550 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1551 ADD std::string GetEntryByName(TagName name);
1552 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1554 std::string vr = "unkn",
1555 std::string fourth = "unkn",
1556 std::string name = "unkn");
1557 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1558 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1559 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1560 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1561 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1562 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1563 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1564 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1567 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1568 ADD virtual std::string GetEntryByName (TagName tagName);
1569 ADD virtual std::string GetEntryVRByName (TagName tagName);
1570 REM virtual bool Write(FILE *, FileType);
1571 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1572 FILE *_fp, FileType type);
1573 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1574 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1575 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1576 REM virtual std::string GetEntryByName (std::string tagName);
1577 REM virtual std::string GetEntryVRByName (std::string tagName);
1578 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1579 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1580 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1582 std::string vr = "unkn",
1583 std::string fourth = "unkn",
1584 std::string name = "unkn");
1585 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1586 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1587 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1588 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1591 ADD virtual void Write(FILE *fp, FileType filetype);
1594 ADD virtual void Write(FILE *fp,FileType filetype);
1597 ADD virtual void Write(FILE *fp, FileType filetype);
1598 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1599 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1600 REM std::string GetEntryByName(TagName name);
1603 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1605 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1606 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1607 The default constructor invoked by the line
1608 gdcmHeader *f1 = new gdcmHeader( header );
1609 was gdcmHeader::gdcmHeader(bool) instead of the expected
1610 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1611 Hence the parsing wasn't executed... See also below.
1612 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1613 as explicit constructor didn't do the trick to fix the above problem.
1614 Could anyone explain why ?
1615 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1616 properly calls gdcmValEntry::Print() (that was weed out from
1617 code related to gdcmBinEntry).
1619 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1620 * In order to fix memory leaks:
1621 - Test/TestWriteSimple.cxx: added cleaning of free store through
1623 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1624 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1625 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1626 (through the call to ::AddDicomDirMeta()) or the destructor
1627 would crash when deleting uninitialized ::metaElems].
1628 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1629 - src/gdcmDocument.cxx:
1630 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1631 from dynamic stores.
1632 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1633 was causing memory leaks.
1634 - src/gdcmSQItem.cxx:
1635 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1636 cleanly handled with polymophism: sorry but my milage is low).
1637 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1638 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1639 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1640 This avoids SegFaulting.
1641 - src/gdcmSQItem.h: coding style.
1643 - Test/TestWriteSimple still severely sucks. The output image content
1644 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1645 damaged when displayed with vtkgdcmViewer.
1646 - on memory leaks: TestWriteSimple leaks really less (see entry
1647 of 2004-06-18 in Changelog file for the call to valgrind).
1648 - on segfaults: ctest now passes all the tests but one (no more
1650 * Erroneous leading white fix:
1651 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1652 white[s] (as opposed to from >> xxx, that removes it [them].
1653 - src/gdcmTS.cxx: ditto.
1654 - gdcmPython/testSuite.py: dirty related kludge removed.
1655 * src/*: remaining references to gdcmParser removed.
1656 * src/*[cxx|h]: added copy[way]left header.
1659 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1660 * In order to fix writing of dicom files:
1661 - Test/TestWriteSimple.cxx: a simpler example of writing.
1662 - Test/CMakeLists.txt changed accordingly.
1663 - src/gdcmDocument.cxx:
1664 -- The destructor now recursilvely removes potential sequences.
1665 -- Bug fix in ::IsJPEG2000()
1666 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1667 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1669 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1670 to only declared) and build on top of
1671 ::GetDocEntryByNumber(guint16, guint16).
1672 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1673 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1674 for usage in destructor and treatement of promotion in
1675 ::ReplaceOrCreateByNumber().
1676 - src/gdcmSQItem.cxx: destructor should better handle his job.
1677 Test/TestWriteSimple now runs (or at least it DOES something).
1678 * We can now start hutting memory links. A good starting point is:
1679 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1680 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1681 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1683 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1684 * Valgrind note: after Mathieu Malaterre teached me how to read
1685 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1687 Using gcc, you can force the STL to use malloc and to free memory as
1688 soon as possible by globally disabling memory caching.
1689 With 3.2.2 and later, you should export the environment variable
1690 GLIBCPP_FORCE_NEW before running your program.
1691 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1692 simply vanish (it is still not clear to me, whether this means that
1693 STL std::string leaks or if valgrind believes it leaks...).
1694 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1695 running bin/gdcmTests makeDicomDir):
1696 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1697 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1699 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1700 SegFaulting (I drowned in DicomDir related code when trying to
1701 understand why the list is empty...).
1702 * src/gdcmDocument.h: first BSD license header try.
1703 * Doc/License.txt added.
1705 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1706 * src/gdcmDocument.[h|cxx]:
1707 - Clean up of the Transfer related predicates. They are now all based
1708 on new method isGivenTransferSyntax, that (should) handle properly
1709 the padding problem.
1710 - general clean up, simplification, and coding style.
1711 - Specific clean up of Parse7FE0() (umproperly named actually).
1712 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1714 2004-06-14 Jean-Pierre Roux
1716 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1717 - fix the display of SQItem ordinal number
1718 - add the GetSQItemByOrdinalNumber method
1719 - remove some useless never written private methods
1721 2004-06-14 Jean-Pierre Roux
1723 - adding a constructor taking a gdcmDocEntry as an input param
1724 - ReplaceOrCreateByNumber now returns :
1725 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1726 a gdcmValEntry * if a string value is passed as a param
1728 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1729 according to the param type (no longer sets a gdcmDocEntry)
1730 - GetValEntryByNumber, GetBinEntryByNumber added
1731 - NewValEntryByNumber and NewBinEntryByNumber added
1733 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1735 - GetSQItemNumber and SetSQItemNumber added, to provide
1736 a (relative) Item identier inside a given Sequence
1737 \warning : some pb remaining around this number
1739 - AddEntry now takes the Item Number as a param
1741 - adding a constructor taking a gdcmDocEntry as an input param
1743 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1744 * Memory leak hunt with the following command:
1745 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1746 --show-reachable=yes gdcmTests PrintDocument
1747 It looks like many (all?) leaks are due to the STL (or a bad usage
1748 of the STL. The lines producing the leaks now have a comment with
1749 a "MEMORY LEAK" tag: you can retrieve them with
1750 grep "MEMORY LEAK" src/*
1751 Here are two typical examples which I can't help fixing:
1756 char * test = "babo";
1757 name = test; //// <--- valgrind detects 960 bytes lost in
1758 //// call to std::string::operator=(char const*)
1759 name.clear(); //// Doesn't help !
1767 std::cout << "Type a bunch of characters followed by RETURN: ";
1768 getline(std::cin, line); //// <--- valgrind dectects a loss
1769 //// of 1320 bytes in call to
1770 /// std::basic_istream<>& std::getline<>
1776 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1777 * src/gdcmHeader.[cxx|h]:
1778 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1779 and related, moved away to gdcmDocument.
1780 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1781 the corresponding protected accessors of inherited class
1782 gdcmDocument, removed ! As a consequence gdcmFile had to be
1783 declared friend of class gdcmDocument (see below).
1784 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1785 - Clean up of undefined or unused methods.
1786 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1787 account the changes to gdcmHeader.h).
1788 * src/gdcmDocument.h:
1789 - gdcmFile is now a friend class (in order to take into account the
1790 changes to gdcmHeader.h).
1791 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1792 (see changes to gdcmHeader.h).
1793 - Accessors (reading on the form GetEntry*) are now public.
1794 - Clean up of undefined or unused methods.
1795 * src/gdcmDocument.cxx:
1796 - adaptation to changes to gdcmDocument.h
1797 - ::OpenFile now writes a verbose message when file cannot be opened.
1798 - some std::string properly set to VRKey
1799 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1800 references to gdcmDocument.
1801 * Test/TestFindTags.cxx: changed accordingly to above changes.
1802 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1803 cvs repository gdcmData.
1805 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1806 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1807 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1808 conflicts with gdcmValEntry::voidArea.
1809 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1810 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1811 Value representation between StringRepresentable and BinaryRepresentable.
1812 * src/gdcmDocument.cxx:
1813 - method ParseDES: proper indentation restored and usage of
1814 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1815 - method LoadDocEntry: the fingerprint left in the SetValue() of
1816 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1817 removed. Reverting to previous code segment with the proper
1818 dynamic_cast< gdcmValEntry* >.
1819 Note: this was (partially) breaking the python test suite
1820 (gdcmPython/testSuite.py) that made usage of the above
1821 fingerprint to check presence of "Pixel Data".
1822 * src/gdcmDocEntry.h: coding style.
1823 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1824 now taken into account.
1825 * gdcmPython/gdcm.i: adaptation to the new internal representation
1826 of gdcm (exit gdcmParser, hello gdcmDocument).
1827 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1829 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1830 anymore, but instead prints the loaded Python dictionary.
1831 * .... alas, the python testSuite is still broken.
1833 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1834 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1836 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1837 * src/gdcmUtil.h : export methods
1839 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1840 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1842 * Initial addition of automatic python testing
1843 * Initial addition of automatic image comparison
1845 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1846 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1847 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1849 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1850 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1851 * Test/ShowDicom.cxx : bug fix for msvc compilation
1852 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1854 2004-05-04 Jean-Pierre Roux
1855 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1856 new concepts (and new classes) :
1857 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1858 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1859 - Sequence Doc Entries (gdcmSeqEntries)
1860 a Sequence is composed of Items.
1861 Each item is a set of Doc Entries (this is recursive)
1862 The non uniqueness of the 'Dicom tag' is due to this recursivity
1863 (never taken into account)
1864 Our unability to add a new 'entry' in the header
1865 at the proper location (neither in the H-Table (map or multimap),
1866 nor in the Chained List is also due to this recursivity.
1867 Don't try, right now, to use/modify/compile these new sources :
1868 nothing is finished.
1869 We just commit all the stuff, 'as is', in order not to loose it.
1871 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1872 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1874 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1875 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1876 file prefix (SetFilePrefix)
1878 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1879 * Add a new test: ShowDicom, for now this is just the c++ version of
1880 checkRead.sh, later it will be able to compare the image read against a
1882 * Replace the DEBUG on the stack with a global entry in cmake interface:
1883 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1885 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1886 * Add an example subdir, with a real example on how to read + write a
1889 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1890 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1891 * Doc/CMakeLists.txt: the main page is now properly differentiated
1892 between the developper and user version.
1893 * Doc/doxygen.config.in: dropped search related obsolete flags
1894 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1896 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1897 * DEVELOPPER: added some helpfull comments for compile/test/install
1900 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1901 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1902 src directory, now generated in the build dir.
1903 2. Tests as mentionned smarter
1905 4. Add a new method in gdcmDict that return the PubDict by name
1906 this is interesting for 3rd party lib like ITK,
1907 where we could set the institution name / patient name...
1909 * ENH: 1. Now the test suite is working for real
1910 2. All binaries are now output in the gdcm-bin directory
1911 (this was not true before)
1913 2004-04-28 Jean-Pierre Roux
1914 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1915 SeQuence indented printing of Dicom Header.
1916 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1917 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1918 Computation of SQDepthLevel is now part of gdcmHeader constructor
1919 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1920 tree-like structure of a Dicom Header.
1921 * FIX Test code cleaning
1923 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1924 * ENH: Adding automatic testing
1925 1. Need a DartConfig.cmake to submit to public
1926 2. Add a test driver gdcmTest.cxx
1927 3. gdcmTestMain, an helper for the main test driver gdcmTest
1928 4. Files in Test don't have a main anymore, this becomes interesting
1929 when we add more and more tests, thus dsw don't have to load
1931 * ENH: Adding a GDCM_DATA_ROOT for testing
1932 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1933 one file instead of seven + some small cleanup
1935 2004-04-22 Jean-Pierre Roux
1936 * ENH Minor changes to the Print() methods.
1937 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1938 Header printing. Example given with :
1939 > PrintHeader fileName 2 new
1940 (SQ based tree-like structure still to be done for the Header ...)
1942 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1943 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1944 1. I have added some unsigned where needed
1945 2. Some function parameter not used -> (void)
1946 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1947 4. g++ don't like character '\' in comment
1948 5. #define jpeg_create_decompress jCreaDecompress
1949 this really need to be fixed
1950 6. virtualize destructor of gdcmObject ... leakage
1951 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1952 this also really need to be fixed
1953 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1954 remove compression file
1955 (as we only do decompression, right ?)
1956 * ENH: Change malloc/calloc/free with c++ equivalent
1958 2004-04-21 Jean-Pierre Roux
1959 * FIX gdcmHeaderHelper::GetXSpacing
1960 when a single value is found (bug ?), xpacing is now
1961 defaulted to yspacing
1963 2004-04-19 Jean-Pierre Roux
1964 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1965 * ENH add parameters :
1966 bool exception_on_error = false,
1967 bool enable_sequences = false,
1968 bool ignore_shadow = false
1969 to the gdcmFile constructors to be full gdcmParser compliant
1970 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1971 to allow reading of PAPYRUS 3.0 files
1973 2004-04-06 Jean-Pierre Roux
1974 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1976 2004-04-02 Jean-Pierre Roux
1977 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1978 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1979 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1981 2004-03-30 Jean-Pierre Roux
1982 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1983 for ACR file, written out as DICOM files (hope so...)
1985 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1986 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1987 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1988 moved to base class gdcmParser and only the specialisation is kept
1990 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1991 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1992 already does the job.
1993 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1994 (to be consistent with gdcmParser::WriteEntries).
1996 2004-03-30 Benoit Regrain
1997 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1998 upate of the object's instance. It's passed to 2 in the unfavorable
1999 case : one in the ExecuteInformation, one in the ExecuteData
2001 2004-03-29 Jean-Pierre Roux
2002 * ENH : Check on file type to be written moved
2003 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2004 * FIX : gdcmObject::ResetBoundaries now stops properly
2005 when end-of-list is reached
2006 : gdcmVersion modified (as Benoit Regrain asked)
2008 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2009 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2010 * src/gdcmUtil.cxx: added forgotten iostream include.
2011 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2012 equivalent to ExplicitVR in existing code).
2014 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2015 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2016 now contains all the gdcmGlobal related code.
2017 * minor coding style and doxygenation changes.
2019 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2020 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2021 now contains all the Debug related code.
2022 * minor clean-up of includes in src/*.cxx
2023 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2024 CreateCleanString) removed.
2025 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2026 * Doc/DoxyMainPageUser.txt added.
2027 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2028 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2029 src/gdcmDirList.cxx)
2031 2004-03-24 Jean-Pierre Roux
2032 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2034 2004-03-23 Jean-Pierre Roux
2035 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2036 big endian made volumes
2037 * ENH Now gdcmParser constructor and destructor are protected to forbid
2038 end user to instanciate class gdcmParser
2039 (only gdcmHeader and gdcmDicomDir are meaningfull)
2041 2004-03-22 Benoit Regrain
2042 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2043 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2044 gdcmSerie to gdcmDicomDirSerie
2046 2004-03-19 Jean-Pierre Roux
2047 * ENH Now the tree-like structure describing a DICOMDIR comming from
2048 an already existing DICOMDIR file is consistent with
2049 the home-made tree-like structure build ex-nihilo
2050 or build from the files held (recursively) in a Directory
2051 functions gdcmDicomDir::CheckBoundaries()
2052 gdcmObject::SetBoundaries() added
2054 2004-03-17 Jean-Pierre Roux
2055 * REM (Eric Boix bug) : removal of meaningless
2056 gdcmDicomDirImage::NewImage function.
2057 * FIX now file names and directory name are written properly in the
2059 * FIX now gdcmDicomDir constructor may be call without any trick
2062 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2063 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2064 of gdcmDicomDirImage::NewImage as empty function.
2066 2004-02-28 Jean-Pierre Roux
2067 * ENH add gdcmDicomDir:NewPatient
2068 add gdcmDicomDirPatient:NewStudy
2069 add gdcmDicomDirStudy:NewSerie
2070 add gdcmDicomDirSerie:NewImage
2071 to allow making gdcDicomDir object.
2072 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2073 (as opposite to the gdcmHeader chained list)
2075 2004-02-11 Benoit Regrain
2076 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2077 when using from python
2079 2004-02-10 Benoit Regrain
2080 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2081 * FIX : in gdcmDicomDir when the directory is empty
2082 * ENH : add callback and methods to get the progression of dicomDir
2085 2004-02-06 Jean-Pierre Roux
2086 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2087 - GDCM_META added to gdcmDicomDirType
2088 - class gdcmMeta created
2089 * ENH : - A brief summary is now displayed at the beginning of
2090 'testDicomDir' to help disaster magnitude estimation
2091 * REM : Now useless Test/explDICOMDIR.cxx
2093 2004-02-05 Benoit Regrain
2094 * ENH : add methods in gdcmObject to get the hash table or the list of
2096 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2097 * FIX : wrapping python for TagHeaderEntryHT
2099 2004-02-04 Benoit Regrain
2100 * FIX : even length for some strings when writting the dicom dir
2101 * FIX : sort the images in the dicom dir
2102 * FIX : Bug fix for python use of dicom dir
2103 * ADD : a python demo
2105 2004-02-04 Jean-Pierre Roux
2106 * FIX : Final solution (?) for icone embedded images
2107 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2108 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2109 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2110 gdcmData/gdcm-MR-SIEMENS-16.acr1
2111 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2112 to make full checking easier
2114 2004-02-04 Benoit Regrain
2115 * FIX : WriteEntries : coding style & logic in parameters
2116 * FIX : Set the elements to create the DicomDir in a dictionary file
2118 2004-02-03 Benoit Regrain
2119 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2120 * gdcmDicomDir : add the load of directory
2121 * Bug fix and print add-on
2123 2004-02-03 Jean-Pierre Roux
2124 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2125 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2126 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2127 * FIX gdcmParser.cxx : 'group length' elements are now considered
2128 as integers, even for shadow groups, when file is Implicit VR
2130 2004-02-02 Jean-Pierre Roux
2131 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2133 of the last synonym :-(
2134 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2136 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2137 * FIX taking into account the possible 7fe0,0010 multiplicity
2138 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2139 to allow removal of references to 7fe0,0010, to deal with
2140 ACR-NEMA images, when 0028,0200 is meaningfull
2142 2004-01-31 Jean-Pierre Roux
2143 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2144 no longer writes 'Un' on disk
2145 * FIX SQ elements with actual length are now dealt with corectly
2146 * FIX gdcmFile::WriteBase make the difference, for color images, between
2147 the length (for Palette expanded images)
2148 and Raw Length (non expanded image + Palette)
2149 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2150 (that broke Write). Replaced by UL.
2151 Aware user will reload the field if he
2152 thinks it's necesssary
2154 2004-01-30 Jean-Pierre Roux
2155 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2156 when 'dirty Acr' is found, to be compliant with the new
2157 IsReadable() methods.
2159 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2160 (no DOUBLE images in kosher DICOM,
2161 but so usefull for people that miss them ;-)
2163 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2164 DICOMDIR related utilities (not checked as Windoze compliant)
2166 2004-01-28 Jean-Pierre Roux
2167 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2169 2004-01-27 Jean-Pierre Roux
2170 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2171 to allow skipping the shadow elements, to save memory space.
2172 The TRUE value for this param has to be used
2173 with a FALSE value for the 'enable_sequence' param.
2174 ('public elements' may be embedded in 'shadow Sequences')
2175 * gdcmHeader methods now deal with 'embedded icones images' in the header
2176 (even when an 'icone image sequence' is announced by the
2177 element (0x0088,0x0200), but there is NO icone at all ...
2179 * gdcmHeader sometimes Image Location value doesn't follow
2180 the supposed processor endianity (see gdcmData/cr172241.dcm).
2183 * gdcmHeader add the method
2184 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2185 to get *all* the Header Entries with the same tag.
2186 GetHeaderEntrySameName is probabely *useless*
2187 (no meaning : Name is *not* an identifier within the Dictionary)
2189 2004-01-26 Benoit Regrain
2190 * Bug fix in the print of hexadecimal representations. Remove long fields
2191 in the print and add a third level of print to print them
2193 2004-01-23 Benoit Regrain
2194 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2195 * Bug fix on test suite after remove the strip made on not string fields
2196 * Split the IsReadable method between gdcmParser which test that the file
2197 is dicom and gdcmHeader which test that it's an image file
2199 2004-01-22 Benoit Regrain
2200 * DicomDir : clean code, add methods, set variables in protected or private
2201 * gdcmUtil : bug fix for the clean string method
2203 2004-01-19 Benoit Regrain
2204 * Add the use of shadow dictionaries
2205 * bug fix and coding style
2207 2004-01-19 Benoit Regrain
2208 * src/gdcmFile.cxx : bug fix concerning the close of file
2209 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2210 * Add the update of header entries using the shadow library
2212 2004-01-19 Benoit Regrain
2213 * removal of file gdcmHeader2.cxx
2214 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2215 inheriting from gdcmParser. This split is to prepare the integration
2216 of dicom dir parsing
2217 * bug fix under python
2219 2004-01-16 Jean-Pierre Roux
2220 * REM removal of class gdcmHeaderEntrySet
2221 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2222 * ADD add file gdcmHeader2.cxx
2223 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2225 2004-01-15 Benoit Regrain
2226 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2227 entries created while parsing the header. Thus, they will be destroyed
2228 when the gdcmDictSet will be destroyed
2229 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2232 2004-01-15 Benoit Regrain
2233 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2234 made a fatal error because of the memory release at the end of program.
2235 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2236 some memory and vtk seems to have some problems with that.
2237 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2239 2004-01-14 Benoit Regrain
2240 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2241 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2242 * src/*.[h|cxx] : make changes due to class name changes
2243 * gdcmPython/demo/*.py : bug fix due to method names
2245 2004-01-13 Benoit Regrain
2246 * src/*.[h|cxx] : coding style
2247 * vtk/*.[h|cxx] : coding style
2249 2004-01-13 Benoit Regrain
2250 * gdcmPython/testSuite.py : test the readable flag of file for tests
2251 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2252 It's lied to the stl compilation by MSVC (windows, always windows...)
2253 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2255 2004-01-12 Benoit Regrain
2256 * src/*.h : add comments
2257 * src/gdcmDictSet.h : set the method BuildDictPath in public
2258 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2259 directly setted in the source code
2260 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2263 2004-01-09 Benoit Regrain
2264 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2265 * setup.py : use a reference to gdcmVERSION
2267 2004-01-07 Benoit Regrain
2268 * Modification to compile with the distutils.
2271 2003-12-10 Benoit Regrain
2272 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2273 can use a gdcmHeaderHelper to load data
2274 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2275 made in the source code
2277 2003-12-10 Benoit Regrain
2278 * Update Windows projects and .cvsignore files
2280 2003-11-12 Jean-Pierre Roux
2281 * ENH gdcmHeader constructor has one more parameter (default value : false)
2282 that allows the user to 'go inside' the SeQuences only
2284 gdcmElValSet:Print takes it into account
2286 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2287 * ENH: Update gdcmPython/CMakeLists
2288 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2289 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2291 2003-11-10 Jean-Pierre Roux
2292 * FIX : gdcmHeader::LoadElements is now based
2293 on the ListTag listElem member,
2294 not longer on the TagElValueHT tagHt member
2295 * ENH : PrintPubElVal shows (temporarily) both results,
2296 with the tagHt member and the listElem member.
2297 (it's easier to 'see' the problems when using Printheader)
2299 * FIX : old private member LgrElem is now splitted into
2300 ReadLength : Length actually found on disk (updated only
2301 if bug fixing is necessary), for internal
2303 UsableLength : Updated by FixFoundLength, to fix a bug
2304 or to allow Parser going on.
2305 Will allow to re-write a kosher header when a SeQuence
2306 with a length (not 0000) is found
2307 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2308 because gdcmElValSet::Add does not update ListElem
2311 2003-11-07 Jean-Pierre Roux
2312 * FIX misstyping in Transfert Syntax name table
2313 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2314 when they have an actual length (not 0000 nor FFFFF)
2315 (Nobody should care of it, but DICOMDIR explorers)
2317 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2318 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2320 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2321 * ENH: vtkGdcmReader now supports LUT !
2322 (vtkgdcmViewer for now is not able to use them though)
2324 2003-11-05 Jean-Pierre Roux
2325 * in testSuite.py : new files names for checking the package
2326 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2327 that returns the pixel area size to the *aware* (vtk) user
2328 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2330 2003-11-05 Benoit Regrain
2331 * in testSuite.py : Modify the rules for checking the paths
2332 : Explicit error messages
2333 * in __init__.py : Related modif
2335 2003-11-03 Jean-Pierre Roux
2336 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2337 to be used by aware (vtk) users that want to manage
2338 LUT (and no to turn the PALETTE image into an RGB pixels one)
2339 * GetPixelType now returns 8U for 24 Bits images
2340 (vtkGdcmReader compliant)
2342 2003-10-31 Jean-Pierre Roux
2343 * Removal of *all* gdcmData images and add them again
2344 in order to loose the 'history' of un-anonymised images
2346 2003-10-31 Jean-Pierre Roux
2347 * RMV : removal of useless jBitsInJsample.h
2348 for both 8 and 12 Bits JPEG Lossy Libraries
2350 2003-10-31 Jean-Pierre Roux
2351 * ENH : Add the functions gdcmFile::GetImageDataRaw
2352 gdcmFile::GetImageDataIntoVectorRaw
2353 that act as GetImageData and GetImageDataIntoVector
2354 except the making of an RGB Plane from Gray Plane + LUT
2355 Intended to aware (vtk) users who know how to manage
2358 GetLUTRGBA return a R,G,B,A LUT if any
2359 lgrTotaleRaw gives the 'Raw' length
2360 GetImageDataRaw returns the gray Plane
2361 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2362 (They stay Grey, just like with other Dicom viewers :-(
2364 2003-10-30 Jean-Pierre Roux
2365 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2367 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2368 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2369 being coherents dicom files.
2371 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2372 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2374 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2375 * ENH: Two steps is necessary to please VC++ compiler...
2376 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2377 * ENH: Add include dir to medcon lib
2378 * FIX: only one function is being exported for now !
2379 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2381 2003-10-29 Jean-Pierre Roux
2382 * adding gdcmHeader::GetLUTRGBA
2383 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2384 --> Mathieu, the modif u're waiting for is not yet committed
2385 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2387 2003-10-27 Jean-Pierre Roux
2388 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2389 00191113.dcm DermaColorLossLess.dcm
2390 MxTwinLossLess.dcm RadBWLossLess.dcm
2391 * ENH: For version prior to vtkImageViewer2 -r 1.19
2392 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2394 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2395 * Removal of ido stuff in CMakeLists.txt
2397 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2398 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2399 * FIX: remove a call to ->Modified ... see comments
2400 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2402 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2403 * FIX: Problem with path for libvtkgdcmPython
2404 * ENH: Try adding a search script for python site-package
2405 * RMV: Remove some file from medcon lib that are not necessary
2406 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2407 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2408 * FIX: More pragma disable fro VC++,
2409 I don't think I break something as it is also disable in VTK/ITK.
2410 But it fasten debug compilation time.
2412 2003-10-23 Jean-Pierre Roux
2413 * gdcm now deals with 16 Bits Run Length Encoded images
2414 (they are compressed as 2 planes images,
2415 one for the high Bytes, the other for low Bytes)
2417 2003-10-22 Jean-Pierre Roux
2418 * Now CheckRead takes into account :
2419 - the bugged 'Leonardo' Siemens images
2420 - the XA images, sent thru the burning VPRO station
2421 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2424 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2425 * FIX: When copying a Makefile.am to CMakeLists.txt
2426 one should remove the '\'
2428 2003-10-22 Jean-Pierre Roux
2429 * in gdcmData adding a bugged 'Leonardo' Siemens image
2430 (wrong lengths in header)
2431 OK with gdcm, KO with the other viewers :-)
2432 * add a GE dlx XA image, thru the VEPRO burning station
2435 2003-10-21 Jean-Pierre Roux
2436 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2437 for a brutal checking of vtkgdcmViewer compliance
2439 2003-10-21 Jean-Pierre Roux
2440 * add the files for 'xmedcon' Jpeg Lossless library
2441 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2443 2003-10-21 Jean-Pierre Roux
2444 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2446 2003-10-21 Jean-Pierre Roux
2447 * garbage Siemens 'Leonardo' images dealt with
2448 (the patch is easy to remove)
2449 * cosmetic changes to avoid warnings
2451 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2452 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2453 no need to press 'r' now.
2455 2003-10-20 Jean-Pierre Roux
2456 * upgrade of checkRead.sh checkWrite.sh according
2457 to new Jpeg Lossless decompressor
2458 * add US.3405.1.dcm, a genuine RGB medical file ...
2459 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2460 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2462 2003-10-15 Jean-Pierre Roux
2463 * general anonymisation in gdcmData
2464 * adding the 'color files' from
2465 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2466 * adding some well knowed bugged-header images
2467 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2468 waiting for their inclusion in Python testsuite
2470 2003-10-15 Jean-Pierre Roux
2471 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2472 no longer seg faults when file is not found
2474 2003-10-14 Jean-Pierre Roux
2475 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2478 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2479 * TODO: *.in file to genereate a UseGDCM later
2481 2003-10-14 Jean-Pierre Roux
2482 * Some supposed-to-be Dicom Images have no preamble.
2483 OpenFile takes it into account
2484 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2485 * Missing elements added in dicomV3.dic
2486 (just to be affraid : have a look at
2487 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2488 and do it again next year ;->
2490 2003-10-13 Jean-Pierre Roux
2491 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2492 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2493 But there are NOT. It's fixed !
2495 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2496 * FIX: "jpeglib.h" was not found on VC++
2497 * FIX: vtkgdcm was not being installed
2499 2003-10-10 Jean-Pierre Roux
2500 * ENH : OpenFile closes the file if it *really* doesn't look like
2501 an ACR-NEMA / DICOM one.
2502 * FIX : testWrite no longer writes an empty file if the source file
2503 is not gdcm Readable
2504 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2507 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2508 * FIX: CMake generate now documentation
2509 * ENH: out of source doc build !
2510 * ENH: Generate both user and dev documentation
2511 * ENH: Should work on windows too
2512 * ENH: Only one doxygen config.in file is needed
2513 * FIX: make install should be ok now on ùnix plateform
2514 * FIX: PATH to dictionary was wrong (missing /)
2515 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2517 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2518 * vtkGdcmReader is now able to read rgb dicom file.
2519 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2520 * added a gdcmViewer to vtk test, use mouse to control
2521 window level & window width
2523 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2524 * CMake-ification of gdcm, we have now two build system
2525 * FIX: on cygwin Wsock32 doesn't exist
2526 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2528 2003-10-06 Emanuel Ollart
2529 * FIX : compilation process wad broken.
2530 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2532 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2533 * change gdcmViewer -> vtkgdcmViewer
2534 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2536 2003-10-06 Jean-Pierre Roux
2537 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2538 ( e.g : well known GE images with a wrong elem length,
2539 : Philips MRI Images with a wrong Huffman table)
2540 * still to be done : allow the reading of bugged LEONARDO Siemens images
2542 2003-10-03 Jean-Pierre Roux
2543 * Odd length strings are padded with '\0' (not with spaces,
2544 to remain compliant with already defined strings,
2545 like Transfert Syntax UID and others)
2547 2003-10-03 Jean-Pierre Roux
2548 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2549 to allow displaying RGB images (not only by affim ;-)
2551 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2552 * vtkGdcmReader is now able to read rgb dicom file.
2553 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2555 2003-10-03 Jean-Pierre Roux
2556 * A few nasty patches to allow the reading of a lot of nasty images
2557 ( e.g : well known GE images with a wrong elem length,
2558 : Philips MRI Images with a wrong Huffman table)
2559 * still to be done : allow the reading of bugged LEONARDO Siemens images
2561 2003-10-03 Jean-Pierre Roux
2562 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2564 2003-10-03 Jean-Pierre Roux
2565 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2566 to allow displaying RGB images (not only by affim ;-)
2568 2003-10-03 Jean-Pierre Roux
2569 * gdcmFile::GetImageDataIntoVector now
2570 - deals with MultiFrames MultiFragments Run Length Encoded files
2571 - deals with YcBcR (YBR_FULL) files
2572 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2573 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2575 (no sample found :-(
2577 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2578 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2579 Two reasons: - clear things
2580 - third parties acces gdcm through header files, so won't
2581 suffer anymore VC++ complains
2583 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2584 * add argv[1] in testvtkGdcmReader.cxx
2587 2003-09-24 Jean-Pierre Roux
2588 * The lines are now eigthy characters long.for
2589 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2591 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2592 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2593 char* to std::string. Thus, the use of strdup becomes useless. (see
2594 previous commis of Malaterre)
2595 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2596 before the last Malaterre's commit.
2598 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2599 * This commit should fix the Debug building under VC++, the problem
2600 was mainly a mixture of debug and release lib being loaded at startup.
2601 * I also remove a depency to a specific C function: strdup. Because I had
2602 to force the link to msvcrtd (whereas strdup is in libc).
2604 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2605 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2606 located in the gdcmCommon.h file. All use of reference of tha has been
2607 changed to now use the variable GDCM_UNFOUND.
2609 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2611 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2612 Dicom dictionary. The test suite can now be run again. Note:
2613 I'm note very happy with the " (RET)" changes. I believe this
2614 RETAINED comment should be dropped when parsing the dictionary.
2615 - PACKAGER corrected
2617 - AUTHORS updated and now in alphabetical order
2618 * Makefile.am now exports gdcm.dsw for Windoze users.
2620 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2621 * cygwin complains about missing std:: in subdir Test/
2623 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2624 * remove some methods that are now in gdcmHeaderHelper
2626 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2627 * vtkGdcmReader set spacing and origin correctly
2629 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2630 * Fix a few delete/delete[] mismatch
2632 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2633 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2634 interpretation to data given by gdcmHeader. For instance there are
2635 heuristics to get informations (look at different places).
2636 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2637 sorting DICOM images based on different strategies.
2638 * modified Makefiles accordingly.
2640 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2641 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2642 when building in debug mode
2643 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2644 src/win32/gdcmdll.dsp
2645 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2647 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2648 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2651 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2652 * src/win32/libgdcmjpeg12.dsp was not dos format
2653 * src/win32/libgdcmjpeg12.dsp :
2654 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2655 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2657 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2658 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2660 * src/gdcmFile.cxx : bug fix in affectation type
2661 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2662 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2663 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2664 symbols... future problem ?
2666 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2667 * src/win32/libgdcmijpeg12.dsp was missing
2668 * modified gdcm.dsw accordingly
2670 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2671 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2673 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2674 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2675 commit of JPR (before his hollidays to facilitate our work).
2676 * setup.py : bug fix in code. Modifications made while the last commit
2677 of JPR. The code hasn't been tested before the commit... it's so
2678 useless to make that (for best programmer that is JPR) !!!
2680 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2681 * tagged the current version as Version0_3 (i.e. version 0.3)
2683 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2684 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2685 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2686 * *.dsp : modifications to use new libgdcmijpeg8 library
2687 * setup.py : bug fix on VTKPATH variable
2688 * PACKAGER : adding all concerning windows
2690 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2691 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2693 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2694 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2695 test suite reported error.
2696 * PACKAGER file added (describes what a packager must do when
2697 packaging a new release).
2698 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2699 * configure.in: upgraded version number to 0.3.0
2700 * fixing build of rpm (through rpm -ta):
2701 - Doc/Makefile.am exports proper doxygen files
2702 - src/jpeg/libijg8/Makefile.am exports the include files.
2704 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2705 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2706 * src/gdcmHeader.h : formatting code
2708 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2709 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2710 We were obtaining error message from vtk. Now, creation of file list
2711 is made in an internal list to prevent this problem.
2712 Bug fix when output is empty.
2713 Bug fix in update of progress value. Previous commit for this was a bad
2715 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2717 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2718 * src/gdcmHeader.h : added method to get the file name
2719 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2720 files. Added method to remove all files on the input
2721 Added FIXME comment concerning the bad parsing of header made by
2722 ExecuteInformation method (in ExecuteData method)
2724 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2725 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2726 when using make instal.
2727 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2728 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2730 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2731 * setup.py : adding include dir of jpeg lib to compile all sources
2732 * */Win32/*.dsp : JPR fix for windows compilation
2734 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2735 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2737 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2738 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2740 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2741 * setup.py is again effective on un*x (takes into account the
2742 addon of the jpeg library)
2743 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2744 * Doc/Doxy* updated (includes above enhancements)
2745 * INSTALL now points to web documentation
2747 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2748 * src/gdcmHeader.h doesn't make unnecessary reference to
2750 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2752 * src/gdcm*.[cxx|h] :
2753 - to allow compilation with gcc 3.x
2754 -- clean up of STL usage (added explicit usage of std::)
2755 -- small fixes on exceptions.
2756 Note: linking not tested !
2757 - clean of doxygen comments to avoid warnings at documentation
2759 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2760 dependent convertion).
2762 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2763 * Clean up of previous JPR garbage commit (not even commented in the
2765 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2766 - moved all jpeg related files from src to src/jpeg/libijg8, with
2767 addition/modification of Makefile.am and configure.in.
2768 - the testSuite is still brain damage (not guilty).
2770 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2771 * WrapVTK.py : modifications to get correctly vtk source files to
2773 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2774 (FileName -> Filename)
2776 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2777 * vtk/vtkGdcmReader.[cxx/h]:
2778 - UpdateProgress method should now be effective
2779 - removed the limitation on having only images loaded (as opposed
2781 - when building a stack of images/volume, a lesser number of
2782 gdcmHeader and gdcmFile instances should be used (hopefully
2783 accelerating things).
2784 - when building a stack of images/volumes, files which are not
2785 loadable (wrong path-filename, wrong permissions on existing file,
2786 or file not parsable by gdcm) are replaced with a black image
2787 in the stack (for the caller to notice the problem).
2789 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2790 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2792 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2793 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2794 between standard library (std) and vtk library (problems are found
2795 under Windows... thanks Windows !)
2797 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2798 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2800 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2802 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2803 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2805 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2806 * When compiling with distutils (see setup.py) the C++ compiler is
2807 called with different flags than the default ones (with automake).
2808 In order to fix all those warning, I compiled gdcm with the command
2809 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2810 and went for warning fixes:
2811 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2812 up from unused variables.
2813 - vtk/vtkGdcmReader.cxx: potential bug fix.
2814 * src/gdcmHeader.h: Doxygen warning cleanup
2816 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2817 * gdcmPython/gdcm.i:
2818 - typemaps correction to take into account the systematic replacement
2819 of "using namespace std" with std:: prefix e.g. std::list,
2820 std::string... (cf changes of 2003-05-21).
2821 - gdcmGlob global variable of type gdcmGlobal (defined in
2822 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2823 exported to Python a as cvar.
2824 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2825 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2826 gdcmDictSet.GetPubDictTagNames() and
2827 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2828 C++ static methods).
2829 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2830 with the above changes.
2832 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2833 * setup.py, manifest.in : bug fix under linux
2835 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2836 * Modification of setup.py to compile vtk part too. Then, we have 2
2837 wrappers which must work with same distutils. For that, we have a
2838 generic distutils in distusiltsWrapping.py ; with :
2839 - build_extWrap class to wrap generically all extensions,
2840 - ExtensionWrap base class for all wrapping extension that contains
2842 - Wrapper interface which wrap sources
2843 + In WrapSwig.py we have extension and wrapper for Swig
2844 + In WrapVTK.py we have extension and wrapper for VTK
2845 * MANIFEST.in : modifications to consider vtk directory and new python
2846 files for compilation
2848 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2849 * Added python wrappers of vtkGdcmReader vtk class (see the
2850 source in vtk/vtkGdcmReader.cxx) :
2851 - vtk/Makefile.am now builds a library
2852 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2853 python library (as opposed to _gdcm.so wich are the python
2854 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2855 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2857 - configure.in has an additional flag --enable-vtk that needs
2858 to be set to enable compilation of vtk related code, that is:
2859 + vtk/vtkGdcmReader.so and
2860 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2861 + gdcmPython/vtkgdcmPython.so (see above)
2862 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2863 be read when compressed or when HighBit + 1 != BitsStored),
2864 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2865 the usage of the python wrapper of vtkGdcmReader vtk class.
2866 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2867 * src/*.[h] all occurences of stl classes are now prefixed with
2868 std::, and all occurences of "using namespace std;" where removed.
2869 This is to avoid pollution of global namespace in included files.
2870 Apparently vtk does not avoid this pitfall: when using both
2871 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2872 collision of various stl members (principally cout...).
2873 * gdcmPython/testSuite.py now cleanly removes temprory generated
2875 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2876 comply with above changes)
2878 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2879 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2880 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2881 vtk data structure (an image Flip was required).
2882 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2883 * cosmetic changes in documentation.
2885 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2886 * src/gdcmHeader.cxx: the constructor no longer exits when an
2887 unexisting file is given as argument.
2888 * The subdirectory Data (containing all the images used for the
2889 test suite) is not part of this repository anymore. A new module
2890 containing those images is now available at
2891 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2892 with the name gdcmData.
2893 All the python scripts (including the package initialisation file
2894 gdcmPython/__init__.py) were adapated to take this change into
2895 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2897 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2898 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2899 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2900 demo of the usage of this class.
2901 Compilation of this vtk part is only done when using the --enable-vtk
2902 at configure (or autogen.sh) stage.
2904 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2905 * More memory link related corrections and documentation fixes.
2907 - maximum info is obtained with a command of the form:
2908 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2909 --show-reachable=yes PrintHeader
2910 - the remaining reachable blocks seem to come from the STL
2911 allocation scheme through the usage of map and list. It looks
2912 like this memory cannot be freed but it is not a memory leak
2913 (in fact further invocation to the STL would recollect the
2914 unused memory allthough it cannot explicitely be freed).
2915 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2916 of displaying an image parsed with gdcm and displayed with VTK.
2917 Note: some images don't seem to work e.g.
2918 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2919 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2920 Allthough this weakens the semantics, it is a ditch attempt to
2921 make gdcm more thread friendly.
2923 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2924 * Memory link hunt (by using valgrind through the command
2925 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2926 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2927 gdcmHeader::_dicom_vr.
2928 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2929 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2931 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2933 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2934 * src/Makefile.am now exports all the necessary include files at
2938 * UpdateGroupLength replaced by new one
2941 * UpdateGroupLength re-written using H-Table
2942 (named UpdateGroupLengthNew untill checks are over)
2944 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2945 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2946 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2948 - gdcmHeader::GetPubElValSet removed.
2949 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2950 UpdateGroupLength, WriteElements, Write.
2951 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2952 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2953 carried the same semantics.
2954 - src/gdcmHeaderIdo.cxx changed accordingly.
2955 - gdcmFile::WriteBase now regroups all the codes from previous
2956 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2957 - enum FileType moved to gdcmCommon.h
2958 * src/gdcmHeader.cxx AddDefault trashed
2959 * gdcmGetXSize added
2960 * getimageDataSize now calls gdcmGetXSize
2961 * Test/*.cxx changed to agree with above changes
2963 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2964 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2965 (to avoid double call by end user).
2966 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2967 by end user, since gdcmHeader::gdcmHeader now handles it.
2969 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2970 * gdcm/Doc many doxygen changes:
2971 - Doxyfile now has two different versions, DoxyfileUsers that generates
2972 the html.users end users oriented documentation and
2973 DoxyfileDeveloppers that generates the html.developper developper
2974 oriented documentation.
2975 - README changed accordingly
2976 - requirement.txt removed (old design info moved to TODO).
2977 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2978 DoxyMainPage.txt, DoxyPython.txt provide more information.
2979 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2980 be updated by simply regenerating the docs with doxygen and copying
2981 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2982 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2983 all the tests in the form "if (<map>.count() >1)" were removed.
2984 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2985 ill-formed documentation sections.
2986 * src/gdcmHeader.cxx: ditto
2988 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2989 * setup.py fixed for un*x (needed macro for stdint.h)
2990 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2991 un*ces with sh-utils test utility.
2992 * gdcmPython/demo/test.py renamed to PrintHeader.py
2993 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2994 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2995 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2996 * src/gdcm*.cxx JPR's bad inclusion fixed.
2998 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2999 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3000 * gdcmPython/demo/test.py changed accordingly.
3002 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3003 * gdcmPython/Makefile.am fixed linking against libstdc++
3004 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3005 * Swig subdir (historical tests of swig version 1.3.17++) removed
3006 * Test/testChangeEntete.cxx some lines commented out in order to make
3008 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3009 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3011 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3012 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3013 hence the user doesn't need this explicit call.
3014 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3015 i.e. LoadElements() call removed.
3016 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3017 - src/Makefile.am declares the proper flag for g++.
3018 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3019 for adding user defined new tags.
3020 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3021 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3022 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3024 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3025 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3026 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3027 src/Makefile.am : the project should properly compile and install
3028 with the autotools, included the python wrappers part.
3029 * gdcm.spec.in : added a spec file for RPM packaging.
3031 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3032 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3034 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3035 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3036 to exported to the environement (see gdcmPython/testSuite.py
3038 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3039 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3040 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3041 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3042 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3044 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3045 * gdcmPython/__init__.py doesn't crash anymore when running in
3046 in InstallMode or PreInstallMode but with an environment given
3047 value of GDCM_DICT_PATH.
3048 * src/gdcmDictSet.[cxx/h] coding style.
3050 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3051 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3052 * src/gdcm.h general comments moved to TODO, and README
3053 * src/gdcm.h should now be seen as a user commodity (including it
3054 should suffice to fully use gdcm). It is nowhere including within
3055 any of the kernel files src/*.cxx and src/*.h.
3057 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3058 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3059 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3061 * src/gdcm*.cxx only include their corresponding include file
3062 (as opposed to gdcm.h)
3063 * gdcmPython/gdcm.i changed accordingly
3064 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3065 the autogen.sh generated "make snapshot" command to work.
3066 * autogen.sh removed history related references to crea package.
3068 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3069 * distutilsSwigCPlusPlus.py work around some swig portability
3072 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3073 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3074 was done in a last ditch attempt to get setup.py _really_
3075 operationnal. The python/gdcmPython layaout add the advantage
3076 of hidding away the python related distutils specific files
3077 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3078 Alas, the src directory was out of scope (i.e. it's relative
3079 position to setup.py was ../src) which made things impossible to
3080 handle (see previous version of python/setup.py). Crossing fingers...
3082 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3083 * python/setup.py now works on Un*x. (harder than I thougth)
3084 * python/distutilsSwigCPlusPlus.py can now have include files
3085 among the list of sources.
3087 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3088 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3089 * modifications in MSVC projects
3091 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3092 * As stated by the first lines of Test/ExceptionAndPython/README, it
3093 looks like we can move back to original usage of exception within
3094 src/gdcm* and hence remove the errno stuff that was introduced
3095 as a quick and dirty fixture of this problem (added to the TODO).
3096 * Doc/Doxyfile configuration file for Doxygen and corresponding
3097 README file for usage added.
3098 * Test/testWrite.cxx added. This new test comes from a split of
3099 test.cxx that is now reverted to its original purpous i.e.
3100 testing the proper parsing of a Dicom related file.
3101 testWrite.cxx concentrates on testing the IO part of gdcm.
3102 * Test/bug1.cxx (containing a bug on WIn32) added.
3103 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3104 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3105 whose purpose is to publish the content of the TagNames of the
3106 Dicom public dictionary were not accessible without an
3107 instance of class gdcmHeader.
3108 - those methods are now static methods of gdcmDictSet and hence
3109 require no instances at all to be invocated.
3110 - within gdcmDictSet this change required to change some method
3111 to class methods (i.e. are now static) among which SetDictPath
3112 (renamed to BuildDictPath) and LoadDefaultPubDict.
3113 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3114 the above changes by calling the new method classes of gdcmDictSet.
3115 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3116 the above to be effective.
3117 * python/gdcmPython: in order to wrap properly the above changes
3118 for Python, swig version now needs to be > 1.3.17.
3119 * python/gdcmPython/Makefile fixed to adapt itself to new
3120 configure/make shema introduced by Johan Montagnat (thanks for the
3121 contribution). Alas this Makefile cannot be turned into a proper
3122 Makefile.am without some heavy changes in the configure.in
3123 (for python dectection).
3124 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3125 now avoids publishing the empty entries.
3127 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3128 * python/setup.py : bug fix concerning install under windows
3129 ExtraPath reused :-P
3130 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3132 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3133 * Dicts/dicomV3.dic : remove double spaces !!!
3134 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3135 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3138 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3139 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3140 method. Doxygenation.
3141 * src/gdcm.h clean up of JPR spurious comments.
3143 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3144 * python/distutilsSwigCPlusPlus.py now properly collects the
3145 shadow classes generated by "swig -c++" (gdcm.py in our case)
3146 when using "python setup.py install".
3147 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3148 reexports the working classes.
3149 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3150 by the classical C errno scheme. This is to prevent an obscure
3151 behavior of the python wrappers when importing wxPython.wx prior
3152 to gdcmPython (which ended up in an abort call). An illustration
3153 of this oddity can be found in the Test/ExceptionAndPython
3154 subdir (see the README file). This problem probably due to
3155 an combination of g++ and dynamic loading.
3156 * added Test/ExceptionAndPython (see above)
3158 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3159 * Changed the layout of the python part to avoid bloating main
3160 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3161 i.e. the distutils arsenal. All the python related stuff is
3162 again in a python subdir, but the package itself is now in
3164 * setup.py was cleaned up:
3165 - pythonIncludePath removed
3166 - python setup.py bdist target is now functional.
3167 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3168 collision with other packages). gdcmPython/demo/*.py changed
3171 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3172 * python subdir moved to gdcmPython (preparation of distutils packaging).
3173 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3174 distutils installer is operational.
3175 * - gdcmPython/__init__.py now properly loads the swig generated
3176 shadow classes (from gdcm.py).
3177 - gdcmPython/demo/*.py changed to import the package gdcmPython
3178 instead of gdcmPython/demo/load.py.
3179 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3181 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3182 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3183 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3184 entries within the associated public Dicom dictionary resp. the same
3185 information but sorted by the fourth field (PAT, IMG, DIR) of the
3187 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3188 are now in the "???" group.
3189 - python/gdcm.i changed accordingly,
3190 - python/demo/printGroupedPublicDict.py added, that gives an example
3191 of the above new functionalities in Python.
3193 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3194 * src/gdcm.h, gdcmHeader.cxx:
3195 - historic references to glib's g_malloc and g_free (#defined)
3196 were definitively removed.
3197 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3198 * src/gdcmElValSet.cxx:
3199 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3200 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3201 - GetElValue(string) renamed to GetElValueByName.
3202 - Added GetElementByName(string).
3203 * src/gdcmHeader.cxx: added
3204 - GetPubElValRepByNumber(guint16, guint16)
3205 - GetPubElValRepByName(string)
3206 - GetShaElValRepByNumber(guint16, guint16)
3207 - GetShaElValRepByName(string)
3208 - GetShaElValByNumber(guint16, guint16)
3209 - GetShaElValRepByName(string)
3210 - GetElValRepByNumber(guint16, guint16)
3211 - GetElValRepByName(string)
3212 - GetElValByNumber(guint16, guint16)
3213 - GetElValRepByName(string)
3214 * Doc/requirements.txt added.
3216 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3217 * Test/Makefile building now depends on the one of libgdcm.so
3218 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3219 pixel data) aware which enables finding the address (offset) of
3220 the pixel data of JPEG encoded DICOM files. This leaves only a single
3221 file in the testSuite whose pixel data address (offset) is unknown.
3222 * python/testSuite.py changed accordingly.
3224 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3225 * VC++ has some strong limitations when working with the STL, as stated
3226 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3227 "Also note that some STL containers (map, set, queue, list, deque)
3228 cannot be exported. [...]
3229 Some STL classes contain nested classes. These classes can not
3231 This is caused by a designed limitation that once a template
3232 class is instantiated, it can not be re-instantiated and
3234 Since our usage of map<> is ubiquitous in gdcm, this "designed
3235 limitation" of VC++ is a pitfall.
3236 Hence the Python wrappers of gdcm cannot be incrementally linked
3237 against the c++ dynamic library. The dirty but only workaround is
3238 to forget about incremental link of dynamic libraries and to generate
3239 the Python wrappers library with the inclusions of the underlying C++
3241 The following modifications concern this matter on Win32/VC++:
3242 - wrapping python correct with standalone wrapped dll (don't use separate
3243 dll under windows !!!!)
3244 - python21_d debug mode enabled (ask Frog how to use it :-)
3245 - NO problem with having an STL member of class for example string in C++
3246 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3247 - Python test of dcmlib in Python is ok under windows on a large set
3249 * removed glib references
3250 * typedef's inserted in gdcm.i for correct swig type management
3252 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3253 * python/demo/*.py load.py extracted from test.py. Added explore.py
3254 that only displays required tags and testAll.py that parses all
3255 the files of the testsuite without using unittest.
3256 * python/testSuite.py other additional test on new files added.
3257 * Data/* new test files added accordingly to the testSuite.
3258 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3259 the vr in the file differs from the one of the dictionary.
3261 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3262 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3263 values, but limits itself to values which are below a user specified
3264 size (by default 1024 bytes).
3265 * python/gdcm.i : elements not loaded (because their size is above the
3266 user specified treshold) are exported with their TagKey as key of the
3267 python dictionary. This enables the testsuite to make some checks
3268 on the unloaded elements (since we have their offset and size).
3269 * python/testSuite.py
3270 - now tests for the existence and proper value of the pixel data
3271 - two new examples added.
3272 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3274 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3275 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3276 aware. See the strategy comments in gdcmHeader::FindLength().
3277 * Test/test.cxx now accepts a filename as first argument.
3278 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3279 * python/testSuite.py changed to integrate test on above files.
3281 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3282 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3283 the vr was also RET.
3284 * python/testSuite.py more tests added.
3286 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3287 * python/testSuite.py unittest test suite added (uses Data)
3288 * Data/* dcm and acr files for the test suite.
3289 * glib dependance removed from un*x version. We now use ISO C99
3290 7.18 Integer types (see stdint.h)
3291 - python/Makefile, src/Makefile src/gdcm.h
3292 * src/ when an explicit vr (like dicom files) suddenly poped an
3293 implicit element we use to mark the underlying DictEntry of the
3294 concerned ElValue with "Implicit". This strategy was damageable
3295 too the public or provite dictionaries, since some of their vr
3296 would be changed. Since Header::FindLength heavily relies on the
3297 detection by Header::FindVR of falsely explicit elements, I
3298 added an extra ImplicitVr member to ElValue (boolean).
3299 The rest of the changes we the necessary adaptations.
3301 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3302 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3304 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3306 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3307 * Adaptation for porting to VC++:
3309 o forced to use std namespace (for string to be known)
3310 o all class use __declspec export style on WIN32
3311 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3312 (in stdlib.h on Win32 but in std:: for gcc)
3313 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3314 variable GDCM_DICT_PATH.
3315 * src/gdcmHeader.cxx verbose comments made discrete.
3317 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3318 * python/gdcm.i: added a typemap that converts a C++ hashing table
3319 to native Python dictionary.
3320 * python/demo/test.py:
3321 - now uses the native dictionary for exploration of gdcmHeader.
3322 - takes an optional filename argument (the file to parse).
3323 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3324 PubElVals hashing table.
3325 * Dicts/dicomV3.dic removed error prone trailing spaces.
3327 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3328 * Python wrapping process moved away from src/Makefile to
3329 newly created python/Makefile (as well as gdcm.i)
3330 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3331 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3332 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3333 from the environement variable GDCM_DICT_PATH (when existing).
3334 * src/gdcmDict::GetTag bug fix.
3336 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3337 * Straightforward temporary fixes for swig to build the python wrappers.
3338 src/Makefile now has a python working entry [by working we mean
3339 that we can import the shadow classes without errors].
3341 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3342 * hashtest.cxx removed (since already in Test)
3343 * src/gdcmlib.h renamed to src/gdcm.h
3344 * src/dcm.i renamed to src/gdcm.i
3345 * src/Makefile prepared for python wrapping
3347 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3348 * src/gdcmHeader.cxx :
3349 - Parsing of header is now separated from loading of element values
3350 (see gdcmHeader::LoadElements).
3351 - general clean up of hopefully all file access (creation of
3352 ReadInt16 and ReadInt32)
3354 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3355 * src/gdcmHeader.cxx :
3356 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3358 - SetLgrElem renamed to SetLength
3359 - GetLgrElem renamed to GetLength
3360 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3361 * src/gdcmElValSet.cxx fixed both GetElValue methods
3362 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3363 due to IdoDude was cleaned out.
3365 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3366 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3367 concentrates on finding the value representation (when it exists).
3368 RecupLgr now only finds the element value length, and it avoids
3369 returning the unecessary skL (skipped length).
3370 Also, offsetCourant was simply removed (with taille_fich) since
3371 it was redundant with the File position internals (by using
3372 ftell and fseek). This also made skL (see above in RecupLgr) usage
3374 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3375 on the libido specificities which are handled through class
3377 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3380 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3381 * Truckload of changes. Parsing of header is barely functional
3382 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3384 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3385 * src/gdcmHeader.cxx many addons of low level methods
3387 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3388 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3389 and _IdDcmSWAP_LONG.
3391 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3392 * This corresponds to all the changes decided at the meeting of
3393 May 23 2002. Needless to say we are running late...