1 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
4 * src/gdcm.h clean up of JPR spurious comments.
6 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
7 * python/distutilsSwigCPlusPlus.py now properly collects the
8 shadow classes generated by "swig -c++" (gdcm.py in our case)
9 when using "python setup.py install".
10 * python/gdcmPython/__init__.py imports gdcm.py and only manually
11 reexports the working classes.
12 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
13 by the classical C errno scheme. This is to prevent an obscure
14 behavior of the python wrappers when importing wxPython.wx prior
15 to gdcmPython (which ended up in an abort call). An illustration
16 of this oddity can be found in the Test/ExceptionAndPython
17 subdir (see the README file). This problem probably due to
18 an combination of g++ and dynamic loading.
19 * added Test/ExceptionAndPython (see above)
21 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
22 * Changed the layout of the python part to avoid bloating main
23 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
24 i.e. the distutils arsenal. All the python related stuff is
25 again in a python subdir, but the package itself is now in
27 * setup.py was cleaned up:
28 - pythonIncludePath removed
29 - python setup.py bdist target is now functional.
30 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
31 collision with other packages). gdcmPython/demo/*.py changed
33 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
34 * python subdir moved to gdcmPython (preparation of distutils packaging).
35 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
36 distutils installer is operational.
37 * - gdcmPython/__init__.py now properly loads the swig generated
38 shadow classes (from gdcm.py).
39 - gdcmPython/demo/*.py changed to import the package gdcmPython
40 instead of gdcmPython/demo/load.py.
41 - gdcmPython/testSuite.py changed to import the package gdcmPython.
44 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
45 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
46 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
47 entries within the associated public Dicom dictionary resp. the same
48 information but sorted by the fourth field (PAT, IMG, DIR) of the
50 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
51 are now in the "???" group.
52 - python/gdcm.i changed accordingly,
53 - python/demo/printGroupedPublicDict.py added, that gives an example
54 of the above new functionalities in Python.
56 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
57 * src/gdcm.h, gdcmHeader.cxx:
58 - historic references to glib's g_malloc and g_free (#defined)
59 were definitively removed.
60 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
61 * src/gdcmElValSet.cxx:
62 - GetElement(guint32, guint32) renamed to GetElementByNumber.
63 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
64 - GetElValue(string) renamed to GetElValueByName.
65 - Added GetElementByName(string).
66 * src/gdcmHeader.cxx: added
67 - GetPubElValRepByNumber(guint16, guint16)
68 - GetPubElValRepByName(string)
69 - GetShaElValRepByNumber(guint16, guint16)
70 - GetShaElValRepByName(string)
71 - GetShaElValByNumber(guint16, guint16)
72 - GetShaElValRepByName(string)
73 - GetElValRepByNumber(guint16, guint16)
74 - GetElValRepByName(string)
75 - GetElValByNumber(guint16, guint16)
76 - GetElValRepByName(string)
77 * Doc/requirements.txt added.
79 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
80 * Test/Makefile building now depends on the one of libgdcm.so
81 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
82 pixel data) aware which enables finding the address (offset) of
83 the pixel data of JPEG encoded DICOM files. This leaves only a single
84 file in the testSuite whose pixel data address (offset) is unknown.
85 * python/testSuite.py changed accordingly.
87 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
88 * VC++ has some strong limitations when working with the STL, as stated
89 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
90 "Also note that some STL containers (map, set, queue, list, deque)
91 cannot be exported. [...]
92 Some STL classes contain nested classes. These classes can not
94 This is caused by a designed limitation that once a template
95 class is instantiated, it can not be re-instantiated and
97 Since our usage of map<> is ubiquitous in gdcm, this "designed
98 limitation" of VC++ is a pitfall.
99 Hence the Python wrappers of gdcm cannot be incrementally linked
100 against the c++ dynamic library. The dirty but only workaround is
101 to forget about incremental link of dynamic libraries and to generate
102 the Python wrappers library with the inclusions of the underlying C++
104 The following modifications concern this matter on Win32/VC++:
105 - wrapping python correct with standalone wrapped dll (don't use separate
106 dll under windows !!!!)
107 - python21_d debug mode enabled (ask Frog how to use it :-)
108 - NO problem with having an STL member of class for example string in C++
109 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
110 - Python test of dcmlib in Python is ok under windows on a large set
112 * removed glib references
113 * typedef's inserted in gdcm.i for correct swig type management
115 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
116 * python/demo/*.py load.py extracted from test.py. Added explore.py
117 that only displays required tags and testAll.py that parses all
118 the files of the testsuite without using unittest.
119 * python/testSuite.py other additional test on new files added.
120 * Data/* new test files added accordingly to the testSuite.
121 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
122 the vr in the file differs from the one of the dictionary.
124 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
125 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
126 values, but limits itself to values which are below a user specified
127 size (by default 1024 bytes).
128 * python/gdcm.i : elements not loaded (because their size is above the
129 user specified treshold) are exported with their TagKey as key of the
130 python dictionary. This enables the testsuite to make some checks
131 on the unloaded elements (since we have their offset and size).
132 * python/testSuite.py
133 - now tests for the existence and proper value of the pixel data
134 - two new examples added.
135 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
137 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
138 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
139 aware. See the strategy comments in gdcmHeader::FindeLength().
140 * Test/test.cxx now accepts a filename as first argument.
141 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
142 * python/testSuite.py changed to integrate test on above files.
144 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
145 * Dicts/dicomV3.dic removed all the trailing (RET) when the
147 * python/testSuite.py more tests added.
149 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
150 * python/testSuite.py unittest test suite added (uses Data)
151 * Data/* dcm and acr files for the test suite.
152 * glib dependance removed from un*x version. We now use ISO C99
153 7.18 Integer types (see stdint.h)
154 - python/Makefile, src/Makefile src/gdcm.h
155 * src/ when an explicit vr (like dicom files) suddenly poped an
156 implicit element we use to mark the underlying DictEntry of the
157 concerned ElValue with "Implicit". This strategy was damageable
158 too the public or provite dictionaries, since some of their vr
159 would be changed. Since Header::FindLength heavily relies on the
160 detection by Header::FindVR of falsely explicit elements, I
161 added an extra ImplicitVr member to ElValue (boolean).
162 The rest of the changes we the necessary adaptations.
164 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
165 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
167 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
169 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
170 * Adaptation for porting to VC++:
172 o forced to use std namespace (for string to be known)
173 o all class use __declspec export style on WIN32
174 - src/gdcmUtil.cxx new Exit method that wraps the exit call
175 (in stdlib.h on Win32 but in std:: for gcc)
176 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
177 variable GDCM_DICT_PATH.
178 * src/gdcmHeader.cxx verbose comments made discrete.
180 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
181 * python/gdcm.i: added a typemap that converts a C++ hashing table
182 to native Python dictionary.
183 * python/demo/test.py:
184 - now uses the native dictionary for exploration of gdcmHeader.
185 - takes an optional filename argument (the file to parse).
186 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
187 PubElVals hashing table.
188 * Dicts/dicomV3.dic removed error prone trailing spaces.
190 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
191 * Python wrapping process moved away from src/Makefile to
192 newly created python/Makefile (as well as gdcm.i)
193 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
194 * src/gdcmHeader::FindLength only looks for current vr when necessary.
195 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
196 from the environement variable GDCM_DICT_PATH (when existing).
197 * src/gdcmDict::GetTag bug fix.
199 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
200 * Straightforward temporary fixes for swig to build the python wrappers.
201 src/Makefile now has a python working entry [by working we mean
202 that we can import de shadow classes without errors].
204 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
205 * hashtest.cxx removed (since allready in Test)
206 * src/gdcmlib.h renamed to src/gdcm.h
207 * src/dcm.i renamed to src/gdcm.i
208 * src/Makefile prepared for python wrapping
210 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
211 * src/gdcmHeader.cxx :
212 - Parsing of header is now separated from loading of element values
213 (see gdcmHeader::LoadElements).
214 - general clean up of hopefully all file access (creation of
215 ReadInt16 and ReadInt32)
217 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
218 * src/gdcmHeader.cxx :
219 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
221 - SetLgrElem renamed to SetLength
222 - GetLgrElem renamed to GetLength
223 - ~gdcmHeader() made virtual to pesky warning messages at compile.
224 * src/gdcmElValSet.cxx fixed both GetElValue methods
225 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
226 due to IdoDude was cleaned out.
228 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
229 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
230 concentrates on finding the value representation (when it exists).
231 RecupLgr now only finds the element value length, and it avoids
232 returning the unecessary skL (skipped length).
233 Also, offsetCourant was simply removed (with taille_fich) since
234 it was redundant with the File position internals (by using
235 ftell and fseek). This also made skL (see above in RecupLgr) usage
237 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
238 on the libido specificities which are handled through class
240 * Test/implicit_vr.dcm dicom v3 in implicit value representation
243 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
244 * Truckload of changes. Parsing of header is barely functional
245 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
247 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
248 * src/gdcmHeader.cxx many addons of low level methods
250 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
251 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
254 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
255 * This corresponds to all the changes decided at the meeting of
256 May 23 2002. Needless to say we are running late...