1 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * Added documentation of vtkgdcmReader on Website:
3 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
4 with it's binary name).
5 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
6 the Website to be more complete.
7 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
8 doxygenated documentation.
9 - Doc/DoxyVtkGdcmReaderExamples.txt added
10 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
11 DoxyVtkGdmReaderExamples.html )
12 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
13 * CLEANUP_ROUND (3) for gdcmPixelConvert
14 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
16 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
17 * CLEANUP_ROUND (2) for gdcmPixelConvert
18 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
20 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
21 * CLEANUP_ROUND for gdcmPixelConvert:
22 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
23 - src/gdcmPixelStuff[h|cxx] removed
24 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
25 - src/CMakeLists.txt changed accordingly
27 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
28 gdcmVersion.py moved to newly created ATTIC related
29 gdcmPython/SetupOldies/ directory.
31 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
32 - autogen.sh configure.in acinclude.m4 python.m4 removed
34 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
35 * src/*.cxx *.h Reference to License.htm fixed to License.html.
36 * Doc/CMakeLists.txt, doxygen.config.in: fix.
37 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
39 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
40 * TODO updated with Mathieu suggestions. I proposed a template for
41 describing TODO entries and used it for new entries.
42 * Added Doc/Website/CodingStyle.html, Developpers.html,
43 DeveloppersPython.html, GdcmDataCvs.html and
44 DownloadVersion0_1.html, DownloadVersion0_3.html.
45 * Some Doc/*.txt Doxygen files (which do not really concern the
46 documentation itself, but the website) moved to html and
47 placed in directory Doc/Website:
48 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
49 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
50 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
51 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
52 * CMakeLists.txt changed accordingly.
53 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
54 DeveloppersPython.html
55 * INSTALL nows refers to Doc/Website/Installation.html
57 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
58 * Added Doc/Website directory, that contains a first raw version
61 2004-09-23 Jean-Pierre Roux
62 * FIX In order not to be poluted any longer by casting problems,
63 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
64 we can now delete[] it safely
65 * VoidArea is now called BinArea (less confusing name),
66 and all the methods called ...VoidArea... are now ... BinArea...
67 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
69 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
70 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
71 clear) TagHT, which is an inherited member of gdcmElementSet. It is
72 up to the destructor of gdcmElementSet to clean up TagHt and it's
75 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
76 * Test/CMakeLists.txt: update to follow gdcmData renamings.
77 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
79 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
80 * ENH: added some utility method that builds a flat dictionnary
81 holding all the Dicom entries contained in the recursive structure
82 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
84 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
85 BuildFlatHashTable() that build a flat dictionary.
86 - src/gdcmElementSet.h: added a new private GetTag() accessor.
87 gdcmDocument is now a friend of gdcmElementSet.
88 - src/gdcmElementSet.cxx: clean up.
89 - Example/FlatHashTablePrint.cxx added.
90 - Example/CmakeLists.txt changed accordingly
92 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
93 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
94 moved away from gdcmDocEntrySet (since this class is an abstract class
95 acting like an interface). SQDepthLevel and BaseTagKey are now
97 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
98 and associated accessors. Doxygenation of the class.
99 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
101 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
102 Use SQDepthLevel accessor instead. ::Print() adapted.
103 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
104 - src/gdcmDocument.cxx changed accordingly.
106 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
107 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
108 - The following is the doxygen comment of the typedef declaration
109 of gdcmagKey in src/gdcmCommon.h:
110 gdcmTagKey is made to old an "universal" (as in URL, Universal
111 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
112 A dicom tag allways has a group and an element, but a set of tags
113 embeded in various (optionally nested) sequences and sharing
114 the same group and element all share the same (group, element)
115 "identifier". Hence the (group, element) cannot be used as an
116 identifier (in gdcm we shall refer to a "TagKey") of a tag.
117 In order to construct a proper tag identifier (i.e. a key) we
118 consider the following definition of a TagKey:
119 - let Group, Element be the string representation of the
120 group and element dicom tag members,
121 - let ItemNumber be the string representation of the integer
122 index of the considered item number of a sequence,
123 Let the key of a tag embeded in a sequence, noted SeqTag, be
125 /ItemNumber#Group|Element
126 where "/", "#" and "|" are characters acting as separators.
127 Then the general form of a gdcmTagKey is given by:
128 Group|Element<SeqTag>
129 where <SeqTag> means NO or many instances of SeqTag.
130 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
133 but the gdcmTagKey of a tag "embeded" is the first item of
134 a sequence, itself nested in the third item of a sequence is the
136 0004|1220/2#0008|0082/0#0008|0090
137 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
138 order to hold the new sequence compatible key. Previously, the
139 GetKey() method would look in the underlying gdcmDictEntry.
140 - src/gdcmDocEntry.cxx:
141 -- constructor now copies the underlying DictEntry key, in the local
143 -- ::Print: displays the member Key, instead of the (group, element).
144 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
145 - src/gdcmDocEntrySet.h:xi
146 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
147 -- now has a new BaseTagKey member.
149 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
150 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
152 This poses the problem with the semantics of the following lines
153 LoadEntryVoidArea(0x0028,0x1201); // R LUT
154 LoadEntryVoidArea(0x0028,0x1202); // G LUT
155 LoadEntryVoidArea(0x0028,0x1203); // B LUT
156 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
157 to the long FIXME note for what the problem is. Nevertheless in
158 order to get things working the dicom dictionary was altered !
159 Please fix things urgently...
160 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
161 information), see above note on moving the member VoidArea. Nevertheless
162 the following entries previously correctly set as US are now inproperly
164 0028 1201 OW IMG Red Palette Color Lookup Table Data
165 0028 1202 OW IMG Green Palette Color Lookup Table Data
166 0028 1203 OW IMG Blue Palette Color Lookup Table Data
167 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
168 of gdcmDocEntry moved to gdcmSeqEntry.
169 * src/gdcmSeqEntry.cxx: STYLE.
171 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
172 * Test/TestAllEntryVerify.cxx minor fix and added comments.
174 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
175 * gdcmPython/testSuite.py: all the test suite in python is now moved
176 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
177 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
178 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
180 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
181 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
182 to avoid inclusion recursion until STL is reached.
183 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
184 mecanism. errno.h is not included in gdcm anymore.
185 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
186 (gdcmFormatError now inherits from gdcmFormatUnexpected).
188 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
189 gdcmData/TestAllEntryVerifyReference.txt
190 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
191 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
192 exception_on_error parameter.
193 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
194 - vtk/vtkGdcmReader.cxx changed accordingly,
195 - Example/*.cxx and Test/*.cxx changed accordingly.
197 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
198 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
199 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
200 enable_sequences removed from gdcmHeader constructor and dependencies.
201 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
202 * gdcmPython/demo/PrintHeader.py: dummy fix.
203 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
204 skip_shadow removed from gdcmHeader constructor and dependencies.
205 * Example/*.cxx and Test/*.cxx changed accordingly.
207 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
208 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
209 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
211 2004-07-21 Jean-Pierre Roux
212 * FIX Now, Parsing and Printing a DICOMDIR do work!
213 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
215 2004-07-20 Jean-Pierre Roux
216 * FIX Some brain damaged headers have Zero-Lenght fields
217 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
219 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
220 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
221 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
222 variable (instance of gdcmDebug) by a definition macro, and the instance
223 is now in static in the gdcmDebug class
224 * src/gdcmSQItem.h : (FIXME) remove an undefined method
225 * Test/PrintAllDocument.cxx : bug fix in the result of the test
227 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
228 * WARNING: ctest now depends more tightly on gdcmData. You should
229 check out gdcmData properly for things to run smoothly...
230 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
231 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
232 we need the pixels not be loaded in order to use the ValEntry
233 that displays position and size).
234 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
235 This is a C++ based equivalent of gdcmPython/testSuite.py that should
236 be deprecated. If you have any doubts about the advantages of a
237 modern scripting language (read Python) versus grass root C++ (i.e.
238 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
239 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
240 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
241 Anyhow, consider documenting the gdcmData images in
242 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
244 * Test/CMakeLists.txt:
245 - now uses TestAllEntryVerify.cxx
246 - specific comments on oldACR00001.ima (now renamed in gdcmData
247 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
248 gdcmData/TestAllEntryVerifyReference.txt
251 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
252 * src/*.[h|cxx] : typedef clean up
253 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
254 - TagKey renamed to gdcmTagKey (for external usage)
255 - VRKey renamed to gdcmVRKey (for external usage)
256 - removal of typedef duplication.
257 - Removed all unecessary inline keyword from class inline definitions.
258 - Some method|function(void) declarations replaced with method|function().
259 * src/jpeg/libijg12/jdhuff12.c:
260 - printf polluting ctest removed.
261 - TAB removal for comminting
263 - TestAllReadCompareDicom.cxx: added a test that compares all the
264 images in gdcmDataImages.h with corresponding images in
265 gdcmData/BaselineDicom/. When baseline images are not present
266 this test creates them.
267 Note: we need to validate each reference image, but before that
268 I'd like to rename them with a more explicit name...
269 - CMakeLists.txt: changed accordingly.
270 * Example/*.cxx: examples now only include gdcm.h (as opposed to
271 including each header needed).
273 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
274 * Test/*.cxx and Example/*.cxx: moved some examples away from the
275 test suite to the Example directory. Are concerned:
280 - TestWriteSimple.cxx
281 * Test/CMakeLists.txt: added some comments on reasons for black listing
282 image gdcmData/oldACR00001.ima
284 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
285 * Test/CmakeList.txt: removed the following from black list (to be coherent
286 with removal from gdcmData):
287 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
288 - gdcm-MR-PHILIPS-16.dcm
290 Added the following because after last cvs update, they cause
291 ctest -R TestReadWriteReadCompare
293 - gdcm-MR-SIEMENS-16-1.acr
295 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
296 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
297 new comments in this file) we temporarily (sigh) move to a weaker
299 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
300 we don't need to black list the following images anymore:
301 - 8BitsUncompressedColor.dcm
303 - US-PAL-8-10x-echo.dcm
304 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
305 fixes and the beautified code ;-)
306 This fixes the bug introduced in version 1.42 (when beautifying)
307 that made the parsing of 8BitsRunLengthColor.dcm unproper.
308 Note: ctest was blind to this bug (this means we need to still
309 improve the test suite). The bug could be detected by using
310 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
312 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
313 and by displaying the (garbage) produced file temp.XDCM...
315 2004-06-29 Jean-Pierre Roux
316 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
317 - replace by uggly but working old code :-(
318 A lot of things should be OK again.
319 It's really urgent to have a test suite that *tests*,
320 to prevent Frog's beautifying sessions to break all the stuff
321 (twice, withing a fortnigh ...)
323 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
324 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
325 redundancy) to added Test/TestReadWriteReadCompare.cxx
326 * Test/CmakeList.txt: because the compare test of
327 Test/TestReadWriteReadCompare.cxx fails, the following images are
328 black listed: - 8BitsUncompressedColor.dcm
330 - US-PAL-8-10x-echo.dcm
331 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
332 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
333 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
334 and ad-hoc kludge. This kludge is now removed, and on encountering
335 such an image (OB field brain damaged) we set errno. Then in
336 ::FindDocLength() we "fix" the length as being ALL what remains
337 in the file (until EOF). We then proceed, hoping for the best...
338 This fixes a SegFault in ShowDicom when trying to write such an
340 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
341 (because TestWriteRead breaks on it, after a non conformal commit?).
342 ctest now runs properly, except for MakeDicomDir (which was allways
343 broken) and the Python related stuff (still not fixed).
345 2004-06-24 Jean-Pierre Roux
346 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
347 FIX : Test/TestReadWrite now iterates on all the file names
348 (instead of infinite loop)
349 ENH : Test/TestWriteRead now iterates on all the file names
351 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
352 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
354 2004-06-24 Jean-Pierre Roux
355 FIX : - now Write drops LUT Descriptors and LUTs (if any)
356 when SamplesPerPixel =3
357 - now Write is no longer confused by
358 'BitsAllocated = 12" and 'BitsStored=12"
359 - "UN" value representation Elements are now written correctly
360 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
361 ENH : - now gdcmHeader has its own Write methods
362 (in order to split the job that has not to be done
365 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
366 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
367 loop on the same image until memory went out.
368 Note: this means we still have gobs of memory loss in PrintDocument
369 * src/gdcmDocument.cxx: fixes problem on parsing on file
370 gdcmData/16BitsJpegLosslessGrayScale.dcm.
372 2004-06-24 Jean-Pierre Roux
373 FIX : Write - All the Sequences and Sequence Item are now written
374 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
375 is added a the end, when necessary.
376 - A lot of brain-damaged images, that were read correctly are
377 now written correctly
378 - length compatible BinEntry are now loaded correctly
379 (even for odd groups)
380 Note : only Explicit Value Representation was checked.
381 (question : is implicit VR really necessary for gdcm ?)
383 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
384 * DEVELOPPER: added a proposition of coding style.
385 * src/gdcmDocEntry.h: removed every inline declaration (for test of
388 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
389 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
390 Use the gdcmDocEntry::Print() and Write() instead.
391 * src/gdcmDocument.cxx: bug fix.
393 2004-06-22 Jean-Pierre Roux
394 FIX : gdcmDocument.cxx
395 - Now we do recognize the JpegLossLess format (there was a misstyping in
396 code 'beautyfication' :-(
397 - Now we automaticaticaly load the Luts, if any
399 2004-06-22 Jean-Pierre Roux
400 In order : to write Sequences, whatever their imbrication level,
401 : to allow user to create his own Sequences
402 a lot of modif where necessary (adding, moving, or virtualising methods)
404 WARNING : save your own sources *before* cvs up !
407 ADD virtual void Write(FILE *fp, FileType filetype);
410 ADD virtual void Write(FILE *fp, FileType filetype);
411 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
414 ADD virtual void Write (FILE *fp, FileType filetype)=0;
415 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
416 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
417 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
418 ADD std::string GetEntryByName(TagName name);
419 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
421 std::string vr = "unkn",
422 std::string fourth = "unkn",
423 std::string name = "unkn");
424 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
425 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
426 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
427 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
428 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
429 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
430 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
431 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
434 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
435 ADD virtual std::string GetEntryByName (TagName tagName);
436 ADD virtual std::string GetEntryVRByName (TagName tagName);
437 REM virtual bool Write(FILE *, FileType);
438 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
439 FILE *_fp, FileType type);
440 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
441 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
442 REM virtual bool WriteEntries(FILE *_fp,FileType type);
443 REM virtual std::string GetEntryByName (std::string tagName);
444 REM virtual std::string GetEntryVRByName (std::string tagName);
445 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
446 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
447 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
449 std::string vr = "unkn",
450 std::string fourth = "unkn",
451 std::string name = "unkn");
452 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
453 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
454 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
455 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
458 ADD virtual void Write(FILE *fp, FileType filetype);
461 ADD virtual void Write(FILE *fp,FileType filetype);
464 ADD virtual void Write(FILE *fp, FileType filetype);
465 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
466 REM std::string GetEntryByNumber(guint16 group, guint16 element);
467 REM std::string GetEntryByName(TagName name);
470 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
472 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
473 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
474 The default constructor invoked by the line
475 gdcmHeader *f1 = new gdcmHeader( header );
476 was gdcmHeader::gdcmHeader(bool) instead of the expected
477 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
478 Hence the parsing wasn't executed... See also below.
479 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
480 as explicit constructor didn't do the trick to fix the above problem.
481 Could anyone explain why ?
482 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
483 properly calls gdcmValEntry::Print() (that was weed out from
484 code related to gdcmBinEntry).
486 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
487 * In order to fix memory leaks:
488 - Test/TestWriteSimple.cxx: added cleaning of free store through
490 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
491 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
492 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
493 (through the call to ::AddDicomDirMeta()) or the destructor
494 would crash when deleting uninitialized ::metaElems].
495 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
496 - src/gdcmDocument.cxx:
497 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
499 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
500 was causing memory leaks.
501 - src/gdcmSQItem.cxx:
502 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
503 cleanly handled with polymophism: sorry but my milage is low).
504 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
505 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
506 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
507 This avoids SegFaulting.
508 - src/gdcmSQItem.h: coding style.
510 - Test/TestWriteSimple still severely sucks. The output image content
511 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
512 damaged when displayed with vtkgdcmViewer.
513 - on memory leaks: TestWriteSimple leaks really less (see entry
514 of 2004-06-18 in Changelog file for the call to valgrind).
515 - on segfaults: ctest now passes all the tests but one (no more
517 * Erroneous leading white fix:
518 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
519 white[s] (as opposed to from >> xxx, that removes it [them].
520 - src/gdcmTS.cxx: ditto.
521 - gdcmPython/testSuite.py: dirty related kludge removed.
522 * src/*: remaining references to gdcmParser removed.
523 * src/*[cxx|h]: added copy[way]left header.
526 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
527 * In order to fix writing of dicom files:
528 - Test/TestWriteSimple.cxx: a simpler example of writing.
529 - Test/CMakeLists.txt changed accordingly.
530 - src/gdcmDocument.cxx:
531 -- The destructor now recursilvely removes potential sequences.
532 -- Bug fix in ::IsJPEG2000()
533 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
534 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
536 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
537 to only declared) and build on top of
538 ::GetDocEntryByNumber(guint16, guint16).
539 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
540 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
541 for usage in destructor and treatement of promotion in
542 ::ReplaceOrCreateByNumber().
543 - src/gdcmSQItem.cxx: destructor should better handle his job.
544 Test/TestWriteSimple now runs (or at least it DOES something).
545 * We can now start hutting memory links. A good starting point is:
546 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
547 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
548 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
550 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
551 * Valgrind note: after Mathieu Malaterre teached me how to read
552 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
554 Using gcc, you can force the STL to use malloc and to free memory as
555 soon as possible by globally disabling memory caching.
556 With 3.2.2 and later, you should export the environment variable
557 GLIBCPP_FORCE_NEW before running your program.
558 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
559 simply vanish (it is still not clear to me, whether this means that
560 STL std::string leaks or if valgrind believes it leaks...).
561 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
562 running bin/gdcmTests makeDicomDir):
563 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
564 - Test/makeDicomDir.cxx now properly traps empty lists and returns
566 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
567 SegFaulting (I drowned in DicomDir related code when trying to
568 understand why the list is empty...).
569 * src/gdcmDocument.h: first BSD license header try.
570 * Doc/License.txt added.
572 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
573 * src/gdcmDocument.[h|cxx]:
574 - Clean up of the Transfer related predicates. They are now all based
575 on new method isGivenTransferSyntax, that (should) handle properly
577 - general clean up, simplification, and coding style.
578 - Specific clean up of Parse7FE0() (umproperly named actually).
579 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
581 2004-06-14 Jean-Pierre Roux
583 - fix the display of Sequence Delimitor (SQDepthLevel pb)
584 - fix the display of SQItem ordinal number
585 - add the GetSQItemByOrdinalNumber method
586 - remove some useless never written private methods
588 2004-06-14 Jean-Pierre Roux
590 - adding a constructor taking a gdcmDocEntry as an input param
591 - ReplaceOrCreateByNumber now returns :
592 a gdcmBinEntry * if a Binary (void *) value is passed as a param
593 a gdcmValEntry * if a string value is passed as a param
595 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
596 according to the param type (no longer sets a gdcmDocEntry)
597 - GetValEntryByNumber, GetBinEntryByNumber added
598 - NewValEntryByNumber and NewBinEntryByNumber added
600 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
602 - GetSQItemNumber and SetSQItemNumber added, to provide
603 a (relative) Item identier inside a given Sequence
604 \warning : some pb remaining around this number
606 - AddEntry now takes the Item Number as a param
608 - adding a constructor taking a gdcmDocEntry as an input param
610 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
611 * Memory leak hunt with the following command:
612 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
613 --show-reachable=yes gdcmTests PrintDocument
614 It looks like many (all?) leaks are due to the STL (or a bad usage
615 of the STL. The lines producing the leaks now have a comment with
616 a "MEMORY LEAK" tag: you can retrieve them with
617 grep "MEMORY LEAK" src/*
618 Here are two typical examples which I can't help fixing:
623 char * test = "babo";
624 name = test; //// <--- valgrind detects 960 bytes lost in
625 //// call to std::string::operator=(char const*)
626 name.clear(); //// Doesn't help !
634 std::cout << "Type a bunch of characters followed by RETURN: ";
635 getline(std::cin, line); //// <--- valgrind dectects a loss
636 //// of 1320 bytes in call to
637 /// std::basic_istream<>& std::getline<>
643 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
644 * src/gdcmHeader.[cxx|h]:
645 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
646 and related, moved away to gdcmDocument.
647 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
648 the corresponding protected accessors of inherited class
649 gdcmDocument, removed ! As a consequence gdcmFile had to be
650 declared friend of class gdcmDocument (see below).
651 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
652 - Clean up of undefined or unused methods.
653 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
654 account the changes to gdcmHeader.h).
655 * src/gdcmDocument.h:
656 - gdcmFile is now a friend class (in order to take into account the
657 changes to gdcmHeader.h).
658 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
659 (see changes to gdcmHeader.h).
660 - Accessors (reading on the form GetEntry*) are now public.
661 - Clean up of undefined or unused methods.
662 * src/gdcmDocument.cxx:
663 - adaptation to changes to gdcmDocument.h
664 - ::OpenFile now writes a verbose message when file cannot be opened.
665 - some std::string properly set to VRKey
666 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
667 references to gdcmDocument.
668 * Test/TestFindTags.cxx: changed accordingly to above changes.
669 * gdcmPython/testSuite.py: adapted to renaming of acr files in
670 cvs repository gdcmData.
672 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
673 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
674 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
675 conflicts with gdcmValEntry::voidArea.
676 * src/gdcmValEntry.cxx: unmatching comment wiped out.
677 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
678 Value representation between StringRepresentable and BinaryRepresentable.
679 * src/gdcmDocument.cxx:
680 - method ParseDES: proper indentation restored and usage of
681 gdcmVR::IsVROfGdcmStringRepresentable wired in.
682 - method LoadDocEntry: the fingerprint left in the SetValue() of
683 unloaded entries (length > MaxSizeLoadEntry) had curiously been
684 removed. Reverting to previous code segment with the proper
685 dynamic_cast< gdcmValEntry* >.
686 Note: this was (partially) breaking the python test suite
687 (gdcmPython/testSuite.py) that made usage of the above
688 fingerprint to check presence of "Pixel Data".
689 * src/gdcmDocEntry.h: coding style.
690 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
691 now taken into account.
692 * gdcmPython/gdcm.i: adaptation to the new internal representation
693 of gdcm (exit gdcmParser, hello gdcmDocument).
694 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
696 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
697 anymore, but instead prints the loaded Python dictionary.
698 * .... alas, the python testSuite is still broken.
700 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
701 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
703 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
704 * src/gdcmUtil.h : export methods
706 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
707 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
709 * Initial addition of automatic python testing
710 * Initial addition of automatic image comparison
712 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
713 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
714 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
716 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
717 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
718 * Test/ShowDicom.cxx : bug fix for msvc compilation
719 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
721 2004-05-04 Jean-Pierre Roux
722 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
723 new concepts (and new classes) :
724 a 'gdcmDocument' is composed of a set of Doc Entries, that are
725 - elementary gdcmDocEntries (former gdcmHeaderEntries)
726 - Sequence Doc Entries (gdcmSeqEntries)
727 a Sequence is composed of Items.
728 Each item is a set of Doc Entries (this is recursive)
729 The non uniqueness of the 'Dicom tag' is due to this recursivity
730 (never taken into account)
731 Our unability to add a new 'entry' in the header
732 at the proper location (neither in the H-Table (map or multimap),
733 nor in the Chained List is also due to this recursivity.
734 Don't try, right now, to use/modify/compile these new sources :
736 We just commit all the stuff, 'as is', in order not to loose it.
738 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
739 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
741 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
742 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
743 file prefix (SetFilePrefix)
745 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
746 * Add a new test: ShowDicom, for now this is just the c++ version of
747 checkRead.sh, later it will be able to compare the image read against a
749 * Replace the DEBUG on the stack with a global entry in cmake interface:
750 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
752 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
753 * Add an example subdir, with a real example on how to read + write a
756 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
757 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
758 * Doc/CMakeLists.txt: the main page is now properly differentiated
759 between the developper and user version.
760 * Doc/doxygen.config.in: dropped search related obsolete flags
761 * src/gdcmParser.h, gdcmHeader.h: doxygenation
763 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
764 * DEVELOPPER: added some helpfull comments for compile/test/install
767 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
768 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
769 src directory, now generated in the build dir.
770 2. Tests as mentionned smarter
772 4. Add a new method in gdcmDict that return the PubDict by name
773 this is interesting for 3rd party lib like ITK,
774 where we could set the institution name / patient name...
776 * ENH: 1. Now the test suite is working for real
777 2. All binaries are now output in the gdcm-bin directory
778 (this was not true before)
780 2004-04-28 Jean-Pierre Roux
781 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
782 SeQuence indented printing of Dicom Header.
783 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
784 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
785 Computation of SQDepthLevel is now part of gdcmHeader constructor
786 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
787 tree-like structure of a Dicom Header.
788 * FIX Test code cleaning
790 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
791 * ENH: Adding automatic testing
792 1. Need a DartConfig.cmake to submit to public
793 2. Add a test driver gdcmTest.cxx
794 3. gdcmTestMain, an helper for the main test driver gdcmTest
795 4. Files in Test don't have a main anymore, this becomes interesting
796 when we add more and more tests, thus dsw don't have to load
798 * ENH: Adding a GDCM_DATA_ROOT for testing
799 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
800 one file instead of seven + some small cleanup
802 2004-04-22 Jean-Pierre Roux
803 * ENH Minor changes to the Print() methods.
804 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
805 Header printing. Example given with :
806 > PrintHeader fileName 2 new
807 (SQ based tree-like structure still to be done for the Header ...)
809 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
810 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
811 1. I have added some unsigned where needed
812 2. Some function parameter not used -> (void)
813 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
814 4. g++ don't like character '\' in comment
815 5. #define jpeg_create_decompress jCreaDecompress
816 this really need to be fixed
817 6. virtualize destructor of gdcmObject ... leakage
818 7. sscanf(g->first.c_str(),"%x",&gr_bid);
819 this also really need to be fixed
820 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
821 remove compression file
822 (as we only do decompression, right ?)
823 * ENH: Change malloc/calloc/free with c++ equivalent
825 2004-04-21 Jean-Pierre Roux
826 * FIX gdcmHeaderHelper::GetXSpacing
827 when a single value is found (bug ?), xpacing is now
828 defaulted to yspacing
830 2004-04-19 Jean-Pierre Roux
831 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
832 * ENH add parameters :
833 bool exception_on_error = false,
834 bool enable_sequences = false,
835 bool ignore_shadow = false
836 to the gdcmFile constructors to be full gdcmParser compliant
837 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
838 to allow reading of PAPYRUS 3.0 files
840 2004-04-06 Jean-Pierre Roux
841 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
843 2004-04-02 Jean-Pierre Roux
844 * ADD : Test/checksequence.sh, for a general recap on SQ pb
845 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
846 for Philips spurious Tag fffe|0000 while rewritting Dicom files
848 2004-03-30 Jean-Pierre Roux
849 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
850 for ACR file, written out as DICOM files (hope so...)
852 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
853 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
854 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
855 moved to base class gdcmParser and only the specialisation is kept
857 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
858 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
859 already does the job.
860 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
861 (to be consistent with gdcmParser::WriteEntries).
863 2004-03-30 Benoit Regrain
864 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
865 upate of the object's instance. It's passed to 2 in the unfavorable
866 case : one in the ExecuteInformation, one in the ExecuteData
868 2004-03-29 Jean-Pierre Roux
869 * ENH : Check on file type to be written moved
870 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
871 * FIX : gdcmObject::ResetBoundaries now stops properly
872 when end-of-list is reached
873 : gdcmVersion modified (as Benoit Regrain asked)
875 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
876 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
877 * src/gdcmUtil.cxx: added forgotten iostream include.
878 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
879 equivalent to ExplicitVR in existing code).
881 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
882 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
883 now contains all the gdcmGlobal related code.
884 * minor coding style and doxygenation changes.
886 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
887 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
888 now contains all the Debug related code.
889 * minor clean-up of includes in src/*.cxx
890 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
891 CreateCleanString) removed.
892 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
893 * Doc/DoxyMainPageUser.txt added.
894 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
895 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
898 2004-03-24 Jean-Pierre Roux
899 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
901 2004-03-23 Jean-Pierre Roux
902 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
903 big endian made volumes
904 * ENH Now gdcmParser constructor and destructor are protected to forbid
905 end user to instanciate class gdcmParser
906 (only gdcmHeader and gdcmDicomDir are meaningfull)
908 2004-03-22 Benoit Regrain
909 * FIX : src/gdcmDicomDir.cxx : make windows compilable
910 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
911 gdcmSerie to gdcmDicomDirSerie
913 2004-03-19 Jean-Pierre Roux
914 * ENH Now the tree-like structure describing a DICOMDIR comming from
915 an already existing DICOMDIR file is consistent with
916 the home-made tree-like structure build ex-nihilo
917 or build from the files held (recursively) in a Directory
918 functions gdcmDicomDir::CheckBoundaries()
919 gdcmObject::SetBoundaries() added
921 2004-03-17 Jean-Pierre Roux
922 * REM (Eric Boix bug) : removal of meaningless
923 gdcmDicomDirImage::NewImage function.
924 * FIX now file names and directory name are written properly in the
926 * FIX now gdcmDicomDir constructor may be call without any trick
929 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
930 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
931 of gdcmDicomDirImage::NewImage as empty function.
933 2004-02-28 Jean-Pierre Roux
934 * ENH add gdcmDicomDir:NewPatient
935 add gdcmDicomDirPatient:NewStudy
936 add gdcmDicomDirStudy:NewSerie
937 add gdcmDicomDirSerie:NewImage
938 to allow making gdcDicomDir object.
939 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
940 (as opposite to the gdcmHeader chained list)
942 2004-02-11 Benoit Regrain
943 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
944 when using from python
946 2004-02-10 Benoit Regrain
947 * FIX : bug fix in the gdcmDirList for the recursivity in directories
948 * FIX : in gdcmDicomDir when the directory is empty
949 * ENH : add callback and methods to get the progression of dicomDir
952 2004-02-06 Jean-Pierre Roux
953 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
954 - GDCM_META added to gdcmDicomDirType
955 - class gdcmMeta created
956 * ENH : - A brief summary is now displayed at the beginning of
957 'testDicomDir' to help disaster magnitude estimation
958 * REM : Now useless Test/explDICOMDIR.cxx
960 2004-02-05 Benoit Regrain
961 * ENH : add methods in gdcmObject to get the hash table or the list of
963 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
964 * FIX : wrapping python for TagHeaderEntryHT
966 2004-02-04 Benoit Regrain
967 * FIX : even length for some strings when writting the dicom dir
968 * FIX : sort the images in the dicom dir
969 * FIX : Bug fix for python use of dicom dir
970 * ADD : a python demo
972 2004-02-04 Jean-Pierre Roux
973 * FIX : Final solution (?) for icone embedded images
974 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
975 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
976 add groups 6002, 6004, 6006, to allow 'clean' parsing of
977 gdcmData/gdcm-MR-SIEMENS-16.acr1
978 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
979 to make full checking easier
981 2004-02-04 Benoit Regrain
982 * FIX : WriteEntries : coding style & logic in parameters
983 * FIX : Set the elements to create the DicomDir in a dictionary file
985 2004-02-03 Benoit Regrain
986 * gdcmDirList : to parse a hard drive directory in recursive (or not)
987 * gdcmDicomDir : add the load of directory
988 * Bug fix and print add-on
990 2004-02-03 Jean-Pierre Roux
991 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
992 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
993 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
994 * FIX gdcmParser.cxx : 'group length' elements are now considered
995 as integers, even for shadow groups, when file is Implicit VR
997 2004-02-02 Jean-Pierre Roux
998 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1000 of the last synonym :-(
1001 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1003 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1004 * FIX taking into account the possible 7fe0,0010 multiplicity
1005 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1006 to allow removal of references to 7fe0,0010, to deal with
1007 ACR-NEMA images, when 0028,0200 is meaningfull
1009 2004-01-31 Jean-Pierre Roux
1010 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1011 no longer writes 'Un' on disk
1012 * FIX SQ elements with actual length are now dealt with corectly
1013 * FIX gdcmFile::WriteBase make the difference, for color images, between
1014 the length (for Palette expanded images)
1015 and Raw Length (non expanded image + Palette)
1016 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1017 (that broke Write). Replaced by UL.
1018 Aware user will reload the field if he
1019 thinks it's necesssary
1021 2004-01-30 Jean-Pierre Roux
1022 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1023 when 'dirty Acr' is found, to be compliant with the new
1024 IsReadable() methods.
1026 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1027 (no DOUBLE images in kosher DICOM,
1028 but so usefull for people that miss them ;-)
1030 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1031 DICOMDIR related utilities (not checked as Windoze compliant)
1033 2004-01-28 Jean-Pierre Roux
1034 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1036 2004-01-27 Jean-Pierre Roux
1037 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1038 to allow skipping the shadow elements, to save memory space.
1039 The TRUE value for this param has to be used
1040 with a FALSE value for the 'enable_sequence' param.
1041 ('public elements' may be embedded in 'shadow Sequences')
1042 * gdcmHeader methods now deal with 'embedded icones images' in the header
1043 (even when an 'icone image sequence' is announced by the
1044 element (0x0088,0x0200), but there is NO icone at all ...
1046 * gdcmHeader sometimes Image Location value doesn't follow
1047 the supposed processor endianity (see gdcmData/cr172241.dcm).
1050 * gdcmHeader add the method
1051 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1052 to get *all* the Header Entries with the same tag.
1053 GetHeaderEntrySameName is probabely *useless*
1054 (no meaning : Name is *not* an identifier within the Dictionnary)
1056 2004-01-26 Benoit Regrain
1057 * Bug fix in the print of hexadecimal representations. Remove long fields
1058 in the print and add a third level of print to print them
1060 2004-01-23 Benoit Regrain
1061 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1062 * Bug fix on test suite after remove the strip made on not string fields
1063 * Split the IsReadable method between gdcmParser which test that the file
1064 is dicom and gdcmHeader which test that it's an image file
1066 2004-01-22 Benoit Regrain
1067 * DicomDir : clean code, add methods, set variables in protected or private
1068 * gdcmUtil : bug fix for the clean string method
1070 2004-01-19 Benoit Regrain
1071 * Add the use of shadow dictionaries
1072 * bug fix and coding style
1074 2004-01-19 Benoit Regrain
1075 * src/gdcmFile.cxx : bug fix concerning the close of file
1076 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1077 * Add the update of header entries using the shadow library
1079 2004-01-19 Benoit Regrain
1080 * removal of file gdcmHeader2.cxx
1081 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1082 inheriting from gdcmParser. This split is to prepare the integration
1083 of dicom dir parsing
1084 * bug fix under python
1086 2004-01-16 Jean-Pierre Roux
1087 * REM removal of class gdcmHeaderEntrySet
1088 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1089 * ADD add file gdcmHeader2.cxx
1090 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1092 2004-01-15 Benoit Regrain
1093 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1094 entries created while parsing the header. Thus, they will be destroyed
1095 when the gdcmDictSet will be destroyed
1096 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1099 2004-01-15 Benoit Regrain
1100 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1101 made a fatal error because of the memory release at the end of program.
1102 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1103 some memory and vtk seems to have some problems with that.
1104 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1106 2004-01-14 Benoit Regrain
1107 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1108 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1109 * src/*.[h|cxx] : make changes due to class name changes
1110 * gdcmPython/demo/*.py : bug fix due to method names
1112 2004-01-13 Benoit Regrain
1113 * src/*.[h|cxx] : coding style
1114 * vtk/*.[h|cxx] : coding style
1116 2004-01-13 Benoit Regrain
1117 * gdcmPython/testSuite.py : test the readable flag of file for tests
1118 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1119 It's lied to the stl compilation by MSVC (windows, always windows...)
1120 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1122 2004-01-12 Benoit Regrain
1123 * src/*.h : add comments
1124 * src/gdcmDictSet.h : set the method BuildDictPath in public
1125 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1126 directly setted in the source code
1127 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1130 2004-01-09 Benoit Regrain
1131 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1132 * setup.py : use a reference to gdcmVERSION
1134 2004-01-07 Benoit Regrain
1135 * Modification to compile with the distutils.
1138 2003-12-10 Benoit Regrain
1139 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1140 can use a gdcmHeaderHelper to load datas
1141 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1142 made in the source code
1144 2003-12-10 Benoit Regrain
1145 * Update Windows projects and .cvsignore files
1147 2003-11-12 Jean-Pierre Roux
1148 * ENH gdcmHeader constructor has one more parameter (default value : false)
1149 that allows the user to 'go inside' the SeQuences only
1151 gdcmElValSet:Print takes it into account
1153 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1154 * ENH: Update gdcmPython/CMakeLists
1155 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1156 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1158 2003-11-10 Jean-Pierre Roux
1159 * FIX : gdcmHeader::LoadElements is now based
1160 on the ListTag listElem member,
1161 not longer on the TagElValueHT tagHt member
1162 * ENH : PrintPubElVal shows (temporarily) both results,
1163 with the tagHt member and the listElem member.
1164 (it's easier to 'see' the problems when using Printheader)
1166 * FIX : old private member LgrElem is now splitted into
1167 ReadLength : Length actually found on disk (updated only
1168 if bug fixing is necessary), for internal
1170 UsableLength : Updated by FixFoundLength, to fix a bug
1171 or to allow Parser going on.
1172 Will allow to re-write a kosher header when a SeQuence
1173 with a length (not 0000) is found
1174 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1175 because gdcmElValSet::Add does not update ListElem
1178 2003-11-07 Jean-Pierre Roux
1179 * FIX misstyping in Transfert Syntax name table
1180 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1181 when they have an actual length (not 0000 nor FFFFF)
1182 (Nobody should care of it, but DICOMDIR explorers)
1184 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1185 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1187 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1188 * ENH: vtkGdcmReader now supports LUT !
1189 (vtkgdcmViewer for now is not able to use them though)
1191 2003-11-05 Jean-Pierre Roux
1192 * in testSuite.py : new files names for checking the package
1193 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1194 that returns the pixel area size to the *aware* (vtk) user
1195 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1197 2003-11-05 Benoit Regrain
1198 * in testSuite.py : Modify the rules for checking the paths
1199 : Explicit error messages
1200 * in __init__.py : Related modif
1202 2003-11-03 Jean-Pierre Roux
1203 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1204 to be used by aware (vtk) users that want to manage
1205 LUT (and no to turn the PALETTE image into an RGB pixels one)
1206 * GetPixelType now returns 8U for 24 Bits images
1207 (vtkGdcmReader compliant)
1209 2003-10-31 Jean-Pierre Roux
1210 * Removal of *all* gdcmData images and add them again
1211 in order to loose the 'history' of un-anonymised images
1213 2003-10-31 Jean-Pierre Roux
1214 * RMV : removal of useless jBitsInJsample.h
1215 for both 8 and 12 Bits JPEG Lossy Libraries
1217 2003-10-31 Jean-Pierre Roux
1218 * ENH : Add the functions gdcmFile::GetImageDataRaw
1219 gdcmFile::GetImageDataIntoVectorRaw
1220 that act as GetImageData and GetImageDataIntoVector
1221 except the making of an RGB Plane from Gray Plane + LUT
1222 Intended to aware (vtk) users who know how to manage
1225 GetLUTRGBA return a R,G,B,A LUT if any
1226 lgrTotaleRaw gives the 'Raw' length
1227 GetImageDataRaw returns the gray Plane
1228 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1229 (They stay Grey, just like with other Dicom viewers :-(
1231 2003-10-30 Jean-Pierre Roux
1232 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1234 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1235 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1236 being coherents dicom files.
1238 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1239 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1241 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1242 * ENH: Two steps is necessary to please VC++ compiler...
1243 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1244 * ENH: Add include dir to medcon lib
1245 * FIX: only one function is being exported for now !
1246 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1248 2003-10-29 Jean-Pierre Roux
1249 * adding gdcmHeader::GetLUTRGBA
1250 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1251 --> Mathieu, the modif u're waiting for is not yet committed
1252 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1254 2003-10-27 Jean-Pierre Roux
1255 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1256 00191113.dcm DermaColorLossLess.dcm
1257 MxTwinLossLess.dcm RadBWLossLess.dcm
1258 * ENH: For version prior to vtkImageViewer2 -r 1.19
1259 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1261 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1262 * Removal of ido stuff in CMakeLists.txt
1264 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1265 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1266 * FIX: remove a call to ->Modified ... see comments
1267 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1269 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1270 * FIX: Problem with path for libvtkgdcmPython
1271 * ENH: Try adding a search script for python site-package
1272 * RMV: Remove some file from medcon lib that are not necessary
1273 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1274 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1275 * FIX: More pragma disable fro VC++,
1276 I don't think I break something as it is also disable in VTK/ITK.
1277 But it fasten debug compilation time.
1279 2003-10-23 Jean-Pierre Roux
1280 * gdcm now deals with 16 Bits Run Length Encoded images
1281 (they are compressed as 2 planes images,
1282 one for the high Bytes, the other for low Bytes)
1284 2003-10-22 Jean-Pierre Roux
1285 * Now CheckRead takes into account :
1286 - the bugged 'Leonardo' Siemens images
1287 - the XA images, sent thru the burning VPRO station
1288 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1291 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1292 * FIX: When copying a Makefile.am to CMakeLists.txt
1293 one should remove the '\'
1295 2003-10-22 Jean-Pierre Roux
1296 * in gdcmData adding a bugged 'Leonardo' Siemens image
1297 (wrong lengths in header)
1298 OK with gdcm, KO with the other viewers :-)
1299 * add a GE dlx XA image, thru the VEPRO burning station
1302 2003-10-21 Jean-Pierre Roux
1303 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1304 for a brutal checking of vtkgdcmViewer compliance
1306 2003-10-21 Jean-Pierre Roux
1307 * add the files for 'xmedcon' Jpeg Lossless library
1308 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1310 2003-10-21 Jean-Pierre Roux
1311 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1313 2003-10-21 Jean-Pierre Roux
1314 * garbage Siemens 'Leonardo' images dealt with
1315 (the patch is easy to remove)
1316 * cosmetic changes to avoid warnings
1318 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1319 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1320 no need to press 'r' now.
1322 2003-10-20 Jean-Pierre Roux
1323 * upgrade of checkRead.sh checkWrite.sh according
1324 to new Jpeg Lossless decompressor
1325 * add US.3405.1.dcm, a genuine RGB medical file ...
1326 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1327 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1329 2003-10-15 Jean-Pierre Roux
1330 * general anonymisation in gdcmData
1331 * adding the 'color files' from
1332 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1333 * adding some well knowed bugged-header images
1334 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1335 waiting for their inclusion in Python testsuite
1337 2003-10-15 Jean-Pierre Roux
1338 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1339 no longer seg faults when file is not found
1341 2003-10-14 Jean-Pierre Roux
1342 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1345 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1346 * TODO: *.in file to genereate a UseGDCM later
1348 2003-10-14 Jean-Pierre Roux
1349 * Some supposed-to-be Dicom Images have no preamble.
1350 OpenFile takes it into account
1351 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1352 * Missing elements added in dicomV3.dic
1353 (just to be affraid : have a look at
1354 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1355 and do it again next year ;->
1357 2003-10-13 Jean-Pierre Roux
1358 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1359 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1360 But there are NOT. It's fixed !
1362 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1363 * FIX: "jpeglib.h" was not found on VC++
1364 * FIX: vtkgdcm was not being installed
1366 2003-10-10 Jean-Pierre Roux
1367 * ENH : OpenFile closes the file if it *really* doesn't look like
1368 an ACR-NEMA / DICOM one.
1369 * FIX : testWrite no longer writes an empty file if the source file
1370 is not gdcm Readable
1371 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1374 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1375 * FIX: CMake generate now documentation
1376 * ENH: out of source doc build !
1377 * ENH: Generate both user and dev documentation
1378 * ENH: Should work on windows too
1379 * ENH: Only one doxygen config.in file is needed
1380 * FIX: make install should be ok now on ùnix plateform
1381 * FIX: PATH to dictionary was wrong (missing /)
1382 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1384 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1385 * vtkGdcmReader is now able to read rgb dicom file.
1386 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1387 * added a gdcmViewer to vtk test, use mouse to control
1388 window level & window width
1390 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1391 * CMake-ification of gdcm, we have now two build system
1392 * FIX: on cygwin Wsock32 doesn't exist
1393 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1395 2003-10-06 Emanuel Ollart
1396 * FIX : compilation process wad broken.
1397 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1399 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1400 * change gdcmViewer -> vtkgdcmViewer
1401 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1403 2003-10-06 Jean-Pierre Roux
1404 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1405 ( e.g : well known GE images with a wrong elem length,
1406 : Philips MRI Images with a wrong Huffman table)
1407 * still to be done : allow the reading of bugged LEONARDO Siemens images
1409 2003-10-03 Jean-Pierre Roux
1410 * Odd length strings are padded with '\0' (not with spaces,
1411 to remain compliant with already defined strings,
1412 like Transfert Syntax UID and others)
1414 2003-10-03 Jean-Pierre Roux
1415 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1416 to allow displaying RGB images (not only by affim ;-)
1418 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1419 * vtkGdcmReader is now able to read rgb dicom file.
1420 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1422 2003-10-03 Jean-Pierre Roux
1423 * A few nasty patches to allow the reading of a lot of nasty images
1424 ( e.g : well known GE images with a wrong elem length,
1425 : Philips MRI Images with a wrong Huffman table)
1426 * still to be done : allow the reading of bugged LEONARDO Siemens images
1428 2003-10-03 Jean-Pierre Roux
1429 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1431 2003-10-03 Jean-Pierre Roux
1432 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1433 to allow displaying RGB images (not only by affim ;-)
1435 2003-10-03 Jean-Pierre Roux
1436 * gdcmFile::GetImageDataIntoVector now
1437 - deals with MultiFrames MultiFragments Run Length Encoded files
1438 - deals with YcBcR (YBR_FULL) files
1439 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1440 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1442 (no sample found :-(
1444 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1445 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1446 Two reasons: - clear things
1447 - third parties acces gdcm through header files, so won't
1448 suffer anymore VC++ complains
1450 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1451 * add argv[1] in testvtkGdcmReader.cxx
1454 2003-09-24 Jean-Pierre Roux
1455 * The lines are now eigthy characters long.for
1456 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1458 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1459 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1460 char* to std::string. Thus, the use of strdup becomes useless. (see
1461 previous commis of Malaterre)
1462 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1463 before the last Malaterre's commit.
1465 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1466 * This commit should fix the Debug building under VC++, the problem
1467 was mainly a mixture of debug and release lib being loaded at startup.
1468 * I also remove a depency to a specific C function: strdup. Because I had
1469 to force the link to msvcrtd (whereas strdup is in libc).
1471 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1472 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1473 located in the gdcmCommon.h file. All use of reference of tha has been
1474 changed to now use the variable GDCM_UNFOUND.
1476 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1478 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1479 Dicom dictionary. The test suite can now be run again. Note:
1480 I'm note very happy with the " (RET)" changes. I believe this
1481 RETAINED comment should be dropped when parsing the dictionary.
1482 - PACKAGER corrected
1484 - AUTHORS updated and now in alphabetical order
1485 * Makefile.am now exports gdcm.dsw for Windoze users.
1487 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1488 * cygwin complains about missing std:: in subdir Test/
1490 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1491 * remove some methods that are now in gdcmHeaderHelper
1493 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1494 * vtkGdcmReader set spacing and origin correctly
1496 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1497 * Fix a few delete/delete[] mismatch
1499 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1500 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1501 interpretation to data given by gdcmHeader. For instance there are
1502 heuristics to get informations (look at different places).
1503 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1504 sorting DICOM images based on different strategies.
1505 * modified Makefiles accordingly.
1507 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1508 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1509 when building in debug mode
1510 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1511 src/win32/gdcmdll.dsp
1512 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1514 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1515 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1518 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1519 * src/win32/libgdcmjpeg12.dsp was not dos format
1520 * src/win32/libgdcmjpeg12.dsp :
1521 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1522 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1524 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1525 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1527 * src/gdcmFile.cxx : bug fix in affectation type
1528 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1529 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1530 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1531 symbols... future problem ?
1533 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1534 * src/win32/libgdcmijpeg12.dsp was missing
1535 * modified gdcm.dsw accordingly
1537 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1538 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1540 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1541 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1542 commit of JPR (before his hollidays to facilitate our work).
1543 * setup.py : bug fix in code. Modifications made while the last commit
1544 of JPR. The code hasn't been tested before the commit... it's so
1545 useless to make that (for best programmer that is JPR) !!!
1547 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1548 * tagged the current version as Version0_3 (i.e. version 0.3)
1550 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1551 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1552 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1553 * *.dsp : modifications to use new libgdcmijpeg8 library
1554 * setup.py : bug fix on VTKPATH variable
1555 * PACKAGER : adding all concerning windows
1557 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1558 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1560 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1561 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1562 test suite reported error.
1563 * PACKAGER file added (describes what a packager must do when
1564 packaging a new release).
1565 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1566 * configure.in: upgraded version number to 0.3.0
1567 * fixing build of rpm (through rpm -ta):
1568 - Doc/Makefile.am exports proper doxygen files
1569 - src/jpeg/libijg8/Makefile.am exports the include files.
1571 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1572 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1573 * src/gdcmHeader.h : formatting code
1575 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1576 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1577 We were obtaining error message from vtk. Now, creation of file list
1578 is made in an internal list to prevent this problem.
1579 Bug fix when output is empty.
1580 Bug fix in update of progress value. Previous commit for this was a bad
1582 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1584 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1585 * src/gdcmHeader.h : added method to get the file name
1586 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1587 files. Added method to remove all files on the input
1588 Added FIXME comment concerning the bad parsing of header made by
1589 ExecuteInformation method (in ExecuteData method)
1591 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1592 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1593 when using make instal.
1594 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1595 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1597 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1598 * setup.py : adding include dir of jpeg lib to compile all sources
1599 * */Win32/*.dsp : JPR fix for windows compilation
1601 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1602 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1604 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1605 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1607 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1608 * setup.py is again effective on un*x (takes into account the
1609 addon of the jpeg library)
1610 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1611 * Doc/Doxy* updated (includes above enhancements)
1612 * INSTALL now points to web documentation
1614 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1615 * src/gdcmHeader.h doesn't make unnecessary reference to
1617 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1619 * src/gdcm*.[cxx|h] :
1620 - to allow compilation with gcc 3.x
1621 -- clean up of STL usage (added explicit usage of std::)
1622 -- small fixes on exceptions.
1623 Note: linking not tested !
1624 - clean of doxygen comments to avoid warnings at documentation
1626 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1627 dependent convertion).
1629 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1630 * Clean up of previous JPR garbage commit (not even commented in the
1632 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1633 - moved all jpeg related files from src to src/jpeg/libijg8, with
1634 addition/modification of Makefile.am and configure.in.
1635 - the testSuite is still brain damage (not guilty).
1637 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1638 * WrapVTK.py : modifications to get correctly vtk source files to
1640 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1641 (FileName -> Filename)
1643 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1644 * vtk/vtkGdcmReader.[cxx/h]:
1645 - UpdateProgress method should now be effective
1646 - removed the limitation on having only images loaded (as opposed
1648 - when building a stack of images/volume, a lesser number of
1649 gdcmHeader and gdcmFile instances should be used (hopefully
1650 accelerating things).
1651 - when building a stack of images/volumes, files which are not
1652 loadable (wrong path-filename, wrong permissions on existing file,
1653 or file not parsable by gdcm) are replaced with a black image
1654 in the stack (for the caller to notice the problem).
1656 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1657 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1659 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1660 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1661 between standard library (std) and vtk library (problems are found
1662 under Windows... thanks Windows !)
1664 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1665 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1667 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1669 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1670 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1672 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1673 * When compiling with distutils (see setup.py) the C++ compiler is
1674 called with different flags than the default ones (with automake).
1675 In order to fix all those warning, I compiled gdcm with the command
1676 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1677 and went for warning fixes:
1678 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1679 up from unused variables.
1680 - vtk/vtkGdcmReader.cxx: potential bug fix.
1681 * src/gdcmHeader.h: Doxygen warning cleanup
1683 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1684 * gdcmPython/gdcm.i:
1685 - typemaps correction to take into account the systematic replacement
1686 of "using namespace std" with std:: prefix e.g. std::list,
1687 std::string... (cf changes of 2003-05-21).
1688 - gdcmGlob global variable of type gdcmGlobal (defined in
1689 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1690 exported to Python a as cvar.
1691 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1692 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1693 gdcmDictSet.GetPubDictTagNames() and
1694 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1695 C++ static methods).
1696 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1697 with the above changes.
1699 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1700 * setup.py, manifest.in : bug fix under linux
1702 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1703 * Modification of setup.py to compile vtk part too. Then, we have 2
1704 wrappers which must work with same distutils. For that, we have a
1705 generic distutils in distusiltsWrapping.py ; with :
1706 - build_extWrap class to wrap generically all extensions,
1707 - ExtensionWrap base class for all wrapping extension that contains
1709 - Wrapper interface which wrap sources
1710 + In WrapSwig.py we have extension and wrapper for Swig
1711 + In WrapVTK.py we have extension and wrapper for VTK
1712 * MANIFEST.in : modifications to consider vtk directory and new python
1713 files for compilation
1715 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1716 * Added python wrappers of vtkGdcmReader vtk class (see the
1717 source in vtk/vtkGdcmReader.cxx) :
1718 - vtk/Makefile.am now builds a library
1719 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1720 python library (as opposed to _gdcm.so wich are the python
1721 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1722 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1724 - configure.in has an additional flag --enable-vtk that needs
1725 to be set to enable compilation of vtk related code, that is:
1726 + vtk/vtkGdcmReader.so and
1727 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1728 + gdcmPython/vtkgdcmPython.so (see above)
1729 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1730 be read when compressed or when HighBit + 1 != BitsStored),
1731 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1732 the usage of the python wrapper of vtkGdcmReader vtk class.
1733 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1734 * src/*.[h] all occurences of stl classes are now prefixed with
1735 std::, and all occurences of "using namespace std;" where removed.
1736 This is to avoid pollution of global namespace in included files.
1737 Apparently vtk does not avoid this pitfall: when using both
1738 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1739 collision of various stl members (principally cout...).
1740 * gdcmPython/testSuite.py now cleanly removes temprory generated
1742 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1743 comply with above changes)
1745 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1746 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1747 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1748 vtk data structure (an image Flip was required).
1749 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1750 * cosmetic changes in documentation.
1752 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1753 * src/gdcmHeader.cxx: the constructor no longer exits when an
1754 unexisting file is given as argument.
1755 * The subdirectory Data (containing all the images used for the
1756 test suite) is not part of this repository anymore. A new module
1757 containing those images is now available at
1758 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1759 with the name gdcmData.
1760 All the python scripts (including the package initialisation file
1761 gdcmPython/__init__.py) were adapated to take this change into
1762 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1764 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1765 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1766 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1767 demo of the usage of this class.
1768 Compilation of this vtk part is only done when using the --enable-vtk
1769 at configure (or autogen.sh) stage.
1771 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1772 * More memory link related corrections and documentation fixes.
1774 - maximum info is obtained with a command of the form:
1775 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1776 --show-reachable=yes PrintHeader
1777 - the remaining reachable blocks seem to come from the STL
1778 allocation scheme through the usage of map and list. It looks
1779 like this memory cannot be freed but it is not a memory leak
1780 (in fact further invocation to the STL would recollect the
1781 unused memory allthough it cannot explicitely be freed).
1782 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1783 of displaying an image parsed with gdcm and displayed with VTK.
1784 Note: some images don't seem to work e.g.
1785 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1786 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1787 Allthough this weakens the semantics, it is a ditch attempt to
1788 make gdcm more thread friendly.
1790 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1791 * Memory link hunt (by using valgrind through the command
1792 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1793 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1794 gdcmHeader::_dicom_vr.
1795 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1796 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1798 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1800 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1801 * src/Makefile.am now exports all the necessary include files at
1805 * UpdateGroupLength replaced by new one
1808 * UpdateGroupLength re-written using H-Table
1809 (named UpdateGroupLengthNew untill checks are over)
1811 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1812 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1813 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1815 - gdcmHeader::GetPubElValSet removed.
1816 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1817 UpdateGroupLength, WriteElements, Write.
1818 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1819 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1820 carried the same semantics.
1821 - src/gdcmHeaderIdo.cxx changed accordingly.
1822 - gdcmFile::WriteBase now regroups all the codes from previous
1823 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1824 - enum FileType moved to gdcmCommon.h
1825 * src/gdcmHeader.cxx AddDefault trashed
1826 * gdcmGetXSize added
1827 * getimageDataSize now calls gdcmGetXSize
1828 * Test/*.cxx changed to agree with above changes
1830 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1831 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1832 (to avoid double call by end user).
1833 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1834 by end user, since gdcmHeader::gdcmHeader now handles it.
1836 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1837 * gdcm/Doc many doxygen changes:
1838 - Doxyfile now has two different versions, DoxyfileUsers that generates
1839 the html.users end users oriented documentation and
1840 DoxyfileDeveloppers that generates the html.developper developper
1841 oriented documentation.
1842 - README changed accordingly
1843 - requirement.txt removed (old design info moved to TODO).
1844 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1845 DoxyMainPage.txt, DoxyPython.txt provide more information.
1846 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1847 be updated by simply regenerating the docs with doxygen and copying
1848 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1849 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1850 all the tests in the form "if (<map>.count() >1)" were removed.
1851 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1852 ill-formed documentation sections.
1853 * src/gdcmHeader.cxx: ditto
1855 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1856 * setup.py fixed for un*x (needed macro for stdint.h)
1857 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1858 un*ces with sh-utils test utility.
1859 * gdcmPython/demo/test.py renamed to PrintHeader.py
1860 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1861 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1862 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1863 * src/gdcm*.cxx JPR's bad inclusion fixed.
1865 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1866 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1867 * gdcmPython/demo/test.py changed accordingly.
1869 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1870 * gdcmPython/Makefile.am fixed linking against libstdc++
1871 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1872 * Swig subdir (historical tests of swig version 1.3.17++) removed
1873 * Test/testChangeEntete.cxx some lines commented out in order to make
1875 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1876 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1878 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1879 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1880 hence the user doesn't need this explicit call.
1881 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1882 i.e. LoadElements() call removed.
1883 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1884 - src/Makefile.am declares the proper flag for g++.
1885 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1886 for adding user defined new tags.
1887 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1888 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1889 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1891 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1892 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1893 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1894 src/Makefile.am : the project should properly compile and install
1895 with the autotools, included the python wrappers part.
1896 * gdcm.spec.in : added a spec file for RPM packaging.
1898 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1899 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1901 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1902 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1903 to exported to the environement (see gdcmPython/testSuite.py
1905 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1906 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1907 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1908 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1909 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1911 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1912 * gdcmPython/__init__.py doesn't crash anymore when running in
1913 in InstallMode or PreInstallMode but with an environement given
1914 value of GDCM_DICT_PATH.
1915 * src/gdcmDictSet.[cxx/h] coding style.
1917 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1918 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1919 * src/gdcm.h general comments moved to TODO, and README
1920 * src/gdcm.h should now be seen as a user commodity (including it
1921 should suffice to fully use gdcm). It is nowhere including within
1922 any of the kernel files src/*.cxx and src/*.h.
1924 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1925 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1926 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1928 * src/gdcm*.cxx only include their corresponding include file
1929 (as opposed to gdcm.h)
1930 * gdcmPython/gdcm.i changed accordingly
1931 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1932 the autogen.sh generated "make snapshot" command to work.
1933 * autogen.sh removed history related references to crea package.
1935 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1936 * distutilsSwigCPlusPlus.py work around some swig portability
1939 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1940 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1941 was done in a last ditch attempt to get setup.py _really_
1942 operationnal. The python/gdcmPython layaout add the advantage
1943 of hidding away the python related distutils specific files
1944 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1945 Alas, the src directory was out of scope (i.e. it's relative
1946 position to setup.py was ../src) which made things impossible to
1947 handle (see previous version of python/setup.py). Crossing fingers...
1949 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1950 * python/setup.py now works on Un*x. (harder than I thougth)
1951 * python/distutilsSwigCPlusPlus.py can now have include files
1952 among the list of sources.
1954 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1955 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1956 * modifications in MSVC projects
1958 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1959 * As stated by the first lines of Test/ExceptionAndPython/README, it
1960 looks like we can move back to original usage of exception within
1961 src/gdcm* and hence remove the errno stuff that was introduced
1962 as a quick and dirty fixture of this problem (added to the TODO).
1963 * Doc/Doxyfile configuration file for Doxygen and corresponding
1964 README file for usage added.
1965 * Test/testWrite.cxx added. This new test comes from a split of
1966 test.cxx that is now reverted to its original purpous i.e.
1967 testing the proper parsing of a Dicom related file.
1968 testWrite.cxx concentrates on testing the IO part of gdcm.
1969 * Test/bug1.cxx (containing a bug on WIn32) added.
1970 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1971 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1972 whose purpose is to publish the content of the TagNames of the
1973 Dicom public dictionnary were not accessible without an
1974 instance of class gdcmHeader.
1975 - those methods are now static methods of gdcmDictSet and hence
1976 require no instances at all to be invocated.
1977 - within gdcmDictSet this change required to change some method
1978 to class methods (i.e. are now static) among which SetDictPath
1979 (renamed to BuildDictPath) and LoadDefaultPubDict.
1980 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1981 the above changes by calling the new method classes of gdcmDictSet.
1982 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1983 the above to be effective.
1984 * python/gdcmPython: in order to wrap properly the above changes
1985 for Python, swig version now needs to be > 1.3.17.
1986 * python/gdcmPython/Makefile fixed to adapt itself to new
1987 configure/make shema introduced by Johan Montagnat (thanks for the
1988 contribution). Alas this Makefile cannot be turned into a proper
1989 Makefile.am without some heavy changes in the configure.in
1990 (for python dectection).
1991 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1992 now avoids publishing the empty entries.
1994 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1995 * python/setup.py : bug fix concerning install under windows
1996 ExtraPath reused :-P
1997 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1999 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2000 * Dicts/dicomV3.dic : remove double spaces !!!
2001 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2002 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2005 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2006 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2007 method. Doxygenation.
2008 * src/gdcm.h clean up of JPR spurious comments.
2010 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2011 * python/distutilsSwigCPlusPlus.py now properly collects the
2012 shadow classes generated by "swig -c++" (gdcm.py in our case)
2013 when using "python setup.py install".
2014 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2015 reexports the working classes.
2016 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2017 by the classical C errno scheme. This is to prevent an obscure
2018 behavior of the python wrappers when importing wxPython.wx prior
2019 to gdcmPython (which ended up in an abort call). An illustration
2020 of this oddity can be found in the Test/ExceptionAndPython
2021 subdir (see the README file). This problem probably due to
2022 an combination of g++ and dynamic loading.
2023 * added Test/ExceptionAndPython (see above)
2025 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2026 * Changed the layout of the python part to avoid bloating main
2027 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2028 i.e. the distutils arsenal. All the python related stuff is
2029 again in a python subdir, but the package itself is now in
2031 * setup.py was cleaned up:
2032 - pythonIncludePath removed
2033 - python setup.py bdist target is now functional.
2034 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2035 collision with other packages). gdcmPython/demo/*.py changed
2038 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2039 * python subdir moved to gdcmPython (preparation of distutils packaging).
2040 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2041 distutils installer is operational.
2042 * - gdcmPython/__init__.py now properly loads the swig generated
2043 shadow classes (from gdcm.py).
2044 - gdcmPython/demo/*.py changed to import the package gdcmPython
2045 instead of gdcmPython/demo/load.py.
2046 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2048 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2049 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2050 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2051 entries within the associated public Dicom dictionary resp. the same
2052 information but sorted by the fourth field (PAT, IMG, DIR) of the
2054 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2055 are now in the "???" group.
2056 - python/gdcm.i changed accordingly,
2057 - python/demo/printGroupedPublicDict.py added, that gives an example
2058 of the above new functionalities in Python.
2060 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2061 * src/gdcm.h, gdcmHeader.cxx:
2062 - historic references to glib's g_malloc and g_free (#defined)
2063 were definitively removed.
2064 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2065 * src/gdcmElValSet.cxx:
2066 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2067 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2068 - GetElValue(string) renamed to GetElValueByName.
2069 - Added GetElementByName(string).
2070 * src/gdcmHeader.cxx: added
2071 - GetPubElValRepByNumber(guint16, guint16)
2072 - GetPubElValRepByName(string)
2073 - GetShaElValRepByNumber(guint16, guint16)
2074 - GetShaElValRepByName(string)
2075 - GetShaElValByNumber(guint16, guint16)
2076 - GetShaElValRepByName(string)
2077 - GetElValRepByNumber(guint16, guint16)
2078 - GetElValRepByName(string)
2079 - GetElValByNumber(guint16, guint16)
2080 - GetElValRepByName(string)
2081 * Doc/requirements.txt added.
2083 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2084 * Test/Makefile building now depends on the one of libgdcm.so
2085 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2086 pixel data) aware which enables finding the address (offset) of
2087 the pixel data of JPEG encoded DICOM files. This leaves only a single
2088 file in the testSuite whose pixel data address (offset) is unknown.
2089 * python/testSuite.py changed accordingly.
2091 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2092 * VC++ has some strong limitations when working with the STL, as stated
2093 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2094 "Also note that some STL containers (map, set, queue, list, deque)
2095 cannot be exported. [...]
2096 Some STL classes contain nested classes. These classes can not
2098 This is caused by a designed limitation that once a template
2099 class is instantiated, it can not be re-instantiated and
2101 Since our usage of map<> is ubiquitous in gdcm, this "designed
2102 limitation" of VC++ is a pitfall.
2103 Hence the Python wrappers of gdcm cannot be incrementally linked
2104 against the c++ dynamic library. The dirty but only workaround is
2105 to forget about incremental link of dynamic libraries and to generate
2106 the Python wrappers library with the inclusions of the underlying C++
2108 The following modifications concern this matter on Win32/VC++:
2109 - wrapping python correct with standalone wrapped dll (don't use separate
2110 dll under windows !!!!)
2111 - python21_d debug mode enabled (ask Frog how to use it :-)
2112 - NO problem with having an STL member of class for example string in C++
2113 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2114 - Python test of dcmlib in Python is ok under windows on a large set
2116 * removed glib references
2117 * typedef's inserted in gdcm.i for correct swig type management
2119 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2120 * python/demo/*.py load.py extracted from test.py. Added explore.py
2121 that only displays required tags and testAll.py that parses all
2122 the files of the testsuite without using unittest.
2123 * python/testSuite.py other additional test on new files added.
2124 * Data/* new test files added accordingly to the testSuite.
2125 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2126 the vr in the file differs from the one of the dictionary.
2128 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2129 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2130 values, but limits itself to values which are below a user specified
2131 size (by default 1024 bytes).
2132 * python/gdcm.i : elements not loaded (because their size is above the
2133 user specified treshold) are exported with their TagKey as key of the
2134 python dictionary. This enables the testsuite to make some checks
2135 on the unloaded elements (since we have their offset and size).
2136 * python/testSuite.py
2137 - now tests for the existence and proper value of the pixel data
2138 - two new examples added.
2139 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2141 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2142 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2143 aware. See the strategy comments in gdcmHeader::FindeLength().
2144 * Test/test.cxx now accepts a filename as first argument.
2145 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2146 * python/testSuite.py changed to integrate test on above files.
2148 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2149 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2150 the vr was also RET.
2151 * python/testSuite.py more tests added.
2153 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2154 * python/testSuite.py unittest test suite added (uses Data)
2155 * Data/* dcm and acr files for the test suite.
2156 * glib dependance removed from un*x version. We now use ISO C99
2157 7.18 Integer types (see stdint.h)
2158 - python/Makefile, src/Makefile src/gdcm.h
2159 * src/ when an explicit vr (like dicom files) suddenly poped an
2160 implicit element we use to mark the underlying DictEntry of the
2161 concerned ElValue with "Implicit". This strategy was damageable
2162 too the public or provite dictionaries, since some of their vr
2163 would be changed. Since Header::FindLength heavily relies on the
2164 detection by Header::FindVR of falsely explicit elements, I
2165 added an extra ImplicitVr member to ElValue (boolean).
2166 The rest of the changes we the necessary adaptations.
2168 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2169 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2171 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2173 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2174 * Adaptation for porting to VC++:
2176 o forced to use std namespace (for string to be known)
2177 o all class use __declspec export style on WIN32
2178 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2179 (in stdlib.h on Win32 but in std:: for gcc)
2180 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2181 variable GDCM_DICT_PATH.
2182 * src/gdcmHeader.cxx verbose comments made discrete.
2184 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2185 * python/gdcm.i: added a typemap that converts a C++ hashing table
2186 to native Python dictionary.
2187 * python/demo/test.py:
2188 - now uses the native dictionary for exploration of gdcmHeader.
2189 - takes an optional filename argument (the file to parse).
2190 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2191 PubElVals hashing table.
2192 * Dicts/dicomV3.dic removed error prone trailing spaces.
2194 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2195 * Python wrapping process moved away from src/Makefile to
2196 newly created python/Makefile (as well as gdcm.i)
2197 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2198 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2199 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2200 from the environement variable GDCM_DICT_PATH (when existing).
2201 * src/gdcmDict::GetTag bug fix.
2203 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2204 * Straightforward temporary fixes for swig to build the python wrappers.
2205 src/Makefile now has a python working entry [by working we mean
2206 that we can import de shadow classes without errors].
2208 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2209 * hashtest.cxx removed (since allready in Test)
2210 * src/gdcmlib.h renamed to src/gdcm.h
2211 * src/dcm.i renamed to src/gdcm.i
2212 * src/Makefile prepared for python wrapping
2214 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2215 * src/gdcmHeader.cxx :
2216 - Parsing of header is now separated from loading of element values
2217 (see gdcmHeader::LoadElements).
2218 - general clean up of hopefully all file access (creation of
2219 ReadInt16 and ReadInt32)
2221 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2222 * src/gdcmHeader.cxx :
2223 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2225 - SetLgrElem renamed to SetLength
2226 - GetLgrElem renamed to GetLength
2227 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2228 * src/gdcmElValSet.cxx fixed both GetElValue methods
2229 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2230 due to IdoDude was cleaned out.
2232 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2233 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2234 concentrates on finding the value representation (when it exists).
2235 RecupLgr now only finds the element value length, and it avoids
2236 returning the unecessary skL (skipped length).
2237 Also, offsetCourant was simply removed (with taille_fich) since
2238 it was redundant with the File position internals (by using
2239 ftell and fseek). This also made skL (see above in RecupLgr) usage
2241 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2242 on the libido specificities which are handled through class
2244 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2247 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2248 * Truckload of changes. Parsing of header is barely functional
2249 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2251 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2252 * src/gdcmHeader.cxx many addons of low level methods
2254 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2255 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2256 and _IdDcmSWAP_LONG.
2258 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2259 * This corresponds to all the changes decided at the meeting of
2260 May 23 2002. Needless to say we are running late...