1 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3 * modifications in MSVC projects
5 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
6 * As stated by the first lines of Test/ExceptionAndPython/README, it
7 looks like we can move back to original usage of exception within
8 src/gdcm* and hence remove the errno stuff that was introduced
9 as a quick and dirty fixture of this problem (added to the TODO).
10 * Doc/Doxyfile configuration file for Doxygen and corresponding
11 README file for usage added.
12 * Test/testWrite.cxx added. This new test comes from a split of
13 test.cxx that is now reverted to its original purpous i.e.
14 testing the proper parsing of a Dicom related file.
15 testWrite.cxx concentrates on testing the IO part of gdcm.
16 * Test/bug1.cxx (containing a bug on WIn32) added.
17 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
18 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
19 whose purpose is to publish the content of the TagNames of the
20 Dicom public dictionnary were not accessible without an
21 instance of class gdcmHeader.
22 - those methods are now static methods of gdcmDictSet and hence
23 require no instances at all to be invocated.
24 - within gdcmDictSet this change required to change some method
25 to class methods (i.e. are now static) among which SetDictPath
26 (renamed to BuildDictPath) and LoadDefaultPubDict.
27 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
28 the above changes by calling the new method classes of gdcmDictSet.
29 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
30 the above to be effective.
31 * python/gdcmPython: in order to wrap properly the above changes
32 for Python, swig version now needs to be > 1.3.17.
33 * python/gdcmPython/Makefile fixed to adapt itself to new
34 configure/make shema introduced by Johan Montagnat (thanks for the
35 contribution). Alas this Makefile cannot be turned into a proper
36 Makefile.am without some heavy changes in the configure.in
37 (for python dectection).
38 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
39 now avoids publishing the empty entries.
41 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
42 * python/setup.py : bug fix concerning install under windows
44 * gdcm.dsw : bug fix concerning path for libraries for python !!!
46 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * Dicts/dicomV3.dic : remove double spaces !!!
48 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
49 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
52 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
53 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
55 * src/gdcm.h clean up of JPR spurious comments.
57 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
58 * python/distutilsSwigCPlusPlus.py now properly collects the
59 shadow classes generated by "swig -c++" (gdcm.py in our case)
60 when using "python setup.py install".
61 * python/gdcmPython/__init__.py imports gdcm.py and only manually
62 reexports the working classes.
63 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
64 by the classical C errno scheme. This is to prevent an obscure
65 behavior of the python wrappers when importing wxPython.wx prior
66 to gdcmPython (which ended up in an abort call). An illustration
67 of this oddity can be found in the Test/ExceptionAndPython
68 subdir (see the README file). This problem probably due to
69 an combination of g++ and dynamic loading.
70 * added Test/ExceptionAndPython (see above)
72 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
73 * Changed the layout of the python part to avoid bloating main
74 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
75 i.e. the distutils arsenal. All the python related stuff is
76 again in a python subdir, but the package itself is now in
78 * setup.py was cleaned up:
79 - pythonIncludePath removed
80 - python setup.py bdist target is now functional.
81 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
82 collision with other packages). gdcmPython/demo/*.py changed
84 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
85 * python subdir moved to gdcmPython (preparation of distutils packaging).
86 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
87 distutils installer is operational.
88 * - gdcmPython/__init__.py now properly loads the swig generated
89 shadow classes (from gdcm.py).
90 - gdcmPython/demo/*.py changed to import the package gdcmPython
91 instead of gdcmPython/demo/load.py.
92 - gdcmPython/testSuite.py changed to import the package gdcmPython.
95 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
96 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
97 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
98 entries within the associated public Dicom dictionary resp. the same
99 information but sorted by the fourth field (PAT, IMG, DIR) of the
101 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
102 are now in the "???" group.
103 - python/gdcm.i changed accordingly,
104 - python/demo/printGroupedPublicDict.py added, that gives an example
105 of the above new functionalities in Python.
107 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
108 * src/gdcm.h, gdcmHeader.cxx:
109 - historic references to glib's g_malloc and g_free (#defined)
110 were definitively removed.
111 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
112 * src/gdcmElValSet.cxx:
113 - GetElement(guint32, guint32) renamed to GetElementByNumber.
114 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
115 - GetElValue(string) renamed to GetElValueByName.
116 - Added GetElementByName(string).
117 * src/gdcmHeader.cxx: added
118 - GetPubElValRepByNumber(guint16, guint16)
119 - GetPubElValRepByName(string)
120 - GetShaElValRepByNumber(guint16, guint16)
121 - GetShaElValRepByName(string)
122 - GetShaElValByNumber(guint16, guint16)
123 - GetShaElValRepByName(string)
124 - GetElValRepByNumber(guint16, guint16)
125 - GetElValRepByName(string)
126 - GetElValByNumber(guint16, guint16)
127 - GetElValRepByName(string)
128 * Doc/requirements.txt added.
130 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
131 * Test/Makefile building now depends on the one of libgdcm.so
132 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
133 pixel data) aware which enables finding the address (offset) of
134 the pixel data of JPEG encoded DICOM files. This leaves only a single
135 file in the testSuite whose pixel data address (offset) is unknown.
136 * python/testSuite.py changed accordingly.
138 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
139 * VC++ has some strong limitations when working with the STL, as stated
140 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
141 "Also note that some STL containers (map, set, queue, list, deque)
142 cannot be exported. [...]
143 Some STL classes contain nested classes. These classes can not
145 This is caused by a designed limitation that once a template
146 class is instantiated, it can not be re-instantiated and
148 Since our usage of map<> is ubiquitous in gdcm, this "designed
149 limitation" of VC++ is a pitfall.
150 Hence the Python wrappers of gdcm cannot be incrementally linked
151 against the c++ dynamic library. The dirty but only workaround is
152 to forget about incremental link of dynamic libraries and to generate
153 the Python wrappers library with the inclusions of the underlying C++
155 The following modifications concern this matter on Win32/VC++:
156 - wrapping python correct with standalone wrapped dll (don't use separate
157 dll under windows !!!!)
158 - python21_d debug mode enabled (ask Frog how to use it :-)
159 - NO problem with having an STL member of class for example string in C++
160 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
161 - Python test of dcmlib in Python is ok under windows on a large set
163 * removed glib references
164 * typedef's inserted in gdcm.i for correct swig type management
166 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
167 * python/demo/*.py load.py extracted from test.py. Added explore.py
168 that only displays required tags and testAll.py that parses all
169 the files of the testsuite without using unittest.
170 * python/testSuite.py other additional test on new files added.
171 * Data/* new test files added accordingly to the testSuite.
172 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
173 the vr in the file differs from the one of the dictionary.
175 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
176 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
177 values, but limits itself to values which are below a user specified
178 size (by default 1024 bytes).
179 * python/gdcm.i : elements not loaded (because their size is above the
180 user specified treshold) are exported with their TagKey as key of the
181 python dictionary. This enables the testsuite to make some checks
182 on the unloaded elements (since we have their offset and size).
183 * python/testSuite.py
184 - now tests for the existence and proper value of the pixel data
185 - two new examples added.
186 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
188 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
189 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
190 aware. See the strategy comments in gdcmHeader::FindeLength().
191 * Test/test.cxx now accepts a filename as first argument.
192 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
193 * python/testSuite.py changed to integrate test on above files.
195 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
196 * Dicts/dicomV3.dic removed all the trailing (RET) when the
198 * python/testSuite.py more tests added.
200 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
201 * python/testSuite.py unittest test suite added (uses Data)
202 * Data/* dcm and acr files for the test suite.
203 * glib dependance removed from un*x version. We now use ISO C99
204 7.18 Integer types (see stdint.h)
205 - python/Makefile, src/Makefile src/gdcm.h
206 * src/ when an explicit vr (like dicom files) suddenly poped an
207 implicit element we use to mark the underlying DictEntry of the
208 concerned ElValue with "Implicit". This strategy was damageable
209 too the public or provite dictionaries, since some of their vr
210 would be changed. Since Header::FindLength heavily relies on the
211 detection by Header::FindVR of falsely explicit elements, I
212 added an extra ImplicitVr member to ElValue (boolean).
213 The rest of the changes we the necessary adaptations.
215 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
216 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
218 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
220 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
221 * Adaptation for porting to VC++:
223 o forced to use std namespace (for string to be known)
224 o all class use __declspec export style on WIN32
225 - src/gdcmUtil.cxx new Exit method that wraps the exit call
226 (in stdlib.h on Win32 but in std:: for gcc)
227 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
228 variable GDCM_DICT_PATH.
229 * src/gdcmHeader.cxx verbose comments made discrete.
231 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
232 * python/gdcm.i: added a typemap that converts a C++ hashing table
233 to native Python dictionary.
234 * python/demo/test.py:
235 - now uses the native dictionary for exploration of gdcmHeader.
236 - takes an optional filename argument (the file to parse).
237 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
238 PubElVals hashing table.
239 * Dicts/dicomV3.dic removed error prone trailing spaces.
241 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
242 * Python wrapping process moved away from src/Makefile to
243 newly created python/Makefile (as well as gdcm.i)
244 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
245 * src/gdcmHeader::FindLength only looks for current vr when necessary.
246 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
247 from the environement variable GDCM_DICT_PATH (when existing).
248 * src/gdcmDict::GetTag bug fix.
250 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
251 * Straightforward temporary fixes for swig to build the python wrappers.
252 src/Makefile now has a python working entry [by working we mean
253 that we can import de shadow classes without errors].
255 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
256 * hashtest.cxx removed (since allready in Test)
257 * src/gdcmlib.h renamed to src/gdcm.h
258 * src/dcm.i renamed to src/gdcm.i
259 * src/Makefile prepared for python wrapping
261 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
262 * src/gdcmHeader.cxx :
263 - Parsing of header is now separated from loading of element values
264 (see gdcmHeader::LoadElements).
265 - general clean up of hopefully all file access (creation of
266 ReadInt16 and ReadInt32)
268 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
269 * src/gdcmHeader.cxx :
270 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
272 - SetLgrElem renamed to SetLength
273 - GetLgrElem renamed to GetLength
274 - ~gdcmHeader() made virtual to pesky warning messages at compile.
275 * src/gdcmElValSet.cxx fixed both GetElValue methods
276 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
277 due to IdoDude was cleaned out.
279 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
280 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
281 concentrates on finding the value representation (when it exists).
282 RecupLgr now only finds the element value length, and it avoids
283 returning the unecessary skL (skipped length).
284 Also, offsetCourant was simply removed (with taille_fich) since
285 it was redundant with the File position internals (by using
286 ftell and fseek). This also made skL (see above in RecupLgr) usage
288 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
289 on the libido specificities which are handled through class
291 * Test/implicit_vr.dcm dicom v3 in implicit value representation
294 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
295 * Truckload of changes. Parsing of header is barely functional
296 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
298 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
299 * src/gdcmHeader.cxx many addons of low level methods
301 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
302 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
305 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
306 * This corresponds to all the changes decided at the meeting of
307 May 23 2002. Needless to say we are running late...