1 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
3 file, to be accessed by other files (like gdcmFile). Remove commented
4 code. Move the change of the header to the gdcmFile, using the
6 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
7 To be sure of that (and simplify calls), the Write of the header now
8 gets a file name and not a file pointer (std::ifstream).
9 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
10 DocEntryArchive. Remove all open of the written file
12 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
13 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
15 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
16 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
17 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
19 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
20 some corresponding methods. Write correctly the file and check before
22 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
23 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
24 is now on RGB datas (as before my last commit
25 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
27 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
29 Add a print information of the type of the entry
30 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
31 It was in the gdcmFile, and all write have been regrouped
32 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
33 Write correctly all dicom files (in decompressed mode only at this time)
34 * Test/ : test on files are now made using Raw datas and not color datas if
36 * Example/PrintFile.cxx : add more printings
38 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
39 * Amelioration of code, remove some code copy. For the loading of
40 BinEntry (in gdcmDocument), add the test to verify if the file is already
43 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
44 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
45 remove a DocEntry in the header (push an empty DocEntry)
46 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
47 lines. Bug fix in the initialization of the PixelConvert and the
49 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
50 use in TestCopyDicom (now this test can run under windows... but fails)
51 * Test/TestCopyDicom.cxx : amelioration of the test :
52 - test the pixels written
53 - add test points to quickly find where is the error
54 - can set a file name input and output in arguments
55 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
56 amelioration of the test output
58 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
59 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
60 all replaced DocEntry's
61 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
62 Now, each needed DocEntry to modify is duplicated, modified and inserted
63 to the header using DocEntryArchive. Thus, after save, we can restore the
66 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
67 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
69 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
71 correct to copy it. The DictEntry is specified at the DocEntry creation,
72 then, it musn't change in the time.
73 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
74 header correctly. At this time, the change is only made for the first
75 level of the Document. In the future, it might consider sequences.
76 The change is made by replacing a DocEntry by an other that is created
77 outside the class. The old value is kept. When we restore the header
78 status, the added DocEntry is deleted and replaced by the old value.
79 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
80 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
81 set the write type to explicit VR, implicit VR or ACR. Add methods to set
82 the write mode to native, decompressed or RGB (but not used at this time)
84 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
85 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
86 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
88 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
89 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
90 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
92 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
93 set because already copied when copying the BinEntry's of the header
94 * Test/TestAllReadCompareDicom.cxx : remove warnings
96 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
97 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
98 Two problems appear when doing it :
99 - with the gdcmFile : when the GetImageData method is called, the pixels
100 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
101 datas (pixels). And each structure destruct the datas when it's
102 destructed. So we have two destructions for the same datas. To solve it,
103 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
104 datas or not. If it doesn't own datas, then they will not destroyed by
106 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
107 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
108 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
109 create a double destruction of the same DocEntry's. So, to solve it,
110 the TagHT is simply cleared and the DicomDir* elements are destroyed.
111 * TODO : add an entry concerning memory leaks in the DicomDir
113 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
114 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
115 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
118 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
119 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
120 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
121 after it have been deleted
123 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
124 * FIX: src/* fix the doxygen warnings.
125 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
126 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
127 was erroneously defined with a size of 15 instead of 16. [many thanks
128 to Jean Michel Rouet for pointing out this bug].
130 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
131 1. Finish merging JMR patch for writting DICOM from scratch
132 2. Fix -hopefully- bug with MONOCHROME and space vs null character
133 3. Use const ref when possible
134 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
135 5. A few more comments
136 6. CreateUniqueUID can now be called without parameter"
138 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
139 * ENH: Slightly bigger patch:
140 1. Getting toward full integration of JMR patch for writting dicom from scratch
141 2. Update Test to test part of this patch: CreateUniqueUID
142 3. File was not close properly in gdcmDict
143 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
144 5. Use of const ref instead of copy (speed issue)
145 6. Remove temporary (duplicate) string in TranslateToKey
146 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
147 8. Do not repeat virtual in subclasses
148 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
150 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
151 * Apply first patch toward better string comparison when dealing with broken
152 DICOM files. Essentially the string could be padded with a space instead
153 of a null character as defined by standard
155 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
156 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
157 because never used... and in the same time, that's remove some memory leaks
159 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
160 * src/gdcmFile.cxx : now delete the PixelConvert instance.
161 * In examples and tests : change the type of image data variables from void*
162 to uint8_t*. Remmove all delete on image data variables
164 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
165 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
166 Verify the file pointer value before open the file, and if it's not null,
167 a verbose message is generated.
168 Close correctly the file when the file isn't considered dicom-like. The
169 correctly close is a call to CloseFile.
170 When closing the file pointer, test if its not null to close the file.
171 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
172 file. For an uncompressed image, the copied datas correspond in the least
173 case to the image size (calculated) or the image size specified in the
174 header. A verbose is generated if these two size mismatch
176 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
177 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
178 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
179 break under windows (with msvc6 compilation).
181 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
182 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
183 compiling with MSVC6)
185 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
186 * Bugs fix for the Windows build with VC6
187 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
188 needed (only for projects required VTK). If the VTK is included in all
189 projects, there is conflicts with the jpeg lib of vtk when compiling the
190 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
191 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
192 when compiling the gdcm_wrap.cxx file (created by the compilation of the
194 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
195 (like it's already made for the cout use). Otherwise, conflict with the
198 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
199 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
201 - comments on the DicomDir::Method related usage added.
202 - now that we use the namespace gdcm, a lot of internal classes do
203 NOT need to be wrapped anymore.
204 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
205 DicomDir::Method) new example added.
207 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
208 * Improve string manipulation. I now inforce the notion of 'DicomString'
209 A DicomString can contain as many \0 as they want
210 and it is *always* of even length.
211 We only support odd length for very rare case.
212 And in the near future this should be removed.
214 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
215 * /binary_write/ gdcm source. Now even on big endian we are writting
216 little endian. This should -heopfully- fix some tests
218 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
219 * Now the dictionary is compiled into gdcm lib. This is a default
220 behavior, thus any dic file specified is picked before failback to
221 the one comiled into lib
223 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
224 * Change internals for gdcmDict. Don't use any 'new' any more.
225 This should definitely solve any leak problem, and we should be
226 as fast as before, as long as don't modify too much the dictionary.
228 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
229 * STYLE: ivars should start with a capital letter.
230 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
231 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
233 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
234 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
235 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
236 new 2004 dictionaries added (thanks to JPR).
237 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
238 * CLEANUP_ROUND (15) for gdcmPixelConvert
239 - RLEFrame::NumberFragments is now of type unsigned int
240 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
241 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
244 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
245 * Initial work in gathering all transfer syntax accessors. clearly
246 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
247 ivars, but only one transfersyntax (class) ivar with equivalent method on
250 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
251 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
252 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
253 discussed (plus I didn't like having a 2000 lines patch not commited)
255 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
256 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
257 * CLEANUP_ROUND (14) for gdcmPixelConvert
258 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
259 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
260 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
262 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
263 anymore and hence avoids storing a copy of PixelConvert::Decompressed
264 into File::Pixel_Data.
266 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
267 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
268 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
269 * CLEANUP_ROUND (13) for gdcmPixelConvert
270 Substituted File::ParsePixelData() with PixelConvert::Print() new
272 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
273 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
274 method to those classes.
275 - src/gdcmFile.[cxx|h]:
276 -- Added a ::Print() method.
277 -- PixelConverter is now a reference instead of a member.
278 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
279 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
281 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
282 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
283 collaboration diagram and inheritance diagram should be generated with
285 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
286 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
287 pointlessly wrapped (see
288 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
289 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
290 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
291 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
292 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
293 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
294 -- File::Initialise: PixelConverter setup moved away to
295 PixelConverter::GrabInformationsFromHeader()
296 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
297 interpretation moved away to PixelConverter::BuildRGBImage()
299 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
300 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
301 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
303 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
304 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
305 displayed on Win32 when a brutal abort() occurs (because of uncatched
306 exception). See TODO new entry of this commit for more on this.
307 * TODO added new entry.
308 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
309 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
310 - HandleColor is no longer called from gdcmFile.cxx
311 - gdcmPixelConvert.cxx clean up on method arguments and internal
312 variable names for semantical coherence.
314 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
315 * Finished lossless transition, not only do we now read all lossless jpeg
316 images, without the need of the Cornwell lib, but we do read them properly now
317 * To reduce code (well to avoid code duplication), I defined a common place
318 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
319 redefine symbols. This is not prefect but this the best solution I found for a
320 compilation time jpeg option.
322 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
323 * Update jpeg ijg lib to support lossless jpeg implementation
324 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
326 * Also added a special copyright for dcmtk since we use their bugfixes.
329 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
330 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
331 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
332 matters, as stated in warning note at begining of %include section).
333 * src/gdcmDicomDir*.[cxx|h]: coding style
334 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
335 * src/gdcmJpeg8.cxx: doxygen fix.
336 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
337 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
338 from File:: to PixelConvert::.
340 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
341 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
342 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
343 - more code moved away from File:: to PixelConvert::
344 - fat setup of PixelConverter set in place in File::Initialise.
346 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
347 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
348 namespace at the file system level. So now you should convert your examples
350 gdcmHeader -> gdcm::Header
351 It would be nice if people keep in mind to no open the namespace, since it
352 allows compilation on broken plateform which were defining common symbol in
353 the standart namespace (like LP, Unknown ...)
355 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
356 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
357 The JPEG fragments are now parsed at the same stage than the RLE
358 information. All code related to JPEG is now in gdcmPixelConvert:
359 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
360 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
361 export a gdcmFile:: method. Those are simply global functions
362 (for the time being this is better than having them attach to
363 either gdcmFile:: or gdcmPixelConvert::).
364 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
365 and stores the result in a gdcmJPEGFragmentsInfo.
366 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
367 code (among other stuff) moved away from gdcmFile:; to
370 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
371 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
372 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
373 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
374 clean up of RLE related code.
375 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
376 - src/gdcmRLE.cxx removed
377 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
378 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
379 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
380 * CLEANUP_ROUND (9) for gdcmPixelConvert
381 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
382 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
383 away from gdcmFile:: to gdcmPixelConvert::.
385 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
386 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
387 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
388 This is because Parse7Fe0 used to parse the pixels to compute the
389 length. This task was passed over to FindDocEntryLengthOB() a long
390 time ago, EXCEPT I had forgotten the OW case...
391 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
392 we just recylce the code for parsing RLE fragments and computing
394 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
395 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
396 with the retired Parse7Fe0().
397 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
398 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
400 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
401 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
402 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
403 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
404 - src/CMakeLists.txt: alphabetic order reodering + new entries.
405 * CLEANUP_ROUND (4) for gdcmPixelConvert
406 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
407 to return an unused length.
409 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
410 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
411 this should be cleanner from the plane view. The iostream are erally a pain
412 to use to do simple stuff.
414 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
415 * Redo the compilation of the ijg jpeg library. Now only one source is
416 necesseray. No need to rename file by hand what so ever. CMake handle the
417 copying of the file within different directory, configure header file to
418 modify some symbol. The only addition made to ijg wasd a mangle table so
419 that symbol are different wether we are within 8bits or 12bits.
421 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
422 * Added documentation of vtkgdcmReader on Website:
423 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
424 with it's binary name).
425 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
426 the Website to be more complete.
427 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
428 doxygenated documentation.
429 - Doc/DoxyVtkGdcmReaderExamples.txt added
430 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
431 DoxyVtkGdmReaderExamples.html )
432 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
433 * CLEANUP_ROUND (3) for gdcmPixelConvert
434 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
436 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
437 * CLEANUP_ROUND (2) for gdcmPixelConvert
438 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
440 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
441 * CLEANUP_ROUND for gdcmPixelConvert:
442 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
443 - src/gdcmPixelStuff[h|cxx] removed
444 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
445 - src/CMakeLists.txt changed accordingly
447 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
448 gdcmVersion.py moved to newly created ATTIC related
449 gdcmPython/SetupOldies/ directory.
450 * Autotools clean up:
451 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
452 - autogen.sh configure.in acinclude.m4 python.m4 removed
454 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
455 * src/*.cxx *.h Reference to License.htm fixed to License.html.
456 * Doc/CMakeLists.txt, doxygen.config.in: fix.
457 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
459 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
460 * TODO updated with Mathieu suggestions. I proposed a template for
461 describing TODO entries and used it for new entries.
462 * Added Doc/Website/CodingStyle.html, Developpers.html,
463 DeveloppersPython.html, GdcmDataCvs.html and
464 DownloadVersion0_1.html, DownloadVersion0_3.html.
465 * Some Doc/*.txt Doxygen files (which do not really concern the
466 documentation itself, but the website) moved to html and
467 placed in directory Doc/Website:
468 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
469 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
470 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
471 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
472 * CMakeLists.txt changed accordingly.
473 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
474 DeveloppersPython.html
475 * INSTALL nows refers to Doc/Website/Installation.html
477 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
478 * Added Doc/Website directory, that contains a first raw version
481 2004-09-23 Jean-Pierre Roux
482 * FIX In order not to be poluted any longer by casting problems,
483 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
484 we can now delete[] it safely
485 * VoidArea is now called BinArea (less confusing name),
486 and all the methods called ...VoidArea... are now ... BinArea...
487 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
489 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
490 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
491 clear) TagHT, which is an inherited member of gdcmElementSet. It is
492 up to the destructor of gdcmElementSet to clean up TagHt and it's
495 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
496 * Test/CMakeLists.txt: update to follow gdcmData renamings.
497 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
499 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
500 * ENH: added some utility method that builds a flat dictionnary
501 holding all the Dicom entries contained in the recursive structure
502 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
504 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
505 BuildFlatHashTable() that build a flat dictionary.
506 - src/gdcmElementSet.h: added a new private GetTag() accessor.
507 gdcmDocument is now a friend of gdcmElementSet.
508 - src/gdcmElementSet.cxx: clean up.
509 - Example/FlatHashTablePrint.cxx added.
510 - Example/CmakeLists.txt changed accordingly
512 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
513 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
514 moved away from gdcmDocEntrySet (since this class is an abstract class
515 acting like an interface). SQDepthLevel and BaseTagKey are now
517 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
518 and associated accessors. Doxygenation of the class.
519 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
521 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
522 Use SQDepthLevel accessor instead. ::Print() adapted.
523 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
524 - src/gdcmDocument.cxx changed accordingly.
526 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
527 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
528 - The following is the doxygen comment of the typedef declaration
529 of gdcmagKey in src/gdcmCommon.h:
530 gdcmTagKey is made to old an "universal" (as in URL, Universal
531 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
532 A dicom tag allways has a group and an element, but a set of tags
533 embeded in various (optionally nested) sequences and sharing
534 the same group and element all share the same (group, element)
535 "identifier". Hence the (group, element) cannot be used as an
536 identifier (in gdcm we shall refer to a "TagKey") of a tag.
537 In order to construct a proper tag identifier (i.e. a key) we
538 consider the following definition of a TagKey:
539 - let Group, Element be the string representation of the
540 group and element dicom tag members,
541 - let ItemNumber be the string representation of the integer
542 index of the considered item number of a sequence,
543 Let the key of a tag embeded in a sequence, noted SeqTag, be
545 /ItemNumber#Group|Element
546 where "/", "#" and "|" are characters acting as separators.
547 Then the general form of a gdcmTagKey is given by:
548 Group|Element<SeqTag>
549 where <SeqTag> means NO or many instances of SeqTag.
550 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
553 but the gdcmTagKey of a tag "embeded" is the first item of
554 a sequence, itself nested in the third item of a sequence is the
556 0004|1220/2#0008|0082/0#0008|0090
557 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
558 order to hold the new sequence compatible key. Previously, the
559 GetKey() method would look in the underlying gdcmDictEntry.
560 - src/gdcmDocEntry.cxx:
561 -- constructor now copies the underlying DictEntry key, in the local
563 -- ::Print: displays the member Key, instead of the (group, element).
564 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
565 - src/gdcmDocEntrySet.h:xi
566 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
567 -- now has a new BaseTagKey member.
569 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
570 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
572 This poses the problem with the semantics of the following lines
573 LoadEntryVoidArea(0x0028,0x1201); // R LUT
574 LoadEntryVoidArea(0x0028,0x1202); // G LUT
575 LoadEntryVoidArea(0x0028,0x1203); // B LUT
576 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
577 to the long FIXME note for what the problem is. Nevertheless in
578 order to get things working the dicom dictionary was altered !
579 Please fix things urgently...
580 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
581 information), see above note on moving the member VoidArea. Nevertheless
582 the following entries previously correctly set as US are now inproperly
584 0028 1201 OW IMG Red Palette Color Lookup Table Data
585 0028 1202 OW IMG Green Palette Color Lookup Table Data
586 0028 1203 OW IMG Blue Palette Color Lookup Table Data
587 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
588 of gdcmDocEntry moved to gdcmSeqEntry.
589 * src/gdcmSeqEntry.cxx: STYLE.
591 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
592 * Test/TestAllEntryVerify.cxx minor fix and added comments.
594 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
595 * gdcmPython/testSuite.py: all the test suite in python is now moved
596 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
597 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
598 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
600 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
601 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
602 to avoid inclusion recursion until STL is reached.
603 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
604 mecanism. errno.h is not included in gdcm anymore.
605 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
606 (gdcmFormatError now inherits from gdcmFormatUnexpected).
608 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
609 gdcmData/TestAllEntryVerifyReference.txt
610 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
611 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
612 exception_on_error parameter.
613 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
614 - vtk/vtkGdcmReader.cxx changed accordingly,
615 - Example/*.cxx and Test/*.cxx changed accordingly.
617 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
618 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
619 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
620 enable_sequences removed from gdcmHeader constructor and dependencies.
621 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
622 * gdcmPython/demo/PrintHeader.py: dummy fix.
623 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
624 skip_shadow removed from gdcmHeader constructor and dependencies.
625 * Example/*.cxx and Test/*.cxx changed accordingly.
627 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
628 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
629 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
631 2004-07-21 Jean-Pierre Roux
632 * FIX Now, Parsing and Printing a DICOMDIR do work!
633 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
635 2004-07-20 Jean-Pierre Roux
636 * FIX Some brain damaged headers have Zero-Lenght fields
637 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
639 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
640 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
641 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
642 variable (instance of gdcmDebug) by a definition macro, and the instance
643 is now in static in the gdcmDebug class
644 * src/gdcmSQItem.h : (FIXME) remove an undefined method
645 * Test/PrintAllDocument.cxx : bug fix in the result of the test
647 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
648 * WARNING: ctest now depends more tightly on gdcmData. You should
649 check out gdcmData properly for things to run smoothly...
650 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
651 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
652 we need the pixels not be loaded in order to use the ValEntry
653 that displays position and size).
654 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
655 This is a C++ based equivalent of gdcmPython/testSuite.py that should
656 be deprecated. If you have any doubts about the advantages of a
657 modern scripting language (read Python) versus grass root C++ (i.e.
658 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
659 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
660 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
661 Anyhow, consider documenting the gdcmData images in
662 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
664 * Test/CMakeLists.txt:
665 - now uses TestAllEntryVerify.cxx
666 - specific comments on oldACR00001.ima (now renamed in gdcmData
667 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
668 gdcmData/TestAllEntryVerifyReference.txt
671 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
672 * src/*.[h|cxx] : typedef clean up
673 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
674 - TagKey renamed to gdcmTagKey (for external usage)
675 - VRKey renamed to gdcmVRKey (for external usage)
676 - removal of typedef duplication.
677 - Removed all unecessary inline keyword from class inline definitions.
678 - Some method|function(void) declarations replaced with method|function().
679 * src/jpeg/libijg12/jdhuff12.c:
680 - printf polluting ctest removed.
681 - TAB removal for comminting
683 - TestAllReadCompareDicom.cxx: added a test that compares all the
684 images in gdcmDataImages.h with corresponding images in
685 gdcmData/BaselineDicom/. When baseline images are not present
686 this test creates them.
687 Note: we need to validate each reference image, but before that
688 I'd like to rename them with a more explicit name...
689 - CMakeLists.txt: changed accordingly.
690 * Example/*.cxx: examples now only include gdcm.h (as opposed to
691 including each header needed).
693 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
694 * Test/*.cxx and Example/*.cxx: moved some examples away from the
695 test suite to the Example directory. Are concerned:
700 - TestWriteSimple.cxx
701 * Test/CMakeLists.txt: added some comments on reasons for black listing
702 image gdcmData/oldACR00001.ima
704 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
705 * Test/CmakeList.txt: removed the following from black list (to be coherent
706 with removal from gdcmData):
707 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
708 - gdcm-MR-PHILIPS-16.dcm
710 Added the following because after last cvs update, they cause
711 ctest -R TestReadWriteReadCompare
713 - gdcm-MR-SIEMENS-16-1.acr
715 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
716 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
717 new comments in this file) we temporarily (sigh) move to a weaker
719 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
720 we don't need to black list the following images anymore:
721 - 8BitsUncompressedColor.dcm
723 - US-PAL-8-10x-echo.dcm
724 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
725 fixes and the beautified code ;-)
726 This fixes the bug introduced in version 1.42 (when beautifying)
727 that made the parsing of 8BitsRunLengthColor.dcm unproper.
728 Note: ctest was blind to this bug (this means we need to still
729 improve the test suite). The bug could be detected by using
730 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
732 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
733 and by displaying the (garbage) produced file temp.XDCM...
735 2004-06-29 Jean-Pierre Roux
736 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
737 - replace by uggly but working old code :-(
738 A lot of things should be OK again.
739 It's really urgent to have a test suite that *tests*,
740 to prevent Frog's beautifying sessions to break all the stuff
741 (twice, withing a fortnigh ...)
743 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
744 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
745 redundancy) to added Test/TestReadWriteReadCompare.cxx
746 * Test/CmakeList.txt: because the compare test of
747 Test/TestReadWriteReadCompare.cxx fails, the following images are
748 black listed: - 8BitsUncompressedColor.dcm
750 - US-PAL-8-10x-echo.dcm
751 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
752 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
753 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
754 and ad-hoc kludge. This kludge is now removed, and on encountering
755 such an image (OB field brain damaged) we set errno. Then in
756 ::FindDocLength() we "fix" the length as being ALL what remains
757 in the file (until EOF). We then proceed, hoping for the best...
758 This fixes a SegFault in ShowDicom when trying to write such an
760 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
761 (because TestWriteRead breaks on it, after a non conformal commit?).
762 ctest now runs properly, except for MakeDicomDir (which was allways
763 broken) and the Python related stuff (still not fixed).
765 2004-06-24 Jean-Pierre Roux
766 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
767 FIX : Test/TestReadWrite now iterates on all the file names
768 (instead of infinite loop)
769 ENH : Test/TestWriteRead now iterates on all the file names
771 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
772 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
774 2004-06-24 Jean-Pierre Roux
775 FIX : - now Write drops LUT Descriptors and LUTs (if any)
776 when SamplesPerPixel =3
777 - now Write is no longer confused by
778 'BitsAllocated = 12" and 'BitsStored=12"
779 - "UN" value representation Elements are now written correctly
780 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
781 ENH : - now gdcmHeader has its own Write methods
782 (in order to split the job that has not to be done
785 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
786 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
787 loop on the same image until memory went out.
788 Note: this means we still have gobs of memory loss in PrintDocument
789 * src/gdcmDocument.cxx: fixes problem on parsing on file
790 gdcmData/16BitsJpegLosslessGrayScale.dcm.
792 2004-06-24 Jean-Pierre Roux
793 FIX : Write - All the Sequences and Sequence Item are now written
794 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
795 is added a the end, when necessary.
796 - A lot of brain-damaged images, that were read correctly are
797 now written correctly
798 - length compatible BinEntry are now loaded correctly
799 (even for odd groups)
800 Note : only Explicit Value Representation was checked.
801 (question : is implicit VR really necessary for gdcm ?)
803 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
804 * DEVELOPPER: added a proposition of coding style.
805 * src/gdcmDocEntry.h: removed every inline declaration (for test of
808 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
809 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
810 Use the gdcmDocEntry::Print() and Write() instead.
811 * src/gdcmDocument.cxx: bug fix.
813 2004-06-22 Jean-Pierre Roux
814 FIX : gdcmDocument.cxx
815 - Now we do recognize the JpegLossLess format (there was a misstyping in
816 code 'beautyfication' :-(
817 - Now we automaticaticaly load the Luts, if any
819 2004-06-22 Jean-Pierre Roux
820 In order : to write Sequences, whatever their imbrication level,
821 : to allow user to create his own Sequences
822 a lot of modif where necessary (adding, moving, or virtualising methods)
824 WARNING : save your own sources *before* cvs up !
827 ADD virtual void Write(FILE *fp, FileType filetype);
830 ADD virtual void Write(FILE *fp, FileType filetype);
831 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
834 ADD virtual void Write (FILE *fp, FileType filetype)=0;
835 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
836 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
837 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
838 ADD std::string GetEntryByName(TagName name);
839 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
841 std::string vr = "unkn",
842 std::string fourth = "unkn",
843 std::string name = "unkn");
844 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
845 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
846 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
847 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
848 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
849 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
850 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
851 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
854 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
855 ADD virtual std::string GetEntryByName (TagName tagName);
856 ADD virtual std::string GetEntryVRByName (TagName tagName);
857 REM virtual bool Write(FILE *, FileType);
858 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
859 FILE *_fp, FileType type);
860 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
861 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
862 REM virtual bool WriteEntries(FILE *_fp,FileType type);
863 REM virtual std::string GetEntryByName (std::string tagName);
864 REM virtual std::string GetEntryVRByName (std::string tagName);
865 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
866 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
867 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
869 std::string vr = "unkn",
870 std::string fourth = "unkn",
871 std::string name = "unkn");
872 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
873 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
874 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
875 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
878 ADD virtual void Write(FILE *fp, FileType filetype);
881 ADD virtual void Write(FILE *fp,FileType filetype);
884 ADD virtual void Write(FILE *fp, FileType filetype);
885 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
886 REM std::string GetEntryByNumber(guint16 group, guint16 element);
887 REM std::string GetEntryByName(TagName name);
890 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
892 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
893 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
894 The default constructor invoked by the line
895 gdcmHeader *f1 = new gdcmHeader( header );
896 was gdcmHeader::gdcmHeader(bool) instead of the expected
897 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
898 Hence the parsing wasn't executed... See also below.
899 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
900 as explicit constructor didn't do the trick to fix the above problem.
901 Could anyone explain why ?
902 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
903 properly calls gdcmValEntry::Print() (that was weed out from
904 code related to gdcmBinEntry).
906 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
907 * In order to fix memory leaks:
908 - Test/TestWriteSimple.cxx: added cleaning of free store through
910 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
911 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
912 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
913 (through the call to ::AddDicomDirMeta()) or the destructor
914 would crash when deleting uninitialized ::metaElems].
915 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
916 - src/gdcmDocument.cxx:
917 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
919 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
920 was causing memory leaks.
921 - src/gdcmSQItem.cxx:
922 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
923 cleanly handled with polymophism: sorry but my milage is low).
924 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
925 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
926 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
927 This avoids SegFaulting.
928 - src/gdcmSQItem.h: coding style.
930 - Test/TestWriteSimple still severely sucks. The output image content
931 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
932 damaged when displayed with vtkgdcmViewer.
933 - on memory leaks: TestWriteSimple leaks really less (see entry
934 of 2004-06-18 in Changelog file for the call to valgrind).
935 - on segfaults: ctest now passes all the tests but one (no more
937 * Erroneous leading white fix:
938 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
939 white[s] (as opposed to from >> xxx, that removes it [them].
940 - src/gdcmTS.cxx: ditto.
941 - gdcmPython/testSuite.py: dirty related kludge removed.
942 * src/*: remaining references to gdcmParser removed.
943 * src/*[cxx|h]: added copy[way]left header.
946 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
947 * In order to fix writing of dicom files:
948 - Test/TestWriteSimple.cxx: a simpler example of writing.
949 - Test/CMakeLists.txt changed accordingly.
950 - src/gdcmDocument.cxx:
951 -- The destructor now recursilvely removes potential sequences.
952 -- Bug fix in ::IsJPEG2000()
953 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
954 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
956 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
957 to only declared) and build on top of
958 ::GetDocEntryByNumber(guint16, guint16).
959 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
960 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
961 for usage in destructor and treatement of promotion in
962 ::ReplaceOrCreateByNumber().
963 - src/gdcmSQItem.cxx: destructor should better handle his job.
964 Test/TestWriteSimple now runs (or at least it DOES something).
965 * We can now start hutting memory links. A good starting point is:
966 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
967 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
968 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
970 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
971 * Valgrind note: after Mathieu Malaterre teached me how to read
972 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
974 Using gcc, you can force the STL to use malloc and to free memory as
975 soon as possible by globally disabling memory caching.
976 With 3.2.2 and later, you should export the environment variable
977 GLIBCPP_FORCE_NEW before running your program.
978 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
979 simply vanish (it is still not clear to me, whether this means that
980 STL std::string leaks or if valgrind believes it leaks...).
981 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
982 running bin/gdcmTests makeDicomDir):
983 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
984 - Test/makeDicomDir.cxx now properly traps empty lists and returns
986 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
987 SegFaulting (I drowned in DicomDir related code when trying to
988 understand why the list is empty...).
989 * src/gdcmDocument.h: first BSD license header try.
990 * Doc/License.txt added.
992 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
993 * src/gdcmDocument.[h|cxx]:
994 - Clean up of the Transfer related predicates. They are now all based
995 on new method isGivenTransferSyntax, that (should) handle properly
997 - general clean up, simplification, and coding style.
998 - Specific clean up of Parse7FE0() (umproperly named actually).
999 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1001 2004-06-14 Jean-Pierre Roux
1003 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1004 - fix the display of SQItem ordinal number
1005 - add the GetSQItemByOrdinalNumber method
1006 - remove some useless never written private methods
1008 2004-06-14 Jean-Pierre Roux
1010 - adding a constructor taking a gdcmDocEntry as an input param
1011 - ReplaceOrCreateByNumber now returns :
1012 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1013 a gdcmValEntry * if a string value is passed as a param
1015 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1016 according to the param type (no longer sets a gdcmDocEntry)
1017 - GetValEntryByNumber, GetBinEntryByNumber added
1018 - NewValEntryByNumber and NewBinEntryByNumber added
1020 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1022 - GetSQItemNumber and SetSQItemNumber added, to provide
1023 a (relative) Item identier inside a given Sequence
1024 \warning : some pb remaining around this number
1026 - AddEntry now takes the Item Number as a param
1028 - adding a constructor taking a gdcmDocEntry as an input param
1030 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1031 * Memory leak hunt with the following command:
1032 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1033 --show-reachable=yes gdcmTests PrintDocument
1034 It looks like many (all?) leaks are due to the STL (or a bad usage
1035 of the STL. The lines producing the leaks now have a comment with
1036 a "MEMORY LEAK" tag: you can retrieve them with
1037 grep "MEMORY LEAK" src/*
1038 Here are two typical examples which I can't help fixing:
1043 char * test = "babo";
1044 name = test; //// <--- valgrind detects 960 bytes lost in
1045 //// call to std::string::operator=(char const*)
1046 name.clear(); //// Doesn't help !
1054 std::cout << "Type a bunch of characters followed by RETURN: ";
1055 getline(std::cin, line); //// <--- valgrind dectects a loss
1056 //// of 1320 bytes in call to
1057 /// std::basic_istream<>& std::getline<>
1063 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1064 * src/gdcmHeader.[cxx|h]:
1065 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1066 and related, moved away to gdcmDocument.
1067 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1068 the corresponding protected accessors of inherited class
1069 gdcmDocument, removed ! As a consequence gdcmFile had to be
1070 declared friend of class gdcmDocument (see below).
1071 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1072 - Clean up of undefined or unused methods.
1073 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1074 account the changes to gdcmHeader.h).
1075 * src/gdcmDocument.h:
1076 - gdcmFile is now a friend class (in order to take into account the
1077 changes to gdcmHeader.h).
1078 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1079 (see changes to gdcmHeader.h).
1080 - Accessors (reading on the form GetEntry*) are now public.
1081 - Clean up of undefined or unused methods.
1082 * src/gdcmDocument.cxx:
1083 - adaptation to changes to gdcmDocument.h
1084 - ::OpenFile now writes a verbose message when file cannot be opened.
1085 - some std::string properly set to VRKey
1086 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1087 references to gdcmDocument.
1088 * Test/TestFindTags.cxx: changed accordingly to above changes.
1089 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1090 cvs repository gdcmData.
1092 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1093 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1094 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1095 conflicts with gdcmValEntry::voidArea.
1096 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1097 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1098 Value representation between StringRepresentable and BinaryRepresentable.
1099 * src/gdcmDocument.cxx:
1100 - method ParseDES: proper indentation restored and usage of
1101 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1102 - method LoadDocEntry: the fingerprint left in the SetValue() of
1103 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1104 removed. Reverting to previous code segment with the proper
1105 dynamic_cast< gdcmValEntry* >.
1106 Note: this was (partially) breaking the python test suite
1107 (gdcmPython/testSuite.py) that made usage of the above
1108 fingerprint to check presence of "Pixel Data".
1109 * src/gdcmDocEntry.h: coding style.
1110 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1111 now taken into account.
1112 * gdcmPython/gdcm.i: adaptation to the new internal representation
1113 of gdcm (exit gdcmParser, hello gdcmDocument).
1114 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1116 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1117 anymore, but instead prints the loaded Python dictionary.
1118 * .... alas, the python testSuite is still broken.
1120 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1121 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1123 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1124 * src/gdcmUtil.h : export methods
1126 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1127 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1129 * Initial addition of automatic python testing
1130 * Initial addition of automatic image comparison
1132 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1133 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1134 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1136 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1137 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1138 * Test/ShowDicom.cxx : bug fix for msvc compilation
1139 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1141 2004-05-04 Jean-Pierre Roux
1142 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1143 new concepts (and new classes) :
1144 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1145 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1146 - Sequence Doc Entries (gdcmSeqEntries)
1147 a Sequence is composed of Items.
1148 Each item is a set of Doc Entries (this is recursive)
1149 The non uniqueness of the 'Dicom tag' is due to this recursivity
1150 (never taken into account)
1151 Our unability to add a new 'entry' in the header
1152 at the proper location (neither in the H-Table (map or multimap),
1153 nor in the Chained List is also due to this recursivity.
1154 Don't try, right now, to use/modify/compile these new sources :
1155 nothing is finished.
1156 We just commit all the stuff, 'as is', in order not to loose it.
1158 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1159 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1161 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1162 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1163 file prefix (SetFilePrefix)
1165 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1166 * Add a new test: ShowDicom, for now this is just the c++ version of
1167 checkRead.sh, later it will be able to compare the image read against a
1169 * Replace the DEBUG on the stack with a global entry in cmake interface:
1170 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1172 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1173 * Add an example subdir, with a real example on how to read + write a
1176 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1177 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1178 * Doc/CMakeLists.txt: the main page is now properly differentiated
1179 between the developper and user version.
1180 * Doc/doxygen.config.in: dropped search related obsolete flags
1181 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1183 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1184 * DEVELOPPER: added some helpfull comments for compile/test/install
1187 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1188 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1189 src directory, now generated in the build dir.
1190 2. Tests as mentionned smarter
1192 4. Add a new method in gdcmDict that return the PubDict by name
1193 this is interesting for 3rd party lib like ITK,
1194 where we could set the institution name / patient name...
1196 * ENH: 1. Now the test suite is working for real
1197 2. All binaries are now output in the gdcm-bin directory
1198 (this was not true before)
1200 2004-04-28 Jean-Pierre Roux
1201 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1202 SeQuence indented printing of Dicom Header.
1203 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1204 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1205 Computation of SQDepthLevel is now part of gdcmHeader constructor
1206 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1207 tree-like structure of a Dicom Header.
1208 * FIX Test code cleaning
1210 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1211 * ENH: Adding automatic testing
1212 1. Need a DartConfig.cmake to submit to public
1213 2. Add a test driver gdcmTest.cxx
1214 3. gdcmTestMain, an helper for the main test driver gdcmTest
1215 4. Files in Test don't have a main anymore, this becomes interesting
1216 when we add more and more tests, thus dsw don't have to load
1218 * ENH: Adding a GDCM_DATA_ROOT for testing
1219 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1220 one file instead of seven + some small cleanup
1222 2004-04-22 Jean-Pierre Roux
1223 * ENH Minor changes to the Print() methods.
1224 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1225 Header printing. Example given with :
1226 > PrintHeader fileName 2 new
1227 (SQ based tree-like structure still to be done for the Header ...)
1229 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1230 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1231 1. I have added some unsigned where needed
1232 2. Some function parameter not used -> (void)
1233 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1234 4. g++ don't like character '\' in comment
1235 5. #define jpeg_create_decompress jCreaDecompress
1236 this really need to be fixed
1237 6. virtualize destructor of gdcmObject ... leakage
1238 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1239 this also really need to be fixed
1240 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1241 remove compression file
1242 (as we only do decompression, right ?)
1243 * ENH: Change malloc/calloc/free with c++ equivalent
1245 2004-04-21 Jean-Pierre Roux
1246 * FIX gdcmHeaderHelper::GetXSpacing
1247 when a single value is found (bug ?), xpacing is now
1248 defaulted to yspacing
1250 2004-04-19 Jean-Pierre Roux
1251 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1252 * ENH add parameters :
1253 bool exception_on_error = false,
1254 bool enable_sequences = false,
1255 bool ignore_shadow = false
1256 to the gdcmFile constructors to be full gdcmParser compliant
1257 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1258 to allow reading of PAPYRUS 3.0 files
1260 2004-04-06 Jean-Pierre Roux
1261 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1263 2004-04-02 Jean-Pierre Roux
1264 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1265 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1266 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1268 2004-03-30 Jean-Pierre Roux
1269 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1270 for ACR file, written out as DICOM files (hope so...)
1272 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1273 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1274 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1275 moved to base class gdcmParser and only the specialisation is kept
1277 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1278 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1279 already does the job.
1280 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1281 (to be consistent with gdcmParser::WriteEntries).
1283 2004-03-30 Benoit Regrain
1284 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1285 upate of the object's instance. It's passed to 2 in the unfavorable
1286 case : one in the ExecuteInformation, one in the ExecuteData
1288 2004-03-29 Jean-Pierre Roux
1289 * ENH : Check on file type to be written moved
1290 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1291 * FIX : gdcmObject::ResetBoundaries now stops properly
1292 when end-of-list is reached
1293 : gdcmVersion modified (as Benoit Regrain asked)
1295 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1296 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1297 * src/gdcmUtil.cxx: added forgotten iostream include.
1298 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1299 equivalent to ExplicitVR in existing code).
1301 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1302 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1303 now contains all the gdcmGlobal related code.
1304 * minor coding style and doxygenation changes.
1306 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1307 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1308 now contains all the Debug related code.
1309 * minor clean-up of includes in src/*.cxx
1310 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1311 CreateCleanString) removed.
1312 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1313 * Doc/DoxyMainPageUser.txt added.
1314 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1315 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1316 src/gdcmDirList.cxx)
1318 2004-03-24 Jean-Pierre Roux
1319 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1321 2004-03-23 Jean-Pierre Roux
1322 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1323 big endian made volumes
1324 * ENH Now gdcmParser constructor and destructor are protected to forbid
1325 end user to instanciate class gdcmParser
1326 (only gdcmHeader and gdcmDicomDir are meaningfull)
1328 2004-03-22 Benoit Regrain
1329 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1330 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1331 gdcmSerie to gdcmDicomDirSerie
1333 2004-03-19 Jean-Pierre Roux
1334 * ENH Now the tree-like structure describing a DICOMDIR comming from
1335 an already existing DICOMDIR file is consistent with
1336 the home-made tree-like structure build ex-nihilo
1337 or build from the files held (recursively) in a Directory
1338 functions gdcmDicomDir::CheckBoundaries()
1339 gdcmObject::SetBoundaries() added
1341 2004-03-17 Jean-Pierre Roux
1342 * REM (Eric Boix bug) : removal of meaningless
1343 gdcmDicomDirImage::NewImage function.
1344 * FIX now file names and directory name are written properly in the
1346 * FIX now gdcmDicomDir constructor may be call without any trick
1349 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1350 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1351 of gdcmDicomDirImage::NewImage as empty function.
1353 2004-02-28 Jean-Pierre Roux
1354 * ENH add gdcmDicomDir:NewPatient
1355 add gdcmDicomDirPatient:NewStudy
1356 add gdcmDicomDirStudy:NewSerie
1357 add gdcmDicomDirSerie:NewImage
1358 to allow making gdcDicomDir object.
1359 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1360 (as opposite to the gdcmHeader chained list)
1362 2004-02-11 Benoit Regrain
1363 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1364 when using from python
1366 2004-02-10 Benoit Regrain
1367 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1368 * FIX : in gdcmDicomDir when the directory is empty
1369 * ENH : add callback and methods to get the progression of dicomDir
1372 2004-02-06 Jean-Pierre Roux
1373 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1374 - GDCM_META added to gdcmDicomDirType
1375 - class gdcmMeta created
1376 * ENH : - A brief summary is now displayed at the beginning of
1377 'testDicomDir' to help disaster magnitude estimation
1378 * REM : Now useless Test/explDICOMDIR.cxx
1380 2004-02-05 Benoit Regrain
1381 * ENH : add methods in gdcmObject to get the hash table or the list of
1383 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1384 * FIX : wrapping python for TagHeaderEntryHT
1386 2004-02-04 Benoit Regrain
1387 * FIX : even length for some strings when writting the dicom dir
1388 * FIX : sort the images in the dicom dir
1389 * FIX : Bug fix for python use of dicom dir
1390 * ADD : a python demo
1392 2004-02-04 Jean-Pierre Roux
1393 * FIX : Final solution (?) for icone embedded images
1394 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1395 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1396 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1397 gdcmData/gdcm-MR-SIEMENS-16.acr1
1398 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1399 to make full checking easier
1401 2004-02-04 Benoit Regrain
1402 * FIX : WriteEntries : coding style & logic in parameters
1403 * FIX : Set the elements to create the DicomDir in a dictionary file
1405 2004-02-03 Benoit Regrain
1406 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1407 * gdcmDicomDir : add the load of directory
1408 * Bug fix and print add-on
1410 2004-02-03 Jean-Pierre Roux
1411 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1412 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1413 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1414 * FIX gdcmParser.cxx : 'group length' elements are now considered
1415 as integers, even for shadow groups, when file is Implicit VR
1417 2004-02-02 Jean-Pierre Roux
1418 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1420 of the last synonym :-(
1421 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1423 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1424 * FIX taking into account the possible 7fe0,0010 multiplicity
1425 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1426 to allow removal of references to 7fe0,0010, to deal with
1427 ACR-NEMA images, when 0028,0200 is meaningfull
1429 2004-01-31 Jean-Pierre Roux
1430 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1431 no longer writes 'Un' on disk
1432 * FIX SQ elements with actual length are now dealt with corectly
1433 * FIX gdcmFile::WriteBase make the difference, for color images, between
1434 the length (for Palette expanded images)
1435 and Raw Length (non expanded image + Palette)
1436 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1437 (that broke Write). Replaced by UL.
1438 Aware user will reload the field if he
1439 thinks it's necesssary
1441 2004-01-30 Jean-Pierre Roux
1442 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1443 when 'dirty Acr' is found, to be compliant with the new
1444 IsReadable() methods.
1446 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1447 (no DOUBLE images in kosher DICOM,
1448 but so usefull for people that miss them ;-)
1450 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1451 DICOMDIR related utilities (not checked as Windoze compliant)
1453 2004-01-28 Jean-Pierre Roux
1454 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1456 2004-01-27 Jean-Pierre Roux
1457 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1458 to allow skipping the shadow elements, to save memory space.
1459 The TRUE value for this param has to be used
1460 with a FALSE value for the 'enable_sequence' param.
1461 ('public elements' may be embedded in 'shadow Sequences')
1462 * gdcmHeader methods now deal with 'embedded icones images' in the header
1463 (even when an 'icone image sequence' is announced by the
1464 element (0x0088,0x0200), but there is NO icone at all ...
1466 * gdcmHeader sometimes Image Location value doesn't follow
1467 the supposed processor endianity (see gdcmData/cr172241.dcm).
1470 * gdcmHeader add the method
1471 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1472 to get *all* the Header Entries with the same tag.
1473 GetHeaderEntrySameName is probabely *useless*
1474 (no meaning : Name is *not* an identifier within the Dictionnary)
1476 2004-01-26 Benoit Regrain
1477 * Bug fix in the print of hexadecimal representations. Remove long fields
1478 in the print and add a third level of print to print them
1480 2004-01-23 Benoit Regrain
1481 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1482 * Bug fix on test suite after remove the strip made on not string fields
1483 * Split the IsReadable method between gdcmParser which test that the file
1484 is dicom and gdcmHeader which test that it's an image file
1486 2004-01-22 Benoit Regrain
1487 * DicomDir : clean code, add methods, set variables in protected or private
1488 * gdcmUtil : bug fix for the clean string method
1490 2004-01-19 Benoit Regrain
1491 * Add the use of shadow dictionaries
1492 * bug fix and coding style
1494 2004-01-19 Benoit Regrain
1495 * src/gdcmFile.cxx : bug fix concerning the close of file
1496 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1497 * Add the update of header entries using the shadow library
1499 2004-01-19 Benoit Regrain
1500 * removal of file gdcmHeader2.cxx
1501 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1502 inheriting from gdcmParser. This split is to prepare the integration
1503 of dicom dir parsing
1504 * bug fix under python
1506 2004-01-16 Jean-Pierre Roux
1507 * REM removal of class gdcmHeaderEntrySet
1508 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1509 * ADD add file gdcmHeader2.cxx
1510 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1512 2004-01-15 Benoit Regrain
1513 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1514 entries created while parsing the header. Thus, they will be destroyed
1515 when the gdcmDictSet will be destroyed
1516 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1519 2004-01-15 Benoit Regrain
1520 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1521 made a fatal error because of the memory release at the end of program.
1522 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1523 some memory and vtk seems to have some problems with that.
1524 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1526 2004-01-14 Benoit Regrain
1527 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1528 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1529 * src/*.[h|cxx] : make changes due to class name changes
1530 * gdcmPython/demo/*.py : bug fix due to method names
1532 2004-01-13 Benoit Regrain
1533 * src/*.[h|cxx] : coding style
1534 * vtk/*.[h|cxx] : coding style
1536 2004-01-13 Benoit Regrain
1537 * gdcmPython/testSuite.py : test the readable flag of file for tests
1538 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1539 It's lied to the stl compilation by MSVC (windows, always windows...)
1540 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1542 2004-01-12 Benoit Regrain
1543 * src/*.h : add comments
1544 * src/gdcmDictSet.h : set the method BuildDictPath in public
1545 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1546 directly setted in the source code
1547 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1550 2004-01-09 Benoit Regrain
1551 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1552 * setup.py : use a reference to gdcmVERSION
1554 2004-01-07 Benoit Regrain
1555 * Modification to compile with the distutils.
1558 2003-12-10 Benoit Regrain
1559 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1560 can use a gdcmHeaderHelper to load datas
1561 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1562 made in the source code
1564 2003-12-10 Benoit Regrain
1565 * Update Windows projects and .cvsignore files
1567 2003-11-12 Jean-Pierre Roux
1568 * ENH gdcmHeader constructor has one more parameter (default value : false)
1569 that allows the user to 'go inside' the SeQuences only
1571 gdcmElValSet:Print takes it into account
1573 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1574 * ENH: Update gdcmPython/CMakeLists
1575 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1576 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1578 2003-11-10 Jean-Pierre Roux
1579 * FIX : gdcmHeader::LoadElements is now based
1580 on the ListTag listElem member,
1581 not longer on the TagElValueHT tagHt member
1582 * ENH : PrintPubElVal shows (temporarily) both results,
1583 with the tagHt member and the listElem member.
1584 (it's easier to 'see' the problems when using Printheader)
1586 * FIX : old private member LgrElem is now splitted into
1587 ReadLength : Length actually found on disk (updated only
1588 if bug fixing is necessary), for internal
1590 UsableLength : Updated by FixFoundLength, to fix a bug
1591 or to allow Parser going on.
1592 Will allow to re-write a kosher header when a SeQuence
1593 with a length (not 0000) is found
1594 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1595 because gdcmElValSet::Add does not update ListElem
1598 2003-11-07 Jean-Pierre Roux
1599 * FIX misstyping in Transfert Syntax name table
1600 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1601 when they have an actual length (not 0000 nor FFFFF)
1602 (Nobody should care of it, but DICOMDIR explorers)
1604 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1605 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1607 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1608 * ENH: vtkGdcmReader now supports LUT !
1609 (vtkgdcmViewer for now is not able to use them though)
1611 2003-11-05 Jean-Pierre Roux
1612 * in testSuite.py : new files names for checking the package
1613 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1614 that returns the pixel area size to the *aware* (vtk) user
1615 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1617 2003-11-05 Benoit Regrain
1618 * in testSuite.py : Modify the rules for checking the paths
1619 : Explicit error messages
1620 * in __init__.py : Related modif
1622 2003-11-03 Jean-Pierre Roux
1623 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1624 to be used by aware (vtk) users that want to manage
1625 LUT (and no to turn the PALETTE image into an RGB pixels one)
1626 * GetPixelType now returns 8U for 24 Bits images
1627 (vtkGdcmReader compliant)
1629 2003-10-31 Jean-Pierre Roux
1630 * Removal of *all* gdcmData images and add them again
1631 in order to loose the 'history' of un-anonymised images
1633 2003-10-31 Jean-Pierre Roux
1634 * RMV : removal of useless jBitsInJsample.h
1635 for both 8 and 12 Bits JPEG Lossy Libraries
1637 2003-10-31 Jean-Pierre Roux
1638 * ENH : Add the functions gdcmFile::GetImageDataRaw
1639 gdcmFile::GetImageDataIntoVectorRaw
1640 that act as GetImageData and GetImageDataIntoVector
1641 except the making of an RGB Plane from Gray Plane + LUT
1642 Intended to aware (vtk) users who know how to manage
1645 GetLUTRGBA return a R,G,B,A LUT if any
1646 lgrTotaleRaw gives the 'Raw' length
1647 GetImageDataRaw returns the gray Plane
1648 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1649 (They stay Grey, just like with other Dicom viewers :-(
1651 2003-10-30 Jean-Pierre Roux
1652 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1654 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1655 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1656 being coherents dicom files.
1658 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1659 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1661 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1662 * ENH: Two steps is necessary to please VC++ compiler...
1663 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1664 * ENH: Add include dir to medcon lib
1665 * FIX: only one function is being exported for now !
1666 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1668 2003-10-29 Jean-Pierre Roux
1669 * adding gdcmHeader::GetLUTRGBA
1670 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1671 --> Mathieu, the modif u're waiting for is not yet committed
1672 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1674 2003-10-27 Jean-Pierre Roux
1675 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1676 00191113.dcm DermaColorLossLess.dcm
1677 MxTwinLossLess.dcm RadBWLossLess.dcm
1678 * ENH: For version prior to vtkImageViewer2 -r 1.19
1679 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1681 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1682 * Removal of ido stuff in CMakeLists.txt
1684 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1685 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1686 * FIX: remove a call to ->Modified ... see comments
1687 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1689 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1690 * FIX: Problem with path for libvtkgdcmPython
1691 * ENH: Try adding a search script for python site-package
1692 * RMV: Remove some file from medcon lib that are not necessary
1693 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1694 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1695 * FIX: More pragma disable fro VC++,
1696 I don't think I break something as it is also disable in VTK/ITK.
1697 But it fasten debug compilation time.
1699 2003-10-23 Jean-Pierre Roux
1700 * gdcm now deals with 16 Bits Run Length Encoded images
1701 (they are compressed as 2 planes images,
1702 one for the high Bytes, the other for low Bytes)
1704 2003-10-22 Jean-Pierre Roux
1705 * Now CheckRead takes into account :
1706 - the bugged 'Leonardo' Siemens images
1707 - the XA images, sent thru the burning VPRO station
1708 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1711 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1712 * FIX: When copying a Makefile.am to CMakeLists.txt
1713 one should remove the '\'
1715 2003-10-22 Jean-Pierre Roux
1716 * in gdcmData adding a bugged 'Leonardo' Siemens image
1717 (wrong lengths in header)
1718 OK with gdcm, KO with the other viewers :-)
1719 * add a GE dlx XA image, thru the VEPRO burning station
1722 2003-10-21 Jean-Pierre Roux
1723 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1724 for a brutal checking of vtkgdcmViewer compliance
1726 2003-10-21 Jean-Pierre Roux
1727 * add the files for 'xmedcon' Jpeg Lossless library
1728 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1730 2003-10-21 Jean-Pierre Roux
1731 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1733 2003-10-21 Jean-Pierre Roux
1734 * garbage Siemens 'Leonardo' images dealt with
1735 (the patch is easy to remove)
1736 * cosmetic changes to avoid warnings
1738 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1739 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1740 no need to press 'r' now.
1742 2003-10-20 Jean-Pierre Roux
1743 * upgrade of checkRead.sh checkWrite.sh according
1744 to new Jpeg Lossless decompressor
1745 * add US.3405.1.dcm, a genuine RGB medical file ...
1746 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1747 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1749 2003-10-15 Jean-Pierre Roux
1750 * general anonymisation in gdcmData
1751 * adding the 'color files' from
1752 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1753 * adding some well knowed bugged-header images
1754 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1755 waiting for their inclusion in Python testsuite
1757 2003-10-15 Jean-Pierre Roux
1758 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1759 no longer seg faults when file is not found
1761 2003-10-14 Jean-Pierre Roux
1762 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1765 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1766 * TODO: *.in file to genereate a UseGDCM later
1768 2003-10-14 Jean-Pierre Roux
1769 * Some supposed-to-be Dicom Images have no preamble.
1770 OpenFile takes it into account
1771 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1772 * Missing elements added in dicomV3.dic
1773 (just to be affraid : have a look at
1774 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1775 and do it again next year ;->
1777 2003-10-13 Jean-Pierre Roux
1778 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1779 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1780 But there are NOT. It's fixed !
1782 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1783 * FIX: "jpeglib.h" was not found on VC++
1784 * FIX: vtkgdcm was not being installed
1786 2003-10-10 Jean-Pierre Roux
1787 * ENH : OpenFile closes the file if it *really* doesn't look like
1788 an ACR-NEMA / DICOM one.
1789 * FIX : testWrite no longer writes an empty file if the source file
1790 is not gdcm Readable
1791 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1794 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1795 * FIX: CMake generate now documentation
1796 * ENH: out of source doc build !
1797 * ENH: Generate both user and dev documentation
1798 * ENH: Should work on windows too
1799 * ENH: Only one doxygen config.in file is needed
1800 * FIX: make install should be ok now on ùnix plateform
1801 * FIX: PATH to dictionary was wrong (missing /)
1802 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1804 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1805 * vtkGdcmReader is now able to read rgb dicom file.
1806 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1807 * added a gdcmViewer to vtk test, use mouse to control
1808 window level & window width
1810 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1811 * CMake-ification of gdcm, we have now two build system
1812 * FIX: on cygwin Wsock32 doesn't exist
1813 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1815 2003-10-06 Emanuel Ollart
1816 * FIX : compilation process wad broken.
1817 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1819 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1820 * change gdcmViewer -> vtkgdcmViewer
1821 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1823 2003-10-06 Jean-Pierre Roux
1824 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1825 ( e.g : well known GE images with a wrong elem length,
1826 : Philips MRI Images with a wrong Huffman table)
1827 * still to be done : allow the reading of bugged LEONARDO Siemens images
1829 2003-10-03 Jean-Pierre Roux
1830 * Odd length strings are padded with '\0' (not with spaces,
1831 to remain compliant with already defined strings,
1832 like Transfert Syntax UID and others)
1834 2003-10-03 Jean-Pierre Roux
1835 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1836 to allow displaying RGB images (not only by affim ;-)
1838 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1839 * vtkGdcmReader is now able to read rgb dicom file.
1840 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1842 2003-10-03 Jean-Pierre Roux
1843 * A few nasty patches to allow the reading of a lot of nasty images
1844 ( e.g : well known GE images with a wrong elem length,
1845 : Philips MRI Images with a wrong Huffman table)
1846 * still to be done : allow the reading of bugged LEONARDO Siemens images
1848 2003-10-03 Jean-Pierre Roux
1849 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1851 2003-10-03 Jean-Pierre Roux
1852 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1853 to allow displaying RGB images (not only by affim ;-)
1855 2003-10-03 Jean-Pierre Roux
1856 * gdcmFile::GetImageDataIntoVector now
1857 - deals with MultiFrames MultiFragments Run Length Encoded files
1858 - deals with YcBcR (YBR_FULL) files
1859 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1860 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1862 (no sample found :-(
1864 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1865 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1866 Two reasons: - clear things
1867 - third parties acces gdcm through header files, so won't
1868 suffer anymore VC++ complains
1870 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1871 * add argv[1] in testvtkGdcmReader.cxx
1874 2003-09-24 Jean-Pierre Roux
1875 * The lines are now eigthy characters long.for
1876 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1878 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1879 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1880 char* to std::string. Thus, the use of strdup becomes useless. (see
1881 previous commis of Malaterre)
1882 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1883 before the last Malaterre's commit.
1885 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1886 * This commit should fix the Debug building under VC++, the problem
1887 was mainly a mixture of debug and release lib being loaded at startup.
1888 * I also remove a depency to a specific C function: strdup. Because I had
1889 to force the link to msvcrtd (whereas strdup is in libc).
1891 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1892 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1893 located in the gdcmCommon.h file. All use of reference of tha has been
1894 changed to now use the variable GDCM_UNFOUND.
1896 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1898 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1899 Dicom dictionary. The test suite can now be run again. Note:
1900 I'm note very happy with the " (RET)" changes. I believe this
1901 RETAINED comment should be dropped when parsing the dictionary.
1902 - PACKAGER corrected
1904 - AUTHORS updated and now in alphabetical order
1905 * Makefile.am now exports gdcm.dsw for Windoze users.
1907 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1908 * cygwin complains about missing std:: in subdir Test/
1910 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1911 * remove some methods that are now in gdcmHeaderHelper
1913 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1914 * vtkGdcmReader set spacing and origin correctly
1916 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1917 * Fix a few delete/delete[] mismatch
1919 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1920 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1921 interpretation to data given by gdcmHeader. For instance there are
1922 heuristics to get informations (look at different places).
1923 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1924 sorting DICOM images based on different strategies.
1925 * modified Makefiles accordingly.
1927 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1928 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1929 when building in debug mode
1930 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1931 src/win32/gdcmdll.dsp
1932 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1934 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1935 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1938 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1939 * src/win32/libgdcmjpeg12.dsp was not dos format
1940 * src/win32/libgdcmjpeg12.dsp :
1941 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1942 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1944 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1945 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1947 * src/gdcmFile.cxx : bug fix in affectation type
1948 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1949 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1950 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1951 symbols... future problem ?
1953 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1954 * src/win32/libgdcmijpeg12.dsp was missing
1955 * modified gdcm.dsw accordingly
1957 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1958 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1960 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1961 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1962 commit of JPR (before his hollidays to facilitate our work).
1963 * setup.py : bug fix in code. Modifications made while the last commit
1964 of JPR. The code hasn't been tested before the commit... it's so
1965 useless to make that (for best programmer that is JPR) !!!
1967 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1968 * tagged the current version as Version0_3 (i.e. version 0.3)
1970 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1971 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1972 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1973 * *.dsp : modifications to use new libgdcmijpeg8 library
1974 * setup.py : bug fix on VTKPATH variable
1975 * PACKAGER : adding all concerning windows
1977 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1978 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1980 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1981 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1982 test suite reported error.
1983 * PACKAGER file added (describes what a packager must do when
1984 packaging a new release).
1985 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1986 * configure.in: upgraded version number to 0.3.0
1987 * fixing build of rpm (through rpm -ta):
1988 - Doc/Makefile.am exports proper doxygen files
1989 - src/jpeg/libijg8/Makefile.am exports the include files.
1991 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1992 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1993 * src/gdcmHeader.h : formatting code
1995 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1996 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1997 We were obtaining error message from vtk. Now, creation of file list
1998 is made in an internal list to prevent this problem.
1999 Bug fix when output is empty.
2000 Bug fix in update of progress value. Previous commit for this was a bad
2002 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2004 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2005 * src/gdcmHeader.h : added method to get the file name
2006 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2007 files. Added method to remove all files on the input
2008 Added FIXME comment concerning the bad parsing of header made by
2009 ExecuteInformation method (in ExecuteData method)
2011 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2012 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2013 when using make instal.
2014 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2015 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2017 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2018 * setup.py : adding include dir of jpeg lib to compile all sources
2019 * */Win32/*.dsp : JPR fix for windows compilation
2021 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2022 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2024 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2025 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2027 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2028 * setup.py is again effective on un*x (takes into account the
2029 addon of the jpeg library)
2030 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2031 * Doc/Doxy* updated (includes above enhancements)
2032 * INSTALL now points to web documentation
2034 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2035 * src/gdcmHeader.h doesn't make unnecessary reference to
2037 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2039 * src/gdcm*.[cxx|h] :
2040 - to allow compilation with gcc 3.x
2041 -- clean up of STL usage (added explicit usage of std::)
2042 -- small fixes on exceptions.
2043 Note: linking not tested !
2044 - clean of doxygen comments to avoid warnings at documentation
2046 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2047 dependent convertion).
2049 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2050 * Clean up of previous JPR garbage commit (not even commented in the
2052 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2053 - moved all jpeg related files from src to src/jpeg/libijg8, with
2054 addition/modification of Makefile.am and configure.in.
2055 - the testSuite is still brain damage (not guilty).
2057 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2058 * WrapVTK.py : modifications to get correctly vtk source files to
2060 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2061 (FileName -> Filename)
2063 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2064 * vtk/vtkGdcmReader.[cxx/h]:
2065 - UpdateProgress method should now be effective
2066 - removed the limitation on having only images loaded (as opposed
2068 - when building a stack of images/volume, a lesser number of
2069 gdcmHeader and gdcmFile instances should be used (hopefully
2070 accelerating things).
2071 - when building a stack of images/volumes, files which are not
2072 loadable (wrong path-filename, wrong permissions on existing file,
2073 or file not parsable by gdcm) are replaced with a black image
2074 in the stack (for the caller to notice the problem).
2076 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2077 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2079 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2080 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2081 between standard library (std) and vtk library (problems are found
2082 under Windows... thanks Windows !)
2084 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2085 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2087 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2089 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2090 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2092 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2093 * When compiling with distutils (see setup.py) the C++ compiler is
2094 called with different flags than the default ones (with automake).
2095 In order to fix all those warning, I compiled gdcm with the command
2096 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2097 and went for warning fixes:
2098 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2099 up from unused variables.
2100 - vtk/vtkGdcmReader.cxx: potential bug fix.
2101 * src/gdcmHeader.h: Doxygen warning cleanup
2103 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2104 * gdcmPython/gdcm.i:
2105 - typemaps correction to take into account the systematic replacement
2106 of "using namespace std" with std:: prefix e.g. std::list,
2107 std::string... (cf changes of 2003-05-21).
2108 - gdcmGlob global variable of type gdcmGlobal (defined in
2109 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2110 exported to Python a as cvar.
2111 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2112 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2113 gdcmDictSet.GetPubDictTagNames() and
2114 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2115 C++ static methods).
2116 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2117 with the above changes.
2119 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2120 * setup.py, manifest.in : bug fix under linux
2122 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2123 * Modification of setup.py to compile vtk part too. Then, we have 2
2124 wrappers which must work with same distutils. For that, we have a
2125 generic distutils in distusiltsWrapping.py ; with :
2126 - build_extWrap class to wrap generically all extensions,
2127 - ExtensionWrap base class for all wrapping extension that contains
2129 - Wrapper interface which wrap sources
2130 + In WrapSwig.py we have extension and wrapper for Swig
2131 + In WrapVTK.py we have extension and wrapper for VTK
2132 * MANIFEST.in : modifications to consider vtk directory and new python
2133 files for compilation
2135 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2136 * Added python wrappers of vtkGdcmReader vtk class (see the
2137 source in vtk/vtkGdcmReader.cxx) :
2138 - vtk/Makefile.am now builds a library
2139 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2140 python library (as opposed to _gdcm.so wich are the python
2141 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2142 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2144 - configure.in has an additional flag --enable-vtk that needs
2145 to be set to enable compilation of vtk related code, that is:
2146 + vtk/vtkGdcmReader.so and
2147 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2148 + gdcmPython/vtkgdcmPython.so (see above)
2149 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2150 be read when compressed or when HighBit + 1 != BitsStored),
2151 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2152 the usage of the python wrapper of vtkGdcmReader vtk class.
2153 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2154 * src/*.[h] all occurences of stl classes are now prefixed with
2155 std::, and all occurences of "using namespace std;" where removed.
2156 This is to avoid pollution of global namespace in included files.
2157 Apparently vtk does not avoid this pitfall: when using both
2158 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2159 collision of various stl members (principally cout...).
2160 * gdcmPython/testSuite.py now cleanly removes temprory generated
2162 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2163 comply with above changes)
2165 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2166 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2167 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2168 vtk data structure (an image Flip was required).
2169 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2170 * cosmetic changes in documentation.
2172 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2173 * src/gdcmHeader.cxx: the constructor no longer exits when an
2174 unexisting file is given as argument.
2175 * The subdirectory Data (containing all the images used for the
2176 test suite) is not part of this repository anymore. A new module
2177 containing those images is now available at
2178 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2179 with the name gdcmData.
2180 All the python scripts (including the package initialisation file
2181 gdcmPython/__init__.py) were adapated to take this change into
2182 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2184 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2185 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2186 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2187 demo of the usage of this class.
2188 Compilation of this vtk part is only done when using the --enable-vtk
2189 at configure (or autogen.sh) stage.
2191 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2192 * More memory link related corrections and documentation fixes.
2194 - maximum info is obtained with a command of the form:
2195 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2196 --show-reachable=yes PrintHeader
2197 - the remaining reachable blocks seem to come from the STL
2198 allocation scheme through the usage of map and list. It looks
2199 like this memory cannot be freed but it is not a memory leak
2200 (in fact further invocation to the STL would recollect the
2201 unused memory allthough it cannot explicitely be freed).
2202 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2203 of displaying an image parsed with gdcm and displayed with VTK.
2204 Note: some images don't seem to work e.g.
2205 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2206 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2207 Allthough this weakens the semantics, it is a ditch attempt to
2208 make gdcm more thread friendly.
2210 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2211 * Memory link hunt (by using valgrind through the command
2212 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2213 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2214 gdcmHeader::_dicom_vr.
2215 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2216 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2218 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2220 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2221 * src/Makefile.am now exports all the necessary include files at
2225 * UpdateGroupLength replaced by new one
2228 * UpdateGroupLength re-written using H-Table
2229 (named UpdateGroupLengthNew untill checks are over)
2231 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2232 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2233 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2235 - gdcmHeader::GetPubElValSet removed.
2236 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2237 UpdateGroupLength, WriteElements, Write.
2238 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2239 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2240 carried the same semantics.
2241 - src/gdcmHeaderIdo.cxx changed accordingly.
2242 - gdcmFile::WriteBase now regroups all the codes from previous
2243 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2244 - enum FileType moved to gdcmCommon.h
2245 * src/gdcmHeader.cxx AddDefault trashed
2246 * gdcmGetXSize added
2247 * getimageDataSize now calls gdcmGetXSize
2248 * Test/*.cxx changed to agree with above changes
2250 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2251 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2252 (to avoid double call by end user).
2253 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2254 by end user, since gdcmHeader::gdcmHeader now handles it.
2256 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2257 * gdcm/Doc many doxygen changes:
2258 - Doxyfile now has two different versions, DoxyfileUsers that generates
2259 the html.users end users oriented documentation and
2260 DoxyfileDeveloppers that generates the html.developper developper
2261 oriented documentation.
2262 - README changed accordingly
2263 - requirement.txt removed (old design info moved to TODO).
2264 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2265 DoxyMainPage.txt, DoxyPython.txt provide more information.
2266 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2267 be updated by simply regenerating the docs with doxygen and copying
2268 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2269 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2270 all the tests in the form "if (<map>.count() >1)" were removed.
2271 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2272 ill-formed documentation sections.
2273 * src/gdcmHeader.cxx: ditto
2275 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2276 * setup.py fixed for un*x (needed macro for stdint.h)
2277 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2278 un*ces with sh-utils test utility.
2279 * gdcmPython/demo/test.py renamed to PrintHeader.py
2280 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2281 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2282 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2283 * src/gdcm*.cxx JPR's bad inclusion fixed.
2285 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2286 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2287 * gdcmPython/demo/test.py changed accordingly.
2289 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2290 * gdcmPython/Makefile.am fixed linking against libstdc++
2291 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2292 * Swig subdir (historical tests of swig version 1.3.17++) removed
2293 * Test/testChangeEntete.cxx some lines commented out in order to make
2295 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2296 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2298 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2299 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2300 hence the user doesn't need this explicit call.
2301 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2302 i.e. LoadElements() call removed.
2303 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2304 - src/Makefile.am declares the proper flag for g++.
2305 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2306 for adding user defined new tags.
2307 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2308 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2309 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2311 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2312 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2313 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2314 src/Makefile.am : the project should properly compile and install
2315 with the autotools, included the python wrappers part.
2316 * gdcm.spec.in : added a spec file for RPM packaging.
2318 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2319 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2321 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2322 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2323 to exported to the environement (see gdcmPython/testSuite.py
2325 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2326 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2327 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2328 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2329 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2331 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2332 * gdcmPython/__init__.py doesn't crash anymore when running in
2333 in InstallMode or PreInstallMode but with an environement given
2334 value of GDCM_DICT_PATH.
2335 * src/gdcmDictSet.[cxx/h] coding style.
2337 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2338 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2339 * src/gdcm.h general comments moved to TODO, and README
2340 * src/gdcm.h should now be seen as a user commodity (including it
2341 should suffice to fully use gdcm). It is nowhere including within
2342 any of the kernel files src/*.cxx and src/*.h.
2344 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2345 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2346 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2348 * src/gdcm*.cxx only include their corresponding include file
2349 (as opposed to gdcm.h)
2350 * gdcmPython/gdcm.i changed accordingly
2351 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2352 the autogen.sh generated "make snapshot" command to work.
2353 * autogen.sh removed history related references to crea package.
2355 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2356 * distutilsSwigCPlusPlus.py work around some swig portability
2359 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2360 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2361 was done in a last ditch attempt to get setup.py _really_
2362 operationnal. The python/gdcmPython layaout add the advantage
2363 of hidding away the python related distutils specific files
2364 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2365 Alas, the src directory was out of scope (i.e. it's relative
2366 position to setup.py was ../src) which made things impossible to
2367 handle (see previous version of python/setup.py). Crossing fingers...
2369 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2370 * python/setup.py now works on Un*x. (harder than I thougth)
2371 * python/distutilsSwigCPlusPlus.py can now have include files
2372 among the list of sources.
2374 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2375 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2376 * modifications in MSVC projects
2378 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2379 * As stated by the first lines of Test/ExceptionAndPython/README, it
2380 looks like we can move back to original usage of exception within
2381 src/gdcm* and hence remove the errno stuff that was introduced
2382 as a quick and dirty fixture of this problem (added to the TODO).
2383 * Doc/Doxyfile configuration file for Doxygen and corresponding
2384 README file for usage added.
2385 * Test/testWrite.cxx added. This new test comes from a split of
2386 test.cxx that is now reverted to its original purpous i.e.
2387 testing the proper parsing of a Dicom related file.
2388 testWrite.cxx concentrates on testing the IO part of gdcm.
2389 * Test/bug1.cxx (containing a bug on WIn32) added.
2390 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2391 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2392 whose purpose is to publish the content of the TagNames of the
2393 Dicom public dictionnary were not accessible without an
2394 instance of class gdcmHeader.
2395 - those methods are now static methods of gdcmDictSet and hence
2396 require no instances at all to be invocated.
2397 - within gdcmDictSet this change required to change some method
2398 to class methods (i.e. are now static) among which SetDictPath
2399 (renamed to BuildDictPath) and LoadDefaultPubDict.
2400 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2401 the above changes by calling the new method classes of gdcmDictSet.
2402 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2403 the above to be effective.
2404 * python/gdcmPython: in order to wrap properly the above changes
2405 for Python, swig version now needs to be > 1.3.17.
2406 * python/gdcmPython/Makefile fixed to adapt itself to new
2407 configure/make shema introduced by Johan Montagnat (thanks for the
2408 contribution). Alas this Makefile cannot be turned into a proper
2409 Makefile.am without some heavy changes in the configure.in
2410 (for python dectection).
2411 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2412 now avoids publishing the empty entries.
2414 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2415 * python/setup.py : bug fix concerning install under windows
2416 ExtraPath reused :-P
2417 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2419 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2420 * Dicts/dicomV3.dic : remove double spaces !!!
2421 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2422 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2425 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2426 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2427 method. Doxygenation.
2428 * src/gdcm.h clean up of JPR spurious comments.
2430 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2431 * python/distutilsSwigCPlusPlus.py now properly collects the
2432 shadow classes generated by "swig -c++" (gdcm.py in our case)
2433 when using "python setup.py install".
2434 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2435 reexports the working classes.
2436 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2437 by the classical C errno scheme. This is to prevent an obscure
2438 behavior of the python wrappers when importing wxPython.wx prior
2439 to gdcmPython (which ended up in an abort call). An illustration
2440 of this oddity can be found in the Test/ExceptionAndPython
2441 subdir (see the README file). This problem probably due to
2442 an combination of g++ and dynamic loading.
2443 * added Test/ExceptionAndPython (see above)
2445 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2446 * Changed the layout of the python part to avoid bloating main
2447 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2448 i.e. the distutils arsenal. All the python related stuff is
2449 again in a python subdir, but the package itself is now in
2451 * setup.py was cleaned up:
2452 - pythonIncludePath removed
2453 - python setup.py bdist target is now functional.
2454 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2455 collision with other packages). gdcmPython/demo/*.py changed
2458 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2459 * python subdir moved to gdcmPython (preparation of distutils packaging).
2460 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2461 distutils installer is operational.
2462 * - gdcmPython/__init__.py now properly loads the swig generated
2463 shadow classes (from gdcm.py).
2464 - gdcmPython/demo/*.py changed to import the package gdcmPython
2465 instead of gdcmPython/demo/load.py.
2466 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2468 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2469 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2470 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2471 entries within the associated public Dicom dictionary resp. the same
2472 information but sorted by the fourth field (PAT, IMG, DIR) of the
2474 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2475 are now in the "???" group.
2476 - python/gdcm.i changed accordingly,
2477 - python/demo/printGroupedPublicDict.py added, that gives an example
2478 of the above new functionalities in Python.
2480 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2481 * src/gdcm.h, gdcmHeader.cxx:
2482 - historic references to glib's g_malloc and g_free (#defined)
2483 were definitively removed.
2484 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2485 * src/gdcmElValSet.cxx:
2486 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2487 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2488 - GetElValue(string) renamed to GetElValueByName.
2489 - Added GetElementByName(string).
2490 * src/gdcmHeader.cxx: added
2491 - GetPubElValRepByNumber(guint16, guint16)
2492 - GetPubElValRepByName(string)
2493 - GetShaElValRepByNumber(guint16, guint16)
2494 - GetShaElValRepByName(string)
2495 - GetShaElValByNumber(guint16, guint16)
2496 - GetShaElValRepByName(string)
2497 - GetElValRepByNumber(guint16, guint16)
2498 - GetElValRepByName(string)
2499 - GetElValByNumber(guint16, guint16)
2500 - GetElValRepByName(string)
2501 * Doc/requirements.txt added.
2503 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2504 * Test/Makefile building now depends on the one of libgdcm.so
2505 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2506 pixel data) aware which enables finding the address (offset) of
2507 the pixel data of JPEG encoded DICOM files. This leaves only a single
2508 file in the testSuite whose pixel data address (offset) is unknown.
2509 * python/testSuite.py changed accordingly.
2511 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2512 * VC++ has some strong limitations when working with the STL, as stated
2513 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2514 "Also note that some STL containers (map, set, queue, list, deque)
2515 cannot be exported. [...]
2516 Some STL classes contain nested classes. These classes can not
2518 This is caused by a designed limitation that once a template
2519 class is instantiated, it can not be re-instantiated and
2521 Since our usage of map<> is ubiquitous in gdcm, this "designed
2522 limitation" of VC++ is a pitfall.
2523 Hence the Python wrappers of gdcm cannot be incrementally linked
2524 against the c++ dynamic library. The dirty but only workaround is
2525 to forget about incremental link of dynamic libraries and to generate
2526 the Python wrappers library with the inclusions of the underlying C++
2528 The following modifications concern this matter on Win32/VC++:
2529 - wrapping python correct with standalone wrapped dll (don't use separate
2530 dll under windows !!!!)
2531 - python21_d debug mode enabled (ask Frog how to use it :-)
2532 - NO problem with having an STL member of class for example string in C++
2533 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2534 - Python test of dcmlib in Python is ok under windows on a large set
2536 * removed glib references
2537 * typedef's inserted in gdcm.i for correct swig type management
2539 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2540 * python/demo/*.py load.py extracted from test.py. Added explore.py
2541 that only displays required tags and testAll.py that parses all
2542 the files of the testsuite without using unittest.
2543 * python/testSuite.py other additional test on new files added.
2544 * Data/* new test files added accordingly to the testSuite.
2545 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2546 the vr in the file differs from the one of the dictionary.
2548 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2549 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2550 values, but limits itself to values which are below a user specified
2551 size (by default 1024 bytes).
2552 * python/gdcm.i : elements not loaded (because their size is above the
2553 user specified treshold) are exported with their TagKey as key of the
2554 python dictionary. This enables the testsuite to make some checks
2555 on the unloaded elements (since we have their offset and size).
2556 * python/testSuite.py
2557 - now tests for the existence and proper value of the pixel data
2558 - two new examples added.
2559 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2561 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2562 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2563 aware. See the strategy comments in gdcmHeader::FindeLength().
2564 * Test/test.cxx now accepts a filename as first argument.
2565 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2566 * python/testSuite.py changed to integrate test on above files.
2568 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2569 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2570 the vr was also RET.
2571 * python/testSuite.py more tests added.
2573 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2574 * python/testSuite.py unittest test suite added (uses Data)
2575 * Data/* dcm and acr files for the test suite.
2576 * glib dependance removed from un*x version. We now use ISO C99
2577 7.18 Integer types (see stdint.h)
2578 - python/Makefile, src/Makefile src/gdcm.h
2579 * src/ when an explicit vr (like dicom files) suddenly poped an
2580 implicit element we use to mark the underlying DictEntry of the
2581 concerned ElValue with "Implicit". This strategy was damageable
2582 too the public or provite dictionaries, since some of their vr
2583 would be changed. Since Header::FindLength heavily relies on the
2584 detection by Header::FindVR of falsely explicit elements, I
2585 added an extra ImplicitVr member to ElValue (boolean).
2586 The rest of the changes we the necessary adaptations.
2588 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2589 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2591 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2593 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2594 * Adaptation for porting to VC++:
2596 o forced to use std namespace (for string to be known)
2597 o all class use __declspec export style on WIN32
2598 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2599 (in stdlib.h on Win32 but in std:: for gcc)
2600 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2601 variable GDCM_DICT_PATH.
2602 * src/gdcmHeader.cxx verbose comments made discrete.
2604 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2605 * python/gdcm.i: added a typemap that converts a C++ hashing table
2606 to native Python dictionary.
2607 * python/demo/test.py:
2608 - now uses the native dictionary for exploration of gdcmHeader.
2609 - takes an optional filename argument (the file to parse).
2610 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2611 PubElVals hashing table.
2612 * Dicts/dicomV3.dic removed error prone trailing spaces.
2614 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2615 * Python wrapping process moved away from src/Makefile to
2616 newly created python/Makefile (as well as gdcm.i)
2617 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2618 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2619 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2620 from the environement variable GDCM_DICT_PATH (when existing).
2621 * src/gdcmDict::GetTag bug fix.
2623 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2624 * Straightforward temporary fixes for swig to build the python wrappers.
2625 src/Makefile now has a python working entry [by working we mean
2626 that we can import de shadow classes without errors].
2628 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2629 * hashtest.cxx removed (since allready in Test)
2630 * src/gdcmlib.h renamed to src/gdcm.h
2631 * src/dcm.i renamed to src/gdcm.i
2632 * src/Makefile prepared for python wrapping
2634 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2635 * src/gdcmHeader.cxx :
2636 - Parsing of header is now separated from loading of element values
2637 (see gdcmHeader::LoadElements).
2638 - general clean up of hopefully all file access (creation of
2639 ReadInt16 and ReadInt32)
2641 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2642 * src/gdcmHeader.cxx :
2643 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2645 - SetLgrElem renamed to SetLength
2646 - GetLgrElem renamed to GetLength
2647 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2648 * src/gdcmElValSet.cxx fixed both GetElValue methods
2649 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2650 due to IdoDude was cleaned out.
2652 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2653 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2654 concentrates on finding the value representation (when it exists).
2655 RecupLgr now only finds the element value length, and it avoids
2656 returning the unecessary skL (skipped length).
2657 Also, offsetCourant was simply removed (with taille_fich) since
2658 it was redundant with the File position internals (by using
2659 ftell and fseek). This also made skL (see above in RecupLgr) usage
2661 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2662 on the libido specificities which are handled through class
2664 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2667 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2668 * Truckload of changes. Parsing of header is barely functional
2669 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2671 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2672 * src/gdcmHeader.cxx many addons of low level methods
2674 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2675 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2676 and _IdDcmSWAP_LONG.
2678 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2679 * This corresponds to all the changes decided at the meeting of
2680 May 23 2002. Needless to say we are running late...