1 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
3 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
4 matters, as stated in warning note at begining of %include section).
5 * src/gdcmDicomDir*.[cxx|h]: coding style
6 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
7 * src/gdcmJpeg8.cxx: doxygen fix.
8 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
9 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
10 from File:: to PixelConvert::.
12 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
13 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
14 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
15 - more code moved away from File:: to PixelConvert::
16 - fat setup of PixelConverter set in place in File::Initialise.
18 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
19 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
20 namespace at the file system level. So now you should convert your examples
22 gdcmHeader -> gdcm::Header
23 It would be nice if people keep in mind to no open the namespace, since it
24 allows compilation on broken plateform which were defining common symbol in
25 the standart namespace (like LP, Unknown ...)
27 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
28 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
29 The JPEG fragments are now parsed at the same stage than the RLE
30 information. All code related to JPEG is now in gdcmPixelConvert:
31 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
32 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
33 export a gdcmFile:: method. Those are simply global functions
34 (for the time being this is better than having them attach to
35 either gdcmFile:: or gdcmPixelConvert::).
36 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
37 and stores the result in a gdcmJPEGFragmentsInfo.
38 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
39 code (among other stuff) moved away from gdcmFile:; to
42 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
43 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
44 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
45 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
46 clean up of RLE related code.
47 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
48 - src/gdcmRLE.cxx removed
49 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
50 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
51 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
52 * CLEANUP_ROUND (9) for gdcmPixelConvert
53 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
54 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
55 away from gdcmFile:: to gdcmPixelConvert::.
57 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
58 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
59 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
60 This is because Parse7Fe0 used to parse the pixels to compute the
61 length. This task was passed over to FindDocEntryLengthOB() a long
62 time ago, EXCEPT I had forgotten the OW case...
63 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
64 we just recylce the code for parsing RLE fragments and computing
66 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
67 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
68 with the retired Parse7Fe0().
69 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
70 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
72 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
73 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
74 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
75 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
76 - src/CMakeLists.txt: alphabetic order reodering + new entries.
77 * CLEANUP_ROUND (4) for gdcmPixelConvert
78 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
79 to return an unused length.
81 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
82 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
83 this should be cleanner from the plane view. The iostream are erally a pain
84 to use to do simple stuff.
86 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
87 * Redo the compilation of the ijg jpeg library. Now only one source is
88 necesseray. No need to rename file by hand what so ever. CMake handle the
89 copying of the file within different directory, configure header file to
90 modify some symbol. The only addition made to ijg wasd a mangle table so
91 that symbol are different wether we are within 8bits or 12bits.
93 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
94 * Added documentation of vtkgdcmReader on Website:
95 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
96 with it's binary name).
97 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
98 the Website to be more complete.
99 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
100 doxygenated documentation.
101 - Doc/DoxyVtkGdcmReaderExamples.txt added
102 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
103 DoxyVtkGdmReaderExamples.html )
104 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
105 * CLEANUP_ROUND (3) for gdcmPixelConvert
106 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
108 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
109 * CLEANUP_ROUND (2) for gdcmPixelConvert
110 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
112 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
113 * CLEANUP_ROUND for gdcmPixelConvert:
114 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
115 - src/gdcmPixelStuff[h|cxx] removed
116 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
117 - src/CMakeLists.txt changed accordingly
119 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
120 gdcmVersion.py moved to newly created ATTIC related
121 gdcmPython/SetupOldies/ directory.
122 * Autotools clean up:
123 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
124 - autogen.sh configure.in acinclude.m4 python.m4 removed
126 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
127 * src/*.cxx *.h Reference to License.htm fixed to License.html.
128 * Doc/CMakeLists.txt, doxygen.config.in: fix.
129 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
131 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
132 * TODO updated with Mathieu suggestions. I proposed a template for
133 describing TODO entries and used it for new entries.
134 * Added Doc/Website/CodingStyle.html, Developpers.html,
135 DeveloppersPython.html, GdcmDataCvs.html and
136 DownloadVersion0_1.html, DownloadVersion0_3.html.
137 * Some Doc/*.txt Doxygen files (which do not really concern the
138 documentation itself, but the website) moved to html and
139 placed in directory Doc/Website:
140 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
141 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
142 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
143 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
144 * CMakeLists.txt changed accordingly.
145 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
146 DeveloppersPython.html
147 * INSTALL nows refers to Doc/Website/Installation.html
149 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
150 * Added Doc/Website directory, that contains a first raw version
153 2004-09-23 Jean-Pierre Roux
154 * FIX In order not to be poluted any longer by casting problems,
155 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
156 we can now delete[] it safely
157 * VoidArea is now called BinArea (less confusing name),
158 and all the methods called ...VoidArea... are now ... BinArea...
159 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
161 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
162 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
163 clear) TagHT, which is an inherited member of gdcmElementSet. It is
164 up to the destructor of gdcmElementSet to clean up TagHt and it's
167 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
168 * Test/CMakeLists.txt: update to follow gdcmData renamings.
169 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
171 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
172 * ENH: added some utility method that builds a flat dictionnary
173 holding all the Dicom entries contained in the recursive structure
174 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
176 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
177 BuildFlatHashTable() that build a flat dictionary.
178 - src/gdcmElementSet.h: added a new private GetTag() accessor.
179 gdcmDocument is now a friend of gdcmElementSet.
180 - src/gdcmElementSet.cxx: clean up.
181 - Example/FlatHashTablePrint.cxx added.
182 - Example/CmakeLists.txt changed accordingly
184 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
185 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
186 moved away from gdcmDocEntrySet (since this class is an abstract class
187 acting like an interface). SQDepthLevel and BaseTagKey are now
189 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
190 and associated accessors. Doxygenation of the class.
191 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
193 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
194 Use SQDepthLevel accessor instead. ::Print() adapted.
195 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
196 - src/gdcmDocument.cxx changed accordingly.
198 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
199 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
200 - The following is the doxygen comment of the typedef declaration
201 of gdcmagKey in src/gdcmCommon.h:
202 gdcmTagKey is made to old an "universal" (as in URL, Universal
203 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
204 A dicom tag allways has a group and an element, but a set of tags
205 embeded in various (optionally nested) sequences and sharing
206 the same group and element all share the same (group, element)
207 "identifier". Hence the (group, element) cannot be used as an
208 identifier (in gdcm we shall refer to a "TagKey") of a tag.
209 In order to construct a proper tag identifier (i.e. a key) we
210 consider the following definition of a TagKey:
211 - let Group, Element be the string representation of the
212 group and element dicom tag members,
213 - let ItemNumber be the string representation of the integer
214 index of the considered item number of a sequence,
215 Let the key of a tag embeded in a sequence, noted SeqTag, be
217 /ItemNumber#Group|Element
218 where "/", "#" and "|" are characters acting as separators.
219 Then the general form of a gdcmTagKey is given by:
220 Group|Element<SeqTag>
221 where <SeqTag> means NO or many instances of SeqTag.
222 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
225 but the gdcmTagKey of a tag "embeded" is the first item of
226 a sequence, itself nested in the third item of a sequence is the
228 0004|1220/2#0008|0082/0#0008|0090
229 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
230 order to hold the new sequence compatible key. Previously, the
231 GetKey() method would look in the underlying gdcmDictEntry.
232 - src/gdcmDocEntry.cxx:
233 -- constructor now copies the underlying DictEntry key, in the local
235 -- ::Print: displays the member Key, instead of the (group, element).
236 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
237 - src/gdcmDocEntrySet.h:xi
238 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
239 -- now has a new BaseTagKey member.
241 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
242 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
244 This poses the problem with the semantics of the following lines
245 LoadEntryVoidArea(0x0028,0x1201); // R LUT
246 LoadEntryVoidArea(0x0028,0x1202); // G LUT
247 LoadEntryVoidArea(0x0028,0x1203); // B LUT
248 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
249 to the long FIXME note for what the problem is. Nevertheless in
250 order to get things working the dicom dictionary was altered !
251 Please fix things urgently...
252 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
253 information), see above note on moving the member VoidArea. Nevertheless
254 the following entries previously correctly set as US are now inproperly
256 0028 1201 OW IMG Red Palette Color Lookup Table Data
257 0028 1202 OW IMG Green Palette Color Lookup Table Data
258 0028 1203 OW IMG Blue Palette Color Lookup Table Data
259 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
260 of gdcmDocEntry moved to gdcmSeqEntry.
261 * src/gdcmSeqEntry.cxx: STYLE.
263 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
264 * Test/TestAllEntryVerify.cxx minor fix and added comments.
266 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
267 * gdcmPython/testSuite.py: all the test suite in python is now moved
268 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
269 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
270 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
272 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
273 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
274 to avoid inclusion recursion until STL is reached.
275 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
276 mecanism. errno.h is not included in gdcm anymore.
277 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
278 (gdcmFormatError now inherits from gdcmFormatUnexpected).
280 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
281 gdcmData/TestAllEntryVerifyReference.txt
282 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
283 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
284 exception_on_error parameter.
285 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
286 - vtk/vtkGdcmReader.cxx changed accordingly,
287 - Example/*.cxx and Test/*.cxx changed accordingly.
289 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
290 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
291 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
292 enable_sequences removed from gdcmHeader constructor and dependencies.
293 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
294 * gdcmPython/demo/PrintHeader.py: dummy fix.
295 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
296 skip_shadow removed from gdcmHeader constructor and dependencies.
297 * Example/*.cxx and Test/*.cxx changed accordingly.
299 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
300 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
301 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
303 2004-07-21 Jean-Pierre Roux
304 * FIX Now, Parsing and Printing a DICOMDIR do work!
305 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
307 2004-07-20 Jean-Pierre Roux
308 * FIX Some brain damaged headers have Zero-Lenght fields
309 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
311 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
312 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
313 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
314 variable (instance of gdcmDebug) by a definition macro, and the instance
315 is now in static in the gdcmDebug class
316 * src/gdcmSQItem.h : (FIXME) remove an undefined method
317 * Test/PrintAllDocument.cxx : bug fix in the result of the test
319 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
320 * WARNING: ctest now depends more tightly on gdcmData. You should
321 check out gdcmData properly for things to run smoothly...
322 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
323 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
324 we need the pixels not be loaded in order to use the ValEntry
325 that displays position and size).
326 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
327 This is a C++ based equivalent of gdcmPython/testSuite.py that should
328 be deprecated. If you have any doubts about the advantages of a
329 modern scripting language (read Python) versus grass root C++ (i.e.
330 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
331 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
332 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
333 Anyhow, consider documenting the gdcmData images in
334 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
336 * Test/CMakeLists.txt:
337 - now uses TestAllEntryVerify.cxx
338 - specific comments on oldACR00001.ima (now renamed in gdcmData
339 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
340 gdcmData/TestAllEntryVerifyReference.txt
343 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
344 * src/*.[h|cxx] : typedef clean up
345 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
346 - TagKey renamed to gdcmTagKey (for external usage)
347 - VRKey renamed to gdcmVRKey (for external usage)
348 - removal of typedef duplication.
349 - Removed all unecessary inline keyword from class inline definitions.
350 - Some method|function(void) declarations replaced with method|function().
351 * src/jpeg/libijg12/jdhuff12.c:
352 - printf polluting ctest removed.
353 - TAB removal for comminting
355 - TestAllReadCompareDicom.cxx: added a test that compares all the
356 images in gdcmDataImages.h with corresponding images in
357 gdcmData/BaselineDicom/. When baseline images are not present
358 this test creates them.
359 Note: we need to validate each reference image, but before that
360 I'd like to rename them with a more explicit name...
361 - CMakeLists.txt: changed accordingly.
362 * Example/*.cxx: examples now only include gdcm.h (as opposed to
363 including each header needed).
365 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
366 * Test/*.cxx and Example/*.cxx: moved some examples away from the
367 test suite to the Example directory. Are concerned:
372 - TestWriteSimple.cxx
373 * Test/CMakeLists.txt: added some comments on reasons for black listing
374 image gdcmData/oldACR00001.ima
376 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
377 * Test/CmakeList.txt: removed the following from black list (to be coherent
378 with removal from gdcmData):
379 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
380 - gdcm-MR-PHILIPS-16.dcm
382 Added the following because after last cvs update, they cause
383 ctest -R TestReadWriteReadCompare
385 - gdcm-MR-SIEMENS-16-1.acr
387 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
388 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
389 new comments in this file) we temporarily (sigh) move to a weaker
391 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
392 we don't need to black list the following images anymore:
393 - 8BitsUncompressedColor.dcm
395 - US-PAL-8-10x-echo.dcm
396 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
397 fixes and the beautified code ;-)
398 This fixes the bug introduced in version 1.42 (when beautifying)
399 that made the parsing of 8BitsRunLengthColor.dcm unproper.
400 Note: ctest was blind to this bug (this means we need to still
401 improve the test suite). The bug could be detected by using
402 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
404 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
405 and by displaying the (garbage) produced file temp.XDCM...
407 2004-06-29 Jean-Pierre Roux
408 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
409 - replace by uggly but working old code :-(
410 A lot of things should be OK again.
411 It's really urgent to have a test suite that *tests*,
412 to prevent Frog's beautifying sessions to break all the stuff
413 (twice, withing a fortnigh ...)
415 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
416 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
417 redundancy) to added Test/TestReadWriteReadCompare.cxx
418 * Test/CmakeList.txt: because the compare test of
419 Test/TestReadWriteReadCompare.cxx fails, the following images are
420 black listed: - 8BitsUncompressedColor.dcm
422 - US-PAL-8-10x-echo.dcm
423 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
424 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
425 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
426 and ad-hoc kludge. This kludge is now removed, and on encountering
427 such an image (OB field brain damaged) we set errno. Then in
428 ::FindDocLength() we "fix" the length as being ALL what remains
429 in the file (until EOF). We then proceed, hoping for the best...
430 This fixes a SegFault in ShowDicom when trying to write such an
432 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
433 (because TestWriteRead breaks on it, after a non conformal commit?).
434 ctest now runs properly, except for MakeDicomDir (which was allways
435 broken) and the Python related stuff (still not fixed).
437 2004-06-24 Jean-Pierre Roux
438 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
439 FIX : Test/TestReadWrite now iterates on all the file names
440 (instead of infinite loop)
441 ENH : Test/TestWriteRead now iterates on all the file names
443 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
444 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
446 2004-06-24 Jean-Pierre Roux
447 FIX : - now Write drops LUT Descriptors and LUTs (if any)
448 when SamplesPerPixel =3
449 - now Write is no longer confused by
450 'BitsAllocated = 12" and 'BitsStored=12"
451 - "UN" value representation Elements are now written correctly
452 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
453 ENH : - now gdcmHeader has its own Write methods
454 (in order to split the job that has not to be done
457 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
458 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
459 loop on the same image until memory went out.
460 Note: this means we still have gobs of memory loss in PrintDocument
461 * src/gdcmDocument.cxx: fixes problem on parsing on file
462 gdcmData/16BitsJpegLosslessGrayScale.dcm.
464 2004-06-24 Jean-Pierre Roux
465 FIX : Write - All the Sequences and Sequence Item are now written
466 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
467 is added a the end, when necessary.
468 - A lot of brain-damaged images, that were read correctly are
469 now written correctly
470 - length compatible BinEntry are now loaded correctly
471 (even for odd groups)
472 Note : only Explicit Value Representation was checked.
473 (question : is implicit VR really necessary for gdcm ?)
475 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
476 * DEVELOPPER: added a proposition of coding style.
477 * src/gdcmDocEntry.h: removed every inline declaration (for test of
480 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
481 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
482 Use the gdcmDocEntry::Print() and Write() instead.
483 * src/gdcmDocument.cxx: bug fix.
485 2004-06-22 Jean-Pierre Roux
486 FIX : gdcmDocument.cxx
487 - Now we do recognize the JpegLossLess format (there was a misstyping in
488 code 'beautyfication' :-(
489 - Now we automaticaticaly load the Luts, if any
491 2004-06-22 Jean-Pierre Roux
492 In order : to write Sequences, whatever their imbrication level,
493 : to allow user to create his own Sequences
494 a lot of modif where necessary (adding, moving, or virtualising methods)
496 WARNING : save your own sources *before* cvs up !
499 ADD virtual void Write(FILE *fp, FileType filetype);
502 ADD virtual void Write(FILE *fp, FileType filetype);
503 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
506 ADD virtual void Write (FILE *fp, FileType filetype)=0;
507 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
508 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
509 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
510 ADD std::string GetEntryByName(TagName name);
511 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
513 std::string vr = "unkn",
514 std::string fourth = "unkn",
515 std::string name = "unkn");
516 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
517 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
518 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
519 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
520 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
521 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
522 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
523 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
526 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
527 ADD virtual std::string GetEntryByName (TagName tagName);
528 ADD virtual std::string GetEntryVRByName (TagName tagName);
529 REM virtual bool Write(FILE *, FileType);
530 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
531 FILE *_fp, FileType type);
532 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
533 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
534 REM virtual bool WriteEntries(FILE *_fp,FileType type);
535 REM virtual std::string GetEntryByName (std::string tagName);
536 REM virtual std::string GetEntryVRByName (std::string tagName);
537 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
538 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
539 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
541 std::string vr = "unkn",
542 std::string fourth = "unkn",
543 std::string name = "unkn");
544 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
545 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
546 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
547 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
550 ADD virtual void Write(FILE *fp, FileType filetype);
553 ADD virtual void Write(FILE *fp,FileType filetype);
556 ADD virtual void Write(FILE *fp, FileType filetype);
557 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
558 REM std::string GetEntryByNumber(guint16 group, guint16 element);
559 REM std::string GetEntryByName(TagName name);
562 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
564 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
565 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
566 The default constructor invoked by the line
567 gdcmHeader *f1 = new gdcmHeader( header );
568 was gdcmHeader::gdcmHeader(bool) instead of the expected
569 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
570 Hence the parsing wasn't executed... See also below.
571 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
572 as explicit constructor didn't do the trick to fix the above problem.
573 Could anyone explain why ?
574 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
575 properly calls gdcmValEntry::Print() (that was weed out from
576 code related to gdcmBinEntry).
578 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
579 * In order to fix memory leaks:
580 - Test/TestWriteSimple.cxx: added cleaning of free store through
582 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
583 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
584 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
585 (through the call to ::AddDicomDirMeta()) or the destructor
586 would crash when deleting uninitialized ::metaElems].
587 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
588 - src/gdcmDocument.cxx:
589 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
591 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
592 was causing memory leaks.
593 - src/gdcmSQItem.cxx:
594 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
595 cleanly handled with polymophism: sorry but my milage is low).
596 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
597 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
598 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
599 This avoids SegFaulting.
600 - src/gdcmSQItem.h: coding style.
602 - Test/TestWriteSimple still severely sucks. The output image content
603 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
604 damaged when displayed with vtkgdcmViewer.
605 - on memory leaks: TestWriteSimple leaks really less (see entry
606 of 2004-06-18 in Changelog file for the call to valgrind).
607 - on segfaults: ctest now passes all the tests but one (no more
609 * Erroneous leading white fix:
610 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
611 white[s] (as opposed to from >> xxx, that removes it [them].
612 - src/gdcmTS.cxx: ditto.
613 - gdcmPython/testSuite.py: dirty related kludge removed.
614 * src/*: remaining references to gdcmParser removed.
615 * src/*[cxx|h]: added copy[way]left header.
618 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
619 * In order to fix writing of dicom files:
620 - Test/TestWriteSimple.cxx: a simpler example of writing.
621 - Test/CMakeLists.txt changed accordingly.
622 - src/gdcmDocument.cxx:
623 -- The destructor now recursilvely removes potential sequences.
624 -- Bug fix in ::IsJPEG2000()
625 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
626 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
628 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
629 to only declared) and build on top of
630 ::GetDocEntryByNumber(guint16, guint16).
631 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
632 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
633 for usage in destructor and treatement of promotion in
634 ::ReplaceOrCreateByNumber().
635 - src/gdcmSQItem.cxx: destructor should better handle his job.
636 Test/TestWriteSimple now runs (or at least it DOES something).
637 * We can now start hutting memory links. A good starting point is:
638 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
639 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
640 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
642 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
643 * Valgrind note: after Mathieu Malaterre teached me how to read
644 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
646 Using gcc, you can force the STL to use malloc and to free memory as
647 soon as possible by globally disabling memory caching.
648 With 3.2.2 and later, you should export the environment variable
649 GLIBCPP_FORCE_NEW before running your program.
650 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
651 simply vanish (it is still not clear to me, whether this means that
652 STL std::string leaks or if valgrind believes it leaks...).
653 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
654 running bin/gdcmTests makeDicomDir):
655 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
656 - Test/makeDicomDir.cxx now properly traps empty lists and returns
658 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
659 SegFaulting (I drowned in DicomDir related code when trying to
660 understand why the list is empty...).
661 * src/gdcmDocument.h: first BSD license header try.
662 * Doc/License.txt added.
664 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
665 * src/gdcmDocument.[h|cxx]:
666 - Clean up of the Transfer related predicates. They are now all based
667 on new method isGivenTransferSyntax, that (should) handle properly
669 - general clean up, simplification, and coding style.
670 - Specific clean up of Parse7FE0() (umproperly named actually).
671 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
673 2004-06-14 Jean-Pierre Roux
675 - fix the display of Sequence Delimitor (SQDepthLevel pb)
676 - fix the display of SQItem ordinal number
677 - add the GetSQItemByOrdinalNumber method
678 - remove some useless never written private methods
680 2004-06-14 Jean-Pierre Roux
682 - adding a constructor taking a gdcmDocEntry as an input param
683 - ReplaceOrCreateByNumber now returns :
684 a gdcmBinEntry * if a Binary (void *) value is passed as a param
685 a gdcmValEntry * if a string value is passed as a param
687 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
688 according to the param type (no longer sets a gdcmDocEntry)
689 - GetValEntryByNumber, GetBinEntryByNumber added
690 - NewValEntryByNumber and NewBinEntryByNumber added
692 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
694 - GetSQItemNumber and SetSQItemNumber added, to provide
695 a (relative) Item identier inside a given Sequence
696 \warning : some pb remaining around this number
698 - AddEntry now takes the Item Number as a param
700 - adding a constructor taking a gdcmDocEntry as an input param
702 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
703 * Memory leak hunt with the following command:
704 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
705 --show-reachable=yes gdcmTests PrintDocument
706 It looks like many (all?) leaks are due to the STL (or a bad usage
707 of the STL. The lines producing the leaks now have a comment with
708 a "MEMORY LEAK" tag: you can retrieve them with
709 grep "MEMORY LEAK" src/*
710 Here are two typical examples which I can't help fixing:
715 char * test = "babo";
716 name = test; //// <--- valgrind detects 960 bytes lost in
717 //// call to std::string::operator=(char const*)
718 name.clear(); //// Doesn't help !
726 std::cout << "Type a bunch of characters followed by RETURN: ";
727 getline(std::cin, line); //// <--- valgrind dectects a loss
728 //// of 1320 bytes in call to
729 /// std::basic_istream<>& std::getline<>
735 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
736 * src/gdcmHeader.[cxx|h]:
737 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
738 and related, moved away to gdcmDocument.
739 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
740 the corresponding protected accessors of inherited class
741 gdcmDocument, removed ! As a consequence gdcmFile had to be
742 declared friend of class gdcmDocument (see below).
743 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
744 - Clean up of undefined or unused methods.
745 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
746 account the changes to gdcmHeader.h).
747 * src/gdcmDocument.h:
748 - gdcmFile is now a friend class (in order to take into account the
749 changes to gdcmHeader.h).
750 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
751 (see changes to gdcmHeader.h).
752 - Accessors (reading on the form GetEntry*) are now public.
753 - Clean up of undefined or unused methods.
754 * src/gdcmDocument.cxx:
755 - adaptation to changes to gdcmDocument.h
756 - ::OpenFile now writes a verbose message when file cannot be opened.
757 - some std::string properly set to VRKey
758 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
759 references to gdcmDocument.
760 * Test/TestFindTags.cxx: changed accordingly to above changes.
761 * gdcmPython/testSuite.py: adapted to renaming of acr files in
762 cvs repository gdcmData.
764 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
765 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
766 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
767 conflicts with gdcmValEntry::voidArea.
768 * src/gdcmValEntry.cxx: unmatching comment wiped out.
769 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
770 Value representation between StringRepresentable and BinaryRepresentable.
771 * src/gdcmDocument.cxx:
772 - method ParseDES: proper indentation restored and usage of
773 gdcmVR::IsVROfGdcmStringRepresentable wired in.
774 - method LoadDocEntry: the fingerprint left in the SetValue() of
775 unloaded entries (length > MaxSizeLoadEntry) had curiously been
776 removed. Reverting to previous code segment with the proper
777 dynamic_cast< gdcmValEntry* >.
778 Note: this was (partially) breaking the python test suite
779 (gdcmPython/testSuite.py) that made usage of the above
780 fingerprint to check presence of "Pixel Data".
781 * src/gdcmDocEntry.h: coding style.
782 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
783 now taken into account.
784 * gdcmPython/gdcm.i: adaptation to the new internal representation
785 of gdcm (exit gdcmParser, hello gdcmDocument).
786 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
788 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
789 anymore, but instead prints the loaded Python dictionary.
790 * .... alas, the python testSuite is still broken.
792 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
793 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
795 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
796 * src/gdcmUtil.h : export methods
798 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
799 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
801 * Initial addition of automatic python testing
802 * Initial addition of automatic image comparison
804 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
805 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
806 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
808 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
809 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
810 * Test/ShowDicom.cxx : bug fix for msvc compilation
811 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
813 2004-05-04 Jean-Pierre Roux
814 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
815 new concepts (and new classes) :
816 a 'gdcmDocument' is composed of a set of Doc Entries, that are
817 - elementary gdcmDocEntries (former gdcmHeaderEntries)
818 - Sequence Doc Entries (gdcmSeqEntries)
819 a Sequence is composed of Items.
820 Each item is a set of Doc Entries (this is recursive)
821 The non uniqueness of the 'Dicom tag' is due to this recursivity
822 (never taken into account)
823 Our unability to add a new 'entry' in the header
824 at the proper location (neither in the H-Table (map or multimap),
825 nor in the Chained List is also due to this recursivity.
826 Don't try, right now, to use/modify/compile these new sources :
828 We just commit all the stuff, 'as is', in order not to loose it.
830 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
831 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
833 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
834 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
835 file prefix (SetFilePrefix)
837 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
838 * Add a new test: ShowDicom, for now this is just the c++ version of
839 checkRead.sh, later it will be able to compare the image read against a
841 * Replace the DEBUG on the stack with a global entry in cmake interface:
842 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
844 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
845 * Add an example subdir, with a real example on how to read + write a
848 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
849 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
850 * Doc/CMakeLists.txt: the main page is now properly differentiated
851 between the developper and user version.
852 * Doc/doxygen.config.in: dropped search related obsolete flags
853 * src/gdcmParser.h, gdcmHeader.h: doxygenation
855 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
856 * DEVELOPPER: added some helpfull comments for compile/test/install
859 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
860 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
861 src directory, now generated in the build dir.
862 2. Tests as mentionned smarter
864 4. Add a new method in gdcmDict that return the PubDict by name
865 this is interesting for 3rd party lib like ITK,
866 where we could set the institution name / patient name...
868 * ENH: 1. Now the test suite is working for real
869 2. All binaries are now output in the gdcm-bin directory
870 (this was not true before)
872 2004-04-28 Jean-Pierre Roux
873 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
874 SeQuence indented printing of Dicom Header.
875 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
876 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
877 Computation of SQDepthLevel is now part of gdcmHeader constructor
878 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
879 tree-like structure of a Dicom Header.
880 * FIX Test code cleaning
882 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
883 * ENH: Adding automatic testing
884 1. Need a DartConfig.cmake to submit to public
885 2. Add a test driver gdcmTest.cxx
886 3. gdcmTestMain, an helper for the main test driver gdcmTest
887 4. Files in Test don't have a main anymore, this becomes interesting
888 when we add more and more tests, thus dsw don't have to load
890 * ENH: Adding a GDCM_DATA_ROOT for testing
891 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
892 one file instead of seven + some small cleanup
894 2004-04-22 Jean-Pierre Roux
895 * ENH Minor changes to the Print() methods.
896 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
897 Header printing. Example given with :
898 > PrintHeader fileName 2 new
899 (SQ based tree-like structure still to be done for the Header ...)
901 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
902 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
903 1. I have added some unsigned where needed
904 2. Some function parameter not used -> (void)
905 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
906 4. g++ don't like character '\' in comment
907 5. #define jpeg_create_decompress jCreaDecompress
908 this really need to be fixed
909 6. virtualize destructor of gdcmObject ... leakage
910 7. sscanf(g->first.c_str(),"%x",&gr_bid);
911 this also really need to be fixed
912 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
913 remove compression file
914 (as we only do decompression, right ?)
915 * ENH: Change malloc/calloc/free with c++ equivalent
917 2004-04-21 Jean-Pierre Roux
918 * FIX gdcmHeaderHelper::GetXSpacing
919 when a single value is found (bug ?), xpacing is now
920 defaulted to yspacing
922 2004-04-19 Jean-Pierre Roux
923 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
924 * ENH add parameters :
925 bool exception_on_error = false,
926 bool enable_sequences = false,
927 bool ignore_shadow = false
928 to the gdcmFile constructors to be full gdcmParser compliant
929 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
930 to allow reading of PAPYRUS 3.0 files
932 2004-04-06 Jean-Pierre Roux
933 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
935 2004-04-02 Jean-Pierre Roux
936 * ADD : Test/checksequence.sh, for a general recap on SQ pb
937 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
938 for Philips spurious Tag fffe|0000 while rewritting Dicom files
940 2004-03-30 Jean-Pierre Roux
941 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
942 for ACR file, written out as DICOM files (hope so...)
944 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
945 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
946 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
947 moved to base class gdcmParser and only the specialisation is kept
949 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
950 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
951 already does the job.
952 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
953 (to be consistent with gdcmParser::WriteEntries).
955 2004-03-30 Benoit Regrain
956 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
957 upate of the object's instance. It's passed to 2 in the unfavorable
958 case : one in the ExecuteInformation, one in the ExecuteData
960 2004-03-29 Jean-Pierre Roux
961 * ENH : Check on file type to be written moved
962 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
963 * FIX : gdcmObject::ResetBoundaries now stops properly
964 when end-of-list is reached
965 : gdcmVersion modified (as Benoit Regrain asked)
967 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
968 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
969 * src/gdcmUtil.cxx: added forgotten iostream include.
970 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
971 equivalent to ExplicitVR in existing code).
973 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
974 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
975 now contains all the gdcmGlobal related code.
976 * minor coding style and doxygenation changes.
978 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
979 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
980 now contains all the Debug related code.
981 * minor clean-up of includes in src/*.cxx
982 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
983 CreateCleanString) removed.
984 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
985 * Doc/DoxyMainPageUser.txt added.
986 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
987 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
990 2004-03-24 Jean-Pierre Roux
991 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
993 2004-03-23 Jean-Pierre Roux
994 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
995 big endian made volumes
996 * ENH Now gdcmParser constructor and destructor are protected to forbid
997 end user to instanciate class gdcmParser
998 (only gdcmHeader and gdcmDicomDir are meaningfull)
1000 2004-03-22 Benoit Regrain
1001 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1002 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1003 gdcmSerie to gdcmDicomDirSerie
1005 2004-03-19 Jean-Pierre Roux
1006 * ENH Now the tree-like structure describing a DICOMDIR comming from
1007 an already existing DICOMDIR file is consistent with
1008 the home-made tree-like structure build ex-nihilo
1009 or build from the files held (recursively) in a Directory
1010 functions gdcmDicomDir::CheckBoundaries()
1011 gdcmObject::SetBoundaries() added
1013 2004-03-17 Jean-Pierre Roux
1014 * REM (Eric Boix bug) : removal of meaningless
1015 gdcmDicomDirImage::NewImage function.
1016 * FIX now file names and directory name are written properly in the
1018 * FIX now gdcmDicomDir constructor may be call without any trick
1021 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1022 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1023 of gdcmDicomDirImage::NewImage as empty function.
1025 2004-02-28 Jean-Pierre Roux
1026 * ENH add gdcmDicomDir:NewPatient
1027 add gdcmDicomDirPatient:NewStudy
1028 add gdcmDicomDirStudy:NewSerie
1029 add gdcmDicomDirSerie:NewImage
1030 to allow making gdcDicomDir object.
1031 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1032 (as opposite to the gdcmHeader chained list)
1034 2004-02-11 Benoit Regrain
1035 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1036 when using from python
1038 2004-02-10 Benoit Regrain
1039 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1040 * FIX : in gdcmDicomDir when the directory is empty
1041 * ENH : add callback and methods to get the progression of dicomDir
1044 2004-02-06 Jean-Pierre Roux
1045 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1046 - GDCM_META added to gdcmDicomDirType
1047 - class gdcmMeta created
1048 * ENH : - A brief summary is now displayed at the beginning of
1049 'testDicomDir' to help disaster magnitude estimation
1050 * REM : Now useless Test/explDICOMDIR.cxx
1052 2004-02-05 Benoit Regrain
1053 * ENH : add methods in gdcmObject to get the hash table or the list of
1055 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1056 * FIX : wrapping python for TagHeaderEntryHT
1058 2004-02-04 Benoit Regrain
1059 * FIX : even length for some strings when writting the dicom dir
1060 * FIX : sort the images in the dicom dir
1061 * FIX : Bug fix for python use of dicom dir
1062 * ADD : a python demo
1064 2004-02-04 Jean-Pierre Roux
1065 * FIX : Final solution (?) for icone embedded images
1066 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1067 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1068 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1069 gdcmData/gdcm-MR-SIEMENS-16.acr1
1070 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1071 to make full checking easier
1073 2004-02-04 Benoit Regrain
1074 * FIX : WriteEntries : coding style & logic in parameters
1075 * FIX : Set the elements to create the DicomDir in a dictionary file
1077 2004-02-03 Benoit Regrain
1078 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1079 * gdcmDicomDir : add the load of directory
1080 * Bug fix and print add-on
1082 2004-02-03 Jean-Pierre Roux
1083 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1084 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1085 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1086 * FIX gdcmParser.cxx : 'group length' elements are now considered
1087 as integers, even for shadow groups, when file is Implicit VR
1089 2004-02-02 Jean-Pierre Roux
1090 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1092 of the last synonym :-(
1093 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1095 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1096 * FIX taking into account the possible 7fe0,0010 multiplicity
1097 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1098 to allow removal of references to 7fe0,0010, to deal with
1099 ACR-NEMA images, when 0028,0200 is meaningfull
1101 2004-01-31 Jean-Pierre Roux
1102 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1103 no longer writes 'Un' on disk
1104 * FIX SQ elements with actual length are now dealt with corectly
1105 * FIX gdcmFile::WriteBase make the difference, for color images, between
1106 the length (for Palette expanded images)
1107 and Raw Length (non expanded image + Palette)
1108 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1109 (that broke Write). Replaced by UL.
1110 Aware user will reload the field if he
1111 thinks it's necesssary
1113 2004-01-30 Jean-Pierre Roux
1114 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1115 when 'dirty Acr' is found, to be compliant with the new
1116 IsReadable() methods.
1118 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1119 (no DOUBLE images in kosher DICOM,
1120 but so usefull for people that miss them ;-)
1122 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1123 DICOMDIR related utilities (not checked as Windoze compliant)
1125 2004-01-28 Jean-Pierre Roux
1126 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1128 2004-01-27 Jean-Pierre Roux
1129 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1130 to allow skipping the shadow elements, to save memory space.
1131 The TRUE value for this param has to be used
1132 with a FALSE value for the 'enable_sequence' param.
1133 ('public elements' may be embedded in 'shadow Sequences')
1134 * gdcmHeader methods now deal with 'embedded icones images' in the header
1135 (even when an 'icone image sequence' is announced by the
1136 element (0x0088,0x0200), but there is NO icone at all ...
1138 * gdcmHeader sometimes Image Location value doesn't follow
1139 the supposed processor endianity (see gdcmData/cr172241.dcm).
1142 * gdcmHeader add the method
1143 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1144 to get *all* the Header Entries with the same tag.
1145 GetHeaderEntrySameName is probabely *useless*
1146 (no meaning : Name is *not* an identifier within the Dictionnary)
1148 2004-01-26 Benoit Regrain
1149 * Bug fix in the print of hexadecimal representations. Remove long fields
1150 in the print and add a third level of print to print them
1152 2004-01-23 Benoit Regrain
1153 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1154 * Bug fix on test suite after remove the strip made on not string fields
1155 * Split the IsReadable method between gdcmParser which test that the file
1156 is dicom and gdcmHeader which test that it's an image file
1158 2004-01-22 Benoit Regrain
1159 * DicomDir : clean code, add methods, set variables in protected or private
1160 * gdcmUtil : bug fix for the clean string method
1162 2004-01-19 Benoit Regrain
1163 * Add the use of shadow dictionaries
1164 * bug fix and coding style
1166 2004-01-19 Benoit Regrain
1167 * src/gdcmFile.cxx : bug fix concerning the close of file
1168 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1169 * Add the update of header entries using the shadow library
1171 2004-01-19 Benoit Regrain
1172 * removal of file gdcmHeader2.cxx
1173 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1174 inheriting from gdcmParser. This split is to prepare the integration
1175 of dicom dir parsing
1176 * bug fix under python
1178 2004-01-16 Jean-Pierre Roux
1179 * REM removal of class gdcmHeaderEntrySet
1180 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1181 * ADD add file gdcmHeader2.cxx
1182 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1184 2004-01-15 Benoit Regrain
1185 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1186 entries created while parsing the header. Thus, they will be destroyed
1187 when the gdcmDictSet will be destroyed
1188 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1191 2004-01-15 Benoit Regrain
1192 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1193 made a fatal error because of the memory release at the end of program.
1194 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1195 some memory and vtk seems to have some problems with that.
1196 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1198 2004-01-14 Benoit Regrain
1199 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1200 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1201 * src/*.[h|cxx] : make changes due to class name changes
1202 * gdcmPython/demo/*.py : bug fix due to method names
1204 2004-01-13 Benoit Regrain
1205 * src/*.[h|cxx] : coding style
1206 * vtk/*.[h|cxx] : coding style
1208 2004-01-13 Benoit Regrain
1209 * gdcmPython/testSuite.py : test the readable flag of file for tests
1210 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1211 It's lied to the stl compilation by MSVC (windows, always windows...)
1212 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1214 2004-01-12 Benoit Regrain
1215 * src/*.h : add comments
1216 * src/gdcmDictSet.h : set the method BuildDictPath in public
1217 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1218 directly setted in the source code
1219 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1222 2004-01-09 Benoit Regrain
1223 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1224 * setup.py : use a reference to gdcmVERSION
1226 2004-01-07 Benoit Regrain
1227 * Modification to compile with the distutils.
1230 2003-12-10 Benoit Regrain
1231 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1232 can use a gdcmHeaderHelper to load datas
1233 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1234 made in the source code
1236 2003-12-10 Benoit Regrain
1237 * Update Windows projects and .cvsignore files
1239 2003-11-12 Jean-Pierre Roux
1240 * ENH gdcmHeader constructor has one more parameter (default value : false)
1241 that allows the user to 'go inside' the SeQuences only
1243 gdcmElValSet:Print takes it into account
1245 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1246 * ENH: Update gdcmPython/CMakeLists
1247 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1248 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1250 2003-11-10 Jean-Pierre Roux
1251 * FIX : gdcmHeader::LoadElements is now based
1252 on the ListTag listElem member,
1253 not longer on the TagElValueHT tagHt member
1254 * ENH : PrintPubElVal shows (temporarily) both results,
1255 with the tagHt member and the listElem member.
1256 (it's easier to 'see' the problems when using Printheader)
1258 * FIX : old private member LgrElem is now splitted into
1259 ReadLength : Length actually found on disk (updated only
1260 if bug fixing is necessary), for internal
1262 UsableLength : Updated by FixFoundLength, to fix a bug
1263 or to allow Parser going on.
1264 Will allow to re-write a kosher header when a SeQuence
1265 with a length (not 0000) is found
1266 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1267 because gdcmElValSet::Add does not update ListElem
1270 2003-11-07 Jean-Pierre Roux
1271 * FIX misstyping in Transfert Syntax name table
1272 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1273 when they have an actual length (not 0000 nor FFFFF)
1274 (Nobody should care of it, but DICOMDIR explorers)
1276 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1277 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1279 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1280 * ENH: vtkGdcmReader now supports LUT !
1281 (vtkgdcmViewer for now is not able to use them though)
1283 2003-11-05 Jean-Pierre Roux
1284 * in testSuite.py : new files names for checking the package
1285 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1286 that returns the pixel area size to the *aware* (vtk) user
1287 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1289 2003-11-05 Benoit Regrain
1290 * in testSuite.py : Modify the rules for checking the paths
1291 : Explicit error messages
1292 * in __init__.py : Related modif
1294 2003-11-03 Jean-Pierre Roux
1295 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1296 to be used by aware (vtk) users that want to manage
1297 LUT (and no to turn the PALETTE image into an RGB pixels one)
1298 * GetPixelType now returns 8U for 24 Bits images
1299 (vtkGdcmReader compliant)
1301 2003-10-31 Jean-Pierre Roux
1302 * Removal of *all* gdcmData images and add them again
1303 in order to loose the 'history' of un-anonymised images
1305 2003-10-31 Jean-Pierre Roux
1306 * RMV : removal of useless jBitsInJsample.h
1307 for both 8 and 12 Bits JPEG Lossy Libraries
1309 2003-10-31 Jean-Pierre Roux
1310 * ENH : Add the functions gdcmFile::GetImageDataRaw
1311 gdcmFile::GetImageDataIntoVectorRaw
1312 that act as GetImageData and GetImageDataIntoVector
1313 except the making of an RGB Plane from Gray Plane + LUT
1314 Intended to aware (vtk) users who know how to manage
1317 GetLUTRGBA return a R,G,B,A LUT if any
1318 lgrTotaleRaw gives the 'Raw' length
1319 GetImageDataRaw returns the gray Plane
1320 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1321 (They stay Grey, just like with other Dicom viewers :-(
1323 2003-10-30 Jean-Pierre Roux
1324 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1326 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1327 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1328 being coherents dicom files.
1330 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1331 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1333 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1334 * ENH: Two steps is necessary to please VC++ compiler...
1335 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1336 * ENH: Add include dir to medcon lib
1337 * FIX: only one function is being exported for now !
1338 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1340 2003-10-29 Jean-Pierre Roux
1341 * adding gdcmHeader::GetLUTRGBA
1342 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1343 --> Mathieu, the modif u're waiting for is not yet committed
1344 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1346 2003-10-27 Jean-Pierre Roux
1347 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1348 00191113.dcm DermaColorLossLess.dcm
1349 MxTwinLossLess.dcm RadBWLossLess.dcm
1350 * ENH: For version prior to vtkImageViewer2 -r 1.19
1351 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1353 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1354 * Removal of ido stuff in CMakeLists.txt
1356 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1357 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1358 * FIX: remove a call to ->Modified ... see comments
1359 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1361 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1362 * FIX: Problem with path for libvtkgdcmPython
1363 * ENH: Try adding a search script for python site-package
1364 * RMV: Remove some file from medcon lib that are not necessary
1365 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1366 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1367 * FIX: More pragma disable fro VC++,
1368 I don't think I break something as it is also disable in VTK/ITK.
1369 But it fasten debug compilation time.
1371 2003-10-23 Jean-Pierre Roux
1372 * gdcm now deals with 16 Bits Run Length Encoded images
1373 (they are compressed as 2 planes images,
1374 one for the high Bytes, the other for low Bytes)
1376 2003-10-22 Jean-Pierre Roux
1377 * Now CheckRead takes into account :
1378 - the bugged 'Leonardo' Siemens images
1379 - the XA images, sent thru the burning VPRO station
1380 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1383 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1384 * FIX: When copying a Makefile.am to CMakeLists.txt
1385 one should remove the '\'
1387 2003-10-22 Jean-Pierre Roux
1388 * in gdcmData adding a bugged 'Leonardo' Siemens image
1389 (wrong lengths in header)
1390 OK with gdcm, KO with the other viewers :-)
1391 * add a GE dlx XA image, thru the VEPRO burning station
1394 2003-10-21 Jean-Pierre Roux
1395 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1396 for a brutal checking of vtkgdcmViewer compliance
1398 2003-10-21 Jean-Pierre Roux
1399 * add the files for 'xmedcon' Jpeg Lossless library
1400 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1402 2003-10-21 Jean-Pierre Roux
1403 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1405 2003-10-21 Jean-Pierre Roux
1406 * garbage Siemens 'Leonardo' images dealt with
1407 (the patch is easy to remove)
1408 * cosmetic changes to avoid warnings
1410 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1411 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1412 no need to press 'r' now.
1414 2003-10-20 Jean-Pierre Roux
1415 * upgrade of checkRead.sh checkWrite.sh according
1416 to new Jpeg Lossless decompressor
1417 * add US.3405.1.dcm, a genuine RGB medical file ...
1418 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1419 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1421 2003-10-15 Jean-Pierre Roux
1422 * general anonymisation in gdcmData
1423 * adding the 'color files' from
1424 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1425 * adding some well knowed bugged-header images
1426 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1427 waiting for their inclusion in Python testsuite
1429 2003-10-15 Jean-Pierre Roux
1430 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1431 no longer seg faults when file is not found
1433 2003-10-14 Jean-Pierre Roux
1434 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1437 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1438 * TODO: *.in file to genereate a UseGDCM later
1440 2003-10-14 Jean-Pierre Roux
1441 * Some supposed-to-be Dicom Images have no preamble.
1442 OpenFile takes it into account
1443 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1444 * Missing elements added in dicomV3.dic
1445 (just to be affraid : have a look at
1446 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1447 and do it again next year ;->
1449 2003-10-13 Jean-Pierre Roux
1450 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1451 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1452 But there are NOT. It's fixed !
1454 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1455 * FIX: "jpeglib.h" was not found on VC++
1456 * FIX: vtkgdcm was not being installed
1458 2003-10-10 Jean-Pierre Roux
1459 * ENH : OpenFile closes the file if it *really* doesn't look like
1460 an ACR-NEMA / DICOM one.
1461 * FIX : testWrite no longer writes an empty file if the source file
1462 is not gdcm Readable
1463 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1466 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1467 * FIX: CMake generate now documentation
1468 * ENH: out of source doc build !
1469 * ENH: Generate both user and dev documentation
1470 * ENH: Should work on windows too
1471 * ENH: Only one doxygen config.in file is needed
1472 * FIX: make install should be ok now on ùnix plateform
1473 * FIX: PATH to dictionary was wrong (missing /)
1474 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1476 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1477 * vtkGdcmReader is now able to read rgb dicom file.
1478 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1479 * added a gdcmViewer to vtk test, use mouse to control
1480 window level & window width
1482 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1483 * CMake-ification of gdcm, we have now two build system
1484 * FIX: on cygwin Wsock32 doesn't exist
1485 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1487 2003-10-06 Emanuel Ollart
1488 * FIX : compilation process wad broken.
1489 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1491 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1492 * change gdcmViewer -> vtkgdcmViewer
1493 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1495 2003-10-06 Jean-Pierre Roux
1496 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1497 ( e.g : well known GE images with a wrong elem length,
1498 : Philips MRI Images with a wrong Huffman table)
1499 * still to be done : allow the reading of bugged LEONARDO Siemens images
1501 2003-10-03 Jean-Pierre Roux
1502 * Odd length strings are padded with '\0' (not with spaces,
1503 to remain compliant with already defined strings,
1504 like Transfert Syntax UID and others)
1506 2003-10-03 Jean-Pierre Roux
1507 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1508 to allow displaying RGB images (not only by affim ;-)
1510 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1511 * vtkGdcmReader is now able to read rgb dicom file.
1512 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1514 2003-10-03 Jean-Pierre Roux
1515 * A few nasty patches to allow the reading of a lot of nasty images
1516 ( e.g : well known GE images with a wrong elem length,
1517 : Philips MRI Images with a wrong Huffman table)
1518 * still to be done : allow the reading of bugged LEONARDO Siemens images
1520 2003-10-03 Jean-Pierre Roux
1521 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1523 2003-10-03 Jean-Pierre Roux
1524 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1525 to allow displaying RGB images (not only by affim ;-)
1527 2003-10-03 Jean-Pierre Roux
1528 * gdcmFile::GetImageDataIntoVector now
1529 - deals with MultiFrames MultiFragments Run Length Encoded files
1530 - deals with YcBcR (YBR_FULL) files
1531 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1532 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1534 (no sample found :-(
1536 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1537 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1538 Two reasons: - clear things
1539 - third parties acces gdcm through header files, so won't
1540 suffer anymore VC++ complains
1542 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1543 * add argv[1] in testvtkGdcmReader.cxx
1546 2003-09-24 Jean-Pierre Roux
1547 * The lines are now eigthy characters long.for
1548 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1550 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1551 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1552 char* to std::string. Thus, the use of strdup becomes useless. (see
1553 previous commis of Malaterre)
1554 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1555 before the last Malaterre's commit.
1557 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1558 * This commit should fix the Debug building under VC++, the problem
1559 was mainly a mixture of debug and release lib being loaded at startup.
1560 * I also remove a depency to a specific C function: strdup. Because I had
1561 to force the link to msvcrtd (whereas strdup is in libc).
1563 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1564 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1565 located in the gdcmCommon.h file. All use of reference of tha has been
1566 changed to now use the variable GDCM_UNFOUND.
1568 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1570 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1571 Dicom dictionary. The test suite can now be run again. Note:
1572 I'm note very happy with the " (RET)" changes. I believe this
1573 RETAINED comment should be dropped when parsing the dictionary.
1574 - PACKAGER corrected
1576 - AUTHORS updated and now in alphabetical order
1577 * Makefile.am now exports gdcm.dsw for Windoze users.
1579 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1580 * cygwin complains about missing std:: in subdir Test/
1582 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1583 * remove some methods that are now in gdcmHeaderHelper
1585 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1586 * vtkGdcmReader set spacing and origin correctly
1588 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1589 * Fix a few delete/delete[] mismatch
1591 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1592 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1593 interpretation to data given by gdcmHeader. For instance there are
1594 heuristics to get informations (look at different places).
1595 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1596 sorting DICOM images based on different strategies.
1597 * modified Makefiles accordingly.
1599 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1600 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1601 when building in debug mode
1602 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1603 src/win32/gdcmdll.dsp
1604 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1606 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1607 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1610 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1611 * src/win32/libgdcmjpeg12.dsp was not dos format
1612 * src/win32/libgdcmjpeg12.dsp :
1613 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1614 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1616 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1617 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1619 * src/gdcmFile.cxx : bug fix in affectation type
1620 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1621 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1622 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1623 symbols... future problem ?
1625 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1626 * src/win32/libgdcmijpeg12.dsp was missing
1627 * modified gdcm.dsw accordingly
1629 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1630 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1632 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1633 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1634 commit of JPR (before his hollidays to facilitate our work).
1635 * setup.py : bug fix in code. Modifications made while the last commit
1636 of JPR. The code hasn't been tested before the commit... it's so
1637 useless to make that (for best programmer that is JPR) !!!
1639 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1640 * tagged the current version as Version0_3 (i.e. version 0.3)
1642 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1643 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1644 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1645 * *.dsp : modifications to use new libgdcmijpeg8 library
1646 * setup.py : bug fix on VTKPATH variable
1647 * PACKAGER : adding all concerning windows
1649 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1650 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1652 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1653 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1654 test suite reported error.
1655 * PACKAGER file added (describes what a packager must do when
1656 packaging a new release).
1657 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1658 * configure.in: upgraded version number to 0.3.0
1659 * fixing build of rpm (through rpm -ta):
1660 - Doc/Makefile.am exports proper doxygen files
1661 - src/jpeg/libijg8/Makefile.am exports the include files.
1663 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1664 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1665 * src/gdcmHeader.h : formatting code
1667 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1668 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1669 We were obtaining error message from vtk. Now, creation of file list
1670 is made in an internal list to prevent this problem.
1671 Bug fix when output is empty.
1672 Bug fix in update of progress value. Previous commit for this was a bad
1674 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1676 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1677 * src/gdcmHeader.h : added method to get the file name
1678 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1679 files. Added method to remove all files on the input
1680 Added FIXME comment concerning the bad parsing of header made by
1681 ExecuteInformation method (in ExecuteData method)
1683 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1684 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1685 when using make instal.
1686 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1687 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1689 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1690 * setup.py : adding include dir of jpeg lib to compile all sources
1691 * */Win32/*.dsp : JPR fix for windows compilation
1693 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1694 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1696 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1697 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1699 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1700 * setup.py is again effective on un*x (takes into account the
1701 addon of the jpeg library)
1702 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1703 * Doc/Doxy* updated (includes above enhancements)
1704 * INSTALL now points to web documentation
1706 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1707 * src/gdcmHeader.h doesn't make unnecessary reference to
1709 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1711 * src/gdcm*.[cxx|h] :
1712 - to allow compilation with gcc 3.x
1713 -- clean up of STL usage (added explicit usage of std::)
1714 -- small fixes on exceptions.
1715 Note: linking not tested !
1716 - clean of doxygen comments to avoid warnings at documentation
1718 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1719 dependent convertion).
1721 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1722 * Clean up of previous JPR garbage commit (not even commented in the
1724 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1725 - moved all jpeg related files from src to src/jpeg/libijg8, with
1726 addition/modification of Makefile.am and configure.in.
1727 - the testSuite is still brain damage (not guilty).
1729 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1730 * WrapVTK.py : modifications to get correctly vtk source files to
1732 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1733 (FileName -> Filename)
1735 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1736 * vtk/vtkGdcmReader.[cxx/h]:
1737 - UpdateProgress method should now be effective
1738 - removed the limitation on having only images loaded (as opposed
1740 - when building a stack of images/volume, a lesser number of
1741 gdcmHeader and gdcmFile instances should be used (hopefully
1742 accelerating things).
1743 - when building a stack of images/volumes, files which are not
1744 loadable (wrong path-filename, wrong permissions on existing file,
1745 or file not parsable by gdcm) are replaced with a black image
1746 in the stack (for the caller to notice the problem).
1748 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1749 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1751 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1752 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1753 between standard library (std) and vtk library (problems are found
1754 under Windows... thanks Windows !)
1756 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1757 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1759 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1761 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1762 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1764 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1765 * When compiling with distutils (see setup.py) the C++ compiler is
1766 called with different flags than the default ones (with automake).
1767 In order to fix all those warning, I compiled gdcm with the command
1768 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1769 and went for warning fixes:
1770 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1771 up from unused variables.
1772 - vtk/vtkGdcmReader.cxx: potential bug fix.
1773 * src/gdcmHeader.h: Doxygen warning cleanup
1775 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1776 * gdcmPython/gdcm.i:
1777 - typemaps correction to take into account the systematic replacement
1778 of "using namespace std" with std:: prefix e.g. std::list,
1779 std::string... (cf changes of 2003-05-21).
1780 - gdcmGlob global variable of type gdcmGlobal (defined in
1781 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1782 exported to Python a as cvar.
1783 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1784 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1785 gdcmDictSet.GetPubDictTagNames() and
1786 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1787 C++ static methods).
1788 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1789 with the above changes.
1791 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1792 * setup.py, manifest.in : bug fix under linux
1794 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1795 * Modification of setup.py to compile vtk part too. Then, we have 2
1796 wrappers which must work with same distutils. For that, we have a
1797 generic distutils in distusiltsWrapping.py ; with :
1798 - build_extWrap class to wrap generically all extensions,
1799 - ExtensionWrap base class for all wrapping extension that contains
1801 - Wrapper interface which wrap sources
1802 + In WrapSwig.py we have extension and wrapper for Swig
1803 + In WrapVTK.py we have extension and wrapper for VTK
1804 * MANIFEST.in : modifications to consider vtk directory and new python
1805 files for compilation
1807 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1808 * Added python wrappers of vtkGdcmReader vtk class (see the
1809 source in vtk/vtkGdcmReader.cxx) :
1810 - vtk/Makefile.am now builds a library
1811 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1812 python library (as opposed to _gdcm.so wich are the python
1813 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1814 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1816 - configure.in has an additional flag --enable-vtk that needs
1817 to be set to enable compilation of vtk related code, that is:
1818 + vtk/vtkGdcmReader.so and
1819 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1820 + gdcmPython/vtkgdcmPython.so (see above)
1821 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1822 be read when compressed or when HighBit + 1 != BitsStored),
1823 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1824 the usage of the python wrapper of vtkGdcmReader vtk class.
1825 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1826 * src/*.[h] all occurences of stl classes are now prefixed with
1827 std::, and all occurences of "using namespace std;" where removed.
1828 This is to avoid pollution of global namespace in included files.
1829 Apparently vtk does not avoid this pitfall: when using both
1830 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1831 collision of various stl members (principally cout...).
1832 * gdcmPython/testSuite.py now cleanly removes temprory generated
1834 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1835 comply with above changes)
1837 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1838 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1839 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1840 vtk data structure (an image Flip was required).
1841 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1842 * cosmetic changes in documentation.
1844 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1845 * src/gdcmHeader.cxx: the constructor no longer exits when an
1846 unexisting file is given as argument.
1847 * The subdirectory Data (containing all the images used for the
1848 test suite) is not part of this repository anymore. A new module
1849 containing those images is now available at
1850 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1851 with the name gdcmData.
1852 All the python scripts (including the package initialisation file
1853 gdcmPython/__init__.py) were adapated to take this change into
1854 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1856 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1857 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1858 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1859 demo of the usage of this class.
1860 Compilation of this vtk part is only done when using the --enable-vtk
1861 at configure (or autogen.sh) stage.
1863 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1864 * More memory link related corrections and documentation fixes.
1866 - maximum info is obtained with a command of the form:
1867 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1868 --show-reachable=yes PrintHeader
1869 - the remaining reachable blocks seem to come from the STL
1870 allocation scheme through the usage of map and list. It looks
1871 like this memory cannot be freed but it is not a memory leak
1872 (in fact further invocation to the STL would recollect the
1873 unused memory allthough it cannot explicitely be freed).
1874 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1875 of displaying an image parsed with gdcm and displayed with VTK.
1876 Note: some images don't seem to work e.g.
1877 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1878 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1879 Allthough this weakens the semantics, it is a ditch attempt to
1880 make gdcm more thread friendly.
1882 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1883 * Memory link hunt (by using valgrind through the command
1884 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1885 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1886 gdcmHeader::_dicom_vr.
1887 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1888 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1890 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1892 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1893 * src/Makefile.am now exports all the necessary include files at
1897 * UpdateGroupLength replaced by new one
1900 * UpdateGroupLength re-written using H-Table
1901 (named UpdateGroupLengthNew untill checks are over)
1903 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1904 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1905 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1907 - gdcmHeader::GetPubElValSet removed.
1908 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1909 UpdateGroupLength, WriteElements, Write.
1910 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1911 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1912 carried the same semantics.
1913 - src/gdcmHeaderIdo.cxx changed accordingly.
1914 - gdcmFile::WriteBase now regroups all the codes from previous
1915 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1916 - enum FileType moved to gdcmCommon.h
1917 * src/gdcmHeader.cxx AddDefault trashed
1918 * gdcmGetXSize added
1919 * getimageDataSize now calls gdcmGetXSize
1920 * Test/*.cxx changed to agree with above changes
1922 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1923 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1924 (to avoid double call by end user).
1925 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1926 by end user, since gdcmHeader::gdcmHeader now handles it.
1928 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1929 * gdcm/Doc many doxygen changes:
1930 - Doxyfile now has two different versions, DoxyfileUsers that generates
1931 the html.users end users oriented documentation and
1932 DoxyfileDeveloppers that generates the html.developper developper
1933 oriented documentation.
1934 - README changed accordingly
1935 - requirement.txt removed (old design info moved to TODO).
1936 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1937 DoxyMainPage.txt, DoxyPython.txt provide more information.
1938 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1939 be updated by simply regenerating the docs with doxygen and copying
1940 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1941 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1942 all the tests in the form "if (<map>.count() >1)" were removed.
1943 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1944 ill-formed documentation sections.
1945 * src/gdcmHeader.cxx: ditto
1947 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1948 * setup.py fixed for un*x (needed macro for stdint.h)
1949 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1950 un*ces with sh-utils test utility.
1951 * gdcmPython/demo/test.py renamed to PrintHeader.py
1952 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1953 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1954 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1955 * src/gdcm*.cxx JPR's bad inclusion fixed.
1957 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1958 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1959 * gdcmPython/demo/test.py changed accordingly.
1961 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1962 * gdcmPython/Makefile.am fixed linking against libstdc++
1963 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1964 * Swig subdir (historical tests of swig version 1.3.17++) removed
1965 * Test/testChangeEntete.cxx some lines commented out in order to make
1967 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1968 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1970 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1971 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1972 hence the user doesn't need this explicit call.
1973 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1974 i.e. LoadElements() call removed.
1975 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1976 - src/Makefile.am declares the proper flag for g++.
1977 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1978 for adding user defined new tags.
1979 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1980 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1981 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1983 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1984 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1985 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1986 src/Makefile.am : the project should properly compile and install
1987 with the autotools, included the python wrappers part.
1988 * gdcm.spec.in : added a spec file for RPM packaging.
1990 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1991 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1993 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1994 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1995 to exported to the environement (see gdcmPython/testSuite.py
1997 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1998 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1999 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2000 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2001 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2003 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2004 * gdcmPython/__init__.py doesn't crash anymore when running in
2005 in InstallMode or PreInstallMode but with an environement given
2006 value of GDCM_DICT_PATH.
2007 * src/gdcmDictSet.[cxx/h] coding style.
2009 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2010 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2011 * src/gdcm.h general comments moved to TODO, and README
2012 * src/gdcm.h should now be seen as a user commodity (including it
2013 should suffice to fully use gdcm). It is nowhere including within
2014 any of the kernel files src/*.cxx and src/*.h.
2016 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2017 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2018 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2020 * src/gdcm*.cxx only include their corresponding include file
2021 (as opposed to gdcm.h)
2022 * gdcmPython/gdcm.i changed accordingly
2023 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2024 the autogen.sh generated "make snapshot" command to work.
2025 * autogen.sh removed history related references to crea package.
2027 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2028 * distutilsSwigCPlusPlus.py work around some swig portability
2031 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2032 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2033 was done in a last ditch attempt to get setup.py _really_
2034 operationnal. The python/gdcmPython layaout add the advantage
2035 of hidding away the python related distutils specific files
2036 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2037 Alas, the src directory was out of scope (i.e. it's relative
2038 position to setup.py was ../src) which made things impossible to
2039 handle (see previous version of python/setup.py). Crossing fingers...
2041 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2042 * python/setup.py now works on Un*x. (harder than I thougth)
2043 * python/distutilsSwigCPlusPlus.py can now have include files
2044 among the list of sources.
2046 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2047 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2048 * modifications in MSVC projects
2050 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2051 * As stated by the first lines of Test/ExceptionAndPython/README, it
2052 looks like we can move back to original usage of exception within
2053 src/gdcm* and hence remove the errno stuff that was introduced
2054 as a quick and dirty fixture of this problem (added to the TODO).
2055 * Doc/Doxyfile configuration file for Doxygen and corresponding
2056 README file for usage added.
2057 * Test/testWrite.cxx added. This new test comes from a split of
2058 test.cxx that is now reverted to its original purpous i.e.
2059 testing the proper parsing of a Dicom related file.
2060 testWrite.cxx concentrates on testing the IO part of gdcm.
2061 * Test/bug1.cxx (containing a bug on WIn32) added.
2062 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2063 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2064 whose purpose is to publish the content of the TagNames of the
2065 Dicom public dictionnary were not accessible without an
2066 instance of class gdcmHeader.
2067 - those methods are now static methods of gdcmDictSet and hence
2068 require no instances at all to be invocated.
2069 - within gdcmDictSet this change required to change some method
2070 to class methods (i.e. are now static) among which SetDictPath
2071 (renamed to BuildDictPath) and LoadDefaultPubDict.
2072 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2073 the above changes by calling the new method classes of gdcmDictSet.
2074 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2075 the above to be effective.
2076 * python/gdcmPython: in order to wrap properly the above changes
2077 for Python, swig version now needs to be > 1.3.17.
2078 * python/gdcmPython/Makefile fixed to adapt itself to new
2079 configure/make shema introduced by Johan Montagnat (thanks for the
2080 contribution). Alas this Makefile cannot be turned into a proper
2081 Makefile.am without some heavy changes in the configure.in
2082 (for python dectection).
2083 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2084 now avoids publishing the empty entries.
2086 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2087 * python/setup.py : bug fix concerning install under windows
2088 ExtraPath reused :-P
2089 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2091 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2092 * Dicts/dicomV3.dic : remove double spaces !!!
2093 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2094 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2097 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2098 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2099 method. Doxygenation.
2100 * src/gdcm.h clean up of JPR spurious comments.
2102 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2103 * python/distutilsSwigCPlusPlus.py now properly collects the
2104 shadow classes generated by "swig -c++" (gdcm.py in our case)
2105 when using "python setup.py install".
2106 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2107 reexports the working classes.
2108 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2109 by the classical C errno scheme. This is to prevent an obscure
2110 behavior of the python wrappers when importing wxPython.wx prior
2111 to gdcmPython (which ended up in an abort call). An illustration
2112 of this oddity can be found in the Test/ExceptionAndPython
2113 subdir (see the README file). This problem probably due to
2114 an combination of g++ and dynamic loading.
2115 * added Test/ExceptionAndPython (see above)
2117 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2118 * Changed the layout of the python part to avoid bloating main
2119 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2120 i.e. the distutils arsenal. All the python related stuff is
2121 again in a python subdir, but the package itself is now in
2123 * setup.py was cleaned up:
2124 - pythonIncludePath removed
2125 - python setup.py bdist target is now functional.
2126 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2127 collision with other packages). gdcmPython/demo/*.py changed
2130 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2131 * python subdir moved to gdcmPython (preparation of distutils packaging).
2132 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2133 distutils installer is operational.
2134 * - gdcmPython/__init__.py now properly loads the swig generated
2135 shadow classes (from gdcm.py).
2136 - gdcmPython/demo/*.py changed to import the package gdcmPython
2137 instead of gdcmPython/demo/load.py.
2138 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2140 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2141 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2142 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2143 entries within the associated public Dicom dictionary resp. the same
2144 information but sorted by the fourth field (PAT, IMG, DIR) of the
2146 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2147 are now in the "???" group.
2148 - python/gdcm.i changed accordingly,
2149 - python/demo/printGroupedPublicDict.py added, that gives an example
2150 of the above new functionalities in Python.
2152 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2153 * src/gdcm.h, gdcmHeader.cxx:
2154 - historic references to glib's g_malloc and g_free (#defined)
2155 were definitively removed.
2156 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2157 * src/gdcmElValSet.cxx:
2158 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2159 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2160 - GetElValue(string) renamed to GetElValueByName.
2161 - Added GetElementByName(string).
2162 * src/gdcmHeader.cxx: added
2163 - GetPubElValRepByNumber(guint16, guint16)
2164 - GetPubElValRepByName(string)
2165 - GetShaElValRepByNumber(guint16, guint16)
2166 - GetShaElValRepByName(string)
2167 - GetShaElValByNumber(guint16, guint16)
2168 - GetShaElValRepByName(string)
2169 - GetElValRepByNumber(guint16, guint16)
2170 - GetElValRepByName(string)
2171 - GetElValByNumber(guint16, guint16)
2172 - GetElValRepByName(string)
2173 * Doc/requirements.txt added.
2175 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2176 * Test/Makefile building now depends on the one of libgdcm.so
2177 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2178 pixel data) aware which enables finding the address (offset) of
2179 the pixel data of JPEG encoded DICOM files. This leaves only a single
2180 file in the testSuite whose pixel data address (offset) is unknown.
2181 * python/testSuite.py changed accordingly.
2183 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2184 * VC++ has some strong limitations when working with the STL, as stated
2185 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2186 "Also note that some STL containers (map, set, queue, list, deque)
2187 cannot be exported. [...]
2188 Some STL classes contain nested classes. These classes can not
2190 This is caused by a designed limitation that once a template
2191 class is instantiated, it can not be re-instantiated and
2193 Since our usage of map<> is ubiquitous in gdcm, this "designed
2194 limitation" of VC++ is a pitfall.
2195 Hence the Python wrappers of gdcm cannot be incrementally linked
2196 against the c++ dynamic library. The dirty but only workaround is
2197 to forget about incremental link of dynamic libraries and to generate
2198 the Python wrappers library with the inclusions of the underlying C++
2200 The following modifications concern this matter on Win32/VC++:
2201 - wrapping python correct with standalone wrapped dll (don't use separate
2202 dll under windows !!!!)
2203 - python21_d debug mode enabled (ask Frog how to use it :-)
2204 - NO problem with having an STL member of class for example string in C++
2205 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2206 - Python test of dcmlib in Python is ok under windows on a large set
2208 * removed glib references
2209 * typedef's inserted in gdcm.i for correct swig type management
2211 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2212 * python/demo/*.py load.py extracted from test.py. Added explore.py
2213 that only displays required tags and testAll.py that parses all
2214 the files of the testsuite without using unittest.
2215 * python/testSuite.py other additional test on new files added.
2216 * Data/* new test files added accordingly to the testSuite.
2217 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2218 the vr in the file differs from the one of the dictionary.
2220 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2221 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2222 values, but limits itself to values which are below a user specified
2223 size (by default 1024 bytes).
2224 * python/gdcm.i : elements not loaded (because their size is above the
2225 user specified treshold) are exported with their TagKey as key of the
2226 python dictionary. This enables the testsuite to make some checks
2227 on the unloaded elements (since we have their offset and size).
2228 * python/testSuite.py
2229 - now tests for the existence and proper value of the pixel data
2230 - two new examples added.
2231 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2233 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2234 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2235 aware. See the strategy comments in gdcmHeader::FindeLength().
2236 * Test/test.cxx now accepts a filename as first argument.
2237 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2238 * python/testSuite.py changed to integrate test on above files.
2240 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2241 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2242 the vr was also RET.
2243 * python/testSuite.py more tests added.
2245 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2246 * python/testSuite.py unittest test suite added (uses Data)
2247 * Data/* dcm and acr files for the test suite.
2248 * glib dependance removed from un*x version. We now use ISO C99
2249 7.18 Integer types (see stdint.h)
2250 - python/Makefile, src/Makefile src/gdcm.h
2251 * src/ when an explicit vr (like dicom files) suddenly poped an
2252 implicit element we use to mark the underlying DictEntry of the
2253 concerned ElValue with "Implicit". This strategy was damageable
2254 too the public or provite dictionaries, since some of their vr
2255 would be changed. Since Header::FindLength heavily relies on the
2256 detection by Header::FindVR of falsely explicit elements, I
2257 added an extra ImplicitVr member to ElValue (boolean).
2258 The rest of the changes we the necessary adaptations.
2260 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2261 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2263 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2265 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2266 * Adaptation for porting to VC++:
2268 o forced to use std namespace (for string to be known)
2269 o all class use __declspec export style on WIN32
2270 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2271 (in stdlib.h on Win32 but in std:: for gcc)
2272 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2273 variable GDCM_DICT_PATH.
2274 * src/gdcmHeader.cxx verbose comments made discrete.
2276 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2277 * python/gdcm.i: added a typemap that converts a C++ hashing table
2278 to native Python dictionary.
2279 * python/demo/test.py:
2280 - now uses the native dictionary for exploration of gdcmHeader.
2281 - takes an optional filename argument (the file to parse).
2282 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2283 PubElVals hashing table.
2284 * Dicts/dicomV3.dic removed error prone trailing spaces.
2286 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2287 * Python wrapping process moved away from src/Makefile to
2288 newly created python/Makefile (as well as gdcm.i)
2289 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2290 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2291 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2292 from the environement variable GDCM_DICT_PATH (when existing).
2293 * src/gdcmDict::GetTag bug fix.
2295 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2296 * Straightforward temporary fixes for swig to build the python wrappers.
2297 src/Makefile now has a python working entry [by working we mean
2298 that we can import de shadow classes without errors].
2300 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2301 * hashtest.cxx removed (since allready in Test)
2302 * src/gdcmlib.h renamed to src/gdcm.h
2303 * src/dcm.i renamed to src/gdcm.i
2304 * src/Makefile prepared for python wrapping
2306 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2307 * src/gdcmHeader.cxx :
2308 - Parsing of header is now separated from loading of element values
2309 (see gdcmHeader::LoadElements).
2310 - general clean up of hopefully all file access (creation of
2311 ReadInt16 and ReadInt32)
2313 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2314 * src/gdcmHeader.cxx :
2315 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2317 - SetLgrElem renamed to SetLength
2318 - GetLgrElem renamed to GetLength
2319 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2320 * src/gdcmElValSet.cxx fixed both GetElValue methods
2321 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2322 due to IdoDude was cleaned out.
2324 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2325 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2326 concentrates on finding the value representation (when it exists).
2327 RecupLgr now only finds the element value length, and it avoids
2328 returning the unecessary skL (skipped length).
2329 Also, offsetCourant was simply removed (with taille_fich) since
2330 it was redundant with the File position internals (by using
2331 ftell and fseek). This also made skL (see above in RecupLgr) usage
2333 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2334 on the libido specificities which are handled through class
2336 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2339 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2340 * Truckload of changes. Parsing of header is barely functional
2341 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2343 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2344 * src/gdcmHeader.cxx many addons of low level methods
2346 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2347 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2348 and _IdDcmSWAP_LONG.
2350 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2351 * This corresponds to all the changes decided at the meeting of
2352 May 23 2002. Needless to say we are running late...