1 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
4 - gdcmHeader::GetPubElValSet removed.
5 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
6 UpdateGroupLength, WriteElements, Write.
7 * Test/*.cxx changed to agree with above changes
9 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
10 * src/gdcmHeader.h: LoadElements() is not a public method anymore
11 (to avoid double call by end user).
12 * Test/*.cxx LoadElements() doesn't need to be called explicitely
13 by end user, since gdcmHeader::gdcmHeader now handles it.
15 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
16 * gdcm/Doc many doxygen changes:
17 - Doxyfile now has two different versions, DoxyfileUsers that generates
18 the html.users end users oriented documentation and
19 DoxyfileDeveloppers that generates the html.developper developper
20 oriented documentation.
21 - README changed accordingly
22 - requirement.txt removed (old design info moved to TODO).
23 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
24 DoxyMainPage.txt, DoxyPython.txt provide more information.
25 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
26 be updated by simply regenerating the docs with doxygen and copying
27 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
28 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
29 all the tests in the form "if (<map>.count() >1)" were removed.
30 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
31 ill-formed documentation sections.
32 * src/gdcmHeader.cxx: ditto
34 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
35 * setup.py fixed for un*x (needed macro for stdint.h)
36 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
37 un*ces with sh-utils test utility.
38 * gdcmPython/demo/test.py renamed to PrintHeader.py
39 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
40 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
41 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
42 * src/gdcm*.cxx JPR's bad inclusion fixed.
44 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
45 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
46 * gdcmPython/demo/test.py changed accordingly.
48 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
49 * gdcmPython/Makefile.am fixed linking against libstdc++
50 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
51 * Swig subdir (historical tests of swig version 1.3.17++) removed
52 * Test/testChangeEntete.cxx some lines commented out in order to make
54 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
55 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
57 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
58 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
59 hence the user doesn't need this explicit call.
60 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
61 i.e. LoadElements() call removed.
62 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
63 - src/Makefile.am declares the proper flag for g++.
64 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
65 for adding user defined new tags.
66 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
67 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
68 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
70 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
71 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
72 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
73 src/Makefile.am : the project should properly compile and install
74 with the autotools, included the python wrappers part.
75 * gdcm.spec.in : added a spec file for RPM packaging.
77 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
78 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
80 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
81 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
82 to exported to the environement (see gdcmPython/testSuite.py
84 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
85 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
86 ElValue class renamed to gdcmElValue for obvious consistency reasons.
87 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
88 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
90 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
91 * gdcmPython/__init__.py doesn't crash anymore when running in
92 in InstallMode or PreInstallMode but with an environement given
93 value of GDCM_DICT_PATH.
94 * src/gdcmDictSet.[cxx/h] coding style.
96 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
97 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
98 * src/gdcm.h general comments moved to TODO, and README
99 * src/gdcm.h should now be seen as a user commodity (including it
100 should suffice to fully use gdcm). It is nowhere including within
101 any of the kernel files src/*.cxx and src/*.h.
103 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
104 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
105 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
107 * src/gdcm*.cxx only include their corresponding include file
108 (as opposed to gdcm.h)
109 * gdcmPython/gdcm.i changed accordingly
110 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
111 the autogen.sh generated "make snapshot" command to work.
112 * autogen.sh removed history related references to crea package.
114 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
115 * distutilsSwigCPlusPlus.py work around some swig portability
118 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
119 * Eventually, python/gdcmPython was renamed to gdcmPython. This
120 was done in a last ditch attempt to get setup.py _really_
121 operationnal. The python/gdcmPython layaout add the advantage
122 of hidding away the python related distutils specific files
123 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
124 Alas, the src directory was out of scope (i.e. it's relative
125 position to setup.py was ../src) which made things impossible to
126 handle (see previous version of python/setup.py). Crossing fingers...
128 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
129 * python/setup.py now works on Un*x. (harder than I thougth)
130 * python/distutilsSwigCPlusPlus.py can now have include files
131 among the list of sources.
133 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
134 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
135 * modifications in MSVC projects
137 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
138 * As stated by the first lines of Test/ExceptionAndPython/README, it
139 looks like we can move back to original usage of exception within
140 src/gdcm* and hence remove the errno stuff that was introduced
141 as a quick and dirty fixture of this problem (added to the TODO).
142 * Doc/Doxyfile configuration file for Doxygen and corresponding
143 README file for usage added.
144 * Test/testWrite.cxx added. This new test comes from a split of
145 test.cxx that is now reverted to its original purpous i.e.
146 testing the proper parsing of a Dicom related file.
147 testWrite.cxx concentrates on testing the IO part of gdcm.
148 * Test/bug1.cxx (containing a bug on WIn32) added.
149 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
150 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
151 whose purpose is to publish the content of the TagNames of the
152 Dicom public dictionnary were not accessible without an
153 instance of class gdcmHeader.
154 - those methods are now static methods of gdcmDictSet and hence
155 require no instances at all to be invocated.
156 - within gdcmDictSet this change required to change some method
157 to class methods (i.e. are now static) among which SetDictPath
158 (renamed to BuildDictPath) and LoadDefaultPubDict.
159 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
160 the above changes by calling the new method classes of gdcmDictSet.
161 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
162 the above to be effective.
163 * python/gdcmPython: in order to wrap properly the above changes
164 for Python, swig version now needs to be > 1.3.17.
165 * python/gdcmPython/Makefile fixed to adapt itself to new
166 configure/make shema introduced by Johan Montagnat (thanks for the
167 contribution). Alas this Makefile cannot be turned into a proper
168 Makefile.am without some heavy changes in the configure.in
169 (for python dectection).
170 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
171 now avoids publishing the empty entries.
173 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
174 * python/setup.py : bug fix concerning install under windows
176 * gdcm.dsw : bug fix concerning path for libraries for python !!!
178 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
179 * Dicts/dicomV3.dic : remove double spaces !!!
180 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
181 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
184 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
185 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
186 method. Doxygenation.
187 * src/gdcm.h clean up of JPR spurious comments.
189 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
190 * python/distutilsSwigCPlusPlus.py now properly collects the
191 shadow classes generated by "swig -c++" (gdcm.py in our case)
192 when using "python setup.py install".
193 * python/gdcmPython/__init__.py imports gdcm.py and only manually
194 reexports the working classes.
195 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
196 by the classical C errno scheme. This is to prevent an obscure
197 behavior of the python wrappers when importing wxPython.wx prior
198 to gdcmPython (which ended up in an abort call). An illustration
199 of this oddity can be found in the Test/ExceptionAndPython
200 subdir (see the README file). This problem probably due to
201 an combination of g++ and dynamic loading.
202 * added Test/ExceptionAndPython (see above)
204 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
205 * Changed the layout of the python part to avoid bloating main
206 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
207 i.e. the distutils arsenal. All the python related stuff is
208 again in a python subdir, but the package itself is now in
210 * setup.py was cleaned up:
211 - pythonIncludePath removed
212 - python setup.py bdist target is now functional.
213 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
214 collision with other packages). gdcmPython/demo/*.py changed
216 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
217 * python subdir moved to gdcmPython (preparation of distutils packaging).
218 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
219 distutils installer is operational.
220 * - gdcmPython/__init__.py now properly loads the swig generated
221 shadow classes (from gdcm.py).
222 - gdcmPython/demo/*.py changed to import the package gdcmPython
223 instead of gdcmPython/demo/load.py.
224 - gdcmPython/testSuite.py changed to import the package gdcmPython.
227 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
228 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
229 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
230 entries within the associated public Dicom dictionary resp. the same
231 information but sorted by the fourth field (PAT, IMG, DIR) of the
233 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
234 are now in the "???" group.
235 - python/gdcm.i changed accordingly,
236 - python/demo/printGroupedPublicDict.py added, that gives an example
237 of the above new functionalities in Python.
239 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
240 * src/gdcm.h, gdcmHeader.cxx:
241 - historic references to glib's g_malloc and g_free (#defined)
242 were definitively removed.
243 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
244 * src/gdcmElValSet.cxx:
245 - GetElement(guint32, guint32) renamed to GetElementByNumber.
246 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
247 - GetElValue(string) renamed to GetElValueByName.
248 - Added GetElementByName(string).
249 * src/gdcmHeader.cxx: added
250 - GetPubElValRepByNumber(guint16, guint16)
251 - GetPubElValRepByName(string)
252 - GetShaElValRepByNumber(guint16, guint16)
253 - GetShaElValRepByName(string)
254 - GetShaElValByNumber(guint16, guint16)
255 - GetShaElValRepByName(string)
256 - GetElValRepByNumber(guint16, guint16)
257 - GetElValRepByName(string)
258 - GetElValByNumber(guint16, guint16)
259 - GetElValRepByName(string)
260 * Doc/requirements.txt added.
262 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
263 * Test/Makefile building now depends on the one of libgdcm.so
264 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
265 pixel data) aware which enables finding the address (offset) of
266 the pixel data of JPEG encoded DICOM files. This leaves only a single
267 file in the testSuite whose pixel data address (offset) is unknown.
268 * python/testSuite.py changed accordingly.
270 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
271 * VC++ has some strong limitations when working with the STL, as stated
272 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
273 "Also note that some STL containers (map, set, queue, list, deque)
274 cannot be exported. [...]
275 Some STL classes contain nested classes. These classes can not
277 This is caused by a designed limitation that once a template
278 class is instantiated, it can not be re-instantiated and
280 Since our usage of map<> is ubiquitous in gdcm, this "designed
281 limitation" of VC++ is a pitfall.
282 Hence the Python wrappers of gdcm cannot be incrementally linked
283 against the c++ dynamic library. The dirty but only workaround is
284 to forget about incremental link of dynamic libraries and to generate
285 the Python wrappers library with the inclusions of the underlying C++
287 The following modifications concern this matter on Win32/VC++:
288 - wrapping python correct with standalone wrapped dll (don't use separate
289 dll under windows !!!!)
290 - python21_d debug mode enabled (ask Frog how to use it :-)
291 - NO problem with having an STL member of class for example string in C++
292 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
293 - Python test of dcmlib in Python is ok under windows on a large set
295 * removed glib references
296 * typedef's inserted in gdcm.i for correct swig type management
298 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
299 * python/demo/*.py load.py extracted from test.py. Added explore.py
300 that only displays required tags and testAll.py that parses all
301 the files of the testsuite without using unittest.
302 * python/testSuite.py other additional test on new files added.
303 * Data/* new test files added accordingly to the testSuite.
304 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
305 the vr in the file differs from the one of the dictionary.
307 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
308 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
309 values, but limits itself to values which are below a user specified
310 size (by default 1024 bytes).
311 * python/gdcm.i : elements not loaded (because their size is above the
312 user specified treshold) are exported with their TagKey as key of the
313 python dictionary. This enables the testsuite to make some checks
314 on the unloaded elements (since we have their offset and size).
315 * python/testSuite.py
316 - now tests for the existence and proper value of the pixel data
317 - two new examples added.
318 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
320 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
321 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
322 aware. See the strategy comments in gdcmHeader::FindeLength().
323 * Test/test.cxx now accepts a filename as first argument.
324 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
325 * python/testSuite.py changed to integrate test on above files.
327 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
328 * Dicts/dicomV3.dic removed all the trailing (RET) when the
330 * python/testSuite.py more tests added.
332 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
333 * python/testSuite.py unittest test suite added (uses Data)
334 * Data/* dcm and acr files for the test suite.
335 * glib dependance removed from un*x version. We now use ISO C99
336 7.18 Integer types (see stdint.h)
337 - python/Makefile, src/Makefile src/gdcm.h
338 * src/ when an explicit vr (like dicom files) suddenly poped an
339 implicit element we use to mark the underlying DictEntry of the
340 concerned ElValue with "Implicit". This strategy was damageable
341 too the public or provite dictionaries, since some of their vr
342 would be changed. Since Header::FindLength heavily relies on the
343 detection by Header::FindVR of falsely explicit elements, I
344 added an extra ImplicitVr member to ElValue (boolean).
345 The rest of the changes we the necessary adaptations.
347 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
348 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
350 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
352 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
353 * Adaptation for porting to VC++:
355 o forced to use std namespace (for string to be known)
356 o all class use __declspec export style on WIN32
357 - src/gdcmUtil.cxx new Exit method that wraps the exit call
358 (in stdlib.h on Win32 but in std:: for gcc)
359 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
360 variable GDCM_DICT_PATH.
361 * src/gdcmHeader.cxx verbose comments made discrete.
363 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
364 * python/gdcm.i: added a typemap that converts a C++ hashing table
365 to native Python dictionary.
366 * python/demo/test.py:
367 - now uses the native dictionary for exploration of gdcmHeader.
368 - takes an optional filename argument (the file to parse).
369 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
370 PubElVals hashing table.
371 * Dicts/dicomV3.dic removed error prone trailing spaces.
373 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
374 * Python wrapping process moved away from src/Makefile to
375 newly created python/Makefile (as well as gdcm.i)
376 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
377 * src/gdcmHeader::FindLength only looks for current vr when necessary.
378 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
379 from the environement variable GDCM_DICT_PATH (when existing).
380 * src/gdcmDict::GetTag bug fix.
382 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
383 * Straightforward temporary fixes for swig to build the python wrappers.
384 src/Makefile now has a python working entry [by working we mean
385 that we can import de shadow classes without errors].
387 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
388 * hashtest.cxx removed (since allready in Test)
389 * src/gdcmlib.h renamed to src/gdcm.h
390 * src/dcm.i renamed to src/gdcm.i
391 * src/Makefile prepared for python wrapping
393 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
394 * src/gdcmHeader.cxx :
395 - Parsing of header is now separated from loading of element values
396 (see gdcmHeader::LoadElements).
397 - general clean up of hopefully all file access (creation of
398 ReadInt16 and ReadInt32)
400 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
401 * src/gdcmHeader.cxx :
402 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
404 - SetLgrElem renamed to SetLength
405 - GetLgrElem renamed to GetLength
406 - ~gdcmHeader() made virtual to pesky warning messages at compile.
407 * src/gdcmElValSet.cxx fixed both GetElValue methods
408 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
409 due to IdoDude was cleaned out.
411 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
412 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
413 concentrates on finding the value representation (when it exists).
414 RecupLgr now only finds the element value length, and it avoids
415 returning the unecessary skL (skipped length).
416 Also, offsetCourant was simply removed (with taille_fich) since
417 it was redundant with the File position internals (by using
418 ftell and fseek). This also made skL (see above in RecupLgr) usage
420 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
421 on the libido specificities which are handled through class
423 * Test/implicit_vr.dcm dicom v3 in implicit value representation
426 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
427 * Truckload of changes. Parsing of header is barely functional
428 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
430 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
431 * src/gdcmHeader.cxx many addons of low level methods
433 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
434 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
437 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
438 * This corresponds to all the changes decided at the meeting of
439 May 23 2002. Needless to say we are running late...