1 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3 * src/gdcm.h general comments moved to TODO, and README
4 * src/gdcm.h should now be seen as a user commodity (including it
5 should suffice to fully use gdcm). It is nowhere including within
6 any of the kernel files src/*.cxx and src/*.h.
8 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
9 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
10 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
12 * src/gdcm*.cxx only include their corresponding include file
13 (as opposed to gdcm.h)
14 * gdcmPython/gdcm.i changed accordingly
15 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
16 the autogen.sh generated "make snapshot" command to work.
17 * autogen.sh removed history related references to crea package.
19 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
20 * distutilsSwigCPlusPlus.py work around some swig portability
23 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
24 * Eventually, python/gdcmPython was renamed to gdcmPython. This
25 was done in a last ditch attempt to get setup.py _really_
26 operationnal. The python/gdcmPython layaout add the advantage
27 of hidding away the python related distutils specific files
28 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
29 Alas, the src directory was out of scope (i.e. it's relative
30 position to setup.py was ../src) which made things impossible to
31 handle (see previous version of python/setup.py). Crossing fingers...
33 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
34 * python/setup.py now works on Un*x. (harder than I thougth)
35 * python/distutilsSwigCPlusPlus.py can now have include files
36 among the list of sources.
38 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
39 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
40 * modifications in MSVC projects
42 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
43 * As stated by the first lines of Test/ExceptionAndPython/README, it
44 looks like we can move back to original usage of exception within
45 src/gdcm* and hence remove the errno stuff that was introduced
46 as a quick and dirty fixture of this problem (added to the TODO).
47 * Doc/Doxyfile configuration file for Doxygen and corresponding
48 README file for usage added.
49 * Test/testWrite.cxx added. This new test comes from a split of
50 test.cxx that is now reverted to its original purpous i.e.
51 testing the proper parsing of a Dicom related file.
52 testWrite.cxx concentrates on testing the IO part of gdcm.
53 * Test/bug1.cxx (containing a bug on WIn32) added.
54 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
55 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
56 whose purpose is to publish the content of the TagNames of the
57 Dicom public dictionnary were not accessible without an
58 instance of class gdcmHeader.
59 - those methods are now static methods of gdcmDictSet and hence
60 require no instances at all to be invocated.
61 - within gdcmDictSet this change required to change some method
62 to class methods (i.e. are now static) among which SetDictPath
63 (renamed to BuildDictPath) and LoadDefaultPubDict.
64 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
65 the above changes by calling the new method classes of gdcmDictSet.
66 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
67 the above to be effective.
68 * python/gdcmPython: in order to wrap properly the above changes
69 for Python, swig version now needs to be > 1.3.17.
70 * python/gdcmPython/Makefile fixed to adapt itself to new
71 configure/make shema introduced by Johan Montagnat (thanks for the
72 contribution). Alas this Makefile cannot be turned into a proper
73 Makefile.am without some heavy changes in the configure.in
74 (for python dectection).
75 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
76 now avoids publishing the empty entries.
78 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
79 * python/setup.py : bug fix concerning install under windows
81 * gdcm.dsw : bug fix concerning path for libraries for python !!!
83 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
84 * Dicts/dicomV3.dic : remove double spaces !!!
85 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
86 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
89 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
90 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
92 * src/gdcm.h clean up of JPR spurious comments.
94 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
95 * python/distutilsSwigCPlusPlus.py now properly collects the
96 shadow classes generated by "swig -c++" (gdcm.py in our case)
97 when using "python setup.py install".
98 * python/gdcmPython/__init__.py imports gdcm.py and only manually
99 reexports the working classes.
100 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
101 by the classical C errno scheme. This is to prevent an obscure
102 behavior of the python wrappers when importing wxPython.wx prior
103 to gdcmPython (which ended up in an abort call). An illustration
104 of this oddity can be found in the Test/ExceptionAndPython
105 subdir (see the README file). This problem probably due to
106 an combination of g++ and dynamic loading.
107 * added Test/ExceptionAndPython (see above)
109 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
110 * Changed the layout of the python part to avoid bloating main
111 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
112 i.e. the distutils arsenal. All the python related stuff is
113 again in a python subdir, but the package itself is now in
115 * setup.py was cleaned up:
116 - pythonIncludePath removed
117 - python setup.py bdist target is now functional.
118 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
119 collision with other packages). gdcmPython/demo/*.py changed
121 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
122 * python subdir moved to gdcmPython (preparation of distutils packaging).
123 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
124 distutils installer is operational.
125 * - gdcmPython/__init__.py now properly loads the swig generated
126 shadow classes (from gdcm.py).
127 - gdcmPython/demo/*.py changed to import the package gdcmPython
128 instead of gdcmPython/demo/load.py.
129 - gdcmPython/testSuite.py changed to import the package gdcmPython.
132 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
133 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
134 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
135 entries within the associated public Dicom dictionary resp. the same
136 information but sorted by the fourth field (PAT, IMG, DIR) of the
138 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
139 are now in the "???" group.
140 - python/gdcm.i changed accordingly,
141 - python/demo/printGroupedPublicDict.py added, that gives an example
142 of the above new functionalities in Python.
144 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
145 * src/gdcm.h, gdcmHeader.cxx:
146 - historic references to glib's g_malloc and g_free (#defined)
147 were definitively removed.
148 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
149 * src/gdcmElValSet.cxx:
150 - GetElement(guint32, guint32) renamed to GetElementByNumber.
151 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
152 - GetElValue(string) renamed to GetElValueByName.
153 - Added GetElementByName(string).
154 * src/gdcmHeader.cxx: added
155 - GetPubElValRepByNumber(guint16, guint16)
156 - GetPubElValRepByName(string)
157 - GetShaElValRepByNumber(guint16, guint16)
158 - GetShaElValRepByName(string)
159 - GetShaElValByNumber(guint16, guint16)
160 - GetShaElValRepByName(string)
161 - GetElValRepByNumber(guint16, guint16)
162 - GetElValRepByName(string)
163 - GetElValByNumber(guint16, guint16)
164 - GetElValRepByName(string)
165 * Doc/requirements.txt added.
167 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
168 * Test/Makefile building now depends on the one of libgdcm.so
169 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
170 pixel data) aware which enables finding the address (offset) of
171 the pixel data of JPEG encoded DICOM files. This leaves only a single
172 file in the testSuite whose pixel data address (offset) is unknown.
173 * python/testSuite.py changed accordingly.
175 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
176 * VC++ has some strong limitations when working with the STL, as stated
177 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
178 "Also note that some STL containers (map, set, queue, list, deque)
179 cannot be exported. [...]
180 Some STL classes contain nested classes. These classes can not
182 This is caused by a designed limitation that once a template
183 class is instantiated, it can not be re-instantiated and
185 Since our usage of map<> is ubiquitous in gdcm, this "designed
186 limitation" of VC++ is a pitfall.
187 Hence the Python wrappers of gdcm cannot be incrementally linked
188 against the c++ dynamic library. The dirty but only workaround is
189 to forget about incremental link of dynamic libraries and to generate
190 the Python wrappers library with the inclusions of the underlying C++
192 The following modifications concern this matter on Win32/VC++:
193 - wrapping python correct with standalone wrapped dll (don't use separate
194 dll under windows !!!!)
195 - python21_d debug mode enabled (ask Frog how to use it :-)
196 - NO problem with having an STL member of class for example string in C++
197 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
198 - Python test of dcmlib in Python is ok under windows on a large set
200 * removed glib references
201 * typedef's inserted in gdcm.i for correct swig type management
203 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
204 * python/demo/*.py load.py extracted from test.py. Added explore.py
205 that only displays required tags and testAll.py that parses all
206 the files of the testsuite without using unittest.
207 * python/testSuite.py other additional test on new files added.
208 * Data/* new test files added accordingly to the testSuite.
209 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
210 the vr in the file differs from the one of the dictionary.
212 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
213 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
214 values, but limits itself to values which are below a user specified
215 size (by default 1024 bytes).
216 * python/gdcm.i : elements not loaded (because their size is above the
217 user specified treshold) are exported with their TagKey as key of the
218 python dictionary. This enables the testsuite to make some checks
219 on the unloaded elements (since we have their offset and size).
220 * python/testSuite.py
221 - now tests for the existence and proper value of the pixel data
222 - two new examples added.
223 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
225 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
226 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
227 aware. See the strategy comments in gdcmHeader::FindeLength().
228 * Test/test.cxx now accepts a filename as first argument.
229 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
230 * python/testSuite.py changed to integrate test on above files.
232 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
233 * Dicts/dicomV3.dic removed all the trailing (RET) when the
235 * python/testSuite.py more tests added.
237 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
238 * python/testSuite.py unittest test suite added (uses Data)
239 * Data/* dcm and acr files for the test suite.
240 * glib dependance removed from un*x version. We now use ISO C99
241 7.18 Integer types (see stdint.h)
242 - python/Makefile, src/Makefile src/gdcm.h
243 * src/ when an explicit vr (like dicom files) suddenly poped an
244 implicit element we use to mark the underlying DictEntry of the
245 concerned ElValue with "Implicit". This strategy was damageable
246 too the public or provite dictionaries, since some of their vr
247 would be changed. Since Header::FindLength heavily relies on the
248 detection by Header::FindVR of falsely explicit elements, I
249 added an extra ImplicitVr member to ElValue (boolean).
250 The rest of the changes we the necessary adaptations.
252 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
253 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
255 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
257 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
258 * Adaptation for porting to VC++:
260 o forced to use std namespace (for string to be known)
261 o all class use __declspec export style on WIN32
262 - src/gdcmUtil.cxx new Exit method that wraps the exit call
263 (in stdlib.h on Win32 but in std:: for gcc)
264 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
265 variable GDCM_DICT_PATH.
266 * src/gdcmHeader.cxx verbose comments made discrete.
268 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
269 * python/gdcm.i: added a typemap that converts a C++ hashing table
270 to native Python dictionary.
271 * python/demo/test.py:
272 - now uses the native dictionary for exploration of gdcmHeader.
273 - takes an optional filename argument (the file to parse).
274 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
275 PubElVals hashing table.
276 * Dicts/dicomV3.dic removed error prone trailing spaces.
278 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
279 * Python wrapping process moved away from src/Makefile to
280 newly created python/Makefile (as well as gdcm.i)
281 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
282 * src/gdcmHeader::FindLength only looks for current vr when necessary.
283 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
284 from the environement variable GDCM_DICT_PATH (when existing).
285 * src/gdcmDict::GetTag bug fix.
287 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
288 * Straightforward temporary fixes for swig to build the python wrappers.
289 src/Makefile now has a python working entry [by working we mean
290 that we can import de shadow classes without errors].
292 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
293 * hashtest.cxx removed (since allready in Test)
294 * src/gdcmlib.h renamed to src/gdcm.h
295 * src/dcm.i renamed to src/gdcm.i
296 * src/Makefile prepared for python wrapping
298 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
299 * src/gdcmHeader.cxx :
300 - Parsing of header is now separated from loading of element values
301 (see gdcmHeader::LoadElements).
302 - general clean up of hopefully all file access (creation of
303 ReadInt16 and ReadInt32)
305 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
306 * src/gdcmHeader.cxx :
307 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
309 - SetLgrElem renamed to SetLength
310 - GetLgrElem renamed to GetLength
311 - ~gdcmHeader() made virtual to pesky warning messages at compile.
312 * src/gdcmElValSet.cxx fixed both GetElValue methods
313 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
314 due to IdoDude was cleaned out.
316 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
317 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
318 concentrates on finding the value representation (when it exists).
319 RecupLgr now only finds the element value length, and it avoids
320 returning the unecessary skL (skipped length).
321 Also, offsetCourant was simply removed (with taille_fich) since
322 it was redundant with the File position internals (by using
323 ftell and fseek). This also made skL (see above in RecupLgr) usage
325 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
326 on the libido specificities which are handled through class
328 * Test/implicit_vr.dcm dicom v3 in implicit value representation
331 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
332 * Truckload of changes. Parsing of header is barely functional
333 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
335 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
336 * src/gdcmHeader.cxx many addons of low level methods
338 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
339 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
342 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
343 * This corresponds to all the changes decided at the meeting of
344 May 23 2002. Needless to say we are running late...