1 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Remove memory leaks on the DicomDir
3 * Remove some useless datas in DicomDirObject
4 * Add usefull methods in SQItem, to be complient withe the ElementSet
6 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
9 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
10 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
11 future, with convertion)
12 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
13 and ImageDataSize values. Remove the method to get the PixelReadConverter
14 from the output of the class
16 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
17 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
19 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
21 and vtkErrorMacro use.
22 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
24 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
25 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
27 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
28 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
29 The string leaves only in the fonction. So when we make a .c_str(), we
30 get the pointeur on the first element, element that will be destroyed
31 immediately after thee instruction.
32 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
33 file has been opened : the test must be made on the content of the
34 pointer and not directly on the pointer !
37 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
38 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
39 the python part recompiles
41 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
42 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
43 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
44 X session is killed (for my computer... it seems to not be identic on
47 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
49 avoid problems (otherwise, the difference test between the visible image
50 and the reference is incorrect. If the reference is greater than the
51 screen resolution, it's produce errors).
52 Can be used for only one image. Can be used with a visible flag.
53 * vtk/vtkGdcmReader.cxx : remove commented codes.
54 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
55 under windows at compilation
56 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
58 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
60 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
61 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
62 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
63 tests on the image size X, Y, Z
65 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
66 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
67 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
68 between the class name and the file name
70 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
71 * src/ : fix compilation warnings for the Write method (2 different
72 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
73 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
74 variable... create a static method in gdcm::Document to access to
75 this variable content.
77 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
78 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
79 file, to be accessed by other files (like gdcmFile). Remove commented
80 code. Move the change of the header to the gdcmFile, using the
82 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
83 To be sure of that (and simplify calls), the Write of the header now
84 gets a file name and not a file pointer (std::ifstream).
85 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
86 DocEntryArchive. Remove all open of the written file
88 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
89 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
91 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
93 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
95 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
96 some corresponding methods. Write correctly the file and check before
98 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
99 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
100 is now on RGB datas (as before my last commit
101 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
103 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
104 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
105 Add a print information of the type of the entry
106 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
107 It was in the gdcmFile, and all write have been regrouped
108 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
109 Write correctly all dicom files (in decompressed mode only at this time)
110 * Test/ : test on files are now made using Raw datas and not color datas if
112 * Example/PrintFile.cxx : add more printings
114 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
115 * Amelioration of code, remove some code copy. For the loading of
116 BinEntry (in gdcmDocument), add the test to verify if the file is already
119 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
120 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
121 remove a DocEntry in the header (push an empty DocEntry)
122 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
123 lines. Bug fix in the initialization of the PixelConvert and the
125 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
126 use in TestCopyDicom (now this test can run under windows... but fails)
127 * Test/TestCopyDicom.cxx : amelioration of the test :
128 - test the pixels written
129 - add test points to quickly find where is the error
130 - can set a file name input and output in arguments
131 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
132 amelioration of the test output
134 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
135 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
136 all replaced DocEntry's
137 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
138 Now, each needed DocEntry to modify is duplicated, modified and inserted
139 to the header using DocEntryArchive. Thus, after save, we can restore the
140 header initial state.
142 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
143 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
145 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
147 correct to copy it. The DictEntry is specified at the DocEntry creation,
148 then, it musn't change in the time.
149 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
150 header correctly. At this time, the change is only made for the first
151 level of the Document. In the future, it might consider sequences.
152 The change is made by replacing a DocEntry by an other that is created
153 outside the class. The old value is kept. When we restore the header
154 status, the added DocEntry is deleted and replaced by the old value.
155 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
156 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
157 set the write type to explicit VR, implicit VR or ACR. Add methods to set
158 the write mode to native, decompressed or RGB (but not used at this time)
160 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
161 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
162 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
164 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
165 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
166 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
168 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
169 set because already copied when copying the BinEntry's of the header
170 * Test/TestAllReadCompareDicom.cxx : remove warnings
172 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
173 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
174 Two problems appear when doing it :
175 - with the gdcmFile : when the GetImageData method is called, the pixels
176 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
177 datas (pixels). And each structure destruct the datas when it's
178 destructed. So we have two destructions for the same datas. To solve it,
179 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
180 datas or not. If it doesn't own datas, then they will not destroyed by
182 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
183 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
184 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
185 create a double destruction of the same DocEntry's. So, to solve it,
186 the TagHT is simply cleared and the DicomDir* elements are destroyed.
187 * TODO : add an entry concerning memory leaks in the DicomDir
189 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
190 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
191 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
194 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
195 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
196 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
197 after it have been deleted
199 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
200 * FIX: src/* fix the doxygen warnings.
201 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
202 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
203 was erroneously defined with a size of 15 instead of 16. [many thanks
204 to Jean Michel Rouet for pointing out this bug].
206 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
207 1. Finish merging JMR patch for writting DICOM from scratch
208 2. Fix -hopefully- bug with MONOCHROME and space vs null character
209 3. Use const ref when possible
210 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
211 5. A few more comments
212 6. CreateUniqueUID can now be called without parameter"
214 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
215 * ENH: Slightly bigger patch:
216 1. Getting toward full integration of JMR patch for writting dicom from scratch
217 2. Update Test to test part of this patch: CreateUniqueUID
218 3. File was not close properly in gdcmDict
219 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
220 5. Use of const ref instead of copy (speed issue)
221 6. Remove temporary (duplicate) string in TranslateToKey
222 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
223 8. Do not repeat virtual in subclasses
224 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
226 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
227 * Apply first patch toward better string comparison when dealing with broken
228 DICOM files. Essentially the string could be padded with a space instead
229 of a null character as defined by standard
231 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
232 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
233 because never used... and in the same time, that's remove some memory leaks
235 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
236 * src/gdcmFile.cxx : now delete the PixelConvert instance.
237 * In examples and tests : change the type of image data variables from void*
238 to uint8_t*. Remmove all delete on image data variables
240 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
241 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
242 Verify the file pointer value before open the file, and if it's not null,
243 a verbose message is generated.
244 Close correctly the file when the file isn't considered dicom-like. The
245 correctly close is a call to CloseFile.
246 When closing the file pointer, test if its not null to close the file.
247 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
248 file. For an uncompressed image, the copied datas correspond in the least
249 case to the image size (calculated) or the image size specified in the
250 header. A verbose is generated if these two size mismatch
252 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
253 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
254 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
255 break under windows (with msvc6 compilation).
257 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
258 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
259 compiling with MSVC6)
261 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
262 * Bugs fix for the Windows build with VC6
263 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
264 needed (only for projects required VTK). If the VTK is included in all
265 projects, there is conflicts with the jpeg lib of vtk when compiling the
266 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
267 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
268 when compiling the gdcm_wrap.cxx file (created by the compilation of the
270 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
271 (like it's already made for the cout use). Otherwise, conflict with the
274 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
275 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
277 - comments on the DicomDir::Method related usage added.
278 - now that we use the namespace gdcm, a lot of internal classes do
279 NOT need to be wrapped anymore.
280 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
281 DicomDir::Method) new example added.
283 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
284 * Improve string manipulation. I now inforce the notion of 'DicomString'
285 A DicomString can contain as many \0 as they want
286 and it is *always* of even length.
287 We only support odd length for very rare case.
288 And in the near future this should be removed.
290 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
291 * /binary_write/ gdcm source. Now even on big endian we are writting
292 little endian. This should -heopfully- fix some tests
294 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
295 * Now the dictionary is compiled into gdcm lib. This is a default
296 behavior, thus any dic file specified is picked before failback to
297 the one comiled into lib
299 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
300 * Change internals for gdcmDict. Don't use any 'new' any more.
301 This should definitely solve any leak problem, and we should be
302 as fast as before, as long as don't modify too much the dictionary.
304 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
305 * STYLE: ivars should start with a capital letter.
306 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
307 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
309 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
310 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
311 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
312 new 2004 dictionaries added (thanks to JPR).
313 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
314 * CLEANUP_ROUND (15) for gdcmPixelConvert
315 - RLEFrame::NumberFragments is now of type unsigned int
316 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
317 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
320 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
321 * Initial work in gathering all transfer syntax accessors. clearly
322 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
323 ivars, but only one transfersyntax (class) ivar with equivalent method on
326 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
327 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
328 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
329 discussed (plus I didn't like having a 2000 lines patch not commited)
331 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
332 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
333 * CLEANUP_ROUND (14) for gdcmPixelConvert
334 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
335 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
336 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
338 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
339 anymore and hence avoids storing a copy of PixelConvert::Decompressed
340 into File::Pixel_Data.
342 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
343 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
344 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
345 * CLEANUP_ROUND (13) for gdcmPixelConvert
346 Substituted File::ParsePixelData() with PixelConvert::Print() new
348 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
349 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
350 method to those classes.
351 - src/gdcmFile.[cxx|h]:
352 -- Added a ::Print() method.
353 -- PixelConverter is now a reference instead of a member.
354 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
355 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
357 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
358 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
359 collaboration diagram and inheritance diagram should be generated with
361 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
362 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
363 pointlessly wrapped (see
364 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
365 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
366 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
367 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
368 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
369 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
370 -- File::Initialise: PixelConverter setup moved away to
371 PixelConverter::GrabInformationsFromHeader()
372 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
373 interpretation moved away to PixelConverter::BuildRGBImage()
375 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
376 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
377 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
379 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
380 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
381 displayed on Win32 when a brutal abort() occurs (because of uncatched
382 exception). See TODO new entry of this commit for more on this.
383 * TODO added new entry.
384 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
385 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
386 - HandleColor is no longer called from gdcmFile.cxx
387 - gdcmPixelConvert.cxx clean up on method arguments and internal
388 variable names for semantical coherence.
390 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
391 * Finished lossless transition, not only do we now read all lossless jpeg
392 images, without the need of the Cornwell lib, but we do read them properly now
393 * To reduce code (well to avoid code duplication), I defined a common place
394 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
395 redefine symbols. This is not prefect but this the best solution I found for a
396 compilation time jpeg option.
398 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
399 * Update jpeg ijg lib to support lossless jpeg implementation
400 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
402 * Also added a special copyright for dcmtk since we use their bugfixes.
405 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
406 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
407 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
408 matters, as stated in warning note at begining of %include section).
409 * src/gdcmDicomDir*.[cxx|h]: coding style
410 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
411 * src/gdcmJpeg8.cxx: doxygen fix.
412 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
413 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
414 from File:: to PixelConvert::.
416 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
417 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
418 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
419 - more code moved away from File:: to PixelConvert::
420 - fat setup of PixelConverter set in place in File::Initialise.
422 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
423 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
424 namespace at the file system level. So now you should convert your examples
426 gdcmHeader -> gdcm::Header
427 It would be nice if people keep in mind to no open the namespace, since it
428 allows compilation on broken plateform which were defining common symbol in
429 the standart namespace (like LP, Unknown ...)
431 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
432 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
433 The JPEG fragments are now parsed at the same stage than the RLE
434 information. All code related to JPEG is now in gdcmPixelConvert:
435 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
436 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
437 export a gdcmFile:: method. Those are simply global functions
438 (for the time being this is better than having them attach to
439 either gdcmFile:: or gdcmPixelConvert::).
440 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
441 and stores the result in a gdcmJPEGFragmentsInfo.
442 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
443 code (among other stuff) moved away from gdcmFile:; to
446 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
447 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
448 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
449 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
450 clean up of RLE related code.
451 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
452 - src/gdcmRLE.cxx removed
453 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
454 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
455 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
456 * CLEANUP_ROUND (9) for gdcmPixelConvert
457 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
458 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
459 away from gdcmFile:: to gdcmPixelConvert::.
461 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
462 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
463 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
464 This is because Parse7Fe0 used to parse the pixels to compute the
465 length. This task was passed over to FindDocEntryLengthOB() a long
466 time ago, EXCEPT I had forgotten the OW case...
467 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
468 we just recylce the code for parsing RLE fragments and computing
470 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
471 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
472 with the retired Parse7Fe0().
473 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
474 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
476 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
477 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
478 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
479 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
480 - src/CMakeLists.txt: alphabetic order reodering + new entries.
481 * CLEANUP_ROUND (4) for gdcmPixelConvert
482 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
483 to return an unused length.
485 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
486 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
487 this should be cleanner from the plane view. The iostream are erally a pain
488 to use to do simple stuff.
490 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
491 * Redo the compilation of the ijg jpeg library. Now only one source is
492 necesseray. No need to rename file by hand what so ever. CMake handle the
493 copying of the file within different directory, configure header file to
494 modify some symbol. The only addition made to ijg wasd a mangle table so
495 that symbol are different wether we are within 8bits or 12bits.
497 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
498 * Added documentation of vtkgdcmReader on Website:
499 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
500 with it's binary name).
501 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
502 the Website to be more complete.
503 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
504 doxygenated documentation.
505 - Doc/DoxyVtkGdcmReaderExamples.txt added
506 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
507 DoxyVtkGdmReaderExamples.html )
508 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
509 * CLEANUP_ROUND (3) for gdcmPixelConvert
510 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
512 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
513 * CLEANUP_ROUND (2) for gdcmPixelConvert
514 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
516 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
517 * CLEANUP_ROUND for gdcmPixelConvert:
518 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
519 - src/gdcmPixelStuff[h|cxx] removed
520 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
521 - src/CMakeLists.txt changed accordingly
523 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
524 gdcmVersion.py moved to newly created ATTIC related
525 gdcmPython/SetupOldies/ directory.
526 * Autotools clean up:
527 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
528 - autogen.sh configure.in acinclude.m4 python.m4 removed
530 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
531 * src/*.cxx *.h Reference to License.htm fixed to License.html.
532 * Doc/CMakeLists.txt, doxygen.config.in: fix.
533 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
535 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
536 * TODO updated with Mathieu suggestions. I proposed a template for
537 describing TODO entries and used it for new entries.
538 * Added Doc/Website/CodingStyle.html, Developpers.html,
539 DeveloppersPython.html, GdcmDataCvs.html and
540 DownloadVersion0_1.html, DownloadVersion0_3.html.
541 * Some Doc/*.txt Doxygen files (which do not really concern the
542 documentation itself, but the website) moved to html and
543 placed in directory Doc/Website:
544 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
545 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
546 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
547 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
548 * CMakeLists.txt changed accordingly.
549 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
550 DeveloppersPython.html
551 * INSTALL nows refers to Doc/Website/Installation.html
553 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
554 * Added Doc/Website directory, that contains a first raw version
557 2004-09-23 Jean-Pierre Roux
558 * FIX In order not to be poluted any longer by casting problems,
559 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
560 we can now delete[] it safely
561 * VoidArea is now called BinArea (less confusing name),
562 and all the methods called ...VoidArea... are now ... BinArea...
563 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
565 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
566 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
567 clear) TagHT, which is an inherited member of gdcmElementSet. It is
568 up to the destructor of gdcmElementSet to clean up TagHt and it's
571 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
572 * Test/CMakeLists.txt: update to follow gdcmData renamings.
573 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
575 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
576 * ENH: added some utility method that builds a flat dictionnary
577 holding all the Dicom entries contained in the recursive structure
578 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
580 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
581 BuildFlatHashTable() that build a flat dictionary.
582 - src/gdcmElementSet.h: added a new private GetTag() accessor.
583 gdcmDocument is now a friend of gdcmElementSet.
584 - src/gdcmElementSet.cxx: clean up.
585 - Example/FlatHashTablePrint.cxx added.
586 - Example/CmakeLists.txt changed accordingly
588 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
589 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
590 moved away from gdcmDocEntrySet (since this class is an abstract class
591 acting like an interface). SQDepthLevel and BaseTagKey are now
593 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
594 and associated accessors. Doxygenation of the class.
595 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
597 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
598 Use SQDepthLevel accessor instead. ::Print() adapted.
599 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
600 - src/gdcmDocument.cxx changed accordingly.
602 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
603 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
604 - The following is the doxygen comment of the typedef declaration
605 of gdcmagKey in src/gdcmCommon.h:
606 gdcmTagKey is made to old an "universal" (as in URL, Universal
607 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
608 A dicom tag allways has a group and an element, but a set of tags
609 embeded in various (optionally nested) sequences and sharing
610 the same group and element all share the same (group, element)
611 "identifier". Hence the (group, element) cannot be used as an
612 identifier (in gdcm we shall refer to a "TagKey") of a tag.
613 In order to construct a proper tag identifier (i.e. a key) we
614 consider the following definition of a TagKey:
615 - let Group, Element be the string representation of the
616 group and element dicom tag members,
617 - let ItemNumber be the string representation of the integer
618 index of the considered item number of a sequence,
619 Let the key of a tag embeded in a sequence, noted SeqTag, be
621 /ItemNumber#Group|Element
622 where "/", "#" and "|" are characters acting as separators.
623 Then the general form of a gdcmTagKey is given by:
624 Group|Element<SeqTag>
625 where <SeqTag> means NO or many instances of SeqTag.
626 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
629 but the gdcmTagKey of a tag "embeded" is the first item of
630 a sequence, itself nested in the third item of a sequence is the
632 0004|1220/2#0008|0082/0#0008|0090
633 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
634 order to hold the new sequence compatible key. Previously, the
635 GetKey() method would look in the underlying gdcmDictEntry.
636 - src/gdcmDocEntry.cxx:
637 -- constructor now copies the underlying DictEntry key, in the local
639 -- ::Print: displays the member Key, instead of the (group, element).
640 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
641 - src/gdcmDocEntrySet.h:xi
642 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
643 -- now has a new BaseTagKey member.
645 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
646 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
648 This poses the problem with the semantics of the following lines
649 LoadEntryVoidArea(0x0028,0x1201); // R LUT
650 LoadEntryVoidArea(0x0028,0x1202); // G LUT
651 LoadEntryVoidArea(0x0028,0x1203); // B LUT
652 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
653 to the long FIXME note for what the problem is. Nevertheless in
654 order to get things working the dicom dictionary was altered !
655 Please fix things urgently...
656 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
657 information), see above note on moving the member VoidArea. Nevertheless
658 the following entries previously correctly set as US are now inproperly
660 0028 1201 OW IMG Red Palette Color Lookup Table Data
661 0028 1202 OW IMG Green Palette Color Lookup Table Data
662 0028 1203 OW IMG Blue Palette Color Lookup Table Data
663 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
664 of gdcmDocEntry moved to gdcmSeqEntry.
665 * src/gdcmSeqEntry.cxx: STYLE.
667 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
668 * Test/TestAllEntryVerify.cxx minor fix and added comments.
670 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
671 * gdcmPython/testSuite.py: all the test suite in python is now moved
672 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
673 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
674 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
676 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
677 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
678 to avoid inclusion recursion until STL is reached.
679 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
680 mecanism. errno.h is not included in gdcm anymore.
681 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
682 (gdcmFormatError now inherits from gdcmFormatUnexpected).
684 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
685 gdcmData/TestAllEntryVerifyReference.txt
686 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
687 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
688 exception_on_error parameter.
689 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
690 - vtk/vtkGdcmReader.cxx changed accordingly,
691 - Example/*.cxx and Test/*.cxx changed accordingly.
693 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
694 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
695 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
696 enable_sequences removed from gdcmHeader constructor and dependencies.
697 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
698 * gdcmPython/demo/PrintHeader.py: dummy fix.
699 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
700 skip_shadow removed from gdcmHeader constructor and dependencies.
701 * Example/*.cxx and Test/*.cxx changed accordingly.
703 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
704 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
705 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
707 2004-07-21 Jean-Pierre Roux
708 * FIX Now, Parsing and Printing a DICOMDIR do work!
709 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
711 2004-07-20 Jean-Pierre Roux
712 * FIX Some brain damaged headers have Zero-Lenght fields
713 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
715 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
716 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
717 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
718 variable (instance of gdcmDebug) by a definition macro, and the instance
719 is now in static in the gdcmDebug class
720 * src/gdcmSQItem.h : (FIXME) remove an undefined method
721 * Test/PrintAllDocument.cxx : bug fix in the result of the test
723 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
724 * WARNING: ctest now depends more tightly on gdcmData. You should
725 check out gdcmData properly for things to run smoothly...
726 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
727 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
728 we need the pixels not be loaded in order to use the ValEntry
729 that displays position and size).
730 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
731 This is a C++ based equivalent of gdcmPython/testSuite.py that should
732 be deprecated. If you have any doubts about the advantages of a
733 modern scripting language (read Python) versus grass root C++ (i.e.
734 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
735 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
736 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
737 Anyhow, consider documenting the gdcmData images in
738 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
740 * Test/CMakeLists.txt:
741 - now uses TestAllEntryVerify.cxx
742 - specific comments on oldACR00001.ima (now renamed in gdcmData
743 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
744 gdcmData/TestAllEntryVerifyReference.txt
747 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
748 * src/*.[h|cxx] : typedef clean up
749 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
750 - TagKey renamed to gdcmTagKey (for external usage)
751 - VRKey renamed to gdcmVRKey (for external usage)
752 - removal of typedef duplication.
753 - Removed all unecessary inline keyword from class inline definitions.
754 - Some method|function(void) declarations replaced with method|function().
755 * src/jpeg/libijg12/jdhuff12.c:
756 - printf polluting ctest removed.
757 - TAB removal for comminting
759 - TestAllReadCompareDicom.cxx: added a test that compares all the
760 images in gdcmDataImages.h with corresponding images in
761 gdcmData/BaselineDicom/. When baseline images are not present
762 this test creates them.
763 Note: we need to validate each reference image, but before that
764 I'd like to rename them with a more explicit name...
765 - CMakeLists.txt: changed accordingly.
766 * Example/*.cxx: examples now only include gdcm.h (as opposed to
767 including each header needed).
769 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
770 * Test/*.cxx and Example/*.cxx: moved some examples away from the
771 test suite to the Example directory. Are concerned:
776 - TestWriteSimple.cxx
777 * Test/CMakeLists.txt: added some comments on reasons for black listing
778 image gdcmData/oldACR00001.ima
780 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
781 * Test/CmakeList.txt: removed the following from black list (to be coherent
782 with removal from gdcmData):
783 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
784 - gdcm-MR-PHILIPS-16.dcm
786 Added the following because after last cvs update, they cause
787 ctest -R TestReadWriteReadCompare
789 - gdcm-MR-SIEMENS-16-1.acr
791 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
792 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
793 new comments in this file) we temporarily (sigh) move to a weaker
795 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
796 we don't need to black list the following images anymore:
797 - 8BitsUncompressedColor.dcm
799 - US-PAL-8-10x-echo.dcm
800 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
801 fixes and the beautified code ;-)
802 This fixes the bug introduced in version 1.42 (when beautifying)
803 that made the parsing of 8BitsRunLengthColor.dcm unproper.
804 Note: ctest was blind to this bug (this means we need to still
805 improve the test suite). The bug could be detected by using
806 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
808 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
809 and by displaying the (garbage) produced file temp.XDCM...
811 2004-06-29 Jean-Pierre Roux
812 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
813 - replace by uggly but working old code :-(
814 A lot of things should be OK again.
815 It's really urgent to have a test suite that *tests*,
816 to prevent Frog's beautifying sessions to break all the stuff
817 (twice, withing a fortnigh ...)
819 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
820 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
821 redundancy) to added Test/TestReadWriteReadCompare.cxx
822 * Test/CmakeList.txt: because the compare test of
823 Test/TestReadWriteReadCompare.cxx fails, the following images are
824 black listed: - 8BitsUncompressedColor.dcm
826 - US-PAL-8-10x-echo.dcm
827 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
828 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
829 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
830 and ad-hoc kludge. This kludge is now removed, and on encountering
831 such an image (OB field brain damaged) we set errno. Then in
832 ::FindDocLength() we "fix" the length as being ALL what remains
833 in the file (until EOF). We then proceed, hoping for the best...
834 This fixes a SegFault in ShowDicom when trying to write such an
836 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
837 (because TestWriteRead breaks on it, after a non conformal commit?).
838 ctest now runs properly, except for MakeDicomDir (which was allways
839 broken) and the Python related stuff (still not fixed).
841 2004-06-24 Jean-Pierre Roux
842 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
843 FIX : Test/TestReadWrite now iterates on all the file names
844 (instead of infinite loop)
845 ENH : Test/TestWriteRead now iterates on all the file names
847 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
848 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
850 2004-06-24 Jean-Pierre Roux
851 FIX : - now Write drops LUT Descriptors and LUTs (if any)
852 when SamplesPerPixel =3
853 - now Write is no longer confused by
854 'BitsAllocated = 12" and 'BitsStored=12"
855 - "UN" value representation Elements are now written correctly
856 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
857 ENH : - now gdcmHeader has its own Write methods
858 (in order to split the job that has not to be done
861 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
862 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
863 loop on the same image until memory went out.
864 Note: this means we still have gobs of memory loss in PrintDocument
865 * src/gdcmDocument.cxx: fixes problem on parsing on file
866 gdcmData/16BitsJpegLosslessGrayScale.dcm.
868 2004-06-24 Jean-Pierre Roux
869 FIX : Write - All the Sequences and Sequence Item are now written
870 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
871 is added a the end, when necessary.
872 - A lot of brain-damaged images, that were read correctly are
873 now written correctly
874 - length compatible BinEntry are now loaded correctly
875 (even for odd groups)
876 Note : only Explicit Value Representation was checked.
877 (question : is implicit VR really necessary for gdcm ?)
879 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
880 * DEVELOPPER: added a proposition of coding style.
881 * src/gdcmDocEntry.h: removed every inline declaration (for test of
884 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
885 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
886 Use the gdcmDocEntry::Print() and Write() instead.
887 * src/gdcmDocument.cxx: bug fix.
889 2004-06-22 Jean-Pierre Roux
890 FIX : gdcmDocument.cxx
891 - Now we do recognize the JpegLossLess format (there was a misstyping in
892 code 'beautyfication' :-(
893 - Now we automaticaticaly load the Luts, if any
895 2004-06-22 Jean-Pierre Roux
896 In order : to write Sequences, whatever their imbrication level,
897 : to allow user to create his own Sequences
898 a lot of modif where necessary (adding, moving, or virtualising methods)
900 WARNING : save your own sources *before* cvs up !
903 ADD virtual void Write(FILE *fp, FileType filetype);
906 ADD virtual void Write(FILE *fp, FileType filetype);
907 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
910 ADD virtual void Write (FILE *fp, FileType filetype)=0;
911 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
912 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
913 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
914 ADD std::string GetEntryByName(TagName name);
915 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
917 std::string vr = "unkn",
918 std::string fourth = "unkn",
919 std::string name = "unkn");
920 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
921 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
922 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
923 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
924 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
925 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
926 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
927 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
930 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
931 ADD virtual std::string GetEntryByName (TagName tagName);
932 ADD virtual std::string GetEntryVRByName (TagName tagName);
933 REM virtual bool Write(FILE *, FileType);
934 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
935 FILE *_fp, FileType type);
936 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
937 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
938 REM virtual bool WriteEntries(FILE *_fp,FileType type);
939 REM virtual std::string GetEntryByName (std::string tagName);
940 REM virtual std::string GetEntryVRByName (std::string tagName);
941 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
942 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
943 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
945 std::string vr = "unkn",
946 std::string fourth = "unkn",
947 std::string name = "unkn");
948 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
949 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
950 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
951 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
954 ADD virtual void Write(FILE *fp, FileType filetype);
957 ADD virtual void Write(FILE *fp,FileType filetype);
960 ADD virtual void Write(FILE *fp, FileType filetype);
961 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
962 REM std::string GetEntryByNumber(guint16 group, guint16 element);
963 REM std::string GetEntryByName(TagName name);
966 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
968 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
969 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
970 The default constructor invoked by the line
971 gdcmHeader *f1 = new gdcmHeader( header );
972 was gdcmHeader::gdcmHeader(bool) instead of the expected
973 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
974 Hence the parsing wasn't executed... See also below.
975 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
976 as explicit constructor didn't do the trick to fix the above problem.
977 Could anyone explain why ?
978 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
979 properly calls gdcmValEntry::Print() (that was weed out from
980 code related to gdcmBinEntry).
982 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
983 * In order to fix memory leaks:
984 - Test/TestWriteSimple.cxx: added cleaning of free store through
986 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
987 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
988 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
989 (through the call to ::AddDicomDirMeta()) or the destructor
990 would crash when deleting uninitialized ::metaElems].
991 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
992 - src/gdcmDocument.cxx:
993 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
995 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
996 was causing memory leaks.
997 - src/gdcmSQItem.cxx:
998 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
999 cleanly handled with polymophism: sorry but my milage is low).
1000 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1001 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1002 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1003 This avoids SegFaulting.
1004 - src/gdcmSQItem.h: coding style.
1006 - Test/TestWriteSimple still severely sucks. The output image content
1007 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1008 damaged when displayed with vtkgdcmViewer.
1009 - on memory leaks: TestWriteSimple leaks really less (see entry
1010 of 2004-06-18 in Changelog file for the call to valgrind).
1011 - on segfaults: ctest now passes all the tests but one (no more
1013 * Erroneous leading white fix:
1014 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1015 white[s] (as opposed to from >> xxx, that removes it [them].
1016 - src/gdcmTS.cxx: ditto.
1017 - gdcmPython/testSuite.py: dirty related kludge removed.
1018 * src/*: remaining references to gdcmParser removed.
1019 * src/*[cxx|h]: added copy[way]left header.
1022 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1023 * In order to fix writing of dicom files:
1024 - Test/TestWriteSimple.cxx: a simpler example of writing.
1025 - Test/CMakeLists.txt changed accordingly.
1026 - src/gdcmDocument.cxx:
1027 -- The destructor now recursilvely removes potential sequences.
1028 -- Bug fix in ::IsJPEG2000()
1029 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1030 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1032 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1033 to only declared) and build on top of
1034 ::GetDocEntryByNumber(guint16, guint16).
1035 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1036 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1037 for usage in destructor and treatement of promotion in
1038 ::ReplaceOrCreateByNumber().
1039 - src/gdcmSQItem.cxx: destructor should better handle his job.
1040 Test/TestWriteSimple now runs (or at least it DOES something).
1041 * We can now start hutting memory links. A good starting point is:
1042 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1043 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1044 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1046 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1047 * Valgrind note: after Mathieu Malaterre teached me how to read
1048 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1050 Using gcc, you can force the STL to use malloc and to free memory as
1051 soon as possible by globally disabling memory caching.
1052 With 3.2.2 and later, you should export the environment variable
1053 GLIBCPP_FORCE_NEW before running your program.
1054 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1055 simply vanish (it is still not clear to me, whether this means that
1056 STL std::string leaks or if valgrind believes it leaks...).
1057 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1058 running bin/gdcmTests makeDicomDir):
1059 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1060 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1062 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1063 SegFaulting (I drowned in DicomDir related code when trying to
1064 understand why the list is empty...).
1065 * src/gdcmDocument.h: first BSD license header try.
1066 * Doc/License.txt added.
1068 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1069 * src/gdcmDocument.[h|cxx]:
1070 - Clean up of the Transfer related predicates. They are now all based
1071 on new method isGivenTransferSyntax, that (should) handle properly
1072 the padding problem.
1073 - general clean up, simplification, and coding style.
1074 - Specific clean up of Parse7FE0() (umproperly named actually).
1075 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1077 2004-06-14 Jean-Pierre Roux
1079 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1080 - fix the display of SQItem ordinal number
1081 - add the GetSQItemByOrdinalNumber method
1082 - remove some useless never written private methods
1084 2004-06-14 Jean-Pierre Roux
1086 - adding a constructor taking a gdcmDocEntry as an input param
1087 - ReplaceOrCreateByNumber now returns :
1088 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1089 a gdcmValEntry * if a string value is passed as a param
1091 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1092 according to the param type (no longer sets a gdcmDocEntry)
1093 - GetValEntryByNumber, GetBinEntryByNumber added
1094 - NewValEntryByNumber and NewBinEntryByNumber added
1096 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1098 - GetSQItemNumber and SetSQItemNumber added, to provide
1099 a (relative) Item identier inside a given Sequence
1100 \warning : some pb remaining around this number
1102 - AddEntry now takes the Item Number as a param
1104 - adding a constructor taking a gdcmDocEntry as an input param
1106 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1107 * Memory leak hunt with the following command:
1108 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1109 --show-reachable=yes gdcmTests PrintDocument
1110 It looks like many (all?) leaks are due to the STL (or a bad usage
1111 of the STL. The lines producing the leaks now have a comment with
1112 a "MEMORY LEAK" tag: you can retrieve them with
1113 grep "MEMORY LEAK" src/*
1114 Here are two typical examples which I can't help fixing:
1119 char * test = "babo";
1120 name = test; //// <--- valgrind detects 960 bytes lost in
1121 //// call to std::string::operator=(char const*)
1122 name.clear(); //// Doesn't help !
1130 std::cout << "Type a bunch of characters followed by RETURN: ";
1131 getline(std::cin, line); //// <--- valgrind dectects a loss
1132 //// of 1320 bytes in call to
1133 /// std::basic_istream<>& std::getline<>
1139 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1140 * src/gdcmHeader.[cxx|h]:
1141 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1142 and related, moved away to gdcmDocument.
1143 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1144 the corresponding protected accessors of inherited class
1145 gdcmDocument, removed ! As a consequence gdcmFile had to be
1146 declared friend of class gdcmDocument (see below).
1147 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1148 - Clean up of undefined or unused methods.
1149 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1150 account the changes to gdcmHeader.h).
1151 * src/gdcmDocument.h:
1152 - gdcmFile is now a friend class (in order to take into account the
1153 changes to gdcmHeader.h).
1154 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1155 (see changes to gdcmHeader.h).
1156 - Accessors (reading on the form GetEntry*) are now public.
1157 - Clean up of undefined or unused methods.
1158 * src/gdcmDocument.cxx:
1159 - adaptation to changes to gdcmDocument.h
1160 - ::OpenFile now writes a verbose message when file cannot be opened.
1161 - some std::string properly set to VRKey
1162 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1163 references to gdcmDocument.
1164 * Test/TestFindTags.cxx: changed accordingly to above changes.
1165 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1166 cvs repository gdcmData.
1168 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1169 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1170 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1171 conflicts with gdcmValEntry::voidArea.
1172 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1173 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1174 Value representation between StringRepresentable and BinaryRepresentable.
1175 * src/gdcmDocument.cxx:
1176 - method ParseDES: proper indentation restored and usage of
1177 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1178 - method LoadDocEntry: the fingerprint left in the SetValue() of
1179 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1180 removed. Reverting to previous code segment with the proper
1181 dynamic_cast< gdcmValEntry* >.
1182 Note: this was (partially) breaking the python test suite
1183 (gdcmPython/testSuite.py) that made usage of the above
1184 fingerprint to check presence of "Pixel Data".
1185 * src/gdcmDocEntry.h: coding style.
1186 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1187 now taken into account.
1188 * gdcmPython/gdcm.i: adaptation to the new internal representation
1189 of gdcm (exit gdcmParser, hello gdcmDocument).
1190 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1192 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1193 anymore, but instead prints the loaded Python dictionary.
1194 * .... alas, the python testSuite is still broken.
1196 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1197 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1199 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1200 * src/gdcmUtil.h : export methods
1202 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1203 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1205 * Initial addition of automatic python testing
1206 * Initial addition of automatic image comparison
1208 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1209 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1210 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1212 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1213 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1214 * Test/ShowDicom.cxx : bug fix for msvc compilation
1215 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1217 2004-05-04 Jean-Pierre Roux
1218 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1219 new concepts (and new classes) :
1220 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1221 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1222 - Sequence Doc Entries (gdcmSeqEntries)
1223 a Sequence is composed of Items.
1224 Each item is a set of Doc Entries (this is recursive)
1225 The non uniqueness of the 'Dicom tag' is due to this recursivity
1226 (never taken into account)
1227 Our unability to add a new 'entry' in the header
1228 at the proper location (neither in the H-Table (map or multimap),
1229 nor in the Chained List is also due to this recursivity.
1230 Don't try, right now, to use/modify/compile these new sources :
1231 nothing is finished.
1232 We just commit all the stuff, 'as is', in order not to loose it.
1234 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1235 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1237 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1238 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1239 file prefix (SetFilePrefix)
1241 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1242 * Add a new test: ShowDicom, for now this is just the c++ version of
1243 checkRead.sh, later it will be able to compare the image read against a
1245 * Replace the DEBUG on the stack with a global entry in cmake interface:
1246 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1248 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1249 * Add an example subdir, with a real example on how to read + write a
1252 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1253 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1254 * Doc/CMakeLists.txt: the main page is now properly differentiated
1255 between the developper and user version.
1256 * Doc/doxygen.config.in: dropped search related obsolete flags
1257 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1259 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1260 * DEVELOPPER: added some helpfull comments for compile/test/install
1263 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1264 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1265 src directory, now generated in the build dir.
1266 2. Tests as mentionned smarter
1268 4. Add a new method in gdcmDict that return the PubDict by name
1269 this is interesting for 3rd party lib like ITK,
1270 where we could set the institution name / patient name...
1272 * ENH: 1. Now the test suite is working for real
1273 2. All binaries are now output in the gdcm-bin directory
1274 (this was not true before)
1276 2004-04-28 Jean-Pierre Roux
1277 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1278 SeQuence indented printing of Dicom Header.
1279 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1280 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1281 Computation of SQDepthLevel is now part of gdcmHeader constructor
1282 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1283 tree-like structure of a Dicom Header.
1284 * FIX Test code cleaning
1286 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1287 * ENH: Adding automatic testing
1288 1. Need a DartConfig.cmake to submit to public
1289 2. Add a test driver gdcmTest.cxx
1290 3. gdcmTestMain, an helper for the main test driver gdcmTest
1291 4. Files in Test don't have a main anymore, this becomes interesting
1292 when we add more and more tests, thus dsw don't have to load
1294 * ENH: Adding a GDCM_DATA_ROOT for testing
1295 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1296 one file instead of seven + some small cleanup
1298 2004-04-22 Jean-Pierre Roux
1299 * ENH Minor changes to the Print() methods.
1300 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1301 Header printing. Example given with :
1302 > PrintHeader fileName 2 new
1303 (SQ based tree-like structure still to be done for the Header ...)
1305 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1306 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1307 1. I have added some unsigned where needed
1308 2. Some function parameter not used -> (void)
1309 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1310 4. g++ don't like character '\' in comment
1311 5. #define jpeg_create_decompress jCreaDecompress
1312 this really need to be fixed
1313 6. virtualize destructor of gdcmObject ... leakage
1314 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1315 this also really need to be fixed
1316 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1317 remove compression file
1318 (as we only do decompression, right ?)
1319 * ENH: Change malloc/calloc/free with c++ equivalent
1321 2004-04-21 Jean-Pierre Roux
1322 * FIX gdcmHeaderHelper::GetXSpacing
1323 when a single value is found (bug ?), xpacing is now
1324 defaulted to yspacing
1326 2004-04-19 Jean-Pierre Roux
1327 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1328 * ENH add parameters :
1329 bool exception_on_error = false,
1330 bool enable_sequences = false,
1331 bool ignore_shadow = false
1332 to the gdcmFile constructors to be full gdcmParser compliant
1333 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1334 to allow reading of PAPYRUS 3.0 files
1336 2004-04-06 Jean-Pierre Roux
1337 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1339 2004-04-02 Jean-Pierre Roux
1340 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1341 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1342 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1344 2004-03-30 Jean-Pierre Roux
1345 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1346 for ACR file, written out as DICOM files (hope so...)
1348 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1349 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1350 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1351 moved to base class gdcmParser and only the specialisation is kept
1353 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1354 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1355 already does the job.
1356 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1357 (to be consistent with gdcmParser::WriteEntries).
1359 2004-03-30 Benoit Regrain
1360 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1361 upate of the object's instance. It's passed to 2 in the unfavorable
1362 case : one in the ExecuteInformation, one in the ExecuteData
1364 2004-03-29 Jean-Pierre Roux
1365 * ENH : Check on file type to be written moved
1366 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1367 * FIX : gdcmObject::ResetBoundaries now stops properly
1368 when end-of-list is reached
1369 : gdcmVersion modified (as Benoit Regrain asked)
1371 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1372 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1373 * src/gdcmUtil.cxx: added forgotten iostream include.
1374 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1375 equivalent to ExplicitVR in existing code).
1377 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1378 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1379 now contains all the gdcmGlobal related code.
1380 * minor coding style and doxygenation changes.
1382 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1383 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1384 now contains all the Debug related code.
1385 * minor clean-up of includes in src/*.cxx
1386 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1387 CreateCleanString) removed.
1388 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1389 * Doc/DoxyMainPageUser.txt added.
1390 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1391 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1392 src/gdcmDirList.cxx)
1394 2004-03-24 Jean-Pierre Roux
1395 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1397 2004-03-23 Jean-Pierre Roux
1398 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1399 big endian made volumes
1400 * ENH Now gdcmParser constructor and destructor are protected to forbid
1401 end user to instanciate class gdcmParser
1402 (only gdcmHeader and gdcmDicomDir are meaningfull)
1404 2004-03-22 Benoit Regrain
1405 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1406 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1407 gdcmSerie to gdcmDicomDirSerie
1409 2004-03-19 Jean-Pierre Roux
1410 * ENH Now the tree-like structure describing a DICOMDIR comming from
1411 an already existing DICOMDIR file is consistent with
1412 the home-made tree-like structure build ex-nihilo
1413 or build from the files held (recursively) in a Directory
1414 functions gdcmDicomDir::CheckBoundaries()
1415 gdcmObject::SetBoundaries() added
1417 2004-03-17 Jean-Pierre Roux
1418 * REM (Eric Boix bug) : removal of meaningless
1419 gdcmDicomDirImage::NewImage function.
1420 * FIX now file names and directory name are written properly in the
1422 * FIX now gdcmDicomDir constructor may be call without any trick
1425 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1426 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1427 of gdcmDicomDirImage::NewImage as empty function.
1429 2004-02-28 Jean-Pierre Roux
1430 * ENH add gdcmDicomDir:NewPatient
1431 add gdcmDicomDirPatient:NewStudy
1432 add gdcmDicomDirStudy:NewSerie
1433 add gdcmDicomDirSerie:NewImage
1434 to allow making gdcDicomDir object.
1435 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1436 (as opposite to the gdcmHeader chained list)
1438 2004-02-11 Benoit Regrain
1439 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1440 when using from python
1442 2004-02-10 Benoit Regrain
1443 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1444 * FIX : in gdcmDicomDir when the directory is empty
1445 * ENH : add callback and methods to get the progression of dicomDir
1448 2004-02-06 Jean-Pierre Roux
1449 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1450 - GDCM_META added to gdcmDicomDirType
1451 - class gdcmMeta created
1452 * ENH : - A brief summary is now displayed at the beginning of
1453 'testDicomDir' to help disaster magnitude estimation
1454 * REM : Now useless Test/explDICOMDIR.cxx
1456 2004-02-05 Benoit Regrain
1457 * ENH : add methods in gdcmObject to get the hash table or the list of
1459 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1460 * FIX : wrapping python for TagHeaderEntryHT
1462 2004-02-04 Benoit Regrain
1463 * FIX : even length for some strings when writting the dicom dir
1464 * FIX : sort the images in the dicom dir
1465 * FIX : Bug fix for python use of dicom dir
1466 * ADD : a python demo
1468 2004-02-04 Jean-Pierre Roux
1469 * FIX : Final solution (?) for icone embedded images
1470 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1471 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1472 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1473 gdcmData/gdcm-MR-SIEMENS-16.acr1
1474 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1475 to make full checking easier
1477 2004-02-04 Benoit Regrain
1478 * FIX : WriteEntries : coding style & logic in parameters
1479 * FIX : Set the elements to create the DicomDir in a dictionary file
1481 2004-02-03 Benoit Regrain
1482 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1483 * gdcmDicomDir : add the load of directory
1484 * Bug fix and print add-on
1486 2004-02-03 Jean-Pierre Roux
1487 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1488 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1489 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1490 * FIX gdcmParser.cxx : 'group length' elements are now considered
1491 as integers, even for shadow groups, when file is Implicit VR
1493 2004-02-02 Jean-Pierre Roux
1494 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1496 of the last synonym :-(
1497 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1499 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1500 * FIX taking into account the possible 7fe0,0010 multiplicity
1501 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1502 to allow removal of references to 7fe0,0010, to deal with
1503 ACR-NEMA images, when 0028,0200 is meaningfull
1505 2004-01-31 Jean-Pierre Roux
1506 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1507 no longer writes 'Un' on disk
1508 * FIX SQ elements with actual length are now dealt with corectly
1509 * FIX gdcmFile::WriteBase make the difference, for color images, between
1510 the length (for Palette expanded images)
1511 and Raw Length (non expanded image + Palette)
1512 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1513 (that broke Write). Replaced by UL.
1514 Aware user will reload the field if he
1515 thinks it's necesssary
1517 2004-01-30 Jean-Pierre Roux
1518 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1519 when 'dirty Acr' is found, to be compliant with the new
1520 IsReadable() methods.
1522 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1523 (no DOUBLE images in kosher DICOM,
1524 but so usefull for people that miss them ;-)
1526 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1527 DICOMDIR related utilities (not checked as Windoze compliant)
1529 2004-01-28 Jean-Pierre Roux
1530 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1532 2004-01-27 Jean-Pierre Roux
1533 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1534 to allow skipping the shadow elements, to save memory space.
1535 The TRUE value for this param has to be used
1536 with a FALSE value for the 'enable_sequence' param.
1537 ('public elements' may be embedded in 'shadow Sequences')
1538 * gdcmHeader methods now deal with 'embedded icones images' in the header
1539 (even when an 'icone image sequence' is announced by the
1540 element (0x0088,0x0200), but there is NO icone at all ...
1542 * gdcmHeader sometimes Image Location value doesn't follow
1543 the supposed processor endianity (see gdcmData/cr172241.dcm).
1546 * gdcmHeader add the method
1547 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1548 to get *all* the Header Entries with the same tag.
1549 GetHeaderEntrySameName is probabely *useless*
1550 (no meaning : Name is *not* an identifier within the Dictionnary)
1552 2004-01-26 Benoit Regrain
1553 * Bug fix in the print of hexadecimal representations. Remove long fields
1554 in the print and add a third level of print to print them
1556 2004-01-23 Benoit Regrain
1557 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1558 * Bug fix on test suite after remove the strip made on not string fields
1559 * Split the IsReadable method between gdcmParser which test that the file
1560 is dicom and gdcmHeader which test that it's an image file
1562 2004-01-22 Benoit Regrain
1563 * DicomDir : clean code, add methods, set variables in protected or private
1564 * gdcmUtil : bug fix for the clean string method
1566 2004-01-19 Benoit Regrain
1567 * Add the use of shadow dictionaries
1568 * bug fix and coding style
1570 2004-01-19 Benoit Regrain
1571 * src/gdcmFile.cxx : bug fix concerning the close of file
1572 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1573 * Add the update of header entries using the shadow library
1575 2004-01-19 Benoit Regrain
1576 * removal of file gdcmHeader2.cxx
1577 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1578 inheriting from gdcmParser. This split is to prepare the integration
1579 of dicom dir parsing
1580 * bug fix under python
1582 2004-01-16 Jean-Pierre Roux
1583 * REM removal of class gdcmHeaderEntrySet
1584 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1585 * ADD add file gdcmHeader2.cxx
1586 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1588 2004-01-15 Benoit Regrain
1589 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1590 entries created while parsing the header. Thus, they will be destroyed
1591 when the gdcmDictSet will be destroyed
1592 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1595 2004-01-15 Benoit Regrain
1596 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1597 made a fatal error because of the memory release at the end of program.
1598 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1599 some memory and vtk seems to have some problems with that.
1600 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1602 2004-01-14 Benoit Regrain
1603 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1604 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1605 * src/*.[h|cxx] : make changes due to class name changes
1606 * gdcmPython/demo/*.py : bug fix due to method names
1608 2004-01-13 Benoit Regrain
1609 * src/*.[h|cxx] : coding style
1610 * vtk/*.[h|cxx] : coding style
1612 2004-01-13 Benoit Regrain
1613 * gdcmPython/testSuite.py : test the readable flag of file for tests
1614 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1615 It's lied to the stl compilation by MSVC (windows, always windows...)
1616 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1618 2004-01-12 Benoit Regrain
1619 * src/*.h : add comments
1620 * src/gdcmDictSet.h : set the method BuildDictPath in public
1621 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1622 directly setted in the source code
1623 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1626 2004-01-09 Benoit Regrain
1627 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1628 * setup.py : use a reference to gdcmVERSION
1630 2004-01-07 Benoit Regrain
1631 * Modification to compile with the distutils.
1634 2003-12-10 Benoit Regrain
1635 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1636 can use a gdcmHeaderHelper to load datas
1637 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1638 made in the source code
1640 2003-12-10 Benoit Regrain
1641 * Update Windows projects and .cvsignore files
1643 2003-11-12 Jean-Pierre Roux
1644 * ENH gdcmHeader constructor has one more parameter (default value : false)
1645 that allows the user to 'go inside' the SeQuences only
1647 gdcmElValSet:Print takes it into account
1649 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1650 * ENH: Update gdcmPython/CMakeLists
1651 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1652 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1654 2003-11-10 Jean-Pierre Roux
1655 * FIX : gdcmHeader::LoadElements is now based
1656 on the ListTag listElem member,
1657 not longer on the TagElValueHT tagHt member
1658 * ENH : PrintPubElVal shows (temporarily) both results,
1659 with the tagHt member and the listElem member.
1660 (it's easier to 'see' the problems when using Printheader)
1662 * FIX : old private member LgrElem is now splitted into
1663 ReadLength : Length actually found on disk (updated only
1664 if bug fixing is necessary), for internal
1666 UsableLength : Updated by FixFoundLength, to fix a bug
1667 or to allow Parser going on.
1668 Will allow to re-write a kosher header when a SeQuence
1669 with a length (not 0000) is found
1670 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1671 because gdcmElValSet::Add does not update ListElem
1674 2003-11-07 Jean-Pierre Roux
1675 * FIX misstyping in Transfert Syntax name table
1676 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1677 when they have an actual length (not 0000 nor FFFFF)
1678 (Nobody should care of it, but DICOMDIR explorers)
1680 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1681 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1683 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1684 * ENH: vtkGdcmReader now supports LUT !
1685 (vtkgdcmViewer for now is not able to use them though)
1687 2003-11-05 Jean-Pierre Roux
1688 * in testSuite.py : new files names for checking the package
1689 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1690 that returns the pixel area size to the *aware* (vtk) user
1691 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1693 2003-11-05 Benoit Regrain
1694 * in testSuite.py : Modify the rules for checking the paths
1695 : Explicit error messages
1696 * in __init__.py : Related modif
1698 2003-11-03 Jean-Pierre Roux
1699 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1700 to be used by aware (vtk) users that want to manage
1701 LUT (and no to turn the PALETTE image into an RGB pixels one)
1702 * GetPixelType now returns 8U for 24 Bits images
1703 (vtkGdcmReader compliant)
1705 2003-10-31 Jean-Pierre Roux
1706 * Removal of *all* gdcmData images and add them again
1707 in order to loose the 'history' of un-anonymised images
1709 2003-10-31 Jean-Pierre Roux
1710 * RMV : removal of useless jBitsInJsample.h
1711 for both 8 and 12 Bits JPEG Lossy Libraries
1713 2003-10-31 Jean-Pierre Roux
1714 * ENH : Add the functions gdcmFile::GetImageDataRaw
1715 gdcmFile::GetImageDataIntoVectorRaw
1716 that act as GetImageData and GetImageDataIntoVector
1717 except the making of an RGB Plane from Gray Plane + LUT
1718 Intended to aware (vtk) users who know how to manage
1721 GetLUTRGBA return a R,G,B,A LUT if any
1722 lgrTotaleRaw gives the 'Raw' length
1723 GetImageDataRaw returns the gray Plane
1724 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1725 (They stay Grey, just like with other Dicom viewers :-(
1727 2003-10-30 Jean-Pierre Roux
1728 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1730 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1731 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1732 being coherents dicom files.
1734 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1735 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1737 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1738 * ENH: Two steps is necessary to please VC++ compiler...
1739 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1740 * ENH: Add include dir to medcon lib
1741 * FIX: only one function is being exported for now !
1742 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1744 2003-10-29 Jean-Pierre Roux
1745 * adding gdcmHeader::GetLUTRGBA
1746 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1747 --> Mathieu, the modif u're waiting for is not yet committed
1748 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1750 2003-10-27 Jean-Pierre Roux
1751 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1752 00191113.dcm DermaColorLossLess.dcm
1753 MxTwinLossLess.dcm RadBWLossLess.dcm
1754 * ENH: For version prior to vtkImageViewer2 -r 1.19
1755 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1757 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1758 * Removal of ido stuff in CMakeLists.txt
1760 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1761 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1762 * FIX: remove a call to ->Modified ... see comments
1763 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1765 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1766 * FIX: Problem with path for libvtkgdcmPython
1767 * ENH: Try adding a search script for python site-package
1768 * RMV: Remove some file from medcon lib that are not necessary
1769 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1770 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1771 * FIX: More pragma disable fro VC++,
1772 I don't think I break something as it is also disable in VTK/ITK.
1773 But it fasten debug compilation time.
1775 2003-10-23 Jean-Pierre Roux
1776 * gdcm now deals with 16 Bits Run Length Encoded images
1777 (they are compressed as 2 planes images,
1778 one for the high Bytes, the other for low Bytes)
1780 2003-10-22 Jean-Pierre Roux
1781 * Now CheckRead takes into account :
1782 - the bugged 'Leonardo' Siemens images
1783 - the XA images, sent thru the burning VPRO station
1784 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1787 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1788 * FIX: When copying a Makefile.am to CMakeLists.txt
1789 one should remove the '\'
1791 2003-10-22 Jean-Pierre Roux
1792 * in gdcmData adding a bugged 'Leonardo' Siemens image
1793 (wrong lengths in header)
1794 OK with gdcm, KO with the other viewers :-)
1795 * add a GE dlx XA image, thru the VEPRO burning station
1798 2003-10-21 Jean-Pierre Roux
1799 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1800 for a brutal checking of vtkgdcmViewer compliance
1802 2003-10-21 Jean-Pierre Roux
1803 * add the files for 'xmedcon' Jpeg Lossless library
1804 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1806 2003-10-21 Jean-Pierre Roux
1807 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1809 2003-10-21 Jean-Pierre Roux
1810 * garbage Siemens 'Leonardo' images dealt with
1811 (the patch is easy to remove)
1812 * cosmetic changes to avoid warnings
1814 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1815 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1816 no need to press 'r' now.
1818 2003-10-20 Jean-Pierre Roux
1819 * upgrade of checkRead.sh checkWrite.sh according
1820 to new Jpeg Lossless decompressor
1821 * add US.3405.1.dcm, a genuine RGB medical file ...
1822 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1823 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1825 2003-10-15 Jean-Pierre Roux
1826 * general anonymisation in gdcmData
1827 * adding the 'color files' from
1828 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1829 * adding some well knowed bugged-header images
1830 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1831 waiting for their inclusion in Python testsuite
1833 2003-10-15 Jean-Pierre Roux
1834 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1835 no longer seg faults when file is not found
1837 2003-10-14 Jean-Pierre Roux
1838 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1841 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1842 * TODO: *.in file to genereate a UseGDCM later
1844 2003-10-14 Jean-Pierre Roux
1845 * Some supposed-to-be Dicom Images have no preamble.
1846 OpenFile takes it into account
1847 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1848 * Missing elements added in dicomV3.dic
1849 (just to be affraid : have a look at
1850 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1851 and do it again next year ;->
1853 2003-10-13 Jean-Pierre Roux
1854 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1855 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1856 But there are NOT. It's fixed !
1858 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1859 * FIX: "jpeglib.h" was not found on VC++
1860 * FIX: vtkgdcm was not being installed
1862 2003-10-10 Jean-Pierre Roux
1863 * ENH : OpenFile closes the file if it *really* doesn't look like
1864 an ACR-NEMA / DICOM one.
1865 * FIX : testWrite no longer writes an empty file if the source file
1866 is not gdcm Readable
1867 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1870 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1871 * FIX: CMake generate now documentation
1872 * ENH: out of source doc build !
1873 * ENH: Generate both user and dev documentation
1874 * ENH: Should work on windows too
1875 * ENH: Only one doxygen config.in file is needed
1876 * FIX: make install should be ok now on ùnix plateform
1877 * FIX: PATH to dictionary was wrong (missing /)
1878 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1880 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1881 * vtkGdcmReader is now able to read rgb dicom file.
1882 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1883 * added a gdcmViewer to vtk test, use mouse to control
1884 window level & window width
1886 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1887 * CMake-ification of gdcm, we have now two build system
1888 * FIX: on cygwin Wsock32 doesn't exist
1889 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1891 2003-10-06 Emanuel Ollart
1892 * FIX : compilation process wad broken.
1893 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1895 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1896 * change gdcmViewer -> vtkgdcmViewer
1897 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1899 2003-10-06 Jean-Pierre Roux
1900 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1901 ( e.g : well known GE images with a wrong elem length,
1902 : Philips MRI Images with a wrong Huffman table)
1903 * still to be done : allow the reading of bugged LEONARDO Siemens images
1905 2003-10-03 Jean-Pierre Roux
1906 * Odd length strings are padded with '\0' (not with spaces,
1907 to remain compliant with already defined strings,
1908 like Transfert Syntax UID and others)
1910 2003-10-03 Jean-Pierre Roux
1911 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1912 to allow displaying RGB images (not only by affim ;-)
1914 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1915 * vtkGdcmReader is now able to read rgb dicom file.
1916 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1918 2003-10-03 Jean-Pierre Roux
1919 * A few nasty patches to allow the reading of a lot of nasty images
1920 ( e.g : well known GE images with a wrong elem length,
1921 : Philips MRI Images with a wrong Huffman table)
1922 * still to be done : allow the reading of bugged LEONARDO Siemens images
1924 2003-10-03 Jean-Pierre Roux
1925 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1927 2003-10-03 Jean-Pierre Roux
1928 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1929 to allow displaying RGB images (not only by affim ;-)
1931 2003-10-03 Jean-Pierre Roux
1932 * gdcmFile::GetImageDataIntoVector now
1933 - deals with MultiFrames MultiFragments Run Length Encoded files
1934 - deals with YcBcR (YBR_FULL) files
1935 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1936 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1938 (no sample found :-(
1940 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1941 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1942 Two reasons: - clear things
1943 - third parties acces gdcm through header files, so won't
1944 suffer anymore VC++ complains
1946 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1947 * add argv[1] in testvtkGdcmReader.cxx
1950 2003-09-24 Jean-Pierre Roux
1951 * The lines are now eigthy characters long.for
1952 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1954 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1955 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1956 char* to std::string. Thus, the use of strdup becomes useless. (see
1957 previous commis of Malaterre)
1958 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1959 before the last Malaterre's commit.
1961 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1962 * This commit should fix the Debug building under VC++, the problem
1963 was mainly a mixture of debug and release lib being loaded at startup.
1964 * I also remove a depency to a specific C function: strdup. Because I had
1965 to force the link to msvcrtd (whereas strdup is in libc).
1967 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1968 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1969 located in the gdcmCommon.h file. All use of reference of tha has been
1970 changed to now use the variable GDCM_UNFOUND.
1972 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1974 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1975 Dicom dictionary. The test suite can now be run again. Note:
1976 I'm note very happy with the " (RET)" changes. I believe this
1977 RETAINED comment should be dropped when parsing the dictionary.
1978 - PACKAGER corrected
1980 - AUTHORS updated and now in alphabetical order
1981 * Makefile.am now exports gdcm.dsw for Windoze users.
1983 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1984 * cygwin complains about missing std:: in subdir Test/
1986 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1987 * remove some methods that are now in gdcmHeaderHelper
1989 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1990 * vtkGdcmReader set spacing and origin correctly
1992 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1993 * Fix a few delete/delete[] mismatch
1995 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1996 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1997 interpretation to data given by gdcmHeader. For instance there are
1998 heuristics to get informations (look at different places).
1999 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2000 sorting DICOM images based on different strategies.
2001 * modified Makefiles accordingly.
2003 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2004 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2005 when building in debug mode
2006 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2007 src/win32/gdcmdll.dsp
2008 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2010 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2011 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2014 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2015 * src/win32/libgdcmjpeg12.dsp was not dos format
2016 * src/win32/libgdcmjpeg12.dsp :
2017 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2018 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2020 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2021 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2023 * src/gdcmFile.cxx : bug fix in affectation type
2024 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2025 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2026 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2027 symbols... future problem ?
2029 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2030 * src/win32/libgdcmijpeg12.dsp was missing
2031 * modified gdcm.dsw accordingly
2033 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2034 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2036 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2037 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2038 commit of JPR (before his hollidays to facilitate our work).
2039 * setup.py : bug fix in code. Modifications made while the last commit
2040 of JPR. The code hasn't been tested before the commit... it's so
2041 useless to make that (for best programmer that is JPR) !!!
2043 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2044 * tagged the current version as Version0_3 (i.e. version 0.3)
2046 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2047 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2048 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2049 * *.dsp : modifications to use new libgdcmijpeg8 library
2050 * setup.py : bug fix on VTKPATH variable
2051 * PACKAGER : adding all concerning windows
2053 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2054 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2056 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2057 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2058 test suite reported error.
2059 * PACKAGER file added (describes what a packager must do when
2060 packaging a new release).
2061 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2062 * configure.in: upgraded version number to 0.3.0
2063 * fixing build of rpm (through rpm -ta):
2064 - Doc/Makefile.am exports proper doxygen files
2065 - src/jpeg/libijg8/Makefile.am exports the include files.
2067 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2068 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2069 * src/gdcmHeader.h : formatting code
2071 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2072 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2073 We were obtaining error message from vtk. Now, creation of file list
2074 is made in an internal list to prevent this problem.
2075 Bug fix when output is empty.
2076 Bug fix in update of progress value. Previous commit for this was a bad
2078 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2080 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2081 * src/gdcmHeader.h : added method to get the file name
2082 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2083 files. Added method to remove all files on the input
2084 Added FIXME comment concerning the bad parsing of header made by
2085 ExecuteInformation method (in ExecuteData method)
2087 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2088 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2089 when using make instal.
2090 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2091 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2093 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2094 * setup.py : adding include dir of jpeg lib to compile all sources
2095 * */Win32/*.dsp : JPR fix for windows compilation
2097 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2098 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2100 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2101 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2103 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2104 * setup.py is again effective on un*x (takes into account the
2105 addon of the jpeg library)
2106 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2107 * Doc/Doxy* updated (includes above enhancements)
2108 * INSTALL now points to web documentation
2110 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2111 * src/gdcmHeader.h doesn't make unnecessary reference to
2113 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2115 * src/gdcm*.[cxx|h] :
2116 - to allow compilation with gcc 3.x
2117 -- clean up of STL usage (added explicit usage of std::)
2118 -- small fixes on exceptions.
2119 Note: linking not tested !
2120 - clean of doxygen comments to avoid warnings at documentation
2122 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2123 dependent convertion).
2125 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2126 * Clean up of previous JPR garbage commit (not even commented in the
2128 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2129 - moved all jpeg related files from src to src/jpeg/libijg8, with
2130 addition/modification of Makefile.am and configure.in.
2131 - the testSuite is still brain damage (not guilty).
2133 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2134 * WrapVTK.py : modifications to get correctly vtk source files to
2136 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2137 (FileName -> Filename)
2139 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2140 * vtk/vtkGdcmReader.[cxx/h]:
2141 - UpdateProgress method should now be effective
2142 - removed the limitation on having only images loaded (as opposed
2144 - when building a stack of images/volume, a lesser number of
2145 gdcmHeader and gdcmFile instances should be used (hopefully
2146 accelerating things).
2147 - when building a stack of images/volumes, files which are not
2148 loadable (wrong path-filename, wrong permissions on existing file,
2149 or file not parsable by gdcm) are replaced with a black image
2150 in the stack (for the caller to notice the problem).
2152 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2153 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2155 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2156 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2157 between standard library (std) and vtk library (problems are found
2158 under Windows... thanks Windows !)
2160 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2161 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2163 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2165 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2166 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2168 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2169 * When compiling with distutils (see setup.py) the C++ compiler is
2170 called with different flags than the default ones (with automake).
2171 In order to fix all those warning, I compiled gdcm with the command
2172 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2173 and went for warning fixes:
2174 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2175 up from unused variables.
2176 - vtk/vtkGdcmReader.cxx: potential bug fix.
2177 * src/gdcmHeader.h: Doxygen warning cleanup
2179 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2180 * gdcmPython/gdcm.i:
2181 - typemaps correction to take into account the systematic replacement
2182 of "using namespace std" with std:: prefix e.g. std::list,
2183 std::string... (cf changes of 2003-05-21).
2184 - gdcmGlob global variable of type gdcmGlobal (defined in
2185 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2186 exported to Python a as cvar.
2187 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2188 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2189 gdcmDictSet.GetPubDictTagNames() and
2190 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2191 C++ static methods).
2192 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2193 with the above changes.
2195 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2196 * setup.py, manifest.in : bug fix under linux
2198 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2199 * Modification of setup.py to compile vtk part too. Then, we have 2
2200 wrappers which must work with same distutils. For that, we have a
2201 generic distutils in distusiltsWrapping.py ; with :
2202 - build_extWrap class to wrap generically all extensions,
2203 - ExtensionWrap base class for all wrapping extension that contains
2205 - Wrapper interface which wrap sources
2206 + In WrapSwig.py we have extension and wrapper for Swig
2207 + In WrapVTK.py we have extension and wrapper for VTK
2208 * MANIFEST.in : modifications to consider vtk directory and new python
2209 files for compilation
2211 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2212 * Added python wrappers of vtkGdcmReader vtk class (see the
2213 source in vtk/vtkGdcmReader.cxx) :
2214 - vtk/Makefile.am now builds a library
2215 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2216 python library (as opposed to _gdcm.so wich are the python
2217 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2218 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2220 - configure.in has an additional flag --enable-vtk that needs
2221 to be set to enable compilation of vtk related code, that is:
2222 + vtk/vtkGdcmReader.so and
2223 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2224 + gdcmPython/vtkgdcmPython.so (see above)
2225 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2226 be read when compressed or when HighBit + 1 != BitsStored),
2227 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2228 the usage of the python wrapper of vtkGdcmReader vtk class.
2229 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2230 * src/*.[h] all occurences of stl classes are now prefixed with
2231 std::, and all occurences of "using namespace std;" where removed.
2232 This is to avoid pollution of global namespace in included files.
2233 Apparently vtk does not avoid this pitfall: when using both
2234 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2235 collision of various stl members (principally cout...).
2236 * gdcmPython/testSuite.py now cleanly removes temprory generated
2238 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2239 comply with above changes)
2241 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2242 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2243 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2244 vtk data structure (an image Flip was required).
2245 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2246 * cosmetic changes in documentation.
2248 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2249 * src/gdcmHeader.cxx: the constructor no longer exits when an
2250 unexisting file is given as argument.
2251 * The subdirectory Data (containing all the images used for the
2252 test suite) is not part of this repository anymore. A new module
2253 containing those images is now available at
2254 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2255 with the name gdcmData.
2256 All the python scripts (including the package initialisation file
2257 gdcmPython/__init__.py) were adapated to take this change into
2258 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2260 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2261 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2262 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2263 demo of the usage of this class.
2264 Compilation of this vtk part is only done when using the --enable-vtk
2265 at configure (or autogen.sh) stage.
2267 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2268 * More memory link related corrections and documentation fixes.
2270 - maximum info is obtained with a command of the form:
2271 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2272 --show-reachable=yes PrintHeader
2273 - the remaining reachable blocks seem to come from the STL
2274 allocation scheme through the usage of map and list. It looks
2275 like this memory cannot be freed but it is not a memory leak
2276 (in fact further invocation to the STL would recollect the
2277 unused memory allthough it cannot explicitely be freed).
2278 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2279 of displaying an image parsed with gdcm and displayed with VTK.
2280 Note: some images don't seem to work e.g.
2281 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2282 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2283 Allthough this weakens the semantics, it is a ditch attempt to
2284 make gdcm more thread friendly.
2286 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2287 * Memory link hunt (by using valgrind through the command
2288 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2289 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2290 gdcmHeader::_dicom_vr.
2291 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2292 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2294 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2296 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2297 * src/Makefile.am now exports all the necessary include files at
2301 * UpdateGroupLength replaced by new one
2304 * UpdateGroupLength re-written using H-Table
2305 (named UpdateGroupLengthNew untill checks are over)
2307 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2308 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2309 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2311 - gdcmHeader::GetPubElValSet removed.
2312 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2313 UpdateGroupLength, WriteElements, Write.
2314 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2315 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2316 carried the same semantics.
2317 - src/gdcmHeaderIdo.cxx changed accordingly.
2318 - gdcmFile::WriteBase now regroups all the codes from previous
2319 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2320 - enum FileType moved to gdcmCommon.h
2321 * src/gdcmHeader.cxx AddDefault trashed
2322 * gdcmGetXSize added
2323 * getimageDataSize now calls gdcmGetXSize
2324 * Test/*.cxx changed to agree with above changes
2326 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2327 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2328 (to avoid double call by end user).
2329 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2330 by end user, since gdcmHeader::gdcmHeader now handles it.
2332 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2333 * gdcm/Doc many doxygen changes:
2334 - Doxyfile now has two different versions, DoxyfileUsers that generates
2335 the html.users end users oriented documentation and
2336 DoxyfileDeveloppers that generates the html.developper developper
2337 oriented documentation.
2338 - README changed accordingly
2339 - requirement.txt removed (old design info moved to TODO).
2340 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2341 DoxyMainPage.txt, DoxyPython.txt provide more information.
2342 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2343 be updated by simply regenerating the docs with doxygen and copying
2344 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2345 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2346 all the tests in the form "if (<map>.count() >1)" were removed.
2347 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2348 ill-formed documentation sections.
2349 * src/gdcmHeader.cxx: ditto
2351 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2352 * setup.py fixed for un*x (needed macro for stdint.h)
2353 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2354 un*ces with sh-utils test utility.
2355 * gdcmPython/demo/test.py renamed to PrintHeader.py
2356 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2357 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2358 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2359 * src/gdcm*.cxx JPR's bad inclusion fixed.
2361 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2362 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2363 * gdcmPython/demo/test.py changed accordingly.
2365 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2366 * gdcmPython/Makefile.am fixed linking against libstdc++
2367 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2368 * Swig subdir (historical tests of swig version 1.3.17++) removed
2369 * Test/testChangeEntete.cxx some lines commented out in order to make
2371 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2372 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2374 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2375 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2376 hence the user doesn't need this explicit call.
2377 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2378 i.e. LoadElements() call removed.
2379 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2380 - src/Makefile.am declares the proper flag for g++.
2381 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2382 for adding user defined new tags.
2383 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2384 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2385 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2387 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2388 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2389 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2390 src/Makefile.am : the project should properly compile and install
2391 with the autotools, included the python wrappers part.
2392 * gdcm.spec.in : added a spec file for RPM packaging.
2394 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2395 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2397 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2398 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2399 to exported to the environement (see gdcmPython/testSuite.py
2401 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2402 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2403 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2404 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2405 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2407 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2408 * gdcmPython/__init__.py doesn't crash anymore when running in
2409 in InstallMode or PreInstallMode but with an environement given
2410 value of GDCM_DICT_PATH.
2411 * src/gdcmDictSet.[cxx/h] coding style.
2413 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2414 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2415 * src/gdcm.h general comments moved to TODO, and README
2416 * src/gdcm.h should now be seen as a user commodity (including it
2417 should suffice to fully use gdcm). It is nowhere including within
2418 any of the kernel files src/*.cxx and src/*.h.
2420 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2421 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2422 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2424 * src/gdcm*.cxx only include their corresponding include file
2425 (as opposed to gdcm.h)
2426 * gdcmPython/gdcm.i changed accordingly
2427 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2428 the autogen.sh generated "make snapshot" command to work.
2429 * autogen.sh removed history related references to crea package.
2431 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2432 * distutilsSwigCPlusPlus.py work around some swig portability
2435 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2436 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2437 was done in a last ditch attempt to get setup.py _really_
2438 operationnal. The python/gdcmPython layaout add the advantage
2439 of hidding away the python related distutils specific files
2440 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2441 Alas, the src directory was out of scope (i.e. it's relative
2442 position to setup.py was ../src) which made things impossible to
2443 handle (see previous version of python/setup.py). Crossing fingers...
2445 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2446 * python/setup.py now works on Un*x. (harder than I thougth)
2447 * python/distutilsSwigCPlusPlus.py can now have include files
2448 among the list of sources.
2450 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2451 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2452 * modifications in MSVC projects
2454 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2455 * As stated by the first lines of Test/ExceptionAndPython/README, it
2456 looks like we can move back to original usage of exception within
2457 src/gdcm* and hence remove the errno stuff that was introduced
2458 as a quick and dirty fixture of this problem (added to the TODO).
2459 * Doc/Doxyfile configuration file for Doxygen and corresponding
2460 README file for usage added.
2461 * Test/testWrite.cxx added. This new test comes from a split of
2462 test.cxx that is now reverted to its original purpous i.e.
2463 testing the proper parsing of a Dicom related file.
2464 testWrite.cxx concentrates on testing the IO part of gdcm.
2465 * Test/bug1.cxx (containing a bug on WIn32) added.
2466 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2467 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2468 whose purpose is to publish the content of the TagNames of the
2469 Dicom public dictionnary were not accessible without an
2470 instance of class gdcmHeader.
2471 - those methods are now static methods of gdcmDictSet and hence
2472 require no instances at all to be invocated.
2473 - within gdcmDictSet this change required to change some method
2474 to class methods (i.e. are now static) among which SetDictPath
2475 (renamed to BuildDictPath) and LoadDefaultPubDict.
2476 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2477 the above changes by calling the new method classes of gdcmDictSet.
2478 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2479 the above to be effective.
2480 * python/gdcmPython: in order to wrap properly the above changes
2481 for Python, swig version now needs to be > 1.3.17.
2482 * python/gdcmPython/Makefile fixed to adapt itself to new
2483 configure/make shema introduced by Johan Montagnat (thanks for the
2484 contribution). Alas this Makefile cannot be turned into a proper
2485 Makefile.am without some heavy changes in the configure.in
2486 (for python dectection).
2487 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2488 now avoids publishing the empty entries.
2490 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2491 * python/setup.py : bug fix concerning install under windows
2492 ExtraPath reused :-P
2493 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2495 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2496 * Dicts/dicomV3.dic : remove double spaces !!!
2497 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2498 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2501 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2502 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2503 method. Doxygenation.
2504 * src/gdcm.h clean up of JPR spurious comments.
2506 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2507 * python/distutilsSwigCPlusPlus.py now properly collects the
2508 shadow classes generated by "swig -c++" (gdcm.py in our case)
2509 when using "python setup.py install".
2510 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2511 reexports the working classes.
2512 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2513 by the classical C errno scheme. This is to prevent an obscure
2514 behavior of the python wrappers when importing wxPython.wx prior
2515 to gdcmPython (which ended up in an abort call). An illustration
2516 of this oddity can be found in the Test/ExceptionAndPython
2517 subdir (see the README file). This problem probably due to
2518 an combination of g++ and dynamic loading.
2519 * added Test/ExceptionAndPython (see above)
2521 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2522 * Changed the layout of the python part to avoid bloating main
2523 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2524 i.e. the distutils arsenal. All the python related stuff is
2525 again in a python subdir, but the package itself is now in
2527 * setup.py was cleaned up:
2528 - pythonIncludePath removed
2529 - python setup.py bdist target is now functional.
2530 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2531 collision with other packages). gdcmPython/demo/*.py changed
2534 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2535 * python subdir moved to gdcmPython (preparation of distutils packaging).
2536 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2537 distutils installer is operational.
2538 * - gdcmPython/__init__.py now properly loads the swig generated
2539 shadow classes (from gdcm.py).
2540 - gdcmPython/demo/*.py changed to import the package gdcmPython
2541 instead of gdcmPython/demo/load.py.
2542 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2544 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2545 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2546 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2547 entries within the associated public Dicom dictionary resp. the same
2548 information but sorted by the fourth field (PAT, IMG, DIR) of the
2550 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2551 are now in the "???" group.
2552 - python/gdcm.i changed accordingly,
2553 - python/demo/printGroupedPublicDict.py added, that gives an example
2554 of the above new functionalities in Python.
2556 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2557 * src/gdcm.h, gdcmHeader.cxx:
2558 - historic references to glib's g_malloc and g_free (#defined)
2559 were definitively removed.
2560 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2561 * src/gdcmElValSet.cxx:
2562 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2563 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2564 - GetElValue(string) renamed to GetElValueByName.
2565 - Added GetElementByName(string).
2566 * src/gdcmHeader.cxx: added
2567 - GetPubElValRepByNumber(guint16, guint16)
2568 - GetPubElValRepByName(string)
2569 - GetShaElValRepByNumber(guint16, guint16)
2570 - GetShaElValRepByName(string)
2571 - GetShaElValByNumber(guint16, guint16)
2572 - GetShaElValRepByName(string)
2573 - GetElValRepByNumber(guint16, guint16)
2574 - GetElValRepByName(string)
2575 - GetElValByNumber(guint16, guint16)
2576 - GetElValRepByName(string)
2577 * Doc/requirements.txt added.
2579 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2580 * Test/Makefile building now depends on the one of libgdcm.so
2581 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2582 pixel data) aware which enables finding the address (offset) of
2583 the pixel data of JPEG encoded DICOM files. This leaves only a single
2584 file in the testSuite whose pixel data address (offset) is unknown.
2585 * python/testSuite.py changed accordingly.
2587 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2588 * VC++ has some strong limitations when working with the STL, as stated
2589 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2590 "Also note that some STL containers (map, set, queue, list, deque)
2591 cannot be exported. [...]
2592 Some STL classes contain nested classes. These classes can not
2594 This is caused by a designed limitation that once a template
2595 class is instantiated, it can not be re-instantiated and
2597 Since our usage of map<> is ubiquitous in gdcm, this "designed
2598 limitation" of VC++ is a pitfall.
2599 Hence the Python wrappers of gdcm cannot be incrementally linked
2600 against the c++ dynamic library. The dirty but only workaround is
2601 to forget about incremental link of dynamic libraries and to generate
2602 the Python wrappers library with the inclusions of the underlying C++
2604 The following modifications concern this matter on Win32/VC++:
2605 - wrapping python correct with standalone wrapped dll (don't use separate
2606 dll under windows !!!!)
2607 - python21_d debug mode enabled (ask Frog how to use it :-)
2608 - NO problem with having an STL member of class for example string in C++
2609 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2610 - Python test of dcmlib in Python is ok under windows on a large set
2612 * removed glib references
2613 * typedef's inserted in gdcm.i for correct swig type management
2615 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2616 * python/demo/*.py load.py extracted from test.py. Added explore.py
2617 that only displays required tags and testAll.py that parses all
2618 the files of the testsuite without using unittest.
2619 * python/testSuite.py other additional test on new files added.
2620 * Data/* new test files added accordingly to the testSuite.
2621 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2622 the vr in the file differs from the one of the dictionary.
2624 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2625 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2626 values, but limits itself to values which are below a user specified
2627 size (by default 1024 bytes).
2628 * python/gdcm.i : elements not loaded (because their size is above the
2629 user specified treshold) are exported with their TagKey as key of the
2630 python dictionary. This enables the testsuite to make some checks
2631 on the unloaded elements (since we have their offset and size).
2632 * python/testSuite.py
2633 - now tests for the existence and proper value of the pixel data
2634 - two new examples added.
2635 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2637 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2638 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2639 aware. See the strategy comments in gdcmHeader::FindeLength().
2640 * Test/test.cxx now accepts a filename as first argument.
2641 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2642 * python/testSuite.py changed to integrate test on above files.
2644 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2645 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2646 the vr was also RET.
2647 * python/testSuite.py more tests added.
2649 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2650 * python/testSuite.py unittest test suite added (uses Data)
2651 * Data/* dcm and acr files for the test suite.
2652 * glib dependance removed from un*x version. We now use ISO C99
2653 7.18 Integer types (see stdint.h)
2654 - python/Makefile, src/Makefile src/gdcm.h
2655 * src/ when an explicit vr (like dicom files) suddenly poped an
2656 implicit element we use to mark the underlying DictEntry of the
2657 concerned ElValue with "Implicit". This strategy was damageable
2658 too the public or provite dictionaries, since some of their vr
2659 would be changed. Since Header::FindLength heavily relies on the
2660 detection by Header::FindVR of falsely explicit elements, I
2661 added an extra ImplicitVr member to ElValue (boolean).
2662 The rest of the changes we the necessary adaptations.
2664 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2665 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2667 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2669 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2670 * Adaptation for porting to VC++:
2672 o forced to use std namespace (for string to be known)
2673 o all class use __declspec export style on WIN32
2674 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2675 (in stdlib.h on Win32 but in std:: for gcc)
2676 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2677 variable GDCM_DICT_PATH.
2678 * src/gdcmHeader.cxx verbose comments made discrete.
2680 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2681 * python/gdcm.i: added a typemap that converts a C++ hashing table
2682 to native Python dictionary.
2683 * python/demo/test.py:
2684 - now uses the native dictionary for exploration of gdcmHeader.
2685 - takes an optional filename argument (the file to parse).
2686 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2687 PubElVals hashing table.
2688 * Dicts/dicomV3.dic removed error prone trailing spaces.
2690 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2691 * Python wrapping process moved away from src/Makefile to
2692 newly created python/Makefile (as well as gdcm.i)
2693 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2694 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2695 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2696 from the environement variable GDCM_DICT_PATH (when existing).
2697 * src/gdcmDict::GetTag bug fix.
2699 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2700 * Straightforward temporary fixes for swig to build the python wrappers.
2701 src/Makefile now has a python working entry [by working we mean
2702 that we can import de shadow classes without errors].
2704 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2705 * hashtest.cxx removed (since allready in Test)
2706 * src/gdcmlib.h renamed to src/gdcm.h
2707 * src/dcm.i renamed to src/gdcm.i
2708 * src/Makefile prepared for python wrapping
2710 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2711 * src/gdcmHeader.cxx :
2712 - Parsing of header is now separated from loading of element values
2713 (see gdcmHeader::LoadElements).
2714 - general clean up of hopefully all file access (creation of
2715 ReadInt16 and ReadInt32)
2717 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2718 * src/gdcmHeader.cxx :
2719 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2721 - SetLgrElem renamed to SetLength
2722 - GetLgrElem renamed to GetLength
2723 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2724 * src/gdcmElValSet.cxx fixed both GetElValue methods
2725 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2726 due to IdoDude was cleaned out.
2728 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2729 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2730 concentrates on finding the value representation (when it exists).
2731 RecupLgr now only finds the element value length, and it avoids
2732 returning the unecessary skL (skipped length).
2733 Also, offsetCourant was simply removed (with taille_fich) since
2734 it was redundant with the File position internals (by using
2735 ftell and fseek). This also made skL (see above in RecupLgr) usage
2737 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2738 on the libido specificities which are handled through class
2740 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2743 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2744 * Truckload of changes. Parsing of header is barely functional
2745 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2747 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2748 * src/gdcmHeader.cxx many addons of low level methods
2750 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2751 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2752 and _IdDcmSWAP_LONG.
2754 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2755 * This corresponds to all the changes decided at the meeting of
2756 May 23 2002. Needless to say we are running late...