1 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
3 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
4 enable_sequences removed from gdcmHeader constructor and dependencies.
5 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
6 * gdcmPython/demo/PrintHeader.py: dummy fix.
7 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
8 skip_shadow removed from gdcmHeader constructor and dependencies.
9 * Example/*.cxx and Test/*.cxx changed accordingly.
11 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
12 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
13 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
15 2004-07-21 Jean-Pierre Roux
16 * FIX Now, Parsing and Printing a DICOMDIR do work!
17 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
19 2004-07-20 Jean-Pierre Roux
20 * FIX Some brain damaged headers have Zero-Lenght fields
21 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
23 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
25 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
26 variable (instance of gdcmDebug) by a definition macro, and the instance
27 is now in static in the gdcmDebug class
28 * src/gdcmSQItem.h : (FIXME) remove an undefined method
29 * Test/PrintAllDocument.cxx : bug fix in the result of the test
31 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
32 * WARNING: ctest now depends more tightly on gdcmData. You should
33 check out gdcmData properly for things to run smoothly...
34 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
35 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
36 we need the pixels not be loaded in order to use the ValEntry
37 that displays position and size).
38 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
39 This is a C++ based equivalent of gdcmPython/testSuite.py that should
40 be deprecated. If you have any doubts about the advantages of a
41 modern scripting language (read Python) versus grass root C++ (i.e.
42 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
43 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
44 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
45 Anyhow, consider documenting the gdcmData images in
46 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
48 * Test/CMakeLists.txt:
49 - now uses TestAllEntryVerify.cxx
50 - specific comments on oldACR00001.ima (now renamed in gdcmData
51 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
52 gdcmData/TestAllEntryVerifyReference.txt
55 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
56 * src/*.[h|cxx] : typedef clean up
57 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
58 - TagKey renamed to gdcmTagKey (for external usage)
59 - VRKey renamed to gdcmVRKey (for external usage)
60 - removal of typedef duplication.
61 - Removed all unecessary inline keyword from class inline definitions.
62 - Some method|function(void) declarations replaced with method|function().
63 * src/jpeg/libijg12/jdhuff12.c:
64 - printf polluting ctest removed.
65 - TAB removal for comminting
67 - TestAllReadCompareDicom.cxx: added a test that compares all the
68 images in gdcmDataImages.h with corresponding images in
69 gdcmData/BaselineDicom/. When baseline images are not present
70 this test creates them.
71 Note: we need to validate each reference image, but before that
72 I'd like to rename them with a more explicit name...
73 - CMakeLists.txt: changed accordingly.
74 * Example/*.cxx: examples now only include gdcm.h (as opposed to
75 including each header needed).
77 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
78 * Test/*.cxx and Example/*.cxx: moved some examples away from the
79 test suite to the Example directory. Are concerned:
85 * Test/CMakeLists.txt: added some comments on reasons for black listing
86 image gdcmData/oldACR00001.ima
88 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
89 * Test/CmakeList.txt: removed the following from black list (to be coherent
90 with removal from gdcmData):
91 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
92 - gdcm-MR-PHILIPS-16.dcm
94 Added the following because after last cvs update, they cause
95 ctest -R TestReadWriteReadCompare
97 - gdcm-MR-SIEMENS-16-1.acr
99 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
100 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
101 new comments in this file) we temporarily (sigh) move to a weaker
103 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
104 we don't need to black list the following images anymore:
105 - 8BitsUncompressedColor.dcm
107 - US-PAL-8-10x-echo.dcm
108 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
109 fixes and the beautified code ;-)
110 This fixes the bug introduced in version 1.42 (when beautifying)
111 that made the parsing of 8BitsRunLengthColor.dcm unproper.
112 Note: ctest was blind to this bug (this means we need to still
113 improve the test suite). The bug could be detected by using
114 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
116 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
117 and by displaying the (garbage) produced file temp.XDCM...
119 2004-06-29 Jean-Pierre Roux
120 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
121 - replace by uggly but working old code :-(
122 A lot of things should be OK again.
123 It's really urgent to have a test suite that *tests*,
124 to prevent Frog's beautifying sessions to break all the stuff
125 (twice, withing a fortnigh ...)
127 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
128 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
129 redundancy) to added Test/TestReadWriteReadCompare.cxx
130 * Test/CmakeList.txt: because the compare test of
131 Test/TestReadWriteReadCompare.cxx fails, the following images are
132 black listed: - 8BitsUncompressedColor.dcm
134 - US-PAL-8-10x-echo.dcm
135 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
136 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
137 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
138 and ad-hoc kludge. This kludge is now removed, and on encountering
139 such an image (OB field brain damaged) we set errno. Then in
140 ::FindDocLength() we "fix" the length as being ALL what remains
141 in the file (until EOF). We then proceed, hoping for the best...
142 This fixes a SegFault in ShowDicom when trying to write such an
144 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
145 (because TestWriteRead breaks on it, after a non conformal commit?).
146 ctest now runs properly, except for MakeDicomDir (which was allways
147 broken) and the Python related stuff (still not fixed).
149 2004-06-24 Jean-Pierre Roux
150 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
151 FIX : Test/TestReadWrite now iterates on all the file names
152 (instead of infinite loop)
153 ENH : Test/TestWriteRead now iterates on all the file names
155 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
156 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
158 2004-06-24 Jean-Pierre Roux
159 FIX : - now Write drops LUT Descriptors and LUTs (if any)
160 when SamplesPerPixel =3
161 - now Write is no longer confused by
162 'BitsAllocated = 12" and 'BitsStored=12"
163 - "UN" value representation Elements are now written correctly
164 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
165 ENH : - now gdcmHeader has its own Write methods
166 (in order to split the job that has not to be done
169 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
170 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
171 loop on the same image until memory went out.
172 Note: this means we still have gobs of memory loss in PrintDocument
173 * src/gdcmDocument.cxx: fixes problem on parsing on file
174 gdcmData/16BitsJpegLosslessGrayScale.dcm.
176 2004-06-24 Jean-Pierre Roux
177 FIX : Write - All the Sequences and Sequence Item are now written
178 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
179 is added a the end, when necessary.
180 - A lot of brain-damaged images, that were read correctly are
181 now written correctly
182 - length compatible BinEntry are now loaded correctly
183 (even for odd groups)
184 Note : only Explicit Value Representation was checked.
185 (question : is implicit VR really necessary for gdcm ?)
187 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
188 * DEVELOPPER: added a proposition of coding style.
189 * src/gdcmDocEntry.h: removed every inline declaration (for test of
192 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
193 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
194 Use the gdcmDocEntry::Print() and Write() instead.
195 * src/gdcmDocument.cxx: bug fix.
197 2004-06-22 Jean-Pierre Roux
198 FIX : gdcmDocument.cxx
199 - Now we do recognize the JpegLossLess format (there was a misstyping in
200 code 'beautyfication' :-(
201 - Now we automaticaticaly load the Luts, if any
203 2004-06-22 Jean-Pierre Roux
204 In order : to write Sequences, whatever their imbrication level,
205 : to allow user to create his own Sequences
206 a lot of modif where necessary (adding, moving, or virtualising methods)
208 WARNING : save your own sources *before* cvs up !
211 ADD virtual void Write(FILE *fp, FileType filetype);
214 ADD virtual void Write(FILE *fp, FileType filetype);
215 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
218 ADD virtual void Write (FILE *fp, FileType filetype)=0;
219 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
220 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
221 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
222 ADD std::string GetEntryByName(TagName name);
223 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
225 std::string vr = "unkn",
226 std::string fourth = "unkn",
227 std::string name = "unkn");
228 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
229 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
230 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
231 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
232 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
233 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
234 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
235 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
238 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
239 ADD virtual std::string GetEntryByName (TagName tagName);
240 ADD virtual std::string GetEntryVRByName (TagName tagName);
241 REM virtual bool Write(FILE *, FileType);
242 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
243 FILE *_fp, FileType type);
244 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
245 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
246 REM virtual bool WriteEntries(FILE *_fp,FileType type);
247 REM virtual std::string GetEntryByName (std::string tagName);
248 REM virtual std::string GetEntryVRByName (std::string tagName);
249 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
250 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
251 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
253 std::string vr = "unkn",
254 std::string fourth = "unkn",
255 std::string name = "unkn");
256 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
257 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
258 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
259 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
262 ADD virtual void Write(FILE *fp, FileType filetype);
265 ADD virtual void Write(FILE *fp,FileType filetype);
268 ADD virtual void Write(FILE *fp, FileType filetype);
269 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
270 REM std::string GetEntryByNumber(guint16 group, guint16 element);
271 REM std::string GetEntryByName(TagName name);
274 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
276 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
277 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
278 The default constructor invoked by the line
279 gdcmHeader *f1 = new gdcmHeader( header );
280 was gdcmHeader::gdcmHeader(bool) instead of the expected
281 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
282 Hence the parsing wasn't executed... See also below.
283 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
284 as explicit constructor didn't do the trick to fix the above problem.
285 Could anyone explain why ?
286 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
287 properly calls gdcmValEntry::Print() (that was weed out from
288 code related to gdcmBinEntry).
290 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
291 * In order to fix memory leaks:
292 - Test/TestWriteSimple.cxx: added cleaning of free store through
294 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
295 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
296 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
297 (through the call to ::AddDicomDirMeta()) or the destructor
298 would crash when deleting uninitialized ::metaElems].
299 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
300 - src/gdcmDocument.cxx:
301 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
303 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
304 was causing memory leaks.
305 - src/gdcmSQItem.cxx:
306 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
307 cleanly handled with polymophism: sorry but my milage is low).
308 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
309 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
310 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
311 This avoids SegFaulting.
312 - src/gdcmSQItem.h: coding style.
314 - Test/TestWriteSimple still severely sucks. The output image content
315 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
316 damaged when displayed with vtkgdcmViewer.
317 - on memory leaks: TestWriteSimple leaks really less (see entry
318 of 2004-06-18 in Changelog file for the call to valgrind).
319 - on segfaults: ctest now passes all the tests but one (no more
321 * Erroneous leading white fix:
322 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
323 white[s] (as opposed to from >> xxx, that removes it [them].
324 - src/gdcmTS.cxx: ditto.
325 - gdcmPython/testSuite.py: dirty related kludge removed.
326 * src/*: remaining references to gdcmParser removed.
327 * src/*[cxx|h]: added copy[way]left header.
330 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
331 * In order to fix writing of dicom files:
332 - Test/TestWriteSimple.cxx: a simpler example of writing.
333 - Test/CMakeLists.txt changed accordingly.
334 - src/gdcmDocument.cxx:
335 -- The destructor now recursilvely removes potential sequences.
336 -- Bug fix in ::IsJPEG2000()
337 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
338 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
340 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
341 to only declared) and build on top of
342 ::GetDocEntryByNumber(guint16, guint16).
343 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
344 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
345 for usage in destructor and treatement of promotion in
346 ::ReplaceOrCreateByNumber().
347 - src/gdcmSQItem.cxx: destructor should better handle his job.
348 Test/TestWriteSimple now runs (or at least it DOES something).
349 * We can now start hutting memory links. A good starting point is:
350 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
351 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
352 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
354 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
355 * Valgrind note: after Mathieu Malaterre teached me how to read
356 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
358 Using gcc, you can force the STL to use malloc and to free memory as
359 soon as possible by globally disabling memory caching.
360 With 3.2.2 and later, you should export the environment variable
361 GLIBCPP_FORCE_NEW before running your program.
362 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
363 simply vanish (it is still not clear to me, whether this means that
364 STL std::string leaks or if valgrind believes it leaks...).
365 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
366 running bin/gdcmTests makeDicomDir):
367 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
368 - Test/makeDicomDir.cxx now properly traps empty lists and returns
370 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
371 SegFaulting (I drowned in DicomDir related code when trying to
372 understand why the list is empty...).
373 * src/gdcmDocument.h: first BSD license header try.
374 * Doc/License.txt added.
376 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
377 * src/gdcmDocument.[h|cxx]:
378 - Clean up of the Transfer related predicates. They are now all based
379 on new method isGivenTransferSyntax, that (should) handle properly
381 - general clean up, simplification, and coding style.
382 - Specific clean up of Parse7FE0() (umproperly named actually).
383 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
385 2004-06-14 Jean-Pierre Roux
387 - fix the display of Sequence Delimitor (SQDepthLevel pb)
388 - fix the display of SQItem ordinal number
389 - add the GetSQItemByOrdinalNumber method
390 - remove some useless never written private methods
392 2004-06-14 Jean-Pierre Roux
394 - adding a constructor taking a gdcmDocEntry as an input param
395 - ReplaceOrCreateByNumber now returns :
396 a gdcmBinEntry * if a Binary (void *) value is passed as a param
397 a gdcmValEntry * if a string value is passed as a param
399 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
400 according to the param type (no longer sets a gdcmDocEntry)
401 - GetValEntryByNumber, GetBinEntryByNumber added
402 - NewValEntryByNumber and NewBinEntryByNumber added
404 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
406 - GetSQItemNumber and SetSQItemNumber added, to provide
407 a (relative) Item identier inside a given Sequence
408 \warning : some pb remaining around this number
410 - AddEntry now takes the Item Number as a param
412 - adding a constructor taking a gdcmDocEntry as an input param
414 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
415 * Memory leak hunt with the following command:
416 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
417 --show-reachable=yes gdcmTests PrintDocument
418 It looks like many (all?) leaks are due to the STL (or a bad usage
419 of the STL. The lines producing the leaks now have a comment with
420 a "MEMORY LEAK" tag: you can retrieve them with
421 grep "MEMORY LEAK" src/*
422 Here are two typical examples which I can't help fixing:
427 char * test = "babo";
428 name = test; //// <--- valgrind detects 960 bytes lost in
429 //// call to std::string::operator=(char const*)
430 name.clear(); //// Doesn't help !
438 std::cout << "Type a bunch of characters followed by RETURN: ";
439 getline(std::cin, line); //// <--- valgrind dectects a loss
440 //// of 1320 bytes in call to
441 /// std::basic_istream<>& std::getline<>
447 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
448 * src/gdcmHeader.[cxx|h]:
449 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
450 and related, moved away to gdcmDocument.
451 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
452 the corresponding protected accessors of inherited class
453 gdcmDocument, removed ! As a consequence gdcmFile had to be
454 declared friend of class gdcmDocument (see below).
455 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
456 - Clean up of undefined or unused methods.
457 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
458 account the changes to gdcmHeader.h).
459 * src/gdcmDocument.h:
460 - gdcmFile is now a friend class (in order to take into account the
461 changes to gdcmHeader.h).
462 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
463 (see changes to gdcmHeader.h).
464 - Accessors (reading on the form GetEntry*) are now public.
465 - Clean up of undefined or unused methods.
466 * src/gdcmDocument.cxx:
467 - adaptation to changes to gdcmDocument.h
468 - ::OpenFile now writes a verbose message when file cannot be opened.
469 - some std::string properly set to VRKey
470 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
471 references to gdcmDocument.
472 * Test/TestFindTags.cxx: changed accordingly to above changes.
473 * gdcmPython/testSuite.py: adapted to renaming of acr files in
474 cvs repository gdcmData.
476 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
477 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
478 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
479 conflicts with gdcmValEntry::voidArea.
480 * src/gdcmValEntry.cxx: unmatching comment wiped out.
481 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
482 Value representation between StringRepresentable and BinaryRepresentable.
483 * src/gdcmDocument.cxx:
484 - method ParseDES: proper indentation restored and usage of
485 gdcmVR::IsVROfGdcmStringRepresentable wired in.
486 - method LoadDocEntry: the fingerprint left in the SetValue() of
487 unloaded entries (length > MaxSizeLoadEntry) had curiously been
488 removed. Reverting to previous code segment with the proper
489 dynamic_cast< gdcmValEntry* >.
490 Note: this was (partially) breaking the python test suite
491 (gdcmPython/testSuite.py) that made usage of the above
492 fingerprint to check presence of "Pixel Data".
493 * src/gdcmDocEntry.h: coding style.
494 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
495 now taken into account.
496 * gdcmPython/gdcm.i: adaptation to the new internal representation
497 of gdcm (exit gdcmParser, hello gdcmDocument).
498 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
500 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
501 anymore, but instead prints the loaded Python dictionary.
502 * .... alas, the python testSuite is still broken.
504 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
505 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
507 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
508 * src/gdcmUtil.h : export methods
510 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
511 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
513 * Initial addition of automatic python testing
514 * Initial addition of automatic image comparison
516 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
517 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
518 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
520 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
521 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
522 * Test/ShowDicom.cxx : bug fix for msvc compilation
523 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
525 2004-05-04 Jean-Pierre Roux
526 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
527 new concepts (and new classes) :
528 a 'gdcmDocument' is composed of a set of Doc Entries, that are
529 - elementary gdcmDocEntries (former gdcmHeaderEntries)
530 - Sequence Doc Entries (gdcmSeqEntries)
531 a Sequence is composed of Items.
532 Each item is a set of Doc Entries (this is recursive)
533 The non uniqueness of the 'Dicom tag' is due to this recursivity
534 (never taken into account)
535 Our unability to add a new 'entry' in the header
536 at the proper location (neither in the H-Table (map or multimap),
537 nor in the Chained List is also due to this recursivity.
538 Don't try, right now, to use/modify/compile these new sources :
540 We just commit all the stuff, 'as is', in order not to loose it.
542 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
543 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
545 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
546 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
547 file prefix (SetFilePrefix)
549 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
550 * Add a new test: ShowDicom, for now this is just the c++ version of
551 checkRead.sh, later it will be able to compare the image read against a
553 * Replace the DEBUG on the stack with a global entry in cmake interface:
554 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
556 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
557 * Add an example subdir, with a real example on how to read + write a
560 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
561 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
562 * Doc/CMakeLists.txt: the main page is now properly differentiated
563 between the developper and user version.
564 * Doc/doxygen.config.in: dropped search related obsolete flags
565 * src/gdcmParser.h, gdcmHeader.h: doxygenation
567 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
568 * DEVELOPPER: added some helpfull comments for compile/test/install
571 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
572 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
573 src directory, now generated in the build dir.
574 2. Tests as mentionned smarter
576 4. Add a new method in gdcmDict that return the PubDict by name
577 this is interesting for 3rd party lib like ITK,
578 where we could set the institution name / patient name...
580 * ENH: 1. Now the test suite is working for real
581 2. All binaries are now output in the gdcm-bin directory
582 (this was not true before)
584 2004-04-28 Jean-Pierre Roux
585 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
586 SeQuence indented printing of Dicom Header.
587 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
588 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
589 Computation of SQDepthLevel is now part of gdcmHeader constructor
590 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
591 tree-like structure of a Dicom Header.
592 * FIX Test code cleaning
594 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
595 * ENH: Adding automatic testing
596 1. Need a DartConfig.cmake to submit to public
597 2. Add a test driver gdcmTest.cxx
598 3. gdcmTestMain, an helper for the main test driver gdcmTest
599 4. Files in Test don't have a main anymore, this becomes interesting
600 when we add more and more tests, thus dsw don't have to load
602 * ENH: Adding a GDCM_DATA_ROOT for testing
603 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
604 one file instead of seven + some small cleanup
606 2004-04-22 Jean-Pierre Roux
607 * ENH Minor changes to the Print() methods.
608 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
609 Header printing. Example given with :
610 > PrintHeader fileName 2 new
611 (SQ based tree-like structure still to be done for the Header ...)
613 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
614 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
615 1. I have added some unsigned where needed
616 2. Some function parameter not used -> (void)
617 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
618 4. g++ don't like character '\' in comment
619 5. #define jpeg_create_decompress jCreaDecompress
620 this really need to be fixed
621 6. virtualize destructor of gdcmObject ... leakage
622 7. sscanf(g->first.c_str(),"%x",&gr_bid);
623 this also really need to be fixed
624 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
625 remove compression file
626 (as we only do decompression, right ?)
627 * ENH: Change malloc/calloc/free with c++ equivalent
629 2004-04-21 Jean-Pierre Roux
630 * FIX gdcmHeaderHelper::GetXSpacing
631 when a single value is found (bug ?), xpacing is now
632 defaulted to yspacing
634 2004-04-19 Jean-Pierre Roux
635 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
636 * ENH add parameters :
637 bool exception_on_error = false,
638 bool enable_sequences = false,
639 bool ignore_shadow = false
640 to the gdcmFile constructors to be full gdcmParser compliant
641 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
642 to allow reading of PAPYRUS 3.0 files
644 2004-04-06 Jean-Pierre Roux
645 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
647 2004-04-02 Jean-Pierre Roux
648 * ADD : Test/checksequence.sh, for a general recap on SQ pb
649 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
650 for Philips spurious Tag fffe|0000 while rewritting Dicom files
652 2004-03-30 Jean-Pierre Roux
653 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
654 for ACR file, written out as DICOM files (hope so...)
656 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
657 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
658 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
659 moved to base class gdcmParser and only the specialisation is kept
661 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
662 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
663 already does the job.
664 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
665 (to be consistent with gdcmParser::WriteEntries).
667 2004-03-30 Benoit Regrain
668 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
669 upate of the object's instance. It's passed to 2 in the unfavorable
670 case : one in the ExecuteInformation, one in the ExecuteData
672 2004-03-29 Jean-Pierre Roux
673 * ENH : Check on file type to be written moved
674 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
675 * FIX : gdcmObject::ResetBoundaries now stops properly
676 when end-of-list is reached
677 : gdcmVersion modified (as Benoit Regrain asked)
679 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
680 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
681 * src/gdcmUtil.cxx: added forgotten iostream include.
682 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
683 equivalent to ExplicitVR in existing code).
685 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
686 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
687 now contains all the gdcmGlobal related code.
688 * minor coding style and doxygenation changes.
690 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
691 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
692 now contains all the Debug related code.
693 * minor clean-up of includes in src/*.cxx
694 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
695 CreateCleanString) removed.
696 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
697 * Doc/DoxyMainPageUser.txt added.
698 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
699 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
702 2004-03-24 Jean-Pierre Roux
703 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
705 2004-03-23 Jean-Pierre Roux
706 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
707 big endian made volumes
708 * ENH Now gdcmParser constructor and destructor are protected to forbid
709 end user to instanciate class gdcmParser
710 (only gdcmHeader and gdcmDicomDir are meaningfull)
712 2004-03-22 Benoit Regrain
713 * FIX : src/gdcmDicomDir.cxx : make windows compilable
714 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
715 gdcmSerie to gdcmDicomDirSerie
717 2004-03-19 Jean-Pierre Roux
718 * ENH Now the tree-like structure describing a DICOMDIR comming from
719 an already existing DICOMDIR file is consistent with
720 the home-made tree-like structure build ex-nihilo
721 or build from the files held (recursively) in a Directory
722 functions gdcmDicomDir::CheckBoundaries()
723 gdcmObject::SetBoundaries() added
725 2004-03-17 Jean-Pierre Roux
726 * REM (Eric Boix bug) : removal of meaningless
727 gdcmDicomDirImage::NewImage function.
728 * FIX now file names and directory name are written properly in the
730 * FIX now gdcmDicomDir constructor may be call without any trick
733 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
734 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
735 of gdcmDicomDirImage::NewImage as empty function.
737 2004-02-28 Jean-Pierre Roux
738 * ENH add gdcmDicomDir:NewPatient
739 add gdcmDicomDirPatient:NewStudy
740 add gdcmDicomDirStudy:NewSerie
741 add gdcmDicomDirSerie:NewImage
742 to allow making gdcDicomDir object.
743 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
744 (as opposite to the gdcmHeader chained list)
746 2004-02-11 Benoit Regrain
747 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
748 when using from python
750 2004-02-10 Benoit Regrain
751 * FIX : bug fix in the gdcmDirList for the recursivity in directories
752 * FIX : in gdcmDicomDir when the directory is empty
753 * ENH : add callback and methods to get the progression of dicomDir
756 2004-02-06 Jean-Pierre Roux
757 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
758 - GDCM_META added to gdcmDicomDirType
759 - class gdcmMeta created
760 * ENH : - A brief summary is now displayed at the beginning of
761 'testDicomDir' to help disaster magnitude estimation
762 * REM : Now useless Test/explDICOMDIR.cxx
764 2004-02-05 Benoit Regrain
765 * ENH : add methods in gdcmObject to get the hash table or the list of
767 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
768 * FIX : wrapping python for TagHeaderEntryHT
770 2004-02-04 Benoit Regrain
771 * FIX : even length for some strings when writting the dicom dir
772 * FIX : sort the images in the dicom dir
773 * FIX : Bug fix for python use of dicom dir
774 * ADD : a python demo
776 2004-02-04 Jean-Pierre Roux
777 * FIX : Final solution (?) for icone embedded images
778 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
779 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
780 add groups 6002, 6004, 6006, to allow 'clean' parsing of
781 gdcmData/gdcm-MR-SIEMENS-16.acr1
782 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
783 to make full checking easier
785 2004-02-04 Benoit Regrain
786 * FIX : WriteEntries : coding style & logic in parameters
787 * FIX : Set the elements to create the DicomDir in a dictionary file
789 2004-02-03 Benoit Regrain
790 * gdcmDirList : to parse a hard drive directory in recursive (or not)
791 * gdcmDicomDir : add the load of directory
792 * Bug fix and print add-on
794 2004-02-03 Jean-Pierre Roux
795 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
796 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
797 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
798 * FIX gdcmParser.cxx : 'group length' elements are now considered
799 as integers, even for shadow groups, when file is Implicit VR
801 2004-02-02 Jean-Pierre Roux
802 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
804 of the last synonym :-(
805 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
807 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
808 * FIX taking into account the possible 7fe0,0010 multiplicity
809 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
810 to allow removal of references to 7fe0,0010, to deal with
811 ACR-NEMA images, when 0028,0200 is meaningfull
813 2004-01-31 Jean-Pierre Roux
814 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
815 no longer writes 'Un' on disk
816 * FIX SQ elements with actual length are now dealt with corectly
817 * FIX gdcmFile::WriteBase make the difference, for color images, between
818 the length (for Palette expanded images)
819 and Raw Length (non expanded image + Palette)
820 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
821 (that broke Write). Replaced by UL.
822 Aware user will reload the field if he
823 thinks it's necesssary
825 2004-01-30 Jean-Pierre Roux
826 * gdcmParser::CheckSwap() now defaults the filetype to ACR
827 when 'dirty Acr' is found, to be compliant with the new
828 IsReadable() methods.
830 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
831 (no DOUBLE images in kosher DICOM,
832 but so usefull for people that miss them ;-)
834 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
835 DICOMDIR related utilities (not checked as Windoze compliant)
837 2004-01-28 Jean-Pierre Roux
838 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
840 2004-01-27 Jean-Pierre Roux
841 * gdcmParser constructor has a new boolean param,'ignore_shadow',
842 to allow skipping the shadow elements, to save memory space.
843 The TRUE value for this param has to be used
844 with a FALSE value for the 'enable_sequence' param.
845 ('public elements' may be embedded in 'shadow Sequences')
846 * gdcmHeader methods now deal with 'embedded icones images' in the header
847 (even when an 'icone image sequence' is announced by the
848 element (0x0088,0x0200), but there is NO icone at all ...
850 * gdcmHeader sometimes Image Location value doesn't follow
851 the supposed processor endianity (see gdcmData/cr172241.dcm).
854 * gdcmHeader add the method
855 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
856 to get *all* the Header Entries with the same tag.
857 GetHeaderEntrySameName is probabely *useless*
858 (no meaning : Name is *not* an identifier within the Dictionnary)
860 2004-01-26 Benoit Regrain
861 * Bug fix in the print of hexadecimal representations. Remove long fields
862 in the print and add a third level of print to print them
864 2004-01-23 Benoit Regrain
865 * Bug fix on field having a VR = 'UI'. Assume that is a string field
866 * Bug fix on test suite after remove the strip made on not string fields
867 * Split the IsReadable method between gdcmParser which test that the file
868 is dicom and gdcmHeader which test that it's an image file
870 2004-01-22 Benoit Regrain
871 * DicomDir : clean code, add methods, set variables in protected or private
872 * gdcmUtil : bug fix for the clean string method
874 2004-01-19 Benoit Regrain
875 * Add the use of shadow dictionaries
876 * bug fix and coding style
878 2004-01-19 Benoit Regrain
879 * src/gdcmFile.cxx : bug fix concerning the close of file
880 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
881 * Add the update of header entries using the shadow library
883 2004-01-19 Benoit Regrain
884 * removal of file gdcmHeader2.cxx
885 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
886 inheriting from gdcmParser. This split is to prepare the integration
888 * bug fix under python
890 2004-01-16 Jean-Pierre Roux
891 * REM removal of class gdcmHeaderEntrySet
892 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
893 * ADD add file gdcmHeader2.cxx
894 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
896 2004-01-15 Benoit Regrain
897 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
898 entries created while parsing the header. Thus, they will be destroyed
899 when the gdcmDictSet will be destroyed
900 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
903 2004-01-15 Benoit Regrain
904 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
905 made a fatal error because of the memory release at the end of program.
906 The problem was in vtkGdcmReader::ExecuteData where we were allocate
907 some memory and vtk seems to have some problems with that.
908 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
910 2004-01-14 Benoit Regrain
911 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
912 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
913 * src/*.[h|cxx] : make changes due to class name changes
914 * gdcmPython/demo/*.py : bug fix due to method names
916 2004-01-13 Benoit Regrain
917 * src/*.[h|cxx] : coding style
918 * vtk/*.[h|cxx] : coding style
920 2004-01-13 Benoit Regrain
921 * gdcmPython/testSuite.py : test the readable flag of file for tests
922 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
923 It's lied to the stl compilation by MSVC (windows, always windows...)
924 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
926 2004-01-12 Benoit Regrain
927 * src/*.h : add comments
928 * src/gdcmDictSet.h : set the method BuildDictPath in public
929 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
930 directly setted in the source code
931 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
934 2004-01-09 Benoit Regrain
935 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
936 * setup.py : use a reference to gdcmVERSION
938 2004-01-07 Benoit Regrain
939 * Modification to compile with the distutils.
942 2003-12-10 Benoit Regrain
943 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
944 can use a gdcmHeaderHelper to load datas
945 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
946 made in the source code
948 2003-12-10 Benoit Regrain
949 * Update Windows projects and .cvsignore files
951 2003-11-12 Jean-Pierre Roux
952 * ENH gdcmHeader constructor has one more parameter (default value : false)
953 that allows the user to 'go inside' the SeQuences only
955 gdcmElValSet:Print takes it into account
957 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
958 * ENH: Update gdcmPython/CMakeLists
959 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
960 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
962 2003-11-10 Jean-Pierre Roux
963 * FIX : gdcmHeader::LoadElements is now based
964 on the ListTag listElem member,
965 not longer on the TagElValueHT tagHt member
966 * ENH : PrintPubElVal shows (temporarily) both results,
967 with the tagHt member and the listElem member.
968 (it's easier to 'see' the problems when using Printheader)
970 * FIX : old private member LgrElem is now splitted into
971 ReadLength : Length actually found on disk (updated only
972 if bug fixing is necessary), for internal
974 UsableLength : Updated by FixFoundLength, to fix a bug
975 or to allow Parser going on.
976 Will allow to re-write a kosher header when a SeQuence
977 with a length (not 0000) is found
978 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
979 because gdcmElValSet::Add does not update ListElem
982 2003-11-07 Jean-Pierre Roux
983 * FIX misstyping in Transfert Syntax name table
984 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
985 when they have an actual length (not 0000 nor FFFFF)
986 (Nobody should care of it, but DICOMDIR explorers)
988 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
989 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
991 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
992 * ENH: vtkGdcmReader now supports LUT !
993 (vtkgdcmViewer for now is not able to use them though)
995 2003-11-05 Jean-Pierre Roux
996 * in testSuite.py : new files names for checking the package
997 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
998 that returns the pixel area size to the *aware* (vtk) user
999 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1001 2003-11-05 Benoit Regrain
1002 * in testSuite.py : Modify the rules for checking the paths
1003 : Explicit error messages
1004 * in __init__.py : Related modif
1006 2003-11-03 Jean-Pierre Roux
1007 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1008 to be used by aware (vtk) users that want to manage
1009 LUT (and no to turn the PALETTE image into an RGB pixels one)
1010 * GetPixelType now returns 8U for 24 Bits images
1011 (vtkGdcmReader compliant)
1013 2003-10-31 Jean-Pierre Roux
1014 * Removal of *all* gdcmData images and add them again
1015 in order to loose the 'history' of un-anonymised images
1017 2003-10-31 Jean-Pierre Roux
1018 * RMV : removal of useless jBitsInJsample.h
1019 for both 8 and 12 Bits JPEG Lossy Libraries
1021 2003-10-31 Jean-Pierre Roux
1022 * ENH : Add the functions gdcmFile::GetImageDataRaw
1023 gdcmFile::GetImageDataIntoVectorRaw
1024 that act as GetImageData and GetImageDataIntoVector
1025 except the making of an RGB Plane from Gray Plane + LUT
1026 Intended to aware (vtk) users who know how to manage
1029 GetLUTRGBA return a R,G,B,A LUT if any
1030 lgrTotaleRaw gives the 'Raw' length
1031 GetImageDataRaw returns the gray Plane
1032 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1033 (They stay Grey, just like with other Dicom viewers :-(
1035 2003-10-30 Jean-Pierre Roux
1036 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1038 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1039 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1040 being coherents dicom files.
1042 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1043 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1045 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1046 * ENH: Two steps is necessary to please VC++ compiler...
1047 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1048 * ENH: Add include dir to medcon lib
1049 * FIX: only one function is being exported for now !
1050 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1052 2003-10-29 Jean-Pierre Roux
1053 * adding gdcmHeader::GetLUTRGBA
1054 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1055 --> Mathieu, the modif u're waiting for is not yet committed
1056 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1058 2003-10-27 Jean-Pierre Roux
1059 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1060 00191113.dcm DermaColorLossLess.dcm
1061 MxTwinLossLess.dcm RadBWLossLess.dcm
1062 * ENH: For version prior to vtkImageViewer2 -r 1.19
1063 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1065 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1066 * Removal of ido stuff in CMakeLists.txt
1068 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1069 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1070 * FIX: remove a call to ->Modified ... see comments
1071 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1073 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1074 * FIX: Problem with path for libvtkgdcmPython
1075 * ENH: Try adding a search script for python site-package
1076 * RMV: Remove some file from medcon lib that are not necessary
1077 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1078 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1079 * FIX: More pragma disable fro VC++,
1080 I don't think I break something as it is also disable in VTK/ITK.
1081 But it fasten debug compilation time.
1083 2003-10-23 Jean-Pierre Roux
1084 * gdcm now deals with 16 Bits Run Length Encoded images
1085 (they are compressed as 2 planes images,
1086 one for the high Bytes, the other for low Bytes)
1088 2003-10-22 Jean-Pierre Roux
1089 * Now CheckRead takes into account :
1090 - the bugged 'Leonardo' Siemens images
1091 - the XA images, sent thru the burning VPRO station
1092 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1095 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1096 * FIX: When copying a Makefile.am to CMakeLists.txt
1097 one should remove the '\'
1099 2003-10-22 Jean-Pierre Roux
1100 * in gdcmData adding a bugged 'Leonardo' Siemens image
1101 (wrong lengths in header)
1102 OK with gdcm, KO with the other viewers :-)
1103 * add a GE dlx XA image, thru the VEPRO burning station
1106 2003-10-21 Jean-Pierre Roux
1107 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1108 for a brutal checking of vtkgdcmViewer compliance
1110 2003-10-21 Jean-Pierre Roux
1111 * add the files for 'xmedcon' Jpeg Lossless library
1112 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1114 2003-10-21 Jean-Pierre Roux
1115 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1117 2003-10-21 Jean-Pierre Roux
1118 * garbage Siemens 'Leonardo' images dealt with
1119 (the patch is easy to remove)
1120 * cosmetic changes to avoid warnings
1122 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1123 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1124 no need to press 'r' now.
1126 2003-10-20 Jean-Pierre Roux
1127 * upgrade of checkRead.sh checkWrite.sh according
1128 to new Jpeg Lossless decompressor
1129 * add US.3405.1.dcm, a genuine RGB medical file ...
1130 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1131 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1133 2003-10-15 Jean-Pierre Roux
1134 * general anonymisation in gdcmData
1135 * adding the 'color files' from
1136 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1137 * adding some well knowed bugged-header images
1138 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1139 waiting for their inclusion in Python testsuite
1141 2003-10-15 Jean-Pierre Roux
1142 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1143 no longer seg faults when file is not found
1145 2003-10-14 Jean-Pierre Roux
1146 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1149 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1150 * TODO: *.in file to genereate a UseGDCM later
1152 2003-10-14 Jean-Pierre Roux
1153 * Some supposed-to-be Dicom Images have no preamble.
1154 OpenFile takes it into account
1155 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1156 * Missing elements added in dicomV3.dic
1157 (just to be affraid : have a look at
1158 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1159 and do it again next year ;->
1161 2003-10-13 Jean-Pierre Roux
1162 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1163 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1164 But there are NOT. It's fixed !
1166 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1167 * FIX: "jpeglib.h" was not found on VC++
1168 * FIX: vtkgdcm was not being installed
1170 2003-10-10 Jean-Pierre Roux
1171 * ENH : OpenFile closes the file if it *really* doesn't look like
1172 an ACR-NEMA / DICOM one.
1173 * FIX : testWrite no longer writes an empty file if the source file
1174 is not gdcm Readable
1175 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1178 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1179 * FIX: CMake generate now documentation
1180 * ENH: out of source doc build !
1181 * ENH: Generate both user and dev documentation
1182 * ENH: Should work on windows too
1183 * ENH: Only one doxygen config.in file is needed
1184 * FIX: make install should be ok now on ùnix plateform
1185 * FIX: PATH to dictionary was wrong (missing /)
1186 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1188 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1189 * vtkGdcmReader is now able to read rgb dicom file.
1190 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1191 * added a gdcmViewer to vtk test, use mouse to control
1192 window level & window width
1194 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1195 * CMake-ification of gdcm, we have now two build system
1196 * FIX: on cygwin Wsock32 doesn't exist
1197 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1199 2003-10-06 Emanuel Ollart
1200 * FIX : compilation process wad broken.
1201 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1203 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1204 * change gdcmViewer -> vtkgdcmViewer
1205 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1207 2003-10-06 Jean-Pierre Roux
1208 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1209 ( e.g : well known GE images with a wrong elem length,
1210 : Philips MRI Images with a wrong Huffman table)
1211 * still to be done : allow the reading of bugged LEONARDO Siemens images
1213 2003-10-03 Jean-Pierre Roux
1214 * Odd length strings are padded with '\0' (not with spaces,
1215 to remain compliant with already defined strings,
1216 like Transfert Syntax UID and others)
1218 2003-10-03 Jean-Pierre Roux
1219 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1220 to allow displaying RGB images (not only by affim ;-)
1222 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1223 * vtkGdcmReader is now able to read rgb dicom file.
1224 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1226 2003-10-03 Jean-Pierre Roux
1227 * A few nasty patches to allow the reading of a lot of nasty images
1228 ( e.g : well known GE images with a wrong elem length,
1229 : Philips MRI Images with a wrong Huffman table)
1230 * still to be done : allow the reading of bugged LEONARDO Siemens images
1232 2003-10-03 Jean-Pierre Roux
1233 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1235 2003-10-03 Jean-Pierre Roux
1236 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1237 to allow displaying RGB images (not only by affim ;-)
1239 2003-10-03 Jean-Pierre Roux
1240 * gdcmFile::GetImageDataIntoVector now
1241 - deals with MultiFrames MultiFragments Run Length Encoded files
1242 - deals with YcBcR (YBR_FULL) files
1243 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1244 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1246 (no sample found :-(
1248 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1249 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1250 Two reasons: - clear things
1251 - third parties acces gdcm through header files, so won't
1252 suffer anymore VC++ complains
1254 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1255 * add argv[1] in testvtkGdcmReader.cxx
1258 2003-09-24 Jean-Pierre Roux
1259 * The lines are now eigthy characters long.for
1260 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1262 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1263 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1264 char* to std::string. Thus, the use of strdup becomes useless. (see
1265 previous commis of Malaterre)
1266 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1267 before the last Malaterre's commit.
1269 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1270 * This commit should fix the Debug building under VC++, the problem
1271 was mainly a mixture of debug and release lib being loaded at startup.
1272 * I also remove a depency to a specific C function: strdup. Because I had
1273 to force the link to msvcrtd (whereas strdup is in libc).
1275 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1276 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1277 located in the gdcmCommon.h file. All use of reference of tha has been
1278 changed to now use the variable GDCM_UNFOUND.
1280 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1282 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1283 Dicom dictionary. The test suite can now be run again. Note:
1284 I'm note very happy with the " (RET)" changes. I believe this
1285 RETAINED comment should be dropped when parsing the dictionary.
1286 - PACKAGER corrected
1288 - AUTHORS updated and now in alphabetical order
1289 * Makefile.am now exports gdcm.dsw for Windoze users.
1291 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1292 * cygwin complains about missing std:: in subdir Test/
1294 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1295 * remove some methods that are now in gdcmHeaderHelper
1297 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1298 * vtkGdcmReader set spacing and origin correctly
1300 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1301 * Fix a few delete/delete[] mismatch
1303 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1304 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1305 interpretation to data given by gdcmHeader. For instance there are
1306 heuristics to get informations (look at different places).
1307 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1308 sorting DICOM images based on different strategies.
1309 * modified Makefiles accordingly.
1311 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1312 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1313 when building in debug mode
1314 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1315 src/win32/gdcmdll.dsp
1316 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1318 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1319 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1322 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1323 * src/win32/libgdcmjpeg12.dsp was not dos format
1324 * src/win32/libgdcmjpeg12.dsp :
1325 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1326 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1328 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1329 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1331 * src/gdcmFile.cxx : bug fix in affectation type
1332 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1333 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1334 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1335 symbols... future problem ?
1337 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1338 * src/win32/libgdcmijpeg12.dsp was missing
1339 * modified gdcm.dsw accordingly
1341 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1342 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1344 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1345 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1346 commit of JPR (before his hollidays to facilitate our work).
1347 * setup.py : bug fix in code. Modifications made while the last commit
1348 of JPR. The code hasn't been tested before the commit... it's so
1349 useless to make that (for best programmer that is JPR) !!!
1351 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1352 * tagged the current version as Version0_3 (i.e. version 0.3)
1354 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1355 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1356 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1357 * *.dsp : modifications to use new libgdcmijpeg8 library
1358 * setup.py : bug fix on VTKPATH variable
1359 * PACKAGER : adding all concerning windows
1361 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1362 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1364 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1365 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1366 test suite reported error.
1367 * PACKAGER file added (describes what a packager must do when
1368 packaging a new release).
1369 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1370 * configure.in: upgraded version number to 0.3.0
1371 * fixing build of rpm (through rpm -ta):
1372 - Doc/Makefile.am exports proper doxygen files
1373 - src/jpeg/libijg8/Makefile.am exports the include files.
1375 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1376 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1377 * src/gdcmHeader.h : formatting code
1379 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1380 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1381 We were obtaining error message from vtk. Now, creation of file list
1382 is made in an internal list to prevent this problem.
1383 Bug fix when output is empty.
1384 Bug fix in update of progress value. Previous commit for this was a bad
1386 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1388 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1389 * src/gdcmHeader.h : added method to get the file name
1390 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1391 files. Added method to remove all files on the input
1392 Added FIXME comment concerning the bad parsing of header made by
1393 ExecuteInformation method (in ExecuteData method)
1395 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1396 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1397 when using make instal.
1398 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1399 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1401 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1402 * setup.py : adding include dir of jpeg lib to compile all sources
1403 * */Win32/*.dsp : JPR fix for windows compilation
1405 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1406 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1408 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1409 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1411 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1412 * setup.py is again effective on un*x (takes into account the
1413 addon of the jpeg library)
1414 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1415 * Doc/Doxy* updated (includes above enhancements)
1416 * INSTALL now points to web documentation
1418 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1419 * src/gdcmHeader.h doesn't make unnecessary reference to
1421 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1423 * src/gdcm*.[cxx|h] :
1424 - to allow compilation with gcc 3.x
1425 -- clean up of STL usage (added explicit usage of std::)
1426 -- small fixes on exceptions.
1427 Note: linking not tested !
1428 - clean of doxygen comments to avoid warnings at documentation
1430 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1431 dependent convertion).
1433 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1434 * Clean up of previous JPR garbage commit (not even commented in the
1436 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1437 - moved all jpeg related files from src to src/jpeg/libijg8, with
1438 addition/modification of Makefile.am and configure.in.
1439 - the testSuite is still brain damage (not guilty).
1441 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1442 * WrapVTK.py : modifications to get correctly vtk source files to
1444 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1445 (FileName -> Filename)
1447 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1448 * vtk/vtkGdcmReader.[cxx/h]:
1449 - UpdateProgress method should now be effective
1450 - removed the limitation on having only images loaded (as opposed
1452 - when building a stack of images/volume, a lesser number of
1453 gdcmHeader and gdcmFile instances should be used (hopefully
1454 accelerating things).
1455 - when building a stack of images/volumes, files which are not
1456 loadable (wrong path-filename, wrong permissions on existing file,
1457 or file not parsable by gdcm) are replaced with a black image
1458 in the stack (for the caller to notice the problem).
1460 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1461 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1463 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1464 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1465 between standard library (std) and vtk library (problems are found
1466 under Windows... thanks Windows !)
1468 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1469 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1471 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1473 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1474 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1476 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1477 * When compiling with distutils (see setup.py) the C++ compiler is
1478 called with different flags than the default ones (with automake).
1479 In order to fix all those warning, I compiled gdcm with the command
1480 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1481 and went for warning fixes:
1482 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1483 up from unused variables.
1484 - vtk/vtkGdcmReader.cxx: potential bug fix.
1485 * src/gdcmHeader.h: Doxygen warning cleanup
1487 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1488 * gdcmPython/gdcm.i:
1489 - typemaps correction to take into account the systematic replacement
1490 of "using namespace std" with std:: prefix e.g. std::list,
1491 std::string... (cf changes of 2003-05-21).
1492 - gdcmGlob global variable of type gdcmGlobal (defined in
1493 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1494 exported to Python a as cvar.
1495 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1496 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1497 gdcmDictSet.GetPubDictTagNames() and
1498 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1499 C++ static methods).
1500 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1501 with the above changes.
1503 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1504 * setup.py, manifest.in : bug fix under linux
1506 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1507 * Modification of setup.py to compile vtk part too. Then, we have 2
1508 wrappers which must work with same distutils. For that, we have a
1509 generic distutils in distusiltsWrapping.py ; with :
1510 - build_extWrap class to wrap generically all extensions,
1511 - ExtensionWrap base class for all wrapping extension that contains
1513 - Wrapper interface which wrap sources
1514 + In WrapSwig.py we have extension and wrapper for Swig
1515 + In WrapVTK.py we have extension and wrapper for VTK
1516 * MANIFEST.in : modifications to consider vtk directory and new python
1517 files for compilation
1519 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1520 * Added python wrappers of vtkGdcmReader vtk class (see the
1521 source in vtk/vtkGdcmReader.cxx) :
1522 - vtk/Makefile.am now builds a library
1523 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1524 python library (as opposed to _gdcm.so wich are the python
1525 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1526 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1528 - configure.in has an additional flag --enable-vtk that needs
1529 to be set to enable compilation of vtk related code, that is:
1530 + vtk/vtkGdcmReader.so and
1531 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1532 + gdcmPython/vtkgdcmPython.so (see above)
1533 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1534 be read when compressed or when HighBit + 1 != BitsStored),
1535 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1536 the usage of the python wrapper of vtkGdcmReader vtk class.
1537 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1538 * src/*.[h] all occurences of stl classes are now prefixed with
1539 std::, and all occurences of "using namespace std;" where removed.
1540 This is to avoid pollution of global namespace in included files.
1541 Apparently vtk does not avoid this pitfall: when using both
1542 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1543 collision of various stl members (principally cout...).
1544 * gdcmPython/testSuite.py now cleanly removes temprory generated
1546 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1547 comply with above changes)
1549 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1550 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1551 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1552 vtk data structure (an image Flip was required).
1553 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1554 * cosmetic changes in documentation.
1556 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1557 * src/gdcmHeader.cxx: the constructor no longer exits when an
1558 unexisting file is given as argument.
1559 * The subdirectory Data (containing all the images used for the
1560 test suite) is not part of this repository anymore. A new module
1561 containing those images is now available at
1562 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1563 with the name gdcmData.
1564 All the python scripts (including the package initialisation file
1565 gdcmPython/__init__.py) were adapated to take this change into
1566 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1568 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1569 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1570 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1571 demo of the usage of this class.
1572 Compilation of this vtk part is only done when using the --enable-vtk
1573 at configure (or autogen.sh) stage.
1575 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1576 * More memory link related corrections and documentation fixes.
1578 - maximum info is obtained with a command of the form:
1579 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1580 --show-reachable=yes PrintHeader
1581 - the remaining reachable blocks seem to come from the STL
1582 allocation scheme through the usage of map and list. It looks
1583 like this memory cannot be freed but it is not a memory leak
1584 (in fact further invocation to the STL would recollect the
1585 unused memory allthough it cannot explicitely be freed).
1586 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1587 of displaying an image parsed with gdcm and displayed with VTK.
1588 Note: some images don't seem to work e.g.
1589 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1590 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1591 Allthough this weakens the semantics, it is a ditch attempt to
1592 make gdcm more thread friendly.
1594 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1595 * Memory link hunt (by using valgrind through the command
1596 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1597 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1598 gdcmHeader::_dicom_vr.
1599 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1600 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1602 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1604 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1605 * src/Makefile.am now exports all the necessary include files at
1609 * UpdateGroupLength replaced by new one
1612 * UpdateGroupLength re-written using H-Table
1613 (named UpdateGroupLengthNew untill checks are over)
1615 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1616 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1617 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1619 - gdcmHeader::GetPubElValSet removed.
1620 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1621 UpdateGroupLength, WriteElements, Write.
1622 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1623 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1624 carried the same semantics.
1625 - src/gdcmHeaderIdo.cxx changed accordingly.
1626 - gdcmFile::WriteBase now regroups all the codes from previous
1627 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1628 - enum FileType moved to gdcmCommon.h
1629 * src/gdcmHeader.cxx AddDefault trashed
1630 * gdcmGetXSize added
1631 * getimageDataSize now calls gdcmGetXSize
1632 * Test/*.cxx changed to agree with above changes
1634 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1635 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1636 (to avoid double call by end user).
1637 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1638 by end user, since gdcmHeader::gdcmHeader now handles it.
1640 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1641 * gdcm/Doc many doxygen changes:
1642 - Doxyfile now has two different versions, DoxyfileUsers that generates
1643 the html.users end users oriented documentation and
1644 DoxyfileDeveloppers that generates the html.developper developper
1645 oriented documentation.
1646 - README changed accordingly
1647 - requirement.txt removed (old design info moved to TODO).
1648 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1649 DoxyMainPage.txt, DoxyPython.txt provide more information.
1650 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1651 be updated by simply regenerating the docs with doxygen and copying
1652 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1653 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1654 all the tests in the form "if (<map>.count() >1)" were removed.
1655 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1656 ill-formed documentation sections.
1657 * src/gdcmHeader.cxx: ditto
1659 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1660 * setup.py fixed for un*x (needed macro for stdint.h)
1661 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1662 un*ces with sh-utils test utility.
1663 * gdcmPython/demo/test.py renamed to PrintHeader.py
1664 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1665 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1666 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1667 * src/gdcm*.cxx JPR's bad inclusion fixed.
1669 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1670 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1671 * gdcmPython/demo/test.py changed accordingly.
1673 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1674 * gdcmPython/Makefile.am fixed linking against libstdc++
1675 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1676 * Swig subdir (historical tests of swig version 1.3.17++) removed
1677 * Test/testChangeEntete.cxx some lines commented out in order to make
1679 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1680 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1682 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1683 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1684 hence the user doesn't need this explicit call.
1685 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1686 i.e. LoadElements() call removed.
1687 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1688 - src/Makefile.am declares the proper flag for g++.
1689 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1690 for adding user defined new tags.
1691 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1692 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1693 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1695 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1696 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1697 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1698 src/Makefile.am : the project should properly compile and install
1699 with the autotools, included the python wrappers part.
1700 * gdcm.spec.in : added a spec file for RPM packaging.
1702 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1703 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1705 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1706 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1707 to exported to the environement (see gdcmPython/testSuite.py
1709 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1710 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1711 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1712 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1713 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1715 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1716 * gdcmPython/__init__.py doesn't crash anymore when running in
1717 in InstallMode or PreInstallMode but with an environement given
1718 value of GDCM_DICT_PATH.
1719 * src/gdcmDictSet.[cxx/h] coding style.
1721 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1722 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1723 * src/gdcm.h general comments moved to TODO, and README
1724 * src/gdcm.h should now be seen as a user commodity (including it
1725 should suffice to fully use gdcm). It is nowhere including within
1726 any of the kernel files src/*.cxx and src/*.h.
1728 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1729 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1730 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1732 * src/gdcm*.cxx only include their corresponding include file
1733 (as opposed to gdcm.h)
1734 * gdcmPython/gdcm.i changed accordingly
1735 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1736 the autogen.sh generated "make snapshot" command to work.
1737 * autogen.sh removed history related references to crea package.
1739 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1740 * distutilsSwigCPlusPlus.py work around some swig portability
1743 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1744 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1745 was done in a last ditch attempt to get setup.py _really_
1746 operationnal. The python/gdcmPython layaout add the advantage
1747 of hidding away the python related distutils specific files
1748 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1749 Alas, the src directory was out of scope (i.e. it's relative
1750 position to setup.py was ../src) which made things impossible to
1751 handle (see previous version of python/setup.py). Crossing fingers...
1753 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1754 * python/setup.py now works on Un*x. (harder than I thougth)
1755 * python/distutilsSwigCPlusPlus.py can now have include files
1756 among the list of sources.
1758 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1759 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1760 * modifications in MSVC projects
1762 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1763 * As stated by the first lines of Test/ExceptionAndPython/README, it
1764 looks like we can move back to original usage of exception within
1765 src/gdcm* and hence remove the errno stuff that was introduced
1766 as a quick and dirty fixture of this problem (added to the TODO).
1767 * Doc/Doxyfile configuration file for Doxygen and corresponding
1768 README file for usage added.
1769 * Test/testWrite.cxx added. This new test comes from a split of
1770 test.cxx that is now reverted to its original purpous i.e.
1771 testing the proper parsing of a Dicom related file.
1772 testWrite.cxx concentrates on testing the IO part of gdcm.
1773 * Test/bug1.cxx (containing a bug on WIn32) added.
1774 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1775 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1776 whose purpose is to publish the content of the TagNames of the
1777 Dicom public dictionnary were not accessible without an
1778 instance of class gdcmHeader.
1779 - those methods are now static methods of gdcmDictSet and hence
1780 require no instances at all to be invocated.
1781 - within gdcmDictSet this change required to change some method
1782 to class methods (i.e. are now static) among which SetDictPath
1783 (renamed to BuildDictPath) and LoadDefaultPubDict.
1784 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1785 the above changes by calling the new method classes of gdcmDictSet.
1786 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1787 the above to be effective.
1788 * python/gdcmPython: in order to wrap properly the above changes
1789 for Python, swig version now needs to be > 1.3.17.
1790 * python/gdcmPython/Makefile fixed to adapt itself to new
1791 configure/make shema introduced by Johan Montagnat (thanks for the
1792 contribution). Alas this Makefile cannot be turned into a proper
1793 Makefile.am without some heavy changes in the configure.in
1794 (for python dectection).
1795 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1796 now avoids publishing the empty entries.
1798 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1799 * python/setup.py : bug fix concerning install under windows
1800 ExtraPath reused :-P
1801 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1803 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1804 * Dicts/dicomV3.dic : remove double spaces !!!
1805 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1806 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1809 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1810 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1811 method. Doxygenation.
1812 * src/gdcm.h clean up of JPR spurious comments.
1814 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1815 * python/distutilsSwigCPlusPlus.py now properly collects the
1816 shadow classes generated by "swig -c++" (gdcm.py in our case)
1817 when using "python setup.py install".
1818 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1819 reexports the working classes.
1820 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1821 by the classical C errno scheme. This is to prevent an obscure
1822 behavior of the python wrappers when importing wxPython.wx prior
1823 to gdcmPython (which ended up in an abort call). An illustration
1824 of this oddity can be found in the Test/ExceptionAndPython
1825 subdir (see the README file). This problem probably due to
1826 an combination of g++ and dynamic loading.
1827 * added Test/ExceptionAndPython (see above)
1829 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1830 * Changed the layout of the python part to avoid bloating main
1831 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1832 i.e. the distutils arsenal. All the python related stuff is
1833 again in a python subdir, but the package itself is now in
1835 * setup.py was cleaned up:
1836 - pythonIncludePath removed
1837 - python setup.py bdist target is now functional.
1838 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1839 collision with other packages). gdcmPython/demo/*.py changed
1842 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1843 * python subdir moved to gdcmPython (preparation of distutils packaging).
1844 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1845 distutils installer is operational.
1846 * - gdcmPython/__init__.py now properly loads the swig generated
1847 shadow classes (from gdcm.py).
1848 - gdcmPython/demo/*.py changed to import the package gdcmPython
1849 instead of gdcmPython/demo/load.py.
1850 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1852 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1853 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1854 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1855 entries within the associated public Dicom dictionary resp. the same
1856 information but sorted by the fourth field (PAT, IMG, DIR) of the
1858 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1859 are now in the "???" group.
1860 - python/gdcm.i changed accordingly,
1861 - python/demo/printGroupedPublicDict.py added, that gives an example
1862 of the above new functionalities in Python.
1864 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1865 * src/gdcm.h, gdcmHeader.cxx:
1866 - historic references to glib's g_malloc and g_free (#defined)
1867 were definitively removed.
1868 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1869 * src/gdcmElValSet.cxx:
1870 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1871 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
1872 - GetElValue(string) renamed to GetElValueByName.
1873 - Added GetElementByName(string).
1874 * src/gdcmHeader.cxx: added
1875 - GetPubElValRepByNumber(guint16, guint16)
1876 - GetPubElValRepByName(string)
1877 - GetShaElValRepByNumber(guint16, guint16)
1878 - GetShaElValRepByName(string)
1879 - GetShaElValByNumber(guint16, guint16)
1880 - GetShaElValRepByName(string)
1881 - GetElValRepByNumber(guint16, guint16)
1882 - GetElValRepByName(string)
1883 - GetElValByNumber(guint16, guint16)
1884 - GetElValRepByName(string)
1885 * Doc/requirements.txt added.
1887 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1888 * Test/Makefile building now depends on the one of libgdcm.so
1889 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
1890 pixel data) aware which enables finding the address (offset) of
1891 the pixel data of JPEG encoded DICOM files. This leaves only a single
1892 file in the testSuite whose pixel data address (offset) is unknown.
1893 * python/testSuite.py changed accordingly.
1895 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
1896 * VC++ has some strong limitations when working with the STL, as stated
1897 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
1898 "Also note that some STL containers (map, set, queue, list, deque)
1899 cannot be exported. [...]
1900 Some STL classes contain nested classes. These classes can not
1902 This is caused by a designed limitation that once a template
1903 class is instantiated, it can not be re-instantiated and
1905 Since our usage of map<> is ubiquitous in gdcm, this "designed
1906 limitation" of VC++ is a pitfall.
1907 Hence the Python wrappers of gdcm cannot be incrementally linked
1908 against the c++ dynamic library. The dirty but only workaround is
1909 to forget about incremental link of dynamic libraries and to generate
1910 the Python wrappers library with the inclusions of the underlying C++
1912 The following modifications concern this matter on Win32/VC++:
1913 - wrapping python correct with standalone wrapped dll (don't use separate
1914 dll under windows !!!!)
1915 - python21_d debug mode enabled (ask Frog how to use it :-)
1916 - NO problem with having an STL member of class for example string in C++
1917 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
1918 - Python test of dcmlib in Python is ok under windows on a large set
1920 * removed glib references
1921 * typedef's inserted in gdcm.i for correct swig type management
1923 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1924 * python/demo/*.py load.py extracted from test.py. Added explore.py
1925 that only displays required tags and testAll.py that parses all
1926 the files of the testsuite without using unittest.
1927 * python/testSuite.py other additional test on new files added.
1928 * Data/* new test files added accordingly to the testSuite.
1929 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
1930 the vr in the file differs from the one of the dictionary.
1932 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1933 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
1934 values, but limits itself to values which are below a user specified
1935 size (by default 1024 bytes).
1936 * python/gdcm.i : elements not loaded (because their size is above the
1937 user specified treshold) are exported with their TagKey as key of the
1938 python dictionary. This enables the testsuite to make some checks
1939 on the unloaded elements (since we have their offset and size).
1940 * python/testSuite.py
1941 - now tests for the existence and proper value of the pixel data
1942 - two new examples added.
1943 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
1945 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1946 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
1947 aware. See the strategy comments in gdcmHeader::FindeLength().
1948 * Test/test.cxx now accepts a filename as first argument.
1949 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
1950 * python/testSuite.py changed to integrate test on above files.
1952 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1953 * Dicts/dicomV3.dic removed all the trailing (RET) when the
1954 the vr was also RET.
1955 * python/testSuite.py more tests added.
1957 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1958 * python/testSuite.py unittest test suite added (uses Data)
1959 * Data/* dcm and acr files for the test suite.
1960 * glib dependance removed from un*x version. We now use ISO C99
1961 7.18 Integer types (see stdint.h)
1962 - python/Makefile, src/Makefile src/gdcm.h
1963 * src/ when an explicit vr (like dicom files) suddenly poped an
1964 implicit element we use to mark the underlying DictEntry of the
1965 concerned ElValue with "Implicit". This strategy was damageable
1966 too the public or provite dictionaries, since some of their vr
1967 would be changed. Since Header::FindLength heavily relies on the
1968 detection by Header::FindVR of falsely explicit elements, I
1969 added an extra ImplicitVr member to ElValue (boolean).
1970 The rest of the changes we the necessary adaptations.
1972 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1973 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
1975 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
1977 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1978 * Adaptation for porting to VC++:
1980 o forced to use std namespace (for string to be known)
1981 o all class use __declspec export style on WIN32
1982 - src/gdcmUtil.cxx new Exit method that wraps the exit call
1983 (in stdlib.h on Win32 but in std:: for gcc)
1984 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
1985 variable GDCM_DICT_PATH.
1986 * src/gdcmHeader.cxx verbose comments made discrete.
1988 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1989 * python/gdcm.i: added a typemap that converts a C++ hashing table
1990 to native Python dictionary.
1991 * python/demo/test.py:
1992 - now uses the native dictionary for exploration of gdcmHeader.
1993 - takes an optional filename argument (the file to parse).
1994 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
1995 PubElVals hashing table.
1996 * Dicts/dicomV3.dic removed error prone trailing spaces.
1998 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1999 * Python wrapping process moved away from src/Makefile to
2000 newly created python/Makefile (as well as gdcm.i)
2001 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2002 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2003 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2004 from the environement variable GDCM_DICT_PATH (when existing).
2005 * src/gdcmDict::GetTag bug fix.
2007 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2008 * Straightforward temporary fixes for swig to build the python wrappers.
2009 src/Makefile now has a python working entry [by working we mean
2010 that we can import de shadow classes without errors].
2012 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2013 * hashtest.cxx removed (since allready in Test)
2014 * src/gdcmlib.h renamed to src/gdcm.h
2015 * src/dcm.i renamed to src/gdcm.i
2016 * src/Makefile prepared for python wrapping
2018 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2019 * src/gdcmHeader.cxx :
2020 - Parsing of header is now separated from loading of element values
2021 (see gdcmHeader::LoadElements).
2022 - general clean up of hopefully all file access (creation of
2023 ReadInt16 and ReadInt32)
2025 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2026 * src/gdcmHeader.cxx :
2027 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2029 - SetLgrElem renamed to SetLength
2030 - GetLgrElem renamed to GetLength
2031 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2032 * src/gdcmElValSet.cxx fixed both GetElValue methods
2033 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2034 due to IdoDude was cleaned out.
2036 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2037 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2038 concentrates on finding the value representation (when it exists).
2039 RecupLgr now only finds the element value length, and it avoids
2040 returning the unecessary skL (skipped length).
2041 Also, offsetCourant was simply removed (with taille_fich) since
2042 it was redundant with the File position internals (by using
2043 ftell and fseek). This also made skL (see above in RecupLgr) usage
2045 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2046 on the libido specificities which are handled through class
2048 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2051 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2052 * Truckload of changes. Parsing of header is barely functional
2053 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2055 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2056 * src/gdcmHeader.cxx many addons of low level methods
2058 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2059 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2060 and _IdDcmSWAP_LONG.
2062 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2063 * This corresponds to all the changes decided at the meeting of
2064 May 23 2002. Needless to say we are running late...