1 2005-04-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * FIX : Numerical exception on borland (cannot divide by 0, doh !)
3 But this is a case where we should really signify the user there is
4 few chance the serie is really a serie...
6 2005-04-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * FIX : on X, the python part is correctly installed. All files are
8 installed in gdcm sub-directory
10 2005-04-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * Builder/ : add something to facilitate the RPM creation of gdcm
13 2005-04-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
14 * Fix gdcmDirList::IsDirectory. Apparently borland did not like the ending
16 * Also fix compilation on gcc 3.3.5 does not have ios::failure either ...
18 2005-04-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
19 * vtk/vtkGdcmWriter fix bug when writing spacing. The Y spacing comes first
21 * Fix compilation on gcc 2.96 (which does not have ios::failure)
23 2005-04-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * src/gdcmDictGroupName.[h|cxx] : add a correlation between a group (number)
25 and it's representation name (for the NIH)
27 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
29 conversion of YBR to RGB pixels. So, now, the conversion is made using
32 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
33 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
34 format) to replace 'at-run' dicom files generated by the
35 TestAllReadCompareDicom test
37 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
38 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
40 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
41 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
43 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
44 * Testing/TestMAkeIcon.cxx : complete the test
46 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memroy leaks
49 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
50 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
53 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
54 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
56 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
57 * Test/ : accelerate tests (it's not very significant accelerations).
58 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
60 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
61 * Testing/TestSequence.cxx : add test for sequences of images... test that
62 we have the same serie or the same study UID
64 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
67 * src/gdcmDict.h : remove commented code
68 * src/gdcmDocument.cxx : initialize values
69 * src/gdcmFile.cxx : bug fix when reading values
70 * gdcmPython/demo/ : change file names. Remove useless files
72 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
73 * src/gdcmFile.cxx : remove the default array of initialization.
74 The static array contained pointers to non-static values (comming from
75 strings). To have coherences, when creating files, these values can't be
76 static. So, the array can't be static, too ! To simplify, the array have
77 been replaced by repeted lines to insert values in the File
79 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
80 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
81 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
83 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
84 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
85 (Dicom Element) into the Sequence Item
87 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
88 * src/*.cxx : first parss to normalize file organisation
90 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
91 * src/gdcmDirList.[h|cxx] : add method to find a directory
92 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
94 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
95 * Finish cleaning up my JPEG mess. Should be ok now.
96 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
97 contained within the RLE* class(doh!)
99 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
100 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
101 * SerieHeader::AddFileName() creates as many Coherent Files lists
102 (same Serie UID) as it founds different Serie UID
103 amongst the files instead of discarting any file
104 that doesn't match with the first one he found.
105 * SerieHeader::OrderGdcmFileList has now one parameter :
106 the Coherent Files list the user wants to sort
107 * SerieHeader::GetFirstCoherentFileList() |
108 * SerieHeader::GetLastCoherentFileList() | allow to parse
109 the set of Coherent Files lists
110 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
111 compatibility (it returns the *first* Coherent Files list,
112 since there was only one before)
113 * Test/TestSerieHeader gets gdcmData as a default root directory
115 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
116 * Remove friend between DocEntry and File classes
117 * Remove friend between PixelReadConverter and RLEFramesInfo,
120 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
121 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
122 0002|0000. The value was incorrect.
124 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
125 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
127 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
128 * src/gdcmUtil.cxx : compilation fix on Win32
129 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
130 variable, to be easy found. Add methods to change the default UID.
131 Amelioration of the CreateUniqueUID to use the correct default UID.
132 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
135 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
136 * Test/TestVR.cxx : fix memory leaks
138 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
139 * Rewrite the base 256 to base 10 conversion, using string operation only.
140 This allows us to get rid of the problematic 64bits integer type (does not
141 always exist on target platform).
143 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
144 * Add construct and destructor to class gdcm::Debug to close the debug file
146 * Don't let uset to open twice the same file
147 * gdcm has now an official UID prefix,
148 supplied by http://www.medicalconnections.co.uk
149 1.2.826.0.1.3680043.2.1143
150 (Thx to Mathieu for providing URL)
151 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
152 to be able to perform some more tests
153 * gdcm::ContentEntry : Contructors and Destructor are now protected,
154 in order to be sure no user will try to use them.
155 (at user level, only the children classes are meaningfull)
157 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
158 * move RLEInfo & JPEGInfo from Document to File
160 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
161 * FIX : remove so many friend between classes
163 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
164 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
165 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
167 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
168 In order to avoid missbehaviour :
169 . gdcm::DocEntry is now specialized in
170 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
171 - gdcm::ContentEntry (Dicom entry with a 'content')
172 . gdcm::ContentEntry is specialized in
173 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
174 characters value, or integers)
175 - gdcm::BinEntry (Dicom entry with a non strig representable value
176 (user hasn't any longer to thing about the precedence of his dynamic_casts)
178 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
179 * Test/VTKTest*.cxx : bug fix under linux
181 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
182 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
183 use with python. Some methods are moved from Document to ElementSet or
184 DocEntrySet. The equivalent methods to ElementSet have been added to
185 SQItem and are virtual in DocEntrySet. Methods that may have the same code
186 in SQItem and ElementSet is directly placed in DocEntrySet
188 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
189 * Test/VTKTest*.cxx : remove the show variable in each test method because
190 it's useless (the viewer variable replace this variable)
192 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
193 * src/gdcmDocument.cxx : bug fix on potential memory leak
194 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
195 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
196 Add ClearXxx methods to remove all the content of the list or map
197 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
199 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
200 * methods ReplaceOrCreate renamed as Insert
201 (nobody will be any longer confused by 'CreateOrReplace')
203 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
204 * Grealty simplify the JPEg decompression, no need to differenciate based on
205 the JPEG possible type (with/without fragment, with/without multiple frame).
206 Everything is done throught the JPEG IO Suspension mechanism in IJG
208 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
209 * Stage 3 of normalization :
210 in order to avoid any missunderstanding while reading method names :
211 - All the methods xxxEntry now deal with dicom Entries
212 - Methods GetEntry splitted into
215 - Method SetEntry renamed as SetEntryValue
216 - Method SetEntryBinArea let as it was
218 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
219 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
220 - Position correctly the entry points for JPEG2000 and JPEG-LS
221 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
223 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
224 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
225 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
226 with other method names
227 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
228 * Test/TestDicomDirElement.cxx : add new test
230 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
231 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
232 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
233 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
234 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
235 So can't you use __int64 in ostream at all.
237 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
238 * bug fix for compilation on MSVC6
239 * gdcmPython/gdcm.i : rename of classes missed
241 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
242 * Stage 2 of names normalization :
243 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
244 (easy to understand ...)
245 - gdcm::FileHelper replaces old class gdcm::File
247 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
248 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
249 type and not a string. So, there remove problems on the format of the
252 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
253 * Add Example/TestPapyrus.cxx
254 - reads a Papyrus file (gdcm::Header compliant),
255 - gets the pixels of all the images, using low level iterators
256 - writes an multiframes Dicom image.
257 (Just to show it's *possible* to do that)
258 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
261 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
262 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
263 Thus, DicomDirXXX are created with a flad that indicates if the created
264 object is empty or not (when not empty, the DicomDirElement is used to
267 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
268 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
269 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
271 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
272 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
274 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
275 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
276 Remove all access to the hash-tables or lists in the objects.
278 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
279 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
280 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
281 be complient with all the gdcm source code
283 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
284 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
287 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
288 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
291 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
292 * Test/ : rename VTK tests to have a best name for the tests
293 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
294 GetFirstEntry/GetNextEntry use
296 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
297 * In SerieHeader::ImagePositionPatientOrdering()
298 // a Dicom 'Serie' may contain scout views
299 // and images may have differents directions.
300 // -> More than one may have the same 'pos'
301 // Sorting has then NO meaning !
302 Thx to Eduardo Davila for reporting bug.
304 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
305 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
306 test. Now it's on image content and not on the resulting visualisation...
307 might solve the problem on linux when using the OpenGL drivers
309 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
310 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
311 DicomDirSerie, DicomDirImage
312 Dict, DictSet classes :
313 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
314 -remove InitTraversal method.
315 * UPD Test programs + Example programs
317 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
318 * remove useless and never updated keyword \ingroup
319 * Solve pb when structure (list, map, ...) is empty.
320 Thx to Benoit for reporting bug
322 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
323 * Taking into account of 'Transfer Syntax' value
324 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
327 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
328 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
329 is no memory access violation
330 * gdcmPython/demo : add python demos using VTK
332 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
333 * FIX 'Dictionnary' is now spelt 'Dictionary'
334 'wether' is now spelt 'whether'
335 'archieve' is now spelt 'archive' ;-)
337 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
338 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
339 related methods, in order not to expose internal mechanisms
342 * REM methods that exposed internal mechanisms :
343 DicomDir::GetDicomDirPatients()
344 DicomDirPatient::GetDicomDirStudies()
345 DicomDirStudy::GetDicomDirSeries()
346 DicomDirSerie::GetDicomDirImages()
347 * UPD Test programs :
351 * UPD Example program
353 * ADD DictSet methods
357 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
358 * Removed the Print/indent/default parameter mess. There is absolutely no
359 reason to have to methods, moreover with the second taking the ostream as
360 *SECOND* parameter. This was clearly a bad hack to get things compile.
362 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
363 * Complete rewrite of the GetMacAddress code. Now the code is *much*
364 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
365 Unfortunately the main code does not work on SunOS, thus provide a specific
366 code for this platform only (and Win32 of course). Since this seems to be
367 working, change CreateUniqueUID to use GetMACAddress instead of the
368 problematic GctestetIPAddress
370 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
371 * Unfortunately to be able to test gdcmDirList I had to break the API
372 a little. Now the class is not a std::list anymore but has a member
373 std::vector (more ITK compatible). Allow unit testing on Win32 and
376 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
377 * Update SerieHeader to take into account a Serie Instance UID to properly
380 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
381 * ENH - Comment out Mathieu's (dangerous) Super Hack
382 for dealing with BIGENDIAN processors
383 - Move equivalent stuff to BinEntry::WriteContent
384 When necessary, 16 Bits Pixels are swapped in a small buffer
385 and then written. This avoid allocating a huge buffer, in
386 PixelWriteConvertor, and avoid modifying the Pixel Area.
388 Probabely, the same operation will have to be done when we want
389 to write image with Big Endian Transfert Syntax,
390 and we are working on Little Endian Processor
392 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
393 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
395 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
396 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
397 all the dict content.
398 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
400 * Test/TestDict.cxx : add a new test for the dict classes
402 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
403 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
404 file. Debug is yanked if compiled with NDEBUG
406 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
407 * src/gdcmDictSet.h : set the default output to the os variable
408 * src/gdcmDictEntry.[h|cxx] : add the Print method
409 * gdcmPython/demo/ : add a new test
411 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
412 * merging of Test/PrintDicomDir and Test/TestDicomDir
413 * removal of now redundant Test/PrintDicomDir
414 * enhancement of Example/PrintDicomDir
416 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
417 * Now, python test might work on systems
418 * Add the PrintDicomDir test
420 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
421 * FIX : First entry following group 0002 was lost for
422 Explicit Big Endian Transfer Syntax files
423 (group and elem not swaped)
425 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
426 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
427 Big Endian Transfer Syntax supposed the group following 0002
428 begins always by element 0000 (element 0000 is *optional*)
429 To avoid further troubles, let's be pessimistic, and use
430 Document::HandleOutOfGroup0002() method
431 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
432 (related pb not yet solved)
434 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
435 * Bug fix for the python part use
436 * Now, PrintHeader.py pass... but outside the ctest use. shit !
438 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
439 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
441 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
442 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
443 a string and should ask the global TS dict what are the propreties of
446 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
447 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
448 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
449 to swap the Swap Code, at parsing time, when we come out of group 0002
450 and Transfer Syntax is Big Endian
451 We should be able to read now 'true DICOM" Big Endian coded images
452 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
453 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
455 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
456 * Hopefully fix the bug on MacOSX and static global initialization.
457 This is the only -minor- patch I found that both please MacOSX and VS6.
458 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
459 but this would require a lot of change. Another approach would be that Global
460 create those string and GDCM_UNFOUND becomes a pointer to a string (which
461 gdcm::Global would destroy at exit).
463 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
464 * Fix bug on MacOSX with static initialization in a multy threaded
465 environment. static const string in a header file used to be ill
466 initialized provoquing the freeze of any tests. patch should solve this
469 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
470 * According to Benoit's suggestion, and without any objection from anybody
471 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
472 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
473 - method gdcmDicomDirObject::GetEntry() renamed as
474 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
476 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
477 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
478 you debug/warning message just as c++ streams which make them very convinient
479 to use. Once this is stabilize I will change the ostringstrem to be
480 redirected to a file (ofstream).
481 * Properly support C99 extension: __FUNCTION__ which allow us to display
482 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
484 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
485 * Removal of useless and dangerous methods :
486 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
487 GetDocEntryByName, GetEntryByName, GetDictEntryByName
488 * Removal of usless methods :
489 Dict::PrintByName, Dict::GetDictEntryByName
490 * Commenting out of probabely useless methods :
491 Dict::GetDictEntryNames()
492 Dict::GetDictEntryNamesByCategory()
493 DictSet::GetPubDictEntryNames()
494 DictSet::GetPubDictEntryNamesByCategory()
495 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
496 * ENH : Use dicomTS.dic as described in 2004 version
497 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
498 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
499 Add Accessors on VM (Value Multiplicity), and VM related methods
500 * ADD : Add a list of 'Dicom Attribute types', as found in
501 http://medical.nema.org/dicom/2004/04_15PU.PDF
503 * ADD : Add dicomGroupNameAbbreviations.dic
504 should be used to write a method to replace the former
505 Dict::GetDictEntryNamesByCategory()
507 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
508 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
509 to read in the file... and only it ! Length is the efective length of the
510 data in the DocEntry structure
512 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
513 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
514 And now use a static function call instead, with a global variable. i
515 This is much closer to the VTK approach. Hopefully should be bulletproof
516 and easier to use...hopefully
518 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
519 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
521 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
522 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
524 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
525 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
526 ValEntry, BinEntry, SeqEntry creation or replace
528 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
529 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
530 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
532 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
533 when specifying the VR
534 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
535 * src/gdcmDocEntry.cxx : amelioration of print
537 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
538 * ADD : Add the method Util::IsCurrentProcessorBigEndian
539 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
540 * ADD Method Document::ComputeGroupLength
541 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
542 in order to allow further VR modification by user
543 * REM : removal of once-called method File::WriteBase
544 integration of its code in formerly one-line method File::Write
546 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
547 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
548 replace the different values "??", "Unkn", "Unknown".
549 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
550 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
551 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
552 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
554 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
555 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
557 * Set the gdcm::Base class to some Printable classes
559 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
560 * src/gdcmFile.[h|cxx] : add the Print method
561 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
562 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
563 * src/gdcmDocument.h : remove the PrintLevel informations
564 * Example/PrintFile.cxx : use the new gdcm::File::Print
566 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
567 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
568 problems when compiling with the python wrapping
570 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
571 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
572 writting in ImplicitVR
574 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
575 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
576 JPEG decompression, especially when dicom frames are split into several
577 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
578 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
580 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
581 * src/gdcmHeader.cxx : change the initialisation of default header.
582 Now, this header is readable by gdm, e-film, DicomWorks
584 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
585 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
586 Rename Decompressed to Raw
587 * Use the API changes in gdcm::File.
588 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
591 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
592 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
593 each added entry in the header. Replace the 'Planes' field by the 'Number
596 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
597 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
598 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
600 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
601 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
602 At this time, this image isn't readable by e-film... waiting JPR help to
605 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
606 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
607 DocEntry. Now use methods of the Document !
609 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
610 * Test/ShowDicomSeq.cxx : bug fix
612 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
613 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
614 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
615 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
616 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
618 * Test/TestCopyRescaleDicom.cxx : remove unused variable
619 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
620 containing found sequences
622 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
623 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
625 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
626 Some fields in BinEntry must be copied to not seg fault when making the :
627 gdcm::File *copy = new gdcm::File( copyH );
628 and tests are now made on good variables
630 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
631 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
632 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
634 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
635 * Add vtkGdcmWriter example and test
637 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
638 * Test/TestUtil.cxx : reformat the source code
639 * vtk/vtkGdcmReader.cxx : remove and change prints
640 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
642 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
643 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
645 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
646 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
647 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
649 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
650 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
651 by an eof to prevent all bad read of the file... and in this case, the
654 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
655 * Example/Volume2Dicom.cxx : comment unused variables
656 * Test/PrintDicomDir.cxx : comment unused variables
657 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
658 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
659 method that is redondant with AddEntry.
660 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
663 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
664 * Bug fix due my last commit (compilation under Windows).
665 * Example/Volume2Dicom : bug fix in the file and reformatting source code
666 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
668 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
670 - Remove printf / sprintf
671 - include iostream AFTER gdcm so we don't get warnings
672 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
674 - Also remove tons of include from header files, hopefully this should
675 speeup the compilation time, since it was becoming a dog slow.
676 - Remove gdcm.h as it include way too many files and slow down compilation
677 (plus it is not up to date)
678 - remove 'using namespace std' this is BAD !
680 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
681 * Remove memory leaks on the DicomDir
682 * Remove some useless data in DicomDirObject
683 * Add usefull methods in SQItem, to be complient withe the ElementSet
685 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
686 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
688 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
689 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
690 future, with convertion)
691 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
692 and ImageDataSize values. Remove the method to get the PixelReadConverter
693 from the output of the class
695 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
696 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
698 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
699 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
700 and vtkErrorMacro use.
701 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
703 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
704 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
706 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
707 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
708 The string leaves only in the fonction. So when we make a .c_str(), we
709 get the pointeur on the first element, element that will be destroyed
710 immediately after thee instruction.
711 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
712 file has been opened : the test must be made on the content of the
713 pointer and not directly on the pointer !
716 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
717 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
718 the python part recompiles
720 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
721 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
722 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
723 X session is killed (for my computer... it seems to not be identic on
726 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
727 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
728 avoid problems (otherwise, the difference test between the visible image
729 and the reference is incorrect. If the reference is greater than the
730 screen resolution, it's produce errors).
731 Can be used for only one image. Can be used with a visible flag.
732 * vtk/vtkGdcmReader.cxx : remove commented codes.
733 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
734 under windows at compilation
735 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
737 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
739 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
740 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
741 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
742 tests on the image size X, Y, Z
744 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
745 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
746 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
747 between the class name and the file name
749 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
750 * src/ : fix compilation warnings for the Write method (2 different
751 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
752 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
753 variable... create a static method in gdcm::Document to access to
754 this variable content.
756 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
757 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
758 file, to be accessed by other files (like gdcmFile). Remove commented
759 code. Move the change of the header to the gdcmFile, using the
761 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
762 To be sure of that (and simplify calls), the Write of the header now
763 gets a file name and not a file pointer (std::ifstream).
764 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
765 DocEntryArchive. Remove all open of the written file
767 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
768 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
770 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
771 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
772 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
774 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
775 some corresponding methods. Write correctly the file and check before
777 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
778 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
779 is now on RGB data (as before my last commit
780 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
782 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
783 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
784 Add a print information of the type of the entry
785 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
786 It was in the gdcmFile, and all write have been regrouped
787 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
788 Write correctly all dicom files (in decompressed mode only at this time)
789 * Test/ : test on files are now made using Raw data and not color data if
791 * Example/PrintFile.cxx : add more printings
793 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
794 * Amelioration of code, remove some code copy. For the loading of
795 BinEntry (in gdcmDocument), add the test to verify if the file is already
798 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
799 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
800 remove a DocEntry in the header (push an empty DocEntry)
801 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
802 lines. Bug fix in the initialization of the PixelConvert and the
804 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
805 use in TestCopyDicom (now this test can run under windows... but fails)
806 * Test/TestCopyDicom.cxx : amelioration of the test :
807 - test the pixels written
808 - add test points to quickly find where is the error
809 - can set a file name input and output in arguments
810 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
811 amelioration of the test output
813 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
814 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
815 all replaced DocEntry's
816 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
817 Now, each needed DocEntry to modify is duplicated, modified and inserted
818 to the header using DocEntryArchive. Thus, after save, we can restore the
819 header initial state.
821 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
822 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
824 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
825 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
826 correct to copy it. The DictEntry is specified at the DocEntry creation,
827 then, it musn't change in the time.
828 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
829 header correctly. At this time, the change is only made for the first
830 level of the Document. In the future, it might consider sequences.
831 The change is made by replacing a DocEntry by an other that is created
832 outside the class. The old value is kept. When we restore the header
833 status, the added DocEntry is deleted and replaced by the old value.
834 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
835 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
836 set the write type to explicit VR, implicit VR or ACR. Add methods to set
837 the write mode to native, decompressed or RGB (but not used at this time)
839 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
840 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
841 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
843 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
844 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
845 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
847 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
848 set because already copied when copying the BinEntry's of the header
849 * Test/TestAllReadCompareDicom.cxx : remove warnings
851 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
852 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
853 Two problems appear when doing it :
854 - with the gdcmFile : when the GetImageData method is called, the pixels
855 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
856 data (pixels). And each structure destruct the data when it's
857 destructed. So we have two destructions for the same data. To solve it,
858 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
859 data or not. If it doesn't own data, then they will not destroyed by
861 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
862 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
863 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
864 create a double destruction of the same DocEntry's. So, to solve it,
865 the TagHT is simply cleared and the DicomDir* elements are destroyed.
866 * TODO : add an entry concerning memory leaks in the DicomDir
868 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
869 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
870 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
873 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
874 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
875 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
876 after it have been deleted
878 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
879 * FIX: src/* fix the doxygen warnings.
880 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
881 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
882 was erroneously defined with a size of 15 instead of 16. [many thanks
883 to Jean Michel Rouet for pointing out this bug].
885 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
886 1. Finish merging JMR patch for writting DICOM from scratch
887 2. Fix -hopefully- bug with MONOCHROME and space vs null character
888 3. Use const ref when possible
889 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
890 5. A few more comments
891 6. CreateUniqueUID can now be called without parameter"
893 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
894 * ENH: Slightly bigger patch:
895 1. Getting toward full integration of JMR patch for writting dicom from scratch
896 2. Update Test to test part of this patch: CreateUniqueUID
897 3. File was not close properly in gdcmDict
898 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
899 5. Use of const ref instead of copy (speed issue)
900 6. Remove temporary (duplicate) string in TranslateToKey
901 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
902 8. Do not repeat virtual in subclasses
903 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
905 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
906 * Apply first patch toward better string comparison when dealing with broken
907 DICOM files. Essentially the string could be padded with a space instead
908 of a null character as defined by standard
910 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
911 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
912 because never used... and in the same time, that's remove some memory leaks
914 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
915 * src/gdcmFile.cxx : now delete the PixelConvert instance.
916 * In examples and tests : change the type of image data variables from void*
917 to uint8_t*. Remmove all delete on image data variables
919 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
920 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
921 Verify the file pointer value before open the file, and if it's not null,
922 a verbose message is generated.
923 Close correctly the file when the file isn't considered dicom-like. The
924 correctly close is a call to CloseFile.
925 When closing the file pointer, test if its not null to close the file.
926 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
927 file. For an uncompressed image, the copied data correspond in the least
928 case to the image size (calculated) or the image size specified in the
929 header. A verbose is generated if these two size mismatch
931 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
932 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
933 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
934 break under windows (with msvc6 compilation).
936 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
937 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
938 compiling with MSVC6)
940 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
941 * Bugs fix for the Windows build with VC6
942 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
943 needed (only for projects required VTK). If the VTK is included in all
944 projects, there is conflicts with the jpeg lib of vtk when compiling the
945 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
946 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
947 when compiling the gdcm_wrap.cxx file (created by the compilation of the
949 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
950 (like it's already made for the cout use). Otherwise, conflict with the
953 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
954 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
956 - comments on the DicomDir::Method related usage added.
957 - now that we use the namespace gdcm, a lot of internal classes do
958 NOT need to be wrapped anymore.
959 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
960 DicomDir::Method) new example added.
962 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
963 * Improve string manipulation. I now inforce the notion of 'DicomString'
964 A DicomString can contain as many \0 as they want
965 and it is *always* of even length.
966 We only support odd length for very rare case.
967 And in the near future this should be removed.
969 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
970 * /binary_write/ gdcm source. Now even on big endian we are writting
971 little endian. This should -heopfully- fix some tests
973 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
974 * Now the dictionary is compiled into gdcm lib. This is a default
975 behavior, thus any dic file specified is picked before failback to
976 the one comiled into lib
978 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
979 * Change internals for gdcmDict. Don't use any 'new' any more.
980 This should definitely solve any leak problem, and we should be
981 as fast as before, as long as don't modify too much the dictionary.
983 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
984 * STYLE: ivars should start with a capital letter.
985 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
986 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
988 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
989 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
990 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
991 new 2004 dictionaries added (thanks to JPR).
992 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
993 * CLEANUP_ROUND (15) for gdcmPixelConvert
994 - RLEFrame::NumberFragments is now of type unsigned int
995 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
996 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
999 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1000 * Initial work in gathering all transfer syntax accessors. clearly
1001 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
1002 ivars, but only one transfersyntax (class) ivar with equivalent method on
1005 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1006 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
1007 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
1008 discussed (plus I didn't like having a 2000 lines patch not commited)
1010 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1011 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
1012 * CLEANUP_ROUND (14) for gdcmPixelConvert
1013 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
1014 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
1015 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
1016 CloseFile() anymore.
1017 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
1018 anymore and hence avoids storing a copy of PixelConvert::Decompressed
1019 into File::Pixel_Data.
1021 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1022 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
1023 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
1024 * CLEANUP_ROUND (13) for gdcmPixelConvert
1025 Substituted File::ParsePixelData() with PixelConvert::Print() new
1027 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1028 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1029 method to those classes.
1030 - src/gdcmFile.[cxx|h]:
1031 -- Added a ::Print() method.
1032 -- PixelConverter is now a reference instead of a member.
1033 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1034 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1036 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1037 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1038 collaboration diagram and inheritance diagram should be generated with
1040 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1041 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1042 pointlessly wrapped (see
1043 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1044 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1045 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1046 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1047 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1048 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1049 -- File::Initialise: PixelConverter setup moved away to
1050 PixelConverter::GrabInformationsFromHeader()
1051 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1052 interpretation moved away to PixelConverter::BuildRGBImage()
1054 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1055 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1056 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1058 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1059 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1060 displayed on Win32 when a brutal abort() occurs (because of uncatched
1061 exception). See TODO new entry of this commit for more on this.
1062 * TODO added new entry.
1063 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1064 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1065 - HandleColor is no longer called from gdcmFile.cxx
1066 - gdcmPixelConvert.cxx clean up on method arguments and internal
1067 variable names for semantical coherence.
1069 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1070 * Finished lossless transition, not only do we now read all lossless jpeg
1071 images, without the need of the Cornwell lib, but we do read them properly now
1072 * To reduce code (well to avoid code duplication), I defined a common place
1073 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1074 redefine symbols. This is not perfect but this the best solution I found for a
1075 compilation time jpeg option.
1077 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1078 * Update jpeg ijg lib to support lossless jpeg implementation
1079 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1081 * Also added a special copyright for dcmtk since we use their bugfixes.
1084 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1085 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1086 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1087 matters, as stated in warning note at beginning of %include section).
1088 * src/gdcmDicomDir*.[cxx|h]: coding style
1089 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1090 * src/gdcmJpeg8.cxx: doxygen fix.
1091 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1092 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1093 from File:: to PixelConvert::.
1095 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1096 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1097 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1098 - more code moved away from File:: to PixelConvert::
1099 - fat setup of PixelConverter set in place in File::Initialise.
1101 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1102 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1103 namespace at the file system level. So now you should convert your examples
1105 gdcmHeader -> gdcm::Header
1106 It would be nice if people keep in mind to no open the namespace, since it
1107 allows compilation on broken plateform which were defining common symbol in
1108 the standart namespace (like LP, Unknown ...)
1110 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1111 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1112 The JPEG fragments are now parsed at the same stage than the RLE
1113 information. All code related to JPEG is now in gdcmPixelConvert:
1114 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1115 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1116 export a gdcmFile:: method. Those are simply global functions
1117 (for the time being this is better than having them attach to
1118 either gdcmFile:: or gdcmPixelConvert::).
1119 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1120 and stores the result in a gdcmJPEGFragmentsInfo.
1121 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1122 code (among other stuff) moved away from gdcmFile:; to
1125 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1126 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1127 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1128 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1129 clean up of RLE related code.
1130 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1131 - src/gdcmRLE.cxx removed
1132 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1133 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1134 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1135 * CLEANUP_ROUND (9) for gdcmPixelConvert
1136 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1137 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1138 away from gdcmFile:: to gdcmPixelConvert::.
1140 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1141 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1142 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1143 This is because Parse7Fe0 used to parse the pixels to compute the
1144 length. This task was passed over to FindDocEntryLengthOB() a long
1145 time ago, EXCEPT I had forgotten the OW case...
1146 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1147 we just recylce the code for parsing RLE fragments and computing
1149 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1150 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1151 with the retired Parse7Fe0().
1152 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1153 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1155 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1156 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1157 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1158 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1159 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1160 * CLEANUP_ROUND (4) for gdcmPixelConvert
1161 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1162 to return an unused length.
1164 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1165 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1166 this should be cleanner from the plane view. The iostream are erally a pain
1167 to use to do simple stuff.
1169 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1170 * Redo the compilation of the ijg jpeg library. Now only one source is
1171 necesseray. No need to rename file by hand what so ever. CMake handle the
1172 copying of the file within different directory, configure header file to
1173 modify some symbol. The only addition made to ijg wasd a mangle table so
1174 that symbol are different whether we are within 8bits or 12bits.
1176 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1177 * Added documentation of vtkgdcmReader on Website:
1178 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1179 with it's binary name).
1180 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1181 the Website to be more complete.
1182 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1183 doxygenated documentation.
1184 - Doc/DoxyVtkGdcmReaderExamples.txt added
1185 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1186 DoxyVtkGdmReaderExamples.html )
1187 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1188 * CLEANUP_ROUND (3) for gdcmPixelConvert
1189 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1191 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1192 * CLEANUP_ROUND (2) for gdcmPixelConvert
1193 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1195 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1196 * CLEANUP_ROUND for gdcmPixelConvert:
1197 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1198 - src/gdcmPixelStuff[h|cxx] removed
1199 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1200 - src/CMakeLists.txt changed accordingly
1201 * GDCMHOME clean up:
1202 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1203 gdcmVersion.py moved to newly created ATTIC related
1204 gdcmPython/SetupOldies/ directory.
1205 * Autotools clean up:
1206 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1207 - autogen.sh configure.in acinclude.m4 python.m4 removed
1209 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1210 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1211 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1212 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1214 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1215 * TODO updated with Mathieu suggestions. I proposed a template for
1216 describing TODO entries and used it for new entries.
1217 * Added Doc/Website/CodingStyle.html, Developpers.html,
1218 DeveloppersPython.html, GdcmDataCvs.html and
1219 DownloadVersion0_1.html, DownloadVersion0_3.html.
1220 * Some Doc/*.txt Doxygen files (which do not really concern the
1221 documentation itself, but the website) moved to html and
1222 placed in directory Doc/Website:
1223 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1224 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1225 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1226 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1227 * CMakeLists.txt changed accordingly.
1228 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1229 DeveloppersPython.html
1230 * INSTALL nows refers to Doc/Website/Installation.html
1232 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1233 * Added Doc/Website directory, that contains a first raw version
1236 2004-09-23 Jean-Pierre Roux
1237 * FIX In order not to be poluted any longer by casting problems,
1238 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1239 we can now delete[] it safely
1240 * VoidArea is now called BinArea (less confusing name),
1241 and all the methods called ...VoidArea... are now ... BinArea...
1242 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1244 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1245 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1246 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1247 up to the destructor of gdcmElementSet to clean up TagHt and it's
1250 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1251 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1252 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1254 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1255 * ENH: added some utility method that builds a flat dictionary
1256 holding all the Dicom entries contained in the recursive structure
1257 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1258 an example of usage.
1259 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1260 BuildFlatHashTable() that build a flat dictionary.
1261 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1262 gdcmDocument is now a friend of gdcmElementSet.
1263 - src/gdcmElementSet.cxx: clean up.
1264 - Example/FlatHashTablePrint.cxx added.
1265 - Example/CmakeLists.txt changed accordingly
1267 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1268 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1269 moved away from gdcmDocEntrySet (since this class is an abstract class
1270 acting like an interface). SQDepthLevel and BaseTagKey are now
1272 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1273 and associated accessors. Doxygenation of the class.
1274 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1276 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1277 Use SQDepthLevel accessor instead. ::Print() adapted.
1278 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1279 - src/gdcmDocument.cxx changed accordingly.
1281 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1282 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1283 - The following is the doxygen comment of the typedef declaration
1284 of gdcmTagKey in src/gdcmCommon.h:
1285 gdcmTagKey is made to old an "universal" (as in URL, Universal
1286 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1287 A dicom tag always has a group and an element, but a set of tags
1288 embeded in various (optionally nested) sequences and sharing
1289 the same group and element all share the same (group, element)
1290 "identifier". Hence the (group, element) cannot be used as an
1291 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1292 In order to construct a proper tag identifier (i.e. a key) we
1293 consider the following definition of a TagKey:
1294 - let Group, Element be the string representation of the
1295 group and element dicom tag members,
1296 - let ItemNumber be the string representation of the integer
1297 index of the considered item number of a sequence,
1298 Let the key of a tag embeded in a sequence, noted SeqTag, be
1300 /ItemNumber#Group|Element
1301 where "/", "#" and "|" are characters acting as separators.
1302 Then the general form of a gdcmTagKey is given by:
1303 Group|Element<SeqTag>
1304 where <SeqTag> means NO or many instances of SeqTag.
1305 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1308 but the gdcmTagKey of a tag "embeded" is the first item of
1309 a sequence, itself nested in the third item of a sequence is the
1311 0004|1220/2#0008|0082/0#0008|0090
1312 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1313 order to hold the new sequence compatible key. Previously, the
1314 GetKey() method would look in the underlying gdcmDictEntry.
1315 - src/gdcmDocEntry.cxx:
1316 -- constructor now copies the underlying DictEntry key, in the local
1318 -- ::Print: displays the member Key, instead of the (group, element).
1319 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1320 - src/gdcmDocEntrySet.h:xi
1321 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1322 -- now has a new BaseTagKey member.
1324 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1325 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1327 This poses the problem with the semantics of the following lines
1328 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1329 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1330 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1331 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1332 to the long FIXME note for what the problem is. Nevertheless in
1333 order to get things working the dicom dictionary was altered !
1334 Please fix things urgently...
1335 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1336 information), see above note on moving the member VoidArea. Nevertheless
1337 the following entries previously correctly set as US are now inproperly
1339 0028 1201 OW IMG Red Palette Color Lookup Table Data
1340 0028 1202 OW IMG Green Palette Color Lookup Table Data
1341 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1342 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1343 of gdcmDocEntry moved to gdcmSeqEntry.
1344 * src/gdcmSeqEntry.cxx: STYLE.
1346 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1347 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1349 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1350 * gdcmPython/testSuite.py: all the test suite in python is now moved
1351 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1352 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1353 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1355 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1356 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1357 to avoid inclusion recursion until STL is reached.
1358 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1359 mecanism. errno.h is not included in gdcm anymore.
1360 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1361 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1363 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1364 gdcmData/TestAllEntryVerifyReference.txt
1365 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1366 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1367 exception_on_error parameter.
1368 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1369 - vtk/vtkGdcmReader.cxx changed accordingly,
1370 - Example/*.cxx and Test/*.cxx changed accordingly.
1372 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1373 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1374 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1375 enable_sequences removed from gdcmHeader constructor and dependencies.
1376 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1377 * gdcmPython/demo/PrintHeader.py: dummy fix.
1378 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1379 skip_shadow removed from gdcmHeader constructor and dependencies.
1380 * Example/*.cxx and Test/*.cxx changed accordingly.
1382 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1383 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1384 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1386 2004-07-21 Jean-Pierre Roux
1387 * FIX Now, Parsing and Printing a DICOMDIR do work!
1388 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1390 2004-07-20 Jean-Pierre Roux
1391 * FIX Some brain damaged headers have Zero-Lenght fields
1392 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1394 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1395 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1396 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1397 variable (instance of gdcmDebug) by a definition macro, and the instance
1398 is now in static in the gdcmDebug class
1399 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1400 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1402 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1403 * WARNING: ctest now depends more tightly on gdcmData. You should
1404 check out gdcmData properly for things to run smoothly...
1405 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1406 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1407 we need the pixels not be loaded in order to use the ValEntry
1408 that displays position and size).
1409 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1410 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1411 be deprecated. If you have any doubts about the advantages of a
1412 modern scripting language (read Python) versus grass root C++ (i.e.
1413 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1414 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1415 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1416 Anyhow, consider documenting the gdcmData images in
1417 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1419 * Test/CMakeLists.txt:
1420 - now uses TestAllEntryVerify.cxx
1421 - specific comments on oldACR00001.ima (now renamed in gdcmData
1422 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1423 gdcmData/TestAllEntryVerifyReference.txt
1426 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1427 * src/*.[h|cxx] : typedef clean up
1428 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1429 - TagKey renamed to gdcmTagKey (for external usage)
1430 - VRKey renamed to gdcmVRKey (for external usage)
1431 - removal of typedef duplication.
1432 - Removed all unecessary inline keyword from class inline definitions.
1433 - Some method|function(void) declarations replaced with method|function().
1434 * src/jpeg/libijg12/jdhuff12.c:
1435 - printf polluting ctest removed.
1436 - TAB removal for comminting
1438 - TestAllReadCompareDicom.cxx: added a test that compares all the
1439 images in gdcmDataImages.h with corresponding images in
1440 gdcmData/BaselineDicom/. When baseline images are not present
1441 this test creates them.
1442 Note: we need to validate each reference image, but before that
1443 I'd like to rename them with a more explicit name...
1444 - CMakeLists.txt: changed accordingly.
1445 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1446 including each header needed).
1448 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1449 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1450 test suite to the Example directory. Are concerned:
1455 - TestWriteSimple.cxx
1456 * Test/CMakeLists.txt: added some comments on reasons for black listing
1457 image gdcmData/oldACR00001.ima
1459 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1460 * Test/CmakeList.txt: removed the following from black list (to be coherent
1461 with removal from gdcmData):
1462 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1463 - gdcm-MR-PHILIPS-16.dcm
1465 Added the following because after last cvs update, they cause
1466 ctest -R TestReadWriteReadCompare
1468 - gdcm-MR-SIEMENS-16-1.acr
1470 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1471 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1472 new comments in this file) we temporarily (sigh) move to a weaker
1474 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1475 we don't need to black list the following images anymore:
1476 - 8BitsUncompressedColor.dcm
1478 - US-PAL-8-10x-echo.dcm
1479 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1480 fixes and the beautified code ;-)
1481 This fixes the bug introduced in version 1.42 (when beautifying)
1482 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1483 Note: ctest was blind to this bug (this means we need to still
1484 improve the test suite). The bug could be detected by using
1485 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1487 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1488 and by displaying the (garbage) produced file temp.XDCM...
1490 2004-06-29 Jean-Pierre Roux
1491 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1492 - replace by uggly but working old code :-(
1493 A lot of things should be OK again.
1494 It's really urgent to have a test suite that *tests*,
1495 to prevent Frog's beautifying sessions to break all the stuff
1496 (twice, withing a fortnigh ...)
1498 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1499 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1500 redundancy) to added Test/TestReadWriteReadCompare.cxx
1501 * Test/CmakeList.txt: because the compare test of
1502 Test/TestReadWriteReadCompare.cxx fails, the following images are
1503 black listed: - 8BitsUncompressedColor.dcm
1505 - US-PAL-8-10x-echo.dcm
1506 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1507 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1508 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1509 and ad-hoc kludge. This kludge is now removed, and on encountering
1510 such an image (OB field brain damaged) we set errno. Then in
1511 ::FindDocLength() we "fix" the length as being ALL what remains
1512 in the file (until EOF). We then proceed, hoping for the best...
1513 This fixes a SegFault in ShowDicom when trying to write such an
1515 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1516 (because TestWriteRead breaks on it, after a non conformal commit?).
1517 ctest now runs properly, except for MakeDicomDir (which was always
1518 broken) and the Python related stuff (still not fixed).
1520 2004-06-24 Jean-Pierre Roux
1521 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1522 FIX : Test/TestReadWrite now iterates on all the file names
1523 (instead of infinite loop)
1524 ENH : Test/TestWriteRead now iterates on all the file names
1526 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1527 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1529 2004-06-24 Jean-Pierre Roux
1530 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1531 when SamplesPerPixel =3
1532 - now Write is no longer confused by
1533 'BitsAllocated = 12" and 'BitsStored=12"
1534 - "UN" value representation Elements are now written correctly
1535 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1536 ENH : - now gdcmHeader has its own Write methods
1537 (in order to split the job that has not to be done
1540 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1541 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1542 loop on the same image until memory went out.
1543 Note: this means we still have gobs of memory loss in PrintDocument
1544 * src/gdcmDocument.cxx: fixes problem on parsing on file
1545 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1547 2004-06-24 Jean-Pierre Roux
1548 FIX : Write - All the Sequences and Sequence Item are now written
1549 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1550 is added a the end, when necessary.
1551 - A lot of brain-damaged images, that were read correctly are
1552 now written correctly
1553 - length compatible BinEntry are now loaded correctly
1554 (even for odd groups)
1555 Note : only Explicit Value Representation was checked.
1556 (question : is implicit VR really necessary for gdcm ?)
1558 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1559 * DEVELOPPER: added a proposition of coding style.
1560 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1563 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1564 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1565 Use the gdcmDocEntry::Print() and Write() instead.
1566 * src/gdcmDocument.cxx: bug fix.
1568 2004-06-22 Jean-Pierre Roux
1569 FIX : gdcmDocument.cxx
1570 - Now we do recognize the JpegLossLess format (there was a misstyping in
1571 code 'beautyfication' :-(
1572 - Now we automaticaticaly load the Luts, if any
1574 2004-06-22 Jean-Pierre Roux
1575 In order : to write Sequences, whatever their imbrication level,
1576 : to allow user to create his own Sequences
1577 a lot of modif where necessary (adding, moving, or virtualising methods)
1579 WARNING : save your own sources *before* cvs up !
1582 ADD virtual void Write(FILE *fp, FileType filetype);
1585 ADD virtual void Write(FILE *fp, FileType filetype);
1586 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1589 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1590 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1591 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1592 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1593 ADD std::string GetEntryByName(TagName name);
1594 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1596 std::string vr = "unkn",
1597 std::string fourth = "unkn",
1598 std::string name = "unkn");
1599 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1600 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1601 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1602 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1603 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1604 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1605 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1606 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1609 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1610 ADD virtual std::string GetEntryByName (TagName tagName);
1611 ADD virtual std::string GetEntryVRByName (TagName tagName);
1612 REM virtual bool Write(FILE *, FileType);
1613 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1614 FILE *_fp, FileType type);
1615 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1616 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1617 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1618 REM virtual std::string GetEntryByName (std::string tagName);
1619 REM virtual std::string GetEntryVRByName (std::string tagName);
1620 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1621 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1622 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1624 std::string vr = "unkn",
1625 std::string fourth = "unkn",
1626 std::string name = "unkn");
1627 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1628 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1629 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1630 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1633 ADD virtual void Write(FILE *fp, FileType filetype);
1636 ADD virtual void Write(FILE *fp,FileType filetype);
1639 ADD virtual void Write(FILE *fp, FileType filetype);
1640 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1641 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1642 REM std::string GetEntryByName(TagName name);
1645 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1647 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1648 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1649 The default constructor invoked by the line
1650 gdcmHeader *f1 = new gdcmHeader( header );
1651 was gdcmHeader::gdcmHeader(bool) instead of the expected
1652 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1653 Hence the parsing wasn't executed... See also below.
1654 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1655 as explicit constructor didn't do the trick to fix the above problem.
1656 Could anyone explain why ?
1657 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1658 properly calls gdcmValEntry::Print() (that was weed out from
1659 code related to gdcmBinEntry).
1661 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1662 * In order to fix memory leaks:
1663 - Test/TestWriteSimple.cxx: added cleaning of free store through
1665 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1666 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1667 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1668 (through the call to ::AddDicomDirMeta()) or the destructor
1669 would crash when deleting uninitialized ::metaElems].
1670 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1671 - src/gdcmDocument.cxx:
1672 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1673 from dynamic stores.
1674 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1675 was causing memory leaks.
1676 - src/gdcmSQItem.cxx:
1677 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1678 cleanly handled with polymophism: sorry but my milage is low).
1679 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1680 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1681 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1682 This avoids SegFaulting.
1683 - src/gdcmSQItem.h: coding style.
1685 - Test/TestWriteSimple still severely sucks. The output image content
1686 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1687 damaged when displayed with vtkgdcmViewer.
1688 - on memory leaks: TestWriteSimple leaks really less (see entry
1689 of 2004-06-18 in Changelog file for the call to valgrind).
1690 - on segfaults: ctest now passes all the tests but one (no more
1692 * Erroneous leading white fix:
1693 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1694 white[s] (as opposed to from >> xxx, that removes it [them].
1695 - src/gdcmTS.cxx: ditto.
1696 - gdcmPython/testSuite.py: dirty related kludge removed.
1697 * src/*: remaining references to gdcmParser removed.
1698 * src/*[cxx|h]: added copy[way]left header.
1701 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1702 * In order to fix writing of dicom files:
1703 - Test/TestWriteSimple.cxx: a simpler example of writing.
1704 - Test/CMakeLists.txt changed accordingly.
1705 - src/gdcmDocument.cxx:
1706 -- The destructor now recursilvely removes potential sequences.
1707 -- Bug fix in ::IsJPEG2000()
1708 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1709 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1711 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1712 to only declared) and build on top of
1713 ::GetDocEntryByNumber(guint16, guint16).
1714 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1715 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1716 for usage in destructor and treatement of promotion in
1717 ::ReplaceOrCreateByNumber().
1718 - src/gdcmSQItem.cxx: destructor should better handle his job.
1719 Test/TestWriteSimple now runs (or at least it DOES something).
1720 * We can now start hutting memory links. A good starting point is:
1721 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1722 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1723 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1725 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1726 * Valgrind note: after Mathieu Malaterre teached me how to read
1727 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1729 Using gcc, you can force the STL to use malloc and to free memory as
1730 soon as possible by globally disabling memory caching.
1731 With 3.2.2 and later, you should export the environment variable
1732 GLIBCPP_FORCE_NEW before running your program.
1733 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1734 simply vanish (it is still not clear to me, whether this means that
1735 STL std::string leaks or if valgrind believes it leaks...).
1736 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1737 running bin/gdcmTests makeDicomDir):
1738 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1739 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1741 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1742 SegFaulting (I drowned in DicomDir related code when trying to
1743 understand why the list is empty...).
1744 * src/gdcmDocument.h: first BSD license header try.
1745 * Doc/License.txt added.
1747 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1748 * src/gdcmDocument.[h|cxx]:
1749 - Clean up of the Transfer related predicates. They are now all based
1750 on new method isGivenTransferSyntax, that (should) handle properly
1751 the padding problem.
1752 - general clean up, simplification, and coding style.
1753 - Specific clean up of Parse7FE0() (umproperly named actually).
1754 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1756 2004-06-14 Jean-Pierre Roux
1758 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1759 - fix the display of SQItem ordinal number
1760 - add the GetSQItemByOrdinalNumber method
1761 - remove some useless never written private methods
1763 2004-06-14 Jean-Pierre Roux
1765 - adding a constructor taking a gdcmDocEntry as an input param
1766 - ReplaceOrCreateByNumber now returns :
1767 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1768 a gdcmValEntry * if a string value is passed as a param
1770 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1771 according to the param type (no longer sets a gdcmDocEntry)
1772 - GetValEntryByNumber, GetBinEntryByNumber added
1773 - NewValEntryByNumber and NewBinEntryByNumber added
1775 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1777 - GetSQItemNumber and SetSQItemNumber added, to provide
1778 a (relative) Item identier inside a given Sequence
1779 \warning : some pb remaining around this number
1781 - AddEntry now takes the Item Number as a param
1783 - adding a constructor taking a gdcmDocEntry as an input param
1785 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1786 * Memory leak hunt with the following command:
1787 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1788 --show-reachable=yes gdcmTests PrintDocument
1789 It looks like many (all?) leaks are due to the STL (or a bad usage
1790 of the STL. The lines producing the leaks now have a comment with
1791 a "MEMORY LEAK" tag: you can retrieve them with
1792 grep "MEMORY LEAK" src/*
1793 Here are two typical examples which I can't help fixing:
1798 char * test = "babo";
1799 name = test; //// <--- valgrind detects 960 bytes lost in
1800 //// call to std::string::operator=(char const*)
1801 name.clear(); //// Doesn't help !
1809 std::cout << "Type a bunch of characters followed by RETURN: ";
1810 getline(std::cin, line); //// <--- valgrind dectects a loss
1811 //// of 1320 bytes in call to
1812 /// std::basic_istream<>& std::getline<>
1818 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1819 * src/gdcmHeader.[cxx|h]:
1820 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1821 and related, moved away to gdcmDocument.
1822 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1823 the corresponding protected accessors of inherited class
1824 gdcmDocument, removed ! As a consequence gdcmFile had to be
1825 declared friend of class gdcmDocument (see below).
1826 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1827 - Clean up of undefined or unused methods.
1828 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1829 account the changes to gdcmHeader.h).
1830 * src/gdcmDocument.h:
1831 - gdcmFile is now a friend class (in order to take into account the
1832 changes to gdcmHeader.h).
1833 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1834 (see changes to gdcmHeader.h).
1835 - Accessors (reading on the form GetEntry*) are now public.
1836 - Clean up of undefined or unused methods.
1837 * src/gdcmDocument.cxx:
1838 - adaptation to changes to gdcmDocument.h
1839 - ::OpenFile now writes a verbose message when file cannot be opened.
1840 - some std::string properly set to VRKey
1841 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1842 references to gdcmDocument.
1843 * Test/TestFindTags.cxx: changed accordingly to above changes.
1844 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1845 cvs repository gdcmData.
1847 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1848 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1849 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1850 conflicts with gdcmValEntry::voidArea.
1851 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1852 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1853 Value representation between StringRepresentable and BinaryRepresentable.
1854 * src/gdcmDocument.cxx:
1855 - method ParseDES: proper indentation restored and usage of
1856 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1857 - method LoadDocEntry: the fingerprint left in the SetValue() of
1858 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1859 removed. Reverting to previous code segment with the proper
1860 dynamic_cast< gdcmValEntry* >.
1861 Note: this was (partially) breaking the python test suite
1862 (gdcmPython/testSuite.py) that made usage of the above
1863 fingerprint to check presence of "Pixel Data".
1864 * src/gdcmDocEntry.h: coding style.
1865 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1866 now taken into account.
1867 * gdcmPython/gdcm.i: adaptation to the new internal representation
1868 of gdcm (exit gdcmParser, hello gdcmDocument).
1869 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1871 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1872 anymore, but instead prints the loaded Python dictionary.
1873 * .... alas, the python testSuite is still broken.
1875 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1876 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1878 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1879 * src/gdcmUtil.h : export methods
1881 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1882 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1884 * Initial addition of automatic python testing
1885 * Initial addition of automatic image comparison
1887 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1888 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1889 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1891 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1892 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1893 * Test/ShowDicom.cxx : bug fix for msvc compilation
1894 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1896 2004-05-04 Jean-Pierre Roux
1897 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1898 new concepts (and new classes) :
1899 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1900 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1901 - Sequence Doc Entries (gdcmSeqEntries)
1902 a Sequence is composed of Items.
1903 Each item is a set of Doc Entries (this is recursive)
1904 The non uniqueness of the 'Dicom tag' is due to this recursivity
1905 (never taken into account)
1906 Our unability to add a new 'entry' in the header
1907 at the proper location (neither in the H-Table (map or multimap),
1908 nor in the Chained List is also due to this recursivity.
1909 Don't try, right now, to use/modify/compile these new sources :
1910 nothing is finished.
1911 We just commit all the stuff, 'as is', in order not to loose it.
1913 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1914 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1916 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1917 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1918 file prefix (SetFilePrefix)
1920 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1921 * Add a new test: ShowDicom, for now this is just the c++ version of
1922 checkRead.sh, later it will be able to compare the image read against a
1924 * Replace the DEBUG on the stack with a global entry in cmake interface:
1925 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1927 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1928 * Add an example subdir, with a real example on how to read + write a
1931 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1932 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1933 * Doc/CMakeLists.txt: the main page is now properly differentiated
1934 between the developper and user version.
1935 * Doc/doxygen.config.in: dropped search related obsolete flags
1936 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1938 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1939 * DEVELOPPER: added some helpfull comments for compile/test/install
1942 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1943 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1944 src directory, now generated in the build dir.
1945 2. Tests as mentionned smarter
1947 4. Add a new method in gdcmDict that return the PubDict by name
1948 this is interesting for 3rd party lib like ITK,
1949 where we could set the institution name / patient name...
1951 * ENH: 1. Now the test suite is working for real
1952 2. All binaries are now output in the gdcm-bin directory
1953 (this was not true before)
1955 2004-04-28 Jean-Pierre Roux
1956 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1957 SeQuence indented printing of Dicom Header.
1958 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1959 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1960 Computation of SQDepthLevel is now part of gdcmHeader constructor
1961 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1962 tree-like structure of a Dicom Header.
1963 * FIX Test code cleaning
1965 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1966 * ENH: Adding automatic testing
1967 1. Need a DartConfig.cmake to submit to public
1968 2. Add a test driver gdcmTest.cxx
1969 3. gdcmTestMain, an helper for the main test driver gdcmTest
1970 4. Files in Test don't have a main anymore, this becomes interesting
1971 when we add more and more tests, thus dsw don't have to load
1973 * ENH: Adding a GDCM_DATA_ROOT for testing
1974 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1975 one file instead of seven + some small cleanup
1977 2004-04-22 Jean-Pierre Roux
1978 * ENH Minor changes to the Print() methods.
1979 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1980 Header printing. Example given with :
1981 > PrintHeader fileName 2 new
1982 (SQ based tree-like structure still to be done for the Header ...)
1984 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1985 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1986 1. I have added some unsigned where needed
1987 2. Some function parameter not used -> (void)
1988 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1989 4. g++ don't like character '\' in comment
1990 5. #define jpeg_create_decompress jCreaDecompress
1991 this really need to be fixed
1992 6. virtualize destructor of gdcmObject ... leakage
1993 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1994 this also really need to be fixed
1995 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1996 remove compression file
1997 (as we only do decompression, right ?)
1998 * ENH: Change malloc/calloc/free with c++ equivalent
2000 2004-04-21 Jean-Pierre Roux
2001 * FIX gdcmHeaderHelper::GetXSpacing
2002 when a single value is found (bug ?), xpacing is now
2003 defaulted to yspacing
2005 2004-04-19 Jean-Pierre Roux
2006 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
2007 * ENH add parameters :
2008 bool exception_on_error = false,
2009 bool enable_sequences = false,
2010 bool ignore_shadow = false
2011 to the gdcmFile constructors to be full gdcmParser compliant
2012 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
2013 to allow reading of PAPYRUS 3.0 files
2015 2004-04-06 Jean-Pierre Roux
2016 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
2018 2004-04-02 Jean-Pierre Roux
2019 * ADD : Test/checksequence.sh, for a general recap on SQ pb
2020 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
2021 for Philips spurious Tag fffe|0000 while rewritting Dicom files
2023 2004-03-30 Jean-Pierre Roux
2024 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
2025 for ACR file, written out as DICOM files (hope so...)
2027 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2028 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2029 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2030 moved to base class gdcmParser and only the specialisation is kept
2032 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2033 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2034 already does the job.
2035 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2036 (to be consistent with gdcmParser::WriteEntries).
2038 2004-03-30 Benoit Regrain
2039 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2040 upate of the object's instance. It's passed to 2 in the unfavorable
2041 case : one in the ExecuteInformation, one in the ExecuteData
2043 2004-03-29 Jean-Pierre Roux
2044 * ENH : Check on file type to be written moved
2045 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2046 * FIX : gdcmObject::ResetBoundaries now stops properly
2047 when end-of-list is reached
2048 : gdcmVersion modified (as Benoit Regrain asked)
2050 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2051 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2052 * src/gdcmUtil.cxx: added forgotten iostream include.
2053 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2054 equivalent to ExplicitVR in existing code).
2056 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2057 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2058 now contains all the gdcmGlobal related code.
2059 * minor coding style and doxygenation changes.
2061 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2062 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2063 now contains all the Debug related code.
2064 * minor clean-up of includes in src/*.cxx
2065 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2066 CreateCleanString) removed.
2067 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2068 * Doc/DoxyMainPageUser.txt added.
2069 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2070 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2071 src/gdcmDirList.cxx)
2073 2004-03-24 Jean-Pierre Roux
2074 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2076 2004-03-23 Jean-Pierre Roux
2077 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2078 big endian made volumes
2079 * ENH Now gdcmParser constructor and destructor are protected to forbid
2080 end user to instanciate class gdcmParser
2081 (only gdcmHeader and gdcmDicomDir are meaningfull)
2083 2004-03-22 Benoit Regrain
2084 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2085 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2086 gdcmSerie to gdcmDicomDirSerie
2088 2004-03-19 Jean-Pierre Roux
2089 * ENH Now the tree-like structure describing a DICOMDIR comming from
2090 an already existing DICOMDIR file is consistent with
2091 the home-made tree-like structure build ex-nihilo
2092 or build from the files held (recursively) in a Directory
2093 functions gdcmDicomDir::CheckBoundaries()
2094 gdcmObject::SetBoundaries() added
2096 2004-03-17 Jean-Pierre Roux
2097 * REM (Eric Boix bug) : removal of meaningless
2098 gdcmDicomDirImage::NewImage function.
2099 * FIX now file names and directory name are written properly in the
2101 * FIX now gdcmDicomDir constructor may be call without any trick
2104 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2105 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2106 of gdcmDicomDirImage::NewImage as empty function.
2108 2004-02-28 Jean-Pierre Roux
2109 * ENH add gdcmDicomDir:NewPatient
2110 add gdcmDicomDirPatient:NewStudy
2111 add gdcmDicomDirStudy:NewSerie
2112 add gdcmDicomDirSerie:NewImage
2113 to allow making gdcDicomDir object.
2114 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2115 (as opposite to the gdcmHeader chained list)
2117 2004-02-11 Benoit Regrain
2118 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2119 when using from python
2121 2004-02-10 Benoit Regrain
2122 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2123 * FIX : in gdcmDicomDir when the directory is empty
2124 * ENH : add callback and methods to get the progression of dicomDir
2127 2004-02-06 Jean-Pierre Roux
2128 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2129 - GDCM_META added to gdcmDicomDirType
2130 - class gdcmMeta created
2131 * ENH : - A brief summary is now displayed at the beginning of
2132 'testDicomDir' to help disaster magnitude estimation
2133 * REM : Now useless Test/explDICOMDIR.cxx
2135 2004-02-05 Benoit Regrain
2136 * ENH : add methods in gdcmObject to get the hash table or the list of
2138 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2139 * FIX : wrapping python for TagHeaderEntryHT
2141 2004-02-04 Benoit Regrain
2142 * FIX : even length for some strings when writting the dicom dir
2143 * FIX : sort the images in the dicom dir
2144 * FIX : Bug fix for python use of dicom dir
2145 * ADD : a python demo
2147 2004-02-04 Jean-Pierre Roux
2148 * FIX : Final solution (?) for icone embedded images
2149 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2150 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2151 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2152 gdcmData/gdcm-MR-SIEMENS-16.acr1
2153 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2154 to make full checking easier
2156 2004-02-04 Benoit Regrain
2157 * FIX : WriteEntries : coding style & logic in parameters
2158 * FIX : Set the elements to create the DicomDir in a dictionary file
2160 2004-02-03 Benoit Regrain
2161 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2162 * gdcmDicomDir : add the load of directory
2163 * Bug fix and print add-on
2165 2004-02-03 Jean-Pierre Roux
2166 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2167 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2168 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2169 * FIX gdcmParser.cxx : 'group length' elements are now considered
2170 as integers, even for shadow groups, when file is Implicit VR
2172 2004-02-02 Jean-Pierre Roux
2173 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2175 of the last synonym :-(
2176 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2178 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2179 * FIX taking into account the possible 7fe0,0010 multiplicity
2180 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2181 to allow removal of references to 7fe0,0010, to deal with
2182 ACR-NEMA images, when 0028,0200 is meaningfull
2184 2004-01-31 Jean-Pierre Roux
2185 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2186 no longer writes 'Un' on disk
2187 * FIX SQ elements with actual length are now dealt with corectly
2188 * FIX gdcmFile::WriteBase make the difference, for color images, between
2189 the length (for Palette expanded images)
2190 and Raw Length (non expanded image + Palette)
2191 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2192 (that broke Write). Replaced by UL.
2193 Aware user will reload the field if he
2194 thinks it's necesssary
2196 2004-01-30 Jean-Pierre Roux
2197 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2198 when 'dirty Acr' is found, to be compliant with the new
2199 IsReadable() methods.
2201 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2202 (no DOUBLE images in kosher DICOM,
2203 but so usefull for people that miss them ;-)
2205 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2206 DICOMDIR related utilities (not checked as Windoze compliant)
2208 2004-01-28 Jean-Pierre Roux
2209 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2211 2004-01-27 Jean-Pierre Roux
2212 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2213 to allow skipping the shadow elements, to save memory space.
2214 The TRUE value for this param has to be used
2215 with a FALSE value for the 'enable_sequence' param.
2216 ('public elements' may be embedded in 'shadow Sequences')
2217 * gdcmHeader methods now deal with 'embedded icones images' in the header
2218 (even when an 'icone image sequence' is announced by the
2219 element (0x0088,0x0200), but there is NO icone at all ...
2221 * gdcmHeader sometimes Image Location value doesn't follow
2222 the supposed processor endianity (see gdcmData/cr172241.dcm).
2225 * gdcmHeader add the method
2226 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2227 to get *all* the Header Entries with the same tag.
2228 GetHeaderEntrySameName is probabely *useless*
2229 (no meaning : Name is *not* an identifier within the Dictionary)
2231 2004-01-26 Benoit Regrain
2232 * Bug fix in the print of hexadecimal representations. Remove long fields
2233 in the print and add a third level of print to print them
2235 2004-01-23 Benoit Regrain
2236 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2237 * Bug fix on test suite after remove the strip made on not string fields
2238 * Split the IsReadable method between gdcmParser which test that the file
2239 is dicom and gdcmHeader which test that it's an image file
2241 2004-01-22 Benoit Regrain
2242 * DicomDir : clean code, add methods, set variables in protected or private
2243 * gdcmUtil : bug fix for the clean string method
2245 2004-01-19 Benoit Regrain
2246 * Add the use of shadow dictionaries
2247 * bug fix and coding style
2249 2004-01-19 Benoit Regrain
2250 * src/gdcmFile.cxx : bug fix concerning the close of file
2251 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2252 * Add the update of header entries using the shadow library
2254 2004-01-19 Benoit Regrain
2255 * removal of file gdcmHeader2.cxx
2256 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2257 inheriting from gdcmParser. This split is to prepare the integration
2258 of dicom dir parsing
2259 * bug fix under python
2261 2004-01-16 Jean-Pierre Roux
2262 * REM removal of class gdcmHeaderEntrySet
2263 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2264 * ADD add file gdcmHeader2.cxx
2265 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2267 2004-01-15 Benoit Regrain
2268 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2269 entries created while parsing the header. Thus, they will be destroyed
2270 when the gdcmDictSet will be destroyed
2271 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2274 2004-01-15 Benoit Regrain
2275 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2276 made a fatal error because of the memory release at the end of program.
2277 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2278 some memory and vtk seems to have some problems with that.
2279 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2281 2004-01-14 Benoit Regrain
2282 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2283 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2284 * src/*.[h|cxx] : make changes due to class name changes
2285 * gdcmPython/demo/*.py : bug fix due to method names
2287 2004-01-13 Benoit Regrain
2288 * src/*.[h|cxx] : coding style
2289 * vtk/*.[h|cxx] : coding style
2291 2004-01-13 Benoit Regrain
2292 * gdcmPython/testSuite.py : test the readable flag of file for tests
2293 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2294 It's lied to the stl compilation by MSVC (windows, always windows...)
2295 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2297 2004-01-12 Benoit Regrain
2298 * src/*.h : add comments
2299 * src/gdcmDictSet.h : set the method BuildDictPath in public
2300 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2301 directly setted in the source code
2302 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2305 2004-01-09 Benoit Regrain
2306 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2307 * setup.py : use a reference to gdcmVERSION
2309 2004-01-07 Benoit Regrain
2310 * Modification to compile with the distutils.
2313 2003-12-10 Benoit Regrain
2314 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2315 can use a gdcmHeaderHelper to load data
2316 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2317 made in the source code
2319 2003-12-10 Benoit Regrain
2320 * Update Windows projects and .cvsignore files
2322 2003-11-12 Jean-Pierre Roux
2323 * ENH gdcmHeader constructor has one more parameter (default value : false)
2324 that allows the user to 'go inside' the SeQuences only
2326 gdcmElValSet:Print takes it into account
2328 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2329 * ENH: Update gdcmPython/CMakeLists
2330 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2331 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2333 2003-11-10 Jean-Pierre Roux
2334 * FIX : gdcmHeader::LoadElements is now based
2335 on the ListTag listElem member,
2336 not longer on the TagElValueHT tagHt member
2337 * ENH : PrintPubElVal shows (temporarily) both results,
2338 with the tagHt member and the listElem member.
2339 (it's easier to 'see' the problems when using Printheader)
2341 * FIX : old private member LgrElem is now splitted into
2342 ReadLength : Length actually found on disk (updated only
2343 if bug fixing is necessary), for internal
2345 UsableLength : Updated by FixFoundLength, to fix a bug
2346 or to allow Parser going on.
2347 Will allow to re-write a kosher header when a SeQuence
2348 with a length (not 0000) is found
2349 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2350 because gdcmElValSet::Add does not update ListElem
2353 2003-11-07 Jean-Pierre Roux
2354 * FIX misstyping in Transfert Syntax name table
2355 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2356 when they have an actual length (not 0000 nor FFFFF)
2357 (Nobody should care of it, but DICOMDIR explorers)
2359 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2360 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2362 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2363 * ENH: vtkGdcmReader now supports LUT !
2364 (vtkgdcmViewer for now is not able to use them though)
2366 2003-11-05 Jean-Pierre Roux
2367 * in testSuite.py : new files names for checking the package
2368 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2369 that returns the pixel area size to the *aware* (vtk) user
2370 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2372 2003-11-05 Benoit Regrain
2373 * in testSuite.py : Modify the rules for checking the paths
2374 : Explicit error messages
2375 * in __init__.py : Related modif
2377 2003-11-03 Jean-Pierre Roux
2378 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2379 to be used by aware (vtk) users that want to manage
2380 LUT (and no to turn the PALETTE image into an RGB pixels one)
2381 * GetPixelType now returns 8U for 24 Bits images
2382 (vtkGdcmReader compliant)
2384 2003-10-31 Jean-Pierre Roux
2385 * Removal of *all* gdcmData images and add them again
2386 in order to loose the 'history' of un-anonymised images
2388 2003-10-31 Jean-Pierre Roux
2389 * RMV : removal of useless jBitsInJsample.h
2390 for both 8 and 12 Bits JPEG Lossy Libraries
2392 2003-10-31 Jean-Pierre Roux
2393 * ENH : Add the functions gdcmFile::GetImageDataRaw
2394 gdcmFile::GetImageDataIntoVectorRaw
2395 that act as GetImageData and GetImageDataIntoVector
2396 except the making of an RGB Plane from Gray Plane + LUT
2397 Intended to aware (vtk) users who know how to manage
2400 GetLUTRGBA return a R,G,B,A LUT if any
2401 lgrTotaleRaw gives the 'Raw' length
2402 GetImageDataRaw returns the gray Plane
2403 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2404 (They stay Grey, just like with other Dicom viewers :-(
2406 2003-10-30 Jean-Pierre Roux
2407 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2409 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2410 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2411 being coherents dicom files.
2413 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2414 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2416 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2417 * ENH: Two steps is necessary to please VC++ compiler...
2418 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2419 * ENH: Add include dir to medcon lib
2420 * FIX: only one function is being exported for now !
2421 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2423 2003-10-29 Jean-Pierre Roux
2424 * adding gdcmHeader::GetLUTRGBA
2425 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2426 --> Mathieu, the modif u're waiting for is not yet committed
2427 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2429 2003-10-27 Jean-Pierre Roux
2430 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2431 00191113.dcm DermaColorLossLess.dcm
2432 MxTwinLossLess.dcm RadBWLossLess.dcm
2433 * ENH: For version prior to vtkImageViewer2 -r 1.19
2434 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2436 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2437 * Removal of ido stuff in CMakeLists.txt
2439 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2440 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2441 * FIX: remove a call to ->Modified ... see comments
2442 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2444 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2445 * FIX: Problem with path for libvtkgdcmPython
2446 * ENH: Try adding a search script for python site-package
2447 * RMV: Remove some file from medcon lib that are not necessary
2448 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2449 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2450 * FIX: More pragma disable fro VC++,
2451 I don't think I break something as it is also disable in VTK/ITK.
2452 But it fasten debug compilation time.
2454 2003-10-23 Jean-Pierre Roux
2455 * gdcm now deals with 16 Bits Run Length Encoded images
2456 (they are compressed as 2 planes images,
2457 one for the high Bytes, the other for low Bytes)
2459 2003-10-22 Jean-Pierre Roux
2460 * Now CheckRead takes into account :
2461 - the bugged 'Leonardo' Siemens images
2462 - the XA images, sent thru the burning VPRO station
2463 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2466 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2467 * FIX: When copying a Makefile.am to CMakeLists.txt
2468 one should remove the '\'
2470 2003-10-22 Jean-Pierre Roux
2471 * in gdcmData adding a bugged 'Leonardo' Siemens image
2472 (wrong lengths in header)
2473 OK with gdcm, KO with the other viewers :-)
2474 * add a GE dlx XA image, thru the VEPRO burning station
2477 2003-10-21 Jean-Pierre Roux
2478 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2479 for a brutal checking of vtkgdcmViewer compliance
2481 2003-10-21 Jean-Pierre Roux
2482 * add the files for 'xmedcon' Jpeg Lossless library
2483 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2485 2003-10-21 Jean-Pierre Roux
2486 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2488 2003-10-21 Jean-Pierre Roux
2489 * garbage Siemens 'Leonardo' images dealt with
2490 (the patch is easy to remove)
2491 * cosmetic changes to avoid warnings
2493 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2494 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2495 no need to press 'r' now.
2497 2003-10-20 Jean-Pierre Roux
2498 * upgrade of checkRead.sh checkWrite.sh according
2499 to new Jpeg Lossless decompressor
2500 * add US.3405.1.dcm, a genuine RGB medical file ...
2501 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2502 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2504 2003-10-15 Jean-Pierre Roux
2505 * general anonymisation in gdcmData
2506 * adding the 'color files' from
2507 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2508 * adding some well knowed bugged-header images
2509 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2510 waiting for their inclusion in Python testsuite
2512 2003-10-15 Jean-Pierre Roux
2513 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2514 no longer seg faults when file is not found
2516 2003-10-14 Jean-Pierre Roux
2517 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2520 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2521 * TODO: *.in file to genereate a UseGDCM later
2523 2003-10-14 Jean-Pierre Roux
2524 * Some supposed-to-be Dicom Images have no preamble.
2525 OpenFile takes it into account
2526 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2527 * Missing elements added in dicomV3.dic
2528 (just to be affraid : have a look at
2529 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2530 and do it again next year ;->
2532 2003-10-13 Jean-Pierre Roux
2533 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2534 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2535 But there are NOT. It's fixed !
2537 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2538 * FIX: "jpeglib.h" was not found on VC++
2539 * FIX: vtkgdcm was not being installed
2541 2003-10-10 Jean-Pierre Roux
2542 * ENH : OpenFile closes the file if it *really* doesn't look like
2543 an ACR-NEMA / DICOM one.
2544 * FIX : testWrite no longer writes an empty file if the source file
2545 is not gdcm Readable
2546 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2549 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2550 * FIX: CMake generate now documentation
2551 * ENH: out of source doc build !
2552 * ENH: Generate both user and dev documentation
2553 * ENH: Should work on windows too
2554 * ENH: Only one doxygen config.in file is needed
2555 * FIX: make install should be ok now on ùnix plateform
2556 * FIX: PATH to dictionary was wrong (missing /)
2557 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2559 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2560 * vtkGdcmReader is now able to read rgb dicom file.
2561 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2562 * added a gdcmViewer to vtk test, use mouse to control
2563 window level & window width
2565 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2566 * CMake-ification of gdcm, we have now two build system
2567 * FIX: on cygwin Wsock32 doesn't exist
2568 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2570 2003-10-06 Emanuel Ollart
2571 * FIX : compilation process wad broken.
2572 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2574 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2575 * change gdcmViewer -> vtkgdcmViewer
2576 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2578 2003-10-06 Jean-Pierre Roux
2579 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2580 ( e.g : well known GE images with a wrong elem length,
2581 : Philips MRI Images with a wrong Huffman table)
2582 * still to be done : allow the reading of bugged LEONARDO Siemens images
2584 2003-10-03 Jean-Pierre Roux
2585 * Odd length strings are padded with '\0' (not with spaces,
2586 to remain compliant with already defined strings,
2587 like Transfert Syntax UID and others)
2589 2003-10-03 Jean-Pierre Roux
2590 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2591 to allow displaying RGB images (not only by affim ;-)
2593 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2594 * vtkGdcmReader is now able to read rgb dicom file.
2595 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2597 2003-10-03 Jean-Pierre Roux
2598 * A few nasty patches to allow the reading of a lot of nasty images
2599 ( e.g : well known GE images with a wrong elem length,
2600 : Philips MRI Images with a wrong Huffman table)
2601 * still to be done : allow the reading of bugged LEONARDO Siemens images
2603 2003-10-03 Jean-Pierre Roux
2604 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2606 2003-10-03 Jean-Pierre Roux
2607 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2608 to allow displaying RGB images (not only by affim ;-)
2610 2003-10-03 Jean-Pierre Roux
2611 * gdcmFile::GetImageDataIntoVector now
2612 - deals with MultiFrames MultiFragments Run Length Encoded files
2613 - deals with YcBcR (YBR_FULL) files
2614 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2615 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2617 (no sample found :-(
2619 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2620 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2621 Two reasons: - clear things
2622 - third parties acces gdcm through header files, so won't
2623 suffer anymore VC++ complains
2625 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2626 * add argv[1] in testvtkGdcmReader.cxx
2629 2003-09-24 Jean-Pierre Roux
2630 * The lines are now eigthy characters long.for
2631 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2633 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2634 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2635 char* to std::string. Thus, the use of strdup becomes useless. (see
2636 previous commis of Malaterre)
2637 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2638 before the last Malaterre's commit.
2640 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2641 * This commit should fix the Debug building under VC++, the problem
2642 was mainly a mixture of debug and release lib being loaded at startup.
2643 * I also remove a depency to a specific C function: strdup. Because I had
2644 to force the link to msvcrtd (whereas strdup is in libc).
2646 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2647 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2648 located in the gdcmCommon.h file. All use of reference of tha has been
2649 changed to now use the variable GDCM_UNFOUND.
2651 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2653 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2654 Dicom dictionary. The test suite can now be run again. Note:
2655 I'm note very happy with the " (RET)" changes. I believe this
2656 RETAINED comment should be dropped when parsing the dictionary.
2657 - PACKAGER corrected
2659 - AUTHORS updated and now in alphabetical order
2660 * Makefile.am now exports gdcm.dsw for Windoze users.
2662 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2663 * cygwin complains about missing std:: in subdir Test/
2665 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2666 * remove some methods that are now in gdcmHeaderHelper
2668 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2669 * vtkGdcmReader set spacing and origin correctly
2671 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2672 * Fix a few delete/delete[] mismatch
2674 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2675 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2676 interpretation to data given by gdcmHeader. For instance there are
2677 heuristics to get informations (look at different places).
2678 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2679 sorting DICOM images based on different strategies.
2680 * modified Makefiles accordingly.
2682 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2683 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2684 when building in debug mode
2685 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2686 src/win32/gdcmdll.dsp
2687 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2689 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2690 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2693 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2694 * src/win32/libgdcmjpeg12.dsp was not dos format
2695 * src/win32/libgdcmjpeg12.dsp :
2696 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2697 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2699 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2700 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2702 * src/gdcmFile.cxx : bug fix in affectation type
2703 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2704 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2705 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2706 symbols... future problem ?
2708 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2709 * src/win32/libgdcmijpeg12.dsp was missing
2710 * modified gdcm.dsw accordingly
2712 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2713 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2715 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2716 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2717 commit of JPR (before his hollidays to facilitate our work).
2718 * setup.py : bug fix in code. Modifications made while the last commit
2719 of JPR. The code hasn't been tested before the commit... it's so
2720 useless to make that (for best programmer that is JPR) !!!
2722 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2723 * tagged the current version as Version0_3 (i.e. version 0.3)
2725 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2726 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2727 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2728 * *.dsp : modifications to use new libgdcmijpeg8 library
2729 * setup.py : bug fix on VTKPATH variable
2730 * PACKAGER : adding all concerning windows
2732 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2733 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2735 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2736 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2737 test suite reported error.
2738 * PACKAGER file added (describes what a packager must do when
2739 packaging a new release).
2740 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2741 * configure.in: upgraded version number to 0.3.0
2742 * fixing build of rpm (through rpm -ta):
2743 - Doc/Makefile.am exports proper doxygen files
2744 - src/jpeg/libijg8/Makefile.am exports the include files.
2746 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2747 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2748 * src/gdcmHeader.h : formatting code
2750 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2751 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2752 We were obtaining error message from vtk. Now, creation of file list
2753 is made in an internal list to prevent this problem.
2754 Bug fix when output is empty.
2755 Bug fix in update of progress value. Previous commit for this was a bad
2757 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2759 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2760 * src/gdcmHeader.h : added method to get the file name
2761 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2762 files. Added method to remove all files on the input
2763 Added FIXME comment concerning the bad parsing of header made by
2764 ExecuteInformation method (in ExecuteData method)
2766 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2767 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2768 when using make instal.
2769 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2770 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2772 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2773 * setup.py : adding include dir of jpeg lib to compile all sources
2774 * */Win32/*.dsp : JPR fix for windows compilation
2776 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2777 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2779 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2780 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2782 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2783 * setup.py is again effective on un*x (takes into account the
2784 addon of the jpeg library)
2785 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2786 * Doc/Doxy* updated (includes above enhancements)
2787 * INSTALL now points to web documentation
2789 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2790 * src/gdcmHeader.h doesn't make unnecessary reference to
2792 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2794 * src/gdcm*.[cxx|h] :
2795 - to allow compilation with gcc 3.x
2796 -- clean up of STL usage (added explicit usage of std::)
2797 -- small fixes on exceptions.
2798 Note: linking not tested !
2799 - clean of doxygen comments to avoid warnings at documentation
2801 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2802 dependent convertion).
2804 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2805 * Clean up of previous JPR garbage commit (not even commented in the
2807 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2808 - moved all jpeg related files from src to src/jpeg/libijg8, with
2809 addition/modification of Makefile.am and configure.in.
2810 - the testSuite is still brain damage (not guilty).
2812 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2813 * WrapVTK.py : modifications to get correctly vtk source files to
2815 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2816 (FileName -> Filename)
2818 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2819 * vtk/vtkGdcmReader.[cxx/h]:
2820 - UpdateProgress method should now be effective
2821 - removed the limitation on having only images loaded (as opposed
2823 - when building a stack of images/volume, a lesser number of
2824 gdcmHeader and gdcmFile instances should be used (hopefully
2825 accelerating things).
2826 - when building a stack of images/volumes, files which are not
2827 loadable (wrong path-filename, wrong permissions on existing file,
2828 or file not parsable by gdcm) are replaced with a black image
2829 in the stack (for the caller to notice the problem).
2831 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2832 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2834 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2835 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2836 between standard library (std) and vtk library (problems are found
2837 under Windows... thanks Windows !)
2839 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2840 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2842 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2844 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2845 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2847 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2848 * When compiling with distutils (see setup.py) the C++ compiler is
2849 called with different flags than the default ones (with automake).
2850 In order to fix all those warning, I compiled gdcm with the command
2851 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2852 and went for warning fixes:
2853 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2854 up from unused variables.
2855 - vtk/vtkGdcmReader.cxx: potential bug fix.
2856 * src/gdcmHeader.h: Doxygen warning cleanup
2858 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2859 * gdcmPython/gdcm.i:
2860 - typemaps correction to take into account the systematic replacement
2861 of "using namespace std" with std:: prefix e.g. std::list,
2862 std::string... (cf changes of 2003-05-21).
2863 - gdcmGlob global variable of type gdcmGlobal (defined in
2864 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2865 exported to Python a as cvar.
2866 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2867 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2868 gdcmDictSet.GetPubDictTagNames() and
2869 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2870 C++ static methods).
2871 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2872 with the above changes.
2874 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2875 * setup.py, manifest.in : bug fix under linux
2877 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2878 * Modification of setup.py to compile vtk part too. Then, we have 2
2879 wrappers which must work with same distutils. For that, we have a
2880 generic distutils in distusiltsWrapping.py ; with :
2881 - build_extWrap class to wrap generically all extensions,
2882 - ExtensionWrap base class for all wrapping extension that contains
2884 - Wrapper interface which wrap sources
2885 + In WrapSwig.py we have extension and wrapper for Swig
2886 + In WrapVTK.py we have extension and wrapper for VTK
2887 * MANIFEST.in : modifications to consider vtk directory and new python
2888 files for compilation
2890 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2891 * Added python wrappers of vtkGdcmReader vtk class (see the
2892 source in vtk/vtkGdcmReader.cxx) :
2893 - vtk/Makefile.am now builds a library
2894 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2895 python library (as opposed to _gdcm.so wich are the python
2896 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2897 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2899 - configure.in has an additional flag --enable-vtk that needs
2900 to be set to enable compilation of vtk related code, that is:
2901 + vtk/vtkGdcmReader.so and
2902 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2903 + gdcmPython/vtkgdcmPython.so (see above)
2904 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2905 be read when compressed or when HighBit + 1 != BitsStored),
2906 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2907 the usage of the python wrapper of vtkGdcmReader vtk class.
2908 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2909 * src/*.[h] all occurences of stl classes are now prefixed with
2910 std::, and all occurences of "using namespace std;" where removed.
2911 This is to avoid pollution of global namespace in included files.
2912 Apparently vtk does not avoid this pitfall: when using both
2913 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2914 collision of various stl members (principally cout...).
2915 * gdcmPython/testSuite.py now cleanly removes temprory generated
2917 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2918 comply with above changes)
2920 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2921 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2922 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2923 vtk data structure (an image Flip was required).
2924 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2925 * cosmetic changes in documentation.
2927 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2928 * src/gdcmHeader.cxx: the constructor no longer exits when an
2929 unexisting file is given as argument.
2930 * The subdirectory Data (containing all the images used for the
2931 test suite) is not part of this repository anymore. A new module
2932 containing those images is now available at
2933 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2934 with the name gdcmData.
2935 All the python scripts (including the package initialisation file
2936 gdcmPython/__init__.py) were adapated to take this change into
2937 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2939 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2940 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2941 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2942 demo of the usage of this class.
2943 Compilation of this vtk part is only done when using the --enable-vtk
2944 at configure (or autogen.sh) stage.
2946 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2947 * More memory link related corrections and documentation fixes.
2949 - maximum info is obtained with a command of the form:
2950 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2951 --show-reachable=yes PrintHeader
2952 - the remaining reachable blocks seem to come from the STL
2953 allocation scheme through the usage of map and list. It looks
2954 like this memory cannot be freed but it is not a memory leak
2955 (in fact further invocation to the STL would recollect the
2956 unused memory allthough it cannot explicitely be freed).
2957 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2958 of displaying an image parsed with gdcm and displayed with VTK.
2959 Note: some images don't seem to work e.g.
2960 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2961 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2962 Allthough this weakens the semantics, it is a ditch attempt to
2963 make gdcm more thread friendly.
2965 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2966 * Memory link hunt (by using valgrind through the command
2967 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2968 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2969 gdcmHeader::_dicom_vr.
2970 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2971 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2973 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2975 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2976 * src/Makefile.am now exports all the necessary include files at
2980 * UpdateGroupLength replaced by new one
2983 * UpdateGroupLength re-written using H-Table
2984 (named UpdateGroupLengthNew untill checks are over)
2986 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2987 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2988 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2990 - gdcmHeader::GetPubElValSet removed.
2991 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2992 UpdateGroupLength, WriteElements, Write.
2993 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2994 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2995 carried the same semantics.
2996 - src/gdcmHeaderIdo.cxx changed accordingly.
2997 - gdcmFile::WriteBase now regroups all the codes from previous
2998 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2999 - enum FileType moved to gdcmCommon.h
3000 * src/gdcmHeader.cxx AddDefault trashed
3001 * gdcmGetXSize added
3002 * getimageDataSize now calls gdcmGetXSize
3003 * Test/*.cxx changed to agree with above changes
3005 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3006 * src/gdcmHeader.h: LoadElements() is not a public method anymore
3007 (to avoid double call by end user).
3008 * Test/*.cxx LoadElements() doesn't need to be called explicitely
3009 by end user, since gdcmHeader::gdcmHeader now handles it.
3011 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3012 * gdcm/Doc many doxygen changes:
3013 - Doxyfile now has two different versions, DoxyfileUsers that generates
3014 the html.users end users oriented documentation and
3015 DoxyfileDeveloppers that generates the html.developper developper
3016 oriented documentation.
3017 - README changed accordingly
3018 - requirement.txt removed (old design info moved to TODO).
3019 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
3020 DoxyMainPage.txt, DoxyPython.txt provide more information.
3021 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
3022 be updated by simply regenerating the docs with doxygen and copying
3023 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
3024 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
3025 all the tests in the form "if (<map>.count() >1)" were removed.
3026 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3027 ill-formed documentation sections.
3028 * src/gdcmHeader.cxx: ditto
3030 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3031 * setup.py fixed for un*x (needed macro for stdint.h)
3032 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3033 un*ces with sh-utils test utility.
3034 * gdcmPython/demo/test.py renamed to PrintHeader.py
3035 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3036 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3037 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3038 * src/gdcm*.cxx JPR's bad inclusion fixed.
3040 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3041 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3042 * gdcmPython/demo/test.py changed accordingly.
3044 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3045 * gdcmPython/Makefile.am fixed linking against libstdc++
3046 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3047 * Swig subdir (historical tests of swig version 1.3.17++) removed
3048 * Test/testChangeEntete.cxx some lines commented out in order to make
3050 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3051 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3053 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3054 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3055 hence the user doesn't need this explicit call.
3056 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3057 i.e. LoadElements() call removed.
3058 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3059 - src/Makefile.am declares the proper flag for g++.
3060 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3061 for adding user defined new tags.
3062 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3063 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3064 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3066 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3067 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3068 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3069 src/Makefile.am : the project should properly compile and install
3070 with the autotools, included the python wrappers part.
3071 * gdcm.spec.in : added a spec file for RPM packaging.
3073 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3074 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3076 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3077 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3078 to exported to the environement (see gdcmPython/testSuite.py
3080 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3081 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3082 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3083 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3084 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3086 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3087 * gdcmPython/__init__.py doesn't crash anymore when running in
3088 in InstallMode or PreInstallMode but with an environment given
3089 value of GDCM_DICT_PATH.
3090 * src/gdcmDictSet.[cxx/h] coding style.
3092 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3093 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3094 * src/gdcm.h general comments moved to TODO, and README
3095 * src/gdcm.h should now be seen as a user commodity (including it
3096 should suffice to fully use gdcm). It is nowhere including within
3097 any of the kernel files src/*.cxx and src/*.h.
3099 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3100 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3101 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3103 * src/gdcm*.cxx only include their corresponding include file
3104 (as opposed to gdcm.h)
3105 * gdcmPython/gdcm.i changed accordingly
3106 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3107 the autogen.sh generated "make snapshot" command to work.
3108 * autogen.sh removed history related references to crea package.
3110 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3111 * distutilsSwigCPlusPlus.py work around some swig portability
3114 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3115 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3116 was done in a last ditch attempt to get setup.py _really_
3117 operationnal. The python/gdcmPython layaout add the advantage
3118 of hidding away the python related distutils specific files
3119 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3120 Alas, the src directory was out of scope (i.e. it's relative
3121 position to setup.py was ../src) which made things impossible to
3122 handle (see previous version of python/setup.py). Crossing fingers...
3124 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3125 * python/setup.py now works on Un*x. (harder than I thougth)
3126 * python/distutilsSwigCPlusPlus.py can now have include files
3127 among the list of sources.
3129 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3130 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3131 * modifications in MSVC projects
3133 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3134 * As stated by the first lines of Test/ExceptionAndPython/README, it
3135 looks like we can move back to original usage of exception within
3136 src/gdcm* and hence remove the errno stuff that was introduced
3137 as a quick and dirty fixture of this problem (added to the TODO).
3138 * Doc/Doxyfile configuration file for Doxygen and corresponding
3139 README file for usage added.
3140 * Test/testWrite.cxx added. This new test comes from a split of
3141 test.cxx that is now reverted to its original purpous i.e.
3142 testing the proper parsing of a Dicom related file.
3143 testWrite.cxx concentrates on testing the IO part of gdcm.
3144 * Test/bug1.cxx (containing a bug on WIn32) added.
3145 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3146 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3147 whose purpose is to publish the content of the TagNames of the
3148 Dicom public dictionary were not accessible without an
3149 instance of class gdcmHeader.
3150 - those methods are now static methods of gdcmDictSet and hence
3151 require no instances at all to be invocated.
3152 - within gdcmDictSet this change required to change some method
3153 to class methods (i.e. are now static) among which SetDictPath
3154 (renamed to BuildDictPath) and LoadDefaultPubDict.
3155 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3156 the above changes by calling the new method classes of gdcmDictSet.
3157 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3158 the above to be effective.
3159 * python/gdcmPython: in order to wrap properly the above changes
3160 for Python, swig version now needs to be > 1.3.17.
3161 * python/gdcmPython/Makefile fixed to adapt itself to new
3162 configure/make shema introduced by Johan Montagnat (thanks for the
3163 contribution). Alas this Makefile cannot be turned into a proper
3164 Makefile.am without some heavy changes in the configure.in
3165 (for python dectection).
3166 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3167 now avoids publishing the empty entries.
3169 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3170 * python/setup.py : bug fix concerning install under windows
3171 ExtraPath reused :-P
3172 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3174 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3175 * Dicts/dicomV3.dic : remove double spaces !!!
3176 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3177 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3180 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3181 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3182 method. Doxygenation.
3183 * src/gdcm.h clean up of JPR spurious comments.
3185 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3186 * python/distutilsSwigCPlusPlus.py now properly collects the
3187 shadow classes generated by "swig -c++" (gdcm.py in our case)
3188 when using "python setup.py install".
3189 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3190 reexports the working classes.
3191 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3192 by the classical C errno scheme. This is to prevent an obscure
3193 behavior of the python wrappers when importing wxPython.wx prior
3194 to gdcmPython (which ended up in an abort call). An illustration
3195 of this oddity can be found in the Test/ExceptionAndPython
3196 subdir (see the README file). This problem probably due to
3197 an combination of g++ and dynamic loading.
3198 * added Test/ExceptionAndPython (see above)
3200 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3201 * Changed the layout of the python part to avoid bloating main
3202 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3203 i.e. the distutils arsenal. All the python related stuff is
3204 again in a python subdir, but the package itself is now in
3206 * setup.py was cleaned up:
3207 - pythonIncludePath removed
3208 - python setup.py bdist target is now functional.
3209 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3210 collision with other packages). gdcmPython/demo/*.py changed
3213 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3214 * python subdir moved to gdcmPython (preparation of distutils packaging).
3215 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3216 distutils installer is operational.
3217 * - gdcmPython/__init__.py now properly loads the swig generated
3218 shadow classes (from gdcm.py).
3219 - gdcmPython/demo/*.py changed to import the package gdcmPython
3220 instead of gdcmPython/demo/load.py.
3221 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3223 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3224 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3225 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3226 entries within the associated public Dicom dictionary resp. the same
3227 information but sorted by the fourth field (PAT, IMG, DIR) of the
3229 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3230 are now in the "???" group.
3231 - python/gdcm.i changed accordingly,
3232 - python/demo/printGroupedPublicDict.py added, that gives an example
3233 of the above new functionalities in Python.
3235 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3236 * src/gdcm.h, gdcmHeader.cxx:
3237 - historic references to glib's g_malloc and g_free (#defined)
3238 were definitively removed.
3239 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3240 * src/gdcmElValSet.cxx:
3241 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3242 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3243 - GetElValue(string) renamed to GetElValueByName.
3244 - Added GetElementByName(string).
3245 * src/gdcmHeader.cxx: added
3246 - GetPubElValRepByNumber(guint16, guint16)
3247 - GetPubElValRepByName(string)
3248 - GetShaElValRepByNumber(guint16, guint16)
3249 - GetShaElValRepByName(string)
3250 - GetShaElValByNumber(guint16, guint16)
3251 - GetShaElValRepByName(string)
3252 - GetElValRepByNumber(guint16, guint16)
3253 - GetElValRepByName(string)
3254 - GetElValByNumber(guint16, guint16)
3255 - GetElValRepByName(string)
3256 * Doc/requirements.txt added.
3258 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3259 * Test/Makefile building now depends on the one of libgdcm.so
3260 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3261 pixel data) aware which enables finding the address (offset) of
3262 the pixel data of JPEG encoded DICOM files. This leaves only a single
3263 file in the testSuite whose pixel data address (offset) is unknown.
3264 * python/testSuite.py changed accordingly.
3266 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3267 * VC++ has some strong limitations when working with the STL, as stated
3268 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3269 "Also note that some STL containers (map, set, queue, list, deque)
3270 cannot be exported. [...]
3271 Some STL classes contain nested classes. These classes can not
3273 This is caused by a designed limitation that once a template
3274 class is instantiated, it can not be re-instantiated and
3276 Since our usage of map<> is ubiquitous in gdcm, this "designed
3277 limitation" of VC++ is a pitfall.
3278 Hence the Python wrappers of gdcm cannot be incrementally linked
3279 against the c++ dynamic library. The dirty but only workaround is
3280 to forget about incremental link of dynamic libraries and to generate
3281 the Python wrappers library with the inclusions of the underlying C++
3283 The following modifications concern this matter on Win32/VC++:
3284 - wrapping python correct with standalone wrapped dll (don't use separate
3285 dll under windows !!!!)
3286 - python21_d debug mode enabled (ask Frog how to use it :-)
3287 - NO problem with having an STL member of class for example string in C++
3288 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3289 - Python test of dcmlib in Python is ok under windows on a large set
3291 * removed glib references
3292 * typedef's inserted in gdcm.i for correct swig type management
3294 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3295 * python/demo/*.py load.py extracted from test.py. Added explore.py
3296 that only displays required tags and testAll.py that parses all
3297 the files of the testsuite without using unittest.
3298 * python/testSuite.py other additional test on new files added.
3299 * Data/* new test files added accordingly to the testSuite.
3300 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3301 the vr in the file differs from the one of the dictionary.
3303 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3304 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3305 values, but limits itself to values which are below a user specified
3306 size (by default 1024 bytes).
3307 * python/gdcm.i : elements not loaded (because their size is above the
3308 user specified treshold) are exported with their TagKey as key of the
3309 python dictionary. This enables the testsuite to make some checks
3310 on the unloaded elements (since we have their offset and size).
3311 * python/testSuite.py
3312 - now tests for the existence and proper value of the pixel data
3313 - two new examples added.
3314 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3316 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3317 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3318 aware. See the strategy comments in gdcmHeader::FindLength().
3319 * Test/test.cxx now accepts a filename as first argument.
3320 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3321 * python/testSuite.py changed to integrate test on above files.
3323 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3324 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3325 the vr was also RET.
3326 * python/testSuite.py more tests added.
3328 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3329 * python/testSuite.py unittest test suite added (uses Data)
3330 * Data/* dcm and acr files for the test suite.
3331 * glib dependance removed from un*x version. We now use ISO C99
3332 7.18 Integer types (see stdint.h)
3333 - python/Makefile, src/Makefile src/gdcm.h
3334 * src/ when an explicit vr (like dicom files) suddenly poped an
3335 implicit element we use to mark the underlying DictEntry of the
3336 concerned ElValue with "Implicit". This strategy was damageable
3337 too the public or provite dictionaries, since some of their vr
3338 would be changed. Since Header::FindLength heavily relies on the
3339 detection by Header::FindVR of falsely explicit elements, I
3340 added an extra ImplicitVr member to ElValue (boolean).
3341 The rest of the changes we the necessary adaptations.
3343 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3344 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3346 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3348 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3349 * Adaptation for porting to VC++:
3351 o forced to use std namespace (for string to be known)
3352 o all class use __declspec export style on WIN32
3353 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3354 (in stdlib.h on Win32 but in std:: for gcc)
3355 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3356 variable GDCM_DICT_PATH.
3357 * src/gdcmHeader.cxx verbose comments made discrete.
3359 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3360 * python/gdcm.i: added a typemap that converts a C++ hashing table
3361 to native Python dictionary.
3362 * python/demo/test.py:
3363 - now uses the native dictionary for exploration of gdcmHeader.
3364 - takes an optional filename argument (the file to parse).
3365 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3366 PubElVals hashing table.
3367 * Dicts/dicomV3.dic removed error prone trailing spaces.
3369 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3370 * Python wrapping process moved away from src/Makefile to
3371 newly created python/Makefile (as well as gdcm.i)
3372 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3373 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3374 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3375 from the environement variable GDCM_DICT_PATH (when existing).
3376 * src/gdcmDict::GetTag bug fix.
3378 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3379 * Straightforward temporary fixes for swig to build the python wrappers.
3380 src/Makefile now has a python working entry [by working we mean
3381 that we can import the shadow classes without errors].
3383 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3384 * hashtest.cxx removed (since already in Test)
3385 * src/gdcmlib.h renamed to src/gdcm.h
3386 * src/dcm.i renamed to src/gdcm.i
3387 * src/Makefile prepared for python wrapping
3389 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3390 * src/gdcmHeader.cxx :
3391 - Parsing of header is now separated from loading of element values
3392 (see gdcmHeader::LoadElements).
3393 - general clean up of hopefully all file access (creation of
3394 ReadInt16 and ReadInt32)
3396 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3397 * src/gdcmHeader.cxx :
3398 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3400 - SetLgrElem renamed to SetLength
3401 - GetLgrElem renamed to GetLength
3402 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3403 * src/gdcmElValSet.cxx fixed both GetElValue methods
3404 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3405 due to IdoDude was cleaned out.
3407 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3408 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3409 concentrates on finding the value representation (when it exists).
3410 RecupLgr now only finds the element value length, and it avoids
3411 returning the unecessary skL (skipped length).
3412 Also, offsetCourant was simply removed (with taille_fich) since
3413 it was redundant with the File position internals (by using
3414 ftell and fseek). This also made skL (see above in RecupLgr) usage
3416 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3417 on the libido specificities which are handled through class
3419 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3422 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3423 * Truckload of changes. Parsing of header is barely functional
3424 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3426 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3427 * src/gdcmHeader.cxx many addons of low level methods
3429 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3430 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3431 and _IdDcmSWAP_LONG.
3433 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3434 * This corresponds to all the changes decided at the meeting of
3435 May 23 2002. Needless to say we are running late...