1 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr
2 * ADD : Add the method Util::IsCurrentProcessorBigEndian
3 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
4 * ADD Method Document::ComputeGroupLength
5 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
6 in order to allow further VR modification by user
7 * REM : removal of once-called method File::WriteBase
8 integration of its code in formerly one-line method File::Write
10 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
12 replace the different values "??", "Unkn", "Unknown".
13 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
14 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
15 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
16 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
18 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
19 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
21 * Set the gdcm::Base class to some Printable classes
23 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * src/gdcmFile.[h|cxx] : add the Print method
25 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
26 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
27 * src/gdcmDocument.h : remove the PrintLevel informations
28 * Example/PrintFile.cxx : use the new gdcm::File::Print
30 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
31 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
32 problems when compiling with the python wrapping
34 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
35 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
36 writting in ImplicitVR
38 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
39 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
40 JPEG decompression, especially when dicom frames are split into several
41 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
42 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
44 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
45 * src/gdcmHeader.cxx : change the initialisation of default header.
46 Now, this header is readable by gdm, e-film, DicomWorks
48 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
49 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
50 Rename Decompressed to Raw
51 * Use the API changes in gdcm::File.
52 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
55 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
57 each added entry in the header. Replace the 'Planes' field by the 'Number
60 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
61 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
62 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
64 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
66 At this time, this image isn't readable by e-film... waiting JPR help to
69 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
71 DocEntry. Now use methods of the Document !
73 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
74 * Test/ShowDicomSeq.cxx : bug fix
76 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
78 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
79 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
80 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
82 * Test/TestCopyRescaleDicom.cxx : remove unused variable
83 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
84 containing found sequences
86 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
87 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
89 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
90 Some fields in BinEntry must be copied to not seg fault when making the :
91 gdcm::File *copy = new gdcm::File( copyH );
92 and tests are now made on good variables
94 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
95 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
96 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
98 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
99 * Add vtkGdcmWriter example and test
101 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
102 * Test/TestUtil.cxx : reformat the source code
103 * vtk/vtkGdcmReader.cxx : remove and change prints
104 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
106 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
107 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
109 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
110 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
111 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
113 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
114 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
115 by an eof to prevent all bad read of the file... and in this case, the
118 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
119 * Example/Volume2Dicom.cxx : comment unused variables
120 * Test/PrintDicomDir.cxx : comment unused variables
121 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
122 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
123 method that is redondant with AddEntry.
124 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
127 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
128 * Bug fix due my last commit (compilation under Windows).
129 * Example/Volume2Dicom : bug fix in the file and reformatting source code
130 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
132 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
134 - Remove printf / sprintf
135 - include iostream AFTER gdcm so we don't get warnings
136 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
138 - Also remove tons of include from header files, hopefully this should
139 speeup the compilation time, since it was becoming a dog slow.
140 - Remove gdcm.h as it include way too many files and slow down compilation
141 (plus it is not up to date)
142 - remove 'using namespace std' this is BAD !
144 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
145 * Remove memory leaks on the DicomDir
146 * Remove some useless datas in DicomDirObject
147 * Add usefull methods in SQItem, to be complient withe the ElementSet
149 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
150 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
152 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
153 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
154 future, with convertion)
155 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
156 and ImageDataSize values. Remove the method to get the PixelReadConverter
157 from the output of the class
159 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
160 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
162 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
163 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
164 and vtkErrorMacro use.
165 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
167 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
168 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
170 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
171 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
172 The string leaves only in the fonction. So when we make a .c_str(), we
173 get the pointeur on the first element, element that will be destroyed
174 immediately after thee instruction.
175 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
176 file has been opened : the test must be made on the content of the
177 pointer and not directly on the pointer !
180 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
181 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
182 the python part recompiles
184 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
185 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
186 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
187 X session is killed (for my computer... it seems to not be identic on
190 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
191 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
192 avoid problems (otherwise, the difference test between the visible image
193 and the reference is incorrect. If the reference is greater than the
194 screen resolution, it's produce errors).
195 Can be used for only one image. Can be used with a visible flag.
196 * vtk/vtkGdcmReader.cxx : remove commented codes.
197 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
198 under windows at compilation
199 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
201 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
203 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
204 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
205 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
206 tests on the image size X, Y, Z
208 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
209 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
210 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
211 between the class name and the file name
213 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
214 * src/ : fix compilation warnings for the Write method (2 different
215 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
216 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
217 variable... create a static method in gdcm::Document to access to
218 this variable content.
220 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
221 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
222 file, to be accessed by other files (like gdcmFile). Remove commented
223 code. Move the change of the header to the gdcmFile, using the
225 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
226 To be sure of that (and simplify calls), the Write of the header now
227 gets a file name and not a file pointer (std::ifstream).
228 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
229 DocEntryArchive. Remove all open of the written file
231 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
232 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
234 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
235 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
236 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
238 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
239 some corresponding methods. Write correctly the file and check before
241 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
242 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
243 is now on RGB datas (as before my last commit
244 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
246 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
247 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
248 Add a print information of the type of the entry
249 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
250 It was in the gdcmFile, and all write have been regrouped
251 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
252 Write correctly all dicom files (in decompressed mode only at this time)
253 * Test/ : test on files are now made using Raw datas and not color datas if
255 * Example/PrintFile.cxx : add more printings
257 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
258 * Amelioration of code, remove some code copy. For the loading of
259 BinEntry (in gdcmDocument), add the test to verify if the file is already
262 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
263 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
264 remove a DocEntry in the header (push an empty DocEntry)
265 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
266 lines. Bug fix in the initialization of the PixelConvert and the
268 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
269 use in TestCopyDicom (now this test can run under windows... but fails)
270 * Test/TestCopyDicom.cxx : amelioration of the test :
271 - test the pixels written
272 - add test points to quickly find where is the error
273 - can set a file name input and output in arguments
274 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
275 amelioration of the test output
277 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
278 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
279 all replaced DocEntry's
280 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
281 Now, each needed DocEntry to modify is duplicated, modified and inserted
282 to the header using DocEntryArchive. Thus, after save, we can restore the
283 header initial state.
285 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
286 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
288 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
289 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
290 correct to copy it. The DictEntry is specified at the DocEntry creation,
291 then, it musn't change in the time.
292 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
293 header correctly. At this time, the change is only made for the first
294 level of the Document. In the future, it might consider sequences.
295 The change is made by replacing a DocEntry by an other that is created
296 outside the class. The old value is kept. When we restore the header
297 status, the added DocEntry is deleted and replaced by the old value.
298 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
299 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
300 set the write type to explicit VR, implicit VR or ACR. Add methods to set
301 the write mode to native, decompressed or RGB (but not used at this time)
303 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
304 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
305 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
307 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
308 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
309 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
311 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
312 set because already copied when copying the BinEntry's of the header
313 * Test/TestAllReadCompareDicom.cxx : remove warnings
315 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
316 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
317 Two problems appear when doing it :
318 - with the gdcmFile : when the GetImageData method is called, the pixels
319 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
320 datas (pixels). And each structure destruct the datas when it's
321 destructed. So we have two destructions for the same datas. To solve it,
322 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
323 datas or not. If it doesn't own datas, then they will not destroyed by
325 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
326 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
327 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
328 create a double destruction of the same DocEntry's. So, to solve it,
329 the TagHT is simply cleared and the DicomDir* elements are destroyed.
330 * TODO : add an entry concerning memory leaks in the DicomDir
332 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
333 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
334 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
337 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
338 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
339 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
340 after it have been deleted
342 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
343 * FIX: src/* fix the doxygen warnings.
344 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
345 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
346 was erroneously defined with a size of 15 instead of 16. [many thanks
347 to Jean Michel Rouet for pointing out this bug].
349 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
350 1. Finish merging JMR patch for writting DICOM from scratch
351 2. Fix -hopefully- bug with MONOCHROME and space vs null character
352 3. Use const ref when possible
353 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
354 5. A few more comments
355 6. CreateUniqueUID can now be called without parameter"
357 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
358 * ENH: Slightly bigger patch:
359 1. Getting toward full integration of JMR patch for writting dicom from scratch
360 2. Update Test to test part of this patch: CreateUniqueUID
361 3. File was not close properly in gdcmDict
362 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
363 5. Use of const ref instead of copy (speed issue)
364 6. Remove temporary (duplicate) string in TranslateToKey
365 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
366 8. Do not repeat virtual in subclasses
367 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
369 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
370 * Apply first patch toward better string comparison when dealing with broken
371 DICOM files. Essentially the string could be padded with a space instead
372 of a null character as defined by standard
374 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
375 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
376 because never used... and in the same time, that's remove some memory leaks
378 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
379 * src/gdcmFile.cxx : now delete the PixelConvert instance.
380 * In examples and tests : change the type of image data variables from void*
381 to uint8_t*. Remmove all delete on image data variables
383 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
384 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
385 Verify the file pointer value before open the file, and if it's not null,
386 a verbose message is generated.
387 Close correctly the file when the file isn't considered dicom-like. The
388 correctly close is a call to CloseFile.
389 When closing the file pointer, test if its not null to close the file.
390 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
391 file. For an uncompressed image, the copied datas correspond in the least
392 case to the image size (calculated) or the image size specified in the
393 header. A verbose is generated if these two size mismatch
395 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
396 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
397 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
398 break under windows (with msvc6 compilation).
400 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
401 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
402 compiling with MSVC6)
404 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
405 * Bugs fix for the Windows build with VC6
406 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
407 needed (only for projects required VTK). If the VTK is included in all
408 projects, there is conflicts with the jpeg lib of vtk when compiling the
409 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
410 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
411 when compiling the gdcm_wrap.cxx file (created by the compilation of the
413 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
414 (like it's already made for the cout use). Otherwise, conflict with the
417 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
418 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
420 - comments on the DicomDir::Method related usage added.
421 - now that we use the namespace gdcm, a lot of internal classes do
422 NOT need to be wrapped anymore.
423 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
424 DicomDir::Method) new example added.
426 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
427 * Improve string manipulation. I now inforce the notion of 'DicomString'
428 A DicomString can contain as many \0 as they want
429 and it is *always* of even length.
430 We only support odd length for very rare case.
431 And in the near future this should be removed.
433 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
434 * /binary_write/ gdcm source. Now even on big endian we are writting
435 little endian. This should -heopfully- fix some tests
437 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
438 * Now the dictionary is compiled into gdcm lib. This is a default
439 behavior, thus any dic file specified is picked before failback to
440 the one comiled into lib
442 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
443 * Change internals for gdcmDict. Don't use any 'new' any more.
444 This should definitely solve any leak problem, and we should be
445 as fast as before, as long as don't modify too much the dictionary.
447 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
448 * STYLE: ivars should start with a capital letter.
449 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
450 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
452 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
453 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
454 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
455 new 2004 dictionaries added (thanks to JPR).
456 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
457 * CLEANUP_ROUND (15) for gdcmPixelConvert
458 - RLEFrame::NumberFragments is now of type unsigned int
459 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
460 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
463 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
464 * Initial work in gathering all transfer syntax accessors. clearly
465 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
466 ivars, but only one transfersyntax (class) ivar with equivalent method on
469 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
470 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
471 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
472 discussed (plus I didn't like having a 2000 lines patch not commited)
474 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
475 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
476 * CLEANUP_ROUND (14) for gdcmPixelConvert
477 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
478 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
479 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
481 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
482 anymore and hence avoids storing a copy of PixelConvert::Decompressed
483 into File::Pixel_Data.
485 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
486 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
487 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
488 * CLEANUP_ROUND (13) for gdcmPixelConvert
489 Substituted File::ParsePixelData() with PixelConvert::Print() new
491 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
492 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
493 method to those classes.
494 - src/gdcmFile.[cxx|h]:
495 -- Added a ::Print() method.
496 -- PixelConverter is now a reference instead of a member.
497 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
498 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
500 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
501 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
502 collaboration diagram and inheritance diagram should be generated with
504 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
505 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
506 pointlessly wrapped (see
507 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
508 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
509 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
510 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
511 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
512 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
513 -- File::Initialise: PixelConverter setup moved away to
514 PixelConverter::GrabInformationsFromHeader()
515 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
516 interpretation moved away to PixelConverter::BuildRGBImage()
518 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
519 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
520 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
522 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
523 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
524 displayed on Win32 when a brutal abort() occurs (because of uncatched
525 exception). See TODO new entry of this commit for more on this.
526 * TODO added new entry.
527 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
528 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
529 - HandleColor is no longer called from gdcmFile.cxx
530 - gdcmPixelConvert.cxx clean up on method arguments and internal
531 variable names for semantical coherence.
533 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
534 * Finished lossless transition, not only do we now read all lossless jpeg
535 images, without the need of the Cornwell lib, but we do read them properly now
536 * To reduce code (well to avoid code duplication), I defined a common place
537 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
538 redefine symbols. This is not prefect but this the best solution I found for a
539 compilation time jpeg option.
541 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
542 * Update jpeg ijg lib to support lossless jpeg implementation
543 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
545 * Also added a special copyright for dcmtk since we use their bugfixes.
548 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
549 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
550 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
551 matters, as stated in warning note at begining of %include section).
552 * src/gdcmDicomDir*.[cxx|h]: coding style
553 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
554 * src/gdcmJpeg8.cxx: doxygen fix.
555 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
556 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
557 from File:: to PixelConvert::.
559 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
560 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
561 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
562 - more code moved away from File:: to PixelConvert::
563 - fat setup of PixelConverter set in place in File::Initialise.
565 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
566 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
567 namespace at the file system level. So now you should convert your examples
569 gdcmHeader -> gdcm::Header
570 It would be nice if people keep in mind to no open the namespace, since it
571 allows compilation on broken plateform which were defining common symbol in
572 the standart namespace (like LP, Unknown ...)
574 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
575 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
576 The JPEG fragments are now parsed at the same stage than the RLE
577 information. All code related to JPEG is now in gdcmPixelConvert:
578 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
579 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
580 export a gdcmFile:: method. Those are simply global functions
581 (for the time being this is better than having them attach to
582 either gdcmFile:: or gdcmPixelConvert::).
583 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
584 and stores the result in a gdcmJPEGFragmentsInfo.
585 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
586 code (among other stuff) moved away from gdcmFile:; to
589 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
590 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
591 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
592 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
593 clean up of RLE related code.
594 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
595 - src/gdcmRLE.cxx removed
596 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
597 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
598 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
599 * CLEANUP_ROUND (9) for gdcmPixelConvert
600 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
601 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
602 away from gdcmFile:: to gdcmPixelConvert::.
604 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
605 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
606 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
607 This is because Parse7Fe0 used to parse the pixels to compute the
608 length. This task was passed over to FindDocEntryLengthOB() a long
609 time ago, EXCEPT I had forgotten the OW case...
610 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
611 we just recylce the code for parsing RLE fragments and computing
613 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
614 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
615 with the retired Parse7Fe0().
616 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
617 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
619 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
620 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
621 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
622 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
623 - src/CMakeLists.txt: alphabetic order reodering + new entries.
624 * CLEANUP_ROUND (4) for gdcmPixelConvert
625 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
626 to return an unused length.
628 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
629 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
630 this should be cleanner from the plane view. The iostream are erally a pain
631 to use to do simple stuff.
633 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
634 * Redo the compilation of the ijg jpeg library. Now only one source is
635 necesseray. No need to rename file by hand what so ever. CMake handle the
636 copying of the file within different directory, configure header file to
637 modify some symbol. The only addition made to ijg wasd a mangle table so
638 that symbol are different wether we are within 8bits or 12bits.
640 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
641 * Added documentation of vtkgdcmReader on Website:
642 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
643 with it's binary name).
644 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
645 the Website to be more complete.
646 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
647 doxygenated documentation.
648 - Doc/DoxyVtkGdcmReaderExamples.txt added
649 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
650 DoxyVtkGdmReaderExamples.html )
651 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
652 * CLEANUP_ROUND (3) for gdcmPixelConvert
653 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
655 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
656 * CLEANUP_ROUND (2) for gdcmPixelConvert
657 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
659 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
660 * CLEANUP_ROUND for gdcmPixelConvert:
661 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
662 - src/gdcmPixelStuff[h|cxx] removed
663 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
664 - src/CMakeLists.txt changed accordingly
666 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
667 gdcmVersion.py moved to newly created ATTIC related
668 gdcmPython/SetupOldies/ directory.
669 * Autotools clean up:
670 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
671 - autogen.sh configure.in acinclude.m4 python.m4 removed
673 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
674 * src/*.cxx *.h Reference to License.htm fixed to License.html.
675 * Doc/CMakeLists.txt, doxygen.config.in: fix.
676 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
678 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
679 * TODO updated with Mathieu suggestions. I proposed a template for
680 describing TODO entries and used it for new entries.
681 * Added Doc/Website/CodingStyle.html, Developpers.html,
682 DeveloppersPython.html, GdcmDataCvs.html and
683 DownloadVersion0_1.html, DownloadVersion0_3.html.
684 * Some Doc/*.txt Doxygen files (which do not really concern the
685 documentation itself, but the website) moved to html and
686 placed in directory Doc/Website:
687 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
688 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
689 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
690 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
691 * CMakeLists.txt changed accordingly.
692 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
693 DeveloppersPython.html
694 * INSTALL nows refers to Doc/Website/Installation.html
696 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
697 * Added Doc/Website directory, that contains a first raw version
700 2004-09-23 Jean-Pierre Roux
701 * FIX In order not to be poluted any longer by casting problems,
702 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
703 we can now delete[] it safely
704 * VoidArea is now called BinArea (less confusing name),
705 and all the methods called ...VoidArea... are now ... BinArea...
706 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
708 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
709 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
710 clear) TagHT, which is an inherited member of gdcmElementSet. It is
711 up to the destructor of gdcmElementSet to clean up TagHt and it's
714 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
715 * Test/CMakeLists.txt: update to follow gdcmData renamings.
716 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
718 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
719 * ENH: added some utility method that builds a flat dictionnary
720 holding all the Dicom entries contained in the recursive structure
721 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
723 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
724 BuildFlatHashTable() that build a flat dictionary.
725 - src/gdcmElementSet.h: added a new private GetTag() accessor.
726 gdcmDocument is now a friend of gdcmElementSet.
727 - src/gdcmElementSet.cxx: clean up.
728 - Example/FlatHashTablePrint.cxx added.
729 - Example/CmakeLists.txt changed accordingly
731 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
732 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
733 moved away from gdcmDocEntrySet (since this class is an abstract class
734 acting like an interface). SQDepthLevel and BaseTagKey are now
736 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
737 and associated accessors. Doxygenation of the class.
738 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
740 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
741 Use SQDepthLevel accessor instead. ::Print() adapted.
742 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
743 - src/gdcmDocument.cxx changed accordingly.
745 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
746 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
747 - The following is the doxygen comment of the typedef declaration
748 of gdcmagKey in src/gdcmCommon.h:
749 gdcmTagKey is made to old an "universal" (as in URL, Universal
750 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
751 A dicom tag allways has a group and an element, but a set of tags
752 embeded in various (optionally nested) sequences and sharing
753 the same group and element all share the same (group, element)
754 "identifier". Hence the (group, element) cannot be used as an
755 identifier (in gdcm we shall refer to a "TagKey") of a tag.
756 In order to construct a proper tag identifier (i.e. a key) we
757 consider the following definition of a TagKey:
758 - let Group, Element be the string representation of the
759 group and element dicom tag members,
760 - let ItemNumber be the string representation of the integer
761 index of the considered item number of a sequence,
762 Let the key of a tag embeded in a sequence, noted SeqTag, be
764 /ItemNumber#Group|Element
765 where "/", "#" and "|" are characters acting as separators.
766 Then the general form of a gdcmTagKey is given by:
767 Group|Element<SeqTag>
768 where <SeqTag> means NO or many instances of SeqTag.
769 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
772 but the gdcmTagKey of a tag "embeded" is the first item of
773 a sequence, itself nested in the third item of a sequence is the
775 0004|1220/2#0008|0082/0#0008|0090
776 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
777 order to hold the new sequence compatible key. Previously, the
778 GetKey() method would look in the underlying gdcmDictEntry.
779 - src/gdcmDocEntry.cxx:
780 -- constructor now copies the underlying DictEntry key, in the local
782 -- ::Print: displays the member Key, instead of the (group, element).
783 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
784 - src/gdcmDocEntrySet.h:xi
785 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
786 -- now has a new BaseTagKey member.
788 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
789 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
791 This poses the problem with the semantics of the following lines
792 LoadEntryVoidArea(0x0028,0x1201); // R LUT
793 LoadEntryVoidArea(0x0028,0x1202); // G LUT
794 LoadEntryVoidArea(0x0028,0x1203); // B LUT
795 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
796 to the long FIXME note for what the problem is. Nevertheless in
797 order to get things working the dicom dictionary was altered !
798 Please fix things urgently...
799 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
800 information), see above note on moving the member VoidArea. Nevertheless
801 the following entries previously correctly set as US are now inproperly
803 0028 1201 OW IMG Red Palette Color Lookup Table Data
804 0028 1202 OW IMG Green Palette Color Lookup Table Data
805 0028 1203 OW IMG Blue Palette Color Lookup Table Data
806 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
807 of gdcmDocEntry moved to gdcmSeqEntry.
808 * src/gdcmSeqEntry.cxx: STYLE.
810 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
811 * Test/TestAllEntryVerify.cxx minor fix and added comments.
813 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
814 * gdcmPython/testSuite.py: all the test suite in python is now moved
815 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
816 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
817 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
819 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
820 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
821 to avoid inclusion recursion until STL is reached.
822 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
823 mecanism. errno.h is not included in gdcm anymore.
824 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
825 (gdcmFormatError now inherits from gdcmFormatUnexpected).
827 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
828 gdcmData/TestAllEntryVerifyReference.txt
829 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
830 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
831 exception_on_error parameter.
832 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
833 - vtk/vtkGdcmReader.cxx changed accordingly,
834 - Example/*.cxx and Test/*.cxx changed accordingly.
836 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
837 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
838 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
839 enable_sequences removed from gdcmHeader constructor and dependencies.
840 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
841 * gdcmPython/demo/PrintHeader.py: dummy fix.
842 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
843 skip_shadow removed from gdcmHeader constructor and dependencies.
844 * Example/*.cxx and Test/*.cxx changed accordingly.
846 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
847 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
848 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
850 2004-07-21 Jean-Pierre Roux
851 * FIX Now, Parsing and Printing a DICOMDIR do work!
852 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
854 2004-07-20 Jean-Pierre Roux
855 * FIX Some brain damaged headers have Zero-Lenght fields
856 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
858 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
859 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
860 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
861 variable (instance of gdcmDebug) by a definition macro, and the instance
862 is now in static in the gdcmDebug class
863 * src/gdcmSQItem.h : (FIXME) remove an undefined method
864 * Test/PrintAllDocument.cxx : bug fix in the result of the test
866 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
867 * WARNING: ctest now depends more tightly on gdcmData. You should
868 check out gdcmData properly for things to run smoothly...
869 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
870 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
871 we need the pixels not be loaded in order to use the ValEntry
872 that displays position and size).
873 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
874 This is a C++ based equivalent of gdcmPython/testSuite.py that should
875 be deprecated. If you have any doubts about the advantages of a
876 modern scripting language (read Python) versus grass root C++ (i.e.
877 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
878 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
879 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
880 Anyhow, consider documenting the gdcmData images in
881 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
883 * Test/CMakeLists.txt:
884 - now uses TestAllEntryVerify.cxx
885 - specific comments on oldACR00001.ima (now renamed in gdcmData
886 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
887 gdcmData/TestAllEntryVerifyReference.txt
890 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
891 * src/*.[h|cxx] : typedef clean up
892 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
893 - TagKey renamed to gdcmTagKey (for external usage)
894 - VRKey renamed to gdcmVRKey (for external usage)
895 - removal of typedef duplication.
896 - Removed all unecessary inline keyword from class inline definitions.
897 - Some method|function(void) declarations replaced with method|function().
898 * src/jpeg/libijg12/jdhuff12.c:
899 - printf polluting ctest removed.
900 - TAB removal for comminting
902 - TestAllReadCompareDicom.cxx: added a test that compares all the
903 images in gdcmDataImages.h with corresponding images in
904 gdcmData/BaselineDicom/. When baseline images are not present
905 this test creates them.
906 Note: we need to validate each reference image, but before that
907 I'd like to rename them with a more explicit name...
908 - CMakeLists.txt: changed accordingly.
909 * Example/*.cxx: examples now only include gdcm.h (as opposed to
910 including each header needed).
912 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
913 * Test/*.cxx and Example/*.cxx: moved some examples away from the
914 test suite to the Example directory. Are concerned:
919 - TestWriteSimple.cxx
920 * Test/CMakeLists.txt: added some comments on reasons for black listing
921 image gdcmData/oldACR00001.ima
923 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
924 * Test/CmakeList.txt: removed the following from black list (to be coherent
925 with removal from gdcmData):
926 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
927 - gdcm-MR-PHILIPS-16.dcm
929 Added the following because after last cvs update, they cause
930 ctest -R TestReadWriteReadCompare
932 - gdcm-MR-SIEMENS-16-1.acr
934 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
935 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
936 new comments in this file) we temporarily (sigh) move to a weaker
938 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
939 we don't need to black list the following images anymore:
940 - 8BitsUncompressedColor.dcm
942 - US-PAL-8-10x-echo.dcm
943 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
944 fixes and the beautified code ;-)
945 This fixes the bug introduced in version 1.42 (when beautifying)
946 that made the parsing of 8BitsRunLengthColor.dcm unproper.
947 Note: ctest was blind to this bug (this means we need to still
948 improve the test suite). The bug could be detected by using
949 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
951 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
952 and by displaying the (garbage) produced file temp.XDCM...
954 2004-06-29 Jean-Pierre Roux
955 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
956 - replace by uggly but working old code :-(
957 A lot of things should be OK again.
958 It's really urgent to have a test suite that *tests*,
959 to prevent Frog's beautifying sessions to break all the stuff
960 (twice, withing a fortnigh ...)
962 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
963 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
964 redundancy) to added Test/TestReadWriteReadCompare.cxx
965 * Test/CmakeList.txt: because the compare test of
966 Test/TestReadWriteReadCompare.cxx fails, the following images are
967 black listed: - 8BitsUncompressedColor.dcm
969 - US-PAL-8-10x-echo.dcm
970 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
971 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
972 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
973 and ad-hoc kludge. This kludge is now removed, and on encountering
974 such an image (OB field brain damaged) we set errno. Then in
975 ::FindDocLength() we "fix" the length as being ALL what remains
976 in the file (until EOF). We then proceed, hoping for the best...
977 This fixes a SegFault in ShowDicom when trying to write such an
979 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
980 (because TestWriteRead breaks on it, after a non conformal commit?).
981 ctest now runs properly, except for MakeDicomDir (which was allways
982 broken) and the Python related stuff (still not fixed).
984 2004-06-24 Jean-Pierre Roux
985 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
986 FIX : Test/TestReadWrite now iterates on all the file names
987 (instead of infinite loop)
988 ENH : Test/TestWriteRead now iterates on all the file names
990 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
991 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
993 2004-06-24 Jean-Pierre Roux
994 FIX : - now Write drops LUT Descriptors and LUTs (if any)
995 when SamplesPerPixel =3
996 - now Write is no longer confused by
997 'BitsAllocated = 12" and 'BitsStored=12"
998 - "UN" value representation Elements are now written correctly
999 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1000 ENH : - now gdcmHeader has its own Write methods
1001 (in order to split the job that has not to be done
1004 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1005 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1006 loop on the same image until memory went out.
1007 Note: this means we still have gobs of memory loss in PrintDocument
1008 * src/gdcmDocument.cxx: fixes problem on parsing on file
1009 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1011 2004-06-24 Jean-Pierre Roux
1012 FIX : Write - All the Sequences and Sequence Item are now written
1013 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1014 is added a the end, when necessary.
1015 - A lot of brain-damaged images, that were read correctly are
1016 now written correctly
1017 - length compatible BinEntry are now loaded correctly
1018 (even for odd groups)
1019 Note : only Explicit Value Representation was checked.
1020 (question : is implicit VR really necessary for gdcm ?)
1022 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1023 * DEVELOPPER: added a proposition of coding style.
1024 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1027 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1028 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1029 Use the gdcmDocEntry::Print() and Write() instead.
1030 * src/gdcmDocument.cxx: bug fix.
1032 2004-06-22 Jean-Pierre Roux
1033 FIX : gdcmDocument.cxx
1034 - Now we do recognize the JpegLossLess format (there was a misstyping in
1035 code 'beautyfication' :-(
1036 - Now we automaticaticaly load the Luts, if any
1038 2004-06-22 Jean-Pierre Roux
1039 In order : to write Sequences, whatever their imbrication level,
1040 : to allow user to create his own Sequences
1041 a lot of modif where necessary (adding, moving, or virtualising methods)
1043 WARNING : save your own sources *before* cvs up !
1046 ADD virtual void Write(FILE *fp, FileType filetype);
1049 ADD virtual void Write(FILE *fp, FileType filetype);
1050 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1053 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1054 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1055 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1056 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1057 ADD std::string GetEntryByName(TagName name);
1058 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1060 std::string vr = "unkn",
1061 std::string fourth = "unkn",
1062 std::string name = "unkn");
1063 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1064 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1065 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1066 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1067 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1068 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1069 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1070 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1073 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1074 ADD virtual std::string GetEntryByName (TagName tagName);
1075 ADD virtual std::string GetEntryVRByName (TagName tagName);
1076 REM virtual bool Write(FILE *, FileType);
1077 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1078 FILE *_fp, FileType type);
1079 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1080 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1081 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1082 REM virtual std::string GetEntryByName (std::string tagName);
1083 REM virtual std::string GetEntryVRByName (std::string tagName);
1084 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1085 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1086 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1088 std::string vr = "unkn",
1089 std::string fourth = "unkn",
1090 std::string name = "unkn");
1091 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1092 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1093 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1094 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1097 ADD virtual void Write(FILE *fp, FileType filetype);
1100 ADD virtual void Write(FILE *fp,FileType filetype);
1103 ADD virtual void Write(FILE *fp, FileType filetype);
1104 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1105 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1106 REM std::string GetEntryByName(TagName name);
1109 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1111 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1112 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1113 The default constructor invoked by the line
1114 gdcmHeader *f1 = new gdcmHeader( header );
1115 was gdcmHeader::gdcmHeader(bool) instead of the expected
1116 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1117 Hence the parsing wasn't executed... See also below.
1118 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1119 as explicit constructor didn't do the trick to fix the above problem.
1120 Could anyone explain why ?
1121 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1122 properly calls gdcmValEntry::Print() (that was weed out from
1123 code related to gdcmBinEntry).
1125 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1126 * In order to fix memory leaks:
1127 - Test/TestWriteSimple.cxx: added cleaning of free store through
1129 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1130 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1131 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1132 (through the call to ::AddDicomDirMeta()) or the destructor
1133 would crash when deleting uninitialized ::metaElems].
1134 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1135 - src/gdcmDocument.cxx:
1136 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1137 from dynamic stores.
1138 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1139 was causing memory leaks.
1140 - src/gdcmSQItem.cxx:
1141 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1142 cleanly handled with polymophism: sorry but my milage is low).
1143 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1144 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1145 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1146 This avoids SegFaulting.
1147 - src/gdcmSQItem.h: coding style.
1149 - Test/TestWriteSimple still severely sucks. The output image content
1150 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1151 damaged when displayed with vtkgdcmViewer.
1152 - on memory leaks: TestWriteSimple leaks really less (see entry
1153 of 2004-06-18 in Changelog file for the call to valgrind).
1154 - on segfaults: ctest now passes all the tests but one (no more
1156 * Erroneous leading white fix:
1157 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1158 white[s] (as opposed to from >> xxx, that removes it [them].
1159 - src/gdcmTS.cxx: ditto.
1160 - gdcmPython/testSuite.py: dirty related kludge removed.
1161 * src/*: remaining references to gdcmParser removed.
1162 * src/*[cxx|h]: added copy[way]left header.
1165 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1166 * In order to fix writing of dicom files:
1167 - Test/TestWriteSimple.cxx: a simpler example of writing.
1168 - Test/CMakeLists.txt changed accordingly.
1169 - src/gdcmDocument.cxx:
1170 -- The destructor now recursilvely removes potential sequences.
1171 -- Bug fix in ::IsJPEG2000()
1172 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1173 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1175 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1176 to only declared) and build on top of
1177 ::GetDocEntryByNumber(guint16, guint16).
1178 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1179 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1180 for usage in destructor and treatement of promotion in
1181 ::ReplaceOrCreateByNumber().
1182 - src/gdcmSQItem.cxx: destructor should better handle his job.
1183 Test/TestWriteSimple now runs (or at least it DOES something).
1184 * We can now start hutting memory links. A good starting point is:
1185 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1186 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1187 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1189 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1190 * Valgrind note: after Mathieu Malaterre teached me how to read
1191 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1193 Using gcc, you can force the STL to use malloc and to free memory as
1194 soon as possible by globally disabling memory caching.
1195 With 3.2.2 and later, you should export the environment variable
1196 GLIBCPP_FORCE_NEW before running your program.
1197 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1198 simply vanish (it is still not clear to me, whether this means that
1199 STL std::string leaks or if valgrind believes it leaks...).
1200 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1201 running bin/gdcmTests makeDicomDir):
1202 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1203 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1205 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1206 SegFaulting (I drowned in DicomDir related code when trying to
1207 understand why the list is empty...).
1208 * src/gdcmDocument.h: first BSD license header try.
1209 * Doc/License.txt added.
1211 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1212 * src/gdcmDocument.[h|cxx]:
1213 - Clean up of the Transfer related predicates. They are now all based
1214 on new method isGivenTransferSyntax, that (should) handle properly
1215 the padding problem.
1216 - general clean up, simplification, and coding style.
1217 - Specific clean up of Parse7FE0() (umproperly named actually).
1218 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1220 2004-06-14 Jean-Pierre Roux
1222 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1223 - fix the display of SQItem ordinal number
1224 - add the GetSQItemByOrdinalNumber method
1225 - remove some useless never written private methods
1227 2004-06-14 Jean-Pierre Roux
1229 - adding a constructor taking a gdcmDocEntry as an input param
1230 - ReplaceOrCreateByNumber now returns :
1231 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1232 a gdcmValEntry * if a string value is passed as a param
1234 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1235 according to the param type (no longer sets a gdcmDocEntry)
1236 - GetValEntryByNumber, GetBinEntryByNumber added
1237 - NewValEntryByNumber and NewBinEntryByNumber added
1239 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1241 - GetSQItemNumber and SetSQItemNumber added, to provide
1242 a (relative) Item identier inside a given Sequence
1243 \warning : some pb remaining around this number
1245 - AddEntry now takes the Item Number as a param
1247 - adding a constructor taking a gdcmDocEntry as an input param
1249 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1250 * Memory leak hunt with the following command:
1251 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1252 --show-reachable=yes gdcmTests PrintDocument
1253 It looks like many (all?) leaks are due to the STL (or a bad usage
1254 of the STL. The lines producing the leaks now have a comment with
1255 a "MEMORY LEAK" tag: you can retrieve them with
1256 grep "MEMORY LEAK" src/*
1257 Here are two typical examples which I can't help fixing:
1262 char * test = "babo";
1263 name = test; //// <--- valgrind detects 960 bytes lost in
1264 //// call to std::string::operator=(char const*)
1265 name.clear(); //// Doesn't help !
1273 std::cout << "Type a bunch of characters followed by RETURN: ";
1274 getline(std::cin, line); //// <--- valgrind dectects a loss
1275 //// of 1320 bytes in call to
1276 /// std::basic_istream<>& std::getline<>
1282 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1283 * src/gdcmHeader.[cxx|h]:
1284 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1285 and related, moved away to gdcmDocument.
1286 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1287 the corresponding protected accessors of inherited class
1288 gdcmDocument, removed ! As a consequence gdcmFile had to be
1289 declared friend of class gdcmDocument (see below).
1290 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1291 - Clean up of undefined or unused methods.
1292 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1293 account the changes to gdcmHeader.h).
1294 * src/gdcmDocument.h:
1295 - gdcmFile is now a friend class (in order to take into account the
1296 changes to gdcmHeader.h).
1297 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1298 (see changes to gdcmHeader.h).
1299 - Accessors (reading on the form GetEntry*) are now public.
1300 - Clean up of undefined or unused methods.
1301 * src/gdcmDocument.cxx:
1302 - adaptation to changes to gdcmDocument.h
1303 - ::OpenFile now writes a verbose message when file cannot be opened.
1304 - some std::string properly set to VRKey
1305 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1306 references to gdcmDocument.
1307 * Test/TestFindTags.cxx: changed accordingly to above changes.
1308 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1309 cvs repository gdcmData.
1311 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1312 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1313 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1314 conflicts with gdcmValEntry::voidArea.
1315 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1316 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1317 Value representation between StringRepresentable and BinaryRepresentable.
1318 * src/gdcmDocument.cxx:
1319 - method ParseDES: proper indentation restored and usage of
1320 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1321 - method LoadDocEntry: the fingerprint left in the SetValue() of
1322 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1323 removed. Reverting to previous code segment with the proper
1324 dynamic_cast< gdcmValEntry* >.
1325 Note: this was (partially) breaking the python test suite
1326 (gdcmPython/testSuite.py) that made usage of the above
1327 fingerprint to check presence of "Pixel Data".
1328 * src/gdcmDocEntry.h: coding style.
1329 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1330 now taken into account.
1331 * gdcmPython/gdcm.i: adaptation to the new internal representation
1332 of gdcm (exit gdcmParser, hello gdcmDocument).
1333 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1335 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1336 anymore, but instead prints the loaded Python dictionary.
1337 * .... alas, the python testSuite is still broken.
1339 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1340 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1342 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1343 * src/gdcmUtil.h : export methods
1345 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1346 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1348 * Initial addition of automatic python testing
1349 * Initial addition of automatic image comparison
1351 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1352 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1353 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1355 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1356 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1357 * Test/ShowDicom.cxx : bug fix for msvc compilation
1358 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1360 2004-05-04 Jean-Pierre Roux
1361 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1362 new concepts (and new classes) :
1363 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1364 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1365 - Sequence Doc Entries (gdcmSeqEntries)
1366 a Sequence is composed of Items.
1367 Each item is a set of Doc Entries (this is recursive)
1368 The non uniqueness of the 'Dicom tag' is due to this recursivity
1369 (never taken into account)
1370 Our unability to add a new 'entry' in the header
1371 at the proper location (neither in the H-Table (map or multimap),
1372 nor in the Chained List is also due to this recursivity.
1373 Don't try, right now, to use/modify/compile these new sources :
1374 nothing is finished.
1375 We just commit all the stuff, 'as is', in order not to loose it.
1377 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1378 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1380 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1381 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1382 file prefix (SetFilePrefix)
1384 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1385 * Add a new test: ShowDicom, for now this is just the c++ version of
1386 checkRead.sh, later it will be able to compare the image read against a
1388 * Replace the DEBUG on the stack with a global entry in cmake interface:
1389 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1391 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1392 * Add an example subdir, with a real example on how to read + write a
1395 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1396 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1397 * Doc/CMakeLists.txt: the main page is now properly differentiated
1398 between the developper and user version.
1399 * Doc/doxygen.config.in: dropped search related obsolete flags
1400 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1402 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1403 * DEVELOPPER: added some helpfull comments for compile/test/install
1406 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1407 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1408 src directory, now generated in the build dir.
1409 2. Tests as mentionned smarter
1411 4. Add a new method in gdcmDict that return the PubDict by name
1412 this is interesting for 3rd party lib like ITK,
1413 where we could set the institution name / patient name...
1415 * ENH: 1. Now the test suite is working for real
1416 2. All binaries are now output in the gdcm-bin directory
1417 (this was not true before)
1419 2004-04-28 Jean-Pierre Roux
1420 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1421 SeQuence indented printing of Dicom Header.
1422 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1423 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1424 Computation of SQDepthLevel is now part of gdcmHeader constructor
1425 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1426 tree-like structure of a Dicom Header.
1427 * FIX Test code cleaning
1429 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1430 * ENH: Adding automatic testing
1431 1. Need a DartConfig.cmake to submit to public
1432 2. Add a test driver gdcmTest.cxx
1433 3. gdcmTestMain, an helper for the main test driver gdcmTest
1434 4. Files in Test don't have a main anymore, this becomes interesting
1435 when we add more and more tests, thus dsw don't have to load
1437 * ENH: Adding a GDCM_DATA_ROOT for testing
1438 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1439 one file instead of seven + some small cleanup
1441 2004-04-22 Jean-Pierre Roux
1442 * ENH Minor changes to the Print() methods.
1443 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1444 Header printing. Example given with :
1445 > PrintHeader fileName 2 new
1446 (SQ based tree-like structure still to be done for the Header ...)
1448 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1449 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1450 1. I have added some unsigned where needed
1451 2. Some function parameter not used -> (void)
1452 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1453 4. g++ don't like character '\' in comment
1454 5. #define jpeg_create_decompress jCreaDecompress
1455 this really need to be fixed
1456 6. virtualize destructor of gdcmObject ... leakage
1457 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1458 this also really need to be fixed
1459 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1460 remove compression file
1461 (as we only do decompression, right ?)
1462 * ENH: Change malloc/calloc/free with c++ equivalent
1464 2004-04-21 Jean-Pierre Roux
1465 * FIX gdcmHeaderHelper::GetXSpacing
1466 when a single value is found (bug ?), xpacing is now
1467 defaulted to yspacing
1469 2004-04-19 Jean-Pierre Roux
1470 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1471 * ENH add parameters :
1472 bool exception_on_error = false,
1473 bool enable_sequences = false,
1474 bool ignore_shadow = false
1475 to the gdcmFile constructors to be full gdcmParser compliant
1476 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1477 to allow reading of PAPYRUS 3.0 files
1479 2004-04-06 Jean-Pierre Roux
1480 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1482 2004-04-02 Jean-Pierre Roux
1483 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1484 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1485 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1487 2004-03-30 Jean-Pierre Roux
1488 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1489 for ACR file, written out as DICOM files (hope so...)
1491 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1492 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1493 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1494 moved to base class gdcmParser and only the specialisation is kept
1496 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1497 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1498 already does the job.
1499 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1500 (to be consistent with gdcmParser::WriteEntries).
1502 2004-03-30 Benoit Regrain
1503 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1504 upate of the object's instance. It's passed to 2 in the unfavorable
1505 case : one in the ExecuteInformation, one in the ExecuteData
1507 2004-03-29 Jean-Pierre Roux
1508 * ENH : Check on file type to be written moved
1509 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1510 * FIX : gdcmObject::ResetBoundaries now stops properly
1511 when end-of-list is reached
1512 : gdcmVersion modified (as Benoit Regrain asked)
1514 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1515 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1516 * src/gdcmUtil.cxx: added forgotten iostream include.
1517 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1518 equivalent to ExplicitVR in existing code).
1520 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1521 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1522 now contains all the gdcmGlobal related code.
1523 * minor coding style and doxygenation changes.
1525 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1526 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1527 now contains all the Debug related code.
1528 * minor clean-up of includes in src/*.cxx
1529 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1530 CreateCleanString) removed.
1531 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1532 * Doc/DoxyMainPageUser.txt added.
1533 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1534 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1535 src/gdcmDirList.cxx)
1537 2004-03-24 Jean-Pierre Roux
1538 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1540 2004-03-23 Jean-Pierre Roux
1541 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1542 big endian made volumes
1543 * ENH Now gdcmParser constructor and destructor are protected to forbid
1544 end user to instanciate class gdcmParser
1545 (only gdcmHeader and gdcmDicomDir are meaningfull)
1547 2004-03-22 Benoit Regrain
1548 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1549 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1550 gdcmSerie to gdcmDicomDirSerie
1552 2004-03-19 Jean-Pierre Roux
1553 * ENH Now the tree-like structure describing a DICOMDIR comming from
1554 an already existing DICOMDIR file is consistent with
1555 the home-made tree-like structure build ex-nihilo
1556 or build from the files held (recursively) in a Directory
1557 functions gdcmDicomDir::CheckBoundaries()
1558 gdcmObject::SetBoundaries() added
1560 2004-03-17 Jean-Pierre Roux
1561 * REM (Eric Boix bug) : removal of meaningless
1562 gdcmDicomDirImage::NewImage function.
1563 * FIX now file names and directory name are written properly in the
1565 * FIX now gdcmDicomDir constructor may be call without any trick
1568 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1569 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1570 of gdcmDicomDirImage::NewImage as empty function.
1572 2004-02-28 Jean-Pierre Roux
1573 * ENH add gdcmDicomDir:NewPatient
1574 add gdcmDicomDirPatient:NewStudy
1575 add gdcmDicomDirStudy:NewSerie
1576 add gdcmDicomDirSerie:NewImage
1577 to allow making gdcDicomDir object.
1578 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1579 (as opposite to the gdcmHeader chained list)
1581 2004-02-11 Benoit Regrain
1582 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1583 when using from python
1585 2004-02-10 Benoit Regrain
1586 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1587 * FIX : in gdcmDicomDir when the directory is empty
1588 * ENH : add callback and methods to get the progression of dicomDir
1591 2004-02-06 Jean-Pierre Roux
1592 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1593 - GDCM_META added to gdcmDicomDirType
1594 - class gdcmMeta created
1595 * ENH : - A brief summary is now displayed at the beginning of
1596 'testDicomDir' to help disaster magnitude estimation
1597 * REM : Now useless Test/explDICOMDIR.cxx
1599 2004-02-05 Benoit Regrain
1600 * ENH : add methods in gdcmObject to get the hash table or the list of
1602 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1603 * FIX : wrapping python for TagHeaderEntryHT
1605 2004-02-04 Benoit Regrain
1606 * FIX : even length for some strings when writting the dicom dir
1607 * FIX : sort the images in the dicom dir
1608 * FIX : Bug fix for python use of dicom dir
1609 * ADD : a python demo
1611 2004-02-04 Jean-Pierre Roux
1612 * FIX : Final solution (?) for icone embedded images
1613 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1614 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1615 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1616 gdcmData/gdcm-MR-SIEMENS-16.acr1
1617 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1618 to make full checking easier
1620 2004-02-04 Benoit Regrain
1621 * FIX : WriteEntries : coding style & logic in parameters
1622 * FIX : Set the elements to create the DicomDir in a dictionary file
1624 2004-02-03 Benoit Regrain
1625 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1626 * gdcmDicomDir : add the load of directory
1627 * Bug fix and print add-on
1629 2004-02-03 Jean-Pierre Roux
1630 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1631 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1632 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1633 * FIX gdcmParser.cxx : 'group length' elements are now considered
1634 as integers, even for shadow groups, when file is Implicit VR
1636 2004-02-02 Jean-Pierre Roux
1637 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1639 of the last synonym :-(
1640 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1642 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1643 * FIX taking into account the possible 7fe0,0010 multiplicity
1644 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1645 to allow removal of references to 7fe0,0010, to deal with
1646 ACR-NEMA images, when 0028,0200 is meaningfull
1648 2004-01-31 Jean-Pierre Roux
1649 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1650 no longer writes 'Un' on disk
1651 * FIX SQ elements with actual length are now dealt with corectly
1652 * FIX gdcmFile::WriteBase make the difference, for color images, between
1653 the length (for Palette expanded images)
1654 and Raw Length (non expanded image + Palette)
1655 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1656 (that broke Write). Replaced by UL.
1657 Aware user will reload the field if he
1658 thinks it's necesssary
1660 2004-01-30 Jean-Pierre Roux
1661 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1662 when 'dirty Acr' is found, to be compliant with the new
1663 IsReadable() methods.
1665 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1666 (no DOUBLE images in kosher DICOM,
1667 but so usefull for people that miss them ;-)
1669 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1670 DICOMDIR related utilities (not checked as Windoze compliant)
1672 2004-01-28 Jean-Pierre Roux
1673 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1675 2004-01-27 Jean-Pierre Roux
1676 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1677 to allow skipping the shadow elements, to save memory space.
1678 The TRUE value for this param has to be used
1679 with a FALSE value for the 'enable_sequence' param.
1680 ('public elements' may be embedded in 'shadow Sequences')
1681 * gdcmHeader methods now deal with 'embedded icones images' in the header
1682 (even when an 'icone image sequence' is announced by the
1683 element (0x0088,0x0200), but there is NO icone at all ...
1685 * gdcmHeader sometimes Image Location value doesn't follow
1686 the supposed processor endianity (see gdcmData/cr172241.dcm).
1689 * gdcmHeader add the method
1690 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1691 to get *all* the Header Entries with the same tag.
1692 GetHeaderEntrySameName is probabely *useless*
1693 (no meaning : Name is *not* an identifier within the Dictionnary)
1695 2004-01-26 Benoit Regrain
1696 * Bug fix in the print of hexadecimal representations. Remove long fields
1697 in the print and add a third level of print to print them
1699 2004-01-23 Benoit Regrain
1700 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1701 * Bug fix on test suite after remove the strip made on not string fields
1702 * Split the IsReadable method between gdcmParser which test that the file
1703 is dicom and gdcmHeader which test that it's an image file
1705 2004-01-22 Benoit Regrain
1706 * DicomDir : clean code, add methods, set variables in protected or private
1707 * gdcmUtil : bug fix for the clean string method
1709 2004-01-19 Benoit Regrain
1710 * Add the use of shadow dictionaries
1711 * bug fix and coding style
1713 2004-01-19 Benoit Regrain
1714 * src/gdcmFile.cxx : bug fix concerning the close of file
1715 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1716 * Add the update of header entries using the shadow library
1718 2004-01-19 Benoit Regrain
1719 * removal of file gdcmHeader2.cxx
1720 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1721 inheriting from gdcmParser. This split is to prepare the integration
1722 of dicom dir parsing
1723 * bug fix under python
1725 2004-01-16 Jean-Pierre Roux
1726 * REM removal of class gdcmHeaderEntrySet
1727 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1728 * ADD add file gdcmHeader2.cxx
1729 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1731 2004-01-15 Benoit Regrain
1732 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1733 entries created while parsing the header. Thus, they will be destroyed
1734 when the gdcmDictSet will be destroyed
1735 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1738 2004-01-15 Benoit Regrain
1739 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1740 made a fatal error because of the memory release at the end of program.
1741 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1742 some memory and vtk seems to have some problems with that.
1743 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1745 2004-01-14 Benoit Regrain
1746 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1747 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1748 * src/*.[h|cxx] : make changes due to class name changes
1749 * gdcmPython/demo/*.py : bug fix due to method names
1751 2004-01-13 Benoit Regrain
1752 * src/*.[h|cxx] : coding style
1753 * vtk/*.[h|cxx] : coding style
1755 2004-01-13 Benoit Regrain
1756 * gdcmPython/testSuite.py : test the readable flag of file for tests
1757 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1758 It's lied to the stl compilation by MSVC (windows, always windows...)
1759 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1761 2004-01-12 Benoit Regrain
1762 * src/*.h : add comments
1763 * src/gdcmDictSet.h : set the method BuildDictPath in public
1764 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1765 directly setted in the source code
1766 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1769 2004-01-09 Benoit Regrain
1770 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1771 * setup.py : use a reference to gdcmVERSION
1773 2004-01-07 Benoit Regrain
1774 * Modification to compile with the distutils.
1777 2003-12-10 Benoit Regrain
1778 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1779 can use a gdcmHeaderHelper to load datas
1780 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1781 made in the source code
1783 2003-12-10 Benoit Regrain
1784 * Update Windows projects and .cvsignore files
1786 2003-11-12 Jean-Pierre Roux
1787 * ENH gdcmHeader constructor has one more parameter (default value : false)
1788 that allows the user to 'go inside' the SeQuences only
1790 gdcmElValSet:Print takes it into account
1792 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1793 * ENH: Update gdcmPython/CMakeLists
1794 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1795 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1797 2003-11-10 Jean-Pierre Roux
1798 * FIX : gdcmHeader::LoadElements is now based
1799 on the ListTag listElem member,
1800 not longer on the TagElValueHT tagHt member
1801 * ENH : PrintPubElVal shows (temporarily) both results,
1802 with the tagHt member and the listElem member.
1803 (it's easier to 'see' the problems when using Printheader)
1805 * FIX : old private member LgrElem is now splitted into
1806 ReadLength : Length actually found on disk (updated only
1807 if bug fixing is necessary), for internal
1809 UsableLength : Updated by FixFoundLength, to fix a bug
1810 or to allow Parser going on.
1811 Will allow to re-write a kosher header when a SeQuence
1812 with a length (not 0000) is found
1813 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1814 because gdcmElValSet::Add does not update ListElem
1817 2003-11-07 Jean-Pierre Roux
1818 * FIX misstyping in Transfert Syntax name table
1819 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1820 when they have an actual length (not 0000 nor FFFFF)
1821 (Nobody should care of it, but DICOMDIR explorers)
1823 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1824 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1826 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1827 * ENH: vtkGdcmReader now supports LUT !
1828 (vtkgdcmViewer for now is not able to use them though)
1830 2003-11-05 Jean-Pierre Roux
1831 * in testSuite.py : new files names for checking the package
1832 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1833 that returns the pixel area size to the *aware* (vtk) user
1834 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1836 2003-11-05 Benoit Regrain
1837 * in testSuite.py : Modify the rules for checking the paths
1838 : Explicit error messages
1839 * in __init__.py : Related modif
1841 2003-11-03 Jean-Pierre Roux
1842 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1843 to be used by aware (vtk) users that want to manage
1844 LUT (and no to turn the PALETTE image into an RGB pixels one)
1845 * GetPixelType now returns 8U for 24 Bits images
1846 (vtkGdcmReader compliant)
1848 2003-10-31 Jean-Pierre Roux
1849 * Removal of *all* gdcmData images and add them again
1850 in order to loose the 'history' of un-anonymised images
1852 2003-10-31 Jean-Pierre Roux
1853 * RMV : removal of useless jBitsInJsample.h
1854 for both 8 and 12 Bits JPEG Lossy Libraries
1856 2003-10-31 Jean-Pierre Roux
1857 * ENH : Add the functions gdcmFile::GetImageDataRaw
1858 gdcmFile::GetImageDataIntoVectorRaw
1859 that act as GetImageData and GetImageDataIntoVector
1860 except the making of an RGB Plane from Gray Plane + LUT
1861 Intended to aware (vtk) users who know how to manage
1864 GetLUTRGBA return a R,G,B,A LUT if any
1865 lgrTotaleRaw gives the 'Raw' length
1866 GetImageDataRaw returns the gray Plane
1867 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1868 (They stay Grey, just like with other Dicom viewers :-(
1870 2003-10-30 Jean-Pierre Roux
1871 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1873 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1874 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1875 being coherents dicom files.
1877 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1878 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1880 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1881 * ENH: Two steps is necessary to please VC++ compiler...
1882 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1883 * ENH: Add include dir to medcon lib
1884 * FIX: only one function is being exported for now !
1885 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1887 2003-10-29 Jean-Pierre Roux
1888 * adding gdcmHeader::GetLUTRGBA
1889 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1890 --> Mathieu, the modif u're waiting for is not yet committed
1891 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1893 2003-10-27 Jean-Pierre Roux
1894 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1895 00191113.dcm DermaColorLossLess.dcm
1896 MxTwinLossLess.dcm RadBWLossLess.dcm
1897 * ENH: For version prior to vtkImageViewer2 -r 1.19
1898 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1900 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1901 * Removal of ido stuff in CMakeLists.txt
1903 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1904 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1905 * FIX: remove a call to ->Modified ... see comments
1906 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1908 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1909 * FIX: Problem with path for libvtkgdcmPython
1910 * ENH: Try adding a search script for python site-package
1911 * RMV: Remove some file from medcon lib that are not necessary
1912 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1913 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1914 * FIX: More pragma disable fro VC++,
1915 I don't think I break something as it is also disable in VTK/ITK.
1916 But it fasten debug compilation time.
1918 2003-10-23 Jean-Pierre Roux
1919 * gdcm now deals with 16 Bits Run Length Encoded images
1920 (they are compressed as 2 planes images,
1921 one for the high Bytes, the other for low Bytes)
1923 2003-10-22 Jean-Pierre Roux
1924 * Now CheckRead takes into account :
1925 - the bugged 'Leonardo' Siemens images
1926 - the XA images, sent thru the burning VPRO station
1927 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1930 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1931 * FIX: When copying a Makefile.am to CMakeLists.txt
1932 one should remove the '\'
1934 2003-10-22 Jean-Pierre Roux
1935 * in gdcmData adding a bugged 'Leonardo' Siemens image
1936 (wrong lengths in header)
1937 OK with gdcm, KO with the other viewers :-)
1938 * add a GE dlx XA image, thru the VEPRO burning station
1941 2003-10-21 Jean-Pierre Roux
1942 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1943 for a brutal checking of vtkgdcmViewer compliance
1945 2003-10-21 Jean-Pierre Roux
1946 * add the files for 'xmedcon' Jpeg Lossless library
1947 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1949 2003-10-21 Jean-Pierre Roux
1950 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1952 2003-10-21 Jean-Pierre Roux
1953 * garbage Siemens 'Leonardo' images dealt with
1954 (the patch is easy to remove)
1955 * cosmetic changes to avoid warnings
1957 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1958 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1959 no need to press 'r' now.
1961 2003-10-20 Jean-Pierre Roux
1962 * upgrade of checkRead.sh checkWrite.sh according
1963 to new Jpeg Lossless decompressor
1964 * add US.3405.1.dcm, a genuine RGB medical file ...
1965 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1966 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1968 2003-10-15 Jean-Pierre Roux
1969 * general anonymisation in gdcmData
1970 * adding the 'color files' from
1971 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1972 * adding some well knowed bugged-header images
1973 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1974 waiting for their inclusion in Python testsuite
1976 2003-10-15 Jean-Pierre Roux
1977 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1978 no longer seg faults when file is not found
1980 2003-10-14 Jean-Pierre Roux
1981 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1984 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1985 * TODO: *.in file to genereate a UseGDCM later
1987 2003-10-14 Jean-Pierre Roux
1988 * Some supposed-to-be Dicom Images have no preamble.
1989 OpenFile takes it into account
1990 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1991 * Missing elements added in dicomV3.dic
1992 (just to be affraid : have a look at
1993 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1994 and do it again next year ;->
1996 2003-10-13 Jean-Pierre Roux
1997 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1998 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1999 But there are NOT. It's fixed !
2001 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2002 * FIX: "jpeglib.h" was not found on VC++
2003 * FIX: vtkgdcm was not being installed
2005 2003-10-10 Jean-Pierre Roux
2006 * ENH : OpenFile closes the file if it *really* doesn't look like
2007 an ACR-NEMA / DICOM one.
2008 * FIX : testWrite no longer writes an empty file if the source file
2009 is not gdcm Readable
2010 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2013 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2014 * FIX: CMake generate now documentation
2015 * ENH: out of source doc build !
2016 * ENH: Generate both user and dev documentation
2017 * ENH: Should work on windows too
2018 * ENH: Only one doxygen config.in file is needed
2019 * FIX: make install should be ok now on ùnix plateform
2020 * FIX: PATH to dictionary was wrong (missing /)
2021 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2023 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2024 * vtkGdcmReader is now able to read rgb dicom file.
2025 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2026 * added a gdcmViewer to vtk test, use mouse to control
2027 window level & window width
2029 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2030 * CMake-ification of gdcm, we have now two build system
2031 * FIX: on cygwin Wsock32 doesn't exist
2032 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2034 2003-10-06 Emanuel Ollart
2035 * FIX : compilation process wad broken.
2036 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2038 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2039 * change gdcmViewer -> vtkgdcmViewer
2040 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2042 2003-10-06 Jean-Pierre Roux
2043 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2044 ( e.g : well known GE images with a wrong elem length,
2045 : Philips MRI Images with a wrong Huffman table)
2046 * still to be done : allow the reading of bugged LEONARDO Siemens images
2048 2003-10-03 Jean-Pierre Roux
2049 * Odd length strings are padded with '\0' (not with spaces,
2050 to remain compliant with already defined strings,
2051 like Transfert Syntax UID and others)
2053 2003-10-03 Jean-Pierre Roux
2054 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2055 to allow displaying RGB images (not only by affim ;-)
2057 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2058 * vtkGdcmReader is now able to read rgb dicom file.
2059 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2061 2003-10-03 Jean-Pierre Roux
2062 * A few nasty patches to allow the reading of a lot of nasty images
2063 ( e.g : well known GE images with a wrong elem length,
2064 : Philips MRI Images with a wrong Huffman table)
2065 * still to be done : allow the reading of bugged LEONARDO Siemens images
2067 2003-10-03 Jean-Pierre Roux
2068 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2070 2003-10-03 Jean-Pierre Roux
2071 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2072 to allow displaying RGB images (not only by affim ;-)
2074 2003-10-03 Jean-Pierre Roux
2075 * gdcmFile::GetImageDataIntoVector now
2076 - deals with MultiFrames MultiFragments Run Length Encoded files
2077 - deals with YcBcR (YBR_FULL) files
2078 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2079 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2081 (no sample found :-(
2083 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2084 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2085 Two reasons: - clear things
2086 - third parties acces gdcm through header files, so won't
2087 suffer anymore VC++ complains
2089 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2090 * add argv[1] in testvtkGdcmReader.cxx
2093 2003-09-24 Jean-Pierre Roux
2094 * The lines are now eigthy characters long.for
2095 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2097 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2098 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2099 char* to std::string. Thus, the use of strdup becomes useless. (see
2100 previous commis of Malaterre)
2101 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2102 before the last Malaterre's commit.
2104 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2105 * This commit should fix the Debug building under VC++, the problem
2106 was mainly a mixture of debug and release lib being loaded at startup.
2107 * I also remove a depency to a specific C function: strdup. Because I had
2108 to force the link to msvcrtd (whereas strdup is in libc).
2110 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2111 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2112 located in the gdcmCommon.h file. All use of reference of tha has been
2113 changed to now use the variable GDCM_UNFOUND.
2115 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2117 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2118 Dicom dictionary. The test suite can now be run again. Note:
2119 I'm note very happy with the " (RET)" changes. I believe this
2120 RETAINED comment should be dropped when parsing the dictionary.
2121 - PACKAGER corrected
2123 - AUTHORS updated and now in alphabetical order
2124 * Makefile.am now exports gdcm.dsw for Windoze users.
2126 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2127 * cygwin complains about missing std:: in subdir Test/
2129 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2130 * remove some methods that are now in gdcmHeaderHelper
2132 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2133 * vtkGdcmReader set spacing and origin correctly
2135 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2136 * Fix a few delete/delete[] mismatch
2138 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2139 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2140 interpretation to data given by gdcmHeader. For instance there are
2141 heuristics to get informations (look at different places).
2142 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2143 sorting DICOM images based on different strategies.
2144 * modified Makefiles accordingly.
2146 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2147 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2148 when building in debug mode
2149 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2150 src/win32/gdcmdll.dsp
2151 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2153 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2154 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2157 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2158 * src/win32/libgdcmjpeg12.dsp was not dos format
2159 * src/win32/libgdcmjpeg12.dsp :
2160 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2161 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2163 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2164 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2166 * src/gdcmFile.cxx : bug fix in affectation type
2167 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2168 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2169 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2170 symbols... future problem ?
2172 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2173 * src/win32/libgdcmijpeg12.dsp was missing
2174 * modified gdcm.dsw accordingly
2176 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2177 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2179 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2180 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2181 commit of JPR (before his hollidays to facilitate our work).
2182 * setup.py : bug fix in code. Modifications made while the last commit
2183 of JPR. The code hasn't been tested before the commit... it's so
2184 useless to make that (for best programmer that is JPR) !!!
2186 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2187 * tagged the current version as Version0_3 (i.e. version 0.3)
2189 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2190 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2191 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2192 * *.dsp : modifications to use new libgdcmijpeg8 library
2193 * setup.py : bug fix on VTKPATH variable
2194 * PACKAGER : adding all concerning windows
2196 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2197 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2199 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2200 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2201 test suite reported error.
2202 * PACKAGER file added (describes what a packager must do when
2203 packaging a new release).
2204 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2205 * configure.in: upgraded version number to 0.3.0
2206 * fixing build of rpm (through rpm -ta):
2207 - Doc/Makefile.am exports proper doxygen files
2208 - src/jpeg/libijg8/Makefile.am exports the include files.
2210 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2211 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2212 * src/gdcmHeader.h : formatting code
2214 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2215 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2216 We were obtaining error message from vtk. Now, creation of file list
2217 is made in an internal list to prevent this problem.
2218 Bug fix when output is empty.
2219 Bug fix in update of progress value. Previous commit for this was a bad
2221 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2223 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2224 * src/gdcmHeader.h : added method to get the file name
2225 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2226 files. Added method to remove all files on the input
2227 Added FIXME comment concerning the bad parsing of header made by
2228 ExecuteInformation method (in ExecuteData method)
2230 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2231 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2232 when using make instal.
2233 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2234 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2236 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2237 * setup.py : adding include dir of jpeg lib to compile all sources
2238 * */Win32/*.dsp : JPR fix for windows compilation
2240 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2241 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2243 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2244 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2246 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2247 * setup.py is again effective on un*x (takes into account the
2248 addon of the jpeg library)
2249 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2250 * Doc/Doxy* updated (includes above enhancements)
2251 * INSTALL now points to web documentation
2253 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2254 * src/gdcmHeader.h doesn't make unnecessary reference to
2256 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2258 * src/gdcm*.[cxx|h] :
2259 - to allow compilation with gcc 3.x
2260 -- clean up of STL usage (added explicit usage of std::)
2261 -- small fixes on exceptions.
2262 Note: linking not tested !
2263 - clean of doxygen comments to avoid warnings at documentation
2265 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2266 dependent convertion).
2268 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2269 * Clean up of previous JPR garbage commit (not even commented in the
2271 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2272 - moved all jpeg related files from src to src/jpeg/libijg8, with
2273 addition/modification of Makefile.am and configure.in.
2274 - the testSuite is still brain damage (not guilty).
2276 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2277 * WrapVTK.py : modifications to get correctly vtk source files to
2279 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2280 (FileName -> Filename)
2282 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2283 * vtk/vtkGdcmReader.[cxx/h]:
2284 - UpdateProgress method should now be effective
2285 - removed the limitation on having only images loaded (as opposed
2287 - when building a stack of images/volume, a lesser number of
2288 gdcmHeader and gdcmFile instances should be used (hopefully
2289 accelerating things).
2290 - when building a stack of images/volumes, files which are not
2291 loadable (wrong path-filename, wrong permissions on existing file,
2292 or file not parsable by gdcm) are replaced with a black image
2293 in the stack (for the caller to notice the problem).
2295 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2296 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2298 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2299 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2300 between standard library (std) and vtk library (problems are found
2301 under Windows... thanks Windows !)
2303 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2304 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2306 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2308 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2309 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2311 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2312 * When compiling with distutils (see setup.py) the C++ compiler is
2313 called with different flags than the default ones (with automake).
2314 In order to fix all those warning, I compiled gdcm with the command
2315 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2316 and went for warning fixes:
2317 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2318 up from unused variables.
2319 - vtk/vtkGdcmReader.cxx: potential bug fix.
2320 * src/gdcmHeader.h: Doxygen warning cleanup
2322 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2323 * gdcmPython/gdcm.i:
2324 - typemaps correction to take into account the systematic replacement
2325 of "using namespace std" with std:: prefix e.g. std::list,
2326 std::string... (cf changes of 2003-05-21).
2327 - gdcmGlob global variable of type gdcmGlobal (defined in
2328 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2329 exported to Python a as cvar.
2330 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2331 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2332 gdcmDictSet.GetPubDictTagNames() and
2333 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2334 C++ static methods).
2335 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2336 with the above changes.
2338 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2339 * setup.py, manifest.in : bug fix under linux
2341 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2342 * Modification of setup.py to compile vtk part too. Then, we have 2
2343 wrappers which must work with same distutils. For that, we have a
2344 generic distutils in distusiltsWrapping.py ; with :
2345 - build_extWrap class to wrap generically all extensions,
2346 - ExtensionWrap base class for all wrapping extension that contains
2348 - Wrapper interface which wrap sources
2349 + In WrapSwig.py we have extension and wrapper for Swig
2350 + In WrapVTK.py we have extension and wrapper for VTK
2351 * MANIFEST.in : modifications to consider vtk directory and new python
2352 files for compilation
2354 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2355 * Added python wrappers of vtkGdcmReader vtk class (see the
2356 source in vtk/vtkGdcmReader.cxx) :
2357 - vtk/Makefile.am now builds a library
2358 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2359 python library (as opposed to _gdcm.so wich are the python
2360 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2361 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2363 - configure.in has an additional flag --enable-vtk that needs
2364 to be set to enable compilation of vtk related code, that is:
2365 + vtk/vtkGdcmReader.so and
2366 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2367 + gdcmPython/vtkgdcmPython.so (see above)
2368 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2369 be read when compressed or when HighBit + 1 != BitsStored),
2370 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2371 the usage of the python wrapper of vtkGdcmReader vtk class.
2372 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2373 * src/*.[h] all occurences of stl classes are now prefixed with
2374 std::, and all occurences of "using namespace std;" where removed.
2375 This is to avoid pollution of global namespace in included files.
2376 Apparently vtk does not avoid this pitfall: when using both
2377 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2378 collision of various stl members (principally cout...).
2379 * gdcmPython/testSuite.py now cleanly removes temprory generated
2381 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2382 comply with above changes)
2384 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2385 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2386 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2387 vtk data structure (an image Flip was required).
2388 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2389 * cosmetic changes in documentation.
2391 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2392 * src/gdcmHeader.cxx: the constructor no longer exits when an
2393 unexisting file is given as argument.
2394 * The subdirectory Data (containing all the images used for the
2395 test suite) is not part of this repository anymore. A new module
2396 containing those images is now available at
2397 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2398 with the name gdcmData.
2399 All the python scripts (including the package initialisation file
2400 gdcmPython/__init__.py) were adapated to take this change into
2401 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2403 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2404 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2405 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2406 demo of the usage of this class.
2407 Compilation of this vtk part is only done when using the --enable-vtk
2408 at configure (or autogen.sh) stage.
2410 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2411 * More memory link related corrections and documentation fixes.
2413 - maximum info is obtained with a command of the form:
2414 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2415 --show-reachable=yes PrintHeader
2416 - the remaining reachable blocks seem to come from the STL
2417 allocation scheme through the usage of map and list. It looks
2418 like this memory cannot be freed but it is not a memory leak
2419 (in fact further invocation to the STL would recollect the
2420 unused memory allthough it cannot explicitely be freed).
2421 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2422 of displaying an image parsed with gdcm and displayed with VTK.
2423 Note: some images don't seem to work e.g.
2424 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2425 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2426 Allthough this weakens the semantics, it is a ditch attempt to
2427 make gdcm more thread friendly.
2429 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2430 * Memory link hunt (by using valgrind through the command
2431 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2432 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2433 gdcmHeader::_dicom_vr.
2434 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2435 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2437 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2439 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2440 * src/Makefile.am now exports all the necessary include files at
2444 * UpdateGroupLength replaced by new one
2447 * UpdateGroupLength re-written using H-Table
2448 (named UpdateGroupLengthNew untill checks are over)
2450 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2451 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2452 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2454 - gdcmHeader::GetPubElValSet removed.
2455 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2456 UpdateGroupLength, WriteElements, Write.
2457 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2458 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2459 carried the same semantics.
2460 - src/gdcmHeaderIdo.cxx changed accordingly.
2461 - gdcmFile::WriteBase now regroups all the codes from previous
2462 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2463 - enum FileType moved to gdcmCommon.h
2464 * src/gdcmHeader.cxx AddDefault trashed
2465 * gdcmGetXSize added
2466 * getimageDataSize now calls gdcmGetXSize
2467 * Test/*.cxx changed to agree with above changes
2469 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2470 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2471 (to avoid double call by end user).
2472 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2473 by end user, since gdcmHeader::gdcmHeader now handles it.
2475 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2476 * gdcm/Doc many doxygen changes:
2477 - Doxyfile now has two different versions, DoxyfileUsers that generates
2478 the html.users end users oriented documentation and
2479 DoxyfileDeveloppers that generates the html.developper developper
2480 oriented documentation.
2481 - README changed accordingly
2482 - requirement.txt removed (old design info moved to TODO).
2483 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2484 DoxyMainPage.txt, DoxyPython.txt provide more information.
2485 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2486 be updated by simply regenerating the docs with doxygen and copying
2487 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2488 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2489 all the tests in the form "if (<map>.count() >1)" were removed.
2490 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2491 ill-formed documentation sections.
2492 * src/gdcmHeader.cxx: ditto
2494 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2495 * setup.py fixed for un*x (needed macro for stdint.h)
2496 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2497 un*ces with sh-utils test utility.
2498 * gdcmPython/demo/test.py renamed to PrintHeader.py
2499 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2500 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2501 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2502 * src/gdcm*.cxx JPR's bad inclusion fixed.
2504 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2505 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2506 * gdcmPython/demo/test.py changed accordingly.
2508 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2509 * gdcmPython/Makefile.am fixed linking against libstdc++
2510 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2511 * Swig subdir (historical tests of swig version 1.3.17++) removed
2512 * Test/testChangeEntete.cxx some lines commented out in order to make
2514 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2515 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2517 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2518 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2519 hence the user doesn't need this explicit call.
2520 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2521 i.e. LoadElements() call removed.
2522 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2523 - src/Makefile.am declares the proper flag for g++.
2524 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2525 for adding user defined new tags.
2526 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2527 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2528 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2530 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2531 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2532 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2533 src/Makefile.am : the project should properly compile and install
2534 with the autotools, included the python wrappers part.
2535 * gdcm.spec.in : added a spec file for RPM packaging.
2537 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2538 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2540 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2541 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2542 to exported to the environement (see gdcmPython/testSuite.py
2544 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2545 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2546 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2547 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2548 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2550 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2551 * gdcmPython/__init__.py doesn't crash anymore when running in
2552 in InstallMode or PreInstallMode but with an environement given
2553 value of GDCM_DICT_PATH.
2554 * src/gdcmDictSet.[cxx/h] coding style.
2556 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2557 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2558 * src/gdcm.h general comments moved to TODO, and README
2559 * src/gdcm.h should now be seen as a user commodity (including it
2560 should suffice to fully use gdcm). It is nowhere including within
2561 any of the kernel files src/*.cxx and src/*.h.
2563 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2564 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2565 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2567 * src/gdcm*.cxx only include their corresponding include file
2568 (as opposed to gdcm.h)
2569 * gdcmPython/gdcm.i changed accordingly
2570 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2571 the autogen.sh generated "make snapshot" command to work.
2572 * autogen.sh removed history related references to crea package.
2574 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2575 * distutilsSwigCPlusPlus.py work around some swig portability
2578 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2579 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2580 was done in a last ditch attempt to get setup.py _really_
2581 operationnal. The python/gdcmPython layaout add the advantage
2582 of hidding away the python related distutils specific files
2583 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2584 Alas, the src directory was out of scope (i.e. it's relative
2585 position to setup.py was ../src) which made things impossible to
2586 handle (see previous version of python/setup.py). Crossing fingers...
2588 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2589 * python/setup.py now works on Un*x. (harder than I thougth)
2590 * python/distutilsSwigCPlusPlus.py can now have include files
2591 among the list of sources.
2593 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2594 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2595 * modifications in MSVC projects
2597 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2598 * As stated by the first lines of Test/ExceptionAndPython/README, it
2599 looks like we can move back to original usage of exception within
2600 src/gdcm* and hence remove the errno stuff that was introduced
2601 as a quick and dirty fixture of this problem (added to the TODO).
2602 * Doc/Doxyfile configuration file for Doxygen and corresponding
2603 README file for usage added.
2604 * Test/testWrite.cxx added. This new test comes from a split of
2605 test.cxx that is now reverted to its original purpous i.e.
2606 testing the proper parsing of a Dicom related file.
2607 testWrite.cxx concentrates on testing the IO part of gdcm.
2608 * Test/bug1.cxx (containing a bug on WIn32) added.
2609 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2610 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2611 whose purpose is to publish the content of the TagNames of the
2612 Dicom public dictionnary were not accessible without an
2613 instance of class gdcmHeader.
2614 - those methods are now static methods of gdcmDictSet and hence
2615 require no instances at all to be invocated.
2616 - within gdcmDictSet this change required to change some method
2617 to class methods (i.e. are now static) among which SetDictPath
2618 (renamed to BuildDictPath) and LoadDefaultPubDict.
2619 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2620 the above changes by calling the new method classes of gdcmDictSet.
2621 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2622 the above to be effective.
2623 * python/gdcmPython: in order to wrap properly the above changes
2624 for Python, swig version now needs to be > 1.3.17.
2625 * python/gdcmPython/Makefile fixed to adapt itself to new
2626 configure/make shema introduced by Johan Montagnat (thanks for the
2627 contribution). Alas this Makefile cannot be turned into a proper
2628 Makefile.am without some heavy changes in the configure.in
2629 (for python dectection).
2630 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2631 now avoids publishing the empty entries.
2633 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2634 * python/setup.py : bug fix concerning install under windows
2635 ExtraPath reused :-P
2636 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2638 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2639 * Dicts/dicomV3.dic : remove double spaces !!!
2640 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2641 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2644 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2645 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2646 method. Doxygenation.
2647 * src/gdcm.h clean up of JPR spurious comments.
2649 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2650 * python/distutilsSwigCPlusPlus.py now properly collects the
2651 shadow classes generated by "swig -c++" (gdcm.py in our case)
2652 when using "python setup.py install".
2653 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2654 reexports the working classes.
2655 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2656 by the classical C errno scheme. This is to prevent an obscure
2657 behavior of the python wrappers when importing wxPython.wx prior
2658 to gdcmPython (which ended up in an abort call). An illustration
2659 of this oddity can be found in the Test/ExceptionAndPython
2660 subdir (see the README file). This problem probably due to
2661 an combination of g++ and dynamic loading.
2662 * added Test/ExceptionAndPython (see above)
2664 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2665 * Changed the layout of the python part to avoid bloating main
2666 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2667 i.e. the distutils arsenal. All the python related stuff is
2668 again in a python subdir, but the package itself is now in
2670 * setup.py was cleaned up:
2671 - pythonIncludePath removed
2672 - python setup.py bdist target is now functional.
2673 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2674 collision with other packages). gdcmPython/demo/*.py changed
2677 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2678 * python subdir moved to gdcmPython (preparation of distutils packaging).
2679 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2680 distutils installer is operational.
2681 * - gdcmPython/__init__.py now properly loads the swig generated
2682 shadow classes (from gdcm.py).
2683 - gdcmPython/demo/*.py changed to import the package gdcmPython
2684 instead of gdcmPython/demo/load.py.
2685 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2687 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2688 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2689 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2690 entries within the associated public Dicom dictionary resp. the same
2691 information but sorted by the fourth field (PAT, IMG, DIR) of the
2693 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2694 are now in the "???" group.
2695 - python/gdcm.i changed accordingly,
2696 - python/demo/printGroupedPublicDict.py added, that gives an example
2697 of the above new functionalities in Python.
2699 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2700 * src/gdcm.h, gdcmHeader.cxx:
2701 - historic references to glib's g_malloc and g_free (#defined)
2702 were definitively removed.
2703 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2704 * src/gdcmElValSet.cxx:
2705 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2706 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2707 - GetElValue(string) renamed to GetElValueByName.
2708 - Added GetElementByName(string).
2709 * src/gdcmHeader.cxx: added
2710 - GetPubElValRepByNumber(guint16, guint16)
2711 - GetPubElValRepByName(string)
2712 - GetShaElValRepByNumber(guint16, guint16)
2713 - GetShaElValRepByName(string)
2714 - GetShaElValByNumber(guint16, guint16)
2715 - GetShaElValRepByName(string)
2716 - GetElValRepByNumber(guint16, guint16)
2717 - GetElValRepByName(string)
2718 - GetElValByNumber(guint16, guint16)
2719 - GetElValRepByName(string)
2720 * Doc/requirements.txt added.
2722 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2723 * Test/Makefile building now depends on the one of libgdcm.so
2724 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2725 pixel data) aware which enables finding the address (offset) of
2726 the pixel data of JPEG encoded DICOM files. This leaves only a single
2727 file in the testSuite whose pixel data address (offset) is unknown.
2728 * python/testSuite.py changed accordingly.
2730 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2731 * VC++ has some strong limitations when working with the STL, as stated
2732 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2733 "Also note that some STL containers (map, set, queue, list, deque)
2734 cannot be exported. [...]
2735 Some STL classes contain nested classes. These classes can not
2737 This is caused by a designed limitation that once a template
2738 class is instantiated, it can not be re-instantiated and
2740 Since our usage of map<> is ubiquitous in gdcm, this "designed
2741 limitation" of VC++ is a pitfall.
2742 Hence the Python wrappers of gdcm cannot be incrementally linked
2743 against the c++ dynamic library. The dirty but only workaround is
2744 to forget about incremental link of dynamic libraries and to generate
2745 the Python wrappers library with the inclusions of the underlying C++
2747 The following modifications concern this matter on Win32/VC++:
2748 - wrapping python correct with standalone wrapped dll (don't use separate
2749 dll under windows !!!!)
2750 - python21_d debug mode enabled (ask Frog how to use it :-)
2751 - NO problem with having an STL member of class for example string in C++
2752 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2753 - Python test of dcmlib in Python is ok under windows on a large set
2755 * removed glib references
2756 * typedef's inserted in gdcm.i for correct swig type management
2758 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2759 * python/demo/*.py load.py extracted from test.py. Added explore.py
2760 that only displays required tags and testAll.py that parses all
2761 the files of the testsuite without using unittest.
2762 * python/testSuite.py other additional test on new files added.
2763 * Data/* new test files added accordingly to the testSuite.
2764 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2765 the vr in the file differs from the one of the dictionary.
2767 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2768 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2769 values, but limits itself to values which are below a user specified
2770 size (by default 1024 bytes).
2771 * python/gdcm.i : elements not loaded (because their size is above the
2772 user specified treshold) are exported with their TagKey as key of the
2773 python dictionary. This enables the testsuite to make some checks
2774 on the unloaded elements (since we have their offset and size).
2775 * python/testSuite.py
2776 - now tests for the existence and proper value of the pixel data
2777 - two new examples added.
2778 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2780 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2781 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2782 aware. See the strategy comments in gdcmHeader::FindeLength().
2783 * Test/test.cxx now accepts a filename as first argument.
2784 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2785 * python/testSuite.py changed to integrate test on above files.
2787 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2788 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2789 the vr was also RET.
2790 * python/testSuite.py more tests added.
2792 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2793 * python/testSuite.py unittest test suite added (uses Data)
2794 * Data/* dcm and acr files for the test suite.
2795 * glib dependance removed from un*x version. We now use ISO C99
2796 7.18 Integer types (see stdint.h)
2797 - python/Makefile, src/Makefile src/gdcm.h
2798 * src/ when an explicit vr (like dicom files) suddenly poped an
2799 implicit element we use to mark the underlying DictEntry of the
2800 concerned ElValue with "Implicit". This strategy was damageable
2801 too the public or provite dictionaries, since some of their vr
2802 would be changed. Since Header::FindLength heavily relies on the
2803 detection by Header::FindVR of falsely explicit elements, I
2804 added an extra ImplicitVr member to ElValue (boolean).
2805 The rest of the changes we the necessary adaptations.
2807 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2808 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2810 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2812 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2813 * Adaptation for porting to VC++:
2815 o forced to use std namespace (for string to be known)
2816 o all class use __declspec export style on WIN32
2817 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2818 (in stdlib.h on Win32 but in std:: for gcc)
2819 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2820 variable GDCM_DICT_PATH.
2821 * src/gdcmHeader.cxx verbose comments made discrete.
2823 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2824 * python/gdcm.i: added a typemap that converts a C++ hashing table
2825 to native Python dictionary.
2826 * python/demo/test.py:
2827 - now uses the native dictionary for exploration of gdcmHeader.
2828 - takes an optional filename argument (the file to parse).
2829 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2830 PubElVals hashing table.
2831 * Dicts/dicomV3.dic removed error prone trailing spaces.
2833 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2834 * Python wrapping process moved away from src/Makefile to
2835 newly created python/Makefile (as well as gdcm.i)
2836 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2837 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2838 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2839 from the environement variable GDCM_DICT_PATH (when existing).
2840 * src/gdcmDict::GetTag bug fix.
2842 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2843 * Straightforward temporary fixes for swig to build the python wrappers.
2844 src/Makefile now has a python working entry [by working we mean
2845 that we can import de shadow classes without errors].
2847 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2848 * hashtest.cxx removed (since allready in Test)
2849 * src/gdcmlib.h renamed to src/gdcm.h
2850 * src/dcm.i renamed to src/gdcm.i
2851 * src/Makefile prepared for python wrapping
2853 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2854 * src/gdcmHeader.cxx :
2855 - Parsing of header is now separated from loading of element values
2856 (see gdcmHeader::LoadElements).
2857 - general clean up of hopefully all file access (creation of
2858 ReadInt16 and ReadInt32)
2860 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2861 * src/gdcmHeader.cxx :
2862 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2864 - SetLgrElem renamed to SetLength
2865 - GetLgrElem renamed to GetLength
2866 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2867 * src/gdcmElValSet.cxx fixed both GetElValue methods
2868 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2869 due to IdoDude was cleaned out.
2871 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2872 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2873 concentrates on finding the value representation (when it exists).
2874 RecupLgr now only finds the element value length, and it avoids
2875 returning the unecessary skL (skipped length).
2876 Also, offsetCourant was simply removed (with taille_fich) since
2877 it was redundant with the File position internals (by using
2878 ftell and fseek). This also made skL (see above in RecupLgr) usage
2880 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2881 on the libido specificities which are handled through class
2883 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2886 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2887 * Truckload of changes. Parsing of header is barely functional
2888 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2890 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2891 * src/gdcmHeader.cxx many addons of low level methods
2893 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2894 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2895 and _IdDcmSWAP_LONG.
2897 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2898 * This corresponds to all the changes decided at the meeting of
2899 May 23 2002. Needless to say we are running late...