1 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
4 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
6 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
9 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
10 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
11 The string leaves only in the fonction. So when we make a .c_str(), we
12 get the pointeur on the first element, element that will be destroyed
13 immediately after thee instruction.
14 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
15 file has been opened : the test must be made on the content of the
16 pointer and not directly on the pointer !
19 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
21 the python part recompiles
23 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
25 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
26 X session is killed (for my computer... it seems to not be identic on
29 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
30 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
31 avoid problems (otherwise, the difference test between the visible image
32 and the reference is incorrect. If the reference is greater than the
33 screen resolution, it's produce errors).
34 Can be used for only one image. Can be used with a visible flag.
35 * vtk/vtkGdcmReader.cxx : remove commented codes.
36 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
37 under windows at compilation
38 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
40 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
42 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
44 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
45 tests on the image size X, Y, Z
47 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
49 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
50 between the class name and the file name
52 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
53 * src/ : fix compilation warnings for the Write method (2 different
54 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
55 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
56 variable... create a static method in gdcm::Document to access to
57 this variable content.
59 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
61 file, to be accessed by other files (like gdcmFile). Remove commented
62 code. Move the change of the header to the gdcmFile, using the
64 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
65 To be sure of that (and simplify calls), the Write of the header now
66 gets a file name and not a file pointer (std::ifstream).
67 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
68 DocEntryArchive. Remove all open of the written file
70 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
71 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
73 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
74 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
75 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
77 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
78 some corresponding methods. Write correctly the file and check before
80 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
81 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
82 is now on RGB datas (as before my last commit
83 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
85 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
86 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
87 Add a print information of the type of the entry
88 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
89 It was in the gdcmFile, and all write have been regrouped
90 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
91 Write correctly all dicom files (in decompressed mode only at this time)
92 * Test/ : test on files are now made using Raw datas and not color datas if
94 * Example/PrintFile.cxx : add more printings
96 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
97 * Amelioration of code, remove some code copy. For the loading of
98 BinEntry (in gdcmDocument), add the test to verify if the file is already
101 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
102 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
103 remove a DocEntry in the header (push an empty DocEntry)
104 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
105 lines. Bug fix in the initialization of the PixelConvert and the
107 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
108 use in TestCopyDicom (now this test can run under windows... but fails)
109 * Test/TestCopyDicom.cxx : amelioration of the test :
110 - test the pixels written
111 - add test points to quickly find where is the error
112 - can set a file name input and output in arguments
113 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
114 amelioration of the test output
116 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
117 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
118 all replaced DocEntry's
119 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
120 Now, each needed DocEntry to modify is duplicated, modified and inserted
121 to the header using DocEntryArchive. Thus, after save, we can restore the
122 header initial state.
124 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
125 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
127 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
128 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
129 correct to copy it. The DictEntry is specified at the DocEntry creation,
130 then, it musn't change in the time.
131 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
132 header correctly. At this time, the change is only made for the first
133 level of the Document. In the future, it might consider sequences.
134 The change is made by replacing a DocEntry by an other that is created
135 outside the class. The old value is kept. When we restore the header
136 status, the added DocEntry is deleted and replaced by the old value.
137 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
138 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
139 set the write type to explicit VR, implicit VR or ACR. Add methods to set
140 the write mode to native, decompressed or RGB (but not used at this time)
142 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
143 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
144 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
146 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
147 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
148 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
150 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
151 set because already copied when copying the BinEntry's of the header
152 * Test/TestAllReadCompareDicom.cxx : remove warnings
154 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
155 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
156 Two problems appear when doing it :
157 - with the gdcmFile : when the GetImageData method is called, the pixels
158 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
159 datas (pixels). And each structure destruct the datas when it's
160 destructed. So we have two destructions for the same datas. To solve it,
161 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
162 datas or not. If it doesn't own datas, then they will not destroyed by
164 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
165 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
166 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
167 create a double destruction of the same DocEntry's. So, to solve it,
168 the TagHT is simply cleared and the DicomDir* elements are destroyed.
169 * TODO : add an entry concerning memory leaks in the DicomDir
171 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
172 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
173 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
176 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
177 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
178 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
179 after it have been deleted
181 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
182 * FIX: src/* fix the doxygen warnings.
183 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
184 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
185 was erroneously defined with a size of 15 instead of 16. [many thanks
186 to Jean Michel Rouet for pointing out this bug].
188 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
189 1. Finish merging JMR patch for writting DICOM from scratch
190 2. Fix -hopefully- bug with MONOCHROME and space vs null character
191 3. Use const ref when possible
192 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
193 5. A few more comments
194 6. CreateUniqueUID can now be called without parameter"
196 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
197 * ENH: Slightly bigger patch:
198 1. Getting toward full integration of JMR patch for writting dicom from scratch
199 2. Update Test to test part of this patch: CreateUniqueUID
200 3. File was not close properly in gdcmDict
201 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
202 5. Use of const ref instead of copy (speed issue)
203 6. Remove temporary (duplicate) string in TranslateToKey
204 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
205 8. Do not repeat virtual in subclasses
206 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
208 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
209 * Apply first patch toward better string comparison when dealing with broken
210 DICOM files. Essentially the string could be padded with a space instead
211 of a null character as defined by standard
213 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
214 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
215 because never used... and in the same time, that's remove some memory leaks
217 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
218 * src/gdcmFile.cxx : now delete the PixelConvert instance.
219 * In examples and tests : change the type of image data variables from void*
220 to uint8_t*. Remmove all delete on image data variables
222 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
223 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
224 Verify the file pointer value before open the file, and if it's not null,
225 a verbose message is generated.
226 Close correctly the file when the file isn't considered dicom-like. The
227 correctly close is a call to CloseFile.
228 When closing the file pointer, test if its not null to close the file.
229 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
230 file. For an uncompressed image, the copied datas correspond in the least
231 case to the image size (calculated) or the image size specified in the
232 header. A verbose is generated if these two size mismatch
234 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
235 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
236 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
237 break under windows (with msvc6 compilation).
239 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
240 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
241 compiling with MSVC6)
243 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
244 * Bugs fix for the Windows build with VC6
245 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
246 needed (only for projects required VTK). If the VTK is included in all
247 projects, there is conflicts with the jpeg lib of vtk when compiling the
248 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
249 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
250 when compiling the gdcm_wrap.cxx file (created by the compilation of the
252 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
253 (like it's already made for the cout use). Otherwise, conflict with the
256 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
257 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
259 - comments on the DicomDir::Method related usage added.
260 - now that we use the namespace gdcm, a lot of internal classes do
261 NOT need to be wrapped anymore.
262 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
263 DicomDir::Method) new example added.
265 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
266 * Improve string manipulation. I now inforce the notion of 'DicomString'
267 A DicomString can contain as many \0 as they want
268 and it is *always* of even length.
269 We only support odd length for very rare case.
270 And in the near future this should be removed.
272 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
273 * /binary_write/ gdcm source. Now even on big endian we are writting
274 little endian. This should -heopfully- fix some tests
276 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
277 * Now the dictionary is compiled into gdcm lib. This is a default
278 behavior, thus any dic file specified is picked before failback to
279 the one comiled into lib
281 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
282 * Change internals for gdcmDict. Don't use any 'new' any more.
283 This should definitely solve any leak problem, and we should be
284 as fast as before, as long as don't modify too much the dictionary.
286 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
287 * STYLE: ivars should start with a capital letter.
288 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
289 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
291 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
292 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
293 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
294 new 2004 dictionaries added (thanks to JPR).
295 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
296 * CLEANUP_ROUND (15) for gdcmPixelConvert
297 - RLEFrame::NumberFragments is now of type unsigned int
298 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
299 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
302 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
303 * Initial work in gathering all transfer syntax accessors. clearly
304 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
305 ivars, but only one transfersyntax (class) ivar with equivalent method on
308 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
309 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
310 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
311 discussed (plus I didn't like having a 2000 lines patch not commited)
313 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
314 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
315 * CLEANUP_ROUND (14) for gdcmPixelConvert
316 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
317 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
318 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
320 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
321 anymore and hence avoids storing a copy of PixelConvert::Decompressed
322 into File::Pixel_Data.
324 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
325 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
326 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
327 * CLEANUP_ROUND (13) for gdcmPixelConvert
328 Substituted File::ParsePixelData() with PixelConvert::Print() new
330 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
331 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
332 method to those classes.
333 - src/gdcmFile.[cxx|h]:
334 -- Added a ::Print() method.
335 -- PixelConverter is now a reference instead of a member.
336 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
337 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
339 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
340 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
341 collaboration diagram and inheritance diagram should be generated with
343 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
344 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
345 pointlessly wrapped (see
346 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
347 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
348 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
349 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
350 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
351 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
352 -- File::Initialise: PixelConverter setup moved away to
353 PixelConverter::GrabInformationsFromHeader()
354 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
355 interpretation moved away to PixelConverter::BuildRGBImage()
357 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
358 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
359 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
361 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
362 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
363 displayed on Win32 when a brutal abort() occurs (because of uncatched
364 exception). See TODO new entry of this commit for more on this.
365 * TODO added new entry.
366 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
367 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
368 - HandleColor is no longer called from gdcmFile.cxx
369 - gdcmPixelConvert.cxx clean up on method arguments and internal
370 variable names for semantical coherence.
372 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
373 * Finished lossless transition, not only do we now read all lossless jpeg
374 images, without the need of the Cornwell lib, but we do read them properly now
375 * To reduce code (well to avoid code duplication), I defined a common place
376 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
377 redefine symbols. This is not prefect but this the best solution I found for a
378 compilation time jpeg option.
380 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
381 * Update jpeg ijg lib to support lossless jpeg implementation
382 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
384 * Also added a special copyright for dcmtk since we use their bugfixes.
387 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
388 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
389 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
390 matters, as stated in warning note at begining of %include section).
391 * src/gdcmDicomDir*.[cxx|h]: coding style
392 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
393 * src/gdcmJpeg8.cxx: doxygen fix.
394 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
395 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
396 from File:: to PixelConvert::.
398 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
399 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
400 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
401 - more code moved away from File:: to PixelConvert::
402 - fat setup of PixelConverter set in place in File::Initialise.
404 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
405 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
406 namespace at the file system level. So now you should convert your examples
408 gdcmHeader -> gdcm::Header
409 It would be nice if people keep in mind to no open the namespace, since it
410 allows compilation on broken plateform which were defining common symbol in
411 the standart namespace (like LP, Unknown ...)
413 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
414 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
415 The JPEG fragments are now parsed at the same stage than the RLE
416 information. All code related to JPEG is now in gdcmPixelConvert:
417 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
418 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
419 export a gdcmFile:: method. Those are simply global functions
420 (for the time being this is better than having them attach to
421 either gdcmFile:: or gdcmPixelConvert::).
422 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
423 and stores the result in a gdcmJPEGFragmentsInfo.
424 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
425 code (among other stuff) moved away from gdcmFile:; to
428 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
429 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
430 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
431 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
432 clean up of RLE related code.
433 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
434 - src/gdcmRLE.cxx removed
435 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
436 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
437 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
438 * CLEANUP_ROUND (9) for gdcmPixelConvert
439 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
440 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
441 away from gdcmFile:: to gdcmPixelConvert::.
443 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
444 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
445 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
446 This is because Parse7Fe0 used to parse the pixels to compute the
447 length. This task was passed over to FindDocEntryLengthOB() a long
448 time ago, EXCEPT I had forgotten the OW case...
449 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
450 we just recylce the code for parsing RLE fragments and computing
452 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
453 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
454 with the retired Parse7Fe0().
455 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
456 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
458 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
459 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
460 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
461 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
462 - src/CMakeLists.txt: alphabetic order reodering + new entries.
463 * CLEANUP_ROUND (4) for gdcmPixelConvert
464 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
465 to return an unused length.
467 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
468 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
469 this should be cleanner from the plane view. The iostream are erally a pain
470 to use to do simple stuff.
472 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
473 * Redo the compilation of the ijg jpeg library. Now only one source is
474 necesseray. No need to rename file by hand what so ever. CMake handle the
475 copying of the file within different directory, configure header file to
476 modify some symbol. The only addition made to ijg wasd a mangle table so
477 that symbol are different wether we are within 8bits or 12bits.
479 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
480 * Added documentation of vtkgdcmReader on Website:
481 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
482 with it's binary name).
483 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
484 the Website to be more complete.
485 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
486 doxygenated documentation.
487 - Doc/DoxyVtkGdcmReaderExamples.txt added
488 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
489 DoxyVtkGdmReaderExamples.html )
490 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
491 * CLEANUP_ROUND (3) for gdcmPixelConvert
492 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
494 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
495 * CLEANUP_ROUND (2) for gdcmPixelConvert
496 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
498 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
499 * CLEANUP_ROUND for gdcmPixelConvert:
500 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
501 - src/gdcmPixelStuff[h|cxx] removed
502 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
503 - src/CMakeLists.txt changed accordingly
505 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
506 gdcmVersion.py moved to newly created ATTIC related
507 gdcmPython/SetupOldies/ directory.
508 * Autotools clean up:
509 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
510 - autogen.sh configure.in acinclude.m4 python.m4 removed
512 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
513 * src/*.cxx *.h Reference to License.htm fixed to License.html.
514 * Doc/CMakeLists.txt, doxygen.config.in: fix.
515 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
517 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
518 * TODO updated with Mathieu suggestions. I proposed a template for
519 describing TODO entries and used it for new entries.
520 * Added Doc/Website/CodingStyle.html, Developpers.html,
521 DeveloppersPython.html, GdcmDataCvs.html and
522 DownloadVersion0_1.html, DownloadVersion0_3.html.
523 * Some Doc/*.txt Doxygen files (which do not really concern the
524 documentation itself, but the website) moved to html and
525 placed in directory Doc/Website:
526 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
527 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
528 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
529 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
530 * CMakeLists.txt changed accordingly.
531 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
532 DeveloppersPython.html
533 * INSTALL nows refers to Doc/Website/Installation.html
535 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
536 * Added Doc/Website directory, that contains a first raw version
539 2004-09-23 Jean-Pierre Roux
540 * FIX In order not to be poluted any longer by casting problems,
541 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
542 we can now delete[] it safely
543 * VoidArea is now called BinArea (less confusing name),
544 and all the methods called ...VoidArea... are now ... BinArea...
545 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
547 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
548 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
549 clear) TagHT, which is an inherited member of gdcmElementSet. It is
550 up to the destructor of gdcmElementSet to clean up TagHt and it's
553 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
554 * Test/CMakeLists.txt: update to follow gdcmData renamings.
555 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
557 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
558 * ENH: added some utility method that builds a flat dictionnary
559 holding all the Dicom entries contained in the recursive structure
560 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
562 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
563 BuildFlatHashTable() that build a flat dictionary.
564 - src/gdcmElementSet.h: added a new private GetTag() accessor.
565 gdcmDocument is now a friend of gdcmElementSet.
566 - src/gdcmElementSet.cxx: clean up.
567 - Example/FlatHashTablePrint.cxx added.
568 - Example/CmakeLists.txt changed accordingly
570 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
571 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
572 moved away from gdcmDocEntrySet (since this class is an abstract class
573 acting like an interface). SQDepthLevel and BaseTagKey are now
575 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
576 and associated accessors. Doxygenation of the class.
577 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
579 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
580 Use SQDepthLevel accessor instead. ::Print() adapted.
581 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
582 - src/gdcmDocument.cxx changed accordingly.
584 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
585 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
586 - The following is the doxygen comment of the typedef declaration
587 of gdcmagKey in src/gdcmCommon.h:
588 gdcmTagKey is made to old an "universal" (as in URL, Universal
589 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
590 A dicom tag allways has a group and an element, but a set of tags
591 embeded in various (optionally nested) sequences and sharing
592 the same group and element all share the same (group, element)
593 "identifier". Hence the (group, element) cannot be used as an
594 identifier (in gdcm we shall refer to a "TagKey") of a tag.
595 In order to construct a proper tag identifier (i.e. a key) we
596 consider the following definition of a TagKey:
597 - let Group, Element be the string representation of the
598 group and element dicom tag members,
599 - let ItemNumber be the string representation of the integer
600 index of the considered item number of a sequence,
601 Let the key of a tag embeded in a sequence, noted SeqTag, be
603 /ItemNumber#Group|Element
604 where "/", "#" and "|" are characters acting as separators.
605 Then the general form of a gdcmTagKey is given by:
606 Group|Element<SeqTag>
607 where <SeqTag> means NO or many instances of SeqTag.
608 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
611 but the gdcmTagKey of a tag "embeded" is the first item of
612 a sequence, itself nested in the third item of a sequence is the
614 0004|1220/2#0008|0082/0#0008|0090
615 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
616 order to hold the new sequence compatible key. Previously, the
617 GetKey() method would look in the underlying gdcmDictEntry.
618 - src/gdcmDocEntry.cxx:
619 -- constructor now copies the underlying DictEntry key, in the local
621 -- ::Print: displays the member Key, instead of the (group, element).
622 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
623 - src/gdcmDocEntrySet.h:xi
624 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
625 -- now has a new BaseTagKey member.
627 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
628 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
630 This poses the problem with the semantics of the following lines
631 LoadEntryVoidArea(0x0028,0x1201); // R LUT
632 LoadEntryVoidArea(0x0028,0x1202); // G LUT
633 LoadEntryVoidArea(0x0028,0x1203); // B LUT
634 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
635 to the long FIXME note for what the problem is. Nevertheless in
636 order to get things working the dicom dictionary was altered !
637 Please fix things urgently...
638 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
639 information), see above note on moving the member VoidArea. Nevertheless
640 the following entries previously correctly set as US are now inproperly
642 0028 1201 OW IMG Red Palette Color Lookup Table Data
643 0028 1202 OW IMG Green Palette Color Lookup Table Data
644 0028 1203 OW IMG Blue Palette Color Lookup Table Data
645 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
646 of gdcmDocEntry moved to gdcmSeqEntry.
647 * src/gdcmSeqEntry.cxx: STYLE.
649 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
650 * Test/TestAllEntryVerify.cxx minor fix and added comments.
652 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
653 * gdcmPython/testSuite.py: all the test suite in python is now moved
654 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
655 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
656 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
658 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
659 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
660 to avoid inclusion recursion until STL is reached.
661 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
662 mecanism. errno.h is not included in gdcm anymore.
663 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
664 (gdcmFormatError now inherits from gdcmFormatUnexpected).
666 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
667 gdcmData/TestAllEntryVerifyReference.txt
668 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
669 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
670 exception_on_error parameter.
671 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
672 - vtk/vtkGdcmReader.cxx changed accordingly,
673 - Example/*.cxx and Test/*.cxx changed accordingly.
675 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
676 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
677 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
678 enable_sequences removed from gdcmHeader constructor and dependencies.
679 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
680 * gdcmPython/demo/PrintHeader.py: dummy fix.
681 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
682 skip_shadow removed from gdcmHeader constructor and dependencies.
683 * Example/*.cxx and Test/*.cxx changed accordingly.
685 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
686 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
687 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
689 2004-07-21 Jean-Pierre Roux
690 * FIX Now, Parsing and Printing a DICOMDIR do work!
691 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
693 2004-07-20 Jean-Pierre Roux
694 * FIX Some brain damaged headers have Zero-Lenght fields
695 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
697 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
698 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
699 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
700 variable (instance of gdcmDebug) by a definition macro, and the instance
701 is now in static in the gdcmDebug class
702 * src/gdcmSQItem.h : (FIXME) remove an undefined method
703 * Test/PrintAllDocument.cxx : bug fix in the result of the test
705 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
706 * WARNING: ctest now depends more tightly on gdcmData. You should
707 check out gdcmData properly for things to run smoothly...
708 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
709 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
710 we need the pixels not be loaded in order to use the ValEntry
711 that displays position and size).
712 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
713 This is a C++ based equivalent of gdcmPython/testSuite.py that should
714 be deprecated. If you have any doubts about the advantages of a
715 modern scripting language (read Python) versus grass root C++ (i.e.
716 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
717 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
718 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
719 Anyhow, consider documenting the gdcmData images in
720 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
722 * Test/CMakeLists.txt:
723 - now uses TestAllEntryVerify.cxx
724 - specific comments on oldACR00001.ima (now renamed in gdcmData
725 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
726 gdcmData/TestAllEntryVerifyReference.txt
729 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
730 * src/*.[h|cxx] : typedef clean up
731 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
732 - TagKey renamed to gdcmTagKey (for external usage)
733 - VRKey renamed to gdcmVRKey (for external usage)
734 - removal of typedef duplication.
735 - Removed all unecessary inline keyword from class inline definitions.
736 - Some method|function(void) declarations replaced with method|function().
737 * src/jpeg/libijg12/jdhuff12.c:
738 - printf polluting ctest removed.
739 - TAB removal for comminting
741 - TestAllReadCompareDicom.cxx: added a test that compares all the
742 images in gdcmDataImages.h with corresponding images in
743 gdcmData/BaselineDicom/. When baseline images are not present
744 this test creates them.
745 Note: we need to validate each reference image, but before that
746 I'd like to rename them with a more explicit name...
747 - CMakeLists.txt: changed accordingly.
748 * Example/*.cxx: examples now only include gdcm.h (as opposed to
749 including each header needed).
751 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
752 * Test/*.cxx and Example/*.cxx: moved some examples away from the
753 test suite to the Example directory. Are concerned:
758 - TestWriteSimple.cxx
759 * Test/CMakeLists.txt: added some comments on reasons for black listing
760 image gdcmData/oldACR00001.ima
762 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
763 * Test/CmakeList.txt: removed the following from black list (to be coherent
764 with removal from gdcmData):
765 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
766 - gdcm-MR-PHILIPS-16.dcm
768 Added the following because after last cvs update, they cause
769 ctest -R TestReadWriteReadCompare
771 - gdcm-MR-SIEMENS-16-1.acr
773 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
774 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
775 new comments in this file) we temporarily (sigh) move to a weaker
777 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
778 we don't need to black list the following images anymore:
779 - 8BitsUncompressedColor.dcm
781 - US-PAL-8-10x-echo.dcm
782 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
783 fixes and the beautified code ;-)
784 This fixes the bug introduced in version 1.42 (when beautifying)
785 that made the parsing of 8BitsRunLengthColor.dcm unproper.
786 Note: ctest was blind to this bug (this means we need to still
787 improve the test suite). The bug could be detected by using
788 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
790 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
791 and by displaying the (garbage) produced file temp.XDCM...
793 2004-06-29 Jean-Pierre Roux
794 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
795 - replace by uggly but working old code :-(
796 A lot of things should be OK again.
797 It's really urgent to have a test suite that *tests*,
798 to prevent Frog's beautifying sessions to break all the stuff
799 (twice, withing a fortnigh ...)
801 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
802 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
803 redundancy) to added Test/TestReadWriteReadCompare.cxx
804 * Test/CmakeList.txt: because the compare test of
805 Test/TestReadWriteReadCompare.cxx fails, the following images are
806 black listed: - 8BitsUncompressedColor.dcm
808 - US-PAL-8-10x-echo.dcm
809 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
810 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
811 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
812 and ad-hoc kludge. This kludge is now removed, and on encountering
813 such an image (OB field brain damaged) we set errno. Then in
814 ::FindDocLength() we "fix" the length as being ALL what remains
815 in the file (until EOF). We then proceed, hoping for the best...
816 This fixes a SegFault in ShowDicom when trying to write such an
818 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
819 (because TestWriteRead breaks on it, after a non conformal commit?).
820 ctest now runs properly, except for MakeDicomDir (which was allways
821 broken) and the Python related stuff (still not fixed).
823 2004-06-24 Jean-Pierre Roux
824 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
825 FIX : Test/TestReadWrite now iterates on all the file names
826 (instead of infinite loop)
827 ENH : Test/TestWriteRead now iterates on all the file names
829 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
830 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
832 2004-06-24 Jean-Pierre Roux
833 FIX : - now Write drops LUT Descriptors and LUTs (if any)
834 when SamplesPerPixel =3
835 - now Write is no longer confused by
836 'BitsAllocated = 12" and 'BitsStored=12"
837 - "UN" value representation Elements are now written correctly
838 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
839 ENH : - now gdcmHeader has its own Write methods
840 (in order to split the job that has not to be done
843 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
844 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
845 loop on the same image until memory went out.
846 Note: this means we still have gobs of memory loss in PrintDocument
847 * src/gdcmDocument.cxx: fixes problem on parsing on file
848 gdcmData/16BitsJpegLosslessGrayScale.dcm.
850 2004-06-24 Jean-Pierre Roux
851 FIX : Write - All the Sequences and Sequence Item are now written
852 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
853 is added a the end, when necessary.
854 - A lot of brain-damaged images, that were read correctly are
855 now written correctly
856 - length compatible BinEntry are now loaded correctly
857 (even for odd groups)
858 Note : only Explicit Value Representation was checked.
859 (question : is implicit VR really necessary for gdcm ?)
861 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
862 * DEVELOPPER: added a proposition of coding style.
863 * src/gdcmDocEntry.h: removed every inline declaration (for test of
866 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
867 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
868 Use the gdcmDocEntry::Print() and Write() instead.
869 * src/gdcmDocument.cxx: bug fix.
871 2004-06-22 Jean-Pierre Roux
872 FIX : gdcmDocument.cxx
873 - Now we do recognize the JpegLossLess format (there was a misstyping in
874 code 'beautyfication' :-(
875 - Now we automaticaticaly load the Luts, if any
877 2004-06-22 Jean-Pierre Roux
878 In order : to write Sequences, whatever their imbrication level,
879 : to allow user to create his own Sequences
880 a lot of modif where necessary (adding, moving, or virtualising methods)
882 WARNING : save your own sources *before* cvs up !
885 ADD virtual void Write(FILE *fp, FileType filetype);
888 ADD virtual void Write(FILE *fp, FileType filetype);
889 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
892 ADD virtual void Write (FILE *fp, FileType filetype)=0;
893 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
894 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
895 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
896 ADD std::string GetEntryByName(TagName name);
897 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
899 std::string vr = "unkn",
900 std::string fourth = "unkn",
901 std::string name = "unkn");
902 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
903 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
904 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
905 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
906 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
907 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
908 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
909 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
912 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
913 ADD virtual std::string GetEntryByName (TagName tagName);
914 ADD virtual std::string GetEntryVRByName (TagName tagName);
915 REM virtual bool Write(FILE *, FileType);
916 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
917 FILE *_fp, FileType type);
918 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
919 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
920 REM virtual bool WriteEntries(FILE *_fp,FileType type);
921 REM virtual std::string GetEntryByName (std::string tagName);
922 REM virtual std::string GetEntryVRByName (std::string tagName);
923 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
924 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
925 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
927 std::string vr = "unkn",
928 std::string fourth = "unkn",
929 std::string name = "unkn");
930 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
931 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
932 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
933 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
936 ADD virtual void Write(FILE *fp, FileType filetype);
939 ADD virtual void Write(FILE *fp,FileType filetype);
942 ADD virtual void Write(FILE *fp, FileType filetype);
943 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
944 REM std::string GetEntryByNumber(guint16 group, guint16 element);
945 REM std::string GetEntryByName(TagName name);
948 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
950 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
951 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
952 The default constructor invoked by the line
953 gdcmHeader *f1 = new gdcmHeader( header );
954 was gdcmHeader::gdcmHeader(bool) instead of the expected
955 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
956 Hence the parsing wasn't executed... See also below.
957 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
958 as explicit constructor didn't do the trick to fix the above problem.
959 Could anyone explain why ?
960 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
961 properly calls gdcmValEntry::Print() (that was weed out from
962 code related to gdcmBinEntry).
964 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
965 * In order to fix memory leaks:
966 - Test/TestWriteSimple.cxx: added cleaning of free store through
968 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
969 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
970 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
971 (through the call to ::AddDicomDirMeta()) or the destructor
972 would crash when deleting uninitialized ::metaElems].
973 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
974 - src/gdcmDocument.cxx:
975 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
977 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
978 was causing memory leaks.
979 - src/gdcmSQItem.cxx:
980 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
981 cleanly handled with polymophism: sorry but my milage is low).
982 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
983 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
984 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
985 This avoids SegFaulting.
986 - src/gdcmSQItem.h: coding style.
988 - Test/TestWriteSimple still severely sucks. The output image content
989 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
990 damaged when displayed with vtkgdcmViewer.
991 - on memory leaks: TestWriteSimple leaks really less (see entry
992 of 2004-06-18 in Changelog file for the call to valgrind).
993 - on segfaults: ctest now passes all the tests but one (no more
995 * Erroneous leading white fix:
996 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
997 white[s] (as opposed to from >> xxx, that removes it [them].
998 - src/gdcmTS.cxx: ditto.
999 - gdcmPython/testSuite.py: dirty related kludge removed.
1000 * src/*: remaining references to gdcmParser removed.
1001 * src/*[cxx|h]: added copy[way]left header.
1004 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1005 * In order to fix writing of dicom files:
1006 - Test/TestWriteSimple.cxx: a simpler example of writing.
1007 - Test/CMakeLists.txt changed accordingly.
1008 - src/gdcmDocument.cxx:
1009 -- The destructor now recursilvely removes potential sequences.
1010 -- Bug fix in ::IsJPEG2000()
1011 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1012 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1014 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1015 to only declared) and build on top of
1016 ::GetDocEntryByNumber(guint16, guint16).
1017 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1018 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1019 for usage in destructor and treatement of promotion in
1020 ::ReplaceOrCreateByNumber().
1021 - src/gdcmSQItem.cxx: destructor should better handle his job.
1022 Test/TestWriteSimple now runs (or at least it DOES something).
1023 * We can now start hutting memory links. A good starting point is:
1024 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1025 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1026 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1028 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1029 * Valgrind note: after Mathieu Malaterre teached me how to read
1030 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1032 Using gcc, you can force the STL to use malloc and to free memory as
1033 soon as possible by globally disabling memory caching.
1034 With 3.2.2 and later, you should export the environment variable
1035 GLIBCPP_FORCE_NEW before running your program.
1036 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1037 simply vanish (it is still not clear to me, whether this means that
1038 STL std::string leaks or if valgrind believes it leaks...).
1039 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1040 running bin/gdcmTests makeDicomDir):
1041 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1042 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1044 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1045 SegFaulting (I drowned in DicomDir related code when trying to
1046 understand why the list is empty...).
1047 * src/gdcmDocument.h: first BSD license header try.
1048 * Doc/License.txt added.
1050 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1051 * src/gdcmDocument.[h|cxx]:
1052 - Clean up of the Transfer related predicates. They are now all based
1053 on new method isGivenTransferSyntax, that (should) handle properly
1054 the padding problem.
1055 - general clean up, simplification, and coding style.
1056 - Specific clean up of Parse7FE0() (umproperly named actually).
1057 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1059 2004-06-14 Jean-Pierre Roux
1061 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1062 - fix the display of SQItem ordinal number
1063 - add the GetSQItemByOrdinalNumber method
1064 - remove some useless never written private methods
1066 2004-06-14 Jean-Pierre Roux
1068 - adding a constructor taking a gdcmDocEntry as an input param
1069 - ReplaceOrCreateByNumber now returns :
1070 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1071 a gdcmValEntry * if a string value is passed as a param
1073 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1074 according to the param type (no longer sets a gdcmDocEntry)
1075 - GetValEntryByNumber, GetBinEntryByNumber added
1076 - NewValEntryByNumber and NewBinEntryByNumber added
1078 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1080 - GetSQItemNumber and SetSQItemNumber added, to provide
1081 a (relative) Item identier inside a given Sequence
1082 \warning : some pb remaining around this number
1084 - AddEntry now takes the Item Number as a param
1086 - adding a constructor taking a gdcmDocEntry as an input param
1088 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1089 * Memory leak hunt with the following command:
1090 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1091 --show-reachable=yes gdcmTests PrintDocument
1092 It looks like many (all?) leaks are due to the STL (or a bad usage
1093 of the STL. The lines producing the leaks now have a comment with
1094 a "MEMORY LEAK" tag: you can retrieve them with
1095 grep "MEMORY LEAK" src/*
1096 Here are two typical examples which I can't help fixing:
1101 char * test = "babo";
1102 name = test; //// <--- valgrind detects 960 bytes lost in
1103 //// call to std::string::operator=(char const*)
1104 name.clear(); //// Doesn't help !
1112 std::cout << "Type a bunch of characters followed by RETURN: ";
1113 getline(std::cin, line); //// <--- valgrind dectects a loss
1114 //// of 1320 bytes in call to
1115 /// std::basic_istream<>& std::getline<>
1121 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1122 * src/gdcmHeader.[cxx|h]:
1123 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1124 and related, moved away to gdcmDocument.
1125 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1126 the corresponding protected accessors of inherited class
1127 gdcmDocument, removed ! As a consequence gdcmFile had to be
1128 declared friend of class gdcmDocument (see below).
1129 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1130 - Clean up of undefined or unused methods.
1131 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1132 account the changes to gdcmHeader.h).
1133 * src/gdcmDocument.h:
1134 - gdcmFile is now a friend class (in order to take into account the
1135 changes to gdcmHeader.h).
1136 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1137 (see changes to gdcmHeader.h).
1138 - Accessors (reading on the form GetEntry*) are now public.
1139 - Clean up of undefined or unused methods.
1140 * src/gdcmDocument.cxx:
1141 - adaptation to changes to gdcmDocument.h
1142 - ::OpenFile now writes a verbose message when file cannot be opened.
1143 - some std::string properly set to VRKey
1144 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1145 references to gdcmDocument.
1146 * Test/TestFindTags.cxx: changed accordingly to above changes.
1147 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1148 cvs repository gdcmData.
1150 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1151 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1152 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1153 conflicts with gdcmValEntry::voidArea.
1154 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1155 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1156 Value representation between StringRepresentable and BinaryRepresentable.
1157 * src/gdcmDocument.cxx:
1158 - method ParseDES: proper indentation restored and usage of
1159 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1160 - method LoadDocEntry: the fingerprint left in the SetValue() of
1161 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1162 removed. Reverting to previous code segment with the proper
1163 dynamic_cast< gdcmValEntry* >.
1164 Note: this was (partially) breaking the python test suite
1165 (gdcmPython/testSuite.py) that made usage of the above
1166 fingerprint to check presence of "Pixel Data".
1167 * src/gdcmDocEntry.h: coding style.
1168 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1169 now taken into account.
1170 * gdcmPython/gdcm.i: adaptation to the new internal representation
1171 of gdcm (exit gdcmParser, hello gdcmDocument).
1172 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1174 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1175 anymore, but instead prints the loaded Python dictionary.
1176 * .... alas, the python testSuite is still broken.
1178 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1179 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1181 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1182 * src/gdcmUtil.h : export methods
1184 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1185 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1187 * Initial addition of automatic python testing
1188 * Initial addition of automatic image comparison
1190 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1191 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1192 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1194 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1195 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1196 * Test/ShowDicom.cxx : bug fix for msvc compilation
1197 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1199 2004-05-04 Jean-Pierre Roux
1200 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1201 new concepts (and new classes) :
1202 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1203 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1204 - Sequence Doc Entries (gdcmSeqEntries)
1205 a Sequence is composed of Items.
1206 Each item is a set of Doc Entries (this is recursive)
1207 The non uniqueness of the 'Dicom tag' is due to this recursivity
1208 (never taken into account)
1209 Our unability to add a new 'entry' in the header
1210 at the proper location (neither in the H-Table (map or multimap),
1211 nor in the Chained List is also due to this recursivity.
1212 Don't try, right now, to use/modify/compile these new sources :
1213 nothing is finished.
1214 We just commit all the stuff, 'as is', in order not to loose it.
1216 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1217 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1219 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1220 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1221 file prefix (SetFilePrefix)
1223 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1224 * Add a new test: ShowDicom, for now this is just the c++ version of
1225 checkRead.sh, later it will be able to compare the image read against a
1227 * Replace the DEBUG on the stack with a global entry in cmake interface:
1228 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1230 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1231 * Add an example subdir, with a real example on how to read + write a
1234 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1235 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1236 * Doc/CMakeLists.txt: the main page is now properly differentiated
1237 between the developper and user version.
1238 * Doc/doxygen.config.in: dropped search related obsolete flags
1239 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1241 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1242 * DEVELOPPER: added some helpfull comments for compile/test/install
1245 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1246 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1247 src directory, now generated in the build dir.
1248 2. Tests as mentionned smarter
1250 4. Add a new method in gdcmDict that return the PubDict by name
1251 this is interesting for 3rd party lib like ITK,
1252 where we could set the institution name / patient name...
1254 * ENH: 1. Now the test suite is working for real
1255 2. All binaries are now output in the gdcm-bin directory
1256 (this was not true before)
1258 2004-04-28 Jean-Pierre Roux
1259 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1260 SeQuence indented printing of Dicom Header.
1261 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1262 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1263 Computation of SQDepthLevel is now part of gdcmHeader constructor
1264 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1265 tree-like structure of a Dicom Header.
1266 * FIX Test code cleaning
1268 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1269 * ENH: Adding automatic testing
1270 1. Need a DartConfig.cmake to submit to public
1271 2. Add a test driver gdcmTest.cxx
1272 3. gdcmTestMain, an helper for the main test driver gdcmTest
1273 4. Files in Test don't have a main anymore, this becomes interesting
1274 when we add more and more tests, thus dsw don't have to load
1276 * ENH: Adding a GDCM_DATA_ROOT for testing
1277 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1278 one file instead of seven + some small cleanup
1280 2004-04-22 Jean-Pierre Roux
1281 * ENH Minor changes to the Print() methods.
1282 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1283 Header printing. Example given with :
1284 > PrintHeader fileName 2 new
1285 (SQ based tree-like structure still to be done for the Header ...)
1287 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1288 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1289 1. I have added some unsigned where needed
1290 2. Some function parameter not used -> (void)
1291 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1292 4. g++ don't like character '\' in comment
1293 5. #define jpeg_create_decompress jCreaDecompress
1294 this really need to be fixed
1295 6. virtualize destructor of gdcmObject ... leakage
1296 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1297 this also really need to be fixed
1298 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1299 remove compression file
1300 (as we only do decompression, right ?)
1301 * ENH: Change malloc/calloc/free with c++ equivalent
1303 2004-04-21 Jean-Pierre Roux
1304 * FIX gdcmHeaderHelper::GetXSpacing
1305 when a single value is found (bug ?), xpacing is now
1306 defaulted to yspacing
1308 2004-04-19 Jean-Pierre Roux
1309 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1310 * ENH add parameters :
1311 bool exception_on_error = false,
1312 bool enable_sequences = false,
1313 bool ignore_shadow = false
1314 to the gdcmFile constructors to be full gdcmParser compliant
1315 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1316 to allow reading of PAPYRUS 3.0 files
1318 2004-04-06 Jean-Pierre Roux
1319 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1321 2004-04-02 Jean-Pierre Roux
1322 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1323 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1324 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1326 2004-03-30 Jean-Pierre Roux
1327 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1328 for ACR file, written out as DICOM files (hope so...)
1330 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1331 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1332 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1333 moved to base class gdcmParser and only the specialisation is kept
1335 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1336 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1337 already does the job.
1338 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1339 (to be consistent with gdcmParser::WriteEntries).
1341 2004-03-30 Benoit Regrain
1342 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1343 upate of the object's instance. It's passed to 2 in the unfavorable
1344 case : one in the ExecuteInformation, one in the ExecuteData
1346 2004-03-29 Jean-Pierre Roux
1347 * ENH : Check on file type to be written moved
1348 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1349 * FIX : gdcmObject::ResetBoundaries now stops properly
1350 when end-of-list is reached
1351 : gdcmVersion modified (as Benoit Regrain asked)
1353 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1354 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1355 * src/gdcmUtil.cxx: added forgotten iostream include.
1356 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1357 equivalent to ExplicitVR in existing code).
1359 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1360 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1361 now contains all the gdcmGlobal related code.
1362 * minor coding style and doxygenation changes.
1364 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1365 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1366 now contains all the Debug related code.
1367 * minor clean-up of includes in src/*.cxx
1368 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1369 CreateCleanString) removed.
1370 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1371 * Doc/DoxyMainPageUser.txt added.
1372 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1373 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1374 src/gdcmDirList.cxx)
1376 2004-03-24 Jean-Pierre Roux
1377 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1379 2004-03-23 Jean-Pierre Roux
1380 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1381 big endian made volumes
1382 * ENH Now gdcmParser constructor and destructor are protected to forbid
1383 end user to instanciate class gdcmParser
1384 (only gdcmHeader and gdcmDicomDir are meaningfull)
1386 2004-03-22 Benoit Regrain
1387 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1388 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1389 gdcmSerie to gdcmDicomDirSerie
1391 2004-03-19 Jean-Pierre Roux
1392 * ENH Now the tree-like structure describing a DICOMDIR comming from
1393 an already existing DICOMDIR file is consistent with
1394 the home-made tree-like structure build ex-nihilo
1395 or build from the files held (recursively) in a Directory
1396 functions gdcmDicomDir::CheckBoundaries()
1397 gdcmObject::SetBoundaries() added
1399 2004-03-17 Jean-Pierre Roux
1400 * REM (Eric Boix bug) : removal of meaningless
1401 gdcmDicomDirImage::NewImage function.
1402 * FIX now file names and directory name are written properly in the
1404 * FIX now gdcmDicomDir constructor may be call without any trick
1407 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1408 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1409 of gdcmDicomDirImage::NewImage as empty function.
1411 2004-02-28 Jean-Pierre Roux
1412 * ENH add gdcmDicomDir:NewPatient
1413 add gdcmDicomDirPatient:NewStudy
1414 add gdcmDicomDirStudy:NewSerie
1415 add gdcmDicomDirSerie:NewImage
1416 to allow making gdcDicomDir object.
1417 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1418 (as opposite to the gdcmHeader chained list)
1420 2004-02-11 Benoit Regrain
1421 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1422 when using from python
1424 2004-02-10 Benoit Regrain
1425 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1426 * FIX : in gdcmDicomDir when the directory is empty
1427 * ENH : add callback and methods to get the progression of dicomDir
1430 2004-02-06 Jean-Pierre Roux
1431 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1432 - GDCM_META added to gdcmDicomDirType
1433 - class gdcmMeta created
1434 * ENH : - A brief summary is now displayed at the beginning of
1435 'testDicomDir' to help disaster magnitude estimation
1436 * REM : Now useless Test/explDICOMDIR.cxx
1438 2004-02-05 Benoit Regrain
1439 * ENH : add methods in gdcmObject to get the hash table or the list of
1441 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1442 * FIX : wrapping python for TagHeaderEntryHT
1444 2004-02-04 Benoit Regrain
1445 * FIX : even length for some strings when writting the dicom dir
1446 * FIX : sort the images in the dicom dir
1447 * FIX : Bug fix for python use of dicom dir
1448 * ADD : a python demo
1450 2004-02-04 Jean-Pierre Roux
1451 * FIX : Final solution (?) for icone embedded images
1452 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1453 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1454 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1455 gdcmData/gdcm-MR-SIEMENS-16.acr1
1456 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1457 to make full checking easier
1459 2004-02-04 Benoit Regrain
1460 * FIX : WriteEntries : coding style & logic in parameters
1461 * FIX : Set the elements to create the DicomDir in a dictionary file
1463 2004-02-03 Benoit Regrain
1464 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1465 * gdcmDicomDir : add the load of directory
1466 * Bug fix and print add-on
1468 2004-02-03 Jean-Pierre Roux
1469 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1470 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1471 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1472 * FIX gdcmParser.cxx : 'group length' elements are now considered
1473 as integers, even for shadow groups, when file is Implicit VR
1475 2004-02-02 Jean-Pierre Roux
1476 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1478 of the last synonym :-(
1479 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1481 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1482 * FIX taking into account the possible 7fe0,0010 multiplicity
1483 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1484 to allow removal of references to 7fe0,0010, to deal with
1485 ACR-NEMA images, when 0028,0200 is meaningfull
1487 2004-01-31 Jean-Pierre Roux
1488 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1489 no longer writes 'Un' on disk
1490 * FIX SQ elements with actual length are now dealt with corectly
1491 * FIX gdcmFile::WriteBase make the difference, for color images, between
1492 the length (for Palette expanded images)
1493 and Raw Length (non expanded image + Palette)
1494 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1495 (that broke Write). Replaced by UL.
1496 Aware user will reload the field if he
1497 thinks it's necesssary
1499 2004-01-30 Jean-Pierre Roux
1500 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1501 when 'dirty Acr' is found, to be compliant with the new
1502 IsReadable() methods.
1504 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1505 (no DOUBLE images in kosher DICOM,
1506 but so usefull for people that miss them ;-)
1508 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1509 DICOMDIR related utilities (not checked as Windoze compliant)
1511 2004-01-28 Jean-Pierre Roux
1512 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1514 2004-01-27 Jean-Pierre Roux
1515 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1516 to allow skipping the shadow elements, to save memory space.
1517 The TRUE value for this param has to be used
1518 with a FALSE value for the 'enable_sequence' param.
1519 ('public elements' may be embedded in 'shadow Sequences')
1520 * gdcmHeader methods now deal with 'embedded icones images' in the header
1521 (even when an 'icone image sequence' is announced by the
1522 element (0x0088,0x0200), but there is NO icone at all ...
1524 * gdcmHeader sometimes Image Location value doesn't follow
1525 the supposed processor endianity (see gdcmData/cr172241.dcm).
1528 * gdcmHeader add the method
1529 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1530 to get *all* the Header Entries with the same tag.
1531 GetHeaderEntrySameName is probabely *useless*
1532 (no meaning : Name is *not* an identifier within the Dictionnary)
1534 2004-01-26 Benoit Regrain
1535 * Bug fix in the print of hexadecimal representations. Remove long fields
1536 in the print and add a third level of print to print them
1538 2004-01-23 Benoit Regrain
1539 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1540 * Bug fix on test suite after remove the strip made on not string fields
1541 * Split the IsReadable method between gdcmParser which test that the file
1542 is dicom and gdcmHeader which test that it's an image file
1544 2004-01-22 Benoit Regrain
1545 * DicomDir : clean code, add methods, set variables in protected or private
1546 * gdcmUtil : bug fix for the clean string method
1548 2004-01-19 Benoit Regrain
1549 * Add the use of shadow dictionaries
1550 * bug fix and coding style
1552 2004-01-19 Benoit Regrain
1553 * src/gdcmFile.cxx : bug fix concerning the close of file
1554 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1555 * Add the update of header entries using the shadow library
1557 2004-01-19 Benoit Regrain
1558 * removal of file gdcmHeader2.cxx
1559 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1560 inheriting from gdcmParser. This split is to prepare the integration
1561 of dicom dir parsing
1562 * bug fix under python
1564 2004-01-16 Jean-Pierre Roux
1565 * REM removal of class gdcmHeaderEntrySet
1566 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1567 * ADD add file gdcmHeader2.cxx
1568 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1570 2004-01-15 Benoit Regrain
1571 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1572 entries created while parsing the header. Thus, they will be destroyed
1573 when the gdcmDictSet will be destroyed
1574 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1577 2004-01-15 Benoit Regrain
1578 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1579 made a fatal error because of the memory release at the end of program.
1580 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1581 some memory and vtk seems to have some problems with that.
1582 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1584 2004-01-14 Benoit Regrain
1585 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1586 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1587 * src/*.[h|cxx] : make changes due to class name changes
1588 * gdcmPython/demo/*.py : bug fix due to method names
1590 2004-01-13 Benoit Regrain
1591 * src/*.[h|cxx] : coding style
1592 * vtk/*.[h|cxx] : coding style
1594 2004-01-13 Benoit Regrain
1595 * gdcmPython/testSuite.py : test the readable flag of file for tests
1596 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1597 It's lied to the stl compilation by MSVC (windows, always windows...)
1598 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1600 2004-01-12 Benoit Regrain
1601 * src/*.h : add comments
1602 * src/gdcmDictSet.h : set the method BuildDictPath in public
1603 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1604 directly setted in the source code
1605 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1608 2004-01-09 Benoit Regrain
1609 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1610 * setup.py : use a reference to gdcmVERSION
1612 2004-01-07 Benoit Regrain
1613 * Modification to compile with the distutils.
1616 2003-12-10 Benoit Regrain
1617 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1618 can use a gdcmHeaderHelper to load datas
1619 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1620 made in the source code
1622 2003-12-10 Benoit Regrain
1623 * Update Windows projects and .cvsignore files
1625 2003-11-12 Jean-Pierre Roux
1626 * ENH gdcmHeader constructor has one more parameter (default value : false)
1627 that allows the user to 'go inside' the SeQuences only
1629 gdcmElValSet:Print takes it into account
1631 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1632 * ENH: Update gdcmPython/CMakeLists
1633 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1634 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1636 2003-11-10 Jean-Pierre Roux
1637 * FIX : gdcmHeader::LoadElements is now based
1638 on the ListTag listElem member,
1639 not longer on the TagElValueHT tagHt member
1640 * ENH : PrintPubElVal shows (temporarily) both results,
1641 with the tagHt member and the listElem member.
1642 (it's easier to 'see' the problems when using Printheader)
1644 * FIX : old private member LgrElem is now splitted into
1645 ReadLength : Length actually found on disk (updated only
1646 if bug fixing is necessary), for internal
1648 UsableLength : Updated by FixFoundLength, to fix a bug
1649 or to allow Parser going on.
1650 Will allow to re-write a kosher header when a SeQuence
1651 with a length (not 0000) is found
1652 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1653 because gdcmElValSet::Add does not update ListElem
1656 2003-11-07 Jean-Pierre Roux
1657 * FIX misstyping in Transfert Syntax name table
1658 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1659 when they have an actual length (not 0000 nor FFFFF)
1660 (Nobody should care of it, but DICOMDIR explorers)
1662 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1663 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1665 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1666 * ENH: vtkGdcmReader now supports LUT !
1667 (vtkgdcmViewer for now is not able to use them though)
1669 2003-11-05 Jean-Pierre Roux
1670 * in testSuite.py : new files names for checking the package
1671 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1672 that returns the pixel area size to the *aware* (vtk) user
1673 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1675 2003-11-05 Benoit Regrain
1676 * in testSuite.py : Modify the rules for checking the paths
1677 : Explicit error messages
1678 * in __init__.py : Related modif
1680 2003-11-03 Jean-Pierre Roux
1681 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1682 to be used by aware (vtk) users that want to manage
1683 LUT (and no to turn the PALETTE image into an RGB pixels one)
1684 * GetPixelType now returns 8U for 24 Bits images
1685 (vtkGdcmReader compliant)
1687 2003-10-31 Jean-Pierre Roux
1688 * Removal of *all* gdcmData images and add them again
1689 in order to loose the 'history' of un-anonymised images
1691 2003-10-31 Jean-Pierre Roux
1692 * RMV : removal of useless jBitsInJsample.h
1693 for both 8 and 12 Bits JPEG Lossy Libraries
1695 2003-10-31 Jean-Pierre Roux
1696 * ENH : Add the functions gdcmFile::GetImageDataRaw
1697 gdcmFile::GetImageDataIntoVectorRaw
1698 that act as GetImageData and GetImageDataIntoVector
1699 except the making of an RGB Plane from Gray Plane + LUT
1700 Intended to aware (vtk) users who know how to manage
1703 GetLUTRGBA return a R,G,B,A LUT if any
1704 lgrTotaleRaw gives the 'Raw' length
1705 GetImageDataRaw returns the gray Plane
1706 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1707 (They stay Grey, just like with other Dicom viewers :-(
1709 2003-10-30 Jean-Pierre Roux
1710 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1712 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1713 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1714 being coherents dicom files.
1716 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1717 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1719 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1720 * ENH: Two steps is necessary to please VC++ compiler...
1721 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1722 * ENH: Add include dir to medcon lib
1723 * FIX: only one function is being exported for now !
1724 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1726 2003-10-29 Jean-Pierre Roux
1727 * adding gdcmHeader::GetLUTRGBA
1728 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1729 --> Mathieu, the modif u're waiting for is not yet committed
1730 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1732 2003-10-27 Jean-Pierre Roux
1733 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1734 00191113.dcm DermaColorLossLess.dcm
1735 MxTwinLossLess.dcm RadBWLossLess.dcm
1736 * ENH: For version prior to vtkImageViewer2 -r 1.19
1737 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1739 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1740 * Removal of ido stuff in CMakeLists.txt
1742 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1743 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1744 * FIX: remove a call to ->Modified ... see comments
1745 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1747 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1748 * FIX: Problem with path for libvtkgdcmPython
1749 * ENH: Try adding a search script for python site-package
1750 * RMV: Remove some file from medcon lib that are not necessary
1751 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1752 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1753 * FIX: More pragma disable fro VC++,
1754 I don't think I break something as it is also disable in VTK/ITK.
1755 But it fasten debug compilation time.
1757 2003-10-23 Jean-Pierre Roux
1758 * gdcm now deals with 16 Bits Run Length Encoded images
1759 (they are compressed as 2 planes images,
1760 one for the high Bytes, the other for low Bytes)
1762 2003-10-22 Jean-Pierre Roux
1763 * Now CheckRead takes into account :
1764 - the bugged 'Leonardo' Siemens images
1765 - the XA images, sent thru the burning VPRO station
1766 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1769 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1770 * FIX: When copying a Makefile.am to CMakeLists.txt
1771 one should remove the '\'
1773 2003-10-22 Jean-Pierre Roux
1774 * in gdcmData adding a bugged 'Leonardo' Siemens image
1775 (wrong lengths in header)
1776 OK with gdcm, KO with the other viewers :-)
1777 * add a GE dlx XA image, thru the VEPRO burning station
1780 2003-10-21 Jean-Pierre Roux
1781 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1782 for a brutal checking of vtkgdcmViewer compliance
1784 2003-10-21 Jean-Pierre Roux
1785 * add the files for 'xmedcon' Jpeg Lossless library
1786 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1788 2003-10-21 Jean-Pierre Roux
1789 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1791 2003-10-21 Jean-Pierre Roux
1792 * garbage Siemens 'Leonardo' images dealt with
1793 (the patch is easy to remove)
1794 * cosmetic changes to avoid warnings
1796 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1797 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1798 no need to press 'r' now.
1800 2003-10-20 Jean-Pierre Roux
1801 * upgrade of checkRead.sh checkWrite.sh according
1802 to new Jpeg Lossless decompressor
1803 * add US.3405.1.dcm, a genuine RGB medical file ...
1804 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1805 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1807 2003-10-15 Jean-Pierre Roux
1808 * general anonymisation in gdcmData
1809 * adding the 'color files' from
1810 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1811 * adding some well knowed bugged-header images
1812 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1813 waiting for their inclusion in Python testsuite
1815 2003-10-15 Jean-Pierre Roux
1816 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1817 no longer seg faults when file is not found
1819 2003-10-14 Jean-Pierre Roux
1820 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1823 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1824 * TODO: *.in file to genereate a UseGDCM later
1826 2003-10-14 Jean-Pierre Roux
1827 * Some supposed-to-be Dicom Images have no preamble.
1828 OpenFile takes it into account
1829 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1830 * Missing elements added in dicomV3.dic
1831 (just to be affraid : have a look at
1832 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1833 and do it again next year ;->
1835 2003-10-13 Jean-Pierre Roux
1836 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1837 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1838 But there are NOT. It's fixed !
1840 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1841 * FIX: "jpeglib.h" was not found on VC++
1842 * FIX: vtkgdcm was not being installed
1844 2003-10-10 Jean-Pierre Roux
1845 * ENH : OpenFile closes the file if it *really* doesn't look like
1846 an ACR-NEMA / DICOM one.
1847 * FIX : testWrite no longer writes an empty file if the source file
1848 is not gdcm Readable
1849 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1852 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1853 * FIX: CMake generate now documentation
1854 * ENH: out of source doc build !
1855 * ENH: Generate both user and dev documentation
1856 * ENH: Should work on windows too
1857 * ENH: Only one doxygen config.in file is needed
1858 * FIX: make install should be ok now on ùnix plateform
1859 * FIX: PATH to dictionary was wrong (missing /)
1860 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1862 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1863 * vtkGdcmReader is now able to read rgb dicom file.
1864 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1865 * added a gdcmViewer to vtk test, use mouse to control
1866 window level & window width
1868 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1869 * CMake-ification of gdcm, we have now two build system
1870 * FIX: on cygwin Wsock32 doesn't exist
1871 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1873 2003-10-06 Emanuel Ollart
1874 * FIX : compilation process wad broken.
1875 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1877 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1878 * change gdcmViewer -> vtkgdcmViewer
1879 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1881 2003-10-06 Jean-Pierre Roux
1882 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1883 ( e.g : well known GE images with a wrong elem length,
1884 : Philips MRI Images with a wrong Huffman table)
1885 * still to be done : allow the reading of bugged LEONARDO Siemens images
1887 2003-10-03 Jean-Pierre Roux
1888 * Odd length strings are padded with '\0' (not with spaces,
1889 to remain compliant with already defined strings,
1890 like Transfert Syntax UID and others)
1892 2003-10-03 Jean-Pierre Roux
1893 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1894 to allow displaying RGB images (not only by affim ;-)
1896 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1897 * vtkGdcmReader is now able to read rgb dicom file.
1898 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1900 2003-10-03 Jean-Pierre Roux
1901 * A few nasty patches to allow the reading of a lot of nasty images
1902 ( e.g : well known GE images with a wrong elem length,
1903 : Philips MRI Images with a wrong Huffman table)
1904 * still to be done : allow the reading of bugged LEONARDO Siemens images
1906 2003-10-03 Jean-Pierre Roux
1907 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1909 2003-10-03 Jean-Pierre Roux
1910 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1911 to allow displaying RGB images (not only by affim ;-)
1913 2003-10-03 Jean-Pierre Roux
1914 * gdcmFile::GetImageDataIntoVector now
1915 - deals with MultiFrames MultiFragments Run Length Encoded files
1916 - deals with YcBcR (YBR_FULL) files
1917 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1918 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1920 (no sample found :-(
1922 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1923 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1924 Two reasons: - clear things
1925 - third parties acces gdcm through header files, so won't
1926 suffer anymore VC++ complains
1928 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1929 * add argv[1] in testvtkGdcmReader.cxx
1932 2003-09-24 Jean-Pierre Roux
1933 * The lines are now eigthy characters long.for
1934 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1936 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1937 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1938 char* to std::string. Thus, the use of strdup becomes useless. (see
1939 previous commis of Malaterre)
1940 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1941 before the last Malaterre's commit.
1943 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1944 * This commit should fix the Debug building under VC++, the problem
1945 was mainly a mixture of debug and release lib being loaded at startup.
1946 * I also remove a depency to a specific C function: strdup. Because I had
1947 to force the link to msvcrtd (whereas strdup is in libc).
1949 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1950 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1951 located in the gdcmCommon.h file. All use of reference of tha has been
1952 changed to now use the variable GDCM_UNFOUND.
1954 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1956 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1957 Dicom dictionary. The test suite can now be run again. Note:
1958 I'm note very happy with the " (RET)" changes. I believe this
1959 RETAINED comment should be dropped when parsing the dictionary.
1960 - PACKAGER corrected
1962 - AUTHORS updated and now in alphabetical order
1963 * Makefile.am now exports gdcm.dsw for Windoze users.
1965 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1966 * cygwin complains about missing std:: in subdir Test/
1968 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1969 * remove some methods that are now in gdcmHeaderHelper
1971 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1972 * vtkGdcmReader set spacing and origin correctly
1974 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1975 * Fix a few delete/delete[] mismatch
1977 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1978 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1979 interpretation to data given by gdcmHeader. For instance there are
1980 heuristics to get informations (look at different places).
1981 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1982 sorting DICOM images based on different strategies.
1983 * modified Makefiles accordingly.
1985 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1986 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1987 when building in debug mode
1988 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1989 src/win32/gdcmdll.dsp
1990 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1992 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1993 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1996 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1997 * src/win32/libgdcmjpeg12.dsp was not dos format
1998 * src/win32/libgdcmjpeg12.dsp :
1999 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2000 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2002 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2003 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2005 * src/gdcmFile.cxx : bug fix in affectation type
2006 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2007 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2008 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2009 symbols... future problem ?
2011 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2012 * src/win32/libgdcmijpeg12.dsp was missing
2013 * modified gdcm.dsw accordingly
2015 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2016 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2018 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2019 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2020 commit of JPR (before his hollidays to facilitate our work).
2021 * setup.py : bug fix in code. Modifications made while the last commit
2022 of JPR. The code hasn't been tested before the commit... it's so
2023 useless to make that (for best programmer that is JPR) !!!
2025 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2026 * tagged the current version as Version0_3 (i.e. version 0.3)
2028 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2029 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2030 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2031 * *.dsp : modifications to use new libgdcmijpeg8 library
2032 * setup.py : bug fix on VTKPATH variable
2033 * PACKAGER : adding all concerning windows
2035 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2036 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2038 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2039 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2040 test suite reported error.
2041 * PACKAGER file added (describes what a packager must do when
2042 packaging a new release).
2043 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2044 * configure.in: upgraded version number to 0.3.0
2045 * fixing build of rpm (through rpm -ta):
2046 - Doc/Makefile.am exports proper doxygen files
2047 - src/jpeg/libijg8/Makefile.am exports the include files.
2049 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2050 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2051 * src/gdcmHeader.h : formatting code
2053 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2054 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2055 We were obtaining error message from vtk. Now, creation of file list
2056 is made in an internal list to prevent this problem.
2057 Bug fix when output is empty.
2058 Bug fix in update of progress value. Previous commit for this was a bad
2060 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2062 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2063 * src/gdcmHeader.h : added method to get the file name
2064 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2065 files. Added method to remove all files on the input
2066 Added FIXME comment concerning the bad parsing of header made by
2067 ExecuteInformation method (in ExecuteData method)
2069 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2070 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2071 when using make instal.
2072 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2073 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2075 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2076 * setup.py : adding include dir of jpeg lib to compile all sources
2077 * */Win32/*.dsp : JPR fix for windows compilation
2079 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2080 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2082 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2083 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2085 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2086 * setup.py is again effective on un*x (takes into account the
2087 addon of the jpeg library)
2088 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2089 * Doc/Doxy* updated (includes above enhancements)
2090 * INSTALL now points to web documentation
2092 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2093 * src/gdcmHeader.h doesn't make unnecessary reference to
2095 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2097 * src/gdcm*.[cxx|h] :
2098 - to allow compilation with gcc 3.x
2099 -- clean up of STL usage (added explicit usage of std::)
2100 -- small fixes on exceptions.
2101 Note: linking not tested !
2102 - clean of doxygen comments to avoid warnings at documentation
2104 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2105 dependent convertion).
2107 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2108 * Clean up of previous JPR garbage commit (not even commented in the
2110 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2111 - moved all jpeg related files from src to src/jpeg/libijg8, with
2112 addition/modification of Makefile.am and configure.in.
2113 - the testSuite is still brain damage (not guilty).
2115 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2116 * WrapVTK.py : modifications to get correctly vtk source files to
2118 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2119 (FileName -> Filename)
2121 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2122 * vtk/vtkGdcmReader.[cxx/h]:
2123 - UpdateProgress method should now be effective
2124 - removed the limitation on having only images loaded (as opposed
2126 - when building a stack of images/volume, a lesser number of
2127 gdcmHeader and gdcmFile instances should be used (hopefully
2128 accelerating things).
2129 - when building a stack of images/volumes, files which are not
2130 loadable (wrong path-filename, wrong permissions on existing file,
2131 or file not parsable by gdcm) are replaced with a black image
2132 in the stack (for the caller to notice the problem).
2134 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2135 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2137 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2138 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2139 between standard library (std) and vtk library (problems are found
2140 under Windows... thanks Windows !)
2142 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2143 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2145 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2147 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2148 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2150 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2151 * When compiling with distutils (see setup.py) the C++ compiler is
2152 called with different flags than the default ones (with automake).
2153 In order to fix all those warning, I compiled gdcm with the command
2154 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2155 and went for warning fixes:
2156 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2157 up from unused variables.
2158 - vtk/vtkGdcmReader.cxx: potential bug fix.
2159 * src/gdcmHeader.h: Doxygen warning cleanup
2161 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2162 * gdcmPython/gdcm.i:
2163 - typemaps correction to take into account the systematic replacement
2164 of "using namespace std" with std:: prefix e.g. std::list,
2165 std::string... (cf changes of 2003-05-21).
2166 - gdcmGlob global variable of type gdcmGlobal (defined in
2167 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2168 exported to Python a as cvar.
2169 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2170 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2171 gdcmDictSet.GetPubDictTagNames() and
2172 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2173 C++ static methods).
2174 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2175 with the above changes.
2177 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2178 * setup.py, manifest.in : bug fix under linux
2180 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2181 * Modification of setup.py to compile vtk part too. Then, we have 2
2182 wrappers which must work with same distutils. For that, we have a
2183 generic distutils in distusiltsWrapping.py ; with :
2184 - build_extWrap class to wrap generically all extensions,
2185 - ExtensionWrap base class for all wrapping extension that contains
2187 - Wrapper interface which wrap sources
2188 + In WrapSwig.py we have extension and wrapper for Swig
2189 + In WrapVTK.py we have extension and wrapper for VTK
2190 * MANIFEST.in : modifications to consider vtk directory and new python
2191 files for compilation
2193 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2194 * Added python wrappers of vtkGdcmReader vtk class (see the
2195 source in vtk/vtkGdcmReader.cxx) :
2196 - vtk/Makefile.am now builds a library
2197 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2198 python library (as opposed to _gdcm.so wich are the python
2199 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2200 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2202 - configure.in has an additional flag --enable-vtk that needs
2203 to be set to enable compilation of vtk related code, that is:
2204 + vtk/vtkGdcmReader.so and
2205 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2206 + gdcmPython/vtkgdcmPython.so (see above)
2207 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2208 be read when compressed or when HighBit + 1 != BitsStored),
2209 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2210 the usage of the python wrapper of vtkGdcmReader vtk class.
2211 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2212 * src/*.[h] all occurences of stl classes are now prefixed with
2213 std::, and all occurences of "using namespace std;" where removed.
2214 This is to avoid pollution of global namespace in included files.
2215 Apparently vtk does not avoid this pitfall: when using both
2216 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2217 collision of various stl members (principally cout...).
2218 * gdcmPython/testSuite.py now cleanly removes temprory generated
2220 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2221 comply with above changes)
2223 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2224 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2225 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2226 vtk data structure (an image Flip was required).
2227 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2228 * cosmetic changes in documentation.
2230 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2231 * src/gdcmHeader.cxx: the constructor no longer exits when an
2232 unexisting file is given as argument.
2233 * The subdirectory Data (containing all the images used for the
2234 test suite) is not part of this repository anymore. A new module
2235 containing those images is now available at
2236 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2237 with the name gdcmData.
2238 All the python scripts (including the package initialisation file
2239 gdcmPython/__init__.py) were adapated to take this change into
2240 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2242 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2243 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2244 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2245 demo of the usage of this class.
2246 Compilation of this vtk part is only done when using the --enable-vtk
2247 at configure (or autogen.sh) stage.
2249 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2250 * More memory link related corrections and documentation fixes.
2252 - maximum info is obtained with a command of the form:
2253 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2254 --show-reachable=yes PrintHeader
2255 - the remaining reachable blocks seem to come from the STL
2256 allocation scheme through the usage of map and list. It looks
2257 like this memory cannot be freed but it is not a memory leak
2258 (in fact further invocation to the STL would recollect the
2259 unused memory allthough it cannot explicitely be freed).
2260 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2261 of displaying an image parsed with gdcm and displayed with VTK.
2262 Note: some images don't seem to work e.g.
2263 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2264 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2265 Allthough this weakens the semantics, it is a ditch attempt to
2266 make gdcm more thread friendly.
2268 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2269 * Memory link hunt (by using valgrind through the command
2270 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2271 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2272 gdcmHeader::_dicom_vr.
2273 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2274 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2276 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2278 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2279 * src/Makefile.am now exports all the necessary include files at
2283 * UpdateGroupLength replaced by new one
2286 * UpdateGroupLength re-written using H-Table
2287 (named UpdateGroupLengthNew untill checks are over)
2289 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2290 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2291 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2293 - gdcmHeader::GetPubElValSet removed.
2294 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2295 UpdateGroupLength, WriteElements, Write.
2296 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2297 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2298 carried the same semantics.
2299 - src/gdcmHeaderIdo.cxx changed accordingly.
2300 - gdcmFile::WriteBase now regroups all the codes from previous
2301 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2302 - enum FileType moved to gdcmCommon.h
2303 * src/gdcmHeader.cxx AddDefault trashed
2304 * gdcmGetXSize added
2305 * getimageDataSize now calls gdcmGetXSize
2306 * Test/*.cxx changed to agree with above changes
2308 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2309 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2310 (to avoid double call by end user).
2311 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2312 by end user, since gdcmHeader::gdcmHeader now handles it.
2314 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2315 * gdcm/Doc many doxygen changes:
2316 - Doxyfile now has two different versions, DoxyfileUsers that generates
2317 the html.users end users oriented documentation and
2318 DoxyfileDeveloppers that generates the html.developper developper
2319 oriented documentation.
2320 - README changed accordingly
2321 - requirement.txt removed (old design info moved to TODO).
2322 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2323 DoxyMainPage.txt, DoxyPython.txt provide more information.
2324 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2325 be updated by simply regenerating the docs with doxygen and copying
2326 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2327 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2328 all the tests in the form "if (<map>.count() >1)" were removed.
2329 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2330 ill-formed documentation sections.
2331 * src/gdcmHeader.cxx: ditto
2333 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2334 * setup.py fixed for un*x (needed macro for stdint.h)
2335 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2336 un*ces with sh-utils test utility.
2337 * gdcmPython/demo/test.py renamed to PrintHeader.py
2338 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2339 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2340 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2341 * src/gdcm*.cxx JPR's bad inclusion fixed.
2343 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2344 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2345 * gdcmPython/demo/test.py changed accordingly.
2347 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2348 * gdcmPython/Makefile.am fixed linking against libstdc++
2349 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2350 * Swig subdir (historical tests of swig version 1.3.17++) removed
2351 * Test/testChangeEntete.cxx some lines commented out in order to make
2353 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2354 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2356 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2357 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2358 hence the user doesn't need this explicit call.
2359 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2360 i.e. LoadElements() call removed.
2361 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2362 - src/Makefile.am declares the proper flag for g++.
2363 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2364 for adding user defined new tags.
2365 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2366 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2367 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2369 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2370 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2371 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2372 src/Makefile.am : the project should properly compile and install
2373 with the autotools, included the python wrappers part.
2374 * gdcm.spec.in : added a spec file for RPM packaging.
2376 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2377 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2379 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2380 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2381 to exported to the environement (see gdcmPython/testSuite.py
2383 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2384 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2385 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2386 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2387 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2389 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2390 * gdcmPython/__init__.py doesn't crash anymore when running in
2391 in InstallMode or PreInstallMode but with an environement given
2392 value of GDCM_DICT_PATH.
2393 * src/gdcmDictSet.[cxx/h] coding style.
2395 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2396 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2397 * src/gdcm.h general comments moved to TODO, and README
2398 * src/gdcm.h should now be seen as a user commodity (including it
2399 should suffice to fully use gdcm). It is nowhere including within
2400 any of the kernel files src/*.cxx and src/*.h.
2402 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2403 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2404 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2406 * src/gdcm*.cxx only include their corresponding include file
2407 (as opposed to gdcm.h)
2408 * gdcmPython/gdcm.i changed accordingly
2409 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2410 the autogen.sh generated "make snapshot" command to work.
2411 * autogen.sh removed history related references to crea package.
2413 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2414 * distutilsSwigCPlusPlus.py work around some swig portability
2417 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2418 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2419 was done in a last ditch attempt to get setup.py _really_
2420 operationnal. The python/gdcmPython layaout add the advantage
2421 of hidding away the python related distutils specific files
2422 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2423 Alas, the src directory was out of scope (i.e. it's relative
2424 position to setup.py was ../src) which made things impossible to
2425 handle (see previous version of python/setup.py). Crossing fingers...
2427 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2428 * python/setup.py now works on Un*x. (harder than I thougth)
2429 * python/distutilsSwigCPlusPlus.py can now have include files
2430 among the list of sources.
2432 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2433 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2434 * modifications in MSVC projects
2436 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2437 * As stated by the first lines of Test/ExceptionAndPython/README, it
2438 looks like we can move back to original usage of exception within
2439 src/gdcm* and hence remove the errno stuff that was introduced
2440 as a quick and dirty fixture of this problem (added to the TODO).
2441 * Doc/Doxyfile configuration file for Doxygen and corresponding
2442 README file for usage added.
2443 * Test/testWrite.cxx added. This new test comes from a split of
2444 test.cxx that is now reverted to its original purpous i.e.
2445 testing the proper parsing of a Dicom related file.
2446 testWrite.cxx concentrates on testing the IO part of gdcm.
2447 * Test/bug1.cxx (containing a bug on WIn32) added.
2448 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2449 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2450 whose purpose is to publish the content of the TagNames of the
2451 Dicom public dictionnary were not accessible without an
2452 instance of class gdcmHeader.
2453 - those methods are now static methods of gdcmDictSet and hence
2454 require no instances at all to be invocated.
2455 - within gdcmDictSet this change required to change some method
2456 to class methods (i.e. are now static) among which SetDictPath
2457 (renamed to BuildDictPath) and LoadDefaultPubDict.
2458 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2459 the above changes by calling the new method classes of gdcmDictSet.
2460 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2461 the above to be effective.
2462 * python/gdcmPython: in order to wrap properly the above changes
2463 for Python, swig version now needs to be > 1.3.17.
2464 * python/gdcmPython/Makefile fixed to adapt itself to new
2465 configure/make shema introduced by Johan Montagnat (thanks for the
2466 contribution). Alas this Makefile cannot be turned into a proper
2467 Makefile.am without some heavy changes in the configure.in
2468 (for python dectection).
2469 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2470 now avoids publishing the empty entries.
2472 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2473 * python/setup.py : bug fix concerning install under windows
2474 ExtraPath reused :-P
2475 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2477 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2478 * Dicts/dicomV3.dic : remove double spaces !!!
2479 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2480 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2483 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2484 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2485 method. Doxygenation.
2486 * src/gdcm.h clean up of JPR spurious comments.
2488 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2489 * python/distutilsSwigCPlusPlus.py now properly collects the
2490 shadow classes generated by "swig -c++" (gdcm.py in our case)
2491 when using "python setup.py install".
2492 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2493 reexports the working classes.
2494 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2495 by the classical C errno scheme. This is to prevent an obscure
2496 behavior of the python wrappers when importing wxPython.wx prior
2497 to gdcmPython (which ended up in an abort call). An illustration
2498 of this oddity can be found in the Test/ExceptionAndPython
2499 subdir (see the README file). This problem probably due to
2500 an combination of g++ and dynamic loading.
2501 * added Test/ExceptionAndPython (see above)
2503 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2504 * Changed the layout of the python part to avoid bloating main
2505 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2506 i.e. the distutils arsenal. All the python related stuff is
2507 again in a python subdir, but the package itself is now in
2509 * setup.py was cleaned up:
2510 - pythonIncludePath removed
2511 - python setup.py bdist target is now functional.
2512 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2513 collision with other packages). gdcmPython/demo/*.py changed
2516 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2517 * python subdir moved to gdcmPython (preparation of distutils packaging).
2518 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2519 distutils installer is operational.
2520 * - gdcmPython/__init__.py now properly loads the swig generated
2521 shadow classes (from gdcm.py).
2522 - gdcmPython/demo/*.py changed to import the package gdcmPython
2523 instead of gdcmPython/demo/load.py.
2524 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2526 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2527 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2528 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2529 entries within the associated public Dicom dictionary resp. the same
2530 information but sorted by the fourth field (PAT, IMG, DIR) of the
2532 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2533 are now in the "???" group.
2534 - python/gdcm.i changed accordingly,
2535 - python/demo/printGroupedPublicDict.py added, that gives an example
2536 of the above new functionalities in Python.
2538 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2539 * src/gdcm.h, gdcmHeader.cxx:
2540 - historic references to glib's g_malloc and g_free (#defined)
2541 were definitively removed.
2542 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2543 * src/gdcmElValSet.cxx:
2544 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2545 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2546 - GetElValue(string) renamed to GetElValueByName.
2547 - Added GetElementByName(string).
2548 * src/gdcmHeader.cxx: added
2549 - GetPubElValRepByNumber(guint16, guint16)
2550 - GetPubElValRepByName(string)
2551 - GetShaElValRepByNumber(guint16, guint16)
2552 - GetShaElValRepByName(string)
2553 - GetShaElValByNumber(guint16, guint16)
2554 - GetShaElValRepByName(string)
2555 - GetElValRepByNumber(guint16, guint16)
2556 - GetElValRepByName(string)
2557 - GetElValByNumber(guint16, guint16)
2558 - GetElValRepByName(string)
2559 * Doc/requirements.txt added.
2561 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2562 * Test/Makefile building now depends on the one of libgdcm.so
2563 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2564 pixel data) aware which enables finding the address (offset) of
2565 the pixel data of JPEG encoded DICOM files. This leaves only a single
2566 file in the testSuite whose pixel data address (offset) is unknown.
2567 * python/testSuite.py changed accordingly.
2569 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2570 * VC++ has some strong limitations when working with the STL, as stated
2571 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2572 "Also note that some STL containers (map, set, queue, list, deque)
2573 cannot be exported. [...]
2574 Some STL classes contain nested classes. These classes can not
2576 This is caused by a designed limitation that once a template
2577 class is instantiated, it can not be re-instantiated and
2579 Since our usage of map<> is ubiquitous in gdcm, this "designed
2580 limitation" of VC++ is a pitfall.
2581 Hence the Python wrappers of gdcm cannot be incrementally linked
2582 against the c++ dynamic library. The dirty but only workaround is
2583 to forget about incremental link of dynamic libraries and to generate
2584 the Python wrappers library with the inclusions of the underlying C++
2586 The following modifications concern this matter on Win32/VC++:
2587 - wrapping python correct with standalone wrapped dll (don't use separate
2588 dll under windows !!!!)
2589 - python21_d debug mode enabled (ask Frog how to use it :-)
2590 - NO problem with having an STL member of class for example string in C++
2591 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2592 - Python test of dcmlib in Python is ok under windows on a large set
2594 * removed glib references
2595 * typedef's inserted in gdcm.i for correct swig type management
2597 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2598 * python/demo/*.py load.py extracted from test.py. Added explore.py
2599 that only displays required tags and testAll.py that parses all
2600 the files of the testsuite without using unittest.
2601 * python/testSuite.py other additional test on new files added.
2602 * Data/* new test files added accordingly to the testSuite.
2603 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2604 the vr in the file differs from the one of the dictionary.
2606 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2607 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2608 values, but limits itself to values which are below a user specified
2609 size (by default 1024 bytes).
2610 * python/gdcm.i : elements not loaded (because their size is above the
2611 user specified treshold) are exported with their TagKey as key of the
2612 python dictionary. This enables the testsuite to make some checks
2613 on the unloaded elements (since we have their offset and size).
2614 * python/testSuite.py
2615 - now tests for the existence and proper value of the pixel data
2616 - two new examples added.
2617 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2619 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2620 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2621 aware. See the strategy comments in gdcmHeader::FindeLength().
2622 * Test/test.cxx now accepts a filename as first argument.
2623 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2624 * python/testSuite.py changed to integrate test on above files.
2626 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2627 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2628 the vr was also RET.
2629 * python/testSuite.py more tests added.
2631 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2632 * python/testSuite.py unittest test suite added (uses Data)
2633 * Data/* dcm and acr files for the test suite.
2634 * glib dependance removed from un*x version. We now use ISO C99
2635 7.18 Integer types (see stdint.h)
2636 - python/Makefile, src/Makefile src/gdcm.h
2637 * src/ when an explicit vr (like dicom files) suddenly poped an
2638 implicit element we use to mark the underlying DictEntry of the
2639 concerned ElValue with "Implicit". This strategy was damageable
2640 too the public or provite dictionaries, since some of their vr
2641 would be changed. Since Header::FindLength heavily relies on the
2642 detection by Header::FindVR of falsely explicit elements, I
2643 added an extra ImplicitVr member to ElValue (boolean).
2644 The rest of the changes we the necessary adaptations.
2646 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2647 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2649 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2651 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2652 * Adaptation for porting to VC++:
2654 o forced to use std namespace (for string to be known)
2655 o all class use __declspec export style on WIN32
2656 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2657 (in stdlib.h on Win32 but in std:: for gcc)
2658 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2659 variable GDCM_DICT_PATH.
2660 * src/gdcmHeader.cxx verbose comments made discrete.
2662 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2663 * python/gdcm.i: added a typemap that converts a C++ hashing table
2664 to native Python dictionary.
2665 * python/demo/test.py:
2666 - now uses the native dictionary for exploration of gdcmHeader.
2667 - takes an optional filename argument (the file to parse).
2668 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2669 PubElVals hashing table.
2670 * Dicts/dicomV3.dic removed error prone trailing spaces.
2672 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2673 * Python wrapping process moved away from src/Makefile to
2674 newly created python/Makefile (as well as gdcm.i)
2675 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2676 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2677 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2678 from the environement variable GDCM_DICT_PATH (when existing).
2679 * src/gdcmDict::GetTag bug fix.
2681 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2682 * Straightforward temporary fixes for swig to build the python wrappers.
2683 src/Makefile now has a python working entry [by working we mean
2684 that we can import de shadow classes without errors].
2686 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2687 * hashtest.cxx removed (since allready in Test)
2688 * src/gdcmlib.h renamed to src/gdcm.h
2689 * src/dcm.i renamed to src/gdcm.i
2690 * src/Makefile prepared for python wrapping
2692 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2693 * src/gdcmHeader.cxx :
2694 - Parsing of header is now separated from loading of element values
2695 (see gdcmHeader::LoadElements).
2696 - general clean up of hopefully all file access (creation of
2697 ReadInt16 and ReadInt32)
2699 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2700 * src/gdcmHeader.cxx :
2701 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2703 - SetLgrElem renamed to SetLength
2704 - GetLgrElem renamed to GetLength
2705 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2706 * src/gdcmElValSet.cxx fixed both GetElValue methods
2707 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2708 due to IdoDude was cleaned out.
2710 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2711 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2712 concentrates on finding the value representation (when it exists).
2713 RecupLgr now only finds the element value length, and it avoids
2714 returning the unecessary skL (skipped length).
2715 Also, offsetCourant was simply removed (with taille_fich) since
2716 it was redundant with the File position internals (by using
2717 ftell and fseek). This also made skL (see above in RecupLgr) usage
2719 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2720 on the libido specificities which are handled through class
2722 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2725 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2726 * Truckload of changes. Parsing of header is barely functional
2727 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2729 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2730 * src/gdcmHeader.cxx many addons of low level methods
2732 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2733 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2734 and _IdDcmSWAP_LONG.
2736 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2737 * This corresponds to all the changes decided at the meeting of
2738 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob