1 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
5 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * Test/ : rename VTK tests to have a best name for the tests
7 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
8 GetFirstEntry/GetNextEntry use
10 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
12 test. Now it's on image content and not on the resulting visualisation...
13 might solve the problem on linux when using the OpenGL drivers
15 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
16 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
17 DicomDirSerie, DicomDirImage
18 Dict, DictSet classes :
19 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
20 -remove InitTraversal method.
21 * UPD Test programs + Example programs
23 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
24 remove useless and never updated keyword \ingroup
26 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
27 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
28 is no memory access violation
29 * gdcmPython/demo : add python demos using VTK
31 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
32 * FIX 'Dictionnary' is now spelt 'Dictionary'
33 'wether' is now spelt 'whether'
34 'archieve' is now spelt 'archive' ;-)
36 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
37 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
38 related methods, in order not to expose internal mechanisms
41 * REM methods that exposed internal mechanisms :
42 DicomDir::GetDicomDirPatients()
43 DicomDirPatient::GetDicomDirStudies()
44 DicomDirStudy::GetDicomDirSeries()
45 DicomDirSerie::GetDicomDirImages()
56 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
57 * Removed the Print/indent/default parameter mess. There is absolutely no
58 reason to have to methods, moreover with the second taking the ostream as
59 *SECOND* parameter. This was clearly a bad hack to get things compile.
61 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
62 * Complete rewrite of the GetMacAddress code. Now the code is *much*
63 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
64 Unfortunately the main code does not work on SunOS, thus provide a specific
65 code for this platform only (and Win32 of course). Since this seems to be
66 working, change CreateUniqueUID to use GetMACAddress instead of the
67 problematic GctestetIPAddress
69 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
70 * Unfortunately to be able to test gdcmDirList I had to break the API
71 a little. Now the class is not a std::list anymore but has a member
72 std::vector (more ITK compatible). Allow unit testing on Win32 and
75 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
76 * Update SerieHeader to take into account a Serie Instance UID to properly
79 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
80 * ENH - Comment out Mathieu's (dangerous) Super Hack
81 for dealing with BIGENDIAN processors
82 - Move equivalent stuff to BinEntry::WriteContent
83 When necessary, 16 Bits Pixels are swapped in a small buffer
84 and then written. This avoid allocating a huge buffer, in
85 PixelWriteConvertor, and avoid modifying the Pixel Area.
87 Probabely, the same operation will have to be done when we want
88 to write image with Big Endian Transfert Syntax,
89 and we are working on Little Endian Processor
91 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
94 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
95 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
97 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
99 * Test/TestDict.cxx : add a new test for the dict classes
101 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
102 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
103 file. Debug is yanked if compiled with NDEBUG
105 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * src/gdcmDictSet.h : set the default output to the os variable
107 * src/gdcmDictEntry.[h|cxx] : add the Print method
108 * gdcmPython/demo/ : add a new test
110 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
111 * merging of Test/PrintDicomDir and Test/TestDicomDir
112 * removal of now redundant Test/PrintDicomDir
113 * enhancement of Example/PrintDicomDir
115 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
116 * Now, python test might work on systems
117 * Add the PrintDicomDir test
119 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
120 * FIX : First entry following group 0002 was lost for
121 Explicit Big Endian Transfer Syntax files
122 (group and elem not swaped)
124 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
125 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
126 Big Endian Transfer Syntax supposed the group following 0002
127 begins always by element 0000 (element 0000 is *optional*)
128 To avoid further troubles, let's be pessimistic, and use
129 Document::HandleOutOfGroup0002() method
130 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
131 (related pb not yet solved)
133 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
134 * Bug fix for the python part use
135 * Now, PrintHeader.py pass... but outside the ctest use. shit !
137 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
138 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
140 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
141 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
142 a string and should ask the global TS dict what are the propreties of
145 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
146 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
147 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
148 to swap the Swap Code, at parsing time, when we come out of group 0002
149 and Transfer Syntax is Big Endian
150 We should be able to read now 'true DICOM" Big Endian coded images
151 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
152 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
154 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
155 * Hopefully fix the bug on MacOSX and static global initialization.
156 This is the only -minor- patch I found that both please MacOSX and VS6.
157 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
158 but this would require a lot of change. Another approach would be that Global
159 create those string and GDCM_UNFOUND becomes a pointer to a string (which
160 gdcm::Global would destroy at exit).
162 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
163 * Fix bug on MacOSX with static initialization in a multy threaded
164 environment. static const string in a header file used to be ill
165 initialized provoquing the freeze of any tests. patch should solve this
168 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
169 * According to Benoit's suggestion, and without any objection from anybody
170 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
171 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
172 - method gdcmDicomDirObject::GetEntry() renamed as
173 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
175 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
176 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
177 you debug/warning message just as c++ streams which make them very convinient
178 to use. Once this is stabilize I will change the ostringstrem to be
179 redirected to a file (ofstream).
180 * Properly support C99 extension: __FUNCTION__ which allow us to display
181 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
183 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
184 * Removal of useless and dangerous methods :
185 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
186 GetDocEntryByName, GetEntryByName, GetDictEntryByName
187 * Removal of usless methods :
188 Dict::PrintByName, Dict::GetDictEntryByName
189 * Commenting out of probabely useless methods :
190 Dict::GetDictEntryNames()
191 Dict::GetDictEntryNamesByCategory()
192 DictSet::GetPubDictEntryNames()
193 DictSet::GetPubDictEntryNamesByCategory()
194 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
195 * ENH : Use dicomTS.dic as described in 2004 version
196 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
197 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
198 Add Accessors on VM (Value Multiplicity), and VM related methods
199 * ADD : Add a list of 'Dicom Attribute types', as found in
200 http://medical.nema.org/dicom/2004/04_15PU.PDF
202 * ADD : Add dicomGroupNameAbbreviations.dic
203 should be used to write a method to replace the former
204 Dict::GetDictEntryNamesByCategory()
206 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
207 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
208 to read in the file... and only it ! Length is the efective length of the
209 data in the DocEntry structure
211 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
212 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
213 And now use a static function call instead, with a global variable. i
214 This is much closer to the VTK approach. Hopefully should be bulletproof
215 and easier to use...hopefully
217 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
218 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
220 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
221 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
223 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
224 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
225 ValEntry, BinEntry, SeqEntry creation or replace
227 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
228 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
229 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
231 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
232 when specifying the VR
233 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
234 * src/gdcmDocEntry.cxx : amelioration of print
236 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
237 * ADD : Add the method Util::IsCurrentProcessorBigEndian
238 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
239 * ADD Method Document::ComputeGroupLength
240 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
241 in order to allow further VR modification by user
242 * REM : removal of once-called method File::WriteBase
243 integration of its code in formerly one-line method File::Write
245 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
246 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
247 replace the different values "??", "Unkn", "Unknown".
248 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
249 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
250 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
251 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
253 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
254 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
256 * Set the gdcm::Base class to some Printable classes
258 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
259 * src/gdcmFile.[h|cxx] : add the Print method
260 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
261 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
262 * src/gdcmDocument.h : remove the PrintLevel informations
263 * Example/PrintFile.cxx : use the new gdcm::File::Print
265 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
266 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
267 problems when compiling with the python wrapping
269 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
270 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
271 writting in ImplicitVR
273 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
274 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
275 JPEG decompression, especially when dicom frames are split into several
276 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
277 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
279 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
280 * src/gdcmHeader.cxx : change the initialisation of default header.
281 Now, this header is readable by gdm, e-film, DicomWorks
283 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
284 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
285 Rename Decompressed to Raw
286 * Use the API changes in gdcm::File.
287 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
290 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
291 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
292 each added entry in the header. Replace the 'Planes' field by the 'Number
295 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
296 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
297 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
299 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
300 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
301 At this time, this image isn't readable by e-film... waiting JPR help to
304 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
305 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
306 DocEntry. Now use methods of the Document !
308 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
309 * Test/ShowDicomSeq.cxx : bug fix
311 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
312 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
313 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
314 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
315 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
317 * Test/TestCopyRescaleDicom.cxx : remove unused variable
318 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
319 containing found sequences
321 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
322 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
324 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
325 Some fields in BinEntry must be copied to not seg fault when making the :
326 gdcm::File *copy = new gdcm::File( copyH );
327 and tests are now made on good variables
329 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
330 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
331 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
333 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
334 * Add vtkGdcmWriter example and test
336 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
337 * Test/TestUtil.cxx : reformat the source code
338 * vtk/vtkGdcmReader.cxx : remove and change prints
339 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
341 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
342 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
344 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
345 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
346 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
348 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
349 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
350 by an eof to prevent all bad read of the file... and in this case, the
353 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
354 * Example/Volume2Dicom.cxx : comment unused variables
355 * Test/PrintDicomDir.cxx : comment unused variables
356 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
357 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
358 method that is redondant with AddEntry.
359 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
362 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
363 * Bug fix due my last commit (compilation under Windows).
364 * Example/Volume2Dicom : bug fix in the file and reformatting source code
365 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
367 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
369 - Remove printf / sprintf
370 - include iostream AFTER gdcm so we don't get warnings
371 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
373 - Also remove tons of include from header files, hopefully this should
374 speeup the compilation time, since it was becoming a dog slow.
375 - Remove gdcm.h as it include way too many files and slow down compilation
376 (plus it is not up to date)
377 - remove 'using namespace std' this is BAD !
379 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
380 * Remove memory leaks on the DicomDir
381 * Remove some useless data in DicomDirObject
382 * Add usefull methods in SQItem, to be complient withe the ElementSet
384 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
385 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
387 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
388 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
389 future, with convertion)
390 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
391 and ImageDataSize values. Remove the method to get the PixelReadConverter
392 from the output of the class
394 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
395 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
397 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
398 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
399 and vtkErrorMacro use.
400 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
402 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
403 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
405 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
406 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
407 The string leaves only in the fonction. So when we make a .c_str(), we
408 get the pointeur on the first element, element that will be destroyed
409 immediately after thee instruction.
410 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
411 file has been opened : the test must be made on the content of the
412 pointer and not directly on the pointer !
415 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
416 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
417 the python part recompiles
419 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
420 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
421 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
422 X session is killed (for my computer... it seems to not be identic on
425 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
426 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
427 avoid problems (otherwise, the difference test between the visible image
428 and the reference is incorrect. If the reference is greater than the
429 screen resolution, it's produce errors).
430 Can be used for only one image. Can be used with a visible flag.
431 * vtk/vtkGdcmReader.cxx : remove commented codes.
432 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
433 under windows at compilation
434 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
436 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
438 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
439 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
440 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
441 tests on the image size X, Y, Z
443 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
444 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
445 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
446 between the class name and the file name
448 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
449 * src/ : fix compilation warnings for the Write method (2 different
450 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
451 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
452 variable... create a static method in gdcm::Document to access to
453 this variable content.
455 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
456 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
457 file, to be accessed by other files (like gdcmFile). Remove commented
458 code. Move the change of the header to the gdcmFile, using the
460 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
461 To be sure of that (and simplify calls), the Write of the header now
462 gets a file name and not a file pointer (std::ifstream).
463 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
464 DocEntryArchive. Remove all open of the written file
466 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
467 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
469 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
470 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
471 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
473 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
474 some corresponding methods. Write correctly the file and check before
476 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
477 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
478 is now on RGB data (as before my last commit
479 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
481 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
482 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
483 Add a print information of the type of the entry
484 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
485 It was in the gdcmFile, and all write have been regrouped
486 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
487 Write correctly all dicom files (in decompressed mode only at this time)
488 * Test/ : test on files are now made using Raw data and not color data if
490 * Example/PrintFile.cxx : add more printings
492 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
493 * Amelioration of code, remove some code copy. For the loading of
494 BinEntry (in gdcmDocument), add the test to verify if the file is already
497 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
498 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
499 remove a DocEntry in the header (push an empty DocEntry)
500 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
501 lines. Bug fix in the initialization of the PixelConvert and the
503 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
504 use in TestCopyDicom (now this test can run under windows... but fails)
505 * Test/TestCopyDicom.cxx : amelioration of the test :
506 - test the pixels written
507 - add test points to quickly find where is the error
508 - can set a file name input and output in arguments
509 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
510 amelioration of the test output
512 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
513 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
514 all replaced DocEntry's
515 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
516 Now, each needed DocEntry to modify is duplicated, modified and inserted
517 to the header using DocEntryArchive. Thus, after save, we can restore the
518 header initial state.
520 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
521 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
523 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
524 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
525 correct to copy it. The DictEntry is specified at the DocEntry creation,
526 then, it musn't change in the time.
527 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
528 header correctly. At this time, the change is only made for the first
529 level of the Document. In the future, it might consider sequences.
530 The change is made by replacing a DocEntry by an other that is created
531 outside the class. The old value is kept. When we restore the header
532 status, the added DocEntry is deleted and replaced by the old value.
533 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
534 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
535 set the write type to explicit VR, implicit VR or ACR. Add methods to set
536 the write mode to native, decompressed or RGB (but not used at this time)
538 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
539 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
540 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
542 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
543 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
544 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
546 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
547 set because already copied when copying the BinEntry's of the header
548 * Test/TestAllReadCompareDicom.cxx : remove warnings
550 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
551 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
552 Two problems appear when doing it :
553 - with the gdcmFile : when the GetImageData method is called, the pixels
554 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
555 data (pixels). And each structure destruct the data when it's
556 destructed. So we have two destructions for the same data. To solve it,
557 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
558 data or not. If it doesn't own data, then they will not destroyed by
560 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
561 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
562 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
563 create a double destruction of the same DocEntry's. So, to solve it,
564 the TagHT is simply cleared and the DicomDir* elements are destroyed.
565 * TODO : add an entry concerning memory leaks in the DicomDir
567 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
568 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
569 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
572 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
573 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
574 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
575 after it have been deleted
577 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
578 * FIX: src/* fix the doxygen warnings.
579 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
580 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
581 was erroneously defined with a size of 15 instead of 16. [many thanks
582 to Jean Michel Rouet for pointing out this bug].
584 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
585 1. Finish merging JMR patch for writting DICOM from scratch
586 2. Fix -hopefully- bug with MONOCHROME and space vs null character
587 3. Use const ref when possible
588 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
589 5. A few more comments
590 6. CreateUniqueUID can now be called without parameter"
592 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
593 * ENH: Slightly bigger patch:
594 1. Getting toward full integration of JMR patch for writting dicom from scratch
595 2. Update Test to test part of this patch: CreateUniqueUID
596 3. File was not close properly in gdcmDict
597 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
598 5. Use of const ref instead of copy (speed issue)
599 6. Remove temporary (duplicate) string in TranslateToKey
600 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
601 8. Do not repeat virtual in subclasses
602 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
604 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
605 * Apply first patch toward better string comparison when dealing with broken
606 DICOM files. Essentially the string could be padded with a space instead
607 of a null character as defined by standard
609 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
610 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
611 because never used... and in the same time, that's remove some memory leaks
613 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
614 * src/gdcmFile.cxx : now delete the PixelConvert instance.
615 * In examples and tests : change the type of image data variables from void*
616 to uint8_t*. Remmove all delete on image data variables
618 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
619 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
620 Verify the file pointer value before open the file, and if it's not null,
621 a verbose message is generated.
622 Close correctly the file when the file isn't considered dicom-like. The
623 correctly close is a call to CloseFile.
624 When closing the file pointer, test if its not null to close the file.
625 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
626 file. For an uncompressed image, the copied data correspond in the least
627 case to the image size (calculated) or the image size specified in the
628 header. A verbose is generated if these two size mismatch
630 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
631 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
632 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
633 break under windows (with msvc6 compilation).
635 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
636 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
637 compiling with MSVC6)
639 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
640 * Bugs fix for the Windows build with VC6
641 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
642 needed (only for projects required VTK). If the VTK is included in all
643 projects, there is conflicts with the jpeg lib of vtk when compiling the
644 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
645 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
646 when compiling the gdcm_wrap.cxx file (created by the compilation of the
648 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
649 (like it's already made for the cout use). Otherwise, conflict with the
652 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
653 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
655 - comments on the DicomDir::Method related usage added.
656 - now that we use the namespace gdcm, a lot of internal classes do
657 NOT need to be wrapped anymore.
658 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
659 DicomDir::Method) new example added.
661 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
662 * Improve string manipulation. I now inforce the notion of 'DicomString'
663 A DicomString can contain as many \0 as they want
664 and it is *always* of even length.
665 We only support odd length for very rare case.
666 And in the near future this should be removed.
668 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
669 * /binary_write/ gdcm source. Now even on big endian we are writting
670 little endian. This should -heopfully- fix some tests
672 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
673 * Now the dictionary is compiled into gdcm lib. This is a default
674 behavior, thus any dic file specified is picked before failback to
675 the one comiled into lib
677 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
678 * Change internals for gdcmDict. Don't use any 'new' any more.
679 This should definitely solve any leak problem, and we should be
680 as fast as before, as long as don't modify too much the dictionary.
682 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
683 * STYLE: ivars should start with a capital letter.
684 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
685 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
687 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
688 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
689 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
690 new 2004 dictionaries added (thanks to JPR).
691 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
692 * CLEANUP_ROUND (15) for gdcmPixelConvert
693 - RLEFrame::NumberFragments is now of type unsigned int
694 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
695 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
698 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
699 * Initial work in gathering all transfer syntax accessors. clearly
700 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
701 ivars, but only one transfersyntax (class) ivar with equivalent method on
704 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
705 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
706 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
707 discussed (plus I didn't like having a 2000 lines patch not commited)
709 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
710 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
711 * CLEANUP_ROUND (14) for gdcmPixelConvert
712 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
713 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
714 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
716 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
717 anymore and hence avoids storing a copy of PixelConvert::Decompressed
718 into File::Pixel_Data.
720 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
721 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
722 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
723 * CLEANUP_ROUND (13) for gdcmPixelConvert
724 Substituted File::ParsePixelData() with PixelConvert::Print() new
726 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
727 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
728 method to those classes.
729 - src/gdcmFile.[cxx|h]:
730 -- Added a ::Print() method.
731 -- PixelConverter is now a reference instead of a member.
732 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
733 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
735 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
736 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
737 collaboration diagram and inheritance diagram should be generated with
739 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
740 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
741 pointlessly wrapped (see
742 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
743 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
744 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
745 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
746 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
747 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
748 -- File::Initialise: PixelConverter setup moved away to
749 PixelConverter::GrabInformationsFromHeader()
750 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
751 interpretation moved away to PixelConverter::BuildRGBImage()
753 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
754 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
755 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
757 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
758 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
759 displayed on Win32 when a brutal abort() occurs (because of uncatched
760 exception). See TODO new entry of this commit for more on this.
761 * TODO added new entry.
762 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
763 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
764 - HandleColor is no longer called from gdcmFile.cxx
765 - gdcmPixelConvert.cxx clean up on method arguments and internal
766 variable names for semantical coherence.
768 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
769 * Finished lossless transition, not only do we now read all lossless jpeg
770 images, without the need of the Cornwell lib, but we do read them properly now
771 * To reduce code (well to avoid code duplication), I defined a common place
772 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
773 redefine symbols. This is not perfect but this the best solution I found for a
774 compilation time jpeg option.
776 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
777 * Update jpeg ijg lib to support lossless jpeg implementation
778 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
780 * Also added a special copyright for dcmtk since we use their bugfixes.
783 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
784 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
785 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
786 matters, as stated in warning note at begining of %include section).
787 * src/gdcmDicomDir*.[cxx|h]: coding style
788 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
789 * src/gdcmJpeg8.cxx: doxygen fix.
790 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
791 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
792 from File:: to PixelConvert::.
794 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
795 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
796 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
797 - more code moved away from File:: to PixelConvert::
798 - fat setup of PixelConverter set in place in File::Initialise.
800 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
801 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
802 namespace at the file system level. So now you should convert your examples
804 gdcmHeader -> gdcm::Header
805 It would be nice if people keep in mind to no open the namespace, since it
806 allows compilation on broken plateform which were defining common symbol in
807 the standart namespace (like LP, Unknown ...)
809 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
810 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
811 The JPEG fragments are now parsed at the same stage than the RLE
812 information. All code related to JPEG is now in gdcmPixelConvert:
813 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
814 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
815 export a gdcmFile:: method. Those are simply global functions
816 (for the time being this is better than having them attach to
817 either gdcmFile:: or gdcmPixelConvert::).
818 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
819 and stores the result in a gdcmJPEGFragmentsInfo.
820 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
821 code (among other stuff) moved away from gdcmFile:; to
824 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
825 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
826 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
827 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
828 clean up of RLE related code.
829 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
830 - src/gdcmRLE.cxx removed
831 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
832 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
833 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
834 * CLEANUP_ROUND (9) for gdcmPixelConvert
835 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
836 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
837 away from gdcmFile:: to gdcmPixelConvert::.
839 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
840 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
841 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
842 This is because Parse7Fe0 used to parse the pixels to compute the
843 length. This task was passed over to FindDocEntryLengthOB() a long
844 time ago, EXCEPT I had forgotten the OW case...
845 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
846 we just recylce the code for parsing RLE fragments and computing
848 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
849 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
850 with the retired Parse7Fe0().
851 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
852 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
854 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
855 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
856 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
857 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
858 - src/CMakeLists.txt: alphabetic order reodering + new entries.
859 * CLEANUP_ROUND (4) for gdcmPixelConvert
860 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
861 to return an unused length.
863 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
864 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
865 this should be cleanner from the plane view. The iostream are erally a pain
866 to use to do simple stuff.
868 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
869 * Redo the compilation of the ijg jpeg library. Now only one source is
870 necesseray. No need to rename file by hand what so ever. CMake handle the
871 copying of the file within different directory, configure header file to
872 modify some symbol. The only addition made to ijg wasd a mangle table so
873 that symbol are different whether we are within 8bits or 12bits.
875 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
876 * Added documentation of vtkgdcmReader on Website:
877 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
878 with it's binary name).
879 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
880 the Website to be more complete.
881 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
882 doxygenated documentation.
883 - Doc/DoxyVtkGdcmReaderExamples.txt added
884 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
885 DoxyVtkGdmReaderExamples.html )
886 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
887 * CLEANUP_ROUND (3) for gdcmPixelConvert
888 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
890 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
891 * CLEANUP_ROUND (2) for gdcmPixelConvert
892 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
894 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
895 * CLEANUP_ROUND for gdcmPixelConvert:
896 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
897 - src/gdcmPixelStuff[h|cxx] removed
898 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
899 - src/CMakeLists.txt changed accordingly
901 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
902 gdcmVersion.py moved to newly created ATTIC related
903 gdcmPython/SetupOldies/ directory.
904 * Autotools clean up:
905 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
906 - autogen.sh configure.in acinclude.m4 python.m4 removed
908 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
909 * src/*.cxx *.h Reference to License.htm fixed to License.html.
910 * Doc/CMakeLists.txt, doxygen.config.in: fix.
911 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
913 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
914 * TODO updated with Mathieu suggestions. I proposed a template for
915 describing TODO entries and used it for new entries.
916 * Added Doc/Website/CodingStyle.html, Developpers.html,
917 DeveloppersPython.html, GdcmDataCvs.html and
918 DownloadVersion0_1.html, DownloadVersion0_3.html.
919 * Some Doc/*.txt Doxygen files (which do not really concern the
920 documentation itself, but the website) moved to html and
921 placed in directory Doc/Website:
922 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
923 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
924 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
925 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
926 * CMakeLists.txt changed accordingly.
927 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
928 DeveloppersPython.html
929 * INSTALL nows refers to Doc/Website/Installation.html
931 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
932 * Added Doc/Website directory, that contains a first raw version
935 2004-09-23 Jean-Pierre Roux
936 * FIX In order not to be poluted any longer by casting problems,
937 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
938 we can now delete[] it safely
939 * VoidArea is now called BinArea (less confusing name),
940 and all the methods called ...VoidArea... are now ... BinArea...
941 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
943 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
944 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
945 clear) TagHT, which is an inherited member of gdcmElementSet. It is
946 up to the destructor of gdcmElementSet to clean up TagHt and it's
949 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
950 * Test/CMakeLists.txt: update to follow gdcmData renamings.
951 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
953 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
954 * ENH: added some utility method that builds a flat dictionary
955 holding all the Dicom entries contained in the recursive structure
956 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
958 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
959 BuildFlatHashTable() that build a flat dictionary.
960 - src/gdcmElementSet.h: added a new private GetTag() accessor.
961 gdcmDocument is now a friend of gdcmElementSet.
962 - src/gdcmElementSet.cxx: clean up.
963 - Example/FlatHashTablePrint.cxx added.
964 - Example/CmakeLists.txt changed accordingly
966 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
967 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
968 moved away from gdcmDocEntrySet (since this class is an abstract class
969 acting like an interface). SQDepthLevel and BaseTagKey are now
971 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
972 and associated accessors. Doxygenation of the class.
973 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
975 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
976 Use SQDepthLevel accessor instead. ::Print() adapted.
977 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
978 - src/gdcmDocument.cxx changed accordingly.
980 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
981 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
982 - The following is the doxygen comment of the typedef declaration
983 of gdcmTagKey in src/gdcmCommon.h:
984 gdcmTagKey is made to old an "universal" (as in URL, Universal
985 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
986 A dicom tag always has a group and an element, but a set of tags
987 embeded in various (optionally nested) sequences and sharing
988 the same group and element all share the same (group, element)
989 "identifier". Hence the (group, element) cannot be used as an
990 identifier (in gdcm we shall refer to a "TagKey") of a tag.
991 In order to construct a proper tag identifier (i.e. a key) we
992 consider the following definition of a TagKey:
993 - let Group, Element be the string representation of the
994 group and element dicom tag members,
995 - let ItemNumber be the string representation of the integer
996 index of the considered item number of a sequence,
997 Let the key of a tag embeded in a sequence, noted SeqTag, be
999 /ItemNumber#Group|Element
1000 where "/", "#" and "|" are characters acting as separators.
1001 Then the general form of a gdcmTagKey is given by:
1002 Group|Element<SeqTag>
1003 where <SeqTag> means NO or many instances of SeqTag.
1004 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1007 but the gdcmTagKey of a tag "embeded" is the first item of
1008 a sequence, itself nested in the third item of a sequence is the
1010 0004|1220/2#0008|0082/0#0008|0090
1011 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1012 order to hold the new sequence compatible key. Previously, the
1013 GetKey() method would look in the underlying gdcmDictEntry.
1014 - src/gdcmDocEntry.cxx:
1015 -- constructor now copies the underlying DictEntry key, in the local
1017 -- ::Print: displays the member Key, instead of the (group, element).
1018 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1019 - src/gdcmDocEntrySet.h:xi
1020 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1021 -- now has a new BaseTagKey member.
1023 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1024 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1026 This poses the problem with the semantics of the following lines
1027 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1028 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1029 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1030 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1031 to the long FIXME note for what the problem is. Nevertheless in
1032 order to get things working the dicom dictionary was altered !
1033 Please fix things urgently...
1034 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1035 information), see above note on moving the member VoidArea. Nevertheless
1036 the following entries previously correctly set as US are now inproperly
1038 0028 1201 OW IMG Red Palette Color Lookup Table Data
1039 0028 1202 OW IMG Green Palette Color Lookup Table Data
1040 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1041 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1042 of gdcmDocEntry moved to gdcmSeqEntry.
1043 * src/gdcmSeqEntry.cxx: STYLE.
1045 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1046 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1048 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1049 * gdcmPython/testSuite.py: all the test suite in python is now moved
1050 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1051 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1052 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1054 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1055 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1056 to avoid inclusion recursion until STL is reached.
1057 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1058 mecanism. errno.h is not included in gdcm anymore.
1059 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1060 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1062 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1063 gdcmData/TestAllEntryVerifyReference.txt
1064 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1065 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1066 exception_on_error parameter.
1067 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1068 - vtk/vtkGdcmReader.cxx changed accordingly,
1069 - Example/*.cxx and Test/*.cxx changed accordingly.
1071 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1072 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1073 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1074 enable_sequences removed from gdcmHeader constructor and dependencies.
1075 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1076 * gdcmPython/demo/PrintHeader.py: dummy fix.
1077 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1078 skip_shadow removed from gdcmHeader constructor and dependencies.
1079 * Example/*.cxx and Test/*.cxx changed accordingly.
1081 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1082 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1083 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1085 2004-07-21 Jean-Pierre Roux
1086 * FIX Now, Parsing and Printing a DICOMDIR do work!
1087 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1089 2004-07-20 Jean-Pierre Roux
1090 * FIX Some brain damaged headers have Zero-Lenght fields
1091 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1093 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1094 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1095 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1096 variable (instance of gdcmDebug) by a definition macro, and the instance
1097 is now in static in the gdcmDebug class
1098 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1099 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1101 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1102 * WARNING: ctest now depends more tightly on gdcmData. You should
1103 check out gdcmData properly for things to run smoothly...
1104 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1105 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1106 we need the pixels not be loaded in order to use the ValEntry
1107 that displays position and size).
1108 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1109 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1110 be deprecated. If you have any doubts about the advantages of a
1111 modern scripting language (read Python) versus grass root C++ (i.e.
1112 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1113 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1114 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1115 Anyhow, consider documenting the gdcmData images in
1116 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1118 * Test/CMakeLists.txt:
1119 - now uses TestAllEntryVerify.cxx
1120 - specific comments on oldACR00001.ima (now renamed in gdcmData
1121 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1122 gdcmData/TestAllEntryVerifyReference.txt
1125 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1126 * src/*.[h|cxx] : typedef clean up
1127 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1128 - TagKey renamed to gdcmTagKey (for external usage)
1129 - VRKey renamed to gdcmVRKey (for external usage)
1130 - removal of typedef duplication.
1131 - Removed all unecessary inline keyword from class inline definitions.
1132 - Some method|function(void) declarations replaced with method|function().
1133 * src/jpeg/libijg12/jdhuff12.c:
1134 - printf polluting ctest removed.
1135 - TAB removal for comminting
1137 - TestAllReadCompareDicom.cxx: added a test that compares all the
1138 images in gdcmDataImages.h with corresponding images in
1139 gdcmData/BaselineDicom/. When baseline images are not present
1140 this test creates them.
1141 Note: we need to validate each reference image, but before that
1142 I'd like to rename them with a more explicit name...
1143 - CMakeLists.txt: changed accordingly.
1144 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1145 including each header needed).
1147 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1148 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1149 test suite to the Example directory. Are concerned:
1154 - TestWriteSimple.cxx
1155 * Test/CMakeLists.txt: added some comments on reasons for black listing
1156 image gdcmData/oldACR00001.ima
1158 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1159 * Test/CmakeList.txt: removed the following from black list (to be coherent
1160 with removal from gdcmData):
1161 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1162 - gdcm-MR-PHILIPS-16.dcm
1164 Added the following because after last cvs update, they cause
1165 ctest -R TestReadWriteReadCompare
1167 - gdcm-MR-SIEMENS-16-1.acr
1169 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1170 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1171 new comments in this file) we temporarily (sigh) move to a weaker
1173 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1174 we don't need to black list the following images anymore:
1175 - 8BitsUncompressedColor.dcm
1177 - US-PAL-8-10x-echo.dcm
1178 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1179 fixes and the beautified code ;-)
1180 This fixes the bug introduced in version 1.42 (when beautifying)
1181 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1182 Note: ctest was blind to this bug (this means we need to still
1183 improve the test suite). The bug could be detected by using
1184 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1186 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1187 and by displaying the (garbage) produced file temp.XDCM...
1189 2004-06-29 Jean-Pierre Roux
1190 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1191 - replace by uggly but working old code :-(
1192 A lot of things should be OK again.
1193 It's really urgent to have a test suite that *tests*,
1194 to prevent Frog's beautifying sessions to break all the stuff
1195 (twice, withing a fortnigh ...)
1197 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1198 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1199 redundancy) to added Test/TestReadWriteReadCompare.cxx
1200 * Test/CmakeList.txt: because the compare test of
1201 Test/TestReadWriteReadCompare.cxx fails, the following images are
1202 black listed: - 8BitsUncompressedColor.dcm
1204 - US-PAL-8-10x-echo.dcm
1205 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1206 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1207 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1208 and ad-hoc kludge. This kludge is now removed, and on encountering
1209 such an image (OB field brain damaged) we set errno. Then in
1210 ::FindDocLength() we "fix" the length as being ALL what remains
1211 in the file (until EOF). We then proceed, hoping for the best...
1212 This fixes a SegFault in ShowDicom when trying to write such an
1214 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1215 (because TestWriteRead breaks on it, after a non conformal commit?).
1216 ctest now runs properly, except for MakeDicomDir (which was always
1217 broken) and the Python related stuff (still not fixed).
1219 2004-06-24 Jean-Pierre Roux
1220 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1221 FIX : Test/TestReadWrite now iterates on all the file names
1222 (instead of infinite loop)
1223 ENH : Test/TestWriteRead now iterates on all the file names
1225 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1226 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1228 2004-06-24 Jean-Pierre Roux
1229 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1230 when SamplesPerPixel =3
1231 - now Write is no longer confused by
1232 'BitsAllocated = 12" and 'BitsStored=12"
1233 - "UN" value representation Elements are now written correctly
1234 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1235 ENH : - now gdcmHeader has its own Write methods
1236 (in order to split the job that has not to be done
1239 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1240 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1241 loop on the same image until memory went out.
1242 Note: this means we still have gobs of memory loss in PrintDocument
1243 * src/gdcmDocument.cxx: fixes problem on parsing on file
1244 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1246 2004-06-24 Jean-Pierre Roux
1247 FIX : Write - All the Sequences and Sequence Item are now written
1248 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1249 is added a the end, when necessary.
1250 - A lot of brain-damaged images, that were read correctly are
1251 now written correctly
1252 - length compatible BinEntry are now loaded correctly
1253 (even for odd groups)
1254 Note : only Explicit Value Representation was checked.
1255 (question : is implicit VR really necessary for gdcm ?)
1257 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1258 * DEVELOPPER: added a proposition of coding style.
1259 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1262 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1263 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1264 Use the gdcmDocEntry::Print() and Write() instead.
1265 * src/gdcmDocument.cxx: bug fix.
1267 2004-06-22 Jean-Pierre Roux
1268 FIX : gdcmDocument.cxx
1269 - Now we do recognize the JpegLossLess format (there was a misstyping in
1270 code 'beautyfication' :-(
1271 - Now we automaticaticaly load the Luts, if any
1273 2004-06-22 Jean-Pierre Roux
1274 In order : to write Sequences, whatever their imbrication level,
1275 : to allow user to create his own Sequences
1276 a lot of modif where necessary (adding, moving, or virtualising methods)
1278 WARNING : save your own sources *before* cvs up !
1281 ADD virtual void Write(FILE *fp, FileType filetype);
1284 ADD virtual void Write(FILE *fp, FileType filetype);
1285 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1288 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1289 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1290 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1291 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1292 ADD std::string GetEntryByName(TagName name);
1293 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1295 std::string vr = "unkn",
1296 std::string fourth = "unkn",
1297 std::string name = "unkn");
1298 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1299 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1300 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1301 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1302 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1303 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1304 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1305 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1308 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1309 ADD virtual std::string GetEntryByName (TagName tagName);
1310 ADD virtual std::string GetEntryVRByName (TagName tagName);
1311 REM virtual bool Write(FILE *, FileType);
1312 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1313 FILE *_fp, FileType type);
1314 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1315 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1316 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1317 REM virtual std::string GetEntryByName (std::string tagName);
1318 REM virtual std::string GetEntryVRByName (std::string tagName);
1319 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1320 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1321 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1323 std::string vr = "unkn",
1324 std::string fourth = "unkn",
1325 std::string name = "unkn");
1326 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1327 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1328 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1329 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1332 ADD virtual void Write(FILE *fp, FileType filetype);
1335 ADD virtual void Write(FILE *fp,FileType filetype);
1338 ADD virtual void Write(FILE *fp, FileType filetype);
1339 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1340 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1341 REM std::string GetEntryByName(TagName name);
1344 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1346 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1347 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1348 The default constructor invoked by the line
1349 gdcmHeader *f1 = new gdcmHeader( header );
1350 was gdcmHeader::gdcmHeader(bool) instead of the expected
1351 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1352 Hence the parsing wasn't executed... See also below.
1353 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1354 as explicit constructor didn't do the trick to fix the above problem.
1355 Could anyone explain why ?
1356 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1357 properly calls gdcmValEntry::Print() (that was weed out from
1358 code related to gdcmBinEntry).
1360 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1361 * In order to fix memory leaks:
1362 - Test/TestWriteSimple.cxx: added cleaning of free store through
1364 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1365 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1366 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1367 (through the call to ::AddDicomDirMeta()) or the destructor
1368 would crash when deleting uninitialized ::metaElems].
1369 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1370 - src/gdcmDocument.cxx:
1371 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1372 from dynamic stores.
1373 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1374 was causing memory leaks.
1375 - src/gdcmSQItem.cxx:
1376 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1377 cleanly handled with polymophism: sorry but my milage is low).
1378 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1379 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1380 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1381 This avoids SegFaulting.
1382 - src/gdcmSQItem.h: coding style.
1384 - Test/TestWriteSimple still severely sucks. The output image content
1385 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1386 damaged when displayed with vtkgdcmViewer.
1387 - on memory leaks: TestWriteSimple leaks really less (see entry
1388 of 2004-06-18 in Changelog file for the call to valgrind).
1389 - on segfaults: ctest now passes all the tests but one (no more
1391 * Erroneous leading white fix:
1392 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1393 white[s] (as opposed to from >> xxx, that removes it [them].
1394 - src/gdcmTS.cxx: ditto.
1395 - gdcmPython/testSuite.py: dirty related kludge removed.
1396 * src/*: remaining references to gdcmParser removed.
1397 * src/*[cxx|h]: added copy[way]left header.
1400 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1401 * In order to fix writing of dicom files:
1402 - Test/TestWriteSimple.cxx: a simpler example of writing.
1403 - Test/CMakeLists.txt changed accordingly.
1404 - src/gdcmDocument.cxx:
1405 -- The destructor now recursilvely removes potential sequences.
1406 -- Bug fix in ::IsJPEG2000()
1407 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1408 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1410 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1411 to only declared) and build on top of
1412 ::GetDocEntryByNumber(guint16, guint16).
1413 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1414 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1415 for usage in destructor and treatement of promotion in
1416 ::ReplaceOrCreateByNumber().
1417 - src/gdcmSQItem.cxx: destructor should better handle his job.
1418 Test/TestWriteSimple now runs (or at least it DOES something).
1419 * We can now start hutting memory links. A good starting point is:
1420 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1421 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1422 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1424 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1425 * Valgrind note: after Mathieu Malaterre teached me how to read
1426 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1428 Using gcc, you can force the STL to use malloc and to free memory as
1429 soon as possible by globally disabling memory caching.
1430 With 3.2.2 and later, you should export the environment variable
1431 GLIBCPP_FORCE_NEW before running your program.
1432 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1433 simply vanish (it is still not clear to me, whether this means that
1434 STL std::string leaks or if valgrind believes it leaks...).
1435 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1436 running bin/gdcmTests makeDicomDir):
1437 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1438 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1440 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1441 SegFaulting (I drowned in DicomDir related code when trying to
1442 understand why the list is empty...).
1443 * src/gdcmDocument.h: first BSD license header try.
1444 * Doc/License.txt added.
1446 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1447 * src/gdcmDocument.[h|cxx]:
1448 - Clean up of the Transfer related predicates. They are now all based
1449 on new method isGivenTransferSyntax, that (should) handle properly
1450 the padding problem.
1451 - general clean up, simplification, and coding style.
1452 - Specific clean up of Parse7FE0() (umproperly named actually).
1453 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1455 2004-06-14 Jean-Pierre Roux
1457 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1458 - fix the display of SQItem ordinal number
1459 - add the GetSQItemByOrdinalNumber method
1460 - remove some useless never written private methods
1462 2004-06-14 Jean-Pierre Roux
1464 - adding a constructor taking a gdcmDocEntry as an input param
1465 - ReplaceOrCreateByNumber now returns :
1466 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1467 a gdcmValEntry * if a string value is passed as a param
1469 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1470 according to the param type (no longer sets a gdcmDocEntry)
1471 - GetValEntryByNumber, GetBinEntryByNumber added
1472 - NewValEntryByNumber and NewBinEntryByNumber added
1474 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1476 - GetSQItemNumber and SetSQItemNumber added, to provide
1477 a (relative) Item identier inside a given Sequence
1478 \warning : some pb remaining around this number
1480 - AddEntry now takes the Item Number as a param
1482 - adding a constructor taking a gdcmDocEntry as an input param
1484 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1485 * Memory leak hunt with the following command:
1486 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1487 --show-reachable=yes gdcmTests PrintDocument
1488 It looks like many (all?) leaks are due to the STL (or a bad usage
1489 of the STL. The lines producing the leaks now have a comment with
1490 a "MEMORY LEAK" tag: you can retrieve them with
1491 grep "MEMORY LEAK" src/*
1492 Here are two typical examples which I can't help fixing:
1497 char * test = "babo";
1498 name = test; //// <--- valgrind detects 960 bytes lost in
1499 //// call to std::string::operator=(char const*)
1500 name.clear(); //// Doesn't help !
1508 std::cout << "Type a bunch of characters followed by RETURN: ";
1509 getline(std::cin, line); //// <--- valgrind dectects a loss
1510 //// of 1320 bytes in call to
1511 /// std::basic_istream<>& std::getline<>
1517 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1518 * src/gdcmHeader.[cxx|h]:
1519 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1520 and related, moved away to gdcmDocument.
1521 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1522 the corresponding protected accessors of inherited class
1523 gdcmDocument, removed ! As a consequence gdcmFile had to be
1524 declared friend of class gdcmDocument (see below).
1525 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1526 - Clean up of undefined or unused methods.
1527 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1528 account the changes to gdcmHeader.h).
1529 * src/gdcmDocument.h:
1530 - gdcmFile is now a friend class (in order to take into account the
1531 changes to gdcmHeader.h).
1532 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1533 (see changes to gdcmHeader.h).
1534 - Accessors (reading on the form GetEntry*) are now public.
1535 - Clean up of undefined or unused methods.
1536 * src/gdcmDocument.cxx:
1537 - adaptation to changes to gdcmDocument.h
1538 - ::OpenFile now writes a verbose message when file cannot be opened.
1539 - some std::string properly set to VRKey
1540 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1541 references to gdcmDocument.
1542 * Test/TestFindTags.cxx: changed accordingly to above changes.
1543 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1544 cvs repository gdcmData.
1546 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1547 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1548 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1549 conflicts with gdcmValEntry::voidArea.
1550 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1551 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1552 Value representation between StringRepresentable and BinaryRepresentable.
1553 * src/gdcmDocument.cxx:
1554 - method ParseDES: proper indentation restored and usage of
1555 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1556 - method LoadDocEntry: the fingerprint left in the SetValue() of
1557 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1558 removed. Reverting to previous code segment with the proper
1559 dynamic_cast< gdcmValEntry* >.
1560 Note: this was (partially) breaking the python test suite
1561 (gdcmPython/testSuite.py) that made usage of the above
1562 fingerprint to check presence of "Pixel Data".
1563 * src/gdcmDocEntry.h: coding style.
1564 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1565 now taken into account.
1566 * gdcmPython/gdcm.i: adaptation to the new internal representation
1567 of gdcm (exit gdcmParser, hello gdcmDocument).
1568 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1570 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1571 anymore, but instead prints the loaded Python dictionary.
1572 * .... alas, the python testSuite is still broken.
1574 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1575 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1577 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1578 * src/gdcmUtil.h : export methods
1580 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1581 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1583 * Initial addition of automatic python testing
1584 * Initial addition of automatic image comparison
1586 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1587 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1588 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1590 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1591 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1592 * Test/ShowDicom.cxx : bug fix for msvc compilation
1593 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1595 2004-05-04 Jean-Pierre Roux
1596 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1597 new concepts (and new classes) :
1598 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1599 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1600 - Sequence Doc Entries (gdcmSeqEntries)
1601 a Sequence is composed of Items.
1602 Each item is a set of Doc Entries (this is recursive)
1603 The non uniqueness of the 'Dicom tag' is due to this recursivity
1604 (never taken into account)
1605 Our unability to add a new 'entry' in the header
1606 at the proper location (neither in the H-Table (map or multimap),
1607 nor in the Chained List is also due to this recursivity.
1608 Don't try, right now, to use/modify/compile these new sources :
1609 nothing is finished.
1610 We just commit all the stuff, 'as is', in order not to loose it.
1612 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1613 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1615 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1616 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1617 file prefix (SetFilePrefix)
1619 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1620 * Add a new test: ShowDicom, for now this is just the c++ version of
1621 checkRead.sh, later it will be able to compare the image read against a
1623 * Replace the DEBUG on the stack with a global entry in cmake interface:
1624 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1626 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1627 * Add an example subdir, with a real example on how to read + write a
1630 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1631 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1632 * Doc/CMakeLists.txt: the main page is now properly differentiated
1633 between the developper and user version.
1634 * Doc/doxygen.config.in: dropped search related obsolete flags
1635 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1637 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1638 * DEVELOPPER: added some helpfull comments for compile/test/install
1641 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1642 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1643 src directory, now generated in the build dir.
1644 2. Tests as mentionned smarter
1646 4. Add a new method in gdcmDict that return the PubDict by name
1647 this is interesting for 3rd party lib like ITK,
1648 where we could set the institution name / patient name...
1650 * ENH: 1. Now the test suite is working for real
1651 2. All binaries are now output in the gdcm-bin directory
1652 (this was not true before)
1654 2004-04-28 Jean-Pierre Roux
1655 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1656 SeQuence indented printing of Dicom Header.
1657 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1658 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1659 Computation of SQDepthLevel is now part of gdcmHeader constructor
1660 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1661 tree-like structure of a Dicom Header.
1662 * FIX Test code cleaning
1664 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1665 * ENH: Adding automatic testing
1666 1. Need a DartConfig.cmake to submit to public
1667 2. Add a test driver gdcmTest.cxx
1668 3. gdcmTestMain, an helper for the main test driver gdcmTest
1669 4. Files in Test don't have a main anymore, this becomes interesting
1670 when we add more and more tests, thus dsw don't have to load
1672 * ENH: Adding a GDCM_DATA_ROOT for testing
1673 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1674 one file instead of seven + some small cleanup
1676 2004-04-22 Jean-Pierre Roux
1677 * ENH Minor changes to the Print() methods.
1678 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1679 Header printing. Example given with :
1680 > PrintHeader fileName 2 new
1681 (SQ based tree-like structure still to be done for the Header ...)
1683 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1684 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1685 1. I have added some unsigned where needed
1686 2. Some function parameter not used -> (void)
1687 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1688 4. g++ don't like character '\' in comment
1689 5. #define jpeg_create_decompress jCreaDecompress
1690 this really need to be fixed
1691 6. virtualize destructor of gdcmObject ... leakage
1692 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1693 this also really need to be fixed
1694 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1695 remove compression file
1696 (as we only do decompression, right ?)
1697 * ENH: Change malloc/calloc/free with c++ equivalent
1699 2004-04-21 Jean-Pierre Roux
1700 * FIX gdcmHeaderHelper::GetXSpacing
1701 when a single value is found (bug ?), xpacing is now
1702 defaulted to yspacing
1704 2004-04-19 Jean-Pierre Roux
1705 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1706 * ENH add parameters :
1707 bool exception_on_error = false,
1708 bool enable_sequences = false,
1709 bool ignore_shadow = false
1710 to the gdcmFile constructors to be full gdcmParser compliant
1711 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1712 to allow reading of PAPYRUS 3.0 files
1714 2004-04-06 Jean-Pierre Roux
1715 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1717 2004-04-02 Jean-Pierre Roux
1718 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1719 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1720 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1722 2004-03-30 Jean-Pierre Roux
1723 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1724 for ACR file, written out as DICOM files (hope so...)
1726 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1727 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1728 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1729 moved to base class gdcmParser and only the specialisation is kept
1731 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1732 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1733 already does the job.
1734 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1735 (to be consistent with gdcmParser::WriteEntries).
1737 2004-03-30 Benoit Regrain
1738 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1739 upate of the object's instance. It's passed to 2 in the unfavorable
1740 case : one in the ExecuteInformation, one in the ExecuteData
1742 2004-03-29 Jean-Pierre Roux
1743 * ENH : Check on file type to be written moved
1744 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1745 * FIX : gdcmObject::ResetBoundaries now stops properly
1746 when end-of-list is reached
1747 : gdcmVersion modified (as Benoit Regrain asked)
1749 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1750 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1751 * src/gdcmUtil.cxx: added forgotten iostream include.
1752 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1753 equivalent to ExplicitVR in existing code).
1755 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1756 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1757 now contains all the gdcmGlobal related code.
1758 * minor coding style and doxygenation changes.
1760 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1761 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1762 now contains all the Debug related code.
1763 * minor clean-up of includes in src/*.cxx
1764 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1765 CreateCleanString) removed.
1766 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1767 * Doc/DoxyMainPageUser.txt added.
1768 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1769 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1770 src/gdcmDirList.cxx)
1772 2004-03-24 Jean-Pierre Roux
1773 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1775 2004-03-23 Jean-Pierre Roux
1776 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1777 big endian made volumes
1778 * ENH Now gdcmParser constructor and destructor are protected to forbid
1779 end user to instanciate class gdcmParser
1780 (only gdcmHeader and gdcmDicomDir are meaningfull)
1782 2004-03-22 Benoit Regrain
1783 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1784 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1785 gdcmSerie to gdcmDicomDirSerie
1787 2004-03-19 Jean-Pierre Roux
1788 * ENH Now the tree-like structure describing a DICOMDIR comming from
1789 an already existing DICOMDIR file is consistent with
1790 the home-made tree-like structure build ex-nihilo
1791 or build from the files held (recursively) in a Directory
1792 functions gdcmDicomDir::CheckBoundaries()
1793 gdcmObject::SetBoundaries() added
1795 2004-03-17 Jean-Pierre Roux
1796 * REM (Eric Boix bug) : removal of meaningless
1797 gdcmDicomDirImage::NewImage function.
1798 * FIX now file names and directory name are written properly in the
1800 * FIX now gdcmDicomDir constructor may be call without any trick
1803 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1804 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1805 of gdcmDicomDirImage::NewImage as empty function.
1807 2004-02-28 Jean-Pierre Roux
1808 * ENH add gdcmDicomDir:NewPatient
1809 add gdcmDicomDirPatient:NewStudy
1810 add gdcmDicomDirStudy:NewSerie
1811 add gdcmDicomDirSerie:NewImage
1812 to allow making gdcDicomDir object.
1813 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1814 (as opposite to the gdcmHeader chained list)
1816 2004-02-11 Benoit Regrain
1817 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1818 when using from python
1820 2004-02-10 Benoit Regrain
1821 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1822 * FIX : in gdcmDicomDir when the directory is empty
1823 * ENH : add callback and methods to get the progression of dicomDir
1826 2004-02-06 Jean-Pierre Roux
1827 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1828 - GDCM_META added to gdcmDicomDirType
1829 - class gdcmMeta created
1830 * ENH : - A brief summary is now displayed at the beginning of
1831 'testDicomDir' to help disaster magnitude estimation
1832 * REM : Now useless Test/explDICOMDIR.cxx
1834 2004-02-05 Benoit Regrain
1835 * ENH : add methods in gdcmObject to get the hash table or the list of
1837 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1838 * FIX : wrapping python for TagHeaderEntryHT
1840 2004-02-04 Benoit Regrain
1841 * FIX : even length for some strings when writting the dicom dir
1842 * FIX : sort the images in the dicom dir
1843 * FIX : Bug fix for python use of dicom dir
1844 * ADD : a python demo
1846 2004-02-04 Jean-Pierre Roux
1847 * FIX : Final solution (?) for icone embedded images
1848 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1849 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1850 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1851 gdcmData/gdcm-MR-SIEMENS-16.acr1
1852 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1853 to make full checking easier
1855 2004-02-04 Benoit Regrain
1856 * FIX : WriteEntries : coding style & logic in parameters
1857 * FIX : Set the elements to create the DicomDir in a dictionary file
1859 2004-02-03 Benoit Regrain
1860 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1861 * gdcmDicomDir : add the load of directory
1862 * Bug fix and print add-on
1864 2004-02-03 Jean-Pierre Roux
1865 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1866 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1867 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1868 * FIX gdcmParser.cxx : 'group length' elements are now considered
1869 as integers, even for shadow groups, when file is Implicit VR
1871 2004-02-02 Jean-Pierre Roux
1872 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1874 of the last synonym :-(
1875 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1877 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1878 * FIX taking into account the possible 7fe0,0010 multiplicity
1879 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1880 to allow removal of references to 7fe0,0010, to deal with
1881 ACR-NEMA images, when 0028,0200 is meaningfull
1883 2004-01-31 Jean-Pierre Roux
1884 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1885 no longer writes 'Un' on disk
1886 * FIX SQ elements with actual length are now dealt with corectly
1887 * FIX gdcmFile::WriteBase make the difference, for color images, between
1888 the length (for Palette expanded images)
1889 and Raw Length (non expanded image + Palette)
1890 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1891 (that broke Write). Replaced by UL.
1892 Aware user will reload the field if he
1893 thinks it's necesssary
1895 2004-01-30 Jean-Pierre Roux
1896 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1897 when 'dirty Acr' is found, to be compliant with the new
1898 IsReadable() methods.
1900 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1901 (no DOUBLE images in kosher DICOM,
1902 but so usefull for people that miss them ;-)
1904 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1905 DICOMDIR related utilities (not checked as Windoze compliant)
1907 2004-01-28 Jean-Pierre Roux
1908 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1910 2004-01-27 Jean-Pierre Roux
1911 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1912 to allow skipping the shadow elements, to save memory space.
1913 The TRUE value for this param has to be used
1914 with a FALSE value for the 'enable_sequence' param.
1915 ('public elements' may be embedded in 'shadow Sequences')
1916 * gdcmHeader methods now deal with 'embedded icones images' in the header
1917 (even when an 'icone image sequence' is announced by the
1918 element (0x0088,0x0200), but there is NO icone at all ...
1920 * gdcmHeader sometimes Image Location value doesn't follow
1921 the supposed processor endianity (see gdcmData/cr172241.dcm).
1924 * gdcmHeader add the method
1925 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1926 to get *all* the Header Entries with the same tag.
1927 GetHeaderEntrySameName is probabely *useless*
1928 (no meaning : Name is *not* an identifier within the Dictionary)
1930 2004-01-26 Benoit Regrain
1931 * Bug fix in the print of hexadecimal representations. Remove long fields
1932 in the print and add a third level of print to print them
1934 2004-01-23 Benoit Regrain
1935 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1936 * Bug fix on test suite after remove the strip made on not string fields
1937 * Split the IsReadable method between gdcmParser which test that the file
1938 is dicom and gdcmHeader which test that it's an image file
1940 2004-01-22 Benoit Regrain
1941 * DicomDir : clean code, add methods, set variables in protected or private
1942 * gdcmUtil : bug fix for the clean string method
1944 2004-01-19 Benoit Regrain
1945 * Add the use of shadow dictionaries
1946 * bug fix and coding style
1948 2004-01-19 Benoit Regrain
1949 * src/gdcmFile.cxx : bug fix concerning the close of file
1950 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1951 * Add the update of header entries using the shadow library
1953 2004-01-19 Benoit Regrain
1954 * removal of file gdcmHeader2.cxx
1955 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1956 inheriting from gdcmParser. This split is to prepare the integration
1957 of dicom dir parsing
1958 * bug fix under python
1960 2004-01-16 Jean-Pierre Roux
1961 * REM removal of class gdcmHeaderEntrySet
1962 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1963 * ADD add file gdcmHeader2.cxx
1964 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1966 2004-01-15 Benoit Regrain
1967 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1968 entries created while parsing the header. Thus, they will be destroyed
1969 when the gdcmDictSet will be destroyed
1970 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1973 2004-01-15 Benoit Regrain
1974 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1975 made a fatal error because of the memory release at the end of program.
1976 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1977 some memory and vtk seems to have some problems with that.
1978 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1980 2004-01-14 Benoit Regrain
1981 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1982 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1983 * src/*.[h|cxx] : make changes due to class name changes
1984 * gdcmPython/demo/*.py : bug fix due to method names
1986 2004-01-13 Benoit Regrain
1987 * src/*.[h|cxx] : coding style
1988 * vtk/*.[h|cxx] : coding style
1990 2004-01-13 Benoit Regrain
1991 * gdcmPython/testSuite.py : test the readable flag of file for tests
1992 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1993 It's lied to the stl compilation by MSVC (windows, always windows...)
1994 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1996 2004-01-12 Benoit Regrain
1997 * src/*.h : add comments
1998 * src/gdcmDictSet.h : set the method BuildDictPath in public
1999 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2000 directly setted in the source code
2001 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2004 2004-01-09 Benoit Regrain
2005 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2006 * setup.py : use a reference to gdcmVERSION
2008 2004-01-07 Benoit Regrain
2009 * Modification to compile with the distutils.
2012 2003-12-10 Benoit Regrain
2013 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2014 can use a gdcmHeaderHelper to load data
2015 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2016 made in the source code
2018 2003-12-10 Benoit Regrain
2019 * Update Windows projects and .cvsignore files
2021 2003-11-12 Jean-Pierre Roux
2022 * ENH gdcmHeader constructor has one more parameter (default value : false)
2023 that allows the user to 'go inside' the SeQuences only
2025 gdcmElValSet:Print takes it into account
2027 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2028 * ENH: Update gdcmPython/CMakeLists
2029 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2030 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2032 2003-11-10 Jean-Pierre Roux
2033 * FIX : gdcmHeader::LoadElements is now based
2034 on the ListTag listElem member,
2035 not longer on the TagElValueHT tagHt member
2036 * ENH : PrintPubElVal shows (temporarily) both results,
2037 with the tagHt member and the listElem member.
2038 (it's easier to 'see' the problems when using Printheader)
2040 * FIX : old private member LgrElem is now splitted into
2041 ReadLength : Length actually found on disk (updated only
2042 if bug fixing is necessary), for internal
2044 UsableLength : Updated by FixFoundLength, to fix a bug
2045 or to allow Parser going on.
2046 Will allow to re-write a kosher header when a SeQuence
2047 with a length (not 0000) is found
2048 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2049 because gdcmElValSet::Add does not update ListElem
2052 2003-11-07 Jean-Pierre Roux
2053 * FIX misstyping in Transfert Syntax name table
2054 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2055 when they have an actual length (not 0000 nor FFFFF)
2056 (Nobody should care of it, but DICOMDIR explorers)
2058 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2059 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2061 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2062 * ENH: vtkGdcmReader now supports LUT !
2063 (vtkgdcmViewer for now is not able to use them though)
2065 2003-11-05 Jean-Pierre Roux
2066 * in testSuite.py : new files names for checking the package
2067 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2068 that returns the pixel area size to the *aware* (vtk) user
2069 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2071 2003-11-05 Benoit Regrain
2072 * in testSuite.py : Modify the rules for checking the paths
2073 : Explicit error messages
2074 * in __init__.py : Related modif
2076 2003-11-03 Jean-Pierre Roux
2077 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2078 to be used by aware (vtk) users that want to manage
2079 LUT (and no to turn the PALETTE image into an RGB pixels one)
2080 * GetPixelType now returns 8U for 24 Bits images
2081 (vtkGdcmReader compliant)
2083 2003-10-31 Jean-Pierre Roux
2084 * Removal of *all* gdcmData images and add them again
2085 in order to loose the 'history' of un-anonymised images
2087 2003-10-31 Jean-Pierre Roux
2088 * RMV : removal of useless jBitsInJsample.h
2089 for both 8 and 12 Bits JPEG Lossy Libraries
2091 2003-10-31 Jean-Pierre Roux
2092 * ENH : Add the functions gdcmFile::GetImageDataRaw
2093 gdcmFile::GetImageDataIntoVectorRaw
2094 that act as GetImageData and GetImageDataIntoVector
2095 except the making of an RGB Plane from Gray Plane + LUT
2096 Intended to aware (vtk) users who know how to manage
2099 GetLUTRGBA return a R,G,B,A LUT if any
2100 lgrTotaleRaw gives the 'Raw' length
2101 GetImageDataRaw returns the gray Plane
2102 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2103 (They stay Grey, just like with other Dicom viewers :-(
2105 2003-10-30 Jean-Pierre Roux
2106 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2108 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2109 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2110 being coherents dicom files.
2112 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2113 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2115 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2116 * ENH: Two steps is necessary to please VC++ compiler...
2117 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2118 * ENH: Add include dir to medcon lib
2119 * FIX: only one function is being exported for now !
2120 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2122 2003-10-29 Jean-Pierre Roux
2123 * adding gdcmHeader::GetLUTRGBA
2124 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2125 --> Mathieu, the modif u're waiting for is not yet committed
2126 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2128 2003-10-27 Jean-Pierre Roux
2129 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2130 00191113.dcm DermaColorLossLess.dcm
2131 MxTwinLossLess.dcm RadBWLossLess.dcm
2132 * ENH: For version prior to vtkImageViewer2 -r 1.19
2133 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2135 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2136 * Removal of ido stuff in CMakeLists.txt
2138 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2139 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2140 * FIX: remove a call to ->Modified ... see comments
2141 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2143 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2144 * FIX: Problem with path for libvtkgdcmPython
2145 * ENH: Try adding a search script for python site-package
2146 * RMV: Remove some file from medcon lib that are not necessary
2147 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2148 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2149 * FIX: More pragma disable fro VC++,
2150 I don't think I break something as it is also disable in VTK/ITK.
2151 But it fasten debug compilation time.
2153 2003-10-23 Jean-Pierre Roux
2154 * gdcm now deals with 16 Bits Run Length Encoded images
2155 (they are compressed as 2 planes images,
2156 one for the high Bytes, the other for low Bytes)
2158 2003-10-22 Jean-Pierre Roux
2159 * Now CheckRead takes into account :
2160 - the bugged 'Leonardo' Siemens images
2161 - the XA images, sent thru the burning VPRO station
2162 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2165 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2166 * FIX: When copying a Makefile.am to CMakeLists.txt
2167 one should remove the '\'
2169 2003-10-22 Jean-Pierre Roux
2170 * in gdcmData adding a bugged 'Leonardo' Siemens image
2171 (wrong lengths in header)
2172 OK with gdcm, KO with the other viewers :-)
2173 * add a GE dlx XA image, thru the VEPRO burning station
2176 2003-10-21 Jean-Pierre Roux
2177 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2178 for a brutal checking of vtkgdcmViewer compliance
2180 2003-10-21 Jean-Pierre Roux
2181 * add the files for 'xmedcon' Jpeg Lossless library
2182 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2184 2003-10-21 Jean-Pierre Roux
2185 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2187 2003-10-21 Jean-Pierre Roux
2188 * garbage Siemens 'Leonardo' images dealt with
2189 (the patch is easy to remove)
2190 * cosmetic changes to avoid warnings
2192 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2193 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2194 no need to press 'r' now.
2196 2003-10-20 Jean-Pierre Roux
2197 * upgrade of checkRead.sh checkWrite.sh according
2198 to new Jpeg Lossless decompressor
2199 * add US.3405.1.dcm, a genuine RGB medical file ...
2200 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2201 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2203 2003-10-15 Jean-Pierre Roux
2204 * general anonymisation in gdcmData
2205 * adding the 'color files' from
2206 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2207 * adding some well knowed bugged-header images
2208 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2209 waiting for their inclusion in Python testsuite
2211 2003-10-15 Jean-Pierre Roux
2212 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2213 no longer seg faults when file is not found
2215 2003-10-14 Jean-Pierre Roux
2216 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2219 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2220 * TODO: *.in file to genereate a UseGDCM later
2222 2003-10-14 Jean-Pierre Roux
2223 * Some supposed-to-be Dicom Images have no preamble.
2224 OpenFile takes it into account
2225 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2226 * Missing elements added in dicomV3.dic
2227 (just to be affraid : have a look at
2228 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2229 and do it again next year ;->
2231 2003-10-13 Jean-Pierre Roux
2232 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2233 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2234 But there are NOT. It's fixed !
2236 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2237 * FIX: "jpeglib.h" was not found on VC++
2238 * FIX: vtkgdcm was not being installed
2240 2003-10-10 Jean-Pierre Roux
2241 * ENH : OpenFile closes the file if it *really* doesn't look like
2242 an ACR-NEMA / DICOM one.
2243 * FIX : testWrite no longer writes an empty file if the source file
2244 is not gdcm Readable
2245 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2248 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2249 * FIX: CMake generate now documentation
2250 * ENH: out of source doc build !
2251 * ENH: Generate both user and dev documentation
2252 * ENH: Should work on windows too
2253 * ENH: Only one doxygen config.in file is needed
2254 * FIX: make install should be ok now on ùnix plateform
2255 * FIX: PATH to dictionary was wrong (missing /)
2256 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2258 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2259 * vtkGdcmReader is now able to read rgb dicom file.
2260 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2261 * added a gdcmViewer to vtk test, use mouse to control
2262 window level & window width
2264 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2265 * CMake-ification of gdcm, we have now two build system
2266 * FIX: on cygwin Wsock32 doesn't exist
2267 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2269 2003-10-06 Emanuel Ollart
2270 * FIX : compilation process wad broken.
2271 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2273 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2274 * change gdcmViewer -> vtkgdcmViewer
2275 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2277 2003-10-06 Jean-Pierre Roux
2278 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2279 ( e.g : well known GE images with a wrong elem length,
2280 : Philips MRI Images with a wrong Huffman table)
2281 * still to be done : allow the reading of bugged LEONARDO Siemens images
2283 2003-10-03 Jean-Pierre Roux
2284 * Odd length strings are padded with '\0' (not with spaces,
2285 to remain compliant with already defined strings,
2286 like Transfert Syntax UID and others)
2288 2003-10-03 Jean-Pierre Roux
2289 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2290 to allow displaying RGB images (not only by affim ;-)
2292 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2293 * vtkGdcmReader is now able to read rgb dicom file.
2294 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2296 2003-10-03 Jean-Pierre Roux
2297 * A few nasty patches to allow the reading of a lot of nasty images
2298 ( e.g : well known GE images with a wrong elem length,
2299 : Philips MRI Images with a wrong Huffman table)
2300 * still to be done : allow the reading of bugged LEONARDO Siemens images
2302 2003-10-03 Jean-Pierre Roux
2303 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2305 2003-10-03 Jean-Pierre Roux
2306 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2307 to allow displaying RGB images (not only by affim ;-)
2309 2003-10-03 Jean-Pierre Roux
2310 * gdcmFile::GetImageDataIntoVector now
2311 - deals with MultiFrames MultiFragments Run Length Encoded files
2312 - deals with YcBcR (YBR_FULL) files
2313 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2314 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2316 (no sample found :-(
2318 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2319 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2320 Two reasons: - clear things
2321 - third parties acces gdcm through header files, so won't
2322 suffer anymore VC++ complains
2324 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2325 * add argv[1] in testvtkGdcmReader.cxx
2328 2003-09-24 Jean-Pierre Roux
2329 * The lines are now eigthy characters long.for
2330 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2332 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2333 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2334 char* to std::string. Thus, the use of strdup becomes useless. (see
2335 previous commis of Malaterre)
2336 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2337 before the last Malaterre's commit.
2339 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2340 * This commit should fix the Debug building under VC++, the problem
2341 was mainly a mixture of debug and release lib being loaded at startup.
2342 * I also remove a depency to a specific C function: strdup. Because I had
2343 to force the link to msvcrtd (whereas strdup is in libc).
2345 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2346 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2347 located in the gdcmCommon.h file. All use of reference of tha has been
2348 changed to now use the variable GDCM_UNFOUND.
2350 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2352 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2353 Dicom dictionary. The test suite can now be run again. Note:
2354 I'm note very happy with the " (RET)" changes. I believe this
2355 RETAINED comment should be dropped when parsing the dictionary.
2356 - PACKAGER corrected
2358 - AUTHORS updated and now in alphabetical order
2359 * Makefile.am now exports gdcm.dsw for Windoze users.
2361 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2362 * cygwin complains about missing std:: in subdir Test/
2364 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2365 * remove some methods that are now in gdcmHeaderHelper
2367 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2368 * vtkGdcmReader set spacing and origin correctly
2370 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2371 * Fix a few delete/delete[] mismatch
2373 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2374 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2375 interpretation to data given by gdcmHeader. For instance there are
2376 heuristics to get informations (look at different places).
2377 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2378 sorting DICOM images based on different strategies.
2379 * modified Makefiles accordingly.
2381 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2382 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2383 when building in debug mode
2384 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2385 src/win32/gdcmdll.dsp
2386 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2388 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2389 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2392 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2393 * src/win32/libgdcmjpeg12.dsp was not dos format
2394 * src/win32/libgdcmjpeg12.dsp :
2395 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2396 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2398 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2399 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2401 * src/gdcmFile.cxx : bug fix in affectation type
2402 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2403 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2404 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2405 symbols... future problem ?
2407 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2408 * src/win32/libgdcmijpeg12.dsp was missing
2409 * modified gdcm.dsw accordingly
2411 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2412 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2414 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2415 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2416 commit of JPR (before his hollidays to facilitate our work).
2417 * setup.py : bug fix in code. Modifications made while the last commit
2418 of JPR. The code hasn't been tested before the commit... it's so
2419 useless to make that (for best programmer that is JPR) !!!
2421 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2422 * tagged the current version as Version0_3 (i.e. version 0.3)
2424 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2425 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2426 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2427 * *.dsp : modifications to use new libgdcmijpeg8 library
2428 * setup.py : bug fix on VTKPATH variable
2429 * PACKAGER : adding all concerning windows
2431 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2432 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2434 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2435 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2436 test suite reported error.
2437 * PACKAGER file added (describes what a packager must do when
2438 packaging a new release).
2439 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2440 * configure.in: upgraded version number to 0.3.0
2441 * fixing build of rpm (through rpm -ta):
2442 - Doc/Makefile.am exports proper doxygen files
2443 - src/jpeg/libijg8/Makefile.am exports the include files.
2445 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2446 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2447 * src/gdcmHeader.h : formatting code
2449 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2450 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2451 We were obtaining error message from vtk. Now, creation of file list
2452 is made in an internal list to prevent this problem.
2453 Bug fix when output is empty.
2454 Bug fix in update of progress value. Previous commit for this was a bad
2456 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2458 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2459 * src/gdcmHeader.h : added method to get the file name
2460 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2461 files. Added method to remove all files on the input
2462 Added FIXME comment concerning the bad parsing of header made by
2463 ExecuteInformation method (in ExecuteData method)
2465 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2466 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2467 when using make instal.
2468 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2469 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2471 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2472 * setup.py : adding include dir of jpeg lib to compile all sources
2473 * */Win32/*.dsp : JPR fix for windows compilation
2475 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2476 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2478 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2479 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2481 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2482 * setup.py is again effective on un*x (takes into account the
2483 addon of the jpeg library)
2484 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2485 * Doc/Doxy* updated (includes above enhancements)
2486 * INSTALL now points to web documentation
2488 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2489 * src/gdcmHeader.h doesn't make unnecessary reference to
2491 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2493 * src/gdcm*.[cxx|h] :
2494 - to allow compilation with gcc 3.x
2495 -- clean up of STL usage (added explicit usage of std::)
2496 -- small fixes on exceptions.
2497 Note: linking not tested !
2498 - clean of doxygen comments to avoid warnings at documentation
2500 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2501 dependent convertion).
2503 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2504 * Clean up of previous JPR garbage commit (not even commented in the
2506 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2507 - moved all jpeg related files from src to src/jpeg/libijg8, with
2508 addition/modification of Makefile.am and configure.in.
2509 - the testSuite is still brain damage (not guilty).
2511 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2512 * WrapVTK.py : modifications to get correctly vtk source files to
2514 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2515 (FileName -> Filename)
2517 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2518 * vtk/vtkGdcmReader.[cxx/h]:
2519 - UpdateProgress method should now be effective
2520 - removed the limitation on having only images loaded (as opposed
2522 - when building a stack of images/volume, a lesser number of
2523 gdcmHeader and gdcmFile instances should be used (hopefully
2524 accelerating things).
2525 - when building a stack of images/volumes, files which are not
2526 loadable (wrong path-filename, wrong permissions on existing file,
2527 or file not parsable by gdcm) are replaced with a black image
2528 in the stack (for the caller to notice the problem).
2530 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2531 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2533 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2534 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2535 between standard library (std) and vtk library (problems are found
2536 under Windows... thanks Windows !)
2538 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2539 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2541 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2543 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2544 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2546 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2547 * When compiling with distutils (see setup.py) the C++ compiler is
2548 called with different flags than the default ones (with automake).
2549 In order to fix all those warning, I compiled gdcm with the command
2550 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2551 and went for warning fixes:
2552 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2553 up from unused variables.
2554 - vtk/vtkGdcmReader.cxx: potential bug fix.
2555 * src/gdcmHeader.h: Doxygen warning cleanup
2557 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2558 * gdcmPython/gdcm.i:
2559 - typemaps correction to take into account the systematic replacement
2560 of "using namespace std" with std:: prefix e.g. std::list,
2561 std::string... (cf changes of 2003-05-21).
2562 - gdcmGlob global variable of type gdcmGlobal (defined in
2563 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2564 exported to Python a as cvar.
2565 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2566 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2567 gdcmDictSet.GetPubDictTagNames() and
2568 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2569 C++ static methods).
2570 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2571 with the above changes.
2573 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2574 * setup.py, manifest.in : bug fix under linux
2576 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2577 * Modification of setup.py to compile vtk part too. Then, we have 2
2578 wrappers which must work with same distutils. For that, we have a
2579 generic distutils in distusiltsWrapping.py ; with :
2580 - build_extWrap class to wrap generically all extensions,
2581 - ExtensionWrap base class for all wrapping extension that contains
2583 - Wrapper interface which wrap sources
2584 + In WrapSwig.py we have extension and wrapper for Swig
2585 + In WrapVTK.py we have extension and wrapper for VTK
2586 * MANIFEST.in : modifications to consider vtk directory and new python
2587 files for compilation
2589 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2590 * Added python wrappers of vtkGdcmReader vtk class (see the
2591 source in vtk/vtkGdcmReader.cxx) :
2592 - vtk/Makefile.am now builds a library
2593 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2594 python library (as opposed to _gdcm.so wich are the python
2595 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2596 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2598 - configure.in has an additional flag --enable-vtk that needs
2599 to be set to enable compilation of vtk related code, that is:
2600 + vtk/vtkGdcmReader.so and
2601 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2602 + gdcmPython/vtkgdcmPython.so (see above)
2603 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2604 be read when compressed or when HighBit + 1 != BitsStored),
2605 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2606 the usage of the python wrapper of vtkGdcmReader vtk class.
2607 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2608 * src/*.[h] all occurences of stl classes are now prefixed with
2609 std::, and all occurences of "using namespace std;" where removed.
2610 This is to avoid pollution of global namespace in included files.
2611 Apparently vtk does not avoid this pitfall: when using both
2612 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2613 collision of various stl members (principally cout...).
2614 * gdcmPython/testSuite.py now cleanly removes temprory generated
2616 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2617 comply with above changes)
2619 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2620 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2621 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2622 vtk data structure (an image Flip was required).
2623 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2624 * cosmetic changes in documentation.
2626 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2627 * src/gdcmHeader.cxx: the constructor no longer exits when an
2628 unexisting file is given as argument.
2629 * The subdirectory Data (containing all the images used for the
2630 test suite) is not part of this repository anymore. A new module
2631 containing those images is now available at
2632 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2633 with the name gdcmData.
2634 All the python scripts (including the package initialisation file
2635 gdcmPython/__init__.py) were adapated to take this change into
2636 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2638 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2639 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2640 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2641 demo of the usage of this class.
2642 Compilation of this vtk part is only done when using the --enable-vtk
2643 at configure (or autogen.sh) stage.
2645 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2646 * More memory link related corrections and documentation fixes.
2648 - maximum info is obtained with a command of the form:
2649 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2650 --show-reachable=yes PrintHeader
2651 - the remaining reachable blocks seem to come from the STL
2652 allocation scheme through the usage of map and list. It looks
2653 like this memory cannot be freed but it is not a memory leak
2654 (in fact further invocation to the STL would recollect the
2655 unused memory allthough it cannot explicitely be freed).
2656 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2657 of displaying an image parsed with gdcm and displayed with VTK.
2658 Note: some images don't seem to work e.g.
2659 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2660 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2661 Allthough this weakens the semantics, it is a ditch attempt to
2662 make gdcm more thread friendly.
2664 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2665 * Memory link hunt (by using valgrind through the command
2666 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2667 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2668 gdcmHeader::_dicom_vr.
2669 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2670 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2672 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2674 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2675 * src/Makefile.am now exports all the necessary include files at
2679 * UpdateGroupLength replaced by new one
2682 * UpdateGroupLength re-written using H-Table
2683 (named UpdateGroupLengthNew untill checks are over)
2685 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2686 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2687 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2689 - gdcmHeader::GetPubElValSet removed.
2690 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2691 UpdateGroupLength, WriteElements, Write.
2692 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2693 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2694 carried the same semantics.
2695 - src/gdcmHeaderIdo.cxx changed accordingly.
2696 - gdcmFile::WriteBase now regroups all the codes from previous
2697 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2698 - enum FileType moved to gdcmCommon.h
2699 * src/gdcmHeader.cxx AddDefault trashed
2700 * gdcmGetXSize added
2701 * getimageDataSize now calls gdcmGetXSize
2702 * Test/*.cxx changed to agree with above changes
2704 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2705 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2706 (to avoid double call by end user).
2707 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2708 by end user, since gdcmHeader::gdcmHeader now handles it.
2710 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2711 * gdcm/Doc many doxygen changes:
2712 - Doxyfile now has two different versions, DoxyfileUsers that generates
2713 the html.users end users oriented documentation and
2714 DoxyfileDeveloppers that generates the html.developper developper
2715 oriented documentation.
2716 - README changed accordingly
2717 - requirement.txt removed (old design info moved to TODO).
2718 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2719 DoxyMainPage.txt, DoxyPython.txt provide more information.
2720 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2721 be updated by simply regenerating the docs with doxygen and copying
2722 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2723 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2724 all the tests in the form "if (<map>.count() >1)" were removed.
2725 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2726 ill-formed documentation sections.
2727 * src/gdcmHeader.cxx: ditto
2729 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2730 * setup.py fixed for un*x (needed macro for stdint.h)
2731 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2732 un*ces with sh-utils test utility.
2733 * gdcmPython/demo/test.py renamed to PrintHeader.py
2734 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2735 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2736 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2737 * src/gdcm*.cxx JPR's bad inclusion fixed.
2739 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2740 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2741 * gdcmPython/demo/test.py changed accordingly.
2743 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2744 * gdcmPython/Makefile.am fixed linking against libstdc++
2745 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2746 * Swig subdir (historical tests of swig version 1.3.17++) removed
2747 * Test/testChangeEntete.cxx some lines commented out in order to make
2749 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2750 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2752 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2753 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2754 hence the user doesn't need this explicit call.
2755 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2756 i.e. LoadElements() call removed.
2757 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2758 - src/Makefile.am declares the proper flag for g++.
2759 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2760 for adding user defined new tags.
2761 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2762 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2763 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2765 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2766 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2767 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2768 src/Makefile.am : the project should properly compile and install
2769 with the autotools, included the python wrappers part.
2770 * gdcm.spec.in : added a spec file for RPM packaging.
2772 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2773 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2775 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2776 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2777 to exported to the environement (see gdcmPython/testSuite.py
2779 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2780 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2781 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2782 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2783 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2785 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2786 * gdcmPython/__init__.py doesn't crash anymore when running in
2787 in InstallMode or PreInstallMode but with an environment given
2788 value of GDCM_DICT_PATH.
2789 * src/gdcmDictSet.[cxx/h] coding style.
2791 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2792 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2793 * src/gdcm.h general comments moved to TODO, and README
2794 * src/gdcm.h should now be seen as a user commodity (including it
2795 should suffice to fully use gdcm). It is nowhere including within
2796 any of the kernel files src/*.cxx and src/*.h.
2798 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2799 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2800 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2802 * src/gdcm*.cxx only include their corresponding include file
2803 (as opposed to gdcm.h)
2804 * gdcmPython/gdcm.i changed accordingly
2805 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2806 the autogen.sh generated "make snapshot" command to work.
2807 * autogen.sh removed history related references to crea package.
2809 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2810 * distutilsSwigCPlusPlus.py work around some swig portability
2813 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2814 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2815 was done in a last ditch attempt to get setup.py _really_
2816 operationnal. The python/gdcmPython layaout add the advantage
2817 of hidding away the python related distutils specific files
2818 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2819 Alas, the src directory was out of scope (i.e. it's relative
2820 position to setup.py was ../src) which made things impossible to
2821 handle (see previous version of python/setup.py). Crossing fingers...
2823 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2824 * python/setup.py now works on Un*x. (harder than I thougth)
2825 * python/distutilsSwigCPlusPlus.py can now have include files
2826 among the list of sources.
2828 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2829 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2830 * modifications in MSVC projects
2832 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2833 * As stated by the first lines of Test/ExceptionAndPython/README, it
2834 looks like we can move back to original usage of exception within
2835 src/gdcm* and hence remove the errno stuff that was introduced
2836 as a quick and dirty fixture of this problem (added to the TODO).
2837 * Doc/Doxyfile configuration file for Doxygen and corresponding
2838 README file for usage added.
2839 * Test/testWrite.cxx added. This new test comes from a split of
2840 test.cxx that is now reverted to its original purpous i.e.
2841 testing the proper parsing of a Dicom related file.
2842 testWrite.cxx concentrates on testing the IO part of gdcm.
2843 * Test/bug1.cxx (containing a bug on WIn32) added.
2844 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2845 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2846 whose purpose is to publish the content of the TagNames of the
2847 Dicom public dictionary were not accessible without an
2848 instance of class gdcmHeader.
2849 - those methods are now static methods of gdcmDictSet and hence
2850 require no instances at all to be invocated.
2851 - within gdcmDictSet this change required to change some method
2852 to class methods (i.e. are now static) among which SetDictPath
2853 (renamed to BuildDictPath) and LoadDefaultPubDict.
2854 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2855 the above changes by calling the new method classes of gdcmDictSet.
2856 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2857 the above to be effective.
2858 * python/gdcmPython: in order to wrap properly the above changes
2859 for Python, swig version now needs to be > 1.3.17.
2860 * python/gdcmPython/Makefile fixed to adapt itself to new
2861 configure/make shema introduced by Johan Montagnat (thanks for the
2862 contribution). Alas this Makefile cannot be turned into a proper
2863 Makefile.am without some heavy changes in the configure.in
2864 (for python dectection).
2865 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2866 now avoids publishing the empty entries.
2868 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2869 * python/setup.py : bug fix concerning install under windows
2870 ExtraPath reused :-P
2871 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2873 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2874 * Dicts/dicomV3.dic : remove double spaces !!!
2875 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2876 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2879 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2880 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2881 method. Doxygenation.
2882 * src/gdcm.h clean up of JPR spurious comments.
2884 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2885 * python/distutilsSwigCPlusPlus.py now properly collects the
2886 shadow classes generated by "swig -c++" (gdcm.py in our case)
2887 when using "python setup.py install".
2888 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2889 reexports the working classes.
2890 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2891 by the classical C errno scheme. This is to prevent an obscure
2892 behavior of the python wrappers when importing wxPython.wx prior
2893 to gdcmPython (which ended up in an abort call). An illustration
2894 of this oddity can be found in the Test/ExceptionAndPython
2895 subdir (see the README file). This problem probably due to
2896 an combination of g++ and dynamic loading.
2897 * added Test/ExceptionAndPython (see above)
2899 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2900 * Changed the layout of the python part to avoid bloating main
2901 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2902 i.e. the distutils arsenal. All the python related stuff is
2903 again in a python subdir, but the package itself is now in
2905 * setup.py was cleaned up:
2906 - pythonIncludePath removed
2907 - python setup.py bdist target is now functional.
2908 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2909 collision with other packages). gdcmPython/demo/*.py changed
2912 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2913 * python subdir moved to gdcmPython (preparation of distutils packaging).
2914 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2915 distutils installer is operational.
2916 * - gdcmPython/__init__.py now properly loads the swig generated
2917 shadow classes (from gdcm.py).
2918 - gdcmPython/demo/*.py changed to import the package gdcmPython
2919 instead of gdcmPython/demo/load.py.
2920 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2922 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2923 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2924 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2925 entries within the associated public Dicom dictionary resp. the same
2926 information but sorted by the fourth field (PAT, IMG, DIR) of the
2928 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2929 are now in the "???" group.
2930 - python/gdcm.i changed accordingly,
2931 - python/demo/printGroupedPublicDict.py added, that gives an example
2932 of the above new functionalities in Python.
2934 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2935 * src/gdcm.h, gdcmHeader.cxx:
2936 - historic references to glib's g_malloc and g_free (#defined)
2937 were definitively removed.
2938 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2939 * src/gdcmElValSet.cxx:
2940 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2941 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2942 - GetElValue(string) renamed to GetElValueByName.
2943 - Added GetElementByName(string).
2944 * src/gdcmHeader.cxx: added
2945 - GetPubElValRepByNumber(guint16, guint16)
2946 - GetPubElValRepByName(string)
2947 - GetShaElValRepByNumber(guint16, guint16)
2948 - GetShaElValRepByName(string)
2949 - GetShaElValByNumber(guint16, guint16)
2950 - GetShaElValRepByName(string)
2951 - GetElValRepByNumber(guint16, guint16)
2952 - GetElValRepByName(string)
2953 - GetElValByNumber(guint16, guint16)
2954 - GetElValRepByName(string)
2955 * Doc/requirements.txt added.
2957 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2958 * Test/Makefile building now depends on the one of libgdcm.so
2959 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2960 pixel data) aware which enables finding the address (offset) of
2961 the pixel data of JPEG encoded DICOM files. This leaves only a single
2962 file in the testSuite whose pixel data address (offset) is unknown.
2963 * python/testSuite.py changed accordingly.
2965 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2966 * VC++ has some strong limitations when working with the STL, as stated
2967 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2968 "Also note that some STL containers (map, set, queue, list, deque)
2969 cannot be exported. [...]
2970 Some STL classes contain nested classes. These classes can not
2972 This is caused by a designed limitation that once a template
2973 class is instantiated, it can not be re-instantiated and
2975 Since our usage of map<> is ubiquitous in gdcm, this "designed
2976 limitation" of VC++ is a pitfall.
2977 Hence the Python wrappers of gdcm cannot be incrementally linked
2978 against the c++ dynamic library. The dirty but only workaround is
2979 to forget about incremental link of dynamic libraries and to generate
2980 the Python wrappers library with the inclusions of the underlying C++
2982 The following modifications concern this matter on Win32/VC++:
2983 - wrapping python correct with standalone wrapped dll (don't use separate
2984 dll under windows !!!!)
2985 - python21_d debug mode enabled (ask Frog how to use it :-)
2986 - NO problem with having an STL member of class for example string in C++
2987 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2988 - Python test of dcmlib in Python is ok under windows on a large set
2990 * removed glib references
2991 * typedef's inserted in gdcm.i for correct swig type management
2993 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2994 * python/demo/*.py load.py extracted from test.py. Added explore.py
2995 that only displays required tags and testAll.py that parses all
2996 the files of the testsuite without using unittest.
2997 * python/testSuite.py other additional test on new files added.
2998 * Data/* new test files added accordingly to the testSuite.
2999 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3000 the vr in the file differs from the one of the dictionary.
3002 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3003 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3004 values, but limits itself to values which are below a user specified
3005 size (by default 1024 bytes).
3006 * python/gdcm.i : elements not loaded (because their size is above the
3007 user specified treshold) are exported with their TagKey as key of the
3008 python dictionary. This enables the testsuite to make some checks
3009 on the unloaded elements (since we have their offset and size).
3010 * python/testSuite.py
3011 - now tests for the existence and proper value of the pixel data
3012 - two new examples added.
3013 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3015 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3016 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3017 aware. See the strategy comments in gdcmHeader::FindeLength().
3018 * Test/test.cxx now accepts a filename as first argument.
3019 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3020 * python/testSuite.py changed to integrate test on above files.
3022 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3023 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3024 the vr was also RET.
3025 * python/testSuite.py more tests added.
3027 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3028 * python/testSuite.py unittest test suite added (uses Data)
3029 * Data/* dcm and acr files for the test suite.
3030 * glib dependance removed from un*x version. We now use ISO C99
3031 7.18 Integer types (see stdint.h)
3032 - python/Makefile, src/Makefile src/gdcm.h
3033 * src/ when an explicit vr (like dicom files) suddenly poped an
3034 implicit element we use to mark the underlying DictEntry of the
3035 concerned ElValue with "Implicit". This strategy was damageable
3036 too the public or provite dictionaries, since some of their vr
3037 would be changed. Since Header::FindLength heavily relies on the
3038 detection by Header::FindVR of falsely explicit elements, I
3039 added an extra ImplicitVr member to ElValue (boolean).
3040 The rest of the changes we the necessary adaptations.
3042 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3043 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3045 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3047 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3048 * Adaptation for porting to VC++:
3050 o forced to use std namespace (for string to be known)
3051 o all class use __declspec export style on WIN32
3052 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3053 (in stdlib.h on Win32 but in std:: for gcc)
3054 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3055 variable GDCM_DICT_PATH.
3056 * src/gdcmHeader.cxx verbose comments made discrete.
3058 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3059 * python/gdcm.i: added a typemap that converts a C++ hashing table
3060 to native Python dictionary.
3061 * python/demo/test.py:
3062 - now uses the native dictionary for exploration of gdcmHeader.
3063 - takes an optional filename argument (the file to parse).
3064 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3065 PubElVals hashing table.
3066 * Dicts/dicomV3.dic removed error prone trailing spaces.
3068 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3069 * Python wrapping process moved away from src/Makefile to
3070 newly created python/Makefile (as well as gdcm.i)
3071 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3072 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3073 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3074 from the environement variable GDCM_DICT_PATH (when existing).
3075 * src/gdcmDict::GetTag bug fix.
3077 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3078 * Straightforward temporary fixes for swig to build the python wrappers.
3079 src/Makefile now has a python working entry [by working we mean
3080 that we can import de shadow classes without errors].
3082 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3083 * hashtest.cxx removed (since already in Test)
3084 * src/gdcmlib.h renamed to src/gdcm.h
3085 * src/dcm.i renamed to src/gdcm.i
3086 * src/Makefile prepared for python wrapping
3088 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3089 * src/gdcmHeader.cxx :
3090 - Parsing of header is now separated from loading of element values
3091 (see gdcmHeader::LoadElements).
3092 - general clean up of hopefully all file access (creation of
3093 ReadInt16 and ReadInt32)
3095 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3096 * src/gdcmHeader.cxx :
3097 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3099 - SetLgrElem renamed to SetLength
3100 - GetLgrElem renamed to GetLength
3101 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3102 * src/gdcmElValSet.cxx fixed both GetElValue methods
3103 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3104 due to IdoDude was cleaned out.
3106 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3107 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3108 concentrates on finding the value representation (when it exists).
3109 RecupLgr now only finds the element value length, and it avoids
3110 returning the unecessary skL (skipped length).
3111 Also, offsetCourant was simply removed (with taille_fich) since
3112 it was redundant with the File position internals (by using
3113 ftell and fseek). This also made skL (see above in RecupLgr) usage
3115 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3116 on the libido specificities which are handled through class
3118 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3121 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3122 * Truckload of changes. Parsing of header is barely functional
3123 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3125 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3126 * src/gdcmHeader.cxx many addons of low level methods
3128 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3129 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3130 and _IdDcmSWAP_LONG.
3132 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3133 * This corresponds to all the changes decided at the meeting of
3134 May 23 2002. Needless to say we are running late...