1 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * As stated by the first lines of Test/ExceptionAndPython/README, it
3 looks like we can move back to original usage of exception within
4 src/gdcm* and hence remove the errno stuff that was introduced
5 as a quick and dirty fixture of this problem (added to the TODO).
6 * Doc/Doxyfile configuration file for Doxygen and corresponding
7 README file for usage added.
8 * Test/testWrite.cxx added. This new test comes from a split of
9 test.cxx that is now reverted to its original purpous i.e.
10 testing the proper parsing of a Dicom related file.
11 testWrite.cxx concentrates on testing the IO part of gdcm.
12 * Test/bug1.cxx (containing a bug on WIn32) added.
13 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
14 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
15 whose purpose is to publish the content of the TagNames of the
16 Dicom public dictionnary were not accessible without an
17 instance of class gdcmHeader.
18 - those methods are now static methods of gdcmDictSet and hence
19 require no instances at all to be invocated.
20 - within gdcmDictSet this change required to change some method
21 to class methods (i.e. are now static) among which SetDictPath
22 (renamed to BuildDictPath) and LoadDefaultPubDict.
23 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
24 the above changes by calling the new method classes of gdcmDictSet.
25 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
26 the above to be effective.
27 * python/gdcmPython: in order to wrap properly the above changes
28 for Python, swig version now needs to be > 1.3.17.
29 * python/gdcmPython/Makefile fixed to adapt itself to new
30 configure/make shema introduced by Johan Montagnat (thanks for the
31 contribution). Alas this Makefile cannot be turned into a proper
32 Makefile.am without some heavy changes in the configure.in
33 (for python dectection).
34 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
35 now avoids publishing the empty entries.
37 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
38 * python/setup.py : bug fix concerning install under windows
40 * gdcm.dsw : bug fix concerning path for libraries for python !!!
42 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * Dicts/dicomV3.dic : remove double spaces !!!
44 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
45 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
48 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
49 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
51 * src/gdcm.h clean up of JPR spurious comments.
53 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
54 * python/distutilsSwigCPlusPlus.py now properly collects the
55 shadow classes generated by "swig -c++" (gdcm.py in our case)
56 when using "python setup.py install".
57 * python/gdcmPython/__init__.py imports gdcm.py and only manually
58 reexports the working classes.
59 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
60 by the classical C errno scheme. This is to prevent an obscure
61 behavior of the python wrappers when importing wxPython.wx prior
62 to gdcmPython (which ended up in an abort call). An illustration
63 of this oddity can be found in the Test/ExceptionAndPython
64 subdir (see the README file). This problem probably due to
65 an combination of g++ and dynamic loading.
66 * added Test/ExceptionAndPython (see above)
68 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
69 * Changed the layout of the python part to avoid bloating main
70 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
71 i.e. the distutils arsenal. All the python related stuff is
72 again in a python subdir, but the package itself is now in
74 * setup.py was cleaned up:
75 - pythonIncludePath removed
76 - python setup.py bdist target is now functional.
77 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
78 collision with other packages). gdcmPython/demo/*.py changed
80 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
81 * python subdir moved to gdcmPython (preparation of distutils packaging).
82 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
83 distutils installer is operational.
84 * - gdcmPython/__init__.py now properly loads the swig generated
85 shadow classes (from gdcm.py).
86 - gdcmPython/demo/*.py changed to import the package gdcmPython
87 instead of gdcmPython/demo/load.py.
88 - gdcmPython/testSuite.py changed to import the package gdcmPython.
91 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
92 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
93 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
94 entries within the associated public Dicom dictionary resp. the same
95 information but sorted by the fourth field (PAT, IMG, DIR) of the
97 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
98 are now in the "???" group.
99 - python/gdcm.i changed accordingly,
100 - python/demo/printGroupedPublicDict.py added, that gives an example
101 of the above new functionalities in Python.
103 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
104 * src/gdcm.h, gdcmHeader.cxx:
105 - historic references to glib's g_malloc and g_free (#defined)
106 were definitively removed.
107 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
108 * src/gdcmElValSet.cxx:
109 - GetElement(guint32, guint32) renamed to GetElementByNumber.
110 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
111 - GetElValue(string) renamed to GetElValueByName.
112 - Added GetElementByName(string).
113 * src/gdcmHeader.cxx: added
114 - GetPubElValRepByNumber(guint16, guint16)
115 - GetPubElValRepByName(string)
116 - GetShaElValRepByNumber(guint16, guint16)
117 - GetShaElValRepByName(string)
118 - GetShaElValByNumber(guint16, guint16)
119 - GetShaElValRepByName(string)
120 - GetElValRepByNumber(guint16, guint16)
121 - GetElValRepByName(string)
122 - GetElValByNumber(guint16, guint16)
123 - GetElValRepByName(string)
124 * Doc/requirements.txt added.
126 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
127 * Test/Makefile building now depends on the one of libgdcm.so
128 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
129 pixel data) aware which enables finding the address (offset) of
130 the pixel data of JPEG encoded DICOM files. This leaves only a single
131 file in the testSuite whose pixel data address (offset) is unknown.
132 * python/testSuite.py changed accordingly.
134 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
135 * VC++ has some strong limitations when working with the STL, as stated
136 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
137 "Also note that some STL containers (map, set, queue, list, deque)
138 cannot be exported. [...]
139 Some STL classes contain nested classes. These classes can not
141 This is caused by a designed limitation that once a template
142 class is instantiated, it can not be re-instantiated and
144 Since our usage of map<> is ubiquitous in gdcm, this "designed
145 limitation" of VC++ is a pitfall.
146 Hence the Python wrappers of gdcm cannot be incrementally linked
147 against the c++ dynamic library. The dirty but only workaround is
148 to forget about incremental link of dynamic libraries and to generate
149 the Python wrappers library with the inclusions of the underlying C++
151 The following modifications concern this matter on Win32/VC++:
152 - wrapping python correct with standalone wrapped dll (don't use separate
153 dll under windows !!!!)
154 - python21_d debug mode enabled (ask Frog how to use it :-)
155 - NO problem with having an STL member of class for example string in C++
156 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
157 - Python test of dcmlib in Python is ok under windows on a large set
159 * removed glib references
160 * typedef's inserted in gdcm.i for correct swig type management
162 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
163 * python/demo/*.py load.py extracted from test.py. Added explore.py
164 that only displays required tags and testAll.py that parses all
165 the files of the testsuite without using unittest.
166 * python/testSuite.py other additional test on new files added.
167 * Data/* new test files added accordingly to the testSuite.
168 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
169 the vr in the file differs from the one of the dictionary.
171 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
172 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
173 values, but limits itself to values which are below a user specified
174 size (by default 1024 bytes).
175 * python/gdcm.i : elements not loaded (because their size is above the
176 user specified treshold) are exported with their TagKey as key of the
177 python dictionary. This enables the testsuite to make some checks
178 on the unloaded elements (since we have their offset and size).
179 * python/testSuite.py
180 - now tests for the existence and proper value of the pixel data
181 - two new examples added.
182 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
184 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
185 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
186 aware. See the strategy comments in gdcmHeader::FindeLength().
187 * Test/test.cxx now accepts a filename as first argument.
188 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
189 * python/testSuite.py changed to integrate test on above files.
191 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
192 * Dicts/dicomV3.dic removed all the trailing (RET) when the
194 * python/testSuite.py more tests added.
196 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
197 * python/testSuite.py unittest test suite added (uses Data)
198 * Data/* dcm and acr files for the test suite.
199 * glib dependance removed from un*x version. We now use ISO C99
200 7.18 Integer types (see stdint.h)
201 - python/Makefile, src/Makefile src/gdcm.h
202 * src/ when an explicit vr (like dicom files) suddenly poped an
203 implicit element we use to mark the underlying DictEntry of the
204 concerned ElValue with "Implicit". This strategy was damageable
205 too the public or provite dictionaries, since some of their vr
206 would be changed. Since Header::FindLength heavily relies on the
207 detection by Header::FindVR of falsely explicit elements, I
208 added an extra ImplicitVr member to ElValue (boolean).
209 The rest of the changes we the necessary adaptations.
211 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
212 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
214 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
216 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
217 * Adaptation for porting to VC++:
219 o forced to use std namespace (for string to be known)
220 o all class use __declspec export style on WIN32
221 - src/gdcmUtil.cxx new Exit method that wraps the exit call
222 (in stdlib.h on Win32 but in std:: for gcc)
223 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
224 variable GDCM_DICT_PATH.
225 * src/gdcmHeader.cxx verbose comments made discrete.
227 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
228 * python/gdcm.i: added a typemap that converts a C++ hashing table
229 to native Python dictionary.
230 * python/demo/test.py:
231 - now uses the native dictionary for exploration of gdcmHeader.
232 - takes an optional filename argument (the file to parse).
233 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
234 PubElVals hashing table.
235 * Dicts/dicomV3.dic removed error prone trailing spaces.
237 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
238 * Python wrapping process moved away from src/Makefile to
239 newly created python/Makefile (as well as gdcm.i)
240 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
241 * src/gdcmHeader::FindLength only looks for current vr when necessary.
242 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
243 from the environement variable GDCM_DICT_PATH (when existing).
244 * src/gdcmDict::GetTag bug fix.
246 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
247 * Straightforward temporary fixes for swig to build the python wrappers.
248 src/Makefile now has a python working entry [by working we mean
249 that we can import de shadow classes without errors].
251 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
252 * hashtest.cxx removed (since allready in Test)
253 * src/gdcmlib.h renamed to src/gdcm.h
254 * src/dcm.i renamed to src/gdcm.i
255 * src/Makefile prepared for python wrapping
257 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
258 * src/gdcmHeader.cxx :
259 - Parsing of header is now separated from loading of element values
260 (see gdcmHeader::LoadElements).
261 - general clean up of hopefully all file access (creation of
262 ReadInt16 and ReadInt32)
264 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
265 * src/gdcmHeader.cxx :
266 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
268 - SetLgrElem renamed to SetLength
269 - GetLgrElem renamed to GetLength
270 - ~gdcmHeader() made virtual to pesky warning messages at compile.
271 * src/gdcmElValSet.cxx fixed both GetElValue methods
272 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
273 due to IdoDude was cleaned out.
275 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
276 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
277 concentrates on finding the value representation (when it exists).
278 RecupLgr now only finds the element value length, and it avoids
279 returning the unecessary skL (skipped length).
280 Also, offsetCourant was simply removed (with taille_fich) since
281 it was redundant with the File position internals (by using
282 ftell and fseek). This also made skL (see above in RecupLgr) usage
284 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
285 on the libido specificities which are handled through class
287 * Test/implicit_vr.dcm dicom v3 in implicit value representation
290 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
291 * Truckload of changes. Parsing of header is barely functional
292 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
294 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
295 * src/gdcmHeader.cxx many addons of low level methods
297 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
298 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
301 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
302 * This corresponds to all the changes decided at the meeting of
303 May 23 2002. Needless to say we are running late...