1 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
3 * CLEANUP_ROUND (14) for gdcmPixelConvert
4 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
5 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
6 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
8 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
9 anymore and hence avoids storing a copy of PixelConvert::Decompressed
10 into File::Pixel_Data.
12 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
13 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
14 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
15 * CLEANUP_ROUND (13) for gdcmPixelConvert
16 Substituted File::ParsePixelData() with PixelConvert::Print() new
18 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
19 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
20 method to those classes.
21 - src/gdcmFile.[cxx|h]:
22 -- Added a ::Print() method.
23 -- PixelConverter is now a reference instead of a member.
24 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
25 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
27 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
28 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
29 collaboration diagram and inheritance diagram should be generated with
31 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
32 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
33 pointlessly wrapped (see
34 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
35 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
36 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
37 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
38 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
39 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
40 -- File::Initialise: PixelConverter setup moved away to
41 PixelConverter::GrabInformationsFromHeader()
42 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
43 interpretation moved away to PixelConverter::BuildRGBImage()
45 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
46 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
47 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
49 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
50 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
51 displayed on Win32 when a brutal abort() occurs (because of uncatched
52 exception). See TODO new entry of this commit for more on this.
53 * TODO added new entry.
54 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
55 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
56 - HandleColor is no longer called from gdcmFile.cxx
57 - gdcmPixelConvert.cxx clean up on method arguments and internal
58 variable names for semantical coherence.
60 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
61 * Finished lossless transition, not only do we now read all lossless jpeg
62 images, without the need of the Cornwell lib, but we do read them properly now
63 * To reduce code (well to avoid code duplication), I defined a common place
64 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
65 redefine symbols. This is not prefect but this the best solution I found for a
66 compilation time jpeg option.
68 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
69 * Update jpeg ijg lib to support lossless jpeg implementation
70 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
72 * Also added a special copyright for dcmtk since we use their bugfixes.
75 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
76 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
77 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
78 matters, as stated in warning note at begining of %include section).
79 * src/gdcmDicomDir*.[cxx|h]: coding style
80 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
81 * src/gdcmJpeg8.cxx: doxygen fix.
82 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
83 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
84 from File:: to PixelConvert::.
86 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
87 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
88 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
89 - more code moved away from File:: to PixelConvert::
90 - fat setup of PixelConverter set in place in File::Initialise.
92 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
93 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
94 namespace at the file system level. So now you should convert your examples
96 gdcmHeader -> gdcm::Header
97 It would be nice if people keep in mind to no open the namespace, since it
98 allows compilation on broken plateform which were defining common symbol in
99 the standart namespace (like LP, Unknown ...)
101 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
102 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
103 The JPEG fragments are now parsed at the same stage than the RLE
104 information. All code related to JPEG is now in gdcmPixelConvert:
105 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
106 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
107 export a gdcmFile:: method. Those are simply global functions
108 (for the time being this is better than having them attach to
109 either gdcmFile:: or gdcmPixelConvert::).
110 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
111 and stores the result in a gdcmJPEGFragmentsInfo.
112 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
113 code (among other stuff) moved away from gdcmFile:; to
116 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
117 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
118 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
119 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
120 clean up of RLE related code.
121 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
122 - src/gdcmRLE.cxx removed
123 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
124 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
125 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
126 * CLEANUP_ROUND (9) for gdcmPixelConvert
127 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
128 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
129 away from gdcmFile:: to gdcmPixelConvert::.
131 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
132 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
133 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
134 This is because Parse7Fe0 used to parse the pixels to compute the
135 length. This task was passed over to FindDocEntryLengthOB() a long
136 time ago, EXCEPT I had forgotten the OW case...
137 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
138 we just recylce the code for parsing RLE fragments and computing
140 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
141 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
142 with the retired Parse7Fe0().
143 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
144 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
146 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
147 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
148 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
149 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
150 - src/CMakeLists.txt: alphabetic order reodering + new entries.
151 * CLEANUP_ROUND (4) for gdcmPixelConvert
152 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
153 to return an unused length.
155 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
156 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
157 this should be cleanner from the plane view. The iostream are erally a pain
158 to use to do simple stuff.
160 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
161 * Redo the compilation of the ijg jpeg library. Now only one source is
162 necesseray. No need to rename file by hand what so ever. CMake handle the
163 copying of the file within different directory, configure header file to
164 modify some symbol. The only addition made to ijg wasd a mangle table so
165 that symbol are different wether we are within 8bits or 12bits.
167 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
168 * Added documentation of vtkgdcmReader on Website:
169 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
170 with it's binary name).
171 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
172 the Website to be more complete.
173 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
174 doxygenated documentation.
175 - Doc/DoxyVtkGdcmReaderExamples.txt added
176 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
177 DoxyVtkGdmReaderExamples.html )
178 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
179 * CLEANUP_ROUND (3) for gdcmPixelConvert
180 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
182 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
183 * CLEANUP_ROUND (2) for gdcmPixelConvert
184 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
186 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
187 * CLEANUP_ROUND for gdcmPixelConvert:
188 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
189 - src/gdcmPixelStuff[h|cxx] removed
190 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
191 - src/CMakeLists.txt changed accordingly
193 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
194 gdcmVersion.py moved to newly created ATTIC related
195 gdcmPython/SetupOldies/ directory.
196 * Autotools clean up:
197 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
198 - autogen.sh configure.in acinclude.m4 python.m4 removed
200 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
201 * src/*.cxx *.h Reference to License.htm fixed to License.html.
202 * Doc/CMakeLists.txt, doxygen.config.in: fix.
203 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
205 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
206 * TODO updated with Mathieu suggestions. I proposed a template for
207 describing TODO entries and used it for new entries.
208 * Added Doc/Website/CodingStyle.html, Developpers.html,
209 DeveloppersPython.html, GdcmDataCvs.html and
210 DownloadVersion0_1.html, DownloadVersion0_3.html.
211 * Some Doc/*.txt Doxygen files (which do not really concern the
212 documentation itself, but the website) moved to html and
213 placed in directory Doc/Website:
214 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
215 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
216 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
217 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
218 * CMakeLists.txt changed accordingly.
219 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
220 DeveloppersPython.html
221 * INSTALL nows refers to Doc/Website/Installation.html
223 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
224 * Added Doc/Website directory, that contains a first raw version
227 2004-09-23 Jean-Pierre Roux
228 * FIX In order not to be poluted any longer by casting problems,
229 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
230 we can now delete[] it safely
231 * VoidArea is now called BinArea (less confusing name),
232 and all the methods called ...VoidArea... are now ... BinArea...
233 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
235 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
236 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
237 clear) TagHT, which is an inherited member of gdcmElementSet. It is
238 up to the destructor of gdcmElementSet to clean up TagHt and it's
241 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
242 * Test/CMakeLists.txt: update to follow gdcmData renamings.
243 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
245 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
246 * ENH: added some utility method that builds a flat dictionnary
247 holding all the Dicom entries contained in the recursive structure
248 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
250 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
251 BuildFlatHashTable() that build a flat dictionary.
252 - src/gdcmElementSet.h: added a new private GetTag() accessor.
253 gdcmDocument is now a friend of gdcmElementSet.
254 - src/gdcmElementSet.cxx: clean up.
255 - Example/FlatHashTablePrint.cxx added.
256 - Example/CmakeLists.txt changed accordingly
258 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
259 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
260 moved away from gdcmDocEntrySet (since this class is an abstract class
261 acting like an interface). SQDepthLevel and BaseTagKey are now
263 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
264 and associated accessors. Doxygenation of the class.
265 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
267 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
268 Use SQDepthLevel accessor instead. ::Print() adapted.
269 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
270 - src/gdcmDocument.cxx changed accordingly.
272 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
273 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
274 - The following is the doxygen comment of the typedef declaration
275 of gdcmagKey in src/gdcmCommon.h:
276 gdcmTagKey is made to old an "universal" (as in URL, Universal
277 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
278 A dicom tag allways has a group and an element, but a set of tags
279 embeded in various (optionally nested) sequences and sharing
280 the same group and element all share the same (group, element)
281 "identifier". Hence the (group, element) cannot be used as an
282 identifier (in gdcm we shall refer to a "TagKey") of a tag.
283 In order to construct a proper tag identifier (i.e. a key) we
284 consider the following definition of a TagKey:
285 - let Group, Element be the string representation of the
286 group and element dicom tag members,
287 - let ItemNumber be the string representation of the integer
288 index of the considered item number of a sequence,
289 Let the key of a tag embeded in a sequence, noted SeqTag, be
291 /ItemNumber#Group|Element
292 where "/", "#" and "|" are characters acting as separators.
293 Then the general form of a gdcmTagKey is given by:
294 Group|Element<SeqTag>
295 where <SeqTag> means NO or many instances of SeqTag.
296 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
299 but the gdcmTagKey of a tag "embeded" is the first item of
300 a sequence, itself nested in the third item of a sequence is the
302 0004|1220/2#0008|0082/0#0008|0090
303 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
304 order to hold the new sequence compatible key. Previously, the
305 GetKey() method would look in the underlying gdcmDictEntry.
306 - src/gdcmDocEntry.cxx:
307 -- constructor now copies the underlying DictEntry key, in the local
309 -- ::Print: displays the member Key, instead of the (group, element).
310 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
311 - src/gdcmDocEntrySet.h:xi
312 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
313 -- now has a new BaseTagKey member.
315 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
316 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
318 This poses the problem with the semantics of the following lines
319 LoadEntryVoidArea(0x0028,0x1201); // R LUT
320 LoadEntryVoidArea(0x0028,0x1202); // G LUT
321 LoadEntryVoidArea(0x0028,0x1203); // B LUT
322 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
323 to the long FIXME note for what the problem is. Nevertheless in
324 order to get things working the dicom dictionary was altered !
325 Please fix things urgently...
326 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
327 information), see above note on moving the member VoidArea. Nevertheless
328 the following entries previously correctly set as US are now inproperly
330 0028 1201 OW IMG Red Palette Color Lookup Table Data
331 0028 1202 OW IMG Green Palette Color Lookup Table Data
332 0028 1203 OW IMG Blue Palette Color Lookup Table Data
333 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
334 of gdcmDocEntry moved to gdcmSeqEntry.
335 * src/gdcmSeqEntry.cxx: STYLE.
337 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
338 * Test/TestAllEntryVerify.cxx minor fix and added comments.
340 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
341 * gdcmPython/testSuite.py: all the test suite in python is now moved
342 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
343 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
344 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
346 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
347 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
348 to avoid inclusion recursion until STL is reached.
349 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
350 mecanism. errno.h is not included in gdcm anymore.
351 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
352 (gdcmFormatError now inherits from gdcmFormatUnexpected).
354 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
355 gdcmData/TestAllEntryVerifyReference.txt
356 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
357 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
358 exception_on_error parameter.
359 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
360 - vtk/vtkGdcmReader.cxx changed accordingly,
361 - Example/*.cxx and Test/*.cxx changed accordingly.
363 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
364 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
365 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
366 enable_sequences removed from gdcmHeader constructor and dependencies.
367 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
368 * gdcmPython/demo/PrintHeader.py: dummy fix.
369 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
370 skip_shadow removed from gdcmHeader constructor and dependencies.
371 * Example/*.cxx and Test/*.cxx changed accordingly.
373 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
374 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
375 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
377 2004-07-21 Jean-Pierre Roux
378 * FIX Now, Parsing and Printing a DICOMDIR do work!
379 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
381 2004-07-20 Jean-Pierre Roux
382 * FIX Some brain damaged headers have Zero-Lenght fields
383 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
385 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
386 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
387 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
388 variable (instance of gdcmDebug) by a definition macro, and the instance
389 is now in static in the gdcmDebug class
390 * src/gdcmSQItem.h : (FIXME) remove an undefined method
391 * Test/PrintAllDocument.cxx : bug fix in the result of the test
393 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
394 * WARNING: ctest now depends more tightly on gdcmData. You should
395 check out gdcmData properly for things to run smoothly...
396 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
397 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
398 we need the pixels not be loaded in order to use the ValEntry
399 that displays position and size).
400 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
401 This is a C++ based equivalent of gdcmPython/testSuite.py that should
402 be deprecated. If you have any doubts about the advantages of a
403 modern scripting language (read Python) versus grass root C++ (i.e.
404 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
405 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
406 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
407 Anyhow, consider documenting the gdcmData images in
408 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
410 * Test/CMakeLists.txt:
411 - now uses TestAllEntryVerify.cxx
412 - specific comments on oldACR00001.ima (now renamed in gdcmData
413 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
414 gdcmData/TestAllEntryVerifyReference.txt
417 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
418 * src/*.[h|cxx] : typedef clean up
419 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
420 - TagKey renamed to gdcmTagKey (for external usage)
421 - VRKey renamed to gdcmVRKey (for external usage)
422 - removal of typedef duplication.
423 - Removed all unecessary inline keyword from class inline definitions.
424 - Some method|function(void) declarations replaced with method|function().
425 * src/jpeg/libijg12/jdhuff12.c:
426 - printf polluting ctest removed.
427 - TAB removal for comminting
429 - TestAllReadCompareDicom.cxx: added a test that compares all the
430 images in gdcmDataImages.h with corresponding images in
431 gdcmData/BaselineDicom/. When baseline images are not present
432 this test creates them.
433 Note: we need to validate each reference image, but before that
434 I'd like to rename them with a more explicit name...
435 - CMakeLists.txt: changed accordingly.
436 * Example/*.cxx: examples now only include gdcm.h (as opposed to
437 including each header needed).
439 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
440 * Test/*.cxx and Example/*.cxx: moved some examples away from the
441 test suite to the Example directory. Are concerned:
446 - TestWriteSimple.cxx
447 * Test/CMakeLists.txt: added some comments on reasons for black listing
448 image gdcmData/oldACR00001.ima
450 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
451 * Test/CmakeList.txt: removed the following from black list (to be coherent
452 with removal from gdcmData):
453 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
454 - gdcm-MR-PHILIPS-16.dcm
456 Added the following because after last cvs update, they cause
457 ctest -R TestReadWriteReadCompare
459 - gdcm-MR-SIEMENS-16-1.acr
461 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
462 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
463 new comments in this file) we temporarily (sigh) move to a weaker
465 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
466 we don't need to black list the following images anymore:
467 - 8BitsUncompressedColor.dcm
469 - US-PAL-8-10x-echo.dcm
470 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
471 fixes and the beautified code ;-)
472 This fixes the bug introduced in version 1.42 (when beautifying)
473 that made the parsing of 8BitsRunLengthColor.dcm unproper.
474 Note: ctest was blind to this bug (this means we need to still
475 improve the test suite). The bug could be detected by using
476 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
478 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
479 and by displaying the (garbage) produced file temp.XDCM...
481 2004-06-29 Jean-Pierre Roux
482 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
483 - replace by uggly but working old code :-(
484 A lot of things should be OK again.
485 It's really urgent to have a test suite that *tests*,
486 to prevent Frog's beautifying sessions to break all the stuff
487 (twice, withing a fortnigh ...)
489 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
490 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
491 redundancy) to added Test/TestReadWriteReadCompare.cxx
492 * Test/CmakeList.txt: because the compare test of
493 Test/TestReadWriteReadCompare.cxx fails, the following images are
494 black listed: - 8BitsUncompressedColor.dcm
496 - US-PAL-8-10x-echo.dcm
497 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
498 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
499 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
500 and ad-hoc kludge. This kludge is now removed, and on encountering
501 such an image (OB field brain damaged) we set errno. Then in
502 ::FindDocLength() we "fix" the length as being ALL what remains
503 in the file (until EOF). We then proceed, hoping for the best...
504 This fixes a SegFault in ShowDicom when trying to write such an
506 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
507 (because TestWriteRead breaks on it, after a non conformal commit?).
508 ctest now runs properly, except for MakeDicomDir (which was allways
509 broken) and the Python related stuff (still not fixed).
511 2004-06-24 Jean-Pierre Roux
512 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
513 FIX : Test/TestReadWrite now iterates on all the file names
514 (instead of infinite loop)
515 ENH : Test/TestWriteRead now iterates on all the file names
517 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
518 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
520 2004-06-24 Jean-Pierre Roux
521 FIX : - now Write drops LUT Descriptors and LUTs (if any)
522 when SamplesPerPixel =3
523 - now Write is no longer confused by
524 'BitsAllocated = 12" and 'BitsStored=12"
525 - "UN" value representation Elements are now written correctly
526 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
527 ENH : - now gdcmHeader has its own Write methods
528 (in order to split the job that has not to be done
531 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
532 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
533 loop on the same image until memory went out.
534 Note: this means we still have gobs of memory loss in PrintDocument
535 * src/gdcmDocument.cxx: fixes problem on parsing on file
536 gdcmData/16BitsJpegLosslessGrayScale.dcm.
538 2004-06-24 Jean-Pierre Roux
539 FIX : Write - All the Sequences and Sequence Item are now written
540 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
541 is added a the end, when necessary.
542 - A lot of brain-damaged images, that were read correctly are
543 now written correctly
544 - length compatible BinEntry are now loaded correctly
545 (even for odd groups)
546 Note : only Explicit Value Representation was checked.
547 (question : is implicit VR really necessary for gdcm ?)
549 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
550 * DEVELOPPER: added a proposition of coding style.
551 * src/gdcmDocEntry.h: removed every inline declaration (for test of
554 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
555 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
556 Use the gdcmDocEntry::Print() and Write() instead.
557 * src/gdcmDocument.cxx: bug fix.
559 2004-06-22 Jean-Pierre Roux
560 FIX : gdcmDocument.cxx
561 - Now we do recognize the JpegLossLess format (there was a misstyping in
562 code 'beautyfication' :-(
563 - Now we automaticaticaly load the Luts, if any
565 2004-06-22 Jean-Pierre Roux
566 In order : to write Sequences, whatever their imbrication level,
567 : to allow user to create his own Sequences
568 a lot of modif where necessary (adding, moving, or virtualising methods)
570 WARNING : save your own sources *before* cvs up !
573 ADD virtual void Write(FILE *fp, FileType filetype);
576 ADD virtual void Write(FILE *fp, FileType filetype);
577 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
580 ADD virtual void Write (FILE *fp, FileType filetype)=0;
581 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
582 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
583 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
584 ADD std::string GetEntryByName(TagName name);
585 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
587 std::string vr = "unkn",
588 std::string fourth = "unkn",
589 std::string name = "unkn");
590 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
591 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
592 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
593 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
594 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
595 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
596 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
597 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
600 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
601 ADD virtual std::string GetEntryByName (TagName tagName);
602 ADD virtual std::string GetEntryVRByName (TagName tagName);
603 REM virtual bool Write(FILE *, FileType);
604 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
605 FILE *_fp, FileType type);
606 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
607 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
608 REM virtual bool WriteEntries(FILE *_fp,FileType type);
609 REM virtual std::string GetEntryByName (std::string tagName);
610 REM virtual std::string GetEntryVRByName (std::string tagName);
611 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
612 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
613 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
615 std::string vr = "unkn",
616 std::string fourth = "unkn",
617 std::string name = "unkn");
618 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
619 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
620 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
621 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
624 ADD virtual void Write(FILE *fp, FileType filetype);
627 ADD virtual void Write(FILE *fp,FileType filetype);
630 ADD virtual void Write(FILE *fp, FileType filetype);
631 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
632 REM std::string GetEntryByNumber(guint16 group, guint16 element);
633 REM std::string GetEntryByName(TagName name);
636 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
638 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
639 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
640 The default constructor invoked by the line
641 gdcmHeader *f1 = new gdcmHeader( header );
642 was gdcmHeader::gdcmHeader(bool) instead of the expected
643 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
644 Hence the parsing wasn't executed... See also below.
645 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
646 as explicit constructor didn't do the trick to fix the above problem.
647 Could anyone explain why ?
648 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
649 properly calls gdcmValEntry::Print() (that was weed out from
650 code related to gdcmBinEntry).
652 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
653 * In order to fix memory leaks:
654 - Test/TestWriteSimple.cxx: added cleaning of free store through
656 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
657 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
658 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
659 (through the call to ::AddDicomDirMeta()) or the destructor
660 would crash when deleting uninitialized ::metaElems].
661 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
662 - src/gdcmDocument.cxx:
663 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
665 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
666 was causing memory leaks.
667 - src/gdcmSQItem.cxx:
668 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
669 cleanly handled with polymophism: sorry but my milage is low).
670 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
671 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
672 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
673 This avoids SegFaulting.
674 - src/gdcmSQItem.h: coding style.
676 - Test/TestWriteSimple still severely sucks. The output image content
677 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
678 damaged when displayed with vtkgdcmViewer.
679 - on memory leaks: TestWriteSimple leaks really less (see entry
680 of 2004-06-18 in Changelog file for the call to valgrind).
681 - on segfaults: ctest now passes all the tests but one (no more
683 * Erroneous leading white fix:
684 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
685 white[s] (as opposed to from >> xxx, that removes it [them].
686 - src/gdcmTS.cxx: ditto.
687 - gdcmPython/testSuite.py: dirty related kludge removed.
688 * src/*: remaining references to gdcmParser removed.
689 * src/*[cxx|h]: added copy[way]left header.
692 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
693 * In order to fix writing of dicom files:
694 - Test/TestWriteSimple.cxx: a simpler example of writing.
695 - Test/CMakeLists.txt changed accordingly.
696 - src/gdcmDocument.cxx:
697 -- The destructor now recursilvely removes potential sequences.
698 -- Bug fix in ::IsJPEG2000()
699 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
700 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
702 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
703 to only declared) and build on top of
704 ::GetDocEntryByNumber(guint16, guint16).
705 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
706 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
707 for usage in destructor and treatement of promotion in
708 ::ReplaceOrCreateByNumber().
709 - src/gdcmSQItem.cxx: destructor should better handle his job.
710 Test/TestWriteSimple now runs (or at least it DOES something).
711 * We can now start hutting memory links. A good starting point is:
712 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
713 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
714 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
716 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
717 * Valgrind note: after Mathieu Malaterre teached me how to read
718 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
720 Using gcc, you can force the STL to use malloc and to free memory as
721 soon as possible by globally disabling memory caching.
722 With 3.2.2 and later, you should export the environment variable
723 GLIBCPP_FORCE_NEW before running your program.
724 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
725 simply vanish (it is still not clear to me, whether this means that
726 STL std::string leaks or if valgrind believes it leaks...).
727 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
728 running bin/gdcmTests makeDicomDir):
729 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
730 - Test/makeDicomDir.cxx now properly traps empty lists and returns
732 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
733 SegFaulting (I drowned in DicomDir related code when trying to
734 understand why the list is empty...).
735 * src/gdcmDocument.h: first BSD license header try.
736 * Doc/License.txt added.
738 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
739 * src/gdcmDocument.[h|cxx]:
740 - Clean up of the Transfer related predicates. They are now all based
741 on new method isGivenTransferSyntax, that (should) handle properly
743 - general clean up, simplification, and coding style.
744 - Specific clean up of Parse7FE0() (umproperly named actually).
745 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
747 2004-06-14 Jean-Pierre Roux
749 - fix the display of Sequence Delimitor (SQDepthLevel pb)
750 - fix the display of SQItem ordinal number
751 - add the GetSQItemByOrdinalNumber method
752 - remove some useless never written private methods
754 2004-06-14 Jean-Pierre Roux
756 - adding a constructor taking a gdcmDocEntry as an input param
757 - ReplaceOrCreateByNumber now returns :
758 a gdcmBinEntry * if a Binary (void *) value is passed as a param
759 a gdcmValEntry * if a string value is passed as a param
761 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
762 according to the param type (no longer sets a gdcmDocEntry)
763 - GetValEntryByNumber, GetBinEntryByNumber added
764 - NewValEntryByNumber and NewBinEntryByNumber added
766 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
768 - GetSQItemNumber and SetSQItemNumber added, to provide
769 a (relative) Item identier inside a given Sequence
770 \warning : some pb remaining around this number
772 - AddEntry now takes the Item Number as a param
774 - adding a constructor taking a gdcmDocEntry as an input param
776 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
777 * Memory leak hunt with the following command:
778 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
779 --show-reachable=yes gdcmTests PrintDocument
780 It looks like many (all?) leaks are due to the STL (or a bad usage
781 of the STL. The lines producing the leaks now have a comment with
782 a "MEMORY LEAK" tag: you can retrieve them with
783 grep "MEMORY LEAK" src/*
784 Here are two typical examples which I can't help fixing:
789 char * test = "babo";
790 name = test; //// <--- valgrind detects 960 bytes lost in
791 //// call to std::string::operator=(char const*)
792 name.clear(); //// Doesn't help !
800 std::cout << "Type a bunch of characters followed by RETURN: ";
801 getline(std::cin, line); //// <--- valgrind dectects a loss
802 //// of 1320 bytes in call to
803 /// std::basic_istream<>& std::getline<>
809 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
810 * src/gdcmHeader.[cxx|h]:
811 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
812 and related, moved away to gdcmDocument.
813 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
814 the corresponding protected accessors of inherited class
815 gdcmDocument, removed ! As a consequence gdcmFile had to be
816 declared friend of class gdcmDocument (see below).
817 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
818 - Clean up of undefined or unused methods.
819 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
820 account the changes to gdcmHeader.h).
821 * src/gdcmDocument.h:
822 - gdcmFile is now a friend class (in order to take into account the
823 changes to gdcmHeader.h).
824 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
825 (see changes to gdcmHeader.h).
826 - Accessors (reading on the form GetEntry*) are now public.
827 - Clean up of undefined or unused methods.
828 * src/gdcmDocument.cxx:
829 - adaptation to changes to gdcmDocument.h
830 - ::OpenFile now writes a verbose message when file cannot be opened.
831 - some std::string properly set to VRKey
832 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
833 references to gdcmDocument.
834 * Test/TestFindTags.cxx: changed accordingly to above changes.
835 * gdcmPython/testSuite.py: adapted to renaming of acr files in
836 cvs repository gdcmData.
838 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
839 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
840 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
841 conflicts with gdcmValEntry::voidArea.
842 * src/gdcmValEntry.cxx: unmatching comment wiped out.
843 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
844 Value representation between StringRepresentable and BinaryRepresentable.
845 * src/gdcmDocument.cxx:
846 - method ParseDES: proper indentation restored and usage of
847 gdcmVR::IsVROfGdcmStringRepresentable wired in.
848 - method LoadDocEntry: the fingerprint left in the SetValue() of
849 unloaded entries (length > MaxSizeLoadEntry) had curiously been
850 removed. Reverting to previous code segment with the proper
851 dynamic_cast< gdcmValEntry* >.
852 Note: this was (partially) breaking the python test suite
853 (gdcmPython/testSuite.py) that made usage of the above
854 fingerprint to check presence of "Pixel Data".
855 * src/gdcmDocEntry.h: coding style.
856 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
857 now taken into account.
858 * gdcmPython/gdcm.i: adaptation to the new internal representation
859 of gdcm (exit gdcmParser, hello gdcmDocument).
860 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
862 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
863 anymore, but instead prints the loaded Python dictionary.
864 * .... alas, the python testSuite is still broken.
866 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
867 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
869 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
870 * src/gdcmUtil.h : export methods
872 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
873 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
875 * Initial addition of automatic python testing
876 * Initial addition of automatic image comparison
878 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
879 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
880 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
882 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
883 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
884 * Test/ShowDicom.cxx : bug fix for msvc compilation
885 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
887 2004-05-04 Jean-Pierre Roux
888 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
889 new concepts (and new classes) :
890 a 'gdcmDocument' is composed of a set of Doc Entries, that are
891 - elementary gdcmDocEntries (former gdcmHeaderEntries)
892 - Sequence Doc Entries (gdcmSeqEntries)
893 a Sequence is composed of Items.
894 Each item is a set of Doc Entries (this is recursive)
895 The non uniqueness of the 'Dicom tag' is due to this recursivity
896 (never taken into account)
897 Our unability to add a new 'entry' in the header
898 at the proper location (neither in the H-Table (map or multimap),
899 nor in the Chained List is also due to this recursivity.
900 Don't try, right now, to use/modify/compile these new sources :
902 We just commit all the stuff, 'as is', in order not to loose it.
904 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
905 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
907 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
908 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
909 file prefix (SetFilePrefix)
911 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
912 * Add a new test: ShowDicom, for now this is just the c++ version of
913 checkRead.sh, later it will be able to compare the image read against a
915 * Replace the DEBUG on the stack with a global entry in cmake interface:
916 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
918 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
919 * Add an example subdir, with a real example on how to read + write a
922 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
923 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
924 * Doc/CMakeLists.txt: the main page is now properly differentiated
925 between the developper and user version.
926 * Doc/doxygen.config.in: dropped search related obsolete flags
927 * src/gdcmParser.h, gdcmHeader.h: doxygenation
929 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
930 * DEVELOPPER: added some helpfull comments for compile/test/install
933 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
934 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
935 src directory, now generated in the build dir.
936 2. Tests as mentionned smarter
938 4. Add a new method in gdcmDict that return the PubDict by name
939 this is interesting for 3rd party lib like ITK,
940 where we could set the institution name / patient name...
942 * ENH: 1. Now the test suite is working for real
943 2. All binaries are now output in the gdcm-bin directory
944 (this was not true before)
946 2004-04-28 Jean-Pierre Roux
947 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
948 SeQuence indented printing of Dicom Header.
949 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
950 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
951 Computation of SQDepthLevel is now part of gdcmHeader constructor
952 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
953 tree-like structure of a Dicom Header.
954 * FIX Test code cleaning
956 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
957 * ENH: Adding automatic testing
958 1. Need a DartConfig.cmake to submit to public
959 2. Add a test driver gdcmTest.cxx
960 3. gdcmTestMain, an helper for the main test driver gdcmTest
961 4. Files in Test don't have a main anymore, this becomes interesting
962 when we add more and more tests, thus dsw don't have to load
964 * ENH: Adding a GDCM_DATA_ROOT for testing
965 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
966 one file instead of seven + some small cleanup
968 2004-04-22 Jean-Pierre Roux
969 * ENH Minor changes to the Print() methods.
970 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
971 Header printing. Example given with :
972 > PrintHeader fileName 2 new
973 (SQ based tree-like structure still to be done for the Header ...)
975 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
976 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
977 1. I have added some unsigned where needed
978 2. Some function parameter not used -> (void)
979 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
980 4. g++ don't like character '\' in comment
981 5. #define jpeg_create_decompress jCreaDecompress
982 this really need to be fixed
983 6. virtualize destructor of gdcmObject ... leakage
984 7. sscanf(g->first.c_str(),"%x",&gr_bid);
985 this also really need to be fixed
986 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
987 remove compression file
988 (as we only do decompression, right ?)
989 * ENH: Change malloc/calloc/free with c++ equivalent
991 2004-04-21 Jean-Pierre Roux
992 * FIX gdcmHeaderHelper::GetXSpacing
993 when a single value is found (bug ?), xpacing is now
994 defaulted to yspacing
996 2004-04-19 Jean-Pierre Roux
997 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
998 * ENH add parameters :
999 bool exception_on_error = false,
1000 bool enable_sequences = false,
1001 bool ignore_shadow = false
1002 to the gdcmFile constructors to be full gdcmParser compliant
1003 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1004 to allow reading of PAPYRUS 3.0 files
1006 2004-04-06 Jean-Pierre Roux
1007 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1009 2004-04-02 Jean-Pierre Roux
1010 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1011 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1012 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1014 2004-03-30 Jean-Pierre Roux
1015 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1016 for ACR file, written out as DICOM files (hope so...)
1018 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1019 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1020 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1021 moved to base class gdcmParser and only the specialisation is kept
1023 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1024 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1025 already does the job.
1026 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1027 (to be consistent with gdcmParser::WriteEntries).
1029 2004-03-30 Benoit Regrain
1030 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1031 upate of the object's instance. It's passed to 2 in the unfavorable
1032 case : one in the ExecuteInformation, one in the ExecuteData
1034 2004-03-29 Jean-Pierre Roux
1035 * ENH : Check on file type to be written moved
1036 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1037 * FIX : gdcmObject::ResetBoundaries now stops properly
1038 when end-of-list is reached
1039 : gdcmVersion modified (as Benoit Regrain asked)
1041 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1042 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1043 * src/gdcmUtil.cxx: added forgotten iostream include.
1044 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1045 equivalent to ExplicitVR in existing code).
1047 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1048 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1049 now contains all the gdcmGlobal related code.
1050 * minor coding style and doxygenation changes.
1052 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1053 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1054 now contains all the Debug related code.
1055 * minor clean-up of includes in src/*.cxx
1056 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1057 CreateCleanString) removed.
1058 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1059 * Doc/DoxyMainPageUser.txt added.
1060 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1061 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1062 src/gdcmDirList.cxx)
1064 2004-03-24 Jean-Pierre Roux
1065 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1067 2004-03-23 Jean-Pierre Roux
1068 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1069 big endian made volumes
1070 * ENH Now gdcmParser constructor and destructor are protected to forbid
1071 end user to instanciate class gdcmParser
1072 (only gdcmHeader and gdcmDicomDir are meaningfull)
1074 2004-03-22 Benoit Regrain
1075 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1076 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1077 gdcmSerie to gdcmDicomDirSerie
1079 2004-03-19 Jean-Pierre Roux
1080 * ENH Now the tree-like structure describing a DICOMDIR comming from
1081 an already existing DICOMDIR file is consistent with
1082 the home-made tree-like structure build ex-nihilo
1083 or build from the files held (recursively) in a Directory
1084 functions gdcmDicomDir::CheckBoundaries()
1085 gdcmObject::SetBoundaries() added
1087 2004-03-17 Jean-Pierre Roux
1088 * REM (Eric Boix bug) : removal of meaningless
1089 gdcmDicomDirImage::NewImage function.
1090 * FIX now file names and directory name are written properly in the
1092 * FIX now gdcmDicomDir constructor may be call without any trick
1095 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1096 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1097 of gdcmDicomDirImage::NewImage as empty function.
1099 2004-02-28 Jean-Pierre Roux
1100 * ENH add gdcmDicomDir:NewPatient
1101 add gdcmDicomDirPatient:NewStudy
1102 add gdcmDicomDirStudy:NewSerie
1103 add gdcmDicomDirSerie:NewImage
1104 to allow making gdcDicomDir object.
1105 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1106 (as opposite to the gdcmHeader chained list)
1108 2004-02-11 Benoit Regrain
1109 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1110 when using from python
1112 2004-02-10 Benoit Regrain
1113 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1114 * FIX : in gdcmDicomDir when the directory is empty
1115 * ENH : add callback and methods to get the progression of dicomDir
1118 2004-02-06 Jean-Pierre Roux
1119 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1120 - GDCM_META added to gdcmDicomDirType
1121 - class gdcmMeta created
1122 * ENH : - A brief summary is now displayed at the beginning of
1123 'testDicomDir' to help disaster magnitude estimation
1124 * REM : Now useless Test/explDICOMDIR.cxx
1126 2004-02-05 Benoit Regrain
1127 * ENH : add methods in gdcmObject to get the hash table or the list of
1129 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1130 * FIX : wrapping python for TagHeaderEntryHT
1132 2004-02-04 Benoit Regrain
1133 * FIX : even length for some strings when writting the dicom dir
1134 * FIX : sort the images in the dicom dir
1135 * FIX : Bug fix for python use of dicom dir
1136 * ADD : a python demo
1138 2004-02-04 Jean-Pierre Roux
1139 * FIX : Final solution (?) for icone embedded images
1140 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1141 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1142 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1143 gdcmData/gdcm-MR-SIEMENS-16.acr1
1144 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1145 to make full checking easier
1147 2004-02-04 Benoit Regrain
1148 * FIX : WriteEntries : coding style & logic in parameters
1149 * FIX : Set the elements to create the DicomDir in a dictionary file
1151 2004-02-03 Benoit Regrain
1152 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1153 * gdcmDicomDir : add the load of directory
1154 * Bug fix and print add-on
1156 2004-02-03 Jean-Pierre Roux
1157 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1158 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1159 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1160 * FIX gdcmParser.cxx : 'group length' elements are now considered
1161 as integers, even for shadow groups, when file is Implicit VR
1163 2004-02-02 Jean-Pierre Roux
1164 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1166 of the last synonym :-(
1167 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1169 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1170 * FIX taking into account the possible 7fe0,0010 multiplicity
1171 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1172 to allow removal of references to 7fe0,0010, to deal with
1173 ACR-NEMA images, when 0028,0200 is meaningfull
1175 2004-01-31 Jean-Pierre Roux
1176 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1177 no longer writes 'Un' on disk
1178 * FIX SQ elements with actual length are now dealt with corectly
1179 * FIX gdcmFile::WriteBase make the difference, for color images, between
1180 the length (for Palette expanded images)
1181 and Raw Length (non expanded image + Palette)
1182 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1183 (that broke Write). Replaced by UL.
1184 Aware user will reload the field if he
1185 thinks it's necesssary
1187 2004-01-30 Jean-Pierre Roux
1188 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1189 when 'dirty Acr' is found, to be compliant with the new
1190 IsReadable() methods.
1192 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1193 (no DOUBLE images in kosher DICOM,
1194 but so usefull for people that miss them ;-)
1196 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1197 DICOMDIR related utilities (not checked as Windoze compliant)
1199 2004-01-28 Jean-Pierre Roux
1200 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1202 2004-01-27 Jean-Pierre Roux
1203 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1204 to allow skipping the shadow elements, to save memory space.
1205 The TRUE value for this param has to be used
1206 with a FALSE value for the 'enable_sequence' param.
1207 ('public elements' may be embedded in 'shadow Sequences')
1208 * gdcmHeader methods now deal with 'embedded icones images' in the header
1209 (even when an 'icone image sequence' is announced by the
1210 element (0x0088,0x0200), but there is NO icone at all ...
1212 * gdcmHeader sometimes Image Location value doesn't follow
1213 the supposed processor endianity (see gdcmData/cr172241.dcm).
1216 * gdcmHeader add the method
1217 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1218 to get *all* the Header Entries with the same tag.
1219 GetHeaderEntrySameName is probabely *useless*
1220 (no meaning : Name is *not* an identifier within the Dictionnary)
1222 2004-01-26 Benoit Regrain
1223 * Bug fix in the print of hexadecimal representations. Remove long fields
1224 in the print and add a third level of print to print them
1226 2004-01-23 Benoit Regrain
1227 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1228 * Bug fix on test suite after remove the strip made on not string fields
1229 * Split the IsReadable method between gdcmParser which test that the file
1230 is dicom and gdcmHeader which test that it's an image file
1232 2004-01-22 Benoit Regrain
1233 * DicomDir : clean code, add methods, set variables in protected or private
1234 * gdcmUtil : bug fix for the clean string method
1236 2004-01-19 Benoit Regrain
1237 * Add the use of shadow dictionaries
1238 * bug fix and coding style
1240 2004-01-19 Benoit Regrain
1241 * src/gdcmFile.cxx : bug fix concerning the close of file
1242 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1243 * Add the update of header entries using the shadow library
1245 2004-01-19 Benoit Regrain
1246 * removal of file gdcmHeader2.cxx
1247 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1248 inheriting from gdcmParser. This split is to prepare the integration
1249 of dicom dir parsing
1250 * bug fix under python
1252 2004-01-16 Jean-Pierre Roux
1253 * REM removal of class gdcmHeaderEntrySet
1254 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1255 * ADD add file gdcmHeader2.cxx
1256 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1258 2004-01-15 Benoit Regrain
1259 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1260 entries created while parsing the header. Thus, they will be destroyed
1261 when the gdcmDictSet will be destroyed
1262 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1265 2004-01-15 Benoit Regrain
1266 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1267 made a fatal error because of the memory release at the end of program.
1268 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1269 some memory and vtk seems to have some problems with that.
1270 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1272 2004-01-14 Benoit Regrain
1273 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1274 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1275 * src/*.[h|cxx] : make changes due to class name changes
1276 * gdcmPython/demo/*.py : bug fix due to method names
1278 2004-01-13 Benoit Regrain
1279 * src/*.[h|cxx] : coding style
1280 * vtk/*.[h|cxx] : coding style
1282 2004-01-13 Benoit Regrain
1283 * gdcmPython/testSuite.py : test the readable flag of file for tests
1284 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1285 It's lied to the stl compilation by MSVC (windows, always windows...)
1286 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1288 2004-01-12 Benoit Regrain
1289 * src/*.h : add comments
1290 * src/gdcmDictSet.h : set the method BuildDictPath in public
1291 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1292 directly setted in the source code
1293 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1296 2004-01-09 Benoit Regrain
1297 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1298 * setup.py : use a reference to gdcmVERSION
1300 2004-01-07 Benoit Regrain
1301 * Modification to compile with the distutils.
1304 2003-12-10 Benoit Regrain
1305 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1306 can use a gdcmHeaderHelper to load datas
1307 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1308 made in the source code
1310 2003-12-10 Benoit Regrain
1311 * Update Windows projects and .cvsignore files
1313 2003-11-12 Jean-Pierre Roux
1314 * ENH gdcmHeader constructor has one more parameter (default value : false)
1315 that allows the user to 'go inside' the SeQuences only
1317 gdcmElValSet:Print takes it into account
1319 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1320 * ENH: Update gdcmPython/CMakeLists
1321 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1322 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1324 2003-11-10 Jean-Pierre Roux
1325 * FIX : gdcmHeader::LoadElements is now based
1326 on the ListTag listElem member,
1327 not longer on the TagElValueHT tagHt member
1328 * ENH : PrintPubElVal shows (temporarily) both results,
1329 with the tagHt member and the listElem member.
1330 (it's easier to 'see' the problems when using Printheader)
1332 * FIX : old private member LgrElem is now splitted into
1333 ReadLength : Length actually found on disk (updated only
1334 if bug fixing is necessary), for internal
1336 UsableLength : Updated by FixFoundLength, to fix a bug
1337 or to allow Parser going on.
1338 Will allow to re-write a kosher header when a SeQuence
1339 with a length (not 0000) is found
1340 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1341 because gdcmElValSet::Add does not update ListElem
1344 2003-11-07 Jean-Pierre Roux
1345 * FIX misstyping in Transfert Syntax name table
1346 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1347 when they have an actual length (not 0000 nor FFFFF)
1348 (Nobody should care of it, but DICOMDIR explorers)
1350 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1351 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1353 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1354 * ENH: vtkGdcmReader now supports LUT !
1355 (vtkgdcmViewer for now is not able to use them though)
1357 2003-11-05 Jean-Pierre Roux
1358 * in testSuite.py : new files names for checking the package
1359 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1360 that returns the pixel area size to the *aware* (vtk) user
1361 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1363 2003-11-05 Benoit Regrain
1364 * in testSuite.py : Modify the rules for checking the paths
1365 : Explicit error messages
1366 * in __init__.py : Related modif
1368 2003-11-03 Jean-Pierre Roux
1369 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1370 to be used by aware (vtk) users that want to manage
1371 LUT (and no to turn the PALETTE image into an RGB pixels one)
1372 * GetPixelType now returns 8U for 24 Bits images
1373 (vtkGdcmReader compliant)
1375 2003-10-31 Jean-Pierre Roux
1376 * Removal of *all* gdcmData images and add them again
1377 in order to loose the 'history' of un-anonymised images
1379 2003-10-31 Jean-Pierre Roux
1380 * RMV : removal of useless jBitsInJsample.h
1381 for both 8 and 12 Bits JPEG Lossy Libraries
1383 2003-10-31 Jean-Pierre Roux
1384 * ENH : Add the functions gdcmFile::GetImageDataRaw
1385 gdcmFile::GetImageDataIntoVectorRaw
1386 that act as GetImageData and GetImageDataIntoVector
1387 except the making of an RGB Plane from Gray Plane + LUT
1388 Intended to aware (vtk) users who know how to manage
1391 GetLUTRGBA return a R,G,B,A LUT if any
1392 lgrTotaleRaw gives the 'Raw' length
1393 GetImageDataRaw returns the gray Plane
1394 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1395 (They stay Grey, just like with other Dicom viewers :-(
1397 2003-10-30 Jean-Pierre Roux
1398 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1400 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1401 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1402 being coherents dicom files.
1404 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1405 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1407 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1408 * ENH: Two steps is necessary to please VC++ compiler...
1409 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1410 * ENH: Add include dir to medcon lib
1411 * FIX: only one function is being exported for now !
1412 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1414 2003-10-29 Jean-Pierre Roux
1415 * adding gdcmHeader::GetLUTRGBA
1416 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1417 --> Mathieu, the modif u're waiting for is not yet committed
1418 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1420 2003-10-27 Jean-Pierre Roux
1421 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1422 00191113.dcm DermaColorLossLess.dcm
1423 MxTwinLossLess.dcm RadBWLossLess.dcm
1424 * ENH: For version prior to vtkImageViewer2 -r 1.19
1425 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1427 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1428 * Removal of ido stuff in CMakeLists.txt
1430 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1431 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1432 * FIX: remove a call to ->Modified ... see comments
1433 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1435 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1436 * FIX: Problem with path for libvtkgdcmPython
1437 * ENH: Try adding a search script for python site-package
1438 * RMV: Remove some file from medcon lib that are not necessary
1439 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1440 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1441 * FIX: More pragma disable fro VC++,
1442 I don't think I break something as it is also disable in VTK/ITK.
1443 But it fasten debug compilation time.
1445 2003-10-23 Jean-Pierre Roux
1446 * gdcm now deals with 16 Bits Run Length Encoded images
1447 (they are compressed as 2 planes images,
1448 one for the high Bytes, the other for low Bytes)
1450 2003-10-22 Jean-Pierre Roux
1451 * Now CheckRead takes into account :
1452 - the bugged 'Leonardo' Siemens images
1453 - the XA images, sent thru the burning VPRO station
1454 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1457 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1458 * FIX: When copying a Makefile.am to CMakeLists.txt
1459 one should remove the '\'
1461 2003-10-22 Jean-Pierre Roux
1462 * in gdcmData adding a bugged 'Leonardo' Siemens image
1463 (wrong lengths in header)
1464 OK with gdcm, KO with the other viewers :-)
1465 * add a GE dlx XA image, thru the VEPRO burning station
1468 2003-10-21 Jean-Pierre Roux
1469 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1470 for a brutal checking of vtkgdcmViewer compliance
1472 2003-10-21 Jean-Pierre Roux
1473 * add the files for 'xmedcon' Jpeg Lossless library
1474 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1476 2003-10-21 Jean-Pierre Roux
1477 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1479 2003-10-21 Jean-Pierre Roux
1480 * garbage Siemens 'Leonardo' images dealt with
1481 (the patch is easy to remove)
1482 * cosmetic changes to avoid warnings
1484 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1485 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1486 no need to press 'r' now.
1488 2003-10-20 Jean-Pierre Roux
1489 * upgrade of checkRead.sh checkWrite.sh according
1490 to new Jpeg Lossless decompressor
1491 * add US.3405.1.dcm, a genuine RGB medical file ...
1492 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1493 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1495 2003-10-15 Jean-Pierre Roux
1496 * general anonymisation in gdcmData
1497 * adding the 'color files' from
1498 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1499 * adding some well knowed bugged-header images
1500 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1501 waiting for their inclusion in Python testsuite
1503 2003-10-15 Jean-Pierre Roux
1504 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1505 no longer seg faults when file is not found
1507 2003-10-14 Jean-Pierre Roux
1508 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1511 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1512 * TODO: *.in file to genereate a UseGDCM later
1514 2003-10-14 Jean-Pierre Roux
1515 * Some supposed-to-be Dicom Images have no preamble.
1516 OpenFile takes it into account
1517 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1518 * Missing elements added in dicomV3.dic
1519 (just to be affraid : have a look at
1520 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1521 and do it again next year ;->
1523 2003-10-13 Jean-Pierre Roux
1524 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1525 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1526 But there are NOT. It's fixed !
1528 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1529 * FIX: "jpeglib.h" was not found on VC++
1530 * FIX: vtkgdcm was not being installed
1532 2003-10-10 Jean-Pierre Roux
1533 * ENH : OpenFile closes the file if it *really* doesn't look like
1534 an ACR-NEMA / DICOM one.
1535 * FIX : testWrite no longer writes an empty file if the source file
1536 is not gdcm Readable
1537 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1540 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1541 * FIX: CMake generate now documentation
1542 * ENH: out of source doc build !
1543 * ENH: Generate both user and dev documentation
1544 * ENH: Should work on windows too
1545 * ENH: Only one doxygen config.in file is needed
1546 * FIX: make install should be ok now on ùnix plateform
1547 * FIX: PATH to dictionary was wrong (missing /)
1548 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1550 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1551 * vtkGdcmReader is now able to read rgb dicom file.
1552 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1553 * added a gdcmViewer to vtk test, use mouse to control
1554 window level & window width
1556 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1557 * CMake-ification of gdcm, we have now two build system
1558 * FIX: on cygwin Wsock32 doesn't exist
1559 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1561 2003-10-06 Emanuel Ollart
1562 * FIX : compilation process wad broken.
1563 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1565 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1566 * change gdcmViewer -> vtkgdcmViewer
1567 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1569 2003-10-06 Jean-Pierre Roux
1570 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1571 ( e.g : well known GE images with a wrong elem length,
1572 : Philips MRI Images with a wrong Huffman table)
1573 * still to be done : allow the reading of bugged LEONARDO Siemens images
1575 2003-10-03 Jean-Pierre Roux
1576 * Odd length strings are padded with '\0' (not with spaces,
1577 to remain compliant with already defined strings,
1578 like Transfert Syntax UID and others)
1580 2003-10-03 Jean-Pierre Roux
1581 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1582 to allow displaying RGB images (not only by affim ;-)
1584 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1585 * vtkGdcmReader is now able to read rgb dicom file.
1586 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1588 2003-10-03 Jean-Pierre Roux
1589 * A few nasty patches to allow the reading of a lot of nasty images
1590 ( e.g : well known GE images with a wrong elem length,
1591 : Philips MRI Images with a wrong Huffman table)
1592 * still to be done : allow the reading of bugged LEONARDO Siemens images
1594 2003-10-03 Jean-Pierre Roux
1595 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1597 2003-10-03 Jean-Pierre Roux
1598 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1599 to allow displaying RGB images (not only by affim ;-)
1601 2003-10-03 Jean-Pierre Roux
1602 * gdcmFile::GetImageDataIntoVector now
1603 - deals with MultiFrames MultiFragments Run Length Encoded files
1604 - deals with YcBcR (YBR_FULL) files
1605 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1606 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1608 (no sample found :-(
1610 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1611 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1612 Two reasons: - clear things
1613 - third parties acces gdcm through header files, so won't
1614 suffer anymore VC++ complains
1616 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1617 * add argv[1] in testvtkGdcmReader.cxx
1620 2003-09-24 Jean-Pierre Roux
1621 * The lines are now eigthy characters long.for
1622 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1624 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1625 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1626 char* to std::string. Thus, the use of strdup becomes useless. (see
1627 previous commis of Malaterre)
1628 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1629 before the last Malaterre's commit.
1631 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1632 * This commit should fix the Debug building under VC++, the problem
1633 was mainly a mixture of debug and release lib being loaded at startup.
1634 * I also remove a depency to a specific C function: strdup. Because I had
1635 to force the link to msvcrtd (whereas strdup is in libc).
1637 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1638 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1639 located in the gdcmCommon.h file. All use of reference of tha has been
1640 changed to now use the variable GDCM_UNFOUND.
1642 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1644 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1645 Dicom dictionary. The test suite can now be run again. Note:
1646 I'm note very happy with the " (RET)" changes. I believe this
1647 RETAINED comment should be dropped when parsing the dictionary.
1648 - PACKAGER corrected
1650 - AUTHORS updated and now in alphabetical order
1651 * Makefile.am now exports gdcm.dsw for Windoze users.
1653 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1654 * cygwin complains about missing std:: in subdir Test/
1656 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1657 * remove some methods that are now in gdcmHeaderHelper
1659 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1660 * vtkGdcmReader set spacing and origin correctly
1662 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1663 * Fix a few delete/delete[] mismatch
1665 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1666 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1667 interpretation to data given by gdcmHeader. For instance there are
1668 heuristics to get informations (look at different places).
1669 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1670 sorting DICOM images based on different strategies.
1671 * modified Makefiles accordingly.
1673 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1674 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1675 when building in debug mode
1676 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1677 src/win32/gdcmdll.dsp
1678 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1680 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1681 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1684 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1685 * src/win32/libgdcmjpeg12.dsp was not dos format
1686 * src/win32/libgdcmjpeg12.dsp :
1687 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1688 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1690 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1691 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1693 * src/gdcmFile.cxx : bug fix in affectation type
1694 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1695 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1696 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1697 symbols... future problem ?
1699 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1700 * src/win32/libgdcmijpeg12.dsp was missing
1701 * modified gdcm.dsw accordingly
1703 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1704 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1706 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1707 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1708 commit of JPR (before his hollidays to facilitate our work).
1709 * setup.py : bug fix in code. Modifications made while the last commit
1710 of JPR. The code hasn't been tested before the commit... it's so
1711 useless to make that (for best programmer that is JPR) !!!
1713 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1714 * tagged the current version as Version0_3 (i.e. version 0.3)
1716 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1717 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1718 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1719 * *.dsp : modifications to use new libgdcmijpeg8 library
1720 * setup.py : bug fix on VTKPATH variable
1721 * PACKAGER : adding all concerning windows
1723 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1724 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1726 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1727 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1728 test suite reported error.
1729 * PACKAGER file added (describes what a packager must do when
1730 packaging a new release).
1731 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1732 * configure.in: upgraded version number to 0.3.0
1733 * fixing build of rpm (through rpm -ta):
1734 - Doc/Makefile.am exports proper doxygen files
1735 - src/jpeg/libijg8/Makefile.am exports the include files.
1737 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1738 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1739 * src/gdcmHeader.h : formatting code
1741 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1742 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1743 We were obtaining error message from vtk. Now, creation of file list
1744 is made in an internal list to prevent this problem.
1745 Bug fix when output is empty.
1746 Bug fix in update of progress value. Previous commit for this was a bad
1748 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1750 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1751 * src/gdcmHeader.h : added method to get the file name
1752 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1753 files. Added method to remove all files on the input
1754 Added FIXME comment concerning the bad parsing of header made by
1755 ExecuteInformation method (in ExecuteData method)
1757 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1758 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1759 when using make instal.
1760 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1761 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1763 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1764 * setup.py : adding include dir of jpeg lib to compile all sources
1765 * */Win32/*.dsp : JPR fix for windows compilation
1767 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1768 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1770 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1771 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1773 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1774 * setup.py is again effective on un*x (takes into account the
1775 addon of the jpeg library)
1776 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1777 * Doc/Doxy* updated (includes above enhancements)
1778 * INSTALL now points to web documentation
1780 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1781 * src/gdcmHeader.h doesn't make unnecessary reference to
1783 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1785 * src/gdcm*.[cxx|h] :
1786 - to allow compilation with gcc 3.x
1787 -- clean up of STL usage (added explicit usage of std::)
1788 -- small fixes on exceptions.
1789 Note: linking not tested !
1790 - clean of doxygen comments to avoid warnings at documentation
1792 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1793 dependent convertion).
1795 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1796 * Clean up of previous JPR garbage commit (not even commented in the
1798 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1799 - moved all jpeg related files from src to src/jpeg/libijg8, with
1800 addition/modification of Makefile.am and configure.in.
1801 - the testSuite is still brain damage (not guilty).
1803 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1804 * WrapVTK.py : modifications to get correctly vtk source files to
1806 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1807 (FileName -> Filename)
1809 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1810 * vtk/vtkGdcmReader.[cxx/h]:
1811 - UpdateProgress method should now be effective
1812 - removed the limitation on having only images loaded (as opposed
1814 - when building a stack of images/volume, a lesser number of
1815 gdcmHeader and gdcmFile instances should be used (hopefully
1816 accelerating things).
1817 - when building a stack of images/volumes, files which are not
1818 loadable (wrong path-filename, wrong permissions on existing file,
1819 or file not parsable by gdcm) are replaced with a black image
1820 in the stack (for the caller to notice the problem).
1822 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1823 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1825 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1826 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1827 between standard library (std) and vtk library (problems are found
1828 under Windows... thanks Windows !)
1830 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1831 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1833 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1835 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1836 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1838 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1839 * When compiling with distutils (see setup.py) the C++ compiler is
1840 called with different flags than the default ones (with automake).
1841 In order to fix all those warning, I compiled gdcm with the command
1842 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1843 and went for warning fixes:
1844 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1845 up from unused variables.
1846 - vtk/vtkGdcmReader.cxx: potential bug fix.
1847 * src/gdcmHeader.h: Doxygen warning cleanup
1849 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1850 * gdcmPython/gdcm.i:
1851 - typemaps correction to take into account the systematic replacement
1852 of "using namespace std" with std:: prefix e.g. std::list,
1853 std::string... (cf changes of 2003-05-21).
1854 - gdcmGlob global variable of type gdcmGlobal (defined in
1855 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1856 exported to Python a as cvar.
1857 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1858 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1859 gdcmDictSet.GetPubDictTagNames() and
1860 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1861 C++ static methods).
1862 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1863 with the above changes.
1865 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1866 * setup.py, manifest.in : bug fix under linux
1868 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1869 * Modification of setup.py to compile vtk part too. Then, we have 2
1870 wrappers which must work with same distutils. For that, we have a
1871 generic distutils in distusiltsWrapping.py ; with :
1872 - build_extWrap class to wrap generically all extensions,
1873 - ExtensionWrap base class for all wrapping extension that contains
1875 - Wrapper interface which wrap sources
1876 + In WrapSwig.py we have extension and wrapper for Swig
1877 + In WrapVTK.py we have extension and wrapper for VTK
1878 * MANIFEST.in : modifications to consider vtk directory and new python
1879 files for compilation
1881 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1882 * Added python wrappers of vtkGdcmReader vtk class (see the
1883 source in vtk/vtkGdcmReader.cxx) :
1884 - vtk/Makefile.am now builds a library
1885 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1886 python library (as opposed to _gdcm.so wich are the python
1887 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1888 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1890 - configure.in has an additional flag --enable-vtk that needs
1891 to be set to enable compilation of vtk related code, that is:
1892 + vtk/vtkGdcmReader.so and
1893 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1894 + gdcmPython/vtkgdcmPython.so (see above)
1895 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1896 be read when compressed or when HighBit + 1 != BitsStored),
1897 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1898 the usage of the python wrapper of vtkGdcmReader vtk class.
1899 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1900 * src/*.[h] all occurences of stl classes are now prefixed with
1901 std::, and all occurences of "using namespace std;" where removed.
1902 This is to avoid pollution of global namespace in included files.
1903 Apparently vtk does not avoid this pitfall: when using both
1904 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1905 collision of various stl members (principally cout...).
1906 * gdcmPython/testSuite.py now cleanly removes temprory generated
1908 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1909 comply with above changes)
1911 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1912 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1913 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1914 vtk data structure (an image Flip was required).
1915 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1916 * cosmetic changes in documentation.
1918 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1919 * src/gdcmHeader.cxx: the constructor no longer exits when an
1920 unexisting file is given as argument.
1921 * The subdirectory Data (containing all the images used for the
1922 test suite) is not part of this repository anymore. A new module
1923 containing those images is now available at
1924 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1925 with the name gdcmData.
1926 All the python scripts (including the package initialisation file
1927 gdcmPython/__init__.py) were adapated to take this change into
1928 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1930 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1931 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1932 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1933 demo of the usage of this class.
1934 Compilation of this vtk part is only done when using the --enable-vtk
1935 at configure (or autogen.sh) stage.
1937 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1938 * More memory link related corrections and documentation fixes.
1940 - maximum info is obtained with a command of the form:
1941 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1942 --show-reachable=yes PrintHeader
1943 - the remaining reachable blocks seem to come from the STL
1944 allocation scheme through the usage of map and list. It looks
1945 like this memory cannot be freed but it is not a memory leak
1946 (in fact further invocation to the STL would recollect the
1947 unused memory allthough it cannot explicitely be freed).
1948 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1949 of displaying an image parsed with gdcm and displayed with VTK.
1950 Note: some images don't seem to work e.g.
1951 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1952 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1953 Allthough this weakens the semantics, it is a ditch attempt to
1954 make gdcm more thread friendly.
1956 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1957 * Memory link hunt (by using valgrind through the command
1958 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1959 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1960 gdcmHeader::_dicom_vr.
1961 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1962 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1964 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1966 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1967 * src/Makefile.am now exports all the necessary include files at
1971 * UpdateGroupLength replaced by new one
1974 * UpdateGroupLength re-written using H-Table
1975 (named UpdateGroupLengthNew untill checks are over)
1977 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1978 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1979 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1981 - gdcmHeader::GetPubElValSet removed.
1982 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1983 UpdateGroupLength, WriteElements, Write.
1984 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1985 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1986 carried the same semantics.
1987 - src/gdcmHeaderIdo.cxx changed accordingly.
1988 - gdcmFile::WriteBase now regroups all the codes from previous
1989 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1990 - enum FileType moved to gdcmCommon.h
1991 * src/gdcmHeader.cxx AddDefault trashed
1992 * gdcmGetXSize added
1993 * getimageDataSize now calls gdcmGetXSize
1994 * Test/*.cxx changed to agree with above changes
1996 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1997 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1998 (to avoid double call by end user).
1999 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2000 by end user, since gdcmHeader::gdcmHeader now handles it.
2002 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2003 * gdcm/Doc many doxygen changes:
2004 - Doxyfile now has two different versions, DoxyfileUsers that generates
2005 the html.users end users oriented documentation and
2006 DoxyfileDeveloppers that generates the html.developper developper
2007 oriented documentation.
2008 - README changed accordingly
2009 - requirement.txt removed (old design info moved to TODO).
2010 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2011 DoxyMainPage.txt, DoxyPython.txt provide more information.
2012 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2013 be updated by simply regenerating the docs with doxygen and copying
2014 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2015 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2016 all the tests in the form "if (<map>.count() >1)" were removed.
2017 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2018 ill-formed documentation sections.
2019 * src/gdcmHeader.cxx: ditto
2021 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2022 * setup.py fixed for un*x (needed macro for stdint.h)
2023 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2024 un*ces with sh-utils test utility.
2025 * gdcmPython/demo/test.py renamed to PrintHeader.py
2026 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2027 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2028 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2029 * src/gdcm*.cxx JPR's bad inclusion fixed.
2031 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2032 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2033 * gdcmPython/demo/test.py changed accordingly.
2035 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2036 * gdcmPython/Makefile.am fixed linking against libstdc++
2037 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2038 * Swig subdir (historical tests of swig version 1.3.17++) removed
2039 * Test/testChangeEntete.cxx some lines commented out in order to make
2041 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2042 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2044 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2045 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2046 hence the user doesn't need this explicit call.
2047 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2048 i.e. LoadElements() call removed.
2049 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2050 - src/Makefile.am declares the proper flag for g++.
2051 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2052 for adding user defined new tags.
2053 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2054 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2055 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2057 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2058 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2059 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2060 src/Makefile.am : the project should properly compile and install
2061 with the autotools, included the python wrappers part.
2062 * gdcm.spec.in : added a spec file for RPM packaging.
2064 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2065 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2067 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2068 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2069 to exported to the environement (see gdcmPython/testSuite.py
2071 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2072 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2073 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2074 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2075 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2077 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2078 * gdcmPython/__init__.py doesn't crash anymore when running in
2079 in InstallMode or PreInstallMode but with an environement given
2080 value of GDCM_DICT_PATH.
2081 * src/gdcmDictSet.[cxx/h] coding style.
2083 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2084 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2085 * src/gdcm.h general comments moved to TODO, and README
2086 * src/gdcm.h should now be seen as a user commodity (including it
2087 should suffice to fully use gdcm). It is nowhere including within
2088 any of the kernel files src/*.cxx and src/*.h.
2090 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2091 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2092 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2094 * src/gdcm*.cxx only include their corresponding include file
2095 (as opposed to gdcm.h)
2096 * gdcmPython/gdcm.i changed accordingly
2097 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2098 the autogen.sh generated "make snapshot" command to work.
2099 * autogen.sh removed history related references to crea package.
2101 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2102 * distutilsSwigCPlusPlus.py work around some swig portability
2105 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2106 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2107 was done in a last ditch attempt to get setup.py _really_
2108 operationnal. The python/gdcmPython layaout add the advantage
2109 of hidding away the python related distutils specific files
2110 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2111 Alas, the src directory was out of scope (i.e. it's relative
2112 position to setup.py was ../src) which made things impossible to
2113 handle (see previous version of python/setup.py). Crossing fingers...
2115 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2116 * python/setup.py now works on Un*x. (harder than I thougth)
2117 * python/distutilsSwigCPlusPlus.py can now have include files
2118 among the list of sources.
2120 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2121 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2122 * modifications in MSVC projects
2124 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2125 * As stated by the first lines of Test/ExceptionAndPython/README, it
2126 looks like we can move back to original usage of exception within
2127 src/gdcm* and hence remove the errno stuff that was introduced
2128 as a quick and dirty fixture of this problem (added to the TODO).
2129 * Doc/Doxyfile configuration file for Doxygen and corresponding
2130 README file for usage added.
2131 * Test/testWrite.cxx added. This new test comes from a split of
2132 test.cxx that is now reverted to its original purpous i.e.
2133 testing the proper parsing of a Dicom related file.
2134 testWrite.cxx concentrates on testing the IO part of gdcm.
2135 * Test/bug1.cxx (containing a bug on WIn32) added.
2136 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2137 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2138 whose purpose is to publish the content of the TagNames of the
2139 Dicom public dictionnary were not accessible without an
2140 instance of class gdcmHeader.
2141 - those methods are now static methods of gdcmDictSet and hence
2142 require no instances at all to be invocated.
2143 - within gdcmDictSet this change required to change some method
2144 to class methods (i.e. are now static) among which SetDictPath
2145 (renamed to BuildDictPath) and LoadDefaultPubDict.
2146 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2147 the above changes by calling the new method classes of gdcmDictSet.
2148 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2149 the above to be effective.
2150 * python/gdcmPython: in order to wrap properly the above changes
2151 for Python, swig version now needs to be > 1.3.17.
2152 * python/gdcmPython/Makefile fixed to adapt itself to new
2153 configure/make shema introduced by Johan Montagnat (thanks for the
2154 contribution). Alas this Makefile cannot be turned into a proper
2155 Makefile.am without some heavy changes in the configure.in
2156 (for python dectection).
2157 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2158 now avoids publishing the empty entries.
2160 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2161 * python/setup.py : bug fix concerning install under windows
2162 ExtraPath reused :-P
2163 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2165 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2166 * Dicts/dicomV3.dic : remove double spaces !!!
2167 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2168 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2171 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2172 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2173 method. Doxygenation.
2174 * src/gdcm.h clean up of JPR spurious comments.
2176 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2177 * python/distutilsSwigCPlusPlus.py now properly collects the
2178 shadow classes generated by "swig -c++" (gdcm.py in our case)
2179 when using "python setup.py install".
2180 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2181 reexports the working classes.
2182 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2183 by the classical C errno scheme. This is to prevent an obscure
2184 behavior of the python wrappers when importing wxPython.wx prior
2185 to gdcmPython (which ended up in an abort call). An illustration
2186 of this oddity can be found in the Test/ExceptionAndPython
2187 subdir (see the README file). This problem probably due to
2188 an combination of g++ and dynamic loading.
2189 * added Test/ExceptionAndPython (see above)
2191 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2192 * Changed the layout of the python part to avoid bloating main
2193 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2194 i.e. the distutils arsenal. All the python related stuff is
2195 again in a python subdir, but the package itself is now in
2197 * setup.py was cleaned up:
2198 - pythonIncludePath removed
2199 - python setup.py bdist target is now functional.
2200 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2201 collision with other packages). gdcmPython/demo/*.py changed
2204 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2205 * python subdir moved to gdcmPython (preparation of distutils packaging).
2206 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2207 distutils installer is operational.
2208 * - gdcmPython/__init__.py now properly loads the swig generated
2209 shadow classes (from gdcm.py).
2210 - gdcmPython/demo/*.py changed to import the package gdcmPython
2211 instead of gdcmPython/demo/load.py.
2212 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2214 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2215 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2216 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2217 entries within the associated public Dicom dictionary resp. the same
2218 information but sorted by the fourth field (PAT, IMG, DIR) of the
2220 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2221 are now in the "???" group.
2222 - python/gdcm.i changed accordingly,
2223 - python/demo/printGroupedPublicDict.py added, that gives an example
2224 of the above new functionalities in Python.
2226 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2227 * src/gdcm.h, gdcmHeader.cxx:
2228 - historic references to glib's g_malloc and g_free (#defined)
2229 were definitively removed.
2230 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2231 * src/gdcmElValSet.cxx:
2232 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2233 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2234 - GetElValue(string) renamed to GetElValueByName.
2235 - Added GetElementByName(string).
2236 * src/gdcmHeader.cxx: added
2237 - GetPubElValRepByNumber(guint16, guint16)
2238 - GetPubElValRepByName(string)
2239 - GetShaElValRepByNumber(guint16, guint16)
2240 - GetShaElValRepByName(string)
2241 - GetShaElValByNumber(guint16, guint16)
2242 - GetShaElValRepByName(string)
2243 - GetElValRepByNumber(guint16, guint16)
2244 - GetElValRepByName(string)
2245 - GetElValByNumber(guint16, guint16)
2246 - GetElValRepByName(string)
2247 * Doc/requirements.txt added.
2249 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2250 * Test/Makefile building now depends on the one of libgdcm.so
2251 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2252 pixel data) aware which enables finding the address (offset) of
2253 the pixel data of JPEG encoded DICOM files. This leaves only a single
2254 file in the testSuite whose pixel data address (offset) is unknown.
2255 * python/testSuite.py changed accordingly.
2257 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2258 * VC++ has some strong limitations when working with the STL, as stated
2259 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2260 "Also note that some STL containers (map, set, queue, list, deque)
2261 cannot be exported. [...]
2262 Some STL classes contain nested classes. These classes can not
2264 This is caused by a designed limitation that once a template
2265 class is instantiated, it can not be re-instantiated and
2267 Since our usage of map<> is ubiquitous in gdcm, this "designed
2268 limitation" of VC++ is a pitfall.
2269 Hence the Python wrappers of gdcm cannot be incrementally linked
2270 against the c++ dynamic library. The dirty but only workaround is
2271 to forget about incremental link of dynamic libraries and to generate
2272 the Python wrappers library with the inclusions of the underlying C++
2274 The following modifications concern this matter on Win32/VC++:
2275 - wrapping python correct with standalone wrapped dll (don't use separate
2276 dll under windows !!!!)
2277 - python21_d debug mode enabled (ask Frog how to use it :-)
2278 - NO problem with having an STL member of class for example string in C++
2279 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2280 - Python test of dcmlib in Python is ok under windows on a large set
2282 * removed glib references
2283 * typedef's inserted in gdcm.i for correct swig type management
2285 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2286 * python/demo/*.py load.py extracted from test.py. Added explore.py
2287 that only displays required tags and testAll.py that parses all
2288 the files of the testsuite without using unittest.
2289 * python/testSuite.py other additional test on new files added.
2290 * Data/* new test files added accordingly to the testSuite.
2291 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2292 the vr in the file differs from the one of the dictionary.
2294 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2295 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2296 values, but limits itself to values which are below a user specified
2297 size (by default 1024 bytes).
2298 * python/gdcm.i : elements not loaded (because their size is above the
2299 user specified treshold) are exported with their TagKey as key of the
2300 python dictionary. This enables the testsuite to make some checks
2301 on the unloaded elements (since we have their offset and size).
2302 * python/testSuite.py
2303 - now tests for the existence and proper value of the pixel data
2304 - two new examples added.
2305 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2307 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2308 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2309 aware. See the strategy comments in gdcmHeader::FindeLength().
2310 * Test/test.cxx now accepts a filename as first argument.
2311 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2312 * python/testSuite.py changed to integrate test on above files.
2314 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2315 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2316 the vr was also RET.
2317 * python/testSuite.py more tests added.
2319 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2320 * python/testSuite.py unittest test suite added (uses Data)
2321 * Data/* dcm and acr files for the test suite.
2322 * glib dependance removed from un*x version. We now use ISO C99
2323 7.18 Integer types (see stdint.h)
2324 - python/Makefile, src/Makefile src/gdcm.h
2325 * src/ when an explicit vr (like dicom files) suddenly poped an
2326 implicit element we use to mark the underlying DictEntry of the
2327 concerned ElValue with "Implicit". This strategy was damageable
2328 too the public or provite dictionaries, since some of their vr
2329 would be changed. Since Header::FindLength heavily relies on the
2330 detection by Header::FindVR of falsely explicit elements, I
2331 added an extra ImplicitVr member to ElValue (boolean).
2332 The rest of the changes we the necessary adaptations.
2334 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2335 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2337 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2339 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2340 * Adaptation for porting to VC++:
2342 o forced to use std namespace (for string to be known)
2343 o all class use __declspec export style on WIN32
2344 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2345 (in stdlib.h on Win32 but in std:: for gcc)
2346 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2347 variable GDCM_DICT_PATH.
2348 * src/gdcmHeader.cxx verbose comments made discrete.
2350 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2351 * python/gdcm.i: added a typemap that converts a C++ hashing table
2352 to native Python dictionary.
2353 * python/demo/test.py:
2354 - now uses the native dictionary for exploration of gdcmHeader.
2355 - takes an optional filename argument (the file to parse).
2356 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2357 PubElVals hashing table.
2358 * Dicts/dicomV3.dic removed error prone trailing spaces.
2360 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2361 * Python wrapping process moved away from src/Makefile to
2362 newly created python/Makefile (as well as gdcm.i)
2363 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2364 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2365 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2366 from the environement variable GDCM_DICT_PATH (when existing).
2367 * src/gdcmDict::GetTag bug fix.
2369 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2370 * Straightforward temporary fixes for swig to build the python wrappers.
2371 src/Makefile now has a python working entry [by working we mean
2372 that we can import de shadow classes without errors].
2374 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2375 * hashtest.cxx removed (since allready in Test)
2376 * src/gdcmlib.h renamed to src/gdcm.h
2377 * src/dcm.i renamed to src/gdcm.i
2378 * src/Makefile prepared for python wrapping
2380 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2381 * src/gdcmHeader.cxx :
2382 - Parsing of header is now separated from loading of element values
2383 (see gdcmHeader::LoadElements).
2384 - general clean up of hopefully all file access (creation of
2385 ReadInt16 and ReadInt32)
2387 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2388 * src/gdcmHeader.cxx :
2389 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2391 - SetLgrElem renamed to SetLength
2392 - GetLgrElem renamed to GetLength
2393 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2394 * src/gdcmElValSet.cxx fixed both GetElValue methods
2395 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2396 due to IdoDude was cleaned out.
2398 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2399 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2400 concentrates on finding the value representation (when it exists).
2401 RecupLgr now only finds the element value length, and it avoids
2402 returning the unecessary skL (skipped length).
2403 Also, offsetCourant was simply removed (with taille_fich) since
2404 it was redundant with the File position internals (by using
2405 ftell and fseek). This also made skL (see above in RecupLgr) usage
2407 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2408 on the libido specificities which are handled through class
2410 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2413 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2414 * Truckload of changes. Parsing of header is barely functional
2415 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2417 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2418 * src/gdcmHeader.cxx many addons of low level methods
2420 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2421 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2422 and _IdDcmSWAP_LONG.
2424 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2425 * This corresponds to all the changes decided at the meeting of
2426 May 23 2002. Needless to say we are running late...