1 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmHeader.cxx : change the initialisation of default header.
3 Now, this header is readable by gdm, e-film, DicomWorks
5 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
7 Rename Decompressed to Raw
8 * Use the API changes in gdcm::File.
9 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
12 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
13 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
14 each added entry in the header. Replace the 'Planes' field by the 'Number
17 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
18 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
19 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
21 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
22 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
23 At this time, this image isn't readable by e-film... waiting JPR help to
26 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
27 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
28 DocEntry. Now use methods of the Document !
30 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
31 * Test/ShowDicomSeq.cxx : bug fix
33 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
34 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
35 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
36 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
37 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
39 * Test/TestCopyRescaleDicom.cxx : remove unused variable
40 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
41 containing found sequences
43 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
44 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
46 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
47 Some fields in BinEntry must be copied to not seg fault when making the :
48 gdcm::File *copy = new gdcm::File( copyH );
49 and tests are now made on good variables
51 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
52 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
53 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
55 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
56 * Add vtkGdcmWriter example and test
58 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
59 * Test/TestUtil.cxx : reformat the source code
60 * vtk/vtkGdcmReader.cxx : remove and change prints
61 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
63 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
64 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
66 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
67 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
68 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
70 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
71 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
72 by an eof to prevent all bad read of the file... and in this case, the
75 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
76 * Example/Volume2Dicom.cxx : comment unused variables
77 * Test/PrintDicomDir.cxx : comment unused variables
78 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
79 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
80 method that is redondant with AddEntry.
81 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
84 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
85 * Bug fix due my last commit (compilation under Windows).
86 * Example/Volume2Dicom : bug fix in the file and reformatting source code
87 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
89 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
91 - Remove printf / sprintf
92 - include iostream AFTER gdcm so we don't get warnings
93 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
95 - Also remove tons of include from header files, hopefully this should
96 speeup the compilation time, since it was becoming a dog slow.
97 - Remove gdcm.h as it include way too many files and slow down compilation
98 (plus it is not up to date)
99 - remove 'using namespace std' this is BAD !
101 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
102 * Remove memory leaks on the DicomDir
103 * Remove some useless datas in DicomDirObject
104 * Add usefull methods in SQItem, to be complient withe the ElementSet
106 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
107 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
109 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
110 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
111 future, with convertion)
112 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
113 and ImageDataSize values. Remove the method to get the PixelReadConverter
114 from the output of the class
116 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
117 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
119 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
120 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
121 and vtkErrorMacro use.
122 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
124 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
125 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
127 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
128 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
129 The string leaves only in the fonction. So when we make a .c_str(), we
130 get the pointeur on the first element, element that will be destroyed
131 immediately after thee instruction.
132 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
133 file has been opened : the test must be made on the content of the
134 pointer and not directly on the pointer !
137 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
138 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
139 the python part recompiles
141 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
142 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
143 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
144 X session is killed (for my computer... it seems to not be identic on
147 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
148 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
149 avoid problems (otherwise, the difference test between the visible image
150 and the reference is incorrect. If the reference is greater than the
151 screen resolution, it's produce errors).
152 Can be used for only one image. Can be used with a visible flag.
153 * vtk/vtkGdcmReader.cxx : remove commented codes.
154 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
155 under windows at compilation
156 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
158 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
160 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
161 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
162 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
163 tests on the image size X, Y, Z
165 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
166 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
167 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
168 between the class name and the file name
170 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
171 * src/ : fix compilation warnings for the Write method (2 different
172 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
173 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
174 variable... create a static method in gdcm::Document to access to
175 this variable content.
177 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
178 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
179 file, to be accessed by other files (like gdcmFile). Remove commented
180 code. Move the change of the header to the gdcmFile, using the
182 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
183 To be sure of that (and simplify calls), the Write of the header now
184 gets a file name and not a file pointer (std::ifstream).
185 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
186 DocEntryArchive. Remove all open of the written file
188 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
189 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
191 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
192 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
193 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
195 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
196 some corresponding methods. Write correctly the file and check before
198 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
199 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
200 is now on RGB datas (as before my last commit
201 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
203 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
204 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
205 Add a print information of the type of the entry
206 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
207 It was in the gdcmFile, and all write have been regrouped
208 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
209 Write correctly all dicom files (in decompressed mode only at this time)
210 * Test/ : test on files are now made using Raw datas and not color datas if
212 * Example/PrintFile.cxx : add more printings
214 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
215 * Amelioration of code, remove some code copy. For the loading of
216 BinEntry (in gdcmDocument), add the test to verify if the file is already
219 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
220 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
221 remove a DocEntry in the header (push an empty DocEntry)
222 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
223 lines. Bug fix in the initialization of the PixelConvert and the
225 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
226 use in TestCopyDicom (now this test can run under windows... but fails)
227 * Test/TestCopyDicom.cxx : amelioration of the test :
228 - test the pixels written
229 - add test points to quickly find where is the error
230 - can set a file name input and output in arguments
231 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
232 amelioration of the test output
234 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
235 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
236 all replaced DocEntry's
237 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
238 Now, each needed DocEntry to modify is duplicated, modified and inserted
239 to the header using DocEntryArchive. Thus, after save, we can restore the
240 header initial state.
242 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
243 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
245 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
246 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
247 correct to copy it. The DictEntry is specified at the DocEntry creation,
248 then, it musn't change in the time.
249 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
250 header correctly. At this time, the change is only made for the first
251 level of the Document. In the future, it might consider sequences.
252 The change is made by replacing a DocEntry by an other that is created
253 outside the class. The old value is kept. When we restore the header
254 status, the added DocEntry is deleted and replaced by the old value.
255 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
256 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
257 set the write type to explicit VR, implicit VR or ACR. Add methods to set
258 the write mode to native, decompressed or RGB (but not used at this time)
260 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
261 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
262 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
264 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
265 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
266 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
268 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
269 set because already copied when copying the BinEntry's of the header
270 * Test/TestAllReadCompareDicom.cxx : remove warnings
272 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
273 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
274 Two problems appear when doing it :
275 - with the gdcmFile : when the GetImageData method is called, the pixels
276 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
277 datas (pixels). And each structure destruct the datas when it's
278 destructed. So we have two destructions for the same datas. To solve it,
279 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
280 datas or not. If it doesn't own datas, then they will not destroyed by
282 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
283 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
284 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
285 create a double destruction of the same DocEntry's. So, to solve it,
286 the TagHT is simply cleared and the DicomDir* elements are destroyed.
287 * TODO : add an entry concerning memory leaks in the DicomDir
289 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
290 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
291 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
294 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
295 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
296 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
297 after it have been deleted
299 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
300 * FIX: src/* fix the doxygen warnings.
301 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
302 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
303 was erroneously defined with a size of 15 instead of 16. [many thanks
304 to Jean Michel Rouet for pointing out this bug].
306 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
307 1. Finish merging JMR patch for writting DICOM from scratch
308 2. Fix -hopefully- bug with MONOCHROME and space vs null character
309 3. Use const ref when possible
310 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
311 5. A few more comments
312 6. CreateUniqueUID can now be called without parameter"
314 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
315 * ENH: Slightly bigger patch:
316 1. Getting toward full integration of JMR patch for writting dicom from scratch
317 2. Update Test to test part of this patch: CreateUniqueUID
318 3. File was not close properly in gdcmDict
319 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
320 5. Use of const ref instead of copy (speed issue)
321 6. Remove temporary (duplicate) string in TranslateToKey
322 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
323 8. Do not repeat virtual in subclasses
324 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
326 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
327 * Apply first patch toward better string comparison when dealing with broken
328 DICOM files. Essentially the string could be padded with a space instead
329 of a null character as defined by standard
331 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
332 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
333 because never used... and in the same time, that's remove some memory leaks
335 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
336 * src/gdcmFile.cxx : now delete the PixelConvert instance.
337 * In examples and tests : change the type of image data variables from void*
338 to uint8_t*. Remmove all delete on image data variables
340 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
341 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
342 Verify the file pointer value before open the file, and if it's not null,
343 a verbose message is generated.
344 Close correctly the file when the file isn't considered dicom-like. The
345 correctly close is a call to CloseFile.
346 When closing the file pointer, test if its not null to close the file.
347 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
348 file. For an uncompressed image, the copied datas correspond in the least
349 case to the image size (calculated) or the image size specified in the
350 header. A verbose is generated if these two size mismatch
352 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
353 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
354 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
355 break under windows (with msvc6 compilation).
357 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
358 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
359 compiling with MSVC6)
361 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
362 * Bugs fix for the Windows build with VC6
363 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
364 needed (only for projects required VTK). If the VTK is included in all
365 projects, there is conflicts with the jpeg lib of vtk when compiling the
366 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
367 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
368 when compiling the gdcm_wrap.cxx file (created by the compilation of the
370 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
371 (like it's already made for the cout use). Otherwise, conflict with the
374 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
375 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
377 - comments on the DicomDir::Method related usage added.
378 - now that we use the namespace gdcm, a lot of internal classes do
379 NOT need to be wrapped anymore.
380 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
381 DicomDir::Method) new example added.
383 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
384 * Improve string manipulation. I now inforce the notion of 'DicomString'
385 A DicomString can contain as many \0 as they want
386 and it is *always* of even length.
387 We only support odd length for very rare case.
388 And in the near future this should be removed.
390 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
391 * /binary_write/ gdcm source. Now even on big endian we are writting
392 little endian. This should -heopfully- fix some tests
394 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
395 * Now the dictionary is compiled into gdcm lib. This is a default
396 behavior, thus any dic file specified is picked before failback to
397 the one comiled into lib
399 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
400 * Change internals for gdcmDict. Don't use any 'new' any more.
401 This should definitely solve any leak problem, and we should be
402 as fast as before, as long as don't modify too much the dictionary.
404 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
405 * STYLE: ivars should start with a capital letter.
406 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
407 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
409 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
410 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
411 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
412 new 2004 dictionaries added (thanks to JPR).
413 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
414 * CLEANUP_ROUND (15) for gdcmPixelConvert
415 - RLEFrame::NumberFragments is now of type unsigned int
416 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
417 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
420 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
421 * Initial work in gathering all transfer syntax accessors. clearly
422 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
423 ivars, but only one transfersyntax (class) ivar with equivalent method on
426 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
427 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
428 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
429 discussed (plus I didn't like having a 2000 lines patch not commited)
431 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
432 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
433 * CLEANUP_ROUND (14) for gdcmPixelConvert
434 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
435 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
436 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
438 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
439 anymore and hence avoids storing a copy of PixelConvert::Decompressed
440 into File::Pixel_Data.
442 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
443 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
444 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
445 * CLEANUP_ROUND (13) for gdcmPixelConvert
446 Substituted File::ParsePixelData() with PixelConvert::Print() new
448 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
449 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
450 method to those classes.
451 - src/gdcmFile.[cxx|h]:
452 -- Added a ::Print() method.
453 -- PixelConverter is now a reference instead of a member.
454 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
455 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
457 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
458 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
459 collaboration diagram and inheritance diagram should be generated with
461 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
462 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
463 pointlessly wrapped (see
464 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
465 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
466 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
467 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
468 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
469 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
470 -- File::Initialise: PixelConverter setup moved away to
471 PixelConverter::GrabInformationsFromHeader()
472 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
473 interpretation moved away to PixelConverter::BuildRGBImage()
475 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
476 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
477 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
479 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
480 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
481 displayed on Win32 when a brutal abort() occurs (because of uncatched
482 exception). See TODO new entry of this commit for more on this.
483 * TODO added new entry.
484 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
485 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
486 - HandleColor is no longer called from gdcmFile.cxx
487 - gdcmPixelConvert.cxx clean up on method arguments and internal
488 variable names for semantical coherence.
490 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
491 * Finished lossless transition, not only do we now read all lossless jpeg
492 images, without the need of the Cornwell lib, but we do read them properly now
493 * To reduce code (well to avoid code duplication), I defined a common place
494 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
495 redefine symbols. This is not prefect but this the best solution I found for a
496 compilation time jpeg option.
498 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
499 * Update jpeg ijg lib to support lossless jpeg implementation
500 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
502 * Also added a special copyright for dcmtk since we use their bugfixes.
505 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
506 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
507 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
508 matters, as stated in warning note at begining of %include section).
509 * src/gdcmDicomDir*.[cxx|h]: coding style
510 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
511 * src/gdcmJpeg8.cxx: doxygen fix.
512 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
513 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
514 from File:: to PixelConvert::.
516 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
517 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
518 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
519 - more code moved away from File:: to PixelConvert::
520 - fat setup of PixelConverter set in place in File::Initialise.
522 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
523 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
524 namespace at the file system level. So now you should convert your examples
526 gdcmHeader -> gdcm::Header
527 It would be nice if people keep in mind to no open the namespace, since it
528 allows compilation on broken plateform which were defining common symbol in
529 the standart namespace (like LP, Unknown ...)
531 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
532 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
533 The JPEG fragments are now parsed at the same stage than the RLE
534 information. All code related to JPEG is now in gdcmPixelConvert:
535 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
536 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
537 export a gdcmFile:: method. Those are simply global functions
538 (for the time being this is better than having them attach to
539 either gdcmFile:: or gdcmPixelConvert::).
540 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
541 and stores the result in a gdcmJPEGFragmentsInfo.
542 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
543 code (among other stuff) moved away from gdcmFile:; to
546 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
547 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
548 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
549 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
550 clean up of RLE related code.
551 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
552 - src/gdcmRLE.cxx removed
553 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
554 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
555 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
556 * CLEANUP_ROUND (9) for gdcmPixelConvert
557 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
558 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
559 away from gdcmFile:: to gdcmPixelConvert::.
561 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
562 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
563 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
564 This is because Parse7Fe0 used to parse the pixels to compute the
565 length. This task was passed over to FindDocEntryLengthOB() a long
566 time ago, EXCEPT I had forgotten the OW case...
567 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
568 we just recylce the code for parsing RLE fragments and computing
570 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
571 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
572 with the retired Parse7Fe0().
573 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
574 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
576 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
577 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
578 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
579 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
580 - src/CMakeLists.txt: alphabetic order reodering + new entries.
581 * CLEANUP_ROUND (4) for gdcmPixelConvert
582 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
583 to return an unused length.
585 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
586 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
587 this should be cleanner from the plane view. The iostream are erally a pain
588 to use to do simple stuff.
590 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
591 * Redo the compilation of the ijg jpeg library. Now only one source is
592 necesseray. No need to rename file by hand what so ever. CMake handle the
593 copying of the file within different directory, configure header file to
594 modify some symbol. The only addition made to ijg wasd a mangle table so
595 that symbol are different wether we are within 8bits or 12bits.
597 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
598 * Added documentation of vtkgdcmReader on Website:
599 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
600 with it's binary name).
601 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
602 the Website to be more complete.
603 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
604 doxygenated documentation.
605 - Doc/DoxyVtkGdcmReaderExamples.txt added
606 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
607 DoxyVtkGdmReaderExamples.html )
608 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
609 * CLEANUP_ROUND (3) for gdcmPixelConvert
610 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
612 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
613 * CLEANUP_ROUND (2) for gdcmPixelConvert
614 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
616 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
617 * CLEANUP_ROUND for gdcmPixelConvert:
618 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
619 - src/gdcmPixelStuff[h|cxx] removed
620 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
621 - src/CMakeLists.txt changed accordingly
623 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
624 gdcmVersion.py moved to newly created ATTIC related
625 gdcmPython/SetupOldies/ directory.
626 * Autotools clean up:
627 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
628 - autogen.sh configure.in acinclude.m4 python.m4 removed
630 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
631 * src/*.cxx *.h Reference to License.htm fixed to License.html.
632 * Doc/CMakeLists.txt, doxygen.config.in: fix.
633 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
635 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
636 * TODO updated with Mathieu suggestions. I proposed a template for
637 describing TODO entries and used it for new entries.
638 * Added Doc/Website/CodingStyle.html, Developpers.html,
639 DeveloppersPython.html, GdcmDataCvs.html and
640 DownloadVersion0_1.html, DownloadVersion0_3.html.
641 * Some Doc/*.txt Doxygen files (which do not really concern the
642 documentation itself, but the website) moved to html and
643 placed in directory Doc/Website:
644 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
645 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
646 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
647 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
648 * CMakeLists.txt changed accordingly.
649 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
650 DeveloppersPython.html
651 * INSTALL nows refers to Doc/Website/Installation.html
653 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
654 * Added Doc/Website directory, that contains a first raw version
657 2004-09-23 Jean-Pierre Roux
658 * FIX In order not to be poluted any longer by casting problems,
659 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
660 we can now delete[] it safely
661 * VoidArea is now called BinArea (less confusing name),
662 and all the methods called ...VoidArea... are now ... BinArea...
663 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
665 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
666 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
667 clear) TagHT, which is an inherited member of gdcmElementSet. It is
668 up to the destructor of gdcmElementSet to clean up TagHt and it's
671 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
672 * Test/CMakeLists.txt: update to follow gdcmData renamings.
673 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
675 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
676 * ENH: added some utility method that builds a flat dictionnary
677 holding all the Dicom entries contained in the recursive structure
678 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
680 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
681 BuildFlatHashTable() that build a flat dictionary.
682 - src/gdcmElementSet.h: added a new private GetTag() accessor.
683 gdcmDocument is now a friend of gdcmElementSet.
684 - src/gdcmElementSet.cxx: clean up.
685 - Example/FlatHashTablePrint.cxx added.
686 - Example/CmakeLists.txt changed accordingly
688 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
689 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
690 moved away from gdcmDocEntrySet (since this class is an abstract class
691 acting like an interface). SQDepthLevel and BaseTagKey are now
693 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
694 and associated accessors. Doxygenation of the class.
695 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
697 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
698 Use SQDepthLevel accessor instead. ::Print() adapted.
699 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
700 - src/gdcmDocument.cxx changed accordingly.
702 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
703 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
704 - The following is the doxygen comment of the typedef declaration
705 of gdcmagKey in src/gdcmCommon.h:
706 gdcmTagKey is made to old an "universal" (as in URL, Universal
707 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
708 A dicom tag allways has a group and an element, but a set of tags
709 embeded in various (optionally nested) sequences and sharing
710 the same group and element all share the same (group, element)
711 "identifier". Hence the (group, element) cannot be used as an
712 identifier (in gdcm we shall refer to a "TagKey") of a tag.
713 In order to construct a proper tag identifier (i.e. a key) we
714 consider the following definition of a TagKey:
715 - let Group, Element be the string representation of the
716 group and element dicom tag members,
717 - let ItemNumber be the string representation of the integer
718 index of the considered item number of a sequence,
719 Let the key of a tag embeded in a sequence, noted SeqTag, be
721 /ItemNumber#Group|Element
722 where "/", "#" and "|" are characters acting as separators.
723 Then the general form of a gdcmTagKey is given by:
724 Group|Element<SeqTag>
725 where <SeqTag> means NO or many instances of SeqTag.
726 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
729 but the gdcmTagKey of a tag "embeded" is the first item of
730 a sequence, itself nested in the third item of a sequence is the
732 0004|1220/2#0008|0082/0#0008|0090
733 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
734 order to hold the new sequence compatible key. Previously, the
735 GetKey() method would look in the underlying gdcmDictEntry.
736 - src/gdcmDocEntry.cxx:
737 -- constructor now copies the underlying DictEntry key, in the local
739 -- ::Print: displays the member Key, instead of the (group, element).
740 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
741 - src/gdcmDocEntrySet.h:xi
742 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
743 -- now has a new BaseTagKey member.
745 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
746 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
748 This poses the problem with the semantics of the following lines
749 LoadEntryVoidArea(0x0028,0x1201); // R LUT
750 LoadEntryVoidArea(0x0028,0x1202); // G LUT
751 LoadEntryVoidArea(0x0028,0x1203); // B LUT
752 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
753 to the long FIXME note for what the problem is. Nevertheless in
754 order to get things working the dicom dictionary was altered !
755 Please fix things urgently...
756 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
757 information), see above note on moving the member VoidArea. Nevertheless
758 the following entries previously correctly set as US are now inproperly
760 0028 1201 OW IMG Red Palette Color Lookup Table Data
761 0028 1202 OW IMG Green Palette Color Lookup Table Data
762 0028 1203 OW IMG Blue Palette Color Lookup Table Data
763 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
764 of gdcmDocEntry moved to gdcmSeqEntry.
765 * src/gdcmSeqEntry.cxx: STYLE.
767 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
768 * Test/TestAllEntryVerify.cxx minor fix and added comments.
770 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
771 * gdcmPython/testSuite.py: all the test suite in python is now moved
772 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
773 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
774 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
776 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
777 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
778 to avoid inclusion recursion until STL is reached.
779 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
780 mecanism. errno.h is not included in gdcm anymore.
781 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
782 (gdcmFormatError now inherits from gdcmFormatUnexpected).
784 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
785 gdcmData/TestAllEntryVerifyReference.txt
786 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
787 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
788 exception_on_error parameter.
789 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
790 - vtk/vtkGdcmReader.cxx changed accordingly,
791 - Example/*.cxx and Test/*.cxx changed accordingly.
793 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
794 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
795 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
796 enable_sequences removed from gdcmHeader constructor and dependencies.
797 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
798 * gdcmPython/demo/PrintHeader.py: dummy fix.
799 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
800 skip_shadow removed from gdcmHeader constructor and dependencies.
801 * Example/*.cxx and Test/*.cxx changed accordingly.
803 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
804 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
805 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
807 2004-07-21 Jean-Pierre Roux
808 * FIX Now, Parsing and Printing a DICOMDIR do work!
809 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
811 2004-07-20 Jean-Pierre Roux
812 * FIX Some brain damaged headers have Zero-Lenght fields
813 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
815 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
816 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
817 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
818 variable (instance of gdcmDebug) by a definition macro, and the instance
819 is now in static in the gdcmDebug class
820 * src/gdcmSQItem.h : (FIXME) remove an undefined method
821 * Test/PrintAllDocument.cxx : bug fix in the result of the test
823 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
824 * WARNING: ctest now depends more tightly on gdcmData. You should
825 check out gdcmData properly for things to run smoothly...
826 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
827 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
828 we need the pixels not be loaded in order to use the ValEntry
829 that displays position and size).
830 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
831 This is a C++ based equivalent of gdcmPython/testSuite.py that should
832 be deprecated. If you have any doubts about the advantages of a
833 modern scripting language (read Python) versus grass root C++ (i.e.
834 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
835 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
836 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
837 Anyhow, consider documenting the gdcmData images in
838 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
840 * Test/CMakeLists.txt:
841 - now uses TestAllEntryVerify.cxx
842 - specific comments on oldACR00001.ima (now renamed in gdcmData
843 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
844 gdcmData/TestAllEntryVerifyReference.txt
847 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
848 * src/*.[h|cxx] : typedef clean up
849 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
850 - TagKey renamed to gdcmTagKey (for external usage)
851 - VRKey renamed to gdcmVRKey (for external usage)
852 - removal of typedef duplication.
853 - Removed all unecessary inline keyword from class inline definitions.
854 - Some method|function(void) declarations replaced with method|function().
855 * src/jpeg/libijg12/jdhuff12.c:
856 - printf polluting ctest removed.
857 - TAB removal for comminting
859 - TestAllReadCompareDicom.cxx: added a test that compares all the
860 images in gdcmDataImages.h with corresponding images in
861 gdcmData/BaselineDicom/. When baseline images are not present
862 this test creates them.
863 Note: we need to validate each reference image, but before that
864 I'd like to rename them with a more explicit name...
865 - CMakeLists.txt: changed accordingly.
866 * Example/*.cxx: examples now only include gdcm.h (as opposed to
867 including each header needed).
869 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
870 * Test/*.cxx and Example/*.cxx: moved some examples away from the
871 test suite to the Example directory. Are concerned:
876 - TestWriteSimple.cxx
877 * Test/CMakeLists.txt: added some comments on reasons for black listing
878 image gdcmData/oldACR00001.ima
880 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
881 * Test/CmakeList.txt: removed the following from black list (to be coherent
882 with removal from gdcmData):
883 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
884 - gdcm-MR-PHILIPS-16.dcm
886 Added the following because after last cvs update, they cause
887 ctest -R TestReadWriteReadCompare
889 - gdcm-MR-SIEMENS-16-1.acr
891 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
892 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
893 new comments in this file) we temporarily (sigh) move to a weaker
895 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
896 we don't need to black list the following images anymore:
897 - 8BitsUncompressedColor.dcm
899 - US-PAL-8-10x-echo.dcm
900 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
901 fixes and the beautified code ;-)
902 This fixes the bug introduced in version 1.42 (when beautifying)
903 that made the parsing of 8BitsRunLengthColor.dcm unproper.
904 Note: ctest was blind to this bug (this means we need to still
905 improve the test suite). The bug could be detected by using
906 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
908 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
909 and by displaying the (garbage) produced file temp.XDCM...
911 2004-06-29 Jean-Pierre Roux
912 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
913 - replace by uggly but working old code :-(
914 A lot of things should be OK again.
915 It's really urgent to have a test suite that *tests*,
916 to prevent Frog's beautifying sessions to break all the stuff
917 (twice, withing a fortnigh ...)
919 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
920 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
921 redundancy) to added Test/TestReadWriteReadCompare.cxx
922 * Test/CmakeList.txt: because the compare test of
923 Test/TestReadWriteReadCompare.cxx fails, the following images are
924 black listed: - 8BitsUncompressedColor.dcm
926 - US-PAL-8-10x-echo.dcm
927 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
928 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
929 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
930 and ad-hoc kludge. This kludge is now removed, and on encountering
931 such an image (OB field brain damaged) we set errno. Then in
932 ::FindDocLength() we "fix" the length as being ALL what remains
933 in the file (until EOF). We then proceed, hoping for the best...
934 This fixes a SegFault in ShowDicom when trying to write such an
936 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
937 (because TestWriteRead breaks on it, after a non conformal commit?).
938 ctest now runs properly, except for MakeDicomDir (which was allways
939 broken) and the Python related stuff (still not fixed).
941 2004-06-24 Jean-Pierre Roux
942 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
943 FIX : Test/TestReadWrite now iterates on all the file names
944 (instead of infinite loop)
945 ENH : Test/TestWriteRead now iterates on all the file names
947 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
948 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
950 2004-06-24 Jean-Pierre Roux
951 FIX : - now Write drops LUT Descriptors and LUTs (if any)
952 when SamplesPerPixel =3
953 - now Write is no longer confused by
954 'BitsAllocated = 12" and 'BitsStored=12"
955 - "UN" value representation Elements are now written correctly
956 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
957 ENH : - now gdcmHeader has its own Write methods
958 (in order to split the job that has not to be done
961 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
962 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
963 loop on the same image until memory went out.
964 Note: this means we still have gobs of memory loss in PrintDocument
965 * src/gdcmDocument.cxx: fixes problem on parsing on file
966 gdcmData/16BitsJpegLosslessGrayScale.dcm.
968 2004-06-24 Jean-Pierre Roux
969 FIX : Write - All the Sequences and Sequence Item are now written
970 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
971 is added a the end, when necessary.
972 - A lot of brain-damaged images, that were read correctly are
973 now written correctly
974 - length compatible BinEntry are now loaded correctly
975 (even for odd groups)
976 Note : only Explicit Value Representation was checked.
977 (question : is implicit VR really necessary for gdcm ?)
979 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
980 * DEVELOPPER: added a proposition of coding style.
981 * src/gdcmDocEntry.h: removed every inline declaration (for test of
984 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
985 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
986 Use the gdcmDocEntry::Print() and Write() instead.
987 * src/gdcmDocument.cxx: bug fix.
989 2004-06-22 Jean-Pierre Roux
990 FIX : gdcmDocument.cxx
991 - Now we do recognize the JpegLossLess format (there was a misstyping in
992 code 'beautyfication' :-(
993 - Now we automaticaticaly load the Luts, if any
995 2004-06-22 Jean-Pierre Roux
996 In order : to write Sequences, whatever their imbrication level,
997 : to allow user to create his own Sequences
998 a lot of modif where necessary (adding, moving, or virtualising methods)
1000 WARNING : save your own sources *before* cvs up !
1003 ADD virtual void Write(FILE *fp, FileType filetype);
1006 ADD virtual void Write(FILE *fp, FileType filetype);
1007 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1010 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1011 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1012 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1013 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1014 ADD std::string GetEntryByName(TagName name);
1015 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1017 std::string vr = "unkn",
1018 std::string fourth = "unkn",
1019 std::string name = "unkn");
1020 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1021 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1022 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1023 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1024 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1025 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1026 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1027 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1030 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1031 ADD virtual std::string GetEntryByName (TagName tagName);
1032 ADD virtual std::string GetEntryVRByName (TagName tagName);
1033 REM virtual bool Write(FILE *, FileType);
1034 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1035 FILE *_fp, FileType type);
1036 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1037 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1038 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1039 REM virtual std::string GetEntryByName (std::string tagName);
1040 REM virtual std::string GetEntryVRByName (std::string tagName);
1041 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1042 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1043 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1045 std::string vr = "unkn",
1046 std::string fourth = "unkn",
1047 std::string name = "unkn");
1048 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1049 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1050 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1051 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1054 ADD virtual void Write(FILE *fp, FileType filetype);
1057 ADD virtual void Write(FILE *fp,FileType filetype);
1060 ADD virtual void Write(FILE *fp, FileType filetype);
1061 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1062 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1063 REM std::string GetEntryByName(TagName name);
1066 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1068 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1069 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1070 The default constructor invoked by the line
1071 gdcmHeader *f1 = new gdcmHeader( header );
1072 was gdcmHeader::gdcmHeader(bool) instead of the expected
1073 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1074 Hence the parsing wasn't executed... See also below.
1075 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1076 as explicit constructor didn't do the trick to fix the above problem.
1077 Could anyone explain why ?
1078 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1079 properly calls gdcmValEntry::Print() (that was weed out from
1080 code related to gdcmBinEntry).
1082 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1083 * In order to fix memory leaks:
1084 - Test/TestWriteSimple.cxx: added cleaning of free store through
1086 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1087 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1088 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1089 (through the call to ::AddDicomDirMeta()) or the destructor
1090 would crash when deleting uninitialized ::metaElems].
1091 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1092 - src/gdcmDocument.cxx:
1093 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1094 from dynamic stores.
1095 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1096 was causing memory leaks.
1097 - src/gdcmSQItem.cxx:
1098 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1099 cleanly handled with polymophism: sorry but my milage is low).
1100 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1101 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1102 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1103 This avoids SegFaulting.
1104 - src/gdcmSQItem.h: coding style.
1106 - Test/TestWriteSimple still severely sucks. The output image content
1107 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1108 damaged when displayed with vtkgdcmViewer.
1109 - on memory leaks: TestWriteSimple leaks really less (see entry
1110 of 2004-06-18 in Changelog file for the call to valgrind).
1111 - on segfaults: ctest now passes all the tests but one (no more
1113 * Erroneous leading white fix:
1114 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1115 white[s] (as opposed to from >> xxx, that removes it [them].
1116 - src/gdcmTS.cxx: ditto.
1117 - gdcmPython/testSuite.py: dirty related kludge removed.
1118 * src/*: remaining references to gdcmParser removed.
1119 * src/*[cxx|h]: added copy[way]left header.
1122 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1123 * In order to fix writing of dicom files:
1124 - Test/TestWriteSimple.cxx: a simpler example of writing.
1125 - Test/CMakeLists.txt changed accordingly.
1126 - src/gdcmDocument.cxx:
1127 -- The destructor now recursilvely removes potential sequences.
1128 -- Bug fix in ::IsJPEG2000()
1129 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1130 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1132 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1133 to only declared) and build on top of
1134 ::GetDocEntryByNumber(guint16, guint16).
1135 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1136 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1137 for usage in destructor and treatement of promotion in
1138 ::ReplaceOrCreateByNumber().
1139 - src/gdcmSQItem.cxx: destructor should better handle his job.
1140 Test/TestWriteSimple now runs (or at least it DOES something).
1141 * We can now start hutting memory links. A good starting point is:
1142 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1143 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1144 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1146 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1147 * Valgrind note: after Mathieu Malaterre teached me how to read
1148 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1150 Using gcc, you can force the STL to use malloc and to free memory as
1151 soon as possible by globally disabling memory caching.
1152 With 3.2.2 and later, you should export the environment variable
1153 GLIBCPP_FORCE_NEW before running your program.
1154 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1155 simply vanish (it is still not clear to me, whether this means that
1156 STL std::string leaks or if valgrind believes it leaks...).
1157 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1158 running bin/gdcmTests makeDicomDir):
1159 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1160 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1162 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1163 SegFaulting (I drowned in DicomDir related code when trying to
1164 understand why the list is empty...).
1165 * src/gdcmDocument.h: first BSD license header try.
1166 * Doc/License.txt added.
1168 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1169 * src/gdcmDocument.[h|cxx]:
1170 - Clean up of the Transfer related predicates. They are now all based
1171 on new method isGivenTransferSyntax, that (should) handle properly
1172 the padding problem.
1173 - general clean up, simplification, and coding style.
1174 - Specific clean up of Parse7FE0() (umproperly named actually).
1175 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1177 2004-06-14 Jean-Pierre Roux
1179 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1180 - fix the display of SQItem ordinal number
1181 - add the GetSQItemByOrdinalNumber method
1182 - remove some useless never written private methods
1184 2004-06-14 Jean-Pierre Roux
1186 - adding a constructor taking a gdcmDocEntry as an input param
1187 - ReplaceOrCreateByNumber now returns :
1188 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1189 a gdcmValEntry * if a string value is passed as a param
1191 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1192 according to the param type (no longer sets a gdcmDocEntry)
1193 - GetValEntryByNumber, GetBinEntryByNumber added
1194 - NewValEntryByNumber and NewBinEntryByNumber added
1196 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1198 - GetSQItemNumber and SetSQItemNumber added, to provide
1199 a (relative) Item identier inside a given Sequence
1200 \warning : some pb remaining around this number
1202 - AddEntry now takes the Item Number as a param
1204 - adding a constructor taking a gdcmDocEntry as an input param
1206 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1207 * Memory leak hunt with the following command:
1208 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1209 --show-reachable=yes gdcmTests PrintDocument
1210 It looks like many (all?) leaks are due to the STL (or a bad usage
1211 of the STL. The lines producing the leaks now have a comment with
1212 a "MEMORY LEAK" tag: you can retrieve them with
1213 grep "MEMORY LEAK" src/*
1214 Here are two typical examples which I can't help fixing:
1219 char * test = "babo";
1220 name = test; //// <--- valgrind detects 960 bytes lost in
1221 //// call to std::string::operator=(char const*)
1222 name.clear(); //// Doesn't help !
1230 std::cout << "Type a bunch of characters followed by RETURN: ";
1231 getline(std::cin, line); //// <--- valgrind dectects a loss
1232 //// of 1320 bytes in call to
1233 /// std::basic_istream<>& std::getline<>
1239 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1240 * src/gdcmHeader.[cxx|h]:
1241 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1242 and related, moved away to gdcmDocument.
1243 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1244 the corresponding protected accessors of inherited class
1245 gdcmDocument, removed ! As a consequence gdcmFile had to be
1246 declared friend of class gdcmDocument (see below).
1247 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1248 - Clean up of undefined or unused methods.
1249 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1250 account the changes to gdcmHeader.h).
1251 * src/gdcmDocument.h:
1252 - gdcmFile is now a friend class (in order to take into account the
1253 changes to gdcmHeader.h).
1254 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1255 (see changes to gdcmHeader.h).
1256 - Accessors (reading on the form GetEntry*) are now public.
1257 - Clean up of undefined or unused methods.
1258 * src/gdcmDocument.cxx:
1259 - adaptation to changes to gdcmDocument.h
1260 - ::OpenFile now writes a verbose message when file cannot be opened.
1261 - some std::string properly set to VRKey
1262 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1263 references to gdcmDocument.
1264 * Test/TestFindTags.cxx: changed accordingly to above changes.
1265 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1266 cvs repository gdcmData.
1268 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1269 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1270 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1271 conflicts with gdcmValEntry::voidArea.
1272 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1273 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1274 Value representation between StringRepresentable and BinaryRepresentable.
1275 * src/gdcmDocument.cxx:
1276 - method ParseDES: proper indentation restored and usage of
1277 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1278 - method LoadDocEntry: the fingerprint left in the SetValue() of
1279 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1280 removed. Reverting to previous code segment with the proper
1281 dynamic_cast< gdcmValEntry* >.
1282 Note: this was (partially) breaking the python test suite
1283 (gdcmPython/testSuite.py) that made usage of the above
1284 fingerprint to check presence of "Pixel Data".
1285 * src/gdcmDocEntry.h: coding style.
1286 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1287 now taken into account.
1288 * gdcmPython/gdcm.i: adaptation to the new internal representation
1289 of gdcm (exit gdcmParser, hello gdcmDocument).
1290 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1292 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1293 anymore, but instead prints the loaded Python dictionary.
1294 * .... alas, the python testSuite is still broken.
1296 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1297 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1299 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1300 * src/gdcmUtil.h : export methods
1302 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1303 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1305 * Initial addition of automatic python testing
1306 * Initial addition of automatic image comparison
1308 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1309 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1310 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1312 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1313 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1314 * Test/ShowDicom.cxx : bug fix for msvc compilation
1315 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1317 2004-05-04 Jean-Pierre Roux
1318 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1319 new concepts (and new classes) :
1320 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1321 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1322 - Sequence Doc Entries (gdcmSeqEntries)
1323 a Sequence is composed of Items.
1324 Each item is a set of Doc Entries (this is recursive)
1325 The non uniqueness of the 'Dicom tag' is due to this recursivity
1326 (never taken into account)
1327 Our unability to add a new 'entry' in the header
1328 at the proper location (neither in the H-Table (map or multimap),
1329 nor in the Chained List is also due to this recursivity.
1330 Don't try, right now, to use/modify/compile these new sources :
1331 nothing is finished.
1332 We just commit all the stuff, 'as is', in order not to loose it.
1334 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1335 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1337 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1338 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1339 file prefix (SetFilePrefix)
1341 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1342 * Add a new test: ShowDicom, for now this is just the c++ version of
1343 checkRead.sh, later it will be able to compare the image read against a
1345 * Replace the DEBUG on the stack with a global entry in cmake interface:
1346 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1348 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1349 * Add an example subdir, with a real example on how to read + write a
1352 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1353 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1354 * Doc/CMakeLists.txt: the main page is now properly differentiated
1355 between the developper and user version.
1356 * Doc/doxygen.config.in: dropped search related obsolete flags
1357 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1359 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1360 * DEVELOPPER: added some helpfull comments for compile/test/install
1363 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1364 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1365 src directory, now generated in the build dir.
1366 2. Tests as mentionned smarter
1368 4. Add a new method in gdcmDict that return the PubDict by name
1369 this is interesting for 3rd party lib like ITK,
1370 where we could set the institution name / patient name...
1372 * ENH: 1. Now the test suite is working for real
1373 2. All binaries are now output in the gdcm-bin directory
1374 (this was not true before)
1376 2004-04-28 Jean-Pierre Roux
1377 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1378 SeQuence indented printing of Dicom Header.
1379 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1380 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1381 Computation of SQDepthLevel is now part of gdcmHeader constructor
1382 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1383 tree-like structure of a Dicom Header.
1384 * FIX Test code cleaning
1386 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1387 * ENH: Adding automatic testing
1388 1. Need a DartConfig.cmake to submit to public
1389 2. Add a test driver gdcmTest.cxx
1390 3. gdcmTestMain, an helper for the main test driver gdcmTest
1391 4. Files in Test don't have a main anymore, this becomes interesting
1392 when we add more and more tests, thus dsw don't have to load
1394 * ENH: Adding a GDCM_DATA_ROOT for testing
1395 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1396 one file instead of seven + some small cleanup
1398 2004-04-22 Jean-Pierre Roux
1399 * ENH Minor changes to the Print() methods.
1400 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1401 Header printing. Example given with :
1402 > PrintHeader fileName 2 new
1403 (SQ based tree-like structure still to be done for the Header ...)
1405 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1406 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1407 1. I have added some unsigned where needed
1408 2. Some function parameter not used -> (void)
1409 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1410 4. g++ don't like character '\' in comment
1411 5. #define jpeg_create_decompress jCreaDecompress
1412 this really need to be fixed
1413 6. virtualize destructor of gdcmObject ... leakage
1414 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1415 this also really need to be fixed
1416 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1417 remove compression file
1418 (as we only do decompression, right ?)
1419 * ENH: Change malloc/calloc/free with c++ equivalent
1421 2004-04-21 Jean-Pierre Roux
1422 * FIX gdcmHeaderHelper::GetXSpacing
1423 when a single value is found (bug ?), xpacing is now
1424 defaulted to yspacing
1426 2004-04-19 Jean-Pierre Roux
1427 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1428 * ENH add parameters :
1429 bool exception_on_error = false,
1430 bool enable_sequences = false,
1431 bool ignore_shadow = false
1432 to the gdcmFile constructors to be full gdcmParser compliant
1433 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1434 to allow reading of PAPYRUS 3.0 files
1436 2004-04-06 Jean-Pierre Roux
1437 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1439 2004-04-02 Jean-Pierre Roux
1440 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1441 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1442 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1444 2004-03-30 Jean-Pierre Roux
1445 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1446 for ACR file, written out as DICOM files (hope so...)
1448 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1449 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1450 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1451 moved to base class gdcmParser and only the specialisation is kept
1453 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1454 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1455 already does the job.
1456 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1457 (to be consistent with gdcmParser::WriteEntries).
1459 2004-03-30 Benoit Regrain
1460 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1461 upate of the object's instance. It's passed to 2 in the unfavorable
1462 case : one in the ExecuteInformation, one in the ExecuteData
1464 2004-03-29 Jean-Pierre Roux
1465 * ENH : Check on file type to be written moved
1466 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1467 * FIX : gdcmObject::ResetBoundaries now stops properly
1468 when end-of-list is reached
1469 : gdcmVersion modified (as Benoit Regrain asked)
1471 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1472 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1473 * src/gdcmUtil.cxx: added forgotten iostream include.
1474 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1475 equivalent to ExplicitVR in existing code).
1477 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1478 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1479 now contains all the gdcmGlobal related code.
1480 * minor coding style and doxygenation changes.
1482 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1483 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1484 now contains all the Debug related code.
1485 * minor clean-up of includes in src/*.cxx
1486 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1487 CreateCleanString) removed.
1488 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1489 * Doc/DoxyMainPageUser.txt added.
1490 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1491 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1492 src/gdcmDirList.cxx)
1494 2004-03-24 Jean-Pierre Roux
1495 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1497 2004-03-23 Jean-Pierre Roux
1498 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1499 big endian made volumes
1500 * ENH Now gdcmParser constructor and destructor are protected to forbid
1501 end user to instanciate class gdcmParser
1502 (only gdcmHeader and gdcmDicomDir are meaningfull)
1504 2004-03-22 Benoit Regrain
1505 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1506 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1507 gdcmSerie to gdcmDicomDirSerie
1509 2004-03-19 Jean-Pierre Roux
1510 * ENH Now the tree-like structure describing a DICOMDIR comming from
1511 an already existing DICOMDIR file is consistent with
1512 the home-made tree-like structure build ex-nihilo
1513 or build from the files held (recursively) in a Directory
1514 functions gdcmDicomDir::CheckBoundaries()
1515 gdcmObject::SetBoundaries() added
1517 2004-03-17 Jean-Pierre Roux
1518 * REM (Eric Boix bug) : removal of meaningless
1519 gdcmDicomDirImage::NewImage function.
1520 * FIX now file names and directory name are written properly in the
1522 * FIX now gdcmDicomDir constructor may be call without any trick
1525 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1526 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1527 of gdcmDicomDirImage::NewImage as empty function.
1529 2004-02-28 Jean-Pierre Roux
1530 * ENH add gdcmDicomDir:NewPatient
1531 add gdcmDicomDirPatient:NewStudy
1532 add gdcmDicomDirStudy:NewSerie
1533 add gdcmDicomDirSerie:NewImage
1534 to allow making gdcDicomDir object.
1535 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1536 (as opposite to the gdcmHeader chained list)
1538 2004-02-11 Benoit Regrain
1539 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1540 when using from python
1542 2004-02-10 Benoit Regrain
1543 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1544 * FIX : in gdcmDicomDir when the directory is empty
1545 * ENH : add callback and methods to get the progression of dicomDir
1548 2004-02-06 Jean-Pierre Roux
1549 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1550 - GDCM_META added to gdcmDicomDirType
1551 - class gdcmMeta created
1552 * ENH : - A brief summary is now displayed at the beginning of
1553 'testDicomDir' to help disaster magnitude estimation
1554 * REM : Now useless Test/explDICOMDIR.cxx
1556 2004-02-05 Benoit Regrain
1557 * ENH : add methods in gdcmObject to get the hash table or the list of
1559 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1560 * FIX : wrapping python for TagHeaderEntryHT
1562 2004-02-04 Benoit Regrain
1563 * FIX : even length for some strings when writting the dicom dir
1564 * FIX : sort the images in the dicom dir
1565 * FIX : Bug fix for python use of dicom dir
1566 * ADD : a python demo
1568 2004-02-04 Jean-Pierre Roux
1569 * FIX : Final solution (?) for icone embedded images
1570 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1571 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1572 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1573 gdcmData/gdcm-MR-SIEMENS-16.acr1
1574 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1575 to make full checking easier
1577 2004-02-04 Benoit Regrain
1578 * FIX : WriteEntries : coding style & logic in parameters
1579 * FIX : Set the elements to create the DicomDir in a dictionary file
1581 2004-02-03 Benoit Regrain
1582 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1583 * gdcmDicomDir : add the load of directory
1584 * Bug fix and print add-on
1586 2004-02-03 Jean-Pierre Roux
1587 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1588 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1589 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1590 * FIX gdcmParser.cxx : 'group length' elements are now considered
1591 as integers, even for shadow groups, when file is Implicit VR
1593 2004-02-02 Jean-Pierre Roux
1594 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1596 of the last synonym :-(
1597 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1599 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1600 * FIX taking into account the possible 7fe0,0010 multiplicity
1601 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1602 to allow removal of references to 7fe0,0010, to deal with
1603 ACR-NEMA images, when 0028,0200 is meaningfull
1605 2004-01-31 Jean-Pierre Roux
1606 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1607 no longer writes 'Un' on disk
1608 * FIX SQ elements with actual length are now dealt with corectly
1609 * FIX gdcmFile::WriteBase make the difference, for color images, between
1610 the length (for Palette expanded images)
1611 and Raw Length (non expanded image + Palette)
1612 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1613 (that broke Write). Replaced by UL.
1614 Aware user will reload the field if he
1615 thinks it's necesssary
1617 2004-01-30 Jean-Pierre Roux
1618 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1619 when 'dirty Acr' is found, to be compliant with the new
1620 IsReadable() methods.
1622 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1623 (no DOUBLE images in kosher DICOM,
1624 but so usefull for people that miss them ;-)
1626 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1627 DICOMDIR related utilities (not checked as Windoze compliant)
1629 2004-01-28 Jean-Pierre Roux
1630 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1632 2004-01-27 Jean-Pierre Roux
1633 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1634 to allow skipping the shadow elements, to save memory space.
1635 The TRUE value for this param has to be used
1636 with a FALSE value for the 'enable_sequence' param.
1637 ('public elements' may be embedded in 'shadow Sequences')
1638 * gdcmHeader methods now deal with 'embedded icones images' in the header
1639 (even when an 'icone image sequence' is announced by the
1640 element (0x0088,0x0200), but there is NO icone at all ...
1642 * gdcmHeader sometimes Image Location value doesn't follow
1643 the supposed processor endianity (see gdcmData/cr172241.dcm).
1646 * gdcmHeader add the method
1647 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1648 to get *all* the Header Entries with the same tag.
1649 GetHeaderEntrySameName is probabely *useless*
1650 (no meaning : Name is *not* an identifier within the Dictionnary)
1652 2004-01-26 Benoit Regrain
1653 * Bug fix in the print of hexadecimal representations. Remove long fields
1654 in the print and add a third level of print to print them
1656 2004-01-23 Benoit Regrain
1657 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1658 * Bug fix on test suite after remove the strip made on not string fields
1659 * Split the IsReadable method between gdcmParser which test that the file
1660 is dicom and gdcmHeader which test that it's an image file
1662 2004-01-22 Benoit Regrain
1663 * DicomDir : clean code, add methods, set variables in protected or private
1664 * gdcmUtil : bug fix for the clean string method
1666 2004-01-19 Benoit Regrain
1667 * Add the use of shadow dictionaries
1668 * bug fix and coding style
1670 2004-01-19 Benoit Regrain
1671 * src/gdcmFile.cxx : bug fix concerning the close of file
1672 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1673 * Add the update of header entries using the shadow library
1675 2004-01-19 Benoit Regrain
1676 * removal of file gdcmHeader2.cxx
1677 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1678 inheriting from gdcmParser. This split is to prepare the integration
1679 of dicom dir parsing
1680 * bug fix under python
1682 2004-01-16 Jean-Pierre Roux
1683 * REM removal of class gdcmHeaderEntrySet
1684 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1685 * ADD add file gdcmHeader2.cxx
1686 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1688 2004-01-15 Benoit Regrain
1689 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1690 entries created while parsing the header. Thus, they will be destroyed
1691 when the gdcmDictSet will be destroyed
1692 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1695 2004-01-15 Benoit Regrain
1696 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1697 made a fatal error because of the memory release at the end of program.
1698 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1699 some memory and vtk seems to have some problems with that.
1700 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1702 2004-01-14 Benoit Regrain
1703 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1704 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1705 * src/*.[h|cxx] : make changes due to class name changes
1706 * gdcmPython/demo/*.py : bug fix due to method names
1708 2004-01-13 Benoit Regrain
1709 * src/*.[h|cxx] : coding style
1710 * vtk/*.[h|cxx] : coding style
1712 2004-01-13 Benoit Regrain
1713 * gdcmPython/testSuite.py : test the readable flag of file for tests
1714 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1715 It's lied to the stl compilation by MSVC (windows, always windows...)
1716 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1718 2004-01-12 Benoit Regrain
1719 * src/*.h : add comments
1720 * src/gdcmDictSet.h : set the method BuildDictPath in public
1721 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1722 directly setted in the source code
1723 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1726 2004-01-09 Benoit Regrain
1727 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1728 * setup.py : use a reference to gdcmVERSION
1730 2004-01-07 Benoit Regrain
1731 * Modification to compile with the distutils.
1734 2003-12-10 Benoit Regrain
1735 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1736 can use a gdcmHeaderHelper to load datas
1737 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1738 made in the source code
1740 2003-12-10 Benoit Regrain
1741 * Update Windows projects and .cvsignore files
1743 2003-11-12 Jean-Pierre Roux
1744 * ENH gdcmHeader constructor has one more parameter (default value : false)
1745 that allows the user to 'go inside' the SeQuences only
1747 gdcmElValSet:Print takes it into account
1749 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1750 * ENH: Update gdcmPython/CMakeLists
1751 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1752 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1754 2003-11-10 Jean-Pierre Roux
1755 * FIX : gdcmHeader::LoadElements is now based
1756 on the ListTag listElem member,
1757 not longer on the TagElValueHT tagHt member
1758 * ENH : PrintPubElVal shows (temporarily) both results,
1759 with the tagHt member and the listElem member.
1760 (it's easier to 'see' the problems when using Printheader)
1762 * FIX : old private member LgrElem is now splitted into
1763 ReadLength : Length actually found on disk (updated only
1764 if bug fixing is necessary), for internal
1766 UsableLength : Updated by FixFoundLength, to fix a bug
1767 or to allow Parser going on.
1768 Will allow to re-write a kosher header when a SeQuence
1769 with a length (not 0000) is found
1770 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1771 because gdcmElValSet::Add does not update ListElem
1774 2003-11-07 Jean-Pierre Roux
1775 * FIX misstyping in Transfert Syntax name table
1776 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1777 when they have an actual length (not 0000 nor FFFFF)
1778 (Nobody should care of it, but DICOMDIR explorers)
1780 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1781 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1783 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1784 * ENH: vtkGdcmReader now supports LUT !
1785 (vtkgdcmViewer for now is not able to use them though)
1787 2003-11-05 Jean-Pierre Roux
1788 * in testSuite.py : new files names for checking the package
1789 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1790 that returns the pixel area size to the *aware* (vtk) user
1791 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1793 2003-11-05 Benoit Regrain
1794 * in testSuite.py : Modify the rules for checking the paths
1795 : Explicit error messages
1796 * in __init__.py : Related modif
1798 2003-11-03 Jean-Pierre Roux
1799 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1800 to be used by aware (vtk) users that want to manage
1801 LUT (and no to turn the PALETTE image into an RGB pixels one)
1802 * GetPixelType now returns 8U for 24 Bits images
1803 (vtkGdcmReader compliant)
1805 2003-10-31 Jean-Pierre Roux
1806 * Removal of *all* gdcmData images and add them again
1807 in order to loose the 'history' of un-anonymised images
1809 2003-10-31 Jean-Pierre Roux
1810 * RMV : removal of useless jBitsInJsample.h
1811 for both 8 and 12 Bits JPEG Lossy Libraries
1813 2003-10-31 Jean-Pierre Roux
1814 * ENH : Add the functions gdcmFile::GetImageDataRaw
1815 gdcmFile::GetImageDataIntoVectorRaw
1816 that act as GetImageData and GetImageDataIntoVector
1817 except the making of an RGB Plane from Gray Plane + LUT
1818 Intended to aware (vtk) users who know how to manage
1821 GetLUTRGBA return a R,G,B,A LUT if any
1822 lgrTotaleRaw gives the 'Raw' length
1823 GetImageDataRaw returns the gray Plane
1824 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1825 (They stay Grey, just like with other Dicom viewers :-(
1827 2003-10-30 Jean-Pierre Roux
1828 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1830 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1831 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1832 being coherents dicom files.
1834 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1835 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1837 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1838 * ENH: Two steps is necessary to please VC++ compiler...
1839 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1840 * ENH: Add include dir to medcon lib
1841 * FIX: only one function is being exported for now !
1842 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1844 2003-10-29 Jean-Pierre Roux
1845 * adding gdcmHeader::GetLUTRGBA
1846 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1847 --> Mathieu, the modif u're waiting for is not yet committed
1848 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1850 2003-10-27 Jean-Pierre Roux
1851 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1852 00191113.dcm DermaColorLossLess.dcm
1853 MxTwinLossLess.dcm RadBWLossLess.dcm
1854 * ENH: For version prior to vtkImageViewer2 -r 1.19
1855 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1857 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1858 * Removal of ido stuff in CMakeLists.txt
1860 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1861 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1862 * FIX: remove a call to ->Modified ... see comments
1863 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1865 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1866 * FIX: Problem with path for libvtkgdcmPython
1867 * ENH: Try adding a search script for python site-package
1868 * RMV: Remove some file from medcon lib that are not necessary
1869 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1870 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1871 * FIX: More pragma disable fro VC++,
1872 I don't think I break something as it is also disable in VTK/ITK.
1873 But it fasten debug compilation time.
1875 2003-10-23 Jean-Pierre Roux
1876 * gdcm now deals with 16 Bits Run Length Encoded images
1877 (they are compressed as 2 planes images,
1878 one for the high Bytes, the other for low Bytes)
1880 2003-10-22 Jean-Pierre Roux
1881 * Now CheckRead takes into account :
1882 - the bugged 'Leonardo' Siemens images
1883 - the XA images, sent thru the burning VPRO station
1884 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1887 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1888 * FIX: When copying a Makefile.am to CMakeLists.txt
1889 one should remove the '\'
1891 2003-10-22 Jean-Pierre Roux
1892 * in gdcmData adding a bugged 'Leonardo' Siemens image
1893 (wrong lengths in header)
1894 OK with gdcm, KO with the other viewers :-)
1895 * add a GE dlx XA image, thru the VEPRO burning station
1898 2003-10-21 Jean-Pierre Roux
1899 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1900 for a brutal checking of vtkgdcmViewer compliance
1902 2003-10-21 Jean-Pierre Roux
1903 * add the files for 'xmedcon' Jpeg Lossless library
1904 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1906 2003-10-21 Jean-Pierre Roux
1907 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1909 2003-10-21 Jean-Pierre Roux
1910 * garbage Siemens 'Leonardo' images dealt with
1911 (the patch is easy to remove)
1912 * cosmetic changes to avoid warnings
1914 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1915 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1916 no need to press 'r' now.
1918 2003-10-20 Jean-Pierre Roux
1919 * upgrade of checkRead.sh checkWrite.sh according
1920 to new Jpeg Lossless decompressor
1921 * add US.3405.1.dcm, a genuine RGB medical file ...
1922 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1923 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1925 2003-10-15 Jean-Pierre Roux
1926 * general anonymisation in gdcmData
1927 * adding the 'color files' from
1928 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1929 * adding some well knowed bugged-header images
1930 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1931 waiting for their inclusion in Python testsuite
1933 2003-10-15 Jean-Pierre Roux
1934 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1935 no longer seg faults when file is not found
1937 2003-10-14 Jean-Pierre Roux
1938 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1941 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1942 * TODO: *.in file to genereate a UseGDCM later
1944 2003-10-14 Jean-Pierre Roux
1945 * Some supposed-to-be Dicom Images have no preamble.
1946 OpenFile takes it into account
1947 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1948 * Missing elements added in dicomV3.dic
1949 (just to be affraid : have a look at
1950 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1951 and do it again next year ;->
1953 2003-10-13 Jean-Pierre Roux
1954 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1955 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1956 But there are NOT. It's fixed !
1958 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1959 * FIX: "jpeglib.h" was not found on VC++
1960 * FIX: vtkgdcm was not being installed
1962 2003-10-10 Jean-Pierre Roux
1963 * ENH : OpenFile closes the file if it *really* doesn't look like
1964 an ACR-NEMA / DICOM one.
1965 * FIX : testWrite no longer writes an empty file if the source file
1966 is not gdcm Readable
1967 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1970 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1971 * FIX: CMake generate now documentation
1972 * ENH: out of source doc build !
1973 * ENH: Generate both user and dev documentation
1974 * ENH: Should work on windows too
1975 * ENH: Only one doxygen config.in file is needed
1976 * FIX: make install should be ok now on ùnix plateform
1977 * FIX: PATH to dictionary was wrong (missing /)
1978 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1980 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1981 * vtkGdcmReader is now able to read rgb dicom file.
1982 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1983 * added a gdcmViewer to vtk test, use mouse to control
1984 window level & window width
1986 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1987 * CMake-ification of gdcm, we have now two build system
1988 * FIX: on cygwin Wsock32 doesn't exist
1989 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1991 2003-10-06 Emanuel Ollart
1992 * FIX : compilation process wad broken.
1993 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1995 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1996 * change gdcmViewer -> vtkgdcmViewer
1997 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1999 2003-10-06 Jean-Pierre Roux
2000 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2001 ( e.g : well known GE images with a wrong elem length,
2002 : Philips MRI Images with a wrong Huffman table)
2003 * still to be done : allow the reading of bugged LEONARDO Siemens images
2005 2003-10-03 Jean-Pierre Roux
2006 * Odd length strings are padded with '\0' (not with spaces,
2007 to remain compliant with already defined strings,
2008 like Transfert Syntax UID and others)
2010 2003-10-03 Jean-Pierre Roux
2011 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2012 to allow displaying RGB images (not only by affim ;-)
2014 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2015 * vtkGdcmReader is now able to read rgb dicom file.
2016 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2018 2003-10-03 Jean-Pierre Roux
2019 * A few nasty patches to allow the reading of a lot of nasty images
2020 ( e.g : well known GE images with a wrong elem length,
2021 : Philips MRI Images with a wrong Huffman table)
2022 * still to be done : allow the reading of bugged LEONARDO Siemens images
2024 2003-10-03 Jean-Pierre Roux
2025 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2027 2003-10-03 Jean-Pierre Roux
2028 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2029 to allow displaying RGB images (not only by affim ;-)
2031 2003-10-03 Jean-Pierre Roux
2032 * gdcmFile::GetImageDataIntoVector now
2033 - deals with MultiFrames MultiFragments Run Length Encoded files
2034 - deals with YcBcR (YBR_FULL) files
2035 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2036 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2038 (no sample found :-(
2040 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2041 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2042 Two reasons: - clear things
2043 - third parties acces gdcm through header files, so won't
2044 suffer anymore VC++ complains
2046 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2047 * add argv[1] in testvtkGdcmReader.cxx
2050 2003-09-24 Jean-Pierre Roux
2051 * The lines are now eigthy characters long.for
2052 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2054 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2055 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2056 char* to std::string. Thus, the use of strdup becomes useless. (see
2057 previous commis of Malaterre)
2058 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2059 before the last Malaterre's commit.
2061 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2062 * This commit should fix the Debug building under VC++, the problem
2063 was mainly a mixture of debug and release lib being loaded at startup.
2064 * I also remove a depency to a specific C function: strdup. Because I had
2065 to force the link to msvcrtd (whereas strdup is in libc).
2067 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2068 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2069 located in the gdcmCommon.h file. All use of reference of tha has been
2070 changed to now use the variable GDCM_UNFOUND.
2072 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2074 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2075 Dicom dictionary. The test suite can now be run again. Note:
2076 I'm note very happy with the " (RET)" changes. I believe this
2077 RETAINED comment should be dropped when parsing the dictionary.
2078 - PACKAGER corrected
2080 - AUTHORS updated and now in alphabetical order
2081 * Makefile.am now exports gdcm.dsw for Windoze users.
2083 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2084 * cygwin complains about missing std:: in subdir Test/
2086 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2087 * remove some methods that are now in gdcmHeaderHelper
2089 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2090 * vtkGdcmReader set spacing and origin correctly
2092 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2093 * Fix a few delete/delete[] mismatch
2095 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2096 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2097 interpretation to data given by gdcmHeader. For instance there are
2098 heuristics to get informations (look at different places).
2099 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2100 sorting DICOM images based on different strategies.
2101 * modified Makefiles accordingly.
2103 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2104 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2105 when building in debug mode
2106 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2107 src/win32/gdcmdll.dsp
2108 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2110 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2111 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2114 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2115 * src/win32/libgdcmjpeg12.dsp was not dos format
2116 * src/win32/libgdcmjpeg12.dsp :
2117 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2118 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2120 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2121 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2123 * src/gdcmFile.cxx : bug fix in affectation type
2124 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2125 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2126 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2127 symbols... future problem ?
2129 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2130 * src/win32/libgdcmijpeg12.dsp was missing
2131 * modified gdcm.dsw accordingly
2133 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2134 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2136 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2137 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2138 commit of JPR (before his hollidays to facilitate our work).
2139 * setup.py : bug fix in code. Modifications made while the last commit
2140 of JPR. The code hasn't been tested before the commit... it's so
2141 useless to make that (for best programmer that is JPR) !!!
2143 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2144 * tagged the current version as Version0_3 (i.e. version 0.3)
2146 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2147 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2148 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2149 * *.dsp : modifications to use new libgdcmijpeg8 library
2150 * setup.py : bug fix on VTKPATH variable
2151 * PACKAGER : adding all concerning windows
2153 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2154 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2156 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2157 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2158 test suite reported error.
2159 * PACKAGER file added (describes what a packager must do when
2160 packaging a new release).
2161 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2162 * configure.in: upgraded version number to 0.3.0
2163 * fixing build of rpm (through rpm -ta):
2164 - Doc/Makefile.am exports proper doxygen files
2165 - src/jpeg/libijg8/Makefile.am exports the include files.
2167 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2168 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2169 * src/gdcmHeader.h : formatting code
2171 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2172 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2173 We were obtaining error message from vtk. Now, creation of file list
2174 is made in an internal list to prevent this problem.
2175 Bug fix when output is empty.
2176 Bug fix in update of progress value. Previous commit for this was a bad
2178 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2180 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2181 * src/gdcmHeader.h : added method to get the file name
2182 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2183 files. Added method to remove all files on the input
2184 Added FIXME comment concerning the bad parsing of header made by
2185 ExecuteInformation method (in ExecuteData method)
2187 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2188 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2189 when using make instal.
2190 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2191 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2193 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2194 * setup.py : adding include dir of jpeg lib to compile all sources
2195 * */Win32/*.dsp : JPR fix for windows compilation
2197 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2198 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2200 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2201 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2203 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2204 * setup.py is again effective on un*x (takes into account the
2205 addon of the jpeg library)
2206 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2207 * Doc/Doxy* updated (includes above enhancements)
2208 * INSTALL now points to web documentation
2210 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2211 * src/gdcmHeader.h doesn't make unnecessary reference to
2213 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2215 * src/gdcm*.[cxx|h] :
2216 - to allow compilation with gcc 3.x
2217 -- clean up of STL usage (added explicit usage of std::)
2218 -- small fixes on exceptions.
2219 Note: linking not tested !
2220 - clean of doxygen comments to avoid warnings at documentation
2222 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2223 dependent convertion).
2225 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2226 * Clean up of previous JPR garbage commit (not even commented in the
2228 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2229 - moved all jpeg related files from src to src/jpeg/libijg8, with
2230 addition/modification of Makefile.am and configure.in.
2231 - the testSuite is still brain damage (not guilty).
2233 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2234 * WrapVTK.py : modifications to get correctly vtk source files to
2236 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2237 (FileName -> Filename)
2239 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2240 * vtk/vtkGdcmReader.[cxx/h]:
2241 - UpdateProgress method should now be effective
2242 - removed the limitation on having only images loaded (as opposed
2244 - when building a stack of images/volume, a lesser number of
2245 gdcmHeader and gdcmFile instances should be used (hopefully
2246 accelerating things).
2247 - when building a stack of images/volumes, files which are not
2248 loadable (wrong path-filename, wrong permissions on existing file,
2249 or file not parsable by gdcm) are replaced with a black image
2250 in the stack (for the caller to notice the problem).
2252 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2253 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2255 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2256 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2257 between standard library (std) and vtk library (problems are found
2258 under Windows... thanks Windows !)
2260 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2261 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2263 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2265 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2266 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2268 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2269 * When compiling with distutils (see setup.py) the C++ compiler is
2270 called with different flags than the default ones (with automake).
2271 In order to fix all those warning, I compiled gdcm with the command
2272 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2273 and went for warning fixes:
2274 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2275 up from unused variables.
2276 - vtk/vtkGdcmReader.cxx: potential bug fix.
2277 * src/gdcmHeader.h: Doxygen warning cleanup
2279 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2280 * gdcmPython/gdcm.i:
2281 - typemaps correction to take into account the systematic replacement
2282 of "using namespace std" with std:: prefix e.g. std::list,
2283 std::string... (cf changes of 2003-05-21).
2284 - gdcmGlob global variable of type gdcmGlobal (defined in
2285 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2286 exported to Python a as cvar.
2287 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2288 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2289 gdcmDictSet.GetPubDictTagNames() and
2290 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2291 C++ static methods).
2292 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2293 with the above changes.
2295 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2296 * setup.py, manifest.in : bug fix under linux
2298 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2299 * Modification of setup.py to compile vtk part too. Then, we have 2
2300 wrappers which must work with same distutils. For that, we have a
2301 generic distutils in distusiltsWrapping.py ; with :
2302 - build_extWrap class to wrap generically all extensions,
2303 - ExtensionWrap base class for all wrapping extension that contains
2305 - Wrapper interface which wrap sources
2306 + In WrapSwig.py we have extension and wrapper for Swig
2307 + In WrapVTK.py we have extension and wrapper for VTK
2308 * MANIFEST.in : modifications to consider vtk directory and new python
2309 files for compilation
2311 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2312 * Added python wrappers of vtkGdcmReader vtk class (see the
2313 source in vtk/vtkGdcmReader.cxx) :
2314 - vtk/Makefile.am now builds a library
2315 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2316 python library (as opposed to _gdcm.so wich are the python
2317 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2318 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2320 - configure.in has an additional flag --enable-vtk that needs
2321 to be set to enable compilation of vtk related code, that is:
2322 + vtk/vtkGdcmReader.so and
2323 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2324 + gdcmPython/vtkgdcmPython.so (see above)
2325 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2326 be read when compressed or when HighBit + 1 != BitsStored),
2327 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2328 the usage of the python wrapper of vtkGdcmReader vtk class.
2329 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2330 * src/*.[h] all occurences of stl classes are now prefixed with
2331 std::, and all occurences of "using namespace std;" where removed.
2332 This is to avoid pollution of global namespace in included files.
2333 Apparently vtk does not avoid this pitfall: when using both
2334 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2335 collision of various stl members (principally cout...).
2336 * gdcmPython/testSuite.py now cleanly removes temprory generated
2338 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2339 comply with above changes)
2341 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2342 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2343 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2344 vtk data structure (an image Flip was required).
2345 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2346 * cosmetic changes in documentation.
2348 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2349 * src/gdcmHeader.cxx: the constructor no longer exits when an
2350 unexisting file is given as argument.
2351 * The subdirectory Data (containing all the images used for the
2352 test suite) is not part of this repository anymore. A new module
2353 containing those images is now available at
2354 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2355 with the name gdcmData.
2356 All the python scripts (including the package initialisation file
2357 gdcmPython/__init__.py) were adapated to take this change into
2358 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2360 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2361 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2362 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2363 demo of the usage of this class.
2364 Compilation of this vtk part is only done when using the --enable-vtk
2365 at configure (or autogen.sh) stage.
2367 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2368 * More memory link related corrections and documentation fixes.
2370 - maximum info is obtained with a command of the form:
2371 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2372 --show-reachable=yes PrintHeader
2373 - the remaining reachable blocks seem to come from the STL
2374 allocation scheme through the usage of map and list. It looks
2375 like this memory cannot be freed but it is not a memory leak
2376 (in fact further invocation to the STL would recollect the
2377 unused memory allthough it cannot explicitely be freed).
2378 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2379 of displaying an image parsed with gdcm and displayed with VTK.
2380 Note: some images don't seem to work e.g.
2381 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2382 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2383 Allthough this weakens the semantics, it is a ditch attempt to
2384 make gdcm more thread friendly.
2386 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2387 * Memory link hunt (by using valgrind through the command
2388 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2389 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2390 gdcmHeader::_dicom_vr.
2391 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2392 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2394 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2396 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2397 * src/Makefile.am now exports all the necessary include files at
2401 * UpdateGroupLength replaced by new one
2404 * UpdateGroupLength re-written using H-Table
2405 (named UpdateGroupLengthNew untill checks are over)
2407 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2408 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2409 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2411 - gdcmHeader::GetPubElValSet removed.
2412 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2413 UpdateGroupLength, WriteElements, Write.
2414 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2415 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2416 carried the same semantics.
2417 - src/gdcmHeaderIdo.cxx changed accordingly.
2418 - gdcmFile::WriteBase now regroups all the codes from previous
2419 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2420 - enum FileType moved to gdcmCommon.h
2421 * src/gdcmHeader.cxx AddDefault trashed
2422 * gdcmGetXSize added
2423 * getimageDataSize now calls gdcmGetXSize
2424 * Test/*.cxx changed to agree with above changes
2426 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2427 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2428 (to avoid double call by end user).
2429 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2430 by end user, since gdcmHeader::gdcmHeader now handles it.
2432 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2433 * gdcm/Doc many doxygen changes:
2434 - Doxyfile now has two different versions, DoxyfileUsers that generates
2435 the html.users end users oriented documentation and
2436 DoxyfileDeveloppers that generates the html.developper developper
2437 oriented documentation.
2438 - README changed accordingly
2439 - requirement.txt removed (old design info moved to TODO).
2440 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2441 DoxyMainPage.txt, DoxyPython.txt provide more information.
2442 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2443 be updated by simply regenerating the docs with doxygen and copying
2444 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2445 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2446 all the tests in the form "if (<map>.count() >1)" were removed.
2447 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2448 ill-formed documentation sections.
2449 * src/gdcmHeader.cxx: ditto
2451 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2452 * setup.py fixed for un*x (needed macro for stdint.h)
2453 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2454 un*ces with sh-utils test utility.
2455 * gdcmPython/demo/test.py renamed to PrintHeader.py
2456 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2457 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2458 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2459 * src/gdcm*.cxx JPR's bad inclusion fixed.
2461 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2462 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2463 * gdcmPython/demo/test.py changed accordingly.
2465 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2466 * gdcmPython/Makefile.am fixed linking against libstdc++
2467 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2468 * Swig subdir (historical tests of swig version 1.3.17++) removed
2469 * Test/testChangeEntete.cxx some lines commented out in order to make
2471 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2472 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2474 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2475 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2476 hence the user doesn't need this explicit call.
2477 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2478 i.e. LoadElements() call removed.
2479 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2480 - src/Makefile.am declares the proper flag for g++.
2481 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2482 for adding user defined new tags.
2483 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2484 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2485 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2487 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2488 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2489 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2490 src/Makefile.am : the project should properly compile and install
2491 with the autotools, included the python wrappers part.
2492 * gdcm.spec.in : added a spec file for RPM packaging.
2494 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2495 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2497 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2498 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2499 to exported to the environement (see gdcmPython/testSuite.py
2501 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2502 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2503 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2504 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2505 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2507 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2508 * gdcmPython/__init__.py doesn't crash anymore when running in
2509 in InstallMode or PreInstallMode but with an environement given
2510 value of GDCM_DICT_PATH.
2511 * src/gdcmDictSet.[cxx/h] coding style.
2513 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2514 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2515 * src/gdcm.h general comments moved to TODO, and README
2516 * src/gdcm.h should now be seen as a user commodity (including it
2517 should suffice to fully use gdcm). It is nowhere including within
2518 any of the kernel files src/*.cxx and src/*.h.
2520 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2521 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2522 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2524 * src/gdcm*.cxx only include their corresponding include file
2525 (as opposed to gdcm.h)
2526 * gdcmPython/gdcm.i changed accordingly
2527 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2528 the autogen.sh generated "make snapshot" command to work.
2529 * autogen.sh removed history related references to crea package.
2531 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2532 * distutilsSwigCPlusPlus.py work around some swig portability
2535 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2536 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2537 was done in a last ditch attempt to get setup.py _really_
2538 operationnal. The python/gdcmPython layaout add the advantage
2539 of hidding away the python related distutils specific files
2540 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2541 Alas, the src directory was out of scope (i.e. it's relative
2542 position to setup.py was ../src) which made things impossible to
2543 handle (see previous version of python/setup.py). Crossing fingers...
2545 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2546 * python/setup.py now works on Un*x. (harder than I thougth)
2547 * python/distutilsSwigCPlusPlus.py can now have include files
2548 among the list of sources.
2550 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2551 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2552 * modifications in MSVC projects
2554 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2555 * As stated by the first lines of Test/ExceptionAndPython/README, it
2556 looks like we can move back to original usage of exception within
2557 src/gdcm* and hence remove the errno stuff that was introduced
2558 as a quick and dirty fixture of this problem (added to the TODO).
2559 * Doc/Doxyfile configuration file for Doxygen and corresponding
2560 README file for usage added.
2561 * Test/testWrite.cxx added. This new test comes from a split of
2562 test.cxx that is now reverted to its original purpous i.e.
2563 testing the proper parsing of a Dicom related file.
2564 testWrite.cxx concentrates on testing the IO part of gdcm.
2565 * Test/bug1.cxx (containing a bug on WIn32) added.
2566 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2567 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2568 whose purpose is to publish the content of the TagNames of the
2569 Dicom public dictionnary were not accessible without an
2570 instance of class gdcmHeader.
2571 - those methods are now static methods of gdcmDictSet and hence
2572 require no instances at all to be invocated.
2573 - within gdcmDictSet this change required to change some method
2574 to class methods (i.e. are now static) among which SetDictPath
2575 (renamed to BuildDictPath) and LoadDefaultPubDict.
2576 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2577 the above changes by calling the new method classes of gdcmDictSet.
2578 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2579 the above to be effective.
2580 * python/gdcmPython: in order to wrap properly the above changes
2581 for Python, swig version now needs to be > 1.3.17.
2582 * python/gdcmPython/Makefile fixed to adapt itself to new
2583 configure/make shema introduced by Johan Montagnat (thanks for the
2584 contribution). Alas this Makefile cannot be turned into a proper
2585 Makefile.am without some heavy changes in the configure.in
2586 (for python dectection).
2587 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2588 now avoids publishing the empty entries.
2590 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2591 * python/setup.py : bug fix concerning install under windows
2592 ExtraPath reused :-P
2593 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2595 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2596 * Dicts/dicomV3.dic : remove double spaces !!!
2597 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2598 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2601 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2602 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2603 method. Doxygenation.
2604 * src/gdcm.h clean up of JPR spurious comments.
2606 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2607 * python/distutilsSwigCPlusPlus.py now properly collects the
2608 shadow classes generated by "swig -c++" (gdcm.py in our case)
2609 when using "python setup.py install".
2610 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2611 reexports the working classes.
2612 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2613 by the classical C errno scheme. This is to prevent an obscure
2614 behavior of the python wrappers when importing wxPython.wx prior
2615 to gdcmPython (which ended up in an abort call). An illustration
2616 of this oddity can be found in the Test/ExceptionAndPython
2617 subdir (see the README file). This problem probably due to
2618 an combination of g++ and dynamic loading.
2619 * added Test/ExceptionAndPython (see above)
2621 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2622 * Changed the layout of the python part to avoid bloating main
2623 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2624 i.e. the distutils arsenal. All the python related stuff is
2625 again in a python subdir, but the package itself is now in
2627 * setup.py was cleaned up:
2628 - pythonIncludePath removed
2629 - python setup.py bdist target is now functional.
2630 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2631 collision with other packages). gdcmPython/demo/*.py changed
2634 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2635 * python subdir moved to gdcmPython (preparation of distutils packaging).
2636 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2637 distutils installer is operational.
2638 * - gdcmPython/__init__.py now properly loads the swig generated
2639 shadow classes (from gdcm.py).
2640 - gdcmPython/demo/*.py changed to import the package gdcmPython
2641 instead of gdcmPython/demo/load.py.
2642 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2644 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2645 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2646 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2647 entries within the associated public Dicom dictionary resp. the same
2648 information but sorted by the fourth field (PAT, IMG, DIR) of the
2650 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2651 are now in the "???" group.
2652 - python/gdcm.i changed accordingly,
2653 - python/demo/printGroupedPublicDict.py added, that gives an example
2654 of the above new functionalities in Python.
2656 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2657 * src/gdcm.h, gdcmHeader.cxx:
2658 - historic references to glib's g_malloc and g_free (#defined)
2659 were definitively removed.
2660 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2661 * src/gdcmElValSet.cxx:
2662 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2663 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2664 - GetElValue(string) renamed to GetElValueByName.
2665 - Added GetElementByName(string).
2666 * src/gdcmHeader.cxx: added
2667 - GetPubElValRepByNumber(guint16, guint16)
2668 - GetPubElValRepByName(string)
2669 - GetShaElValRepByNumber(guint16, guint16)
2670 - GetShaElValRepByName(string)
2671 - GetShaElValByNumber(guint16, guint16)
2672 - GetShaElValRepByName(string)
2673 - GetElValRepByNumber(guint16, guint16)
2674 - GetElValRepByName(string)
2675 - GetElValByNumber(guint16, guint16)
2676 - GetElValRepByName(string)
2677 * Doc/requirements.txt added.
2679 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2680 * Test/Makefile building now depends on the one of libgdcm.so
2681 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2682 pixel data) aware which enables finding the address (offset) of
2683 the pixel data of JPEG encoded DICOM files. This leaves only a single
2684 file in the testSuite whose pixel data address (offset) is unknown.
2685 * python/testSuite.py changed accordingly.
2687 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2688 * VC++ has some strong limitations when working with the STL, as stated
2689 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2690 "Also note that some STL containers (map, set, queue, list, deque)
2691 cannot be exported. [...]
2692 Some STL classes contain nested classes. These classes can not
2694 This is caused by a designed limitation that once a template
2695 class is instantiated, it can not be re-instantiated and
2697 Since our usage of map<> is ubiquitous in gdcm, this "designed
2698 limitation" of VC++ is a pitfall.
2699 Hence the Python wrappers of gdcm cannot be incrementally linked
2700 against the c++ dynamic library. The dirty but only workaround is
2701 to forget about incremental link of dynamic libraries and to generate
2702 the Python wrappers library with the inclusions of the underlying C++
2704 The following modifications concern this matter on Win32/VC++:
2705 - wrapping python correct with standalone wrapped dll (don't use separate
2706 dll under windows !!!!)
2707 - python21_d debug mode enabled (ask Frog how to use it :-)
2708 - NO problem with having an STL member of class for example string in C++
2709 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2710 - Python test of dcmlib in Python is ok under windows on a large set
2712 * removed glib references
2713 * typedef's inserted in gdcm.i for correct swig type management
2715 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2716 * python/demo/*.py load.py extracted from test.py. Added explore.py
2717 that only displays required tags and testAll.py that parses all
2718 the files of the testsuite without using unittest.
2719 * python/testSuite.py other additional test on new files added.
2720 * Data/* new test files added accordingly to the testSuite.
2721 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2722 the vr in the file differs from the one of the dictionary.
2724 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2725 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2726 values, but limits itself to values which are below a user specified
2727 size (by default 1024 bytes).
2728 * python/gdcm.i : elements not loaded (because their size is above the
2729 user specified treshold) are exported with their TagKey as key of the
2730 python dictionary. This enables the testsuite to make some checks
2731 on the unloaded elements (since we have their offset and size).
2732 * python/testSuite.py
2733 - now tests for the existence and proper value of the pixel data
2734 - two new examples added.
2735 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2737 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2738 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2739 aware. See the strategy comments in gdcmHeader::FindeLength().
2740 * Test/test.cxx now accepts a filename as first argument.
2741 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2742 * python/testSuite.py changed to integrate test on above files.
2744 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2745 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2746 the vr was also RET.
2747 * python/testSuite.py more tests added.
2749 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2750 * python/testSuite.py unittest test suite added (uses Data)
2751 * Data/* dcm and acr files for the test suite.
2752 * glib dependance removed from un*x version. We now use ISO C99
2753 7.18 Integer types (see stdint.h)
2754 - python/Makefile, src/Makefile src/gdcm.h
2755 * src/ when an explicit vr (like dicom files) suddenly poped an
2756 implicit element we use to mark the underlying DictEntry of the
2757 concerned ElValue with "Implicit". This strategy was damageable
2758 too the public or provite dictionaries, since some of their vr
2759 would be changed. Since Header::FindLength heavily relies on the
2760 detection by Header::FindVR of falsely explicit elements, I
2761 added an extra ImplicitVr member to ElValue (boolean).
2762 The rest of the changes we the necessary adaptations.
2764 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2765 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2767 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2769 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2770 * Adaptation for porting to VC++:
2772 o forced to use std namespace (for string to be known)
2773 o all class use __declspec export style on WIN32
2774 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2775 (in stdlib.h on Win32 but in std:: for gcc)
2776 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2777 variable GDCM_DICT_PATH.
2778 * src/gdcmHeader.cxx verbose comments made discrete.
2780 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2781 * python/gdcm.i: added a typemap that converts a C++ hashing table
2782 to native Python dictionary.
2783 * python/demo/test.py:
2784 - now uses the native dictionary for exploration of gdcmHeader.
2785 - takes an optional filename argument (the file to parse).
2786 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2787 PubElVals hashing table.
2788 * Dicts/dicomV3.dic removed error prone trailing spaces.
2790 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2791 * Python wrapping process moved away from src/Makefile to
2792 newly created python/Makefile (as well as gdcm.i)
2793 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2794 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2795 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2796 from the environement variable GDCM_DICT_PATH (when existing).
2797 * src/gdcmDict::GetTag bug fix.
2799 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2800 * Straightforward temporary fixes for swig to build the python wrappers.
2801 src/Makefile now has a python working entry [by working we mean
2802 that we can import de shadow classes without errors].
2804 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2805 * hashtest.cxx removed (since allready in Test)
2806 * src/gdcmlib.h renamed to src/gdcm.h
2807 * src/dcm.i renamed to src/gdcm.i
2808 * src/Makefile prepared for python wrapping
2810 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2811 * src/gdcmHeader.cxx :
2812 - Parsing of header is now separated from loading of element values
2813 (see gdcmHeader::LoadElements).
2814 - general clean up of hopefully all file access (creation of
2815 ReadInt16 and ReadInt32)
2817 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2818 * src/gdcmHeader.cxx :
2819 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2821 - SetLgrElem renamed to SetLength
2822 - GetLgrElem renamed to GetLength
2823 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2824 * src/gdcmElValSet.cxx fixed both GetElValue methods
2825 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2826 due to IdoDude was cleaned out.
2828 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2829 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2830 concentrates on finding the value representation (when it exists).
2831 RecupLgr now only finds the element value length, and it avoids
2832 returning the unecessary skL (skipped length).
2833 Also, offsetCourant was simply removed (with taille_fich) since
2834 it was redundant with the File position internals (by using
2835 ftell and fseek). This also made skL (see above in RecupLgr) usage
2837 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2838 on the libido specificities which are handled through class
2840 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2843 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2844 * Truckload of changes. Parsing of header is barely functional
2845 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2847 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2848 * src/gdcmHeader.cxx many addons of low level methods
2850 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2851 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2852 and _IdDcmSWAP_LONG.
2854 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2855 * This corresponds to all the changes decided at the meeting of
2856 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob