1 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
3 collaboration diagram and inheritance diagram should be generated with
5 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
6 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
7 pointlessly wrapped (see
8 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
9 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
10 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
11 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
12 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
13 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
14 -- File::Initialise: PixelConverter setup moved away to
15 PixelConverter::GrabInformationsFromHeader()
16 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
17 interpretation moved away to PixelConverter::BuildRGBImage()
19 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
20 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
21 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
23 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
24 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
25 displayed on Win32 when a brutal abort() occurs (because of uncatched
26 exception). See TODO new entry of this commit for more on this.
27 * TODO added new entry.
28 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
29 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
30 - HandleColor is no longer called from gdcmFile.cxx
31 - gdcmPixelConvert.cxx clean up on method arguments and internal
32 variable names for semantical coherence.
34 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
35 * Finished lossless transition, not only do we now read all lossless jpeg
36 images, without the need of the Cornwell lib, but we do read them properly now
37 * To reduce code (well to avoid code duplication), I defined a common place
38 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
39 redefine symbols. This is not prefect but this the best solution I found for a
40 compilation time jpeg option.
42 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
43 * Update jpeg ijg lib to support lossless jpeg implementation
44 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
46 * Also added a special copyright for dcmtk since we use their bugfixes.
49 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
50 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
51 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
52 matters, as stated in warning note at begining of %include section).
53 * src/gdcmDicomDir*.[cxx|h]: coding style
54 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
55 * src/gdcmJpeg8.cxx: doxygen fix.
56 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
57 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
58 from File:: to PixelConvert::.
60 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
61 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
62 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
63 - more code moved away from File:: to PixelConvert::
64 - fat setup of PixelConverter set in place in File::Initialise.
66 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
67 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
68 namespace at the file system level. So now you should convert your examples
70 gdcmHeader -> gdcm::Header
71 It would be nice if people keep in mind to no open the namespace, since it
72 allows compilation on broken plateform which were defining common symbol in
73 the standart namespace (like LP, Unknown ...)
75 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
76 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
77 The JPEG fragments are now parsed at the same stage than the RLE
78 information. All code related to JPEG is now in gdcmPixelConvert:
79 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
80 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
81 export a gdcmFile:: method. Those are simply global functions
82 (for the time being this is better than having them attach to
83 either gdcmFile:: or gdcmPixelConvert::).
84 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
85 and stores the result in a gdcmJPEGFragmentsInfo.
86 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
87 code (among other stuff) moved away from gdcmFile:; to
90 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
91 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
92 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
93 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
94 clean up of RLE related code.
95 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
96 - src/gdcmRLE.cxx removed
97 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
98 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
99 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
100 * CLEANUP_ROUND (9) for gdcmPixelConvert
101 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
102 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
103 away from gdcmFile:: to gdcmPixelConvert::.
105 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
106 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
107 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
108 This is because Parse7Fe0 used to parse the pixels to compute the
109 length. This task was passed over to FindDocEntryLengthOB() a long
110 time ago, EXCEPT I had forgotten the OW case...
111 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
112 we just recylce the code for parsing RLE fragments and computing
114 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
115 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
116 with the retired Parse7Fe0().
117 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
118 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
120 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
121 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
122 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
123 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
124 - src/CMakeLists.txt: alphabetic order reodering + new entries.
125 * CLEANUP_ROUND (4) for gdcmPixelConvert
126 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
127 to return an unused length.
129 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
130 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
131 this should be cleanner from the plane view. The iostream are erally a pain
132 to use to do simple stuff.
134 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
135 * Redo the compilation of the ijg jpeg library. Now only one source is
136 necesseray. No need to rename file by hand what so ever. CMake handle the
137 copying of the file within different directory, configure header file to
138 modify some symbol. The only addition made to ijg wasd a mangle table so
139 that symbol are different wether we are within 8bits or 12bits.
141 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
142 * Added documentation of vtkgdcmReader on Website:
143 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
144 with it's binary name).
145 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
146 the Website to be more complete.
147 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
148 doxygenated documentation.
149 - Doc/DoxyVtkGdcmReaderExamples.txt added
150 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
151 DoxyVtkGdmReaderExamples.html )
152 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
153 * CLEANUP_ROUND (3) for gdcmPixelConvert
154 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
156 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
157 * CLEANUP_ROUND (2) for gdcmPixelConvert
158 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
160 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
161 * CLEANUP_ROUND for gdcmPixelConvert:
162 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
163 - src/gdcmPixelStuff[h|cxx] removed
164 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
165 - src/CMakeLists.txt changed accordingly
167 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
168 gdcmVersion.py moved to newly created ATTIC related
169 gdcmPython/SetupOldies/ directory.
170 * Autotools clean up:
171 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
172 - autogen.sh configure.in acinclude.m4 python.m4 removed
174 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
175 * src/*.cxx *.h Reference to License.htm fixed to License.html.
176 * Doc/CMakeLists.txt, doxygen.config.in: fix.
177 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
179 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
180 * TODO updated with Mathieu suggestions. I proposed a template for
181 describing TODO entries and used it for new entries.
182 * Added Doc/Website/CodingStyle.html, Developpers.html,
183 DeveloppersPython.html, GdcmDataCvs.html and
184 DownloadVersion0_1.html, DownloadVersion0_3.html.
185 * Some Doc/*.txt Doxygen files (which do not really concern the
186 documentation itself, but the website) moved to html and
187 placed in directory Doc/Website:
188 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
189 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
190 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
191 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
192 * CMakeLists.txt changed accordingly.
193 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
194 DeveloppersPython.html
195 * INSTALL nows refers to Doc/Website/Installation.html
197 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
198 * Added Doc/Website directory, that contains a first raw version
201 2004-09-23 Jean-Pierre Roux
202 * FIX In order not to be poluted any longer by casting problems,
203 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
204 we can now delete[] it safely
205 * VoidArea is now called BinArea (less confusing name),
206 and all the methods called ...VoidArea... are now ... BinArea...
207 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
209 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
210 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
211 clear) TagHT, which is an inherited member of gdcmElementSet. It is
212 up to the destructor of gdcmElementSet to clean up TagHt and it's
215 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
216 * Test/CMakeLists.txt: update to follow gdcmData renamings.
217 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
219 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
220 * ENH: added some utility method that builds a flat dictionnary
221 holding all the Dicom entries contained in the recursive structure
222 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
224 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
225 BuildFlatHashTable() that build a flat dictionary.
226 - src/gdcmElementSet.h: added a new private GetTag() accessor.
227 gdcmDocument is now a friend of gdcmElementSet.
228 - src/gdcmElementSet.cxx: clean up.
229 - Example/FlatHashTablePrint.cxx added.
230 - Example/CmakeLists.txt changed accordingly
232 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
233 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
234 moved away from gdcmDocEntrySet (since this class is an abstract class
235 acting like an interface). SQDepthLevel and BaseTagKey are now
237 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
238 and associated accessors. Doxygenation of the class.
239 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
241 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
242 Use SQDepthLevel accessor instead. ::Print() adapted.
243 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
244 - src/gdcmDocument.cxx changed accordingly.
246 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
247 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
248 - The following is the doxygen comment of the typedef declaration
249 of gdcmagKey in src/gdcmCommon.h:
250 gdcmTagKey is made to old an "universal" (as in URL, Universal
251 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
252 A dicom tag allways has a group and an element, but a set of tags
253 embeded in various (optionally nested) sequences and sharing
254 the same group and element all share the same (group, element)
255 "identifier". Hence the (group, element) cannot be used as an
256 identifier (in gdcm we shall refer to a "TagKey") of a tag.
257 In order to construct a proper tag identifier (i.e. a key) we
258 consider the following definition of a TagKey:
259 - let Group, Element be the string representation of the
260 group and element dicom tag members,
261 - let ItemNumber be the string representation of the integer
262 index of the considered item number of a sequence,
263 Let the key of a tag embeded in a sequence, noted SeqTag, be
265 /ItemNumber#Group|Element
266 where "/", "#" and "|" are characters acting as separators.
267 Then the general form of a gdcmTagKey is given by:
268 Group|Element<SeqTag>
269 where <SeqTag> means NO or many instances of SeqTag.
270 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
273 but the gdcmTagKey of a tag "embeded" is the first item of
274 a sequence, itself nested in the third item of a sequence is the
276 0004|1220/2#0008|0082/0#0008|0090
277 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
278 order to hold the new sequence compatible key. Previously, the
279 GetKey() method would look in the underlying gdcmDictEntry.
280 - src/gdcmDocEntry.cxx:
281 -- constructor now copies the underlying DictEntry key, in the local
283 -- ::Print: displays the member Key, instead of the (group, element).
284 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
285 - src/gdcmDocEntrySet.h:xi
286 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
287 -- now has a new BaseTagKey member.
289 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
290 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
292 This poses the problem with the semantics of the following lines
293 LoadEntryVoidArea(0x0028,0x1201); // R LUT
294 LoadEntryVoidArea(0x0028,0x1202); // G LUT
295 LoadEntryVoidArea(0x0028,0x1203); // B LUT
296 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
297 to the long FIXME note for what the problem is. Nevertheless in
298 order to get things working the dicom dictionary was altered !
299 Please fix things urgently...
300 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
301 information), see above note on moving the member VoidArea. Nevertheless
302 the following entries previously correctly set as US are now inproperly
304 0028 1201 OW IMG Red Palette Color Lookup Table Data
305 0028 1202 OW IMG Green Palette Color Lookup Table Data
306 0028 1203 OW IMG Blue Palette Color Lookup Table Data
307 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
308 of gdcmDocEntry moved to gdcmSeqEntry.
309 * src/gdcmSeqEntry.cxx: STYLE.
311 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
312 * Test/TestAllEntryVerify.cxx minor fix and added comments.
314 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
315 * gdcmPython/testSuite.py: all the test suite in python is now moved
316 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
317 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
318 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
320 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
321 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
322 to avoid inclusion recursion until STL is reached.
323 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
324 mecanism. errno.h is not included in gdcm anymore.
325 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
326 (gdcmFormatError now inherits from gdcmFormatUnexpected).
328 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
329 gdcmData/TestAllEntryVerifyReference.txt
330 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
331 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
332 exception_on_error parameter.
333 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
334 - vtk/vtkGdcmReader.cxx changed accordingly,
335 - Example/*.cxx and Test/*.cxx changed accordingly.
337 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
338 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
339 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
340 enable_sequences removed from gdcmHeader constructor and dependencies.
341 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
342 * gdcmPython/demo/PrintHeader.py: dummy fix.
343 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
344 skip_shadow removed from gdcmHeader constructor and dependencies.
345 * Example/*.cxx and Test/*.cxx changed accordingly.
347 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
348 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
349 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
351 2004-07-21 Jean-Pierre Roux
352 * FIX Now, Parsing and Printing a DICOMDIR do work!
353 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
355 2004-07-20 Jean-Pierre Roux
356 * FIX Some brain damaged headers have Zero-Lenght fields
357 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
359 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
360 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
361 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
362 variable (instance of gdcmDebug) by a definition macro, and the instance
363 is now in static in the gdcmDebug class
364 * src/gdcmSQItem.h : (FIXME) remove an undefined method
365 * Test/PrintAllDocument.cxx : bug fix in the result of the test
367 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
368 * WARNING: ctest now depends more tightly on gdcmData. You should
369 check out gdcmData properly for things to run smoothly...
370 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
371 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
372 we need the pixels not be loaded in order to use the ValEntry
373 that displays position and size).
374 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
375 This is a C++ based equivalent of gdcmPython/testSuite.py that should
376 be deprecated. If you have any doubts about the advantages of a
377 modern scripting language (read Python) versus grass root C++ (i.e.
378 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
379 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
380 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
381 Anyhow, consider documenting the gdcmData images in
382 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
384 * Test/CMakeLists.txt:
385 - now uses TestAllEntryVerify.cxx
386 - specific comments on oldACR00001.ima (now renamed in gdcmData
387 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
388 gdcmData/TestAllEntryVerifyReference.txt
391 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
392 * src/*.[h|cxx] : typedef clean up
393 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
394 - TagKey renamed to gdcmTagKey (for external usage)
395 - VRKey renamed to gdcmVRKey (for external usage)
396 - removal of typedef duplication.
397 - Removed all unecessary inline keyword from class inline definitions.
398 - Some method|function(void) declarations replaced with method|function().
399 * src/jpeg/libijg12/jdhuff12.c:
400 - printf polluting ctest removed.
401 - TAB removal for comminting
403 - TestAllReadCompareDicom.cxx: added a test that compares all the
404 images in gdcmDataImages.h with corresponding images in
405 gdcmData/BaselineDicom/. When baseline images are not present
406 this test creates them.
407 Note: we need to validate each reference image, but before that
408 I'd like to rename them with a more explicit name...
409 - CMakeLists.txt: changed accordingly.
410 * Example/*.cxx: examples now only include gdcm.h (as opposed to
411 including each header needed).
413 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
414 * Test/*.cxx and Example/*.cxx: moved some examples away from the
415 test suite to the Example directory. Are concerned:
420 - TestWriteSimple.cxx
421 * Test/CMakeLists.txt: added some comments on reasons for black listing
422 image gdcmData/oldACR00001.ima
424 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
425 * Test/CmakeList.txt: removed the following from black list (to be coherent
426 with removal from gdcmData):
427 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
428 - gdcm-MR-PHILIPS-16.dcm
430 Added the following because after last cvs update, they cause
431 ctest -R TestReadWriteReadCompare
433 - gdcm-MR-SIEMENS-16-1.acr
435 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
436 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
437 new comments in this file) we temporarily (sigh) move to a weaker
439 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
440 we don't need to black list the following images anymore:
441 - 8BitsUncompressedColor.dcm
443 - US-PAL-8-10x-echo.dcm
444 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
445 fixes and the beautified code ;-)
446 This fixes the bug introduced in version 1.42 (when beautifying)
447 that made the parsing of 8BitsRunLengthColor.dcm unproper.
448 Note: ctest was blind to this bug (this means we need to still
449 improve the test suite). The bug could be detected by using
450 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
452 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
453 and by displaying the (garbage) produced file temp.XDCM...
455 2004-06-29 Jean-Pierre Roux
456 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
457 - replace by uggly but working old code :-(
458 A lot of things should be OK again.
459 It's really urgent to have a test suite that *tests*,
460 to prevent Frog's beautifying sessions to break all the stuff
461 (twice, withing a fortnigh ...)
463 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
464 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
465 redundancy) to added Test/TestReadWriteReadCompare.cxx
466 * Test/CmakeList.txt: because the compare test of
467 Test/TestReadWriteReadCompare.cxx fails, the following images are
468 black listed: - 8BitsUncompressedColor.dcm
470 - US-PAL-8-10x-echo.dcm
471 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
472 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
473 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
474 and ad-hoc kludge. This kludge is now removed, and on encountering
475 such an image (OB field brain damaged) we set errno. Then in
476 ::FindDocLength() we "fix" the length as being ALL what remains
477 in the file (until EOF). We then proceed, hoping for the best...
478 This fixes a SegFault in ShowDicom when trying to write such an
480 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
481 (because TestWriteRead breaks on it, after a non conformal commit?).
482 ctest now runs properly, except for MakeDicomDir (which was allways
483 broken) and the Python related stuff (still not fixed).
485 2004-06-24 Jean-Pierre Roux
486 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
487 FIX : Test/TestReadWrite now iterates on all the file names
488 (instead of infinite loop)
489 ENH : Test/TestWriteRead now iterates on all the file names
491 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
492 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
494 2004-06-24 Jean-Pierre Roux
495 FIX : - now Write drops LUT Descriptors and LUTs (if any)
496 when SamplesPerPixel =3
497 - now Write is no longer confused by
498 'BitsAllocated = 12" and 'BitsStored=12"
499 - "UN" value representation Elements are now written correctly
500 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
501 ENH : - now gdcmHeader has its own Write methods
502 (in order to split the job that has not to be done
505 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
506 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
507 loop on the same image until memory went out.
508 Note: this means we still have gobs of memory loss in PrintDocument
509 * src/gdcmDocument.cxx: fixes problem on parsing on file
510 gdcmData/16BitsJpegLosslessGrayScale.dcm.
512 2004-06-24 Jean-Pierre Roux
513 FIX : Write - All the Sequences and Sequence Item are now written
514 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
515 is added a the end, when necessary.
516 - A lot of brain-damaged images, that were read correctly are
517 now written correctly
518 - length compatible BinEntry are now loaded correctly
519 (even for odd groups)
520 Note : only Explicit Value Representation was checked.
521 (question : is implicit VR really necessary for gdcm ?)
523 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
524 * DEVELOPPER: added a proposition of coding style.
525 * src/gdcmDocEntry.h: removed every inline declaration (for test of
528 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
529 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
530 Use the gdcmDocEntry::Print() and Write() instead.
531 * src/gdcmDocument.cxx: bug fix.
533 2004-06-22 Jean-Pierre Roux
534 FIX : gdcmDocument.cxx
535 - Now we do recognize the JpegLossLess format (there was a misstyping in
536 code 'beautyfication' :-(
537 - Now we automaticaticaly load the Luts, if any
539 2004-06-22 Jean-Pierre Roux
540 In order : to write Sequences, whatever their imbrication level,
541 : to allow user to create his own Sequences
542 a lot of modif where necessary (adding, moving, or virtualising methods)
544 WARNING : save your own sources *before* cvs up !
547 ADD virtual void Write(FILE *fp, FileType filetype);
550 ADD virtual void Write(FILE *fp, FileType filetype);
551 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
554 ADD virtual void Write (FILE *fp, FileType filetype)=0;
555 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
556 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
557 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
558 ADD std::string GetEntryByName(TagName name);
559 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
561 std::string vr = "unkn",
562 std::string fourth = "unkn",
563 std::string name = "unkn");
564 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
565 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
566 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
567 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
568 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
569 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
570 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
571 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
574 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
575 ADD virtual std::string GetEntryByName (TagName tagName);
576 ADD virtual std::string GetEntryVRByName (TagName tagName);
577 REM virtual bool Write(FILE *, FileType);
578 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
579 FILE *_fp, FileType type);
580 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
581 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
582 REM virtual bool WriteEntries(FILE *_fp,FileType type);
583 REM virtual std::string GetEntryByName (std::string tagName);
584 REM virtual std::string GetEntryVRByName (std::string tagName);
585 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
586 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
587 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
589 std::string vr = "unkn",
590 std::string fourth = "unkn",
591 std::string name = "unkn");
592 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
593 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
594 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
595 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
598 ADD virtual void Write(FILE *fp, FileType filetype);
601 ADD virtual void Write(FILE *fp,FileType filetype);
604 ADD virtual void Write(FILE *fp, FileType filetype);
605 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
606 REM std::string GetEntryByNumber(guint16 group, guint16 element);
607 REM std::string GetEntryByName(TagName name);
610 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
612 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
613 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
614 The default constructor invoked by the line
615 gdcmHeader *f1 = new gdcmHeader( header );
616 was gdcmHeader::gdcmHeader(bool) instead of the expected
617 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
618 Hence the parsing wasn't executed... See also below.
619 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
620 as explicit constructor didn't do the trick to fix the above problem.
621 Could anyone explain why ?
622 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
623 properly calls gdcmValEntry::Print() (that was weed out from
624 code related to gdcmBinEntry).
626 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
627 * In order to fix memory leaks:
628 - Test/TestWriteSimple.cxx: added cleaning of free store through
630 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
631 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
632 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
633 (through the call to ::AddDicomDirMeta()) or the destructor
634 would crash when deleting uninitialized ::metaElems].
635 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
636 - src/gdcmDocument.cxx:
637 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
639 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
640 was causing memory leaks.
641 - src/gdcmSQItem.cxx:
642 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
643 cleanly handled with polymophism: sorry but my milage is low).
644 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
645 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
646 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
647 This avoids SegFaulting.
648 - src/gdcmSQItem.h: coding style.
650 - Test/TestWriteSimple still severely sucks. The output image content
651 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
652 damaged when displayed with vtkgdcmViewer.
653 - on memory leaks: TestWriteSimple leaks really less (see entry
654 of 2004-06-18 in Changelog file for the call to valgrind).
655 - on segfaults: ctest now passes all the tests but one (no more
657 * Erroneous leading white fix:
658 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
659 white[s] (as opposed to from >> xxx, that removes it [them].
660 - src/gdcmTS.cxx: ditto.
661 - gdcmPython/testSuite.py: dirty related kludge removed.
662 * src/*: remaining references to gdcmParser removed.
663 * src/*[cxx|h]: added copy[way]left header.
666 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
667 * In order to fix writing of dicom files:
668 - Test/TestWriteSimple.cxx: a simpler example of writing.
669 - Test/CMakeLists.txt changed accordingly.
670 - src/gdcmDocument.cxx:
671 -- The destructor now recursilvely removes potential sequences.
672 -- Bug fix in ::IsJPEG2000()
673 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
674 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
676 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
677 to only declared) and build on top of
678 ::GetDocEntryByNumber(guint16, guint16).
679 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
680 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
681 for usage in destructor and treatement of promotion in
682 ::ReplaceOrCreateByNumber().
683 - src/gdcmSQItem.cxx: destructor should better handle his job.
684 Test/TestWriteSimple now runs (or at least it DOES something).
685 * We can now start hutting memory links. A good starting point is:
686 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
687 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
688 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
690 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
691 * Valgrind note: after Mathieu Malaterre teached me how to read
692 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
694 Using gcc, you can force the STL to use malloc and to free memory as
695 soon as possible by globally disabling memory caching.
696 With 3.2.2 and later, you should export the environment variable
697 GLIBCPP_FORCE_NEW before running your program.
698 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
699 simply vanish (it is still not clear to me, whether this means that
700 STL std::string leaks or if valgrind believes it leaks...).
701 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
702 running bin/gdcmTests makeDicomDir):
703 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
704 - Test/makeDicomDir.cxx now properly traps empty lists and returns
706 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
707 SegFaulting (I drowned in DicomDir related code when trying to
708 understand why the list is empty...).
709 * src/gdcmDocument.h: first BSD license header try.
710 * Doc/License.txt added.
712 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
713 * src/gdcmDocument.[h|cxx]:
714 - Clean up of the Transfer related predicates. They are now all based
715 on new method isGivenTransferSyntax, that (should) handle properly
717 - general clean up, simplification, and coding style.
718 - Specific clean up of Parse7FE0() (umproperly named actually).
719 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
721 2004-06-14 Jean-Pierre Roux
723 - fix the display of Sequence Delimitor (SQDepthLevel pb)
724 - fix the display of SQItem ordinal number
725 - add the GetSQItemByOrdinalNumber method
726 - remove some useless never written private methods
728 2004-06-14 Jean-Pierre Roux
730 - adding a constructor taking a gdcmDocEntry as an input param
731 - ReplaceOrCreateByNumber now returns :
732 a gdcmBinEntry * if a Binary (void *) value is passed as a param
733 a gdcmValEntry * if a string value is passed as a param
735 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
736 according to the param type (no longer sets a gdcmDocEntry)
737 - GetValEntryByNumber, GetBinEntryByNumber added
738 - NewValEntryByNumber and NewBinEntryByNumber added
740 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
742 - GetSQItemNumber and SetSQItemNumber added, to provide
743 a (relative) Item identier inside a given Sequence
744 \warning : some pb remaining around this number
746 - AddEntry now takes the Item Number as a param
748 - adding a constructor taking a gdcmDocEntry as an input param
750 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
751 * Memory leak hunt with the following command:
752 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
753 --show-reachable=yes gdcmTests PrintDocument
754 It looks like many (all?) leaks are due to the STL (or a bad usage
755 of the STL. The lines producing the leaks now have a comment with
756 a "MEMORY LEAK" tag: you can retrieve them with
757 grep "MEMORY LEAK" src/*
758 Here are two typical examples which I can't help fixing:
763 char * test = "babo";
764 name = test; //// <--- valgrind detects 960 bytes lost in
765 //// call to std::string::operator=(char const*)
766 name.clear(); //// Doesn't help !
774 std::cout << "Type a bunch of characters followed by RETURN: ";
775 getline(std::cin, line); //// <--- valgrind dectects a loss
776 //// of 1320 bytes in call to
777 /// std::basic_istream<>& std::getline<>
783 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
784 * src/gdcmHeader.[cxx|h]:
785 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
786 and related, moved away to gdcmDocument.
787 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
788 the corresponding protected accessors of inherited class
789 gdcmDocument, removed ! As a consequence gdcmFile had to be
790 declared friend of class gdcmDocument (see below).
791 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
792 - Clean up of undefined or unused methods.
793 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
794 account the changes to gdcmHeader.h).
795 * src/gdcmDocument.h:
796 - gdcmFile is now a friend class (in order to take into account the
797 changes to gdcmHeader.h).
798 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
799 (see changes to gdcmHeader.h).
800 - Accessors (reading on the form GetEntry*) are now public.
801 - Clean up of undefined or unused methods.
802 * src/gdcmDocument.cxx:
803 - adaptation to changes to gdcmDocument.h
804 - ::OpenFile now writes a verbose message when file cannot be opened.
805 - some std::string properly set to VRKey
806 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
807 references to gdcmDocument.
808 * Test/TestFindTags.cxx: changed accordingly to above changes.
809 * gdcmPython/testSuite.py: adapted to renaming of acr files in
810 cvs repository gdcmData.
812 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
813 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
814 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
815 conflicts with gdcmValEntry::voidArea.
816 * src/gdcmValEntry.cxx: unmatching comment wiped out.
817 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
818 Value representation between StringRepresentable and BinaryRepresentable.
819 * src/gdcmDocument.cxx:
820 - method ParseDES: proper indentation restored and usage of
821 gdcmVR::IsVROfGdcmStringRepresentable wired in.
822 - method LoadDocEntry: the fingerprint left in the SetValue() of
823 unloaded entries (length > MaxSizeLoadEntry) had curiously been
824 removed. Reverting to previous code segment with the proper
825 dynamic_cast< gdcmValEntry* >.
826 Note: this was (partially) breaking the python test suite
827 (gdcmPython/testSuite.py) that made usage of the above
828 fingerprint to check presence of "Pixel Data".
829 * src/gdcmDocEntry.h: coding style.
830 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
831 now taken into account.
832 * gdcmPython/gdcm.i: adaptation to the new internal representation
833 of gdcm (exit gdcmParser, hello gdcmDocument).
834 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
836 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
837 anymore, but instead prints the loaded Python dictionary.
838 * .... alas, the python testSuite is still broken.
840 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
841 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
843 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
844 * src/gdcmUtil.h : export methods
846 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
847 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
849 * Initial addition of automatic python testing
850 * Initial addition of automatic image comparison
852 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
853 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
854 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
856 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
857 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
858 * Test/ShowDicom.cxx : bug fix for msvc compilation
859 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
861 2004-05-04 Jean-Pierre Roux
862 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
863 new concepts (and new classes) :
864 a 'gdcmDocument' is composed of a set of Doc Entries, that are
865 - elementary gdcmDocEntries (former gdcmHeaderEntries)
866 - Sequence Doc Entries (gdcmSeqEntries)
867 a Sequence is composed of Items.
868 Each item is a set of Doc Entries (this is recursive)
869 The non uniqueness of the 'Dicom tag' is due to this recursivity
870 (never taken into account)
871 Our unability to add a new 'entry' in the header
872 at the proper location (neither in the H-Table (map or multimap),
873 nor in the Chained List is also due to this recursivity.
874 Don't try, right now, to use/modify/compile these new sources :
876 We just commit all the stuff, 'as is', in order not to loose it.
878 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
879 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
881 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
882 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
883 file prefix (SetFilePrefix)
885 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
886 * Add a new test: ShowDicom, for now this is just the c++ version of
887 checkRead.sh, later it will be able to compare the image read against a
889 * Replace the DEBUG on the stack with a global entry in cmake interface:
890 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
892 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
893 * Add an example subdir, with a real example on how to read + write a
896 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
897 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
898 * Doc/CMakeLists.txt: the main page is now properly differentiated
899 between the developper and user version.
900 * Doc/doxygen.config.in: dropped search related obsolete flags
901 * src/gdcmParser.h, gdcmHeader.h: doxygenation
903 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
904 * DEVELOPPER: added some helpfull comments for compile/test/install
907 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
908 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
909 src directory, now generated in the build dir.
910 2. Tests as mentionned smarter
912 4. Add a new method in gdcmDict that return the PubDict by name
913 this is interesting for 3rd party lib like ITK,
914 where we could set the institution name / patient name...
916 * ENH: 1. Now the test suite is working for real
917 2. All binaries are now output in the gdcm-bin directory
918 (this was not true before)
920 2004-04-28 Jean-Pierre Roux
921 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
922 SeQuence indented printing of Dicom Header.
923 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
924 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
925 Computation of SQDepthLevel is now part of gdcmHeader constructor
926 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
927 tree-like structure of a Dicom Header.
928 * FIX Test code cleaning
930 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
931 * ENH: Adding automatic testing
932 1. Need a DartConfig.cmake to submit to public
933 2. Add a test driver gdcmTest.cxx
934 3. gdcmTestMain, an helper for the main test driver gdcmTest
935 4. Files in Test don't have a main anymore, this becomes interesting
936 when we add more and more tests, thus dsw don't have to load
938 * ENH: Adding a GDCM_DATA_ROOT for testing
939 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
940 one file instead of seven + some small cleanup
942 2004-04-22 Jean-Pierre Roux
943 * ENH Minor changes to the Print() methods.
944 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
945 Header printing. Example given with :
946 > PrintHeader fileName 2 new
947 (SQ based tree-like structure still to be done for the Header ...)
949 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
950 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
951 1. I have added some unsigned where needed
952 2. Some function parameter not used -> (void)
953 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
954 4. g++ don't like character '\' in comment
955 5. #define jpeg_create_decompress jCreaDecompress
956 this really need to be fixed
957 6. virtualize destructor of gdcmObject ... leakage
958 7. sscanf(g->first.c_str(),"%x",&gr_bid);
959 this also really need to be fixed
960 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
961 remove compression file
962 (as we only do decompression, right ?)
963 * ENH: Change malloc/calloc/free with c++ equivalent
965 2004-04-21 Jean-Pierre Roux
966 * FIX gdcmHeaderHelper::GetXSpacing
967 when a single value is found (bug ?), xpacing is now
968 defaulted to yspacing
970 2004-04-19 Jean-Pierre Roux
971 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
972 * ENH add parameters :
973 bool exception_on_error = false,
974 bool enable_sequences = false,
975 bool ignore_shadow = false
976 to the gdcmFile constructors to be full gdcmParser compliant
977 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
978 to allow reading of PAPYRUS 3.0 files
980 2004-04-06 Jean-Pierre Roux
981 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
983 2004-04-02 Jean-Pierre Roux
984 * ADD : Test/checksequence.sh, for a general recap on SQ pb
985 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
986 for Philips spurious Tag fffe|0000 while rewritting Dicom files
988 2004-03-30 Jean-Pierre Roux
989 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
990 for ACR file, written out as DICOM files (hope so...)
992 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
993 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
994 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
995 moved to base class gdcmParser and only the specialisation is kept
997 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
998 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
999 already does the job.
1000 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1001 (to be consistent with gdcmParser::WriteEntries).
1003 2004-03-30 Benoit Regrain
1004 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1005 upate of the object's instance. It's passed to 2 in the unfavorable
1006 case : one in the ExecuteInformation, one in the ExecuteData
1008 2004-03-29 Jean-Pierre Roux
1009 * ENH : Check on file type to be written moved
1010 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1011 * FIX : gdcmObject::ResetBoundaries now stops properly
1012 when end-of-list is reached
1013 : gdcmVersion modified (as Benoit Regrain asked)
1015 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1016 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1017 * src/gdcmUtil.cxx: added forgotten iostream include.
1018 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1019 equivalent to ExplicitVR in existing code).
1021 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1022 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1023 now contains all the gdcmGlobal related code.
1024 * minor coding style and doxygenation changes.
1026 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1027 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1028 now contains all the Debug related code.
1029 * minor clean-up of includes in src/*.cxx
1030 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1031 CreateCleanString) removed.
1032 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1033 * Doc/DoxyMainPageUser.txt added.
1034 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1035 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1036 src/gdcmDirList.cxx)
1038 2004-03-24 Jean-Pierre Roux
1039 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1041 2004-03-23 Jean-Pierre Roux
1042 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1043 big endian made volumes
1044 * ENH Now gdcmParser constructor and destructor are protected to forbid
1045 end user to instanciate class gdcmParser
1046 (only gdcmHeader and gdcmDicomDir are meaningfull)
1048 2004-03-22 Benoit Regrain
1049 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1050 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1051 gdcmSerie to gdcmDicomDirSerie
1053 2004-03-19 Jean-Pierre Roux
1054 * ENH Now the tree-like structure describing a DICOMDIR comming from
1055 an already existing DICOMDIR file is consistent with
1056 the home-made tree-like structure build ex-nihilo
1057 or build from the files held (recursively) in a Directory
1058 functions gdcmDicomDir::CheckBoundaries()
1059 gdcmObject::SetBoundaries() added
1061 2004-03-17 Jean-Pierre Roux
1062 * REM (Eric Boix bug) : removal of meaningless
1063 gdcmDicomDirImage::NewImage function.
1064 * FIX now file names and directory name are written properly in the
1066 * FIX now gdcmDicomDir constructor may be call without any trick
1069 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1070 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1071 of gdcmDicomDirImage::NewImage as empty function.
1073 2004-02-28 Jean-Pierre Roux
1074 * ENH add gdcmDicomDir:NewPatient
1075 add gdcmDicomDirPatient:NewStudy
1076 add gdcmDicomDirStudy:NewSerie
1077 add gdcmDicomDirSerie:NewImage
1078 to allow making gdcDicomDir object.
1079 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1080 (as opposite to the gdcmHeader chained list)
1082 2004-02-11 Benoit Regrain
1083 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1084 when using from python
1086 2004-02-10 Benoit Regrain
1087 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1088 * FIX : in gdcmDicomDir when the directory is empty
1089 * ENH : add callback and methods to get the progression of dicomDir
1092 2004-02-06 Jean-Pierre Roux
1093 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1094 - GDCM_META added to gdcmDicomDirType
1095 - class gdcmMeta created
1096 * ENH : - A brief summary is now displayed at the beginning of
1097 'testDicomDir' to help disaster magnitude estimation
1098 * REM : Now useless Test/explDICOMDIR.cxx
1100 2004-02-05 Benoit Regrain
1101 * ENH : add methods in gdcmObject to get the hash table or the list of
1103 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1104 * FIX : wrapping python for TagHeaderEntryHT
1106 2004-02-04 Benoit Regrain
1107 * FIX : even length for some strings when writting the dicom dir
1108 * FIX : sort the images in the dicom dir
1109 * FIX : Bug fix for python use of dicom dir
1110 * ADD : a python demo
1112 2004-02-04 Jean-Pierre Roux
1113 * FIX : Final solution (?) for icone embedded images
1114 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1115 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1116 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1117 gdcmData/gdcm-MR-SIEMENS-16.acr1
1118 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1119 to make full checking easier
1121 2004-02-04 Benoit Regrain
1122 * FIX : WriteEntries : coding style & logic in parameters
1123 * FIX : Set the elements to create the DicomDir in a dictionary file
1125 2004-02-03 Benoit Regrain
1126 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1127 * gdcmDicomDir : add the load of directory
1128 * Bug fix and print add-on
1130 2004-02-03 Jean-Pierre Roux
1131 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1132 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1133 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1134 * FIX gdcmParser.cxx : 'group length' elements are now considered
1135 as integers, even for shadow groups, when file is Implicit VR
1137 2004-02-02 Jean-Pierre Roux
1138 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1140 of the last synonym :-(
1141 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1143 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1144 * FIX taking into account the possible 7fe0,0010 multiplicity
1145 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1146 to allow removal of references to 7fe0,0010, to deal with
1147 ACR-NEMA images, when 0028,0200 is meaningfull
1149 2004-01-31 Jean-Pierre Roux
1150 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1151 no longer writes 'Un' on disk
1152 * FIX SQ elements with actual length are now dealt with corectly
1153 * FIX gdcmFile::WriteBase make the difference, for color images, between
1154 the length (for Palette expanded images)
1155 and Raw Length (non expanded image + Palette)
1156 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1157 (that broke Write). Replaced by UL.
1158 Aware user will reload the field if he
1159 thinks it's necesssary
1161 2004-01-30 Jean-Pierre Roux
1162 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1163 when 'dirty Acr' is found, to be compliant with the new
1164 IsReadable() methods.
1166 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1167 (no DOUBLE images in kosher DICOM,
1168 but so usefull for people that miss them ;-)
1170 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1171 DICOMDIR related utilities (not checked as Windoze compliant)
1173 2004-01-28 Jean-Pierre Roux
1174 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1176 2004-01-27 Jean-Pierre Roux
1177 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1178 to allow skipping the shadow elements, to save memory space.
1179 The TRUE value for this param has to be used
1180 with a FALSE value for the 'enable_sequence' param.
1181 ('public elements' may be embedded in 'shadow Sequences')
1182 * gdcmHeader methods now deal with 'embedded icones images' in the header
1183 (even when an 'icone image sequence' is announced by the
1184 element (0x0088,0x0200), but there is NO icone at all ...
1186 * gdcmHeader sometimes Image Location value doesn't follow
1187 the supposed processor endianity (see gdcmData/cr172241.dcm).
1190 * gdcmHeader add the method
1191 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1192 to get *all* the Header Entries with the same tag.
1193 GetHeaderEntrySameName is probabely *useless*
1194 (no meaning : Name is *not* an identifier within the Dictionnary)
1196 2004-01-26 Benoit Regrain
1197 * Bug fix in the print of hexadecimal representations. Remove long fields
1198 in the print and add a third level of print to print them
1200 2004-01-23 Benoit Regrain
1201 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1202 * Bug fix on test suite after remove the strip made on not string fields
1203 * Split the IsReadable method between gdcmParser which test that the file
1204 is dicom and gdcmHeader which test that it's an image file
1206 2004-01-22 Benoit Regrain
1207 * DicomDir : clean code, add methods, set variables in protected or private
1208 * gdcmUtil : bug fix for the clean string method
1210 2004-01-19 Benoit Regrain
1211 * Add the use of shadow dictionaries
1212 * bug fix and coding style
1214 2004-01-19 Benoit Regrain
1215 * src/gdcmFile.cxx : bug fix concerning the close of file
1216 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1217 * Add the update of header entries using the shadow library
1219 2004-01-19 Benoit Regrain
1220 * removal of file gdcmHeader2.cxx
1221 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1222 inheriting from gdcmParser. This split is to prepare the integration
1223 of dicom dir parsing
1224 * bug fix under python
1226 2004-01-16 Jean-Pierre Roux
1227 * REM removal of class gdcmHeaderEntrySet
1228 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1229 * ADD add file gdcmHeader2.cxx
1230 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1232 2004-01-15 Benoit Regrain
1233 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1234 entries created while parsing the header. Thus, they will be destroyed
1235 when the gdcmDictSet will be destroyed
1236 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1239 2004-01-15 Benoit Regrain
1240 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1241 made a fatal error because of the memory release at the end of program.
1242 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1243 some memory and vtk seems to have some problems with that.
1244 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1246 2004-01-14 Benoit Regrain
1247 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1248 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1249 * src/*.[h|cxx] : make changes due to class name changes
1250 * gdcmPython/demo/*.py : bug fix due to method names
1252 2004-01-13 Benoit Regrain
1253 * src/*.[h|cxx] : coding style
1254 * vtk/*.[h|cxx] : coding style
1256 2004-01-13 Benoit Regrain
1257 * gdcmPython/testSuite.py : test the readable flag of file for tests
1258 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1259 It's lied to the stl compilation by MSVC (windows, always windows...)
1260 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1262 2004-01-12 Benoit Regrain
1263 * src/*.h : add comments
1264 * src/gdcmDictSet.h : set the method BuildDictPath in public
1265 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1266 directly setted in the source code
1267 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1270 2004-01-09 Benoit Regrain
1271 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1272 * setup.py : use a reference to gdcmVERSION
1274 2004-01-07 Benoit Regrain
1275 * Modification to compile with the distutils.
1278 2003-12-10 Benoit Regrain
1279 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1280 can use a gdcmHeaderHelper to load datas
1281 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1282 made in the source code
1284 2003-12-10 Benoit Regrain
1285 * Update Windows projects and .cvsignore files
1287 2003-11-12 Jean-Pierre Roux
1288 * ENH gdcmHeader constructor has one more parameter (default value : false)
1289 that allows the user to 'go inside' the SeQuences only
1291 gdcmElValSet:Print takes it into account
1293 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1294 * ENH: Update gdcmPython/CMakeLists
1295 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1296 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1298 2003-11-10 Jean-Pierre Roux
1299 * FIX : gdcmHeader::LoadElements is now based
1300 on the ListTag listElem member,
1301 not longer on the TagElValueHT tagHt member
1302 * ENH : PrintPubElVal shows (temporarily) both results,
1303 with the tagHt member and the listElem member.
1304 (it's easier to 'see' the problems when using Printheader)
1306 * FIX : old private member LgrElem is now splitted into
1307 ReadLength : Length actually found on disk (updated only
1308 if bug fixing is necessary), for internal
1310 UsableLength : Updated by FixFoundLength, to fix a bug
1311 or to allow Parser going on.
1312 Will allow to re-write a kosher header when a SeQuence
1313 with a length (not 0000) is found
1314 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1315 because gdcmElValSet::Add does not update ListElem
1318 2003-11-07 Jean-Pierre Roux
1319 * FIX misstyping in Transfert Syntax name table
1320 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1321 when they have an actual length (not 0000 nor FFFFF)
1322 (Nobody should care of it, but DICOMDIR explorers)
1324 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1325 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1327 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1328 * ENH: vtkGdcmReader now supports LUT !
1329 (vtkgdcmViewer for now is not able to use them though)
1331 2003-11-05 Jean-Pierre Roux
1332 * in testSuite.py : new files names for checking the package
1333 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1334 that returns the pixel area size to the *aware* (vtk) user
1335 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1337 2003-11-05 Benoit Regrain
1338 * in testSuite.py : Modify the rules for checking the paths
1339 : Explicit error messages
1340 * in __init__.py : Related modif
1342 2003-11-03 Jean-Pierre Roux
1343 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1344 to be used by aware (vtk) users that want to manage
1345 LUT (and no to turn the PALETTE image into an RGB pixels one)
1346 * GetPixelType now returns 8U for 24 Bits images
1347 (vtkGdcmReader compliant)
1349 2003-10-31 Jean-Pierre Roux
1350 * Removal of *all* gdcmData images and add them again
1351 in order to loose the 'history' of un-anonymised images
1353 2003-10-31 Jean-Pierre Roux
1354 * RMV : removal of useless jBitsInJsample.h
1355 for both 8 and 12 Bits JPEG Lossy Libraries
1357 2003-10-31 Jean-Pierre Roux
1358 * ENH : Add the functions gdcmFile::GetImageDataRaw
1359 gdcmFile::GetImageDataIntoVectorRaw
1360 that act as GetImageData and GetImageDataIntoVector
1361 except the making of an RGB Plane from Gray Plane + LUT
1362 Intended to aware (vtk) users who know how to manage
1365 GetLUTRGBA return a R,G,B,A LUT if any
1366 lgrTotaleRaw gives the 'Raw' length
1367 GetImageDataRaw returns the gray Plane
1368 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1369 (They stay Grey, just like with other Dicom viewers :-(
1371 2003-10-30 Jean-Pierre Roux
1372 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1374 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1375 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1376 being coherents dicom files.
1378 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1379 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1381 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1382 * ENH: Two steps is necessary to please VC++ compiler...
1383 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1384 * ENH: Add include dir to medcon lib
1385 * FIX: only one function is being exported for now !
1386 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1388 2003-10-29 Jean-Pierre Roux
1389 * adding gdcmHeader::GetLUTRGBA
1390 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1391 --> Mathieu, the modif u're waiting for is not yet committed
1392 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1394 2003-10-27 Jean-Pierre Roux
1395 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1396 00191113.dcm DermaColorLossLess.dcm
1397 MxTwinLossLess.dcm RadBWLossLess.dcm
1398 * ENH: For version prior to vtkImageViewer2 -r 1.19
1399 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1401 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1402 * Removal of ido stuff in CMakeLists.txt
1404 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1405 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1406 * FIX: remove a call to ->Modified ... see comments
1407 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1409 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1410 * FIX: Problem with path for libvtkgdcmPython
1411 * ENH: Try adding a search script for python site-package
1412 * RMV: Remove some file from medcon lib that are not necessary
1413 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1414 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1415 * FIX: More pragma disable fro VC++,
1416 I don't think I break something as it is also disable in VTK/ITK.
1417 But it fasten debug compilation time.
1419 2003-10-23 Jean-Pierre Roux
1420 * gdcm now deals with 16 Bits Run Length Encoded images
1421 (they are compressed as 2 planes images,
1422 one for the high Bytes, the other for low Bytes)
1424 2003-10-22 Jean-Pierre Roux
1425 * Now CheckRead takes into account :
1426 - the bugged 'Leonardo' Siemens images
1427 - the XA images, sent thru the burning VPRO station
1428 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1431 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1432 * FIX: When copying a Makefile.am to CMakeLists.txt
1433 one should remove the '\'
1435 2003-10-22 Jean-Pierre Roux
1436 * in gdcmData adding a bugged 'Leonardo' Siemens image
1437 (wrong lengths in header)
1438 OK with gdcm, KO with the other viewers :-)
1439 * add a GE dlx XA image, thru the VEPRO burning station
1442 2003-10-21 Jean-Pierre Roux
1443 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1444 for a brutal checking of vtkgdcmViewer compliance
1446 2003-10-21 Jean-Pierre Roux
1447 * add the files for 'xmedcon' Jpeg Lossless library
1448 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1450 2003-10-21 Jean-Pierre Roux
1451 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1453 2003-10-21 Jean-Pierre Roux
1454 * garbage Siemens 'Leonardo' images dealt with
1455 (the patch is easy to remove)
1456 * cosmetic changes to avoid warnings
1458 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1459 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1460 no need to press 'r' now.
1462 2003-10-20 Jean-Pierre Roux
1463 * upgrade of checkRead.sh checkWrite.sh according
1464 to new Jpeg Lossless decompressor
1465 * add US.3405.1.dcm, a genuine RGB medical file ...
1466 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1467 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1469 2003-10-15 Jean-Pierre Roux
1470 * general anonymisation in gdcmData
1471 * adding the 'color files' from
1472 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1473 * adding some well knowed bugged-header images
1474 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1475 waiting for their inclusion in Python testsuite
1477 2003-10-15 Jean-Pierre Roux
1478 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1479 no longer seg faults when file is not found
1481 2003-10-14 Jean-Pierre Roux
1482 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1485 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1486 * TODO: *.in file to genereate a UseGDCM later
1488 2003-10-14 Jean-Pierre Roux
1489 * Some supposed-to-be Dicom Images have no preamble.
1490 OpenFile takes it into account
1491 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1492 * Missing elements added in dicomV3.dic
1493 (just to be affraid : have a look at
1494 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1495 and do it again next year ;->
1497 2003-10-13 Jean-Pierre Roux
1498 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1499 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1500 But there are NOT. It's fixed !
1502 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1503 * FIX: "jpeglib.h" was not found on VC++
1504 * FIX: vtkgdcm was not being installed
1506 2003-10-10 Jean-Pierre Roux
1507 * ENH : OpenFile closes the file if it *really* doesn't look like
1508 an ACR-NEMA / DICOM one.
1509 * FIX : testWrite no longer writes an empty file if the source file
1510 is not gdcm Readable
1511 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1514 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1515 * FIX: CMake generate now documentation
1516 * ENH: out of source doc build !
1517 * ENH: Generate both user and dev documentation
1518 * ENH: Should work on windows too
1519 * ENH: Only one doxygen config.in file is needed
1520 * FIX: make install should be ok now on ùnix plateform
1521 * FIX: PATH to dictionary was wrong (missing /)
1522 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1524 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1525 * vtkGdcmReader is now able to read rgb dicom file.
1526 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1527 * added a gdcmViewer to vtk test, use mouse to control
1528 window level & window width
1530 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1531 * CMake-ification of gdcm, we have now two build system
1532 * FIX: on cygwin Wsock32 doesn't exist
1533 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1535 2003-10-06 Emanuel Ollart
1536 * FIX : compilation process wad broken.
1537 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1539 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1540 * change gdcmViewer -> vtkgdcmViewer
1541 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1543 2003-10-06 Jean-Pierre Roux
1544 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1545 ( e.g : well known GE images with a wrong elem length,
1546 : Philips MRI Images with a wrong Huffman table)
1547 * still to be done : allow the reading of bugged LEONARDO Siemens images
1549 2003-10-03 Jean-Pierre Roux
1550 * Odd length strings are padded with '\0' (not with spaces,
1551 to remain compliant with already defined strings,
1552 like Transfert Syntax UID and others)
1554 2003-10-03 Jean-Pierre Roux
1555 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1556 to allow displaying RGB images (not only by affim ;-)
1558 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1559 * vtkGdcmReader is now able to read rgb dicom file.
1560 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1562 2003-10-03 Jean-Pierre Roux
1563 * A few nasty patches to allow the reading of a lot of nasty images
1564 ( e.g : well known GE images with a wrong elem length,
1565 : Philips MRI Images with a wrong Huffman table)
1566 * still to be done : allow the reading of bugged LEONARDO Siemens images
1568 2003-10-03 Jean-Pierre Roux
1569 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1571 2003-10-03 Jean-Pierre Roux
1572 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1573 to allow displaying RGB images (not only by affim ;-)
1575 2003-10-03 Jean-Pierre Roux
1576 * gdcmFile::GetImageDataIntoVector now
1577 - deals with MultiFrames MultiFragments Run Length Encoded files
1578 - deals with YcBcR (YBR_FULL) files
1579 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1580 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1582 (no sample found :-(
1584 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1585 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1586 Two reasons: - clear things
1587 - third parties acces gdcm through header files, so won't
1588 suffer anymore VC++ complains
1590 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1591 * add argv[1] in testvtkGdcmReader.cxx
1594 2003-09-24 Jean-Pierre Roux
1595 * The lines are now eigthy characters long.for
1596 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1598 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1599 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1600 char* to std::string. Thus, the use of strdup becomes useless. (see
1601 previous commis of Malaterre)
1602 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1603 before the last Malaterre's commit.
1605 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1606 * This commit should fix the Debug building under VC++, the problem
1607 was mainly a mixture of debug and release lib being loaded at startup.
1608 * I also remove a depency to a specific C function: strdup. Because I had
1609 to force the link to msvcrtd (whereas strdup is in libc).
1611 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1612 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1613 located in the gdcmCommon.h file. All use of reference of tha has been
1614 changed to now use the variable GDCM_UNFOUND.
1616 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1618 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1619 Dicom dictionary. The test suite can now be run again. Note:
1620 I'm note very happy with the " (RET)" changes. I believe this
1621 RETAINED comment should be dropped when parsing the dictionary.
1622 - PACKAGER corrected
1624 - AUTHORS updated and now in alphabetical order
1625 * Makefile.am now exports gdcm.dsw for Windoze users.
1627 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1628 * cygwin complains about missing std:: in subdir Test/
1630 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1631 * remove some methods that are now in gdcmHeaderHelper
1633 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1634 * vtkGdcmReader set spacing and origin correctly
1636 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1637 * Fix a few delete/delete[] mismatch
1639 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1640 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1641 interpretation to data given by gdcmHeader. For instance there are
1642 heuristics to get informations (look at different places).
1643 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1644 sorting DICOM images based on different strategies.
1645 * modified Makefiles accordingly.
1647 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1648 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1649 when building in debug mode
1650 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1651 src/win32/gdcmdll.dsp
1652 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1654 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1655 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1658 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1659 * src/win32/libgdcmjpeg12.dsp was not dos format
1660 * src/win32/libgdcmjpeg12.dsp :
1661 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1662 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1664 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1665 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1667 * src/gdcmFile.cxx : bug fix in affectation type
1668 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1669 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1670 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1671 symbols... future problem ?
1673 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1674 * src/win32/libgdcmijpeg12.dsp was missing
1675 * modified gdcm.dsw accordingly
1677 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1678 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1680 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1681 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1682 commit of JPR (before his hollidays to facilitate our work).
1683 * setup.py : bug fix in code. Modifications made while the last commit
1684 of JPR. The code hasn't been tested before the commit... it's so
1685 useless to make that (for best programmer that is JPR) !!!
1687 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1688 * tagged the current version as Version0_3 (i.e. version 0.3)
1690 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1691 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1692 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1693 * *.dsp : modifications to use new libgdcmijpeg8 library
1694 * setup.py : bug fix on VTKPATH variable
1695 * PACKAGER : adding all concerning windows
1697 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1698 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1700 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1701 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1702 test suite reported error.
1703 * PACKAGER file added (describes what a packager must do when
1704 packaging a new release).
1705 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1706 * configure.in: upgraded version number to 0.3.0
1707 * fixing build of rpm (through rpm -ta):
1708 - Doc/Makefile.am exports proper doxygen files
1709 - src/jpeg/libijg8/Makefile.am exports the include files.
1711 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1712 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1713 * src/gdcmHeader.h : formatting code
1715 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1716 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1717 We were obtaining error message from vtk. Now, creation of file list
1718 is made in an internal list to prevent this problem.
1719 Bug fix when output is empty.
1720 Bug fix in update of progress value. Previous commit for this was a bad
1722 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1724 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1725 * src/gdcmHeader.h : added method to get the file name
1726 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1727 files. Added method to remove all files on the input
1728 Added FIXME comment concerning the bad parsing of header made by
1729 ExecuteInformation method (in ExecuteData method)
1731 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1732 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1733 when using make instal.
1734 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1735 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1737 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1738 * setup.py : adding include dir of jpeg lib to compile all sources
1739 * */Win32/*.dsp : JPR fix for windows compilation
1741 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1742 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1744 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1745 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1747 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1748 * setup.py is again effective on un*x (takes into account the
1749 addon of the jpeg library)
1750 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1751 * Doc/Doxy* updated (includes above enhancements)
1752 * INSTALL now points to web documentation
1754 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1755 * src/gdcmHeader.h doesn't make unnecessary reference to
1757 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1759 * src/gdcm*.[cxx|h] :
1760 - to allow compilation with gcc 3.x
1761 -- clean up of STL usage (added explicit usage of std::)
1762 -- small fixes on exceptions.
1763 Note: linking not tested !
1764 - clean of doxygen comments to avoid warnings at documentation
1766 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1767 dependent convertion).
1769 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1770 * Clean up of previous JPR garbage commit (not even commented in the
1772 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1773 - moved all jpeg related files from src to src/jpeg/libijg8, with
1774 addition/modification of Makefile.am and configure.in.
1775 - the testSuite is still brain damage (not guilty).
1777 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1778 * WrapVTK.py : modifications to get correctly vtk source files to
1780 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1781 (FileName -> Filename)
1783 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1784 * vtk/vtkGdcmReader.[cxx/h]:
1785 - UpdateProgress method should now be effective
1786 - removed the limitation on having only images loaded (as opposed
1788 - when building a stack of images/volume, a lesser number of
1789 gdcmHeader and gdcmFile instances should be used (hopefully
1790 accelerating things).
1791 - when building a stack of images/volumes, files which are not
1792 loadable (wrong path-filename, wrong permissions on existing file,
1793 or file not parsable by gdcm) are replaced with a black image
1794 in the stack (for the caller to notice the problem).
1796 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1797 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1799 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1800 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1801 between standard library (std) and vtk library (problems are found
1802 under Windows... thanks Windows !)
1804 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1805 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1807 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1809 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1810 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1812 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1813 * When compiling with distutils (see setup.py) the C++ compiler is
1814 called with different flags than the default ones (with automake).
1815 In order to fix all those warning, I compiled gdcm with the command
1816 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1817 and went for warning fixes:
1818 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1819 up from unused variables.
1820 - vtk/vtkGdcmReader.cxx: potential bug fix.
1821 * src/gdcmHeader.h: Doxygen warning cleanup
1823 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1824 * gdcmPython/gdcm.i:
1825 - typemaps correction to take into account the systematic replacement
1826 of "using namespace std" with std:: prefix e.g. std::list,
1827 std::string... (cf changes of 2003-05-21).
1828 - gdcmGlob global variable of type gdcmGlobal (defined in
1829 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1830 exported to Python a as cvar.
1831 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1832 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1833 gdcmDictSet.GetPubDictTagNames() and
1834 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1835 C++ static methods).
1836 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1837 with the above changes.
1839 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1840 * setup.py, manifest.in : bug fix under linux
1842 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1843 * Modification of setup.py to compile vtk part too. Then, we have 2
1844 wrappers which must work with same distutils. For that, we have a
1845 generic distutils in distusiltsWrapping.py ; with :
1846 - build_extWrap class to wrap generically all extensions,
1847 - ExtensionWrap base class for all wrapping extension that contains
1849 - Wrapper interface which wrap sources
1850 + In WrapSwig.py we have extension and wrapper for Swig
1851 + In WrapVTK.py we have extension and wrapper for VTK
1852 * MANIFEST.in : modifications to consider vtk directory and new python
1853 files for compilation
1855 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1856 * Added python wrappers of vtkGdcmReader vtk class (see the
1857 source in vtk/vtkGdcmReader.cxx) :
1858 - vtk/Makefile.am now builds a library
1859 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1860 python library (as opposed to _gdcm.so wich are the python
1861 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1862 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1864 - configure.in has an additional flag --enable-vtk that needs
1865 to be set to enable compilation of vtk related code, that is:
1866 + vtk/vtkGdcmReader.so and
1867 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1868 + gdcmPython/vtkgdcmPython.so (see above)
1869 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1870 be read when compressed or when HighBit + 1 != BitsStored),
1871 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1872 the usage of the python wrapper of vtkGdcmReader vtk class.
1873 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1874 * src/*.[h] all occurences of stl classes are now prefixed with
1875 std::, and all occurences of "using namespace std;" where removed.
1876 This is to avoid pollution of global namespace in included files.
1877 Apparently vtk does not avoid this pitfall: when using both
1878 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1879 collision of various stl members (principally cout...).
1880 * gdcmPython/testSuite.py now cleanly removes temprory generated
1882 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1883 comply with above changes)
1885 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1886 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1887 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1888 vtk data structure (an image Flip was required).
1889 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1890 * cosmetic changes in documentation.
1892 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1893 * src/gdcmHeader.cxx: the constructor no longer exits when an
1894 unexisting file is given as argument.
1895 * The subdirectory Data (containing all the images used for the
1896 test suite) is not part of this repository anymore. A new module
1897 containing those images is now available at
1898 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1899 with the name gdcmData.
1900 All the python scripts (including the package initialisation file
1901 gdcmPython/__init__.py) were adapated to take this change into
1902 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1904 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1905 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1906 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1907 demo of the usage of this class.
1908 Compilation of this vtk part is only done when using the --enable-vtk
1909 at configure (or autogen.sh) stage.
1911 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1912 * More memory link related corrections and documentation fixes.
1914 - maximum info is obtained with a command of the form:
1915 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1916 --show-reachable=yes PrintHeader
1917 - the remaining reachable blocks seem to come from the STL
1918 allocation scheme through the usage of map and list. It looks
1919 like this memory cannot be freed but it is not a memory leak
1920 (in fact further invocation to the STL would recollect the
1921 unused memory allthough it cannot explicitely be freed).
1922 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1923 of displaying an image parsed with gdcm and displayed with VTK.
1924 Note: some images don't seem to work e.g.
1925 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1926 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1927 Allthough this weakens the semantics, it is a ditch attempt to
1928 make gdcm more thread friendly.
1930 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1931 * Memory link hunt (by using valgrind through the command
1932 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1933 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1934 gdcmHeader::_dicom_vr.
1935 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1936 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1938 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1940 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1941 * src/Makefile.am now exports all the necessary include files at
1945 * UpdateGroupLength replaced by new one
1948 * UpdateGroupLength re-written using H-Table
1949 (named UpdateGroupLengthNew untill checks are over)
1951 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1952 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1953 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1955 - gdcmHeader::GetPubElValSet removed.
1956 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1957 UpdateGroupLength, WriteElements, Write.
1958 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1959 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1960 carried the same semantics.
1961 - src/gdcmHeaderIdo.cxx changed accordingly.
1962 - gdcmFile::WriteBase now regroups all the codes from previous
1963 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1964 - enum FileType moved to gdcmCommon.h
1965 * src/gdcmHeader.cxx AddDefault trashed
1966 * gdcmGetXSize added
1967 * getimageDataSize now calls gdcmGetXSize
1968 * Test/*.cxx changed to agree with above changes
1970 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1971 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1972 (to avoid double call by end user).
1973 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1974 by end user, since gdcmHeader::gdcmHeader now handles it.
1976 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1977 * gdcm/Doc many doxygen changes:
1978 - Doxyfile now has two different versions, DoxyfileUsers that generates
1979 the html.users end users oriented documentation and
1980 DoxyfileDeveloppers that generates the html.developper developper
1981 oriented documentation.
1982 - README changed accordingly
1983 - requirement.txt removed (old design info moved to TODO).
1984 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1985 DoxyMainPage.txt, DoxyPython.txt provide more information.
1986 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1987 be updated by simply regenerating the docs with doxygen and copying
1988 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1989 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1990 all the tests in the form "if (<map>.count() >1)" were removed.
1991 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1992 ill-formed documentation sections.
1993 * src/gdcmHeader.cxx: ditto
1995 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1996 * setup.py fixed for un*x (needed macro for stdint.h)
1997 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1998 un*ces with sh-utils test utility.
1999 * gdcmPython/demo/test.py renamed to PrintHeader.py
2000 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2001 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2002 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2003 * src/gdcm*.cxx JPR's bad inclusion fixed.
2005 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2006 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2007 * gdcmPython/demo/test.py changed accordingly.
2009 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2010 * gdcmPython/Makefile.am fixed linking against libstdc++
2011 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2012 * Swig subdir (historical tests of swig version 1.3.17++) removed
2013 * Test/testChangeEntete.cxx some lines commented out in order to make
2015 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2016 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2018 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2019 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2020 hence the user doesn't need this explicit call.
2021 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2022 i.e. LoadElements() call removed.
2023 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2024 - src/Makefile.am declares the proper flag for g++.
2025 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2026 for adding user defined new tags.
2027 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2028 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2029 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2031 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2032 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2033 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2034 src/Makefile.am : the project should properly compile and install
2035 with the autotools, included the python wrappers part.
2036 * gdcm.spec.in : added a spec file for RPM packaging.
2038 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2039 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2041 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2042 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2043 to exported to the environement (see gdcmPython/testSuite.py
2045 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2046 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2047 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2048 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2049 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2051 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2052 * gdcmPython/__init__.py doesn't crash anymore when running in
2053 in InstallMode or PreInstallMode but with an environement given
2054 value of GDCM_DICT_PATH.
2055 * src/gdcmDictSet.[cxx/h] coding style.
2057 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2058 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2059 * src/gdcm.h general comments moved to TODO, and README
2060 * src/gdcm.h should now be seen as a user commodity (including it
2061 should suffice to fully use gdcm). It is nowhere including within
2062 any of the kernel files src/*.cxx and src/*.h.
2064 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2065 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2066 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2068 * src/gdcm*.cxx only include their corresponding include file
2069 (as opposed to gdcm.h)
2070 * gdcmPython/gdcm.i changed accordingly
2071 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2072 the autogen.sh generated "make snapshot" command to work.
2073 * autogen.sh removed history related references to crea package.
2075 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2076 * distutilsSwigCPlusPlus.py work around some swig portability
2079 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2080 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2081 was done in a last ditch attempt to get setup.py _really_
2082 operationnal. The python/gdcmPython layaout add the advantage
2083 of hidding away the python related distutils specific files
2084 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2085 Alas, the src directory was out of scope (i.e. it's relative
2086 position to setup.py was ../src) which made things impossible to
2087 handle (see previous version of python/setup.py). Crossing fingers...
2089 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2090 * python/setup.py now works on Un*x. (harder than I thougth)
2091 * python/distutilsSwigCPlusPlus.py can now have include files
2092 among the list of sources.
2094 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2095 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2096 * modifications in MSVC projects
2098 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2099 * As stated by the first lines of Test/ExceptionAndPython/README, it
2100 looks like we can move back to original usage of exception within
2101 src/gdcm* and hence remove the errno stuff that was introduced
2102 as a quick and dirty fixture of this problem (added to the TODO).
2103 * Doc/Doxyfile configuration file for Doxygen and corresponding
2104 README file for usage added.
2105 * Test/testWrite.cxx added. This new test comes from a split of
2106 test.cxx that is now reverted to its original purpous i.e.
2107 testing the proper parsing of a Dicom related file.
2108 testWrite.cxx concentrates on testing the IO part of gdcm.
2109 * Test/bug1.cxx (containing a bug on WIn32) added.
2110 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2111 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2112 whose purpose is to publish the content of the TagNames of the
2113 Dicom public dictionnary were not accessible without an
2114 instance of class gdcmHeader.
2115 - those methods are now static methods of gdcmDictSet and hence
2116 require no instances at all to be invocated.
2117 - within gdcmDictSet this change required to change some method
2118 to class methods (i.e. are now static) among which SetDictPath
2119 (renamed to BuildDictPath) and LoadDefaultPubDict.
2120 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2121 the above changes by calling the new method classes of gdcmDictSet.
2122 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2123 the above to be effective.
2124 * python/gdcmPython: in order to wrap properly the above changes
2125 for Python, swig version now needs to be > 1.3.17.
2126 * python/gdcmPython/Makefile fixed to adapt itself to new
2127 configure/make shema introduced by Johan Montagnat (thanks for the
2128 contribution). Alas this Makefile cannot be turned into a proper
2129 Makefile.am without some heavy changes in the configure.in
2130 (for python dectection).
2131 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2132 now avoids publishing the empty entries.
2134 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2135 * python/setup.py : bug fix concerning install under windows
2136 ExtraPath reused :-P
2137 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2139 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2140 * Dicts/dicomV3.dic : remove double spaces !!!
2141 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2142 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2145 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2146 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2147 method. Doxygenation.
2148 * src/gdcm.h clean up of JPR spurious comments.
2150 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2151 * python/distutilsSwigCPlusPlus.py now properly collects the
2152 shadow classes generated by "swig -c++" (gdcm.py in our case)
2153 when using "python setup.py install".
2154 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2155 reexports the working classes.
2156 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2157 by the classical C errno scheme. This is to prevent an obscure
2158 behavior of the python wrappers when importing wxPython.wx prior
2159 to gdcmPython (which ended up in an abort call). An illustration
2160 of this oddity can be found in the Test/ExceptionAndPython
2161 subdir (see the README file). This problem probably due to
2162 an combination of g++ and dynamic loading.
2163 * added Test/ExceptionAndPython (see above)
2165 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2166 * Changed the layout of the python part to avoid bloating main
2167 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2168 i.e. the distutils arsenal. All the python related stuff is
2169 again in a python subdir, but the package itself is now in
2171 * setup.py was cleaned up:
2172 - pythonIncludePath removed
2173 - python setup.py bdist target is now functional.
2174 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2175 collision with other packages). gdcmPython/demo/*.py changed
2178 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2179 * python subdir moved to gdcmPython (preparation of distutils packaging).
2180 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2181 distutils installer is operational.
2182 * - gdcmPython/__init__.py now properly loads the swig generated
2183 shadow classes (from gdcm.py).
2184 - gdcmPython/demo/*.py changed to import the package gdcmPython
2185 instead of gdcmPython/demo/load.py.
2186 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2188 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2189 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2190 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2191 entries within the associated public Dicom dictionary resp. the same
2192 information but sorted by the fourth field (PAT, IMG, DIR) of the
2194 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2195 are now in the "???" group.
2196 - python/gdcm.i changed accordingly,
2197 - python/demo/printGroupedPublicDict.py added, that gives an example
2198 of the above new functionalities in Python.
2200 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2201 * src/gdcm.h, gdcmHeader.cxx:
2202 - historic references to glib's g_malloc and g_free (#defined)
2203 were definitively removed.
2204 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2205 * src/gdcmElValSet.cxx:
2206 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2207 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2208 - GetElValue(string) renamed to GetElValueByName.
2209 - Added GetElementByName(string).
2210 * src/gdcmHeader.cxx: added
2211 - GetPubElValRepByNumber(guint16, guint16)
2212 - GetPubElValRepByName(string)
2213 - GetShaElValRepByNumber(guint16, guint16)
2214 - GetShaElValRepByName(string)
2215 - GetShaElValByNumber(guint16, guint16)
2216 - GetShaElValRepByName(string)
2217 - GetElValRepByNumber(guint16, guint16)
2218 - GetElValRepByName(string)
2219 - GetElValByNumber(guint16, guint16)
2220 - GetElValRepByName(string)
2221 * Doc/requirements.txt added.
2223 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2224 * Test/Makefile building now depends on the one of libgdcm.so
2225 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2226 pixel data) aware which enables finding the address (offset) of
2227 the pixel data of JPEG encoded DICOM files. This leaves only a single
2228 file in the testSuite whose pixel data address (offset) is unknown.
2229 * python/testSuite.py changed accordingly.
2231 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2232 * VC++ has some strong limitations when working with the STL, as stated
2233 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2234 "Also note that some STL containers (map, set, queue, list, deque)
2235 cannot be exported. [...]
2236 Some STL classes contain nested classes. These classes can not
2238 This is caused by a designed limitation that once a template
2239 class is instantiated, it can not be re-instantiated and
2241 Since our usage of map<> is ubiquitous in gdcm, this "designed
2242 limitation" of VC++ is a pitfall.
2243 Hence the Python wrappers of gdcm cannot be incrementally linked
2244 against the c++ dynamic library. The dirty but only workaround is
2245 to forget about incremental link of dynamic libraries and to generate
2246 the Python wrappers library with the inclusions of the underlying C++
2248 The following modifications concern this matter on Win32/VC++:
2249 - wrapping python correct with standalone wrapped dll (don't use separate
2250 dll under windows !!!!)
2251 - python21_d debug mode enabled (ask Frog how to use it :-)
2252 - NO problem with having an STL member of class for example string in C++
2253 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2254 - Python test of dcmlib in Python is ok under windows on a large set
2256 * removed glib references
2257 * typedef's inserted in gdcm.i for correct swig type management
2259 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2260 * python/demo/*.py load.py extracted from test.py. Added explore.py
2261 that only displays required tags and testAll.py that parses all
2262 the files of the testsuite without using unittest.
2263 * python/testSuite.py other additional test on new files added.
2264 * Data/* new test files added accordingly to the testSuite.
2265 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2266 the vr in the file differs from the one of the dictionary.
2268 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2269 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2270 values, but limits itself to values which are below a user specified
2271 size (by default 1024 bytes).
2272 * python/gdcm.i : elements not loaded (because their size is above the
2273 user specified treshold) are exported with their TagKey as key of the
2274 python dictionary. This enables the testsuite to make some checks
2275 on the unloaded elements (since we have their offset and size).
2276 * python/testSuite.py
2277 - now tests for the existence and proper value of the pixel data
2278 - two new examples added.
2279 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2281 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2282 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2283 aware. See the strategy comments in gdcmHeader::FindeLength().
2284 * Test/test.cxx now accepts a filename as first argument.
2285 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2286 * python/testSuite.py changed to integrate test on above files.
2288 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2289 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2290 the vr was also RET.
2291 * python/testSuite.py more tests added.
2293 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2294 * python/testSuite.py unittest test suite added (uses Data)
2295 * Data/* dcm and acr files for the test suite.
2296 * glib dependance removed from un*x version. We now use ISO C99
2297 7.18 Integer types (see stdint.h)
2298 - python/Makefile, src/Makefile src/gdcm.h
2299 * src/ when an explicit vr (like dicom files) suddenly poped an
2300 implicit element we use to mark the underlying DictEntry of the
2301 concerned ElValue with "Implicit". This strategy was damageable
2302 too the public or provite dictionaries, since some of their vr
2303 would be changed. Since Header::FindLength heavily relies on the
2304 detection by Header::FindVR of falsely explicit elements, I
2305 added an extra ImplicitVr member to ElValue (boolean).
2306 The rest of the changes we the necessary adaptations.
2308 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2309 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2311 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2313 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2314 * Adaptation for porting to VC++:
2316 o forced to use std namespace (for string to be known)
2317 o all class use __declspec export style on WIN32
2318 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2319 (in stdlib.h on Win32 but in std:: for gcc)
2320 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2321 variable GDCM_DICT_PATH.
2322 * src/gdcmHeader.cxx verbose comments made discrete.
2324 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2325 * python/gdcm.i: added a typemap that converts a C++ hashing table
2326 to native Python dictionary.
2327 * python/demo/test.py:
2328 - now uses the native dictionary for exploration of gdcmHeader.
2329 - takes an optional filename argument (the file to parse).
2330 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2331 PubElVals hashing table.
2332 * Dicts/dicomV3.dic removed error prone trailing spaces.
2334 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2335 * Python wrapping process moved away from src/Makefile to
2336 newly created python/Makefile (as well as gdcm.i)
2337 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2338 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2339 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2340 from the environement variable GDCM_DICT_PATH (when existing).
2341 * src/gdcmDict::GetTag bug fix.
2343 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2344 * Straightforward temporary fixes for swig to build the python wrappers.
2345 src/Makefile now has a python working entry [by working we mean
2346 that we can import de shadow classes without errors].
2348 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2349 * hashtest.cxx removed (since allready in Test)
2350 * src/gdcmlib.h renamed to src/gdcm.h
2351 * src/dcm.i renamed to src/gdcm.i
2352 * src/Makefile prepared for python wrapping
2354 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2355 * src/gdcmHeader.cxx :
2356 - Parsing of header is now separated from loading of element values
2357 (see gdcmHeader::LoadElements).
2358 - general clean up of hopefully all file access (creation of
2359 ReadInt16 and ReadInt32)
2361 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2362 * src/gdcmHeader.cxx :
2363 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2365 - SetLgrElem renamed to SetLength
2366 - GetLgrElem renamed to GetLength
2367 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2368 * src/gdcmElValSet.cxx fixed both GetElValue methods
2369 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2370 due to IdoDude was cleaned out.
2372 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2373 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2374 concentrates on finding the value representation (when it exists).
2375 RecupLgr now only finds the element value length, and it avoids
2376 returning the unecessary skL (skipped length).
2377 Also, offsetCourant was simply removed (with taille_fich) since
2378 it was redundant with the File position internals (by using
2379 ftell and fseek). This also made skL (see above in RecupLgr) usage
2381 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2382 on the libido specificities which are handled through class
2384 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2387 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2388 * Truckload of changes. Parsing of header is barely functional
2389 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2391 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2392 * src/gdcmHeader.cxx many addons of low level methods
2394 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2395 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2396 and _IdDcmSWAP_LONG.
2398 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2399 * This corresponds to all the changes decided at the meeting of
2400 May 23 2002. Needless to say we are running late...