1 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Testing/TestSequence.cxx : add test for sequences of images... test that
3 we have the same serie or the same study UID
5 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
8 * src/gdcmDict.h : remove commented code
9 * src/gdcmDocument.cxx : initialize values
10 * src/gdcmFile.cxx : bug fix when reading values
11 * gdcmPython/demo/ : change file names. Remove useless files
13 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
14 * src/gdcmFile.cxx : remove the default array of initialization.
15 The static array contained pointers to non-static values (comming from
16 strings). To have coherences, when creating files, these values can't be
17 static. So, the array can't be static, too ! To simplify, the array have
18 been replaced by repeted lines to insert values in the File
20 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
21 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
22 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
24 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
25 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
26 (Dicom Element) into the Sequence Item
28 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
29 * src/*.cxx : first parss to normalize file organisation
31 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * src/gdcmDirList.[h|cxx] : add method to find a directory
33 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
35 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
36 * Finish cleaning up my JPEG mess. Should be ok now.
37 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
38 contained within the RLE* class(doh!)
40 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
41 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
42 * SerieHeader::AddFileName() creates as many Coherent Files lists
43 (same Serie UID) as it founds different Serie UID
44 amongst the files instead of discarting any file
45 that doesn't match with the first one he found.
46 * SerieHeader::OrderGdcmFileList has now one parameter :
47 the Coherent Files list the user wants to sort
48 * SerieHeader::GetFirstCoherentFileList() |
49 * SerieHeader::GetLastCoherentFileList() | allow to parse
50 the set of Coherent Files lists
51 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
52 compatibility (it returns the *first* Coherent Files list,
53 since there was only one before)
54 * Test/TestSerieHeader gets gdcmData as a default root directory
56 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
57 * Remove friend between DocEntry and File classes
58 * Remove friend between PixelReadConverter and RLEFramesInfo,
61 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
62 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
63 0002|0000. The value was incorrect.
65 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
66 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
68 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
69 * src/gdcmUtil.cxx : compilation fix on Win32
70 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
71 variable, to be easy found. Add methods to change the default UID.
72 Amelioration of the CreateUniqueUID to use the correct default UID.
73 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
76 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * Test/TestVR.cxx : fix memory leaks
79 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
80 * Rewrite the base 256 to base 10 conversion, using string operation only.
81 This allows us to get rid of the problematic 64bits integer type (does not
82 always exist on target platform).
84 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
85 * Add construct and destructor to class gdcm::Debug to close the debug file
87 * Don't let uset to open twice the same file
88 * gdcm has now an official UID prefix,
89 supplied by http://www.medicalconnections.co.uk
90 1.2.826.0.1.3680043.2.1143
91 (Thx to Mathieu for providing URL)
92 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
93 to be able to perform some more tests
94 * gdcm::ContentEntry : Contructors and Destructor are now protected,
95 in order to be sure no user will try to use them.
96 (at user level, only the children classes are meaningfull)
98 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
99 * move RLEInfo & JPEGInfo from Document to File
101 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
102 * FIX : remove so many friend between classes
104 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
105 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
106 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
108 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
109 In order to avoid missbehaviour :
110 . gdcm::DocEntry is now specialized in
111 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
112 - gdcm::ContentEntry (Dicom entry with a 'content')
113 . gdcm::ContentEntry is specialized in
114 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
115 characters value, or integers)
116 - gdcm::BinEntry (Dicom entry with a non strig representable value
117 (user hasn't any longer to thing about the precedence of his dynamic_casts)
119 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
120 * Test/VTKTest*.cxx : bug fix under linux
122 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
123 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
124 use with python. Some methods are moved from Document to ElementSet or
125 DocEntrySet. The equivalent methods to ElementSet have been added to
126 SQItem and are virtual in DocEntrySet. Methods that may have the same code
127 in SQItem and ElementSet is directly placed in DocEntrySet
129 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
130 * Test/VTKTest*.cxx : remove the show variable in each test method because
131 it's useless (the viewer variable replace this variable)
133 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
134 * src/gdcmDocument.cxx : bug fix on potential memory leak
135 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
136 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
137 Add ClearXxx methods to remove all the content of the list or map
138 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
140 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
141 * methods ReplaceOrCreate renamed as Insert
142 (nobody will be any longer confused by 'CreateOrReplace')
144 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
145 * Grealty simplify the JPEg decompression, no need to differenciate based on
146 the JPEG possible type (with/without fragment, with/without multiple frame).
147 Everything is done throught the JPEG IO Suspension mechanism in IJG
149 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
150 * Stage 3 of normalization :
151 in order to avoid any missunderstanding while reading method names :
152 - All the methods xxxEntry now deal with dicom Entries
153 - Methods GetEntry splitted into
156 - Method SetEntry renamed as SetEntryValue
157 - Method SetEntryBinArea let as it was
159 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
160 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
161 - Position correctly the entry points for JPEG2000 and JPEG-LS
162 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
164 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
165 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
166 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
167 with other method names
168 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
169 * Test/TestDicomDirElement.cxx : add new test
171 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
172 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
173 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
174 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
175 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
176 So can't you use __int64 in ostream at all.
178 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
179 * bug fix for compilation on MSVC6
180 * gdcmPython/gdcm.i : rename of classes missed
182 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
183 * Stage 2 of names normalization :
184 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
185 (easy to understand ...)
186 - gdcm::FileHelper replaces old class gdcm::File
188 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
189 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
190 type and not a string. So, there remove problems on the format of the
193 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
194 * Add Example/TestPapyrus.cxx
195 - reads a Papyrus file (gdcm::Header compliant),
196 - gets the pixels of all the images, using low level iterators
197 - writes an multiframes Dicom image.
198 (Just to show it's *possible* to do that)
199 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
202 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
203 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
204 Thus, DicomDirXXX are created with a flad that indicates if the created
205 object is empty or not (when not empty, the DicomDirElement is used to
208 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
209 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
210 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
212 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
213 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
215 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
216 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
217 Remove all access to the hash-tables or lists in the objects.
219 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
220 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
221 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
222 be complient with all the gdcm source code
224 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
225 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
228 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
229 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
232 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
233 * Test/ : rename VTK tests to have a best name for the tests
234 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
235 GetFirstEntry/GetNextEntry use
237 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
238 * In SerieHeader::ImagePositionPatientOrdering()
239 // a Dicom 'Serie' may contain scout views
240 // and images may have differents directions.
241 // -> More than one may have the same 'pos'
242 // Sorting has then NO meaning !
243 Thx to Eduardo Davila for reporting bug.
245 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
246 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
247 test. Now it's on image content and not on the resulting visualisation...
248 might solve the problem on linux when using the OpenGL drivers
250 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
251 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
252 DicomDirSerie, DicomDirImage
253 Dict, DictSet classes :
254 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
255 -remove InitTraversal method.
256 * UPD Test programs + Example programs
258 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
259 * remove useless and never updated keyword \ingroup
260 * Solve pb when structure (list, map, ...) is empty.
261 Thx to Benoit for reporting bug
263 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
264 * Taking into account of 'Transfer Syntax' value
265 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
268 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
269 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
270 is no memory access violation
271 * gdcmPython/demo : add python demos using VTK
273 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
274 * FIX 'Dictionnary' is now spelt 'Dictionary'
275 'wether' is now spelt 'whether'
276 'archieve' is now spelt 'archive' ;-)
278 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
279 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
280 related methods, in order not to expose internal mechanisms
283 * REM methods that exposed internal mechanisms :
284 DicomDir::GetDicomDirPatients()
285 DicomDirPatient::GetDicomDirStudies()
286 DicomDirStudy::GetDicomDirSeries()
287 DicomDirSerie::GetDicomDirImages()
288 * UPD Test programs :
292 * UPD Example program
294 * ADD DictSet methods
298 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
299 * Removed the Print/indent/default parameter mess. There is absolutely no
300 reason to have to methods, moreover with the second taking the ostream as
301 *SECOND* parameter. This was clearly a bad hack to get things compile.
303 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
304 * Complete rewrite of the GetMacAddress code. Now the code is *much*
305 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
306 Unfortunately the main code does not work on SunOS, thus provide a specific
307 code for this platform only (and Win32 of course). Since this seems to be
308 working, change CreateUniqueUID to use GetMACAddress instead of the
309 problematic GctestetIPAddress
311 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
312 * Unfortunately to be able to test gdcmDirList I had to break the API
313 a little. Now the class is not a std::list anymore but has a member
314 std::vector (more ITK compatible). Allow unit testing on Win32 and
317 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
318 * Update SerieHeader to take into account a Serie Instance UID to properly
321 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
322 * ENH - Comment out Mathieu's (dangerous) Super Hack
323 for dealing with BIGENDIAN processors
324 - Move equivalent stuff to BinEntry::WriteContent
325 When necessary, 16 Bits Pixels are swapped in a small buffer
326 and then written. This avoid allocating a huge buffer, in
327 PixelWriteConvertor, and avoid modifying the Pixel Area.
329 Probabely, the same operation will have to be done when we want
330 to write image with Big Endian Transfert Syntax,
331 and we are working on Little Endian Processor
333 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
334 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
336 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
337 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
338 all the dict content.
339 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
341 * Test/TestDict.cxx : add a new test for the dict classes
343 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
344 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
345 file. Debug is yanked if compiled with NDEBUG
347 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
348 * src/gdcmDictSet.h : set the default output to the os variable
349 * src/gdcmDictEntry.[h|cxx] : add the Print method
350 * gdcmPython/demo/ : add a new test
352 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
353 * merging of Test/PrintDicomDir and Test/TestDicomDir
354 * removal of now redundant Test/PrintDicomDir
355 * enhancement of Example/PrintDicomDir
357 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
358 * Now, python test might work on systems
359 * Add the PrintDicomDir test
361 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
362 * FIX : First entry following group 0002 was lost for
363 Explicit Big Endian Transfer Syntax files
364 (group and elem not swaped)
366 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
367 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
368 Big Endian Transfer Syntax supposed the group following 0002
369 begins always by element 0000 (element 0000 is *optional*)
370 To avoid further troubles, let's be pessimistic, and use
371 Document::HandleOutOfGroup0002() method
372 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
373 (related pb not yet solved)
375 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
376 * Bug fix for the python part use
377 * Now, PrintHeader.py pass... but outside the ctest use. shit !
379 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
380 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
382 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
383 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
384 a string and should ask the global TS dict what are the propreties of
387 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
388 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
389 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
390 to swap the Swap Code, at parsing time, when we come out of group 0002
391 and Transfer Syntax is Big Endian
392 We should be able to read now 'true DICOM" Big Endian coded images
393 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
394 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
396 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
397 * Hopefully fix the bug on MacOSX and static global initialization.
398 This is the only -minor- patch I found that both please MacOSX and VS6.
399 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
400 but this would require a lot of change. Another approach would be that Global
401 create those string and GDCM_UNFOUND becomes a pointer to a string (which
402 gdcm::Global would destroy at exit).
404 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
405 * Fix bug on MacOSX with static initialization in a multy threaded
406 environment. static const string in a header file used to be ill
407 initialized provoquing the freeze of any tests. patch should solve this
410 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
411 * According to Benoit's suggestion, and without any objection from anybody
412 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
413 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
414 - method gdcmDicomDirObject::GetEntry() renamed as
415 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
417 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
418 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
419 you debug/warning message just as c++ streams which make them very convinient
420 to use. Once this is stabilize I will change the ostringstrem to be
421 redirected to a file (ofstream).
422 * Properly support C99 extension: __FUNCTION__ which allow us to display
423 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
425 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
426 * Removal of useless and dangerous methods :
427 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
428 GetDocEntryByName, GetEntryByName, GetDictEntryByName
429 * Removal of usless methods :
430 Dict::PrintByName, Dict::GetDictEntryByName
431 * Commenting out of probabely useless methods :
432 Dict::GetDictEntryNames()
433 Dict::GetDictEntryNamesByCategory()
434 DictSet::GetPubDictEntryNames()
435 DictSet::GetPubDictEntryNamesByCategory()
436 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
437 * ENH : Use dicomTS.dic as described in 2004 version
438 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
439 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
440 Add Accessors on VM (Value Multiplicity), and VM related methods
441 * ADD : Add a list of 'Dicom Attribute types', as found in
442 http://medical.nema.org/dicom/2004/04_15PU.PDF
444 * ADD : Add dicomGroupNameAbbreviations.dic
445 should be used to write a method to replace the former
446 Dict::GetDictEntryNamesByCategory()
448 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
449 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
450 to read in the file... and only it ! Length is the efective length of the
451 data in the DocEntry structure
453 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
454 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
455 And now use a static function call instead, with a global variable. i
456 This is much closer to the VTK approach. Hopefully should be bulletproof
457 and easier to use...hopefully
459 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
460 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
462 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
463 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
465 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
466 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
467 ValEntry, BinEntry, SeqEntry creation or replace
469 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
470 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
471 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
473 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
474 when specifying the VR
475 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
476 * src/gdcmDocEntry.cxx : amelioration of print
478 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
479 * ADD : Add the method Util::IsCurrentProcessorBigEndian
480 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
481 * ADD Method Document::ComputeGroupLength
482 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
483 in order to allow further VR modification by user
484 * REM : removal of once-called method File::WriteBase
485 integration of its code in formerly one-line method File::Write
487 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
488 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
489 replace the different values "??", "Unkn", "Unknown".
490 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
491 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
492 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
493 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
495 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
496 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
498 * Set the gdcm::Base class to some Printable classes
500 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
501 * src/gdcmFile.[h|cxx] : add the Print method
502 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
503 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
504 * src/gdcmDocument.h : remove the PrintLevel informations
505 * Example/PrintFile.cxx : use the new gdcm::File::Print
507 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
508 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
509 problems when compiling with the python wrapping
511 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
512 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
513 writting in ImplicitVR
515 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
516 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
517 JPEG decompression, especially when dicom frames are split into several
518 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
519 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
521 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
522 * src/gdcmHeader.cxx : change the initialisation of default header.
523 Now, this header is readable by gdm, e-film, DicomWorks
525 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
526 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
527 Rename Decompressed to Raw
528 * Use the API changes in gdcm::File.
529 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
532 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
533 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
534 each added entry in the header. Replace the 'Planes' field by the 'Number
537 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
538 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
539 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
541 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
542 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
543 At this time, this image isn't readable by e-film... waiting JPR help to
546 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
547 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
548 DocEntry. Now use methods of the Document !
550 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
551 * Test/ShowDicomSeq.cxx : bug fix
553 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
554 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
555 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
556 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
557 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
559 * Test/TestCopyRescaleDicom.cxx : remove unused variable
560 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
561 containing found sequences
563 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
564 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
566 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
567 Some fields in BinEntry must be copied to not seg fault when making the :
568 gdcm::File *copy = new gdcm::File( copyH );
569 and tests are now made on good variables
571 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
572 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
573 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
575 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
576 * Add vtkGdcmWriter example and test
578 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
579 * Test/TestUtil.cxx : reformat the source code
580 * vtk/vtkGdcmReader.cxx : remove and change prints
581 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
583 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
584 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
586 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
587 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
588 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
590 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
591 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
592 by an eof to prevent all bad read of the file... and in this case, the
595 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
596 * Example/Volume2Dicom.cxx : comment unused variables
597 * Test/PrintDicomDir.cxx : comment unused variables
598 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
599 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
600 method that is redondant with AddEntry.
601 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
604 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
605 * Bug fix due my last commit (compilation under Windows).
606 * Example/Volume2Dicom : bug fix in the file and reformatting source code
607 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
609 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
611 - Remove printf / sprintf
612 - include iostream AFTER gdcm so we don't get warnings
613 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
615 - Also remove tons of include from header files, hopefully this should
616 speeup the compilation time, since it was becoming a dog slow.
617 - Remove gdcm.h as it include way too many files and slow down compilation
618 (plus it is not up to date)
619 - remove 'using namespace std' this is BAD !
621 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
622 * Remove memory leaks on the DicomDir
623 * Remove some useless data in DicomDirObject
624 * Add usefull methods in SQItem, to be complient withe the ElementSet
626 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
627 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
629 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
630 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
631 future, with convertion)
632 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
633 and ImageDataSize values. Remove the method to get the PixelReadConverter
634 from the output of the class
636 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
637 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
639 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
640 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
641 and vtkErrorMacro use.
642 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
644 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
645 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
647 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
648 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
649 The string leaves only in the fonction. So when we make a .c_str(), we
650 get the pointeur on the first element, element that will be destroyed
651 immediately after thee instruction.
652 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
653 file has been opened : the test must be made on the content of the
654 pointer and not directly on the pointer !
657 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
658 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
659 the python part recompiles
661 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
662 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
663 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
664 X session is killed (for my computer... it seems to not be identic on
667 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
668 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
669 avoid problems (otherwise, the difference test between the visible image
670 and the reference is incorrect. If the reference is greater than the
671 screen resolution, it's produce errors).
672 Can be used for only one image. Can be used with a visible flag.
673 * vtk/vtkGdcmReader.cxx : remove commented codes.
674 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
675 under windows at compilation
676 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
678 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
680 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
681 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
682 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
683 tests on the image size X, Y, Z
685 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
686 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
687 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
688 between the class name and the file name
690 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
691 * src/ : fix compilation warnings for the Write method (2 different
692 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
693 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
694 variable... create a static method in gdcm::Document to access to
695 this variable content.
697 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
698 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
699 file, to be accessed by other files (like gdcmFile). Remove commented
700 code. Move the change of the header to the gdcmFile, using the
702 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
703 To be sure of that (and simplify calls), the Write of the header now
704 gets a file name and not a file pointer (std::ifstream).
705 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
706 DocEntryArchive. Remove all open of the written file
708 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
709 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
711 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
712 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
713 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
715 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
716 some corresponding methods. Write correctly the file and check before
718 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
719 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
720 is now on RGB data (as before my last commit
721 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
723 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
724 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
725 Add a print information of the type of the entry
726 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
727 It was in the gdcmFile, and all write have been regrouped
728 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
729 Write correctly all dicom files (in decompressed mode only at this time)
730 * Test/ : test on files are now made using Raw data and not color data if
732 * Example/PrintFile.cxx : add more printings
734 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
735 * Amelioration of code, remove some code copy. For the loading of
736 BinEntry (in gdcmDocument), add the test to verify if the file is already
739 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
740 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
741 remove a DocEntry in the header (push an empty DocEntry)
742 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
743 lines. Bug fix in the initialization of the PixelConvert and the
745 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
746 use in TestCopyDicom (now this test can run under windows... but fails)
747 * Test/TestCopyDicom.cxx : amelioration of the test :
748 - test the pixels written
749 - add test points to quickly find where is the error
750 - can set a file name input and output in arguments
751 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
752 amelioration of the test output
754 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
755 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
756 all replaced DocEntry's
757 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
758 Now, each needed DocEntry to modify is duplicated, modified and inserted
759 to the header using DocEntryArchive. Thus, after save, we can restore the
760 header initial state.
762 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
763 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
765 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
766 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
767 correct to copy it. The DictEntry is specified at the DocEntry creation,
768 then, it musn't change in the time.
769 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
770 header correctly. At this time, the change is only made for the first
771 level of the Document. In the future, it might consider sequences.
772 The change is made by replacing a DocEntry by an other that is created
773 outside the class. The old value is kept. When we restore the header
774 status, the added DocEntry is deleted and replaced by the old value.
775 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
776 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
777 set the write type to explicit VR, implicit VR or ACR. Add methods to set
778 the write mode to native, decompressed or RGB (but not used at this time)
780 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
781 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
782 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
784 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
785 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
786 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
788 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
789 set because already copied when copying the BinEntry's of the header
790 * Test/TestAllReadCompareDicom.cxx : remove warnings
792 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
793 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
794 Two problems appear when doing it :
795 - with the gdcmFile : when the GetImageData method is called, the pixels
796 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
797 data (pixels). And each structure destruct the data when it's
798 destructed. So we have two destructions for the same data. To solve it,
799 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
800 data or not. If it doesn't own data, then they will not destroyed by
802 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
803 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
804 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
805 create a double destruction of the same DocEntry's. So, to solve it,
806 the TagHT is simply cleared and the DicomDir* elements are destroyed.
807 * TODO : add an entry concerning memory leaks in the DicomDir
809 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
810 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
811 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
814 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
815 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
816 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
817 after it have been deleted
819 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
820 * FIX: src/* fix the doxygen warnings.
821 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
822 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
823 was erroneously defined with a size of 15 instead of 16. [many thanks
824 to Jean Michel Rouet for pointing out this bug].
826 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
827 1. Finish merging JMR patch for writting DICOM from scratch
828 2. Fix -hopefully- bug with MONOCHROME and space vs null character
829 3. Use const ref when possible
830 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
831 5. A few more comments
832 6. CreateUniqueUID can now be called without parameter"
834 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
835 * ENH: Slightly bigger patch:
836 1. Getting toward full integration of JMR patch for writting dicom from scratch
837 2. Update Test to test part of this patch: CreateUniqueUID
838 3. File was not close properly in gdcmDict
839 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
840 5. Use of const ref instead of copy (speed issue)
841 6. Remove temporary (duplicate) string in TranslateToKey
842 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
843 8. Do not repeat virtual in subclasses
844 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
846 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
847 * Apply first patch toward better string comparison when dealing with broken
848 DICOM files. Essentially the string could be padded with a space instead
849 of a null character as defined by standard
851 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
852 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
853 because never used... and in the same time, that's remove some memory leaks
855 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
856 * src/gdcmFile.cxx : now delete the PixelConvert instance.
857 * In examples and tests : change the type of image data variables from void*
858 to uint8_t*. Remmove all delete on image data variables
860 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
861 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
862 Verify the file pointer value before open the file, and if it's not null,
863 a verbose message is generated.
864 Close correctly the file when the file isn't considered dicom-like. The
865 correctly close is a call to CloseFile.
866 When closing the file pointer, test if its not null to close the file.
867 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
868 file. For an uncompressed image, the copied data correspond in the least
869 case to the image size (calculated) or the image size specified in the
870 header. A verbose is generated if these two size mismatch
872 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
873 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
874 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
875 break under windows (with msvc6 compilation).
877 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
878 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
879 compiling with MSVC6)
881 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
882 * Bugs fix for the Windows build with VC6
883 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
884 needed (only for projects required VTK). If the VTK is included in all
885 projects, there is conflicts with the jpeg lib of vtk when compiling the
886 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
887 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
888 when compiling the gdcm_wrap.cxx file (created by the compilation of the
890 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
891 (like it's already made for the cout use). Otherwise, conflict with the
894 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
895 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
897 - comments on the DicomDir::Method related usage added.
898 - now that we use the namespace gdcm, a lot of internal classes do
899 NOT need to be wrapped anymore.
900 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
901 DicomDir::Method) new example added.
903 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
904 * Improve string manipulation. I now inforce the notion of 'DicomString'
905 A DicomString can contain as many \0 as they want
906 and it is *always* of even length.
907 We only support odd length for very rare case.
908 And in the near future this should be removed.
910 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
911 * /binary_write/ gdcm source. Now even on big endian we are writting
912 little endian. This should -heopfully- fix some tests
914 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
915 * Now the dictionary is compiled into gdcm lib. This is a default
916 behavior, thus any dic file specified is picked before failback to
917 the one comiled into lib
919 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
920 * Change internals for gdcmDict. Don't use any 'new' any more.
921 This should definitely solve any leak problem, and we should be
922 as fast as before, as long as don't modify too much the dictionary.
924 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
925 * STYLE: ivars should start with a capital letter.
926 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
927 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
929 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
930 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
931 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
932 new 2004 dictionaries added (thanks to JPR).
933 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
934 * CLEANUP_ROUND (15) for gdcmPixelConvert
935 - RLEFrame::NumberFragments is now of type unsigned int
936 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
937 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
940 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
941 * Initial work in gathering all transfer syntax accessors. clearly
942 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
943 ivars, but only one transfersyntax (class) ivar with equivalent method on
946 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
947 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
948 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
949 discussed (plus I didn't like having a 2000 lines patch not commited)
951 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
952 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
953 * CLEANUP_ROUND (14) for gdcmPixelConvert
954 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
955 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
956 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
958 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
959 anymore and hence avoids storing a copy of PixelConvert::Decompressed
960 into File::Pixel_Data.
962 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
963 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
964 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
965 * CLEANUP_ROUND (13) for gdcmPixelConvert
966 Substituted File::ParsePixelData() with PixelConvert::Print() new
968 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
969 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
970 method to those classes.
971 - src/gdcmFile.[cxx|h]:
972 -- Added a ::Print() method.
973 -- PixelConverter is now a reference instead of a member.
974 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
975 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
977 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
978 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
979 collaboration diagram and inheritance diagram should be generated with
981 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
982 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
983 pointlessly wrapped (see
984 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
985 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
986 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
987 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
988 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
989 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
990 -- File::Initialise: PixelConverter setup moved away to
991 PixelConverter::GrabInformationsFromHeader()
992 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
993 interpretation moved away to PixelConverter::BuildRGBImage()
995 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
996 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
997 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
999 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1000 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1001 displayed on Win32 when a brutal abort() occurs (because of uncatched
1002 exception). See TODO new entry of this commit for more on this.
1003 * TODO added new entry.
1004 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1005 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1006 - HandleColor is no longer called from gdcmFile.cxx
1007 - gdcmPixelConvert.cxx clean up on method arguments and internal
1008 variable names for semantical coherence.
1010 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1011 * Finished lossless transition, not only do we now read all lossless jpeg
1012 images, without the need of the Cornwell lib, but we do read them properly now
1013 * To reduce code (well to avoid code duplication), I defined a common place
1014 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1015 redefine symbols. This is not perfect but this the best solution I found for a
1016 compilation time jpeg option.
1018 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1019 * Update jpeg ijg lib to support lossless jpeg implementation
1020 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1022 * Also added a special copyright for dcmtk since we use their bugfixes.
1025 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1026 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1027 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1028 matters, as stated in warning note at beginning of %include section).
1029 * src/gdcmDicomDir*.[cxx|h]: coding style
1030 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1031 * src/gdcmJpeg8.cxx: doxygen fix.
1032 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1033 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1034 from File:: to PixelConvert::.
1036 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1037 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1038 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1039 - more code moved away from File:: to PixelConvert::
1040 - fat setup of PixelConverter set in place in File::Initialise.
1042 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1043 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1044 namespace at the file system level. So now you should convert your examples
1046 gdcmHeader -> gdcm::Header
1047 It would be nice if people keep in mind to no open the namespace, since it
1048 allows compilation on broken plateform which were defining common symbol in
1049 the standart namespace (like LP, Unknown ...)
1051 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1052 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1053 The JPEG fragments are now parsed at the same stage than the RLE
1054 information. All code related to JPEG is now in gdcmPixelConvert:
1055 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1056 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1057 export a gdcmFile:: method. Those are simply global functions
1058 (for the time being this is better than having them attach to
1059 either gdcmFile:: or gdcmPixelConvert::).
1060 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1061 and stores the result in a gdcmJPEGFragmentsInfo.
1062 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1063 code (among other stuff) moved away from gdcmFile:; to
1066 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1067 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1068 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1069 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1070 clean up of RLE related code.
1071 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1072 - src/gdcmRLE.cxx removed
1073 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1074 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1075 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1076 * CLEANUP_ROUND (9) for gdcmPixelConvert
1077 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1078 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1079 away from gdcmFile:: to gdcmPixelConvert::.
1081 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1082 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1083 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1084 This is because Parse7Fe0 used to parse the pixels to compute the
1085 length. This task was passed over to FindDocEntryLengthOB() a long
1086 time ago, EXCEPT I had forgotten the OW case...
1087 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1088 we just recylce the code for parsing RLE fragments and computing
1090 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1091 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1092 with the retired Parse7Fe0().
1093 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1094 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1096 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1097 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1098 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1099 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1100 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1101 * CLEANUP_ROUND (4) for gdcmPixelConvert
1102 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1103 to return an unused length.
1105 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1106 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1107 this should be cleanner from the plane view. The iostream are erally a pain
1108 to use to do simple stuff.
1110 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1111 * Redo the compilation of the ijg jpeg library. Now only one source is
1112 necesseray. No need to rename file by hand what so ever. CMake handle the
1113 copying of the file within different directory, configure header file to
1114 modify some symbol. The only addition made to ijg wasd a mangle table so
1115 that symbol are different whether we are within 8bits or 12bits.
1117 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1118 * Added documentation of vtkgdcmReader on Website:
1119 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1120 with it's binary name).
1121 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1122 the Website to be more complete.
1123 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1124 doxygenated documentation.
1125 - Doc/DoxyVtkGdcmReaderExamples.txt added
1126 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1127 DoxyVtkGdmReaderExamples.html )
1128 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1129 * CLEANUP_ROUND (3) for gdcmPixelConvert
1130 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1132 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1133 * CLEANUP_ROUND (2) for gdcmPixelConvert
1134 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1136 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1137 * CLEANUP_ROUND for gdcmPixelConvert:
1138 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1139 - src/gdcmPixelStuff[h|cxx] removed
1140 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1141 - src/CMakeLists.txt changed accordingly
1142 * GDCMHOME clean up:
1143 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1144 gdcmVersion.py moved to newly created ATTIC related
1145 gdcmPython/SetupOldies/ directory.
1146 * Autotools clean up:
1147 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1148 - autogen.sh configure.in acinclude.m4 python.m4 removed
1150 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1151 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1152 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1153 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1155 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1156 * TODO updated with Mathieu suggestions. I proposed a template for
1157 describing TODO entries and used it for new entries.
1158 * Added Doc/Website/CodingStyle.html, Developpers.html,
1159 DeveloppersPython.html, GdcmDataCvs.html and
1160 DownloadVersion0_1.html, DownloadVersion0_3.html.
1161 * Some Doc/*.txt Doxygen files (which do not really concern the
1162 documentation itself, but the website) moved to html and
1163 placed in directory Doc/Website:
1164 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1165 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1166 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1167 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1168 * CMakeLists.txt changed accordingly.
1169 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1170 DeveloppersPython.html
1171 * INSTALL nows refers to Doc/Website/Installation.html
1173 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1174 * Added Doc/Website directory, that contains a first raw version
1177 2004-09-23 Jean-Pierre Roux
1178 * FIX In order not to be poluted any longer by casting problems,
1179 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1180 we can now delete[] it safely
1181 * VoidArea is now called BinArea (less confusing name),
1182 and all the methods called ...VoidArea... are now ... BinArea...
1183 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1185 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1186 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1187 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1188 up to the destructor of gdcmElementSet to clean up TagHt and it's
1191 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1192 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1193 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1195 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1196 * ENH: added some utility method that builds a flat dictionary
1197 holding all the Dicom entries contained in the recursive structure
1198 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1199 an example of usage.
1200 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1201 BuildFlatHashTable() that build a flat dictionary.
1202 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1203 gdcmDocument is now a friend of gdcmElementSet.
1204 - src/gdcmElementSet.cxx: clean up.
1205 - Example/FlatHashTablePrint.cxx added.
1206 - Example/CmakeLists.txt changed accordingly
1208 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1209 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1210 moved away from gdcmDocEntrySet (since this class is an abstract class
1211 acting like an interface). SQDepthLevel and BaseTagKey are now
1213 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1214 and associated accessors. Doxygenation of the class.
1215 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1217 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1218 Use SQDepthLevel accessor instead. ::Print() adapted.
1219 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1220 - src/gdcmDocument.cxx changed accordingly.
1222 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1223 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1224 - The following is the doxygen comment of the typedef declaration
1225 of gdcmTagKey in src/gdcmCommon.h:
1226 gdcmTagKey is made to old an "universal" (as in URL, Universal
1227 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1228 A dicom tag always has a group and an element, but a set of tags
1229 embeded in various (optionally nested) sequences and sharing
1230 the same group and element all share the same (group, element)
1231 "identifier". Hence the (group, element) cannot be used as an
1232 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1233 In order to construct a proper tag identifier (i.e. a key) we
1234 consider the following definition of a TagKey:
1235 - let Group, Element be the string representation of the
1236 group and element dicom tag members,
1237 - let ItemNumber be the string representation of the integer
1238 index of the considered item number of a sequence,
1239 Let the key of a tag embeded in a sequence, noted SeqTag, be
1241 /ItemNumber#Group|Element
1242 where "/", "#" and "|" are characters acting as separators.
1243 Then the general form of a gdcmTagKey is given by:
1244 Group|Element<SeqTag>
1245 where <SeqTag> means NO or many instances of SeqTag.
1246 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1249 but the gdcmTagKey of a tag "embeded" is the first item of
1250 a sequence, itself nested in the third item of a sequence is the
1252 0004|1220/2#0008|0082/0#0008|0090
1253 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1254 order to hold the new sequence compatible key. Previously, the
1255 GetKey() method would look in the underlying gdcmDictEntry.
1256 - src/gdcmDocEntry.cxx:
1257 -- constructor now copies the underlying DictEntry key, in the local
1259 -- ::Print: displays the member Key, instead of the (group, element).
1260 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1261 - src/gdcmDocEntrySet.h:xi
1262 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1263 -- now has a new BaseTagKey member.
1265 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1266 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1268 This poses the problem with the semantics of the following lines
1269 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1270 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1271 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1272 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1273 to the long FIXME note for what the problem is. Nevertheless in
1274 order to get things working the dicom dictionary was altered !
1275 Please fix things urgently...
1276 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1277 information), see above note on moving the member VoidArea. Nevertheless
1278 the following entries previously correctly set as US are now inproperly
1280 0028 1201 OW IMG Red Palette Color Lookup Table Data
1281 0028 1202 OW IMG Green Palette Color Lookup Table Data
1282 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1283 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1284 of gdcmDocEntry moved to gdcmSeqEntry.
1285 * src/gdcmSeqEntry.cxx: STYLE.
1287 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1288 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1290 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1291 * gdcmPython/testSuite.py: all the test suite in python is now moved
1292 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1293 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1294 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1296 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1297 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1298 to avoid inclusion recursion until STL is reached.
1299 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1300 mecanism. errno.h is not included in gdcm anymore.
1301 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1302 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1304 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1305 gdcmData/TestAllEntryVerifyReference.txt
1306 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1307 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1308 exception_on_error parameter.
1309 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1310 - vtk/vtkGdcmReader.cxx changed accordingly,
1311 - Example/*.cxx and Test/*.cxx changed accordingly.
1313 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1314 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1315 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1316 enable_sequences removed from gdcmHeader constructor and dependencies.
1317 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1318 * gdcmPython/demo/PrintHeader.py: dummy fix.
1319 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1320 skip_shadow removed from gdcmHeader constructor and dependencies.
1321 * Example/*.cxx and Test/*.cxx changed accordingly.
1323 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1324 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1325 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1327 2004-07-21 Jean-Pierre Roux
1328 * FIX Now, Parsing and Printing a DICOMDIR do work!
1329 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1331 2004-07-20 Jean-Pierre Roux
1332 * FIX Some brain damaged headers have Zero-Lenght fields
1333 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1335 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1336 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1337 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1338 variable (instance of gdcmDebug) by a definition macro, and the instance
1339 is now in static in the gdcmDebug class
1340 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1341 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1343 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1344 * WARNING: ctest now depends more tightly on gdcmData. You should
1345 check out gdcmData properly for things to run smoothly...
1346 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1347 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1348 we need the pixels not be loaded in order to use the ValEntry
1349 that displays position and size).
1350 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1351 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1352 be deprecated. If you have any doubts about the advantages of a
1353 modern scripting language (read Python) versus grass root C++ (i.e.
1354 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1355 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1356 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1357 Anyhow, consider documenting the gdcmData images in
1358 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1360 * Test/CMakeLists.txt:
1361 - now uses TestAllEntryVerify.cxx
1362 - specific comments on oldACR00001.ima (now renamed in gdcmData
1363 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1364 gdcmData/TestAllEntryVerifyReference.txt
1367 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1368 * src/*.[h|cxx] : typedef clean up
1369 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1370 - TagKey renamed to gdcmTagKey (for external usage)
1371 - VRKey renamed to gdcmVRKey (for external usage)
1372 - removal of typedef duplication.
1373 - Removed all unecessary inline keyword from class inline definitions.
1374 - Some method|function(void) declarations replaced with method|function().
1375 * src/jpeg/libijg12/jdhuff12.c:
1376 - printf polluting ctest removed.
1377 - TAB removal for comminting
1379 - TestAllReadCompareDicom.cxx: added a test that compares all the
1380 images in gdcmDataImages.h with corresponding images in
1381 gdcmData/BaselineDicom/. When baseline images are not present
1382 this test creates them.
1383 Note: we need to validate each reference image, but before that
1384 I'd like to rename them with a more explicit name...
1385 - CMakeLists.txt: changed accordingly.
1386 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1387 including each header needed).
1389 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1390 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1391 test suite to the Example directory. Are concerned:
1396 - TestWriteSimple.cxx
1397 * Test/CMakeLists.txt: added some comments on reasons for black listing
1398 image gdcmData/oldACR00001.ima
1400 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1401 * Test/CmakeList.txt: removed the following from black list (to be coherent
1402 with removal from gdcmData):
1403 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1404 - gdcm-MR-PHILIPS-16.dcm
1406 Added the following because after last cvs update, they cause
1407 ctest -R TestReadWriteReadCompare
1409 - gdcm-MR-SIEMENS-16-1.acr
1411 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1412 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1413 new comments in this file) we temporarily (sigh) move to a weaker
1415 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1416 we don't need to black list the following images anymore:
1417 - 8BitsUncompressedColor.dcm
1419 - US-PAL-8-10x-echo.dcm
1420 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1421 fixes and the beautified code ;-)
1422 This fixes the bug introduced in version 1.42 (when beautifying)
1423 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1424 Note: ctest was blind to this bug (this means we need to still
1425 improve the test suite). The bug could be detected by using
1426 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1428 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1429 and by displaying the (garbage) produced file temp.XDCM...
1431 2004-06-29 Jean-Pierre Roux
1432 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1433 - replace by uggly but working old code :-(
1434 A lot of things should be OK again.
1435 It's really urgent to have a test suite that *tests*,
1436 to prevent Frog's beautifying sessions to break all the stuff
1437 (twice, withing a fortnigh ...)
1439 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1440 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1441 redundancy) to added Test/TestReadWriteReadCompare.cxx
1442 * Test/CmakeList.txt: because the compare test of
1443 Test/TestReadWriteReadCompare.cxx fails, the following images are
1444 black listed: - 8BitsUncompressedColor.dcm
1446 - US-PAL-8-10x-echo.dcm
1447 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1448 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1449 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1450 and ad-hoc kludge. This kludge is now removed, and on encountering
1451 such an image (OB field brain damaged) we set errno. Then in
1452 ::FindDocLength() we "fix" the length as being ALL what remains
1453 in the file (until EOF). We then proceed, hoping for the best...
1454 This fixes a SegFault in ShowDicom when trying to write such an
1456 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1457 (because TestWriteRead breaks on it, after a non conformal commit?).
1458 ctest now runs properly, except for MakeDicomDir (which was always
1459 broken) and the Python related stuff (still not fixed).
1461 2004-06-24 Jean-Pierre Roux
1462 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1463 FIX : Test/TestReadWrite now iterates on all the file names
1464 (instead of infinite loop)
1465 ENH : Test/TestWriteRead now iterates on all the file names
1467 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1468 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1470 2004-06-24 Jean-Pierre Roux
1471 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1472 when SamplesPerPixel =3
1473 - now Write is no longer confused by
1474 'BitsAllocated = 12" and 'BitsStored=12"
1475 - "UN" value representation Elements are now written correctly
1476 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1477 ENH : - now gdcmHeader has its own Write methods
1478 (in order to split the job that has not to be done
1481 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1482 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1483 loop on the same image until memory went out.
1484 Note: this means we still have gobs of memory loss in PrintDocument
1485 * src/gdcmDocument.cxx: fixes problem on parsing on file
1486 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1488 2004-06-24 Jean-Pierre Roux
1489 FIX : Write - All the Sequences and Sequence Item are now written
1490 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1491 is added a the end, when necessary.
1492 - A lot of brain-damaged images, that were read correctly are
1493 now written correctly
1494 - length compatible BinEntry are now loaded correctly
1495 (even for odd groups)
1496 Note : only Explicit Value Representation was checked.
1497 (question : is implicit VR really necessary for gdcm ?)
1499 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1500 * DEVELOPPER: added a proposition of coding style.
1501 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1504 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1505 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1506 Use the gdcmDocEntry::Print() and Write() instead.
1507 * src/gdcmDocument.cxx: bug fix.
1509 2004-06-22 Jean-Pierre Roux
1510 FIX : gdcmDocument.cxx
1511 - Now we do recognize the JpegLossLess format (there was a misstyping in
1512 code 'beautyfication' :-(
1513 - Now we automaticaticaly load the Luts, if any
1515 2004-06-22 Jean-Pierre Roux
1516 In order : to write Sequences, whatever their imbrication level,
1517 : to allow user to create his own Sequences
1518 a lot of modif where necessary (adding, moving, or virtualising methods)
1520 WARNING : save your own sources *before* cvs up !
1523 ADD virtual void Write(FILE *fp, FileType filetype);
1526 ADD virtual void Write(FILE *fp, FileType filetype);
1527 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1530 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1531 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1532 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1533 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1534 ADD std::string GetEntryByName(TagName name);
1535 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1537 std::string vr = "unkn",
1538 std::string fourth = "unkn",
1539 std::string name = "unkn");
1540 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1541 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1542 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1543 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1544 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1545 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1546 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1547 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1550 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1551 ADD virtual std::string GetEntryByName (TagName tagName);
1552 ADD virtual std::string GetEntryVRByName (TagName tagName);
1553 REM virtual bool Write(FILE *, FileType);
1554 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1555 FILE *_fp, FileType type);
1556 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1557 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1558 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1559 REM virtual std::string GetEntryByName (std::string tagName);
1560 REM virtual std::string GetEntryVRByName (std::string tagName);
1561 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1562 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1563 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1565 std::string vr = "unkn",
1566 std::string fourth = "unkn",
1567 std::string name = "unkn");
1568 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1569 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1570 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1571 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1574 ADD virtual void Write(FILE *fp, FileType filetype);
1577 ADD virtual void Write(FILE *fp,FileType filetype);
1580 ADD virtual void Write(FILE *fp, FileType filetype);
1581 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1582 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1583 REM std::string GetEntryByName(TagName name);
1586 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1588 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1589 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1590 The default constructor invoked by the line
1591 gdcmHeader *f1 = new gdcmHeader( header );
1592 was gdcmHeader::gdcmHeader(bool) instead of the expected
1593 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1594 Hence the parsing wasn't executed... See also below.
1595 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1596 as explicit constructor didn't do the trick to fix the above problem.
1597 Could anyone explain why ?
1598 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1599 properly calls gdcmValEntry::Print() (that was weed out from
1600 code related to gdcmBinEntry).
1602 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1603 * In order to fix memory leaks:
1604 - Test/TestWriteSimple.cxx: added cleaning of free store through
1606 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1607 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1608 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1609 (through the call to ::AddDicomDirMeta()) or the destructor
1610 would crash when deleting uninitialized ::metaElems].
1611 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1612 - src/gdcmDocument.cxx:
1613 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1614 from dynamic stores.
1615 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1616 was causing memory leaks.
1617 - src/gdcmSQItem.cxx:
1618 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1619 cleanly handled with polymophism: sorry but my milage is low).
1620 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1621 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1622 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1623 This avoids SegFaulting.
1624 - src/gdcmSQItem.h: coding style.
1626 - Test/TestWriteSimple still severely sucks. The output image content
1627 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1628 damaged when displayed with vtkgdcmViewer.
1629 - on memory leaks: TestWriteSimple leaks really less (see entry
1630 of 2004-06-18 in Changelog file for the call to valgrind).
1631 - on segfaults: ctest now passes all the tests but one (no more
1633 * Erroneous leading white fix:
1634 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1635 white[s] (as opposed to from >> xxx, that removes it [them].
1636 - src/gdcmTS.cxx: ditto.
1637 - gdcmPython/testSuite.py: dirty related kludge removed.
1638 * src/*: remaining references to gdcmParser removed.
1639 * src/*[cxx|h]: added copy[way]left header.
1642 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1643 * In order to fix writing of dicom files:
1644 - Test/TestWriteSimple.cxx: a simpler example of writing.
1645 - Test/CMakeLists.txt changed accordingly.
1646 - src/gdcmDocument.cxx:
1647 -- The destructor now recursilvely removes potential sequences.
1648 -- Bug fix in ::IsJPEG2000()
1649 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1650 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1652 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1653 to only declared) and build on top of
1654 ::GetDocEntryByNumber(guint16, guint16).
1655 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1656 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1657 for usage in destructor and treatement of promotion in
1658 ::ReplaceOrCreateByNumber().
1659 - src/gdcmSQItem.cxx: destructor should better handle his job.
1660 Test/TestWriteSimple now runs (or at least it DOES something).
1661 * We can now start hutting memory links. A good starting point is:
1662 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1663 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1664 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1666 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1667 * Valgrind note: after Mathieu Malaterre teached me how to read
1668 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1670 Using gcc, you can force the STL to use malloc and to free memory as
1671 soon as possible by globally disabling memory caching.
1672 With 3.2.2 and later, you should export the environment variable
1673 GLIBCPP_FORCE_NEW before running your program.
1674 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1675 simply vanish (it is still not clear to me, whether this means that
1676 STL std::string leaks or if valgrind believes it leaks...).
1677 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1678 running bin/gdcmTests makeDicomDir):
1679 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1680 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1682 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1683 SegFaulting (I drowned in DicomDir related code when trying to
1684 understand why the list is empty...).
1685 * src/gdcmDocument.h: first BSD license header try.
1686 * Doc/License.txt added.
1688 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1689 * src/gdcmDocument.[h|cxx]:
1690 - Clean up of the Transfer related predicates. They are now all based
1691 on new method isGivenTransferSyntax, that (should) handle properly
1692 the padding problem.
1693 - general clean up, simplification, and coding style.
1694 - Specific clean up of Parse7FE0() (umproperly named actually).
1695 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1697 2004-06-14 Jean-Pierre Roux
1699 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1700 - fix the display of SQItem ordinal number
1701 - add the GetSQItemByOrdinalNumber method
1702 - remove some useless never written private methods
1704 2004-06-14 Jean-Pierre Roux
1706 - adding a constructor taking a gdcmDocEntry as an input param
1707 - ReplaceOrCreateByNumber now returns :
1708 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1709 a gdcmValEntry * if a string value is passed as a param
1711 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1712 according to the param type (no longer sets a gdcmDocEntry)
1713 - GetValEntryByNumber, GetBinEntryByNumber added
1714 - NewValEntryByNumber and NewBinEntryByNumber added
1716 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1718 - GetSQItemNumber and SetSQItemNumber added, to provide
1719 a (relative) Item identier inside a given Sequence
1720 \warning : some pb remaining around this number
1722 - AddEntry now takes the Item Number as a param
1724 - adding a constructor taking a gdcmDocEntry as an input param
1726 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1727 * Memory leak hunt with the following command:
1728 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1729 --show-reachable=yes gdcmTests PrintDocument
1730 It looks like many (all?) leaks are due to the STL (or a bad usage
1731 of the STL. The lines producing the leaks now have a comment with
1732 a "MEMORY LEAK" tag: you can retrieve them with
1733 grep "MEMORY LEAK" src/*
1734 Here are two typical examples which I can't help fixing:
1739 char * test = "babo";
1740 name = test; //// <--- valgrind detects 960 bytes lost in
1741 //// call to std::string::operator=(char const*)
1742 name.clear(); //// Doesn't help !
1750 std::cout << "Type a bunch of characters followed by RETURN: ";
1751 getline(std::cin, line); //// <--- valgrind dectects a loss
1752 //// of 1320 bytes in call to
1753 /// std::basic_istream<>& std::getline<>
1759 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1760 * src/gdcmHeader.[cxx|h]:
1761 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1762 and related, moved away to gdcmDocument.
1763 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1764 the corresponding protected accessors of inherited class
1765 gdcmDocument, removed ! As a consequence gdcmFile had to be
1766 declared friend of class gdcmDocument (see below).
1767 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1768 - Clean up of undefined or unused methods.
1769 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1770 account the changes to gdcmHeader.h).
1771 * src/gdcmDocument.h:
1772 - gdcmFile is now a friend class (in order to take into account the
1773 changes to gdcmHeader.h).
1774 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1775 (see changes to gdcmHeader.h).
1776 - Accessors (reading on the form GetEntry*) are now public.
1777 - Clean up of undefined or unused methods.
1778 * src/gdcmDocument.cxx:
1779 - adaptation to changes to gdcmDocument.h
1780 - ::OpenFile now writes a verbose message when file cannot be opened.
1781 - some std::string properly set to VRKey
1782 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1783 references to gdcmDocument.
1784 * Test/TestFindTags.cxx: changed accordingly to above changes.
1785 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1786 cvs repository gdcmData.
1788 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1789 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1790 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1791 conflicts with gdcmValEntry::voidArea.
1792 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1793 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1794 Value representation between StringRepresentable and BinaryRepresentable.
1795 * src/gdcmDocument.cxx:
1796 - method ParseDES: proper indentation restored and usage of
1797 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1798 - method LoadDocEntry: the fingerprint left in the SetValue() of
1799 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1800 removed. Reverting to previous code segment with the proper
1801 dynamic_cast< gdcmValEntry* >.
1802 Note: this was (partially) breaking the python test suite
1803 (gdcmPython/testSuite.py) that made usage of the above
1804 fingerprint to check presence of "Pixel Data".
1805 * src/gdcmDocEntry.h: coding style.
1806 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1807 now taken into account.
1808 * gdcmPython/gdcm.i: adaptation to the new internal representation
1809 of gdcm (exit gdcmParser, hello gdcmDocument).
1810 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1812 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1813 anymore, but instead prints the loaded Python dictionary.
1814 * .... alas, the python testSuite is still broken.
1816 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1817 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1819 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1820 * src/gdcmUtil.h : export methods
1822 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1823 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1825 * Initial addition of automatic python testing
1826 * Initial addition of automatic image comparison
1828 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1829 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1830 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1832 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1833 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1834 * Test/ShowDicom.cxx : bug fix for msvc compilation
1835 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1837 2004-05-04 Jean-Pierre Roux
1838 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1839 new concepts (and new classes) :
1840 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1841 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1842 - Sequence Doc Entries (gdcmSeqEntries)
1843 a Sequence is composed of Items.
1844 Each item is a set of Doc Entries (this is recursive)
1845 The non uniqueness of the 'Dicom tag' is due to this recursivity
1846 (never taken into account)
1847 Our unability to add a new 'entry' in the header
1848 at the proper location (neither in the H-Table (map or multimap),
1849 nor in the Chained List is also due to this recursivity.
1850 Don't try, right now, to use/modify/compile these new sources :
1851 nothing is finished.
1852 We just commit all the stuff, 'as is', in order not to loose it.
1854 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1855 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1857 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1858 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1859 file prefix (SetFilePrefix)
1861 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1862 * Add a new test: ShowDicom, for now this is just the c++ version of
1863 checkRead.sh, later it will be able to compare the image read against a
1865 * Replace the DEBUG on the stack with a global entry in cmake interface:
1866 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1868 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1869 * Add an example subdir, with a real example on how to read + write a
1872 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1873 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1874 * Doc/CMakeLists.txt: the main page is now properly differentiated
1875 between the developper and user version.
1876 * Doc/doxygen.config.in: dropped search related obsolete flags
1877 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1879 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1880 * DEVELOPPER: added some helpfull comments for compile/test/install
1883 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1884 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1885 src directory, now generated in the build dir.
1886 2. Tests as mentionned smarter
1888 4. Add a new method in gdcmDict that return the PubDict by name
1889 this is interesting for 3rd party lib like ITK,
1890 where we could set the institution name / patient name...
1892 * ENH: 1. Now the test suite is working for real
1893 2. All binaries are now output in the gdcm-bin directory
1894 (this was not true before)
1896 2004-04-28 Jean-Pierre Roux
1897 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1898 SeQuence indented printing of Dicom Header.
1899 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1900 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1901 Computation of SQDepthLevel is now part of gdcmHeader constructor
1902 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1903 tree-like structure of a Dicom Header.
1904 * FIX Test code cleaning
1906 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1907 * ENH: Adding automatic testing
1908 1. Need a DartConfig.cmake to submit to public
1909 2. Add a test driver gdcmTest.cxx
1910 3. gdcmTestMain, an helper for the main test driver gdcmTest
1911 4. Files in Test don't have a main anymore, this becomes interesting
1912 when we add more and more tests, thus dsw don't have to load
1914 * ENH: Adding a GDCM_DATA_ROOT for testing
1915 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1916 one file instead of seven + some small cleanup
1918 2004-04-22 Jean-Pierre Roux
1919 * ENH Minor changes to the Print() methods.
1920 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1921 Header printing. Example given with :
1922 > PrintHeader fileName 2 new
1923 (SQ based tree-like structure still to be done for the Header ...)
1925 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1926 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1927 1. I have added some unsigned where needed
1928 2. Some function parameter not used -> (void)
1929 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1930 4. g++ don't like character '\' in comment
1931 5. #define jpeg_create_decompress jCreaDecompress
1932 this really need to be fixed
1933 6. virtualize destructor of gdcmObject ... leakage
1934 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1935 this also really need to be fixed
1936 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1937 remove compression file
1938 (as we only do decompression, right ?)
1939 * ENH: Change malloc/calloc/free with c++ equivalent
1941 2004-04-21 Jean-Pierre Roux
1942 * FIX gdcmHeaderHelper::GetXSpacing
1943 when a single value is found (bug ?), xpacing is now
1944 defaulted to yspacing
1946 2004-04-19 Jean-Pierre Roux
1947 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1948 * ENH add parameters :
1949 bool exception_on_error = false,
1950 bool enable_sequences = false,
1951 bool ignore_shadow = false
1952 to the gdcmFile constructors to be full gdcmParser compliant
1953 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1954 to allow reading of PAPYRUS 3.0 files
1956 2004-04-06 Jean-Pierre Roux
1957 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1959 2004-04-02 Jean-Pierre Roux
1960 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1961 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1962 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1964 2004-03-30 Jean-Pierre Roux
1965 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1966 for ACR file, written out as DICOM files (hope so...)
1968 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1969 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1970 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1971 moved to base class gdcmParser and only the specialisation is kept
1973 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1974 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1975 already does the job.
1976 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1977 (to be consistent with gdcmParser::WriteEntries).
1979 2004-03-30 Benoit Regrain
1980 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1981 upate of the object's instance. It's passed to 2 in the unfavorable
1982 case : one in the ExecuteInformation, one in the ExecuteData
1984 2004-03-29 Jean-Pierre Roux
1985 * ENH : Check on file type to be written moved
1986 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1987 * FIX : gdcmObject::ResetBoundaries now stops properly
1988 when end-of-list is reached
1989 : gdcmVersion modified (as Benoit Regrain asked)
1991 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1992 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1993 * src/gdcmUtil.cxx: added forgotten iostream include.
1994 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1995 equivalent to ExplicitVR in existing code).
1997 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1998 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1999 now contains all the gdcmGlobal related code.
2000 * minor coding style and doxygenation changes.
2002 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2003 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2004 now contains all the Debug related code.
2005 * minor clean-up of includes in src/*.cxx
2006 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2007 CreateCleanString) removed.
2008 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2009 * Doc/DoxyMainPageUser.txt added.
2010 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2011 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2012 src/gdcmDirList.cxx)
2014 2004-03-24 Jean-Pierre Roux
2015 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2017 2004-03-23 Jean-Pierre Roux
2018 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2019 big endian made volumes
2020 * ENH Now gdcmParser constructor and destructor are protected to forbid
2021 end user to instanciate class gdcmParser
2022 (only gdcmHeader and gdcmDicomDir are meaningfull)
2024 2004-03-22 Benoit Regrain
2025 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2026 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2027 gdcmSerie to gdcmDicomDirSerie
2029 2004-03-19 Jean-Pierre Roux
2030 * ENH Now the tree-like structure describing a DICOMDIR comming from
2031 an already existing DICOMDIR file is consistent with
2032 the home-made tree-like structure build ex-nihilo
2033 or build from the files held (recursively) in a Directory
2034 functions gdcmDicomDir::CheckBoundaries()
2035 gdcmObject::SetBoundaries() added
2037 2004-03-17 Jean-Pierre Roux
2038 * REM (Eric Boix bug) : removal of meaningless
2039 gdcmDicomDirImage::NewImage function.
2040 * FIX now file names and directory name are written properly in the
2042 * FIX now gdcmDicomDir constructor may be call without any trick
2045 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2046 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2047 of gdcmDicomDirImage::NewImage as empty function.
2049 2004-02-28 Jean-Pierre Roux
2050 * ENH add gdcmDicomDir:NewPatient
2051 add gdcmDicomDirPatient:NewStudy
2052 add gdcmDicomDirStudy:NewSerie
2053 add gdcmDicomDirSerie:NewImage
2054 to allow making gdcDicomDir object.
2055 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2056 (as opposite to the gdcmHeader chained list)
2058 2004-02-11 Benoit Regrain
2059 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2060 when using from python
2062 2004-02-10 Benoit Regrain
2063 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2064 * FIX : in gdcmDicomDir when the directory is empty
2065 * ENH : add callback and methods to get the progression of dicomDir
2068 2004-02-06 Jean-Pierre Roux
2069 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2070 - GDCM_META added to gdcmDicomDirType
2071 - class gdcmMeta created
2072 * ENH : - A brief summary is now displayed at the beginning of
2073 'testDicomDir' to help disaster magnitude estimation
2074 * REM : Now useless Test/explDICOMDIR.cxx
2076 2004-02-05 Benoit Regrain
2077 * ENH : add methods in gdcmObject to get the hash table or the list of
2079 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2080 * FIX : wrapping python for TagHeaderEntryHT
2082 2004-02-04 Benoit Regrain
2083 * FIX : even length for some strings when writting the dicom dir
2084 * FIX : sort the images in the dicom dir
2085 * FIX : Bug fix for python use of dicom dir
2086 * ADD : a python demo
2088 2004-02-04 Jean-Pierre Roux
2089 * FIX : Final solution (?) for icone embedded images
2090 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2091 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2092 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2093 gdcmData/gdcm-MR-SIEMENS-16.acr1
2094 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2095 to make full checking easier
2097 2004-02-04 Benoit Regrain
2098 * FIX : WriteEntries : coding style & logic in parameters
2099 * FIX : Set the elements to create the DicomDir in a dictionary file
2101 2004-02-03 Benoit Regrain
2102 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2103 * gdcmDicomDir : add the load of directory
2104 * Bug fix and print add-on
2106 2004-02-03 Jean-Pierre Roux
2107 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2108 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2109 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2110 * FIX gdcmParser.cxx : 'group length' elements are now considered
2111 as integers, even for shadow groups, when file is Implicit VR
2113 2004-02-02 Jean-Pierre Roux
2114 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2116 of the last synonym :-(
2117 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2119 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2120 * FIX taking into account the possible 7fe0,0010 multiplicity
2121 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2122 to allow removal of references to 7fe0,0010, to deal with
2123 ACR-NEMA images, when 0028,0200 is meaningfull
2125 2004-01-31 Jean-Pierre Roux
2126 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2127 no longer writes 'Un' on disk
2128 * FIX SQ elements with actual length are now dealt with corectly
2129 * FIX gdcmFile::WriteBase make the difference, for color images, between
2130 the length (for Palette expanded images)
2131 and Raw Length (non expanded image + Palette)
2132 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2133 (that broke Write). Replaced by UL.
2134 Aware user will reload the field if he
2135 thinks it's necesssary
2137 2004-01-30 Jean-Pierre Roux
2138 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2139 when 'dirty Acr' is found, to be compliant with the new
2140 IsReadable() methods.
2142 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2143 (no DOUBLE images in kosher DICOM,
2144 but so usefull for people that miss them ;-)
2146 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2147 DICOMDIR related utilities (not checked as Windoze compliant)
2149 2004-01-28 Jean-Pierre Roux
2150 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2152 2004-01-27 Jean-Pierre Roux
2153 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2154 to allow skipping the shadow elements, to save memory space.
2155 The TRUE value for this param has to be used
2156 with a FALSE value for the 'enable_sequence' param.
2157 ('public elements' may be embedded in 'shadow Sequences')
2158 * gdcmHeader methods now deal with 'embedded icones images' in the header
2159 (even when an 'icone image sequence' is announced by the
2160 element (0x0088,0x0200), but there is NO icone at all ...
2162 * gdcmHeader sometimes Image Location value doesn't follow
2163 the supposed processor endianity (see gdcmData/cr172241.dcm).
2166 * gdcmHeader add the method
2167 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2168 to get *all* the Header Entries with the same tag.
2169 GetHeaderEntrySameName is probabely *useless*
2170 (no meaning : Name is *not* an identifier within the Dictionary)
2172 2004-01-26 Benoit Regrain
2173 * Bug fix in the print of hexadecimal representations. Remove long fields
2174 in the print and add a third level of print to print them
2176 2004-01-23 Benoit Regrain
2177 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2178 * Bug fix on test suite after remove the strip made on not string fields
2179 * Split the IsReadable method between gdcmParser which test that the file
2180 is dicom and gdcmHeader which test that it's an image file
2182 2004-01-22 Benoit Regrain
2183 * DicomDir : clean code, add methods, set variables in protected or private
2184 * gdcmUtil : bug fix for the clean string method
2186 2004-01-19 Benoit Regrain
2187 * Add the use of shadow dictionaries
2188 * bug fix and coding style
2190 2004-01-19 Benoit Regrain
2191 * src/gdcmFile.cxx : bug fix concerning the close of file
2192 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2193 * Add the update of header entries using the shadow library
2195 2004-01-19 Benoit Regrain
2196 * removal of file gdcmHeader2.cxx
2197 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2198 inheriting from gdcmParser. This split is to prepare the integration
2199 of dicom dir parsing
2200 * bug fix under python
2202 2004-01-16 Jean-Pierre Roux
2203 * REM removal of class gdcmHeaderEntrySet
2204 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2205 * ADD add file gdcmHeader2.cxx
2206 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2208 2004-01-15 Benoit Regrain
2209 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2210 entries created while parsing the header. Thus, they will be destroyed
2211 when the gdcmDictSet will be destroyed
2212 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2215 2004-01-15 Benoit Regrain
2216 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2217 made a fatal error because of the memory release at the end of program.
2218 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2219 some memory and vtk seems to have some problems with that.
2220 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2222 2004-01-14 Benoit Regrain
2223 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2224 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2225 * src/*.[h|cxx] : make changes due to class name changes
2226 * gdcmPython/demo/*.py : bug fix due to method names
2228 2004-01-13 Benoit Regrain
2229 * src/*.[h|cxx] : coding style
2230 * vtk/*.[h|cxx] : coding style
2232 2004-01-13 Benoit Regrain
2233 * gdcmPython/testSuite.py : test the readable flag of file for tests
2234 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2235 It's lied to the stl compilation by MSVC (windows, always windows...)
2236 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2238 2004-01-12 Benoit Regrain
2239 * src/*.h : add comments
2240 * src/gdcmDictSet.h : set the method BuildDictPath in public
2241 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2242 directly setted in the source code
2243 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2246 2004-01-09 Benoit Regrain
2247 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2248 * setup.py : use a reference to gdcmVERSION
2250 2004-01-07 Benoit Regrain
2251 * Modification to compile with the distutils.
2254 2003-12-10 Benoit Regrain
2255 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2256 can use a gdcmHeaderHelper to load data
2257 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2258 made in the source code
2260 2003-12-10 Benoit Regrain
2261 * Update Windows projects and .cvsignore files
2263 2003-11-12 Jean-Pierre Roux
2264 * ENH gdcmHeader constructor has one more parameter (default value : false)
2265 that allows the user to 'go inside' the SeQuences only
2267 gdcmElValSet:Print takes it into account
2269 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2270 * ENH: Update gdcmPython/CMakeLists
2271 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2272 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2274 2003-11-10 Jean-Pierre Roux
2275 * FIX : gdcmHeader::LoadElements is now based
2276 on the ListTag listElem member,
2277 not longer on the TagElValueHT tagHt member
2278 * ENH : PrintPubElVal shows (temporarily) both results,
2279 with the tagHt member and the listElem member.
2280 (it's easier to 'see' the problems when using Printheader)
2282 * FIX : old private member LgrElem is now splitted into
2283 ReadLength : Length actually found on disk (updated only
2284 if bug fixing is necessary), for internal
2286 UsableLength : Updated by FixFoundLength, to fix a bug
2287 or to allow Parser going on.
2288 Will allow to re-write a kosher header when a SeQuence
2289 with a length (not 0000) is found
2290 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2291 because gdcmElValSet::Add does not update ListElem
2294 2003-11-07 Jean-Pierre Roux
2295 * FIX misstyping in Transfert Syntax name table
2296 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2297 when they have an actual length (not 0000 nor FFFFF)
2298 (Nobody should care of it, but DICOMDIR explorers)
2300 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2301 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2303 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2304 * ENH: vtkGdcmReader now supports LUT !
2305 (vtkgdcmViewer for now is not able to use them though)
2307 2003-11-05 Jean-Pierre Roux
2308 * in testSuite.py : new files names for checking the package
2309 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2310 that returns the pixel area size to the *aware* (vtk) user
2311 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2313 2003-11-05 Benoit Regrain
2314 * in testSuite.py : Modify the rules for checking the paths
2315 : Explicit error messages
2316 * in __init__.py : Related modif
2318 2003-11-03 Jean-Pierre Roux
2319 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2320 to be used by aware (vtk) users that want to manage
2321 LUT (and no to turn the PALETTE image into an RGB pixels one)
2322 * GetPixelType now returns 8U for 24 Bits images
2323 (vtkGdcmReader compliant)
2325 2003-10-31 Jean-Pierre Roux
2326 * Removal of *all* gdcmData images and add them again
2327 in order to loose the 'history' of un-anonymised images
2329 2003-10-31 Jean-Pierre Roux
2330 * RMV : removal of useless jBitsInJsample.h
2331 for both 8 and 12 Bits JPEG Lossy Libraries
2333 2003-10-31 Jean-Pierre Roux
2334 * ENH : Add the functions gdcmFile::GetImageDataRaw
2335 gdcmFile::GetImageDataIntoVectorRaw
2336 that act as GetImageData and GetImageDataIntoVector
2337 except the making of an RGB Plane from Gray Plane + LUT
2338 Intended to aware (vtk) users who know how to manage
2341 GetLUTRGBA return a R,G,B,A LUT if any
2342 lgrTotaleRaw gives the 'Raw' length
2343 GetImageDataRaw returns the gray Plane
2344 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2345 (They stay Grey, just like with other Dicom viewers :-(
2347 2003-10-30 Jean-Pierre Roux
2348 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2350 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2351 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2352 being coherents dicom files.
2354 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2355 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2357 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2358 * ENH: Two steps is necessary to please VC++ compiler...
2359 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2360 * ENH: Add include dir to medcon lib
2361 * FIX: only one function is being exported for now !
2362 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2364 2003-10-29 Jean-Pierre Roux
2365 * adding gdcmHeader::GetLUTRGBA
2366 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2367 --> Mathieu, the modif u're waiting for is not yet committed
2368 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2370 2003-10-27 Jean-Pierre Roux
2371 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2372 00191113.dcm DermaColorLossLess.dcm
2373 MxTwinLossLess.dcm RadBWLossLess.dcm
2374 * ENH: For version prior to vtkImageViewer2 -r 1.19
2375 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2377 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2378 * Removal of ido stuff in CMakeLists.txt
2380 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2381 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2382 * FIX: remove a call to ->Modified ... see comments
2383 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2385 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2386 * FIX: Problem with path for libvtkgdcmPython
2387 * ENH: Try adding a search script for python site-package
2388 * RMV: Remove some file from medcon lib that are not necessary
2389 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2390 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2391 * FIX: More pragma disable fro VC++,
2392 I don't think I break something as it is also disable in VTK/ITK.
2393 But it fasten debug compilation time.
2395 2003-10-23 Jean-Pierre Roux
2396 * gdcm now deals with 16 Bits Run Length Encoded images
2397 (they are compressed as 2 planes images,
2398 one for the high Bytes, the other for low Bytes)
2400 2003-10-22 Jean-Pierre Roux
2401 * Now CheckRead takes into account :
2402 - the bugged 'Leonardo' Siemens images
2403 - the XA images, sent thru the burning VPRO station
2404 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2407 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2408 * FIX: When copying a Makefile.am to CMakeLists.txt
2409 one should remove the '\'
2411 2003-10-22 Jean-Pierre Roux
2412 * in gdcmData adding a bugged 'Leonardo' Siemens image
2413 (wrong lengths in header)
2414 OK with gdcm, KO with the other viewers :-)
2415 * add a GE dlx XA image, thru the VEPRO burning station
2418 2003-10-21 Jean-Pierre Roux
2419 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2420 for a brutal checking of vtkgdcmViewer compliance
2422 2003-10-21 Jean-Pierre Roux
2423 * add the files for 'xmedcon' Jpeg Lossless library
2424 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2426 2003-10-21 Jean-Pierre Roux
2427 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2429 2003-10-21 Jean-Pierre Roux
2430 * garbage Siemens 'Leonardo' images dealt with
2431 (the patch is easy to remove)
2432 * cosmetic changes to avoid warnings
2434 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2435 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2436 no need to press 'r' now.
2438 2003-10-20 Jean-Pierre Roux
2439 * upgrade of checkRead.sh checkWrite.sh according
2440 to new Jpeg Lossless decompressor
2441 * add US.3405.1.dcm, a genuine RGB medical file ...
2442 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2443 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2445 2003-10-15 Jean-Pierre Roux
2446 * general anonymisation in gdcmData
2447 * adding the 'color files' from
2448 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2449 * adding some well knowed bugged-header images
2450 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2451 waiting for their inclusion in Python testsuite
2453 2003-10-15 Jean-Pierre Roux
2454 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2455 no longer seg faults when file is not found
2457 2003-10-14 Jean-Pierre Roux
2458 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2461 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2462 * TODO: *.in file to genereate a UseGDCM later
2464 2003-10-14 Jean-Pierre Roux
2465 * Some supposed-to-be Dicom Images have no preamble.
2466 OpenFile takes it into account
2467 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2468 * Missing elements added in dicomV3.dic
2469 (just to be affraid : have a look at
2470 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2471 and do it again next year ;->
2473 2003-10-13 Jean-Pierre Roux
2474 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2475 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2476 But there are NOT. It's fixed !
2478 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2479 * FIX: "jpeglib.h" was not found on VC++
2480 * FIX: vtkgdcm was not being installed
2482 2003-10-10 Jean-Pierre Roux
2483 * ENH : OpenFile closes the file if it *really* doesn't look like
2484 an ACR-NEMA / DICOM one.
2485 * FIX : testWrite no longer writes an empty file if the source file
2486 is not gdcm Readable
2487 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2490 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2491 * FIX: CMake generate now documentation
2492 * ENH: out of source doc build !
2493 * ENH: Generate both user and dev documentation
2494 * ENH: Should work on windows too
2495 * ENH: Only one doxygen config.in file is needed
2496 * FIX: make install should be ok now on ùnix plateform
2497 * FIX: PATH to dictionary was wrong (missing /)
2498 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2500 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2501 * vtkGdcmReader is now able to read rgb dicom file.
2502 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2503 * added a gdcmViewer to vtk test, use mouse to control
2504 window level & window width
2506 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2507 * CMake-ification of gdcm, we have now two build system
2508 * FIX: on cygwin Wsock32 doesn't exist
2509 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2511 2003-10-06 Emanuel Ollart
2512 * FIX : compilation process wad broken.
2513 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2515 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2516 * change gdcmViewer -> vtkgdcmViewer
2517 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2519 2003-10-06 Jean-Pierre Roux
2520 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2521 ( e.g : well known GE images with a wrong elem length,
2522 : Philips MRI Images with a wrong Huffman table)
2523 * still to be done : allow the reading of bugged LEONARDO Siemens images
2525 2003-10-03 Jean-Pierre Roux
2526 * Odd length strings are padded with '\0' (not with spaces,
2527 to remain compliant with already defined strings,
2528 like Transfert Syntax UID and others)
2530 2003-10-03 Jean-Pierre Roux
2531 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2532 to allow displaying RGB images (not only by affim ;-)
2534 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2535 * vtkGdcmReader is now able to read rgb dicom file.
2536 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2538 2003-10-03 Jean-Pierre Roux
2539 * A few nasty patches to allow the reading of a lot of nasty images
2540 ( e.g : well known GE images with a wrong elem length,
2541 : Philips MRI Images with a wrong Huffman table)
2542 * still to be done : allow the reading of bugged LEONARDO Siemens images
2544 2003-10-03 Jean-Pierre Roux
2545 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2547 2003-10-03 Jean-Pierre Roux
2548 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2549 to allow displaying RGB images (not only by affim ;-)
2551 2003-10-03 Jean-Pierre Roux
2552 * gdcmFile::GetImageDataIntoVector now
2553 - deals with MultiFrames MultiFragments Run Length Encoded files
2554 - deals with YcBcR (YBR_FULL) files
2555 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2556 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2558 (no sample found :-(
2560 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2561 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2562 Two reasons: - clear things
2563 - third parties acces gdcm through header files, so won't
2564 suffer anymore VC++ complains
2566 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2567 * add argv[1] in testvtkGdcmReader.cxx
2570 2003-09-24 Jean-Pierre Roux
2571 * The lines are now eigthy characters long.for
2572 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2574 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2575 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2576 char* to std::string. Thus, the use of strdup becomes useless. (see
2577 previous commis of Malaterre)
2578 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2579 before the last Malaterre's commit.
2581 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2582 * This commit should fix the Debug building under VC++, the problem
2583 was mainly a mixture of debug and release lib being loaded at startup.
2584 * I also remove a depency to a specific C function: strdup. Because I had
2585 to force the link to msvcrtd (whereas strdup is in libc).
2587 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2588 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2589 located in the gdcmCommon.h file. All use of reference of tha has been
2590 changed to now use the variable GDCM_UNFOUND.
2592 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2594 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2595 Dicom dictionary. The test suite can now be run again. Note:
2596 I'm note very happy with the " (RET)" changes. I believe this
2597 RETAINED comment should be dropped when parsing the dictionary.
2598 - PACKAGER corrected
2600 - AUTHORS updated and now in alphabetical order
2601 * Makefile.am now exports gdcm.dsw for Windoze users.
2603 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2604 * cygwin complains about missing std:: in subdir Test/
2606 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2607 * remove some methods that are now in gdcmHeaderHelper
2609 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2610 * vtkGdcmReader set spacing and origin correctly
2612 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2613 * Fix a few delete/delete[] mismatch
2615 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2616 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2617 interpretation to data given by gdcmHeader. For instance there are
2618 heuristics to get informations (look at different places).
2619 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2620 sorting DICOM images based on different strategies.
2621 * modified Makefiles accordingly.
2623 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2624 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2625 when building in debug mode
2626 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2627 src/win32/gdcmdll.dsp
2628 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2630 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2631 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2634 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2635 * src/win32/libgdcmjpeg12.dsp was not dos format
2636 * src/win32/libgdcmjpeg12.dsp :
2637 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2638 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2640 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2641 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2643 * src/gdcmFile.cxx : bug fix in affectation type
2644 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2645 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2646 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2647 symbols... future problem ?
2649 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2650 * src/win32/libgdcmijpeg12.dsp was missing
2651 * modified gdcm.dsw accordingly
2653 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2654 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2656 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2657 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2658 commit of JPR (before his hollidays to facilitate our work).
2659 * setup.py : bug fix in code. Modifications made while the last commit
2660 of JPR. The code hasn't been tested before the commit... it's so
2661 useless to make that (for best programmer that is JPR) !!!
2663 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2664 * tagged the current version as Version0_3 (i.e. version 0.3)
2666 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2667 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2668 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2669 * *.dsp : modifications to use new libgdcmijpeg8 library
2670 * setup.py : bug fix on VTKPATH variable
2671 * PACKAGER : adding all concerning windows
2673 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2674 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2676 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2677 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2678 test suite reported error.
2679 * PACKAGER file added (describes what a packager must do when
2680 packaging a new release).
2681 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2682 * configure.in: upgraded version number to 0.3.0
2683 * fixing build of rpm (through rpm -ta):
2684 - Doc/Makefile.am exports proper doxygen files
2685 - src/jpeg/libijg8/Makefile.am exports the include files.
2687 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2688 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2689 * src/gdcmHeader.h : formatting code
2691 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2692 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2693 We were obtaining error message from vtk. Now, creation of file list
2694 is made in an internal list to prevent this problem.
2695 Bug fix when output is empty.
2696 Bug fix in update of progress value. Previous commit for this was a bad
2698 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2700 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2701 * src/gdcmHeader.h : added method to get the file name
2702 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2703 files. Added method to remove all files on the input
2704 Added FIXME comment concerning the bad parsing of header made by
2705 ExecuteInformation method (in ExecuteData method)
2707 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2708 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2709 when using make instal.
2710 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2711 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2713 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2714 * setup.py : adding include dir of jpeg lib to compile all sources
2715 * */Win32/*.dsp : JPR fix for windows compilation
2717 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2718 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2720 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2721 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2723 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2724 * setup.py is again effective on un*x (takes into account the
2725 addon of the jpeg library)
2726 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2727 * Doc/Doxy* updated (includes above enhancements)
2728 * INSTALL now points to web documentation
2730 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2731 * src/gdcmHeader.h doesn't make unnecessary reference to
2733 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2735 * src/gdcm*.[cxx|h] :
2736 - to allow compilation with gcc 3.x
2737 -- clean up of STL usage (added explicit usage of std::)
2738 -- small fixes on exceptions.
2739 Note: linking not tested !
2740 - clean of doxygen comments to avoid warnings at documentation
2742 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2743 dependent convertion).
2745 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2746 * Clean up of previous JPR garbage commit (not even commented in the
2748 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2749 - moved all jpeg related files from src to src/jpeg/libijg8, with
2750 addition/modification of Makefile.am and configure.in.
2751 - the testSuite is still brain damage (not guilty).
2753 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2754 * WrapVTK.py : modifications to get correctly vtk source files to
2756 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2757 (FileName -> Filename)
2759 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2760 * vtk/vtkGdcmReader.[cxx/h]:
2761 - UpdateProgress method should now be effective
2762 - removed the limitation on having only images loaded (as opposed
2764 - when building a stack of images/volume, a lesser number of
2765 gdcmHeader and gdcmFile instances should be used (hopefully
2766 accelerating things).
2767 - when building a stack of images/volumes, files which are not
2768 loadable (wrong path-filename, wrong permissions on existing file,
2769 or file not parsable by gdcm) are replaced with a black image
2770 in the stack (for the caller to notice the problem).
2772 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2773 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2775 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2776 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2777 between standard library (std) and vtk library (problems are found
2778 under Windows... thanks Windows !)
2780 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2781 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2783 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2785 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2786 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2788 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2789 * When compiling with distutils (see setup.py) the C++ compiler is
2790 called with different flags than the default ones (with automake).
2791 In order to fix all those warning, I compiled gdcm with the command
2792 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2793 and went for warning fixes:
2794 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2795 up from unused variables.
2796 - vtk/vtkGdcmReader.cxx: potential bug fix.
2797 * src/gdcmHeader.h: Doxygen warning cleanup
2799 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2800 * gdcmPython/gdcm.i:
2801 - typemaps correction to take into account the systematic replacement
2802 of "using namespace std" with std:: prefix e.g. std::list,
2803 std::string... (cf changes of 2003-05-21).
2804 - gdcmGlob global variable of type gdcmGlobal (defined in
2805 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2806 exported to Python a as cvar.
2807 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2808 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2809 gdcmDictSet.GetPubDictTagNames() and
2810 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2811 C++ static methods).
2812 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2813 with the above changes.
2815 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2816 * setup.py, manifest.in : bug fix under linux
2818 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2819 * Modification of setup.py to compile vtk part too. Then, we have 2
2820 wrappers which must work with same distutils. For that, we have a
2821 generic distutils in distusiltsWrapping.py ; with :
2822 - build_extWrap class to wrap generically all extensions,
2823 - ExtensionWrap base class for all wrapping extension that contains
2825 - Wrapper interface which wrap sources
2826 + In WrapSwig.py we have extension and wrapper for Swig
2827 + In WrapVTK.py we have extension and wrapper for VTK
2828 * MANIFEST.in : modifications to consider vtk directory and new python
2829 files for compilation
2831 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2832 * Added python wrappers of vtkGdcmReader vtk class (see the
2833 source in vtk/vtkGdcmReader.cxx) :
2834 - vtk/Makefile.am now builds a library
2835 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2836 python library (as opposed to _gdcm.so wich are the python
2837 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2838 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2840 - configure.in has an additional flag --enable-vtk that needs
2841 to be set to enable compilation of vtk related code, that is:
2842 + vtk/vtkGdcmReader.so and
2843 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2844 + gdcmPython/vtkgdcmPython.so (see above)
2845 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2846 be read when compressed or when HighBit + 1 != BitsStored),
2847 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2848 the usage of the python wrapper of vtkGdcmReader vtk class.
2849 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2850 * src/*.[h] all occurences of stl classes are now prefixed with
2851 std::, and all occurences of "using namespace std;" where removed.
2852 This is to avoid pollution of global namespace in included files.
2853 Apparently vtk does not avoid this pitfall: when using both
2854 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2855 collision of various stl members (principally cout...).
2856 * gdcmPython/testSuite.py now cleanly removes temprory generated
2858 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2859 comply with above changes)
2861 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2862 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2863 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2864 vtk data structure (an image Flip was required).
2865 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2866 * cosmetic changes in documentation.
2868 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2869 * src/gdcmHeader.cxx: the constructor no longer exits when an
2870 unexisting file is given as argument.
2871 * The subdirectory Data (containing all the images used for the
2872 test suite) is not part of this repository anymore. A new module
2873 containing those images is now available at
2874 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2875 with the name gdcmData.
2876 All the python scripts (including the package initialisation file
2877 gdcmPython/__init__.py) were adapated to take this change into
2878 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2880 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2881 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2882 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2883 demo of the usage of this class.
2884 Compilation of this vtk part is only done when using the --enable-vtk
2885 at configure (or autogen.sh) stage.
2887 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2888 * More memory link related corrections and documentation fixes.
2890 - maximum info is obtained with a command of the form:
2891 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2892 --show-reachable=yes PrintHeader
2893 - the remaining reachable blocks seem to come from the STL
2894 allocation scheme through the usage of map and list. It looks
2895 like this memory cannot be freed but it is not a memory leak
2896 (in fact further invocation to the STL would recollect the
2897 unused memory allthough it cannot explicitely be freed).
2898 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2899 of displaying an image parsed with gdcm and displayed with VTK.
2900 Note: some images don't seem to work e.g.
2901 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2902 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2903 Allthough this weakens the semantics, it is a ditch attempt to
2904 make gdcm more thread friendly.
2906 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2907 * Memory link hunt (by using valgrind through the command
2908 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2909 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2910 gdcmHeader::_dicom_vr.
2911 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2912 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2914 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2916 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2917 * src/Makefile.am now exports all the necessary include files at
2921 * UpdateGroupLength replaced by new one
2924 * UpdateGroupLength re-written using H-Table
2925 (named UpdateGroupLengthNew untill checks are over)
2927 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2928 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2929 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2931 - gdcmHeader::GetPubElValSet removed.
2932 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2933 UpdateGroupLength, WriteElements, Write.
2934 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2935 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2936 carried the same semantics.
2937 - src/gdcmHeaderIdo.cxx changed accordingly.
2938 - gdcmFile::WriteBase now regroups all the codes from previous
2939 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2940 - enum FileType moved to gdcmCommon.h
2941 * src/gdcmHeader.cxx AddDefault trashed
2942 * gdcmGetXSize added
2943 * getimageDataSize now calls gdcmGetXSize
2944 * Test/*.cxx changed to agree with above changes
2946 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2947 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2948 (to avoid double call by end user).
2949 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2950 by end user, since gdcmHeader::gdcmHeader now handles it.
2952 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2953 * gdcm/Doc many doxygen changes:
2954 - Doxyfile now has two different versions, DoxyfileUsers that generates
2955 the html.users end users oriented documentation and
2956 DoxyfileDeveloppers that generates the html.developper developper
2957 oriented documentation.
2958 - README changed accordingly
2959 - requirement.txt removed (old design info moved to TODO).
2960 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2961 DoxyMainPage.txt, DoxyPython.txt provide more information.
2962 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2963 be updated by simply regenerating the docs with doxygen and copying
2964 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2965 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2966 all the tests in the form "if (<map>.count() >1)" were removed.
2967 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2968 ill-formed documentation sections.
2969 * src/gdcmHeader.cxx: ditto
2971 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2972 * setup.py fixed for un*x (needed macro for stdint.h)
2973 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2974 un*ces with sh-utils test utility.
2975 * gdcmPython/demo/test.py renamed to PrintHeader.py
2976 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2977 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2978 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2979 * src/gdcm*.cxx JPR's bad inclusion fixed.
2981 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2982 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2983 * gdcmPython/demo/test.py changed accordingly.
2985 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2986 * gdcmPython/Makefile.am fixed linking against libstdc++
2987 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2988 * Swig subdir (historical tests of swig version 1.3.17++) removed
2989 * Test/testChangeEntete.cxx some lines commented out in order to make
2991 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2992 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2994 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2995 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2996 hence the user doesn't need this explicit call.
2997 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2998 i.e. LoadElements() call removed.
2999 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3000 - src/Makefile.am declares the proper flag for g++.
3001 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3002 for adding user defined new tags.
3003 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3004 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3005 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3007 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3008 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3009 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3010 src/Makefile.am : the project should properly compile and install
3011 with the autotools, included the python wrappers part.
3012 * gdcm.spec.in : added a spec file for RPM packaging.
3014 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3015 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3017 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3018 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3019 to exported to the environement (see gdcmPython/testSuite.py
3021 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3022 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3023 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3024 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3025 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3027 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3028 * gdcmPython/__init__.py doesn't crash anymore when running in
3029 in InstallMode or PreInstallMode but with an environment given
3030 value of GDCM_DICT_PATH.
3031 * src/gdcmDictSet.[cxx/h] coding style.
3033 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3034 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3035 * src/gdcm.h general comments moved to TODO, and README
3036 * src/gdcm.h should now be seen as a user commodity (including it
3037 should suffice to fully use gdcm). It is nowhere including within
3038 any of the kernel files src/*.cxx and src/*.h.
3040 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3041 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3042 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3044 * src/gdcm*.cxx only include their corresponding include file
3045 (as opposed to gdcm.h)
3046 * gdcmPython/gdcm.i changed accordingly
3047 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3048 the autogen.sh generated "make snapshot" command to work.
3049 * autogen.sh removed history related references to crea package.
3051 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3052 * distutilsSwigCPlusPlus.py work around some swig portability
3055 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3056 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3057 was done in a last ditch attempt to get setup.py _really_
3058 operationnal. The python/gdcmPython layaout add the advantage
3059 of hidding away the python related distutils specific files
3060 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3061 Alas, the src directory was out of scope (i.e. it's relative
3062 position to setup.py was ../src) which made things impossible to
3063 handle (see previous version of python/setup.py). Crossing fingers...
3065 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3066 * python/setup.py now works on Un*x. (harder than I thougth)
3067 * python/distutilsSwigCPlusPlus.py can now have include files
3068 among the list of sources.
3070 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3071 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3072 * modifications in MSVC projects
3074 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3075 * As stated by the first lines of Test/ExceptionAndPython/README, it
3076 looks like we can move back to original usage of exception within
3077 src/gdcm* and hence remove the errno stuff that was introduced
3078 as a quick and dirty fixture of this problem (added to the TODO).
3079 * Doc/Doxyfile configuration file for Doxygen and corresponding
3080 README file for usage added.
3081 * Test/testWrite.cxx added. This new test comes from a split of
3082 test.cxx that is now reverted to its original purpous i.e.
3083 testing the proper parsing of a Dicom related file.
3084 testWrite.cxx concentrates on testing the IO part of gdcm.
3085 * Test/bug1.cxx (containing a bug on WIn32) added.
3086 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3087 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3088 whose purpose is to publish the content of the TagNames of the
3089 Dicom public dictionary were not accessible without an
3090 instance of class gdcmHeader.
3091 - those methods are now static methods of gdcmDictSet and hence
3092 require no instances at all to be invocated.
3093 - within gdcmDictSet this change required to change some method
3094 to class methods (i.e. are now static) among which SetDictPath
3095 (renamed to BuildDictPath) and LoadDefaultPubDict.
3096 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3097 the above changes by calling the new method classes of gdcmDictSet.
3098 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3099 the above to be effective.
3100 * python/gdcmPython: in order to wrap properly the above changes
3101 for Python, swig version now needs to be > 1.3.17.
3102 * python/gdcmPython/Makefile fixed to adapt itself to new
3103 configure/make shema introduced by Johan Montagnat (thanks for the
3104 contribution). Alas this Makefile cannot be turned into a proper
3105 Makefile.am without some heavy changes in the configure.in
3106 (for python dectection).
3107 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3108 now avoids publishing the empty entries.
3110 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3111 * python/setup.py : bug fix concerning install under windows
3112 ExtraPath reused :-P
3113 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3115 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3116 * Dicts/dicomV3.dic : remove double spaces !!!
3117 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3118 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3121 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3122 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3123 method. Doxygenation.
3124 * src/gdcm.h clean up of JPR spurious comments.
3126 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3127 * python/distutilsSwigCPlusPlus.py now properly collects the
3128 shadow classes generated by "swig -c++" (gdcm.py in our case)
3129 when using "python setup.py install".
3130 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3131 reexports the working classes.
3132 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3133 by the classical C errno scheme. This is to prevent an obscure
3134 behavior of the python wrappers when importing wxPython.wx prior
3135 to gdcmPython (which ended up in an abort call). An illustration
3136 of this oddity can be found in the Test/ExceptionAndPython
3137 subdir (see the README file). This problem probably due to
3138 an combination of g++ and dynamic loading.
3139 * added Test/ExceptionAndPython (see above)
3141 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3142 * Changed the layout of the python part to avoid bloating main
3143 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3144 i.e. the distutils arsenal. All the python related stuff is
3145 again in a python subdir, but the package itself is now in
3147 * setup.py was cleaned up:
3148 - pythonIncludePath removed
3149 - python setup.py bdist target is now functional.
3150 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3151 collision with other packages). gdcmPython/demo/*.py changed
3154 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3155 * python subdir moved to gdcmPython (preparation of distutils packaging).
3156 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3157 distutils installer is operational.
3158 * - gdcmPython/__init__.py now properly loads the swig generated
3159 shadow classes (from gdcm.py).
3160 - gdcmPython/demo/*.py changed to import the package gdcmPython
3161 instead of gdcmPython/demo/load.py.
3162 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3164 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3165 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3166 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3167 entries within the associated public Dicom dictionary resp. the same
3168 information but sorted by the fourth field (PAT, IMG, DIR) of the
3170 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3171 are now in the "???" group.
3172 - python/gdcm.i changed accordingly,
3173 - python/demo/printGroupedPublicDict.py added, that gives an example
3174 of the above new functionalities in Python.
3176 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3177 * src/gdcm.h, gdcmHeader.cxx:
3178 - historic references to glib's g_malloc and g_free (#defined)
3179 were definitively removed.
3180 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3181 * src/gdcmElValSet.cxx:
3182 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3183 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3184 - GetElValue(string) renamed to GetElValueByName.
3185 - Added GetElementByName(string).
3186 * src/gdcmHeader.cxx: added
3187 - GetPubElValRepByNumber(guint16, guint16)
3188 - GetPubElValRepByName(string)
3189 - GetShaElValRepByNumber(guint16, guint16)
3190 - GetShaElValRepByName(string)
3191 - GetShaElValByNumber(guint16, guint16)
3192 - GetShaElValRepByName(string)
3193 - GetElValRepByNumber(guint16, guint16)
3194 - GetElValRepByName(string)
3195 - GetElValByNumber(guint16, guint16)
3196 - GetElValRepByName(string)
3197 * Doc/requirements.txt added.
3199 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3200 * Test/Makefile building now depends on the one of libgdcm.so
3201 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3202 pixel data) aware which enables finding the address (offset) of
3203 the pixel data of JPEG encoded DICOM files. This leaves only a single
3204 file in the testSuite whose pixel data address (offset) is unknown.
3205 * python/testSuite.py changed accordingly.
3207 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3208 * VC++ has some strong limitations when working with the STL, as stated
3209 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3210 "Also note that some STL containers (map, set, queue, list, deque)
3211 cannot be exported. [...]
3212 Some STL classes contain nested classes. These classes can not
3214 This is caused by a designed limitation that once a template
3215 class is instantiated, it can not be re-instantiated and
3217 Since our usage of map<> is ubiquitous in gdcm, this "designed
3218 limitation" of VC++ is a pitfall.
3219 Hence the Python wrappers of gdcm cannot be incrementally linked
3220 against the c++ dynamic library. The dirty but only workaround is
3221 to forget about incremental link of dynamic libraries and to generate
3222 the Python wrappers library with the inclusions of the underlying C++
3224 The following modifications concern this matter on Win32/VC++:
3225 - wrapping python correct with standalone wrapped dll (don't use separate
3226 dll under windows !!!!)
3227 - python21_d debug mode enabled (ask Frog how to use it :-)
3228 - NO problem with having an STL member of class for example string in C++
3229 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3230 - Python test of dcmlib in Python is ok under windows on a large set
3232 * removed glib references
3233 * typedef's inserted in gdcm.i for correct swig type management
3235 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3236 * python/demo/*.py load.py extracted from test.py. Added explore.py
3237 that only displays required tags and testAll.py that parses all
3238 the files of the testsuite without using unittest.
3239 * python/testSuite.py other additional test on new files added.
3240 * Data/* new test files added accordingly to the testSuite.
3241 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3242 the vr in the file differs from the one of the dictionary.
3244 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3245 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3246 values, but limits itself to values which are below a user specified
3247 size (by default 1024 bytes).
3248 * python/gdcm.i : elements not loaded (because their size is above the
3249 user specified treshold) are exported with their TagKey as key of the
3250 python dictionary. This enables the testsuite to make some checks
3251 on the unloaded elements (since we have their offset and size).
3252 * python/testSuite.py
3253 - now tests for the existence and proper value of the pixel data
3254 - two new examples added.
3255 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3257 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3258 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3259 aware. See the strategy comments in gdcmHeader::FindLength().
3260 * Test/test.cxx now accepts a filename as first argument.
3261 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3262 * python/testSuite.py changed to integrate test on above files.
3264 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3265 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3266 the vr was also RET.
3267 * python/testSuite.py more tests added.
3269 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3270 * python/testSuite.py unittest test suite added (uses Data)
3271 * Data/* dcm and acr files for the test suite.
3272 * glib dependance removed from un*x version. We now use ISO C99
3273 7.18 Integer types (see stdint.h)
3274 - python/Makefile, src/Makefile src/gdcm.h
3275 * src/ when an explicit vr (like dicom files) suddenly poped an
3276 implicit element we use to mark the underlying DictEntry of the
3277 concerned ElValue with "Implicit". This strategy was damageable
3278 too the public or provite dictionaries, since some of their vr
3279 would be changed. Since Header::FindLength heavily relies on the
3280 detection by Header::FindVR of falsely explicit elements, I
3281 added an extra ImplicitVr member to ElValue (boolean).
3282 The rest of the changes we the necessary adaptations.
3284 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3285 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3287 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3289 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3290 * Adaptation for porting to VC++:
3292 o forced to use std namespace (for string to be known)
3293 o all class use __declspec export style on WIN32
3294 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3295 (in stdlib.h on Win32 but in std:: for gcc)
3296 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3297 variable GDCM_DICT_PATH.
3298 * src/gdcmHeader.cxx verbose comments made discrete.
3300 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3301 * python/gdcm.i: added a typemap that converts a C++ hashing table
3302 to native Python dictionary.
3303 * python/demo/test.py:
3304 - now uses the native dictionary for exploration of gdcmHeader.
3305 - takes an optional filename argument (the file to parse).
3306 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3307 PubElVals hashing table.
3308 * Dicts/dicomV3.dic removed error prone trailing spaces.
3310 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3311 * Python wrapping process moved away from src/Makefile to
3312 newly created python/Makefile (as well as gdcm.i)
3313 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3314 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3315 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3316 from the environement variable GDCM_DICT_PATH (when existing).
3317 * src/gdcmDict::GetTag bug fix.
3319 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3320 * Straightforward temporary fixes for swig to build the python wrappers.
3321 src/Makefile now has a python working entry [by working we mean
3322 that we can import the shadow classes without errors].
3324 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3325 * hashtest.cxx removed (since already in Test)
3326 * src/gdcmlib.h renamed to src/gdcm.h
3327 * src/dcm.i renamed to src/gdcm.i
3328 * src/Makefile prepared for python wrapping
3330 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3331 * src/gdcmHeader.cxx :
3332 - Parsing of header is now separated from loading of element values
3333 (see gdcmHeader::LoadElements).
3334 - general clean up of hopefully all file access (creation of
3335 ReadInt16 and ReadInt32)
3337 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3338 * src/gdcmHeader.cxx :
3339 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3341 - SetLgrElem renamed to SetLength
3342 - GetLgrElem renamed to GetLength
3343 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3344 * src/gdcmElValSet.cxx fixed both GetElValue methods
3345 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3346 due to IdoDude was cleaned out.
3348 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3349 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3350 concentrates on finding the value representation (when it exists).
3351 RecupLgr now only finds the element value length, and it avoids
3352 returning the unecessary skL (skipped length).
3353 Also, offsetCourant was simply removed (with taille_fich) since
3354 it was redundant with the File position internals (by using
3355 ftell and fseek). This also made skL (see above in RecupLgr) usage
3357 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3358 on the libido specificities which are handled through class
3360 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3363 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3364 * Truckload of changes. Parsing of header is barely functional
3365 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3367 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3368 * src/gdcmHeader.cxx many addons of low level methods
3370 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3371 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3372 and _IdDcmSWAP_LONG.
3374 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3375 * This corresponds to all the changes decided at the meeting of
3376 May 23 2002. Needless to say we are running late...