1 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * /binary_write/ gdcm source. Now even on big endian we are writting
3 little endian. This should -heopfully- fix some tests
5 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
6 * Now the dictionary is compiled into gdcm lib. This is a default
7 behavior, thus any dic file specified is picked before failback to
8 the one comiled into lib
10 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
11 * Change internals for gdcmDict. Don't use any 'new' any more.
12 This should definitely solve any leak problem, and we should be
13 as fast as before, as long as don't modify too much the dictionary.
15 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
16 * STYLE: ivars should start with a capital letter.
17 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
18 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
20 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
21 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
22 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
23 new 2004 dictionaries added (thanks to JPR).
24 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
25 * CLEANUP_ROUND (15) for gdcmPixelConvert
26 - RLEFrame::NumberFragments is now of type unsigned int
27 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
28 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
31 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
32 * Initial work in gathering all transfer syntax accessors. clearly
33 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
34 ivars, but only one transfersyntax (class) ivar with equivalent method on
37 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
38 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
39 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
40 discussed (plus I didn't like having a 2000 lines patch not commited)
42 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
43 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
44 * CLEANUP_ROUND (14) for gdcmPixelConvert
45 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
46 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
47 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
49 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
50 anymore and hence avoids storing a copy of PixelConvert::Decompressed
51 into File::Pixel_Data.
53 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
54 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
55 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
56 * CLEANUP_ROUND (13) for gdcmPixelConvert
57 Substituted File::ParsePixelData() with PixelConvert::Print() new
59 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
60 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
61 method to those classes.
62 - src/gdcmFile.[cxx|h]:
63 -- Added a ::Print() method.
64 -- PixelConverter is now a reference instead of a member.
65 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
66 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
68 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
69 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
70 collaboration diagram and inheritance diagram should be generated with
72 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
73 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
74 pointlessly wrapped (see
75 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
76 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
77 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
78 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
79 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
80 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
81 -- File::Initialise: PixelConverter setup moved away to
82 PixelConverter::GrabInformationsFromHeader()
83 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
84 interpretation moved away to PixelConverter::BuildRGBImage()
86 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
87 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
88 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
90 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
91 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
92 displayed on Win32 when a brutal abort() occurs (because of uncatched
93 exception). See TODO new entry of this commit for more on this.
94 * TODO added new entry.
95 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
96 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
97 - HandleColor is no longer called from gdcmFile.cxx
98 - gdcmPixelConvert.cxx clean up on method arguments and internal
99 variable names for semantical coherence.
101 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
102 * Finished lossless transition, not only do we now read all lossless jpeg
103 images, without the need of the Cornwell lib, but we do read them properly now
104 * To reduce code (well to avoid code duplication), I defined a common place
105 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
106 redefine symbols. This is not prefect but this the best solution I found for a
107 compilation time jpeg option.
109 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
110 * Update jpeg ijg lib to support lossless jpeg implementation
111 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
113 * Also added a special copyright for dcmtk since we use their bugfixes.
116 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
117 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
118 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
119 matters, as stated in warning note at begining of %include section).
120 * src/gdcmDicomDir*.[cxx|h]: coding style
121 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
122 * src/gdcmJpeg8.cxx: doxygen fix.
123 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
124 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
125 from File:: to PixelConvert::.
127 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
128 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
129 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
130 - more code moved away from File:: to PixelConvert::
131 - fat setup of PixelConverter set in place in File::Initialise.
133 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
134 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
135 namespace at the file system level. So now you should convert your examples
137 gdcmHeader -> gdcm::Header
138 It would be nice if people keep in mind to no open the namespace, since it
139 allows compilation on broken plateform which were defining common symbol in
140 the standart namespace (like LP, Unknown ...)
142 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
143 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
144 The JPEG fragments are now parsed at the same stage than the RLE
145 information. All code related to JPEG is now in gdcmPixelConvert:
146 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
147 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
148 export a gdcmFile:: method. Those are simply global functions
149 (for the time being this is better than having them attach to
150 either gdcmFile:: or gdcmPixelConvert::).
151 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
152 and stores the result in a gdcmJPEGFragmentsInfo.
153 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
154 code (among other stuff) moved away from gdcmFile:; to
157 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
158 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
159 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
160 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
161 clean up of RLE related code.
162 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
163 - src/gdcmRLE.cxx removed
164 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
165 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
166 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
167 * CLEANUP_ROUND (9) for gdcmPixelConvert
168 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
169 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
170 away from gdcmFile:: to gdcmPixelConvert::.
172 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
173 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
174 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
175 This is because Parse7Fe0 used to parse the pixels to compute the
176 length. This task was passed over to FindDocEntryLengthOB() a long
177 time ago, EXCEPT I had forgotten the OW case...
178 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
179 we just recylce the code for parsing RLE fragments and computing
181 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
182 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
183 with the retired Parse7Fe0().
184 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
185 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
187 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
188 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
189 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
190 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
191 - src/CMakeLists.txt: alphabetic order reodering + new entries.
192 * CLEANUP_ROUND (4) for gdcmPixelConvert
193 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
194 to return an unused length.
196 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
197 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
198 this should be cleanner from the plane view. The iostream are erally a pain
199 to use to do simple stuff.
201 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
202 * Redo the compilation of the ijg jpeg library. Now only one source is
203 necesseray. No need to rename file by hand what so ever. CMake handle the
204 copying of the file within different directory, configure header file to
205 modify some symbol. The only addition made to ijg wasd a mangle table so
206 that symbol are different wether we are within 8bits or 12bits.
208 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
209 * Added documentation of vtkgdcmReader on Website:
210 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
211 with it's binary name).
212 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
213 the Website to be more complete.
214 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
215 doxygenated documentation.
216 - Doc/DoxyVtkGdcmReaderExamples.txt added
217 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
218 DoxyVtkGdmReaderExamples.html )
219 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
220 * CLEANUP_ROUND (3) for gdcmPixelConvert
221 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
223 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
224 * CLEANUP_ROUND (2) for gdcmPixelConvert
225 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
227 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
228 * CLEANUP_ROUND for gdcmPixelConvert:
229 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
230 - src/gdcmPixelStuff[h|cxx] removed
231 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
232 - src/CMakeLists.txt changed accordingly
234 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
235 gdcmVersion.py moved to newly created ATTIC related
236 gdcmPython/SetupOldies/ directory.
237 * Autotools clean up:
238 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
239 - autogen.sh configure.in acinclude.m4 python.m4 removed
241 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
242 * src/*.cxx *.h Reference to License.htm fixed to License.html.
243 * Doc/CMakeLists.txt, doxygen.config.in: fix.
244 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
246 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
247 * TODO updated with Mathieu suggestions. I proposed a template for
248 describing TODO entries and used it for new entries.
249 * Added Doc/Website/CodingStyle.html, Developpers.html,
250 DeveloppersPython.html, GdcmDataCvs.html and
251 DownloadVersion0_1.html, DownloadVersion0_3.html.
252 * Some Doc/*.txt Doxygen files (which do not really concern the
253 documentation itself, but the website) moved to html and
254 placed in directory Doc/Website:
255 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
256 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
257 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
258 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
259 * CMakeLists.txt changed accordingly.
260 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
261 DeveloppersPython.html
262 * INSTALL nows refers to Doc/Website/Installation.html
264 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
265 * Added Doc/Website directory, that contains a first raw version
268 2004-09-23 Jean-Pierre Roux
269 * FIX In order not to be poluted any longer by casting problems,
270 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
271 we can now delete[] it safely
272 * VoidArea is now called BinArea (less confusing name),
273 and all the methods called ...VoidArea... are now ... BinArea...
274 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
276 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
277 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
278 clear) TagHT, which is an inherited member of gdcmElementSet. It is
279 up to the destructor of gdcmElementSet to clean up TagHt and it's
282 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
283 * Test/CMakeLists.txt: update to follow gdcmData renamings.
284 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
286 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
287 * ENH: added some utility method that builds a flat dictionnary
288 holding all the Dicom entries contained in the recursive structure
289 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
291 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
292 BuildFlatHashTable() that build a flat dictionary.
293 - src/gdcmElementSet.h: added a new private GetTag() accessor.
294 gdcmDocument is now a friend of gdcmElementSet.
295 - src/gdcmElementSet.cxx: clean up.
296 - Example/FlatHashTablePrint.cxx added.
297 - Example/CmakeLists.txt changed accordingly
299 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
300 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
301 moved away from gdcmDocEntrySet (since this class is an abstract class
302 acting like an interface). SQDepthLevel and BaseTagKey are now
304 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
305 and associated accessors. Doxygenation of the class.
306 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
308 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
309 Use SQDepthLevel accessor instead. ::Print() adapted.
310 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
311 - src/gdcmDocument.cxx changed accordingly.
313 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
314 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
315 - The following is the doxygen comment of the typedef declaration
316 of gdcmagKey in src/gdcmCommon.h:
317 gdcmTagKey is made to old an "universal" (as in URL, Universal
318 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
319 A dicom tag allways has a group and an element, but a set of tags
320 embeded in various (optionally nested) sequences and sharing
321 the same group and element all share the same (group, element)
322 "identifier". Hence the (group, element) cannot be used as an
323 identifier (in gdcm we shall refer to a "TagKey") of a tag.
324 In order to construct a proper tag identifier (i.e. a key) we
325 consider the following definition of a TagKey:
326 - let Group, Element be the string representation of the
327 group and element dicom tag members,
328 - let ItemNumber be the string representation of the integer
329 index of the considered item number of a sequence,
330 Let the key of a tag embeded in a sequence, noted SeqTag, be
332 /ItemNumber#Group|Element
333 where "/", "#" and "|" are characters acting as separators.
334 Then the general form of a gdcmTagKey is given by:
335 Group|Element<SeqTag>
336 where <SeqTag> means NO or many instances of SeqTag.
337 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
340 but the gdcmTagKey of a tag "embeded" is the first item of
341 a sequence, itself nested in the third item of a sequence is the
343 0004|1220/2#0008|0082/0#0008|0090
344 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
345 order to hold the new sequence compatible key. Previously, the
346 GetKey() method would look in the underlying gdcmDictEntry.
347 - src/gdcmDocEntry.cxx:
348 -- constructor now copies the underlying DictEntry key, in the local
350 -- ::Print: displays the member Key, instead of the (group, element).
351 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
352 - src/gdcmDocEntrySet.h:xi
353 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
354 -- now has a new BaseTagKey member.
356 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
357 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
359 This poses the problem with the semantics of the following lines
360 LoadEntryVoidArea(0x0028,0x1201); // R LUT
361 LoadEntryVoidArea(0x0028,0x1202); // G LUT
362 LoadEntryVoidArea(0x0028,0x1203); // B LUT
363 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
364 to the long FIXME note for what the problem is. Nevertheless in
365 order to get things working the dicom dictionary was altered !
366 Please fix things urgently...
367 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
368 information), see above note on moving the member VoidArea. Nevertheless
369 the following entries previously correctly set as US are now inproperly
371 0028 1201 OW IMG Red Palette Color Lookup Table Data
372 0028 1202 OW IMG Green Palette Color Lookup Table Data
373 0028 1203 OW IMG Blue Palette Color Lookup Table Data
374 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
375 of gdcmDocEntry moved to gdcmSeqEntry.
376 * src/gdcmSeqEntry.cxx: STYLE.
378 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
379 * Test/TestAllEntryVerify.cxx minor fix and added comments.
381 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
382 * gdcmPython/testSuite.py: all the test suite in python is now moved
383 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
384 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
385 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
387 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
388 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
389 to avoid inclusion recursion until STL is reached.
390 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
391 mecanism. errno.h is not included in gdcm anymore.
392 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
393 (gdcmFormatError now inherits from gdcmFormatUnexpected).
395 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
396 gdcmData/TestAllEntryVerifyReference.txt
397 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
398 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
399 exception_on_error parameter.
400 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
401 - vtk/vtkGdcmReader.cxx changed accordingly,
402 - Example/*.cxx and Test/*.cxx changed accordingly.
404 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
405 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
406 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
407 enable_sequences removed from gdcmHeader constructor and dependencies.
408 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
409 * gdcmPython/demo/PrintHeader.py: dummy fix.
410 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
411 skip_shadow removed from gdcmHeader constructor and dependencies.
412 * Example/*.cxx and Test/*.cxx changed accordingly.
414 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
415 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
416 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
418 2004-07-21 Jean-Pierre Roux
419 * FIX Now, Parsing and Printing a DICOMDIR do work!
420 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
422 2004-07-20 Jean-Pierre Roux
423 * FIX Some brain damaged headers have Zero-Lenght fields
424 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
426 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
427 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
428 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
429 variable (instance of gdcmDebug) by a definition macro, and the instance
430 is now in static in the gdcmDebug class
431 * src/gdcmSQItem.h : (FIXME) remove an undefined method
432 * Test/PrintAllDocument.cxx : bug fix in the result of the test
434 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
435 * WARNING: ctest now depends more tightly on gdcmData. You should
436 check out gdcmData properly for things to run smoothly...
437 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
438 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
439 we need the pixels not be loaded in order to use the ValEntry
440 that displays position and size).
441 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
442 This is a C++ based equivalent of gdcmPython/testSuite.py that should
443 be deprecated. If you have any doubts about the advantages of a
444 modern scripting language (read Python) versus grass root C++ (i.e.
445 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
446 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
447 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
448 Anyhow, consider documenting the gdcmData images in
449 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
451 * Test/CMakeLists.txt:
452 - now uses TestAllEntryVerify.cxx
453 - specific comments on oldACR00001.ima (now renamed in gdcmData
454 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
455 gdcmData/TestAllEntryVerifyReference.txt
458 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
459 * src/*.[h|cxx] : typedef clean up
460 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
461 - TagKey renamed to gdcmTagKey (for external usage)
462 - VRKey renamed to gdcmVRKey (for external usage)
463 - removal of typedef duplication.
464 - Removed all unecessary inline keyword from class inline definitions.
465 - Some method|function(void) declarations replaced with method|function().
466 * src/jpeg/libijg12/jdhuff12.c:
467 - printf polluting ctest removed.
468 - TAB removal for comminting
470 - TestAllReadCompareDicom.cxx: added a test that compares all the
471 images in gdcmDataImages.h with corresponding images in
472 gdcmData/BaselineDicom/. When baseline images are not present
473 this test creates them.
474 Note: we need to validate each reference image, but before that
475 I'd like to rename them with a more explicit name...
476 - CMakeLists.txt: changed accordingly.
477 * Example/*.cxx: examples now only include gdcm.h (as opposed to
478 including each header needed).
480 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
481 * Test/*.cxx and Example/*.cxx: moved some examples away from the
482 test suite to the Example directory. Are concerned:
487 - TestWriteSimple.cxx
488 * Test/CMakeLists.txt: added some comments on reasons for black listing
489 image gdcmData/oldACR00001.ima
491 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
492 * Test/CmakeList.txt: removed the following from black list (to be coherent
493 with removal from gdcmData):
494 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
495 - gdcm-MR-PHILIPS-16.dcm
497 Added the following because after last cvs update, they cause
498 ctest -R TestReadWriteReadCompare
500 - gdcm-MR-SIEMENS-16-1.acr
502 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
503 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
504 new comments in this file) we temporarily (sigh) move to a weaker
506 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
507 we don't need to black list the following images anymore:
508 - 8BitsUncompressedColor.dcm
510 - US-PAL-8-10x-echo.dcm
511 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
512 fixes and the beautified code ;-)
513 This fixes the bug introduced in version 1.42 (when beautifying)
514 that made the parsing of 8BitsRunLengthColor.dcm unproper.
515 Note: ctest was blind to this bug (this means we need to still
516 improve the test suite). The bug could be detected by using
517 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
519 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
520 and by displaying the (garbage) produced file temp.XDCM...
522 2004-06-29 Jean-Pierre Roux
523 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
524 - replace by uggly but working old code :-(
525 A lot of things should be OK again.
526 It's really urgent to have a test suite that *tests*,
527 to prevent Frog's beautifying sessions to break all the stuff
528 (twice, withing a fortnigh ...)
530 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
531 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
532 redundancy) to added Test/TestReadWriteReadCompare.cxx
533 * Test/CmakeList.txt: because the compare test of
534 Test/TestReadWriteReadCompare.cxx fails, the following images are
535 black listed: - 8BitsUncompressedColor.dcm
537 - US-PAL-8-10x-echo.dcm
538 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
539 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
540 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
541 and ad-hoc kludge. This kludge is now removed, and on encountering
542 such an image (OB field brain damaged) we set errno. Then in
543 ::FindDocLength() we "fix" the length as being ALL what remains
544 in the file (until EOF). We then proceed, hoping for the best...
545 This fixes a SegFault in ShowDicom when trying to write such an
547 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
548 (because TestWriteRead breaks on it, after a non conformal commit?).
549 ctest now runs properly, except for MakeDicomDir (which was allways
550 broken) and the Python related stuff (still not fixed).
552 2004-06-24 Jean-Pierre Roux
553 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
554 FIX : Test/TestReadWrite now iterates on all the file names
555 (instead of infinite loop)
556 ENH : Test/TestWriteRead now iterates on all the file names
558 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
559 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
561 2004-06-24 Jean-Pierre Roux
562 FIX : - now Write drops LUT Descriptors and LUTs (if any)
563 when SamplesPerPixel =3
564 - now Write is no longer confused by
565 'BitsAllocated = 12" and 'BitsStored=12"
566 - "UN" value representation Elements are now written correctly
567 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
568 ENH : - now gdcmHeader has its own Write methods
569 (in order to split the job that has not to be done
572 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
573 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
574 loop on the same image until memory went out.
575 Note: this means we still have gobs of memory loss in PrintDocument
576 * src/gdcmDocument.cxx: fixes problem on parsing on file
577 gdcmData/16BitsJpegLosslessGrayScale.dcm.
579 2004-06-24 Jean-Pierre Roux
580 FIX : Write - All the Sequences and Sequence Item are now written
581 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
582 is added a the end, when necessary.
583 - A lot of brain-damaged images, that were read correctly are
584 now written correctly
585 - length compatible BinEntry are now loaded correctly
586 (even for odd groups)
587 Note : only Explicit Value Representation was checked.
588 (question : is implicit VR really necessary for gdcm ?)
590 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
591 * DEVELOPPER: added a proposition of coding style.
592 * src/gdcmDocEntry.h: removed every inline declaration (for test of
595 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
596 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
597 Use the gdcmDocEntry::Print() and Write() instead.
598 * src/gdcmDocument.cxx: bug fix.
600 2004-06-22 Jean-Pierre Roux
601 FIX : gdcmDocument.cxx
602 - Now we do recognize the JpegLossLess format (there was a misstyping in
603 code 'beautyfication' :-(
604 - Now we automaticaticaly load the Luts, if any
606 2004-06-22 Jean-Pierre Roux
607 In order : to write Sequences, whatever their imbrication level,
608 : to allow user to create his own Sequences
609 a lot of modif where necessary (adding, moving, or virtualising methods)
611 WARNING : save your own sources *before* cvs up !
614 ADD virtual void Write(FILE *fp, FileType filetype);
617 ADD virtual void Write(FILE *fp, FileType filetype);
618 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
621 ADD virtual void Write (FILE *fp, FileType filetype)=0;
622 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
623 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
624 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
625 ADD std::string GetEntryByName(TagName name);
626 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
628 std::string vr = "unkn",
629 std::string fourth = "unkn",
630 std::string name = "unkn");
631 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
632 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
633 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
634 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
635 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
636 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
637 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
638 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
641 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
642 ADD virtual std::string GetEntryByName (TagName tagName);
643 ADD virtual std::string GetEntryVRByName (TagName tagName);
644 REM virtual bool Write(FILE *, FileType);
645 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
646 FILE *_fp, FileType type);
647 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
648 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
649 REM virtual bool WriteEntries(FILE *_fp,FileType type);
650 REM virtual std::string GetEntryByName (std::string tagName);
651 REM virtual std::string GetEntryVRByName (std::string tagName);
652 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
653 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
654 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
656 std::string vr = "unkn",
657 std::string fourth = "unkn",
658 std::string name = "unkn");
659 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
660 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
661 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
662 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
665 ADD virtual void Write(FILE *fp, FileType filetype);
668 ADD virtual void Write(FILE *fp,FileType filetype);
671 ADD virtual void Write(FILE *fp, FileType filetype);
672 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
673 REM std::string GetEntryByNumber(guint16 group, guint16 element);
674 REM std::string GetEntryByName(TagName name);
677 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
679 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
680 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
681 The default constructor invoked by the line
682 gdcmHeader *f1 = new gdcmHeader( header );
683 was gdcmHeader::gdcmHeader(bool) instead of the expected
684 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
685 Hence the parsing wasn't executed... See also below.
686 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
687 as explicit constructor didn't do the trick to fix the above problem.
688 Could anyone explain why ?
689 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
690 properly calls gdcmValEntry::Print() (that was weed out from
691 code related to gdcmBinEntry).
693 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
694 * In order to fix memory leaks:
695 - Test/TestWriteSimple.cxx: added cleaning of free store through
697 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
698 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
699 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
700 (through the call to ::AddDicomDirMeta()) or the destructor
701 would crash when deleting uninitialized ::metaElems].
702 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
703 - src/gdcmDocument.cxx:
704 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
706 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
707 was causing memory leaks.
708 - src/gdcmSQItem.cxx:
709 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
710 cleanly handled with polymophism: sorry but my milage is low).
711 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
712 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
713 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
714 This avoids SegFaulting.
715 - src/gdcmSQItem.h: coding style.
717 - Test/TestWriteSimple still severely sucks. The output image content
718 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
719 damaged when displayed with vtkgdcmViewer.
720 - on memory leaks: TestWriteSimple leaks really less (see entry
721 of 2004-06-18 in Changelog file for the call to valgrind).
722 - on segfaults: ctest now passes all the tests but one (no more
724 * Erroneous leading white fix:
725 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
726 white[s] (as opposed to from >> xxx, that removes it [them].
727 - src/gdcmTS.cxx: ditto.
728 - gdcmPython/testSuite.py: dirty related kludge removed.
729 * src/*: remaining references to gdcmParser removed.
730 * src/*[cxx|h]: added copy[way]left header.
733 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
734 * In order to fix writing of dicom files:
735 - Test/TestWriteSimple.cxx: a simpler example of writing.
736 - Test/CMakeLists.txt changed accordingly.
737 - src/gdcmDocument.cxx:
738 -- The destructor now recursilvely removes potential sequences.
739 -- Bug fix in ::IsJPEG2000()
740 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
741 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
743 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
744 to only declared) and build on top of
745 ::GetDocEntryByNumber(guint16, guint16).
746 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
747 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
748 for usage in destructor and treatement of promotion in
749 ::ReplaceOrCreateByNumber().
750 - src/gdcmSQItem.cxx: destructor should better handle his job.
751 Test/TestWriteSimple now runs (or at least it DOES something).
752 * We can now start hutting memory links. A good starting point is:
753 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
754 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
755 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
757 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
758 * Valgrind note: after Mathieu Malaterre teached me how to read
759 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
761 Using gcc, you can force the STL to use malloc and to free memory as
762 soon as possible by globally disabling memory caching.
763 With 3.2.2 and later, you should export the environment variable
764 GLIBCPP_FORCE_NEW before running your program.
765 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
766 simply vanish (it is still not clear to me, whether this means that
767 STL std::string leaks or if valgrind believes it leaks...).
768 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
769 running bin/gdcmTests makeDicomDir):
770 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
771 - Test/makeDicomDir.cxx now properly traps empty lists and returns
773 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
774 SegFaulting (I drowned in DicomDir related code when trying to
775 understand why the list is empty...).
776 * src/gdcmDocument.h: first BSD license header try.
777 * Doc/License.txt added.
779 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
780 * src/gdcmDocument.[h|cxx]:
781 - Clean up of the Transfer related predicates. They are now all based
782 on new method isGivenTransferSyntax, that (should) handle properly
784 - general clean up, simplification, and coding style.
785 - Specific clean up of Parse7FE0() (umproperly named actually).
786 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
788 2004-06-14 Jean-Pierre Roux
790 - fix the display of Sequence Delimitor (SQDepthLevel pb)
791 - fix the display of SQItem ordinal number
792 - add the GetSQItemByOrdinalNumber method
793 - remove some useless never written private methods
795 2004-06-14 Jean-Pierre Roux
797 - adding a constructor taking a gdcmDocEntry as an input param
798 - ReplaceOrCreateByNumber now returns :
799 a gdcmBinEntry * if a Binary (void *) value is passed as a param
800 a gdcmValEntry * if a string value is passed as a param
802 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
803 according to the param type (no longer sets a gdcmDocEntry)
804 - GetValEntryByNumber, GetBinEntryByNumber added
805 - NewValEntryByNumber and NewBinEntryByNumber added
807 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
809 - GetSQItemNumber and SetSQItemNumber added, to provide
810 a (relative) Item identier inside a given Sequence
811 \warning : some pb remaining around this number
813 - AddEntry now takes the Item Number as a param
815 - adding a constructor taking a gdcmDocEntry as an input param
817 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
818 * Memory leak hunt with the following command:
819 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
820 --show-reachable=yes gdcmTests PrintDocument
821 It looks like many (all?) leaks are due to the STL (or a bad usage
822 of the STL. The lines producing the leaks now have a comment with
823 a "MEMORY LEAK" tag: you can retrieve them with
824 grep "MEMORY LEAK" src/*
825 Here are two typical examples which I can't help fixing:
830 char * test = "babo";
831 name = test; //// <--- valgrind detects 960 bytes lost in
832 //// call to std::string::operator=(char const*)
833 name.clear(); //// Doesn't help !
841 std::cout << "Type a bunch of characters followed by RETURN: ";
842 getline(std::cin, line); //// <--- valgrind dectects a loss
843 //// of 1320 bytes in call to
844 /// std::basic_istream<>& std::getline<>
850 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
851 * src/gdcmHeader.[cxx|h]:
852 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
853 and related, moved away to gdcmDocument.
854 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
855 the corresponding protected accessors of inherited class
856 gdcmDocument, removed ! As a consequence gdcmFile had to be
857 declared friend of class gdcmDocument (see below).
858 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
859 - Clean up of undefined or unused methods.
860 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
861 account the changes to gdcmHeader.h).
862 * src/gdcmDocument.h:
863 - gdcmFile is now a friend class (in order to take into account the
864 changes to gdcmHeader.h).
865 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
866 (see changes to gdcmHeader.h).
867 - Accessors (reading on the form GetEntry*) are now public.
868 - Clean up of undefined or unused methods.
869 * src/gdcmDocument.cxx:
870 - adaptation to changes to gdcmDocument.h
871 - ::OpenFile now writes a verbose message when file cannot be opened.
872 - some std::string properly set to VRKey
873 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
874 references to gdcmDocument.
875 * Test/TestFindTags.cxx: changed accordingly to above changes.
876 * gdcmPython/testSuite.py: adapted to renaming of acr files in
877 cvs repository gdcmData.
879 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
880 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
881 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
882 conflicts with gdcmValEntry::voidArea.
883 * src/gdcmValEntry.cxx: unmatching comment wiped out.
884 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
885 Value representation between StringRepresentable and BinaryRepresentable.
886 * src/gdcmDocument.cxx:
887 - method ParseDES: proper indentation restored and usage of
888 gdcmVR::IsVROfGdcmStringRepresentable wired in.
889 - method LoadDocEntry: the fingerprint left in the SetValue() of
890 unloaded entries (length > MaxSizeLoadEntry) had curiously been
891 removed. Reverting to previous code segment with the proper
892 dynamic_cast< gdcmValEntry* >.
893 Note: this was (partially) breaking the python test suite
894 (gdcmPython/testSuite.py) that made usage of the above
895 fingerprint to check presence of "Pixel Data".
896 * src/gdcmDocEntry.h: coding style.
897 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
898 now taken into account.
899 * gdcmPython/gdcm.i: adaptation to the new internal representation
900 of gdcm (exit gdcmParser, hello gdcmDocument).
901 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
903 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
904 anymore, but instead prints the loaded Python dictionary.
905 * .... alas, the python testSuite is still broken.
907 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
908 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
910 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
911 * src/gdcmUtil.h : export methods
913 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
914 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
916 * Initial addition of automatic python testing
917 * Initial addition of automatic image comparison
919 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
920 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
921 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
923 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
924 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
925 * Test/ShowDicom.cxx : bug fix for msvc compilation
926 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
928 2004-05-04 Jean-Pierre Roux
929 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
930 new concepts (and new classes) :
931 a 'gdcmDocument' is composed of a set of Doc Entries, that are
932 - elementary gdcmDocEntries (former gdcmHeaderEntries)
933 - Sequence Doc Entries (gdcmSeqEntries)
934 a Sequence is composed of Items.
935 Each item is a set of Doc Entries (this is recursive)
936 The non uniqueness of the 'Dicom tag' is due to this recursivity
937 (never taken into account)
938 Our unability to add a new 'entry' in the header
939 at the proper location (neither in the H-Table (map or multimap),
940 nor in the Chained List is also due to this recursivity.
941 Don't try, right now, to use/modify/compile these new sources :
943 We just commit all the stuff, 'as is', in order not to loose it.
945 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
946 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
948 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
949 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
950 file prefix (SetFilePrefix)
952 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
953 * Add a new test: ShowDicom, for now this is just the c++ version of
954 checkRead.sh, later it will be able to compare the image read against a
956 * Replace the DEBUG on the stack with a global entry in cmake interface:
957 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
959 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
960 * Add an example subdir, with a real example on how to read + write a
963 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
964 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
965 * Doc/CMakeLists.txt: the main page is now properly differentiated
966 between the developper and user version.
967 * Doc/doxygen.config.in: dropped search related obsolete flags
968 * src/gdcmParser.h, gdcmHeader.h: doxygenation
970 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
971 * DEVELOPPER: added some helpfull comments for compile/test/install
974 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
975 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
976 src directory, now generated in the build dir.
977 2. Tests as mentionned smarter
979 4. Add a new method in gdcmDict that return the PubDict by name
980 this is interesting for 3rd party lib like ITK,
981 where we could set the institution name / patient name...
983 * ENH: 1. Now the test suite is working for real
984 2. All binaries are now output in the gdcm-bin directory
985 (this was not true before)
987 2004-04-28 Jean-Pierre Roux
988 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
989 SeQuence indented printing of Dicom Header.
990 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
991 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
992 Computation of SQDepthLevel is now part of gdcmHeader constructor
993 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
994 tree-like structure of a Dicom Header.
995 * FIX Test code cleaning
997 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
998 * ENH: Adding automatic testing
999 1. Need a DartConfig.cmake to submit to public
1000 2. Add a test driver gdcmTest.cxx
1001 3. gdcmTestMain, an helper for the main test driver gdcmTest
1002 4. Files in Test don't have a main anymore, this becomes interesting
1003 when we add more and more tests, thus dsw don't have to load
1005 * ENH: Adding a GDCM_DATA_ROOT for testing
1006 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1007 one file instead of seven + some small cleanup
1009 2004-04-22 Jean-Pierre Roux
1010 * ENH Minor changes to the Print() methods.
1011 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1012 Header printing. Example given with :
1013 > PrintHeader fileName 2 new
1014 (SQ based tree-like structure still to be done for the Header ...)
1016 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1017 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1018 1. I have added some unsigned where needed
1019 2. Some function parameter not used -> (void)
1020 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1021 4. g++ don't like character '\' in comment
1022 5. #define jpeg_create_decompress jCreaDecompress
1023 this really need to be fixed
1024 6. virtualize destructor of gdcmObject ... leakage
1025 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1026 this also really need to be fixed
1027 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1028 remove compression file
1029 (as we only do decompression, right ?)
1030 * ENH: Change malloc/calloc/free with c++ equivalent
1032 2004-04-21 Jean-Pierre Roux
1033 * FIX gdcmHeaderHelper::GetXSpacing
1034 when a single value is found (bug ?), xpacing is now
1035 defaulted to yspacing
1037 2004-04-19 Jean-Pierre Roux
1038 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1039 * ENH add parameters :
1040 bool exception_on_error = false,
1041 bool enable_sequences = false,
1042 bool ignore_shadow = false
1043 to the gdcmFile constructors to be full gdcmParser compliant
1044 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1045 to allow reading of PAPYRUS 3.0 files
1047 2004-04-06 Jean-Pierre Roux
1048 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1050 2004-04-02 Jean-Pierre Roux
1051 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1052 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1053 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1055 2004-03-30 Jean-Pierre Roux
1056 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1057 for ACR file, written out as DICOM files (hope so...)
1059 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1060 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1061 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1062 moved to base class gdcmParser and only the specialisation is kept
1064 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1065 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1066 already does the job.
1067 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1068 (to be consistent with gdcmParser::WriteEntries).
1070 2004-03-30 Benoit Regrain
1071 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1072 upate of the object's instance. It's passed to 2 in the unfavorable
1073 case : one in the ExecuteInformation, one in the ExecuteData
1075 2004-03-29 Jean-Pierre Roux
1076 * ENH : Check on file type to be written moved
1077 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1078 * FIX : gdcmObject::ResetBoundaries now stops properly
1079 when end-of-list is reached
1080 : gdcmVersion modified (as Benoit Regrain asked)
1082 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1083 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1084 * src/gdcmUtil.cxx: added forgotten iostream include.
1085 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1086 equivalent to ExplicitVR in existing code).
1088 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1089 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1090 now contains all the gdcmGlobal related code.
1091 * minor coding style and doxygenation changes.
1093 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1094 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1095 now contains all the Debug related code.
1096 * minor clean-up of includes in src/*.cxx
1097 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1098 CreateCleanString) removed.
1099 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1100 * Doc/DoxyMainPageUser.txt added.
1101 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1102 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1103 src/gdcmDirList.cxx)
1105 2004-03-24 Jean-Pierre Roux
1106 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1108 2004-03-23 Jean-Pierre Roux
1109 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1110 big endian made volumes
1111 * ENH Now gdcmParser constructor and destructor are protected to forbid
1112 end user to instanciate class gdcmParser
1113 (only gdcmHeader and gdcmDicomDir are meaningfull)
1115 2004-03-22 Benoit Regrain
1116 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1117 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1118 gdcmSerie to gdcmDicomDirSerie
1120 2004-03-19 Jean-Pierre Roux
1121 * ENH Now the tree-like structure describing a DICOMDIR comming from
1122 an already existing DICOMDIR file is consistent with
1123 the home-made tree-like structure build ex-nihilo
1124 or build from the files held (recursively) in a Directory
1125 functions gdcmDicomDir::CheckBoundaries()
1126 gdcmObject::SetBoundaries() added
1128 2004-03-17 Jean-Pierre Roux
1129 * REM (Eric Boix bug) : removal of meaningless
1130 gdcmDicomDirImage::NewImage function.
1131 * FIX now file names and directory name are written properly in the
1133 * FIX now gdcmDicomDir constructor may be call without any trick
1136 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1137 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1138 of gdcmDicomDirImage::NewImage as empty function.
1140 2004-02-28 Jean-Pierre Roux
1141 * ENH add gdcmDicomDir:NewPatient
1142 add gdcmDicomDirPatient:NewStudy
1143 add gdcmDicomDirStudy:NewSerie
1144 add gdcmDicomDirSerie:NewImage
1145 to allow making gdcDicomDir object.
1146 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1147 (as opposite to the gdcmHeader chained list)
1149 2004-02-11 Benoit Regrain
1150 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1151 when using from python
1153 2004-02-10 Benoit Regrain
1154 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1155 * FIX : in gdcmDicomDir when the directory is empty
1156 * ENH : add callback and methods to get the progression of dicomDir
1159 2004-02-06 Jean-Pierre Roux
1160 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1161 - GDCM_META added to gdcmDicomDirType
1162 - class gdcmMeta created
1163 * ENH : - A brief summary is now displayed at the beginning of
1164 'testDicomDir' to help disaster magnitude estimation
1165 * REM : Now useless Test/explDICOMDIR.cxx
1167 2004-02-05 Benoit Regrain
1168 * ENH : add methods in gdcmObject to get the hash table or the list of
1170 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1171 * FIX : wrapping python for TagHeaderEntryHT
1173 2004-02-04 Benoit Regrain
1174 * FIX : even length for some strings when writting the dicom dir
1175 * FIX : sort the images in the dicom dir
1176 * FIX : Bug fix for python use of dicom dir
1177 * ADD : a python demo
1179 2004-02-04 Jean-Pierre Roux
1180 * FIX : Final solution (?) for icone embedded images
1181 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1182 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1183 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1184 gdcmData/gdcm-MR-SIEMENS-16.acr1
1185 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1186 to make full checking easier
1188 2004-02-04 Benoit Regrain
1189 * FIX : WriteEntries : coding style & logic in parameters
1190 * FIX : Set the elements to create the DicomDir in a dictionary file
1192 2004-02-03 Benoit Regrain
1193 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1194 * gdcmDicomDir : add the load of directory
1195 * Bug fix and print add-on
1197 2004-02-03 Jean-Pierre Roux
1198 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1199 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1200 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1201 * FIX gdcmParser.cxx : 'group length' elements are now considered
1202 as integers, even for shadow groups, when file is Implicit VR
1204 2004-02-02 Jean-Pierre Roux
1205 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1207 of the last synonym :-(
1208 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1210 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1211 * FIX taking into account the possible 7fe0,0010 multiplicity
1212 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1213 to allow removal of references to 7fe0,0010, to deal with
1214 ACR-NEMA images, when 0028,0200 is meaningfull
1216 2004-01-31 Jean-Pierre Roux
1217 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1218 no longer writes 'Un' on disk
1219 * FIX SQ elements with actual length are now dealt with corectly
1220 * FIX gdcmFile::WriteBase make the difference, for color images, between
1221 the length (for Palette expanded images)
1222 and Raw Length (non expanded image + Palette)
1223 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1224 (that broke Write). Replaced by UL.
1225 Aware user will reload the field if he
1226 thinks it's necesssary
1228 2004-01-30 Jean-Pierre Roux
1229 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1230 when 'dirty Acr' is found, to be compliant with the new
1231 IsReadable() methods.
1233 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1234 (no DOUBLE images in kosher DICOM,
1235 but so usefull for people that miss them ;-)
1237 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1238 DICOMDIR related utilities (not checked as Windoze compliant)
1240 2004-01-28 Jean-Pierre Roux
1241 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1243 2004-01-27 Jean-Pierre Roux
1244 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1245 to allow skipping the shadow elements, to save memory space.
1246 The TRUE value for this param has to be used
1247 with a FALSE value for the 'enable_sequence' param.
1248 ('public elements' may be embedded in 'shadow Sequences')
1249 * gdcmHeader methods now deal with 'embedded icones images' in the header
1250 (even when an 'icone image sequence' is announced by the
1251 element (0x0088,0x0200), but there is NO icone at all ...
1253 * gdcmHeader sometimes Image Location value doesn't follow
1254 the supposed processor endianity (see gdcmData/cr172241.dcm).
1257 * gdcmHeader add the method
1258 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1259 to get *all* the Header Entries with the same tag.
1260 GetHeaderEntrySameName is probabely *useless*
1261 (no meaning : Name is *not* an identifier within the Dictionnary)
1263 2004-01-26 Benoit Regrain
1264 * Bug fix in the print of hexadecimal representations. Remove long fields
1265 in the print and add a third level of print to print them
1267 2004-01-23 Benoit Regrain
1268 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1269 * Bug fix on test suite after remove the strip made on not string fields
1270 * Split the IsReadable method between gdcmParser which test that the file
1271 is dicom and gdcmHeader which test that it's an image file
1273 2004-01-22 Benoit Regrain
1274 * DicomDir : clean code, add methods, set variables in protected or private
1275 * gdcmUtil : bug fix for the clean string method
1277 2004-01-19 Benoit Regrain
1278 * Add the use of shadow dictionaries
1279 * bug fix and coding style
1281 2004-01-19 Benoit Regrain
1282 * src/gdcmFile.cxx : bug fix concerning the close of file
1283 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1284 * Add the update of header entries using the shadow library
1286 2004-01-19 Benoit Regrain
1287 * removal of file gdcmHeader2.cxx
1288 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1289 inheriting from gdcmParser. This split is to prepare the integration
1290 of dicom dir parsing
1291 * bug fix under python
1293 2004-01-16 Jean-Pierre Roux
1294 * REM removal of class gdcmHeaderEntrySet
1295 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1296 * ADD add file gdcmHeader2.cxx
1297 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1299 2004-01-15 Benoit Regrain
1300 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1301 entries created while parsing the header. Thus, they will be destroyed
1302 when the gdcmDictSet will be destroyed
1303 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1306 2004-01-15 Benoit Regrain
1307 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1308 made a fatal error because of the memory release at the end of program.
1309 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1310 some memory and vtk seems to have some problems with that.
1311 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1313 2004-01-14 Benoit Regrain
1314 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1315 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1316 * src/*.[h|cxx] : make changes due to class name changes
1317 * gdcmPython/demo/*.py : bug fix due to method names
1319 2004-01-13 Benoit Regrain
1320 * src/*.[h|cxx] : coding style
1321 * vtk/*.[h|cxx] : coding style
1323 2004-01-13 Benoit Regrain
1324 * gdcmPython/testSuite.py : test the readable flag of file for tests
1325 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1326 It's lied to the stl compilation by MSVC (windows, always windows...)
1327 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1329 2004-01-12 Benoit Regrain
1330 * src/*.h : add comments
1331 * src/gdcmDictSet.h : set the method BuildDictPath in public
1332 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1333 directly setted in the source code
1334 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1337 2004-01-09 Benoit Regrain
1338 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1339 * setup.py : use a reference to gdcmVERSION
1341 2004-01-07 Benoit Regrain
1342 * Modification to compile with the distutils.
1345 2003-12-10 Benoit Regrain
1346 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1347 can use a gdcmHeaderHelper to load datas
1348 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1349 made in the source code
1351 2003-12-10 Benoit Regrain
1352 * Update Windows projects and .cvsignore files
1354 2003-11-12 Jean-Pierre Roux
1355 * ENH gdcmHeader constructor has one more parameter (default value : false)
1356 that allows the user to 'go inside' the SeQuences only
1358 gdcmElValSet:Print takes it into account
1360 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1361 * ENH: Update gdcmPython/CMakeLists
1362 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1363 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1365 2003-11-10 Jean-Pierre Roux
1366 * FIX : gdcmHeader::LoadElements is now based
1367 on the ListTag listElem member,
1368 not longer on the TagElValueHT tagHt member
1369 * ENH : PrintPubElVal shows (temporarily) both results,
1370 with the tagHt member and the listElem member.
1371 (it's easier to 'see' the problems when using Printheader)
1373 * FIX : old private member LgrElem is now splitted into
1374 ReadLength : Length actually found on disk (updated only
1375 if bug fixing is necessary), for internal
1377 UsableLength : Updated by FixFoundLength, to fix a bug
1378 or to allow Parser going on.
1379 Will allow to re-write a kosher header when a SeQuence
1380 with a length (not 0000) is found
1381 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1382 because gdcmElValSet::Add does not update ListElem
1385 2003-11-07 Jean-Pierre Roux
1386 * FIX misstyping in Transfert Syntax name table
1387 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1388 when they have an actual length (not 0000 nor FFFFF)
1389 (Nobody should care of it, but DICOMDIR explorers)
1391 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1392 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1394 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1395 * ENH: vtkGdcmReader now supports LUT !
1396 (vtkgdcmViewer for now is not able to use them though)
1398 2003-11-05 Jean-Pierre Roux
1399 * in testSuite.py : new files names for checking the package
1400 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1401 that returns the pixel area size to the *aware* (vtk) user
1402 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1404 2003-11-05 Benoit Regrain
1405 * in testSuite.py : Modify the rules for checking the paths
1406 : Explicit error messages
1407 * in __init__.py : Related modif
1409 2003-11-03 Jean-Pierre Roux
1410 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1411 to be used by aware (vtk) users that want to manage
1412 LUT (and no to turn the PALETTE image into an RGB pixels one)
1413 * GetPixelType now returns 8U for 24 Bits images
1414 (vtkGdcmReader compliant)
1416 2003-10-31 Jean-Pierre Roux
1417 * Removal of *all* gdcmData images and add them again
1418 in order to loose the 'history' of un-anonymised images
1420 2003-10-31 Jean-Pierre Roux
1421 * RMV : removal of useless jBitsInJsample.h
1422 for both 8 and 12 Bits JPEG Lossy Libraries
1424 2003-10-31 Jean-Pierre Roux
1425 * ENH : Add the functions gdcmFile::GetImageDataRaw
1426 gdcmFile::GetImageDataIntoVectorRaw
1427 that act as GetImageData and GetImageDataIntoVector
1428 except the making of an RGB Plane from Gray Plane + LUT
1429 Intended to aware (vtk) users who know how to manage
1432 GetLUTRGBA return a R,G,B,A LUT if any
1433 lgrTotaleRaw gives the 'Raw' length
1434 GetImageDataRaw returns the gray Plane
1435 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1436 (They stay Grey, just like with other Dicom viewers :-(
1438 2003-10-30 Jean-Pierre Roux
1439 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1441 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1442 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1443 being coherents dicom files.
1445 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1446 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1448 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1449 * ENH: Two steps is necessary to please VC++ compiler...
1450 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1451 * ENH: Add include dir to medcon lib
1452 * FIX: only one function is being exported for now !
1453 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1455 2003-10-29 Jean-Pierre Roux
1456 * adding gdcmHeader::GetLUTRGBA
1457 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1458 --> Mathieu, the modif u're waiting for is not yet committed
1459 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1461 2003-10-27 Jean-Pierre Roux
1462 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1463 00191113.dcm DermaColorLossLess.dcm
1464 MxTwinLossLess.dcm RadBWLossLess.dcm
1465 * ENH: For version prior to vtkImageViewer2 -r 1.19
1466 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1468 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1469 * Removal of ido stuff in CMakeLists.txt
1471 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1472 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1473 * FIX: remove a call to ->Modified ... see comments
1474 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1476 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1477 * FIX: Problem with path for libvtkgdcmPython
1478 * ENH: Try adding a search script for python site-package
1479 * RMV: Remove some file from medcon lib that are not necessary
1480 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1481 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1482 * FIX: More pragma disable fro VC++,
1483 I don't think I break something as it is also disable in VTK/ITK.
1484 But it fasten debug compilation time.
1486 2003-10-23 Jean-Pierre Roux
1487 * gdcm now deals with 16 Bits Run Length Encoded images
1488 (they are compressed as 2 planes images,
1489 one for the high Bytes, the other for low Bytes)
1491 2003-10-22 Jean-Pierre Roux
1492 * Now CheckRead takes into account :
1493 - the bugged 'Leonardo' Siemens images
1494 - the XA images, sent thru the burning VPRO station
1495 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1498 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1499 * FIX: When copying a Makefile.am to CMakeLists.txt
1500 one should remove the '\'
1502 2003-10-22 Jean-Pierre Roux
1503 * in gdcmData adding a bugged 'Leonardo' Siemens image
1504 (wrong lengths in header)
1505 OK with gdcm, KO with the other viewers :-)
1506 * add a GE dlx XA image, thru the VEPRO burning station
1509 2003-10-21 Jean-Pierre Roux
1510 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1511 for a brutal checking of vtkgdcmViewer compliance
1513 2003-10-21 Jean-Pierre Roux
1514 * add the files for 'xmedcon' Jpeg Lossless library
1515 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1517 2003-10-21 Jean-Pierre Roux
1518 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1520 2003-10-21 Jean-Pierre Roux
1521 * garbage Siemens 'Leonardo' images dealt with
1522 (the patch is easy to remove)
1523 * cosmetic changes to avoid warnings
1525 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1526 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1527 no need to press 'r' now.
1529 2003-10-20 Jean-Pierre Roux
1530 * upgrade of checkRead.sh checkWrite.sh according
1531 to new Jpeg Lossless decompressor
1532 * add US.3405.1.dcm, a genuine RGB medical file ...
1533 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1534 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1536 2003-10-15 Jean-Pierre Roux
1537 * general anonymisation in gdcmData
1538 * adding the 'color files' from
1539 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1540 * adding some well knowed bugged-header images
1541 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1542 waiting for their inclusion in Python testsuite
1544 2003-10-15 Jean-Pierre Roux
1545 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1546 no longer seg faults when file is not found
1548 2003-10-14 Jean-Pierre Roux
1549 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1552 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1553 * TODO: *.in file to genereate a UseGDCM later
1555 2003-10-14 Jean-Pierre Roux
1556 * Some supposed-to-be Dicom Images have no preamble.
1557 OpenFile takes it into account
1558 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1559 * Missing elements added in dicomV3.dic
1560 (just to be affraid : have a look at
1561 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1562 and do it again next year ;->
1564 2003-10-13 Jean-Pierre Roux
1565 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1566 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1567 But there are NOT. It's fixed !
1569 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1570 * FIX: "jpeglib.h" was not found on VC++
1571 * FIX: vtkgdcm was not being installed
1573 2003-10-10 Jean-Pierre Roux
1574 * ENH : OpenFile closes the file if it *really* doesn't look like
1575 an ACR-NEMA / DICOM one.
1576 * FIX : testWrite no longer writes an empty file if the source file
1577 is not gdcm Readable
1578 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1581 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1582 * FIX: CMake generate now documentation
1583 * ENH: out of source doc build !
1584 * ENH: Generate both user and dev documentation
1585 * ENH: Should work on windows too
1586 * ENH: Only one doxygen config.in file is needed
1587 * FIX: make install should be ok now on ùnix plateform
1588 * FIX: PATH to dictionary was wrong (missing /)
1589 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1591 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1592 * vtkGdcmReader is now able to read rgb dicom file.
1593 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1594 * added a gdcmViewer to vtk test, use mouse to control
1595 window level & window width
1597 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1598 * CMake-ification of gdcm, we have now two build system
1599 * FIX: on cygwin Wsock32 doesn't exist
1600 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1602 2003-10-06 Emanuel Ollart
1603 * FIX : compilation process wad broken.
1604 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1606 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1607 * change gdcmViewer -> vtkgdcmViewer
1608 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1610 2003-10-06 Jean-Pierre Roux
1611 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1612 ( e.g : well known GE images with a wrong elem length,
1613 : Philips MRI Images with a wrong Huffman table)
1614 * still to be done : allow the reading of bugged LEONARDO Siemens images
1616 2003-10-03 Jean-Pierre Roux
1617 * Odd length strings are padded with '\0' (not with spaces,
1618 to remain compliant with already defined strings,
1619 like Transfert Syntax UID and others)
1621 2003-10-03 Jean-Pierre Roux
1622 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1623 to allow displaying RGB images (not only by affim ;-)
1625 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1626 * vtkGdcmReader is now able to read rgb dicom file.
1627 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1629 2003-10-03 Jean-Pierre Roux
1630 * A few nasty patches to allow the reading of a lot of nasty images
1631 ( e.g : well known GE images with a wrong elem length,
1632 : Philips MRI Images with a wrong Huffman table)
1633 * still to be done : allow the reading of bugged LEONARDO Siemens images
1635 2003-10-03 Jean-Pierre Roux
1636 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1638 2003-10-03 Jean-Pierre Roux
1639 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1640 to allow displaying RGB images (not only by affim ;-)
1642 2003-10-03 Jean-Pierre Roux
1643 * gdcmFile::GetImageDataIntoVector now
1644 - deals with MultiFrames MultiFragments Run Length Encoded files
1645 - deals with YcBcR (YBR_FULL) files
1646 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1647 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1649 (no sample found :-(
1651 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1652 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1653 Two reasons: - clear things
1654 - third parties acces gdcm through header files, so won't
1655 suffer anymore VC++ complains
1657 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1658 * add argv[1] in testvtkGdcmReader.cxx
1661 2003-09-24 Jean-Pierre Roux
1662 * The lines are now eigthy characters long.for
1663 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1665 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1666 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1667 char* to std::string. Thus, the use of strdup becomes useless. (see
1668 previous commis of Malaterre)
1669 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1670 before the last Malaterre's commit.
1672 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1673 * This commit should fix the Debug building under VC++, the problem
1674 was mainly a mixture of debug and release lib being loaded at startup.
1675 * I also remove a depency to a specific C function: strdup. Because I had
1676 to force the link to msvcrtd (whereas strdup is in libc).
1678 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1679 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1680 located in the gdcmCommon.h file. All use of reference of tha has been
1681 changed to now use the variable GDCM_UNFOUND.
1683 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1685 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1686 Dicom dictionary. The test suite can now be run again. Note:
1687 I'm note very happy with the " (RET)" changes. I believe this
1688 RETAINED comment should be dropped when parsing the dictionary.
1689 - PACKAGER corrected
1691 - AUTHORS updated and now in alphabetical order
1692 * Makefile.am now exports gdcm.dsw for Windoze users.
1694 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1695 * cygwin complains about missing std:: in subdir Test/
1697 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1698 * remove some methods that are now in gdcmHeaderHelper
1700 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1701 * vtkGdcmReader set spacing and origin correctly
1703 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1704 * Fix a few delete/delete[] mismatch
1706 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1707 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1708 interpretation to data given by gdcmHeader. For instance there are
1709 heuristics to get informations (look at different places).
1710 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1711 sorting DICOM images based on different strategies.
1712 * modified Makefiles accordingly.
1714 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1715 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1716 when building in debug mode
1717 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1718 src/win32/gdcmdll.dsp
1719 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1721 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1722 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1725 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1726 * src/win32/libgdcmjpeg12.dsp was not dos format
1727 * src/win32/libgdcmjpeg12.dsp :
1728 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1729 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1731 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1732 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1734 * src/gdcmFile.cxx : bug fix in affectation type
1735 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1736 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1737 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1738 symbols... future problem ?
1740 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1741 * src/win32/libgdcmijpeg12.dsp was missing
1742 * modified gdcm.dsw accordingly
1744 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1745 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1747 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1748 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1749 commit of JPR (before his hollidays to facilitate our work).
1750 * setup.py : bug fix in code. Modifications made while the last commit
1751 of JPR. The code hasn't been tested before the commit... it's so
1752 useless to make that (for best programmer that is JPR) !!!
1754 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1755 * tagged the current version as Version0_3 (i.e. version 0.3)
1757 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1758 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1759 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1760 * *.dsp : modifications to use new libgdcmijpeg8 library
1761 * setup.py : bug fix on VTKPATH variable
1762 * PACKAGER : adding all concerning windows
1764 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1765 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1767 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1768 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1769 test suite reported error.
1770 * PACKAGER file added (describes what a packager must do when
1771 packaging a new release).
1772 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1773 * configure.in: upgraded version number to 0.3.0
1774 * fixing build of rpm (through rpm -ta):
1775 - Doc/Makefile.am exports proper doxygen files
1776 - src/jpeg/libijg8/Makefile.am exports the include files.
1778 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1779 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1780 * src/gdcmHeader.h : formatting code
1782 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1783 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1784 We were obtaining error message from vtk. Now, creation of file list
1785 is made in an internal list to prevent this problem.
1786 Bug fix when output is empty.
1787 Bug fix in update of progress value. Previous commit for this was a bad
1789 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1791 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1792 * src/gdcmHeader.h : added method to get the file name
1793 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1794 files. Added method to remove all files on the input
1795 Added FIXME comment concerning the bad parsing of header made by
1796 ExecuteInformation method (in ExecuteData method)
1798 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1799 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1800 when using make instal.
1801 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1802 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1804 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1805 * setup.py : adding include dir of jpeg lib to compile all sources
1806 * */Win32/*.dsp : JPR fix for windows compilation
1808 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1809 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1811 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1812 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1814 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1815 * setup.py is again effective on un*x (takes into account the
1816 addon of the jpeg library)
1817 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1818 * Doc/Doxy* updated (includes above enhancements)
1819 * INSTALL now points to web documentation
1821 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1822 * src/gdcmHeader.h doesn't make unnecessary reference to
1824 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1826 * src/gdcm*.[cxx|h] :
1827 - to allow compilation with gcc 3.x
1828 -- clean up of STL usage (added explicit usage of std::)
1829 -- small fixes on exceptions.
1830 Note: linking not tested !
1831 - clean of doxygen comments to avoid warnings at documentation
1833 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1834 dependent convertion).
1836 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1837 * Clean up of previous JPR garbage commit (not even commented in the
1839 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1840 - moved all jpeg related files from src to src/jpeg/libijg8, with
1841 addition/modification of Makefile.am and configure.in.
1842 - the testSuite is still brain damage (not guilty).
1844 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1845 * WrapVTK.py : modifications to get correctly vtk source files to
1847 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1848 (FileName -> Filename)
1850 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1851 * vtk/vtkGdcmReader.[cxx/h]:
1852 - UpdateProgress method should now be effective
1853 - removed the limitation on having only images loaded (as opposed
1855 - when building a stack of images/volume, a lesser number of
1856 gdcmHeader and gdcmFile instances should be used (hopefully
1857 accelerating things).
1858 - when building a stack of images/volumes, files which are not
1859 loadable (wrong path-filename, wrong permissions on existing file,
1860 or file not parsable by gdcm) are replaced with a black image
1861 in the stack (for the caller to notice the problem).
1863 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1864 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1866 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1867 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1868 between standard library (std) and vtk library (problems are found
1869 under Windows... thanks Windows !)
1871 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1872 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1874 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1876 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1877 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1879 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1880 * When compiling with distutils (see setup.py) the C++ compiler is
1881 called with different flags than the default ones (with automake).
1882 In order to fix all those warning, I compiled gdcm with the command
1883 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1884 and went for warning fixes:
1885 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1886 up from unused variables.
1887 - vtk/vtkGdcmReader.cxx: potential bug fix.
1888 * src/gdcmHeader.h: Doxygen warning cleanup
1890 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1891 * gdcmPython/gdcm.i:
1892 - typemaps correction to take into account the systematic replacement
1893 of "using namespace std" with std:: prefix e.g. std::list,
1894 std::string... (cf changes of 2003-05-21).
1895 - gdcmGlob global variable of type gdcmGlobal (defined in
1896 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1897 exported to Python a as cvar.
1898 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1899 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1900 gdcmDictSet.GetPubDictTagNames() and
1901 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1902 C++ static methods).
1903 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1904 with the above changes.
1906 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1907 * setup.py, manifest.in : bug fix under linux
1909 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1910 * Modification of setup.py to compile vtk part too. Then, we have 2
1911 wrappers which must work with same distutils. For that, we have a
1912 generic distutils in distusiltsWrapping.py ; with :
1913 - build_extWrap class to wrap generically all extensions,
1914 - ExtensionWrap base class for all wrapping extension that contains
1916 - Wrapper interface which wrap sources
1917 + In WrapSwig.py we have extension and wrapper for Swig
1918 + In WrapVTK.py we have extension and wrapper for VTK
1919 * MANIFEST.in : modifications to consider vtk directory and new python
1920 files for compilation
1922 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1923 * Added python wrappers of vtkGdcmReader vtk class (see the
1924 source in vtk/vtkGdcmReader.cxx) :
1925 - vtk/Makefile.am now builds a library
1926 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1927 python library (as opposed to _gdcm.so wich are the python
1928 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1929 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1931 - configure.in has an additional flag --enable-vtk that needs
1932 to be set to enable compilation of vtk related code, that is:
1933 + vtk/vtkGdcmReader.so and
1934 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1935 + gdcmPython/vtkgdcmPython.so (see above)
1936 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1937 be read when compressed or when HighBit + 1 != BitsStored),
1938 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1939 the usage of the python wrapper of vtkGdcmReader vtk class.
1940 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1941 * src/*.[h] all occurences of stl classes are now prefixed with
1942 std::, and all occurences of "using namespace std;" where removed.
1943 This is to avoid pollution of global namespace in included files.
1944 Apparently vtk does not avoid this pitfall: when using both
1945 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1946 collision of various stl members (principally cout...).
1947 * gdcmPython/testSuite.py now cleanly removes temprory generated
1949 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1950 comply with above changes)
1952 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1953 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1954 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1955 vtk data structure (an image Flip was required).
1956 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1957 * cosmetic changes in documentation.
1959 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1960 * src/gdcmHeader.cxx: the constructor no longer exits when an
1961 unexisting file is given as argument.
1962 * The subdirectory Data (containing all the images used for the
1963 test suite) is not part of this repository anymore. A new module
1964 containing those images is now available at
1965 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1966 with the name gdcmData.
1967 All the python scripts (including the package initialisation file
1968 gdcmPython/__init__.py) were adapated to take this change into
1969 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1971 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1972 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1973 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1974 demo of the usage of this class.
1975 Compilation of this vtk part is only done when using the --enable-vtk
1976 at configure (or autogen.sh) stage.
1978 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1979 * More memory link related corrections and documentation fixes.
1981 - maximum info is obtained with a command of the form:
1982 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1983 --show-reachable=yes PrintHeader
1984 - the remaining reachable blocks seem to come from the STL
1985 allocation scheme through the usage of map and list. It looks
1986 like this memory cannot be freed but it is not a memory leak
1987 (in fact further invocation to the STL would recollect the
1988 unused memory allthough it cannot explicitely be freed).
1989 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1990 of displaying an image parsed with gdcm and displayed with VTK.
1991 Note: some images don't seem to work e.g.
1992 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1993 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1994 Allthough this weakens the semantics, it is a ditch attempt to
1995 make gdcm more thread friendly.
1997 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1998 * Memory link hunt (by using valgrind through the command
1999 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2000 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2001 gdcmHeader::_dicom_vr.
2002 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2003 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2005 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2007 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2008 * src/Makefile.am now exports all the necessary include files at
2012 * UpdateGroupLength replaced by new one
2015 * UpdateGroupLength re-written using H-Table
2016 (named UpdateGroupLengthNew untill checks are over)
2018 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2019 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2020 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2022 - gdcmHeader::GetPubElValSet removed.
2023 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2024 UpdateGroupLength, WriteElements, Write.
2025 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2026 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2027 carried the same semantics.
2028 - src/gdcmHeaderIdo.cxx changed accordingly.
2029 - gdcmFile::WriteBase now regroups all the codes from previous
2030 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2031 - enum FileType moved to gdcmCommon.h
2032 * src/gdcmHeader.cxx AddDefault trashed
2033 * gdcmGetXSize added
2034 * getimageDataSize now calls gdcmGetXSize
2035 * Test/*.cxx changed to agree with above changes
2037 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2038 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2039 (to avoid double call by end user).
2040 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2041 by end user, since gdcmHeader::gdcmHeader now handles it.
2043 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2044 * gdcm/Doc many doxygen changes:
2045 - Doxyfile now has two different versions, DoxyfileUsers that generates
2046 the html.users end users oriented documentation and
2047 DoxyfileDeveloppers that generates the html.developper developper
2048 oriented documentation.
2049 - README changed accordingly
2050 - requirement.txt removed (old design info moved to TODO).
2051 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2052 DoxyMainPage.txt, DoxyPython.txt provide more information.
2053 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2054 be updated by simply regenerating the docs with doxygen and copying
2055 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2056 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2057 all the tests in the form "if (<map>.count() >1)" were removed.
2058 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2059 ill-formed documentation sections.
2060 * src/gdcmHeader.cxx: ditto
2062 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2063 * setup.py fixed for un*x (needed macro for stdint.h)
2064 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2065 un*ces with sh-utils test utility.
2066 * gdcmPython/demo/test.py renamed to PrintHeader.py
2067 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2068 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2069 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2070 * src/gdcm*.cxx JPR's bad inclusion fixed.
2072 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2073 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2074 * gdcmPython/demo/test.py changed accordingly.
2076 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2077 * gdcmPython/Makefile.am fixed linking against libstdc++
2078 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2079 * Swig subdir (historical tests of swig version 1.3.17++) removed
2080 * Test/testChangeEntete.cxx some lines commented out in order to make
2082 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2083 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2085 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2086 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2087 hence the user doesn't need this explicit call.
2088 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2089 i.e. LoadElements() call removed.
2090 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2091 - src/Makefile.am declares the proper flag for g++.
2092 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2093 for adding user defined new tags.
2094 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2095 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2096 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2098 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2099 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2100 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2101 src/Makefile.am : the project should properly compile and install
2102 with the autotools, included the python wrappers part.
2103 * gdcm.spec.in : added a spec file for RPM packaging.
2105 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2106 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2108 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2109 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2110 to exported to the environement (see gdcmPython/testSuite.py
2112 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2113 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2114 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2115 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2116 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2118 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2119 * gdcmPython/__init__.py doesn't crash anymore when running in
2120 in InstallMode or PreInstallMode but with an environement given
2121 value of GDCM_DICT_PATH.
2122 * src/gdcmDictSet.[cxx/h] coding style.
2124 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2125 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2126 * src/gdcm.h general comments moved to TODO, and README
2127 * src/gdcm.h should now be seen as a user commodity (including it
2128 should suffice to fully use gdcm). It is nowhere including within
2129 any of the kernel files src/*.cxx and src/*.h.
2131 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2132 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2133 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2135 * src/gdcm*.cxx only include their corresponding include file
2136 (as opposed to gdcm.h)
2137 * gdcmPython/gdcm.i changed accordingly
2138 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2139 the autogen.sh generated "make snapshot" command to work.
2140 * autogen.sh removed history related references to crea package.
2142 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2143 * distutilsSwigCPlusPlus.py work around some swig portability
2146 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2147 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2148 was done in a last ditch attempt to get setup.py _really_
2149 operationnal. The python/gdcmPython layaout add the advantage
2150 of hidding away the python related distutils specific files
2151 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2152 Alas, the src directory was out of scope (i.e. it's relative
2153 position to setup.py was ../src) which made things impossible to
2154 handle (see previous version of python/setup.py). Crossing fingers...
2156 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2157 * python/setup.py now works on Un*x. (harder than I thougth)
2158 * python/distutilsSwigCPlusPlus.py can now have include files
2159 among the list of sources.
2161 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2162 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2163 * modifications in MSVC projects
2165 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2166 * As stated by the first lines of Test/ExceptionAndPython/README, it
2167 looks like we can move back to original usage of exception within
2168 src/gdcm* and hence remove the errno stuff that was introduced
2169 as a quick and dirty fixture of this problem (added to the TODO).
2170 * Doc/Doxyfile configuration file for Doxygen and corresponding
2171 README file for usage added.
2172 * Test/testWrite.cxx added. This new test comes from a split of
2173 test.cxx that is now reverted to its original purpous i.e.
2174 testing the proper parsing of a Dicom related file.
2175 testWrite.cxx concentrates on testing the IO part of gdcm.
2176 * Test/bug1.cxx (containing a bug on WIn32) added.
2177 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2178 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2179 whose purpose is to publish the content of the TagNames of the
2180 Dicom public dictionnary were not accessible without an
2181 instance of class gdcmHeader.
2182 - those methods are now static methods of gdcmDictSet and hence
2183 require no instances at all to be invocated.
2184 - within gdcmDictSet this change required to change some method
2185 to class methods (i.e. are now static) among which SetDictPath
2186 (renamed to BuildDictPath) and LoadDefaultPubDict.
2187 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2188 the above changes by calling the new method classes of gdcmDictSet.
2189 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2190 the above to be effective.
2191 * python/gdcmPython: in order to wrap properly the above changes
2192 for Python, swig version now needs to be > 1.3.17.
2193 * python/gdcmPython/Makefile fixed to adapt itself to new
2194 configure/make shema introduced by Johan Montagnat (thanks for the
2195 contribution). Alas this Makefile cannot be turned into a proper
2196 Makefile.am without some heavy changes in the configure.in
2197 (for python dectection).
2198 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2199 now avoids publishing the empty entries.
2201 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2202 * python/setup.py : bug fix concerning install under windows
2203 ExtraPath reused :-P
2204 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2206 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2207 * Dicts/dicomV3.dic : remove double spaces !!!
2208 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2209 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2212 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2213 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2214 method. Doxygenation.
2215 * src/gdcm.h clean up of JPR spurious comments.
2217 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2218 * python/distutilsSwigCPlusPlus.py now properly collects the
2219 shadow classes generated by "swig -c++" (gdcm.py in our case)
2220 when using "python setup.py install".
2221 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2222 reexports the working classes.
2223 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2224 by the classical C errno scheme. This is to prevent an obscure
2225 behavior of the python wrappers when importing wxPython.wx prior
2226 to gdcmPython (which ended up in an abort call). An illustration
2227 of this oddity can be found in the Test/ExceptionAndPython
2228 subdir (see the README file). This problem probably due to
2229 an combination of g++ and dynamic loading.
2230 * added Test/ExceptionAndPython (see above)
2232 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2233 * Changed the layout of the python part to avoid bloating main
2234 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2235 i.e. the distutils arsenal. All the python related stuff is
2236 again in a python subdir, but the package itself is now in
2238 * setup.py was cleaned up:
2239 - pythonIncludePath removed
2240 - python setup.py bdist target is now functional.
2241 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2242 collision with other packages). gdcmPython/demo/*.py changed
2245 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2246 * python subdir moved to gdcmPython (preparation of distutils packaging).
2247 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2248 distutils installer is operational.
2249 * - gdcmPython/__init__.py now properly loads the swig generated
2250 shadow classes (from gdcm.py).
2251 - gdcmPython/demo/*.py changed to import the package gdcmPython
2252 instead of gdcmPython/demo/load.py.
2253 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2255 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2256 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2257 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2258 entries within the associated public Dicom dictionary resp. the same
2259 information but sorted by the fourth field (PAT, IMG, DIR) of the
2261 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2262 are now in the "???" group.
2263 - python/gdcm.i changed accordingly,
2264 - python/demo/printGroupedPublicDict.py added, that gives an example
2265 of the above new functionalities in Python.
2267 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2268 * src/gdcm.h, gdcmHeader.cxx:
2269 - historic references to glib's g_malloc and g_free (#defined)
2270 were definitively removed.
2271 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2272 * src/gdcmElValSet.cxx:
2273 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2274 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2275 - GetElValue(string) renamed to GetElValueByName.
2276 - Added GetElementByName(string).
2277 * src/gdcmHeader.cxx: added
2278 - GetPubElValRepByNumber(guint16, guint16)
2279 - GetPubElValRepByName(string)
2280 - GetShaElValRepByNumber(guint16, guint16)
2281 - GetShaElValRepByName(string)
2282 - GetShaElValByNumber(guint16, guint16)
2283 - GetShaElValRepByName(string)
2284 - GetElValRepByNumber(guint16, guint16)
2285 - GetElValRepByName(string)
2286 - GetElValByNumber(guint16, guint16)
2287 - GetElValRepByName(string)
2288 * Doc/requirements.txt added.
2290 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2291 * Test/Makefile building now depends on the one of libgdcm.so
2292 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2293 pixel data) aware which enables finding the address (offset) of
2294 the pixel data of JPEG encoded DICOM files. This leaves only a single
2295 file in the testSuite whose pixel data address (offset) is unknown.
2296 * python/testSuite.py changed accordingly.
2298 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2299 * VC++ has some strong limitations when working with the STL, as stated
2300 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2301 "Also note that some STL containers (map, set, queue, list, deque)
2302 cannot be exported. [...]
2303 Some STL classes contain nested classes. These classes can not
2305 This is caused by a designed limitation that once a template
2306 class is instantiated, it can not be re-instantiated and
2308 Since our usage of map<> is ubiquitous in gdcm, this "designed
2309 limitation" of VC++ is a pitfall.
2310 Hence the Python wrappers of gdcm cannot be incrementally linked
2311 against the c++ dynamic library. The dirty but only workaround is
2312 to forget about incremental link of dynamic libraries and to generate
2313 the Python wrappers library with the inclusions of the underlying C++
2315 The following modifications concern this matter on Win32/VC++:
2316 - wrapping python correct with standalone wrapped dll (don't use separate
2317 dll under windows !!!!)
2318 - python21_d debug mode enabled (ask Frog how to use it :-)
2319 - NO problem with having an STL member of class for example string in C++
2320 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2321 - Python test of dcmlib in Python is ok under windows on a large set
2323 * removed glib references
2324 * typedef's inserted in gdcm.i for correct swig type management
2326 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2327 * python/demo/*.py load.py extracted from test.py. Added explore.py
2328 that only displays required tags and testAll.py that parses all
2329 the files of the testsuite without using unittest.
2330 * python/testSuite.py other additional test on new files added.
2331 * Data/* new test files added accordingly to the testSuite.
2332 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2333 the vr in the file differs from the one of the dictionary.
2335 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2336 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2337 values, but limits itself to values which are below a user specified
2338 size (by default 1024 bytes).
2339 * python/gdcm.i : elements not loaded (because their size is above the
2340 user specified treshold) are exported with their TagKey as key of the
2341 python dictionary. This enables the testsuite to make some checks
2342 on the unloaded elements (since we have their offset and size).
2343 * python/testSuite.py
2344 - now tests for the existence and proper value of the pixel data
2345 - two new examples added.
2346 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2348 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2349 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2350 aware. See the strategy comments in gdcmHeader::FindeLength().
2351 * Test/test.cxx now accepts a filename as first argument.
2352 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2353 * python/testSuite.py changed to integrate test on above files.
2355 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2356 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2357 the vr was also RET.
2358 * python/testSuite.py more tests added.
2360 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2361 * python/testSuite.py unittest test suite added (uses Data)
2362 * Data/* dcm and acr files for the test suite.
2363 * glib dependance removed from un*x version. We now use ISO C99
2364 7.18 Integer types (see stdint.h)
2365 - python/Makefile, src/Makefile src/gdcm.h
2366 * src/ when an explicit vr (like dicom files) suddenly poped an
2367 implicit element we use to mark the underlying DictEntry of the
2368 concerned ElValue with "Implicit". This strategy was damageable
2369 too the public or provite dictionaries, since some of their vr
2370 would be changed. Since Header::FindLength heavily relies on the
2371 detection by Header::FindVR of falsely explicit elements, I
2372 added an extra ImplicitVr member to ElValue (boolean).
2373 The rest of the changes we the necessary adaptations.
2375 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2376 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2378 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2380 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2381 * Adaptation for porting to VC++:
2383 o forced to use std namespace (for string to be known)
2384 o all class use __declspec export style on WIN32
2385 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2386 (in stdlib.h on Win32 but in std:: for gcc)
2387 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2388 variable GDCM_DICT_PATH.
2389 * src/gdcmHeader.cxx verbose comments made discrete.
2391 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2392 * python/gdcm.i: added a typemap that converts a C++ hashing table
2393 to native Python dictionary.
2394 * python/demo/test.py:
2395 - now uses the native dictionary for exploration of gdcmHeader.
2396 - takes an optional filename argument (the file to parse).
2397 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2398 PubElVals hashing table.
2399 * Dicts/dicomV3.dic removed error prone trailing spaces.
2401 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2402 * Python wrapping process moved away from src/Makefile to
2403 newly created python/Makefile (as well as gdcm.i)
2404 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2405 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2406 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2407 from the environement variable GDCM_DICT_PATH (when existing).
2408 * src/gdcmDict::GetTag bug fix.
2410 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2411 * Straightforward temporary fixes for swig to build the python wrappers.
2412 src/Makefile now has a python working entry [by working we mean
2413 that we can import de shadow classes without errors].
2415 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2416 * hashtest.cxx removed (since allready in Test)
2417 * src/gdcmlib.h renamed to src/gdcm.h
2418 * src/dcm.i renamed to src/gdcm.i
2419 * src/Makefile prepared for python wrapping
2421 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2422 * src/gdcmHeader.cxx :
2423 - Parsing of header is now separated from loading of element values
2424 (see gdcmHeader::LoadElements).
2425 - general clean up of hopefully all file access (creation of
2426 ReadInt16 and ReadInt32)
2428 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2429 * src/gdcmHeader.cxx :
2430 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2432 - SetLgrElem renamed to SetLength
2433 - GetLgrElem renamed to GetLength
2434 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2435 * src/gdcmElValSet.cxx fixed both GetElValue methods
2436 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2437 due to IdoDude was cleaned out.
2439 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2440 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2441 concentrates on finding the value representation (when it exists).
2442 RecupLgr now only finds the element value length, and it avoids
2443 returning the unecessary skL (skipped length).
2444 Also, offsetCourant was simply removed (with taille_fich) since
2445 it was redundant with the File position internals (by using
2446 ftell and fseek). This also made skL (see above in RecupLgr) usage
2448 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2449 on the libido specificities which are handled through class
2451 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2454 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2455 * Truckload of changes. Parsing of header is barely functional
2456 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2458 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2459 * src/gdcmHeader.cxx many addons of low level methods
2461 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2462 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2463 and _IdDcmSWAP_LONG.
2465 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2466 * This corresponds to all the changes decided at the meeting of
2467 May 23 2002. Needless to say we are running late...