1 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Finished lossless transition, not only do we now read all lossless jpeg
3 images, without the need of the Cornwell lib, but we do read them properly now
4 * To reduce code (well to avoid code duplication), I defined a common place
5 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
6 redefine symbols. This is not prefect but this the best solution I found for a
7 compilation time jpeg option.
9 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
10 * Update jpeg ijg lib to support lossless jpeg implementation
11 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
13 * Also added a special copyright for dcmtk since we use their bugfixes.
16 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
17 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
18 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
19 matters, as stated in warning note at begining of %include section).
20 * src/gdcmDicomDir*.[cxx|h]: coding style
21 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
22 * src/gdcmJpeg8.cxx: doxygen fix.
23 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
24 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
25 from File:: to PixelConvert::.
27 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
28 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
29 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
30 - more code moved away from File:: to PixelConvert::
31 - fat setup of PixelConverter set in place in File::Initialise.
33 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
34 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
35 namespace at the file system level. So now you should convert your examples
37 gdcmHeader -> gdcm::Header
38 It would be nice if people keep in mind to no open the namespace, since it
39 allows compilation on broken plateform which were defining common symbol in
40 the standart namespace (like LP, Unknown ...)
42 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
43 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
44 The JPEG fragments are now parsed at the same stage than the RLE
45 information. All code related to JPEG is now in gdcmPixelConvert:
46 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
47 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
48 export a gdcmFile:: method. Those are simply global functions
49 (for the time being this is better than having them attach to
50 either gdcmFile:: or gdcmPixelConvert::).
51 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
52 and stores the result in a gdcmJPEGFragmentsInfo.
53 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
54 code (among other stuff) moved away from gdcmFile:; to
57 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
58 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
59 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
60 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
61 clean up of RLE related code.
62 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
63 - src/gdcmRLE.cxx removed
64 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
65 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
66 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
67 * CLEANUP_ROUND (9) for gdcmPixelConvert
68 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
69 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
70 away from gdcmFile:: to gdcmPixelConvert::.
72 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
73 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
74 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
75 This is because Parse7Fe0 used to parse the pixels to compute the
76 length. This task was passed over to FindDocEntryLengthOB() a long
77 time ago, EXCEPT I had forgotten the OW case...
78 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
79 we just recylce the code for parsing RLE fragments and computing
81 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
82 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
83 with the retired Parse7Fe0().
84 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
85 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
87 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
88 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
89 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
90 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
91 - src/CMakeLists.txt: alphabetic order reodering + new entries.
92 * CLEANUP_ROUND (4) for gdcmPixelConvert
93 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
94 to return an unused length.
96 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
97 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
98 this should be cleanner from the plane view. The iostream are erally a pain
99 to use to do simple stuff.
101 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
102 * Redo the compilation of the ijg jpeg library. Now only one source is
103 necesseray. No need to rename file by hand what so ever. CMake handle the
104 copying of the file within different directory, configure header file to
105 modify some symbol. The only addition made to ijg wasd a mangle table so
106 that symbol are different wether we are within 8bits or 12bits.
108 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
109 * Added documentation of vtkgdcmReader on Website:
110 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
111 with it's binary name).
112 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
113 the Website to be more complete.
114 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
115 doxygenated documentation.
116 - Doc/DoxyVtkGdcmReaderExamples.txt added
117 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
118 DoxyVtkGdmReaderExamples.html )
119 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
120 * CLEANUP_ROUND (3) for gdcmPixelConvert
121 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
123 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
124 * CLEANUP_ROUND (2) for gdcmPixelConvert
125 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
127 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
128 * CLEANUP_ROUND for gdcmPixelConvert:
129 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
130 - src/gdcmPixelStuff[h|cxx] removed
131 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
132 - src/CMakeLists.txt changed accordingly
134 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
135 gdcmVersion.py moved to newly created ATTIC related
136 gdcmPython/SetupOldies/ directory.
137 * Autotools clean up:
138 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
139 - autogen.sh configure.in acinclude.m4 python.m4 removed
141 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
142 * src/*.cxx *.h Reference to License.htm fixed to License.html.
143 * Doc/CMakeLists.txt, doxygen.config.in: fix.
144 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
146 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
147 * TODO updated with Mathieu suggestions. I proposed a template for
148 describing TODO entries and used it for new entries.
149 * Added Doc/Website/CodingStyle.html, Developpers.html,
150 DeveloppersPython.html, GdcmDataCvs.html and
151 DownloadVersion0_1.html, DownloadVersion0_3.html.
152 * Some Doc/*.txt Doxygen files (which do not really concern the
153 documentation itself, but the website) moved to html and
154 placed in directory Doc/Website:
155 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
156 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
157 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
158 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
159 * CMakeLists.txt changed accordingly.
160 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
161 DeveloppersPython.html
162 * INSTALL nows refers to Doc/Website/Installation.html
164 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
165 * Added Doc/Website directory, that contains a first raw version
168 2004-09-23 Jean-Pierre Roux
169 * FIX In order not to be poluted any longer by casting problems,
170 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
171 we can now delete[] it safely
172 * VoidArea is now called BinArea (less confusing name),
173 and all the methods called ...VoidArea... are now ... BinArea...
174 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
176 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
177 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
178 clear) TagHT, which is an inherited member of gdcmElementSet. It is
179 up to the destructor of gdcmElementSet to clean up TagHt and it's
182 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
183 * Test/CMakeLists.txt: update to follow gdcmData renamings.
184 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
186 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
187 * ENH: added some utility method that builds a flat dictionnary
188 holding all the Dicom entries contained in the recursive structure
189 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
191 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
192 BuildFlatHashTable() that build a flat dictionary.
193 - src/gdcmElementSet.h: added a new private GetTag() accessor.
194 gdcmDocument is now a friend of gdcmElementSet.
195 - src/gdcmElementSet.cxx: clean up.
196 - Example/FlatHashTablePrint.cxx added.
197 - Example/CmakeLists.txt changed accordingly
199 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
200 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
201 moved away from gdcmDocEntrySet (since this class is an abstract class
202 acting like an interface). SQDepthLevel and BaseTagKey are now
204 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
205 and associated accessors. Doxygenation of the class.
206 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
208 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
209 Use SQDepthLevel accessor instead. ::Print() adapted.
210 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
211 - src/gdcmDocument.cxx changed accordingly.
213 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
214 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
215 - The following is the doxygen comment of the typedef declaration
216 of gdcmagKey in src/gdcmCommon.h:
217 gdcmTagKey is made to old an "universal" (as in URL, Universal
218 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
219 A dicom tag allways has a group and an element, but a set of tags
220 embeded in various (optionally nested) sequences and sharing
221 the same group and element all share the same (group, element)
222 "identifier". Hence the (group, element) cannot be used as an
223 identifier (in gdcm we shall refer to a "TagKey") of a tag.
224 In order to construct a proper tag identifier (i.e. a key) we
225 consider the following definition of a TagKey:
226 - let Group, Element be the string representation of the
227 group and element dicom tag members,
228 - let ItemNumber be the string representation of the integer
229 index of the considered item number of a sequence,
230 Let the key of a tag embeded in a sequence, noted SeqTag, be
232 /ItemNumber#Group|Element
233 where "/", "#" and "|" are characters acting as separators.
234 Then the general form of a gdcmTagKey is given by:
235 Group|Element<SeqTag>
236 where <SeqTag> means NO or many instances of SeqTag.
237 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
240 but the gdcmTagKey of a tag "embeded" is the first item of
241 a sequence, itself nested in the third item of a sequence is the
243 0004|1220/2#0008|0082/0#0008|0090
244 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
245 order to hold the new sequence compatible key. Previously, the
246 GetKey() method would look in the underlying gdcmDictEntry.
247 - src/gdcmDocEntry.cxx:
248 -- constructor now copies the underlying DictEntry key, in the local
250 -- ::Print: displays the member Key, instead of the (group, element).
251 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
252 - src/gdcmDocEntrySet.h:xi
253 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
254 -- now has a new BaseTagKey member.
256 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
257 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
259 This poses the problem with the semantics of the following lines
260 LoadEntryVoidArea(0x0028,0x1201); // R LUT
261 LoadEntryVoidArea(0x0028,0x1202); // G LUT
262 LoadEntryVoidArea(0x0028,0x1203); // B LUT
263 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
264 to the long FIXME note for what the problem is. Nevertheless in
265 order to get things working the dicom dictionary was altered !
266 Please fix things urgently...
267 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
268 information), see above note on moving the member VoidArea. Nevertheless
269 the following entries previously correctly set as US are now inproperly
271 0028 1201 OW IMG Red Palette Color Lookup Table Data
272 0028 1202 OW IMG Green Palette Color Lookup Table Data
273 0028 1203 OW IMG Blue Palette Color Lookup Table Data
274 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
275 of gdcmDocEntry moved to gdcmSeqEntry.
276 * src/gdcmSeqEntry.cxx: STYLE.
278 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
279 * Test/TestAllEntryVerify.cxx minor fix and added comments.
281 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
282 * gdcmPython/testSuite.py: all the test suite in python is now moved
283 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
284 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
285 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
287 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
288 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
289 to avoid inclusion recursion until STL is reached.
290 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
291 mecanism. errno.h is not included in gdcm anymore.
292 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
293 (gdcmFormatError now inherits from gdcmFormatUnexpected).
295 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
296 gdcmData/TestAllEntryVerifyReference.txt
297 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
298 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
299 exception_on_error parameter.
300 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
301 - vtk/vtkGdcmReader.cxx changed accordingly,
302 - Example/*.cxx and Test/*.cxx changed accordingly.
304 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
305 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
306 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
307 enable_sequences removed from gdcmHeader constructor and dependencies.
308 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
309 * gdcmPython/demo/PrintHeader.py: dummy fix.
310 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
311 skip_shadow removed from gdcmHeader constructor and dependencies.
312 * Example/*.cxx and Test/*.cxx changed accordingly.
314 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
315 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
316 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
318 2004-07-21 Jean-Pierre Roux
319 * FIX Now, Parsing and Printing a DICOMDIR do work!
320 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
322 2004-07-20 Jean-Pierre Roux
323 * FIX Some brain damaged headers have Zero-Lenght fields
324 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
326 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
327 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
328 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
329 variable (instance of gdcmDebug) by a definition macro, and the instance
330 is now in static in the gdcmDebug class
331 * src/gdcmSQItem.h : (FIXME) remove an undefined method
332 * Test/PrintAllDocument.cxx : bug fix in the result of the test
334 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
335 * WARNING: ctest now depends more tightly on gdcmData. You should
336 check out gdcmData properly for things to run smoothly...
337 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
338 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
339 we need the pixels not be loaded in order to use the ValEntry
340 that displays position and size).
341 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
342 This is a C++ based equivalent of gdcmPython/testSuite.py that should
343 be deprecated. If you have any doubts about the advantages of a
344 modern scripting language (read Python) versus grass root C++ (i.e.
345 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
346 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
347 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
348 Anyhow, consider documenting the gdcmData images in
349 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
351 * Test/CMakeLists.txt:
352 - now uses TestAllEntryVerify.cxx
353 - specific comments on oldACR00001.ima (now renamed in gdcmData
354 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
355 gdcmData/TestAllEntryVerifyReference.txt
358 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
359 * src/*.[h|cxx] : typedef clean up
360 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
361 - TagKey renamed to gdcmTagKey (for external usage)
362 - VRKey renamed to gdcmVRKey (for external usage)
363 - removal of typedef duplication.
364 - Removed all unecessary inline keyword from class inline definitions.
365 - Some method|function(void) declarations replaced with method|function().
366 * src/jpeg/libijg12/jdhuff12.c:
367 - printf polluting ctest removed.
368 - TAB removal for comminting
370 - TestAllReadCompareDicom.cxx: added a test that compares all the
371 images in gdcmDataImages.h with corresponding images in
372 gdcmData/BaselineDicom/. When baseline images are not present
373 this test creates them.
374 Note: we need to validate each reference image, but before that
375 I'd like to rename them with a more explicit name...
376 - CMakeLists.txt: changed accordingly.
377 * Example/*.cxx: examples now only include gdcm.h (as opposed to
378 including each header needed).
380 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
381 * Test/*.cxx and Example/*.cxx: moved some examples away from the
382 test suite to the Example directory. Are concerned:
387 - TestWriteSimple.cxx
388 * Test/CMakeLists.txt: added some comments on reasons for black listing
389 image gdcmData/oldACR00001.ima
391 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
392 * Test/CmakeList.txt: removed the following from black list (to be coherent
393 with removal from gdcmData):
394 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
395 - gdcm-MR-PHILIPS-16.dcm
397 Added the following because after last cvs update, they cause
398 ctest -R TestReadWriteReadCompare
400 - gdcm-MR-SIEMENS-16-1.acr
402 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
403 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
404 new comments in this file) we temporarily (sigh) move to a weaker
406 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
407 we don't need to black list the following images anymore:
408 - 8BitsUncompressedColor.dcm
410 - US-PAL-8-10x-echo.dcm
411 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
412 fixes and the beautified code ;-)
413 This fixes the bug introduced in version 1.42 (when beautifying)
414 that made the parsing of 8BitsRunLengthColor.dcm unproper.
415 Note: ctest was blind to this bug (this means we need to still
416 improve the test suite). The bug could be detected by using
417 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
419 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
420 and by displaying the (garbage) produced file temp.XDCM...
422 2004-06-29 Jean-Pierre Roux
423 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
424 - replace by uggly but working old code :-(
425 A lot of things should be OK again.
426 It's really urgent to have a test suite that *tests*,
427 to prevent Frog's beautifying sessions to break all the stuff
428 (twice, withing a fortnigh ...)
430 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
431 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
432 redundancy) to added Test/TestReadWriteReadCompare.cxx
433 * Test/CmakeList.txt: because the compare test of
434 Test/TestReadWriteReadCompare.cxx fails, the following images are
435 black listed: - 8BitsUncompressedColor.dcm
437 - US-PAL-8-10x-echo.dcm
438 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
439 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
440 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
441 and ad-hoc kludge. This kludge is now removed, and on encountering
442 such an image (OB field brain damaged) we set errno. Then in
443 ::FindDocLength() we "fix" the length as being ALL what remains
444 in the file (until EOF). We then proceed, hoping for the best...
445 This fixes a SegFault in ShowDicom when trying to write such an
447 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
448 (because TestWriteRead breaks on it, after a non conformal commit?).
449 ctest now runs properly, except for MakeDicomDir (which was allways
450 broken) and the Python related stuff (still not fixed).
452 2004-06-24 Jean-Pierre Roux
453 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
454 FIX : Test/TestReadWrite now iterates on all the file names
455 (instead of infinite loop)
456 ENH : Test/TestWriteRead now iterates on all the file names
458 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
459 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
461 2004-06-24 Jean-Pierre Roux
462 FIX : - now Write drops LUT Descriptors and LUTs (if any)
463 when SamplesPerPixel =3
464 - now Write is no longer confused by
465 'BitsAllocated = 12" and 'BitsStored=12"
466 - "UN" value representation Elements are now written correctly
467 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
468 ENH : - now gdcmHeader has its own Write methods
469 (in order to split the job that has not to be done
472 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
473 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
474 loop on the same image until memory went out.
475 Note: this means we still have gobs of memory loss in PrintDocument
476 * src/gdcmDocument.cxx: fixes problem on parsing on file
477 gdcmData/16BitsJpegLosslessGrayScale.dcm.
479 2004-06-24 Jean-Pierre Roux
480 FIX : Write - All the Sequences and Sequence Item are now written
481 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
482 is added a the end, when necessary.
483 - A lot of brain-damaged images, that were read correctly are
484 now written correctly
485 - length compatible BinEntry are now loaded correctly
486 (even for odd groups)
487 Note : only Explicit Value Representation was checked.
488 (question : is implicit VR really necessary for gdcm ?)
490 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
491 * DEVELOPPER: added a proposition of coding style.
492 * src/gdcmDocEntry.h: removed every inline declaration (for test of
495 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
496 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
497 Use the gdcmDocEntry::Print() and Write() instead.
498 * src/gdcmDocument.cxx: bug fix.
500 2004-06-22 Jean-Pierre Roux
501 FIX : gdcmDocument.cxx
502 - Now we do recognize the JpegLossLess format (there was a misstyping in
503 code 'beautyfication' :-(
504 - Now we automaticaticaly load the Luts, if any
506 2004-06-22 Jean-Pierre Roux
507 In order : to write Sequences, whatever their imbrication level,
508 : to allow user to create his own Sequences
509 a lot of modif where necessary (adding, moving, or virtualising methods)
511 WARNING : save your own sources *before* cvs up !
514 ADD virtual void Write(FILE *fp, FileType filetype);
517 ADD virtual void Write(FILE *fp, FileType filetype);
518 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
521 ADD virtual void Write (FILE *fp, FileType filetype)=0;
522 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
523 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
524 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
525 ADD std::string GetEntryByName(TagName name);
526 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
528 std::string vr = "unkn",
529 std::string fourth = "unkn",
530 std::string name = "unkn");
531 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
532 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
533 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
534 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
535 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
536 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
537 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
538 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
541 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
542 ADD virtual std::string GetEntryByName (TagName tagName);
543 ADD virtual std::string GetEntryVRByName (TagName tagName);
544 REM virtual bool Write(FILE *, FileType);
545 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
546 FILE *_fp, FileType type);
547 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
548 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
549 REM virtual bool WriteEntries(FILE *_fp,FileType type);
550 REM virtual std::string GetEntryByName (std::string tagName);
551 REM virtual std::string GetEntryVRByName (std::string tagName);
552 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
553 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
554 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
556 std::string vr = "unkn",
557 std::string fourth = "unkn",
558 std::string name = "unkn");
559 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
560 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
561 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
562 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
565 ADD virtual void Write(FILE *fp, FileType filetype);
568 ADD virtual void Write(FILE *fp,FileType filetype);
571 ADD virtual void Write(FILE *fp, FileType filetype);
572 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
573 REM std::string GetEntryByNumber(guint16 group, guint16 element);
574 REM std::string GetEntryByName(TagName name);
577 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
579 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
580 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
581 The default constructor invoked by the line
582 gdcmHeader *f1 = new gdcmHeader( header );
583 was gdcmHeader::gdcmHeader(bool) instead of the expected
584 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
585 Hence the parsing wasn't executed... See also below.
586 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
587 as explicit constructor didn't do the trick to fix the above problem.
588 Could anyone explain why ?
589 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
590 properly calls gdcmValEntry::Print() (that was weed out from
591 code related to gdcmBinEntry).
593 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
594 * In order to fix memory leaks:
595 - Test/TestWriteSimple.cxx: added cleaning of free store through
597 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
598 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
599 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
600 (through the call to ::AddDicomDirMeta()) or the destructor
601 would crash when deleting uninitialized ::metaElems].
602 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
603 - src/gdcmDocument.cxx:
604 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
606 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
607 was causing memory leaks.
608 - src/gdcmSQItem.cxx:
609 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
610 cleanly handled with polymophism: sorry but my milage is low).
611 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
612 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
613 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
614 This avoids SegFaulting.
615 - src/gdcmSQItem.h: coding style.
617 - Test/TestWriteSimple still severely sucks. The output image content
618 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
619 damaged when displayed with vtkgdcmViewer.
620 - on memory leaks: TestWriteSimple leaks really less (see entry
621 of 2004-06-18 in Changelog file for the call to valgrind).
622 - on segfaults: ctest now passes all the tests but one (no more
624 * Erroneous leading white fix:
625 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
626 white[s] (as opposed to from >> xxx, that removes it [them].
627 - src/gdcmTS.cxx: ditto.
628 - gdcmPython/testSuite.py: dirty related kludge removed.
629 * src/*: remaining references to gdcmParser removed.
630 * src/*[cxx|h]: added copy[way]left header.
633 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
634 * In order to fix writing of dicom files:
635 - Test/TestWriteSimple.cxx: a simpler example of writing.
636 - Test/CMakeLists.txt changed accordingly.
637 - src/gdcmDocument.cxx:
638 -- The destructor now recursilvely removes potential sequences.
639 -- Bug fix in ::IsJPEG2000()
640 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
641 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
643 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
644 to only declared) and build on top of
645 ::GetDocEntryByNumber(guint16, guint16).
646 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
647 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
648 for usage in destructor and treatement of promotion in
649 ::ReplaceOrCreateByNumber().
650 - src/gdcmSQItem.cxx: destructor should better handle his job.
651 Test/TestWriteSimple now runs (or at least it DOES something).
652 * We can now start hutting memory links. A good starting point is:
653 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
654 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
655 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
657 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
658 * Valgrind note: after Mathieu Malaterre teached me how to read
659 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
661 Using gcc, you can force the STL to use malloc and to free memory as
662 soon as possible by globally disabling memory caching.
663 With 3.2.2 and later, you should export the environment variable
664 GLIBCPP_FORCE_NEW before running your program.
665 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
666 simply vanish (it is still not clear to me, whether this means that
667 STL std::string leaks or if valgrind believes it leaks...).
668 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
669 running bin/gdcmTests makeDicomDir):
670 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
671 - Test/makeDicomDir.cxx now properly traps empty lists and returns
673 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
674 SegFaulting (I drowned in DicomDir related code when trying to
675 understand why the list is empty...).
676 * src/gdcmDocument.h: first BSD license header try.
677 * Doc/License.txt added.
679 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
680 * src/gdcmDocument.[h|cxx]:
681 - Clean up of the Transfer related predicates. They are now all based
682 on new method isGivenTransferSyntax, that (should) handle properly
684 - general clean up, simplification, and coding style.
685 - Specific clean up of Parse7FE0() (umproperly named actually).
686 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
688 2004-06-14 Jean-Pierre Roux
690 - fix the display of Sequence Delimitor (SQDepthLevel pb)
691 - fix the display of SQItem ordinal number
692 - add the GetSQItemByOrdinalNumber method
693 - remove some useless never written private methods
695 2004-06-14 Jean-Pierre Roux
697 - adding a constructor taking a gdcmDocEntry as an input param
698 - ReplaceOrCreateByNumber now returns :
699 a gdcmBinEntry * if a Binary (void *) value is passed as a param
700 a gdcmValEntry * if a string value is passed as a param
702 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
703 according to the param type (no longer sets a gdcmDocEntry)
704 - GetValEntryByNumber, GetBinEntryByNumber added
705 - NewValEntryByNumber and NewBinEntryByNumber added
707 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
709 - GetSQItemNumber and SetSQItemNumber added, to provide
710 a (relative) Item identier inside a given Sequence
711 \warning : some pb remaining around this number
713 - AddEntry now takes the Item Number as a param
715 - adding a constructor taking a gdcmDocEntry as an input param
717 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
718 * Memory leak hunt with the following command:
719 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
720 --show-reachable=yes gdcmTests PrintDocument
721 It looks like many (all?) leaks are due to the STL (or a bad usage
722 of the STL. The lines producing the leaks now have a comment with
723 a "MEMORY LEAK" tag: you can retrieve them with
724 grep "MEMORY LEAK" src/*
725 Here are two typical examples which I can't help fixing:
730 char * test = "babo";
731 name = test; //// <--- valgrind detects 960 bytes lost in
732 //// call to std::string::operator=(char const*)
733 name.clear(); //// Doesn't help !
741 std::cout << "Type a bunch of characters followed by RETURN: ";
742 getline(std::cin, line); //// <--- valgrind dectects a loss
743 //// of 1320 bytes in call to
744 /// std::basic_istream<>& std::getline<>
750 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
751 * src/gdcmHeader.[cxx|h]:
752 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
753 and related, moved away to gdcmDocument.
754 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
755 the corresponding protected accessors of inherited class
756 gdcmDocument, removed ! As a consequence gdcmFile had to be
757 declared friend of class gdcmDocument (see below).
758 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
759 - Clean up of undefined or unused methods.
760 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
761 account the changes to gdcmHeader.h).
762 * src/gdcmDocument.h:
763 - gdcmFile is now a friend class (in order to take into account the
764 changes to gdcmHeader.h).
765 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
766 (see changes to gdcmHeader.h).
767 - Accessors (reading on the form GetEntry*) are now public.
768 - Clean up of undefined or unused methods.
769 * src/gdcmDocument.cxx:
770 - adaptation to changes to gdcmDocument.h
771 - ::OpenFile now writes a verbose message when file cannot be opened.
772 - some std::string properly set to VRKey
773 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
774 references to gdcmDocument.
775 * Test/TestFindTags.cxx: changed accordingly to above changes.
776 * gdcmPython/testSuite.py: adapted to renaming of acr files in
777 cvs repository gdcmData.
779 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
780 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
781 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
782 conflicts with gdcmValEntry::voidArea.
783 * src/gdcmValEntry.cxx: unmatching comment wiped out.
784 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
785 Value representation between StringRepresentable and BinaryRepresentable.
786 * src/gdcmDocument.cxx:
787 - method ParseDES: proper indentation restored and usage of
788 gdcmVR::IsVROfGdcmStringRepresentable wired in.
789 - method LoadDocEntry: the fingerprint left in the SetValue() of
790 unloaded entries (length > MaxSizeLoadEntry) had curiously been
791 removed. Reverting to previous code segment with the proper
792 dynamic_cast< gdcmValEntry* >.
793 Note: this was (partially) breaking the python test suite
794 (gdcmPython/testSuite.py) that made usage of the above
795 fingerprint to check presence of "Pixel Data".
796 * src/gdcmDocEntry.h: coding style.
797 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
798 now taken into account.
799 * gdcmPython/gdcm.i: adaptation to the new internal representation
800 of gdcm (exit gdcmParser, hello gdcmDocument).
801 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
803 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
804 anymore, but instead prints the loaded Python dictionary.
805 * .... alas, the python testSuite is still broken.
807 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
808 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
810 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
811 * src/gdcmUtil.h : export methods
813 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
814 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
816 * Initial addition of automatic python testing
817 * Initial addition of automatic image comparison
819 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
820 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
821 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
823 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
824 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
825 * Test/ShowDicom.cxx : bug fix for msvc compilation
826 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
828 2004-05-04 Jean-Pierre Roux
829 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
830 new concepts (and new classes) :
831 a 'gdcmDocument' is composed of a set of Doc Entries, that are
832 - elementary gdcmDocEntries (former gdcmHeaderEntries)
833 - Sequence Doc Entries (gdcmSeqEntries)
834 a Sequence is composed of Items.
835 Each item is a set of Doc Entries (this is recursive)
836 The non uniqueness of the 'Dicom tag' is due to this recursivity
837 (never taken into account)
838 Our unability to add a new 'entry' in the header
839 at the proper location (neither in the H-Table (map or multimap),
840 nor in the Chained List is also due to this recursivity.
841 Don't try, right now, to use/modify/compile these new sources :
843 We just commit all the stuff, 'as is', in order not to loose it.
845 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
846 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
848 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
849 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
850 file prefix (SetFilePrefix)
852 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
853 * Add a new test: ShowDicom, for now this is just the c++ version of
854 checkRead.sh, later it will be able to compare the image read against a
856 * Replace the DEBUG on the stack with a global entry in cmake interface:
857 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
859 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
860 * Add an example subdir, with a real example on how to read + write a
863 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
864 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
865 * Doc/CMakeLists.txt: the main page is now properly differentiated
866 between the developper and user version.
867 * Doc/doxygen.config.in: dropped search related obsolete flags
868 * src/gdcmParser.h, gdcmHeader.h: doxygenation
870 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
871 * DEVELOPPER: added some helpfull comments for compile/test/install
874 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
875 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
876 src directory, now generated in the build dir.
877 2. Tests as mentionned smarter
879 4. Add a new method in gdcmDict that return the PubDict by name
880 this is interesting for 3rd party lib like ITK,
881 where we could set the institution name / patient name...
883 * ENH: 1. Now the test suite is working for real
884 2. All binaries are now output in the gdcm-bin directory
885 (this was not true before)
887 2004-04-28 Jean-Pierre Roux
888 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
889 SeQuence indented printing of Dicom Header.
890 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
891 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
892 Computation of SQDepthLevel is now part of gdcmHeader constructor
893 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
894 tree-like structure of a Dicom Header.
895 * FIX Test code cleaning
897 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
898 * ENH: Adding automatic testing
899 1. Need a DartConfig.cmake to submit to public
900 2. Add a test driver gdcmTest.cxx
901 3. gdcmTestMain, an helper for the main test driver gdcmTest
902 4. Files in Test don't have a main anymore, this becomes interesting
903 when we add more and more tests, thus dsw don't have to load
905 * ENH: Adding a GDCM_DATA_ROOT for testing
906 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
907 one file instead of seven + some small cleanup
909 2004-04-22 Jean-Pierre Roux
910 * ENH Minor changes to the Print() methods.
911 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
912 Header printing. Example given with :
913 > PrintHeader fileName 2 new
914 (SQ based tree-like structure still to be done for the Header ...)
916 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
917 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
918 1. I have added some unsigned where needed
919 2. Some function parameter not used -> (void)
920 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
921 4. g++ don't like character '\' in comment
922 5. #define jpeg_create_decompress jCreaDecompress
923 this really need to be fixed
924 6. virtualize destructor of gdcmObject ... leakage
925 7. sscanf(g->first.c_str(),"%x",&gr_bid);
926 this also really need to be fixed
927 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
928 remove compression file
929 (as we only do decompression, right ?)
930 * ENH: Change malloc/calloc/free with c++ equivalent
932 2004-04-21 Jean-Pierre Roux
933 * FIX gdcmHeaderHelper::GetXSpacing
934 when a single value is found (bug ?), xpacing is now
935 defaulted to yspacing
937 2004-04-19 Jean-Pierre Roux
938 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
939 * ENH add parameters :
940 bool exception_on_error = false,
941 bool enable_sequences = false,
942 bool ignore_shadow = false
943 to the gdcmFile constructors to be full gdcmParser compliant
944 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
945 to allow reading of PAPYRUS 3.0 files
947 2004-04-06 Jean-Pierre Roux
948 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
950 2004-04-02 Jean-Pierre Roux
951 * ADD : Test/checksequence.sh, for a general recap on SQ pb
952 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
953 for Philips spurious Tag fffe|0000 while rewritting Dicom files
955 2004-03-30 Jean-Pierre Roux
956 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
957 for ACR file, written out as DICOM files (hope so...)
959 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
960 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
961 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
962 moved to base class gdcmParser and only the specialisation is kept
964 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
965 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
966 already does the job.
967 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
968 (to be consistent with gdcmParser::WriteEntries).
970 2004-03-30 Benoit Regrain
971 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
972 upate of the object's instance. It's passed to 2 in the unfavorable
973 case : one in the ExecuteInformation, one in the ExecuteData
975 2004-03-29 Jean-Pierre Roux
976 * ENH : Check on file type to be written moved
977 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
978 * FIX : gdcmObject::ResetBoundaries now stops properly
979 when end-of-list is reached
980 : gdcmVersion modified (as Benoit Regrain asked)
982 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
983 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
984 * src/gdcmUtil.cxx: added forgotten iostream include.
985 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
986 equivalent to ExplicitVR in existing code).
988 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
989 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
990 now contains all the gdcmGlobal related code.
991 * minor coding style and doxygenation changes.
993 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
994 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
995 now contains all the Debug related code.
996 * minor clean-up of includes in src/*.cxx
997 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
998 CreateCleanString) removed.
999 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1000 * Doc/DoxyMainPageUser.txt added.
1001 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1002 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1003 src/gdcmDirList.cxx)
1005 2004-03-24 Jean-Pierre Roux
1006 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1008 2004-03-23 Jean-Pierre Roux
1009 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1010 big endian made volumes
1011 * ENH Now gdcmParser constructor and destructor are protected to forbid
1012 end user to instanciate class gdcmParser
1013 (only gdcmHeader and gdcmDicomDir are meaningfull)
1015 2004-03-22 Benoit Regrain
1016 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1017 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1018 gdcmSerie to gdcmDicomDirSerie
1020 2004-03-19 Jean-Pierre Roux
1021 * ENH Now the tree-like structure describing a DICOMDIR comming from
1022 an already existing DICOMDIR file is consistent with
1023 the home-made tree-like structure build ex-nihilo
1024 or build from the files held (recursively) in a Directory
1025 functions gdcmDicomDir::CheckBoundaries()
1026 gdcmObject::SetBoundaries() added
1028 2004-03-17 Jean-Pierre Roux
1029 * REM (Eric Boix bug) : removal of meaningless
1030 gdcmDicomDirImage::NewImage function.
1031 * FIX now file names and directory name are written properly in the
1033 * FIX now gdcmDicomDir constructor may be call without any trick
1036 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1037 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1038 of gdcmDicomDirImage::NewImage as empty function.
1040 2004-02-28 Jean-Pierre Roux
1041 * ENH add gdcmDicomDir:NewPatient
1042 add gdcmDicomDirPatient:NewStudy
1043 add gdcmDicomDirStudy:NewSerie
1044 add gdcmDicomDirSerie:NewImage
1045 to allow making gdcDicomDir object.
1046 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1047 (as opposite to the gdcmHeader chained list)
1049 2004-02-11 Benoit Regrain
1050 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1051 when using from python
1053 2004-02-10 Benoit Regrain
1054 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1055 * FIX : in gdcmDicomDir when the directory is empty
1056 * ENH : add callback and methods to get the progression of dicomDir
1059 2004-02-06 Jean-Pierre Roux
1060 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1061 - GDCM_META added to gdcmDicomDirType
1062 - class gdcmMeta created
1063 * ENH : - A brief summary is now displayed at the beginning of
1064 'testDicomDir' to help disaster magnitude estimation
1065 * REM : Now useless Test/explDICOMDIR.cxx
1067 2004-02-05 Benoit Regrain
1068 * ENH : add methods in gdcmObject to get the hash table or the list of
1070 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1071 * FIX : wrapping python for TagHeaderEntryHT
1073 2004-02-04 Benoit Regrain
1074 * FIX : even length for some strings when writting the dicom dir
1075 * FIX : sort the images in the dicom dir
1076 * FIX : Bug fix for python use of dicom dir
1077 * ADD : a python demo
1079 2004-02-04 Jean-Pierre Roux
1080 * FIX : Final solution (?) for icone embedded images
1081 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1082 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1083 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1084 gdcmData/gdcm-MR-SIEMENS-16.acr1
1085 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1086 to make full checking easier
1088 2004-02-04 Benoit Regrain
1089 * FIX : WriteEntries : coding style & logic in parameters
1090 * FIX : Set the elements to create the DicomDir in a dictionary file
1092 2004-02-03 Benoit Regrain
1093 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1094 * gdcmDicomDir : add the load of directory
1095 * Bug fix and print add-on
1097 2004-02-03 Jean-Pierre Roux
1098 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1099 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1100 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1101 * FIX gdcmParser.cxx : 'group length' elements are now considered
1102 as integers, even for shadow groups, when file is Implicit VR
1104 2004-02-02 Jean-Pierre Roux
1105 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1107 of the last synonym :-(
1108 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1110 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1111 * FIX taking into account the possible 7fe0,0010 multiplicity
1112 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1113 to allow removal of references to 7fe0,0010, to deal with
1114 ACR-NEMA images, when 0028,0200 is meaningfull
1116 2004-01-31 Jean-Pierre Roux
1117 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1118 no longer writes 'Un' on disk
1119 * FIX SQ elements with actual length are now dealt with corectly
1120 * FIX gdcmFile::WriteBase make the difference, for color images, between
1121 the length (for Palette expanded images)
1122 and Raw Length (non expanded image + Palette)
1123 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1124 (that broke Write). Replaced by UL.
1125 Aware user will reload the field if he
1126 thinks it's necesssary
1128 2004-01-30 Jean-Pierre Roux
1129 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1130 when 'dirty Acr' is found, to be compliant with the new
1131 IsReadable() methods.
1133 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1134 (no DOUBLE images in kosher DICOM,
1135 but so usefull for people that miss them ;-)
1137 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1138 DICOMDIR related utilities (not checked as Windoze compliant)
1140 2004-01-28 Jean-Pierre Roux
1141 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1143 2004-01-27 Jean-Pierre Roux
1144 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1145 to allow skipping the shadow elements, to save memory space.
1146 The TRUE value for this param has to be used
1147 with a FALSE value for the 'enable_sequence' param.
1148 ('public elements' may be embedded in 'shadow Sequences')
1149 * gdcmHeader methods now deal with 'embedded icones images' in the header
1150 (even when an 'icone image sequence' is announced by the
1151 element (0x0088,0x0200), but there is NO icone at all ...
1153 * gdcmHeader sometimes Image Location value doesn't follow
1154 the supposed processor endianity (see gdcmData/cr172241.dcm).
1157 * gdcmHeader add the method
1158 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1159 to get *all* the Header Entries with the same tag.
1160 GetHeaderEntrySameName is probabely *useless*
1161 (no meaning : Name is *not* an identifier within the Dictionnary)
1163 2004-01-26 Benoit Regrain
1164 * Bug fix in the print of hexadecimal representations. Remove long fields
1165 in the print and add a third level of print to print them
1167 2004-01-23 Benoit Regrain
1168 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1169 * Bug fix on test suite after remove the strip made on not string fields
1170 * Split the IsReadable method between gdcmParser which test that the file
1171 is dicom and gdcmHeader which test that it's an image file
1173 2004-01-22 Benoit Regrain
1174 * DicomDir : clean code, add methods, set variables in protected or private
1175 * gdcmUtil : bug fix for the clean string method
1177 2004-01-19 Benoit Regrain
1178 * Add the use of shadow dictionaries
1179 * bug fix and coding style
1181 2004-01-19 Benoit Regrain
1182 * src/gdcmFile.cxx : bug fix concerning the close of file
1183 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1184 * Add the update of header entries using the shadow library
1186 2004-01-19 Benoit Regrain
1187 * removal of file gdcmHeader2.cxx
1188 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1189 inheriting from gdcmParser. This split is to prepare the integration
1190 of dicom dir parsing
1191 * bug fix under python
1193 2004-01-16 Jean-Pierre Roux
1194 * REM removal of class gdcmHeaderEntrySet
1195 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1196 * ADD add file gdcmHeader2.cxx
1197 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1199 2004-01-15 Benoit Regrain
1200 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1201 entries created while parsing the header. Thus, they will be destroyed
1202 when the gdcmDictSet will be destroyed
1203 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1206 2004-01-15 Benoit Regrain
1207 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1208 made a fatal error because of the memory release at the end of program.
1209 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1210 some memory and vtk seems to have some problems with that.
1211 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1213 2004-01-14 Benoit Regrain
1214 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1215 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1216 * src/*.[h|cxx] : make changes due to class name changes
1217 * gdcmPython/demo/*.py : bug fix due to method names
1219 2004-01-13 Benoit Regrain
1220 * src/*.[h|cxx] : coding style
1221 * vtk/*.[h|cxx] : coding style
1223 2004-01-13 Benoit Regrain
1224 * gdcmPython/testSuite.py : test the readable flag of file for tests
1225 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1226 It's lied to the stl compilation by MSVC (windows, always windows...)
1227 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1229 2004-01-12 Benoit Regrain
1230 * src/*.h : add comments
1231 * src/gdcmDictSet.h : set the method BuildDictPath in public
1232 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1233 directly setted in the source code
1234 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1237 2004-01-09 Benoit Regrain
1238 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1239 * setup.py : use a reference to gdcmVERSION
1241 2004-01-07 Benoit Regrain
1242 * Modification to compile with the distutils.
1245 2003-12-10 Benoit Regrain
1246 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1247 can use a gdcmHeaderHelper to load datas
1248 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1249 made in the source code
1251 2003-12-10 Benoit Regrain
1252 * Update Windows projects and .cvsignore files
1254 2003-11-12 Jean-Pierre Roux
1255 * ENH gdcmHeader constructor has one more parameter (default value : false)
1256 that allows the user to 'go inside' the SeQuences only
1258 gdcmElValSet:Print takes it into account
1260 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1261 * ENH: Update gdcmPython/CMakeLists
1262 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1263 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1265 2003-11-10 Jean-Pierre Roux
1266 * FIX : gdcmHeader::LoadElements is now based
1267 on the ListTag listElem member,
1268 not longer on the TagElValueHT tagHt member
1269 * ENH : PrintPubElVal shows (temporarily) both results,
1270 with the tagHt member and the listElem member.
1271 (it's easier to 'see' the problems when using Printheader)
1273 * FIX : old private member LgrElem is now splitted into
1274 ReadLength : Length actually found on disk (updated only
1275 if bug fixing is necessary), for internal
1277 UsableLength : Updated by FixFoundLength, to fix a bug
1278 or to allow Parser going on.
1279 Will allow to re-write a kosher header when a SeQuence
1280 with a length (not 0000) is found
1281 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1282 because gdcmElValSet::Add does not update ListElem
1285 2003-11-07 Jean-Pierre Roux
1286 * FIX misstyping in Transfert Syntax name table
1287 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1288 when they have an actual length (not 0000 nor FFFFF)
1289 (Nobody should care of it, but DICOMDIR explorers)
1291 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1292 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1294 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1295 * ENH: vtkGdcmReader now supports LUT !
1296 (vtkgdcmViewer for now is not able to use them though)
1298 2003-11-05 Jean-Pierre Roux
1299 * in testSuite.py : new files names for checking the package
1300 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1301 that returns the pixel area size to the *aware* (vtk) user
1302 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1304 2003-11-05 Benoit Regrain
1305 * in testSuite.py : Modify the rules for checking the paths
1306 : Explicit error messages
1307 * in __init__.py : Related modif
1309 2003-11-03 Jean-Pierre Roux
1310 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1311 to be used by aware (vtk) users that want to manage
1312 LUT (and no to turn the PALETTE image into an RGB pixels one)
1313 * GetPixelType now returns 8U for 24 Bits images
1314 (vtkGdcmReader compliant)
1316 2003-10-31 Jean-Pierre Roux
1317 * Removal of *all* gdcmData images and add them again
1318 in order to loose the 'history' of un-anonymised images
1320 2003-10-31 Jean-Pierre Roux
1321 * RMV : removal of useless jBitsInJsample.h
1322 for both 8 and 12 Bits JPEG Lossy Libraries
1324 2003-10-31 Jean-Pierre Roux
1325 * ENH : Add the functions gdcmFile::GetImageDataRaw
1326 gdcmFile::GetImageDataIntoVectorRaw
1327 that act as GetImageData and GetImageDataIntoVector
1328 except the making of an RGB Plane from Gray Plane + LUT
1329 Intended to aware (vtk) users who know how to manage
1332 GetLUTRGBA return a R,G,B,A LUT if any
1333 lgrTotaleRaw gives the 'Raw' length
1334 GetImageDataRaw returns the gray Plane
1335 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1336 (They stay Grey, just like with other Dicom viewers :-(
1338 2003-10-30 Jean-Pierre Roux
1339 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1341 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1342 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1343 being coherents dicom files.
1345 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1346 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1348 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1349 * ENH: Two steps is necessary to please VC++ compiler...
1350 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1351 * ENH: Add include dir to medcon lib
1352 * FIX: only one function is being exported for now !
1353 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1355 2003-10-29 Jean-Pierre Roux
1356 * adding gdcmHeader::GetLUTRGBA
1357 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1358 --> Mathieu, the modif u're waiting for is not yet committed
1359 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1361 2003-10-27 Jean-Pierre Roux
1362 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1363 00191113.dcm DermaColorLossLess.dcm
1364 MxTwinLossLess.dcm RadBWLossLess.dcm
1365 * ENH: For version prior to vtkImageViewer2 -r 1.19
1366 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1368 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1369 * Removal of ido stuff in CMakeLists.txt
1371 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1372 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1373 * FIX: remove a call to ->Modified ... see comments
1374 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1376 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1377 * FIX: Problem with path for libvtkgdcmPython
1378 * ENH: Try adding a search script for python site-package
1379 * RMV: Remove some file from medcon lib that are not necessary
1380 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1381 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1382 * FIX: More pragma disable fro VC++,
1383 I don't think I break something as it is also disable in VTK/ITK.
1384 But it fasten debug compilation time.
1386 2003-10-23 Jean-Pierre Roux
1387 * gdcm now deals with 16 Bits Run Length Encoded images
1388 (they are compressed as 2 planes images,
1389 one for the high Bytes, the other for low Bytes)
1391 2003-10-22 Jean-Pierre Roux
1392 * Now CheckRead takes into account :
1393 - the bugged 'Leonardo' Siemens images
1394 - the XA images, sent thru the burning VPRO station
1395 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1398 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1399 * FIX: When copying a Makefile.am to CMakeLists.txt
1400 one should remove the '\'
1402 2003-10-22 Jean-Pierre Roux
1403 * in gdcmData adding a bugged 'Leonardo' Siemens image
1404 (wrong lengths in header)
1405 OK with gdcm, KO with the other viewers :-)
1406 * add a GE dlx XA image, thru the VEPRO burning station
1409 2003-10-21 Jean-Pierre Roux
1410 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1411 for a brutal checking of vtkgdcmViewer compliance
1413 2003-10-21 Jean-Pierre Roux
1414 * add the files for 'xmedcon' Jpeg Lossless library
1415 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1417 2003-10-21 Jean-Pierre Roux
1418 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1420 2003-10-21 Jean-Pierre Roux
1421 * garbage Siemens 'Leonardo' images dealt with
1422 (the patch is easy to remove)
1423 * cosmetic changes to avoid warnings
1425 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1426 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1427 no need to press 'r' now.
1429 2003-10-20 Jean-Pierre Roux
1430 * upgrade of checkRead.sh checkWrite.sh according
1431 to new Jpeg Lossless decompressor
1432 * add US.3405.1.dcm, a genuine RGB medical file ...
1433 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1434 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1436 2003-10-15 Jean-Pierre Roux
1437 * general anonymisation in gdcmData
1438 * adding the 'color files' from
1439 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1440 * adding some well knowed bugged-header images
1441 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1442 waiting for their inclusion in Python testsuite
1444 2003-10-15 Jean-Pierre Roux
1445 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1446 no longer seg faults when file is not found
1448 2003-10-14 Jean-Pierre Roux
1449 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1452 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1453 * TODO: *.in file to genereate a UseGDCM later
1455 2003-10-14 Jean-Pierre Roux
1456 * Some supposed-to-be Dicom Images have no preamble.
1457 OpenFile takes it into account
1458 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1459 * Missing elements added in dicomV3.dic
1460 (just to be affraid : have a look at
1461 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1462 and do it again next year ;->
1464 2003-10-13 Jean-Pierre Roux
1465 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1466 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1467 But there are NOT. It's fixed !
1469 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1470 * FIX: "jpeglib.h" was not found on VC++
1471 * FIX: vtkgdcm was not being installed
1473 2003-10-10 Jean-Pierre Roux
1474 * ENH : OpenFile closes the file if it *really* doesn't look like
1475 an ACR-NEMA / DICOM one.
1476 * FIX : testWrite no longer writes an empty file if the source file
1477 is not gdcm Readable
1478 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1481 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1482 * FIX: CMake generate now documentation
1483 * ENH: out of source doc build !
1484 * ENH: Generate both user and dev documentation
1485 * ENH: Should work on windows too
1486 * ENH: Only one doxygen config.in file is needed
1487 * FIX: make install should be ok now on ùnix plateform
1488 * FIX: PATH to dictionary was wrong (missing /)
1489 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1491 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1492 * vtkGdcmReader is now able to read rgb dicom file.
1493 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1494 * added a gdcmViewer to vtk test, use mouse to control
1495 window level & window width
1497 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1498 * CMake-ification of gdcm, we have now two build system
1499 * FIX: on cygwin Wsock32 doesn't exist
1500 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1502 2003-10-06 Emanuel Ollart
1503 * FIX : compilation process wad broken.
1504 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1506 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1507 * change gdcmViewer -> vtkgdcmViewer
1508 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1510 2003-10-06 Jean-Pierre Roux
1511 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1512 ( e.g : well known GE images with a wrong elem length,
1513 : Philips MRI Images with a wrong Huffman table)
1514 * still to be done : allow the reading of bugged LEONARDO Siemens images
1516 2003-10-03 Jean-Pierre Roux
1517 * Odd length strings are padded with '\0' (not with spaces,
1518 to remain compliant with already defined strings,
1519 like Transfert Syntax UID and others)
1521 2003-10-03 Jean-Pierre Roux
1522 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1523 to allow displaying RGB images (not only by affim ;-)
1525 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1526 * vtkGdcmReader is now able to read rgb dicom file.
1527 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1529 2003-10-03 Jean-Pierre Roux
1530 * A few nasty patches to allow the reading of a lot of nasty images
1531 ( e.g : well known GE images with a wrong elem length,
1532 : Philips MRI Images with a wrong Huffman table)
1533 * still to be done : allow the reading of bugged LEONARDO Siemens images
1535 2003-10-03 Jean-Pierre Roux
1536 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1538 2003-10-03 Jean-Pierre Roux
1539 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1540 to allow displaying RGB images (not only by affim ;-)
1542 2003-10-03 Jean-Pierre Roux
1543 * gdcmFile::GetImageDataIntoVector now
1544 - deals with MultiFrames MultiFragments Run Length Encoded files
1545 - deals with YcBcR (YBR_FULL) files
1546 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1547 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1549 (no sample found :-(
1551 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1552 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1553 Two reasons: - clear things
1554 - third parties acces gdcm through header files, so won't
1555 suffer anymore VC++ complains
1557 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1558 * add argv[1] in testvtkGdcmReader.cxx
1561 2003-09-24 Jean-Pierre Roux
1562 * The lines are now eigthy characters long.for
1563 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1565 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1566 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1567 char* to std::string. Thus, the use of strdup becomes useless. (see
1568 previous commis of Malaterre)
1569 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1570 before the last Malaterre's commit.
1572 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1573 * This commit should fix the Debug building under VC++, the problem
1574 was mainly a mixture of debug and release lib being loaded at startup.
1575 * I also remove a depency to a specific C function: strdup. Because I had
1576 to force the link to msvcrtd (whereas strdup is in libc).
1578 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1579 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1580 located in the gdcmCommon.h file. All use of reference of tha has been
1581 changed to now use the variable GDCM_UNFOUND.
1583 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1585 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1586 Dicom dictionary. The test suite can now be run again. Note:
1587 I'm note very happy with the " (RET)" changes. I believe this
1588 RETAINED comment should be dropped when parsing the dictionary.
1589 - PACKAGER corrected
1591 - AUTHORS updated and now in alphabetical order
1592 * Makefile.am now exports gdcm.dsw for Windoze users.
1594 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1595 * cygwin complains about missing std:: in subdir Test/
1597 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1598 * remove some methods that are now in gdcmHeaderHelper
1600 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1601 * vtkGdcmReader set spacing and origin correctly
1603 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1604 * Fix a few delete/delete[] mismatch
1606 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1607 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1608 interpretation to data given by gdcmHeader. For instance there are
1609 heuristics to get informations (look at different places).
1610 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1611 sorting DICOM images based on different strategies.
1612 * modified Makefiles accordingly.
1614 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1615 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1616 when building in debug mode
1617 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1618 src/win32/gdcmdll.dsp
1619 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1621 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1622 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1625 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1626 * src/win32/libgdcmjpeg12.dsp was not dos format
1627 * src/win32/libgdcmjpeg12.dsp :
1628 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1629 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1631 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1632 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1634 * src/gdcmFile.cxx : bug fix in affectation type
1635 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1636 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1637 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1638 symbols... future problem ?
1640 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1641 * src/win32/libgdcmijpeg12.dsp was missing
1642 * modified gdcm.dsw accordingly
1644 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1645 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1647 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1648 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1649 commit of JPR (before his hollidays to facilitate our work).
1650 * setup.py : bug fix in code. Modifications made while the last commit
1651 of JPR. The code hasn't been tested before the commit... it's so
1652 useless to make that (for best programmer that is JPR) !!!
1654 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1655 * tagged the current version as Version0_3 (i.e. version 0.3)
1657 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1658 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1659 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1660 * *.dsp : modifications to use new libgdcmijpeg8 library
1661 * setup.py : bug fix on VTKPATH variable
1662 * PACKAGER : adding all concerning windows
1664 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1665 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1667 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1668 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1669 test suite reported error.
1670 * PACKAGER file added (describes what a packager must do when
1671 packaging a new release).
1672 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1673 * configure.in: upgraded version number to 0.3.0
1674 * fixing build of rpm (through rpm -ta):
1675 - Doc/Makefile.am exports proper doxygen files
1676 - src/jpeg/libijg8/Makefile.am exports the include files.
1678 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1679 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1680 * src/gdcmHeader.h : formatting code
1682 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1683 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1684 We were obtaining error message from vtk. Now, creation of file list
1685 is made in an internal list to prevent this problem.
1686 Bug fix when output is empty.
1687 Bug fix in update of progress value. Previous commit for this was a bad
1689 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1691 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1692 * src/gdcmHeader.h : added method to get the file name
1693 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1694 files. Added method to remove all files on the input
1695 Added FIXME comment concerning the bad parsing of header made by
1696 ExecuteInformation method (in ExecuteData method)
1698 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1699 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1700 when using make instal.
1701 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1702 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1704 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1705 * setup.py : adding include dir of jpeg lib to compile all sources
1706 * */Win32/*.dsp : JPR fix for windows compilation
1708 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1709 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1711 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1712 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1714 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1715 * setup.py is again effective on un*x (takes into account the
1716 addon of the jpeg library)
1717 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1718 * Doc/Doxy* updated (includes above enhancements)
1719 * INSTALL now points to web documentation
1721 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1722 * src/gdcmHeader.h doesn't make unnecessary reference to
1724 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1726 * src/gdcm*.[cxx|h] :
1727 - to allow compilation with gcc 3.x
1728 -- clean up of STL usage (added explicit usage of std::)
1729 -- small fixes on exceptions.
1730 Note: linking not tested !
1731 - clean of doxygen comments to avoid warnings at documentation
1733 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1734 dependent convertion).
1736 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1737 * Clean up of previous JPR garbage commit (not even commented in the
1739 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1740 - moved all jpeg related files from src to src/jpeg/libijg8, with
1741 addition/modification of Makefile.am and configure.in.
1742 - the testSuite is still brain damage (not guilty).
1744 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1745 * WrapVTK.py : modifications to get correctly vtk source files to
1747 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1748 (FileName -> Filename)
1750 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1751 * vtk/vtkGdcmReader.[cxx/h]:
1752 - UpdateProgress method should now be effective
1753 - removed the limitation on having only images loaded (as opposed
1755 - when building a stack of images/volume, a lesser number of
1756 gdcmHeader and gdcmFile instances should be used (hopefully
1757 accelerating things).
1758 - when building a stack of images/volumes, files which are not
1759 loadable (wrong path-filename, wrong permissions on existing file,
1760 or file not parsable by gdcm) are replaced with a black image
1761 in the stack (for the caller to notice the problem).
1763 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1764 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1766 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1767 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1768 between standard library (std) and vtk library (problems are found
1769 under Windows... thanks Windows !)
1771 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1772 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1774 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1776 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1777 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1779 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1780 * When compiling with distutils (see setup.py) the C++ compiler is
1781 called with different flags than the default ones (with automake).
1782 In order to fix all those warning, I compiled gdcm with the command
1783 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1784 and went for warning fixes:
1785 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1786 up from unused variables.
1787 - vtk/vtkGdcmReader.cxx: potential bug fix.
1788 * src/gdcmHeader.h: Doxygen warning cleanup
1790 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1791 * gdcmPython/gdcm.i:
1792 - typemaps correction to take into account the systematic replacement
1793 of "using namespace std" with std:: prefix e.g. std::list,
1794 std::string... (cf changes of 2003-05-21).
1795 - gdcmGlob global variable of type gdcmGlobal (defined in
1796 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1797 exported to Python a as cvar.
1798 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1799 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1800 gdcmDictSet.GetPubDictTagNames() and
1801 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1802 C++ static methods).
1803 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1804 with the above changes.
1806 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1807 * setup.py, manifest.in : bug fix under linux
1809 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1810 * Modification of setup.py to compile vtk part too. Then, we have 2
1811 wrappers which must work with same distutils. For that, we have a
1812 generic distutils in distusiltsWrapping.py ; with :
1813 - build_extWrap class to wrap generically all extensions,
1814 - ExtensionWrap base class for all wrapping extension that contains
1816 - Wrapper interface which wrap sources
1817 + In WrapSwig.py we have extension and wrapper for Swig
1818 + In WrapVTK.py we have extension and wrapper for VTK
1819 * MANIFEST.in : modifications to consider vtk directory and new python
1820 files for compilation
1822 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1823 * Added python wrappers of vtkGdcmReader vtk class (see the
1824 source in vtk/vtkGdcmReader.cxx) :
1825 - vtk/Makefile.am now builds a library
1826 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1827 python library (as opposed to _gdcm.so wich are the python
1828 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1829 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1831 - configure.in has an additional flag --enable-vtk that needs
1832 to be set to enable compilation of vtk related code, that is:
1833 + vtk/vtkGdcmReader.so and
1834 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1835 + gdcmPython/vtkgdcmPython.so (see above)
1836 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1837 be read when compressed or when HighBit + 1 != BitsStored),
1838 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1839 the usage of the python wrapper of vtkGdcmReader vtk class.
1840 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1841 * src/*.[h] all occurences of stl classes are now prefixed with
1842 std::, and all occurences of "using namespace std;" where removed.
1843 This is to avoid pollution of global namespace in included files.
1844 Apparently vtk does not avoid this pitfall: when using both
1845 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1846 collision of various stl members (principally cout...).
1847 * gdcmPython/testSuite.py now cleanly removes temprory generated
1849 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1850 comply with above changes)
1852 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1853 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1854 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1855 vtk data structure (an image Flip was required).
1856 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1857 * cosmetic changes in documentation.
1859 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1860 * src/gdcmHeader.cxx: the constructor no longer exits when an
1861 unexisting file is given as argument.
1862 * The subdirectory Data (containing all the images used for the
1863 test suite) is not part of this repository anymore. A new module
1864 containing those images is now available at
1865 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1866 with the name gdcmData.
1867 All the python scripts (including the package initialisation file
1868 gdcmPython/__init__.py) were adapated to take this change into
1869 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1871 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1872 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1873 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1874 demo of the usage of this class.
1875 Compilation of this vtk part is only done when using the --enable-vtk
1876 at configure (or autogen.sh) stage.
1878 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1879 * More memory link related corrections and documentation fixes.
1881 - maximum info is obtained with a command of the form:
1882 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1883 --show-reachable=yes PrintHeader
1884 - the remaining reachable blocks seem to come from the STL
1885 allocation scheme through the usage of map and list. It looks
1886 like this memory cannot be freed but it is not a memory leak
1887 (in fact further invocation to the STL would recollect the
1888 unused memory allthough it cannot explicitely be freed).
1889 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1890 of displaying an image parsed with gdcm and displayed with VTK.
1891 Note: some images don't seem to work e.g.
1892 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1893 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1894 Allthough this weakens the semantics, it is a ditch attempt to
1895 make gdcm more thread friendly.
1897 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1898 * Memory link hunt (by using valgrind through the command
1899 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1900 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1901 gdcmHeader::_dicom_vr.
1902 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1903 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1905 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1907 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1908 * src/Makefile.am now exports all the necessary include files at
1912 * UpdateGroupLength replaced by new one
1915 * UpdateGroupLength re-written using H-Table
1916 (named UpdateGroupLengthNew untill checks are over)
1918 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1919 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1920 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1922 - gdcmHeader::GetPubElValSet removed.
1923 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1924 UpdateGroupLength, WriteElements, Write.
1925 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1926 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1927 carried the same semantics.
1928 - src/gdcmHeaderIdo.cxx changed accordingly.
1929 - gdcmFile::WriteBase now regroups all the codes from previous
1930 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1931 - enum FileType moved to gdcmCommon.h
1932 * src/gdcmHeader.cxx AddDefault trashed
1933 * gdcmGetXSize added
1934 * getimageDataSize now calls gdcmGetXSize
1935 * Test/*.cxx changed to agree with above changes
1937 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1938 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1939 (to avoid double call by end user).
1940 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1941 by end user, since gdcmHeader::gdcmHeader now handles it.
1943 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1944 * gdcm/Doc many doxygen changes:
1945 - Doxyfile now has two different versions, DoxyfileUsers that generates
1946 the html.users end users oriented documentation and
1947 DoxyfileDeveloppers that generates the html.developper developper
1948 oriented documentation.
1949 - README changed accordingly
1950 - requirement.txt removed (old design info moved to TODO).
1951 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1952 DoxyMainPage.txt, DoxyPython.txt provide more information.
1953 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1954 be updated by simply regenerating the docs with doxygen and copying
1955 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1956 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1957 all the tests in the form "if (<map>.count() >1)" were removed.
1958 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1959 ill-formed documentation sections.
1960 * src/gdcmHeader.cxx: ditto
1962 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1963 * setup.py fixed for un*x (needed macro for stdint.h)
1964 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1965 un*ces with sh-utils test utility.
1966 * gdcmPython/demo/test.py renamed to PrintHeader.py
1967 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1968 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1969 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1970 * src/gdcm*.cxx JPR's bad inclusion fixed.
1972 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1973 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1974 * gdcmPython/demo/test.py changed accordingly.
1976 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1977 * gdcmPython/Makefile.am fixed linking against libstdc++
1978 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1979 * Swig subdir (historical tests of swig version 1.3.17++) removed
1980 * Test/testChangeEntete.cxx some lines commented out in order to make
1982 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1983 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1985 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1986 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1987 hence the user doesn't need this explicit call.
1988 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1989 i.e. LoadElements() call removed.
1990 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1991 - src/Makefile.am declares the proper flag for g++.
1992 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1993 for adding user defined new tags.
1994 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1995 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1996 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1998 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1999 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2000 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2001 src/Makefile.am : the project should properly compile and install
2002 with the autotools, included the python wrappers part.
2003 * gdcm.spec.in : added a spec file for RPM packaging.
2005 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2006 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2008 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2009 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2010 to exported to the environement (see gdcmPython/testSuite.py
2012 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2013 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2014 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2015 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2016 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2018 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2019 * gdcmPython/__init__.py doesn't crash anymore when running in
2020 in InstallMode or PreInstallMode but with an environement given
2021 value of GDCM_DICT_PATH.
2022 * src/gdcmDictSet.[cxx/h] coding style.
2024 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2025 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2026 * src/gdcm.h general comments moved to TODO, and README
2027 * src/gdcm.h should now be seen as a user commodity (including it
2028 should suffice to fully use gdcm). It is nowhere including within
2029 any of the kernel files src/*.cxx and src/*.h.
2031 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2032 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2033 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2035 * src/gdcm*.cxx only include their corresponding include file
2036 (as opposed to gdcm.h)
2037 * gdcmPython/gdcm.i changed accordingly
2038 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2039 the autogen.sh generated "make snapshot" command to work.
2040 * autogen.sh removed history related references to crea package.
2042 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2043 * distutilsSwigCPlusPlus.py work around some swig portability
2046 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2047 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2048 was done in a last ditch attempt to get setup.py _really_
2049 operationnal. The python/gdcmPython layaout add the advantage
2050 of hidding away the python related distutils specific files
2051 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2052 Alas, the src directory was out of scope (i.e. it's relative
2053 position to setup.py was ../src) which made things impossible to
2054 handle (see previous version of python/setup.py). Crossing fingers...
2056 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2057 * python/setup.py now works on Un*x. (harder than I thougth)
2058 * python/distutilsSwigCPlusPlus.py can now have include files
2059 among the list of sources.
2061 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2062 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2063 * modifications in MSVC projects
2065 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2066 * As stated by the first lines of Test/ExceptionAndPython/README, it
2067 looks like we can move back to original usage of exception within
2068 src/gdcm* and hence remove the errno stuff that was introduced
2069 as a quick and dirty fixture of this problem (added to the TODO).
2070 * Doc/Doxyfile configuration file for Doxygen and corresponding
2071 README file for usage added.
2072 * Test/testWrite.cxx added. This new test comes from a split of
2073 test.cxx that is now reverted to its original purpous i.e.
2074 testing the proper parsing of a Dicom related file.
2075 testWrite.cxx concentrates on testing the IO part of gdcm.
2076 * Test/bug1.cxx (containing a bug on WIn32) added.
2077 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2078 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2079 whose purpose is to publish the content of the TagNames of the
2080 Dicom public dictionnary were not accessible without an
2081 instance of class gdcmHeader.
2082 - those methods are now static methods of gdcmDictSet and hence
2083 require no instances at all to be invocated.
2084 - within gdcmDictSet this change required to change some method
2085 to class methods (i.e. are now static) among which SetDictPath
2086 (renamed to BuildDictPath) and LoadDefaultPubDict.
2087 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2088 the above changes by calling the new method classes of gdcmDictSet.
2089 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2090 the above to be effective.
2091 * python/gdcmPython: in order to wrap properly the above changes
2092 for Python, swig version now needs to be > 1.3.17.
2093 * python/gdcmPython/Makefile fixed to adapt itself to new
2094 configure/make shema introduced by Johan Montagnat (thanks for the
2095 contribution). Alas this Makefile cannot be turned into a proper
2096 Makefile.am without some heavy changes in the configure.in
2097 (for python dectection).
2098 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2099 now avoids publishing the empty entries.
2101 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2102 * python/setup.py : bug fix concerning install under windows
2103 ExtraPath reused :-P
2104 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2106 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2107 * Dicts/dicomV3.dic : remove double spaces !!!
2108 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2109 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2112 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2113 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2114 method. Doxygenation.
2115 * src/gdcm.h clean up of JPR spurious comments.
2117 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2118 * python/distutilsSwigCPlusPlus.py now properly collects the
2119 shadow classes generated by "swig -c++" (gdcm.py in our case)
2120 when using "python setup.py install".
2121 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2122 reexports the working classes.
2123 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2124 by the classical C errno scheme. This is to prevent an obscure
2125 behavior of the python wrappers when importing wxPython.wx prior
2126 to gdcmPython (which ended up in an abort call). An illustration
2127 of this oddity can be found in the Test/ExceptionAndPython
2128 subdir (see the README file). This problem probably due to
2129 an combination of g++ and dynamic loading.
2130 * added Test/ExceptionAndPython (see above)
2132 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2133 * Changed the layout of the python part to avoid bloating main
2134 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2135 i.e. the distutils arsenal. All the python related stuff is
2136 again in a python subdir, but the package itself is now in
2138 * setup.py was cleaned up:
2139 - pythonIncludePath removed
2140 - python setup.py bdist target is now functional.
2141 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2142 collision with other packages). gdcmPython/demo/*.py changed
2145 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2146 * python subdir moved to gdcmPython (preparation of distutils packaging).
2147 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2148 distutils installer is operational.
2149 * - gdcmPython/__init__.py now properly loads the swig generated
2150 shadow classes (from gdcm.py).
2151 - gdcmPython/demo/*.py changed to import the package gdcmPython
2152 instead of gdcmPython/demo/load.py.
2153 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2155 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2156 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2157 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2158 entries within the associated public Dicom dictionary resp. the same
2159 information but sorted by the fourth field (PAT, IMG, DIR) of the
2161 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2162 are now in the "???" group.
2163 - python/gdcm.i changed accordingly,
2164 - python/demo/printGroupedPublicDict.py added, that gives an example
2165 of the above new functionalities in Python.
2167 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2168 * src/gdcm.h, gdcmHeader.cxx:
2169 - historic references to glib's g_malloc and g_free (#defined)
2170 were definitively removed.
2171 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2172 * src/gdcmElValSet.cxx:
2173 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2174 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2175 - GetElValue(string) renamed to GetElValueByName.
2176 - Added GetElementByName(string).
2177 * src/gdcmHeader.cxx: added
2178 - GetPubElValRepByNumber(guint16, guint16)
2179 - GetPubElValRepByName(string)
2180 - GetShaElValRepByNumber(guint16, guint16)
2181 - GetShaElValRepByName(string)
2182 - GetShaElValByNumber(guint16, guint16)
2183 - GetShaElValRepByName(string)
2184 - GetElValRepByNumber(guint16, guint16)
2185 - GetElValRepByName(string)
2186 - GetElValByNumber(guint16, guint16)
2187 - GetElValRepByName(string)
2188 * Doc/requirements.txt added.
2190 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2191 * Test/Makefile building now depends on the one of libgdcm.so
2192 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2193 pixel data) aware which enables finding the address (offset) of
2194 the pixel data of JPEG encoded DICOM files. This leaves only a single
2195 file in the testSuite whose pixel data address (offset) is unknown.
2196 * python/testSuite.py changed accordingly.
2198 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2199 * VC++ has some strong limitations when working with the STL, as stated
2200 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2201 "Also note that some STL containers (map, set, queue, list, deque)
2202 cannot be exported. [...]
2203 Some STL classes contain nested classes. These classes can not
2205 This is caused by a designed limitation that once a template
2206 class is instantiated, it can not be re-instantiated and
2208 Since our usage of map<> is ubiquitous in gdcm, this "designed
2209 limitation" of VC++ is a pitfall.
2210 Hence the Python wrappers of gdcm cannot be incrementally linked
2211 against the c++ dynamic library. The dirty but only workaround is
2212 to forget about incremental link of dynamic libraries and to generate
2213 the Python wrappers library with the inclusions of the underlying C++
2215 The following modifications concern this matter on Win32/VC++:
2216 - wrapping python correct with standalone wrapped dll (don't use separate
2217 dll under windows !!!!)
2218 - python21_d debug mode enabled (ask Frog how to use it :-)
2219 - NO problem with having an STL member of class for example string in C++
2220 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2221 - Python test of dcmlib in Python is ok under windows on a large set
2223 * removed glib references
2224 * typedef's inserted in gdcm.i for correct swig type management
2226 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2227 * python/demo/*.py load.py extracted from test.py. Added explore.py
2228 that only displays required tags and testAll.py that parses all
2229 the files of the testsuite without using unittest.
2230 * python/testSuite.py other additional test on new files added.
2231 * Data/* new test files added accordingly to the testSuite.
2232 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2233 the vr in the file differs from the one of the dictionary.
2235 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2236 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2237 values, but limits itself to values which are below a user specified
2238 size (by default 1024 bytes).
2239 * python/gdcm.i : elements not loaded (because their size is above the
2240 user specified treshold) are exported with their TagKey as key of the
2241 python dictionary. This enables the testsuite to make some checks
2242 on the unloaded elements (since we have their offset and size).
2243 * python/testSuite.py
2244 - now tests for the existence and proper value of the pixel data
2245 - two new examples added.
2246 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2248 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2249 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2250 aware. See the strategy comments in gdcmHeader::FindeLength().
2251 * Test/test.cxx now accepts a filename as first argument.
2252 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2253 * python/testSuite.py changed to integrate test on above files.
2255 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2256 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2257 the vr was also RET.
2258 * python/testSuite.py more tests added.
2260 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2261 * python/testSuite.py unittest test suite added (uses Data)
2262 * Data/* dcm and acr files for the test suite.
2263 * glib dependance removed from un*x version. We now use ISO C99
2264 7.18 Integer types (see stdint.h)
2265 - python/Makefile, src/Makefile src/gdcm.h
2266 * src/ when an explicit vr (like dicom files) suddenly poped an
2267 implicit element we use to mark the underlying DictEntry of the
2268 concerned ElValue with "Implicit". This strategy was damageable
2269 too the public or provite dictionaries, since some of their vr
2270 would be changed. Since Header::FindLength heavily relies on the
2271 detection by Header::FindVR of falsely explicit elements, I
2272 added an extra ImplicitVr member to ElValue (boolean).
2273 The rest of the changes we the necessary adaptations.
2275 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2276 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2278 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2280 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2281 * Adaptation for porting to VC++:
2283 o forced to use std namespace (for string to be known)
2284 o all class use __declspec export style on WIN32
2285 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2286 (in stdlib.h on Win32 but in std:: for gcc)
2287 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2288 variable GDCM_DICT_PATH.
2289 * src/gdcmHeader.cxx verbose comments made discrete.
2291 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2292 * python/gdcm.i: added a typemap that converts a C++ hashing table
2293 to native Python dictionary.
2294 * python/demo/test.py:
2295 - now uses the native dictionary for exploration of gdcmHeader.
2296 - takes an optional filename argument (the file to parse).
2297 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2298 PubElVals hashing table.
2299 * Dicts/dicomV3.dic removed error prone trailing spaces.
2301 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2302 * Python wrapping process moved away from src/Makefile to
2303 newly created python/Makefile (as well as gdcm.i)
2304 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2305 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2306 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2307 from the environement variable GDCM_DICT_PATH (when existing).
2308 * src/gdcmDict::GetTag bug fix.
2310 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2311 * Straightforward temporary fixes for swig to build the python wrappers.
2312 src/Makefile now has a python working entry [by working we mean
2313 that we can import de shadow classes without errors].
2315 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2316 * hashtest.cxx removed (since allready in Test)
2317 * src/gdcmlib.h renamed to src/gdcm.h
2318 * src/dcm.i renamed to src/gdcm.i
2319 * src/Makefile prepared for python wrapping
2321 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2322 * src/gdcmHeader.cxx :
2323 - Parsing of header is now separated from loading of element values
2324 (see gdcmHeader::LoadElements).
2325 - general clean up of hopefully all file access (creation of
2326 ReadInt16 and ReadInt32)
2328 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2329 * src/gdcmHeader.cxx :
2330 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2332 - SetLgrElem renamed to SetLength
2333 - GetLgrElem renamed to GetLength
2334 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2335 * src/gdcmElValSet.cxx fixed both GetElValue methods
2336 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2337 due to IdoDude was cleaned out.
2339 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2340 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2341 concentrates on finding the value representation (when it exists).
2342 RecupLgr now only finds the element value length, and it avoids
2343 returning the unecessary skL (skipped length).
2344 Also, offsetCourant was simply removed (with taille_fich) since
2345 it was redundant with the File position internals (by using
2346 ftell and fseek). This also made skL (see above in RecupLgr) usage
2348 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2349 on the libido specificities which are handled through class
2351 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2354 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2355 * Truckload of changes. Parsing of header is barely functional
2356 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2358 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2359 * src/gdcmHeader.cxx many addons of low level methods
2361 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2362 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2363 and _IdDcmSWAP_LONG.
2365 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2366 * This corresponds to all the changes decided at the meeting of
2367 May 23 2002. Needless to say we are running late...