1 2005-04-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * FIX : on X, the python part is correctly installed. All files are
3 installed in gdcm sub-directory
5 2005-04-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * Builder/ : add something to facilitate the RPM creation of gdcm
8 2005-04-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
9 * Fix gdcmDirList::IsDirectory. Apparently borland did not like the ending
11 * Also fix compilation on gcc 3.3.5 does not have ios::failure either ...
13 2005-04-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
14 * vtk/vtkGdcmWriter fix bug when writing spacing. The Y spacing comes first
16 * Fix compilation on gcc 2.96 (which does not have ios::failure)
18 2005-04-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
19 * src/gdcmDictGroupName.[h|cxx] : add a correlation between a group (number)
20 and it's representation name (for the NIH)
22 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
24 conversion of YBR to RGB pixels. So, now, the conversion is made using
27 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
29 format) to replace 'at-run' dicom files generated by the
30 TestAllReadCompareDicom test
32 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
33 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
35 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
36 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
38 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
39 * Testing/TestMAkeIcon.cxx : complete the test
41 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
42 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memroy leaks
44 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
45 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
48 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
49 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
51 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
52 * Test/ : accelerate tests (it's not very significant accelerations).
53 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
55 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * Testing/TestSequence.cxx : add test for sequences of images... test that
57 we have the same serie or the same study UID
59 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
62 * src/gdcmDict.h : remove commented code
63 * src/gdcmDocument.cxx : initialize values
64 * src/gdcmFile.cxx : bug fix when reading values
65 * gdcmPython/demo/ : change file names. Remove useless files
67 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
68 * src/gdcmFile.cxx : remove the default array of initialization.
69 The static array contained pointers to non-static values (comming from
70 strings). To have coherences, when creating files, these values can't be
71 static. So, the array can't be static, too ! To simplify, the array have
72 been replaced by repeted lines to insert values in the File
74 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
75 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
76 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
78 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
79 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
80 (Dicom Element) into the Sequence Item
82 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
83 * src/*.cxx : first parss to normalize file organisation
85 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
86 * src/gdcmDirList.[h|cxx] : add method to find a directory
87 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
89 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
90 * Finish cleaning up my JPEG mess. Should be ok now.
91 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
92 contained within the RLE* class(doh!)
94 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
95 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
96 * SerieHeader::AddFileName() creates as many Coherent Files lists
97 (same Serie UID) as it founds different Serie UID
98 amongst the files instead of discarting any file
99 that doesn't match with the first one he found.
100 * SerieHeader::OrderGdcmFileList has now one parameter :
101 the Coherent Files list the user wants to sort
102 * SerieHeader::GetFirstCoherentFileList() |
103 * SerieHeader::GetLastCoherentFileList() | allow to parse
104 the set of Coherent Files lists
105 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
106 compatibility (it returns the *first* Coherent Files list,
107 since there was only one before)
108 * Test/TestSerieHeader gets gdcmData as a default root directory
110 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
111 * Remove friend between DocEntry and File classes
112 * Remove friend between PixelReadConverter and RLEFramesInfo,
115 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
116 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
117 0002|0000. The value was incorrect.
119 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
120 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
122 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
123 * src/gdcmUtil.cxx : compilation fix on Win32
124 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
125 variable, to be easy found. Add methods to change the default UID.
126 Amelioration of the CreateUniqueUID to use the correct default UID.
127 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
130 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
131 * Test/TestVR.cxx : fix memory leaks
133 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
134 * Rewrite the base 256 to base 10 conversion, using string operation only.
135 This allows us to get rid of the problematic 64bits integer type (does not
136 always exist on target platform).
138 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
139 * Add construct and destructor to class gdcm::Debug to close the debug file
141 * Don't let uset to open twice the same file
142 * gdcm has now an official UID prefix,
143 supplied by http://www.medicalconnections.co.uk
144 1.2.826.0.1.3680043.2.1143
145 (Thx to Mathieu for providing URL)
146 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
147 to be able to perform some more tests
148 * gdcm::ContentEntry : Contructors and Destructor are now protected,
149 in order to be sure no user will try to use them.
150 (at user level, only the children classes are meaningfull)
152 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
153 * move RLEInfo & JPEGInfo from Document to File
155 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
156 * FIX : remove so many friend between classes
158 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
159 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
160 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
162 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
163 In order to avoid missbehaviour :
164 . gdcm::DocEntry is now specialized in
165 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
166 - gdcm::ContentEntry (Dicom entry with a 'content')
167 . gdcm::ContentEntry is specialized in
168 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
169 characters value, or integers)
170 - gdcm::BinEntry (Dicom entry with a non strig representable value
171 (user hasn't any longer to thing about the precedence of his dynamic_casts)
173 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
174 * Test/VTKTest*.cxx : bug fix under linux
176 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
177 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
178 use with python. Some methods are moved from Document to ElementSet or
179 DocEntrySet. The equivalent methods to ElementSet have been added to
180 SQItem and are virtual in DocEntrySet. Methods that may have the same code
181 in SQItem and ElementSet is directly placed in DocEntrySet
183 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
184 * Test/VTKTest*.cxx : remove the show variable in each test method because
185 it's useless (the viewer variable replace this variable)
187 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
188 * src/gdcmDocument.cxx : bug fix on potential memory leak
189 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
190 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
191 Add ClearXxx methods to remove all the content of the list or map
192 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
194 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
195 * methods ReplaceOrCreate renamed as Insert
196 (nobody will be any longer confused by 'CreateOrReplace')
198 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
199 * Grealty simplify the JPEg decompression, no need to differenciate based on
200 the JPEG possible type (with/without fragment, with/without multiple frame).
201 Everything is done throught the JPEG IO Suspension mechanism in IJG
203 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
204 * Stage 3 of normalization :
205 in order to avoid any missunderstanding while reading method names :
206 - All the methods xxxEntry now deal with dicom Entries
207 - Methods GetEntry splitted into
210 - Method SetEntry renamed as SetEntryValue
211 - Method SetEntryBinArea let as it was
213 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
214 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
215 - Position correctly the entry points for JPEG2000 and JPEG-LS
216 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
218 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
219 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
220 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
221 with other method names
222 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
223 * Test/TestDicomDirElement.cxx : add new test
225 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
226 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
227 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
228 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
229 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
230 So can't you use __int64 in ostream at all.
232 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
233 * bug fix for compilation on MSVC6
234 * gdcmPython/gdcm.i : rename of classes missed
236 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
237 * Stage 2 of names normalization :
238 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
239 (easy to understand ...)
240 - gdcm::FileHelper replaces old class gdcm::File
242 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
243 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
244 type and not a string. So, there remove problems on the format of the
247 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
248 * Add Example/TestPapyrus.cxx
249 - reads a Papyrus file (gdcm::Header compliant),
250 - gets the pixels of all the images, using low level iterators
251 - writes an multiframes Dicom image.
252 (Just to show it's *possible* to do that)
253 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
256 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
257 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
258 Thus, DicomDirXXX are created with a flad that indicates if the created
259 object is empty or not (when not empty, the DicomDirElement is used to
262 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
263 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
264 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
266 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
267 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
269 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
270 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
271 Remove all access to the hash-tables or lists in the objects.
273 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
274 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
275 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
276 be complient with all the gdcm source code
278 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
279 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
282 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
283 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
286 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
287 * Test/ : rename VTK tests to have a best name for the tests
288 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
289 GetFirstEntry/GetNextEntry use
291 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
292 * In SerieHeader::ImagePositionPatientOrdering()
293 // a Dicom 'Serie' may contain scout views
294 // and images may have differents directions.
295 // -> More than one may have the same 'pos'
296 // Sorting has then NO meaning !
297 Thx to Eduardo Davila for reporting bug.
299 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
300 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
301 test. Now it's on image content and not on the resulting visualisation...
302 might solve the problem on linux when using the OpenGL drivers
304 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
305 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
306 DicomDirSerie, DicomDirImage
307 Dict, DictSet classes :
308 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
309 -remove InitTraversal method.
310 * UPD Test programs + Example programs
312 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
313 * remove useless and never updated keyword \ingroup
314 * Solve pb when structure (list, map, ...) is empty.
315 Thx to Benoit for reporting bug
317 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
318 * Taking into account of 'Transfer Syntax' value
319 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
322 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
323 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
324 is no memory access violation
325 * gdcmPython/demo : add python demos using VTK
327 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
328 * FIX 'Dictionnary' is now spelt 'Dictionary'
329 'wether' is now spelt 'whether'
330 'archieve' is now spelt 'archive' ;-)
332 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
333 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
334 related methods, in order not to expose internal mechanisms
337 * REM methods that exposed internal mechanisms :
338 DicomDir::GetDicomDirPatients()
339 DicomDirPatient::GetDicomDirStudies()
340 DicomDirStudy::GetDicomDirSeries()
341 DicomDirSerie::GetDicomDirImages()
342 * UPD Test programs :
346 * UPD Example program
348 * ADD DictSet methods
352 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
353 * Removed the Print/indent/default parameter mess. There is absolutely no
354 reason to have to methods, moreover with the second taking the ostream as
355 *SECOND* parameter. This was clearly a bad hack to get things compile.
357 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
358 * Complete rewrite of the GetMacAddress code. Now the code is *much*
359 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
360 Unfortunately the main code does not work on SunOS, thus provide a specific
361 code for this platform only (and Win32 of course). Since this seems to be
362 working, change CreateUniqueUID to use GetMACAddress instead of the
363 problematic GctestetIPAddress
365 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
366 * Unfortunately to be able to test gdcmDirList I had to break the API
367 a little. Now the class is not a std::list anymore but has a member
368 std::vector (more ITK compatible). Allow unit testing on Win32 and
371 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
372 * Update SerieHeader to take into account a Serie Instance UID to properly
375 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
376 * ENH - Comment out Mathieu's (dangerous) Super Hack
377 for dealing with BIGENDIAN processors
378 - Move equivalent stuff to BinEntry::WriteContent
379 When necessary, 16 Bits Pixels are swapped in a small buffer
380 and then written. This avoid allocating a huge buffer, in
381 PixelWriteConvertor, and avoid modifying the Pixel Area.
383 Probabely, the same operation will have to be done when we want
384 to write image with Big Endian Transfert Syntax,
385 and we are working on Little Endian Processor
387 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
388 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
390 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
391 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
392 all the dict content.
393 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
395 * Test/TestDict.cxx : add a new test for the dict classes
397 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
398 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
399 file. Debug is yanked if compiled with NDEBUG
401 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
402 * src/gdcmDictSet.h : set the default output to the os variable
403 * src/gdcmDictEntry.[h|cxx] : add the Print method
404 * gdcmPython/demo/ : add a new test
406 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
407 * merging of Test/PrintDicomDir and Test/TestDicomDir
408 * removal of now redundant Test/PrintDicomDir
409 * enhancement of Example/PrintDicomDir
411 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
412 * Now, python test might work on systems
413 * Add the PrintDicomDir test
415 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
416 * FIX : First entry following group 0002 was lost for
417 Explicit Big Endian Transfer Syntax files
418 (group and elem not swaped)
420 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
421 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
422 Big Endian Transfer Syntax supposed the group following 0002
423 begins always by element 0000 (element 0000 is *optional*)
424 To avoid further troubles, let's be pessimistic, and use
425 Document::HandleOutOfGroup0002() method
426 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
427 (related pb not yet solved)
429 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
430 * Bug fix for the python part use
431 * Now, PrintHeader.py pass... but outside the ctest use. shit !
433 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
434 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
436 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
437 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
438 a string and should ask the global TS dict what are the propreties of
441 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
442 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
443 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
444 to swap the Swap Code, at parsing time, when we come out of group 0002
445 and Transfer Syntax is Big Endian
446 We should be able to read now 'true DICOM" Big Endian coded images
447 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
448 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
450 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
451 * Hopefully fix the bug on MacOSX and static global initialization.
452 This is the only -minor- patch I found that both please MacOSX and VS6.
453 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
454 but this would require a lot of change. Another approach would be that Global
455 create those string and GDCM_UNFOUND becomes a pointer to a string (which
456 gdcm::Global would destroy at exit).
458 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
459 * Fix bug on MacOSX with static initialization in a multy threaded
460 environment. static const string in a header file used to be ill
461 initialized provoquing the freeze of any tests. patch should solve this
464 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
465 * According to Benoit's suggestion, and without any objection from anybody
466 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
467 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
468 - method gdcmDicomDirObject::GetEntry() renamed as
469 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
471 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
472 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
473 you debug/warning message just as c++ streams which make them very convinient
474 to use. Once this is stabilize I will change the ostringstrem to be
475 redirected to a file (ofstream).
476 * Properly support C99 extension: __FUNCTION__ which allow us to display
477 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
479 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
480 * Removal of useless and dangerous methods :
481 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
482 GetDocEntryByName, GetEntryByName, GetDictEntryByName
483 * Removal of usless methods :
484 Dict::PrintByName, Dict::GetDictEntryByName
485 * Commenting out of probabely useless methods :
486 Dict::GetDictEntryNames()
487 Dict::GetDictEntryNamesByCategory()
488 DictSet::GetPubDictEntryNames()
489 DictSet::GetPubDictEntryNamesByCategory()
490 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
491 * ENH : Use dicomTS.dic as described in 2004 version
492 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
493 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
494 Add Accessors on VM (Value Multiplicity), and VM related methods
495 * ADD : Add a list of 'Dicom Attribute types', as found in
496 http://medical.nema.org/dicom/2004/04_15PU.PDF
498 * ADD : Add dicomGroupNameAbbreviations.dic
499 should be used to write a method to replace the former
500 Dict::GetDictEntryNamesByCategory()
502 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
503 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
504 to read in the file... and only it ! Length is the efective length of the
505 data in the DocEntry structure
507 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
508 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
509 And now use a static function call instead, with a global variable. i
510 This is much closer to the VTK approach. Hopefully should be bulletproof
511 and easier to use...hopefully
513 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
514 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
516 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
517 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
519 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
520 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
521 ValEntry, BinEntry, SeqEntry creation or replace
523 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
524 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
525 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
527 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
528 when specifying the VR
529 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
530 * src/gdcmDocEntry.cxx : amelioration of print
532 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
533 * ADD : Add the method Util::IsCurrentProcessorBigEndian
534 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
535 * ADD Method Document::ComputeGroupLength
536 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
537 in order to allow further VR modification by user
538 * REM : removal of once-called method File::WriteBase
539 integration of its code in formerly one-line method File::Write
541 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
542 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
543 replace the different values "??", "Unkn", "Unknown".
544 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
545 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
546 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
547 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
549 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
550 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
552 * Set the gdcm::Base class to some Printable classes
554 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
555 * src/gdcmFile.[h|cxx] : add the Print method
556 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
557 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
558 * src/gdcmDocument.h : remove the PrintLevel informations
559 * Example/PrintFile.cxx : use the new gdcm::File::Print
561 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
562 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
563 problems when compiling with the python wrapping
565 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
566 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
567 writting in ImplicitVR
569 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
570 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
571 JPEG decompression, especially when dicom frames are split into several
572 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
573 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
575 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
576 * src/gdcmHeader.cxx : change the initialisation of default header.
577 Now, this header is readable by gdm, e-film, DicomWorks
579 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
580 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
581 Rename Decompressed to Raw
582 * Use the API changes in gdcm::File.
583 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
586 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
587 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
588 each added entry in the header. Replace the 'Planes' field by the 'Number
591 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
592 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
593 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
595 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
596 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
597 At this time, this image isn't readable by e-film... waiting JPR help to
600 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
601 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
602 DocEntry. Now use methods of the Document !
604 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
605 * Test/ShowDicomSeq.cxx : bug fix
607 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
608 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
609 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
610 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
611 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
613 * Test/TestCopyRescaleDicom.cxx : remove unused variable
614 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
615 containing found sequences
617 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
618 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
620 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
621 Some fields in BinEntry must be copied to not seg fault when making the :
622 gdcm::File *copy = new gdcm::File( copyH );
623 and tests are now made on good variables
625 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
626 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
627 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
629 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
630 * Add vtkGdcmWriter example and test
632 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
633 * Test/TestUtil.cxx : reformat the source code
634 * vtk/vtkGdcmReader.cxx : remove and change prints
635 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
637 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
638 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
640 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
641 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
642 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
644 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
645 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
646 by an eof to prevent all bad read of the file... and in this case, the
649 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
650 * Example/Volume2Dicom.cxx : comment unused variables
651 * Test/PrintDicomDir.cxx : comment unused variables
652 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
653 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
654 method that is redondant with AddEntry.
655 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
658 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
659 * Bug fix due my last commit (compilation under Windows).
660 * Example/Volume2Dicom : bug fix in the file and reformatting source code
661 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
663 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
665 - Remove printf / sprintf
666 - include iostream AFTER gdcm so we don't get warnings
667 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
669 - Also remove tons of include from header files, hopefully this should
670 speeup the compilation time, since it was becoming a dog slow.
671 - Remove gdcm.h as it include way too many files and slow down compilation
672 (plus it is not up to date)
673 - remove 'using namespace std' this is BAD !
675 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
676 * Remove memory leaks on the DicomDir
677 * Remove some useless data in DicomDirObject
678 * Add usefull methods in SQItem, to be complient withe the ElementSet
680 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
681 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
683 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
684 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
685 future, with convertion)
686 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
687 and ImageDataSize values. Remove the method to get the PixelReadConverter
688 from the output of the class
690 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
691 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
693 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
694 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
695 and vtkErrorMacro use.
696 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
698 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
699 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
701 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
702 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
703 The string leaves only in the fonction. So when we make a .c_str(), we
704 get the pointeur on the first element, element that will be destroyed
705 immediately after thee instruction.
706 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
707 file has been opened : the test must be made on the content of the
708 pointer and not directly on the pointer !
711 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
712 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
713 the python part recompiles
715 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
716 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
717 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
718 X session is killed (for my computer... it seems to not be identic on
721 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
722 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
723 avoid problems (otherwise, the difference test between the visible image
724 and the reference is incorrect. If the reference is greater than the
725 screen resolution, it's produce errors).
726 Can be used for only one image. Can be used with a visible flag.
727 * vtk/vtkGdcmReader.cxx : remove commented codes.
728 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
729 under windows at compilation
730 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
732 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
734 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
735 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
736 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
737 tests on the image size X, Y, Z
739 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
740 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
741 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
742 between the class name and the file name
744 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
745 * src/ : fix compilation warnings for the Write method (2 different
746 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
747 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
748 variable... create a static method in gdcm::Document to access to
749 this variable content.
751 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
752 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
753 file, to be accessed by other files (like gdcmFile). Remove commented
754 code. Move the change of the header to the gdcmFile, using the
756 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
757 To be sure of that (and simplify calls), the Write of the header now
758 gets a file name and not a file pointer (std::ifstream).
759 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
760 DocEntryArchive. Remove all open of the written file
762 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
763 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
765 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
766 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
767 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
769 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
770 some corresponding methods. Write correctly the file and check before
772 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
773 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
774 is now on RGB data (as before my last commit
775 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
777 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
778 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
779 Add a print information of the type of the entry
780 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
781 It was in the gdcmFile, and all write have been regrouped
782 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
783 Write correctly all dicom files (in decompressed mode only at this time)
784 * Test/ : test on files are now made using Raw data and not color data if
786 * Example/PrintFile.cxx : add more printings
788 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
789 * Amelioration of code, remove some code copy. For the loading of
790 BinEntry (in gdcmDocument), add the test to verify if the file is already
793 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
794 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
795 remove a DocEntry in the header (push an empty DocEntry)
796 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
797 lines. Bug fix in the initialization of the PixelConvert and the
799 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
800 use in TestCopyDicom (now this test can run under windows... but fails)
801 * Test/TestCopyDicom.cxx : amelioration of the test :
802 - test the pixels written
803 - add test points to quickly find where is the error
804 - can set a file name input and output in arguments
805 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
806 amelioration of the test output
808 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
809 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
810 all replaced DocEntry's
811 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
812 Now, each needed DocEntry to modify is duplicated, modified and inserted
813 to the header using DocEntryArchive. Thus, after save, we can restore the
814 header initial state.
816 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
817 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
819 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
820 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
821 correct to copy it. The DictEntry is specified at the DocEntry creation,
822 then, it musn't change in the time.
823 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
824 header correctly. At this time, the change is only made for the first
825 level of the Document. In the future, it might consider sequences.
826 The change is made by replacing a DocEntry by an other that is created
827 outside the class. The old value is kept. When we restore the header
828 status, the added DocEntry is deleted and replaced by the old value.
829 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
830 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
831 set the write type to explicit VR, implicit VR or ACR. Add methods to set
832 the write mode to native, decompressed or RGB (but not used at this time)
834 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
835 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
836 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
838 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
839 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
840 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
842 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
843 set because already copied when copying the BinEntry's of the header
844 * Test/TestAllReadCompareDicom.cxx : remove warnings
846 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
847 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
848 Two problems appear when doing it :
849 - with the gdcmFile : when the GetImageData method is called, the pixels
850 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
851 data (pixels). And each structure destruct the data when it's
852 destructed. So we have two destructions for the same data. To solve it,
853 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
854 data or not. If it doesn't own data, then they will not destroyed by
856 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
857 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
858 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
859 create a double destruction of the same DocEntry's. So, to solve it,
860 the TagHT is simply cleared and the DicomDir* elements are destroyed.
861 * TODO : add an entry concerning memory leaks in the DicomDir
863 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
864 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
865 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
868 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
869 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
870 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
871 after it have been deleted
873 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
874 * FIX: src/* fix the doxygen warnings.
875 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
876 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
877 was erroneously defined with a size of 15 instead of 16. [many thanks
878 to Jean Michel Rouet for pointing out this bug].
880 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
881 1. Finish merging JMR patch for writting DICOM from scratch
882 2. Fix -hopefully- bug with MONOCHROME and space vs null character
883 3. Use const ref when possible
884 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
885 5. A few more comments
886 6. CreateUniqueUID can now be called without parameter"
888 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
889 * ENH: Slightly bigger patch:
890 1. Getting toward full integration of JMR patch for writting dicom from scratch
891 2. Update Test to test part of this patch: CreateUniqueUID
892 3. File was not close properly in gdcmDict
893 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
894 5. Use of const ref instead of copy (speed issue)
895 6. Remove temporary (duplicate) string in TranslateToKey
896 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
897 8. Do not repeat virtual in subclasses
898 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
900 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
901 * Apply first patch toward better string comparison when dealing with broken
902 DICOM files. Essentially the string could be padded with a space instead
903 of a null character as defined by standard
905 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
906 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
907 because never used... and in the same time, that's remove some memory leaks
909 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
910 * src/gdcmFile.cxx : now delete the PixelConvert instance.
911 * In examples and tests : change the type of image data variables from void*
912 to uint8_t*. Remmove all delete on image data variables
914 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
915 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
916 Verify the file pointer value before open the file, and if it's not null,
917 a verbose message is generated.
918 Close correctly the file when the file isn't considered dicom-like. The
919 correctly close is a call to CloseFile.
920 When closing the file pointer, test if its not null to close the file.
921 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
922 file. For an uncompressed image, the copied data correspond in the least
923 case to the image size (calculated) or the image size specified in the
924 header. A verbose is generated if these two size mismatch
926 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
927 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
928 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
929 break under windows (with msvc6 compilation).
931 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
932 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
933 compiling with MSVC6)
935 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
936 * Bugs fix for the Windows build with VC6
937 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
938 needed (only for projects required VTK). If the VTK is included in all
939 projects, there is conflicts with the jpeg lib of vtk when compiling the
940 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
941 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
942 when compiling the gdcm_wrap.cxx file (created by the compilation of the
944 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
945 (like it's already made for the cout use). Otherwise, conflict with the
948 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
949 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
951 - comments on the DicomDir::Method related usage added.
952 - now that we use the namespace gdcm, a lot of internal classes do
953 NOT need to be wrapped anymore.
954 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
955 DicomDir::Method) new example added.
957 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
958 * Improve string manipulation. I now inforce the notion of 'DicomString'
959 A DicomString can contain as many \0 as they want
960 and it is *always* of even length.
961 We only support odd length for very rare case.
962 And in the near future this should be removed.
964 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
965 * /binary_write/ gdcm source. Now even on big endian we are writting
966 little endian. This should -heopfully- fix some tests
968 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
969 * Now the dictionary is compiled into gdcm lib. This is a default
970 behavior, thus any dic file specified is picked before failback to
971 the one comiled into lib
973 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
974 * Change internals for gdcmDict. Don't use any 'new' any more.
975 This should definitely solve any leak problem, and we should be
976 as fast as before, as long as don't modify too much the dictionary.
978 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
979 * STYLE: ivars should start with a capital letter.
980 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
981 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
983 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
984 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
985 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
986 new 2004 dictionaries added (thanks to JPR).
987 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
988 * CLEANUP_ROUND (15) for gdcmPixelConvert
989 - RLEFrame::NumberFragments is now of type unsigned int
990 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
991 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
994 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
995 * Initial work in gathering all transfer syntax accessors. clearly
996 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
997 ivars, but only one transfersyntax (class) ivar with equivalent method on
1000 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1001 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
1002 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
1003 discussed (plus I didn't like having a 2000 lines patch not commited)
1005 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1006 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
1007 * CLEANUP_ROUND (14) for gdcmPixelConvert
1008 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
1009 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
1010 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
1011 CloseFile() anymore.
1012 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
1013 anymore and hence avoids storing a copy of PixelConvert::Decompressed
1014 into File::Pixel_Data.
1016 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1017 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
1018 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
1019 * CLEANUP_ROUND (13) for gdcmPixelConvert
1020 Substituted File::ParsePixelData() with PixelConvert::Print() new
1022 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1023 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1024 method to those classes.
1025 - src/gdcmFile.[cxx|h]:
1026 -- Added a ::Print() method.
1027 -- PixelConverter is now a reference instead of a member.
1028 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1029 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1031 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1032 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1033 collaboration diagram and inheritance diagram should be generated with
1035 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1036 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1037 pointlessly wrapped (see
1038 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1039 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1040 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1041 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1042 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1043 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1044 -- File::Initialise: PixelConverter setup moved away to
1045 PixelConverter::GrabInformationsFromHeader()
1046 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1047 interpretation moved away to PixelConverter::BuildRGBImage()
1049 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1050 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1051 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1053 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1054 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1055 displayed on Win32 when a brutal abort() occurs (because of uncatched
1056 exception). See TODO new entry of this commit for more on this.
1057 * TODO added new entry.
1058 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1059 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1060 - HandleColor is no longer called from gdcmFile.cxx
1061 - gdcmPixelConvert.cxx clean up on method arguments and internal
1062 variable names for semantical coherence.
1064 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1065 * Finished lossless transition, not only do we now read all lossless jpeg
1066 images, without the need of the Cornwell lib, but we do read them properly now
1067 * To reduce code (well to avoid code duplication), I defined a common place
1068 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1069 redefine symbols. This is not perfect but this the best solution I found for a
1070 compilation time jpeg option.
1072 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1073 * Update jpeg ijg lib to support lossless jpeg implementation
1074 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1076 * Also added a special copyright for dcmtk since we use their bugfixes.
1079 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1080 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1081 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1082 matters, as stated in warning note at beginning of %include section).
1083 * src/gdcmDicomDir*.[cxx|h]: coding style
1084 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1085 * src/gdcmJpeg8.cxx: doxygen fix.
1086 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1087 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1088 from File:: to PixelConvert::.
1090 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1091 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1092 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1093 - more code moved away from File:: to PixelConvert::
1094 - fat setup of PixelConverter set in place in File::Initialise.
1096 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1097 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1098 namespace at the file system level. So now you should convert your examples
1100 gdcmHeader -> gdcm::Header
1101 It would be nice if people keep in mind to no open the namespace, since it
1102 allows compilation on broken plateform which were defining common symbol in
1103 the standart namespace (like LP, Unknown ...)
1105 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1106 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1107 The JPEG fragments are now parsed at the same stage than the RLE
1108 information. All code related to JPEG is now in gdcmPixelConvert:
1109 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1110 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1111 export a gdcmFile:: method. Those are simply global functions
1112 (for the time being this is better than having them attach to
1113 either gdcmFile:: or gdcmPixelConvert::).
1114 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1115 and stores the result in a gdcmJPEGFragmentsInfo.
1116 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1117 code (among other stuff) moved away from gdcmFile:; to
1120 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1121 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1122 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1123 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1124 clean up of RLE related code.
1125 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1126 - src/gdcmRLE.cxx removed
1127 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1128 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1129 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1130 * CLEANUP_ROUND (9) for gdcmPixelConvert
1131 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1132 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1133 away from gdcmFile:: to gdcmPixelConvert::.
1135 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1136 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1137 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1138 This is because Parse7Fe0 used to parse the pixels to compute the
1139 length. This task was passed over to FindDocEntryLengthOB() a long
1140 time ago, EXCEPT I had forgotten the OW case...
1141 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1142 we just recylce the code for parsing RLE fragments and computing
1144 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1145 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1146 with the retired Parse7Fe0().
1147 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1148 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1150 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1151 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1152 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1153 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1154 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1155 * CLEANUP_ROUND (4) for gdcmPixelConvert
1156 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1157 to return an unused length.
1159 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1160 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1161 this should be cleanner from the plane view. The iostream are erally a pain
1162 to use to do simple stuff.
1164 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1165 * Redo the compilation of the ijg jpeg library. Now only one source is
1166 necesseray. No need to rename file by hand what so ever. CMake handle the
1167 copying of the file within different directory, configure header file to
1168 modify some symbol. The only addition made to ijg wasd a mangle table so
1169 that symbol are different whether we are within 8bits or 12bits.
1171 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1172 * Added documentation of vtkgdcmReader on Website:
1173 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1174 with it's binary name).
1175 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1176 the Website to be more complete.
1177 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1178 doxygenated documentation.
1179 - Doc/DoxyVtkGdcmReaderExamples.txt added
1180 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1181 DoxyVtkGdmReaderExamples.html )
1182 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1183 * CLEANUP_ROUND (3) for gdcmPixelConvert
1184 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1186 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1187 * CLEANUP_ROUND (2) for gdcmPixelConvert
1188 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1190 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1191 * CLEANUP_ROUND for gdcmPixelConvert:
1192 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1193 - src/gdcmPixelStuff[h|cxx] removed
1194 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1195 - src/CMakeLists.txt changed accordingly
1196 * GDCMHOME clean up:
1197 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1198 gdcmVersion.py moved to newly created ATTIC related
1199 gdcmPython/SetupOldies/ directory.
1200 * Autotools clean up:
1201 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1202 - autogen.sh configure.in acinclude.m4 python.m4 removed
1204 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1205 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1206 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1207 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1209 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1210 * TODO updated with Mathieu suggestions. I proposed a template for
1211 describing TODO entries and used it for new entries.
1212 * Added Doc/Website/CodingStyle.html, Developpers.html,
1213 DeveloppersPython.html, GdcmDataCvs.html and
1214 DownloadVersion0_1.html, DownloadVersion0_3.html.
1215 * Some Doc/*.txt Doxygen files (which do not really concern the
1216 documentation itself, but the website) moved to html and
1217 placed in directory Doc/Website:
1218 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1219 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1220 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1221 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1222 * CMakeLists.txt changed accordingly.
1223 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1224 DeveloppersPython.html
1225 * INSTALL nows refers to Doc/Website/Installation.html
1227 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1228 * Added Doc/Website directory, that contains a first raw version
1231 2004-09-23 Jean-Pierre Roux
1232 * FIX In order not to be poluted any longer by casting problems,
1233 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1234 we can now delete[] it safely
1235 * VoidArea is now called BinArea (less confusing name),
1236 and all the methods called ...VoidArea... are now ... BinArea...
1237 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1239 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1240 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1241 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1242 up to the destructor of gdcmElementSet to clean up TagHt and it's
1245 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1246 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1247 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1249 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1250 * ENH: added some utility method that builds a flat dictionary
1251 holding all the Dicom entries contained in the recursive structure
1252 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1253 an example of usage.
1254 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1255 BuildFlatHashTable() that build a flat dictionary.
1256 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1257 gdcmDocument is now a friend of gdcmElementSet.
1258 - src/gdcmElementSet.cxx: clean up.
1259 - Example/FlatHashTablePrint.cxx added.
1260 - Example/CmakeLists.txt changed accordingly
1262 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1263 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1264 moved away from gdcmDocEntrySet (since this class is an abstract class
1265 acting like an interface). SQDepthLevel and BaseTagKey are now
1267 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1268 and associated accessors. Doxygenation of the class.
1269 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1271 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1272 Use SQDepthLevel accessor instead. ::Print() adapted.
1273 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1274 - src/gdcmDocument.cxx changed accordingly.
1276 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1277 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1278 - The following is the doxygen comment of the typedef declaration
1279 of gdcmTagKey in src/gdcmCommon.h:
1280 gdcmTagKey is made to old an "universal" (as in URL, Universal
1281 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1282 A dicom tag always has a group and an element, but a set of tags
1283 embeded in various (optionally nested) sequences and sharing
1284 the same group and element all share the same (group, element)
1285 "identifier". Hence the (group, element) cannot be used as an
1286 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1287 In order to construct a proper tag identifier (i.e. a key) we
1288 consider the following definition of a TagKey:
1289 - let Group, Element be the string representation of the
1290 group and element dicom tag members,
1291 - let ItemNumber be the string representation of the integer
1292 index of the considered item number of a sequence,
1293 Let the key of a tag embeded in a sequence, noted SeqTag, be
1295 /ItemNumber#Group|Element
1296 where "/", "#" and "|" are characters acting as separators.
1297 Then the general form of a gdcmTagKey is given by:
1298 Group|Element<SeqTag>
1299 where <SeqTag> means NO or many instances of SeqTag.
1300 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1303 but the gdcmTagKey of a tag "embeded" is the first item of
1304 a sequence, itself nested in the third item of a sequence is the
1306 0004|1220/2#0008|0082/0#0008|0090
1307 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1308 order to hold the new sequence compatible key. Previously, the
1309 GetKey() method would look in the underlying gdcmDictEntry.
1310 - src/gdcmDocEntry.cxx:
1311 -- constructor now copies the underlying DictEntry key, in the local
1313 -- ::Print: displays the member Key, instead of the (group, element).
1314 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1315 - src/gdcmDocEntrySet.h:xi
1316 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1317 -- now has a new BaseTagKey member.
1319 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1320 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1322 This poses the problem with the semantics of the following lines
1323 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1324 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1325 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1326 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1327 to the long FIXME note for what the problem is. Nevertheless in
1328 order to get things working the dicom dictionary was altered !
1329 Please fix things urgently...
1330 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1331 information), see above note on moving the member VoidArea. Nevertheless
1332 the following entries previously correctly set as US are now inproperly
1334 0028 1201 OW IMG Red Palette Color Lookup Table Data
1335 0028 1202 OW IMG Green Palette Color Lookup Table Data
1336 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1337 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1338 of gdcmDocEntry moved to gdcmSeqEntry.
1339 * src/gdcmSeqEntry.cxx: STYLE.
1341 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1342 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1344 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1345 * gdcmPython/testSuite.py: all the test suite in python is now moved
1346 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1347 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1348 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1350 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1351 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1352 to avoid inclusion recursion until STL is reached.
1353 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1354 mecanism. errno.h is not included in gdcm anymore.
1355 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1356 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1358 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1359 gdcmData/TestAllEntryVerifyReference.txt
1360 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1361 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1362 exception_on_error parameter.
1363 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1364 - vtk/vtkGdcmReader.cxx changed accordingly,
1365 - Example/*.cxx and Test/*.cxx changed accordingly.
1367 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1368 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1369 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1370 enable_sequences removed from gdcmHeader constructor and dependencies.
1371 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1372 * gdcmPython/demo/PrintHeader.py: dummy fix.
1373 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1374 skip_shadow removed from gdcmHeader constructor and dependencies.
1375 * Example/*.cxx and Test/*.cxx changed accordingly.
1377 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1378 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1379 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1381 2004-07-21 Jean-Pierre Roux
1382 * FIX Now, Parsing and Printing a DICOMDIR do work!
1383 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1385 2004-07-20 Jean-Pierre Roux
1386 * FIX Some brain damaged headers have Zero-Lenght fields
1387 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1389 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1390 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1391 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1392 variable (instance of gdcmDebug) by a definition macro, and the instance
1393 is now in static in the gdcmDebug class
1394 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1395 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1397 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1398 * WARNING: ctest now depends more tightly on gdcmData. You should
1399 check out gdcmData properly for things to run smoothly...
1400 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1401 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1402 we need the pixels not be loaded in order to use the ValEntry
1403 that displays position and size).
1404 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1405 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1406 be deprecated. If you have any doubts about the advantages of a
1407 modern scripting language (read Python) versus grass root C++ (i.e.
1408 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1409 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1410 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1411 Anyhow, consider documenting the gdcmData images in
1412 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1414 * Test/CMakeLists.txt:
1415 - now uses TestAllEntryVerify.cxx
1416 - specific comments on oldACR00001.ima (now renamed in gdcmData
1417 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1418 gdcmData/TestAllEntryVerifyReference.txt
1421 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1422 * src/*.[h|cxx] : typedef clean up
1423 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1424 - TagKey renamed to gdcmTagKey (for external usage)
1425 - VRKey renamed to gdcmVRKey (for external usage)
1426 - removal of typedef duplication.
1427 - Removed all unecessary inline keyword from class inline definitions.
1428 - Some method|function(void) declarations replaced with method|function().
1429 * src/jpeg/libijg12/jdhuff12.c:
1430 - printf polluting ctest removed.
1431 - TAB removal for comminting
1433 - TestAllReadCompareDicom.cxx: added a test that compares all the
1434 images in gdcmDataImages.h with corresponding images in
1435 gdcmData/BaselineDicom/. When baseline images are not present
1436 this test creates them.
1437 Note: we need to validate each reference image, but before that
1438 I'd like to rename them with a more explicit name...
1439 - CMakeLists.txt: changed accordingly.
1440 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1441 including each header needed).
1443 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1444 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1445 test suite to the Example directory. Are concerned:
1450 - TestWriteSimple.cxx
1451 * Test/CMakeLists.txt: added some comments on reasons for black listing
1452 image gdcmData/oldACR00001.ima
1454 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1455 * Test/CmakeList.txt: removed the following from black list (to be coherent
1456 with removal from gdcmData):
1457 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1458 - gdcm-MR-PHILIPS-16.dcm
1460 Added the following because after last cvs update, they cause
1461 ctest -R TestReadWriteReadCompare
1463 - gdcm-MR-SIEMENS-16-1.acr
1465 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1466 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1467 new comments in this file) we temporarily (sigh) move to a weaker
1469 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1470 we don't need to black list the following images anymore:
1471 - 8BitsUncompressedColor.dcm
1473 - US-PAL-8-10x-echo.dcm
1474 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1475 fixes and the beautified code ;-)
1476 This fixes the bug introduced in version 1.42 (when beautifying)
1477 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1478 Note: ctest was blind to this bug (this means we need to still
1479 improve the test suite). The bug could be detected by using
1480 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1482 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1483 and by displaying the (garbage) produced file temp.XDCM...
1485 2004-06-29 Jean-Pierre Roux
1486 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1487 - replace by uggly but working old code :-(
1488 A lot of things should be OK again.
1489 It's really urgent to have a test suite that *tests*,
1490 to prevent Frog's beautifying sessions to break all the stuff
1491 (twice, withing a fortnigh ...)
1493 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1494 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1495 redundancy) to added Test/TestReadWriteReadCompare.cxx
1496 * Test/CmakeList.txt: because the compare test of
1497 Test/TestReadWriteReadCompare.cxx fails, the following images are
1498 black listed: - 8BitsUncompressedColor.dcm
1500 - US-PAL-8-10x-echo.dcm
1501 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1502 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1503 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1504 and ad-hoc kludge. This kludge is now removed, and on encountering
1505 such an image (OB field brain damaged) we set errno. Then in
1506 ::FindDocLength() we "fix" the length as being ALL what remains
1507 in the file (until EOF). We then proceed, hoping for the best...
1508 This fixes a SegFault in ShowDicom when trying to write such an
1510 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1511 (because TestWriteRead breaks on it, after a non conformal commit?).
1512 ctest now runs properly, except for MakeDicomDir (which was always
1513 broken) and the Python related stuff (still not fixed).
1515 2004-06-24 Jean-Pierre Roux
1516 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1517 FIX : Test/TestReadWrite now iterates on all the file names
1518 (instead of infinite loop)
1519 ENH : Test/TestWriteRead now iterates on all the file names
1521 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1522 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1524 2004-06-24 Jean-Pierre Roux
1525 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1526 when SamplesPerPixel =3
1527 - now Write is no longer confused by
1528 'BitsAllocated = 12" and 'BitsStored=12"
1529 - "UN" value representation Elements are now written correctly
1530 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1531 ENH : - now gdcmHeader has its own Write methods
1532 (in order to split the job that has not to be done
1535 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1536 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1537 loop on the same image until memory went out.
1538 Note: this means we still have gobs of memory loss in PrintDocument
1539 * src/gdcmDocument.cxx: fixes problem on parsing on file
1540 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1542 2004-06-24 Jean-Pierre Roux
1543 FIX : Write - All the Sequences and Sequence Item are now written
1544 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1545 is added a the end, when necessary.
1546 - A lot of brain-damaged images, that were read correctly are
1547 now written correctly
1548 - length compatible BinEntry are now loaded correctly
1549 (even for odd groups)
1550 Note : only Explicit Value Representation was checked.
1551 (question : is implicit VR really necessary for gdcm ?)
1553 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1554 * DEVELOPPER: added a proposition of coding style.
1555 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1558 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1559 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1560 Use the gdcmDocEntry::Print() and Write() instead.
1561 * src/gdcmDocument.cxx: bug fix.
1563 2004-06-22 Jean-Pierre Roux
1564 FIX : gdcmDocument.cxx
1565 - Now we do recognize the JpegLossLess format (there was a misstyping in
1566 code 'beautyfication' :-(
1567 - Now we automaticaticaly load the Luts, if any
1569 2004-06-22 Jean-Pierre Roux
1570 In order : to write Sequences, whatever their imbrication level,
1571 : to allow user to create his own Sequences
1572 a lot of modif where necessary (adding, moving, or virtualising methods)
1574 WARNING : save your own sources *before* cvs up !
1577 ADD virtual void Write(FILE *fp, FileType filetype);
1580 ADD virtual void Write(FILE *fp, FileType filetype);
1581 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1584 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1585 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1586 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1587 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1588 ADD std::string GetEntryByName(TagName name);
1589 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1591 std::string vr = "unkn",
1592 std::string fourth = "unkn",
1593 std::string name = "unkn");
1594 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1595 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1596 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1597 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1598 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1599 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1600 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1601 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1604 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1605 ADD virtual std::string GetEntryByName (TagName tagName);
1606 ADD virtual std::string GetEntryVRByName (TagName tagName);
1607 REM virtual bool Write(FILE *, FileType);
1608 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1609 FILE *_fp, FileType type);
1610 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1611 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1612 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1613 REM virtual std::string GetEntryByName (std::string tagName);
1614 REM virtual std::string GetEntryVRByName (std::string tagName);
1615 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1616 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1617 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1619 std::string vr = "unkn",
1620 std::string fourth = "unkn",
1621 std::string name = "unkn");
1622 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1623 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1624 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1625 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1628 ADD virtual void Write(FILE *fp, FileType filetype);
1631 ADD virtual void Write(FILE *fp,FileType filetype);
1634 ADD virtual void Write(FILE *fp, FileType filetype);
1635 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1636 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1637 REM std::string GetEntryByName(TagName name);
1640 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1642 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1643 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1644 The default constructor invoked by the line
1645 gdcmHeader *f1 = new gdcmHeader( header );
1646 was gdcmHeader::gdcmHeader(bool) instead of the expected
1647 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1648 Hence the parsing wasn't executed... See also below.
1649 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1650 as explicit constructor didn't do the trick to fix the above problem.
1651 Could anyone explain why ?
1652 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1653 properly calls gdcmValEntry::Print() (that was weed out from
1654 code related to gdcmBinEntry).
1656 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1657 * In order to fix memory leaks:
1658 - Test/TestWriteSimple.cxx: added cleaning of free store through
1660 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1661 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1662 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1663 (through the call to ::AddDicomDirMeta()) or the destructor
1664 would crash when deleting uninitialized ::metaElems].
1665 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1666 - src/gdcmDocument.cxx:
1667 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1668 from dynamic stores.
1669 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1670 was causing memory leaks.
1671 - src/gdcmSQItem.cxx:
1672 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1673 cleanly handled with polymophism: sorry but my milage is low).
1674 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1675 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1676 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1677 This avoids SegFaulting.
1678 - src/gdcmSQItem.h: coding style.
1680 - Test/TestWriteSimple still severely sucks. The output image content
1681 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1682 damaged when displayed with vtkgdcmViewer.
1683 - on memory leaks: TestWriteSimple leaks really less (see entry
1684 of 2004-06-18 in Changelog file for the call to valgrind).
1685 - on segfaults: ctest now passes all the tests but one (no more
1687 * Erroneous leading white fix:
1688 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1689 white[s] (as opposed to from >> xxx, that removes it [them].
1690 - src/gdcmTS.cxx: ditto.
1691 - gdcmPython/testSuite.py: dirty related kludge removed.
1692 * src/*: remaining references to gdcmParser removed.
1693 * src/*[cxx|h]: added copy[way]left header.
1696 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1697 * In order to fix writing of dicom files:
1698 - Test/TestWriteSimple.cxx: a simpler example of writing.
1699 - Test/CMakeLists.txt changed accordingly.
1700 - src/gdcmDocument.cxx:
1701 -- The destructor now recursilvely removes potential sequences.
1702 -- Bug fix in ::IsJPEG2000()
1703 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1704 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1706 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1707 to only declared) and build on top of
1708 ::GetDocEntryByNumber(guint16, guint16).
1709 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1710 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1711 for usage in destructor and treatement of promotion in
1712 ::ReplaceOrCreateByNumber().
1713 - src/gdcmSQItem.cxx: destructor should better handle his job.
1714 Test/TestWriteSimple now runs (or at least it DOES something).
1715 * We can now start hutting memory links. A good starting point is:
1716 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1717 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1718 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1720 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1721 * Valgrind note: after Mathieu Malaterre teached me how to read
1722 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1724 Using gcc, you can force the STL to use malloc and to free memory as
1725 soon as possible by globally disabling memory caching.
1726 With 3.2.2 and later, you should export the environment variable
1727 GLIBCPP_FORCE_NEW before running your program.
1728 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1729 simply vanish (it is still not clear to me, whether this means that
1730 STL std::string leaks or if valgrind believes it leaks...).
1731 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1732 running bin/gdcmTests makeDicomDir):
1733 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1734 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1736 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1737 SegFaulting (I drowned in DicomDir related code when trying to
1738 understand why the list is empty...).
1739 * src/gdcmDocument.h: first BSD license header try.
1740 * Doc/License.txt added.
1742 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1743 * src/gdcmDocument.[h|cxx]:
1744 - Clean up of the Transfer related predicates. They are now all based
1745 on new method isGivenTransferSyntax, that (should) handle properly
1746 the padding problem.
1747 - general clean up, simplification, and coding style.
1748 - Specific clean up of Parse7FE0() (umproperly named actually).
1749 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1751 2004-06-14 Jean-Pierre Roux
1753 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1754 - fix the display of SQItem ordinal number
1755 - add the GetSQItemByOrdinalNumber method
1756 - remove some useless never written private methods
1758 2004-06-14 Jean-Pierre Roux
1760 - adding a constructor taking a gdcmDocEntry as an input param
1761 - ReplaceOrCreateByNumber now returns :
1762 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1763 a gdcmValEntry * if a string value is passed as a param
1765 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1766 according to the param type (no longer sets a gdcmDocEntry)
1767 - GetValEntryByNumber, GetBinEntryByNumber added
1768 - NewValEntryByNumber and NewBinEntryByNumber added
1770 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1772 - GetSQItemNumber and SetSQItemNumber added, to provide
1773 a (relative) Item identier inside a given Sequence
1774 \warning : some pb remaining around this number
1776 - AddEntry now takes the Item Number as a param
1778 - adding a constructor taking a gdcmDocEntry as an input param
1780 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1781 * Memory leak hunt with the following command:
1782 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1783 --show-reachable=yes gdcmTests PrintDocument
1784 It looks like many (all?) leaks are due to the STL (or a bad usage
1785 of the STL. The lines producing the leaks now have a comment with
1786 a "MEMORY LEAK" tag: you can retrieve them with
1787 grep "MEMORY LEAK" src/*
1788 Here are two typical examples which I can't help fixing:
1793 char * test = "babo";
1794 name = test; //// <--- valgrind detects 960 bytes lost in
1795 //// call to std::string::operator=(char const*)
1796 name.clear(); //// Doesn't help !
1804 std::cout << "Type a bunch of characters followed by RETURN: ";
1805 getline(std::cin, line); //// <--- valgrind dectects a loss
1806 //// of 1320 bytes in call to
1807 /// std::basic_istream<>& std::getline<>
1813 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1814 * src/gdcmHeader.[cxx|h]:
1815 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1816 and related, moved away to gdcmDocument.
1817 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1818 the corresponding protected accessors of inherited class
1819 gdcmDocument, removed ! As a consequence gdcmFile had to be
1820 declared friend of class gdcmDocument (see below).
1821 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1822 - Clean up of undefined or unused methods.
1823 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1824 account the changes to gdcmHeader.h).
1825 * src/gdcmDocument.h:
1826 - gdcmFile is now a friend class (in order to take into account the
1827 changes to gdcmHeader.h).
1828 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1829 (see changes to gdcmHeader.h).
1830 - Accessors (reading on the form GetEntry*) are now public.
1831 - Clean up of undefined or unused methods.
1832 * src/gdcmDocument.cxx:
1833 - adaptation to changes to gdcmDocument.h
1834 - ::OpenFile now writes a verbose message when file cannot be opened.
1835 - some std::string properly set to VRKey
1836 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1837 references to gdcmDocument.
1838 * Test/TestFindTags.cxx: changed accordingly to above changes.
1839 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1840 cvs repository gdcmData.
1842 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1843 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1844 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1845 conflicts with gdcmValEntry::voidArea.
1846 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1847 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1848 Value representation between StringRepresentable and BinaryRepresentable.
1849 * src/gdcmDocument.cxx:
1850 - method ParseDES: proper indentation restored and usage of
1851 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1852 - method LoadDocEntry: the fingerprint left in the SetValue() of
1853 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1854 removed. Reverting to previous code segment with the proper
1855 dynamic_cast< gdcmValEntry* >.
1856 Note: this was (partially) breaking the python test suite
1857 (gdcmPython/testSuite.py) that made usage of the above
1858 fingerprint to check presence of "Pixel Data".
1859 * src/gdcmDocEntry.h: coding style.
1860 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1861 now taken into account.
1862 * gdcmPython/gdcm.i: adaptation to the new internal representation
1863 of gdcm (exit gdcmParser, hello gdcmDocument).
1864 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1866 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1867 anymore, but instead prints the loaded Python dictionary.
1868 * .... alas, the python testSuite is still broken.
1870 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1871 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1873 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1874 * src/gdcmUtil.h : export methods
1876 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1877 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1879 * Initial addition of automatic python testing
1880 * Initial addition of automatic image comparison
1882 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1883 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1884 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1886 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1887 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1888 * Test/ShowDicom.cxx : bug fix for msvc compilation
1889 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1891 2004-05-04 Jean-Pierre Roux
1892 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1893 new concepts (and new classes) :
1894 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1895 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1896 - Sequence Doc Entries (gdcmSeqEntries)
1897 a Sequence is composed of Items.
1898 Each item is a set of Doc Entries (this is recursive)
1899 The non uniqueness of the 'Dicom tag' is due to this recursivity
1900 (never taken into account)
1901 Our unability to add a new 'entry' in the header
1902 at the proper location (neither in the H-Table (map or multimap),
1903 nor in the Chained List is also due to this recursivity.
1904 Don't try, right now, to use/modify/compile these new sources :
1905 nothing is finished.
1906 We just commit all the stuff, 'as is', in order not to loose it.
1908 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1909 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1911 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1912 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1913 file prefix (SetFilePrefix)
1915 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1916 * Add a new test: ShowDicom, for now this is just the c++ version of
1917 checkRead.sh, later it will be able to compare the image read against a
1919 * Replace the DEBUG on the stack with a global entry in cmake interface:
1920 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1922 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1923 * Add an example subdir, with a real example on how to read + write a
1926 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1927 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1928 * Doc/CMakeLists.txt: the main page is now properly differentiated
1929 between the developper and user version.
1930 * Doc/doxygen.config.in: dropped search related obsolete flags
1931 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1933 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1934 * DEVELOPPER: added some helpfull comments for compile/test/install
1937 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1938 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1939 src directory, now generated in the build dir.
1940 2. Tests as mentionned smarter
1942 4. Add a new method in gdcmDict that return the PubDict by name
1943 this is interesting for 3rd party lib like ITK,
1944 where we could set the institution name / patient name...
1946 * ENH: 1. Now the test suite is working for real
1947 2. All binaries are now output in the gdcm-bin directory
1948 (this was not true before)
1950 2004-04-28 Jean-Pierre Roux
1951 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1952 SeQuence indented printing of Dicom Header.
1953 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1954 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1955 Computation of SQDepthLevel is now part of gdcmHeader constructor
1956 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1957 tree-like structure of a Dicom Header.
1958 * FIX Test code cleaning
1960 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1961 * ENH: Adding automatic testing
1962 1. Need a DartConfig.cmake to submit to public
1963 2. Add a test driver gdcmTest.cxx
1964 3. gdcmTestMain, an helper for the main test driver gdcmTest
1965 4. Files in Test don't have a main anymore, this becomes interesting
1966 when we add more and more tests, thus dsw don't have to load
1968 * ENH: Adding a GDCM_DATA_ROOT for testing
1969 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1970 one file instead of seven + some small cleanup
1972 2004-04-22 Jean-Pierre Roux
1973 * ENH Minor changes to the Print() methods.
1974 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1975 Header printing. Example given with :
1976 > PrintHeader fileName 2 new
1977 (SQ based tree-like structure still to be done for the Header ...)
1979 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1980 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1981 1. I have added some unsigned where needed
1982 2. Some function parameter not used -> (void)
1983 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1984 4. g++ don't like character '\' in comment
1985 5. #define jpeg_create_decompress jCreaDecompress
1986 this really need to be fixed
1987 6. virtualize destructor of gdcmObject ... leakage
1988 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1989 this also really need to be fixed
1990 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1991 remove compression file
1992 (as we only do decompression, right ?)
1993 * ENH: Change malloc/calloc/free with c++ equivalent
1995 2004-04-21 Jean-Pierre Roux
1996 * FIX gdcmHeaderHelper::GetXSpacing
1997 when a single value is found (bug ?), xpacing is now
1998 defaulted to yspacing
2000 2004-04-19 Jean-Pierre Roux
2001 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
2002 * ENH add parameters :
2003 bool exception_on_error = false,
2004 bool enable_sequences = false,
2005 bool ignore_shadow = false
2006 to the gdcmFile constructors to be full gdcmParser compliant
2007 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
2008 to allow reading of PAPYRUS 3.0 files
2010 2004-04-06 Jean-Pierre Roux
2011 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
2013 2004-04-02 Jean-Pierre Roux
2014 * ADD : Test/checksequence.sh, for a general recap on SQ pb
2015 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
2016 for Philips spurious Tag fffe|0000 while rewritting Dicom files
2018 2004-03-30 Jean-Pierre Roux
2019 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
2020 for ACR file, written out as DICOM files (hope so...)
2022 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2023 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2024 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2025 moved to base class gdcmParser and only the specialisation is kept
2027 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2028 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2029 already does the job.
2030 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2031 (to be consistent with gdcmParser::WriteEntries).
2033 2004-03-30 Benoit Regrain
2034 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2035 upate of the object's instance. It's passed to 2 in the unfavorable
2036 case : one in the ExecuteInformation, one in the ExecuteData
2038 2004-03-29 Jean-Pierre Roux
2039 * ENH : Check on file type to be written moved
2040 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2041 * FIX : gdcmObject::ResetBoundaries now stops properly
2042 when end-of-list is reached
2043 : gdcmVersion modified (as Benoit Regrain asked)
2045 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2046 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2047 * src/gdcmUtil.cxx: added forgotten iostream include.
2048 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2049 equivalent to ExplicitVR in existing code).
2051 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2052 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2053 now contains all the gdcmGlobal related code.
2054 * minor coding style and doxygenation changes.
2056 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2057 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2058 now contains all the Debug related code.
2059 * minor clean-up of includes in src/*.cxx
2060 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2061 CreateCleanString) removed.
2062 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2063 * Doc/DoxyMainPageUser.txt added.
2064 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2065 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2066 src/gdcmDirList.cxx)
2068 2004-03-24 Jean-Pierre Roux
2069 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2071 2004-03-23 Jean-Pierre Roux
2072 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2073 big endian made volumes
2074 * ENH Now gdcmParser constructor and destructor are protected to forbid
2075 end user to instanciate class gdcmParser
2076 (only gdcmHeader and gdcmDicomDir are meaningfull)
2078 2004-03-22 Benoit Regrain
2079 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2080 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2081 gdcmSerie to gdcmDicomDirSerie
2083 2004-03-19 Jean-Pierre Roux
2084 * ENH Now the tree-like structure describing a DICOMDIR comming from
2085 an already existing DICOMDIR file is consistent with
2086 the home-made tree-like structure build ex-nihilo
2087 or build from the files held (recursively) in a Directory
2088 functions gdcmDicomDir::CheckBoundaries()
2089 gdcmObject::SetBoundaries() added
2091 2004-03-17 Jean-Pierre Roux
2092 * REM (Eric Boix bug) : removal of meaningless
2093 gdcmDicomDirImage::NewImage function.
2094 * FIX now file names and directory name are written properly in the
2096 * FIX now gdcmDicomDir constructor may be call without any trick
2099 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2100 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2101 of gdcmDicomDirImage::NewImage as empty function.
2103 2004-02-28 Jean-Pierre Roux
2104 * ENH add gdcmDicomDir:NewPatient
2105 add gdcmDicomDirPatient:NewStudy
2106 add gdcmDicomDirStudy:NewSerie
2107 add gdcmDicomDirSerie:NewImage
2108 to allow making gdcDicomDir object.
2109 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2110 (as opposite to the gdcmHeader chained list)
2112 2004-02-11 Benoit Regrain
2113 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2114 when using from python
2116 2004-02-10 Benoit Regrain
2117 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2118 * FIX : in gdcmDicomDir when the directory is empty
2119 * ENH : add callback and methods to get the progression of dicomDir
2122 2004-02-06 Jean-Pierre Roux
2123 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2124 - GDCM_META added to gdcmDicomDirType
2125 - class gdcmMeta created
2126 * ENH : - A brief summary is now displayed at the beginning of
2127 'testDicomDir' to help disaster magnitude estimation
2128 * REM : Now useless Test/explDICOMDIR.cxx
2130 2004-02-05 Benoit Regrain
2131 * ENH : add methods in gdcmObject to get the hash table or the list of
2133 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2134 * FIX : wrapping python for TagHeaderEntryHT
2136 2004-02-04 Benoit Regrain
2137 * FIX : even length for some strings when writting the dicom dir
2138 * FIX : sort the images in the dicom dir
2139 * FIX : Bug fix for python use of dicom dir
2140 * ADD : a python demo
2142 2004-02-04 Jean-Pierre Roux
2143 * FIX : Final solution (?) for icone embedded images
2144 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2145 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2146 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2147 gdcmData/gdcm-MR-SIEMENS-16.acr1
2148 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2149 to make full checking easier
2151 2004-02-04 Benoit Regrain
2152 * FIX : WriteEntries : coding style & logic in parameters
2153 * FIX : Set the elements to create the DicomDir in a dictionary file
2155 2004-02-03 Benoit Regrain
2156 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2157 * gdcmDicomDir : add the load of directory
2158 * Bug fix and print add-on
2160 2004-02-03 Jean-Pierre Roux
2161 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2162 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2163 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2164 * FIX gdcmParser.cxx : 'group length' elements are now considered
2165 as integers, even for shadow groups, when file is Implicit VR
2167 2004-02-02 Jean-Pierre Roux
2168 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2170 of the last synonym :-(
2171 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2173 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2174 * FIX taking into account the possible 7fe0,0010 multiplicity
2175 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2176 to allow removal of references to 7fe0,0010, to deal with
2177 ACR-NEMA images, when 0028,0200 is meaningfull
2179 2004-01-31 Jean-Pierre Roux
2180 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2181 no longer writes 'Un' on disk
2182 * FIX SQ elements with actual length are now dealt with corectly
2183 * FIX gdcmFile::WriteBase make the difference, for color images, between
2184 the length (for Palette expanded images)
2185 and Raw Length (non expanded image + Palette)
2186 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2187 (that broke Write). Replaced by UL.
2188 Aware user will reload the field if he
2189 thinks it's necesssary
2191 2004-01-30 Jean-Pierre Roux
2192 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2193 when 'dirty Acr' is found, to be compliant with the new
2194 IsReadable() methods.
2196 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2197 (no DOUBLE images in kosher DICOM,
2198 but so usefull for people that miss them ;-)
2200 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2201 DICOMDIR related utilities (not checked as Windoze compliant)
2203 2004-01-28 Jean-Pierre Roux
2204 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2206 2004-01-27 Jean-Pierre Roux
2207 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2208 to allow skipping the shadow elements, to save memory space.
2209 The TRUE value for this param has to be used
2210 with a FALSE value for the 'enable_sequence' param.
2211 ('public elements' may be embedded in 'shadow Sequences')
2212 * gdcmHeader methods now deal with 'embedded icones images' in the header
2213 (even when an 'icone image sequence' is announced by the
2214 element (0x0088,0x0200), but there is NO icone at all ...
2216 * gdcmHeader sometimes Image Location value doesn't follow
2217 the supposed processor endianity (see gdcmData/cr172241.dcm).
2220 * gdcmHeader add the method
2221 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2222 to get *all* the Header Entries with the same tag.
2223 GetHeaderEntrySameName is probabely *useless*
2224 (no meaning : Name is *not* an identifier within the Dictionary)
2226 2004-01-26 Benoit Regrain
2227 * Bug fix in the print of hexadecimal representations. Remove long fields
2228 in the print and add a third level of print to print them
2230 2004-01-23 Benoit Regrain
2231 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2232 * Bug fix on test suite after remove the strip made on not string fields
2233 * Split the IsReadable method between gdcmParser which test that the file
2234 is dicom and gdcmHeader which test that it's an image file
2236 2004-01-22 Benoit Regrain
2237 * DicomDir : clean code, add methods, set variables in protected or private
2238 * gdcmUtil : bug fix for the clean string method
2240 2004-01-19 Benoit Regrain
2241 * Add the use of shadow dictionaries
2242 * bug fix and coding style
2244 2004-01-19 Benoit Regrain
2245 * src/gdcmFile.cxx : bug fix concerning the close of file
2246 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2247 * Add the update of header entries using the shadow library
2249 2004-01-19 Benoit Regrain
2250 * removal of file gdcmHeader2.cxx
2251 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2252 inheriting from gdcmParser. This split is to prepare the integration
2253 of dicom dir parsing
2254 * bug fix under python
2256 2004-01-16 Jean-Pierre Roux
2257 * REM removal of class gdcmHeaderEntrySet
2258 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2259 * ADD add file gdcmHeader2.cxx
2260 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2262 2004-01-15 Benoit Regrain
2263 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2264 entries created while parsing the header. Thus, they will be destroyed
2265 when the gdcmDictSet will be destroyed
2266 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2269 2004-01-15 Benoit Regrain
2270 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2271 made a fatal error because of the memory release at the end of program.
2272 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2273 some memory and vtk seems to have some problems with that.
2274 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2276 2004-01-14 Benoit Regrain
2277 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2278 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2279 * src/*.[h|cxx] : make changes due to class name changes
2280 * gdcmPython/demo/*.py : bug fix due to method names
2282 2004-01-13 Benoit Regrain
2283 * src/*.[h|cxx] : coding style
2284 * vtk/*.[h|cxx] : coding style
2286 2004-01-13 Benoit Regrain
2287 * gdcmPython/testSuite.py : test the readable flag of file for tests
2288 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2289 It's lied to the stl compilation by MSVC (windows, always windows...)
2290 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2292 2004-01-12 Benoit Regrain
2293 * src/*.h : add comments
2294 * src/gdcmDictSet.h : set the method BuildDictPath in public
2295 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2296 directly setted in the source code
2297 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2300 2004-01-09 Benoit Regrain
2301 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2302 * setup.py : use a reference to gdcmVERSION
2304 2004-01-07 Benoit Regrain
2305 * Modification to compile with the distutils.
2308 2003-12-10 Benoit Regrain
2309 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2310 can use a gdcmHeaderHelper to load data
2311 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2312 made in the source code
2314 2003-12-10 Benoit Regrain
2315 * Update Windows projects and .cvsignore files
2317 2003-11-12 Jean-Pierre Roux
2318 * ENH gdcmHeader constructor has one more parameter (default value : false)
2319 that allows the user to 'go inside' the SeQuences only
2321 gdcmElValSet:Print takes it into account
2323 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2324 * ENH: Update gdcmPython/CMakeLists
2325 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2326 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2328 2003-11-10 Jean-Pierre Roux
2329 * FIX : gdcmHeader::LoadElements is now based
2330 on the ListTag listElem member,
2331 not longer on the TagElValueHT tagHt member
2332 * ENH : PrintPubElVal shows (temporarily) both results,
2333 with the tagHt member and the listElem member.
2334 (it's easier to 'see' the problems when using Printheader)
2336 * FIX : old private member LgrElem is now splitted into
2337 ReadLength : Length actually found on disk (updated only
2338 if bug fixing is necessary), for internal
2340 UsableLength : Updated by FixFoundLength, to fix a bug
2341 or to allow Parser going on.
2342 Will allow to re-write a kosher header when a SeQuence
2343 with a length (not 0000) is found
2344 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2345 because gdcmElValSet::Add does not update ListElem
2348 2003-11-07 Jean-Pierre Roux
2349 * FIX misstyping in Transfert Syntax name table
2350 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2351 when they have an actual length (not 0000 nor FFFFF)
2352 (Nobody should care of it, but DICOMDIR explorers)
2354 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2355 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2357 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2358 * ENH: vtkGdcmReader now supports LUT !
2359 (vtkgdcmViewer for now is not able to use them though)
2361 2003-11-05 Jean-Pierre Roux
2362 * in testSuite.py : new files names for checking the package
2363 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2364 that returns the pixel area size to the *aware* (vtk) user
2365 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2367 2003-11-05 Benoit Regrain
2368 * in testSuite.py : Modify the rules for checking the paths
2369 : Explicit error messages
2370 * in __init__.py : Related modif
2372 2003-11-03 Jean-Pierre Roux
2373 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2374 to be used by aware (vtk) users that want to manage
2375 LUT (and no to turn the PALETTE image into an RGB pixels one)
2376 * GetPixelType now returns 8U for 24 Bits images
2377 (vtkGdcmReader compliant)
2379 2003-10-31 Jean-Pierre Roux
2380 * Removal of *all* gdcmData images and add them again
2381 in order to loose the 'history' of un-anonymised images
2383 2003-10-31 Jean-Pierre Roux
2384 * RMV : removal of useless jBitsInJsample.h
2385 for both 8 and 12 Bits JPEG Lossy Libraries
2387 2003-10-31 Jean-Pierre Roux
2388 * ENH : Add the functions gdcmFile::GetImageDataRaw
2389 gdcmFile::GetImageDataIntoVectorRaw
2390 that act as GetImageData and GetImageDataIntoVector
2391 except the making of an RGB Plane from Gray Plane + LUT
2392 Intended to aware (vtk) users who know how to manage
2395 GetLUTRGBA return a R,G,B,A LUT if any
2396 lgrTotaleRaw gives the 'Raw' length
2397 GetImageDataRaw returns the gray Plane
2398 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2399 (They stay Grey, just like with other Dicom viewers :-(
2401 2003-10-30 Jean-Pierre Roux
2402 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2404 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2405 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2406 being coherents dicom files.
2408 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2409 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2411 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2412 * ENH: Two steps is necessary to please VC++ compiler...
2413 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2414 * ENH: Add include dir to medcon lib
2415 * FIX: only one function is being exported for now !
2416 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2418 2003-10-29 Jean-Pierre Roux
2419 * adding gdcmHeader::GetLUTRGBA
2420 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2421 --> Mathieu, the modif u're waiting for is not yet committed
2422 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2424 2003-10-27 Jean-Pierre Roux
2425 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2426 00191113.dcm DermaColorLossLess.dcm
2427 MxTwinLossLess.dcm RadBWLossLess.dcm
2428 * ENH: For version prior to vtkImageViewer2 -r 1.19
2429 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2431 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2432 * Removal of ido stuff in CMakeLists.txt
2434 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2435 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2436 * FIX: remove a call to ->Modified ... see comments
2437 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2439 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2440 * FIX: Problem with path for libvtkgdcmPython
2441 * ENH: Try adding a search script for python site-package
2442 * RMV: Remove some file from medcon lib that are not necessary
2443 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2444 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2445 * FIX: More pragma disable fro VC++,
2446 I don't think I break something as it is also disable in VTK/ITK.
2447 But it fasten debug compilation time.
2449 2003-10-23 Jean-Pierre Roux
2450 * gdcm now deals with 16 Bits Run Length Encoded images
2451 (they are compressed as 2 planes images,
2452 one for the high Bytes, the other for low Bytes)
2454 2003-10-22 Jean-Pierre Roux
2455 * Now CheckRead takes into account :
2456 - the bugged 'Leonardo' Siemens images
2457 - the XA images, sent thru the burning VPRO station
2458 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2461 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2462 * FIX: When copying a Makefile.am to CMakeLists.txt
2463 one should remove the '\'
2465 2003-10-22 Jean-Pierre Roux
2466 * in gdcmData adding a bugged 'Leonardo' Siemens image
2467 (wrong lengths in header)
2468 OK with gdcm, KO with the other viewers :-)
2469 * add a GE dlx XA image, thru the VEPRO burning station
2472 2003-10-21 Jean-Pierre Roux
2473 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2474 for a brutal checking of vtkgdcmViewer compliance
2476 2003-10-21 Jean-Pierre Roux
2477 * add the files for 'xmedcon' Jpeg Lossless library
2478 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2480 2003-10-21 Jean-Pierre Roux
2481 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2483 2003-10-21 Jean-Pierre Roux
2484 * garbage Siemens 'Leonardo' images dealt with
2485 (the patch is easy to remove)
2486 * cosmetic changes to avoid warnings
2488 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2489 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2490 no need to press 'r' now.
2492 2003-10-20 Jean-Pierre Roux
2493 * upgrade of checkRead.sh checkWrite.sh according
2494 to new Jpeg Lossless decompressor
2495 * add US.3405.1.dcm, a genuine RGB medical file ...
2496 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2497 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2499 2003-10-15 Jean-Pierre Roux
2500 * general anonymisation in gdcmData
2501 * adding the 'color files' from
2502 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2503 * adding some well knowed bugged-header images
2504 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2505 waiting for their inclusion in Python testsuite
2507 2003-10-15 Jean-Pierre Roux
2508 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2509 no longer seg faults when file is not found
2511 2003-10-14 Jean-Pierre Roux
2512 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2515 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2516 * TODO: *.in file to genereate a UseGDCM later
2518 2003-10-14 Jean-Pierre Roux
2519 * Some supposed-to-be Dicom Images have no preamble.
2520 OpenFile takes it into account
2521 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2522 * Missing elements added in dicomV3.dic
2523 (just to be affraid : have a look at
2524 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2525 and do it again next year ;->
2527 2003-10-13 Jean-Pierre Roux
2528 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2529 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2530 But there are NOT. It's fixed !
2532 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2533 * FIX: "jpeglib.h" was not found on VC++
2534 * FIX: vtkgdcm was not being installed
2536 2003-10-10 Jean-Pierre Roux
2537 * ENH : OpenFile closes the file if it *really* doesn't look like
2538 an ACR-NEMA / DICOM one.
2539 * FIX : testWrite no longer writes an empty file if the source file
2540 is not gdcm Readable
2541 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2544 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2545 * FIX: CMake generate now documentation
2546 * ENH: out of source doc build !
2547 * ENH: Generate both user and dev documentation
2548 * ENH: Should work on windows too
2549 * ENH: Only one doxygen config.in file is needed
2550 * FIX: make install should be ok now on ùnix plateform
2551 * FIX: PATH to dictionary was wrong (missing /)
2552 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2554 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2555 * vtkGdcmReader is now able to read rgb dicom file.
2556 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2557 * added a gdcmViewer to vtk test, use mouse to control
2558 window level & window width
2560 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2561 * CMake-ification of gdcm, we have now two build system
2562 * FIX: on cygwin Wsock32 doesn't exist
2563 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2565 2003-10-06 Emanuel Ollart
2566 * FIX : compilation process wad broken.
2567 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2569 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2570 * change gdcmViewer -> vtkgdcmViewer
2571 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2573 2003-10-06 Jean-Pierre Roux
2574 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2575 ( e.g : well known GE images with a wrong elem length,
2576 : Philips MRI Images with a wrong Huffman table)
2577 * still to be done : allow the reading of bugged LEONARDO Siemens images
2579 2003-10-03 Jean-Pierre Roux
2580 * Odd length strings are padded with '\0' (not with spaces,
2581 to remain compliant with already defined strings,
2582 like Transfert Syntax UID and others)
2584 2003-10-03 Jean-Pierre Roux
2585 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2586 to allow displaying RGB images (not only by affim ;-)
2588 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2589 * vtkGdcmReader is now able to read rgb dicom file.
2590 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2592 2003-10-03 Jean-Pierre Roux
2593 * A few nasty patches to allow the reading of a lot of nasty images
2594 ( e.g : well known GE images with a wrong elem length,
2595 : Philips MRI Images with a wrong Huffman table)
2596 * still to be done : allow the reading of bugged LEONARDO Siemens images
2598 2003-10-03 Jean-Pierre Roux
2599 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2601 2003-10-03 Jean-Pierre Roux
2602 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2603 to allow displaying RGB images (not only by affim ;-)
2605 2003-10-03 Jean-Pierre Roux
2606 * gdcmFile::GetImageDataIntoVector now
2607 - deals with MultiFrames MultiFragments Run Length Encoded files
2608 - deals with YcBcR (YBR_FULL) files
2609 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2610 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2612 (no sample found :-(
2614 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2615 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2616 Two reasons: - clear things
2617 - third parties acces gdcm through header files, so won't
2618 suffer anymore VC++ complains
2620 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2621 * add argv[1] in testvtkGdcmReader.cxx
2624 2003-09-24 Jean-Pierre Roux
2625 * The lines are now eigthy characters long.for
2626 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2628 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2629 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2630 char* to std::string. Thus, the use of strdup becomes useless. (see
2631 previous commis of Malaterre)
2632 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2633 before the last Malaterre's commit.
2635 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2636 * This commit should fix the Debug building under VC++, the problem
2637 was mainly a mixture of debug and release lib being loaded at startup.
2638 * I also remove a depency to a specific C function: strdup. Because I had
2639 to force the link to msvcrtd (whereas strdup is in libc).
2641 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2642 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2643 located in the gdcmCommon.h file. All use of reference of tha has been
2644 changed to now use the variable GDCM_UNFOUND.
2646 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2648 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2649 Dicom dictionary. The test suite can now be run again. Note:
2650 I'm note very happy with the " (RET)" changes. I believe this
2651 RETAINED comment should be dropped when parsing the dictionary.
2652 - PACKAGER corrected
2654 - AUTHORS updated and now in alphabetical order
2655 * Makefile.am now exports gdcm.dsw for Windoze users.
2657 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2658 * cygwin complains about missing std:: in subdir Test/
2660 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2661 * remove some methods that are now in gdcmHeaderHelper
2663 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2664 * vtkGdcmReader set spacing and origin correctly
2666 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2667 * Fix a few delete/delete[] mismatch
2669 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2670 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2671 interpretation to data given by gdcmHeader. For instance there are
2672 heuristics to get informations (look at different places).
2673 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2674 sorting DICOM images based on different strategies.
2675 * modified Makefiles accordingly.
2677 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2678 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2679 when building in debug mode
2680 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2681 src/win32/gdcmdll.dsp
2682 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2684 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2685 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2688 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2689 * src/win32/libgdcmjpeg12.dsp was not dos format
2690 * src/win32/libgdcmjpeg12.dsp :
2691 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2692 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2694 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2695 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2697 * src/gdcmFile.cxx : bug fix in affectation type
2698 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2699 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2700 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2701 symbols... future problem ?
2703 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2704 * src/win32/libgdcmijpeg12.dsp was missing
2705 * modified gdcm.dsw accordingly
2707 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2708 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2710 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2711 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2712 commit of JPR (before his hollidays to facilitate our work).
2713 * setup.py : bug fix in code. Modifications made while the last commit
2714 of JPR. The code hasn't been tested before the commit... it's so
2715 useless to make that (for best programmer that is JPR) !!!
2717 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2718 * tagged the current version as Version0_3 (i.e. version 0.3)
2720 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2721 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2722 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2723 * *.dsp : modifications to use new libgdcmijpeg8 library
2724 * setup.py : bug fix on VTKPATH variable
2725 * PACKAGER : adding all concerning windows
2727 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2728 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2730 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2731 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2732 test suite reported error.
2733 * PACKAGER file added (describes what a packager must do when
2734 packaging a new release).
2735 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2736 * configure.in: upgraded version number to 0.3.0
2737 * fixing build of rpm (through rpm -ta):
2738 - Doc/Makefile.am exports proper doxygen files
2739 - src/jpeg/libijg8/Makefile.am exports the include files.
2741 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2742 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2743 * src/gdcmHeader.h : formatting code
2745 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2746 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2747 We were obtaining error message from vtk. Now, creation of file list
2748 is made in an internal list to prevent this problem.
2749 Bug fix when output is empty.
2750 Bug fix in update of progress value. Previous commit for this was a bad
2752 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2754 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2755 * src/gdcmHeader.h : added method to get the file name
2756 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2757 files. Added method to remove all files on the input
2758 Added FIXME comment concerning the bad parsing of header made by
2759 ExecuteInformation method (in ExecuteData method)
2761 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2762 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2763 when using make instal.
2764 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2765 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2767 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2768 * setup.py : adding include dir of jpeg lib to compile all sources
2769 * */Win32/*.dsp : JPR fix for windows compilation
2771 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2772 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2774 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2775 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2777 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2778 * setup.py is again effective on un*x (takes into account the
2779 addon of the jpeg library)
2780 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2781 * Doc/Doxy* updated (includes above enhancements)
2782 * INSTALL now points to web documentation
2784 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2785 * src/gdcmHeader.h doesn't make unnecessary reference to
2787 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2789 * src/gdcm*.[cxx|h] :
2790 - to allow compilation with gcc 3.x
2791 -- clean up of STL usage (added explicit usage of std::)
2792 -- small fixes on exceptions.
2793 Note: linking not tested !
2794 - clean of doxygen comments to avoid warnings at documentation
2796 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2797 dependent convertion).
2799 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2800 * Clean up of previous JPR garbage commit (not even commented in the
2802 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2803 - moved all jpeg related files from src to src/jpeg/libijg8, with
2804 addition/modification of Makefile.am and configure.in.
2805 - the testSuite is still brain damage (not guilty).
2807 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2808 * WrapVTK.py : modifications to get correctly vtk source files to
2810 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2811 (FileName -> Filename)
2813 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2814 * vtk/vtkGdcmReader.[cxx/h]:
2815 - UpdateProgress method should now be effective
2816 - removed the limitation on having only images loaded (as opposed
2818 - when building a stack of images/volume, a lesser number of
2819 gdcmHeader and gdcmFile instances should be used (hopefully
2820 accelerating things).
2821 - when building a stack of images/volumes, files which are not
2822 loadable (wrong path-filename, wrong permissions on existing file,
2823 or file not parsable by gdcm) are replaced with a black image
2824 in the stack (for the caller to notice the problem).
2826 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2827 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2829 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2830 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2831 between standard library (std) and vtk library (problems are found
2832 under Windows... thanks Windows !)
2834 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2835 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2837 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2839 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2840 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2842 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2843 * When compiling with distutils (see setup.py) the C++ compiler is
2844 called with different flags than the default ones (with automake).
2845 In order to fix all those warning, I compiled gdcm with the command
2846 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2847 and went for warning fixes:
2848 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2849 up from unused variables.
2850 - vtk/vtkGdcmReader.cxx: potential bug fix.
2851 * src/gdcmHeader.h: Doxygen warning cleanup
2853 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2854 * gdcmPython/gdcm.i:
2855 - typemaps correction to take into account the systematic replacement
2856 of "using namespace std" with std:: prefix e.g. std::list,
2857 std::string... (cf changes of 2003-05-21).
2858 - gdcmGlob global variable of type gdcmGlobal (defined in
2859 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2860 exported to Python a as cvar.
2861 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2862 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2863 gdcmDictSet.GetPubDictTagNames() and
2864 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2865 C++ static methods).
2866 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2867 with the above changes.
2869 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2870 * setup.py, manifest.in : bug fix under linux
2872 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2873 * Modification of setup.py to compile vtk part too. Then, we have 2
2874 wrappers which must work with same distutils. For that, we have a
2875 generic distutils in distusiltsWrapping.py ; with :
2876 - build_extWrap class to wrap generically all extensions,
2877 - ExtensionWrap base class for all wrapping extension that contains
2879 - Wrapper interface which wrap sources
2880 + In WrapSwig.py we have extension and wrapper for Swig
2881 + In WrapVTK.py we have extension and wrapper for VTK
2882 * MANIFEST.in : modifications to consider vtk directory and new python
2883 files for compilation
2885 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2886 * Added python wrappers of vtkGdcmReader vtk class (see the
2887 source in vtk/vtkGdcmReader.cxx) :
2888 - vtk/Makefile.am now builds a library
2889 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2890 python library (as opposed to _gdcm.so wich are the python
2891 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2892 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2894 - configure.in has an additional flag --enable-vtk that needs
2895 to be set to enable compilation of vtk related code, that is:
2896 + vtk/vtkGdcmReader.so and
2897 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2898 + gdcmPython/vtkgdcmPython.so (see above)
2899 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2900 be read when compressed or when HighBit + 1 != BitsStored),
2901 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2902 the usage of the python wrapper of vtkGdcmReader vtk class.
2903 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2904 * src/*.[h] all occurences of stl classes are now prefixed with
2905 std::, and all occurences of "using namespace std;" where removed.
2906 This is to avoid pollution of global namespace in included files.
2907 Apparently vtk does not avoid this pitfall: when using both
2908 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2909 collision of various stl members (principally cout...).
2910 * gdcmPython/testSuite.py now cleanly removes temprory generated
2912 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2913 comply with above changes)
2915 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2916 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2917 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2918 vtk data structure (an image Flip was required).
2919 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2920 * cosmetic changes in documentation.
2922 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2923 * src/gdcmHeader.cxx: the constructor no longer exits when an
2924 unexisting file is given as argument.
2925 * The subdirectory Data (containing all the images used for the
2926 test suite) is not part of this repository anymore. A new module
2927 containing those images is now available at
2928 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2929 with the name gdcmData.
2930 All the python scripts (including the package initialisation file
2931 gdcmPython/__init__.py) were adapated to take this change into
2932 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2934 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2935 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2936 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2937 demo of the usage of this class.
2938 Compilation of this vtk part is only done when using the --enable-vtk
2939 at configure (or autogen.sh) stage.
2941 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2942 * More memory link related corrections and documentation fixes.
2944 - maximum info is obtained with a command of the form:
2945 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2946 --show-reachable=yes PrintHeader
2947 - the remaining reachable blocks seem to come from the STL
2948 allocation scheme through the usage of map and list. It looks
2949 like this memory cannot be freed but it is not a memory leak
2950 (in fact further invocation to the STL would recollect the
2951 unused memory allthough it cannot explicitely be freed).
2952 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2953 of displaying an image parsed with gdcm and displayed with VTK.
2954 Note: some images don't seem to work e.g.
2955 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2956 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2957 Allthough this weakens the semantics, it is a ditch attempt to
2958 make gdcm more thread friendly.
2960 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2961 * Memory link hunt (by using valgrind through the command
2962 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2963 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2964 gdcmHeader::_dicom_vr.
2965 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2966 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2968 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2970 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2971 * src/Makefile.am now exports all the necessary include files at
2975 * UpdateGroupLength replaced by new one
2978 * UpdateGroupLength re-written using H-Table
2979 (named UpdateGroupLengthNew untill checks are over)
2981 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2982 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2983 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2985 - gdcmHeader::GetPubElValSet removed.
2986 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2987 UpdateGroupLength, WriteElements, Write.
2988 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2989 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2990 carried the same semantics.
2991 - src/gdcmHeaderIdo.cxx changed accordingly.
2992 - gdcmFile::WriteBase now regroups all the codes from previous
2993 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2994 - enum FileType moved to gdcmCommon.h
2995 * src/gdcmHeader.cxx AddDefault trashed
2996 * gdcmGetXSize added
2997 * getimageDataSize now calls gdcmGetXSize
2998 * Test/*.cxx changed to agree with above changes
3000 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3001 * src/gdcmHeader.h: LoadElements() is not a public method anymore
3002 (to avoid double call by end user).
3003 * Test/*.cxx LoadElements() doesn't need to be called explicitely
3004 by end user, since gdcmHeader::gdcmHeader now handles it.
3006 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3007 * gdcm/Doc many doxygen changes:
3008 - Doxyfile now has two different versions, DoxyfileUsers that generates
3009 the html.users end users oriented documentation and
3010 DoxyfileDeveloppers that generates the html.developper developper
3011 oriented documentation.
3012 - README changed accordingly
3013 - requirement.txt removed (old design info moved to TODO).
3014 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
3015 DoxyMainPage.txt, DoxyPython.txt provide more information.
3016 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
3017 be updated by simply regenerating the docs with doxygen and copying
3018 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
3019 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
3020 all the tests in the form "if (<map>.count() >1)" were removed.
3021 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3022 ill-formed documentation sections.
3023 * src/gdcmHeader.cxx: ditto
3025 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3026 * setup.py fixed for un*x (needed macro for stdint.h)
3027 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3028 un*ces with sh-utils test utility.
3029 * gdcmPython/demo/test.py renamed to PrintHeader.py
3030 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3031 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3032 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3033 * src/gdcm*.cxx JPR's bad inclusion fixed.
3035 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3036 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3037 * gdcmPython/demo/test.py changed accordingly.
3039 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3040 * gdcmPython/Makefile.am fixed linking against libstdc++
3041 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3042 * Swig subdir (historical tests of swig version 1.3.17++) removed
3043 * Test/testChangeEntete.cxx some lines commented out in order to make
3045 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3046 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3048 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3049 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3050 hence the user doesn't need this explicit call.
3051 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3052 i.e. LoadElements() call removed.
3053 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3054 - src/Makefile.am declares the proper flag for g++.
3055 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3056 for adding user defined new tags.
3057 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3058 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3059 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3061 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3062 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3063 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3064 src/Makefile.am : the project should properly compile and install
3065 with the autotools, included the python wrappers part.
3066 * gdcm.spec.in : added a spec file for RPM packaging.
3068 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3069 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3071 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3072 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3073 to exported to the environement (see gdcmPython/testSuite.py
3075 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3076 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3077 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3078 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3079 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3081 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3082 * gdcmPython/__init__.py doesn't crash anymore when running in
3083 in InstallMode or PreInstallMode but with an environment given
3084 value of GDCM_DICT_PATH.
3085 * src/gdcmDictSet.[cxx/h] coding style.
3087 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3088 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3089 * src/gdcm.h general comments moved to TODO, and README
3090 * src/gdcm.h should now be seen as a user commodity (including it
3091 should suffice to fully use gdcm). It is nowhere including within
3092 any of the kernel files src/*.cxx and src/*.h.
3094 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3095 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3096 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3098 * src/gdcm*.cxx only include their corresponding include file
3099 (as opposed to gdcm.h)
3100 * gdcmPython/gdcm.i changed accordingly
3101 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3102 the autogen.sh generated "make snapshot" command to work.
3103 * autogen.sh removed history related references to crea package.
3105 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3106 * distutilsSwigCPlusPlus.py work around some swig portability
3109 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3110 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3111 was done in a last ditch attempt to get setup.py _really_
3112 operationnal. The python/gdcmPython layaout add the advantage
3113 of hidding away the python related distutils specific files
3114 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3115 Alas, the src directory was out of scope (i.e. it's relative
3116 position to setup.py was ../src) which made things impossible to
3117 handle (see previous version of python/setup.py). Crossing fingers...
3119 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3120 * python/setup.py now works on Un*x. (harder than I thougth)
3121 * python/distutilsSwigCPlusPlus.py can now have include files
3122 among the list of sources.
3124 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3125 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3126 * modifications in MSVC projects
3128 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3129 * As stated by the first lines of Test/ExceptionAndPython/README, it
3130 looks like we can move back to original usage of exception within
3131 src/gdcm* and hence remove the errno stuff that was introduced
3132 as a quick and dirty fixture of this problem (added to the TODO).
3133 * Doc/Doxyfile configuration file for Doxygen and corresponding
3134 README file for usage added.
3135 * Test/testWrite.cxx added. This new test comes from a split of
3136 test.cxx that is now reverted to its original purpous i.e.
3137 testing the proper parsing of a Dicom related file.
3138 testWrite.cxx concentrates on testing the IO part of gdcm.
3139 * Test/bug1.cxx (containing a bug on WIn32) added.
3140 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3141 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3142 whose purpose is to publish the content of the TagNames of the
3143 Dicom public dictionary were not accessible without an
3144 instance of class gdcmHeader.
3145 - those methods are now static methods of gdcmDictSet and hence
3146 require no instances at all to be invocated.
3147 - within gdcmDictSet this change required to change some method
3148 to class methods (i.e. are now static) among which SetDictPath
3149 (renamed to BuildDictPath) and LoadDefaultPubDict.
3150 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3151 the above changes by calling the new method classes of gdcmDictSet.
3152 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3153 the above to be effective.
3154 * python/gdcmPython: in order to wrap properly the above changes
3155 for Python, swig version now needs to be > 1.3.17.
3156 * python/gdcmPython/Makefile fixed to adapt itself to new
3157 configure/make shema introduced by Johan Montagnat (thanks for the
3158 contribution). Alas this Makefile cannot be turned into a proper
3159 Makefile.am without some heavy changes in the configure.in
3160 (for python dectection).
3161 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3162 now avoids publishing the empty entries.
3164 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3165 * python/setup.py : bug fix concerning install under windows
3166 ExtraPath reused :-P
3167 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3169 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3170 * Dicts/dicomV3.dic : remove double spaces !!!
3171 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3172 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3175 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3176 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3177 method. Doxygenation.
3178 * src/gdcm.h clean up of JPR spurious comments.
3180 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3181 * python/distutilsSwigCPlusPlus.py now properly collects the
3182 shadow classes generated by "swig -c++" (gdcm.py in our case)
3183 when using "python setup.py install".
3184 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3185 reexports the working classes.
3186 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3187 by the classical C errno scheme. This is to prevent an obscure
3188 behavior of the python wrappers when importing wxPython.wx prior
3189 to gdcmPython (which ended up in an abort call). An illustration
3190 of this oddity can be found in the Test/ExceptionAndPython
3191 subdir (see the README file). This problem probably due to
3192 an combination of g++ and dynamic loading.
3193 * added Test/ExceptionAndPython (see above)
3195 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3196 * Changed the layout of the python part to avoid bloating main
3197 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3198 i.e. the distutils arsenal. All the python related stuff is
3199 again in a python subdir, but the package itself is now in
3201 * setup.py was cleaned up:
3202 - pythonIncludePath removed
3203 - python setup.py bdist target is now functional.
3204 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3205 collision with other packages). gdcmPython/demo/*.py changed
3208 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3209 * python subdir moved to gdcmPython (preparation of distutils packaging).
3210 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3211 distutils installer is operational.
3212 * - gdcmPython/__init__.py now properly loads the swig generated
3213 shadow classes (from gdcm.py).
3214 - gdcmPython/demo/*.py changed to import the package gdcmPython
3215 instead of gdcmPython/demo/load.py.
3216 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3218 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3219 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3220 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3221 entries within the associated public Dicom dictionary resp. the same
3222 information but sorted by the fourth field (PAT, IMG, DIR) of the
3224 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3225 are now in the "???" group.
3226 - python/gdcm.i changed accordingly,
3227 - python/demo/printGroupedPublicDict.py added, that gives an example
3228 of the above new functionalities in Python.
3230 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3231 * src/gdcm.h, gdcmHeader.cxx:
3232 - historic references to glib's g_malloc and g_free (#defined)
3233 were definitively removed.
3234 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3235 * src/gdcmElValSet.cxx:
3236 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3237 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3238 - GetElValue(string) renamed to GetElValueByName.
3239 - Added GetElementByName(string).
3240 * src/gdcmHeader.cxx: added
3241 - GetPubElValRepByNumber(guint16, guint16)
3242 - GetPubElValRepByName(string)
3243 - GetShaElValRepByNumber(guint16, guint16)
3244 - GetShaElValRepByName(string)
3245 - GetShaElValByNumber(guint16, guint16)
3246 - GetShaElValRepByName(string)
3247 - GetElValRepByNumber(guint16, guint16)
3248 - GetElValRepByName(string)
3249 - GetElValByNumber(guint16, guint16)
3250 - GetElValRepByName(string)
3251 * Doc/requirements.txt added.
3253 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3254 * Test/Makefile building now depends on the one of libgdcm.so
3255 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3256 pixel data) aware which enables finding the address (offset) of
3257 the pixel data of JPEG encoded DICOM files. This leaves only a single
3258 file in the testSuite whose pixel data address (offset) is unknown.
3259 * python/testSuite.py changed accordingly.
3261 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3262 * VC++ has some strong limitations when working with the STL, as stated
3263 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3264 "Also note that some STL containers (map, set, queue, list, deque)
3265 cannot be exported. [...]
3266 Some STL classes contain nested classes. These classes can not
3268 This is caused by a designed limitation that once a template
3269 class is instantiated, it can not be re-instantiated and
3271 Since our usage of map<> is ubiquitous in gdcm, this "designed
3272 limitation" of VC++ is a pitfall.
3273 Hence the Python wrappers of gdcm cannot be incrementally linked
3274 against the c++ dynamic library. The dirty but only workaround is
3275 to forget about incremental link of dynamic libraries and to generate
3276 the Python wrappers library with the inclusions of the underlying C++
3278 The following modifications concern this matter on Win32/VC++:
3279 - wrapping python correct with standalone wrapped dll (don't use separate
3280 dll under windows !!!!)
3281 - python21_d debug mode enabled (ask Frog how to use it :-)
3282 - NO problem with having an STL member of class for example string in C++
3283 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3284 - Python test of dcmlib in Python is ok under windows on a large set
3286 * removed glib references
3287 * typedef's inserted in gdcm.i for correct swig type management
3289 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3290 * python/demo/*.py load.py extracted from test.py. Added explore.py
3291 that only displays required tags and testAll.py that parses all
3292 the files of the testsuite without using unittest.
3293 * python/testSuite.py other additional test on new files added.
3294 * Data/* new test files added accordingly to the testSuite.
3295 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3296 the vr in the file differs from the one of the dictionary.
3298 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3299 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3300 values, but limits itself to values which are below a user specified
3301 size (by default 1024 bytes).
3302 * python/gdcm.i : elements not loaded (because their size is above the
3303 user specified treshold) are exported with their TagKey as key of the
3304 python dictionary. This enables the testsuite to make some checks
3305 on the unloaded elements (since we have their offset and size).
3306 * python/testSuite.py
3307 - now tests for the existence and proper value of the pixel data
3308 - two new examples added.
3309 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3311 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3312 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3313 aware. See the strategy comments in gdcmHeader::FindLength().
3314 * Test/test.cxx now accepts a filename as first argument.
3315 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3316 * python/testSuite.py changed to integrate test on above files.
3318 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3319 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3320 the vr was also RET.
3321 * python/testSuite.py more tests added.
3323 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3324 * python/testSuite.py unittest test suite added (uses Data)
3325 * Data/* dcm and acr files for the test suite.
3326 * glib dependance removed from un*x version. We now use ISO C99
3327 7.18 Integer types (see stdint.h)
3328 - python/Makefile, src/Makefile src/gdcm.h
3329 * src/ when an explicit vr (like dicom files) suddenly poped an
3330 implicit element we use to mark the underlying DictEntry of the
3331 concerned ElValue with "Implicit". This strategy was damageable
3332 too the public or provite dictionaries, since some of their vr
3333 would be changed. Since Header::FindLength heavily relies on the
3334 detection by Header::FindVR of falsely explicit elements, I
3335 added an extra ImplicitVr member to ElValue (boolean).
3336 The rest of the changes we the necessary adaptations.
3338 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3339 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3341 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3343 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3344 * Adaptation for porting to VC++:
3346 o forced to use std namespace (for string to be known)
3347 o all class use __declspec export style on WIN32
3348 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3349 (in stdlib.h on Win32 but in std:: for gcc)
3350 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3351 variable GDCM_DICT_PATH.
3352 * src/gdcmHeader.cxx verbose comments made discrete.
3354 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3355 * python/gdcm.i: added a typemap that converts a C++ hashing table
3356 to native Python dictionary.
3357 * python/demo/test.py:
3358 - now uses the native dictionary for exploration of gdcmHeader.
3359 - takes an optional filename argument (the file to parse).
3360 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3361 PubElVals hashing table.
3362 * Dicts/dicomV3.dic removed error prone trailing spaces.
3364 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3365 * Python wrapping process moved away from src/Makefile to
3366 newly created python/Makefile (as well as gdcm.i)
3367 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3368 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3369 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3370 from the environement variable GDCM_DICT_PATH (when existing).
3371 * src/gdcmDict::GetTag bug fix.
3373 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3374 * Straightforward temporary fixes for swig to build the python wrappers.
3375 src/Makefile now has a python working entry [by working we mean
3376 that we can import the shadow classes without errors].
3378 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3379 * hashtest.cxx removed (since already in Test)
3380 * src/gdcmlib.h renamed to src/gdcm.h
3381 * src/dcm.i renamed to src/gdcm.i
3382 * src/Makefile prepared for python wrapping
3384 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3385 * src/gdcmHeader.cxx :
3386 - Parsing of header is now separated from loading of element values
3387 (see gdcmHeader::LoadElements).
3388 - general clean up of hopefully all file access (creation of
3389 ReadInt16 and ReadInt32)
3391 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3392 * src/gdcmHeader.cxx :
3393 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3395 - SetLgrElem renamed to SetLength
3396 - GetLgrElem renamed to GetLength
3397 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3398 * src/gdcmElValSet.cxx fixed both GetElValue methods
3399 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3400 due to IdoDude was cleaned out.
3402 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3403 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3404 concentrates on finding the value representation (when it exists).
3405 RecupLgr now only finds the element value length, and it avoids
3406 returning the unecessary skL (skipped length).
3407 Also, offsetCourant was simply removed (with taille_fich) since
3408 it was redundant with the File position internals (by using
3409 ftell and fseek). This also made skL (see above in RecupLgr) usage
3411 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3412 on the libido specificities which are handled through class
3414 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3417 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3418 * Truckload of changes. Parsing of header is barely functional
3419 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3421 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3422 * src/gdcmHeader.cxx many addons of low level methods
3424 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3425 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3426 and _IdDcmSWAP_LONG.
3428 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3429 * This corresponds to all the changes decided at the meeting of
3430 May 23 2002. Needless to say we are running late...