1 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
3 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
4 X session is killed (for my computer... it seems to not be identic on
7 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
8 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
9 avoid problems (otherwise, the difference test between the visible image
10 and the reference is incorrect. If the reference is greater than the
11 screen resolution, it's produce errors).
12 Can be used for only one image. Can be used with a visible flag.
13 * vtk/vtkGdcmReader.cxx : remove commented codes.
14 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
15 under windows at compilation
16 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
18 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
20 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
21 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
22 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
23 tests on the image size X, Y, Z
25 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
26 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
27 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
28 between the class name and the file name
30 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
31 * src/ : fix compilation warnings for the Write method (2 different
32 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
33 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
34 variable... create a static method in gdcm::Document to access to
35 this variable content.
37 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
38 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
39 file, to be accessed by other files (like gdcmFile). Remove commented
40 code. Move the change of the header to the gdcmFile, using the
42 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
43 To be sure of that (and simplify calls), the Write of the header now
44 gets a file name and not a file pointer (std::ifstream).
45 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
46 DocEntryArchive. Remove all open of the written file
48 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
49 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
51 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
52 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
53 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
55 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
56 some corresponding methods. Write correctly the file and check before
58 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
59 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
60 is now on RGB datas (as before my last commit
61 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
63 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
64 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
65 Add a print information of the type of the entry
66 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
67 It was in the gdcmFile, and all write have been regrouped
68 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
69 Write correctly all dicom files (in decompressed mode only at this time)
70 * Test/ : test on files are now made using Raw datas and not color datas if
72 * Example/PrintFile.cxx : add more printings
74 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
75 * Amelioration of code, remove some code copy. For the loading of
76 BinEntry (in gdcmDocument), add the test to verify if the file is already
79 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
80 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
81 remove a DocEntry in the header (push an empty DocEntry)
82 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
83 lines. Bug fix in the initialization of the PixelConvert and the
85 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
86 use in TestCopyDicom (now this test can run under windows... but fails)
87 * Test/TestCopyDicom.cxx : amelioration of the test :
88 - test the pixels written
89 - add test points to quickly find where is the error
90 - can set a file name input and output in arguments
91 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
92 amelioration of the test output
94 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
95 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
96 all replaced DocEntry's
97 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
98 Now, each needed DocEntry to modify is duplicated, modified and inserted
99 to the header using DocEntryArchive. Thus, after save, we can restore the
100 header initial state.
102 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
103 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
105 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
107 correct to copy it. The DictEntry is specified at the DocEntry creation,
108 then, it musn't change in the time.
109 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
110 header correctly. At this time, the change is only made for the first
111 level of the Document. In the future, it might consider sequences.
112 The change is made by replacing a DocEntry by an other that is created
113 outside the class. The old value is kept. When we restore the header
114 status, the added DocEntry is deleted and replaced by the old value.
115 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
116 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
117 set the write type to explicit VR, implicit VR or ACR. Add methods to set
118 the write mode to native, decompressed or RGB (but not used at this time)
120 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
121 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
122 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
124 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
125 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
126 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
128 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
129 set because already copied when copying the BinEntry's of the header
130 * Test/TestAllReadCompareDicom.cxx : remove warnings
132 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
133 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
134 Two problems appear when doing it :
135 - with the gdcmFile : when the GetImageData method is called, the pixels
136 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
137 datas (pixels). And each structure destruct the datas when it's
138 destructed. So we have two destructions for the same datas. To solve it,
139 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
140 datas or not. If it doesn't own datas, then they will not destroyed by
142 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
143 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
144 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
145 create a double destruction of the same DocEntry's. So, to solve it,
146 the TagHT is simply cleared and the DicomDir* elements are destroyed.
147 * TODO : add an entry concerning memory leaks in the DicomDir
149 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
150 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
151 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
154 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
155 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
156 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
157 after it have been deleted
159 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
160 * FIX: src/* fix the doxygen warnings.
161 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
162 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
163 was erroneously defined with a size of 15 instead of 16. [many thanks
164 to Jean Michel Rouet for pointing out this bug].
166 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
167 1. Finish merging JMR patch for writting DICOM from scratch
168 2. Fix -hopefully- bug with MONOCHROME and space vs null character
169 3. Use const ref when possible
170 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
171 5. A few more comments
172 6. CreateUniqueUID can now be called without parameter"
174 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
175 * ENH: Slightly bigger patch:
176 1. Getting toward full integration of JMR patch for writting dicom from scratch
177 2. Update Test to test part of this patch: CreateUniqueUID
178 3. File was not close properly in gdcmDict
179 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
180 5. Use of const ref instead of copy (speed issue)
181 6. Remove temporary (duplicate) string in TranslateToKey
182 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
183 8. Do not repeat virtual in subclasses
184 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
186 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
187 * Apply first patch toward better string comparison when dealing with broken
188 DICOM files. Essentially the string could be padded with a space instead
189 of a null character as defined by standard
191 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
192 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
193 because never used... and in the same time, that's remove some memory leaks
195 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
196 * src/gdcmFile.cxx : now delete the PixelConvert instance.
197 * In examples and tests : change the type of image data variables from void*
198 to uint8_t*. Remmove all delete on image data variables
200 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
201 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
202 Verify the file pointer value before open the file, and if it's not null,
203 a verbose message is generated.
204 Close correctly the file when the file isn't considered dicom-like. The
205 correctly close is a call to CloseFile.
206 When closing the file pointer, test if its not null to close the file.
207 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
208 file. For an uncompressed image, the copied datas correspond in the least
209 case to the image size (calculated) or the image size specified in the
210 header. A verbose is generated if these two size mismatch
212 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
213 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
214 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
215 break under windows (with msvc6 compilation).
217 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
218 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
219 compiling with MSVC6)
221 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
222 * Bugs fix for the Windows build with VC6
223 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
224 needed (only for projects required VTK). If the VTK is included in all
225 projects, there is conflicts with the jpeg lib of vtk when compiling the
226 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
227 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
228 when compiling the gdcm_wrap.cxx file (created by the compilation of the
230 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
231 (like it's already made for the cout use). Otherwise, conflict with the
234 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
235 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
237 - comments on the DicomDir::Method related usage added.
238 - now that we use the namespace gdcm, a lot of internal classes do
239 NOT need to be wrapped anymore.
240 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
241 DicomDir::Method) new example added.
243 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
244 * Improve string manipulation. I now inforce the notion of 'DicomString'
245 A DicomString can contain as many \0 as they want
246 and it is *always* of even length.
247 We only support odd length for very rare case.
248 And in the near future this should be removed.
250 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
251 * /binary_write/ gdcm source. Now even on big endian we are writting
252 little endian. This should -heopfully- fix some tests
254 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
255 * Now the dictionary is compiled into gdcm lib. This is a default
256 behavior, thus any dic file specified is picked before failback to
257 the one comiled into lib
259 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
260 * Change internals for gdcmDict. Don't use any 'new' any more.
261 This should definitely solve any leak problem, and we should be
262 as fast as before, as long as don't modify too much the dictionary.
264 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
265 * STYLE: ivars should start with a capital letter.
266 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
267 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
269 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
270 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
271 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
272 new 2004 dictionaries added (thanks to JPR).
273 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
274 * CLEANUP_ROUND (15) for gdcmPixelConvert
275 - RLEFrame::NumberFragments is now of type unsigned int
276 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
277 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
280 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
281 * Initial work in gathering all transfer syntax accessors. clearly
282 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
283 ivars, but only one transfersyntax (class) ivar with equivalent method on
286 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
287 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
288 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
289 discussed (plus I didn't like having a 2000 lines patch not commited)
291 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
292 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
293 * CLEANUP_ROUND (14) for gdcmPixelConvert
294 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
295 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
296 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
298 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
299 anymore and hence avoids storing a copy of PixelConvert::Decompressed
300 into File::Pixel_Data.
302 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
303 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
304 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
305 * CLEANUP_ROUND (13) for gdcmPixelConvert
306 Substituted File::ParsePixelData() with PixelConvert::Print() new
308 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
309 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
310 method to those classes.
311 - src/gdcmFile.[cxx|h]:
312 -- Added a ::Print() method.
313 -- PixelConverter is now a reference instead of a member.
314 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
315 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
317 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
318 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
319 collaboration diagram and inheritance diagram should be generated with
321 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
322 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
323 pointlessly wrapped (see
324 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
325 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
326 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
327 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
328 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
329 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
330 -- File::Initialise: PixelConverter setup moved away to
331 PixelConverter::GrabInformationsFromHeader()
332 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
333 interpretation moved away to PixelConverter::BuildRGBImage()
335 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
336 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
337 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
339 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
340 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
341 displayed on Win32 when a brutal abort() occurs (because of uncatched
342 exception). See TODO new entry of this commit for more on this.
343 * TODO added new entry.
344 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
345 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
346 - HandleColor is no longer called from gdcmFile.cxx
347 - gdcmPixelConvert.cxx clean up on method arguments and internal
348 variable names for semantical coherence.
350 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
351 * Finished lossless transition, not only do we now read all lossless jpeg
352 images, without the need of the Cornwell lib, but we do read them properly now
353 * To reduce code (well to avoid code duplication), I defined a common place
354 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
355 redefine symbols. This is not prefect but this the best solution I found for a
356 compilation time jpeg option.
358 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
359 * Update jpeg ijg lib to support lossless jpeg implementation
360 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
362 * Also added a special copyright for dcmtk since we use their bugfixes.
365 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
366 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
367 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
368 matters, as stated in warning note at begining of %include section).
369 * src/gdcmDicomDir*.[cxx|h]: coding style
370 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
371 * src/gdcmJpeg8.cxx: doxygen fix.
372 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
373 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
374 from File:: to PixelConvert::.
376 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
377 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
378 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
379 - more code moved away from File:: to PixelConvert::
380 - fat setup of PixelConverter set in place in File::Initialise.
382 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
383 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
384 namespace at the file system level. So now you should convert your examples
386 gdcmHeader -> gdcm::Header
387 It would be nice if people keep in mind to no open the namespace, since it
388 allows compilation on broken plateform which were defining common symbol in
389 the standart namespace (like LP, Unknown ...)
391 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
392 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
393 The JPEG fragments are now parsed at the same stage than the RLE
394 information. All code related to JPEG is now in gdcmPixelConvert:
395 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
396 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
397 export a gdcmFile:: method. Those are simply global functions
398 (for the time being this is better than having them attach to
399 either gdcmFile:: or gdcmPixelConvert::).
400 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
401 and stores the result in a gdcmJPEGFragmentsInfo.
402 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
403 code (among other stuff) moved away from gdcmFile:; to
406 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
407 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
408 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
409 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
410 clean up of RLE related code.
411 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
412 - src/gdcmRLE.cxx removed
413 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
414 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
415 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
416 * CLEANUP_ROUND (9) for gdcmPixelConvert
417 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
418 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
419 away from gdcmFile:: to gdcmPixelConvert::.
421 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
422 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
423 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
424 This is because Parse7Fe0 used to parse the pixels to compute the
425 length. This task was passed over to FindDocEntryLengthOB() a long
426 time ago, EXCEPT I had forgotten the OW case...
427 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
428 we just recylce the code for parsing RLE fragments and computing
430 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
431 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
432 with the retired Parse7Fe0().
433 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
434 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
436 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
437 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
438 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
439 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
440 - src/CMakeLists.txt: alphabetic order reodering + new entries.
441 * CLEANUP_ROUND (4) for gdcmPixelConvert
442 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
443 to return an unused length.
445 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
446 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
447 this should be cleanner from the plane view. The iostream are erally a pain
448 to use to do simple stuff.
450 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
451 * Redo the compilation of the ijg jpeg library. Now only one source is
452 necesseray. No need to rename file by hand what so ever. CMake handle the
453 copying of the file within different directory, configure header file to
454 modify some symbol. The only addition made to ijg wasd a mangle table so
455 that symbol are different wether we are within 8bits or 12bits.
457 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
458 * Added documentation of vtkgdcmReader on Website:
459 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
460 with it's binary name).
461 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
462 the Website to be more complete.
463 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
464 doxygenated documentation.
465 - Doc/DoxyVtkGdcmReaderExamples.txt added
466 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
467 DoxyVtkGdmReaderExamples.html )
468 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
469 * CLEANUP_ROUND (3) for gdcmPixelConvert
470 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
472 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
473 * CLEANUP_ROUND (2) for gdcmPixelConvert
474 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
476 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
477 * CLEANUP_ROUND for gdcmPixelConvert:
478 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
479 - src/gdcmPixelStuff[h|cxx] removed
480 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
481 - src/CMakeLists.txt changed accordingly
483 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
484 gdcmVersion.py moved to newly created ATTIC related
485 gdcmPython/SetupOldies/ directory.
486 * Autotools clean up:
487 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
488 - autogen.sh configure.in acinclude.m4 python.m4 removed
490 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
491 * src/*.cxx *.h Reference to License.htm fixed to License.html.
492 * Doc/CMakeLists.txt, doxygen.config.in: fix.
493 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
495 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
496 * TODO updated with Mathieu suggestions. I proposed a template for
497 describing TODO entries and used it for new entries.
498 * Added Doc/Website/CodingStyle.html, Developpers.html,
499 DeveloppersPython.html, GdcmDataCvs.html and
500 DownloadVersion0_1.html, DownloadVersion0_3.html.
501 * Some Doc/*.txt Doxygen files (which do not really concern the
502 documentation itself, but the website) moved to html and
503 placed in directory Doc/Website:
504 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
505 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
506 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
507 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
508 * CMakeLists.txt changed accordingly.
509 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
510 DeveloppersPython.html
511 * INSTALL nows refers to Doc/Website/Installation.html
513 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
514 * Added Doc/Website directory, that contains a first raw version
517 2004-09-23 Jean-Pierre Roux
518 * FIX In order not to be poluted any longer by casting problems,
519 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
520 we can now delete[] it safely
521 * VoidArea is now called BinArea (less confusing name),
522 and all the methods called ...VoidArea... are now ... BinArea...
523 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
525 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
526 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
527 clear) TagHT, which is an inherited member of gdcmElementSet. It is
528 up to the destructor of gdcmElementSet to clean up TagHt and it's
531 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
532 * Test/CMakeLists.txt: update to follow gdcmData renamings.
533 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
535 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
536 * ENH: added some utility method that builds a flat dictionnary
537 holding all the Dicom entries contained in the recursive structure
538 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
540 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
541 BuildFlatHashTable() that build a flat dictionary.
542 - src/gdcmElementSet.h: added a new private GetTag() accessor.
543 gdcmDocument is now a friend of gdcmElementSet.
544 - src/gdcmElementSet.cxx: clean up.
545 - Example/FlatHashTablePrint.cxx added.
546 - Example/CmakeLists.txt changed accordingly
548 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
549 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
550 moved away from gdcmDocEntrySet (since this class is an abstract class
551 acting like an interface). SQDepthLevel and BaseTagKey are now
553 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
554 and associated accessors. Doxygenation of the class.
555 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
557 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
558 Use SQDepthLevel accessor instead. ::Print() adapted.
559 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
560 - src/gdcmDocument.cxx changed accordingly.
562 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
563 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
564 - The following is the doxygen comment of the typedef declaration
565 of gdcmagKey in src/gdcmCommon.h:
566 gdcmTagKey is made to old an "universal" (as in URL, Universal
567 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
568 A dicom tag allways has a group and an element, but a set of tags
569 embeded in various (optionally nested) sequences and sharing
570 the same group and element all share the same (group, element)
571 "identifier". Hence the (group, element) cannot be used as an
572 identifier (in gdcm we shall refer to a "TagKey") of a tag.
573 In order to construct a proper tag identifier (i.e. a key) we
574 consider the following definition of a TagKey:
575 - let Group, Element be the string representation of the
576 group and element dicom tag members,
577 - let ItemNumber be the string representation of the integer
578 index of the considered item number of a sequence,
579 Let the key of a tag embeded in a sequence, noted SeqTag, be
581 /ItemNumber#Group|Element
582 where "/", "#" and "|" are characters acting as separators.
583 Then the general form of a gdcmTagKey is given by:
584 Group|Element<SeqTag>
585 where <SeqTag> means NO or many instances of SeqTag.
586 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
589 but the gdcmTagKey of a tag "embeded" is the first item of
590 a sequence, itself nested in the third item of a sequence is the
592 0004|1220/2#0008|0082/0#0008|0090
593 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
594 order to hold the new sequence compatible key. Previously, the
595 GetKey() method would look in the underlying gdcmDictEntry.
596 - src/gdcmDocEntry.cxx:
597 -- constructor now copies the underlying DictEntry key, in the local
599 -- ::Print: displays the member Key, instead of the (group, element).
600 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
601 - src/gdcmDocEntrySet.h:xi
602 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
603 -- now has a new BaseTagKey member.
605 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
606 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
608 This poses the problem with the semantics of the following lines
609 LoadEntryVoidArea(0x0028,0x1201); // R LUT
610 LoadEntryVoidArea(0x0028,0x1202); // G LUT
611 LoadEntryVoidArea(0x0028,0x1203); // B LUT
612 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
613 to the long FIXME note for what the problem is. Nevertheless in
614 order to get things working the dicom dictionary was altered !
615 Please fix things urgently...
616 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
617 information), see above note on moving the member VoidArea. Nevertheless
618 the following entries previously correctly set as US are now inproperly
620 0028 1201 OW IMG Red Palette Color Lookup Table Data
621 0028 1202 OW IMG Green Palette Color Lookup Table Data
622 0028 1203 OW IMG Blue Palette Color Lookup Table Data
623 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
624 of gdcmDocEntry moved to gdcmSeqEntry.
625 * src/gdcmSeqEntry.cxx: STYLE.
627 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
628 * Test/TestAllEntryVerify.cxx minor fix and added comments.
630 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
631 * gdcmPython/testSuite.py: all the test suite in python is now moved
632 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
633 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
634 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
636 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
637 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
638 to avoid inclusion recursion until STL is reached.
639 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
640 mecanism. errno.h is not included in gdcm anymore.
641 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
642 (gdcmFormatError now inherits from gdcmFormatUnexpected).
644 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
645 gdcmData/TestAllEntryVerifyReference.txt
646 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
647 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
648 exception_on_error parameter.
649 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
650 - vtk/vtkGdcmReader.cxx changed accordingly,
651 - Example/*.cxx and Test/*.cxx changed accordingly.
653 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
654 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
655 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
656 enable_sequences removed from gdcmHeader constructor and dependencies.
657 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
658 * gdcmPython/demo/PrintHeader.py: dummy fix.
659 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
660 skip_shadow removed from gdcmHeader constructor and dependencies.
661 * Example/*.cxx and Test/*.cxx changed accordingly.
663 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
664 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
665 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
667 2004-07-21 Jean-Pierre Roux
668 * FIX Now, Parsing and Printing a DICOMDIR do work!
669 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
671 2004-07-20 Jean-Pierre Roux
672 * FIX Some brain damaged headers have Zero-Lenght fields
673 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
675 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
676 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
677 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
678 variable (instance of gdcmDebug) by a definition macro, and the instance
679 is now in static in the gdcmDebug class
680 * src/gdcmSQItem.h : (FIXME) remove an undefined method
681 * Test/PrintAllDocument.cxx : bug fix in the result of the test
683 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
684 * WARNING: ctest now depends more tightly on gdcmData. You should
685 check out gdcmData properly for things to run smoothly...
686 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
687 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
688 we need the pixels not be loaded in order to use the ValEntry
689 that displays position and size).
690 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
691 This is a C++ based equivalent of gdcmPython/testSuite.py that should
692 be deprecated. If you have any doubts about the advantages of a
693 modern scripting language (read Python) versus grass root C++ (i.e.
694 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
695 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
696 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
697 Anyhow, consider documenting the gdcmData images in
698 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
700 * Test/CMakeLists.txt:
701 - now uses TestAllEntryVerify.cxx
702 - specific comments on oldACR00001.ima (now renamed in gdcmData
703 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
704 gdcmData/TestAllEntryVerifyReference.txt
707 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
708 * src/*.[h|cxx] : typedef clean up
709 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
710 - TagKey renamed to gdcmTagKey (for external usage)
711 - VRKey renamed to gdcmVRKey (for external usage)
712 - removal of typedef duplication.
713 - Removed all unecessary inline keyword from class inline definitions.
714 - Some method|function(void) declarations replaced with method|function().
715 * src/jpeg/libijg12/jdhuff12.c:
716 - printf polluting ctest removed.
717 - TAB removal for comminting
719 - TestAllReadCompareDicom.cxx: added a test that compares all the
720 images in gdcmDataImages.h with corresponding images in
721 gdcmData/BaselineDicom/. When baseline images are not present
722 this test creates them.
723 Note: we need to validate each reference image, but before that
724 I'd like to rename them with a more explicit name...
725 - CMakeLists.txt: changed accordingly.
726 * Example/*.cxx: examples now only include gdcm.h (as opposed to
727 including each header needed).
729 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
730 * Test/*.cxx and Example/*.cxx: moved some examples away from the
731 test suite to the Example directory. Are concerned:
736 - TestWriteSimple.cxx
737 * Test/CMakeLists.txt: added some comments on reasons for black listing
738 image gdcmData/oldACR00001.ima
740 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
741 * Test/CmakeList.txt: removed the following from black list (to be coherent
742 with removal from gdcmData):
743 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
744 - gdcm-MR-PHILIPS-16.dcm
746 Added the following because after last cvs update, they cause
747 ctest -R TestReadWriteReadCompare
749 - gdcm-MR-SIEMENS-16-1.acr
751 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
752 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
753 new comments in this file) we temporarily (sigh) move to a weaker
755 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
756 we don't need to black list the following images anymore:
757 - 8BitsUncompressedColor.dcm
759 - US-PAL-8-10x-echo.dcm
760 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
761 fixes and the beautified code ;-)
762 This fixes the bug introduced in version 1.42 (when beautifying)
763 that made the parsing of 8BitsRunLengthColor.dcm unproper.
764 Note: ctest was blind to this bug (this means we need to still
765 improve the test suite). The bug could be detected by using
766 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
768 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
769 and by displaying the (garbage) produced file temp.XDCM...
771 2004-06-29 Jean-Pierre Roux
772 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
773 - replace by uggly but working old code :-(
774 A lot of things should be OK again.
775 It's really urgent to have a test suite that *tests*,
776 to prevent Frog's beautifying sessions to break all the stuff
777 (twice, withing a fortnigh ...)
779 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
780 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
781 redundancy) to added Test/TestReadWriteReadCompare.cxx
782 * Test/CmakeList.txt: because the compare test of
783 Test/TestReadWriteReadCompare.cxx fails, the following images are
784 black listed: - 8BitsUncompressedColor.dcm
786 - US-PAL-8-10x-echo.dcm
787 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
788 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
789 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
790 and ad-hoc kludge. This kludge is now removed, and on encountering
791 such an image (OB field brain damaged) we set errno. Then in
792 ::FindDocLength() we "fix" the length as being ALL what remains
793 in the file (until EOF). We then proceed, hoping for the best...
794 This fixes a SegFault in ShowDicom when trying to write such an
796 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
797 (because TestWriteRead breaks on it, after a non conformal commit?).
798 ctest now runs properly, except for MakeDicomDir (which was allways
799 broken) and the Python related stuff (still not fixed).
801 2004-06-24 Jean-Pierre Roux
802 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
803 FIX : Test/TestReadWrite now iterates on all the file names
804 (instead of infinite loop)
805 ENH : Test/TestWriteRead now iterates on all the file names
807 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
808 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
810 2004-06-24 Jean-Pierre Roux
811 FIX : - now Write drops LUT Descriptors and LUTs (if any)
812 when SamplesPerPixel =3
813 - now Write is no longer confused by
814 'BitsAllocated = 12" and 'BitsStored=12"
815 - "UN" value representation Elements are now written correctly
816 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
817 ENH : - now gdcmHeader has its own Write methods
818 (in order to split the job that has not to be done
821 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
822 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
823 loop on the same image until memory went out.
824 Note: this means we still have gobs of memory loss in PrintDocument
825 * src/gdcmDocument.cxx: fixes problem on parsing on file
826 gdcmData/16BitsJpegLosslessGrayScale.dcm.
828 2004-06-24 Jean-Pierre Roux
829 FIX : Write - All the Sequences and Sequence Item are now written
830 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
831 is added a the end, when necessary.
832 - A lot of brain-damaged images, that were read correctly are
833 now written correctly
834 - length compatible BinEntry are now loaded correctly
835 (even for odd groups)
836 Note : only Explicit Value Representation was checked.
837 (question : is implicit VR really necessary for gdcm ?)
839 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
840 * DEVELOPPER: added a proposition of coding style.
841 * src/gdcmDocEntry.h: removed every inline declaration (for test of
844 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
845 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
846 Use the gdcmDocEntry::Print() and Write() instead.
847 * src/gdcmDocument.cxx: bug fix.
849 2004-06-22 Jean-Pierre Roux
850 FIX : gdcmDocument.cxx
851 - Now we do recognize the JpegLossLess format (there was a misstyping in
852 code 'beautyfication' :-(
853 - Now we automaticaticaly load the Luts, if any
855 2004-06-22 Jean-Pierre Roux
856 In order : to write Sequences, whatever their imbrication level,
857 : to allow user to create his own Sequences
858 a lot of modif where necessary (adding, moving, or virtualising methods)
860 WARNING : save your own sources *before* cvs up !
863 ADD virtual void Write(FILE *fp, FileType filetype);
866 ADD virtual void Write(FILE *fp, FileType filetype);
867 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
870 ADD virtual void Write (FILE *fp, FileType filetype)=0;
871 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
872 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
873 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
874 ADD std::string GetEntryByName(TagName name);
875 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
877 std::string vr = "unkn",
878 std::string fourth = "unkn",
879 std::string name = "unkn");
880 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
881 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
882 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
883 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
884 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
885 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
886 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
887 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
890 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
891 ADD virtual std::string GetEntryByName (TagName tagName);
892 ADD virtual std::string GetEntryVRByName (TagName tagName);
893 REM virtual bool Write(FILE *, FileType);
894 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
895 FILE *_fp, FileType type);
896 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
897 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
898 REM virtual bool WriteEntries(FILE *_fp,FileType type);
899 REM virtual std::string GetEntryByName (std::string tagName);
900 REM virtual std::string GetEntryVRByName (std::string tagName);
901 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
902 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
903 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
905 std::string vr = "unkn",
906 std::string fourth = "unkn",
907 std::string name = "unkn");
908 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
909 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
910 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
911 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
914 ADD virtual void Write(FILE *fp, FileType filetype);
917 ADD virtual void Write(FILE *fp,FileType filetype);
920 ADD virtual void Write(FILE *fp, FileType filetype);
921 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
922 REM std::string GetEntryByNumber(guint16 group, guint16 element);
923 REM std::string GetEntryByName(TagName name);
926 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
928 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
929 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
930 The default constructor invoked by the line
931 gdcmHeader *f1 = new gdcmHeader( header );
932 was gdcmHeader::gdcmHeader(bool) instead of the expected
933 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
934 Hence the parsing wasn't executed... See also below.
935 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
936 as explicit constructor didn't do the trick to fix the above problem.
937 Could anyone explain why ?
938 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
939 properly calls gdcmValEntry::Print() (that was weed out from
940 code related to gdcmBinEntry).
942 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
943 * In order to fix memory leaks:
944 - Test/TestWriteSimple.cxx: added cleaning of free store through
946 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
947 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
948 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
949 (through the call to ::AddDicomDirMeta()) or the destructor
950 would crash when deleting uninitialized ::metaElems].
951 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
952 - src/gdcmDocument.cxx:
953 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
955 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
956 was causing memory leaks.
957 - src/gdcmSQItem.cxx:
958 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
959 cleanly handled with polymophism: sorry but my milage is low).
960 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
961 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
962 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
963 This avoids SegFaulting.
964 - src/gdcmSQItem.h: coding style.
966 - Test/TestWriteSimple still severely sucks. The output image content
967 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
968 damaged when displayed with vtkgdcmViewer.
969 - on memory leaks: TestWriteSimple leaks really less (see entry
970 of 2004-06-18 in Changelog file for the call to valgrind).
971 - on segfaults: ctest now passes all the tests but one (no more
973 * Erroneous leading white fix:
974 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
975 white[s] (as opposed to from >> xxx, that removes it [them].
976 - src/gdcmTS.cxx: ditto.
977 - gdcmPython/testSuite.py: dirty related kludge removed.
978 * src/*: remaining references to gdcmParser removed.
979 * src/*[cxx|h]: added copy[way]left header.
982 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
983 * In order to fix writing of dicom files:
984 - Test/TestWriteSimple.cxx: a simpler example of writing.
985 - Test/CMakeLists.txt changed accordingly.
986 - src/gdcmDocument.cxx:
987 -- The destructor now recursilvely removes potential sequences.
988 -- Bug fix in ::IsJPEG2000()
989 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
990 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
992 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
993 to only declared) and build on top of
994 ::GetDocEntryByNumber(guint16, guint16).
995 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
996 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
997 for usage in destructor and treatement of promotion in
998 ::ReplaceOrCreateByNumber().
999 - src/gdcmSQItem.cxx: destructor should better handle his job.
1000 Test/TestWriteSimple now runs (or at least it DOES something).
1001 * We can now start hutting memory links. A good starting point is:
1002 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1003 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1004 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1006 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1007 * Valgrind note: after Mathieu Malaterre teached me how to read
1008 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1010 Using gcc, you can force the STL to use malloc and to free memory as
1011 soon as possible by globally disabling memory caching.
1012 With 3.2.2 and later, you should export the environment variable
1013 GLIBCPP_FORCE_NEW before running your program.
1014 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1015 simply vanish (it is still not clear to me, whether this means that
1016 STL std::string leaks or if valgrind believes it leaks...).
1017 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1018 running bin/gdcmTests makeDicomDir):
1019 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1020 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1022 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1023 SegFaulting (I drowned in DicomDir related code when trying to
1024 understand why the list is empty...).
1025 * src/gdcmDocument.h: first BSD license header try.
1026 * Doc/License.txt added.
1028 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1029 * src/gdcmDocument.[h|cxx]:
1030 - Clean up of the Transfer related predicates. They are now all based
1031 on new method isGivenTransferSyntax, that (should) handle properly
1032 the padding problem.
1033 - general clean up, simplification, and coding style.
1034 - Specific clean up of Parse7FE0() (umproperly named actually).
1035 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1037 2004-06-14 Jean-Pierre Roux
1039 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1040 - fix the display of SQItem ordinal number
1041 - add the GetSQItemByOrdinalNumber method
1042 - remove some useless never written private methods
1044 2004-06-14 Jean-Pierre Roux
1046 - adding a constructor taking a gdcmDocEntry as an input param
1047 - ReplaceOrCreateByNumber now returns :
1048 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1049 a gdcmValEntry * if a string value is passed as a param
1051 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1052 according to the param type (no longer sets a gdcmDocEntry)
1053 - GetValEntryByNumber, GetBinEntryByNumber added
1054 - NewValEntryByNumber and NewBinEntryByNumber added
1056 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1058 - GetSQItemNumber and SetSQItemNumber added, to provide
1059 a (relative) Item identier inside a given Sequence
1060 \warning : some pb remaining around this number
1062 - AddEntry now takes the Item Number as a param
1064 - adding a constructor taking a gdcmDocEntry as an input param
1066 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1067 * Memory leak hunt with the following command:
1068 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1069 --show-reachable=yes gdcmTests PrintDocument
1070 It looks like many (all?) leaks are due to the STL (or a bad usage
1071 of the STL. The lines producing the leaks now have a comment with
1072 a "MEMORY LEAK" tag: you can retrieve them with
1073 grep "MEMORY LEAK" src/*
1074 Here are two typical examples which I can't help fixing:
1079 char * test = "babo";
1080 name = test; //// <--- valgrind detects 960 bytes lost in
1081 //// call to std::string::operator=(char const*)
1082 name.clear(); //// Doesn't help !
1090 std::cout << "Type a bunch of characters followed by RETURN: ";
1091 getline(std::cin, line); //// <--- valgrind dectects a loss
1092 //// of 1320 bytes in call to
1093 /// std::basic_istream<>& std::getline<>
1099 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1100 * src/gdcmHeader.[cxx|h]:
1101 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1102 and related, moved away to gdcmDocument.
1103 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1104 the corresponding protected accessors of inherited class
1105 gdcmDocument, removed ! As a consequence gdcmFile had to be
1106 declared friend of class gdcmDocument (see below).
1107 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1108 - Clean up of undefined or unused methods.
1109 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1110 account the changes to gdcmHeader.h).
1111 * src/gdcmDocument.h:
1112 - gdcmFile is now a friend class (in order to take into account the
1113 changes to gdcmHeader.h).
1114 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1115 (see changes to gdcmHeader.h).
1116 - Accessors (reading on the form GetEntry*) are now public.
1117 - Clean up of undefined or unused methods.
1118 * src/gdcmDocument.cxx:
1119 - adaptation to changes to gdcmDocument.h
1120 - ::OpenFile now writes a verbose message when file cannot be opened.
1121 - some std::string properly set to VRKey
1122 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1123 references to gdcmDocument.
1124 * Test/TestFindTags.cxx: changed accordingly to above changes.
1125 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1126 cvs repository gdcmData.
1128 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1129 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1130 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1131 conflicts with gdcmValEntry::voidArea.
1132 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1133 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1134 Value representation between StringRepresentable and BinaryRepresentable.
1135 * src/gdcmDocument.cxx:
1136 - method ParseDES: proper indentation restored and usage of
1137 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1138 - method LoadDocEntry: the fingerprint left in the SetValue() of
1139 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1140 removed. Reverting to previous code segment with the proper
1141 dynamic_cast< gdcmValEntry* >.
1142 Note: this was (partially) breaking the python test suite
1143 (gdcmPython/testSuite.py) that made usage of the above
1144 fingerprint to check presence of "Pixel Data".
1145 * src/gdcmDocEntry.h: coding style.
1146 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1147 now taken into account.
1148 * gdcmPython/gdcm.i: adaptation to the new internal representation
1149 of gdcm (exit gdcmParser, hello gdcmDocument).
1150 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1152 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1153 anymore, but instead prints the loaded Python dictionary.
1154 * .... alas, the python testSuite is still broken.
1156 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1157 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1159 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1160 * src/gdcmUtil.h : export methods
1162 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1163 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1165 * Initial addition of automatic python testing
1166 * Initial addition of automatic image comparison
1168 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1169 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1170 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1172 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1173 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1174 * Test/ShowDicom.cxx : bug fix for msvc compilation
1175 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1177 2004-05-04 Jean-Pierre Roux
1178 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1179 new concepts (and new classes) :
1180 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1181 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1182 - Sequence Doc Entries (gdcmSeqEntries)
1183 a Sequence is composed of Items.
1184 Each item is a set of Doc Entries (this is recursive)
1185 The non uniqueness of the 'Dicom tag' is due to this recursivity
1186 (never taken into account)
1187 Our unability to add a new 'entry' in the header
1188 at the proper location (neither in the H-Table (map or multimap),
1189 nor in the Chained List is also due to this recursivity.
1190 Don't try, right now, to use/modify/compile these new sources :
1191 nothing is finished.
1192 We just commit all the stuff, 'as is', in order not to loose it.
1194 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1195 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1197 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1198 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1199 file prefix (SetFilePrefix)
1201 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1202 * Add a new test: ShowDicom, for now this is just the c++ version of
1203 checkRead.sh, later it will be able to compare the image read against a
1205 * Replace the DEBUG on the stack with a global entry in cmake interface:
1206 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1208 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1209 * Add an example subdir, with a real example on how to read + write a
1212 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1213 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1214 * Doc/CMakeLists.txt: the main page is now properly differentiated
1215 between the developper and user version.
1216 * Doc/doxygen.config.in: dropped search related obsolete flags
1217 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1219 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1220 * DEVELOPPER: added some helpfull comments for compile/test/install
1223 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1224 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1225 src directory, now generated in the build dir.
1226 2. Tests as mentionned smarter
1228 4. Add a new method in gdcmDict that return the PubDict by name
1229 this is interesting for 3rd party lib like ITK,
1230 where we could set the institution name / patient name...
1232 * ENH: 1. Now the test suite is working for real
1233 2. All binaries are now output in the gdcm-bin directory
1234 (this was not true before)
1236 2004-04-28 Jean-Pierre Roux
1237 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1238 SeQuence indented printing of Dicom Header.
1239 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1240 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1241 Computation of SQDepthLevel is now part of gdcmHeader constructor
1242 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1243 tree-like structure of a Dicom Header.
1244 * FIX Test code cleaning
1246 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1247 * ENH: Adding automatic testing
1248 1. Need a DartConfig.cmake to submit to public
1249 2. Add a test driver gdcmTest.cxx
1250 3. gdcmTestMain, an helper for the main test driver gdcmTest
1251 4. Files in Test don't have a main anymore, this becomes interesting
1252 when we add more and more tests, thus dsw don't have to load
1254 * ENH: Adding a GDCM_DATA_ROOT for testing
1255 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1256 one file instead of seven + some small cleanup
1258 2004-04-22 Jean-Pierre Roux
1259 * ENH Minor changes to the Print() methods.
1260 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1261 Header printing. Example given with :
1262 > PrintHeader fileName 2 new
1263 (SQ based tree-like structure still to be done for the Header ...)
1265 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1266 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1267 1. I have added some unsigned where needed
1268 2. Some function parameter not used -> (void)
1269 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1270 4. g++ don't like character '\' in comment
1271 5. #define jpeg_create_decompress jCreaDecompress
1272 this really need to be fixed
1273 6. virtualize destructor of gdcmObject ... leakage
1274 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1275 this also really need to be fixed
1276 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1277 remove compression file
1278 (as we only do decompression, right ?)
1279 * ENH: Change malloc/calloc/free with c++ equivalent
1281 2004-04-21 Jean-Pierre Roux
1282 * FIX gdcmHeaderHelper::GetXSpacing
1283 when a single value is found (bug ?), xpacing is now
1284 defaulted to yspacing
1286 2004-04-19 Jean-Pierre Roux
1287 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1288 * ENH add parameters :
1289 bool exception_on_error = false,
1290 bool enable_sequences = false,
1291 bool ignore_shadow = false
1292 to the gdcmFile constructors to be full gdcmParser compliant
1293 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1294 to allow reading of PAPYRUS 3.0 files
1296 2004-04-06 Jean-Pierre Roux
1297 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1299 2004-04-02 Jean-Pierre Roux
1300 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1301 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1302 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1304 2004-03-30 Jean-Pierre Roux
1305 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1306 for ACR file, written out as DICOM files (hope so...)
1308 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1309 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1310 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1311 moved to base class gdcmParser and only the specialisation is kept
1313 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1314 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1315 already does the job.
1316 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1317 (to be consistent with gdcmParser::WriteEntries).
1319 2004-03-30 Benoit Regrain
1320 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1321 upate of the object's instance. It's passed to 2 in the unfavorable
1322 case : one in the ExecuteInformation, one in the ExecuteData
1324 2004-03-29 Jean-Pierre Roux
1325 * ENH : Check on file type to be written moved
1326 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1327 * FIX : gdcmObject::ResetBoundaries now stops properly
1328 when end-of-list is reached
1329 : gdcmVersion modified (as Benoit Regrain asked)
1331 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1332 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1333 * src/gdcmUtil.cxx: added forgotten iostream include.
1334 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1335 equivalent to ExplicitVR in existing code).
1337 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1338 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1339 now contains all the gdcmGlobal related code.
1340 * minor coding style and doxygenation changes.
1342 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1343 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1344 now contains all the Debug related code.
1345 * minor clean-up of includes in src/*.cxx
1346 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1347 CreateCleanString) removed.
1348 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1349 * Doc/DoxyMainPageUser.txt added.
1350 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1351 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1352 src/gdcmDirList.cxx)
1354 2004-03-24 Jean-Pierre Roux
1355 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1357 2004-03-23 Jean-Pierre Roux
1358 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1359 big endian made volumes
1360 * ENH Now gdcmParser constructor and destructor are protected to forbid
1361 end user to instanciate class gdcmParser
1362 (only gdcmHeader and gdcmDicomDir are meaningfull)
1364 2004-03-22 Benoit Regrain
1365 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1366 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1367 gdcmSerie to gdcmDicomDirSerie
1369 2004-03-19 Jean-Pierre Roux
1370 * ENH Now the tree-like structure describing a DICOMDIR comming from
1371 an already existing DICOMDIR file is consistent with
1372 the home-made tree-like structure build ex-nihilo
1373 or build from the files held (recursively) in a Directory
1374 functions gdcmDicomDir::CheckBoundaries()
1375 gdcmObject::SetBoundaries() added
1377 2004-03-17 Jean-Pierre Roux
1378 * REM (Eric Boix bug) : removal of meaningless
1379 gdcmDicomDirImage::NewImage function.
1380 * FIX now file names and directory name are written properly in the
1382 * FIX now gdcmDicomDir constructor may be call without any trick
1385 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1386 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1387 of gdcmDicomDirImage::NewImage as empty function.
1389 2004-02-28 Jean-Pierre Roux
1390 * ENH add gdcmDicomDir:NewPatient
1391 add gdcmDicomDirPatient:NewStudy
1392 add gdcmDicomDirStudy:NewSerie
1393 add gdcmDicomDirSerie:NewImage
1394 to allow making gdcDicomDir object.
1395 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1396 (as opposite to the gdcmHeader chained list)
1398 2004-02-11 Benoit Regrain
1399 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1400 when using from python
1402 2004-02-10 Benoit Regrain
1403 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1404 * FIX : in gdcmDicomDir when the directory is empty
1405 * ENH : add callback and methods to get the progression of dicomDir
1408 2004-02-06 Jean-Pierre Roux
1409 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1410 - GDCM_META added to gdcmDicomDirType
1411 - class gdcmMeta created
1412 * ENH : - A brief summary is now displayed at the beginning of
1413 'testDicomDir' to help disaster magnitude estimation
1414 * REM : Now useless Test/explDICOMDIR.cxx
1416 2004-02-05 Benoit Regrain
1417 * ENH : add methods in gdcmObject to get the hash table or the list of
1419 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1420 * FIX : wrapping python for TagHeaderEntryHT
1422 2004-02-04 Benoit Regrain
1423 * FIX : even length for some strings when writting the dicom dir
1424 * FIX : sort the images in the dicom dir
1425 * FIX : Bug fix for python use of dicom dir
1426 * ADD : a python demo
1428 2004-02-04 Jean-Pierre Roux
1429 * FIX : Final solution (?) for icone embedded images
1430 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1431 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1432 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1433 gdcmData/gdcm-MR-SIEMENS-16.acr1
1434 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1435 to make full checking easier
1437 2004-02-04 Benoit Regrain
1438 * FIX : WriteEntries : coding style & logic in parameters
1439 * FIX : Set the elements to create the DicomDir in a dictionary file
1441 2004-02-03 Benoit Regrain
1442 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1443 * gdcmDicomDir : add the load of directory
1444 * Bug fix and print add-on
1446 2004-02-03 Jean-Pierre Roux
1447 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1448 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1449 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1450 * FIX gdcmParser.cxx : 'group length' elements are now considered
1451 as integers, even for shadow groups, when file is Implicit VR
1453 2004-02-02 Jean-Pierre Roux
1454 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1456 of the last synonym :-(
1457 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1459 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1460 * FIX taking into account the possible 7fe0,0010 multiplicity
1461 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1462 to allow removal of references to 7fe0,0010, to deal with
1463 ACR-NEMA images, when 0028,0200 is meaningfull
1465 2004-01-31 Jean-Pierre Roux
1466 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1467 no longer writes 'Un' on disk
1468 * FIX SQ elements with actual length are now dealt with corectly
1469 * FIX gdcmFile::WriteBase make the difference, for color images, between
1470 the length (for Palette expanded images)
1471 and Raw Length (non expanded image + Palette)
1472 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1473 (that broke Write). Replaced by UL.
1474 Aware user will reload the field if he
1475 thinks it's necesssary
1477 2004-01-30 Jean-Pierre Roux
1478 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1479 when 'dirty Acr' is found, to be compliant with the new
1480 IsReadable() methods.
1482 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1483 (no DOUBLE images in kosher DICOM,
1484 but so usefull for people that miss them ;-)
1486 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1487 DICOMDIR related utilities (not checked as Windoze compliant)
1489 2004-01-28 Jean-Pierre Roux
1490 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1492 2004-01-27 Jean-Pierre Roux
1493 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1494 to allow skipping the shadow elements, to save memory space.
1495 The TRUE value for this param has to be used
1496 with a FALSE value for the 'enable_sequence' param.
1497 ('public elements' may be embedded in 'shadow Sequences')
1498 * gdcmHeader methods now deal with 'embedded icones images' in the header
1499 (even when an 'icone image sequence' is announced by the
1500 element (0x0088,0x0200), but there is NO icone at all ...
1502 * gdcmHeader sometimes Image Location value doesn't follow
1503 the supposed processor endianity (see gdcmData/cr172241.dcm).
1506 * gdcmHeader add the method
1507 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1508 to get *all* the Header Entries with the same tag.
1509 GetHeaderEntrySameName is probabely *useless*
1510 (no meaning : Name is *not* an identifier within the Dictionnary)
1512 2004-01-26 Benoit Regrain
1513 * Bug fix in the print of hexadecimal representations. Remove long fields
1514 in the print and add a third level of print to print them
1516 2004-01-23 Benoit Regrain
1517 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1518 * Bug fix on test suite after remove the strip made on not string fields
1519 * Split the IsReadable method between gdcmParser which test that the file
1520 is dicom and gdcmHeader which test that it's an image file
1522 2004-01-22 Benoit Regrain
1523 * DicomDir : clean code, add methods, set variables in protected or private
1524 * gdcmUtil : bug fix for the clean string method
1526 2004-01-19 Benoit Regrain
1527 * Add the use of shadow dictionaries
1528 * bug fix and coding style
1530 2004-01-19 Benoit Regrain
1531 * src/gdcmFile.cxx : bug fix concerning the close of file
1532 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1533 * Add the update of header entries using the shadow library
1535 2004-01-19 Benoit Regrain
1536 * removal of file gdcmHeader2.cxx
1537 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1538 inheriting from gdcmParser. This split is to prepare the integration
1539 of dicom dir parsing
1540 * bug fix under python
1542 2004-01-16 Jean-Pierre Roux
1543 * REM removal of class gdcmHeaderEntrySet
1544 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1545 * ADD add file gdcmHeader2.cxx
1546 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1548 2004-01-15 Benoit Regrain
1549 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1550 entries created while parsing the header. Thus, they will be destroyed
1551 when the gdcmDictSet will be destroyed
1552 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1555 2004-01-15 Benoit Regrain
1556 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1557 made a fatal error because of the memory release at the end of program.
1558 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1559 some memory and vtk seems to have some problems with that.
1560 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1562 2004-01-14 Benoit Regrain
1563 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1564 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1565 * src/*.[h|cxx] : make changes due to class name changes
1566 * gdcmPython/demo/*.py : bug fix due to method names
1568 2004-01-13 Benoit Regrain
1569 * src/*.[h|cxx] : coding style
1570 * vtk/*.[h|cxx] : coding style
1572 2004-01-13 Benoit Regrain
1573 * gdcmPython/testSuite.py : test the readable flag of file for tests
1574 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1575 It's lied to the stl compilation by MSVC (windows, always windows...)
1576 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1578 2004-01-12 Benoit Regrain
1579 * src/*.h : add comments
1580 * src/gdcmDictSet.h : set the method BuildDictPath in public
1581 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1582 directly setted in the source code
1583 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1586 2004-01-09 Benoit Regrain
1587 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1588 * setup.py : use a reference to gdcmVERSION
1590 2004-01-07 Benoit Regrain
1591 * Modification to compile with the distutils.
1594 2003-12-10 Benoit Regrain
1595 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1596 can use a gdcmHeaderHelper to load datas
1597 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1598 made in the source code
1600 2003-12-10 Benoit Regrain
1601 * Update Windows projects and .cvsignore files
1603 2003-11-12 Jean-Pierre Roux
1604 * ENH gdcmHeader constructor has one more parameter (default value : false)
1605 that allows the user to 'go inside' the SeQuences only
1607 gdcmElValSet:Print takes it into account
1609 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1610 * ENH: Update gdcmPython/CMakeLists
1611 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1612 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1614 2003-11-10 Jean-Pierre Roux
1615 * FIX : gdcmHeader::LoadElements is now based
1616 on the ListTag listElem member,
1617 not longer on the TagElValueHT tagHt member
1618 * ENH : PrintPubElVal shows (temporarily) both results,
1619 with the tagHt member and the listElem member.
1620 (it's easier to 'see' the problems when using Printheader)
1622 * FIX : old private member LgrElem is now splitted into
1623 ReadLength : Length actually found on disk (updated only
1624 if bug fixing is necessary), for internal
1626 UsableLength : Updated by FixFoundLength, to fix a bug
1627 or to allow Parser going on.
1628 Will allow to re-write a kosher header when a SeQuence
1629 with a length (not 0000) is found
1630 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1631 because gdcmElValSet::Add does not update ListElem
1634 2003-11-07 Jean-Pierre Roux
1635 * FIX misstyping in Transfert Syntax name table
1636 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1637 when they have an actual length (not 0000 nor FFFFF)
1638 (Nobody should care of it, but DICOMDIR explorers)
1640 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1641 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1643 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1644 * ENH: vtkGdcmReader now supports LUT !
1645 (vtkgdcmViewer for now is not able to use them though)
1647 2003-11-05 Jean-Pierre Roux
1648 * in testSuite.py : new files names for checking the package
1649 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1650 that returns the pixel area size to the *aware* (vtk) user
1651 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1653 2003-11-05 Benoit Regrain
1654 * in testSuite.py : Modify the rules for checking the paths
1655 : Explicit error messages
1656 * in __init__.py : Related modif
1658 2003-11-03 Jean-Pierre Roux
1659 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1660 to be used by aware (vtk) users that want to manage
1661 LUT (and no to turn the PALETTE image into an RGB pixels one)
1662 * GetPixelType now returns 8U for 24 Bits images
1663 (vtkGdcmReader compliant)
1665 2003-10-31 Jean-Pierre Roux
1666 * Removal of *all* gdcmData images and add them again
1667 in order to loose the 'history' of un-anonymised images
1669 2003-10-31 Jean-Pierre Roux
1670 * RMV : removal of useless jBitsInJsample.h
1671 for both 8 and 12 Bits JPEG Lossy Libraries
1673 2003-10-31 Jean-Pierre Roux
1674 * ENH : Add the functions gdcmFile::GetImageDataRaw
1675 gdcmFile::GetImageDataIntoVectorRaw
1676 that act as GetImageData and GetImageDataIntoVector
1677 except the making of an RGB Plane from Gray Plane + LUT
1678 Intended to aware (vtk) users who know how to manage
1681 GetLUTRGBA return a R,G,B,A LUT if any
1682 lgrTotaleRaw gives the 'Raw' length
1683 GetImageDataRaw returns the gray Plane
1684 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1685 (They stay Grey, just like with other Dicom viewers :-(
1687 2003-10-30 Jean-Pierre Roux
1688 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1690 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1691 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1692 being coherents dicom files.
1694 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1695 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1697 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1698 * ENH: Two steps is necessary to please VC++ compiler...
1699 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1700 * ENH: Add include dir to medcon lib
1701 * FIX: only one function is being exported for now !
1702 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1704 2003-10-29 Jean-Pierre Roux
1705 * adding gdcmHeader::GetLUTRGBA
1706 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1707 --> Mathieu, the modif u're waiting for is not yet committed
1708 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1710 2003-10-27 Jean-Pierre Roux
1711 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1712 00191113.dcm DermaColorLossLess.dcm
1713 MxTwinLossLess.dcm RadBWLossLess.dcm
1714 * ENH: For version prior to vtkImageViewer2 -r 1.19
1715 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1717 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1718 * Removal of ido stuff in CMakeLists.txt
1720 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1721 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1722 * FIX: remove a call to ->Modified ... see comments
1723 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1725 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1726 * FIX: Problem with path for libvtkgdcmPython
1727 * ENH: Try adding a search script for python site-package
1728 * RMV: Remove some file from medcon lib that are not necessary
1729 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1730 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1731 * FIX: More pragma disable fro VC++,
1732 I don't think I break something as it is also disable in VTK/ITK.
1733 But it fasten debug compilation time.
1735 2003-10-23 Jean-Pierre Roux
1736 * gdcm now deals with 16 Bits Run Length Encoded images
1737 (they are compressed as 2 planes images,
1738 one for the high Bytes, the other for low Bytes)
1740 2003-10-22 Jean-Pierre Roux
1741 * Now CheckRead takes into account :
1742 - the bugged 'Leonardo' Siemens images
1743 - the XA images, sent thru the burning VPRO station
1744 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1747 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1748 * FIX: When copying a Makefile.am to CMakeLists.txt
1749 one should remove the '\'
1751 2003-10-22 Jean-Pierre Roux
1752 * in gdcmData adding a bugged 'Leonardo' Siemens image
1753 (wrong lengths in header)
1754 OK with gdcm, KO with the other viewers :-)
1755 * add a GE dlx XA image, thru the VEPRO burning station
1758 2003-10-21 Jean-Pierre Roux
1759 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1760 for a brutal checking of vtkgdcmViewer compliance
1762 2003-10-21 Jean-Pierre Roux
1763 * add the files for 'xmedcon' Jpeg Lossless library
1764 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1766 2003-10-21 Jean-Pierre Roux
1767 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1769 2003-10-21 Jean-Pierre Roux
1770 * garbage Siemens 'Leonardo' images dealt with
1771 (the patch is easy to remove)
1772 * cosmetic changes to avoid warnings
1774 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1775 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1776 no need to press 'r' now.
1778 2003-10-20 Jean-Pierre Roux
1779 * upgrade of checkRead.sh checkWrite.sh according
1780 to new Jpeg Lossless decompressor
1781 * add US.3405.1.dcm, a genuine RGB medical file ...
1782 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1783 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1785 2003-10-15 Jean-Pierre Roux
1786 * general anonymisation in gdcmData
1787 * adding the 'color files' from
1788 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1789 * adding some well knowed bugged-header images
1790 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1791 waiting for their inclusion in Python testsuite
1793 2003-10-15 Jean-Pierre Roux
1794 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1795 no longer seg faults when file is not found
1797 2003-10-14 Jean-Pierre Roux
1798 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1801 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1802 * TODO: *.in file to genereate a UseGDCM later
1804 2003-10-14 Jean-Pierre Roux
1805 * Some supposed-to-be Dicom Images have no preamble.
1806 OpenFile takes it into account
1807 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1808 * Missing elements added in dicomV3.dic
1809 (just to be affraid : have a look at
1810 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1811 and do it again next year ;->
1813 2003-10-13 Jean-Pierre Roux
1814 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1815 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1816 But there are NOT. It's fixed !
1818 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1819 * FIX: "jpeglib.h" was not found on VC++
1820 * FIX: vtkgdcm was not being installed
1822 2003-10-10 Jean-Pierre Roux
1823 * ENH : OpenFile closes the file if it *really* doesn't look like
1824 an ACR-NEMA / DICOM one.
1825 * FIX : testWrite no longer writes an empty file if the source file
1826 is not gdcm Readable
1827 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1830 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1831 * FIX: CMake generate now documentation
1832 * ENH: out of source doc build !
1833 * ENH: Generate both user and dev documentation
1834 * ENH: Should work on windows too
1835 * ENH: Only one doxygen config.in file is needed
1836 * FIX: make install should be ok now on ùnix plateform
1837 * FIX: PATH to dictionary was wrong (missing /)
1838 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1840 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1841 * vtkGdcmReader is now able to read rgb dicom file.
1842 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1843 * added a gdcmViewer to vtk test, use mouse to control
1844 window level & window width
1846 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1847 * CMake-ification of gdcm, we have now two build system
1848 * FIX: on cygwin Wsock32 doesn't exist
1849 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1851 2003-10-06 Emanuel Ollart
1852 * FIX : compilation process wad broken.
1853 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1855 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1856 * change gdcmViewer -> vtkgdcmViewer
1857 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1859 2003-10-06 Jean-Pierre Roux
1860 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1861 ( e.g : well known GE images with a wrong elem length,
1862 : Philips MRI Images with a wrong Huffman table)
1863 * still to be done : allow the reading of bugged LEONARDO Siemens images
1865 2003-10-03 Jean-Pierre Roux
1866 * Odd length strings are padded with '\0' (not with spaces,
1867 to remain compliant with already defined strings,
1868 like Transfert Syntax UID and others)
1870 2003-10-03 Jean-Pierre Roux
1871 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1872 to allow displaying RGB images (not only by affim ;-)
1874 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1875 * vtkGdcmReader is now able to read rgb dicom file.
1876 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1878 2003-10-03 Jean-Pierre Roux
1879 * A few nasty patches to allow the reading of a lot of nasty images
1880 ( e.g : well known GE images with a wrong elem length,
1881 : Philips MRI Images with a wrong Huffman table)
1882 * still to be done : allow the reading of bugged LEONARDO Siemens images
1884 2003-10-03 Jean-Pierre Roux
1885 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1887 2003-10-03 Jean-Pierre Roux
1888 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1889 to allow displaying RGB images (not only by affim ;-)
1891 2003-10-03 Jean-Pierre Roux
1892 * gdcmFile::GetImageDataIntoVector now
1893 - deals with MultiFrames MultiFragments Run Length Encoded files
1894 - deals with YcBcR (YBR_FULL) files
1895 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1896 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1898 (no sample found :-(
1900 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1901 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1902 Two reasons: - clear things
1903 - third parties acces gdcm through header files, so won't
1904 suffer anymore VC++ complains
1906 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1907 * add argv[1] in testvtkGdcmReader.cxx
1910 2003-09-24 Jean-Pierre Roux
1911 * The lines are now eigthy characters long.for
1912 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1914 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1915 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1916 char* to std::string. Thus, the use of strdup becomes useless. (see
1917 previous commis of Malaterre)
1918 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1919 before the last Malaterre's commit.
1921 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1922 * This commit should fix the Debug building under VC++, the problem
1923 was mainly a mixture of debug and release lib being loaded at startup.
1924 * I also remove a depency to a specific C function: strdup. Because I had
1925 to force the link to msvcrtd (whereas strdup is in libc).
1927 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1928 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1929 located in the gdcmCommon.h file. All use of reference of tha has been
1930 changed to now use the variable GDCM_UNFOUND.
1932 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1934 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1935 Dicom dictionary. The test suite can now be run again. Note:
1936 I'm note very happy with the " (RET)" changes. I believe this
1937 RETAINED comment should be dropped when parsing the dictionary.
1938 - PACKAGER corrected
1940 - AUTHORS updated and now in alphabetical order
1941 * Makefile.am now exports gdcm.dsw for Windoze users.
1943 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1944 * cygwin complains about missing std:: in subdir Test/
1946 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1947 * remove some methods that are now in gdcmHeaderHelper
1949 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1950 * vtkGdcmReader set spacing and origin correctly
1952 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1953 * Fix a few delete/delete[] mismatch
1955 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1956 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1957 interpretation to data given by gdcmHeader. For instance there are
1958 heuristics to get informations (look at different places).
1959 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1960 sorting DICOM images based on different strategies.
1961 * modified Makefiles accordingly.
1963 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1964 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1965 when building in debug mode
1966 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1967 src/win32/gdcmdll.dsp
1968 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1970 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1971 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1974 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1975 * src/win32/libgdcmjpeg12.dsp was not dos format
1976 * src/win32/libgdcmjpeg12.dsp :
1977 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1978 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1980 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1981 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1983 * src/gdcmFile.cxx : bug fix in affectation type
1984 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1985 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1986 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1987 symbols... future problem ?
1989 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1990 * src/win32/libgdcmijpeg12.dsp was missing
1991 * modified gdcm.dsw accordingly
1993 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1994 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1996 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1997 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1998 commit of JPR (before his hollidays to facilitate our work).
1999 * setup.py : bug fix in code. Modifications made while the last commit
2000 of JPR. The code hasn't been tested before the commit... it's so
2001 useless to make that (for best programmer that is JPR) !!!
2003 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2004 * tagged the current version as Version0_3 (i.e. version 0.3)
2006 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2007 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2008 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2009 * *.dsp : modifications to use new libgdcmijpeg8 library
2010 * setup.py : bug fix on VTKPATH variable
2011 * PACKAGER : adding all concerning windows
2013 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2014 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2016 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2017 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2018 test suite reported error.
2019 * PACKAGER file added (describes what a packager must do when
2020 packaging a new release).
2021 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2022 * configure.in: upgraded version number to 0.3.0
2023 * fixing build of rpm (through rpm -ta):
2024 - Doc/Makefile.am exports proper doxygen files
2025 - src/jpeg/libijg8/Makefile.am exports the include files.
2027 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2028 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2029 * src/gdcmHeader.h : formatting code
2031 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2032 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2033 We were obtaining error message from vtk. Now, creation of file list
2034 is made in an internal list to prevent this problem.
2035 Bug fix when output is empty.
2036 Bug fix in update of progress value. Previous commit for this was a bad
2038 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2040 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2041 * src/gdcmHeader.h : added method to get the file name
2042 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2043 files. Added method to remove all files on the input
2044 Added FIXME comment concerning the bad parsing of header made by
2045 ExecuteInformation method (in ExecuteData method)
2047 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2048 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2049 when using make instal.
2050 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2051 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2053 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2054 * setup.py : adding include dir of jpeg lib to compile all sources
2055 * */Win32/*.dsp : JPR fix for windows compilation
2057 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2058 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2060 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2061 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2063 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2064 * setup.py is again effective on un*x (takes into account the
2065 addon of the jpeg library)
2066 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2067 * Doc/Doxy* updated (includes above enhancements)
2068 * INSTALL now points to web documentation
2070 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2071 * src/gdcmHeader.h doesn't make unnecessary reference to
2073 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2075 * src/gdcm*.[cxx|h] :
2076 - to allow compilation with gcc 3.x
2077 -- clean up of STL usage (added explicit usage of std::)
2078 -- small fixes on exceptions.
2079 Note: linking not tested !
2080 - clean of doxygen comments to avoid warnings at documentation
2082 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2083 dependent convertion).
2085 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2086 * Clean up of previous JPR garbage commit (not even commented in the
2088 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2089 - moved all jpeg related files from src to src/jpeg/libijg8, with
2090 addition/modification of Makefile.am and configure.in.
2091 - the testSuite is still brain damage (not guilty).
2093 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2094 * WrapVTK.py : modifications to get correctly vtk source files to
2096 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2097 (FileName -> Filename)
2099 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2100 * vtk/vtkGdcmReader.[cxx/h]:
2101 - UpdateProgress method should now be effective
2102 - removed the limitation on having only images loaded (as opposed
2104 - when building a stack of images/volume, a lesser number of
2105 gdcmHeader and gdcmFile instances should be used (hopefully
2106 accelerating things).
2107 - when building a stack of images/volumes, files which are not
2108 loadable (wrong path-filename, wrong permissions on existing file,
2109 or file not parsable by gdcm) are replaced with a black image
2110 in the stack (for the caller to notice the problem).
2112 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2113 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2115 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2116 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2117 between standard library (std) and vtk library (problems are found
2118 under Windows... thanks Windows !)
2120 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2121 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2123 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2125 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2126 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2128 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2129 * When compiling with distutils (see setup.py) the C++ compiler is
2130 called with different flags than the default ones (with automake).
2131 In order to fix all those warning, I compiled gdcm with the command
2132 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2133 and went for warning fixes:
2134 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2135 up from unused variables.
2136 - vtk/vtkGdcmReader.cxx: potential bug fix.
2137 * src/gdcmHeader.h: Doxygen warning cleanup
2139 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2140 * gdcmPython/gdcm.i:
2141 - typemaps correction to take into account the systematic replacement
2142 of "using namespace std" with std:: prefix e.g. std::list,
2143 std::string... (cf changes of 2003-05-21).
2144 - gdcmGlob global variable of type gdcmGlobal (defined in
2145 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2146 exported to Python a as cvar.
2147 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2148 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2149 gdcmDictSet.GetPubDictTagNames() and
2150 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2151 C++ static methods).
2152 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2153 with the above changes.
2155 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2156 * setup.py, manifest.in : bug fix under linux
2158 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2159 * Modification of setup.py to compile vtk part too. Then, we have 2
2160 wrappers which must work with same distutils. For that, we have a
2161 generic distutils in distusiltsWrapping.py ; with :
2162 - build_extWrap class to wrap generically all extensions,
2163 - ExtensionWrap base class for all wrapping extension that contains
2165 - Wrapper interface which wrap sources
2166 + In WrapSwig.py we have extension and wrapper for Swig
2167 + In WrapVTK.py we have extension and wrapper for VTK
2168 * MANIFEST.in : modifications to consider vtk directory and new python
2169 files for compilation
2171 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2172 * Added python wrappers of vtkGdcmReader vtk class (see the
2173 source in vtk/vtkGdcmReader.cxx) :
2174 - vtk/Makefile.am now builds a library
2175 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2176 python library (as opposed to _gdcm.so wich are the python
2177 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2178 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2180 - configure.in has an additional flag --enable-vtk that needs
2181 to be set to enable compilation of vtk related code, that is:
2182 + vtk/vtkGdcmReader.so and
2183 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2184 + gdcmPython/vtkgdcmPython.so (see above)
2185 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2186 be read when compressed or when HighBit + 1 != BitsStored),
2187 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2188 the usage of the python wrapper of vtkGdcmReader vtk class.
2189 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2190 * src/*.[h] all occurences of stl classes are now prefixed with
2191 std::, and all occurences of "using namespace std;" where removed.
2192 This is to avoid pollution of global namespace in included files.
2193 Apparently vtk does not avoid this pitfall: when using both
2194 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2195 collision of various stl members (principally cout...).
2196 * gdcmPython/testSuite.py now cleanly removes temprory generated
2198 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2199 comply with above changes)
2201 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2202 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2203 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2204 vtk data structure (an image Flip was required).
2205 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2206 * cosmetic changes in documentation.
2208 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2209 * src/gdcmHeader.cxx: the constructor no longer exits when an
2210 unexisting file is given as argument.
2211 * The subdirectory Data (containing all the images used for the
2212 test suite) is not part of this repository anymore. A new module
2213 containing those images is now available at
2214 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2215 with the name gdcmData.
2216 All the python scripts (including the package initialisation file
2217 gdcmPython/__init__.py) were adapated to take this change into
2218 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2220 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2221 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2222 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2223 demo of the usage of this class.
2224 Compilation of this vtk part is only done when using the --enable-vtk
2225 at configure (or autogen.sh) stage.
2227 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2228 * More memory link related corrections and documentation fixes.
2230 - maximum info is obtained with a command of the form:
2231 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2232 --show-reachable=yes PrintHeader
2233 - the remaining reachable blocks seem to come from the STL
2234 allocation scheme through the usage of map and list. It looks
2235 like this memory cannot be freed but it is not a memory leak
2236 (in fact further invocation to the STL would recollect the
2237 unused memory allthough it cannot explicitely be freed).
2238 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2239 of displaying an image parsed with gdcm and displayed with VTK.
2240 Note: some images don't seem to work e.g.
2241 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2242 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2243 Allthough this weakens the semantics, it is a ditch attempt to
2244 make gdcm more thread friendly.
2246 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2247 * Memory link hunt (by using valgrind through the command
2248 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2249 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2250 gdcmHeader::_dicom_vr.
2251 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2252 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2254 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2256 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2257 * src/Makefile.am now exports all the necessary include files at
2261 * UpdateGroupLength replaced by new one
2264 * UpdateGroupLength re-written using H-Table
2265 (named UpdateGroupLengthNew untill checks are over)
2267 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2268 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2269 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2271 - gdcmHeader::GetPubElValSet removed.
2272 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2273 UpdateGroupLength, WriteElements, Write.
2274 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2275 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2276 carried the same semantics.
2277 - src/gdcmHeaderIdo.cxx changed accordingly.
2278 - gdcmFile::WriteBase now regroups all the codes from previous
2279 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2280 - enum FileType moved to gdcmCommon.h
2281 * src/gdcmHeader.cxx AddDefault trashed
2282 * gdcmGetXSize added
2283 * getimageDataSize now calls gdcmGetXSize
2284 * Test/*.cxx changed to agree with above changes
2286 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2287 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2288 (to avoid double call by end user).
2289 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2290 by end user, since gdcmHeader::gdcmHeader now handles it.
2292 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2293 * gdcm/Doc many doxygen changes:
2294 - Doxyfile now has two different versions, DoxyfileUsers that generates
2295 the html.users end users oriented documentation and
2296 DoxyfileDeveloppers that generates the html.developper developper
2297 oriented documentation.
2298 - README changed accordingly
2299 - requirement.txt removed (old design info moved to TODO).
2300 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2301 DoxyMainPage.txt, DoxyPython.txt provide more information.
2302 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2303 be updated by simply regenerating the docs with doxygen and copying
2304 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2305 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2306 all the tests in the form "if (<map>.count() >1)" were removed.
2307 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2308 ill-formed documentation sections.
2309 * src/gdcmHeader.cxx: ditto
2311 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2312 * setup.py fixed for un*x (needed macro for stdint.h)
2313 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2314 un*ces with sh-utils test utility.
2315 * gdcmPython/demo/test.py renamed to PrintHeader.py
2316 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2317 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2318 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2319 * src/gdcm*.cxx JPR's bad inclusion fixed.
2321 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2322 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2323 * gdcmPython/demo/test.py changed accordingly.
2325 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2326 * gdcmPython/Makefile.am fixed linking against libstdc++
2327 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2328 * Swig subdir (historical tests of swig version 1.3.17++) removed
2329 * Test/testChangeEntete.cxx some lines commented out in order to make
2331 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2332 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2334 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2335 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2336 hence the user doesn't need this explicit call.
2337 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2338 i.e. LoadElements() call removed.
2339 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2340 - src/Makefile.am declares the proper flag for g++.
2341 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2342 for adding user defined new tags.
2343 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2344 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2345 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2347 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2348 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2349 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2350 src/Makefile.am : the project should properly compile and install
2351 with the autotools, included the python wrappers part.
2352 * gdcm.spec.in : added a spec file for RPM packaging.
2354 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2355 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2357 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2358 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2359 to exported to the environement (see gdcmPython/testSuite.py
2361 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2362 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2363 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2364 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2365 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2367 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2368 * gdcmPython/__init__.py doesn't crash anymore when running in
2369 in InstallMode or PreInstallMode but with an environement given
2370 value of GDCM_DICT_PATH.
2371 * src/gdcmDictSet.[cxx/h] coding style.
2373 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2374 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2375 * src/gdcm.h general comments moved to TODO, and README
2376 * src/gdcm.h should now be seen as a user commodity (including it
2377 should suffice to fully use gdcm). It is nowhere including within
2378 any of the kernel files src/*.cxx and src/*.h.
2380 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2381 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2382 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2384 * src/gdcm*.cxx only include their corresponding include file
2385 (as opposed to gdcm.h)
2386 * gdcmPython/gdcm.i changed accordingly
2387 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2388 the autogen.sh generated "make snapshot" command to work.
2389 * autogen.sh removed history related references to crea package.
2391 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2392 * distutilsSwigCPlusPlus.py work around some swig portability
2395 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2396 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2397 was done in a last ditch attempt to get setup.py _really_
2398 operationnal. The python/gdcmPython layaout add the advantage
2399 of hidding away the python related distutils specific files
2400 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2401 Alas, the src directory was out of scope (i.e. it's relative
2402 position to setup.py was ../src) which made things impossible to
2403 handle (see previous version of python/setup.py). Crossing fingers...
2405 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2406 * python/setup.py now works on Un*x. (harder than I thougth)
2407 * python/distutilsSwigCPlusPlus.py can now have include files
2408 among the list of sources.
2410 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2411 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2412 * modifications in MSVC projects
2414 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2415 * As stated by the first lines of Test/ExceptionAndPython/README, it
2416 looks like we can move back to original usage of exception within
2417 src/gdcm* and hence remove the errno stuff that was introduced
2418 as a quick and dirty fixture of this problem (added to the TODO).
2419 * Doc/Doxyfile configuration file for Doxygen and corresponding
2420 README file for usage added.
2421 * Test/testWrite.cxx added. This new test comes from a split of
2422 test.cxx that is now reverted to its original purpous i.e.
2423 testing the proper parsing of a Dicom related file.
2424 testWrite.cxx concentrates on testing the IO part of gdcm.
2425 * Test/bug1.cxx (containing a bug on WIn32) added.
2426 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2427 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2428 whose purpose is to publish the content of the TagNames of the
2429 Dicom public dictionnary were not accessible without an
2430 instance of class gdcmHeader.
2431 - those methods are now static methods of gdcmDictSet and hence
2432 require no instances at all to be invocated.
2433 - within gdcmDictSet this change required to change some method
2434 to class methods (i.e. are now static) among which SetDictPath
2435 (renamed to BuildDictPath) and LoadDefaultPubDict.
2436 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2437 the above changes by calling the new method classes of gdcmDictSet.
2438 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2439 the above to be effective.
2440 * python/gdcmPython: in order to wrap properly the above changes
2441 for Python, swig version now needs to be > 1.3.17.
2442 * python/gdcmPython/Makefile fixed to adapt itself to new
2443 configure/make shema introduced by Johan Montagnat (thanks for the
2444 contribution). Alas this Makefile cannot be turned into a proper
2445 Makefile.am without some heavy changes in the configure.in
2446 (for python dectection).
2447 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2448 now avoids publishing the empty entries.
2450 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2451 * python/setup.py : bug fix concerning install under windows
2452 ExtraPath reused :-P
2453 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2455 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2456 * Dicts/dicomV3.dic : remove double spaces !!!
2457 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2458 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2461 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2462 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2463 method. Doxygenation.
2464 * src/gdcm.h clean up of JPR spurious comments.
2466 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2467 * python/distutilsSwigCPlusPlus.py now properly collects the
2468 shadow classes generated by "swig -c++" (gdcm.py in our case)
2469 when using "python setup.py install".
2470 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2471 reexports the working classes.
2472 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2473 by the classical C errno scheme. This is to prevent an obscure
2474 behavior of the python wrappers when importing wxPython.wx prior
2475 to gdcmPython (which ended up in an abort call). An illustration
2476 of this oddity can be found in the Test/ExceptionAndPython
2477 subdir (see the README file). This problem probably due to
2478 an combination of g++ and dynamic loading.
2479 * added Test/ExceptionAndPython (see above)
2481 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2482 * Changed the layout of the python part to avoid bloating main
2483 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2484 i.e. the distutils arsenal. All the python related stuff is
2485 again in a python subdir, but the package itself is now in
2487 * setup.py was cleaned up:
2488 - pythonIncludePath removed
2489 - python setup.py bdist target is now functional.
2490 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2491 collision with other packages). gdcmPython/demo/*.py changed
2494 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2495 * python subdir moved to gdcmPython (preparation of distutils packaging).
2496 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2497 distutils installer is operational.
2498 * - gdcmPython/__init__.py now properly loads the swig generated
2499 shadow classes (from gdcm.py).
2500 - gdcmPython/demo/*.py changed to import the package gdcmPython
2501 instead of gdcmPython/demo/load.py.
2502 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2504 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2505 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2506 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2507 entries within the associated public Dicom dictionary resp. the same
2508 information but sorted by the fourth field (PAT, IMG, DIR) of the
2510 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2511 are now in the "???" group.
2512 - python/gdcm.i changed accordingly,
2513 - python/demo/printGroupedPublicDict.py added, that gives an example
2514 of the above new functionalities in Python.
2516 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2517 * src/gdcm.h, gdcmHeader.cxx:
2518 - historic references to glib's g_malloc and g_free (#defined)
2519 were definitively removed.
2520 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2521 * src/gdcmElValSet.cxx:
2522 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2523 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2524 - GetElValue(string) renamed to GetElValueByName.
2525 - Added GetElementByName(string).
2526 * src/gdcmHeader.cxx: added
2527 - GetPubElValRepByNumber(guint16, guint16)
2528 - GetPubElValRepByName(string)
2529 - GetShaElValRepByNumber(guint16, guint16)
2530 - GetShaElValRepByName(string)
2531 - GetShaElValByNumber(guint16, guint16)
2532 - GetShaElValRepByName(string)
2533 - GetElValRepByNumber(guint16, guint16)
2534 - GetElValRepByName(string)
2535 - GetElValByNumber(guint16, guint16)
2536 - GetElValRepByName(string)
2537 * Doc/requirements.txt added.
2539 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2540 * Test/Makefile building now depends on the one of libgdcm.so
2541 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2542 pixel data) aware which enables finding the address (offset) of
2543 the pixel data of JPEG encoded DICOM files. This leaves only a single
2544 file in the testSuite whose pixel data address (offset) is unknown.
2545 * python/testSuite.py changed accordingly.
2547 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2548 * VC++ has some strong limitations when working with the STL, as stated
2549 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2550 "Also note that some STL containers (map, set, queue, list, deque)
2551 cannot be exported. [...]
2552 Some STL classes contain nested classes. These classes can not
2554 This is caused by a designed limitation that once a template
2555 class is instantiated, it can not be re-instantiated and
2557 Since our usage of map<> is ubiquitous in gdcm, this "designed
2558 limitation" of VC++ is a pitfall.
2559 Hence the Python wrappers of gdcm cannot be incrementally linked
2560 against the c++ dynamic library. The dirty but only workaround is
2561 to forget about incremental link of dynamic libraries and to generate
2562 the Python wrappers library with the inclusions of the underlying C++
2564 The following modifications concern this matter on Win32/VC++:
2565 - wrapping python correct with standalone wrapped dll (don't use separate
2566 dll under windows !!!!)
2567 - python21_d debug mode enabled (ask Frog how to use it :-)
2568 - NO problem with having an STL member of class for example string in C++
2569 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2570 - Python test of dcmlib in Python is ok under windows on a large set
2572 * removed glib references
2573 * typedef's inserted in gdcm.i for correct swig type management
2575 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2576 * python/demo/*.py load.py extracted from test.py. Added explore.py
2577 that only displays required tags and testAll.py that parses all
2578 the files of the testsuite without using unittest.
2579 * python/testSuite.py other additional test on new files added.
2580 * Data/* new test files added accordingly to the testSuite.
2581 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2582 the vr in the file differs from the one of the dictionary.
2584 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2585 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2586 values, but limits itself to values which are below a user specified
2587 size (by default 1024 bytes).
2588 * python/gdcm.i : elements not loaded (because their size is above the
2589 user specified treshold) are exported with their TagKey as key of the
2590 python dictionary. This enables the testsuite to make some checks
2591 on the unloaded elements (since we have their offset and size).
2592 * python/testSuite.py
2593 - now tests for the existence and proper value of the pixel data
2594 - two new examples added.
2595 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2597 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2598 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2599 aware. See the strategy comments in gdcmHeader::FindeLength().
2600 * Test/test.cxx now accepts a filename as first argument.
2601 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2602 * python/testSuite.py changed to integrate test on above files.
2604 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2605 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2606 the vr was also RET.
2607 * python/testSuite.py more tests added.
2609 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2610 * python/testSuite.py unittest test suite added (uses Data)
2611 * Data/* dcm and acr files for the test suite.
2612 * glib dependance removed from un*x version. We now use ISO C99
2613 7.18 Integer types (see stdint.h)
2614 - python/Makefile, src/Makefile src/gdcm.h
2615 * src/ when an explicit vr (like dicom files) suddenly poped an
2616 implicit element we use to mark the underlying DictEntry of the
2617 concerned ElValue with "Implicit". This strategy was damageable
2618 too the public or provite dictionaries, since some of their vr
2619 would be changed. Since Header::FindLength heavily relies on the
2620 detection by Header::FindVR of falsely explicit elements, I
2621 added an extra ImplicitVr member to ElValue (boolean).
2622 The rest of the changes we the necessary adaptations.
2624 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2625 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2627 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2629 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2630 * Adaptation for porting to VC++:
2632 o forced to use std namespace (for string to be known)
2633 o all class use __declspec export style on WIN32
2634 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2635 (in stdlib.h on Win32 but in std:: for gcc)
2636 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2637 variable GDCM_DICT_PATH.
2638 * src/gdcmHeader.cxx verbose comments made discrete.
2640 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2641 * python/gdcm.i: added a typemap that converts a C++ hashing table
2642 to native Python dictionary.
2643 * python/demo/test.py:
2644 - now uses the native dictionary for exploration of gdcmHeader.
2645 - takes an optional filename argument (the file to parse).
2646 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2647 PubElVals hashing table.
2648 * Dicts/dicomV3.dic removed error prone trailing spaces.
2650 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2651 * Python wrapping process moved away from src/Makefile to
2652 newly created python/Makefile (as well as gdcm.i)
2653 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2654 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2655 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2656 from the environement variable GDCM_DICT_PATH (when existing).
2657 * src/gdcmDict::GetTag bug fix.
2659 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2660 * Straightforward temporary fixes for swig to build the python wrappers.
2661 src/Makefile now has a python working entry [by working we mean
2662 that we can import de shadow classes without errors].
2664 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2665 * hashtest.cxx removed (since allready in Test)
2666 * src/gdcmlib.h renamed to src/gdcm.h
2667 * src/dcm.i renamed to src/gdcm.i
2668 * src/Makefile prepared for python wrapping
2670 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2671 * src/gdcmHeader.cxx :
2672 - Parsing of header is now separated from loading of element values
2673 (see gdcmHeader::LoadElements).
2674 - general clean up of hopefully all file access (creation of
2675 ReadInt16 and ReadInt32)
2677 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2678 * src/gdcmHeader.cxx :
2679 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2681 - SetLgrElem renamed to SetLength
2682 - GetLgrElem renamed to GetLength
2683 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2684 * src/gdcmElValSet.cxx fixed both GetElValue methods
2685 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2686 due to IdoDude was cleaned out.
2688 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2689 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2690 concentrates on finding the value representation (when it exists).
2691 RecupLgr now only finds the element value length, and it avoids
2692 returning the unecessary skL (skipped length).
2693 Also, offsetCourant was simply removed (with taille_fich) since
2694 it was redundant with the File position internals (by using
2695 ftell and fseek). This also made skL (see above in RecupLgr) usage
2697 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2698 on the libido specificities which are handled through class
2700 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2703 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2704 * Truckload of changes. Parsing of header is barely functional
2705 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2707 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2708 * src/gdcmHeader.cxx many addons of low level methods
2710 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2711 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2712 and _IdDcmSWAP_LONG.
2714 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2715 * This corresponds to all the changes decided at the meeting of
2716 May 23 2002. Needless to say we are running late...