1 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * gdcmPython/testSuite.py: all the test suite in python is now moved
3 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
4 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
5 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
7 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
8 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
9 to avoid inclusion recursion until STL is reached.
10 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
11 mecanism. errno.h is not included in gdcm anymore.
12 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
13 (gdcmFormatError now inherits from gdcmFormatUnexpected).
15 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
16 gdcmData/TestAllEntryVerifyReference.txt
17 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
18 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
19 exception_on_error parameter.
20 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
21 - vtk/vtkGdcmReader.cxx changed accordingly,
22 - Example/*.cxx and Test/*.cxx changed accordingly.
24 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
25 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
26 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
27 enable_sequences removed from gdcmHeader constructor and dependencies.
28 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
29 * gdcmPython/demo/PrintHeader.py: dummy fix.
30 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
31 skip_shadow removed from gdcmHeader constructor and dependencies.
32 * Example/*.cxx and Test/*.cxx changed accordingly.
34 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
35 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
36 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
38 2004-07-21 Jean-Pierre Roux
39 * FIX Now, Parsing and Printing a DICOMDIR do work!
40 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
42 2004-07-20 Jean-Pierre Roux
43 * FIX Some brain damaged headers have Zero-Lenght fields
44 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
46 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
48 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
49 variable (instance of gdcmDebug) by a definition macro, and the instance
50 is now in static in the gdcmDebug class
51 * src/gdcmSQItem.h : (FIXME) remove an undefined method
52 * Test/PrintAllDocument.cxx : bug fix in the result of the test
54 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
55 * WARNING: ctest now depends more tightly on gdcmData. You should
56 check out gdcmData properly for things to run smoothly...
57 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
58 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
59 we need the pixels not be loaded in order to use the ValEntry
60 that displays position and size).
61 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
62 This is a C++ based equivalent of gdcmPython/testSuite.py that should
63 be deprecated. If you have any doubts about the advantages of a
64 modern scripting language (read Python) versus grass root C++ (i.e.
65 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
66 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
67 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
68 Anyhow, consider documenting the gdcmData images in
69 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
71 * Test/CMakeLists.txt:
72 - now uses TestAllEntryVerify.cxx
73 - specific comments on oldACR00001.ima (now renamed in gdcmData
74 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
75 gdcmData/TestAllEntryVerifyReference.txt
78 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
79 * src/*.[h|cxx] : typedef clean up
80 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
81 - TagKey renamed to gdcmTagKey (for external usage)
82 - VRKey renamed to gdcmVRKey (for external usage)
83 - removal of typedef duplication.
84 - Removed all unecessary inline keyword from class inline definitions.
85 - Some method|function(void) declarations replaced with method|function().
86 * src/jpeg/libijg12/jdhuff12.c:
87 - printf polluting ctest removed.
88 - TAB removal for comminting
90 - TestAllReadCompareDicom.cxx: added a test that compares all the
91 images in gdcmDataImages.h with corresponding images in
92 gdcmData/BaselineDicom/. When baseline images are not present
93 this test creates them.
94 Note: we need to validate each reference image, but before that
95 I'd like to rename them with a more explicit name...
96 - CMakeLists.txt: changed accordingly.
97 * Example/*.cxx: examples now only include gdcm.h (as opposed to
98 including each header needed).
100 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
101 * Test/*.cxx and Example/*.cxx: moved some examples away from the
102 test suite to the Example directory. Are concerned:
107 - TestWriteSimple.cxx
108 * Test/CMakeLists.txt: added some comments on reasons for black listing
109 image gdcmData/oldACR00001.ima
111 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
112 * Test/CmakeList.txt: removed the following from black list (to be coherent
113 with removal from gdcmData):
114 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
115 - gdcm-MR-PHILIPS-16.dcm
117 Added the following because after last cvs update, they cause
118 ctest -R TestReadWriteReadCompare
120 - gdcm-MR-SIEMENS-16-1.acr
122 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
123 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
124 new comments in this file) we temporarily (sigh) move to a weaker
126 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
127 we don't need to black list the following images anymore:
128 - 8BitsUncompressedColor.dcm
130 - US-PAL-8-10x-echo.dcm
131 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
132 fixes and the beautified code ;-)
133 This fixes the bug introduced in version 1.42 (when beautifying)
134 that made the parsing of 8BitsRunLengthColor.dcm unproper.
135 Note: ctest was blind to this bug (this means we need to still
136 improve the test suite). The bug could be detected by using
137 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
139 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
140 and by displaying the (garbage) produced file temp.XDCM...
142 2004-06-29 Jean-Pierre Roux
143 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
144 - replace by uggly but working old code :-(
145 A lot of things should be OK again.
146 It's really urgent to have a test suite that *tests*,
147 to prevent Frog's beautifying sessions to break all the stuff
148 (twice, withing a fortnigh ...)
150 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
151 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
152 redundancy) to added Test/TestReadWriteReadCompare.cxx
153 * Test/CmakeList.txt: because the compare test of
154 Test/TestReadWriteReadCompare.cxx fails, the following images are
155 black listed: - 8BitsUncompressedColor.dcm
157 - US-PAL-8-10x-echo.dcm
158 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
159 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
160 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
161 and ad-hoc kludge. This kludge is now removed, and on encountering
162 such an image (OB field brain damaged) we set errno. Then in
163 ::FindDocLength() we "fix" the length as being ALL what remains
164 in the file (until EOF). We then proceed, hoping for the best...
165 This fixes a SegFault in ShowDicom when trying to write such an
167 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
168 (because TestWriteRead breaks on it, after a non conformal commit?).
169 ctest now runs properly, except for MakeDicomDir (which was allways
170 broken) and the Python related stuff (still not fixed).
172 2004-06-24 Jean-Pierre Roux
173 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
174 FIX : Test/TestReadWrite now iterates on all the file names
175 (instead of infinite loop)
176 ENH : Test/TestWriteRead now iterates on all the file names
178 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
179 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
181 2004-06-24 Jean-Pierre Roux
182 FIX : - now Write drops LUT Descriptors and LUTs (if any)
183 when SamplesPerPixel =3
184 - now Write is no longer confused by
185 'BitsAllocated = 12" and 'BitsStored=12"
186 - "UN" value representation Elements are now written correctly
187 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
188 ENH : - now gdcmHeader has its own Write methods
189 (in order to split the job that has not to be done
192 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
193 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
194 loop on the same image until memory went out.
195 Note: this means we still have gobs of memory loss in PrintDocument
196 * src/gdcmDocument.cxx: fixes problem on parsing on file
197 gdcmData/16BitsJpegLosslessGrayScale.dcm.
199 2004-06-24 Jean-Pierre Roux
200 FIX : Write - All the Sequences and Sequence Item are now written
201 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
202 is added a the end, when necessary.
203 - A lot of brain-damaged images, that were read correctly are
204 now written correctly
205 - length compatible BinEntry are now loaded correctly
206 (even for odd groups)
207 Note : only Explicit Value Representation was checked.
208 (question : is implicit VR really necessary for gdcm ?)
210 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
211 * DEVELOPPER: added a proposition of coding style.
212 * src/gdcmDocEntry.h: removed every inline declaration (for test of
215 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
216 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
217 Use the gdcmDocEntry::Print() and Write() instead.
218 * src/gdcmDocument.cxx: bug fix.
220 2004-06-22 Jean-Pierre Roux
221 FIX : gdcmDocument.cxx
222 - Now we do recognize the JpegLossLess format (there was a misstyping in
223 code 'beautyfication' :-(
224 - Now we automaticaticaly load the Luts, if any
226 2004-06-22 Jean-Pierre Roux
227 In order : to write Sequences, whatever their imbrication level,
228 : to allow user to create his own Sequences
229 a lot of modif where necessary (adding, moving, or virtualising methods)
231 WARNING : save your own sources *before* cvs up !
234 ADD virtual void Write(FILE *fp, FileType filetype);
237 ADD virtual void Write(FILE *fp, FileType filetype);
238 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
241 ADD virtual void Write (FILE *fp, FileType filetype)=0;
242 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
243 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
244 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
245 ADD std::string GetEntryByName(TagName name);
246 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
248 std::string vr = "unkn",
249 std::string fourth = "unkn",
250 std::string name = "unkn");
251 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
252 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
253 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
254 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
255 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
256 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
257 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
258 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
261 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
262 ADD virtual std::string GetEntryByName (TagName tagName);
263 ADD virtual std::string GetEntryVRByName (TagName tagName);
264 REM virtual bool Write(FILE *, FileType);
265 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
266 FILE *_fp, FileType type);
267 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
268 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
269 REM virtual bool WriteEntries(FILE *_fp,FileType type);
270 REM virtual std::string GetEntryByName (std::string tagName);
271 REM virtual std::string GetEntryVRByName (std::string tagName);
272 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
273 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
274 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
276 std::string vr = "unkn",
277 std::string fourth = "unkn",
278 std::string name = "unkn");
279 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
280 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
281 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
282 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
285 ADD virtual void Write(FILE *fp, FileType filetype);
288 ADD virtual void Write(FILE *fp,FileType filetype);
291 ADD virtual void Write(FILE *fp, FileType filetype);
292 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
293 REM std::string GetEntryByNumber(guint16 group, guint16 element);
294 REM std::string GetEntryByName(TagName name);
297 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
299 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
300 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
301 The default constructor invoked by the line
302 gdcmHeader *f1 = new gdcmHeader( header );
303 was gdcmHeader::gdcmHeader(bool) instead of the expected
304 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
305 Hence the parsing wasn't executed... See also below.
306 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
307 as explicit constructor didn't do the trick to fix the above problem.
308 Could anyone explain why ?
309 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
310 properly calls gdcmValEntry::Print() (that was weed out from
311 code related to gdcmBinEntry).
313 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
314 * In order to fix memory leaks:
315 - Test/TestWriteSimple.cxx: added cleaning of free store through
317 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
318 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
319 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
320 (through the call to ::AddDicomDirMeta()) or the destructor
321 would crash when deleting uninitialized ::metaElems].
322 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
323 - src/gdcmDocument.cxx:
324 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
326 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
327 was causing memory leaks.
328 - src/gdcmSQItem.cxx:
329 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
330 cleanly handled with polymophism: sorry but my milage is low).
331 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
332 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
333 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
334 This avoids SegFaulting.
335 - src/gdcmSQItem.h: coding style.
337 - Test/TestWriteSimple still severely sucks. The output image content
338 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
339 damaged when displayed with vtkgdcmViewer.
340 - on memory leaks: TestWriteSimple leaks really less (see entry
341 of 2004-06-18 in Changelog file for the call to valgrind).
342 - on segfaults: ctest now passes all the tests but one (no more
344 * Erroneous leading white fix:
345 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
346 white[s] (as opposed to from >> xxx, that removes it [them].
347 - src/gdcmTS.cxx: ditto.
348 - gdcmPython/testSuite.py: dirty related kludge removed.
349 * src/*: remaining references to gdcmParser removed.
350 * src/*[cxx|h]: added copy[way]left header.
353 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
354 * In order to fix writing of dicom files:
355 - Test/TestWriteSimple.cxx: a simpler example of writing.
356 - Test/CMakeLists.txt changed accordingly.
357 - src/gdcmDocument.cxx:
358 -- The destructor now recursilvely removes potential sequences.
359 -- Bug fix in ::IsJPEG2000()
360 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
361 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
363 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
364 to only declared) and build on top of
365 ::GetDocEntryByNumber(guint16, guint16).
366 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
367 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
368 for usage in destructor and treatement of promotion in
369 ::ReplaceOrCreateByNumber().
370 - src/gdcmSQItem.cxx: destructor should better handle his job.
371 Test/TestWriteSimple now runs (or at least it DOES something).
372 * We can now start hutting memory links. A good starting point is:
373 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
374 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
375 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
377 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
378 * Valgrind note: after Mathieu Malaterre teached me how to read
379 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
381 Using gcc, you can force the STL to use malloc and to free memory as
382 soon as possible by globally disabling memory caching.
383 With 3.2.2 and later, you should export the environment variable
384 GLIBCPP_FORCE_NEW before running your program.
385 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
386 simply vanish (it is still not clear to me, whether this means that
387 STL std::string leaks or if valgrind believes it leaks...).
388 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
389 running bin/gdcmTests makeDicomDir):
390 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
391 - Test/makeDicomDir.cxx now properly traps empty lists and returns
393 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
394 SegFaulting (I drowned in DicomDir related code when trying to
395 understand why the list is empty...).
396 * src/gdcmDocument.h: first BSD license header try.
397 * Doc/License.txt added.
399 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
400 * src/gdcmDocument.[h|cxx]:
401 - Clean up of the Transfer related predicates. They are now all based
402 on new method isGivenTransferSyntax, that (should) handle properly
404 - general clean up, simplification, and coding style.
405 - Specific clean up of Parse7FE0() (umproperly named actually).
406 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
408 2004-06-14 Jean-Pierre Roux
410 - fix the display of Sequence Delimitor (SQDepthLevel pb)
411 - fix the display of SQItem ordinal number
412 - add the GetSQItemByOrdinalNumber method
413 - remove some useless never written private methods
415 2004-06-14 Jean-Pierre Roux
417 - adding a constructor taking a gdcmDocEntry as an input param
418 - ReplaceOrCreateByNumber now returns :
419 a gdcmBinEntry * if a Binary (void *) value is passed as a param
420 a gdcmValEntry * if a string value is passed as a param
422 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
423 according to the param type (no longer sets a gdcmDocEntry)
424 - GetValEntryByNumber, GetBinEntryByNumber added
425 - NewValEntryByNumber and NewBinEntryByNumber added
427 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
429 - GetSQItemNumber and SetSQItemNumber added, to provide
430 a (relative) Item identier inside a given Sequence
431 \warning : some pb remaining around this number
433 - AddEntry now takes the Item Number as a param
435 - adding a constructor taking a gdcmDocEntry as an input param
437 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
438 * Memory leak hunt with the following command:
439 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
440 --show-reachable=yes gdcmTests PrintDocument
441 It looks like many (all?) leaks are due to the STL (or a bad usage
442 of the STL. The lines producing the leaks now have a comment with
443 a "MEMORY LEAK" tag: you can retrieve them with
444 grep "MEMORY LEAK" src/*
445 Here are two typical examples which I can't help fixing:
450 char * test = "babo";
451 name = test; //// <--- valgrind detects 960 bytes lost in
452 //// call to std::string::operator=(char const*)
453 name.clear(); //// Doesn't help !
461 std::cout << "Type a bunch of characters followed by RETURN: ";
462 getline(std::cin, line); //// <--- valgrind dectects a loss
463 //// of 1320 bytes in call to
464 /// std::basic_istream<>& std::getline<>
470 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
471 * src/gdcmHeader.[cxx|h]:
472 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
473 and related, moved away to gdcmDocument.
474 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
475 the corresponding protected accessors of inherited class
476 gdcmDocument, removed ! As a consequence gdcmFile had to be
477 declared friend of class gdcmDocument (see below).
478 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
479 - Clean up of undefined or unused methods.
480 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
481 account the changes to gdcmHeader.h).
482 * src/gdcmDocument.h:
483 - gdcmFile is now a friend class (in order to take into account the
484 changes to gdcmHeader.h).
485 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
486 (see changes to gdcmHeader.h).
487 - Accessors (reading on the form GetEntry*) are now public.
488 - Clean up of undefined or unused methods.
489 * src/gdcmDocument.cxx:
490 - adaptation to changes to gdcmDocument.h
491 - ::OpenFile now writes a verbose message when file cannot be opened.
492 - some std::string properly set to VRKey
493 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
494 references to gdcmDocument.
495 * Test/TestFindTags.cxx: changed accordingly to above changes.
496 * gdcmPython/testSuite.py: adapted to renaming of acr files in
497 cvs repository gdcmData.
499 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
500 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
501 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
502 conflicts with gdcmValEntry::voidArea.
503 * src/gdcmValEntry.cxx: unmatching comment wiped out.
504 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
505 Value representation between StringRepresentable and BinaryRepresentable.
506 * src/gdcmDocument.cxx:
507 - method ParseDES: proper indentation restored and usage of
508 gdcmVR::IsVROfGdcmStringRepresentable wired in.
509 - method LoadDocEntry: the fingerprint left in the SetValue() of
510 unloaded entries (length > MaxSizeLoadEntry) had curiously been
511 removed. Reverting to previous code segment with the proper
512 dynamic_cast< gdcmValEntry* >.
513 Note: this was (partially) breaking the python test suite
514 (gdcmPython/testSuite.py) that made usage of the above
515 fingerprint to check presence of "Pixel Data".
516 * src/gdcmDocEntry.h: coding style.
517 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
518 now taken into account.
519 * gdcmPython/gdcm.i: adaptation to the new internal representation
520 of gdcm (exit gdcmParser, hello gdcmDocument).
521 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
523 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
524 anymore, but instead prints the loaded Python dictionary.
525 * .... alas, the python testSuite is still broken.
527 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
528 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
530 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
531 * src/gdcmUtil.h : export methods
533 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
534 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
536 * Initial addition of automatic python testing
537 * Initial addition of automatic image comparison
539 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
540 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
541 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
543 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
544 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
545 * Test/ShowDicom.cxx : bug fix for msvc compilation
546 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
548 2004-05-04 Jean-Pierre Roux
549 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
550 new concepts (and new classes) :
551 a 'gdcmDocument' is composed of a set of Doc Entries, that are
552 - elementary gdcmDocEntries (former gdcmHeaderEntries)
553 - Sequence Doc Entries (gdcmSeqEntries)
554 a Sequence is composed of Items.
555 Each item is a set of Doc Entries (this is recursive)
556 The non uniqueness of the 'Dicom tag' is due to this recursivity
557 (never taken into account)
558 Our unability to add a new 'entry' in the header
559 at the proper location (neither in the H-Table (map or multimap),
560 nor in the Chained List is also due to this recursivity.
561 Don't try, right now, to use/modify/compile these new sources :
563 We just commit all the stuff, 'as is', in order not to loose it.
565 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
566 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
568 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
569 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
570 file prefix (SetFilePrefix)
572 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
573 * Add a new test: ShowDicom, for now this is just the c++ version of
574 checkRead.sh, later it will be able to compare the image read against a
576 * Replace the DEBUG on the stack with a global entry in cmake interface:
577 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
579 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
580 * Add an example subdir, with a real example on how to read + write a
583 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
584 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
585 * Doc/CMakeLists.txt: the main page is now properly differentiated
586 between the developper and user version.
587 * Doc/doxygen.config.in: dropped search related obsolete flags
588 * src/gdcmParser.h, gdcmHeader.h: doxygenation
590 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
591 * DEVELOPPER: added some helpfull comments for compile/test/install
594 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
595 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
596 src directory, now generated in the build dir.
597 2. Tests as mentionned smarter
599 4. Add a new method in gdcmDict that return the PubDict by name
600 this is interesting for 3rd party lib like ITK,
601 where we could set the institution name / patient name...
603 * ENH: 1. Now the test suite is working for real
604 2. All binaries are now output in the gdcm-bin directory
605 (this was not true before)
607 2004-04-28 Jean-Pierre Roux
608 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
609 SeQuence indented printing of Dicom Header.
610 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
611 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
612 Computation of SQDepthLevel is now part of gdcmHeader constructor
613 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
614 tree-like structure of a Dicom Header.
615 * FIX Test code cleaning
617 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
618 * ENH: Adding automatic testing
619 1. Need a DartConfig.cmake to submit to public
620 2. Add a test driver gdcmTest.cxx
621 3. gdcmTestMain, an helper for the main test driver gdcmTest
622 4. Files in Test don't have a main anymore, this becomes interesting
623 when we add more and more tests, thus dsw don't have to load
625 * ENH: Adding a GDCM_DATA_ROOT for testing
626 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
627 one file instead of seven + some small cleanup
629 2004-04-22 Jean-Pierre Roux
630 * ENH Minor changes to the Print() methods.
631 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
632 Header printing. Example given with :
633 > PrintHeader fileName 2 new
634 (SQ based tree-like structure still to be done for the Header ...)
636 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
637 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
638 1. I have added some unsigned where needed
639 2. Some function parameter not used -> (void)
640 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
641 4. g++ don't like character '\' in comment
642 5. #define jpeg_create_decompress jCreaDecompress
643 this really need to be fixed
644 6. virtualize destructor of gdcmObject ... leakage
645 7. sscanf(g->first.c_str(),"%x",&gr_bid);
646 this also really need to be fixed
647 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
648 remove compression file
649 (as we only do decompression, right ?)
650 * ENH: Change malloc/calloc/free with c++ equivalent
652 2004-04-21 Jean-Pierre Roux
653 * FIX gdcmHeaderHelper::GetXSpacing
654 when a single value is found (bug ?), xpacing is now
655 defaulted to yspacing
657 2004-04-19 Jean-Pierre Roux
658 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
659 * ENH add parameters :
660 bool exception_on_error = false,
661 bool enable_sequences = false,
662 bool ignore_shadow = false
663 to the gdcmFile constructors to be full gdcmParser compliant
664 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
665 to allow reading of PAPYRUS 3.0 files
667 2004-04-06 Jean-Pierre Roux
668 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
670 2004-04-02 Jean-Pierre Roux
671 * ADD : Test/checksequence.sh, for a general recap on SQ pb
672 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
673 for Philips spurious Tag fffe|0000 while rewritting Dicom files
675 2004-03-30 Jean-Pierre Roux
676 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
677 for ACR file, written out as DICOM files (hope so...)
679 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
680 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
681 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
682 moved to base class gdcmParser and only the specialisation is kept
684 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
685 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
686 already does the job.
687 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
688 (to be consistent with gdcmParser::WriteEntries).
690 2004-03-30 Benoit Regrain
691 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
692 upate of the object's instance. It's passed to 2 in the unfavorable
693 case : one in the ExecuteInformation, one in the ExecuteData
695 2004-03-29 Jean-Pierre Roux
696 * ENH : Check on file type to be written moved
697 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
698 * FIX : gdcmObject::ResetBoundaries now stops properly
699 when end-of-list is reached
700 : gdcmVersion modified (as Benoit Regrain asked)
702 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
703 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
704 * src/gdcmUtil.cxx: added forgotten iostream include.
705 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
706 equivalent to ExplicitVR in existing code).
708 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
709 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
710 now contains all the gdcmGlobal related code.
711 * minor coding style and doxygenation changes.
713 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
714 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
715 now contains all the Debug related code.
716 * minor clean-up of includes in src/*.cxx
717 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
718 CreateCleanString) removed.
719 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
720 * Doc/DoxyMainPageUser.txt added.
721 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
722 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
725 2004-03-24 Jean-Pierre Roux
726 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
728 2004-03-23 Jean-Pierre Roux
729 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
730 big endian made volumes
731 * ENH Now gdcmParser constructor and destructor are protected to forbid
732 end user to instanciate class gdcmParser
733 (only gdcmHeader and gdcmDicomDir are meaningfull)
735 2004-03-22 Benoit Regrain
736 * FIX : src/gdcmDicomDir.cxx : make windows compilable
737 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
738 gdcmSerie to gdcmDicomDirSerie
740 2004-03-19 Jean-Pierre Roux
741 * ENH Now the tree-like structure describing a DICOMDIR comming from
742 an already existing DICOMDIR file is consistent with
743 the home-made tree-like structure build ex-nihilo
744 or build from the files held (recursively) in a Directory
745 functions gdcmDicomDir::CheckBoundaries()
746 gdcmObject::SetBoundaries() added
748 2004-03-17 Jean-Pierre Roux
749 * REM (Eric Boix bug) : removal of meaningless
750 gdcmDicomDirImage::NewImage function.
751 * FIX now file names and directory name are written properly in the
753 * FIX now gdcmDicomDir constructor may be call without any trick
756 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
757 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
758 of gdcmDicomDirImage::NewImage as empty function.
760 2004-02-28 Jean-Pierre Roux
761 * ENH add gdcmDicomDir:NewPatient
762 add gdcmDicomDirPatient:NewStudy
763 add gdcmDicomDirStudy:NewSerie
764 add gdcmDicomDirSerie:NewImage
765 to allow making gdcDicomDir object.
766 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
767 (as opposite to the gdcmHeader chained list)
769 2004-02-11 Benoit Regrain
770 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
771 when using from python
773 2004-02-10 Benoit Regrain
774 * FIX : bug fix in the gdcmDirList for the recursivity in directories
775 * FIX : in gdcmDicomDir when the directory is empty
776 * ENH : add callback and methods to get the progression of dicomDir
779 2004-02-06 Jean-Pierre Roux
780 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
781 - GDCM_META added to gdcmDicomDirType
782 - class gdcmMeta created
783 * ENH : - A brief summary is now displayed at the beginning of
784 'testDicomDir' to help disaster magnitude estimation
785 * REM : Now useless Test/explDICOMDIR.cxx
787 2004-02-05 Benoit Regrain
788 * ENH : add methods in gdcmObject to get the hash table or the list of
790 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
791 * FIX : wrapping python for TagHeaderEntryHT
793 2004-02-04 Benoit Regrain
794 * FIX : even length for some strings when writting the dicom dir
795 * FIX : sort the images in the dicom dir
796 * FIX : Bug fix for python use of dicom dir
797 * ADD : a python demo
799 2004-02-04 Jean-Pierre Roux
800 * FIX : Final solution (?) for icone embedded images
801 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
802 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
803 add groups 6002, 6004, 6006, to allow 'clean' parsing of
804 gdcmData/gdcm-MR-SIEMENS-16.acr1
805 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
806 to make full checking easier
808 2004-02-04 Benoit Regrain
809 * FIX : WriteEntries : coding style & logic in parameters
810 * FIX : Set the elements to create the DicomDir in a dictionary file
812 2004-02-03 Benoit Regrain
813 * gdcmDirList : to parse a hard drive directory in recursive (or not)
814 * gdcmDicomDir : add the load of directory
815 * Bug fix and print add-on
817 2004-02-03 Jean-Pierre Roux
818 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
819 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
820 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
821 * FIX gdcmParser.cxx : 'group length' elements are now considered
822 as integers, even for shadow groups, when file is Implicit VR
824 2004-02-02 Jean-Pierre Roux
825 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
827 of the last synonym :-(
828 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
830 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
831 * FIX taking into account the possible 7fe0,0010 multiplicity
832 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
833 to allow removal of references to 7fe0,0010, to deal with
834 ACR-NEMA images, when 0028,0200 is meaningfull
836 2004-01-31 Jean-Pierre Roux
837 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
838 no longer writes 'Un' on disk
839 * FIX SQ elements with actual length are now dealt with corectly
840 * FIX gdcmFile::WriteBase make the difference, for color images, between
841 the length (for Palette expanded images)
842 and Raw Length (non expanded image + Palette)
843 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
844 (that broke Write). Replaced by UL.
845 Aware user will reload the field if he
846 thinks it's necesssary
848 2004-01-30 Jean-Pierre Roux
849 * gdcmParser::CheckSwap() now defaults the filetype to ACR
850 when 'dirty Acr' is found, to be compliant with the new
851 IsReadable() methods.
853 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
854 (no DOUBLE images in kosher DICOM,
855 but so usefull for people that miss them ;-)
857 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
858 DICOMDIR related utilities (not checked as Windoze compliant)
860 2004-01-28 Jean-Pierre Roux
861 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
863 2004-01-27 Jean-Pierre Roux
864 * gdcmParser constructor has a new boolean param,'ignore_shadow',
865 to allow skipping the shadow elements, to save memory space.
866 The TRUE value for this param has to be used
867 with a FALSE value for the 'enable_sequence' param.
868 ('public elements' may be embedded in 'shadow Sequences')
869 * gdcmHeader methods now deal with 'embedded icones images' in the header
870 (even when an 'icone image sequence' is announced by the
871 element (0x0088,0x0200), but there is NO icone at all ...
873 * gdcmHeader sometimes Image Location value doesn't follow
874 the supposed processor endianity (see gdcmData/cr172241.dcm).
877 * gdcmHeader add the method
878 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
879 to get *all* the Header Entries with the same tag.
880 GetHeaderEntrySameName is probabely *useless*
881 (no meaning : Name is *not* an identifier within the Dictionnary)
883 2004-01-26 Benoit Regrain
884 * Bug fix in the print of hexadecimal representations. Remove long fields
885 in the print and add a third level of print to print them
887 2004-01-23 Benoit Regrain
888 * Bug fix on field having a VR = 'UI'. Assume that is a string field
889 * Bug fix on test suite after remove the strip made on not string fields
890 * Split the IsReadable method between gdcmParser which test that the file
891 is dicom and gdcmHeader which test that it's an image file
893 2004-01-22 Benoit Regrain
894 * DicomDir : clean code, add methods, set variables in protected or private
895 * gdcmUtil : bug fix for the clean string method
897 2004-01-19 Benoit Regrain
898 * Add the use of shadow dictionaries
899 * bug fix and coding style
901 2004-01-19 Benoit Regrain
902 * src/gdcmFile.cxx : bug fix concerning the close of file
903 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
904 * Add the update of header entries using the shadow library
906 2004-01-19 Benoit Regrain
907 * removal of file gdcmHeader2.cxx
908 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
909 inheriting from gdcmParser. This split is to prepare the integration
911 * bug fix under python
913 2004-01-16 Jean-Pierre Roux
914 * REM removal of class gdcmHeaderEntrySet
915 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
916 * ADD add file gdcmHeader2.cxx
917 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
919 2004-01-15 Benoit Regrain
920 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
921 entries created while parsing the header. Thus, they will be destroyed
922 when the gdcmDictSet will be destroyed
923 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
926 2004-01-15 Benoit Regrain
927 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
928 made a fatal error because of the memory release at the end of program.
929 The problem was in vtkGdcmReader::ExecuteData where we were allocate
930 some memory and vtk seems to have some problems with that.
931 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
933 2004-01-14 Benoit Regrain
934 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
935 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
936 * src/*.[h|cxx] : make changes due to class name changes
937 * gdcmPython/demo/*.py : bug fix due to method names
939 2004-01-13 Benoit Regrain
940 * src/*.[h|cxx] : coding style
941 * vtk/*.[h|cxx] : coding style
943 2004-01-13 Benoit Regrain
944 * gdcmPython/testSuite.py : test the readable flag of file for tests
945 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
946 It's lied to the stl compilation by MSVC (windows, always windows...)
947 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
949 2004-01-12 Benoit Regrain
950 * src/*.h : add comments
951 * src/gdcmDictSet.h : set the method BuildDictPath in public
952 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
953 directly setted in the source code
954 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
957 2004-01-09 Benoit Regrain
958 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
959 * setup.py : use a reference to gdcmVERSION
961 2004-01-07 Benoit Regrain
962 * Modification to compile with the distutils.
965 2003-12-10 Benoit Regrain
966 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
967 can use a gdcmHeaderHelper to load datas
968 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
969 made in the source code
971 2003-12-10 Benoit Regrain
972 * Update Windows projects and .cvsignore files
974 2003-11-12 Jean-Pierre Roux
975 * ENH gdcmHeader constructor has one more parameter (default value : false)
976 that allows the user to 'go inside' the SeQuences only
978 gdcmElValSet:Print takes it into account
980 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
981 * ENH: Update gdcmPython/CMakeLists
982 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
983 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
985 2003-11-10 Jean-Pierre Roux
986 * FIX : gdcmHeader::LoadElements is now based
987 on the ListTag listElem member,
988 not longer on the TagElValueHT tagHt member
989 * ENH : PrintPubElVal shows (temporarily) both results,
990 with the tagHt member and the listElem member.
991 (it's easier to 'see' the problems when using Printheader)
993 * FIX : old private member LgrElem is now splitted into
994 ReadLength : Length actually found on disk (updated only
995 if bug fixing is necessary), for internal
997 UsableLength : Updated by FixFoundLength, to fix a bug
998 or to allow Parser going on.
999 Will allow to re-write a kosher header when a SeQuence
1000 with a length (not 0000) is found
1001 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1002 because gdcmElValSet::Add does not update ListElem
1005 2003-11-07 Jean-Pierre Roux
1006 * FIX misstyping in Transfert Syntax name table
1007 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1008 when they have an actual length (not 0000 nor FFFFF)
1009 (Nobody should care of it, but DICOMDIR explorers)
1011 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1012 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1014 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1015 * ENH: vtkGdcmReader now supports LUT !
1016 (vtkgdcmViewer for now is not able to use them though)
1018 2003-11-05 Jean-Pierre Roux
1019 * in testSuite.py : new files names for checking the package
1020 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1021 that returns the pixel area size to the *aware* (vtk) user
1022 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1024 2003-11-05 Benoit Regrain
1025 * in testSuite.py : Modify the rules for checking the paths
1026 : Explicit error messages
1027 * in __init__.py : Related modif
1029 2003-11-03 Jean-Pierre Roux
1030 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1031 to be used by aware (vtk) users that want to manage
1032 LUT (and no to turn the PALETTE image into an RGB pixels one)
1033 * GetPixelType now returns 8U for 24 Bits images
1034 (vtkGdcmReader compliant)
1036 2003-10-31 Jean-Pierre Roux
1037 * Removal of *all* gdcmData images and add them again
1038 in order to loose the 'history' of un-anonymised images
1040 2003-10-31 Jean-Pierre Roux
1041 * RMV : removal of useless jBitsInJsample.h
1042 for both 8 and 12 Bits JPEG Lossy Libraries
1044 2003-10-31 Jean-Pierre Roux
1045 * ENH : Add the functions gdcmFile::GetImageDataRaw
1046 gdcmFile::GetImageDataIntoVectorRaw
1047 that act as GetImageData and GetImageDataIntoVector
1048 except the making of an RGB Plane from Gray Plane + LUT
1049 Intended to aware (vtk) users who know how to manage
1052 GetLUTRGBA return a R,G,B,A LUT if any
1053 lgrTotaleRaw gives the 'Raw' length
1054 GetImageDataRaw returns the gray Plane
1055 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1056 (They stay Grey, just like with other Dicom viewers :-(
1058 2003-10-30 Jean-Pierre Roux
1059 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1061 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1062 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1063 being coherents dicom files.
1065 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1066 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1068 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1069 * ENH: Two steps is necessary to please VC++ compiler...
1070 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1071 * ENH: Add include dir to medcon lib
1072 * FIX: only one function is being exported for now !
1073 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1075 2003-10-29 Jean-Pierre Roux
1076 * adding gdcmHeader::GetLUTRGBA
1077 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1078 --> Mathieu, the modif u're waiting for is not yet committed
1079 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1081 2003-10-27 Jean-Pierre Roux
1082 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1083 00191113.dcm DermaColorLossLess.dcm
1084 MxTwinLossLess.dcm RadBWLossLess.dcm
1085 * ENH: For version prior to vtkImageViewer2 -r 1.19
1086 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1088 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1089 * Removal of ido stuff in CMakeLists.txt
1091 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1092 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1093 * FIX: remove a call to ->Modified ... see comments
1094 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1096 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1097 * FIX: Problem with path for libvtkgdcmPython
1098 * ENH: Try adding a search script for python site-package
1099 * RMV: Remove some file from medcon lib that are not necessary
1100 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1101 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1102 * FIX: More pragma disable fro VC++,
1103 I don't think I break something as it is also disable in VTK/ITK.
1104 But it fasten debug compilation time.
1106 2003-10-23 Jean-Pierre Roux
1107 * gdcm now deals with 16 Bits Run Length Encoded images
1108 (they are compressed as 2 planes images,
1109 one for the high Bytes, the other for low Bytes)
1111 2003-10-22 Jean-Pierre Roux
1112 * Now CheckRead takes into account :
1113 - the bugged 'Leonardo' Siemens images
1114 - the XA images, sent thru the burning VPRO station
1115 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1118 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1119 * FIX: When copying a Makefile.am to CMakeLists.txt
1120 one should remove the '\'
1122 2003-10-22 Jean-Pierre Roux
1123 * in gdcmData adding a bugged 'Leonardo' Siemens image
1124 (wrong lengths in header)
1125 OK with gdcm, KO with the other viewers :-)
1126 * add a GE dlx XA image, thru the VEPRO burning station
1129 2003-10-21 Jean-Pierre Roux
1130 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1131 for a brutal checking of vtkgdcmViewer compliance
1133 2003-10-21 Jean-Pierre Roux
1134 * add the files for 'xmedcon' Jpeg Lossless library
1135 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1137 2003-10-21 Jean-Pierre Roux
1138 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1140 2003-10-21 Jean-Pierre Roux
1141 * garbage Siemens 'Leonardo' images dealt with
1142 (the patch is easy to remove)
1143 * cosmetic changes to avoid warnings
1145 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1146 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1147 no need to press 'r' now.
1149 2003-10-20 Jean-Pierre Roux
1150 * upgrade of checkRead.sh checkWrite.sh according
1151 to new Jpeg Lossless decompressor
1152 * add US.3405.1.dcm, a genuine RGB medical file ...
1153 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1154 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1156 2003-10-15 Jean-Pierre Roux
1157 * general anonymisation in gdcmData
1158 * adding the 'color files' from
1159 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1160 * adding some well knowed bugged-header images
1161 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1162 waiting for their inclusion in Python testsuite
1164 2003-10-15 Jean-Pierre Roux
1165 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1166 no longer seg faults when file is not found
1168 2003-10-14 Jean-Pierre Roux
1169 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1172 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1173 * TODO: *.in file to genereate a UseGDCM later
1175 2003-10-14 Jean-Pierre Roux
1176 * Some supposed-to-be Dicom Images have no preamble.
1177 OpenFile takes it into account
1178 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1179 * Missing elements added in dicomV3.dic
1180 (just to be affraid : have a look at
1181 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1182 and do it again next year ;->
1184 2003-10-13 Jean-Pierre Roux
1185 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1186 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1187 But there are NOT. It's fixed !
1189 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1190 * FIX: "jpeglib.h" was not found on VC++
1191 * FIX: vtkgdcm was not being installed
1193 2003-10-10 Jean-Pierre Roux
1194 * ENH : OpenFile closes the file if it *really* doesn't look like
1195 an ACR-NEMA / DICOM one.
1196 * FIX : testWrite no longer writes an empty file if the source file
1197 is not gdcm Readable
1198 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1201 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1202 * FIX: CMake generate now documentation
1203 * ENH: out of source doc build !
1204 * ENH: Generate both user and dev documentation
1205 * ENH: Should work on windows too
1206 * ENH: Only one doxygen config.in file is needed
1207 * FIX: make install should be ok now on ùnix plateform
1208 * FIX: PATH to dictionary was wrong (missing /)
1209 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1211 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1212 * vtkGdcmReader is now able to read rgb dicom file.
1213 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1214 * added a gdcmViewer to vtk test, use mouse to control
1215 window level & window width
1217 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1218 * CMake-ification of gdcm, we have now two build system
1219 * FIX: on cygwin Wsock32 doesn't exist
1220 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1222 2003-10-06 Emanuel Ollart
1223 * FIX : compilation process wad broken.
1224 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1226 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1227 * change gdcmViewer -> vtkgdcmViewer
1228 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1230 2003-10-06 Jean-Pierre Roux
1231 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1232 ( e.g : well known GE images with a wrong elem length,
1233 : Philips MRI Images with a wrong Huffman table)
1234 * still to be done : allow the reading of bugged LEONARDO Siemens images
1236 2003-10-03 Jean-Pierre Roux
1237 * Odd length strings are padded with '\0' (not with spaces,
1238 to remain compliant with already defined strings,
1239 like Transfert Syntax UID and others)
1241 2003-10-03 Jean-Pierre Roux
1242 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1243 to allow displaying RGB images (not only by affim ;-)
1245 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1246 * vtkGdcmReader is now able to read rgb dicom file.
1247 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1249 2003-10-03 Jean-Pierre Roux
1250 * A few nasty patches to allow the reading of a lot of nasty images
1251 ( e.g : well known GE images with a wrong elem length,
1252 : Philips MRI Images with a wrong Huffman table)
1253 * still to be done : allow the reading of bugged LEONARDO Siemens images
1255 2003-10-03 Jean-Pierre Roux
1256 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1258 2003-10-03 Jean-Pierre Roux
1259 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1260 to allow displaying RGB images (not only by affim ;-)
1262 2003-10-03 Jean-Pierre Roux
1263 * gdcmFile::GetImageDataIntoVector now
1264 - deals with MultiFrames MultiFragments Run Length Encoded files
1265 - deals with YcBcR (YBR_FULL) files
1266 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1267 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1269 (no sample found :-(
1271 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1272 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1273 Two reasons: - clear things
1274 - third parties acces gdcm through header files, so won't
1275 suffer anymore VC++ complains
1277 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1278 * add argv[1] in testvtkGdcmReader.cxx
1281 2003-09-24 Jean-Pierre Roux
1282 * The lines are now eigthy characters long.for
1283 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1285 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1286 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1287 char* to std::string. Thus, the use of strdup becomes useless. (see
1288 previous commis of Malaterre)
1289 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1290 before the last Malaterre's commit.
1292 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1293 * This commit should fix the Debug building under VC++, the problem
1294 was mainly a mixture of debug and release lib being loaded at startup.
1295 * I also remove a depency to a specific C function: strdup. Because I had
1296 to force the link to msvcrtd (whereas strdup is in libc).
1298 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1299 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1300 located in the gdcmCommon.h file. All use of reference of tha has been
1301 changed to now use the variable GDCM_UNFOUND.
1303 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1305 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1306 Dicom dictionary. The test suite can now be run again. Note:
1307 I'm note very happy with the " (RET)" changes. I believe this
1308 RETAINED comment should be dropped when parsing the dictionary.
1309 - PACKAGER corrected
1311 - AUTHORS updated and now in alphabetical order
1312 * Makefile.am now exports gdcm.dsw for Windoze users.
1314 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1315 * cygwin complains about missing std:: in subdir Test/
1317 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1318 * remove some methods that are now in gdcmHeaderHelper
1320 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1321 * vtkGdcmReader set spacing and origin correctly
1323 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1324 * Fix a few delete/delete[] mismatch
1326 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1327 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1328 interpretation to data given by gdcmHeader. For instance there are
1329 heuristics to get informations (look at different places).
1330 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1331 sorting DICOM images based on different strategies.
1332 * modified Makefiles accordingly.
1334 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1335 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1336 when building in debug mode
1337 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1338 src/win32/gdcmdll.dsp
1339 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1341 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1342 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1345 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1346 * src/win32/libgdcmjpeg12.dsp was not dos format
1347 * src/win32/libgdcmjpeg12.dsp :
1348 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1349 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1351 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1352 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1354 * src/gdcmFile.cxx : bug fix in affectation type
1355 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1356 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1357 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1358 symbols... future problem ?
1360 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1361 * src/win32/libgdcmijpeg12.dsp was missing
1362 * modified gdcm.dsw accordingly
1364 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1365 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1367 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1368 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1369 commit of JPR (before his hollidays to facilitate our work).
1370 * setup.py : bug fix in code. Modifications made while the last commit
1371 of JPR. The code hasn't been tested before the commit... it's so
1372 useless to make that (for best programmer that is JPR) !!!
1374 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1375 * tagged the current version as Version0_3 (i.e. version 0.3)
1377 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1378 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1379 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1380 * *.dsp : modifications to use new libgdcmijpeg8 library
1381 * setup.py : bug fix on VTKPATH variable
1382 * PACKAGER : adding all concerning windows
1384 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1385 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1387 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1388 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1389 test suite reported error.
1390 * PACKAGER file added (describes what a packager must do when
1391 packaging a new release).
1392 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1393 * configure.in: upgraded version number to 0.3.0
1394 * fixing build of rpm (through rpm -ta):
1395 - Doc/Makefile.am exports proper doxygen files
1396 - src/jpeg/libijg8/Makefile.am exports the include files.
1398 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1399 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1400 * src/gdcmHeader.h : formatting code
1402 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1403 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1404 We were obtaining error message from vtk. Now, creation of file list
1405 is made in an internal list to prevent this problem.
1406 Bug fix when output is empty.
1407 Bug fix in update of progress value. Previous commit for this was a bad
1409 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1411 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1412 * src/gdcmHeader.h : added method to get the file name
1413 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1414 files. Added method to remove all files on the input
1415 Added FIXME comment concerning the bad parsing of header made by
1416 ExecuteInformation method (in ExecuteData method)
1418 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1419 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1420 when using make instal.
1421 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1422 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1424 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1425 * setup.py : adding include dir of jpeg lib to compile all sources
1426 * */Win32/*.dsp : JPR fix for windows compilation
1428 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1429 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1431 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1432 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1434 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1435 * setup.py is again effective on un*x (takes into account the
1436 addon of the jpeg library)
1437 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1438 * Doc/Doxy* updated (includes above enhancements)
1439 * INSTALL now points to web documentation
1441 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1442 * src/gdcmHeader.h doesn't make unnecessary reference to
1444 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1446 * src/gdcm*.[cxx|h] :
1447 - to allow compilation with gcc 3.x
1448 -- clean up of STL usage (added explicit usage of std::)
1449 -- small fixes on exceptions.
1450 Note: linking not tested !
1451 - clean of doxygen comments to avoid warnings at documentation
1453 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1454 dependent convertion).
1456 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1457 * Clean up of previous JPR garbage commit (not even commented in the
1459 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1460 - moved all jpeg related files from src to src/jpeg/libijg8, with
1461 addition/modification of Makefile.am and configure.in.
1462 - the testSuite is still brain damage (not guilty).
1464 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1465 * WrapVTK.py : modifications to get correctly vtk source files to
1467 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1468 (FileName -> Filename)
1470 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1471 * vtk/vtkGdcmReader.[cxx/h]:
1472 - UpdateProgress method should now be effective
1473 - removed the limitation on having only images loaded (as opposed
1475 - when building a stack of images/volume, a lesser number of
1476 gdcmHeader and gdcmFile instances should be used (hopefully
1477 accelerating things).
1478 - when building a stack of images/volumes, files which are not
1479 loadable (wrong path-filename, wrong permissions on existing file,
1480 or file not parsable by gdcm) are replaced with a black image
1481 in the stack (for the caller to notice the problem).
1483 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1484 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1486 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1487 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1488 between standard library (std) and vtk library (problems are found
1489 under Windows... thanks Windows !)
1491 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1492 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1494 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1496 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1497 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1499 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1500 * When compiling with distutils (see setup.py) the C++ compiler is
1501 called with different flags than the default ones (with automake).
1502 In order to fix all those warning, I compiled gdcm with the command
1503 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1504 and went for warning fixes:
1505 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1506 up from unused variables.
1507 - vtk/vtkGdcmReader.cxx: potential bug fix.
1508 * src/gdcmHeader.h: Doxygen warning cleanup
1510 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1511 * gdcmPython/gdcm.i:
1512 - typemaps correction to take into account the systematic replacement
1513 of "using namespace std" with std:: prefix e.g. std::list,
1514 std::string... (cf changes of 2003-05-21).
1515 - gdcmGlob global variable of type gdcmGlobal (defined in
1516 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1517 exported to Python a as cvar.
1518 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1519 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1520 gdcmDictSet.GetPubDictTagNames() and
1521 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1522 C++ static methods).
1523 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1524 with the above changes.
1526 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1527 * setup.py, manifest.in : bug fix under linux
1529 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1530 * Modification of setup.py to compile vtk part too. Then, we have 2
1531 wrappers which must work with same distutils. For that, we have a
1532 generic distutils in distusiltsWrapping.py ; with :
1533 - build_extWrap class to wrap generically all extensions,
1534 - ExtensionWrap base class for all wrapping extension that contains
1536 - Wrapper interface which wrap sources
1537 + In WrapSwig.py we have extension and wrapper for Swig
1538 + In WrapVTK.py we have extension and wrapper for VTK
1539 * MANIFEST.in : modifications to consider vtk directory and new python
1540 files for compilation
1542 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1543 * Added python wrappers of vtkGdcmReader vtk class (see the
1544 source in vtk/vtkGdcmReader.cxx) :
1545 - vtk/Makefile.am now builds a library
1546 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1547 python library (as opposed to _gdcm.so wich are the python
1548 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1549 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1551 - configure.in has an additional flag --enable-vtk that needs
1552 to be set to enable compilation of vtk related code, that is:
1553 + vtk/vtkGdcmReader.so and
1554 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1555 + gdcmPython/vtkgdcmPython.so (see above)
1556 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1557 be read when compressed or when HighBit + 1 != BitsStored),
1558 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1559 the usage of the python wrapper of vtkGdcmReader vtk class.
1560 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1561 * src/*.[h] all occurences of stl classes are now prefixed with
1562 std::, and all occurences of "using namespace std;" where removed.
1563 This is to avoid pollution of global namespace in included files.
1564 Apparently vtk does not avoid this pitfall: when using both
1565 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1566 collision of various stl members (principally cout...).
1567 * gdcmPython/testSuite.py now cleanly removes temprory generated
1569 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1570 comply with above changes)
1572 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1573 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1574 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1575 vtk data structure (an image Flip was required).
1576 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1577 * cosmetic changes in documentation.
1579 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1580 * src/gdcmHeader.cxx: the constructor no longer exits when an
1581 unexisting file is given as argument.
1582 * The subdirectory Data (containing all the images used for the
1583 test suite) is not part of this repository anymore. A new module
1584 containing those images is now available at
1585 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1586 with the name gdcmData.
1587 All the python scripts (including the package initialisation file
1588 gdcmPython/__init__.py) were adapated to take this change into
1589 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1591 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1592 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1593 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1594 demo of the usage of this class.
1595 Compilation of this vtk part is only done when using the --enable-vtk
1596 at configure (or autogen.sh) stage.
1598 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1599 * More memory link related corrections and documentation fixes.
1601 - maximum info is obtained with a command of the form:
1602 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1603 --show-reachable=yes PrintHeader
1604 - the remaining reachable blocks seem to come from the STL
1605 allocation scheme through the usage of map and list. It looks
1606 like this memory cannot be freed but it is not a memory leak
1607 (in fact further invocation to the STL would recollect the
1608 unused memory allthough it cannot explicitely be freed).
1609 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1610 of displaying an image parsed with gdcm and displayed with VTK.
1611 Note: some images don't seem to work e.g.
1612 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1613 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1614 Allthough this weakens the semantics, it is a ditch attempt to
1615 make gdcm more thread friendly.
1617 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1618 * Memory link hunt (by using valgrind through the command
1619 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1620 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1621 gdcmHeader::_dicom_vr.
1622 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1623 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1625 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1627 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1628 * src/Makefile.am now exports all the necessary include files at
1632 * UpdateGroupLength replaced by new one
1635 * UpdateGroupLength re-written using H-Table
1636 (named UpdateGroupLengthNew untill checks are over)
1638 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1639 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1640 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1642 - gdcmHeader::GetPubElValSet removed.
1643 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1644 UpdateGroupLength, WriteElements, Write.
1645 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1646 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1647 carried the same semantics.
1648 - src/gdcmHeaderIdo.cxx changed accordingly.
1649 - gdcmFile::WriteBase now regroups all the codes from previous
1650 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1651 - enum FileType moved to gdcmCommon.h
1652 * src/gdcmHeader.cxx AddDefault trashed
1653 * gdcmGetXSize added
1654 * getimageDataSize now calls gdcmGetXSize
1655 * Test/*.cxx changed to agree with above changes
1657 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1658 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1659 (to avoid double call by end user).
1660 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1661 by end user, since gdcmHeader::gdcmHeader now handles it.
1663 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1664 * gdcm/Doc many doxygen changes:
1665 - Doxyfile now has two different versions, DoxyfileUsers that generates
1666 the html.users end users oriented documentation and
1667 DoxyfileDeveloppers that generates the html.developper developper
1668 oriented documentation.
1669 - README changed accordingly
1670 - requirement.txt removed (old design info moved to TODO).
1671 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1672 DoxyMainPage.txt, DoxyPython.txt provide more information.
1673 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1674 be updated by simply regenerating the docs with doxygen and copying
1675 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1676 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1677 all the tests in the form "if (<map>.count() >1)" were removed.
1678 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1679 ill-formed documentation sections.
1680 * src/gdcmHeader.cxx: ditto
1682 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1683 * setup.py fixed for un*x (needed macro for stdint.h)
1684 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1685 un*ces with sh-utils test utility.
1686 * gdcmPython/demo/test.py renamed to PrintHeader.py
1687 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1688 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1689 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1690 * src/gdcm*.cxx JPR's bad inclusion fixed.
1692 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1693 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1694 * gdcmPython/demo/test.py changed accordingly.
1696 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1697 * gdcmPython/Makefile.am fixed linking against libstdc++
1698 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1699 * Swig subdir (historical tests of swig version 1.3.17++) removed
1700 * Test/testChangeEntete.cxx some lines commented out in order to make
1702 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1703 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1705 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1706 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1707 hence the user doesn't need this explicit call.
1708 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1709 i.e. LoadElements() call removed.
1710 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1711 - src/Makefile.am declares the proper flag for g++.
1712 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1713 for adding user defined new tags.
1714 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1715 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1716 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1718 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1719 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1720 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1721 src/Makefile.am : the project should properly compile and install
1722 with the autotools, included the python wrappers part.
1723 * gdcm.spec.in : added a spec file for RPM packaging.
1725 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1726 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1728 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1729 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1730 to exported to the environement (see gdcmPython/testSuite.py
1732 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1733 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1734 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1735 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1736 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1738 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1739 * gdcmPython/__init__.py doesn't crash anymore when running in
1740 in InstallMode or PreInstallMode but with an environement given
1741 value of GDCM_DICT_PATH.
1742 * src/gdcmDictSet.[cxx/h] coding style.
1744 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1745 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1746 * src/gdcm.h general comments moved to TODO, and README
1747 * src/gdcm.h should now be seen as a user commodity (including it
1748 should suffice to fully use gdcm). It is nowhere including within
1749 any of the kernel files src/*.cxx and src/*.h.
1751 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1752 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1753 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1755 * src/gdcm*.cxx only include their corresponding include file
1756 (as opposed to gdcm.h)
1757 * gdcmPython/gdcm.i changed accordingly
1758 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1759 the autogen.sh generated "make snapshot" command to work.
1760 * autogen.sh removed history related references to crea package.
1762 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1763 * distutilsSwigCPlusPlus.py work around some swig portability
1766 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1767 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1768 was done in a last ditch attempt to get setup.py _really_
1769 operationnal. The python/gdcmPython layaout add the advantage
1770 of hidding away the python related distutils specific files
1771 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1772 Alas, the src directory was out of scope (i.e. it's relative
1773 position to setup.py was ../src) which made things impossible to
1774 handle (see previous version of python/setup.py). Crossing fingers...
1776 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1777 * python/setup.py now works on Un*x. (harder than I thougth)
1778 * python/distutilsSwigCPlusPlus.py can now have include files
1779 among the list of sources.
1781 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1782 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1783 * modifications in MSVC projects
1785 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1786 * As stated by the first lines of Test/ExceptionAndPython/README, it
1787 looks like we can move back to original usage of exception within
1788 src/gdcm* and hence remove the errno stuff that was introduced
1789 as a quick and dirty fixture of this problem (added to the TODO).
1790 * Doc/Doxyfile configuration file for Doxygen and corresponding
1791 README file for usage added.
1792 * Test/testWrite.cxx added. This new test comes from a split of
1793 test.cxx that is now reverted to its original purpous i.e.
1794 testing the proper parsing of a Dicom related file.
1795 testWrite.cxx concentrates on testing the IO part of gdcm.
1796 * Test/bug1.cxx (containing a bug on WIn32) added.
1797 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1798 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1799 whose purpose is to publish the content of the TagNames of the
1800 Dicom public dictionnary were not accessible without an
1801 instance of class gdcmHeader.
1802 - those methods are now static methods of gdcmDictSet and hence
1803 require no instances at all to be invocated.
1804 - within gdcmDictSet this change required to change some method
1805 to class methods (i.e. are now static) among which SetDictPath
1806 (renamed to BuildDictPath) and LoadDefaultPubDict.
1807 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1808 the above changes by calling the new method classes of gdcmDictSet.
1809 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1810 the above to be effective.
1811 * python/gdcmPython: in order to wrap properly the above changes
1812 for Python, swig version now needs to be > 1.3.17.
1813 * python/gdcmPython/Makefile fixed to adapt itself to new
1814 configure/make shema introduced by Johan Montagnat (thanks for the
1815 contribution). Alas this Makefile cannot be turned into a proper
1816 Makefile.am without some heavy changes in the configure.in
1817 (for python dectection).
1818 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1819 now avoids publishing the empty entries.
1821 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1822 * python/setup.py : bug fix concerning install under windows
1823 ExtraPath reused :-P
1824 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1826 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1827 * Dicts/dicomV3.dic : remove double spaces !!!
1828 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1829 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1832 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1833 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1834 method. Doxygenation.
1835 * src/gdcm.h clean up of JPR spurious comments.
1837 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1838 * python/distutilsSwigCPlusPlus.py now properly collects the
1839 shadow classes generated by "swig -c++" (gdcm.py in our case)
1840 when using "python setup.py install".
1841 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1842 reexports the working classes.
1843 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1844 by the classical C errno scheme. This is to prevent an obscure
1845 behavior of the python wrappers when importing wxPython.wx prior
1846 to gdcmPython (which ended up in an abort call). An illustration
1847 of this oddity can be found in the Test/ExceptionAndPython
1848 subdir (see the README file). This problem probably due to
1849 an combination of g++ and dynamic loading.
1850 * added Test/ExceptionAndPython (see above)
1852 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1853 * Changed the layout of the python part to avoid bloating main
1854 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1855 i.e. the distutils arsenal. All the python related stuff is
1856 again in a python subdir, but the package itself is now in
1858 * setup.py was cleaned up:
1859 - pythonIncludePath removed
1860 - python setup.py bdist target is now functional.
1861 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1862 collision with other packages). gdcmPython/demo/*.py changed
1865 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1866 * python subdir moved to gdcmPython (preparation of distutils packaging).
1867 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1868 distutils installer is operational.
1869 * - gdcmPython/__init__.py now properly loads the swig generated
1870 shadow classes (from gdcm.py).
1871 - gdcmPython/demo/*.py changed to import the package gdcmPython
1872 instead of gdcmPython/demo/load.py.
1873 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1875 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1876 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1877 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1878 entries within the associated public Dicom dictionary resp. the same
1879 information but sorted by the fourth field (PAT, IMG, DIR) of the
1881 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1882 are now in the "???" group.
1883 - python/gdcm.i changed accordingly,
1884 - python/demo/printGroupedPublicDict.py added, that gives an example
1885 of the above new functionalities in Python.
1887 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1888 * src/gdcm.h, gdcmHeader.cxx:
1889 - historic references to glib's g_malloc and g_free (#defined)
1890 were definitively removed.
1891 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1892 * src/gdcmElValSet.cxx:
1893 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1894 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
1895 - GetElValue(string) renamed to GetElValueByName.
1896 - Added GetElementByName(string).
1897 * src/gdcmHeader.cxx: added
1898 - GetPubElValRepByNumber(guint16, guint16)
1899 - GetPubElValRepByName(string)
1900 - GetShaElValRepByNumber(guint16, guint16)
1901 - GetShaElValRepByName(string)
1902 - GetShaElValByNumber(guint16, guint16)
1903 - GetShaElValRepByName(string)
1904 - GetElValRepByNumber(guint16, guint16)
1905 - GetElValRepByName(string)
1906 - GetElValByNumber(guint16, guint16)
1907 - GetElValRepByName(string)
1908 * Doc/requirements.txt added.
1910 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1911 * Test/Makefile building now depends on the one of libgdcm.so
1912 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
1913 pixel data) aware which enables finding the address (offset) of
1914 the pixel data of JPEG encoded DICOM files. This leaves only a single
1915 file in the testSuite whose pixel data address (offset) is unknown.
1916 * python/testSuite.py changed accordingly.
1918 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
1919 * VC++ has some strong limitations when working with the STL, as stated
1920 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
1921 "Also note that some STL containers (map, set, queue, list, deque)
1922 cannot be exported. [...]
1923 Some STL classes contain nested classes. These classes can not
1925 This is caused by a designed limitation that once a template
1926 class is instantiated, it can not be re-instantiated and
1928 Since our usage of map<> is ubiquitous in gdcm, this "designed
1929 limitation" of VC++ is a pitfall.
1930 Hence the Python wrappers of gdcm cannot be incrementally linked
1931 against the c++ dynamic library. The dirty but only workaround is
1932 to forget about incremental link of dynamic libraries and to generate
1933 the Python wrappers library with the inclusions of the underlying C++
1935 The following modifications concern this matter on Win32/VC++:
1936 - wrapping python correct with standalone wrapped dll (don't use separate
1937 dll under windows !!!!)
1938 - python21_d debug mode enabled (ask Frog how to use it :-)
1939 - NO problem with having an STL member of class for example string in C++
1940 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
1941 - Python test of dcmlib in Python is ok under windows on a large set
1943 * removed glib references
1944 * typedef's inserted in gdcm.i for correct swig type management
1946 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1947 * python/demo/*.py load.py extracted from test.py. Added explore.py
1948 that only displays required tags and testAll.py that parses all
1949 the files of the testsuite without using unittest.
1950 * python/testSuite.py other additional test on new files added.
1951 * Data/* new test files added accordingly to the testSuite.
1952 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
1953 the vr in the file differs from the one of the dictionary.
1955 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1956 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
1957 values, but limits itself to values which are below a user specified
1958 size (by default 1024 bytes).
1959 * python/gdcm.i : elements not loaded (because their size is above the
1960 user specified treshold) are exported with their TagKey as key of the
1961 python dictionary. This enables the testsuite to make some checks
1962 on the unloaded elements (since we have their offset and size).
1963 * python/testSuite.py
1964 - now tests for the existence and proper value of the pixel data
1965 - two new examples added.
1966 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
1968 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1969 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
1970 aware. See the strategy comments in gdcmHeader::FindeLength().
1971 * Test/test.cxx now accepts a filename as first argument.
1972 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
1973 * python/testSuite.py changed to integrate test on above files.
1975 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1976 * Dicts/dicomV3.dic removed all the trailing (RET) when the
1977 the vr was also RET.
1978 * python/testSuite.py more tests added.
1980 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1981 * python/testSuite.py unittest test suite added (uses Data)
1982 * Data/* dcm and acr files for the test suite.
1983 * glib dependance removed from un*x version. We now use ISO C99
1984 7.18 Integer types (see stdint.h)
1985 - python/Makefile, src/Makefile src/gdcm.h
1986 * src/ when an explicit vr (like dicom files) suddenly poped an
1987 implicit element we use to mark the underlying DictEntry of the
1988 concerned ElValue with "Implicit". This strategy was damageable
1989 too the public or provite dictionaries, since some of their vr
1990 would be changed. Since Header::FindLength heavily relies on the
1991 detection by Header::FindVR of falsely explicit elements, I
1992 added an extra ImplicitVr member to ElValue (boolean).
1993 The rest of the changes we the necessary adaptations.
1995 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1996 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
1998 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2000 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2001 * Adaptation for porting to VC++:
2003 o forced to use std namespace (for string to be known)
2004 o all class use __declspec export style on WIN32
2005 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2006 (in stdlib.h on Win32 but in std:: for gcc)
2007 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2008 variable GDCM_DICT_PATH.
2009 * src/gdcmHeader.cxx verbose comments made discrete.
2011 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2012 * python/gdcm.i: added a typemap that converts a C++ hashing table
2013 to native Python dictionary.
2014 * python/demo/test.py:
2015 - now uses the native dictionary for exploration of gdcmHeader.
2016 - takes an optional filename argument (the file to parse).
2017 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2018 PubElVals hashing table.
2019 * Dicts/dicomV3.dic removed error prone trailing spaces.
2021 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2022 * Python wrapping process moved away from src/Makefile to
2023 newly created python/Makefile (as well as gdcm.i)
2024 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2025 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2026 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2027 from the environement variable GDCM_DICT_PATH (when existing).
2028 * src/gdcmDict::GetTag bug fix.
2030 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2031 * Straightforward temporary fixes for swig to build the python wrappers.
2032 src/Makefile now has a python working entry [by working we mean
2033 that we can import de shadow classes without errors].
2035 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2036 * hashtest.cxx removed (since allready in Test)
2037 * src/gdcmlib.h renamed to src/gdcm.h
2038 * src/dcm.i renamed to src/gdcm.i
2039 * src/Makefile prepared for python wrapping
2041 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2042 * src/gdcmHeader.cxx :
2043 - Parsing of header is now separated from loading of element values
2044 (see gdcmHeader::LoadElements).
2045 - general clean up of hopefully all file access (creation of
2046 ReadInt16 and ReadInt32)
2048 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2049 * src/gdcmHeader.cxx :
2050 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2052 - SetLgrElem renamed to SetLength
2053 - GetLgrElem renamed to GetLength
2054 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2055 * src/gdcmElValSet.cxx fixed both GetElValue methods
2056 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2057 due to IdoDude was cleaned out.
2059 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2060 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2061 concentrates on finding the value representation (when it exists).
2062 RecupLgr now only finds the element value length, and it avoids
2063 returning the unecessary skL (skipped length).
2064 Also, offsetCourant was simply removed (with taille_fich) since
2065 it was redundant with the File position internals (by using
2066 ftell and fseek). This also made skL (see above in RecupLgr) usage
2068 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2069 on the libido specificities which are handled through class
2071 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2074 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2075 * Truckload of changes. Parsing of header is barely functional
2076 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2078 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2079 * src/gdcmHeader.cxx many addons of low level methods
2081 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2082 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2083 and _IdDcmSWAP_LONG.
2085 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2086 * This corresponds to all the changes decided at the meeting of
2087 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob