1 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * CLEANUP_ROUND (2) for gdcmPixelConvert
3 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
5 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
6 * CLEANUP_ROUND for gdcmPixelConvert:
7 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
8 - src/gdcmPixelStuff[h|cxx] removed
9 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
10 - src/CMakeLists.txt changed accordingly
12 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
13 gdcmVersion.py moved to newly created ATTIC related
14 gdcmPython/SetupOldies/ directory.
16 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
17 - autogen.sh configure.in acinclude.m4 python.m4 removed
19 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
20 * src/*.cxx *.h Reference to License.htm fixed to License.html.
21 * Doc/CMakeLists.txt, doxygen.config.in: fix.
22 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
24 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
25 * TODO updated with Mathieu suggestions. I proposed a template for
26 describing TODO entries and used it for new entries.
27 * Added Doc/Website/CodingStyle.html, Developpers.html,
28 DeveloppersPython.html, GdcmDataCvs.html and
29 DownloadVersion0_1.html, DownloadVersion0_3.html.
30 * Some Doc/*.txt Doxygen files (which do not really concern the
31 documentation itself, but the website) moved to html and
32 placed in directory Doc/Website:
33 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
34 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
35 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
36 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
37 * CMakeLists.txt changed accordingly.
38 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
39 DeveloppersPython.html
40 * INSTALL nows refers to Doc/Website/Installation.html
42 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
43 * Added Doc/Website directory, that contains a first raw version
46 2004-09-23 Jean-Pierre Roux
47 * FIX In order not to be poluted any longer by casting problems,
48 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
49 we can now delete[] it safely
50 * VoidArea is now called BinArea (less confusing name),
51 and all the methods called ...VoidArea... are now ... BinArea...
52 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
54 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
55 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
56 clear) TagHT, which is an inherited member of gdcmElementSet. It is
57 up to the destructor of gdcmElementSet to clean up TagHt and it's
60 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
61 * Test/CMakeLists.txt: update to follow gdcmData renamings.
62 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
64 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
65 * ENH: added some utility method that builds a flat dictionnary
66 holding all the Dicom entries contained in the recursive structure
67 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
69 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
70 BuildFlatHashTable() that build a flat dictionary.
71 - src/gdcmElementSet.h: added a new private GetTag() accessor.
72 gdcmDocument is now a friend of gdcmElementSet.
73 - src/gdcmElementSet.cxx: clean up.
74 - Example/FlatHashTablePrint.cxx added.
75 - Example/CmakeLists.txt changed accordingly
77 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
78 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
79 moved away from gdcmDocEntrySet (since this class is an abstract class
80 acting like an interface). SQDepthLevel and BaseTagKey are now
82 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
83 and associated accessors. Doxygenation of the class.
84 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
86 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
87 Use SQDepthLevel accessor instead. ::Print() adapted.
88 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
89 - src/gdcmDocument.cxx changed accordingly.
91 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
92 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
93 - The following is the doxygen comment of the typedef declaration
94 of gdcmagKey in src/gdcmCommon.h:
95 gdcmTagKey is made to old an "universal" (as in URL, Universal
96 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
97 A dicom tag allways has a group and an element, but a set of tags
98 embeded in various (optionally nested) sequences and sharing
99 the same group and element all share the same (group, element)
100 "identifier". Hence the (group, element) cannot be used as an
101 identifier (in gdcm we shall refer to a "TagKey") of a tag.
102 In order to construct a proper tag identifier (i.e. a key) we
103 consider the following definition of a TagKey:
104 - let Group, Element be the string representation of the
105 group and element dicom tag members,
106 - let ItemNumber be the string representation of the integer
107 index of the considered item number of a sequence,
108 Let the key of a tag embeded in a sequence, noted SeqTag, be
110 /ItemNumber#Group|Element
111 where "/", "#" and "|" are characters acting as separators.
112 Then the general form of a gdcmTagKey is given by:
113 Group|Element<SeqTag>
114 where <SeqTag> means NO or many instances of SeqTag.
115 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
118 but the gdcmTagKey of a tag "embeded" is the first item of
119 a sequence, itself nested in the third item of a sequence is the
121 0004|1220/2#0008|0082/0#0008|0090
122 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
123 order to hold the new sequence compatible key. Previously, the
124 GetKey() method would look in the underlying gdcmDictEntry.
125 - src/gdcmDocEntry.cxx:
126 -- constructor now copies the underlying DictEntry key, in the local
128 -- ::Print: displays the member Key, instead of the (group, element).
129 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
130 - src/gdcmDocEntrySet.h:xi
131 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
132 -- now has a new BaseTagKey member.
134 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
135 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
137 This poses the problem with the semantics of the following lines
138 LoadEntryVoidArea(0x0028,0x1201); // R LUT
139 LoadEntryVoidArea(0x0028,0x1202); // G LUT
140 LoadEntryVoidArea(0x0028,0x1203); // B LUT
141 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
142 to the long FIXME note for what the problem is. Nevertheless in
143 order to get things working the dicom dictionary was altered !
144 Please fix things urgently...
145 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
146 information), see above note on moving the member VoidArea. Nevertheless
147 the following entries previously correctly set as US are now inproperly
149 0028 1201 OW IMG Red Palette Color Lookup Table Data
150 0028 1202 OW IMG Green Palette Color Lookup Table Data
151 0028 1203 OW IMG Blue Palette Color Lookup Table Data
152 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
153 of gdcmDocEntry moved to gdcmSeqEntry.
154 * src/gdcmSeqEntry.cxx: STYLE.
156 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
157 * Test/TestAllEntryVerify.cxx minor fix and added comments.
159 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
160 * gdcmPython/testSuite.py: all the test suite in python is now moved
161 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
162 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
163 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
165 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
166 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
167 to avoid inclusion recursion until STL is reached.
168 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
169 mecanism. errno.h is not included in gdcm anymore.
170 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
171 (gdcmFormatError now inherits from gdcmFormatUnexpected).
173 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
174 gdcmData/TestAllEntryVerifyReference.txt
175 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
176 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
177 exception_on_error parameter.
178 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
179 - vtk/vtkGdcmReader.cxx changed accordingly,
180 - Example/*.cxx and Test/*.cxx changed accordingly.
182 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
183 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
184 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
185 enable_sequences removed from gdcmHeader constructor and dependencies.
186 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
187 * gdcmPython/demo/PrintHeader.py: dummy fix.
188 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
189 skip_shadow removed from gdcmHeader constructor and dependencies.
190 * Example/*.cxx and Test/*.cxx changed accordingly.
192 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
193 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
194 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
196 2004-07-21 Jean-Pierre Roux
197 * FIX Now, Parsing and Printing a DICOMDIR do work!
198 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
200 2004-07-20 Jean-Pierre Roux
201 * FIX Some brain damaged headers have Zero-Lenght fields
202 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
204 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
205 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
206 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
207 variable (instance of gdcmDebug) by a definition macro, and the instance
208 is now in static in the gdcmDebug class
209 * src/gdcmSQItem.h : (FIXME) remove an undefined method
210 * Test/PrintAllDocument.cxx : bug fix in the result of the test
212 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
213 * WARNING: ctest now depends more tightly on gdcmData. You should
214 check out gdcmData properly for things to run smoothly...
215 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
216 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
217 we need the pixels not be loaded in order to use the ValEntry
218 that displays position and size).
219 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
220 This is a C++ based equivalent of gdcmPython/testSuite.py that should
221 be deprecated. If you have any doubts about the advantages of a
222 modern scripting language (read Python) versus grass root C++ (i.e.
223 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
224 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
225 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
226 Anyhow, consider documenting the gdcmData images in
227 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
229 * Test/CMakeLists.txt:
230 - now uses TestAllEntryVerify.cxx
231 - specific comments on oldACR00001.ima (now renamed in gdcmData
232 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
233 gdcmData/TestAllEntryVerifyReference.txt
236 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
237 * src/*.[h|cxx] : typedef clean up
238 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
239 - TagKey renamed to gdcmTagKey (for external usage)
240 - VRKey renamed to gdcmVRKey (for external usage)
241 - removal of typedef duplication.
242 - Removed all unecessary inline keyword from class inline definitions.
243 - Some method|function(void) declarations replaced with method|function().
244 * src/jpeg/libijg12/jdhuff12.c:
245 - printf polluting ctest removed.
246 - TAB removal for comminting
248 - TestAllReadCompareDicom.cxx: added a test that compares all the
249 images in gdcmDataImages.h with corresponding images in
250 gdcmData/BaselineDicom/. When baseline images are not present
251 this test creates them.
252 Note: we need to validate each reference image, but before that
253 I'd like to rename them with a more explicit name...
254 - CMakeLists.txt: changed accordingly.
255 * Example/*.cxx: examples now only include gdcm.h (as opposed to
256 including each header needed).
258 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
259 * Test/*.cxx and Example/*.cxx: moved some examples away from the
260 test suite to the Example directory. Are concerned:
265 - TestWriteSimple.cxx
266 * Test/CMakeLists.txt: added some comments on reasons for black listing
267 image gdcmData/oldACR00001.ima
269 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
270 * Test/CmakeList.txt: removed the following from black list (to be coherent
271 with removal from gdcmData):
272 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
273 - gdcm-MR-PHILIPS-16.dcm
275 Added the following because after last cvs update, they cause
276 ctest -R TestReadWriteReadCompare
278 - gdcm-MR-SIEMENS-16-1.acr
280 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
281 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
282 new comments in this file) we temporarily (sigh) move to a weaker
284 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
285 we don't need to black list the following images anymore:
286 - 8BitsUncompressedColor.dcm
288 - US-PAL-8-10x-echo.dcm
289 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
290 fixes and the beautified code ;-)
291 This fixes the bug introduced in version 1.42 (when beautifying)
292 that made the parsing of 8BitsRunLengthColor.dcm unproper.
293 Note: ctest was blind to this bug (this means we need to still
294 improve the test suite). The bug could be detected by using
295 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
297 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
298 and by displaying the (garbage) produced file temp.XDCM...
300 2004-06-29 Jean-Pierre Roux
301 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
302 - replace by uggly but working old code :-(
303 A lot of things should be OK again.
304 It's really urgent to have a test suite that *tests*,
305 to prevent Frog's beautifying sessions to break all the stuff
306 (twice, withing a fortnigh ...)
308 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
309 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
310 redundancy) to added Test/TestReadWriteReadCompare.cxx
311 * Test/CmakeList.txt: because the compare test of
312 Test/TestReadWriteReadCompare.cxx fails, the following images are
313 black listed: - 8BitsUncompressedColor.dcm
315 - US-PAL-8-10x-echo.dcm
316 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
317 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
318 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
319 and ad-hoc kludge. This kludge is now removed, and on encountering
320 such an image (OB field brain damaged) we set errno. Then in
321 ::FindDocLength() we "fix" the length as being ALL what remains
322 in the file (until EOF). We then proceed, hoping for the best...
323 This fixes a SegFault in ShowDicom when trying to write such an
325 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
326 (because TestWriteRead breaks on it, after a non conformal commit?).
327 ctest now runs properly, except for MakeDicomDir (which was allways
328 broken) and the Python related stuff (still not fixed).
330 2004-06-24 Jean-Pierre Roux
331 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
332 FIX : Test/TestReadWrite now iterates on all the file names
333 (instead of infinite loop)
334 ENH : Test/TestWriteRead now iterates on all the file names
336 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
337 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
339 2004-06-24 Jean-Pierre Roux
340 FIX : - now Write drops LUT Descriptors and LUTs (if any)
341 when SamplesPerPixel =3
342 - now Write is no longer confused by
343 'BitsAllocated = 12" and 'BitsStored=12"
344 - "UN" value representation Elements are now written correctly
345 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
346 ENH : - now gdcmHeader has its own Write methods
347 (in order to split the job that has not to be done
350 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
351 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
352 loop on the same image until memory went out.
353 Note: this means we still have gobs of memory loss in PrintDocument
354 * src/gdcmDocument.cxx: fixes problem on parsing on file
355 gdcmData/16BitsJpegLosslessGrayScale.dcm.
357 2004-06-24 Jean-Pierre Roux
358 FIX : Write - All the Sequences and Sequence Item are now written
359 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
360 is added a the end, when necessary.
361 - A lot of brain-damaged images, that were read correctly are
362 now written correctly
363 - length compatible BinEntry are now loaded correctly
364 (even for odd groups)
365 Note : only Explicit Value Representation was checked.
366 (question : is implicit VR really necessary for gdcm ?)
368 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
369 * DEVELOPPER: added a proposition of coding style.
370 * src/gdcmDocEntry.h: removed every inline declaration (for test of
373 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
374 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
375 Use the gdcmDocEntry::Print() and Write() instead.
376 * src/gdcmDocument.cxx: bug fix.
378 2004-06-22 Jean-Pierre Roux
379 FIX : gdcmDocument.cxx
380 - Now we do recognize the JpegLossLess format (there was a misstyping in
381 code 'beautyfication' :-(
382 - Now we automaticaticaly load the Luts, if any
384 2004-06-22 Jean-Pierre Roux
385 In order : to write Sequences, whatever their imbrication level,
386 : to allow user to create his own Sequences
387 a lot of modif where necessary (adding, moving, or virtualising methods)
389 WARNING : save your own sources *before* cvs up !
392 ADD virtual void Write(FILE *fp, FileType filetype);
395 ADD virtual void Write(FILE *fp, FileType filetype);
396 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
399 ADD virtual void Write (FILE *fp, FileType filetype)=0;
400 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
401 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
402 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
403 ADD std::string GetEntryByName(TagName name);
404 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
406 std::string vr = "unkn",
407 std::string fourth = "unkn",
408 std::string name = "unkn");
409 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
410 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
411 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
412 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
413 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
414 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
415 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
416 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
419 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
420 ADD virtual std::string GetEntryByName (TagName tagName);
421 ADD virtual std::string GetEntryVRByName (TagName tagName);
422 REM virtual bool Write(FILE *, FileType);
423 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
424 FILE *_fp, FileType type);
425 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
426 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
427 REM virtual bool WriteEntries(FILE *_fp,FileType type);
428 REM virtual std::string GetEntryByName (std::string tagName);
429 REM virtual std::string GetEntryVRByName (std::string tagName);
430 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
431 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
432 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
434 std::string vr = "unkn",
435 std::string fourth = "unkn",
436 std::string name = "unkn");
437 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
438 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
439 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
440 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
443 ADD virtual void Write(FILE *fp, FileType filetype);
446 ADD virtual void Write(FILE *fp,FileType filetype);
449 ADD virtual void Write(FILE *fp, FileType filetype);
450 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
451 REM std::string GetEntryByNumber(guint16 group, guint16 element);
452 REM std::string GetEntryByName(TagName name);
455 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
457 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
458 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
459 The default constructor invoked by the line
460 gdcmHeader *f1 = new gdcmHeader( header );
461 was gdcmHeader::gdcmHeader(bool) instead of the expected
462 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
463 Hence the parsing wasn't executed... See also below.
464 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
465 as explicit constructor didn't do the trick to fix the above problem.
466 Could anyone explain why ?
467 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
468 properly calls gdcmValEntry::Print() (that was weed out from
469 code related to gdcmBinEntry).
471 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
472 * In order to fix memory leaks:
473 - Test/TestWriteSimple.cxx: added cleaning of free store through
475 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
476 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
477 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
478 (through the call to ::AddDicomDirMeta()) or the destructor
479 would crash when deleting uninitialized ::metaElems].
480 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
481 - src/gdcmDocument.cxx:
482 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
484 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
485 was causing memory leaks.
486 - src/gdcmSQItem.cxx:
487 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
488 cleanly handled with polymophism: sorry but my milage is low).
489 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
490 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
491 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
492 This avoids SegFaulting.
493 - src/gdcmSQItem.h: coding style.
495 - Test/TestWriteSimple still severely sucks. The output image content
496 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
497 damaged when displayed with vtkgdcmViewer.
498 - on memory leaks: TestWriteSimple leaks really less (see entry
499 of 2004-06-18 in Changelog file for the call to valgrind).
500 - on segfaults: ctest now passes all the tests but one (no more
502 * Erroneous leading white fix:
503 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
504 white[s] (as opposed to from >> xxx, that removes it [them].
505 - src/gdcmTS.cxx: ditto.
506 - gdcmPython/testSuite.py: dirty related kludge removed.
507 * src/*: remaining references to gdcmParser removed.
508 * src/*[cxx|h]: added copy[way]left header.
511 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
512 * In order to fix writing of dicom files:
513 - Test/TestWriteSimple.cxx: a simpler example of writing.
514 - Test/CMakeLists.txt changed accordingly.
515 - src/gdcmDocument.cxx:
516 -- The destructor now recursilvely removes potential sequences.
517 -- Bug fix in ::IsJPEG2000()
518 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
519 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
521 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
522 to only declared) and build on top of
523 ::GetDocEntryByNumber(guint16, guint16).
524 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
525 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
526 for usage in destructor and treatement of promotion in
527 ::ReplaceOrCreateByNumber().
528 - src/gdcmSQItem.cxx: destructor should better handle his job.
529 Test/TestWriteSimple now runs (or at least it DOES something).
530 * We can now start hutting memory links. A good starting point is:
531 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
532 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
533 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
535 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
536 * Valgrind note: after Mathieu Malaterre teached me how to read
537 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
539 Using gcc, you can force the STL to use malloc and to free memory as
540 soon as possible by globally disabling memory caching.
541 With 3.2.2 and later, you should export the environment variable
542 GLIBCPP_FORCE_NEW before running your program.
543 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
544 simply vanish (it is still not clear to me, whether this means that
545 STL std::string leaks or if valgrind believes it leaks...).
546 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
547 running bin/gdcmTests makeDicomDir):
548 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
549 - Test/makeDicomDir.cxx now properly traps empty lists and returns
551 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
552 SegFaulting (I drowned in DicomDir related code when trying to
553 understand why the list is empty...).
554 * src/gdcmDocument.h: first BSD license header try.
555 * Doc/License.txt added.
557 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
558 * src/gdcmDocument.[h|cxx]:
559 - Clean up of the Transfer related predicates. They are now all based
560 on new method isGivenTransferSyntax, that (should) handle properly
562 - general clean up, simplification, and coding style.
563 - Specific clean up of Parse7FE0() (umproperly named actually).
564 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
566 2004-06-14 Jean-Pierre Roux
568 - fix the display of Sequence Delimitor (SQDepthLevel pb)
569 - fix the display of SQItem ordinal number
570 - add the GetSQItemByOrdinalNumber method
571 - remove some useless never written private methods
573 2004-06-14 Jean-Pierre Roux
575 - adding a constructor taking a gdcmDocEntry as an input param
576 - ReplaceOrCreateByNumber now returns :
577 a gdcmBinEntry * if a Binary (void *) value is passed as a param
578 a gdcmValEntry * if a string value is passed as a param
580 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
581 according to the param type (no longer sets a gdcmDocEntry)
582 - GetValEntryByNumber, GetBinEntryByNumber added
583 - NewValEntryByNumber and NewBinEntryByNumber added
585 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
587 - GetSQItemNumber and SetSQItemNumber added, to provide
588 a (relative) Item identier inside a given Sequence
589 \warning : some pb remaining around this number
591 - AddEntry now takes the Item Number as a param
593 - adding a constructor taking a gdcmDocEntry as an input param
595 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
596 * Memory leak hunt with the following command:
597 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
598 --show-reachable=yes gdcmTests PrintDocument
599 It looks like many (all?) leaks are due to the STL (or a bad usage
600 of the STL. The lines producing the leaks now have a comment with
601 a "MEMORY LEAK" tag: you can retrieve them with
602 grep "MEMORY LEAK" src/*
603 Here are two typical examples which I can't help fixing:
608 char * test = "babo";
609 name = test; //// <--- valgrind detects 960 bytes lost in
610 //// call to std::string::operator=(char const*)
611 name.clear(); //// Doesn't help !
619 std::cout << "Type a bunch of characters followed by RETURN: ";
620 getline(std::cin, line); //// <--- valgrind dectects a loss
621 //// of 1320 bytes in call to
622 /// std::basic_istream<>& std::getline<>
628 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
629 * src/gdcmHeader.[cxx|h]:
630 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
631 and related, moved away to gdcmDocument.
632 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
633 the corresponding protected accessors of inherited class
634 gdcmDocument, removed ! As a consequence gdcmFile had to be
635 declared friend of class gdcmDocument (see below).
636 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
637 - Clean up of undefined or unused methods.
638 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
639 account the changes to gdcmHeader.h).
640 * src/gdcmDocument.h:
641 - gdcmFile is now a friend class (in order to take into account the
642 changes to gdcmHeader.h).
643 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
644 (see changes to gdcmHeader.h).
645 - Accessors (reading on the form GetEntry*) are now public.
646 - Clean up of undefined or unused methods.
647 * src/gdcmDocument.cxx:
648 - adaptation to changes to gdcmDocument.h
649 - ::OpenFile now writes a verbose message when file cannot be opened.
650 - some std::string properly set to VRKey
651 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
652 references to gdcmDocument.
653 * Test/TestFindTags.cxx: changed accordingly to above changes.
654 * gdcmPython/testSuite.py: adapted to renaming of acr files in
655 cvs repository gdcmData.
657 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
658 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
659 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
660 conflicts with gdcmValEntry::voidArea.
661 * src/gdcmValEntry.cxx: unmatching comment wiped out.
662 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
663 Value representation between StringRepresentable and BinaryRepresentable.
664 * src/gdcmDocument.cxx:
665 - method ParseDES: proper indentation restored and usage of
666 gdcmVR::IsVROfGdcmStringRepresentable wired in.
667 - method LoadDocEntry: the fingerprint left in the SetValue() of
668 unloaded entries (length > MaxSizeLoadEntry) had curiously been
669 removed. Reverting to previous code segment with the proper
670 dynamic_cast< gdcmValEntry* >.
671 Note: this was (partially) breaking the python test suite
672 (gdcmPython/testSuite.py) that made usage of the above
673 fingerprint to check presence of "Pixel Data".
674 * src/gdcmDocEntry.h: coding style.
675 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
676 now taken into account.
677 * gdcmPython/gdcm.i: adaptation to the new internal representation
678 of gdcm (exit gdcmParser, hello gdcmDocument).
679 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
681 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
682 anymore, but instead prints the loaded Python dictionary.
683 * .... alas, the python testSuite is still broken.
685 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
686 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
688 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
689 * src/gdcmUtil.h : export methods
691 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
692 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
694 * Initial addition of automatic python testing
695 * Initial addition of automatic image comparison
697 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
698 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
699 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
701 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
702 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
703 * Test/ShowDicom.cxx : bug fix for msvc compilation
704 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
706 2004-05-04 Jean-Pierre Roux
707 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
708 new concepts (and new classes) :
709 a 'gdcmDocument' is composed of a set of Doc Entries, that are
710 - elementary gdcmDocEntries (former gdcmHeaderEntries)
711 - Sequence Doc Entries (gdcmSeqEntries)
712 a Sequence is composed of Items.
713 Each item is a set of Doc Entries (this is recursive)
714 The non uniqueness of the 'Dicom tag' is due to this recursivity
715 (never taken into account)
716 Our unability to add a new 'entry' in the header
717 at the proper location (neither in the H-Table (map or multimap),
718 nor in the Chained List is also due to this recursivity.
719 Don't try, right now, to use/modify/compile these new sources :
721 We just commit all the stuff, 'as is', in order not to loose it.
723 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
724 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
726 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
727 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
728 file prefix (SetFilePrefix)
730 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
731 * Add a new test: ShowDicom, for now this is just the c++ version of
732 checkRead.sh, later it will be able to compare the image read against a
734 * Replace the DEBUG on the stack with a global entry in cmake interface:
735 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
737 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
738 * Add an example subdir, with a real example on how to read + write a
741 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
742 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
743 * Doc/CMakeLists.txt: the main page is now properly differentiated
744 between the developper and user version.
745 * Doc/doxygen.config.in: dropped search related obsolete flags
746 * src/gdcmParser.h, gdcmHeader.h: doxygenation
748 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
749 * DEVELOPPER: added some helpfull comments for compile/test/install
752 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
753 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
754 src directory, now generated in the build dir.
755 2. Tests as mentionned smarter
757 4. Add a new method in gdcmDict that return the PubDict by name
758 this is interesting for 3rd party lib like ITK,
759 where we could set the institution name / patient name...
761 * ENH: 1. Now the test suite is working for real
762 2. All binaries are now output in the gdcm-bin directory
763 (this was not true before)
765 2004-04-28 Jean-Pierre Roux
766 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
767 SeQuence indented printing of Dicom Header.
768 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
769 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
770 Computation of SQDepthLevel is now part of gdcmHeader constructor
771 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
772 tree-like structure of a Dicom Header.
773 * FIX Test code cleaning
775 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
776 * ENH: Adding automatic testing
777 1. Need a DartConfig.cmake to submit to public
778 2. Add a test driver gdcmTest.cxx
779 3. gdcmTestMain, an helper for the main test driver gdcmTest
780 4. Files in Test don't have a main anymore, this becomes interesting
781 when we add more and more tests, thus dsw don't have to load
783 * ENH: Adding a GDCM_DATA_ROOT for testing
784 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
785 one file instead of seven + some small cleanup
787 2004-04-22 Jean-Pierre Roux
788 * ENH Minor changes to the Print() methods.
789 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
790 Header printing. Example given with :
791 > PrintHeader fileName 2 new
792 (SQ based tree-like structure still to be done for the Header ...)
794 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
795 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
796 1. I have added some unsigned where needed
797 2. Some function parameter not used -> (void)
798 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
799 4. g++ don't like character '\' in comment
800 5. #define jpeg_create_decompress jCreaDecompress
801 this really need to be fixed
802 6. virtualize destructor of gdcmObject ... leakage
803 7. sscanf(g->first.c_str(),"%x",&gr_bid);
804 this also really need to be fixed
805 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
806 remove compression file
807 (as we only do decompression, right ?)
808 * ENH: Change malloc/calloc/free with c++ equivalent
810 2004-04-21 Jean-Pierre Roux
811 * FIX gdcmHeaderHelper::GetXSpacing
812 when a single value is found (bug ?), xpacing is now
813 defaulted to yspacing
815 2004-04-19 Jean-Pierre Roux
816 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
817 * ENH add parameters :
818 bool exception_on_error = false,
819 bool enable_sequences = false,
820 bool ignore_shadow = false
821 to the gdcmFile constructors to be full gdcmParser compliant
822 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
823 to allow reading of PAPYRUS 3.0 files
825 2004-04-06 Jean-Pierre Roux
826 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
828 2004-04-02 Jean-Pierre Roux
829 * ADD : Test/checksequence.sh, for a general recap on SQ pb
830 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
831 for Philips spurious Tag fffe|0000 while rewritting Dicom files
833 2004-03-30 Jean-Pierre Roux
834 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
835 for ACR file, written out as DICOM files (hope so...)
837 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
838 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
839 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
840 moved to base class gdcmParser and only the specialisation is kept
842 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
843 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
844 already does the job.
845 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
846 (to be consistent with gdcmParser::WriteEntries).
848 2004-03-30 Benoit Regrain
849 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
850 upate of the object's instance. It's passed to 2 in the unfavorable
851 case : one in the ExecuteInformation, one in the ExecuteData
853 2004-03-29 Jean-Pierre Roux
854 * ENH : Check on file type to be written moved
855 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
856 * FIX : gdcmObject::ResetBoundaries now stops properly
857 when end-of-list is reached
858 : gdcmVersion modified (as Benoit Regrain asked)
860 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
861 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
862 * src/gdcmUtil.cxx: added forgotten iostream include.
863 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
864 equivalent to ExplicitVR in existing code).
866 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
867 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
868 now contains all the gdcmGlobal related code.
869 * minor coding style and doxygenation changes.
871 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
872 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
873 now contains all the Debug related code.
874 * minor clean-up of includes in src/*.cxx
875 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
876 CreateCleanString) removed.
877 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
878 * Doc/DoxyMainPageUser.txt added.
879 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
880 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
883 2004-03-24 Jean-Pierre Roux
884 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
886 2004-03-23 Jean-Pierre Roux
887 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
888 big endian made volumes
889 * ENH Now gdcmParser constructor and destructor are protected to forbid
890 end user to instanciate class gdcmParser
891 (only gdcmHeader and gdcmDicomDir are meaningfull)
893 2004-03-22 Benoit Regrain
894 * FIX : src/gdcmDicomDir.cxx : make windows compilable
895 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
896 gdcmSerie to gdcmDicomDirSerie
898 2004-03-19 Jean-Pierre Roux
899 * ENH Now the tree-like structure describing a DICOMDIR comming from
900 an already existing DICOMDIR file is consistent with
901 the home-made tree-like structure build ex-nihilo
902 or build from the files held (recursively) in a Directory
903 functions gdcmDicomDir::CheckBoundaries()
904 gdcmObject::SetBoundaries() added
906 2004-03-17 Jean-Pierre Roux
907 * REM (Eric Boix bug) : removal of meaningless
908 gdcmDicomDirImage::NewImage function.
909 * FIX now file names and directory name are written properly in the
911 * FIX now gdcmDicomDir constructor may be call without any trick
914 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
915 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
916 of gdcmDicomDirImage::NewImage as empty function.
918 2004-02-28 Jean-Pierre Roux
919 * ENH add gdcmDicomDir:NewPatient
920 add gdcmDicomDirPatient:NewStudy
921 add gdcmDicomDirStudy:NewSerie
922 add gdcmDicomDirSerie:NewImage
923 to allow making gdcDicomDir object.
924 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
925 (as opposite to the gdcmHeader chained list)
927 2004-02-11 Benoit Regrain
928 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
929 when using from python
931 2004-02-10 Benoit Regrain
932 * FIX : bug fix in the gdcmDirList for the recursivity in directories
933 * FIX : in gdcmDicomDir when the directory is empty
934 * ENH : add callback and methods to get the progression of dicomDir
937 2004-02-06 Jean-Pierre Roux
938 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
939 - GDCM_META added to gdcmDicomDirType
940 - class gdcmMeta created
941 * ENH : - A brief summary is now displayed at the beginning of
942 'testDicomDir' to help disaster magnitude estimation
943 * REM : Now useless Test/explDICOMDIR.cxx
945 2004-02-05 Benoit Regrain
946 * ENH : add methods in gdcmObject to get the hash table or the list of
948 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
949 * FIX : wrapping python for TagHeaderEntryHT
951 2004-02-04 Benoit Regrain
952 * FIX : even length for some strings when writting the dicom dir
953 * FIX : sort the images in the dicom dir
954 * FIX : Bug fix for python use of dicom dir
955 * ADD : a python demo
957 2004-02-04 Jean-Pierre Roux
958 * FIX : Final solution (?) for icone embedded images
959 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
960 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
961 add groups 6002, 6004, 6006, to allow 'clean' parsing of
962 gdcmData/gdcm-MR-SIEMENS-16.acr1
963 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
964 to make full checking easier
966 2004-02-04 Benoit Regrain
967 * FIX : WriteEntries : coding style & logic in parameters
968 * FIX : Set the elements to create the DicomDir in a dictionary file
970 2004-02-03 Benoit Regrain
971 * gdcmDirList : to parse a hard drive directory in recursive (or not)
972 * gdcmDicomDir : add the load of directory
973 * Bug fix and print add-on
975 2004-02-03 Jean-Pierre Roux
976 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
977 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
978 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
979 * FIX gdcmParser.cxx : 'group length' elements are now considered
980 as integers, even for shadow groups, when file is Implicit VR
982 2004-02-02 Jean-Pierre Roux
983 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
985 of the last synonym :-(
986 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
988 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
989 * FIX taking into account the possible 7fe0,0010 multiplicity
990 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
991 to allow removal of references to 7fe0,0010, to deal with
992 ACR-NEMA images, when 0028,0200 is meaningfull
994 2004-01-31 Jean-Pierre Roux
995 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
996 no longer writes 'Un' on disk
997 * FIX SQ elements with actual length are now dealt with corectly
998 * FIX gdcmFile::WriteBase make the difference, for color images, between
999 the length (for Palette expanded images)
1000 and Raw Length (non expanded image + Palette)
1001 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1002 (that broke Write). Replaced by UL.
1003 Aware user will reload the field if he
1004 thinks it's necesssary
1006 2004-01-30 Jean-Pierre Roux
1007 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1008 when 'dirty Acr' is found, to be compliant with the new
1009 IsReadable() methods.
1011 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1012 (no DOUBLE images in kosher DICOM,
1013 but so usefull for people that miss them ;-)
1015 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1016 DICOMDIR related utilities (not checked as Windoze compliant)
1018 2004-01-28 Jean-Pierre Roux
1019 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1021 2004-01-27 Jean-Pierre Roux
1022 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1023 to allow skipping the shadow elements, to save memory space.
1024 The TRUE value for this param has to be used
1025 with a FALSE value for the 'enable_sequence' param.
1026 ('public elements' may be embedded in 'shadow Sequences')
1027 * gdcmHeader methods now deal with 'embedded icones images' in the header
1028 (even when an 'icone image sequence' is announced by the
1029 element (0x0088,0x0200), but there is NO icone at all ...
1031 * gdcmHeader sometimes Image Location value doesn't follow
1032 the supposed processor endianity (see gdcmData/cr172241.dcm).
1035 * gdcmHeader add the method
1036 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1037 to get *all* the Header Entries with the same tag.
1038 GetHeaderEntrySameName is probabely *useless*
1039 (no meaning : Name is *not* an identifier within the Dictionnary)
1041 2004-01-26 Benoit Regrain
1042 * Bug fix in the print of hexadecimal representations. Remove long fields
1043 in the print and add a third level of print to print them
1045 2004-01-23 Benoit Regrain
1046 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1047 * Bug fix on test suite after remove the strip made on not string fields
1048 * Split the IsReadable method between gdcmParser which test that the file
1049 is dicom and gdcmHeader which test that it's an image file
1051 2004-01-22 Benoit Regrain
1052 * DicomDir : clean code, add methods, set variables in protected or private
1053 * gdcmUtil : bug fix for the clean string method
1055 2004-01-19 Benoit Regrain
1056 * Add the use of shadow dictionaries
1057 * bug fix and coding style
1059 2004-01-19 Benoit Regrain
1060 * src/gdcmFile.cxx : bug fix concerning the close of file
1061 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1062 * Add the update of header entries using the shadow library
1064 2004-01-19 Benoit Regrain
1065 * removal of file gdcmHeader2.cxx
1066 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1067 inheriting from gdcmParser. This split is to prepare the integration
1068 of dicom dir parsing
1069 * bug fix under python
1071 2004-01-16 Jean-Pierre Roux
1072 * REM removal of class gdcmHeaderEntrySet
1073 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1074 * ADD add file gdcmHeader2.cxx
1075 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1077 2004-01-15 Benoit Regrain
1078 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1079 entries created while parsing the header. Thus, they will be destroyed
1080 when the gdcmDictSet will be destroyed
1081 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1084 2004-01-15 Benoit Regrain
1085 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1086 made a fatal error because of the memory release at the end of program.
1087 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1088 some memory and vtk seems to have some problems with that.
1089 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1091 2004-01-14 Benoit Regrain
1092 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1093 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1094 * src/*.[h|cxx] : make changes due to class name changes
1095 * gdcmPython/demo/*.py : bug fix due to method names
1097 2004-01-13 Benoit Regrain
1098 * src/*.[h|cxx] : coding style
1099 * vtk/*.[h|cxx] : coding style
1101 2004-01-13 Benoit Regrain
1102 * gdcmPython/testSuite.py : test the readable flag of file for tests
1103 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1104 It's lied to the stl compilation by MSVC (windows, always windows...)
1105 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1107 2004-01-12 Benoit Regrain
1108 * src/*.h : add comments
1109 * src/gdcmDictSet.h : set the method BuildDictPath in public
1110 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1111 directly setted in the source code
1112 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1115 2004-01-09 Benoit Regrain
1116 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1117 * setup.py : use a reference to gdcmVERSION
1119 2004-01-07 Benoit Regrain
1120 * Modification to compile with the distutils.
1123 2003-12-10 Benoit Regrain
1124 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1125 can use a gdcmHeaderHelper to load datas
1126 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1127 made in the source code
1129 2003-12-10 Benoit Regrain
1130 * Update Windows projects and .cvsignore files
1132 2003-11-12 Jean-Pierre Roux
1133 * ENH gdcmHeader constructor has one more parameter (default value : false)
1134 that allows the user to 'go inside' the SeQuences only
1136 gdcmElValSet:Print takes it into account
1138 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1139 * ENH: Update gdcmPython/CMakeLists
1140 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1141 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1143 2003-11-10 Jean-Pierre Roux
1144 * FIX : gdcmHeader::LoadElements is now based
1145 on the ListTag listElem member,
1146 not longer on the TagElValueHT tagHt member
1147 * ENH : PrintPubElVal shows (temporarily) both results,
1148 with the tagHt member and the listElem member.
1149 (it's easier to 'see' the problems when using Printheader)
1151 * FIX : old private member LgrElem is now splitted into
1152 ReadLength : Length actually found on disk (updated only
1153 if bug fixing is necessary), for internal
1155 UsableLength : Updated by FixFoundLength, to fix a bug
1156 or to allow Parser going on.
1157 Will allow to re-write a kosher header when a SeQuence
1158 with a length (not 0000) is found
1159 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1160 because gdcmElValSet::Add does not update ListElem
1163 2003-11-07 Jean-Pierre Roux
1164 * FIX misstyping in Transfert Syntax name table
1165 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1166 when they have an actual length (not 0000 nor FFFFF)
1167 (Nobody should care of it, but DICOMDIR explorers)
1169 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1170 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1172 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1173 * ENH: vtkGdcmReader now supports LUT !
1174 (vtkgdcmViewer for now is not able to use them though)
1176 2003-11-05 Jean-Pierre Roux
1177 * in testSuite.py : new files names for checking the package
1178 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1179 that returns the pixel area size to the *aware* (vtk) user
1180 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1182 2003-11-05 Benoit Regrain
1183 * in testSuite.py : Modify the rules for checking the paths
1184 : Explicit error messages
1185 * in __init__.py : Related modif
1187 2003-11-03 Jean-Pierre Roux
1188 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1189 to be used by aware (vtk) users that want to manage
1190 LUT (and no to turn the PALETTE image into an RGB pixels one)
1191 * GetPixelType now returns 8U for 24 Bits images
1192 (vtkGdcmReader compliant)
1194 2003-10-31 Jean-Pierre Roux
1195 * Removal of *all* gdcmData images and add them again
1196 in order to loose the 'history' of un-anonymised images
1198 2003-10-31 Jean-Pierre Roux
1199 * RMV : removal of useless jBitsInJsample.h
1200 for both 8 and 12 Bits JPEG Lossy Libraries
1202 2003-10-31 Jean-Pierre Roux
1203 * ENH : Add the functions gdcmFile::GetImageDataRaw
1204 gdcmFile::GetImageDataIntoVectorRaw
1205 that act as GetImageData and GetImageDataIntoVector
1206 except the making of an RGB Plane from Gray Plane + LUT
1207 Intended to aware (vtk) users who know how to manage
1210 GetLUTRGBA return a R,G,B,A LUT if any
1211 lgrTotaleRaw gives the 'Raw' length
1212 GetImageDataRaw returns the gray Plane
1213 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1214 (They stay Grey, just like with other Dicom viewers :-(
1216 2003-10-30 Jean-Pierre Roux
1217 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1219 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1220 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1221 being coherents dicom files.
1223 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1224 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1226 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1227 * ENH: Two steps is necessary to please VC++ compiler...
1228 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1229 * ENH: Add include dir to medcon lib
1230 * FIX: only one function is being exported for now !
1231 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1233 2003-10-29 Jean-Pierre Roux
1234 * adding gdcmHeader::GetLUTRGBA
1235 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1236 --> Mathieu, the modif u're waiting for is not yet committed
1237 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1239 2003-10-27 Jean-Pierre Roux
1240 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1241 00191113.dcm DermaColorLossLess.dcm
1242 MxTwinLossLess.dcm RadBWLossLess.dcm
1243 * ENH: For version prior to vtkImageViewer2 -r 1.19
1244 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1246 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1247 * Removal of ido stuff in CMakeLists.txt
1249 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1250 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1251 * FIX: remove a call to ->Modified ... see comments
1252 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1254 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1255 * FIX: Problem with path for libvtkgdcmPython
1256 * ENH: Try adding a search script for python site-package
1257 * RMV: Remove some file from medcon lib that are not necessary
1258 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1259 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1260 * FIX: More pragma disable fro VC++,
1261 I don't think I break something as it is also disable in VTK/ITK.
1262 But it fasten debug compilation time.
1264 2003-10-23 Jean-Pierre Roux
1265 * gdcm now deals with 16 Bits Run Length Encoded images
1266 (they are compressed as 2 planes images,
1267 one for the high Bytes, the other for low Bytes)
1269 2003-10-22 Jean-Pierre Roux
1270 * Now CheckRead takes into account :
1271 - the bugged 'Leonardo' Siemens images
1272 - the XA images, sent thru the burning VPRO station
1273 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1276 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1277 * FIX: When copying a Makefile.am to CMakeLists.txt
1278 one should remove the '\'
1280 2003-10-22 Jean-Pierre Roux
1281 * in gdcmData adding a bugged 'Leonardo' Siemens image
1282 (wrong lengths in header)
1283 OK with gdcm, KO with the other viewers :-)
1284 * add a GE dlx XA image, thru the VEPRO burning station
1287 2003-10-21 Jean-Pierre Roux
1288 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1289 for a brutal checking of vtkgdcmViewer compliance
1291 2003-10-21 Jean-Pierre Roux
1292 * add the files for 'xmedcon' Jpeg Lossless library
1293 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1295 2003-10-21 Jean-Pierre Roux
1296 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1298 2003-10-21 Jean-Pierre Roux
1299 * garbage Siemens 'Leonardo' images dealt with
1300 (the patch is easy to remove)
1301 * cosmetic changes to avoid warnings
1303 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1304 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1305 no need to press 'r' now.
1307 2003-10-20 Jean-Pierre Roux
1308 * upgrade of checkRead.sh checkWrite.sh according
1309 to new Jpeg Lossless decompressor
1310 * add US.3405.1.dcm, a genuine RGB medical file ...
1311 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1312 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1314 2003-10-15 Jean-Pierre Roux
1315 * general anonymisation in gdcmData
1316 * adding the 'color files' from
1317 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1318 * adding some well knowed bugged-header images
1319 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1320 waiting for their inclusion in Python testsuite
1322 2003-10-15 Jean-Pierre Roux
1323 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1324 no longer seg faults when file is not found
1326 2003-10-14 Jean-Pierre Roux
1327 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1330 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1331 * TODO: *.in file to genereate a UseGDCM later
1333 2003-10-14 Jean-Pierre Roux
1334 * Some supposed-to-be Dicom Images have no preamble.
1335 OpenFile takes it into account
1336 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1337 * Missing elements added in dicomV3.dic
1338 (just to be affraid : have a look at
1339 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1340 and do it again next year ;->
1342 2003-10-13 Jean-Pierre Roux
1343 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1344 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1345 But there are NOT. It's fixed !
1347 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1348 * FIX: "jpeglib.h" was not found on VC++
1349 * FIX: vtkgdcm was not being installed
1351 2003-10-10 Jean-Pierre Roux
1352 * ENH : OpenFile closes the file if it *really* doesn't look like
1353 an ACR-NEMA / DICOM one.
1354 * FIX : testWrite no longer writes an empty file if the source file
1355 is not gdcm Readable
1356 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1359 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1360 * FIX: CMake generate now documentation
1361 * ENH: out of source doc build !
1362 * ENH: Generate both user and dev documentation
1363 * ENH: Should work on windows too
1364 * ENH: Only one doxygen config.in file is needed
1365 * FIX: make install should be ok now on ùnix plateform
1366 * FIX: PATH to dictionary was wrong (missing /)
1367 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1369 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1370 * vtkGdcmReader is now able to read rgb dicom file.
1371 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1372 * added a gdcmViewer to vtk test, use mouse to control
1373 window level & window width
1375 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1376 * CMake-ification of gdcm, we have now two build system
1377 * FIX: on cygwin Wsock32 doesn't exist
1378 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1380 2003-10-06 Emanuel Ollart
1381 * FIX : compilation process wad broken.
1382 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1384 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1385 * change gdcmViewer -> vtkgdcmViewer
1386 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1388 2003-10-06 Jean-Pierre Roux
1389 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1390 ( e.g : well known GE images with a wrong elem length,
1391 : Philips MRI Images with a wrong Huffman table)
1392 * still to be done : allow the reading of bugged LEONARDO Siemens images
1394 2003-10-03 Jean-Pierre Roux
1395 * Odd length strings are padded with '\0' (not with spaces,
1396 to remain compliant with already defined strings,
1397 like Transfert Syntax UID and others)
1399 2003-10-03 Jean-Pierre Roux
1400 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1401 to allow displaying RGB images (not only by affim ;-)
1403 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1404 * vtkGdcmReader is now able to read rgb dicom file.
1405 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1407 2003-10-03 Jean-Pierre Roux
1408 * A few nasty patches to allow the reading of a lot of nasty images
1409 ( e.g : well known GE images with a wrong elem length,
1410 : Philips MRI Images with a wrong Huffman table)
1411 * still to be done : allow the reading of bugged LEONARDO Siemens images
1413 2003-10-03 Jean-Pierre Roux
1414 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1416 2003-10-03 Jean-Pierre Roux
1417 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1418 to allow displaying RGB images (not only by affim ;-)
1420 2003-10-03 Jean-Pierre Roux
1421 * gdcmFile::GetImageDataIntoVector now
1422 - deals with MultiFrames MultiFragments Run Length Encoded files
1423 - deals with YcBcR (YBR_FULL) files
1424 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1425 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1427 (no sample found :-(
1429 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1430 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1431 Two reasons: - clear things
1432 - third parties acces gdcm through header files, so won't
1433 suffer anymore VC++ complains
1435 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1436 * add argv[1] in testvtkGdcmReader.cxx
1439 2003-09-24 Jean-Pierre Roux
1440 * The lines are now eigthy characters long.for
1441 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1443 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1444 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1445 char* to std::string. Thus, the use of strdup becomes useless. (see
1446 previous commis of Malaterre)
1447 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1448 before the last Malaterre's commit.
1450 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1451 * This commit should fix the Debug building under VC++, the problem
1452 was mainly a mixture of debug and release lib being loaded at startup.
1453 * I also remove a depency to a specific C function: strdup. Because I had
1454 to force the link to msvcrtd (whereas strdup is in libc).
1456 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1457 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1458 located in the gdcmCommon.h file. All use of reference of tha has been
1459 changed to now use the variable GDCM_UNFOUND.
1461 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1463 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1464 Dicom dictionary. The test suite can now be run again. Note:
1465 I'm note very happy with the " (RET)" changes. I believe this
1466 RETAINED comment should be dropped when parsing the dictionary.
1467 - PACKAGER corrected
1469 - AUTHORS updated and now in alphabetical order
1470 * Makefile.am now exports gdcm.dsw for Windoze users.
1472 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1473 * cygwin complains about missing std:: in subdir Test/
1475 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1476 * remove some methods that are now in gdcmHeaderHelper
1478 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1479 * vtkGdcmReader set spacing and origin correctly
1481 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1482 * Fix a few delete/delete[] mismatch
1484 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1485 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1486 interpretation to data given by gdcmHeader. For instance there are
1487 heuristics to get informations (look at different places).
1488 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1489 sorting DICOM images based on different strategies.
1490 * modified Makefiles accordingly.
1492 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1493 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1494 when building in debug mode
1495 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1496 src/win32/gdcmdll.dsp
1497 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1499 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1500 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1503 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1504 * src/win32/libgdcmjpeg12.dsp was not dos format
1505 * src/win32/libgdcmjpeg12.dsp :
1506 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1507 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1509 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1510 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1512 * src/gdcmFile.cxx : bug fix in affectation type
1513 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1514 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1515 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1516 symbols... future problem ?
1518 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1519 * src/win32/libgdcmijpeg12.dsp was missing
1520 * modified gdcm.dsw accordingly
1522 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1523 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1525 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1526 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1527 commit of JPR (before his hollidays to facilitate our work).
1528 * setup.py : bug fix in code. Modifications made while the last commit
1529 of JPR. The code hasn't been tested before the commit... it's so
1530 useless to make that (for best programmer that is JPR) !!!
1532 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1533 * tagged the current version as Version0_3 (i.e. version 0.3)
1535 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1536 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1537 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1538 * *.dsp : modifications to use new libgdcmijpeg8 library
1539 * setup.py : bug fix on VTKPATH variable
1540 * PACKAGER : adding all concerning windows
1542 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1543 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1545 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1546 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1547 test suite reported error.
1548 * PACKAGER file added (describes what a packager must do when
1549 packaging a new release).
1550 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1551 * configure.in: upgraded version number to 0.3.0
1552 * fixing build of rpm (through rpm -ta):
1553 - Doc/Makefile.am exports proper doxygen files
1554 - src/jpeg/libijg8/Makefile.am exports the include files.
1556 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1557 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1558 * src/gdcmHeader.h : formatting code
1560 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1561 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1562 We were obtaining error message from vtk. Now, creation of file list
1563 is made in an internal list to prevent this problem.
1564 Bug fix when output is empty.
1565 Bug fix in update of progress value. Previous commit for this was a bad
1567 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1569 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1570 * src/gdcmHeader.h : added method to get the file name
1571 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1572 files. Added method to remove all files on the input
1573 Added FIXME comment concerning the bad parsing of header made by
1574 ExecuteInformation method (in ExecuteData method)
1576 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1577 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1578 when using make instal.
1579 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1580 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1582 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1583 * setup.py : adding include dir of jpeg lib to compile all sources
1584 * */Win32/*.dsp : JPR fix for windows compilation
1586 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1587 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1589 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1590 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1592 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1593 * setup.py is again effective on un*x (takes into account the
1594 addon of the jpeg library)
1595 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1596 * Doc/Doxy* updated (includes above enhancements)
1597 * INSTALL now points to web documentation
1599 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1600 * src/gdcmHeader.h doesn't make unnecessary reference to
1602 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1604 * src/gdcm*.[cxx|h] :
1605 - to allow compilation with gcc 3.x
1606 -- clean up of STL usage (added explicit usage of std::)
1607 -- small fixes on exceptions.
1608 Note: linking not tested !
1609 - clean of doxygen comments to avoid warnings at documentation
1611 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1612 dependent convertion).
1614 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1615 * Clean up of previous JPR garbage commit (not even commented in the
1617 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1618 - moved all jpeg related files from src to src/jpeg/libijg8, with
1619 addition/modification of Makefile.am and configure.in.
1620 - the testSuite is still brain damage (not guilty).
1622 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1623 * WrapVTK.py : modifications to get correctly vtk source files to
1625 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1626 (FileName -> Filename)
1628 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1629 * vtk/vtkGdcmReader.[cxx/h]:
1630 - UpdateProgress method should now be effective
1631 - removed the limitation on having only images loaded (as opposed
1633 - when building a stack of images/volume, a lesser number of
1634 gdcmHeader and gdcmFile instances should be used (hopefully
1635 accelerating things).
1636 - when building a stack of images/volumes, files which are not
1637 loadable (wrong path-filename, wrong permissions on existing file,
1638 or file not parsable by gdcm) are replaced with a black image
1639 in the stack (for the caller to notice the problem).
1641 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1642 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1644 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1645 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1646 between standard library (std) and vtk library (problems are found
1647 under Windows... thanks Windows !)
1649 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1650 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1652 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1654 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1655 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1657 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1658 * When compiling with distutils (see setup.py) the C++ compiler is
1659 called with different flags than the default ones (with automake).
1660 In order to fix all those warning, I compiled gdcm with the command
1661 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1662 and went for warning fixes:
1663 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1664 up from unused variables.
1665 - vtk/vtkGdcmReader.cxx: potential bug fix.
1666 * src/gdcmHeader.h: Doxygen warning cleanup
1668 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1669 * gdcmPython/gdcm.i:
1670 - typemaps correction to take into account the systematic replacement
1671 of "using namespace std" with std:: prefix e.g. std::list,
1672 std::string... (cf changes of 2003-05-21).
1673 - gdcmGlob global variable of type gdcmGlobal (defined in
1674 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1675 exported to Python a as cvar.
1676 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1677 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1678 gdcmDictSet.GetPubDictTagNames() and
1679 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1680 C++ static methods).
1681 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1682 with the above changes.
1684 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1685 * setup.py, manifest.in : bug fix under linux
1687 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1688 * Modification of setup.py to compile vtk part too. Then, we have 2
1689 wrappers which must work with same distutils. For that, we have a
1690 generic distutils in distusiltsWrapping.py ; with :
1691 - build_extWrap class to wrap generically all extensions,
1692 - ExtensionWrap base class for all wrapping extension that contains
1694 - Wrapper interface which wrap sources
1695 + In WrapSwig.py we have extension and wrapper for Swig
1696 + In WrapVTK.py we have extension and wrapper for VTK
1697 * MANIFEST.in : modifications to consider vtk directory and new python
1698 files for compilation
1700 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1701 * Added python wrappers of vtkGdcmReader vtk class (see the
1702 source in vtk/vtkGdcmReader.cxx) :
1703 - vtk/Makefile.am now builds a library
1704 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1705 python library (as opposed to _gdcm.so wich are the python
1706 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1707 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1709 - configure.in has an additional flag --enable-vtk that needs
1710 to be set to enable compilation of vtk related code, that is:
1711 + vtk/vtkGdcmReader.so and
1712 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1713 + gdcmPython/vtkgdcmPython.so (see above)
1714 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1715 be read when compressed or when HighBit + 1 != BitsStored),
1716 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1717 the usage of the python wrapper of vtkGdcmReader vtk class.
1718 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1719 * src/*.[h] all occurences of stl classes are now prefixed with
1720 std::, and all occurences of "using namespace std;" where removed.
1721 This is to avoid pollution of global namespace in included files.
1722 Apparently vtk does not avoid this pitfall: when using both
1723 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1724 collision of various stl members (principally cout...).
1725 * gdcmPython/testSuite.py now cleanly removes temprory generated
1727 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1728 comply with above changes)
1730 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1731 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1732 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1733 vtk data structure (an image Flip was required).
1734 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1735 * cosmetic changes in documentation.
1737 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1738 * src/gdcmHeader.cxx: the constructor no longer exits when an
1739 unexisting file is given as argument.
1740 * The subdirectory Data (containing all the images used for the
1741 test suite) is not part of this repository anymore. A new module
1742 containing those images is now available at
1743 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1744 with the name gdcmData.
1745 All the python scripts (including the package initialisation file
1746 gdcmPython/__init__.py) were adapated to take this change into
1747 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1749 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1750 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1751 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1752 demo of the usage of this class.
1753 Compilation of this vtk part is only done when using the --enable-vtk
1754 at configure (or autogen.sh) stage.
1756 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1757 * More memory link related corrections and documentation fixes.
1759 - maximum info is obtained with a command of the form:
1760 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1761 --show-reachable=yes PrintHeader
1762 - the remaining reachable blocks seem to come from the STL
1763 allocation scheme through the usage of map and list. It looks
1764 like this memory cannot be freed but it is not a memory leak
1765 (in fact further invocation to the STL would recollect the
1766 unused memory allthough it cannot explicitely be freed).
1767 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1768 of displaying an image parsed with gdcm and displayed with VTK.
1769 Note: some images don't seem to work e.g.
1770 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1771 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1772 Allthough this weakens the semantics, it is a ditch attempt to
1773 make gdcm more thread friendly.
1775 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1776 * Memory link hunt (by using valgrind through the command
1777 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1778 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1779 gdcmHeader::_dicom_vr.
1780 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1781 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1783 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1785 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1786 * src/Makefile.am now exports all the necessary include files at
1790 * UpdateGroupLength replaced by new one
1793 * UpdateGroupLength re-written using H-Table
1794 (named UpdateGroupLengthNew untill checks are over)
1796 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1797 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1798 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1800 - gdcmHeader::GetPubElValSet removed.
1801 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1802 UpdateGroupLength, WriteElements, Write.
1803 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1804 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1805 carried the same semantics.
1806 - src/gdcmHeaderIdo.cxx changed accordingly.
1807 - gdcmFile::WriteBase now regroups all the codes from previous
1808 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1809 - enum FileType moved to gdcmCommon.h
1810 * src/gdcmHeader.cxx AddDefault trashed
1811 * gdcmGetXSize added
1812 * getimageDataSize now calls gdcmGetXSize
1813 * Test/*.cxx changed to agree with above changes
1815 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1816 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1817 (to avoid double call by end user).
1818 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1819 by end user, since gdcmHeader::gdcmHeader now handles it.
1821 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1822 * gdcm/Doc many doxygen changes:
1823 - Doxyfile now has two different versions, DoxyfileUsers that generates
1824 the html.users end users oriented documentation and
1825 DoxyfileDeveloppers that generates the html.developper developper
1826 oriented documentation.
1827 - README changed accordingly
1828 - requirement.txt removed (old design info moved to TODO).
1829 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1830 DoxyMainPage.txt, DoxyPython.txt provide more information.
1831 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1832 be updated by simply regenerating the docs with doxygen and copying
1833 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1834 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1835 all the tests in the form "if (<map>.count() >1)" were removed.
1836 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1837 ill-formed documentation sections.
1838 * src/gdcmHeader.cxx: ditto
1840 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1841 * setup.py fixed for un*x (needed macro for stdint.h)
1842 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1843 un*ces with sh-utils test utility.
1844 * gdcmPython/demo/test.py renamed to PrintHeader.py
1845 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1846 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1847 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1848 * src/gdcm*.cxx JPR's bad inclusion fixed.
1850 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1851 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1852 * gdcmPython/demo/test.py changed accordingly.
1854 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1855 * gdcmPython/Makefile.am fixed linking against libstdc++
1856 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1857 * Swig subdir (historical tests of swig version 1.3.17++) removed
1858 * Test/testChangeEntete.cxx some lines commented out in order to make
1860 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1861 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1863 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1864 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1865 hence the user doesn't need this explicit call.
1866 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1867 i.e. LoadElements() call removed.
1868 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1869 - src/Makefile.am declares the proper flag for g++.
1870 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1871 for adding user defined new tags.
1872 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1873 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1874 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1876 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1877 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1878 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1879 src/Makefile.am : the project should properly compile and install
1880 with the autotools, included the python wrappers part.
1881 * gdcm.spec.in : added a spec file for RPM packaging.
1883 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1884 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1886 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1887 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1888 to exported to the environement (see gdcmPython/testSuite.py
1890 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1891 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1892 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1893 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1894 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1896 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1897 * gdcmPython/__init__.py doesn't crash anymore when running in
1898 in InstallMode or PreInstallMode but with an environement given
1899 value of GDCM_DICT_PATH.
1900 * src/gdcmDictSet.[cxx/h] coding style.
1902 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1903 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1904 * src/gdcm.h general comments moved to TODO, and README
1905 * src/gdcm.h should now be seen as a user commodity (including it
1906 should suffice to fully use gdcm). It is nowhere including within
1907 any of the kernel files src/*.cxx and src/*.h.
1909 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1910 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1911 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1913 * src/gdcm*.cxx only include their corresponding include file
1914 (as opposed to gdcm.h)
1915 * gdcmPython/gdcm.i changed accordingly
1916 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1917 the autogen.sh generated "make snapshot" command to work.
1918 * autogen.sh removed history related references to crea package.
1920 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1921 * distutilsSwigCPlusPlus.py work around some swig portability
1924 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1925 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1926 was done in a last ditch attempt to get setup.py _really_
1927 operationnal. The python/gdcmPython layaout add the advantage
1928 of hidding away the python related distutils specific files
1929 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1930 Alas, the src directory was out of scope (i.e. it's relative
1931 position to setup.py was ../src) which made things impossible to
1932 handle (see previous version of python/setup.py). Crossing fingers...
1934 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1935 * python/setup.py now works on Un*x. (harder than I thougth)
1936 * python/distutilsSwigCPlusPlus.py can now have include files
1937 among the list of sources.
1939 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1940 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1941 * modifications in MSVC projects
1943 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1944 * As stated by the first lines of Test/ExceptionAndPython/README, it
1945 looks like we can move back to original usage of exception within
1946 src/gdcm* and hence remove the errno stuff that was introduced
1947 as a quick and dirty fixture of this problem (added to the TODO).
1948 * Doc/Doxyfile configuration file for Doxygen and corresponding
1949 README file for usage added.
1950 * Test/testWrite.cxx added. This new test comes from a split of
1951 test.cxx that is now reverted to its original purpous i.e.
1952 testing the proper parsing of a Dicom related file.
1953 testWrite.cxx concentrates on testing the IO part of gdcm.
1954 * Test/bug1.cxx (containing a bug on WIn32) added.
1955 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1956 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1957 whose purpose is to publish the content of the TagNames of the
1958 Dicom public dictionnary were not accessible without an
1959 instance of class gdcmHeader.
1960 - those methods are now static methods of gdcmDictSet and hence
1961 require no instances at all to be invocated.
1962 - within gdcmDictSet this change required to change some method
1963 to class methods (i.e. are now static) among which SetDictPath
1964 (renamed to BuildDictPath) and LoadDefaultPubDict.
1965 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1966 the above changes by calling the new method classes of gdcmDictSet.
1967 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1968 the above to be effective.
1969 * python/gdcmPython: in order to wrap properly the above changes
1970 for Python, swig version now needs to be > 1.3.17.
1971 * python/gdcmPython/Makefile fixed to adapt itself to new
1972 configure/make shema introduced by Johan Montagnat (thanks for the
1973 contribution). Alas this Makefile cannot be turned into a proper
1974 Makefile.am without some heavy changes in the configure.in
1975 (for python dectection).
1976 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1977 now avoids publishing the empty entries.
1979 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1980 * python/setup.py : bug fix concerning install under windows
1981 ExtraPath reused :-P
1982 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1984 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1985 * Dicts/dicomV3.dic : remove double spaces !!!
1986 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1987 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1990 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1991 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1992 method. Doxygenation.
1993 * src/gdcm.h clean up of JPR spurious comments.
1995 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1996 * python/distutilsSwigCPlusPlus.py now properly collects the
1997 shadow classes generated by "swig -c++" (gdcm.py in our case)
1998 when using "python setup.py install".
1999 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2000 reexports the working classes.
2001 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2002 by the classical C errno scheme. This is to prevent an obscure
2003 behavior of the python wrappers when importing wxPython.wx prior
2004 to gdcmPython (which ended up in an abort call). An illustration
2005 of this oddity can be found in the Test/ExceptionAndPython
2006 subdir (see the README file). This problem probably due to
2007 an combination of g++ and dynamic loading.
2008 * added Test/ExceptionAndPython (see above)
2010 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2011 * Changed the layout of the python part to avoid bloating main
2012 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2013 i.e. the distutils arsenal. All the python related stuff is
2014 again in a python subdir, but the package itself is now in
2016 * setup.py was cleaned up:
2017 - pythonIncludePath removed
2018 - python setup.py bdist target is now functional.
2019 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2020 collision with other packages). gdcmPython/demo/*.py changed
2023 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2024 * python subdir moved to gdcmPython (preparation of distutils packaging).
2025 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2026 distutils installer is operational.
2027 * - gdcmPython/__init__.py now properly loads the swig generated
2028 shadow classes (from gdcm.py).
2029 - gdcmPython/demo/*.py changed to import the package gdcmPython
2030 instead of gdcmPython/demo/load.py.
2031 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2033 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2034 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2035 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2036 entries within the associated public Dicom dictionary resp. the same
2037 information but sorted by the fourth field (PAT, IMG, DIR) of the
2039 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2040 are now in the "???" group.
2041 - python/gdcm.i changed accordingly,
2042 - python/demo/printGroupedPublicDict.py added, that gives an example
2043 of the above new functionalities in Python.
2045 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2046 * src/gdcm.h, gdcmHeader.cxx:
2047 - historic references to glib's g_malloc and g_free (#defined)
2048 were definitively removed.
2049 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2050 * src/gdcmElValSet.cxx:
2051 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2052 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2053 - GetElValue(string) renamed to GetElValueByName.
2054 - Added GetElementByName(string).
2055 * src/gdcmHeader.cxx: added
2056 - GetPubElValRepByNumber(guint16, guint16)
2057 - GetPubElValRepByName(string)
2058 - GetShaElValRepByNumber(guint16, guint16)
2059 - GetShaElValRepByName(string)
2060 - GetShaElValByNumber(guint16, guint16)
2061 - GetShaElValRepByName(string)
2062 - GetElValRepByNumber(guint16, guint16)
2063 - GetElValRepByName(string)
2064 - GetElValByNumber(guint16, guint16)
2065 - GetElValRepByName(string)
2066 * Doc/requirements.txt added.
2068 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2069 * Test/Makefile building now depends on the one of libgdcm.so
2070 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2071 pixel data) aware which enables finding the address (offset) of
2072 the pixel data of JPEG encoded DICOM files. This leaves only a single
2073 file in the testSuite whose pixel data address (offset) is unknown.
2074 * python/testSuite.py changed accordingly.
2076 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2077 * VC++ has some strong limitations when working with the STL, as stated
2078 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2079 "Also note that some STL containers (map, set, queue, list, deque)
2080 cannot be exported. [...]
2081 Some STL classes contain nested classes. These classes can not
2083 This is caused by a designed limitation that once a template
2084 class is instantiated, it can not be re-instantiated and
2086 Since our usage of map<> is ubiquitous in gdcm, this "designed
2087 limitation" of VC++ is a pitfall.
2088 Hence the Python wrappers of gdcm cannot be incrementally linked
2089 against the c++ dynamic library. The dirty but only workaround is
2090 to forget about incremental link of dynamic libraries and to generate
2091 the Python wrappers library with the inclusions of the underlying C++
2093 The following modifications concern this matter on Win32/VC++:
2094 - wrapping python correct with standalone wrapped dll (don't use separate
2095 dll under windows !!!!)
2096 - python21_d debug mode enabled (ask Frog how to use it :-)
2097 - NO problem with having an STL member of class for example string in C++
2098 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2099 - Python test of dcmlib in Python is ok under windows on a large set
2101 * removed glib references
2102 * typedef's inserted in gdcm.i for correct swig type management
2104 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2105 * python/demo/*.py load.py extracted from test.py. Added explore.py
2106 that only displays required tags and testAll.py that parses all
2107 the files of the testsuite without using unittest.
2108 * python/testSuite.py other additional test on new files added.
2109 * Data/* new test files added accordingly to the testSuite.
2110 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2111 the vr in the file differs from the one of the dictionary.
2113 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2114 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2115 values, but limits itself to values which are below a user specified
2116 size (by default 1024 bytes).
2117 * python/gdcm.i : elements not loaded (because their size is above the
2118 user specified treshold) are exported with their TagKey as key of the
2119 python dictionary. This enables the testsuite to make some checks
2120 on the unloaded elements (since we have their offset and size).
2121 * python/testSuite.py
2122 - now tests for the existence and proper value of the pixel data
2123 - two new examples added.
2124 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2126 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2127 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2128 aware. See the strategy comments in gdcmHeader::FindeLength().
2129 * Test/test.cxx now accepts a filename as first argument.
2130 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2131 * python/testSuite.py changed to integrate test on above files.
2133 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2134 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2135 the vr was also RET.
2136 * python/testSuite.py more tests added.
2138 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2139 * python/testSuite.py unittest test suite added (uses Data)
2140 * Data/* dcm and acr files for the test suite.
2141 * glib dependance removed from un*x version. We now use ISO C99
2142 7.18 Integer types (see stdint.h)
2143 - python/Makefile, src/Makefile src/gdcm.h
2144 * src/ when an explicit vr (like dicom files) suddenly poped an
2145 implicit element we use to mark the underlying DictEntry of the
2146 concerned ElValue with "Implicit". This strategy was damageable
2147 too the public or provite dictionaries, since some of their vr
2148 would be changed. Since Header::FindLength heavily relies on the
2149 detection by Header::FindVR of falsely explicit elements, I
2150 added an extra ImplicitVr member to ElValue (boolean).
2151 The rest of the changes we the necessary adaptations.
2153 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2154 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2156 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2158 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2159 * Adaptation for porting to VC++:
2161 o forced to use std namespace (for string to be known)
2162 o all class use __declspec export style on WIN32
2163 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2164 (in stdlib.h on Win32 but in std:: for gcc)
2165 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2166 variable GDCM_DICT_PATH.
2167 * src/gdcmHeader.cxx verbose comments made discrete.
2169 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2170 * python/gdcm.i: added a typemap that converts a C++ hashing table
2171 to native Python dictionary.
2172 * python/demo/test.py:
2173 - now uses the native dictionary for exploration of gdcmHeader.
2174 - takes an optional filename argument (the file to parse).
2175 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2176 PubElVals hashing table.
2177 * Dicts/dicomV3.dic removed error prone trailing spaces.
2179 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2180 * Python wrapping process moved away from src/Makefile to
2181 newly created python/Makefile (as well as gdcm.i)
2182 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2183 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2184 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2185 from the environement variable GDCM_DICT_PATH (when existing).
2186 * src/gdcmDict::GetTag bug fix.
2188 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2189 * Straightforward temporary fixes for swig to build the python wrappers.
2190 src/Makefile now has a python working entry [by working we mean
2191 that we can import de shadow classes without errors].
2193 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2194 * hashtest.cxx removed (since allready in Test)
2195 * src/gdcmlib.h renamed to src/gdcm.h
2196 * src/dcm.i renamed to src/gdcm.i
2197 * src/Makefile prepared for python wrapping
2199 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2200 * src/gdcmHeader.cxx :
2201 - Parsing of header is now separated from loading of element values
2202 (see gdcmHeader::LoadElements).
2203 - general clean up of hopefully all file access (creation of
2204 ReadInt16 and ReadInt32)
2206 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2207 * src/gdcmHeader.cxx :
2208 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2210 - SetLgrElem renamed to SetLength
2211 - GetLgrElem renamed to GetLength
2212 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2213 * src/gdcmElValSet.cxx fixed both GetElValue methods
2214 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2215 due to IdoDude was cleaned out.
2217 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2218 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2219 concentrates on finding the value representation (when it exists).
2220 RecupLgr now only finds the element value length, and it avoids
2221 returning the unecessary skL (skipped length).
2222 Also, offsetCourant was simply removed (with taille_fich) since
2223 it was redundant with the File position internals (by using
2224 ftell and fseek). This also made skL (see above in RecupLgr) usage
2226 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2227 on the libido specificities which are handled through class
2229 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2232 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2233 * Truckload of changes. Parsing of header is barely functional
2234 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2236 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2237 * src/gdcmHeader.cxx many addons of low level methods
2239 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2240 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2241 and _IdDcmSWAP_LONG.
2243 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2244 * This corresponds to all the changes decided at the meeting of
2245 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob