1 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
3 the python part recompiles
5 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
7 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
8 X session is killed (for my computer... it seems to not be identic on
11 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
12 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
13 avoid problems (otherwise, the difference test between the visible image
14 and the reference is incorrect. If the reference is greater than the
15 screen resolution, it's produce errors).
16 Can be used for only one image. Can be used with a visible flag.
17 * vtk/vtkGdcmReader.cxx : remove commented codes.
18 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
19 under windows at compilation
20 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
22 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
24 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
25 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
26 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
27 tests on the image size X, Y, Z
29 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
30 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
31 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
32 between the class name and the file name
34 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
35 * src/ : fix compilation warnings for the Write method (2 different
36 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
37 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
38 variable... create a static method in gdcm::Document to access to
39 this variable content.
41 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
42 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
43 file, to be accessed by other files (like gdcmFile). Remove commented
44 code. Move the change of the header to the gdcmFile, using the
46 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
47 To be sure of that (and simplify calls), the Write of the header now
48 gets a file name and not a file pointer (std::ifstream).
49 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
50 DocEntryArchive. Remove all open of the written file
52 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
53 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
55 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
57 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
59 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
60 some corresponding methods. Write correctly the file and check before
62 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
63 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
64 is now on RGB datas (as before my last commit
65 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
67 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
68 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
69 Add a print information of the type of the entry
70 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
71 It was in the gdcmFile, and all write have been regrouped
72 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
73 Write correctly all dicom files (in decompressed mode only at this time)
74 * Test/ : test on files are now made using Raw datas and not color datas if
76 * Example/PrintFile.cxx : add more printings
78 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
79 * Amelioration of code, remove some code copy. For the loading of
80 BinEntry (in gdcmDocument), add the test to verify if the file is already
83 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
84 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
85 remove a DocEntry in the header (push an empty DocEntry)
86 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
87 lines. Bug fix in the initialization of the PixelConvert and the
89 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
90 use in TestCopyDicom (now this test can run under windows... but fails)
91 * Test/TestCopyDicom.cxx : amelioration of the test :
92 - test the pixels written
93 - add test points to quickly find where is the error
94 - can set a file name input and output in arguments
95 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
96 amelioration of the test output
98 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
99 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
100 all replaced DocEntry's
101 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
102 Now, each needed DocEntry to modify is duplicated, modified and inserted
103 to the header using DocEntryArchive. Thus, after save, we can restore the
104 header initial state.
106 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
107 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
109 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
110 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
111 correct to copy it. The DictEntry is specified at the DocEntry creation,
112 then, it musn't change in the time.
113 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
114 header correctly. At this time, the change is only made for the first
115 level of the Document. In the future, it might consider sequences.
116 The change is made by replacing a DocEntry by an other that is created
117 outside the class. The old value is kept. When we restore the header
118 status, the added DocEntry is deleted and replaced by the old value.
119 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
120 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
121 set the write type to explicit VR, implicit VR or ACR. Add methods to set
122 the write mode to native, decompressed or RGB (but not used at this time)
124 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
125 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
126 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
128 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
129 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
130 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
132 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
133 set because already copied when copying the BinEntry's of the header
134 * Test/TestAllReadCompareDicom.cxx : remove warnings
136 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
137 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
138 Two problems appear when doing it :
139 - with the gdcmFile : when the GetImageData method is called, the pixels
140 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
141 datas (pixels). And each structure destruct the datas when it's
142 destructed. So we have two destructions for the same datas. To solve it,
143 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
144 datas or not. If it doesn't own datas, then they will not destroyed by
146 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
147 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
148 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
149 create a double destruction of the same DocEntry's. So, to solve it,
150 the TagHT is simply cleared and the DicomDir* elements are destroyed.
151 * TODO : add an entry concerning memory leaks in the DicomDir
153 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
154 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
155 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
158 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
159 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
160 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
161 after it have been deleted
163 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
164 * FIX: src/* fix the doxygen warnings.
165 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
166 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
167 was erroneously defined with a size of 15 instead of 16. [many thanks
168 to Jean Michel Rouet for pointing out this bug].
170 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
171 1. Finish merging JMR patch for writting DICOM from scratch
172 2. Fix -hopefully- bug with MONOCHROME and space vs null character
173 3. Use const ref when possible
174 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
175 5. A few more comments
176 6. CreateUniqueUID can now be called without parameter"
178 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
179 * ENH: Slightly bigger patch:
180 1. Getting toward full integration of JMR patch for writting dicom from scratch
181 2. Update Test to test part of this patch: CreateUniqueUID
182 3. File was not close properly in gdcmDict
183 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
184 5. Use of const ref instead of copy (speed issue)
185 6. Remove temporary (duplicate) string in TranslateToKey
186 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
187 8. Do not repeat virtual in subclasses
188 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
190 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
191 * Apply first patch toward better string comparison when dealing with broken
192 DICOM files. Essentially the string could be padded with a space instead
193 of a null character as defined by standard
195 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
196 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
197 because never used... and in the same time, that's remove some memory leaks
199 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
200 * src/gdcmFile.cxx : now delete the PixelConvert instance.
201 * In examples and tests : change the type of image data variables from void*
202 to uint8_t*. Remmove all delete on image data variables
204 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
205 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
206 Verify the file pointer value before open the file, and if it's not null,
207 a verbose message is generated.
208 Close correctly the file when the file isn't considered dicom-like. The
209 correctly close is a call to CloseFile.
210 When closing the file pointer, test if its not null to close the file.
211 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
212 file. For an uncompressed image, the copied datas correspond in the least
213 case to the image size (calculated) or the image size specified in the
214 header. A verbose is generated if these two size mismatch
216 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
217 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
218 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
219 break under windows (with msvc6 compilation).
221 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
222 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
223 compiling with MSVC6)
225 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
226 * Bugs fix for the Windows build with VC6
227 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
228 needed (only for projects required VTK). If the VTK is included in all
229 projects, there is conflicts with the jpeg lib of vtk when compiling the
230 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
231 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
232 when compiling the gdcm_wrap.cxx file (created by the compilation of the
234 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
235 (like it's already made for the cout use). Otherwise, conflict with the
238 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
239 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
241 - comments on the DicomDir::Method related usage added.
242 - now that we use the namespace gdcm, a lot of internal classes do
243 NOT need to be wrapped anymore.
244 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
245 DicomDir::Method) new example added.
247 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
248 * Improve string manipulation. I now inforce the notion of 'DicomString'
249 A DicomString can contain as many \0 as they want
250 and it is *always* of even length.
251 We only support odd length for very rare case.
252 And in the near future this should be removed.
254 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
255 * /binary_write/ gdcm source. Now even on big endian we are writting
256 little endian. This should -heopfully- fix some tests
258 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
259 * Now the dictionary is compiled into gdcm lib. This is a default
260 behavior, thus any dic file specified is picked before failback to
261 the one comiled into lib
263 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
264 * Change internals for gdcmDict. Don't use any 'new' any more.
265 This should definitely solve any leak problem, and we should be
266 as fast as before, as long as don't modify too much the dictionary.
268 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
269 * STYLE: ivars should start with a capital letter.
270 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
271 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
273 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
274 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
275 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
276 new 2004 dictionaries added (thanks to JPR).
277 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
278 * CLEANUP_ROUND (15) for gdcmPixelConvert
279 - RLEFrame::NumberFragments is now of type unsigned int
280 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
281 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
284 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
285 * Initial work in gathering all transfer syntax accessors. clearly
286 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
287 ivars, but only one transfersyntax (class) ivar with equivalent method on
290 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
291 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
292 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
293 discussed (plus I didn't like having a 2000 lines patch not commited)
295 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
296 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
297 * CLEANUP_ROUND (14) for gdcmPixelConvert
298 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
299 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
300 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
302 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
303 anymore and hence avoids storing a copy of PixelConvert::Decompressed
304 into File::Pixel_Data.
306 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
307 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
308 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
309 * CLEANUP_ROUND (13) for gdcmPixelConvert
310 Substituted File::ParsePixelData() with PixelConvert::Print() new
312 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
313 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
314 method to those classes.
315 - src/gdcmFile.[cxx|h]:
316 -- Added a ::Print() method.
317 -- PixelConverter is now a reference instead of a member.
318 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
319 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
321 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
322 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
323 collaboration diagram and inheritance diagram should be generated with
325 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
326 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
327 pointlessly wrapped (see
328 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
329 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
330 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
331 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
332 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
333 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
334 -- File::Initialise: PixelConverter setup moved away to
335 PixelConverter::GrabInformationsFromHeader()
336 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
337 interpretation moved away to PixelConverter::BuildRGBImage()
339 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
340 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
341 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
343 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
344 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
345 displayed on Win32 when a brutal abort() occurs (because of uncatched
346 exception). See TODO new entry of this commit for more on this.
347 * TODO added new entry.
348 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
349 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
350 - HandleColor is no longer called from gdcmFile.cxx
351 - gdcmPixelConvert.cxx clean up on method arguments and internal
352 variable names for semantical coherence.
354 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
355 * Finished lossless transition, not only do we now read all lossless jpeg
356 images, without the need of the Cornwell lib, but we do read them properly now
357 * To reduce code (well to avoid code duplication), I defined a common place
358 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
359 redefine symbols. This is not prefect but this the best solution I found for a
360 compilation time jpeg option.
362 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
363 * Update jpeg ijg lib to support lossless jpeg implementation
364 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
366 * Also added a special copyright for dcmtk since we use their bugfixes.
369 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
370 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
371 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
372 matters, as stated in warning note at begining of %include section).
373 * src/gdcmDicomDir*.[cxx|h]: coding style
374 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
375 * src/gdcmJpeg8.cxx: doxygen fix.
376 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
377 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
378 from File:: to PixelConvert::.
380 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
381 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
382 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
383 - more code moved away from File:: to PixelConvert::
384 - fat setup of PixelConverter set in place in File::Initialise.
386 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
387 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
388 namespace at the file system level. So now you should convert your examples
390 gdcmHeader -> gdcm::Header
391 It would be nice if people keep in mind to no open the namespace, since it
392 allows compilation on broken plateform which were defining common symbol in
393 the standart namespace (like LP, Unknown ...)
395 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
396 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
397 The JPEG fragments are now parsed at the same stage than the RLE
398 information. All code related to JPEG is now in gdcmPixelConvert:
399 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
400 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
401 export a gdcmFile:: method. Those are simply global functions
402 (for the time being this is better than having them attach to
403 either gdcmFile:: or gdcmPixelConvert::).
404 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
405 and stores the result in a gdcmJPEGFragmentsInfo.
406 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
407 code (among other stuff) moved away from gdcmFile:; to
410 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
411 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
412 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
413 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
414 clean up of RLE related code.
415 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
416 - src/gdcmRLE.cxx removed
417 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
418 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
419 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
420 * CLEANUP_ROUND (9) for gdcmPixelConvert
421 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
422 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
423 away from gdcmFile:: to gdcmPixelConvert::.
425 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
426 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
427 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
428 This is because Parse7Fe0 used to parse the pixels to compute the
429 length. This task was passed over to FindDocEntryLengthOB() a long
430 time ago, EXCEPT I had forgotten the OW case...
431 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
432 we just recylce the code for parsing RLE fragments and computing
434 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
435 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
436 with the retired Parse7Fe0().
437 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
438 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
440 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
441 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
442 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
443 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
444 - src/CMakeLists.txt: alphabetic order reodering + new entries.
445 * CLEANUP_ROUND (4) for gdcmPixelConvert
446 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
447 to return an unused length.
449 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
450 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
451 this should be cleanner from the plane view. The iostream are erally a pain
452 to use to do simple stuff.
454 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
455 * Redo the compilation of the ijg jpeg library. Now only one source is
456 necesseray. No need to rename file by hand what so ever. CMake handle the
457 copying of the file within different directory, configure header file to
458 modify some symbol. The only addition made to ijg wasd a mangle table so
459 that symbol are different wether we are within 8bits or 12bits.
461 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
462 * Added documentation of vtkgdcmReader on Website:
463 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
464 with it's binary name).
465 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
466 the Website to be more complete.
467 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
468 doxygenated documentation.
469 - Doc/DoxyVtkGdcmReaderExamples.txt added
470 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
471 DoxyVtkGdmReaderExamples.html )
472 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
473 * CLEANUP_ROUND (3) for gdcmPixelConvert
474 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
476 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
477 * CLEANUP_ROUND (2) for gdcmPixelConvert
478 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
480 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
481 * CLEANUP_ROUND for gdcmPixelConvert:
482 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
483 - src/gdcmPixelStuff[h|cxx] removed
484 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
485 - src/CMakeLists.txt changed accordingly
487 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
488 gdcmVersion.py moved to newly created ATTIC related
489 gdcmPython/SetupOldies/ directory.
490 * Autotools clean up:
491 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
492 - autogen.sh configure.in acinclude.m4 python.m4 removed
494 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
495 * src/*.cxx *.h Reference to License.htm fixed to License.html.
496 * Doc/CMakeLists.txt, doxygen.config.in: fix.
497 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
499 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
500 * TODO updated with Mathieu suggestions. I proposed a template for
501 describing TODO entries and used it for new entries.
502 * Added Doc/Website/CodingStyle.html, Developpers.html,
503 DeveloppersPython.html, GdcmDataCvs.html and
504 DownloadVersion0_1.html, DownloadVersion0_3.html.
505 * Some Doc/*.txt Doxygen files (which do not really concern the
506 documentation itself, but the website) moved to html and
507 placed in directory Doc/Website:
508 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
509 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
510 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
511 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
512 * CMakeLists.txt changed accordingly.
513 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
514 DeveloppersPython.html
515 * INSTALL nows refers to Doc/Website/Installation.html
517 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
518 * Added Doc/Website directory, that contains a first raw version
521 2004-09-23 Jean-Pierre Roux
522 * FIX In order not to be poluted any longer by casting problems,
523 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
524 we can now delete[] it safely
525 * VoidArea is now called BinArea (less confusing name),
526 and all the methods called ...VoidArea... are now ... BinArea...
527 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
529 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
530 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
531 clear) TagHT, which is an inherited member of gdcmElementSet. It is
532 up to the destructor of gdcmElementSet to clean up TagHt and it's
535 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
536 * Test/CMakeLists.txt: update to follow gdcmData renamings.
537 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
539 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
540 * ENH: added some utility method that builds a flat dictionnary
541 holding all the Dicom entries contained in the recursive structure
542 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
544 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
545 BuildFlatHashTable() that build a flat dictionary.
546 - src/gdcmElementSet.h: added a new private GetTag() accessor.
547 gdcmDocument is now a friend of gdcmElementSet.
548 - src/gdcmElementSet.cxx: clean up.
549 - Example/FlatHashTablePrint.cxx added.
550 - Example/CmakeLists.txt changed accordingly
552 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
553 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
554 moved away from gdcmDocEntrySet (since this class is an abstract class
555 acting like an interface). SQDepthLevel and BaseTagKey are now
557 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
558 and associated accessors. Doxygenation of the class.
559 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
561 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
562 Use SQDepthLevel accessor instead. ::Print() adapted.
563 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
564 - src/gdcmDocument.cxx changed accordingly.
566 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
567 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
568 - The following is the doxygen comment of the typedef declaration
569 of gdcmagKey in src/gdcmCommon.h:
570 gdcmTagKey is made to old an "universal" (as in URL, Universal
571 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
572 A dicom tag allways has a group and an element, but a set of tags
573 embeded in various (optionally nested) sequences and sharing
574 the same group and element all share the same (group, element)
575 "identifier". Hence the (group, element) cannot be used as an
576 identifier (in gdcm we shall refer to a "TagKey") of a tag.
577 In order to construct a proper tag identifier (i.e. a key) we
578 consider the following definition of a TagKey:
579 - let Group, Element be the string representation of the
580 group and element dicom tag members,
581 - let ItemNumber be the string representation of the integer
582 index of the considered item number of a sequence,
583 Let the key of a tag embeded in a sequence, noted SeqTag, be
585 /ItemNumber#Group|Element
586 where "/", "#" and "|" are characters acting as separators.
587 Then the general form of a gdcmTagKey is given by:
588 Group|Element<SeqTag>
589 where <SeqTag> means NO or many instances of SeqTag.
590 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
593 but the gdcmTagKey of a tag "embeded" is the first item of
594 a sequence, itself nested in the third item of a sequence is the
596 0004|1220/2#0008|0082/0#0008|0090
597 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
598 order to hold the new sequence compatible key. Previously, the
599 GetKey() method would look in the underlying gdcmDictEntry.
600 - src/gdcmDocEntry.cxx:
601 -- constructor now copies the underlying DictEntry key, in the local
603 -- ::Print: displays the member Key, instead of the (group, element).
604 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
605 - src/gdcmDocEntrySet.h:xi
606 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
607 -- now has a new BaseTagKey member.
609 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
610 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
612 This poses the problem with the semantics of the following lines
613 LoadEntryVoidArea(0x0028,0x1201); // R LUT
614 LoadEntryVoidArea(0x0028,0x1202); // G LUT
615 LoadEntryVoidArea(0x0028,0x1203); // B LUT
616 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
617 to the long FIXME note for what the problem is. Nevertheless in
618 order to get things working the dicom dictionary was altered !
619 Please fix things urgently...
620 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
621 information), see above note on moving the member VoidArea. Nevertheless
622 the following entries previously correctly set as US are now inproperly
624 0028 1201 OW IMG Red Palette Color Lookup Table Data
625 0028 1202 OW IMG Green Palette Color Lookup Table Data
626 0028 1203 OW IMG Blue Palette Color Lookup Table Data
627 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
628 of gdcmDocEntry moved to gdcmSeqEntry.
629 * src/gdcmSeqEntry.cxx: STYLE.
631 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
632 * Test/TestAllEntryVerify.cxx minor fix and added comments.
634 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
635 * gdcmPython/testSuite.py: all the test suite in python is now moved
636 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
637 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
638 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
640 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
641 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
642 to avoid inclusion recursion until STL is reached.
643 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
644 mecanism. errno.h is not included in gdcm anymore.
645 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
646 (gdcmFormatError now inherits from gdcmFormatUnexpected).
648 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
649 gdcmData/TestAllEntryVerifyReference.txt
650 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
651 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
652 exception_on_error parameter.
653 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
654 - vtk/vtkGdcmReader.cxx changed accordingly,
655 - Example/*.cxx and Test/*.cxx changed accordingly.
657 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
658 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
659 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
660 enable_sequences removed from gdcmHeader constructor and dependencies.
661 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
662 * gdcmPython/demo/PrintHeader.py: dummy fix.
663 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
664 skip_shadow removed from gdcmHeader constructor and dependencies.
665 * Example/*.cxx and Test/*.cxx changed accordingly.
667 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
668 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
669 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
671 2004-07-21 Jean-Pierre Roux
672 * FIX Now, Parsing and Printing a DICOMDIR do work!
673 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
675 2004-07-20 Jean-Pierre Roux
676 * FIX Some brain damaged headers have Zero-Lenght fields
677 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
679 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
680 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
681 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
682 variable (instance of gdcmDebug) by a definition macro, and the instance
683 is now in static in the gdcmDebug class
684 * src/gdcmSQItem.h : (FIXME) remove an undefined method
685 * Test/PrintAllDocument.cxx : bug fix in the result of the test
687 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
688 * WARNING: ctest now depends more tightly on gdcmData. You should
689 check out gdcmData properly for things to run smoothly...
690 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
691 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
692 we need the pixels not be loaded in order to use the ValEntry
693 that displays position and size).
694 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
695 This is a C++ based equivalent of gdcmPython/testSuite.py that should
696 be deprecated. If you have any doubts about the advantages of a
697 modern scripting language (read Python) versus grass root C++ (i.e.
698 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
699 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
700 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
701 Anyhow, consider documenting the gdcmData images in
702 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
704 * Test/CMakeLists.txt:
705 - now uses TestAllEntryVerify.cxx
706 - specific comments on oldACR00001.ima (now renamed in gdcmData
707 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
708 gdcmData/TestAllEntryVerifyReference.txt
711 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
712 * src/*.[h|cxx] : typedef clean up
713 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
714 - TagKey renamed to gdcmTagKey (for external usage)
715 - VRKey renamed to gdcmVRKey (for external usage)
716 - removal of typedef duplication.
717 - Removed all unecessary inline keyword from class inline definitions.
718 - Some method|function(void) declarations replaced with method|function().
719 * src/jpeg/libijg12/jdhuff12.c:
720 - printf polluting ctest removed.
721 - TAB removal for comminting
723 - TestAllReadCompareDicom.cxx: added a test that compares all the
724 images in gdcmDataImages.h with corresponding images in
725 gdcmData/BaselineDicom/. When baseline images are not present
726 this test creates them.
727 Note: we need to validate each reference image, but before that
728 I'd like to rename them with a more explicit name...
729 - CMakeLists.txt: changed accordingly.
730 * Example/*.cxx: examples now only include gdcm.h (as opposed to
731 including each header needed).
733 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
734 * Test/*.cxx and Example/*.cxx: moved some examples away from the
735 test suite to the Example directory. Are concerned:
740 - TestWriteSimple.cxx
741 * Test/CMakeLists.txt: added some comments on reasons for black listing
742 image gdcmData/oldACR00001.ima
744 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
745 * Test/CmakeList.txt: removed the following from black list (to be coherent
746 with removal from gdcmData):
747 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
748 - gdcm-MR-PHILIPS-16.dcm
750 Added the following because after last cvs update, they cause
751 ctest -R TestReadWriteReadCompare
753 - gdcm-MR-SIEMENS-16-1.acr
755 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
756 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
757 new comments in this file) we temporarily (sigh) move to a weaker
759 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
760 we don't need to black list the following images anymore:
761 - 8BitsUncompressedColor.dcm
763 - US-PAL-8-10x-echo.dcm
764 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
765 fixes and the beautified code ;-)
766 This fixes the bug introduced in version 1.42 (when beautifying)
767 that made the parsing of 8BitsRunLengthColor.dcm unproper.
768 Note: ctest was blind to this bug (this means we need to still
769 improve the test suite). The bug could be detected by using
770 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
772 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
773 and by displaying the (garbage) produced file temp.XDCM...
775 2004-06-29 Jean-Pierre Roux
776 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
777 - replace by uggly but working old code :-(
778 A lot of things should be OK again.
779 It's really urgent to have a test suite that *tests*,
780 to prevent Frog's beautifying sessions to break all the stuff
781 (twice, withing a fortnigh ...)
783 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
784 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
785 redundancy) to added Test/TestReadWriteReadCompare.cxx
786 * Test/CmakeList.txt: because the compare test of
787 Test/TestReadWriteReadCompare.cxx fails, the following images are
788 black listed: - 8BitsUncompressedColor.dcm
790 - US-PAL-8-10x-echo.dcm
791 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
792 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
793 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
794 and ad-hoc kludge. This kludge is now removed, and on encountering
795 such an image (OB field brain damaged) we set errno. Then in
796 ::FindDocLength() we "fix" the length as being ALL what remains
797 in the file (until EOF). We then proceed, hoping for the best...
798 This fixes a SegFault in ShowDicom when trying to write such an
800 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
801 (because TestWriteRead breaks on it, after a non conformal commit?).
802 ctest now runs properly, except for MakeDicomDir (which was allways
803 broken) and the Python related stuff (still not fixed).
805 2004-06-24 Jean-Pierre Roux
806 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
807 FIX : Test/TestReadWrite now iterates on all the file names
808 (instead of infinite loop)
809 ENH : Test/TestWriteRead now iterates on all the file names
811 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
812 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
814 2004-06-24 Jean-Pierre Roux
815 FIX : - now Write drops LUT Descriptors and LUTs (if any)
816 when SamplesPerPixel =3
817 - now Write is no longer confused by
818 'BitsAllocated = 12" and 'BitsStored=12"
819 - "UN" value representation Elements are now written correctly
820 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
821 ENH : - now gdcmHeader has its own Write methods
822 (in order to split the job that has not to be done
825 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
826 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
827 loop on the same image until memory went out.
828 Note: this means we still have gobs of memory loss in PrintDocument
829 * src/gdcmDocument.cxx: fixes problem on parsing on file
830 gdcmData/16BitsJpegLosslessGrayScale.dcm.
832 2004-06-24 Jean-Pierre Roux
833 FIX : Write - All the Sequences and Sequence Item are now written
834 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
835 is added a the end, when necessary.
836 - A lot of brain-damaged images, that were read correctly are
837 now written correctly
838 - length compatible BinEntry are now loaded correctly
839 (even for odd groups)
840 Note : only Explicit Value Representation was checked.
841 (question : is implicit VR really necessary for gdcm ?)
843 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
844 * DEVELOPPER: added a proposition of coding style.
845 * src/gdcmDocEntry.h: removed every inline declaration (for test of
848 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
849 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
850 Use the gdcmDocEntry::Print() and Write() instead.
851 * src/gdcmDocument.cxx: bug fix.
853 2004-06-22 Jean-Pierre Roux
854 FIX : gdcmDocument.cxx
855 - Now we do recognize the JpegLossLess format (there was a misstyping in
856 code 'beautyfication' :-(
857 - Now we automaticaticaly load the Luts, if any
859 2004-06-22 Jean-Pierre Roux
860 In order : to write Sequences, whatever their imbrication level,
861 : to allow user to create his own Sequences
862 a lot of modif where necessary (adding, moving, or virtualising methods)
864 WARNING : save your own sources *before* cvs up !
867 ADD virtual void Write(FILE *fp, FileType filetype);
870 ADD virtual void Write(FILE *fp, FileType filetype);
871 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
874 ADD virtual void Write (FILE *fp, FileType filetype)=0;
875 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
876 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
877 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
878 ADD std::string GetEntryByName(TagName name);
879 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
881 std::string vr = "unkn",
882 std::string fourth = "unkn",
883 std::string name = "unkn");
884 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
885 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
886 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
887 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
888 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
889 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
890 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
891 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
894 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
895 ADD virtual std::string GetEntryByName (TagName tagName);
896 ADD virtual std::string GetEntryVRByName (TagName tagName);
897 REM virtual bool Write(FILE *, FileType);
898 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
899 FILE *_fp, FileType type);
900 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
901 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
902 REM virtual bool WriteEntries(FILE *_fp,FileType type);
903 REM virtual std::string GetEntryByName (std::string tagName);
904 REM virtual std::string GetEntryVRByName (std::string tagName);
905 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
906 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
907 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
909 std::string vr = "unkn",
910 std::string fourth = "unkn",
911 std::string name = "unkn");
912 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
913 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
914 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
915 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
918 ADD virtual void Write(FILE *fp, FileType filetype);
921 ADD virtual void Write(FILE *fp,FileType filetype);
924 ADD virtual void Write(FILE *fp, FileType filetype);
925 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
926 REM std::string GetEntryByNumber(guint16 group, guint16 element);
927 REM std::string GetEntryByName(TagName name);
930 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
932 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
933 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
934 The default constructor invoked by the line
935 gdcmHeader *f1 = new gdcmHeader( header );
936 was gdcmHeader::gdcmHeader(bool) instead of the expected
937 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
938 Hence the parsing wasn't executed... See also below.
939 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
940 as explicit constructor didn't do the trick to fix the above problem.
941 Could anyone explain why ?
942 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
943 properly calls gdcmValEntry::Print() (that was weed out from
944 code related to gdcmBinEntry).
946 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
947 * In order to fix memory leaks:
948 - Test/TestWriteSimple.cxx: added cleaning of free store through
950 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
951 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
952 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
953 (through the call to ::AddDicomDirMeta()) or the destructor
954 would crash when deleting uninitialized ::metaElems].
955 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
956 - src/gdcmDocument.cxx:
957 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
959 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
960 was causing memory leaks.
961 - src/gdcmSQItem.cxx:
962 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
963 cleanly handled with polymophism: sorry but my milage is low).
964 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
965 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
966 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
967 This avoids SegFaulting.
968 - src/gdcmSQItem.h: coding style.
970 - Test/TestWriteSimple still severely sucks. The output image content
971 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
972 damaged when displayed with vtkgdcmViewer.
973 - on memory leaks: TestWriteSimple leaks really less (see entry
974 of 2004-06-18 in Changelog file for the call to valgrind).
975 - on segfaults: ctest now passes all the tests but one (no more
977 * Erroneous leading white fix:
978 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
979 white[s] (as opposed to from >> xxx, that removes it [them].
980 - src/gdcmTS.cxx: ditto.
981 - gdcmPython/testSuite.py: dirty related kludge removed.
982 * src/*: remaining references to gdcmParser removed.
983 * src/*[cxx|h]: added copy[way]left header.
986 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
987 * In order to fix writing of dicom files:
988 - Test/TestWriteSimple.cxx: a simpler example of writing.
989 - Test/CMakeLists.txt changed accordingly.
990 - src/gdcmDocument.cxx:
991 -- The destructor now recursilvely removes potential sequences.
992 -- Bug fix in ::IsJPEG2000()
993 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
994 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
996 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
997 to only declared) and build on top of
998 ::GetDocEntryByNumber(guint16, guint16).
999 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1000 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1001 for usage in destructor and treatement of promotion in
1002 ::ReplaceOrCreateByNumber().
1003 - src/gdcmSQItem.cxx: destructor should better handle his job.
1004 Test/TestWriteSimple now runs (or at least it DOES something).
1005 * We can now start hutting memory links. A good starting point is:
1006 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1007 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1008 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1010 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1011 * Valgrind note: after Mathieu Malaterre teached me how to read
1012 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1014 Using gcc, you can force the STL to use malloc and to free memory as
1015 soon as possible by globally disabling memory caching.
1016 With 3.2.2 and later, you should export the environment variable
1017 GLIBCPP_FORCE_NEW before running your program.
1018 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1019 simply vanish (it is still not clear to me, whether this means that
1020 STL std::string leaks or if valgrind believes it leaks...).
1021 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1022 running bin/gdcmTests makeDicomDir):
1023 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1024 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1026 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1027 SegFaulting (I drowned in DicomDir related code when trying to
1028 understand why the list is empty...).
1029 * src/gdcmDocument.h: first BSD license header try.
1030 * Doc/License.txt added.
1032 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1033 * src/gdcmDocument.[h|cxx]:
1034 - Clean up of the Transfer related predicates. They are now all based
1035 on new method isGivenTransferSyntax, that (should) handle properly
1036 the padding problem.
1037 - general clean up, simplification, and coding style.
1038 - Specific clean up of Parse7FE0() (umproperly named actually).
1039 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1041 2004-06-14 Jean-Pierre Roux
1043 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1044 - fix the display of SQItem ordinal number
1045 - add the GetSQItemByOrdinalNumber method
1046 - remove some useless never written private methods
1048 2004-06-14 Jean-Pierre Roux
1050 - adding a constructor taking a gdcmDocEntry as an input param
1051 - ReplaceOrCreateByNumber now returns :
1052 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1053 a gdcmValEntry * if a string value is passed as a param
1055 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1056 according to the param type (no longer sets a gdcmDocEntry)
1057 - GetValEntryByNumber, GetBinEntryByNumber added
1058 - NewValEntryByNumber and NewBinEntryByNumber added
1060 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1062 - GetSQItemNumber and SetSQItemNumber added, to provide
1063 a (relative) Item identier inside a given Sequence
1064 \warning : some pb remaining around this number
1066 - AddEntry now takes the Item Number as a param
1068 - adding a constructor taking a gdcmDocEntry as an input param
1070 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1071 * Memory leak hunt with the following command:
1072 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1073 --show-reachable=yes gdcmTests PrintDocument
1074 It looks like many (all?) leaks are due to the STL (or a bad usage
1075 of the STL. The lines producing the leaks now have a comment with
1076 a "MEMORY LEAK" tag: you can retrieve them with
1077 grep "MEMORY LEAK" src/*
1078 Here are two typical examples which I can't help fixing:
1083 char * test = "babo";
1084 name = test; //// <--- valgrind detects 960 bytes lost in
1085 //// call to std::string::operator=(char const*)
1086 name.clear(); //// Doesn't help !
1094 std::cout << "Type a bunch of characters followed by RETURN: ";
1095 getline(std::cin, line); //// <--- valgrind dectects a loss
1096 //// of 1320 bytes in call to
1097 /// std::basic_istream<>& std::getline<>
1103 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1104 * src/gdcmHeader.[cxx|h]:
1105 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1106 and related, moved away to gdcmDocument.
1107 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1108 the corresponding protected accessors of inherited class
1109 gdcmDocument, removed ! As a consequence gdcmFile had to be
1110 declared friend of class gdcmDocument (see below).
1111 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1112 - Clean up of undefined or unused methods.
1113 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1114 account the changes to gdcmHeader.h).
1115 * src/gdcmDocument.h:
1116 - gdcmFile is now a friend class (in order to take into account the
1117 changes to gdcmHeader.h).
1118 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1119 (see changes to gdcmHeader.h).
1120 - Accessors (reading on the form GetEntry*) are now public.
1121 - Clean up of undefined or unused methods.
1122 * src/gdcmDocument.cxx:
1123 - adaptation to changes to gdcmDocument.h
1124 - ::OpenFile now writes a verbose message when file cannot be opened.
1125 - some std::string properly set to VRKey
1126 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1127 references to gdcmDocument.
1128 * Test/TestFindTags.cxx: changed accordingly to above changes.
1129 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1130 cvs repository gdcmData.
1132 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1133 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1134 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1135 conflicts with gdcmValEntry::voidArea.
1136 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1137 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1138 Value representation between StringRepresentable and BinaryRepresentable.
1139 * src/gdcmDocument.cxx:
1140 - method ParseDES: proper indentation restored and usage of
1141 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1142 - method LoadDocEntry: the fingerprint left in the SetValue() of
1143 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1144 removed. Reverting to previous code segment with the proper
1145 dynamic_cast< gdcmValEntry* >.
1146 Note: this was (partially) breaking the python test suite
1147 (gdcmPython/testSuite.py) that made usage of the above
1148 fingerprint to check presence of "Pixel Data".
1149 * src/gdcmDocEntry.h: coding style.
1150 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1151 now taken into account.
1152 * gdcmPython/gdcm.i: adaptation to the new internal representation
1153 of gdcm (exit gdcmParser, hello gdcmDocument).
1154 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1156 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1157 anymore, but instead prints the loaded Python dictionary.
1158 * .... alas, the python testSuite is still broken.
1160 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1161 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1163 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1164 * src/gdcmUtil.h : export methods
1166 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1167 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1169 * Initial addition of automatic python testing
1170 * Initial addition of automatic image comparison
1172 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1173 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1174 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1176 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1177 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1178 * Test/ShowDicom.cxx : bug fix for msvc compilation
1179 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1181 2004-05-04 Jean-Pierre Roux
1182 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1183 new concepts (and new classes) :
1184 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1185 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1186 - Sequence Doc Entries (gdcmSeqEntries)
1187 a Sequence is composed of Items.
1188 Each item is a set of Doc Entries (this is recursive)
1189 The non uniqueness of the 'Dicom tag' is due to this recursivity
1190 (never taken into account)
1191 Our unability to add a new 'entry' in the header
1192 at the proper location (neither in the H-Table (map or multimap),
1193 nor in the Chained List is also due to this recursivity.
1194 Don't try, right now, to use/modify/compile these new sources :
1195 nothing is finished.
1196 We just commit all the stuff, 'as is', in order not to loose it.
1198 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1199 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1201 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1202 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1203 file prefix (SetFilePrefix)
1205 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1206 * Add a new test: ShowDicom, for now this is just the c++ version of
1207 checkRead.sh, later it will be able to compare the image read against a
1209 * Replace the DEBUG on the stack with a global entry in cmake interface:
1210 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1212 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1213 * Add an example subdir, with a real example on how to read + write a
1216 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1217 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1218 * Doc/CMakeLists.txt: the main page is now properly differentiated
1219 between the developper and user version.
1220 * Doc/doxygen.config.in: dropped search related obsolete flags
1221 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1223 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1224 * DEVELOPPER: added some helpfull comments for compile/test/install
1227 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1228 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1229 src directory, now generated in the build dir.
1230 2. Tests as mentionned smarter
1232 4. Add a new method in gdcmDict that return the PubDict by name
1233 this is interesting for 3rd party lib like ITK,
1234 where we could set the institution name / patient name...
1236 * ENH: 1. Now the test suite is working for real
1237 2. All binaries are now output in the gdcm-bin directory
1238 (this was not true before)
1240 2004-04-28 Jean-Pierre Roux
1241 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1242 SeQuence indented printing of Dicom Header.
1243 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1244 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1245 Computation of SQDepthLevel is now part of gdcmHeader constructor
1246 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1247 tree-like structure of a Dicom Header.
1248 * FIX Test code cleaning
1250 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1251 * ENH: Adding automatic testing
1252 1. Need a DartConfig.cmake to submit to public
1253 2. Add a test driver gdcmTest.cxx
1254 3. gdcmTestMain, an helper for the main test driver gdcmTest
1255 4. Files in Test don't have a main anymore, this becomes interesting
1256 when we add more and more tests, thus dsw don't have to load
1258 * ENH: Adding a GDCM_DATA_ROOT for testing
1259 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1260 one file instead of seven + some small cleanup
1262 2004-04-22 Jean-Pierre Roux
1263 * ENH Minor changes to the Print() methods.
1264 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1265 Header printing. Example given with :
1266 > PrintHeader fileName 2 new
1267 (SQ based tree-like structure still to be done for the Header ...)
1269 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1270 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1271 1. I have added some unsigned where needed
1272 2. Some function parameter not used -> (void)
1273 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1274 4. g++ don't like character '\' in comment
1275 5. #define jpeg_create_decompress jCreaDecompress
1276 this really need to be fixed
1277 6. virtualize destructor of gdcmObject ... leakage
1278 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1279 this also really need to be fixed
1280 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1281 remove compression file
1282 (as we only do decompression, right ?)
1283 * ENH: Change malloc/calloc/free with c++ equivalent
1285 2004-04-21 Jean-Pierre Roux
1286 * FIX gdcmHeaderHelper::GetXSpacing
1287 when a single value is found (bug ?), xpacing is now
1288 defaulted to yspacing
1290 2004-04-19 Jean-Pierre Roux
1291 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1292 * ENH add parameters :
1293 bool exception_on_error = false,
1294 bool enable_sequences = false,
1295 bool ignore_shadow = false
1296 to the gdcmFile constructors to be full gdcmParser compliant
1297 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1298 to allow reading of PAPYRUS 3.0 files
1300 2004-04-06 Jean-Pierre Roux
1301 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1303 2004-04-02 Jean-Pierre Roux
1304 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1305 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1306 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1308 2004-03-30 Jean-Pierre Roux
1309 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1310 for ACR file, written out as DICOM files (hope so...)
1312 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1313 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1314 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1315 moved to base class gdcmParser and only the specialisation is kept
1317 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1318 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1319 already does the job.
1320 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1321 (to be consistent with gdcmParser::WriteEntries).
1323 2004-03-30 Benoit Regrain
1324 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1325 upate of the object's instance. It's passed to 2 in the unfavorable
1326 case : one in the ExecuteInformation, one in the ExecuteData
1328 2004-03-29 Jean-Pierre Roux
1329 * ENH : Check on file type to be written moved
1330 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1331 * FIX : gdcmObject::ResetBoundaries now stops properly
1332 when end-of-list is reached
1333 : gdcmVersion modified (as Benoit Regrain asked)
1335 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1336 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1337 * src/gdcmUtil.cxx: added forgotten iostream include.
1338 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1339 equivalent to ExplicitVR in existing code).
1341 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1342 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1343 now contains all the gdcmGlobal related code.
1344 * minor coding style and doxygenation changes.
1346 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1347 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1348 now contains all the Debug related code.
1349 * minor clean-up of includes in src/*.cxx
1350 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1351 CreateCleanString) removed.
1352 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1353 * Doc/DoxyMainPageUser.txt added.
1354 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1355 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1356 src/gdcmDirList.cxx)
1358 2004-03-24 Jean-Pierre Roux
1359 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1361 2004-03-23 Jean-Pierre Roux
1362 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1363 big endian made volumes
1364 * ENH Now gdcmParser constructor and destructor are protected to forbid
1365 end user to instanciate class gdcmParser
1366 (only gdcmHeader and gdcmDicomDir are meaningfull)
1368 2004-03-22 Benoit Regrain
1369 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1370 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1371 gdcmSerie to gdcmDicomDirSerie
1373 2004-03-19 Jean-Pierre Roux
1374 * ENH Now the tree-like structure describing a DICOMDIR comming from
1375 an already existing DICOMDIR file is consistent with
1376 the home-made tree-like structure build ex-nihilo
1377 or build from the files held (recursively) in a Directory
1378 functions gdcmDicomDir::CheckBoundaries()
1379 gdcmObject::SetBoundaries() added
1381 2004-03-17 Jean-Pierre Roux
1382 * REM (Eric Boix bug) : removal of meaningless
1383 gdcmDicomDirImage::NewImage function.
1384 * FIX now file names and directory name are written properly in the
1386 * FIX now gdcmDicomDir constructor may be call without any trick
1389 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1390 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1391 of gdcmDicomDirImage::NewImage as empty function.
1393 2004-02-28 Jean-Pierre Roux
1394 * ENH add gdcmDicomDir:NewPatient
1395 add gdcmDicomDirPatient:NewStudy
1396 add gdcmDicomDirStudy:NewSerie
1397 add gdcmDicomDirSerie:NewImage
1398 to allow making gdcDicomDir object.
1399 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1400 (as opposite to the gdcmHeader chained list)
1402 2004-02-11 Benoit Regrain
1403 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1404 when using from python
1406 2004-02-10 Benoit Regrain
1407 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1408 * FIX : in gdcmDicomDir when the directory is empty
1409 * ENH : add callback and methods to get the progression of dicomDir
1412 2004-02-06 Jean-Pierre Roux
1413 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1414 - GDCM_META added to gdcmDicomDirType
1415 - class gdcmMeta created
1416 * ENH : - A brief summary is now displayed at the beginning of
1417 'testDicomDir' to help disaster magnitude estimation
1418 * REM : Now useless Test/explDICOMDIR.cxx
1420 2004-02-05 Benoit Regrain
1421 * ENH : add methods in gdcmObject to get the hash table or the list of
1423 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1424 * FIX : wrapping python for TagHeaderEntryHT
1426 2004-02-04 Benoit Regrain
1427 * FIX : even length for some strings when writting the dicom dir
1428 * FIX : sort the images in the dicom dir
1429 * FIX : Bug fix for python use of dicom dir
1430 * ADD : a python demo
1432 2004-02-04 Jean-Pierre Roux
1433 * FIX : Final solution (?) for icone embedded images
1434 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1435 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1436 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1437 gdcmData/gdcm-MR-SIEMENS-16.acr1
1438 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1439 to make full checking easier
1441 2004-02-04 Benoit Regrain
1442 * FIX : WriteEntries : coding style & logic in parameters
1443 * FIX : Set the elements to create the DicomDir in a dictionary file
1445 2004-02-03 Benoit Regrain
1446 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1447 * gdcmDicomDir : add the load of directory
1448 * Bug fix and print add-on
1450 2004-02-03 Jean-Pierre Roux
1451 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1452 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1453 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1454 * FIX gdcmParser.cxx : 'group length' elements are now considered
1455 as integers, even for shadow groups, when file is Implicit VR
1457 2004-02-02 Jean-Pierre Roux
1458 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1460 of the last synonym :-(
1461 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1463 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1464 * FIX taking into account the possible 7fe0,0010 multiplicity
1465 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1466 to allow removal of references to 7fe0,0010, to deal with
1467 ACR-NEMA images, when 0028,0200 is meaningfull
1469 2004-01-31 Jean-Pierre Roux
1470 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1471 no longer writes 'Un' on disk
1472 * FIX SQ elements with actual length are now dealt with corectly
1473 * FIX gdcmFile::WriteBase make the difference, for color images, between
1474 the length (for Palette expanded images)
1475 and Raw Length (non expanded image + Palette)
1476 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1477 (that broke Write). Replaced by UL.
1478 Aware user will reload the field if he
1479 thinks it's necesssary
1481 2004-01-30 Jean-Pierre Roux
1482 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1483 when 'dirty Acr' is found, to be compliant with the new
1484 IsReadable() methods.
1486 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1487 (no DOUBLE images in kosher DICOM,
1488 but so usefull for people that miss them ;-)
1490 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1491 DICOMDIR related utilities (not checked as Windoze compliant)
1493 2004-01-28 Jean-Pierre Roux
1494 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1496 2004-01-27 Jean-Pierre Roux
1497 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1498 to allow skipping the shadow elements, to save memory space.
1499 The TRUE value for this param has to be used
1500 with a FALSE value for the 'enable_sequence' param.
1501 ('public elements' may be embedded in 'shadow Sequences')
1502 * gdcmHeader methods now deal with 'embedded icones images' in the header
1503 (even when an 'icone image sequence' is announced by the
1504 element (0x0088,0x0200), but there is NO icone at all ...
1506 * gdcmHeader sometimes Image Location value doesn't follow
1507 the supposed processor endianity (see gdcmData/cr172241.dcm).
1510 * gdcmHeader add the method
1511 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1512 to get *all* the Header Entries with the same tag.
1513 GetHeaderEntrySameName is probabely *useless*
1514 (no meaning : Name is *not* an identifier within the Dictionnary)
1516 2004-01-26 Benoit Regrain
1517 * Bug fix in the print of hexadecimal representations. Remove long fields
1518 in the print and add a third level of print to print them
1520 2004-01-23 Benoit Regrain
1521 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1522 * Bug fix on test suite after remove the strip made on not string fields
1523 * Split the IsReadable method between gdcmParser which test that the file
1524 is dicom and gdcmHeader which test that it's an image file
1526 2004-01-22 Benoit Regrain
1527 * DicomDir : clean code, add methods, set variables in protected or private
1528 * gdcmUtil : bug fix for the clean string method
1530 2004-01-19 Benoit Regrain
1531 * Add the use of shadow dictionaries
1532 * bug fix and coding style
1534 2004-01-19 Benoit Regrain
1535 * src/gdcmFile.cxx : bug fix concerning the close of file
1536 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1537 * Add the update of header entries using the shadow library
1539 2004-01-19 Benoit Regrain
1540 * removal of file gdcmHeader2.cxx
1541 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1542 inheriting from gdcmParser. This split is to prepare the integration
1543 of dicom dir parsing
1544 * bug fix under python
1546 2004-01-16 Jean-Pierre Roux
1547 * REM removal of class gdcmHeaderEntrySet
1548 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1549 * ADD add file gdcmHeader2.cxx
1550 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1552 2004-01-15 Benoit Regrain
1553 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1554 entries created while parsing the header. Thus, they will be destroyed
1555 when the gdcmDictSet will be destroyed
1556 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1559 2004-01-15 Benoit Regrain
1560 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1561 made a fatal error because of the memory release at the end of program.
1562 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1563 some memory and vtk seems to have some problems with that.
1564 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1566 2004-01-14 Benoit Regrain
1567 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1568 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1569 * src/*.[h|cxx] : make changes due to class name changes
1570 * gdcmPython/demo/*.py : bug fix due to method names
1572 2004-01-13 Benoit Regrain
1573 * src/*.[h|cxx] : coding style
1574 * vtk/*.[h|cxx] : coding style
1576 2004-01-13 Benoit Regrain
1577 * gdcmPython/testSuite.py : test the readable flag of file for tests
1578 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1579 It's lied to the stl compilation by MSVC (windows, always windows...)
1580 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1582 2004-01-12 Benoit Regrain
1583 * src/*.h : add comments
1584 * src/gdcmDictSet.h : set the method BuildDictPath in public
1585 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1586 directly setted in the source code
1587 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1590 2004-01-09 Benoit Regrain
1591 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1592 * setup.py : use a reference to gdcmVERSION
1594 2004-01-07 Benoit Regrain
1595 * Modification to compile with the distutils.
1598 2003-12-10 Benoit Regrain
1599 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1600 can use a gdcmHeaderHelper to load datas
1601 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1602 made in the source code
1604 2003-12-10 Benoit Regrain
1605 * Update Windows projects and .cvsignore files
1607 2003-11-12 Jean-Pierre Roux
1608 * ENH gdcmHeader constructor has one more parameter (default value : false)
1609 that allows the user to 'go inside' the SeQuences only
1611 gdcmElValSet:Print takes it into account
1613 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1614 * ENH: Update gdcmPython/CMakeLists
1615 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1616 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1618 2003-11-10 Jean-Pierre Roux
1619 * FIX : gdcmHeader::LoadElements is now based
1620 on the ListTag listElem member,
1621 not longer on the TagElValueHT tagHt member
1622 * ENH : PrintPubElVal shows (temporarily) both results,
1623 with the tagHt member and the listElem member.
1624 (it's easier to 'see' the problems when using Printheader)
1626 * FIX : old private member LgrElem is now splitted into
1627 ReadLength : Length actually found on disk (updated only
1628 if bug fixing is necessary), for internal
1630 UsableLength : Updated by FixFoundLength, to fix a bug
1631 or to allow Parser going on.
1632 Will allow to re-write a kosher header when a SeQuence
1633 with a length (not 0000) is found
1634 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1635 because gdcmElValSet::Add does not update ListElem
1638 2003-11-07 Jean-Pierre Roux
1639 * FIX misstyping in Transfert Syntax name table
1640 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1641 when they have an actual length (not 0000 nor FFFFF)
1642 (Nobody should care of it, but DICOMDIR explorers)
1644 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1645 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1647 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1648 * ENH: vtkGdcmReader now supports LUT !
1649 (vtkgdcmViewer for now is not able to use them though)
1651 2003-11-05 Jean-Pierre Roux
1652 * in testSuite.py : new files names for checking the package
1653 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1654 that returns the pixel area size to the *aware* (vtk) user
1655 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1657 2003-11-05 Benoit Regrain
1658 * in testSuite.py : Modify the rules for checking the paths
1659 : Explicit error messages
1660 * in __init__.py : Related modif
1662 2003-11-03 Jean-Pierre Roux
1663 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1664 to be used by aware (vtk) users that want to manage
1665 LUT (and no to turn the PALETTE image into an RGB pixels one)
1666 * GetPixelType now returns 8U for 24 Bits images
1667 (vtkGdcmReader compliant)
1669 2003-10-31 Jean-Pierre Roux
1670 * Removal of *all* gdcmData images and add them again
1671 in order to loose the 'history' of un-anonymised images
1673 2003-10-31 Jean-Pierre Roux
1674 * RMV : removal of useless jBitsInJsample.h
1675 for both 8 and 12 Bits JPEG Lossy Libraries
1677 2003-10-31 Jean-Pierre Roux
1678 * ENH : Add the functions gdcmFile::GetImageDataRaw
1679 gdcmFile::GetImageDataIntoVectorRaw
1680 that act as GetImageData and GetImageDataIntoVector
1681 except the making of an RGB Plane from Gray Plane + LUT
1682 Intended to aware (vtk) users who know how to manage
1685 GetLUTRGBA return a R,G,B,A LUT if any
1686 lgrTotaleRaw gives the 'Raw' length
1687 GetImageDataRaw returns the gray Plane
1688 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1689 (They stay Grey, just like with other Dicom viewers :-(
1691 2003-10-30 Jean-Pierre Roux
1692 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1694 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1695 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1696 being coherents dicom files.
1698 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1699 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1701 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1702 * ENH: Two steps is necessary to please VC++ compiler...
1703 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1704 * ENH: Add include dir to medcon lib
1705 * FIX: only one function is being exported for now !
1706 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1708 2003-10-29 Jean-Pierre Roux
1709 * adding gdcmHeader::GetLUTRGBA
1710 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1711 --> Mathieu, the modif u're waiting for is not yet committed
1712 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1714 2003-10-27 Jean-Pierre Roux
1715 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1716 00191113.dcm DermaColorLossLess.dcm
1717 MxTwinLossLess.dcm RadBWLossLess.dcm
1718 * ENH: For version prior to vtkImageViewer2 -r 1.19
1719 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1721 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1722 * Removal of ido stuff in CMakeLists.txt
1724 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1725 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1726 * FIX: remove a call to ->Modified ... see comments
1727 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1729 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1730 * FIX: Problem with path for libvtkgdcmPython
1731 * ENH: Try adding a search script for python site-package
1732 * RMV: Remove some file from medcon lib that are not necessary
1733 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1734 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1735 * FIX: More pragma disable fro VC++,
1736 I don't think I break something as it is also disable in VTK/ITK.
1737 But it fasten debug compilation time.
1739 2003-10-23 Jean-Pierre Roux
1740 * gdcm now deals with 16 Bits Run Length Encoded images
1741 (they are compressed as 2 planes images,
1742 one for the high Bytes, the other for low Bytes)
1744 2003-10-22 Jean-Pierre Roux
1745 * Now CheckRead takes into account :
1746 - the bugged 'Leonardo' Siemens images
1747 - the XA images, sent thru the burning VPRO station
1748 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1751 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1752 * FIX: When copying a Makefile.am to CMakeLists.txt
1753 one should remove the '\'
1755 2003-10-22 Jean-Pierre Roux
1756 * in gdcmData adding a bugged 'Leonardo' Siemens image
1757 (wrong lengths in header)
1758 OK with gdcm, KO with the other viewers :-)
1759 * add a GE dlx XA image, thru the VEPRO burning station
1762 2003-10-21 Jean-Pierre Roux
1763 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1764 for a brutal checking of vtkgdcmViewer compliance
1766 2003-10-21 Jean-Pierre Roux
1767 * add the files for 'xmedcon' Jpeg Lossless library
1768 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1770 2003-10-21 Jean-Pierre Roux
1771 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1773 2003-10-21 Jean-Pierre Roux
1774 * garbage Siemens 'Leonardo' images dealt with
1775 (the patch is easy to remove)
1776 * cosmetic changes to avoid warnings
1778 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1779 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1780 no need to press 'r' now.
1782 2003-10-20 Jean-Pierre Roux
1783 * upgrade of checkRead.sh checkWrite.sh according
1784 to new Jpeg Lossless decompressor
1785 * add US.3405.1.dcm, a genuine RGB medical file ...
1786 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1787 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1789 2003-10-15 Jean-Pierre Roux
1790 * general anonymisation in gdcmData
1791 * adding the 'color files' from
1792 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1793 * adding some well knowed bugged-header images
1794 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1795 waiting for their inclusion in Python testsuite
1797 2003-10-15 Jean-Pierre Roux
1798 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1799 no longer seg faults when file is not found
1801 2003-10-14 Jean-Pierre Roux
1802 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1805 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1806 * TODO: *.in file to genereate a UseGDCM later
1808 2003-10-14 Jean-Pierre Roux
1809 * Some supposed-to-be Dicom Images have no preamble.
1810 OpenFile takes it into account
1811 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1812 * Missing elements added in dicomV3.dic
1813 (just to be affraid : have a look at
1814 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1815 and do it again next year ;->
1817 2003-10-13 Jean-Pierre Roux
1818 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1819 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1820 But there are NOT. It's fixed !
1822 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1823 * FIX: "jpeglib.h" was not found on VC++
1824 * FIX: vtkgdcm was not being installed
1826 2003-10-10 Jean-Pierre Roux
1827 * ENH : OpenFile closes the file if it *really* doesn't look like
1828 an ACR-NEMA / DICOM one.
1829 * FIX : testWrite no longer writes an empty file if the source file
1830 is not gdcm Readable
1831 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1834 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1835 * FIX: CMake generate now documentation
1836 * ENH: out of source doc build !
1837 * ENH: Generate both user and dev documentation
1838 * ENH: Should work on windows too
1839 * ENH: Only one doxygen config.in file is needed
1840 * FIX: make install should be ok now on ùnix plateform
1841 * FIX: PATH to dictionary was wrong (missing /)
1842 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1844 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1845 * vtkGdcmReader is now able to read rgb dicom file.
1846 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1847 * added a gdcmViewer to vtk test, use mouse to control
1848 window level & window width
1850 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1851 * CMake-ification of gdcm, we have now two build system
1852 * FIX: on cygwin Wsock32 doesn't exist
1853 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1855 2003-10-06 Emanuel Ollart
1856 * FIX : compilation process wad broken.
1857 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1859 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1860 * change gdcmViewer -> vtkgdcmViewer
1861 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1863 2003-10-06 Jean-Pierre Roux
1864 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1865 ( e.g : well known GE images with a wrong elem length,
1866 : Philips MRI Images with a wrong Huffman table)
1867 * still to be done : allow the reading of bugged LEONARDO Siemens images
1869 2003-10-03 Jean-Pierre Roux
1870 * Odd length strings are padded with '\0' (not with spaces,
1871 to remain compliant with already defined strings,
1872 like Transfert Syntax UID and others)
1874 2003-10-03 Jean-Pierre Roux
1875 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1876 to allow displaying RGB images (not only by affim ;-)
1878 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1879 * vtkGdcmReader is now able to read rgb dicom file.
1880 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1882 2003-10-03 Jean-Pierre Roux
1883 * A few nasty patches to allow the reading of a lot of nasty images
1884 ( e.g : well known GE images with a wrong elem length,
1885 : Philips MRI Images with a wrong Huffman table)
1886 * still to be done : allow the reading of bugged LEONARDO Siemens images
1888 2003-10-03 Jean-Pierre Roux
1889 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1891 2003-10-03 Jean-Pierre Roux
1892 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1893 to allow displaying RGB images (not only by affim ;-)
1895 2003-10-03 Jean-Pierre Roux
1896 * gdcmFile::GetImageDataIntoVector now
1897 - deals with MultiFrames MultiFragments Run Length Encoded files
1898 - deals with YcBcR (YBR_FULL) files
1899 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1900 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1902 (no sample found :-(
1904 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1905 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1906 Two reasons: - clear things
1907 - third parties acces gdcm through header files, so won't
1908 suffer anymore VC++ complains
1910 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1911 * add argv[1] in testvtkGdcmReader.cxx
1914 2003-09-24 Jean-Pierre Roux
1915 * The lines are now eigthy characters long.for
1916 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1918 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1919 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1920 char* to std::string. Thus, the use of strdup becomes useless. (see
1921 previous commis of Malaterre)
1922 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1923 before the last Malaterre's commit.
1925 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1926 * This commit should fix the Debug building under VC++, the problem
1927 was mainly a mixture of debug and release lib being loaded at startup.
1928 * I also remove a depency to a specific C function: strdup. Because I had
1929 to force the link to msvcrtd (whereas strdup is in libc).
1931 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1932 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1933 located in the gdcmCommon.h file. All use of reference of tha has been
1934 changed to now use the variable GDCM_UNFOUND.
1936 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1938 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1939 Dicom dictionary. The test suite can now be run again. Note:
1940 I'm note very happy with the " (RET)" changes. I believe this
1941 RETAINED comment should be dropped when parsing the dictionary.
1942 - PACKAGER corrected
1944 - AUTHORS updated and now in alphabetical order
1945 * Makefile.am now exports gdcm.dsw for Windoze users.
1947 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1948 * cygwin complains about missing std:: in subdir Test/
1950 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1951 * remove some methods that are now in gdcmHeaderHelper
1953 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1954 * vtkGdcmReader set spacing and origin correctly
1956 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1957 * Fix a few delete/delete[] mismatch
1959 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1960 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1961 interpretation to data given by gdcmHeader. For instance there are
1962 heuristics to get informations (look at different places).
1963 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1964 sorting DICOM images based on different strategies.
1965 * modified Makefiles accordingly.
1967 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1968 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1969 when building in debug mode
1970 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1971 src/win32/gdcmdll.dsp
1972 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1974 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1975 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1978 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1979 * src/win32/libgdcmjpeg12.dsp was not dos format
1980 * src/win32/libgdcmjpeg12.dsp :
1981 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1982 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1984 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1985 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1987 * src/gdcmFile.cxx : bug fix in affectation type
1988 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1989 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1990 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1991 symbols... future problem ?
1993 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1994 * src/win32/libgdcmijpeg12.dsp was missing
1995 * modified gdcm.dsw accordingly
1997 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1998 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2000 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2001 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2002 commit of JPR (before his hollidays to facilitate our work).
2003 * setup.py : bug fix in code. Modifications made while the last commit
2004 of JPR. The code hasn't been tested before the commit... it's so
2005 useless to make that (for best programmer that is JPR) !!!
2007 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2008 * tagged the current version as Version0_3 (i.e. version 0.3)
2010 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2011 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2012 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2013 * *.dsp : modifications to use new libgdcmijpeg8 library
2014 * setup.py : bug fix on VTKPATH variable
2015 * PACKAGER : adding all concerning windows
2017 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2018 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2020 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2021 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2022 test suite reported error.
2023 * PACKAGER file added (describes what a packager must do when
2024 packaging a new release).
2025 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2026 * configure.in: upgraded version number to 0.3.0
2027 * fixing build of rpm (through rpm -ta):
2028 - Doc/Makefile.am exports proper doxygen files
2029 - src/jpeg/libijg8/Makefile.am exports the include files.
2031 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2032 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2033 * src/gdcmHeader.h : formatting code
2035 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2036 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2037 We were obtaining error message from vtk. Now, creation of file list
2038 is made in an internal list to prevent this problem.
2039 Bug fix when output is empty.
2040 Bug fix in update of progress value. Previous commit for this was a bad
2042 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2044 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2045 * src/gdcmHeader.h : added method to get the file name
2046 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2047 files. Added method to remove all files on the input
2048 Added FIXME comment concerning the bad parsing of header made by
2049 ExecuteInformation method (in ExecuteData method)
2051 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2052 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2053 when using make instal.
2054 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2055 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2057 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2058 * setup.py : adding include dir of jpeg lib to compile all sources
2059 * */Win32/*.dsp : JPR fix for windows compilation
2061 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2062 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2064 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2065 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2067 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2068 * setup.py is again effective on un*x (takes into account the
2069 addon of the jpeg library)
2070 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2071 * Doc/Doxy* updated (includes above enhancements)
2072 * INSTALL now points to web documentation
2074 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2075 * src/gdcmHeader.h doesn't make unnecessary reference to
2077 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2079 * src/gdcm*.[cxx|h] :
2080 - to allow compilation with gcc 3.x
2081 -- clean up of STL usage (added explicit usage of std::)
2082 -- small fixes on exceptions.
2083 Note: linking not tested !
2084 - clean of doxygen comments to avoid warnings at documentation
2086 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2087 dependent convertion).
2089 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2090 * Clean up of previous JPR garbage commit (not even commented in the
2092 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2093 - moved all jpeg related files from src to src/jpeg/libijg8, with
2094 addition/modification of Makefile.am and configure.in.
2095 - the testSuite is still brain damage (not guilty).
2097 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2098 * WrapVTK.py : modifications to get correctly vtk source files to
2100 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2101 (FileName -> Filename)
2103 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2104 * vtk/vtkGdcmReader.[cxx/h]:
2105 - UpdateProgress method should now be effective
2106 - removed the limitation on having only images loaded (as opposed
2108 - when building a stack of images/volume, a lesser number of
2109 gdcmHeader and gdcmFile instances should be used (hopefully
2110 accelerating things).
2111 - when building a stack of images/volumes, files which are not
2112 loadable (wrong path-filename, wrong permissions on existing file,
2113 or file not parsable by gdcm) are replaced with a black image
2114 in the stack (for the caller to notice the problem).
2116 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2117 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2119 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2120 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2121 between standard library (std) and vtk library (problems are found
2122 under Windows... thanks Windows !)
2124 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2125 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2127 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2129 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2130 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2132 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2133 * When compiling with distutils (see setup.py) the C++ compiler is
2134 called with different flags than the default ones (with automake).
2135 In order to fix all those warning, I compiled gdcm with the command
2136 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2137 and went for warning fixes:
2138 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2139 up from unused variables.
2140 - vtk/vtkGdcmReader.cxx: potential bug fix.
2141 * src/gdcmHeader.h: Doxygen warning cleanup
2143 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2144 * gdcmPython/gdcm.i:
2145 - typemaps correction to take into account the systematic replacement
2146 of "using namespace std" with std:: prefix e.g. std::list,
2147 std::string... (cf changes of 2003-05-21).
2148 - gdcmGlob global variable of type gdcmGlobal (defined in
2149 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2150 exported to Python a as cvar.
2151 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2152 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2153 gdcmDictSet.GetPubDictTagNames() and
2154 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2155 C++ static methods).
2156 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2157 with the above changes.
2159 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2160 * setup.py, manifest.in : bug fix under linux
2162 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2163 * Modification of setup.py to compile vtk part too. Then, we have 2
2164 wrappers which must work with same distutils. For that, we have a
2165 generic distutils in distusiltsWrapping.py ; with :
2166 - build_extWrap class to wrap generically all extensions,
2167 - ExtensionWrap base class for all wrapping extension that contains
2169 - Wrapper interface which wrap sources
2170 + In WrapSwig.py we have extension and wrapper for Swig
2171 + In WrapVTK.py we have extension and wrapper for VTK
2172 * MANIFEST.in : modifications to consider vtk directory and new python
2173 files for compilation
2175 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2176 * Added python wrappers of vtkGdcmReader vtk class (see the
2177 source in vtk/vtkGdcmReader.cxx) :
2178 - vtk/Makefile.am now builds a library
2179 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2180 python library (as opposed to _gdcm.so wich are the python
2181 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2182 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2184 - configure.in has an additional flag --enable-vtk that needs
2185 to be set to enable compilation of vtk related code, that is:
2186 + vtk/vtkGdcmReader.so and
2187 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2188 + gdcmPython/vtkgdcmPython.so (see above)
2189 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2190 be read when compressed or when HighBit + 1 != BitsStored),
2191 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2192 the usage of the python wrapper of vtkGdcmReader vtk class.
2193 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2194 * src/*.[h] all occurences of stl classes are now prefixed with
2195 std::, and all occurences of "using namespace std;" where removed.
2196 This is to avoid pollution of global namespace in included files.
2197 Apparently vtk does not avoid this pitfall: when using both
2198 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2199 collision of various stl members (principally cout...).
2200 * gdcmPython/testSuite.py now cleanly removes temprory generated
2202 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2203 comply with above changes)
2205 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2206 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2207 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2208 vtk data structure (an image Flip was required).
2209 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2210 * cosmetic changes in documentation.
2212 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2213 * src/gdcmHeader.cxx: the constructor no longer exits when an
2214 unexisting file is given as argument.
2215 * The subdirectory Data (containing all the images used for the
2216 test suite) is not part of this repository anymore. A new module
2217 containing those images is now available at
2218 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2219 with the name gdcmData.
2220 All the python scripts (including the package initialisation file
2221 gdcmPython/__init__.py) were adapated to take this change into
2222 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2224 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2225 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2226 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2227 demo of the usage of this class.
2228 Compilation of this vtk part is only done when using the --enable-vtk
2229 at configure (or autogen.sh) stage.
2231 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2232 * More memory link related corrections and documentation fixes.
2234 - maximum info is obtained with a command of the form:
2235 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2236 --show-reachable=yes PrintHeader
2237 - the remaining reachable blocks seem to come from the STL
2238 allocation scheme through the usage of map and list. It looks
2239 like this memory cannot be freed but it is not a memory leak
2240 (in fact further invocation to the STL would recollect the
2241 unused memory allthough it cannot explicitely be freed).
2242 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2243 of displaying an image parsed with gdcm and displayed with VTK.
2244 Note: some images don't seem to work e.g.
2245 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2246 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2247 Allthough this weakens the semantics, it is a ditch attempt to
2248 make gdcm more thread friendly.
2250 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2251 * Memory link hunt (by using valgrind through the command
2252 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2253 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2254 gdcmHeader::_dicom_vr.
2255 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2256 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2258 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2260 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2261 * src/Makefile.am now exports all the necessary include files at
2265 * UpdateGroupLength replaced by new one
2268 * UpdateGroupLength re-written using H-Table
2269 (named UpdateGroupLengthNew untill checks are over)
2271 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2272 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2273 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2275 - gdcmHeader::GetPubElValSet removed.
2276 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2277 UpdateGroupLength, WriteElements, Write.
2278 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2279 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2280 carried the same semantics.
2281 - src/gdcmHeaderIdo.cxx changed accordingly.
2282 - gdcmFile::WriteBase now regroups all the codes from previous
2283 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2284 - enum FileType moved to gdcmCommon.h
2285 * src/gdcmHeader.cxx AddDefault trashed
2286 * gdcmGetXSize added
2287 * getimageDataSize now calls gdcmGetXSize
2288 * Test/*.cxx changed to agree with above changes
2290 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2291 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2292 (to avoid double call by end user).
2293 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2294 by end user, since gdcmHeader::gdcmHeader now handles it.
2296 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2297 * gdcm/Doc many doxygen changes:
2298 - Doxyfile now has two different versions, DoxyfileUsers that generates
2299 the html.users end users oriented documentation and
2300 DoxyfileDeveloppers that generates the html.developper developper
2301 oriented documentation.
2302 - README changed accordingly
2303 - requirement.txt removed (old design info moved to TODO).
2304 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2305 DoxyMainPage.txt, DoxyPython.txt provide more information.
2306 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2307 be updated by simply regenerating the docs with doxygen and copying
2308 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2309 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2310 all the tests in the form "if (<map>.count() >1)" were removed.
2311 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2312 ill-formed documentation sections.
2313 * src/gdcmHeader.cxx: ditto
2315 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2316 * setup.py fixed for un*x (needed macro for stdint.h)
2317 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2318 un*ces with sh-utils test utility.
2319 * gdcmPython/demo/test.py renamed to PrintHeader.py
2320 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2321 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2322 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2323 * src/gdcm*.cxx JPR's bad inclusion fixed.
2325 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2326 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2327 * gdcmPython/demo/test.py changed accordingly.
2329 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2330 * gdcmPython/Makefile.am fixed linking against libstdc++
2331 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2332 * Swig subdir (historical tests of swig version 1.3.17++) removed
2333 * Test/testChangeEntete.cxx some lines commented out in order to make
2335 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2336 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2338 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2339 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2340 hence the user doesn't need this explicit call.
2341 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2342 i.e. LoadElements() call removed.
2343 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2344 - src/Makefile.am declares the proper flag for g++.
2345 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2346 for adding user defined new tags.
2347 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2348 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2349 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2351 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2352 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2353 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2354 src/Makefile.am : the project should properly compile and install
2355 with the autotools, included the python wrappers part.
2356 * gdcm.spec.in : added a spec file for RPM packaging.
2358 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2359 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2361 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2362 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2363 to exported to the environement (see gdcmPython/testSuite.py
2365 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2366 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2367 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2368 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2369 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2371 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2372 * gdcmPython/__init__.py doesn't crash anymore when running in
2373 in InstallMode or PreInstallMode but with an environement given
2374 value of GDCM_DICT_PATH.
2375 * src/gdcmDictSet.[cxx/h] coding style.
2377 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2378 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2379 * src/gdcm.h general comments moved to TODO, and README
2380 * src/gdcm.h should now be seen as a user commodity (including it
2381 should suffice to fully use gdcm). It is nowhere including within
2382 any of the kernel files src/*.cxx and src/*.h.
2384 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2385 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2386 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2388 * src/gdcm*.cxx only include their corresponding include file
2389 (as opposed to gdcm.h)
2390 * gdcmPython/gdcm.i changed accordingly
2391 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2392 the autogen.sh generated "make snapshot" command to work.
2393 * autogen.sh removed history related references to crea package.
2395 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2396 * distutilsSwigCPlusPlus.py work around some swig portability
2399 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2400 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2401 was done in a last ditch attempt to get setup.py _really_
2402 operationnal. The python/gdcmPython layaout add the advantage
2403 of hidding away the python related distutils specific files
2404 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2405 Alas, the src directory was out of scope (i.e. it's relative
2406 position to setup.py was ../src) which made things impossible to
2407 handle (see previous version of python/setup.py). Crossing fingers...
2409 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2410 * python/setup.py now works on Un*x. (harder than I thougth)
2411 * python/distutilsSwigCPlusPlus.py can now have include files
2412 among the list of sources.
2414 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2415 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2416 * modifications in MSVC projects
2418 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2419 * As stated by the first lines of Test/ExceptionAndPython/README, it
2420 looks like we can move back to original usage of exception within
2421 src/gdcm* and hence remove the errno stuff that was introduced
2422 as a quick and dirty fixture of this problem (added to the TODO).
2423 * Doc/Doxyfile configuration file for Doxygen and corresponding
2424 README file for usage added.
2425 * Test/testWrite.cxx added. This new test comes from a split of
2426 test.cxx that is now reverted to its original purpous i.e.
2427 testing the proper parsing of a Dicom related file.
2428 testWrite.cxx concentrates on testing the IO part of gdcm.
2429 * Test/bug1.cxx (containing a bug on WIn32) added.
2430 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2431 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2432 whose purpose is to publish the content of the TagNames of the
2433 Dicom public dictionnary were not accessible without an
2434 instance of class gdcmHeader.
2435 - those methods are now static methods of gdcmDictSet and hence
2436 require no instances at all to be invocated.
2437 - within gdcmDictSet this change required to change some method
2438 to class methods (i.e. are now static) among which SetDictPath
2439 (renamed to BuildDictPath) and LoadDefaultPubDict.
2440 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2441 the above changes by calling the new method classes of gdcmDictSet.
2442 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2443 the above to be effective.
2444 * python/gdcmPython: in order to wrap properly the above changes
2445 for Python, swig version now needs to be > 1.3.17.
2446 * python/gdcmPython/Makefile fixed to adapt itself to new
2447 configure/make shema introduced by Johan Montagnat (thanks for the
2448 contribution). Alas this Makefile cannot be turned into a proper
2449 Makefile.am without some heavy changes in the configure.in
2450 (for python dectection).
2451 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2452 now avoids publishing the empty entries.
2454 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2455 * python/setup.py : bug fix concerning install under windows
2456 ExtraPath reused :-P
2457 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2459 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2460 * Dicts/dicomV3.dic : remove double spaces !!!
2461 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2462 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2465 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2466 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2467 method. Doxygenation.
2468 * src/gdcm.h clean up of JPR spurious comments.
2470 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2471 * python/distutilsSwigCPlusPlus.py now properly collects the
2472 shadow classes generated by "swig -c++" (gdcm.py in our case)
2473 when using "python setup.py install".
2474 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2475 reexports the working classes.
2476 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2477 by the classical C errno scheme. This is to prevent an obscure
2478 behavior of the python wrappers when importing wxPython.wx prior
2479 to gdcmPython (which ended up in an abort call). An illustration
2480 of this oddity can be found in the Test/ExceptionAndPython
2481 subdir (see the README file). This problem probably due to
2482 an combination of g++ and dynamic loading.
2483 * added Test/ExceptionAndPython (see above)
2485 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2486 * Changed the layout of the python part to avoid bloating main
2487 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2488 i.e. the distutils arsenal. All the python related stuff is
2489 again in a python subdir, but the package itself is now in
2491 * setup.py was cleaned up:
2492 - pythonIncludePath removed
2493 - python setup.py bdist target is now functional.
2494 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2495 collision with other packages). gdcmPython/demo/*.py changed
2498 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2499 * python subdir moved to gdcmPython (preparation of distutils packaging).
2500 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2501 distutils installer is operational.
2502 * - gdcmPython/__init__.py now properly loads the swig generated
2503 shadow classes (from gdcm.py).
2504 - gdcmPython/demo/*.py changed to import the package gdcmPython
2505 instead of gdcmPython/demo/load.py.
2506 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2508 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2509 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2510 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2511 entries within the associated public Dicom dictionary resp. the same
2512 information but sorted by the fourth field (PAT, IMG, DIR) of the
2514 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2515 are now in the "???" group.
2516 - python/gdcm.i changed accordingly,
2517 - python/demo/printGroupedPublicDict.py added, that gives an example
2518 of the above new functionalities in Python.
2520 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2521 * src/gdcm.h, gdcmHeader.cxx:
2522 - historic references to glib's g_malloc and g_free (#defined)
2523 were definitively removed.
2524 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2525 * src/gdcmElValSet.cxx:
2526 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2527 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2528 - GetElValue(string) renamed to GetElValueByName.
2529 - Added GetElementByName(string).
2530 * src/gdcmHeader.cxx: added
2531 - GetPubElValRepByNumber(guint16, guint16)
2532 - GetPubElValRepByName(string)
2533 - GetShaElValRepByNumber(guint16, guint16)
2534 - GetShaElValRepByName(string)
2535 - GetShaElValByNumber(guint16, guint16)
2536 - GetShaElValRepByName(string)
2537 - GetElValRepByNumber(guint16, guint16)
2538 - GetElValRepByName(string)
2539 - GetElValByNumber(guint16, guint16)
2540 - GetElValRepByName(string)
2541 * Doc/requirements.txt added.
2543 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2544 * Test/Makefile building now depends on the one of libgdcm.so
2545 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2546 pixel data) aware which enables finding the address (offset) of
2547 the pixel data of JPEG encoded DICOM files. This leaves only a single
2548 file in the testSuite whose pixel data address (offset) is unknown.
2549 * python/testSuite.py changed accordingly.
2551 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2552 * VC++ has some strong limitations when working with the STL, as stated
2553 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2554 "Also note that some STL containers (map, set, queue, list, deque)
2555 cannot be exported. [...]
2556 Some STL classes contain nested classes. These classes can not
2558 This is caused by a designed limitation that once a template
2559 class is instantiated, it can not be re-instantiated and
2561 Since our usage of map<> is ubiquitous in gdcm, this "designed
2562 limitation" of VC++ is a pitfall.
2563 Hence the Python wrappers of gdcm cannot be incrementally linked
2564 against the c++ dynamic library. The dirty but only workaround is
2565 to forget about incremental link of dynamic libraries and to generate
2566 the Python wrappers library with the inclusions of the underlying C++
2568 The following modifications concern this matter on Win32/VC++:
2569 - wrapping python correct with standalone wrapped dll (don't use separate
2570 dll under windows !!!!)
2571 - python21_d debug mode enabled (ask Frog how to use it :-)
2572 - NO problem with having an STL member of class for example string in C++
2573 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2574 - Python test of dcmlib in Python is ok under windows on a large set
2576 * removed glib references
2577 * typedef's inserted in gdcm.i for correct swig type management
2579 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2580 * python/demo/*.py load.py extracted from test.py. Added explore.py
2581 that only displays required tags and testAll.py that parses all
2582 the files of the testsuite without using unittest.
2583 * python/testSuite.py other additional test on new files added.
2584 * Data/* new test files added accordingly to the testSuite.
2585 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2586 the vr in the file differs from the one of the dictionary.
2588 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2589 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2590 values, but limits itself to values which are below a user specified
2591 size (by default 1024 bytes).
2592 * python/gdcm.i : elements not loaded (because their size is above the
2593 user specified treshold) are exported with their TagKey as key of the
2594 python dictionary. This enables the testsuite to make some checks
2595 on the unloaded elements (since we have their offset and size).
2596 * python/testSuite.py
2597 - now tests for the existence and proper value of the pixel data
2598 - two new examples added.
2599 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2601 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2602 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2603 aware. See the strategy comments in gdcmHeader::FindeLength().
2604 * Test/test.cxx now accepts a filename as first argument.
2605 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2606 * python/testSuite.py changed to integrate test on above files.
2608 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2609 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2610 the vr was also RET.
2611 * python/testSuite.py more tests added.
2613 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2614 * python/testSuite.py unittest test suite added (uses Data)
2615 * Data/* dcm and acr files for the test suite.
2616 * glib dependance removed from un*x version. We now use ISO C99
2617 7.18 Integer types (see stdint.h)
2618 - python/Makefile, src/Makefile src/gdcm.h
2619 * src/ when an explicit vr (like dicom files) suddenly poped an
2620 implicit element we use to mark the underlying DictEntry of the
2621 concerned ElValue with "Implicit". This strategy was damageable
2622 too the public or provite dictionaries, since some of their vr
2623 would be changed. Since Header::FindLength heavily relies on the
2624 detection by Header::FindVR of falsely explicit elements, I
2625 added an extra ImplicitVr member to ElValue (boolean).
2626 The rest of the changes we the necessary adaptations.
2628 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2629 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2631 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2633 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2634 * Adaptation for porting to VC++:
2636 o forced to use std namespace (for string to be known)
2637 o all class use __declspec export style on WIN32
2638 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2639 (in stdlib.h on Win32 but in std:: for gcc)
2640 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2641 variable GDCM_DICT_PATH.
2642 * src/gdcmHeader.cxx verbose comments made discrete.
2644 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2645 * python/gdcm.i: added a typemap that converts a C++ hashing table
2646 to native Python dictionary.
2647 * python/demo/test.py:
2648 - now uses the native dictionary for exploration of gdcmHeader.
2649 - takes an optional filename argument (the file to parse).
2650 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2651 PubElVals hashing table.
2652 * Dicts/dicomV3.dic removed error prone trailing spaces.
2654 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2655 * Python wrapping process moved away from src/Makefile to
2656 newly created python/Makefile (as well as gdcm.i)
2657 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2658 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2659 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2660 from the environement variable GDCM_DICT_PATH (when existing).
2661 * src/gdcmDict::GetTag bug fix.
2663 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2664 * Straightforward temporary fixes for swig to build the python wrappers.
2665 src/Makefile now has a python working entry [by working we mean
2666 that we can import de shadow classes without errors].
2668 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2669 * hashtest.cxx removed (since allready in Test)
2670 * src/gdcmlib.h renamed to src/gdcm.h
2671 * src/dcm.i renamed to src/gdcm.i
2672 * src/Makefile prepared for python wrapping
2674 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2675 * src/gdcmHeader.cxx :
2676 - Parsing of header is now separated from loading of element values
2677 (see gdcmHeader::LoadElements).
2678 - general clean up of hopefully all file access (creation of
2679 ReadInt16 and ReadInt32)
2681 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2682 * src/gdcmHeader.cxx :
2683 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2685 - SetLgrElem renamed to SetLength
2686 - GetLgrElem renamed to GetLength
2687 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2688 * src/gdcmElValSet.cxx fixed both GetElValue methods
2689 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2690 due to IdoDude was cleaned out.
2692 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2693 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2694 concentrates on finding the value representation (when it exists).
2695 RecupLgr now only finds the element value length, and it avoids
2696 returning the unecessary skL (skipped length).
2697 Also, offsetCourant was simply removed (with taille_fich) since
2698 it was redundant with the File position internals (by using
2699 ftell and fseek). This also made skL (see above in RecupLgr) usage
2701 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2702 on the libido specificities which are handled through class
2704 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2707 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2708 * Truckload of changes. Parsing of header is barely functional
2709 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2711 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2712 * src/gdcmHeader.cxx many addons of low level methods
2714 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2715 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2716 and _IdDcmSWAP_LONG.
2718 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2719 * This corresponds to all the changes decided at the meeting of
2720 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob