1 2005-04-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Testing/TestAllReadCompareDicom.cxx : update the test printed results and
5 2005-04-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
6 * FIX : Numerical exception on borland (cannot divide by 0, doh !)
7 But this is a case where we should really signify the user there is
8 few chance the serie is really a serie...
10 2005-04-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * FIX : on X, the python part is correctly installed. All files are
12 installed in gdcm sub-directory
14 2005-04-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
15 * Builder/ : add something to facilitate the RPM creation of gdcm
17 2005-04-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
18 * Fix gdcmDirList::IsDirectory. Apparently borland did not like the ending
20 * Also fix compilation on gcc 3.3.5 does not have ios::failure either ...
22 2005-04-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
23 * vtk/vtkGdcmWriter fix bug when writing spacing. The Y spacing comes first
25 * Fix compilation on gcc 2.96 (which does not have ios::failure)
27 2005-04-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * src/gdcmDictGroupName.[h|cxx] : add a correlation between a group (number)
29 and it's representation name (for the NIH)
31 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
33 conversion of YBR to RGB pixels. So, now, the conversion is made using
36 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
37 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
38 format) to replace 'at-run' dicom files generated by the
39 TestAllReadCompareDicom test
41 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
42 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
44 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
45 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
47 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * Testing/TestMAkeIcon.cxx : complete the test
50 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
51 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memroy leaks
53 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
54 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
57 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
58 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
60 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
61 * Test/ : accelerate tests (it's not very significant accelerations).
62 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
64 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * Testing/TestSequence.cxx : add test for sequences of images... test that
66 we have the same serie or the same study UID
68 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
69 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
71 * src/gdcmDict.h : remove commented code
72 * src/gdcmDocument.cxx : initialize values
73 * src/gdcmFile.cxx : bug fix when reading values
74 * gdcmPython/demo/ : change file names. Remove useless files
76 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * src/gdcmFile.cxx : remove the default array of initialization.
78 The static array contained pointers to non-static values (comming from
79 strings). To have coherences, when creating files, these values can't be
80 static. So, the array can't be static, too ! To simplify, the array have
81 been replaced by repeted lines to insert values in the File
83 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
84 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
85 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
87 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
88 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
89 (Dicom Element) into the Sequence Item
91 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * src/*.cxx : first parss to normalize file organisation
94 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
95 * src/gdcmDirList.[h|cxx] : add method to find a directory
96 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
98 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
99 * Finish cleaning up my JPEG mess. Should be ok now.
100 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
101 contained within the RLE* class(doh!)
103 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
104 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
105 * SerieHeader::AddFileName() creates as many Coherent Files lists
106 (same Serie UID) as it founds different Serie UID
107 amongst the files instead of discarting any file
108 that doesn't match with the first one he found.
109 * SerieHeader::OrderGdcmFileList has now one parameter :
110 the Coherent Files list the user wants to sort
111 * SerieHeader::GetFirstCoherentFileList() |
112 * SerieHeader::GetLastCoherentFileList() | allow to parse
113 the set of Coherent Files lists
114 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
115 compatibility (it returns the *first* Coherent Files list,
116 since there was only one before)
117 * Test/TestSerieHeader gets gdcmData as a default root directory
119 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
120 * Remove friend between DocEntry and File classes
121 * Remove friend between PixelReadConverter and RLEFramesInfo,
124 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
125 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
126 0002|0000. The value was incorrect.
128 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
129 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
131 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
132 * src/gdcmUtil.cxx : compilation fix on Win32
133 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
134 variable, to be easy found. Add methods to change the default UID.
135 Amelioration of the CreateUniqueUID to use the correct default UID.
136 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
139 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
140 * Test/TestVR.cxx : fix memory leaks
142 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
143 * Rewrite the base 256 to base 10 conversion, using string operation only.
144 This allows us to get rid of the problematic 64bits integer type (does not
145 always exist on target platform).
147 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
148 * Add construct and destructor to class gdcm::Debug to close the debug file
150 * Don't let uset to open twice the same file
151 * gdcm has now an official UID prefix,
152 supplied by http://www.medicalconnections.co.uk
153 1.2.826.0.1.3680043.2.1143
154 (Thx to Mathieu for providing URL)
155 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
156 to be able to perform some more tests
157 * gdcm::ContentEntry : Contructors and Destructor are now protected,
158 in order to be sure no user will try to use them.
159 (at user level, only the children classes are meaningfull)
161 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
162 * move RLEInfo & JPEGInfo from Document to File
164 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
165 * FIX : remove so many friend between classes
167 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
168 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
169 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
171 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
172 In order to avoid missbehaviour :
173 . gdcm::DocEntry is now specialized in
174 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
175 - gdcm::ContentEntry (Dicom entry with a 'content')
176 . gdcm::ContentEntry is specialized in
177 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
178 characters value, or integers)
179 - gdcm::BinEntry (Dicom entry with a non strig representable value
180 (user hasn't any longer to thing about the precedence of his dynamic_casts)
182 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
183 * Test/VTKTest*.cxx : bug fix under linux
185 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
186 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
187 use with python. Some methods are moved from Document to ElementSet or
188 DocEntrySet. The equivalent methods to ElementSet have been added to
189 SQItem and are virtual in DocEntrySet. Methods that may have the same code
190 in SQItem and ElementSet is directly placed in DocEntrySet
192 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
193 * Test/VTKTest*.cxx : remove the show variable in each test method because
194 it's useless (the viewer variable replace this variable)
196 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
197 * src/gdcmDocument.cxx : bug fix on potential memory leak
198 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
199 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
200 Add ClearXxx methods to remove all the content of the list or map
201 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
203 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
204 * methods ReplaceOrCreate renamed as Insert
205 (nobody will be any longer confused by 'CreateOrReplace')
207 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
208 * Grealty simplify the JPEg decompression, no need to differenciate based on
209 the JPEG possible type (with/without fragment, with/without multiple frame).
210 Everything is done throught the JPEG IO Suspension mechanism in IJG
212 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
213 * Stage 3 of normalization :
214 in order to avoid any missunderstanding while reading method names :
215 - All the methods xxxEntry now deal with dicom Entries
216 - Methods GetEntry splitted into
219 - Method SetEntry renamed as SetEntryValue
220 - Method SetEntryBinArea let as it was
222 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
223 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
224 - Position correctly the entry points for JPEG2000 and JPEG-LS
225 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
227 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
228 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
229 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
230 with other method names
231 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
232 * Test/TestDicomDirElement.cxx : add new test
234 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
235 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
236 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
237 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
238 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
239 So can't you use __int64 in ostream at all.
241 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
242 * bug fix for compilation on MSVC6
243 * gdcmPython/gdcm.i : rename of classes missed
245 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
246 * Stage 2 of names normalization :
247 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
248 (easy to understand ...)
249 - gdcm::FileHelper replaces old class gdcm::File
251 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
252 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
253 type and not a string. So, there remove problems on the format of the
256 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
257 * Add Example/TestPapyrus.cxx
258 - reads a Papyrus file (gdcm::Header compliant),
259 - gets the pixels of all the images, using low level iterators
260 - writes an multiframes Dicom image.
261 (Just to show it's *possible* to do that)
262 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
265 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
266 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
267 Thus, DicomDirXXX are created with a flad that indicates if the created
268 object is empty or not (when not empty, the DicomDirElement is used to
271 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
272 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
273 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
275 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
276 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
278 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
279 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
280 Remove all access to the hash-tables or lists in the objects.
282 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
283 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
284 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
285 be complient with all the gdcm source code
287 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
288 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
291 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
292 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
295 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
296 * Test/ : rename VTK tests to have a best name for the tests
297 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
298 GetFirstEntry/GetNextEntry use
300 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
301 * In SerieHeader::ImagePositionPatientOrdering()
302 // a Dicom 'Serie' may contain scout views
303 // and images may have differents directions.
304 // -> More than one may have the same 'pos'
305 // Sorting has then NO meaning !
306 Thx to Eduardo Davila for reporting bug.
308 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
309 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
310 test. Now it's on image content and not on the resulting visualisation...
311 might solve the problem on linux when using the OpenGL drivers
313 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
314 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
315 DicomDirSerie, DicomDirImage
316 Dict, DictSet classes :
317 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
318 -remove InitTraversal method.
319 * UPD Test programs + Example programs
321 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
322 * remove useless and never updated keyword \ingroup
323 * Solve pb when structure (list, map, ...) is empty.
324 Thx to Benoit for reporting bug
326 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
327 * Taking into account of 'Transfer Syntax' value
328 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
331 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
332 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
333 is no memory access violation
334 * gdcmPython/demo : add python demos using VTK
336 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
337 * FIX 'Dictionnary' is now spelt 'Dictionary'
338 'wether' is now spelt 'whether'
339 'archieve' is now spelt 'archive' ;-)
341 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
342 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
343 related methods, in order not to expose internal mechanisms
346 * REM methods that exposed internal mechanisms :
347 DicomDir::GetDicomDirPatients()
348 DicomDirPatient::GetDicomDirStudies()
349 DicomDirStudy::GetDicomDirSeries()
350 DicomDirSerie::GetDicomDirImages()
351 * UPD Test programs :
355 * UPD Example program
357 * ADD DictSet methods
361 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
362 * Removed the Print/indent/default parameter mess. There is absolutely no
363 reason to have to methods, moreover with the second taking the ostream as
364 *SECOND* parameter. This was clearly a bad hack to get things compile.
366 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
367 * Complete rewrite of the GetMacAddress code. Now the code is *much*
368 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
369 Unfortunately the main code does not work on SunOS, thus provide a specific
370 code for this platform only (and Win32 of course). Since this seems to be
371 working, change CreateUniqueUID to use GetMACAddress instead of the
372 problematic GctestetIPAddress
374 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
375 * Unfortunately to be able to test gdcmDirList I had to break the API
376 a little. Now the class is not a std::list anymore but has a member
377 std::vector (more ITK compatible). Allow unit testing on Win32 and
380 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
381 * Update SerieHeader to take into account a Serie Instance UID to properly
384 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
385 * ENH - Comment out Mathieu's (dangerous) Super Hack
386 for dealing with BIGENDIAN processors
387 - Move equivalent stuff to BinEntry::WriteContent
388 When necessary, 16 Bits Pixels are swapped in a small buffer
389 and then written. This avoid allocating a huge buffer, in
390 PixelWriteConvertor, and avoid modifying the Pixel Area.
392 Probabely, the same operation will have to be done when we want
393 to write image with Big Endian Transfert Syntax,
394 and we are working on Little Endian Processor
396 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
397 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
399 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
400 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
401 all the dict content.
402 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
404 * Test/TestDict.cxx : add a new test for the dict classes
406 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
407 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
408 file. Debug is yanked if compiled with NDEBUG
410 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
411 * src/gdcmDictSet.h : set the default output to the os variable
412 * src/gdcmDictEntry.[h|cxx] : add the Print method
413 * gdcmPython/demo/ : add a new test
415 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
416 * merging of Test/PrintDicomDir and Test/TestDicomDir
417 * removal of now redundant Test/PrintDicomDir
418 * enhancement of Example/PrintDicomDir
420 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
421 * Now, python test might work on systems
422 * Add the PrintDicomDir test
424 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
425 * FIX : First entry following group 0002 was lost for
426 Explicit Big Endian Transfer Syntax files
427 (group and elem not swaped)
429 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
430 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
431 Big Endian Transfer Syntax supposed the group following 0002
432 begins always by element 0000 (element 0000 is *optional*)
433 To avoid further troubles, let's be pessimistic, and use
434 Document::HandleOutOfGroup0002() method
435 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
436 (related pb not yet solved)
438 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
439 * Bug fix for the python part use
440 * Now, PrintHeader.py pass... but outside the ctest use. shit !
442 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
443 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
445 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
446 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
447 a string and should ask the global TS dict what are the propreties of
450 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
451 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
452 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
453 to swap the Swap Code, at parsing time, when we come out of group 0002
454 and Transfer Syntax is Big Endian
455 We should be able to read now 'true DICOM" Big Endian coded images
456 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
457 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
459 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
460 * Hopefully fix the bug on MacOSX and static global initialization.
461 This is the only -minor- patch I found that both please MacOSX and VS6.
462 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
463 but this would require a lot of change. Another approach would be that Global
464 create those string and GDCM_UNFOUND becomes a pointer to a string (which
465 gdcm::Global would destroy at exit).
467 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
468 * Fix bug on MacOSX with static initialization in a multy threaded
469 environment. static const string in a header file used to be ill
470 initialized provoquing the freeze of any tests. patch should solve this
473 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
474 * According to Benoit's suggestion, and without any objection from anybody
475 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
476 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
477 - method gdcmDicomDirObject::GetEntry() renamed as
478 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
480 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
481 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
482 you debug/warning message just as c++ streams which make them very convinient
483 to use. Once this is stabilize I will change the ostringstrem to be
484 redirected to a file (ofstream).
485 * Properly support C99 extension: __FUNCTION__ which allow us to display
486 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
488 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
489 * Removal of useless and dangerous methods :
490 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
491 GetDocEntryByName, GetEntryByName, GetDictEntryByName
492 * Removal of usless methods :
493 Dict::PrintByName, Dict::GetDictEntryByName
494 * Commenting out of probabely useless methods :
495 Dict::GetDictEntryNames()
496 Dict::GetDictEntryNamesByCategory()
497 DictSet::GetPubDictEntryNames()
498 DictSet::GetPubDictEntryNamesByCategory()
499 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
500 * ENH : Use dicomTS.dic as described in 2004 version
501 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
502 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
503 Add Accessors on VM (Value Multiplicity), and VM related methods
504 * ADD : Add a list of 'Dicom Attribute types', as found in
505 http://medical.nema.org/dicom/2004/04_15PU.PDF
507 * ADD : Add dicomGroupNameAbbreviations.dic
508 should be used to write a method to replace the former
509 Dict::GetDictEntryNamesByCategory()
511 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
512 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
513 to read in the file... and only it ! Length is the efective length of the
514 data in the DocEntry structure
516 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
517 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
518 And now use a static function call instead, with a global variable. i
519 This is much closer to the VTK approach. Hopefully should be bulletproof
520 and easier to use...hopefully
522 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
523 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
525 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
526 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
528 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
529 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
530 ValEntry, BinEntry, SeqEntry creation or replace
532 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
533 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
534 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
536 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
537 when specifying the VR
538 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
539 * src/gdcmDocEntry.cxx : amelioration of print
541 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
542 * ADD : Add the method Util::IsCurrentProcessorBigEndian
543 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
544 * ADD Method Document::ComputeGroupLength
545 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
546 in order to allow further VR modification by user
547 * REM : removal of once-called method File::WriteBase
548 integration of its code in formerly one-line method File::Write
550 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
551 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
552 replace the different values "??", "Unkn", "Unknown".
553 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
554 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
555 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
556 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
558 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
559 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
561 * Set the gdcm::Base class to some Printable classes
563 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
564 * src/gdcmFile.[h|cxx] : add the Print method
565 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
566 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
567 * src/gdcmDocument.h : remove the PrintLevel informations
568 * Example/PrintFile.cxx : use the new gdcm::File::Print
570 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
571 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
572 problems when compiling with the python wrapping
574 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
575 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
576 writting in ImplicitVR
578 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
579 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
580 JPEG decompression, especially when dicom frames are split into several
581 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
582 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
584 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
585 * src/gdcmHeader.cxx : change the initialisation of default header.
586 Now, this header is readable by gdm, e-film, DicomWorks
588 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
589 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
590 Rename Decompressed to Raw
591 * Use the API changes in gdcm::File.
592 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
595 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
596 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
597 each added entry in the header. Replace the 'Planes' field by the 'Number
600 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
601 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
602 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
604 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
605 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
606 At this time, this image isn't readable by e-film... waiting JPR help to
609 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
610 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
611 DocEntry. Now use methods of the Document !
613 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
614 * Test/ShowDicomSeq.cxx : bug fix
616 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
617 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
618 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
619 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
620 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
622 * Test/TestCopyRescaleDicom.cxx : remove unused variable
623 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
624 containing found sequences
626 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
627 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
629 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
630 Some fields in BinEntry must be copied to not seg fault when making the :
631 gdcm::File *copy = new gdcm::File( copyH );
632 and tests are now made on good variables
634 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
635 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
636 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
638 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
639 * Add vtkGdcmWriter example and test
641 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
642 * Test/TestUtil.cxx : reformat the source code
643 * vtk/vtkGdcmReader.cxx : remove and change prints
644 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
646 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
647 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
649 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
650 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
651 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
653 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
654 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
655 by an eof to prevent all bad read of the file... and in this case, the
658 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
659 * Example/Volume2Dicom.cxx : comment unused variables
660 * Test/PrintDicomDir.cxx : comment unused variables
661 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
662 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
663 method that is redondant with AddEntry.
664 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
667 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
668 * Bug fix due my last commit (compilation under Windows).
669 * Example/Volume2Dicom : bug fix in the file and reformatting source code
670 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
672 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
674 - Remove printf / sprintf
675 - include iostream AFTER gdcm so we don't get warnings
676 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
678 - Also remove tons of include from header files, hopefully this should
679 speeup the compilation time, since it was becoming a dog slow.
680 - Remove gdcm.h as it include way too many files and slow down compilation
681 (plus it is not up to date)
682 - remove 'using namespace std' this is BAD !
684 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
685 * Remove memory leaks on the DicomDir
686 * Remove some useless data in DicomDirObject
687 * Add usefull methods in SQItem, to be complient withe the ElementSet
689 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
690 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
692 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
693 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
694 future, with convertion)
695 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
696 and ImageDataSize values. Remove the method to get the PixelReadConverter
697 from the output of the class
699 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
700 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
702 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
703 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
704 and vtkErrorMacro use.
705 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
707 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
708 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
710 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
711 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
712 The string leaves only in the fonction. So when we make a .c_str(), we
713 get the pointeur on the first element, element that will be destroyed
714 immediately after thee instruction.
715 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
716 file has been opened : the test must be made on the content of the
717 pointer and not directly on the pointer !
720 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
721 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
722 the python part recompiles
724 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
725 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
726 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
727 X session is killed (for my computer... it seems to not be identic on
730 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
731 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
732 avoid problems (otherwise, the difference test between the visible image
733 and the reference is incorrect. If the reference is greater than the
734 screen resolution, it's produce errors).
735 Can be used for only one image. Can be used with a visible flag.
736 * vtk/vtkGdcmReader.cxx : remove commented codes.
737 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
738 under windows at compilation
739 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
741 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
743 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
744 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
745 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
746 tests on the image size X, Y, Z
748 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
749 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
750 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
751 between the class name and the file name
753 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
754 * src/ : fix compilation warnings for the Write method (2 different
755 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
756 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
757 variable... create a static method in gdcm::Document to access to
758 this variable content.
760 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
761 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
762 file, to be accessed by other files (like gdcmFile). Remove commented
763 code. Move the change of the header to the gdcmFile, using the
765 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
766 To be sure of that (and simplify calls), the Write of the header now
767 gets a file name and not a file pointer (std::ifstream).
768 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
769 DocEntryArchive. Remove all open of the written file
771 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
772 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
774 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
775 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
776 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
778 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
779 some corresponding methods. Write correctly the file and check before
781 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
782 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
783 is now on RGB data (as before my last commit
784 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
786 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
787 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
788 Add a print information of the type of the entry
789 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
790 It was in the gdcmFile, and all write have been regrouped
791 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
792 Write correctly all dicom files (in decompressed mode only at this time)
793 * Test/ : test on files are now made using Raw data and not color data if
795 * Example/PrintFile.cxx : add more printings
797 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
798 * Amelioration of code, remove some code copy. For the loading of
799 BinEntry (in gdcmDocument), add the test to verify if the file is already
802 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
803 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
804 remove a DocEntry in the header (push an empty DocEntry)
805 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
806 lines. Bug fix in the initialization of the PixelConvert and the
808 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
809 use in TestCopyDicom (now this test can run under windows... but fails)
810 * Test/TestCopyDicom.cxx : amelioration of the test :
811 - test the pixels written
812 - add test points to quickly find where is the error
813 - can set a file name input and output in arguments
814 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
815 amelioration of the test output
817 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
818 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
819 all replaced DocEntry's
820 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
821 Now, each needed DocEntry to modify is duplicated, modified and inserted
822 to the header using DocEntryArchive. Thus, after save, we can restore the
823 header initial state.
825 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
826 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
828 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
829 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
830 correct to copy it. The DictEntry is specified at the DocEntry creation,
831 then, it musn't change in the time.
832 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
833 header correctly. At this time, the change is only made for the first
834 level of the Document. In the future, it might consider sequences.
835 The change is made by replacing a DocEntry by an other that is created
836 outside the class. The old value is kept. When we restore the header
837 status, the added DocEntry is deleted and replaced by the old value.
838 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
839 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
840 set the write type to explicit VR, implicit VR or ACR. Add methods to set
841 the write mode to native, decompressed or RGB (but not used at this time)
843 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
844 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
845 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
847 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
848 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
849 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
851 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
852 set because already copied when copying the BinEntry's of the header
853 * Test/TestAllReadCompareDicom.cxx : remove warnings
855 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
856 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
857 Two problems appear when doing it :
858 - with the gdcmFile : when the GetImageData method is called, the pixels
859 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
860 data (pixels). And each structure destruct the data when it's
861 destructed. So we have two destructions for the same data. To solve it,
862 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
863 data or not. If it doesn't own data, then they will not destroyed by
865 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
866 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
867 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
868 create a double destruction of the same DocEntry's. So, to solve it,
869 the TagHT is simply cleared and the DicomDir* elements are destroyed.
870 * TODO : add an entry concerning memory leaks in the DicomDir
872 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
873 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
874 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
877 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
878 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
879 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
880 after it have been deleted
882 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
883 * FIX: src/* fix the doxygen warnings.
884 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
885 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
886 was erroneously defined with a size of 15 instead of 16. [many thanks
887 to Jean Michel Rouet for pointing out this bug].
889 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
890 1. Finish merging JMR patch for writting DICOM from scratch
891 2. Fix -hopefully- bug with MONOCHROME and space vs null character
892 3. Use const ref when possible
893 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
894 5. A few more comments
895 6. CreateUniqueUID can now be called without parameter"
897 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
898 * ENH: Slightly bigger patch:
899 1. Getting toward full integration of JMR patch for writting dicom from scratch
900 2. Update Test to test part of this patch: CreateUniqueUID
901 3. File was not close properly in gdcmDict
902 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
903 5. Use of const ref instead of copy (speed issue)
904 6. Remove temporary (duplicate) string in TranslateToKey
905 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
906 8. Do not repeat virtual in subclasses
907 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
909 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
910 * Apply first patch toward better string comparison when dealing with broken
911 DICOM files. Essentially the string could be padded with a space instead
912 of a null character as defined by standard
914 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
915 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
916 because never used... and in the same time, that's remove some memory leaks
918 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
919 * src/gdcmFile.cxx : now delete the PixelConvert instance.
920 * In examples and tests : change the type of image data variables from void*
921 to uint8_t*. Remmove all delete on image data variables
923 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
924 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
925 Verify the file pointer value before open the file, and if it's not null,
926 a verbose message is generated.
927 Close correctly the file when the file isn't considered dicom-like. The
928 correctly close is a call to CloseFile.
929 When closing the file pointer, test if its not null to close the file.
930 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
931 file. For an uncompressed image, the copied data correspond in the least
932 case to the image size (calculated) or the image size specified in the
933 header. A verbose is generated if these two size mismatch
935 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
936 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
937 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
938 break under windows (with msvc6 compilation).
940 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
941 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
942 compiling with MSVC6)
944 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
945 * Bugs fix for the Windows build with VC6
946 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
947 needed (only for projects required VTK). If the VTK is included in all
948 projects, there is conflicts with the jpeg lib of vtk when compiling the
949 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
950 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
951 when compiling the gdcm_wrap.cxx file (created by the compilation of the
953 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
954 (like it's already made for the cout use). Otherwise, conflict with the
957 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
958 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
960 - comments on the DicomDir::Method related usage added.
961 - now that we use the namespace gdcm, a lot of internal classes do
962 NOT need to be wrapped anymore.
963 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
964 DicomDir::Method) new example added.
966 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
967 * Improve string manipulation. I now inforce the notion of 'DicomString'
968 A DicomString can contain as many \0 as they want
969 and it is *always* of even length.
970 We only support odd length for very rare case.
971 And in the near future this should be removed.
973 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
974 * /binary_write/ gdcm source. Now even on big endian we are writting
975 little endian. This should -heopfully- fix some tests
977 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
978 * Now the dictionary is compiled into gdcm lib. This is a default
979 behavior, thus any dic file specified is picked before failback to
980 the one comiled into lib
982 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
983 * Change internals for gdcmDict. Don't use any 'new' any more.
984 This should definitely solve any leak problem, and we should be
985 as fast as before, as long as don't modify too much the dictionary.
987 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
988 * STYLE: ivars should start with a capital letter.
989 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
990 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
992 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
993 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
994 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
995 new 2004 dictionaries added (thanks to JPR).
996 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
997 * CLEANUP_ROUND (15) for gdcmPixelConvert
998 - RLEFrame::NumberFragments is now of type unsigned int
999 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
1000 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
1003 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1004 * Initial work in gathering all transfer syntax accessors. clearly
1005 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
1006 ivars, but only one transfersyntax (class) ivar with equivalent method on
1009 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1010 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
1011 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
1012 discussed (plus I didn't like having a 2000 lines patch not commited)
1014 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1015 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
1016 * CLEANUP_ROUND (14) for gdcmPixelConvert
1017 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
1018 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
1019 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
1020 CloseFile() anymore.
1021 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
1022 anymore and hence avoids storing a copy of PixelConvert::Decompressed
1023 into File::Pixel_Data.
1025 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1026 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
1027 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
1028 * CLEANUP_ROUND (13) for gdcmPixelConvert
1029 Substituted File::ParsePixelData() with PixelConvert::Print() new
1031 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1032 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1033 method to those classes.
1034 - src/gdcmFile.[cxx|h]:
1035 -- Added a ::Print() method.
1036 -- PixelConverter is now a reference instead of a member.
1037 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1038 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1040 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1041 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1042 collaboration diagram and inheritance diagram should be generated with
1044 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1045 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1046 pointlessly wrapped (see
1047 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1048 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1049 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1050 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1051 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1052 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1053 -- File::Initialise: PixelConverter setup moved away to
1054 PixelConverter::GrabInformationsFromHeader()
1055 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1056 interpretation moved away to PixelConverter::BuildRGBImage()
1058 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1059 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1060 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1062 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1063 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1064 displayed on Win32 when a brutal abort() occurs (because of uncatched
1065 exception). See TODO new entry of this commit for more on this.
1066 * TODO added new entry.
1067 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1068 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1069 - HandleColor is no longer called from gdcmFile.cxx
1070 - gdcmPixelConvert.cxx clean up on method arguments and internal
1071 variable names for semantical coherence.
1073 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1074 * Finished lossless transition, not only do we now read all lossless jpeg
1075 images, without the need of the Cornwell lib, but we do read them properly now
1076 * To reduce code (well to avoid code duplication), I defined a common place
1077 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1078 redefine symbols. This is not perfect but this the best solution I found for a
1079 compilation time jpeg option.
1081 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1082 * Update jpeg ijg lib to support lossless jpeg implementation
1083 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1085 * Also added a special copyright for dcmtk since we use their bugfixes.
1088 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1089 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1090 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1091 matters, as stated in warning note at beginning of %include section).
1092 * src/gdcmDicomDir*.[cxx|h]: coding style
1093 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1094 * src/gdcmJpeg8.cxx: doxygen fix.
1095 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1096 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1097 from File:: to PixelConvert::.
1099 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1100 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1101 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1102 - more code moved away from File:: to PixelConvert::
1103 - fat setup of PixelConverter set in place in File::Initialise.
1105 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1106 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1107 namespace at the file system level. So now you should convert your examples
1109 gdcmHeader -> gdcm::Header
1110 It would be nice if people keep in mind to no open the namespace, since it
1111 allows compilation on broken plateform which were defining common symbol in
1112 the standart namespace (like LP, Unknown ...)
1114 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1115 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1116 The JPEG fragments are now parsed at the same stage than the RLE
1117 information. All code related to JPEG is now in gdcmPixelConvert:
1118 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1119 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1120 export a gdcmFile:: method. Those are simply global functions
1121 (for the time being this is better than having them attach to
1122 either gdcmFile:: or gdcmPixelConvert::).
1123 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1124 and stores the result in a gdcmJPEGFragmentsInfo.
1125 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1126 code (among other stuff) moved away from gdcmFile:; to
1129 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1130 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1131 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1132 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1133 clean up of RLE related code.
1134 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1135 - src/gdcmRLE.cxx removed
1136 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1137 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1138 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1139 * CLEANUP_ROUND (9) for gdcmPixelConvert
1140 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1141 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1142 away from gdcmFile:: to gdcmPixelConvert::.
1144 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1145 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1146 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1147 This is because Parse7Fe0 used to parse the pixels to compute the
1148 length. This task was passed over to FindDocEntryLengthOB() a long
1149 time ago, EXCEPT I had forgotten the OW case...
1150 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1151 we just recylce the code for parsing RLE fragments and computing
1153 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1154 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1155 with the retired Parse7Fe0().
1156 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1157 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1159 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1160 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1161 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1162 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1163 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1164 * CLEANUP_ROUND (4) for gdcmPixelConvert
1165 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1166 to return an unused length.
1168 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1169 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1170 this should be cleanner from the plane view. The iostream are erally a pain
1171 to use to do simple stuff.
1173 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1174 * Redo the compilation of the ijg jpeg library. Now only one source is
1175 necesseray. No need to rename file by hand what so ever. CMake handle the
1176 copying of the file within different directory, configure header file to
1177 modify some symbol. The only addition made to ijg wasd a mangle table so
1178 that symbol are different whether we are within 8bits or 12bits.
1180 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1181 * Added documentation of vtkgdcmReader on Website:
1182 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1183 with it's binary name).
1184 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1185 the Website to be more complete.
1186 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1187 doxygenated documentation.
1188 - Doc/DoxyVtkGdcmReaderExamples.txt added
1189 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1190 DoxyVtkGdmReaderExamples.html )
1191 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1192 * CLEANUP_ROUND (3) for gdcmPixelConvert
1193 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1195 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1196 * CLEANUP_ROUND (2) for gdcmPixelConvert
1197 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1199 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1200 * CLEANUP_ROUND for gdcmPixelConvert:
1201 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1202 - src/gdcmPixelStuff[h|cxx] removed
1203 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1204 - src/CMakeLists.txt changed accordingly
1205 * GDCMHOME clean up:
1206 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1207 gdcmVersion.py moved to newly created ATTIC related
1208 gdcmPython/SetupOldies/ directory.
1209 * Autotools clean up:
1210 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1211 - autogen.sh configure.in acinclude.m4 python.m4 removed
1213 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1214 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1215 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1216 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1218 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1219 * TODO updated with Mathieu suggestions. I proposed a template for
1220 describing TODO entries and used it for new entries.
1221 * Added Doc/Website/CodingStyle.html, Developpers.html,
1222 DeveloppersPython.html, GdcmDataCvs.html and
1223 DownloadVersion0_1.html, DownloadVersion0_3.html.
1224 * Some Doc/*.txt Doxygen files (which do not really concern the
1225 documentation itself, but the website) moved to html and
1226 placed in directory Doc/Website:
1227 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1228 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1229 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1230 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1231 * CMakeLists.txt changed accordingly.
1232 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1233 DeveloppersPython.html
1234 * INSTALL nows refers to Doc/Website/Installation.html
1236 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1237 * Added Doc/Website directory, that contains a first raw version
1240 2004-09-23 Jean-Pierre Roux
1241 * FIX In order not to be poluted any longer by casting problems,
1242 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1243 we can now delete[] it safely
1244 * VoidArea is now called BinArea (less confusing name),
1245 and all the methods called ...VoidArea... are now ... BinArea...
1246 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1248 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1249 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1250 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1251 up to the destructor of gdcmElementSet to clean up TagHt and it's
1254 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1255 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1256 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1258 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1259 * ENH: added some utility method that builds a flat dictionary
1260 holding all the Dicom entries contained in the recursive structure
1261 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1262 an example of usage.
1263 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1264 BuildFlatHashTable() that build a flat dictionary.
1265 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1266 gdcmDocument is now a friend of gdcmElementSet.
1267 - src/gdcmElementSet.cxx: clean up.
1268 - Example/FlatHashTablePrint.cxx added.
1269 - Example/CmakeLists.txt changed accordingly
1271 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1272 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1273 moved away from gdcmDocEntrySet (since this class is an abstract class
1274 acting like an interface). SQDepthLevel and BaseTagKey are now
1276 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1277 and associated accessors. Doxygenation of the class.
1278 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1280 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1281 Use SQDepthLevel accessor instead. ::Print() adapted.
1282 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1283 - src/gdcmDocument.cxx changed accordingly.
1285 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1286 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1287 - The following is the doxygen comment of the typedef declaration
1288 of gdcmTagKey in src/gdcmCommon.h:
1289 gdcmTagKey is made to old an "universal" (as in URL, Universal
1290 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1291 A dicom tag always has a group and an element, but a set of tags
1292 embeded in various (optionally nested) sequences and sharing
1293 the same group and element all share the same (group, element)
1294 "identifier". Hence the (group, element) cannot be used as an
1295 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1296 In order to construct a proper tag identifier (i.e. a key) we
1297 consider the following definition of a TagKey:
1298 - let Group, Element be the string representation of the
1299 group and element dicom tag members,
1300 - let ItemNumber be the string representation of the integer
1301 index of the considered item number of a sequence,
1302 Let the key of a tag embeded in a sequence, noted SeqTag, be
1304 /ItemNumber#Group|Element
1305 where "/", "#" and "|" are characters acting as separators.
1306 Then the general form of a gdcmTagKey is given by:
1307 Group|Element<SeqTag>
1308 where <SeqTag> means NO or many instances of SeqTag.
1309 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1312 but the gdcmTagKey of a tag "embeded" is the first item of
1313 a sequence, itself nested in the third item of a sequence is the
1315 0004|1220/2#0008|0082/0#0008|0090
1316 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1317 order to hold the new sequence compatible key. Previously, the
1318 GetKey() method would look in the underlying gdcmDictEntry.
1319 - src/gdcmDocEntry.cxx:
1320 -- constructor now copies the underlying DictEntry key, in the local
1322 -- ::Print: displays the member Key, instead of the (group, element).
1323 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1324 - src/gdcmDocEntrySet.h:xi
1325 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1326 -- now has a new BaseTagKey member.
1328 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1329 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1331 This poses the problem with the semantics of the following lines
1332 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1333 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1334 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1335 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1336 to the long FIXME note for what the problem is. Nevertheless in
1337 order to get things working the dicom dictionary was altered !
1338 Please fix things urgently...
1339 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1340 information), see above note on moving the member VoidArea. Nevertheless
1341 the following entries previously correctly set as US are now inproperly
1343 0028 1201 OW IMG Red Palette Color Lookup Table Data
1344 0028 1202 OW IMG Green Palette Color Lookup Table Data
1345 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1346 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1347 of gdcmDocEntry moved to gdcmSeqEntry.
1348 * src/gdcmSeqEntry.cxx: STYLE.
1350 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1351 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1353 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1354 * gdcmPython/testSuite.py: all the test suite in python is now moved
1355 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1356 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1357 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1359 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1360 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1361 to avoid inclusion recursion until STL is reached.
1362 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1363 mecanism. errno.h is not included in gdcm anymore.
1364 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1365 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1367 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1368 gdcmData/TestAllEntryVerifyReference.txt
1369 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1370 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1371 exception_on_error parameter.
1372 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1373 - vtk/vtkGdcmReader.cxx changed accordingly,
1374 - Example/*.cxx and Test/*.cxx changed accordingly.
1376 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1377 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1378 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1379 enable_sequences removed from gdcmHeader constructor and dependencies.
1380 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1381 * gdcmPython/demo/PrintHeader.py: dummy fix.
1382 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1383 skip_shadow removed from gdcmHeader constructor and dependencies.
1384 * Example/*.cxx and Test/*.cxx changed accordingly.
1386 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1387 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1388 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1390 2004-07-21 Jean-Pierre Roux
1391 * FIX Now, Parsing and Printing a DICOMDIR do work!
1392 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1394 2004-07-20 Jean-Pierre Roux
1395 * FIX Some brain damaged headers have Zero-Lenght fields
1396 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1398 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1399 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1400 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1401 variable (instance of gdcmDebug) by a definition macro, and the instance
1402 is now in static in the gdcmDebug class
1403 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1404 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1406 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1407 * WARNING: ctest now depends more tightly on gdcmData. You should
1408 check out gdcmData properly for things to run smoothly...
1409 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1410 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1411 we need the pixels not be loaded in order to use the ValEntry
1412 that displays position and size).
1413 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1414 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1415 be deprecated. If you have any doubts about the advantages of a
1416 modern scripting language (read Python) versus grass root C++ (i.e.
1417 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1418 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1419 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1420 Anyhow, consider documenting the gdcmData images in
1421 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1423 * Test/CMakeLists.txt:
1424 - now uses TestAllEntryVerify.cxx
1425 - specific comments on oldACR00001.ima (now renamed in gdcmData
1426 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1427 gdcmData/TestAllEntryVerifyReference.txt
1430 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1431 * src/*.[h|cxx] : typedef clean up
1432 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1433 - TagKey renamed to gdcmTagKey (for external usage)
1434 - VRKey renamed to gdcmVRKey (for external usage)
1435 - removal of typedef duplication.
1436 - Removed all unecessary inline keyword from class inline definitions.
1437 - Some method|function(void) declarations replaced with method|function().
1438 * src/jpeg/libijg12/jdhuff12.c:
1439 - printf polluting ctest removed.
1440 - TAB removal for comminting
1442 - TestAllReadCompareDicom.cxx: added a test that compares all the
1443 images in gdcmDataImages.h with corresponding images in
1444 gdcmData/BaselineDicom/. When baseline images are not present
1445 this test creates them.
1446 Note: we need to validate each reference image, but before that
1447 I'd like to rename them with a more explicit name...
1448 - CMakeLists.txt: changed accordingly.
1449 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1450 including each header needed).
1452 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1453 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1454 test suite to the Example directory. Are concerned:
1459 - TestWriteSimple.cxx
1460 * Test/CMakeLists.txt: added some comments on reasons for black listing
1461 image gdcmData/oldACR00001.ima
1463 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1464 * Test/CmakeList.txt: removed the following from black list (to be coherent
1465 with removal from gdcmData):
1466 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1467 - gdcm-MR-PHILIPS-16.dcm
1469 Added the following because after last cvs update, they cause
1470 ctest -R TestReadWriteReadCompare
1472 - gdcm-MR-SIEMENS-16-1.acr
1474 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1475 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1476 new comments in this file) we temporarily (sigh) move to a weaker
1478 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1479 we don't need to black list the following images anymore:
1480 - 8BitsUncompressedColor.dcm
1482 - US-PAL-8-10x-echo.dcm
1483 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1484 fixes and the beautified code ;-)
1485 This fixes the bug introduced in version 1.42 (when beautifying)
1486 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1487 Note: ctest was blind to this bug (this means we need to still
1488 improve the test suite). The bug could be detected by using
1489 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1491 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1492 and by displaying the (garbage) produced file temp.XDCM...
1494 2004-06-29 Jean-Pierre Roux
1495 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1496 - replace by uggly but working old code :-(
1497 A lot of things should be OK again.
1498 It's really urgent to have a test suite that *tests*,
1499 to prevent Frog's beautifying sessions to break all the stuff
1500 (twice, withing a fortnigh ...)
1502 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1503 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1504 redundancy) to added Test/TestReadWriteReadCompare.cxx
1505 * Test/CmakeList.txt: because the compare test of
1506 Test/TestReadWriteReadCompare.cxx fails, the following images are
1507 black listed: - 8BitsUncompressedColor.dcm
1509 - US-PAL-8-10x-echo.dcm
1510 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1511 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1512 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1513 and ad-hoc kludge. This kludge is now removed, and on encountering
1514 such an image (OB field brain damaged) we set errno. Then in
1515 ::FindDocLength() we "fix" the length as being ALL what remains
1516 in the file (until EOF). We then proceed, hoping for the best...
1517 This fixes a SegFault in ShowDicom when trying to write such an
1519 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1520 (because TestWriteRead breaks on it, after a non conformal commit?).
1521 ctest now runs properly, except for MakeDicomDir (which was always
1522 broken) and the Python related stuff (still not fixed).
1524 2004-06-24 Jean-Pierre Roux
1525 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1526 FIX : Test/TestReadWrite now iterates on all the file names
1527 (instead of infinite loop)
1528 ENH : Test/TestWriteRead now iterates on all the file names
1530 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1531 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1533 2004-06-24 Jean-Pierre Roux
1534 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1535 when SamplesPerPixel =3
1536 - now Write is no longer confused by
1537 'BitsAllocated = 12" and 'BitsStored=12"
1538 - "UN" value representation Elements are now written correctly
1539 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1540 ENH : - now gdcmHeader has its own Write methods
1541 (in order to split the job that has not to be done
1544 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1545 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1546 loop on the same image until memory went out.
1547 Note: this means we still have gobs of memory loss in PrintDocument
1548 * src/gdcmDocument.cxx: fixes problem on parsing on file
1549 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1551 2004-06-24 Jean-Pierre Roux
1552 FIX : Write - All the Sequences and Sequence Item are now written
1553 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1554 is added a the end, when necessary.
1555 - A lot of brain-damaged images, that were read correctly are
1556 now written correctly
1557 - length compatible BinEntry are now loaded correctly
1558 (even for odd groups)
1559 Note : only Explicit Value Representation was checked.
1560 (question : is implicit VR really necessary for gdcm ?)
1562 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1563 * DEVELOPPER: added a proposition of coding style.
1564 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1567 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1568 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1569 Use the gdcmDocEntry::Print() and Write() instead.
1570 * src/gdcmDocument.cxx: bug fix.
1572 2004-06-22 Jean-Pierre Roux
1573 FIX : gdcmDocument.cxx
1574 - Now we do recognize the JpegLossLess format (there was a misstyping in
1575 code 'beautyfication' :-(
1576 - Now we automaticaticaly load the Luts, if any
1578 2004-06-22 Jean-Pierre Roux
1579 In order : to write Sequences, whatever their imbrication level,
1580 : to allow user to create his own Sequences
1581 a lot of modif where necessary (adding, moving, or virtualising methods)
1583 WARNING : save your own sources *before* cvs up !
1586 ADD virtual void Write(FILE *fp, FileType filetype);
1589 ADD virtual void Write(FILE *fp, FileType filetype);
1590 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1593 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1594 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1595 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1596 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1597 ADD std::string GetEntryByName(TagName name);
1598 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1600 std::string vr = "unkn",
1601 std::string fourth = "unkn",
1602 std::string name = "unkn");
1603 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1604 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1605 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1606 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1607 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1608 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1609 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1610 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1613 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1614 ADD virtual std::string GetEntryByName (TagName tagName);
1615 ADD virtual std::string GetEntryVRByName (TagName tagName);
1616 REM virtual bool Write(FILE *, FileType);
1617 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1618 FILE *_fp, FileType type);
1619 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1620 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1621 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1622 REM virtual std::string GetEntryByName (std::string tagName);
1623 REM virtual std::string GetEntryVRByName (std::string tagName);
1624 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1625 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1626 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1628 std::string vr = "unkn",
1629 std::string fourth = "unkn",
1630 std::string name = "unkn");
1631 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1632 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1633 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1634 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1637 ADD virtual void Write(FILE *fp, FileType filetype);
1640 ADD virtual void Write(FILE *fp,FileType filetype);
1643 ADD virtual void Write(FILE *fp, FileType filetype);
1644 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1645 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1646 REM std::string GetEntryByName(TagName name);
1649 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1651 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1652 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1653 The default constructor invoked by the line
1654 gdcmHeader *f1 = new gdcmHeader( header );
1655 was gdcmHeader::gdcmHeader(bool) instead of the expected
1656 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1657 Hence the parsing wasn't executed... See also below.
1658 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1659 as explicit constructor didn't do the trick to fix the above problem.
1660 Could anyone explain why ?
1661 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1662 properly calls gdcmValEntry::Print() (that was weed out from
1663 code related to gdcmBinEntry).
1665 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1666 * In order to fix memory leaks:
1667 - Test/TestWriteSimple.cxx: added cleaning of free store through
1669 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1670 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1671 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1672 (through the call to ::AddDicomDirMeta()) or the destructor
1673 would crash when deleting uninitialized ::metaElems].
1674 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1675 - src/gdcmDocument.cxx:
1676 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1677 from dynamic stores.
1678 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1679 was causing memory leaks.
1680 - src/gdcmSQItem.cxx:
1681 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1682 cleanly handled with polymophism: sorry but my milage is low).
1683 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1684 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1685 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1686 This avoids SegFaulting.
1687 - src/gdcmSQItem.h: coding style.
1689 - Test/TestWriteSimple still severely sucks. The output image content
1690 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1691 damaged when displayed with vtkgdcmViewer.
1692 - on memory leaks: TestWriteSimple leaks really less (see entry
1693 of 2004-06-18 in Changelog file for the call to valgrind).
1694 - on segfaults: ctest now passes all the tests but one (no more
1696 * Erroneous leading white fix:
1697 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1698 white[s] (as opposed to from >> xxx, that removes it [them].
1699 - src/gdcmTS.cxx: ditto.
1700 - gdcmPython/testSuite.py: dirty related kludge removed.
1701 * src/*: remaining references to gdcmParser removed.
1702 * src/*[cxx|h]: added copy[way]left header.
1705 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1706 * In order to fix writing of dicom files:
1707 - Test/TestWriteSimple.cxx: a simpler example of writing.
1708 - Test/CMakeLists.txt changed accordingly.
1709 - src/gdcmDocument.cxx:
1710 -- The destructor now recursilvely removes potential sequences.
1711 -- Bug fix in ::IsJPEG2000()
1712 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1713 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1715 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1716 to only declared) and build on top of
1717 ::GetDocEntryByNumber(guint16, guint16).
1718 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1719 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1720 for usage in destructor and treatement of promotion in
1721 ::ReplaceOrCreateByNumber().
1722 - src/gdcmSQItem.cxx: destructor should better handle his job.
1723 Test/TestWriteSimple now runs (or at least it DOES something).
1724 * We can now start hutting memory links. A good starting point is:
1725 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1726 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1727 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1729 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1730 * Valgrind note: after Mathieu Malaterre teached me how to read
1731 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1733 Using gcc, you can force the STL to use malloc and to free memory as
1734 soon as possible by globally disabling memory caching.
1735 With 3.2.2 and later, you should export the environment variable
1736 GLIBCPP_FORCE_NEW before running your program.
1737 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1738 simply vanish (it is still not clear to me, whether this means that
1739 STL std::string leaks or if valgrind believes it leaks...).
1740 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1741 running bin/gdcmTests makeDicomDir):
1742 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1743 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1745 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1746 SegFaulting (I drowned in DicomDir related code when trying to
1747 understand why the list is empty...).
1748 * src/gdcmDocument.h: first BSD license header try.
1749 * Doc/License.txt added.
1751 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1752 * src/gdcmDocument.[h|cxx]:
1753 - Clean up of the Transfer related predicates. They are now all based
1754 on new method isGivenTransferSyntax, that (should) handle properly
1755 the padding problem.
1756 - general clean up, simplification, and coding style.
1757 - Specific clean up of Parse7FE0() (umproperly named actually).
1758 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1760 2004-06-14 Jean-Pierre Roux
1762 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1763 - fix the display of SQItem ordinal number
1764 - add the GetSQItemByOrdinalNumber method
1765 - remove some useless never written private methods
1767 2004-06-14 Jean-Pierre Roux
1769 - adding a constructor taking a gdcmDocEntry as an input param
1770 - ReplaceOrCreateByNumber now returns :
1771 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1772 a gdcmValEntry * if a string value is passed as a param
1774 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1775 according to the param type (no longer sets a gdcmDocEntry)
1776 - GetValEntryByNumber, GetBinEntryByNumber added
1777 - NewValEntryByNumber and NewBinEntryByNumber added
1779 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1781 - GetSQItemNumber and SetSQItemNumber added, to provide
1782 a (relative) Item identier inside a given Sequence
1783 \warning : some pb remaining around this number
1785 - AddEntry now takes the Item Number as a param
1787 - adding a constructor taking a gdcmDocEntry as an input param
1789 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1790 * Memory leak hunt with the following command:
1791 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1792 --show-reachable=yes gdcmTests PrintDocument
1793 It looks like many (all?) leaks are due to the STL (or a bad usage
1794 of the STL. The lines producing the leaks now have a comment with
1795 a "MEMORY LEAK" tag: you can retrieve them with
1796 grep "MEMORY LEAK" src/*
1797 Here are two typical examples which I can't help fixing:
1802 char * test = "babo";
1803 name = test; //// <--- valgrind detects 960 bytes lost in
1804 //// call to std::string::operator=(char const*)
1805 name.clear(); //// Doesn't help !
1813 std::cout << "Type a bunch of characters followed by RETURN: ";
1814 getline(std::cin, line); //// <--- valgrind dectects a loss
1815 //// of 1320 bytes in call to
1816 /// std::basic_istream<>& std::getline<>
1822 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1823 * src/gdcmHeader.[cxx|h]:
1824 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1825 and related, moved away to gdcmDocument.
1826 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1827 the corresponding protected accessors of inherited class
1828 gdcmDocument, removed ! As a consequence gdcmFile had to be
1829 declared friend of class gdcmDocument (see below).
1830 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1831 - Clean up of undefined or unused methods.
1832 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1833 account the changes to gdcmHeader.h).
1834 * src/gdcmDocument.h:
1835 - gdcmFile is now a friend class (in order to take into account the
1836 changes to gdcmHeader.h).
1837 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1838 (see changes to gdcmHeader.h).
1839 - Accessors (reading on the form GetEntry*) are now public.
1840 - Clean up of undefined or unused methods.
1841 * src/gdcmDocument.cxx:
1842 - adaptation to changes to gdcmDocument.h
1843 - ::OpenFile now writes a verbose message when file cannot be opened.
1844 - some std::string properly set to VRKey
1845 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1846 references to gdcmDocument.
1847 * Test/TestFindTags.cxx: changed accordingly to above changes.
1848 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1849 cvs repository gdcmData.
1851 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1852 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1853 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1854 conflicts with gdcmValEntry::voidArea.
1855 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1856 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1857 Value representation between StringRepresentable and BinaryRepresentable.
1858 * src/gdcmDocument.cxx:
1859 - method ParseDES: proper indentation restored and usage of
1860 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1861 - method LoadDocEntry: the fingerprint left in the SetValue() of
1862 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1863 removed. Reverting to previous code segment with the proper
1864 dynamic_cast< gdcmValEntry* >.
1865 Note: this was (partially) breaking the python test suite
1866 (gdcmPython/testSuite.py) that made usage of the above
1867 fingerprint to check presence of "Pixel Data".
1868 * src/gdcmDocEntry.h: coding style.
1869 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1870 now taken into account.
1871 * gdcmPython/gdcm.i: adaptation to the new internal representation
1872 of gdcm (exit gdcmParser, hello gdcmDocument).
1873 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1875 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1876 anymore, but instead prints the loaded Python dictionary.
1877 * .... alas, the python testSuite is still broken.
1879 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1880 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1882 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1883 * src/gdcmUtil.h : export methods
1885 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1886 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1888 * Initial addition of automatic python testing
1889 * Initial addition of automatic image comparison
1891 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1892 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1893 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1895 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1896 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1897 * Test/ShowDicom.cxx : bug fix for msvc compilation
1898 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1900 2004-05-04 Jean-Pierre Roux
1901 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1902 new concepts (and new classes) :
1903 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1904 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1905 - Sequence Doc Entries (gdcmSeqEntries)
1906 a Sequence is composed of Items.
1907 Each item is a set of Doc Entries (this is recursive)
1908 The non uniqueness of the 'Dicom tag' is due to this recursivity
1909 (never taken into account)
1910 Our unability to add a new 'entry' in the header
1911 at the proper location (neither in the H-Table (map or multimap),
1912 nor in the Chained List is also due to this recursivity.
1913 Don't try, right now, to use/modify/compile these new sources :
1914 nothing is finished.
1915 We just commit all the stuff, 'as is', in order not to loose it.
1917 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1918 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1920 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1921 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1922 file prefix (SetFilePrefix)
1924 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1925 * Add a new test: ShowDicom, for now this is just the c++ version of
1926 checkRead.sh, later it will be able to compare the image read against a
1928 * Replace the DEBUG on the stack with a global entry in cmake interface:
1929 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1931 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1932 * Add an example subdir, with a real example on how to read + write a
1935 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1936 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1937 * Doc/CMakeLists.txt: the main page is now properly differentiated
1938 between the developper and user version.
1939 * Doc/doxygen.config.in: dropped search related obsolete flags
1940 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1942 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1943 * DEVELOPPER: added some helpfull comments for compile/test/install
1946 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1947 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1948 src directory, now generated in the build dir.
1949 2. Tests as mentionned smarter
1951 4. Add a new method in gdcmDict that return the PubDict by name
1952 this is interesting for 3rd party lib like ITK,
1953 where we could set the institution name / patient name...
1955 * ENH: 1. Now the test suite is working for real
1956 2. All binaries are now output in the gdcm-bin directory
1957 (this was not true before)
1959 2004-04-28 Jean-Pierre Roux
1960 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1961 SeQuence indented printing of Dicom Header.
1962 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1963 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1964 Computation of SQDepthLevel is now part of gdcmHeader constructor
1965 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1966 tree-like structure of a Dicom Header.
1967 * FIX Test code cleaning
1969 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1970 * ENH: Adding automatic testing
1971 1. Need a DartConfig.cmake to submit to public
1972 2. Add a test driver gdcmTest.cxx
1973 3. gdcmTestMain, an helper for the main test driver gdcmTest
1974 4. Files in Test don't have a main anymore, this becomes interesting
1975 when we add more and more tests, thus dsw don't have to load
1977 * ENH: Adding a GDCM_DATA_ROOT for testing
1978 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1979 one file instead of seven + some small cleanup
1981 2004-04-22 Jean-Pierre Roux
1982 * ENH Minor changes to the Print() methods.
1983 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1984 Header printing. Example given with :
1985 > PrintHeader fileName 2 new
1986 (SQ based tree-like structure still to be done for the Header ...)
1988 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1989 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1990 1. I have added some unsigned where needed
1991 2. Some function parameter not used -> (void)
1992 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1993 4. g++ don't like character '\' in comment
1994 5. #define jpeg_create_decompress jCreaDecompress
1995 this really need to be fixed
1996 6. virtualize destructor of gdcmObject ... leakage
1997 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1998 this also really need to be fixed
1999 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
2000 remove compression file
2001 (as we only do decompression, right ?)
2002 * ENH: Change malloc/calloc/free with c++ equivalent
2004 2004-04-21 Jean-Pierre Roux
2005 * FIX gdcmHeaderHelper::GetXSpacing
2006 when a single value is found (bug ?), xpacing is now
2007 defaulted to yspacing
2009 2004-04-19 Jean-Pierre Roux
2010 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
2011 * ENH add parameters :
2012 bool exception_on_error = false,
2013 bool enable_sequences = false,
2014 bool ignore_shadow = false
2015 to the gdcmFile constructors to be full gdcmParser compliant
2016 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
2017 to allow reading of PAPYRUS 3.0 files
2019 2004-04-06 Jean-Pierre Roux
2020 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
2022 2004-04-02 Jean-Pierre Roux
2023 * ADD : Test/checksequence.sh, for a general recap on SQ pb
2024 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
2025 for Philips spurious Tag fffe|0000 while rewritting Dicom files
2027 2004-03-30 Jean-Pierre Roux
2028 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
2029 for ACR file, written out as DICOM files (hope so...)
2031 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2032 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2033 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2034 moved to base class gdcmParser and only the specialisation is kept
2036 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2037 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2038 already does the job.
2039 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2040 (to be consistent with gdcmParser::WriteEntries).
2042 2004-03-30 Benoit Regrain
2043 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2044 upate of the object's instance. It's passed to 2 in the unfavorable
2045 case : one in the ExecuteInformation, one in the ExecuteData
2047 2004-03-29 Jean-Pierre Roux
2048 * ENH : Check on file type to be written moved
2049 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2050 * FIX : gdcmObject::ResetBoundaries now stops properly
2051 when end-of-list is reached
2052 : gdcmVersion modified (as Benoit Regrain asked)
2054 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2055 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2056 * src/gdcmUtil.cxx: added forgotten iostream include.
2057 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2058 equivalent to ExplicitVR in existing code).
2060 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2061 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2062 now contains all the gdcmGlobal related code.
2063 * minor coding style and doxygenation changes.
2065 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2066 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2067 now contains all the Debug related code.
2068 * minor clean-up of includes in src/*.cxx
2069 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2070 CreateCleanString) removed.
2071 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2072 * Doc/DoxyMainPageUser.txt added.
2073 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2074 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2075 src/gdcmDirList.cxx)
2077 2004-03-24 Jean-Pierre Roux
2078 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2080 2004-03-23 Jean-Pierre Roux
2081 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2082 big endian made volumes
2083 * ENH Now gdcmParser constructor and destructor are protected to forbid
2084 end user to instanciate class gdcmParser
2085 (only gdcmHeader and gdcmDicomDir are meaningfull)
2087 2004-03-22 Benoit Regrain
2088 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2089 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2090 gdcmSerie to gdcmDicomDirSerie
2092 2004-03-19 Jean-Pierre Roux
2093 * ENH Now the tree-like structure describing a DICOMDIR comming from
2094 an already existing DICOMDIR file is consistent with
2095 the home-made tree-like structure build ex-nihilo
2096 or build from the files held (recursively) in a Directory
2097 functions gdcmDicomDir::CheckBoundaries()
2098 gdcmObject::SetBoundaries() added
2100 2004-03-17 Jean-Pierre Roux
2101 * REM (Eric Boix bug) : removal of meaningless
2102 gdcmDicomDirImage::NewImage function.
2103 * FIX now file names and directory name are written properly in the
2105 * FIX now gdcmDicomDir constructor may be call without any trick
2108 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2109 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2110 of gdcmDicomDirImage::NewImage as empty function.
2112 2004-02-28 Jean-Pierre Roux
2113 * ENH add gdcmDicomDir:NewPatient
2114 add gdcmDicomDirPatient:NewStudy
2115 add gdcmDicomDirStudy:NewSerie
2116 add gdcmDicomDirSerie:NewImage
2117 to allow making gdcDicomDir object.
2118 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2119 (as opposite to the gdcmHeader chained list)
2121 2004-02-11 Benoit Regrain
2122 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2123 when using from python
2125 2004-02-10 Benoit Regrain
2126 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2127 * FIX : in gdcmDicomDir when the directory is empty
2128 * ENH : add callback and methods to get the progression of dicomDir
2131 2004-02-06 Jean-Pierre Roux
2132 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2133 - GDCM_META added to gdcmDicomDirType
2134 - class gdcmMeta created
2135 * ENH : - A brief summary is now displayed at the beginning of
2136 'testDicomDir' to help disaster magnitude estimation
2137 * REM : Now useless Test/explDICOMDIR.cxx
2139 2004-02-05 Benoit Regrain
2140 * ENH : add methods in gdcmObject to get the hash table or the list of
2142 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2143 * FIX : wrapping python for TagHeaderEntryHT
2145 2004-02-04 Benoit Regrain
2146 * FIX : even length for some strings when writting the dicom dir
2147 * FIX : sort the images in the dicom dir
2148 * FIX : Bug fix for python use of dicom dir
2149 * ADD : a python demo
2151 2004-02-04 Jean-Pierre Roux
2152 * FIX : Final solution (?) for icone embedded images
2153 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2154 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2155 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2156 gdcmData/gdcm-MR-SIEMENS-16.acr1
2157 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2158 to make full checking easier
2160 2004-02-04 Benoit Regrain
2161 * FIX : WriteEntries : coding style & logic in parameters
2162 * FIX : Set the elements to create the DicomDir in a dictionary file
2164 2004-02-03 Benoit Regrain
2165 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2166 * gdcmDicomDir : add the load of directory
2167 * Bug fix and print add-on
2169 2004-02-03 Jean-Pierre Roux
2170 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2171 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2172 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2173 * FIX gdcmParser.cxx : 'group length' elements are now considered
2174 as integers, even for shadow groups, when file is Implicit VR
2176 2004-02-02 Jean-Pierre Roux
2177 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2179 of the last synonym :-(
2180 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2182 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2183 * FIX taking into account the possible 7fe0,0010 multiplicity
2184 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2185 to allow removal of references to 7fe0,0010, to deal with
2186 ACR-NEMA images, when 0028,0200 is meaningfull
2188 2004-01-31 Jean-Pierre Roux
2189 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2190 no longer writes 'Un' on disk
2191 * FIX SQ elements with actual length are now dealt with corectly
2192 * FIX gdcmFile::WriteBase make the difference, for color images, between
2193 the length (for Palette expanded images)
2194 and Raw Length (non expanded image + Palette)
2195 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2196 (that broke Write). Replaced by UL.
2197 Aware user will reload the field if he
2198 thinks it's necesssary
2200 2004-01-30 Jean-Pierre Roux
2201 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2202 when 'dirty Acr' is found, to be compliant with the new
2203 IsReadable() methods.
2205 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2206 (no DOUBLE images in kosher DICOM,
2207 but so usefull for people that miss them ;-)
2209 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2210 DICOMDIR related utilities (not checked as Windoze compliant)
2212 2004-01-28 Jean-Pierre Roux
2213 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2215 2004-01-27 Jean-Pierre Roux
2216 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2217 to allow skipping the shadow elements, to save memory space.
2218 The TRUE value for this param has to be used
2219 with a FALSE value for the 'enable_sequence' param.
2220 ('public elements' may be embedded in 'shadow Sequences')
2221 * gdcmHeader methods now deal with 'embedded icones images' in the header
2222 (even when an 'icone image sequence' is announced by the
2223 element (0x0088,0x0200), but there is NO icone at all ...
2225 * gdcmHeader sometimes Image Location value doesn't follow
2226 the supposed processor endianity (see gdcmData/cr172241.dcm).
2229 * gdcmHeader add the method
2230 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2231 to get *all* the Header Entries with the same tag.
2232 GetHeaderEntrySameName is probabely *useless*
2233 (no meaning : Name is *not* an identifier within the Dictionary)
2235 2004-01-26 Benoit Regrain
2236 * Bug fix in the print of hexadecimal representations. Remove long fields
2237 in the print and add a third level of print to print them
2239 2004-01-23 Benoit Regrain
2240 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2241 * Bug fix on test suite after remove the strip made on not string fields
2242 * Split the IsReadable method between gdcmParser which test that the file
2243 is dicom and gdcmHeader which test that it's an image file
2245 2004-01-22 Benoit Regrain
2246 * DicomDir : clean code, add methods, set variables in protected or private
2247 * gdcmUtil : bug fix for the clean string method
2249 2004-01-19 Benoit Regrain
2250 * Add the use of shadow dictionaries
2251 * bug fix and coding style
2253 2004-01-19 Benoit Regrain
2254 * src/gdcmFile.cxx : bug fix concerning the close of file
2255 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2256 * Add the update of header entries using the shadow library
2258 2004-01-19 Benoit Regrain
2259 * removal of file gdcmHeader2.cxx
2260 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2261 inheriting from gdcmParser. This split is to prepare the integration
2262 of dicom dir parsing
2263 * bug fix under python
2265 2004-01-16 Jean-Pierre Roux
2266 * REM removal of class gdcmHeaderEntrySet
2267 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2268 * ADD add file gdcmHeader2.cxx
2269 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2271 2004-01-15 Benoit Regrain
2272 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2273 entries created while parsing the header. Thus, they will be destroyed
2274 when the gdcmDictSet will be destroyed
2275 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2278 2004-01-15 Benoit Regrain
2279 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2280 made a fatal error because of the memory release at the end of program.
2281 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2282 some memory and vtk seems to have some problems with that.
2283 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2285 2004-01-14 Benoit Regrain
2286 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2287 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2288 * src/*.[h|cxx] : make changes due to class name changes
2289 * gdcmPython/demo/*.py : bug fix due to method names
2291 2004-01-13 Benoit Regrain
2292 * src/*.[h|cxx] : coding style
2293 * vtk/*.[h|cxx] : coding style
2295 2004-01-13 Benoit Regrain
2296 * gdcmPython/testSuite.py : test the readable flag of file for tests
2297 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2298 It's lied to the stl compilation by MSVC (windows, always windows...)
2299 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2301 2004-01-12 Benoit Regrain
2302 * src/*.h : add comments
2303 * src/gdcmDictSet.h : set the method BuildDictPath in public
2304 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2305 directly setted in the source code
2306 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2309 2004-01-09 Benoit Regrain
2310 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2311 * setup.py : use a reference to gdcmVERSION
2313 2004-01-07 Benoit Regrain
2314 * Modification to compile with the distutils.
2317 2003-12-10 Benoit Regrain
2318 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2319 can use a gdcmHeaderHelper to load data
2320 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2321 made in the source code
2323 2003-12-10 Benoit Regrain
2324 * Update Windows projects and .cvsignore files
2326 2003-11-12 Jean-Pierre Roux
2327 * ENH gdcmHeader constructor has one more parameter (default value : false)
2328 that allows the user to 'go inside' the SeQuences only
2330 gdcmElValSet:Print takes it into account
2332 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2333 * ENH: Update gdcmPython/CMakeLists
2334 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2335 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2337 2003-11-10 Jean-Pierre Roux
2338 * FIX : gdcmHeader::LoadElements is now based
2339 on the ListTag listElem member,
2340 not longer on the TagElValueHT tagHt member
2341 * ENH : PrintPubElVal shows (temporarily) both results,
2342 with the tagHt member and the listElem member.
2343 (it's easier to 'see' the problems when using Printheader)
2345 * FIX : old private member LgrElem is now splitted into
2346 ReadLength : Length actually found on disk (updated only
2347 if bug fixing is necessary), for internal
2349 UsableLength : Updated by FixFoundLength, to fix a bug
2350 or to allow Parser going on.
2351 Will allow to re-write a kosher header when a SeQuence
2352 with a length (not 0000) is found
2353 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2354 because gdcmElValSet::Add does not update ListElem
2357 2003-11-07 Jean-Pierre Roux
2358 * FIX misstyping in Transfert Syntax name table
2359 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2360 when they have an actual length (not 0000 nor FFFFF)
2361 (Nobody should care of it, but DICOMDIR explorers)
2363 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2364 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2366 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2367 * ENH: vtkGdcmReader now supports LUT !
2368 (vtkgdcmViewer for now is not able to use them though)
2370 2003-11-05 Jean-Pierre Roux
2371 * in testSuite.py : new files names for checking the package
2372 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2373 that returns the pixel area size to the *aware* (vtk) user
2374 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2376 2003-11-05 Benoit Regrain
2377 * in testSuite.py : Modify the rules for checking the paths
2378 : Explicit error messages
2379 * in __init__.py : Related modif
2381 2003-11-03 Jean-Pierre Roux
2382 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2383 to be used by aware (vtk) users that want to manage
2384 LUT (and no to turn the PALETTE image into an RGB pixels one)
2385 * GetPixelType now returns 8U for 24 Bits images
2386 (vtkGdcmReader compliant)
2388 2003-10-31 Jean-Pierre Roux
2389 * Removal of *all* gdcmData images and add them again
2390 in order to loose the 'history' of un-anonymised images
2392 2003-10-31 Jean-Pierre Roux
2393 * RMV : removal of useless jBitsInJsample.h
2394 for both 8 and 12 Bits JPEG Lossy Libraries
2396 2003-10-31 Jean-Pierre Roux
2397 * ENH : Add the functions gdcmFile::GetImageDataRaw
2398 gdcmFile::GetImageDataIntoVectorRaw
2399 that act as GetImageData and GetImageDataIntoVector
2400 except the making of an RGB Plane from Gray Plane + LUT
2401 Intended to aware (vtk) users who know how to manage
2404 GetLUTRGBA return a R,G,B,A LUT if any
2405 lgrTotaleRaw gives the 'Raw' length
2406 GetImageDataRaw returns the gray Plane
2407 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2408 (They stay Grey, just like with other Dicom viewers :-(
2410 2003-10-30 Jean-Pierre Roux
2411 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2413 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2414 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2415 being coherents dicom files.
2417 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2418 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2420 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2421 * ENH: Two steps is necessary to please VC++ compiler...
2422 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2423 * ENH: Add include dir to medcon lib
2424 * FIX: only one function is being exported for now !
2425 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2427 2003-10-29 Jean-Pierre Roux
2428 * adding gdcmHeader::GetLUTRGBA
2429 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2430 --> Mathieu, the modif u're waiting for is not yet committed
2431 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2433 2003-10-27 Jean-Pierre Roux
2434 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2435 00191113.dcm DermaColorLossLess.dcm
2436 MxTwinLossLess.dcm RadBWLossLess.dcm
2437 * ENH: For version prior to vtkImageViewer2 -r 1.19
2438 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2440 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2441 * Removal of ido stuff in CMakeLists.txt
2443 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2444 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2445 * FIX: remove a call to ->Modified ... see comments
2446 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2448 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2449 * FIX: Problem with path for libvtkgdcmPython
2450 * ENH: Try adding a search script for python site-package
2451 * RMV: Remove some file from medcon lib that are not necessary
2452 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2453 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2454 * FIX: More pragma disable fro VC++,
2455 I don't think I break something as it is also disable in VTK/ITK.
2456 But it fasten debug compilation time.
2458 2003-10-23 Jean-Pierre Roux
2459 * gdcm now deals with 16 Bits Run Length Encoded images
2460 (they are compressed as 2 planes images,
2461 one for the high Bytes, the other for low Bytes)
2463 2003-10-22 Jean-Pierre Roux
2464 * Now CheckRead takes into account :
2465 - the bugged 'Leonardo' Siemens images
2466 - the XA images, sent thru the burning VPRO station
2467 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2470 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2471 * FIX: When copying a Makefile.am to CMakeLists.txt
2472 one should remove the '\'
2474 2003-10-22 Jean-Pierre Roux
2475 * in gdcmData adding a bugged 'Leonardo' Siemens image
2476 (wrong lengths in header)
2477 OK with gdcm, KO with the other viewers :-)
2478 * add a GE dlx XA image, thru the VEPRO burning station
2481 2003-10-21 Jean-Pierre Roux
2482 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2483 for a brutal checking of vtkgdcmViewer compliance
2485 2003-10-21 Jean-Pierre Roux
2486 * add the files for 'xmedcon' Jpeg Lossless library
2487 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2489 2003-10-21 Jean-Pierre Roux
2490 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2492 2003-10-21 Jean-Pierre Roux
2493 * garbage Siemens 'Leonardo' images dealt with
2494 (the patch is easy to remove)
2495 * cosmetic changes to avoid warnings
2497 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2498 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2499 no need to press 'r' now.
2501 2003-10-20 Jean-Pierre Roux
2502 * upgrade of checkRead.sh checkWrite.sh according
2503 to new Jpeg Lossless decompressor
2504 * add US.3405.1.dcm, a genuine RGB medical file ...
2505 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2506 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2508 2003-10-15 Jean-Pierre Roux
2509 * general anonymisation in gdcmData
2510 * adding the 'color files' from
2511 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2512 * adding some well knowed bugged-header images
2513 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2514 waiting for their inclusion in Python testsuite
2516 2003-10-15 Jean-Pierre Roux
2517 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2518 no longer seg faults when file is not found
2520 2003-10-14 Jean-Pierre Roux
2521 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2524 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2525 * TODO: *.in file to genereate a UseGDCM later
2527 2003-10-14 Jean-Pierre Roux
2528 * Some supposed-to-be Dicom Images have no preamble.
2529 OpenFile takes it into account
2530 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2531 * Missing elements added in dicomV3.dic
2532 (just to be affraid : have a look at
2533 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2534 and do it again next year ;->
2536 2003-10-13 Jean-Pierre Roux
2537 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2538 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2539 But there are NOT. It's fixed !
2541 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2542 * FIX: "jpeglib.h" was not found on VC++
2543 * FIX: vtkgdcm was not being installed
2545 2003-10-10 Jean-Pierre Roux
2546 * ENH : OpenFile closes the file if it *really* doesn't look like
2547 an ACR-NEMA / DICOM one.
2548 * FIX : testWrite no longer writes an empty file if the source file
2549 is not gdcm Readable
2550 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2553 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2554 * FIX: CMake generate now documentation
2555 * ENH: out of source doc build !
2556 * ENH: Generate both user and dev documentation
2557 * ENH: Should work on windows too
2558 * ENH: Only one doxygen config.in file is needed
2559 * FIX: make install should be ok now on ùnix plateform
2560 * FIX: PATH to dictionary was wrong (missing /)
2561 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2563 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2564 * vtkGdcmReader is now able to read rgb dicom file.
2565 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2566 * added a gdcmViewer to vtk test, use mouse to control
2567 window level & window width
2569 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2570 * CMake-ification of gdcm, we have now two build system
2571 * FIX: on cygwin Wsock32 doesn't exist
2572 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2574 2003-10-06 Emanuel Ollart
2575 * FIX : compilation process wad broken.
2576 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2578 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2579 * change gdcmViewer -> vtkgdcmViewer
2580 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2582 2003-10-06 Jean-Pierre Roux
2583 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2584 ( e.g : well known GE images with a wrong elem length,
2585 : Philips MRI Images with a wrong Huffman table)
2586 * still to be done : allow the reading of bugged LEONARDO Siemens images
2588 2003-10-03 Jean-Pierre Roux
2589 * Odd length strings are padded with '\0' (not with spaces,
2590 to remain compliant with already defined strings,
2591 like Transfert Syntax UID and others)
2593 2003-10-03 Jean-Pierre Roux
2594 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2595 to allow displaying RGB images (not only by affim ;-)
2597 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2598 * vtkGdcmReader is now able to read rgb dicom file.
2599 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2601 2003-10-03 Jean-Pierre Roux
2602 * A few nasty patches to allow the reading of a lot of nasty images
2603 ( e.g : well known GE images with a wrong elem length,
2604 : Philips MRI Images with a wrong Huffman table)
2605 * still to be done : allow the reading of bugged LEONARDO Siemens images
2607 2003-10-03 Jean-Pierre Roux
2608 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2610 2003-10-03 Jean-Pierre Roux
2611 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2612 to allow displaying RGB images (not only by affim ;-)
2614 2003-10-03 Jean-Pierre Roux
2615 * gdcmFile::GetImageDataIntoVector now
2616 - deals with MultiFrames MultiFragments Run Length Encoded files
2617 - deals with YcBcR (YBR_FULL) files
2618 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2619 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2621 (no sample found :-(
2623 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2624 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2625 Two reasons: - clear things
2626 - third parties acces gdcm through header files, so won't
2627 suffer anymore VC++ complains
2629 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2630 * add argv[1] in testvtkGdcmReader.cxx
2633 2003-09-24 Jean-Pierre Roux
2634 * The lines are now eigthy characters long.for
2635 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2637 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2638 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2639 char* to std::string. Thus, the use of strdup becomes useless. (see
2640 previous commis of Malaterre)
2641 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2642 before the last Malaterre's commit.
2644 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2645 * This commit should fix the Debug building under VC++, the problem
2646 was mainly a mixture of debug and release lib being loaded at startup.
2647 * I also remove a depency to a specific C function: strdup. Because I had
2648 to force the link to msvcrtd (whereas strdup is in libc).
2650 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2651 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2652 located in the gdcmCommon.h file. All use of reference of tha has been
2653 changed to now use the variable GDCM_UNFOUND.
2655 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2657 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2658 Dicom dictionary. The test suite can now be run again. Note:
2659 I'm note very happy with the " (RET)" changes. I believe this
2660 RETAINED comment should be dropped when parsing the dictionary.
2661 - PACKAGER corrected
2663 - AUTHORS updated and now in alphabetical order
2664 * Makefile.am now exports gdcm.dsw for Windoze users.
2666 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2667 * cygwin complains about missing std:: in subdir Test/
2669 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2670 * remove some methods that are now in gdcmHeaderHelper
2672 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2673 * vtkGdcmReader set spacing and origin correctly
2675 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2676 * Fix a few delete/delete[] mismatch
2678 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2679 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2680 interpretation to data given by gdcmHeader. For instance there are
2681 heuristics to get informations (look at different places).
2682 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2683 sorting DICOM images based on different strategies.
2684 * modified Makefiles accordingly.
2686 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2687 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2688 when building in debug mode
2689 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2690 src/win32/gdcmdll.dsp
2691 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2693 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2694 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2697 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2698 * src/win32/libgdcmjpeg12.dsp was not dos format
2699 * src/win32/libgdcmjpeg12.dsp :
2700 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2701 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2703 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2704 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2706 * src/gdcmFile.cxx : bug fix in affectation type
2707 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2708 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2709 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2710 symbols... future problem ?
2712 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2713 * src/win32/libgdcmijpeg12.dsp was missing
2714 * modified gdcm.dsw accordingly
2716 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2717 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2719 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2720 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2721 commit of JPR (before his hollidays to facilitate our work).
2722 * setup.py : bug fix in code. Modifications made while the last commit
2723 of JPR. The code hasn't been tested before the commit... it's so
2724 useless to make that (for best programmer that is JPR) !!!
2726 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2727 * tagged the current version as Version0_3 (i.e. version 0.3)
2729 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2730 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2731 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2732 * *.dsp : modifications to use new libgdcmijpeg8 library
2733 * setup.py : bug fix on VTKPATH variable
2734 * PACKAGER : adding all concerning windows
2736 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2737 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2739 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2740 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2741 test suite reported error.
2742 * PACKAGER file added (describes what a packager must do when
2743 packaging a new release).
2744 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2745 * configure.in: upgraded version number to 0.3.0
2746 * fixing build of rpm (through rpm -ta):
2747 - Doc/Makefile.am exports proper doxygen files
2748 - src/jpeg/libijg8/Makefile.am exports the include files.
2750 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2751 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2752 * src/gdcmHeader.h : formatting code
2754 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2755 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2756 We were obtaining error message from vtk. Now, creation of file list
2757 is made in an internal list to prevent this problem.
2758 Bug fix when output is empty.
2759 Bug fix in update of progress value. Previous commit for this was a bad
2761 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2763 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2764 * src/gdcmHeader.h : added method to get the file name
2765 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2766 files. Added method to remove all files on the input
2767 Added FIXME comment concerning the bad parsing of header made by
2768 ExecuteInformation method (in ExecuteData method)
2770 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2771 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2772 when using make instal.
2773 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2774 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2776 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2777 * setup.py : adding include dir of jpeg lib to compile all sources
2778 * */Win32/*.dsp : JPR fix for windows compilation
2780 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2781 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2783 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2784 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2786 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2787 * setup.py is again effective on un*x (takes into account the
2788 addon of the jpeg library)
2789 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2790 * Doc/Doxy* updated (includes above enhancements)
2791 * INSTALL now points to web documentation
2793 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2794 * src/gdcmHeader.h doesn't make unnecessary reference to
2796 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2798 * src/gdcm*.[cxx|h] :
2799 - to allow compilation with gcc 3.x
2800 -- clean up of STL usage (added explicit usage of std::)
2801 -- small fixes on exceptions.
2802 Note: linking not tested !
2803 - clean of doxygen comments to avoid warnings at documentation
2805 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2806 dependent convertion).
2808 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2809 * Clean up of previous JPR garbage commit (not even commented in the
2811 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2812 - moved all jpeg related files from src to src/jpeg/libijg8, with
2813 addition/modification of Makefile.am and configure.in.
2814 - the testSuite is still brain damage (not guilty).
2816 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2817 * WrapVTK.py : modifications to get correctly vtk source files to
2819 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2820 (FileName -> Filename)
2822 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2823 * vtk/vtkGdcmReader.[cxx/h]:
2824 - UpdateProgress method should now be effective
2825 - removed the limitation on having only images loaded (as opposed
2827 - when building a stack of images/volume, a lesser number of
2828 gdcmHeader and gdcmFile instances should be used (hopefully
2829 accelerating things).
2830 - when building a stack of images/volumes, files which are not
2831 loadable (wrong path-filename, wrong permissions on existing file,
2832 or file not parsable by gdcm) are replaced with a black image
2833 in the stack (for the caller to notice the problem).
2835 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2836 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2838 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2839 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2840 between standard library (std) and vtk library (problems are found
2841 under Windows... thanks Windows !)
2843 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2844 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2846 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2848 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2849 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2851 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2852 * When compiling with distutils (see setup.py) the C++ compiler is
2853 called with different flags than the default ones (with automake).
2854 In order to fix all those warning, I compiled gdcm with the command
2855 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2856 and went for warning fixes:
2857 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2858 up from unused variables.
2859 - vtk/vtkGdcmReader.cxx: potential bug fix.
2860 * src/gdcmHeader.h: Doxygen warning cleanup
2862 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2863 * gdcmPython/gdcm.i:
2864 - typemaps correction to take into account the systematic replacement
2865 of "using namespace std" with std:: prefix e.g. std::list,
2866 std::string... (cf changes of 2003-05-21).
2867 - gdcmGlob global variable of type gdcmGlobal (defined in
2868 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2869 exported to Python a as cvar.
2870 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2871 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2872 gdcmDictSet.GetPubDictTagNames() and
2873 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2874 C++ static methods).
2875 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2876 with the above changes.
2878 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2879 * setup.py, manifest.in : bug fix under linux
2881 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2882 * Modification of setup.py to compile vtk part too. Then, we have 2
2883 wrappers which must work with same distutils. For that, we have a
2884 generic distutils in distusiltsWrapping.py ; with :
2885 - build_extWrap class to wrap generically all extensions,
2886 - ExtensionWrap base class for all wrapping extension that contains
2888 - Wrapper interface which wrap sources
2889 + In WrapSwig.py we have extension and wrapper for Swig
2890 + In WrapVTK.py we have extension and wrapper for VTK
2891 * MANIFEST.in : modifications to consider vtk directory and new python
2892 files for compilation
2894 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2895 * Added python wrappers of vtkGdcmReader vtk class (see the
2896 source in vtk/vtkGdcmReader.cxx) :
2897 - vtk/Makefile.am now builds a library
2898 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2899 python library (as opposed to _gdcm.so wich are the python
2900 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2901 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2903 - configure.in has an additional flag --enable-vtk that needs
2904 to be set to enable compilation of vtk related code, that is:
2905 + vtk/vtkGdcmReader.so and
2906 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2907 + gdcmPython/vtkgdcmPython.so (see above)
2908 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2909 be read when compressed or when HighBit + 1 != BitsStored),
2910 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2911 the usage of the python wrapper of vtkGdcmReader vtk class.
2912 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2913 * src/*.[h] all occurences of stl classes are now prefixed with
2914 std::, and all occurences of "using namespace std;" where removed.
2915 This is to avoid pollution of global namespace in included files.
2916 Apparently vtk does not avoid this pitfall: when using both
2917 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2918 collision of various stl members (principally cout...).
2919 * gdcmPython/testSuite.py now cleanly removes temprory generated
2921 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2922 comply with above changes)
2924 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2925 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2926 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2927 vtk data structure (an image Flip was required).
2928 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2929 * cosmetic changes in documentation.
2931 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2932 * src/gdcmHeader.cxx: the constructor no longer exits when an
2933 unexisting file is given as argument.
2934 * The subdirectory Data (containing all the images used for the
2935 test suite) is not part of this repository anymore. A new module
2936 containing those images is now available at
2937 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2938 with the name gdcmData.
2939 All the python scripts (including the package initialisation file
2940 gdcmPython/__init__.py) were adapated to take this change into
2941 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2943 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2944 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2945 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2946 demo of the usage of this class.
2947 Compilation of this vtk part is only done when using the --enable-vtk
2948 at configure (or autogen.sh) stage.
2950 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2951 * More memory link related corrections and documentation fixes.
2953 - maximum info is obtained with a command of the form:
2954 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2955 --show-reachable=yes PrintHeader
2956 - the remaining reachable blocks seem to come from the STL
2957 allocation scheme through the usage of map and list. It looks
2958 like this memory cannot be freed but it is not a memory leak
2959 (in fact further invocation to the STL would recollect the
2960 unused memory allthough it cannot explicitely be freed).
2961 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2962 of displaying an image parsed with gdcm and displayed with VTK.
2963 Note: some images don't seem to work e.g.
2964 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2965 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2966 Allthough this weakens the semantics, it is a ditch attempt to
2967 make gdcm more thread friendly.
2969 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2970 * Memory link hunt (by using valgrind through the command
2971 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2972 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2973 gdcmHeader::_dicom_vr.
2974 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2975 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2977 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2979 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2980 * src/Makefile.am now exports all the necessary include files at
2984 * UpdateGroupLength replaced by new one
2987 * UpdateGroupLength re-written using H-Table
2988 (named UpdateGroupLengthNew untill checks are over)
2990 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2991 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2992 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2994 - gdcmHeader::GetPubElValSet removed.
2995 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2996 UpdateGroupLength, WriteElements, Write.
2997 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2998 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2999 carried the same semantics.
3000 - src/gdcmHeaderIdo.cxx changed accordingly.
3001 - gdcmFile::WriteBase now regroups all the codes from previous
3002 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
3003 - enum FileType moved to gdcmCommon.h
3004 * src/gdcmHeader.cxx AddDefault trashed
3005 * gdcmGetXSize added
3006 * getimageDataSize now calls gdcmGetXSize
3007 * Test/*.cxx changed to agree with above changes
3009 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3010 * src/gdcmHeader.h: LoadElements() is not a public method anymore
3011 (to avoid double call by end user).
3012 * Test/*.cxx LoadElements() doesn't need to be called explicitely
3013 by end user, since gdcmHeader::gdcmHeader now handles it.
3015 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3016 * gdcm/Doc many doxygen changes:
3017 - Doxyfile now has two different versions, DoxyfileUsers that generates
3018 the html.users end users oriented documentation and
3019 DoxyfileDeveloppers that generates the html.developper developper
3020 oriented documentation.
3021 - README changed accordingly
3022 - requirement.txt removed (old design info moved to TODO).
3023 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
3024 DoxyMainPage.txt, DoxyPython.txt provide more information.
3025 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
3026 be updated by simply regenerating the docs with doxygen and copying
3027 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
3028 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
3029 all the tests in the form "if (<map>.count() >1)" were removed.
3030 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3031 ill-formed documentation sections.
3032 * src/gdcmHeader.cxx: ditto
3034 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3035 * setup.py fixed for un*x (needed macro for stdint.h)
3036 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3037 un*ces with sh-utils test utility.
3038 * gdcmPython/demo/test.py renamed to PrintHeader.py
3039 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3040 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3041 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3042 * src/gdcm*.cxx JPR's bad inclusion fixed.
3044 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3045 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3046 * gdcmPython/demo/test.py changed accordingly.
3048 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3049 * gdcmPython/Makefile.am fixed linking against libstdc++
3050 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3051 * Swig subdir (historical tests of swig version 1.3.17++) removed
3052 * Test/testChangeEntete.cxx some lines commented out in order to make
3054 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3055 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3057 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3058 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3059 hence the user doesn't need this explicit call.
3060 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3061 i.e. LoadElements() call removed.
3062 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3063 - src/Makefile.am declares the proper flag for g++.
3064 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3065 for adding user defined new tags.
3066 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3067 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3068 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3070 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3071 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3072 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3073 src/Makefile.am : the project should properly compile and install
3074 with the autotools, included the python wrappers part.
3075 * gdcm.spec.in : added a spec file for RPM packaging.
3077 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3078 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3080 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3081 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3082 to exported to the environement (see gdcmPython/testSuite.py
3084 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3085 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3086 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3087 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3088 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3090 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3091 * gdcmPython/__init__.py doesn't crash anymore when running in
3092 in InstallMode or PreInstallMode but with an environment given
3093 value of GDCM_DICT_PATH.
3094 * src/gdcmDictSet.[cxx/h] coding style.
3096 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3097 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3098 * src/gdcm.h general comments moved to TODO, and README
3099 * src/gdcm.h should now be seen as a user commodity (including it
3100 should suffice to fully use gdcm). It is nowhere including within
3101 any of the kernel files src/*.cxx and src/*.h.
3103 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3104 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3105 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3107 * src/gdcm*.cxx only include their corresponding include file
3108 (as opposed to gdcm.h)
3109 * gdcmPython/gdcm.i changed accordingly
3110 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3111 the autogen.sh generated "make snapshot" command to work.
3112 * autogen.sh removed history related references to crea package.
3114 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3115 * distutilsSwigCPlusPlus.py work around some swig portability
3118 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3119 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3120 was done in a last ditch attempt to get setup.py _really_
3121 operationnal. The python/gdcmPython layaout add the advantage
3122 of hidding away the python related distutils specific files
3123 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3124 Alas, the src directory was out of scope (i.e. it's relative
3125 position to setup.py was ../src) which made things impossible to
3126 handle (see previous version of python/setup.py). Crossing fingers...
3128 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3129 * python/setup.py now works on Un*x. (harder than I thougth)
3130 * python/distutilsSwigCPlusPlus.py can now have include files
3131 among the list of sources.
3133 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3134 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3135 * modifications in MSVC projects
3137 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3138 * As stated by the first lines of Test/ExceptionAndPython/README, it
3139 looks like we can move back to original usage of exception within
3140 src/gdcm* and hence remove the errno stuff that was introduced
3141 as a quick and dirty fixture of this problem (added to the TODO).
3142 * Doc/Doxyfile configuration file for Doxygen and corresponding
3143 README file for usage added.
3144 * Test/testWrite.cxx added. This new test comes from a split of
3145 test.cxx that is now reverted to its original purpous i.e.
3146 testing the proper parsing of a Dicom related file.
3147 testWrite.cxx concentrates on testing the IO part of gdcm.
3148 * Test/bug1.cxx (containing a bug on WIn32) added.
3149 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3150 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3151 whose purpose is to publish the content of the TagNames of the
3152 Dicom public dictionary were not accessible without an
3153 instance of class gdcmHeader.
3154 - those methods are now static methods of gdcmDictSet and hence
3155 require no instances at all to be invocated.
3156 - within gdcmDictSet this change required to change some method
3157 to class methods (i.e. are now static) among which SetDictPath
3158 (renamed to BuildDictPath) and LoadDefaultPubDict.
3159 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3160 the above changes by calling the new method classes of gdcmDictSet.
3161 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3162 the above to be effective.
3163 * python/gdcmPython: in order to wrap properly the above changes
3164 for Python, swig version now needs to be > 1.3.17.
3165 * python/gdcmPython/Makefile fixed to adapt itself to new
3166 configure/make shema introduced by Johan Montagnat (thanks for the
3167 contribution). Alas this Makefile cannot be turned into a proper
3168 Makefile.am without some heavy changes in the configure.in
3169 (for python dectection).
3170 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3171 now avoids publishing the empty entries.
3173 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3174 * python/setup.py : bug fix concerning install under windows
3175 ExtraPath reused :-P
3176 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3178 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3179 * Dicts/dicomV3.dic : remove double spaces !!!
3180 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3181 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3184 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3185 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3186 method. Doxygenation.
3187 * src/gdcm.h clean up of JPR spurious comments.
3189 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3190 * python/distutilsSwigCPlusPlus.py now properly collects the
3191 shadow classes generated by "swig -c++" (gdcm.py in our case)
3192 when using "python setup.py install".
3193 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3194 reexports the working classes.
3195 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3196 by the classical C errno scheme. This is to prevent an obscure
3197 behavior of the python wrappers when importing wxPython.wx prior
3198 to gdcmPython (which ended up in an abort call). An illustration
3199 of this oddity can be found in the Test/ExceptionAndPython
3200 subdir (see the README file). This problem probably due to
3201 an combination of g++ and dynamic loading.
3202 * added Test/ExceptionAndPython (see above)
3204 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3205 * Changed the layout of the python part to avoid bloating main
3206 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3207 i.e. the distutils arsenal. All the python related stuff is
3208 again in a python subdir, but the package itself is now in
3210 * setup.py was cleaned up:
3211 - pythonIncludePath removed
3212 - python setup.py bdist target is now functional.
3213 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3214 collision with other packages). gdcmPython/demo/*.py changed
3217 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3218 * python subdir moved to gdcmPython (preparation of distutils packaging).
3219 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3220 distutils installer is operational.
3221 * - gdcmPython/__init__.py now properly loads the swig generated
3222 shadow classes (from gdcm.py).
3223 - gdcmPython/demo/*.py changed to import the package gdcmPython
3224 instead of gdcmPython/demo/load.py.
3225 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3227 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3228 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3229 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3230 entries within the associated public Dicom dictionary resp. the same
3231 information but sorted by the fourth field (PAT, IMG, DIR) of the
3233 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3234 are now in the "???" group.
3235 - python/gdcm.i changed accordingly,
3236 - python/demo/printGroupedPublicDict.py added, that gives an example
3237 of the above new functionalities in Python.
3239 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3240 * src/gdcm.h, gdcmHeader.cxx:
3241 - historic references to glib's g_malloc and g_free (#defined)
3242 were definitively removed.
3243 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3244 * src/gdcmElValSet.cxx:
3245 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3246 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3247 - GetElValue(string) renamed to GetElValueByName.
3248 - Added GetElementByName(string).
3249 * src/gdcmHeader.cxx: added
3250 - GetPubElValRepByNumber(guint16, guint16)
3251 - GetPubElValRepByName(string)
3252 - GetShaElValRepByNumber(guint16, guint16)
3253 - GetShaElValRepByName(string)
3254 - GetShaElValByNumber(guint16, guint16)
3255 - GetShaElValRepByName(string)
3256 - GetElValRepByNumber(guint16, guint16)
3257 - GetElValRepByName(string)
3258 - GetElValByNumber(guint16, guint16)
3259 - GetElValRepByName(string)
3260 * Doc/requirements.txt added.
3262 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3263 * Test/Makefile building now depends on the one of libgdcm.so
3264 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3265 pixel data) aware which enables finding the address (offset) of
3266 the pixel data of JPEG encoded DICOM files. This leaves only a single
3267 file in the testSuite whose pixel data address (offset) is unknown.
3268 * python/testSuite.py changed accordingly.
3270 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3271 * VC++ has some strong limitations when working with the STL, as stated
3272 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3273 "Also note that some STL containers (map, set, queue, list, deque)
3274 cannot be exported. [...]
3275 Some STL classes contain nested classes. These classes can not
3277 This is caused by a designed limitation that once a template
3278 class is instantiated, it can not be re-instantiated and
3280 Since our usage of map<> is ubiquitous in gdcm, this "designed
3281 limitation" of VC++ is a pitfall.
3282 Hence the Python wrappers of gdcm cannot be incrementally linked
3283 against the c++ dynamic library. The dirty but only workaround is
3284 to forget about incremental link of dynamic libraries and to generate
3285 the Python wrappers library with the inclusions of the underlying C++
3287 The following modifications concern this matter on Win32/VC++:
3288 - wrapping python correct with standalone wrapped dll (don't use separate
3289 dll under windows !!!!)
3290 - python21_d debug mode enabled (ask Frog how to use it :-)
3291 - NO problem with having an STL member of class for example string in C++
3292 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3293 - Python test of dcmlib in Python is ok under windows on a large set
3295 * removed glib references
3296 * typedef's inserted in gdcm.i for correct swig type management
3298 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3299 * python/demo/*.py load.py extracted from test.py. Added explore.py
3300 that only displays required tags and testAll.py that parses all
3301 the files of the testsuite without using unittest.
3302 * python/testSuite.py other additional test on new files added.
3303 * Data/* new test files added accordingly to the testSuite.
3304 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3305 the vr in the file differs from the one of the dictionary.
3307 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3308 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3309 values, but limits itself to values which are below a user specified
3310 size (by default 1024 bytes).
3311 * python/gdcm.i : elements not loaded (because their size is above the
3312 user specified treshold) are exported with their TagKey as key of the
3313 python dictionary. This enables the testsuite to make some checks
3314 on the unloaded elements (since we have their offset and size).
3315 * python/testSuite.py
3316 - now tests for the existence and proper value of the pixel data
3317 - two new examples added.
3318 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3320 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3321 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3322 aware. See the strategy comments in gdcmHeader::FindLength().
3323 * Test/test.cxx now accepts a filename as first argument.
3324 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3325 * python/testSuite.py changed to integrate test on above files.
3327 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3328 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3329 the vr was also RET.
3330 * python/testSuite.py more tests added.
3332 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3333 * python/testSuite.py unittest test suite added (uses Data)
3334 * Data/* dcm and acr files for the test suite.
3335 * glib dependance removed from un*x version. We now use ISO C99
3336 7.18 Integer types (see stdint.h)
3337 - python/Makefile, src/Makefile src/gdcm.h
3338 * src/ when an explicit vr (like dicom files) suddenly poped an
3339 implicit element we use to mark the underlying DictEntry of the
3340 concerned ElValue with "Implicit". This strategy was damageable
3341 too the public or provite dictionaries, since some of their vr
3342 would be changed. Since Header::FindLength heavily relies on the
3343 detection by Header::FindVR of falsely explicit elements, I
3344 added an extra ImplicitVr member to ElValue (boolean).
3345 The rest of the changes we the necessary adaptations.
3347 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3348 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3350 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3352 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3353 * Adaptation for porting to VC++:
3355 o forced to use std namespace (for string to be known)
3356 o all class use __declspec export style on WIN32
3357 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3358 (in stdlib.h on Win32 but in std:: for gcc)
3359 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3360 variable GDCM_DICT_PATH.
3361 * src/gdcmHeader.cxx verbose comments made discrete.
3363 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3364 * python/gdcm.i: added a typemap that converts a C++ hashing table
3365 to native Python dictionary.
3366 * python/demo/test.py:
3367 - now uses the native dictionary for exploration of gdcmHeader.
3368 - takes an optional filename argument (the file to parse).
3369 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3370 PubElVals hashing table.
3371 * Dicts/dicomV3.dic removed error prone trailing spaces.
3373 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3374 * Python wrapping process moved away from src/Makefile to
3375 newly created python/Makefile (as well as gdcm.i)
3376 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3377 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3378 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3379 from the environement variable GDCM_DICT_PATH (when existing).
3380 * src/gdcmDict::GetTag bug fix.
3382 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3383 * Straightforward temporary fixes for swig to build the python wrappers.
3384 src/Makefile now has a python working entry [by working we mean
3385 that we can import the shadow classes without errors].
3387 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3388 * hashtest.cxx removed (since already in Test)
3389 * src/gdcmlib.h renamed to src/gdcm.h
3390 * src/dcm.i renamed to src/gdcm.i
3391 * src/Makefile prepared for python wrapping
3393 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3394 * src/gdcmHeader.cxx :
3395 - Parsing of header is now separated from loading of element values
3396 (see gdcmHeader::LoadElements).
3397 - general clean up of hopefully all file access (creation of
3398 ReadInt16 and ReadInt32)
3400 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3401 * src/gdcmHeader.cxx :
3402 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3404 - SetLgrElem renamed to SetLength
3405 - GetLgrElem renamed to GetLength
3406 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3407 * src/gdcmElValSet.cxx fixed both GetElValue methods
3408 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3409 due to IdoDude was cleaned out.
3411 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3412 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3413 concentrates on finding the value representation (when it exists).
3414 RecupLgr now only finds the element value length, and it avoids
3415 returning the unecessary skL (skipped length).
3416 Also, offsetCourant was simply removed (with taille_fich) since
3417 it was redundant with the File position internals (by using
3418 ftell and fseek). This also made skL (see above in RecupLgr) usage
3420 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3421 on the libido specificities which are handled through class
3423 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3426 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3427 * Truckload of changes. Parsing of header is barely functional
3428 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3430 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3431 * src/gdcmHeader.cxx many addons of low level methods
3433 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3434 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3435 and _IdDcmSWAP_LONG.
3437 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3438 * This corresponds to all the changes decided at the meeting of
3439 May 23 2002. Needless to say we are running late...