1 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * python/setup.py now works on Un*x. (harder than I thougth)
3 * python/distutilsSwigCPlusPlus.py can now have include files
4 among the list of sources.
6 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
8 * modifications in MSVC projects
10 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
11 * As stated by the first lines of Test/ExceptionAndPython/README, it
12 looks like we can move back to original usage of exception within
13 src/gdcm* and hence remove the errno stuff that was introduced
14 as a quick and dirty fixture of this problem (added to the TODO).
15 * Doc/Doxyfile configuration file for Doxygen and corresponding
16 README file for usage added.
17 * Test/testWrite.cxx added. This new test comes from a split of
18 test.cxx that is now reverted to its original purpous i.e.
19 testing the proper parsing of a Dicom related file.
20 testWrite.cxx concentrates on testing the IO part of gdcm.
21 * Test/bug1.cxx (containing a bug on WIn32) added.
22 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
23 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
24 whose purpose is to publish the content of the TagNames of the
25 Dicom public dictionnary were not accessible without an
26 instance of class gdcmHeader.
27 - those methods are now static methods of gdcmDictSet and hence
28 require no instances at all to be invocated.
29 - within gdcmDictSet this change required to change some method
30 to class methods (i.e. are now static) among which SetDictPath
31 (renamed to BuildDictPath) and LoadDefaultPubDict.
32 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
33 the above changes by calling the new method classes of gdcmDictSet.
34 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
35 the above to be effective.
36 * python/gdcmPython: in order to wrap properly the above changes
37 for Python, swig version now needs to be > 1.3.17.
38 * python/gdcmPython/Makefile fixed to adapt itself to new
39 configure/make shema introduced by Johan Montagnat (thanks for the
40 contribution). Alas this Makefile cannot be turned into a proper
41 Makefile.am without some heavy changes in the configure.in
42 (for python dectection).
43 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
44 now avoids publishing the empty entries.
46 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * python/setup.py : bug fix concerning install under windows
49 * gdcm.dsw : bug fix concerning path for libraries for python !!!
51 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
52 * Dicts/dicomV3.dic : remove double spaces !!!
53 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
54 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
57 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
58 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
60 * src/gdcm.h clean up of JPR spurious comments.
62 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
63 * python/distutilsSwigCPlusPlus.py now properly collects the
64 shadow classes generated by "swig -c++" (gdcm.py in our case)
65 when using "python setup.py install".
66 * python/gdcmPython/__init__.py imports gdcm.py and only manually
67 reexports the working classes.
68 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
69 by the classical C errno scheme. This is to prevent an obscure
70 behavior of the python wrappers when importing wxPython.wx prior
71 to gdcmPython (which ended up in an abort call). An illustration
72 of this oddity can be found in the Test/ExceptionAndPython
73 subdir (see the README file). This problem probably due to
74 an combination of g++ and dynamic loading.
75 * added Test/ExceptionAndPython (see above)
77 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
78 * Changed the layout of the python part to avoid bloating main
79 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
80 i.e. the distutils arsenal. All the python related stuff is
81 again in a python subdir, but the package itself is now in
83 * setup.py was cleaned up:
84 - pythonIncludePath removed
85 - python setup.py bdist target is now functional.
86 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
87 collision with other packages). gdcmPython/demo/*.py changed
89 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
90 * python subdir moved to gdcmPython (preparation of distutils packaging).
91 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
92 distutils installer is operational.
93 * - gdcmPython/__init__.py now properly loads the swig generated
94 shadow classes (from gdcm.py).
95 - gdcmPython/demo/*.py changed to import the package gdcmPython
96 instead of gdcmPython/demo/load.py.
97 - gdcmPython/testSuite.py changed to import the package gdcmPython.
100 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
101 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
102 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
103 entries within the associated public Dicom dictionary resp. the same
104 information but sorted by the fourth field (PAT, IMG, DIR) of the
106 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
107 are now in the "???" group.
108 - python/gdcm.i changed accordingly,
109 - python/demo/printGroupedPublicDict.py added, that gives an example
110 of the above new functionalities in Python.
112 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
113 * src/gdcm.h, gdcmHeader.cxx:
114 - historic references to glib's g_malloc and g_free (#defined)
115 were definitively removed.
116 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
117 * src/gdcmElValSet.cxx:
118 - GetElement(guint32, guint32) renamed to GetElementByNumber.
119 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
120 - GetElValue(string) renamed to GetElValueByName.
121 - Added GetElementByName(string).
122 * src/gdcmHeader.cxx: added
123 - GetPubElValRepByNumber(guint16, guint16)
124 - GetPubElValRepByName(string)
125 - GetShaElValRepByNumber(guint16, guint16)
126 - GetShaElValRepByName(string)
127 - GetShaElValByNumber(guint16, guint16)
128 - GetShaElValRepByName(string)
129 - GetElValRepByNumber(guint16, guint16)
130 - GetElValRepByName(string)
131 - GetElValByNumber(guint16, guint16)
132 - GetElValRepByName(string)
133 * Doc/requirements.txt added.
135 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
136 * Test/Makefile building now depends on the one of libgdcm.so
137 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
138 pixel data) aware which enables finding the address (offset) of
139 the pixel data of JPEG encoded DICOM files. This leaves only a single
140 file in the testSuite whose pixel data address (offset) is unknown.
141 * python/testSuite.py changed accordingly.
143 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
144 * VC++ has some strong limitations when working with the STL, as stated
145 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
146 "Also note that some STL containers (map, set, queue, list, deque)
147 cannot be exported. [...]
148 Some STL classes contain nested classes. These classes can not
150 This is caused by a designed limitation that once a template
151 class is instantiated, it can not be re-instantiated and
153 Since our usage of map<> is ubiquitous in gdcm, this "designed
154 limitation" of VC++ is a pitfall.
155 Hence the Python wrappers of gdcm cannot be incrementally linked
156 against the c++ dynamic library. The dirty but only workaround is
157 to forget about incremental link of dynamic libraries and to generate
158 the Python wrappers library with the inclusions of the underlying C++
160 The following modifications concern this matter on Win32/VC++:
161 - wrapping python correct with standalone wrapped dll (don't use separate
162 dll under windows !!!!)
163 - python21_d debug mode enabled (ask Frog how to use it :-)
164 - NO problem with having an STL member of class for example string in C++
165 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
166 - Python test of dcmlib in Python is ok under windows on a large set
168 * removed glib references
169 * typedef's inserted in gdcm.i for correct swig type management
171 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
172 * python/demo/*.py load.py extracted from test.py. Added explore.py
173 that only displays required tags and testAll.py that parses all
174 the files of the testsuite without using unittest.
175 * python/testSuite.py other additional test on new files added.
176 * Data/* new test files added accordingly to the testSuite.
177 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
178 the vr in the file differs from the one of the dictionary.
180 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
181 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
182 values, but limits itself to values which are below a user specified
183 size (by default 1024 bytes).
184 * python/gdcm.i : elements not loaded (because their size is above the
185 user specified treshold) are exported with their TagKey as key of the
186 python dictionary. This enables the testsuite to make some checks
187 on the unloaded elements (since we have their offset and size).
188 * python/testSuite.py
189 - now tests for the existence and proper value of the pixel data
190 - two new examples added.
191 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
193 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
194 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
195 aware. See the strategy comments in gdcmHeader::FindeLength().
196 * Test/test.cxx now accepts a filename as first argument.
197 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
198 * python/testSuite.py changed to integrate test on above files.
200 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
201 * Dicts/dicomV3.dic removed all the trailing (RET) when the
203 * python/testSuite.py more tests added.
205 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
206 * python/testSuite.py unittest test suite added (uses Data)
207 * Data/* dcm and acr files for the test suite.
208 * glib dependance removed from un*x version. We now use ISO C99
209 7.18 Integer types (see stdint.h)
210 - python/Makefile, src/Makefile src/gdcm.h
211 * src/ when an explicit vr (like dicom files) suddenly poped an
212 implicit element we use to mark the underlying DictEntry of the
213 concerned ElValue with "Implicit". This strategy was damageable
214 too the public or provite dictionaries, since some of their vr
215 would be changed. Since Header::FindLength heavily relies on the
216 detection by Header::FindVR of falsely explicit elements, I
217 added an extra ImplicitVr member to ElValue (boolean).
218 The rest of the changes we the necessary adaptations.
220 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
221 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
223 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
225 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
226 * Adaptation for porting to VC++:
228 o forced to use std namespace (for string to be known)
229 o all class use __declspec export style on WIN32
230 - src/gdcmUtil.cxx new Exit method that wraps the exit call
231 (in stdlib.h on Win32 but in std:: for gcc)
232 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
233 variable GDCM_DICT_PATH.
234 * src/gdcmHeader.cxx verbose comments made discrete.
236 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
237 * python/gdcm.i: added a typemap that converts a C++ hashing table
238 to native Python dictionary.
239 * python/demo/test.py:
240 - now uses the native dictionary for exploration of gdcmHeader.
241 - takes an optional filename argument (the file to parse).
242 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
243 PubElVals hashing table.
244 * Dicts/dicomV3.dic removed error prone trailing spaces.
246 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
247 * Python wrapping process moved away from src/Makefile to
248 newly created python/Makefile (as well as gdcm.i)
249 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
250 * src/gdcmHeader::FindLength only looks for current vr when necessary.
251 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
252 from the environement variable GDCM_DICT_PATH (when existing).
253 * src/gdcmDict::GetTag bug fix.
255 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
256 * Straightforward temporary fixes for swig to build the python wrappers.
257 src/Makefile now has a python working entry [by working we mean
258 that we can import de shadow classes without errors].
260 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
261 * hashtest.cxx removed (since allready in Test)
262 * src/gdcmlib.h renamed to src/gdcm.h
263 * src/dcm.i renamed to src/gdcm.i
264 * src/Makefile prepared for python wrapping
266 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
267 * src/gdcmHeader.cxx :
268 - Parsing of header is now separated from loading of element values
269 (see gdcmHeader::LoadElements).
270 - general clean up of hopefully all file access (creation of
271 ReadInt16 and ReadInt32)
273 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
274 * src/gdcmHeader.cxx :
275 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
277 - SetLgrElem renamed to SetLength
278 - GetLgrElem renamed to GetLength
279 - ~gdcmHeader() made virtual to pesky warning messages at compile.
280 * src/gdcmElValSet.cxx fixed both GetElValue methods
281 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
282 due to IdoDude was cleaned out.
284 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
285 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
286 concentrates on finding the value representation (when it exists).
287 RecupLgr now only finds the element value length, and it avoids
288 returning the unecessary skL (skipped length).
289 Also, offsetCourant was simply removed (with taille_fich) since
290 it was redundant with the File position internals (by using
291 ftell and fseek). This also made skL (see above in RecupLgr) usage
293 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
294 on the libido specificities which are handled through class
296 * Test/implicit_vr.dcm dicom v3 in implicit value representation
299 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
300 * Truckload of changes. Parsing of header is barely functional
301 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
303 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
304 * src/gdcmHeader.cxx many addons of low level methods
306 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
307 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
310 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
311 * This corresponds to all the changes decided at the meeting of
312 May 23 2002. Needless to say we are running late...