1 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
3 Two problems appear when doing it :
4 - with the gdcmFile : when the GetImageData method is called, the pixels
5 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
6 datas (pixels). And each structure destruct the datas when it's
7 destructed. So we have two destructions for the same datas. To solve it,
8 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
9 datas or not. If it doesn't own datas, then they will not destroyed by
11 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
12 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
13 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
14 create a double destruction of the same DocEntry's. So, to solve it,
15 the TagHT is simply cleared and the DicomDir* elements are destroyed.
16 * TODO : add an entry concerning memory leaks in the DicomDir
18 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
19 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
20 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
23 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
25 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
26 after it have been deleted
28 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
29 * FIX: src/* fix the doxygen warnings.
30 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
31 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
32 was erroneously defined with a size of 15 instead of 16. [many thanks
33 to Jean Michel Rouet for pointing out this bug].
35 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
36 1. Finish merging JMR patch for writting DICOM from scratch
37 2. Fix -hopefully- bug with MONOCHROME and space vs null character
38 3. Use const ref when possible
39 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
40 5. A few more comments
41 6. CreateUniqueUID can now be called without parameter"
43 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
44 * ENH: Slightly bigger patch:
45 1. Getting toward full integration of JMR patch for writting dicom from scratch
46 2. Update Test to test part of this patch: CreateUniqueUID
47 3. File was not close properly in gdcmDict
48 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
49 5. Use of const ref instead of copy (speed issue)
50 6. Remove temporary (duplicate) string in TranslateToKey
51 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
52 8. Do not repeat virtual in subclasses
53 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
55 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
56 * Apply first patch toward better string comparison when dealing with broken
57 DICOM files. Essentially the string could be padded with a space instead
58 of a null character as defined by standard
60 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
61 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
62 because never used... and in the same time, that's remove some memory leaks
64 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * src/gdcmFile.cxx : now delete the PixelConvert instance.
66 * In examples and tests : change the type of image data variables from void*
67 to uint8_t*. Remmove all delete on image data variables
69 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
71 Verify the file pointer value before open the file, and if it's not null,
72 a verbose message is generated.
73 Close correctly the file when the file isn't considered dicom-like. The
74 correctly close is a call to CloseFile.
75 When closing the file pointer, test if its not null to close the file.
76 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
77 file. For an uncompressed image, the copied datas correspond in the least
78 case to the image size (calculated) or the image size specified in the
79 header. A verbose is generated if these two size mismatch
81 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
82 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
83 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
84 break under windows (with msvc6 compilation).
86 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
87 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
90 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
91 * Bugs fix for the Windows build with VC6
92 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
93 needed (only for projects required VTK). If the VTK is included in all
94 projects, there is conflicts with the jpeg lib of vtk when compiling the
95 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
96 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
97 when compiling the gdcm_wrap.cxx file (created by the compilation of the
99 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
100 (like it's already made for the cout use). Otherwise, conflict with the
103 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
104 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
106 - comments on the DicomDir::Method related usage added.
107 - now that we use the namespace gdcm, a lot of internal classes do
108 NOT need to be wrapped anymore.
109 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
110 DicomDir::Method) new example added.
112 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
113 * Improve string manipulation. I now inforce the notion of 'DicomString'
114 A DicomString can contain as many \0 as they want
115 and it is *always* of even length.
116 We only support odd length for very rare case.
117 And in the near future this should be removed.
119 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
120 * /binary_write/ gdcm source. Now even on big endian we are writting
121 little endian. This should -heopfully- fix some tests
123 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
124 * Now the dictionary is compiled into gdcm lib. This is a default
125 behavior, thus any dic file specified is picked before failback to
126 the one comiled into lib
128 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
129 * Change internals for gdcmDict. Don't use any 'new' any more.
130 This should definitely solve any leak problem, and we should be
131 as fast as before, as long as don't modify too much the dictionary.
133 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
134 * STYLE: ivars should start with a capital letter.
135 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
136 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
138 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
139 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
140 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
141 new 2004 dictionaries added (thanks to JPR).
142 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
143 * CLEANUP_ROUND (15) for gdcmPixelConvert
144 - RLEFrame::NumberFragments is now of type unsigned int
145 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
146 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
149 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
150 * Initial work in gathering all transfer syntax accessors. clearly
151 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
152 ivars, but only one transfersyntax (class) ivar with equivalent method on
155 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
156 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
157 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
158 discussed (plus I didn't like having a 2000 lines patch not commited)
160 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
161 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
162 * CLEANUP_ROUND (14) for gdcmPixelConvert
163 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
164 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
165 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
167 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
168 anymore and hence avoids storing a copy of PixelConvert::Decompressed
169 into File::Pixel_Data.
171 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
172 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
173 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
174 * CLEANUP_ROUND (13) for gdcmPixelConvert
175 Substituted File::ParsePixelData() with PixelConvert::Print() new
177 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
178 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
179 method to those classes.
180 - src/gdcmFile.[cxx|h]:
181 -- Added a ::Print() method.
182 -- PixelConverter is now a reference instead of a member.
183 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
184 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
186 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
187 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
188 collaboration diagram and inheritance diagram should be generated with
190 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
191 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
192 pointlessly wrapped (see
193 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
194 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
195 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
196 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
197 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
198 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
199 -- File::Initialise: PixelConverter setup moved away to
200 PixelConverter::GrabInformationsFromHeader()
201 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
202 interpretation moved away to PixelConverter::BuildRGBImage()
204 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
205 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
206 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
208 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
209 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
210 displayed on Win32 when a brutal abort() occurs (because of uncatched
211 exception). See TODO new entry of this commit for more on this.
212 * TODO added new entry.
213 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
214 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
215 - HandleColor is no longer called from gdcmFile.cxx
216 - gdcmPixelConvert.cxx clean up on method arguments and internal
217 variable names for semantical coherence.
219 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
220 * Finished lossless transition, not only do we now read all lossless jpeg
221 images, without the need of the Cornwell lib, but we do read them properly now
222 * To reduce code (well to avoid code duplication), I defined a common place
223 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
224 redefine symbols. This is not prefect but this the best solution I found for a
225 compilation time jpeg option.
227 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
228 * Update jpeg ijg lib to support lossless jpeg implementation
229 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
231 * Also added a special copyright for dcmtk since we use their bugfixes.
234 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
235 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
236 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
237 matters, as stated in warning note at begining of %include section).
238 * src/gdcmDicomDir*.[cxx|h]: coding style
239 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
240 * src/gdcmJpeg8.cxx: doxygen fix.
241 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
242 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
243 from File:: to PixelConvert::.
245 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
246 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
247 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
248 - more code moved away from File:: to PixelConvert::
249 - fat setup of PixelConverter set in place in File::Initialise.
251 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
252 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
253 namespace at the file system level. So now you should convert your examples
255 gdcmHeader -> gdcm::Header
256 It would be nice if people keep in mind to no open the namespace, since it
257 allows compilation on broken plateform which were defining common symbol in
258 the standart namespace (like LP, Unknown ...)
260 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
261 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
262 The JPEG fragments are now parsed at the same stage than the RLE
263 information. All code related to JPEG is now in gdcmPixelConvert:
264 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
265 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
266 export a gdcmFile:: method. Those are simply global functions
267 (for the time being this is better than having them attach to
268 either gdcmFile:: or gdcmPixelConvert::).
269 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
270 and stores the result in a gdcmJPEGFragmentsInfo.
271 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
272 code (among other stuff) moved away from gdcmFile:; to
275 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
276 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
277 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
278 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
279 clean up of RLE related code.
280 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
281 - src/gdcmRLE.cxx removed
282 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
283 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
284 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
285 * CLEANUP_ROUND (9) for gdcmPixelConvert
286 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
287 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
288 away from gdcmFile:: to gdcmPixelConvert::.
290 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
291 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
292 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
293 This is because Parse7Fe0 used to parse the pixels to compute the
294 length. This task was passed over to FindDocEntryLengthOB() a long
295 time ago, EXCEPT I had forgotten the OW case...
296 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
297 we just recylce the code for parsing RLE fragments and computing
299 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
300 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
301 with the retired Parse7Fe0().
302 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
303 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
305 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
306 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
307 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
308 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
309 - src/CMakeLists.txt: alphabetic order reodering + new entries.
310 * CLEANUP_ROUND (4) for gdcmPixelConvert
311 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
312 to return an unused length.
314 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
315 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
316 this should be cleanner from the plane view. The iostream are erally a pain
317 to use to do simple stuff.
319 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
320 * Redo the compilation of the ijg jpeg library. Now only one source is
321 necesseray. No need to rename file by hand what so ever. CMake handle the
322 copying of the file within different directory, configure header file to
323 modify some symbol. The only addition made to ijg wasd a mangle table so
324 that symbol are different wether we are within 8bits or 12bits.
326 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
327 * Added documentation of vtkgdcmReader on Website:
328 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
329 with it's binary name).
330 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
331 the Website to be more complete.
332 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
333 doxygenated documentation.
334 - Doc/DoxyVtkGdcmReaderExamples.txt added
335 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
336 DoxyVtkGdmReaderExamples.html )
337 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
338 * CLEANUP_ROUND (3) for gdcmPixelConvert
339 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
341 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
342 * CLEANUP_ROUND (2) for gdcmPixelConvert
343 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
345 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
346 * CLEANUP_ROUND for gdcmPixelConvert:
347 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
348 - src/gdcmPixelStuff[h|cxx] removed
349 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
350 - src/CMakeLists.txt changed accordingly
352 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
353 gdcmVersion.py moved to newly created ATTIC related
354 gdcmPython/SetupOldies/ directory.
355 * Autotools clean up:
356 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
357 - autogen.sh configure.in acinclude.m4 python.m4 removed
359 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
360 * src/*.cxx *.h Reference to License.htm fixed to License.html.
361 * Doc/CMakeLists.txt, doxygen.config.in: fix.
362 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
364 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
365 * TODO updated with Mathieu suggestions. I proposed a template for
366 describing TODO entries and used it for new entries.
367 * Added Doc/Website/CodingStyle.html, Developpers.html,
368 DeveloppersPython.html, GdcmDataCvs.html and
369 DownloadVersion0_1.html, DownloadVersion0_3.html.
370 * Some Doc/*.txt Doxygen files (which do not really concern the
371 documentation itself, but the website) moved to html and
372 placed in directory Doc/Website:
373 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
374 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
375 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
376 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
377 * CMakeLists.txt changed accordingly.
378 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
379 DeveloppersPython.html
380 * INSTALL nows refers to Doc/Website/Installation.html
382 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
383 * Added Doc/Website directory, that contains a first raw version
386 2004-09-23 Jean-Pierre Roux
387 * FIX In order not to be poluted any longer by casting problems,
388 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
389 we can now delete[] it safely
390 * VoidArea is now called BinArea (less confusing name),
391 and all the methods called ...VoidArea... are now ... BinArea...
392 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
394 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
395 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
396 clear) TagHT, which is an inherited member of gdcmElementSet. It is
397 up to the destructor of gdcmElementSet to clean up TagHt and it's
400 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
401 * Test/CMakeLists.txt: update to follow gdcmData renamings.
402 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
404 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
405 * ENH: added some utility method that builds a flat dictionnary
406 holding all the Dicom entries contained in the recursive structure
407 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
409 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
410 BuildFlatHashTable() that build a flat dictionary.
411 - src/gdcmElementSet.h: added a new private GetTag() accessor.
412 gdcmDocument is now a friend of gdcmElementSet.
413 - src/gdcmElementSet.cxx: clean up.
414 - Example/FlatHashTablePrint.cxx added.
415 - Example/CmakeLists.txt changed accordingly
417 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
418 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
419 moved away from gdcmDocEntrySet (since this class is an abstract class
420 acting like an interface). SQDepthLevel and BaseTagKey are now
422 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
423 and associated accessors. Doxygenation of the class.
424 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
426 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
427 Use SQDepthLevel accessor instead. ::Print() adapted.
428 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
429 - src/gdcmDocument.cxx changed accordingly.
431 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
432 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
433 - The following is the doxygen comment of the typedef declaration
434 of gdcmagKey in src/gdcmCommon.h:
435 gdcmTagKey is made to old an "universal" (as in URL, Universal
436 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
437 A dicom tag allways has a group and an element, but a set of tags
438 embeded in various (optionally nested) sequences and sharing
439 the same group and element all share the same (group, element)
440 "identifier". Hence the (group, element) cannot be used as an
441 identifier (in gdcm we shall refer to a "TagKey") of a tag.
442 In order to construct a proper tag identifier (i.e. a key) we
443 consider the following definition of a TagKey:
444 - let Group, Element be the string representation of the
445 group and element dicom tag members,
446 - let ItemNumber be the string representation of the integer
447 index of the considered item number of a sequence,
448 Let the key of a tag embeded in a sequence, noted SeqTag, be
450 /ItemNumber#Group|Element
451 where "/", "#" and "|" are characters acting as separators.
452 Then the general form of a gdcmTagKey is given by:
453 Group|Element<SeqTag>
454 where <SeqTag> means NO or many instances of SeqTag.
455 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
458 but the gdcmTagKey of a tag "embeded" is the first item of
459 a sequence, itself nested in the third item of a sequence is the
461 0004|1220/2#0008|0082/0#0008|0090
462 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
463 order to hold the new sequence compatible key. Previously, the
464 GetKey() method would look in the underlying gdcmDictEntry.
465 - src/gdcmDocEntry.cxx:
466 -- constructor now copies the underlying DictEntry key, in the local
468 -- ::Print: displays the member Key, instead of the (group, element).
469 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
470 - src/gdcmDocEntrySet.h:xi
471 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
472 -- now has a new BaseTagKey member.
474 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
475 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
477 This poses the problem with the semantics of the following lines
478 LoadEntryVoidArea(0x0028,0x1201); // R LUT
479 LoadEntryVoidArea(0x0028,0x1202); // G LUT
480 LoadEntryVoidArea(0x0028,0x1203); // B LUT
481 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
482 to the long FIXME note for what the problem is. Nevertheless in
483 order to get things working the dicom dictionary was altered !
484 Please fix things urgently...
485 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
486 information), see above note on moving the member VoidArea. Nevertheless
487 the following entries previously correctly set as US are now inproperly
489 0028 1201 OW IMG Red Palette Color Lookup Table Data
490 0028 1202 OW IMG Green Palette Color Lookup Table Data
491 0028 1203 OW IMG Blue Palette Color Lookup Table Data
492 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
493 of gdcmDocEntry moved to gdcmSeqEntry.
494 * src/gdcmSeqEntry.cxx: STYLE.
496 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
497 * Test/TestAllEntryVerify.cxx minor fix and added comments.
499 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
500 * gdcmPython/testSuite.py: all the test suite in python is now moved
501 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
502 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
503 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
505 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
506 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
507 to avoid inclusion recursion until STL is reached.
508 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
509 mecanism. errno.h is not included in gdcm anymore.
510 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
511 (gdcmFormatError now inherits from gdcmFormatUnexpected).
513 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
514 gdcmData/TestAllEntryVerifyReference.txt
515 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
516 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
517 exception_on_error parameter.
518 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
519 - vtk/vtkGdcmReader.cxx changed accordingly,
520 - Example/*.cxx and Test/*.cxx changed accordingly.
522 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
523 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
524 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
525 enable_sequences removed from gdcmHeader constructor and dependencies.
526 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
527 * gdcmPython/demo/PrintHeader.py: dummy fix.
528 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
529 skip_shadow removed from gdcmHeader constructor and dependencies.
530 * Example/*.cxx and Test/*.cxx changed accordingly.
532 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
533 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
534 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
536 2004-07-21 Jean-Pierre Roux
537 * FIX Now, Parsing and Printing a DICOMDIR do work!
538 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
540 2004-07-20 Jean-Pierre Roux
541 * FIX Some brain damaged headers have Zero-Lenght fields
542 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
544 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
545 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
546 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
547 variable (instance of gdcmDebug) by a definition macro, and the instance
548 is now in static in the gdcmDebug class
549 * src/gdcmSQItem.h : (FIXME) remove an undefined method
550 * Test/PrintAllDocument.cxx : bug fix in the result of the test
552 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
553 * WARNING: ctest now depends more tightly on gdcmData. You should
554 check out gdcmData properly for things to run smoothly...
555 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
556 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
557 we need the pixels not be loaded in order to use the ValEntry
558 that displays position and size).
559 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
560 This is a C++ based equivalent of gdcmPython/testSuite.py that should
561 be deprecated. If you have any doubts about the advantages of a
562 modern scripting language (read Python) versus grass root C++ (i.e.
563 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
564 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
565 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
566 Anyhow, consider documenting the gdcmData images in
567 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
569 * Test/CMakeLists.txt:
570 - now uses TestAllEntryVerify.cxx
571 - specific comments on oldACR00001.ima (now renamed in gdcmData
572 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
573 gdcmData/TestAllEntryVerifyReference.txt
576 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
577 * src/*.[h|cxx] : typedef clean up
578 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
579 - TagKey renamed to gdcmTagKey (for external usage)
580 - VRKey renamed to gdcmVRKey (for external usage)
581 - removal of typedef duplication.
582 - Removed all unecessary inline keyword from class inline definitions.
583 - Some method|function(void) declarations replaced with method|function().
584 * src/jpeg/libijg12/jdhuff12.c:
585 - printf polluting ctest removed.
586 - TAB removal for comminting
588 - TestAllReadCompareDicom.cxx: added a test that compares all the
589 images in gdcmDataImages.h with corresponding images in
590 gdcmData/BaselineDicom/. When baseline images are not present
591 this test creates them.
592 Note: we need to validate each reference image, but before that
593 I'd like to rename them with a more explicit name...
594 - CMakeLists.txt: changed accordingly.
595 * Example/*.cxx: examples now only include gdcm.h (as opposed to
596 including each header needed).
598 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
599 * Test/*.cxx and Example/*.cxx: moved some examples away from the
600 test suite to the Example directory. Are concerned:
605 - TestWriteSimple.cxx
606 * Test/CMakeLists.txt: added some comments on reasons for black listing
607 image gdcmData/oldACR00001.ima
609 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
610 * Test/CmakeList.txt: removed the following from black list (to be coherent
611 with removal from gdcmData):
612 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
613 - gdcm-MR-PHILIPS-16.dcm
615 Added the following because after last cvs update, they cause
616 ctest -R TestReadWriteReadCompare
618 - gdcm-MR-SIEMENS-16-1.acr
620 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
621 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
622 new comments in this file) we temporarily (sigh) move to a weaker
624 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
625 we don't need to black list the following images anymore:
626 - 8BitsUncompressedColor.dcm
628 - US-PAL-8-10x-echo.dcm
629 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
630 fixes and the beautified code ;-)
631 This fixes the bug introduced in version 1.42 (when beautifying)
632 that made the parsing of 8BitsRunLengthColor.dcm unproper.
633 Note: ctest was blind to this bug (this means we need to still
634 improve the test suite). The bug could be detected by using
635 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
637 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
638 and by displaying the (garbage) produced file temp.XDCM...
640 2004-06-29 Jean-Pierre Roux
641 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
642 - replace by uggly but working old code :-(
643 A lot of things should be OK again.
644 It's really urgent to have a test suite that *tests*,
645 to prevent Frog's beautifying sessions to break all the stuff
646 (twice, withing a fortnigh ...)
648 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
649 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
650 redundancy) to added Test/TestReadWriteReadCompare.cxx
651 * Test/CmakeList.txt: because the compare test of
652 Test/TestReadWriteReadCompare.cxx fails, the following images are
653 black listed: - 8BitsUncompressedColor.dcm
655 - US-PAL-8-10x-echo.dcm
656 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
657 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
658 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
659 and ad-hoc kludge. This kludge is now removed, and on encountering
660 such an image (OB field brain damaged) we set errno. Then in
661 ::FindDocLength() we "fix" the length as being ALL what remains
662 in the file (until EOF). We then proceed, hoping for the best...
663 This fixes a SegFault in ShowDicom when trying to write such an
665 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
666 (because TestWriteRead breaks on it, after a non conformal commit?).
667 ctest now runs properly, except for MakeDicomDir (which was allways
668 broken) and the Python related stuff (still not fixed).
670 2004-06-24 Jean-Pierre Roux
671 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
672 FIX : Test/TestReadWrite now iterates on all the file names
673 (instead of infinite loop)
674 ENH : Test/TestWriteRead now iterates on all the file names
676 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
677 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
679 2004-06-24 Jean-Pierre Roux
680 FIX : - now Write drops LUT Descriptors and LUTs (if any)
681 when SamplesPerPixel =3
682 - now Write is no longer confused by
683 'BitsAllocated = 12" and 'BitsStored=12"
684 - "UN" value representation Elements are now written correctly
685 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
686 ENH : - now gdcmHeader has its own Write methods
687 (in order to split the job that has not to be done
690 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
691 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
692 loop on the same image until memory went out.
693 Note: this means we still have gobs of memory loss in PrintDocument
694 * src/gdcmDocument.cxx: fixes problem on parsing on file
695 gdcmData/16BitsJpegLosslessGrayScale.dcm.
697 2004-06-24 Jean-Pierre Roux
698 FIX : Write - All the Sequences and Sequence Item are now written
699 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
700 is added a the end, when necessary.
701 - A lot of brain-damaged images, that were read correctly are
702 now written correctly
703 - length compatible BinEntry are now loaded correctly
704 (even for odd groups)
705 Note : only Explicit Value Representation was checked.
706 (question : is implicit VR really necessary for gdcm ?)
708 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
709 * DEVELOPPER: added a proposition of coding style.
710 * src/gdcmDocEntry.h: removed every inline declaration (for test of
713 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
714 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
715 Use the gdcmDocEntry::Print() and Write() instead.
716 * src/gdcmDocument.cxx: bug fix.
718 2004-06-22 Jean-Pierre Roux
719 FIX : gdcmDocument.cxx
720 - Now we do recognize the JpegLossLess format (there was a misstyping in
721 code 'beautyfication' :-(
722 - Now we automaticaticaly load the Luts, if any
724 2004-06-22 Jean-Pierre Roux
725 In order : to write Sequences, whatever their imbrication level,
726 : to allow user to create his own Sequences
727 a lot of modif where necessary (adding, moving, or virtualising methods)
729 WARNING : save your own sources *before* cvs up !
732 ADD virtual void Write(FILE *fp, FileType filetype);
735 ADD virtual void Write(FILE *fp, FileType filetype);
736 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
739 ADD virtual void Write (FILE *fp, FileType filetype)=0;
740 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
741 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
742 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
743 ADD std::string GetEntryByName(TagName name);
744 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
746 std::string vr = "unkn",
747 std::string fourth = "unkn",
748 std::string name = "unkn");
749 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
750 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
751 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
752 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
753 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
754 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
755 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
756 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
759 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
760 ADD virtual std::string GetEntryByName (TagName tagName);
761 ADD virtual std::string GetEntryVRByName (TagName tagName);
762 REM virtual bool Write(FILE *, FileType);
763 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
764 FILE *_fp, FileType type);
765 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
766 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
767 REM virtual bool WriteEntries(FILE *_fp,FileType type);
768 REM virtual std::string GetEntryByName (std::string tagName);
769 REM virtual std::string GetEntryVRByName (std::string tagName);
770 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
771 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
772 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
774 std::string vr = "unkn",
775 std::string fourth = "unkn",
776 std::string name = "unkn");
777 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
778 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
779 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
780 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
783 ADD virtual void Write(FILE *fp, FileType filetype);
786 ADD virtual void Write(FILE *fp,FileType filetype);
789 ADD virtual void Write(FILE *fp, FileType filetype);
790 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
791 REM std::string GetEntryByNumber(guint16 group, guint16 element);
792 REM std::string GetEntryByName(TagName name);
795 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
797 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
798 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
799 The default constructor invoked by the line
800 gdcmHeader *f1 = new gdcmHeader( header );
801 was gdcmHeader::gdcmHeader(bool) instead of the expected
802 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
803 Hence the parsing wasn't executed... See also below.
804 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
805 as explicit constructor didn't do the trick to fix the above problem.
806 Could anyone explain why ?
807 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
808 properly calls gdcmValEntry::Print() (that was weed out from
809 code related to gdcmBinEntry).
811 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
812 * In order to fix memory leaks:
813 - Test/TestWriteSimple.cxx: added cleaning of free store through
815 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
816 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
817 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
818 (through the call to ::AddDicomDirMeta()) or the destructor
819 would crash when deleting uninitialized ::metaElems].
820 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
821 - src/gdcmDocument.cxx:
822 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
824 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
825 was causing memory leaks.
826 - src/gdcmSQItem.cxx:
827 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
828 cleanly handled with polymophism: sorry but my milage is low).
829 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
830 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
831 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
832 This avoids SegFaulting.
833 - src/gdcmSQItem.h: coding style.
835 - Test/TestWriteSimple still severely sucks. The output image content
836 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
837 damaged when displayed with vtkgdcmViewer.
838 - on memory leaks: TestWriteSimple leaks really less (see entry
839 of 2004-06-18 in Changelog file for the call to valgrind).
840 - on segfaults: ctest now passes all the tests but one (no more
842 * Erroneous leading white fix:
843 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
844 white[s] (as opposed to from >> xxx, that removes it [them].
845 - src/gdcmTS.cxx: ditto.
846 - gdcmPython/testSuite.py: dirty related kludge removed.
847 * src/*: remaining references to gdcmParser removed.
848 * src/*[cxx|h]: added copy[way]left header.
851 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
852 * In order to fix writing of dicom files:
853 - Test/TestWriteSimple.cxx: a simpler example of writing.
854 - Test/CMakeLists.txt changed accordingly.
855 - src/gdcmDocument.cxx:
856 -- The destructor now recursilvely removes potential sequences.
857 -- Bug fix in ::IsJPEG2000()
858 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
859 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
861 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
862 to only declared) and build on top of
863 ::GetDocEntryByNumber(guint16, guint16).
864 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
865 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
866 for usage in destructor and treatement of promotion in
867 ::ReplaceOrCreateByNumber().
868 - src/gdcmSQItem.cxx: destructor should better handle his job.
869 Test/TestWriteSimple now runs (or at least it DOES something).
870 * We can now start hutting memory links. A good starting point is:
871 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
872 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
873 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
875 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
876 * Valgrind note: after Mathieu Malaterre teached me how to read
877 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
879 Using gcc, you can force the STL to use malloc and to free memory as
880 soon as possible by globally disabling memory caching.
881 With 3.2.2 and later, you should export the environment variable
882 GLIBCPP_FORCE_NEW before running your program.
883 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
884 simply vanish (it is still not clear to me, whether this means that
885 STL std::string leaks or if valgrind believes it leaks...).
886 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
887 running bin/gdcmTests makeDicomDir):
888 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
889 - Test/makeDicomDir.cxx now properly traps empty lists and returns
891 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
892 SegFaulting (I drowned in DicomDir related code when trying to
893 understand why the list is empty...).
894 * src/gdcmDocument.h: first BSD license header try.
895 * Doc/License.txt added.
897 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
898 * src/gdcmDocument.[h|cxx]:
899 - Clean up of the Transfer related predicates. They are now all based
900 on new method isGivenTransferSyntax, that (should) handle properly
902 - general clean up, simplification, and coding style.
903 - Specific clean up of Parse7FE0() (umproperly named actually).
904 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
906 2004-06-14 Jean-Pierre Roux
908 - fix the display of Sequence Delimitor (SQDepthLevel pb)
909 - fix the display of SQItem ordinal number
910 - add the GetSQItemByOrdinalNumber method
911 - remove some useless never written private methods
913 2004-06-14 Jean-Pierre Roux
915 - adding a constructor taking a gdcmDocEntry as an input param
916 - ReplaceOrCreateByNumber now returns :
917 a gdcmBinEntry * if a Binary (void *) value is passed as a param
918 a gdcmValEntry * if a string value is passed as a param
920 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
921 according to the param type (no longer sets a gdcmDocEntry)
922 - GetValEntryByNumber, GetBinEntryByNumber added
923 - NewValEntryByNumber and NewBinEntryByNumber added
925 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
927 - GetSQItemNumber and SetSQItemNumber added, to provide
928 a (relative) Item identier inside a given Sequence
929 \warning : some pb remaining around this number
931 - AddEntry now takes the Item Number as a param
933 - adding a constructor taking a gdcmDocEntry as an input param
935 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
936 * Memory leak hunt with the following command:
937 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
938 --show-reachable=yes gdcmTests PrintDocument
939 It looks like many (all?) leaks are due to the STL (or a bad usage
940 of the STL. The lines producing the leaks now have a comment with
941 a "MEMORY LEAK" tag: you can retrieve them with
942 grep "MEMORY LEAK" src/*
943 Here are two typical examples which I can't help fixing:
948 char * test = "babo";
949 name = test; //// <--- valgrind detects 960 bytes lost in
950 //// call to std::string::operator=(char const*)
951 name.clear(); //// Doesn't help !
959 std::cout << "Type a bunch of characters followed by RETURN: ";
960 getline(std::cin, line); //// <--- valgrind dectects a loss
961 //// of 1320 bytes in call to
962 /// std::basic_istream<>& std::getline<>
968 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
969 * src/gdcmHeader.[cxx|h]:
970 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
971 and related, moved away to gdcmDocument.
972 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
973 the corresponding protected accessors of inherited class
974 gdcmDocument, removed ! As a consequence gdcmFile had to be
975 declared friend of class gdcmDocument (see below).
976 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
977 - Clean up of undefined or unused methods.
978 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
979 account the changes to gdcmHeader.h).
980 * src/gdcmDocument.h:
981 - gdcmFile is now a friend class (in order to take into account the
982 changes to gdcmHeader.h).
983 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
984 (see changes to gdcmHeader.h).
985 - Accessors (reading on the form GetEntry*) are now public.
986 - Clean up of undefined or unused methods.
987 * src/gdcmDocument.cxx:
988 - adaptation to changes to gdcmDocument.h
989 - ::OpenFile now writes a verbose message when file cannot be opened.
990 - some std::string properly set to VRKey
991 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
992 references to gdcmDocument.
993 * Test/TestFindTags.cxx: changed accordingly to above changes.
994 * gdcmPython/testSuite.py: adapted to renaming of acr files in
995 cvs repository gdcmData.
997 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
998 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
999 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1000 conflicts with gdcmValEntry::voidArea.
1001 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1002 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1003 Value representation between StringRepresentable and BinaryRepresentable.
1004 * src/gdcmDocument.cxx:
1005 - method ParseDES: proper indentation restored and usage of
1006 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1007 - method LoadDocEntry: the fingerprint left in the SetValue() of
1008 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1009 removed. Reverting to previous code segment with the proper
1010 dynamic_cast< gdcmValEntry* >.
1011 Note: this was (partially) breaking the python test suite
1012 (gdcmPython/testSuite.py) that made usage of the above
1013 fingerprint to check presence of "Pixel Data".
1014 * src/gdcmDocEntry.h: coding style.
1015 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1016 now taken into account.
1017 * gdcmPython/gdcm.i: adaptation to the new internal representation
1018 of gdcm (exit gdcmParser, hello gdcmDocument).
1019 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1021 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1022 anymore, but instead prints the loaded Python dictionary.
1023 * .... alas, the python testSuite is still broken.
1025 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1026 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1028 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1029 * src/gdcmUtil.h : export methods
1031 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1032 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1034 * Initial addition of automatic python testing
1035 * Initial addition of automatic image comparison
1037 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1038 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1039 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1041 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1042 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1043 * Test/ShowDicom.cxx : bug fix for msvc compilation
1044 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1046 2004-05-04 Jean-Pierre Roux
1047 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1048 new concepts (and new classes) :
1049 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1050 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1051 - Sequence Doc Entries (gdcmSeqEntries)
1052 a Sequence is composed of Items.
1053 Each item is a set of Doc Entries (this is recursive)
1054 The non uniqueness of the 'Dicom tag' is due to this recursivity
1055 (never taken into account)
1056 Our unability to add a new 'entry' in the header
1057 at the proper location (neither in the H-Table (map or multimap),
1058 nor in the Chained List is also due to this recursivity.
1059 Don't try, right now, to use/modify/compile these new sources :
1060 nothing is finished.
1061 We just commit all the stuff, 'as is', in order not to loose it.
1063 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1064 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1066 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1067 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1068 file prefix (SetFilePrefix)
1070 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1071 * Add a new test: ShowDicom, for now this is just the c++ version of
1072 checkRead.sh, later it will be able to compare the image read against a
1074 * Replace the DEBUG on the stack with a global entry in cmake interface:
1075 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1077 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1078 * Add an example subdir, with a real example on how to read + write a
1081 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1082 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1083 * Doc/CMakeLists.txt: the main page is now properly differentiated
1084 between the developper and user version.
1085 * Doc/doxygen.config.in: dropped search related obsolete flags
1086 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1088 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1089 * DEVELOPPER: added some helpfull comments for compile/test/install
1092 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1093 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1094 src directory, now generated in the build dir.
1095 2. Tests as mentionned smarter
1097 4. Add a new method in gdcmDict that return the PubDict by name
1098 this is interesting for 3rd party lib like ITK,
1099 where we could set the institution name / patient name...
1101 * ENH: 1. Now the test suite is working for real
1102 2. All binaries are now output in the gdcm-bin directory
1103 (this was not true before)
1105 2004-04-28 Jean-Pierre Roux
1106 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1107 SeQuence indented printing of Dicom Header.
1108 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1109 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1110 Computation of SQDepthLevel is now part of gdcmHeader constructor
1111 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1112 tree-like structure of a Dicom Header.
1113 * FIX Test code cleaning
1115 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1116 * ENH: Adding automatic testing
1117 1. Need a DartConfig.cmake to submit to public
1118 2. Add a test driver gdcmTest.cxx
1119 3. gdcmTestMain, an helper for the main test driver gdcmTest
1120 4. Files in Test don't have a main anymore, this becomes interesting
1121 when we add more and more tests, thus dsw don't have to load
1123 * ENH: Adding a GDCM_DATA_ROOT for testing
1124 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1125 one file instead of seven + some small cleanup
1127 2004-04-22 Jean-Pierre Roux
1128 * ENH Minor changes to the Print() methods.
1129 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1130 Header printing. Example given with :
1131 > PrintHeader fileName 2 new
1132 (SQ based tree-like structure still to be done for the Header ...)
1134 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1135 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1136 1. I have added some unsigned where needed
1137 2. Some function parameter not used -> (void)
1138 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1139 4. g++ don't like character '\' in comment
1140 5. #define jpeg_create_decompress jCreaDecompress
1141 this really need to be fixed
1142 6. virtualize destructor of gdcmObject ... leakage
1143 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1144 this also really need to be fixed
1145 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1146 remove compression file
1147 (as we only do decompression, right ?)
1148 * ENH: Change malloc/calloc/free with c++ equivalent
1150 2004-04-21 Jean-Pierre Roux
1151 * FIX gdcmHeaderHelper::GetXSpacing
1152 when a single value is found (bug ?), xpacing is now
1153 defaulted to yspacing
1155 2004-04-19 Jean-Pierre Roux
1156 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1157 * ENH add parameters :
1158 bool exception_on_error = false,
1159 bool enable_sequences = false,
1160 bool ignore_shadow = false
1161 to the gdcmFile constructors to be full gdcmParser compliant
1162 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1163 to allow reading of PAPYRUS 3.0 files
1165 2004-04-06 Jean-Pierre Roux
1166 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1168 2004-04-02 Jean-Pierre Roux
1169 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1170 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1171 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1173 2004-03-30 Jean-Pierre Roux
1174 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1175 for ACR file, written out as DICOM files (hope so...)
1177 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1178 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1179 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1180 moved to base class gdcmParser and only the specialisation is kept
1182 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1183 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1184 already does the job.
1185 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1186 (to be consistent with gdcmParser::WriteEntries).
1188 2004-03-30 Benoit Regrain
1189 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1190 upate of the object's instance. It's passed to 2 in the unfavorable
1191 case : one in the ExecuteInformation, one in the ExecuteData
1193 2004-03-29 Jean-Pierre Roux
1194 * ENH : Check on file type to be written moved
1195 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1196 * FIX : gdcmObject::ResetBoundaries now stops properly
1197 when end-of-list is reached
1198 : gdcmVersion modified (as Benoit Regrain asked)
1200 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1201 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1202 * src/gdcmUtil.cxx: added forgotten iostream include.
1203 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1204 equivalent to ExplicitVR in existing code).
1206 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1207 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1208 now contains all the gdcmGlobal related code.
1209 * minor coding style and doxygenation changes.
1211 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1212 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1213 now contains all the Debug related code.
1214 * minor clean-up of includes in src/*.cxx
1215 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1216 CreateCleanString) removed.
1217 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1218 * Doc/DoxyMainPageUser.txt added.
1219 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1220 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1221 src/gdcmDirList.cxx)
1223 2004-03-24 Jean-Pierre Roux
1224 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1226 2004-03-23 Jean-Pierre Roux
1227 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1228 big endian made volumes
1229 * ENH Now gdcmParser constructor and destructor are protected to forbid
1230 end user to instanciate class gdcmParser
1231 (only gdcmHeader and gdcmDicomDir are meaningfull)
1233 2004-03-22 Benoit Regrain
1234 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1235 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1236 gdcmSerie to gdcmDicomDirSerie
1238 2004-03-19 Jean-Pierre Roux
1239 * ENH Now the tree-like structure describing a DICOMDIR comming from
1240 an already existing DICOMDIR file is consistent with
1241 the home-made tree-like structure build ex-nihilo
1242 or build from the files held (recursively) in a Directory
1243 functions gdcmDicomDir::CheckBoundaries()
1244 gdcmObject::SetBoundaries() added
1246 2004-03-17 Jean-Pierre Roux
1247 * REM (Eric Boix bug) : removal of meaningless
1248 gdcmDicomDirImage::NewImage function.
1249 * FIX now file names and directory name are written properly in the
1251 * FIX now gdcmDicomDir constructor may be call without any trick
1254 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1255 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1256 of gdcmDicomDirImage::NewImage as empty function.
1258 2004-02-28 Jean-Pierre Roux
1259 * ENH add gdcmDicomDir:NewPatient
1260 add gdcmDicomDirPatient:NewStudy
1261 add gdcmDicomDirStudy:NewSerie
1262 add gdcmDicomDirSerie:NewImage
1263 to allow making gdcDicomDir object.
1264 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1265 (as opposite to the gdcmHeader chained list)
1267 2004-02-11 Benoit Regrain
1268 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1269 when using from python
1271 2004-02-10 Benoit Regrain
1272 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1273 * FIX : in gdcmDicomDir when the directory is empty
1274 * ENH : add callback and methods to get the progression of dicomDir
1277 2004-02-06 Jean-Pierre Roux
1278 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1279 - GDCM_META added to gdcmDicomDirType
1280 - class gdcmMeta created
1281 * ENH : - A brief summary is now displayed at the beginning of
1282 'testDicomDir' to help disaster magnitude estimation
1283 * REM : Now useless Test/explDICOMDIR.cxx
1285 2004-02-05 Benoit Regrain
1286 * ENH : add methods in gdcmObject to get the hash table or the list of
1288 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1289 * FIX : wrapping python for TagHeaderEntryHT
1291 2004-02-04 Benoit Regrain
1292 * FIX : even length for some strings when writting the dicom dir
1293 * FIX : sort the images in the dicom dir
1294 * FIX : Bug fix for python use of dicom dir
1295 * ADD : a python demo
1297 2004-02-04 Jean-Pierre Roux
1298 * FIX : Final solution (?) for icone embedded images
1299 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1300 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1301 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1302 gdcmData/gdcm-MR-SIEMENS-16.acr1
1303 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1304 to make full checking easier
1306 2004-02-04 Benoit Regrain
1307 * FIX : WriteEntries : coding style & logic in parameters
1308 * FIX : Set the elements to create the DicomDir in a dictionary file
1310 2004-02-03 Benoit Regrain
1311 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1312 * gdcmDicomDir : add the load of directory
1313 * Bug fix and print add-on
1315 2004-02-03 Jean-Pierre Roux
1316 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1317 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1318 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1319 * FIX gdcmParser.cxx : 'group length' elements are now considered
1320 as integers, even for shadow groups, when file is Implicit VR
1322 2004-02-02 Jean-Pierre Roux
1323 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1325 of the last synonym :-(
1326 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1328 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1329 * FIX taking into account the possible 7fe0,0010 multiplicity
1330 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1331 to allow removal of references to 7fe0,0010, to deal with
1332 ACR-NEMA images, when 0028,0200 is meaningfull
1334 2004-01-31 Jean-Pierre Roux
1335 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1336 no longer writes 'Un' on disk
1337 * FIX SQ elements with actual length are now dealt with corectly
1338 * FIX gdcmFile::WriteBase make the difference, for color images, between
1339 the length (for Palette expanded images)
1340 and Raw Length (non expanded image + Palette)
1341 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1342 (that broke Write). Replaced by UL.
1343 Aware user will reload the field if he
1344 thinks it's necesssary
1346 2004-01-30 Jean-Pierre Roux
1347 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1348 when 'dirty Acr' is found, to be compliant with the new
1349 IsReadable() methods.
1351 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1352 (no DOUBLE images in kosher DICOM,
1353 but so usefull for people that miss them ;-)
1355 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1356 DICOMDIR related utilities (not checked as Windoze compliant)
1358 2004-01-28 Jean-Pierre Roux
1359 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1361 2004-01-27 Jean-Pierre Roux
1362 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1363 to allow skipping the shadow elements, to save memory space.
1364 The TRUE value for this param has to be used
1365 with a FALSE value for the 'enable_sequence' param.
1366 ('public elements' may be embedded in 'shadow Sequences')
1367 * gdcmHeader methods now deal with 'embedded icones images' in the header
1368 (even when an 'icone image sequence' is announced by the
1369 element (0x0088,0x0200), but there is NO icone at all ...
1371 * gdcmHeader sometimes Image Location value doesn't follow
1372 the supposed processor endianity (see gdcmData/cr172241.dcm).
1375 * gdcmHeader add the method
1376 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1377 to get *all* the Header Entries with the same tag.
1378 GetHeaderEntrySameName is probabely *useless*
1379 (no meaning : Name is *not* an identifier within the Dictionnary)
1381 2004-01-26 Benoit Regrain
1382 * Bug fix in the print of hexadecimal representations. Remove long fields
1383 in the print and add a third level of print to print them
1385 2004-01-23 Benoit Regrain
1386 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1387 * Bug fix on test suite after remove the strip made on not string fields
1388 * Split the IsReadable method between gdcmParser which test that the file
1389 is dicom and gdcmHeader which test that it's an image file
1391 2004-01-22 Benoit Regrain
1392 * DicomDir : clean code, add methods, set variables in protected or private
1393 * gdcmUtil : bug fix for the clean string method
1395 2004-01-19 Benoit Regrain
1396 * Add the use of shadow dictionaries
1397 * bug fix and coding style
1399 2004-01-19 Benoit Regrain
1400 * src/gdcmFile.cxx : bug fix concerning the close of file
1401 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1402 * Add the update of header entries using the shadow library
1404 2004-01-19 Benoit Regrain
1405 * removal of file gdcmHeader2.cxx
1406 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1407 inheriting from gdcmParser. This split is to prepare the integration
1408 of dicom dir parsing
1409 * bug fix under python
1411 2004-01-16 Jean-Pierre Roux
1412 * REM removal of class gdcmHeaderEntrySet
1413 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1414 * ADD add file gdcmHeader2.cxx
1415 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1417 2004-01-15 Benoit Regrain
1418 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1419 entries created while parsing the header. Thus, they will be destroyed
1420 when the gdcmDictSet will be destroyed
1421 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1424 2004-01-15 Benoit Regrain
1425 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1426 made a fatal error because of the memory release at the end of program.
1427 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1428 some memory and vtk seems to have some problems with that.
1429 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1431 2004-01-14 Benoit Regrain
1432 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1433 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1434 * src/*.[h|cxx] : make changes due to class name changes
1435 * gdcmPython/demo/*.py : bug fix due to method names
1437 2004-01-13 Benoit Regrain
1438 * src/*.[h|cxx] : coding style
1439 * vtk/*.[h|cxx] : coding style
1441 2004-01-13 Benoit Regrain
1442 * gdcmPython/testSuite.py : test the readable flag of file for tests
1443 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1444 It's lied to the stl compilation by MSVC (windows, always windows...)
1445 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1447 2004-01-12 Benoit Regrain
1448 * src/*.h : add comments
1449 * src/gdcmDictSet.h : set the method BuildDictPath in public
1450 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1451 directly setted in the source code
1452 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1455 2004-01-09 Benoit Regrain
1456 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1457 * setup.py : use a reference to gdcmVERSION
1459 2004-01-07 Benoit Regrain
1460 * Modification to compile with the distutils.
1463 2003-12-10 Benoit Regrain
1464 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1465 can use a gdcmHeaderHelper to load datas
1466 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1467 made in the source code
1469 2003-12-10 Benoit Regrain
1470 * Update Windows projects and .cvsignore files
1472 2003-11-12 Jean-Pierre Roux
1473 * ENH gdcmHeader constructor has one more parameter (default value : false)
1474 that allows the user to 'go inside' the SeQuences only
1476 gdcmElValSet:Print takes it into account
1478 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1479 * ENH: Update gdcmPython/CMakeLists
1480 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1481 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1483 2003-11-10 Jean-Pierre Roux
1484 * FIX : gdcmHeader::LoadElements is now based
1485 on the ListTag listElem member,
1486 not longer on the TagElValueHT tagHt member
1487 * ENH : PrintPubElVal shows (temporarily) both results,
1488 with the tagHt member and the listElem member.
1489 (it's easier to 'see' the problems when using Printheader)
1491 * FIX : old private member LgrElem is now splitted into
1492 ReadLength : Length actually found on disk (updated only
1493 if bug fixing is necessary), for internal
1495 UsableLength : Updated by FixFoundLength, to fix a bug
1496 or to allow Parser going on.
1497 Will allow to re-write a kosher header when a SeQuence
1498 with a length (not 0000) is found
1499 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1500 because gdcmElValSet::Add does not update ListElem
1503 2003-11-07 Jean-Pierre Roux
1504 * FIX misstyping in Transfert Syntax name table
1505 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1506 when they have an actual length (not 0000 nor FFFFF)
1507 (Nobody should care of it, but DICOMDIR explorers)
1509 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1510 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1512 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1513 * ENH: vtkGdcmReader now supports LUT !
1514 (vtkgdcmViewer for now is not able to use them though)
1516 2003-11-05 Jean-Pierre Roux
1517 * in testSuite.py : new files names for checking the package
1518 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1519 that returns the pixel area size to the *aware* (vtk) user
1520 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1522 2003-11-05 Benoit Regrain
1523 * in testSuite.py : Modify the rules for checking the paths
1524 : Explicit error messages
1525 * in __init__.py : Related modif
1527 2003-11-03 Jean-Pierre Roux
1528 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1529 to be used by aware (vtk) users that want to manage
1530 LUT (and no to turn the PALETTE image into an RGB pixels one)
1531 * GetPixelType now returns 8U for 24 Bits images
1532 (vtkGdcmReader compliant)
1534 2003-10-31 Jean-Pierre Roux
1535 * Removal of *all* gdcmData images and add them again
1536 in order to loose the 'history' of un-anonymised images
1538 2003-10-31 Jean-Pierre Roux
1539 * RMV : removal of useless jBitsInJsample.h
1540 for both 8 and 12 Bits JPEG Lossy Libraries
1542 2003-10-31 Jean-Pierre Roux
1543 * ENH : Add the functions gdcmFile::GetImageDataRaw
1544 gdcmFile::GetImageDataIntoVectorRaw
1545 that act as GetImageData and GetImageDataIntoVector
1546 except the making of an RGB Plane from Gray Plane + LUT
1547 Intended to aware (vtk) users who know how to manage
1550 GetLUTRGBA return a R,G,B,A LUT if any
1551 lgrTotaleRaw gives the 'Raw' length
1552 GetImageDataRaw returns the gray Plane
1553 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1554 (They stay Grey, just like with other Dicom viewers :-(
1556 2003-10-30 Jean-Pierre Roux
1557 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1559 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1560 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1561 being coherents dicom files.
1563 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1564 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1566 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1567 * ENH: Two steps is necessary to please VC++ compiler...
1568 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1569 * ENH: Add include dir to medcon lib
1570 * FIX: only one function is being exported for now !
1571 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1573 2003-10-29 Jean-Pierre Roux
1574 * adding gdcmHeader::GetLUTRGBA
1575 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1576 --> Mathieu, the modif u're waiting for is not yet committed
1577 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1579 2003-10-27 Jean-Pierre Roux
1580 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1581 00191113.dcm DermaColorLossLess.dcm
1582 MxTwinLossLess.dcm RadBWLossLess.dcm
1583 * ENH: For version prior to vtkImageViewer2 -r 1.19
1584 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1586 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1587 * Removal of ido stuff in CMakeLists.txt
1589 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1590 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1591 * FIX: remove a call to ->Modified ... see comments
1592 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1594 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1595 * FIX: Problem with path for libvtkgdcmPython
1596 * ENH: Try adding a search script for python site-package
1597 * RMV: Remove some file from medcon lib that are not necessary
1598 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1599 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1600 * FIX: More pragma disable fro VC++,
1601 I don't think I break something as it is also disable in VTK/ITK.
1602 But it fasten debug compilation time.
1604 2003-10-23 Jean-Pierre Roux
1605 * gdcm now deals with 16 Bits Run Length Encoded images
1606 (they are compressed as 2 planes images,
1607 one for the high Bytes, the other for low Bytes)
1609 2003-10-22 Jean-Pierre Roux
1610 * Now CheckRead takes into account :
1611 - the bugged 'Leonardo' Siemens images
1612 - the XA images, sent thru the burning VPRO station
1613 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1616 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1617 * FIX: When copying a Makefile.am to CMakeLists.txt
1618 one should remove the '\'
1620 2003-10-22 Jean-Pierre Roux
1621 * in gdcmData adding a bugged 'Leonardo' Siemens image
1622 (wrong lengths in header)
1623 OK with gdcm, KO with the other viewers :-)
1624 * add a GE dlx XA image, thru the VEPRO burning station
1627 2003-10-21 Jean-Pierre Roux
1628 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1629 for a brutal checking of vtkgdcmViewer compliance
1631 2003-10-21 Jean-Pierre Roux
1632 * add the files for 'xmedcon' Jpeg Lossless library
1633 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1635 2003-10-21 Jean-Pierre Roux
1636 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1638 2003-10-21 Jean-Pierre Roux
1639 * garbage Siemens 'Leonardo' images dealt with
1640 (the patch is easy to remove)
1641 * cosmetic changes to avoid warnings
1643 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1644 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1645 no need to press 'r' now.
1647 2003-10-20 Jean-Pierre Roux
1648 * upgrade of checkRead.sh checkWrite.sh according
1649 to new Jpeg Lossless decompressor
1650 * add US.3405.1.dcm, a genuine RGB medical file ...
1651 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1652 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1654 2003-10-15 Jean-Pierre Roux
1655 * general anonymisation in gdcmData
1656 * adding the 'color files' from
1657 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1658 * adding some well knowed bugged-header images
1659 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1660 waiting for their inclusion in Python testsuite
1662 2003-10-15 Jean-Pierre Roux
1663 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1664 no longer seg faults when file is not found
1666 2003-10-14 Jean-Pierre Roux
1667 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1670 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1671 * TODO: *.in file to genereate a UseGDCM later
1673 2003-10-14 Jean-Pierre Roux
1674 * Some supposed-to-be Dicom Images have no preamble.
1675 OpenFile takes it into account
1676 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1677 * Missing elements added in dicomV3.dic
1678 (just to be affraid : have a look at
1679 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1680 and do it again next year ;->
1682 2003-10-13 Jean-Pierre Roux
1683 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1684 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1685 But there are NOT. It's fixed !
1687 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1688 * FIX: "jpeglib.h" was not found on VC++
1689 * FIX: vtkgdcm was not being installed
1691 2003-10-10 Jean-Pierre Roux
1692 * ENH : OpenFile closes the file if it *really* doesn't look like
1693 an ACR-NEMA / DICOM one.
1694 * FIX : testWrite no longer writes an empty file if the source file
1695 is not gdcm Readable
1696 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1699 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1700 * FIX: CMake generate now documentation
1701 * ENH: out of source doc build !
1702 * ENH: Generate both user and dev documentation
1703 * ENH: Should work on windows too
1704 * ENH: Only one doxygen config.in file is needed
1705 * FIX: make install should be ok now on ùnix plateform
1706 * FIX: PATH to dictionary was wrong (missing /)
1707 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1709 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1710 * vtkGdcmReader is now able to read rgb dicom file.
1711 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1712 * added a gdcmViewer to vtk test, use mouse to control
1713 window level & window width
1715 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1716 * CMake-ification of gdcm, we have now two build system
1717 * FIX: on cygwin Wsock32 doesn't exist
1718 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1720 2003-10-06 Emanuel Ollart
1721 * FIX : compilation process wad broken.
1722 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1724 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1725 * change gdcmViewer -> vtkgdcmViewer
1726 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1728 2003-10-06 Jean-Pierre Roux
1729 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1730 ( e.g : well known GE images with a wrong elem length,
1731 : Philips MRI Images with a wrong Huffman table)
1732 * still to be done : allow the reading of bugged LEONARDO Siemens images
1734 2003-10-03 Jean-Pierre Roux
1735 * Odd length strings are padded with '\0' (not with spaces,
1736 to remain compliant with already defined strings,
1737 like Transfert Syntax UID and others)
1739 2003-10-03 Jean-Pierre Roux
1740 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1741 to allow displaying RGB images (not only by affim ;-)
1743 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1744 * vtkGdcmReader is now able to read rgb dicom file.
1745 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1747 2003-10-03 Jean-Pierre Roux
1748 * A few nasty patches to allow the reading of a lot of nasty images
1749 ( e.g : well known GE images with a wrong elem length,
1750 : Philips MRI Images with a wrong Huffman table)
1751 * still to be done : allow the reading of bugged LEONARDO Siemens images
1753 2003-10-03 Jean-Pierre Roux
1754 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1756 2003-10-03 Jean-Pierre Roux
1757 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1758 to allow displaying RGB images (not only by affim ;-)
1760 2003-10-03 Jean-Pierre Roux
1761 * gdcmFile::GetImageDataIntoVector now
1762 - deals with MultiFrames MultiFragments Run Length Encoded files
1763 - deals with YcBcR (YBR_FULL) files
1764 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1765 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1767 (no sample found :-(
1769 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1770 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1771 Two reasons: - clear things
1772 - third parties acces gdcm through header files, so won't
1773 suffer anymore VC++ complains
1775 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1776 * add argv[1] in testvtkGdcmReader.cxx
1779 2003-09-24 Jean-Pierre Roux
1780 * The lines are now eigthy characters long.for
1781 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1783 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1784 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1785 char* to std::string. Thus, the use of strdup becomes useless. (see
1786 previous commis of Malaterre)
1787 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1788 before the last Malaterre's commit.
1790 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1791 * This commit should fix the Debug building under VC++, the problem
1792 was mainly a mixture of debug and release lib being loaded at startup.
1793 * I also remove a depency to a specific C function: strdup. Because I had
1794 to force the link to msvcrtd (whereas strdup is in libc).
1796 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1797 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1798 located in the gdcmCommon.h file. All use of reference of tha has been
1799 changed to now use the variable GDCM_UNFOUND.
1801 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1803 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1804 Dicom dictionary. The test suite can now be run again. Note:
1805 I'm note very happy with the " (RET)" changes. I believe this
1806 RETAINED comment should be dropped when parsing the dictionary.
1807 - PACKAGER corrected
1809 - AUTHORS updated and now in alphabetical order
1810 * Makefile.am now exports gdcm.dsw for Windoze users.
1812 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1813 * cygwin complains about missing std:: in subdir Test/
1815 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1816 * remove some methods that are now in gdcmHeaderHelper
1818 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1819 * vtkGdcmReader set spacing and origin correctly
1821 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1822 * Fix a few delete/delete[] mismatch
1824 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1825 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1826 interpretation to data given by gdcmHeader. For instance there are
1827 heuristics to get informations (look at different places).
1828 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1829 sorting DICOM images based on different strategies.
1830 * modified Makefiles accordingly.
1832 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1833 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1834 when building in debug mode
1835 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1836 src/win32/gdcmdll.dsp
1837 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1839 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1840 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1843 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1844 * src/win32/libgdcmjpeg12.dsp was not dos format
1845 * src/win32/libgdcmjpeg12.dsp :
1846 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1847 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1849 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1850 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1852 * src/gdcmFile.cxx : bug fix in affectation type
1853 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1854 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1855 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1856 symbols... future problem ?
1858 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1859 * src/win32/libgdcmijpeg12.dsp was missing
1860 * modified gdcm.dsw accordingly
1862 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1863 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1865 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1866 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1867 commit of JPR (before his hollidays to facilitate our work).
1868 * setup.py : bug fix in code. Modifications made while the last commit
1869 of JPR. The code hasn't been tested before the commit... it's so
1870 useless to make that (for best programmer that is JPR) !!!
1872 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1873 * tagged the current version as Version0_3 (i.e. version 0.3)
1875 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1876 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1877 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1878 * *.dsp : modifications to use new libgdcmijpeg8 library
1879 * setup.py : bug fix on VTKPATH variable
1880 * PACKAGER : adding all concerning windows
1882 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1883 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1885 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1886 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1887 test suite reported error.
1888 * PACKAGER file added (describes what a packager must do when
1889 packaging a new release).
1890 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1891 * configure.in: upgraded version number to 0.3.0
1892 * fixing build of rpm (through rpm -ta):
1893 - Doc/Makefile.am exports proper doxygen files
1894 - src/jpeg/libijg8/Makefile.am exports the include files.
1896 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1897 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1898 * src/gdcmHeader.h : formatting code
1900 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1901 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1902 We were obtaining error message from vtk. Now, creation of file list
1903 is made in an internal list to prevent this problem.
1904 Bug fix when output is empty.
1905 Bug fix in update of progress value. Previous commit for this was a bad
1907 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1909 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1910 * src/gdcmHeader.h : added method to get the file name
1911 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1912 files. Added method to remove all files on the input
1913 Added FIXME comment concerning the bad parsing of header made by
1914 ExecuteInformation method (in ExecuteData method)
1916 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1917 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1918 when using make instal.
1919 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1920 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1922 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1923 * setup.py : adding include dir of jpeg lib to compile all sources
1924 * */Win32/*.dsp : JPR fix for windows compilation
1926 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1927 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1929 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1930 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1932 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1933 * setup.py is again effective on un*x (takes into account the
1934 addon of the jpeg library)
1935 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1936 * Doc/Doxy* updated (includes above enhancements)
1937 * INSTALL now points to web documentation
1939 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1940 * src/gdcmHeader.h doesn't make unnecessary reference to
1942 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1944 * src/gdcm*.[cxx|h] :
1945 - to allow compilation with gcc 3.x
1946 -- clean up of STL usage (added explicit usage of std::)
1947 -- small fixes on exceptions.
1948 Note: linking not tested !
1949 - clean of doxygen comments to avoid warnings at documentation
1951 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1952 dependent convertion).
1954 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1955 * Clean up of previous JPR garbage commit (not even commented in the
1957 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1958 - moved all jpeg related files from src to src/jpeg/libijg8, with
1959 addition/modification of Makefile.am and configure.in.
1960 - the testSuite is still brain damage (not guilty).
1962 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1963 * WrapVTK.py : modifications to get correctly vtk source files to
1965 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1966 (FileName -> Filename)
1968 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1969 * vtk/vtkGdcmReader.[cxx/h]:
1970 - UpdateProgress method should now be effective
1971 - removed the limitation on having only images loaded (as opposed
1973 - when building a stack of images/volume, a lesser number of
1974 gdcmHeader and gdcmFile instances should be used (hopefully
1975 accelerating things).
1976 - when building a stack of images/volumes, files which are not
1977 loadable (wrong path-filename, wrong permissions on existing file,
1978 or file not parsable by gdcm) are replaced with a black image
1979 in the stack (for the caller to notice the problem).
1981 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1982 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1984 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1985 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1986 between standard library (std) and vtk library (problems are found
1987 under Windows... thanks Windows !)
1989 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1990 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1992 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1994 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1995 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1997 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1998 * When compiling with distutils (see setup.py) the C++ compiler is
1999 called with different flags than the default ones (with automake).
2000 In order to fix all those warning, I compiled gdcm with the command
2001 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2002 and went for warning fixes:
2003 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2004 up from unused variables.
2005 - vtk/vtkGdcmReader.cxx: potential bug fix.
2006 * src/gdcmHeader.h: Doxygen warning cleanup
2008 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2009 * gdcmPython/gdcm.i:
2010 - typemaps correction to take into account the systematic replacement
2011 of "using namespace std" with std:: prefix e.g. std::list,
2012 std::string... (cf changes of 2003-05-21).
2013 - gdcmGlob global variable of type gdcmGlobal (defined in
2014 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2015 exported to Python a as cvar.
2016 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2017 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2018 gdcmDictSet.GetPubDictTagNames() and
2019 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2020 C++ static methods).
2021 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2022 with the above changes.
2024 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2025 * setup.py, manifest.in : bug fix under linux
2027 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2028 * Modification of setup.py to compile vtk part too. Then, we have 2
2029 wrappers which must work with same distutils. For that, we have a
2030 generic distutils in distusiltsWrapping.py ; with :
2031 - build_extWrap class to wrap generically all extensions,
2032 - ExtensionWrap base class for all wrapping extension that contains
2034 - Wrapper interface which wrap sources
2035 + In WrapSwig.py we have extension and wrapper for Swig
2036 + In WrapVTK.py we have extension and wrapper for VTK
2037 * MANIFEST.in : modifications to consider vtk directory and new python
2038 files for compilation
2040 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2041 * Added python wrappers of vtkGdcmReader vtk class (see the
2042 source in vtk/vtkGdcmReader.cxx) :
2043 - vtk/Makefile.am now builds a library
2044 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2045 python library (as opposed to _gdcm.so wich are the python
2046 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2047 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2049 - configure.in has an additional flag --enable-vtk that needs
2050 to be set to enable compilation of vtk related code, that is:
2051 + vtk/vtkGdcmReader.so and
2052 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2053 + gdcmPython/vtkgdcmPython.so (see above)
2054 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2055 be read when compressed or when HighBit + 1 != BitsStored),
2056 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2057 the usage of the python wrapper of vtkGdcmReader vtk class.
2058 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2059 * src/*.[h] all occurences of stl classes are now prefixed with
2060 std::, and all occurences of "using namespace std;" where removed.
2061 This is to avoid pollution of global namespace in included files.
2062 Apparently vtk does not avoid this pitfall: when using both
2063 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2064 collision of various stl members (principally cout...).
2065 * gdcmPython/testSuite.py now cleanly removes temprory generated
2067 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2068 comply with above changes)
2070 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2071 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2072 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2073 vtk data structure (an image Flip was required).
2074 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2075 * cosmetic changes in documentation.
2077 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2078 * src/gdcmHeader.cxx: the constructor no longer exits when an
2079 unexisting file is given as argument.
2080 * The subdirectory Data (containing all the images used for the
2081 test suite) is not part of this repository anymore. A new module
2082 containing those images is now available at
2083 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2084 with the name gdcmData.
2085 All the python scripts (including the package initialisation file
2086 gdcmPython/__init__.py) were adapated to take this change into
2087 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2089 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2090 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2091 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2092 demo of the usage of this class.
2093 Compilation of this vtk part is only done when using the --enable-vtk
2094 at configure (or autogen.sh) stage.
2096 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2097 * More memory link related corrections and documentation fixes.
2099 - maximum info is obtained with a command of the form:
2100 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2101 --show-reachable=yes PrintHeader
2102 - the remaining reachable blocks seem to come from the STL
2103 allocation scheme through the usage of map and list. It looks
2104 like this memory cannot be freed but it is not a memory leak
2105 (in fact further invocation to the STL would recollect the
2106 unused memory allthough it cannot explicitely be freed).
2107 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2108 of displaying an image parsed with gdcm and displayed with VTK.
2109 Note: some images don't seem to work e.g.
2110 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2111 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2112 Allthough this weakens the semantics, it is a ditch attempt to
2113 make gdcm more thread friendly.
2115 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2116 * Memory link hunt (by using valgrind through the command
2117 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2118 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2119 gdcmHeader::_dicom_vr.
2120 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2121 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2123 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2125 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2126 * src/Makefile.am now exports all the necessary include files at
2130 * UpdateGroupLength replaced by new one
2133 * UpdateGroupLength re-written using H-Table
2134 (named UpdateGroupLengthNew untill checks are over)
2136 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2137 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2138 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2140 - gdcmHeader::GetPubElValSet removed.
2141 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2142 UpdateGroupLength, WriteElements, Write.
2143 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2144 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2145 carried the same semantics.
2146 - src/gdcmHeaderIdo.cxx changed accordingly.
2147 - gdcmFile::WriteBase now regroups all the codes from previous
2148 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2149 - enum FileType moved to gdcmCommon.h
2150 * src/gdcmHeader.cxx AddDefault trashed
2151 * gdcmGetXSize added
2152 * getimageDataSize now calls gdcmGetXSize
2153 * Test/*.cxx changed to agree with above changes
2155 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2156 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2157 (to avoid double call by end user).
2158 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2159 by end user, since gdcmHeader::gdcmHeader now handles it.
2161 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2162 * gdcm/Doc many doxygen changes:
2163 - Doxyfile now has two different versions, DoxyfileUsers that generates
2164 the html.users end users oriented documentation and
2165 DoxyfileDeveloppers that generates the html.developper developper
2166 oriented documentation.
2167 - README changed accordingly
2168 - requirement.txt removed (old design info moved to TODO).
2169 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2170 DoxyMainPage.txt, DoxyPython.txt provide more information.
2171 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2172 be updated by simply regenerating the docs with doxygen and copying
2173 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2174 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2175 all the tests in the form "if (<map>.count() >1)" were removed.
2176 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2177 ill-formed documentation sections.
2178 * src/gdcmHeader.cxx: ditto
2180 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2181 * setup.py fixed for un*x (needed macro for stdint.h)
2182 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2183 un*ces with sh-utils test utility.
2184 * gdcmPython/demo/test.py renamed to PrintHeader.py
2185 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2186 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2187 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2188 * src/gdcm*.cxx JPR's bad inclusion fixed.
2190 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2191 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2192 * gdcmPython/demo/test.py changed accordingly.
2194 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2195 * gdcmPython/Makefile.am fixed linking against libstdc++
2196 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2197 * Swig subdir (historical tests of swig version 1.3.17++) removed
2198 * Test/testChangeEntete.cxx some lines commented out in order to make
2200 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2201 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2203 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2204 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2205 hence the user doesn't need this explicit call.
2206 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2207 i.e. LoadElements() call removed.
2208 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2209 - src/Makefile.am declares the proper flag for g++.
2210 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2211 for adding user defined new tags.
2212 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2213 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2214 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2216 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2217 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2218 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2219 src/Makefile.am : the project should properly compile and install
2220 with the autotools, included the python wrappers part.
2221 * gdcm.spec.in : added a spec file for RPM packaging.
2223 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2224 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2226 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2227 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2228 to exported to the environement (see gdcmPython/testSuite.py
2230 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2231 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2232 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2233 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2234 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2236 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2237 * gdcmPython/__init__.py doesn't crash anymore when running in
2238 in InstallMode or PreInstallMode but with an environement given
2239 value of GDCM_DICT_PATH.
2240 * src/gdcmDictSet.[cxx/h] coding style.
2242 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2243 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2244 * src/gdcm.h general comments moved to TODO, and README
2245 * src/gdcm.h should now be seen as a user commodity (including it
2246 should suffice to fully use gdcm). It is nowhere including within
2247 any of the kernel files src/*.cxx and src/*.h.
2249 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2250 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2251 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2253 * src/gdcm*.cxx only include their corresponding include file
2254 (as opposed to gdcm.h)
2255 * gdcmPython/gdcm.i changed accordingly
2256 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2257 the autogen.sh generated "make snapshot" command to work.
2258 * autogen.sh removed history related references to crea package.
2260 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2261 * distutilsSwigCPlusPlus.py work around some swig portability
2264 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2265 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2266 was done in a last ditch attempt to get setup.py _really_
2267 operationnal. The python/gdcmPython layaout add the advantage
2268 of hidding away the python related distutils specific files
2269 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2270 Alas, the src directory was out of scope (i.e. it's relative
2271 position to setup.py was ../src) which made things impossible to
2272 handle (see previous version of python/setup.py). Crossing fingers...
2274 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2275 * python/setup.py now works on Un*x. (harder than I thougth)
2276 * python/distutilsSwigCPlusPlus.py can now have include files
2277 among the list of sources.
2279 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2280 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2281 * modifications in MSVC projects
2283 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2284 * As stated by the first lines of Test/ExceptionAndPython/README, it
2285 looks like we can move back to original usage of exception within
2286 src/gdcm* and hence remove the errno stuff that was introduced
2287 as a quick and dirty fixture of this problem (added to the TODO).
2288 * Doc/Doxyfile configuration file for Doxygen and corresponding
2289 README file for usage added.
2290 * Test/testWrite.cxx added. This new test comes from a split of
2291 test.cxx that is now reverted to its original purpous i.e.
2292 testing the proper parsing of a Dicom related file.
2293 testWrite.cxx concentrates on testing the IO part of gdcm.
2294 * Test/bug1.cxx (containing a bug on WIn32) added.
2295 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2296 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2297 whose purpose is to publish the content of the TagNames of the
2298 Dicom public dictionnary were not accessible without an
2299 instance of class gdcmHeader.
2300 - those methods are now static methods of gdcmDictSet and hence
2301 require no instances at all to be invocated.
2302 - within gdcmDictSet this change required to change some method
2303 to class methods (i.e. are now static) among which SetDictPath
2304 (renamed to BuildDictPath) and LoadDefaultPubDict.
2305 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2306 the above changes by calling the new method classes of gdcmDictSet.
2307 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2308 the above to be effective.
2309 * python/gdcmPython: in order to wrap properly the above changes
2310 for Python, swig version now needs to be > 1.3.17.
2311 * python/gdcmPython/Makefile fixed to adapt itself to new
2312 configure/make shema introduced by Johan Montagnat (thanks for the
2313 contribution). Alas this Makefile cannot be turned into a proper
2314 Makefile.am without some heavy changes in the configure.in
2315 (for python dectection).
2316 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2317 now avoids publishing the empty entries.
2319 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2320 * python/setup.py : bug fix concerning install under windows
2321 ExtraPath reused :-P
2322 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2324 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2325 * Dicts/dicomV3.dic : remove double spaces !!!
2326 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2327 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2330 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2331 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2332 method. Doxygenation.
2333 * src/gdcm.h clean up of JPR spurious comments.
2335 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2336 * python/distutilsSwigCPlusPlus.py now properly collects the
2337 shadow classes generated by "swig -c++" (gdcm.py in our case)
2338 when using "python setup.py install".
2339 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2340 reexports the working classes.
2341 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2342 by the classical C errno scheme. This is to prevent an obscure
2343 behavior of the python wrappers when importing wxPython.wx prior
2344 to gdcmPython (which ended up in an abort call). An illustration
2345 of this oddity can be found in the Test/ExceptionAndPython
2346 subdir (see the README file). This problem probably due to
2347 an combination of g++ and dynamic loading.
2348 * added Test/ExceptionAndPython (see above)
2350 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2351 * Changed the layout of the python part to avoid bloating main
2352 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2353 i.e. the distutils arsenal. All the python related stuff is
2354 again in a python subdir, but the package itself is now in
2356 * setup.py was cleaned up:
2357 - pythonIncludePath removed
2358 - python setup.py bdist target is now functional.
2359 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2360 collision with other packages). gdcmPython/demo/*.py changed
2363 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2364 * python subdir moved to gdcmPython (preparation of distutils packaging).
2365 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2366 distutils installer is operational.
2367 * - gdcmPython/__init__.py now properly loads the swig generated
2368 shadow classes (from gdcm.py).
2369 - gdcmPython/demo/*.py changed to import the package gdcmPython
2370 instead of gdcmPython/demo/load.py.
2371 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2373 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2374 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2375 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2376 entries within the associated public Dicom dictionary resp. the same
2377 information but sorted by the fourth field (PAT, IMG, DIR) of the
2379 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2380 are now in the "???" group.
2381 - python/gdcm.i changed accordingly,
2382 - python/demo/printGroupedPublicDict.py added, that gives an example
2383 of the above new functionalities in Python.
2385 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2386 * src/gdcm.h, gdcmHeader.cxx:
2387 - historic references to glib's g_malloc and g_free (#defined)
2388 were definitively removed.
2389 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2390 * src/gdcmElValSet.cxx:
2391 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2392 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2393 - GetElValue(string) renamed to GetElValueByName.
2394 - Added GetElementByName(string).
2395 * src/gdcmHeader.cxx: added
2396 - GetPubElValRepByNumber(guint16, guint16)
2397 - GetPubElValRepByName(string)
2398 - GetShaElValRepByNumber(guint16, guint16)
2399 - GetShaElValRepByName(string)
2400 - GetShaElValByNumber(guint16, guint16)
2401 - GetShaElValRepByName(string)
2402 - GetElValRepByNumber(guint16, guint16)
2403 - GetElValRepByName(string)
2404 - GetElValByNumber(guint16, guint16)
2405 - GetElValRepByName(string)
2406 * Doc/requirements.txt added.
2408 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2409 * Test/Makefile building now depends on the one of libgdcm.so
2410 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2411 pixel data) aware which enables finding the address (offset) of
2412 the pixel data of JPEG encoded DICOM files. This leaves only a single
2413 file in the testSuite whose pixel data address (offset) is unknown.
2414 * python/testSuite.py changed accordingly.
2416 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2417 * VC++ has some strong limitations when working with the STL, as stated
2418 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2419 "Also note that some STL containers (map, set, queue, list, deque)
2420 cannot be exported. [...]
2421 Some STL classes contain nested classes. These classes can not
2423 This is caused by a designed limitation that once a template
2424 class is instantiated, it can not be re-instantiated and
2426 Since our usage of map<> is ubiquitous in gdcm, this "designed
2427 limitation" of VC++ is a pitfall.
2428 Hence the Python wrappers of gdcm cannot be incrementally linked
2429 against the c++ dynamic library. The dirty but only workaround is
2430 to forget about incremental link of dynamic libraries and to generate
2431 the Python wrappers library with the inclusions of the underlying C++
2433 The following modifications concern this matter on Win32/VC++:
2434 - wrapping python correct with standalone wrapped dll (don't use separate
2435 dll under windows !!!!)
2436 - python21_d debug mode enabled (ask Frog how to use it :-)
2437 - NO problem with having an STL member of class for example string in C++
2438 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2439 - Python test of dcmlib in Python is ok under windows on a large set
2441 * removed glib references
2442 * typedef's inserted in gdcm.i for correct swig type management
2444 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2445 * python/demo/*.py load.py extracted from test.py. Added explore.py
2446 that only displays required tags and testAll.py that parses all
2447 the files of the testsuite without using unittest.
2448 * python/testSuite.py other additional test on new files added.
2449 * Data/* new test files added accordingly to the testSuite.
2450 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2451 the vr in the file differs from the one of the dictionary.
2453 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2454 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2455 values, but limits itself to values which are below a user specified
2456 size (by default 1024 bytes).
2457 * python/gdcm.i : elements not loaded (because their size is above the
2458 user specified treshold) are exported with their TagKey as key of the
2459 python dictionary. This enables the testsuite to make some checks
2460 on the unloaded elements (since we have their offset and size).
2461 * python/testSuite.py
2462 - now tests for the existence and proper value of the pixel data
2463 - two new examples added.
2464 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2466 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2467 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2468 aware. See the strategy comments in gdcmHeader::FindeLength().
2469 * Test/test.cxx now accepts a filename as first argument.
2470 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2471 * python/testSuite.py changed to integrate test on above files.
2473 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2474 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2475 the vr was also RET.
2476 * python/testSuite.py more tests added.
2478 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2479 * python/testSuite.py unittest test suite added (uses Data)
2480 * Data/* dcm and acr files for the test suite.
2481 * glib dependance removed from un*x version. We now use ISO C99
2482 7.18 Integer types (see stdint.h)
2483 - python/Makefile, src/Makefile src/gdcm.h
2484 * src/ when an explicit vr (like dicom files) suddenly poped an
2485 implicit element we use to mark the underlying DictEntry of the
2486 concerned ElValue with "Implicit". This strategy was damageable
2487 too the public or provite dictionaries, since some of their vr
2488 would be changed. Since Header::FindLength heavily relies on the
2489 detection by Header::FindVR of falsely explicit elements, I
2490 added an extra ImplicitVr member to ElValue (boolean).
2491 The rest of the changes we the necessary adaptations.
2493 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2494 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2496 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2498 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2499 * Adaptation for porting to VC++:
2501 o forced to use std namespace (for string to be known)
2502 o all class use __declspec export style on WIN32
2503 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2504 (in stdlib.h on Win32 but in std:: for gcc)
2505 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2506 variable GDCM_DICT_PATH.
2507 * src/gdcmHeader.cxx verbose comments made discrete.
2509 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2510 * python/gdcm.i: added a typemap that converts a C++ hashing table
2511 to native Python dictionary.
2512 * python/demo/test.py:
2513 - now uses the native dictionary for exploration of gdcmHeader.
2514 - takes an optional filename argument (the file to parse).
2515 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2516 PubElVals hashing table.
2517 * Dicts/dicomV3.dic removed error prone trailing spaces.
2519 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2520 * Python wrapping process moved away from src/Makefile to
2521 newly created python/Makefile (as well as gdcm.i)
2522 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2523 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2524 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2525 from the environement variable GDCM_DICT_PATH (when existing).
2526 * src/gdcmDict::GetTag bug fix.
2528 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2529 * Straightforward temporary fixes for swig to build the python wrappers.
2530 src/Makefile now has a python working entry [by working we mean
2531 that we can import de shadow classes without errors].
2533 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2534 * hashtest.cxx removed (since allready in Test)
2535 * src/gdcmlib.h renamed to src/gdcm.h
2536 * src/dcm.i renamed to src/gdcm.i
2537 * src/Makefile prepared for python wrapping
2539 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2540 * src/gdcmHeader.cxx :
2541 - Parsing of header is now separated from loading of element values
2542 (see gdcmHeader::LoadElements).
2543 - general clean up of hopefully all file access (creation of
2544 ReadInt16 and ReadInt32)
2546 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2547 * src/gdcmHeader.cxx :
2548 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2550 - SetLgrElem renamed to SetLength
2551 - GetLgrElem renamed to GetLength
2552 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2553 * src/gdcmElValSet.cxx fixed both GetElValue methods
2554 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2555 due to IdoDude was cleaned out.
2557 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2558 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2559 concentrates on finding the value representation (when it exists).
2560 RecupLgr now only finds the element value length, and it avoids
2561 returning the unecessary skL (skipped length).
2562 Also, offsetCourant was simply removed (with taille_fich) since
2563 it was redundant with the File position internals (by using
2564 ftell and fseek). This also made skL (see above in RecupLgr) usage
2566 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2567 on the libido specificities which are handled through class
2569 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2572 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2573 * Truckload of changes. Parsing of header is barely functional
2574 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2576 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2577 * src/gdcmHeader.cxx many addons of low level methods
2579 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2580 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2581 and _IdDcmSWAP_LONG.
2583 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2584 * This corresponds to all the changes decided at the meeting of
2585 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob