1 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * src/*.cxx *.h Reference to License.htm fixed to License.html.
3 * Doc/CMakeLists.txt, doxygen.config.in: fix.
4 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
6 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
7 * TODO updated with Mathieu suggestions. I proposed a template for
8 describing TODO entries and used it for new entries.
9 * Added Doc/Website/CodingStyle.html, Developpers.html,
10 DeveloppersPython.html, GdcmDataCvs.html and
11 DownloadVersion0_1.html, DownloadVersion0_3.html.
12 * Some Doc/*.txt Doxygen files (which do not really concern the
13 documentation itself, but the website) moved to html and
14 placed in directory Doc/Website:
15 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
16 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
17 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
18 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
19 * CMakeLists.txt changed accordingly.
20 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
21 DeveloppersPython.html
22 * INSTALL nows refers to Doc/Website/Installation.html
24 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
25 * Added Doc/Website directory, that contains a first raw version
28 2004-09-23 Jean-Pierre Roux
29 * FIX In order not to be poluted any longer by casting problems,
30 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
31 we can now delete[] it safely
32 * VoidArea is now called BinArea (less confusing name),
33 and all the methods called ...VoidArea... are now ... BinArea...
34 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
36 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
37 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
38 clear) TagHT, which is an inherited member of gdcmElementSet. It is
39 up to the destructor of gdcmElementSet to clean up TagHt and it's
42 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
43 * Test/CMakeLists.txt: update to follow gdcmData renamings.
44 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
46 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
47 * ENH: added some utility method that builds a flat dictionnary
48 holding all the Dicom entries contained in the recursive structure
49 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
51 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
52 BuildFlatHashTable() that build a flat dictionary.
53 - src/gdcmElementSet.h: added a new private GetTag() accessor.
54 gdcmDocument is now a friend of gdcmElementSet.
55 - src/gdcmElementSet.cxx: clean up.
56 - Example/FlatHashTablePrint.cxx added.
57 - Example/CmakeLists.txt changed accordingly
59 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
60 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
61 moved away from gdcmDocEntrySet (since this class is an abstract class
62 acting like an interface). SQDepthLevel and BaseTagKey are now
64 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
65 and associated accessors. Doxygenation of the class.
66 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
68 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
69 Use SQDepthLevel accessor instead. ::Print() adapted.
70 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
71 - src/gdcmDocument.cxx changed accordingly.
73 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
74 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
75 - The following is the doxygen comment of the typedef declaration
76 of gdcmagKey in src/gdcmCommon.h:
77 gdcmTagKey is made to old an "universal" (as in URL, Universal
78 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
79 A dicom tag allways has a group and an element, but a set of tags
80 embeded in various (optionally nested) sequences and sharing
81 the same group and element all share the same (group, element)
82 "identifier". Hence the (group, element) cannot be used as an
83 identifier (in gdcm we shall refer to a "TagKey") of a tag.
84 In order to construct a proper tag identifier (i.e. a key) we
85 consider the following definition of a TagKey:
86 - let Group, Element be the string representation of the
87 group and element dicom tag members,
88 - let ItemNumber be the string representation of the integer
89 index of the considered item number of a sequence,
90 Let the key of a tag embeded in a sequence, noted SeqTag, be
92 /ItemNumber#Group|Element
93 where "/", "#" and "|" are characters acting as separators.
94 Then the general form of a gdcmTagKey is given by:
96 where <SeqTag> means NO or many instances of SeqTag.
97 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
100 but the gdcmTagKey of a tag "embeded" is the first item of
101 a sequence, itself nested in the third item of a sequence is the
103 0004|1220/2#0008|0082/0#0008|0090
104 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
105 order to hold the new sequence compatible key. Previously, the
106 GetKey() method would look in the underlying gdcmDictEntry.
107 - src/gdcmDocEntry.cxx:
108 -- constructor now copies the underlying DictEntry key, in the local
110 -- ::Print: displays the member Key, instead of the (group, element).
111 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
112 - src/gdcmDocEntrySet.h:xi
113 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
114 -- now has a new BaseTagKey member.
116 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
117 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
119 This poses the problem with the semantics of the following lines
120 LoadEntryVoidArea(0x0028,0x1201); // R LUT
121 LoadEntryVoidArea(0x0028,0x1202); // G LUT
122 LoadEntryVoidArea(0x0028,0x1203); // B LUT
123 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
124 to the long FIXME note for what the problem is. Nevertheless in
125 order to get things working the dicom dictionary was altered !
126 Please fix things urgently...
127 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
128 information), see above note on moving the member VoidArea. Nevertheless
129 the following entries previously correctly set as US are now inproperly
131 0028 1201 OW IMG Red Palette Color Lookup Table Data
132 0028 1202 OW IMG Green Palette Color Lookup Table Data
133 0028 1203 OW IMG Blue Palette Color Lookup Table Data
134 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
135 of gdcmDocEntry moved to gdcmSeqEntry.
136 * src/gdcmSeqEntry.cxx: STYLE.
138 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
139 * Test/TestAllEntryVerify.cxx minor fix and added comments.
141 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
142 * gdcmPython/testSuite.py: all the test suite in python is now moved
143 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
144 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
145 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
147 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
148 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
149 to avoid inclusion recursion until STL is reached.
150 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
151 mecanism. errno.h is not included in gdcm anymore.
152 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
153 (gdcmFormatError now inherits from gdcmFormatUnexpected).
155 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
156 gdcmData/TestAllEntryVerifyReference.txt
157 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
158 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
159 exception_on_error parameter.
160 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
161 - vtk/vtkGdcmReader.cxx changed accordingly,
162 - Example/*.cxx and Test/*.cxx changed accordingly.
164 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
165 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
166 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
167 enable_sequences removed from gdcmHeader constructor and dependencies.
168 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
169 * gdcmPython/demo/PrintHeader.py: dummy fix.
170 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
171 skip_shadow removed from gdcmHeader constructor and dependencies.
172 * Example/*.cxx and Test/*.cxx changed accordingly.
174 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
175 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
176 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
178 2004-07-21 Jean-Pierre Roux
179 * FIX Now, Parsing and Printing a DICOMDIR do work!
180 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
182 2004-07-20 Jean-Pierre Roux
183 * FIX Some brain damaged headers have Zero-Lenght fields
184 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
186 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
187 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
188 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
189 variable (instance of gdcmDebug) by a definition macro, and the instance
190 is now in static in the gdcmDebug class
191 * src/gdcmSQItem.h : (FIXME) remove an undefined method
192 * Test/PrintAllDocument.cxx : bug fix in the result of the test
194 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
195 * WARNING: ctest now depends more tightly on gdcmData. You should
196 check out gdcmData properly for things to run smoothly...
197 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
198 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
199 we need the pixels not be loaded in order to use the ValEntry
200 that displays position and size).
201 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
202 This is a C++ based equivalent of gdcmPython/testSuite.py that should
203 be deprecated. If you have any doubts about the advantages of a
204 modern scripting language (read Python) versus grass root C++ (i.e.
205 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
206 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
207 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
208 Anyhow, consider documenting the gdcmData images in
209 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
211 * Test/CMakeLists.txt:
212 - now uses TestAllEntryVerify.cxx
213 - specific comments on oldACR00001.ima (now renamed in gdcmData
214 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
215 gdcmData/TestAllEntryVerifyReference.txt
218 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
219 * src/*.[h|cxx] : typedef clean up
220 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
221 - TagKey renamed to gdcmTagKey (for external usage)
222 - VRKey renamed to gdcmVRKey (for external usage)
223 - removal of typedef duplication.
224 - Removed all unecessary inline keyword from class inline definitions.
225 - Some method|function(void) declarations replaced with method|function().
226 * src/jpeg/libijg12/jdhuff12.c:
227 - printf polluting ctest removed.
228 - TAB removal for comminting
230 - TestAllReadCompareDicom.cxx: added a test that compares all the
231 images in gdcmDataImages.h with corresponding images in
232 gdcmData/BaselineDicom/. When baseline images are not present
233 this test creates them.
234 Note: we need to validate each reference image, but before that
235 I'd like to rename them with a more explicit name...
236 - CMakeLists.txt: changed accordingly.
237 * Example/*.cxx: examples now only include gdcm.h (as opposed to
238 including each header needed).
240 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
241 * Test/*.cxx and Example/*.cxx: moved some examples away from the
242 test suite to the Example directory. Are concerned:
247 - TestWriteSimple.cxx
248 * Test/CMakeLists.txt: added some comments on reasons for black listing
249 image gdcmData/oldACR00001.ima
251 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
252 * Test/CmakeList.txt: removed the following from black list (to be coherent
253 with removal from gdcmData):
254 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
255 - gdcm-MR-PHILIPS-16.dcm
257 Added the following because after last cvs update, they cause
258 ctest -R TestReadWriteReadCompare
260 - gdcm-MR-SIEMENS-16-1.acr
262 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
263 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
264 new comments in this file) we temporarily (sigh) move to a weaker
266 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
267 we don't need to black list the following images anymore:
268 - 8BitsUncompressedColor.dcm
270 - US-PAL-8-10x-echo.dcm
271 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
272 fixes and the beautified code ;-)
273 This fixes the bug introduced in version 1.42 (when beautifying)
274 that made the parsing of 8BitsRunLengthColor.dcm unproper.
275 Note: ctest was blind to this bug (this means we need to still
276 improve the test suite). The bug could be detected by using
277 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
279 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
280 and by displaying the (garbage) produced file temp.XDCM...
282 2004-06-29 Jean-Pierre Roux
283 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
284 - replace by uggly but working old code :-(
285 A lot of things should be OK again.
286 It's really urgent to have a test suite that *tests*,
287 to prevent Frog's beautifying sessions to break all the stuff
288 (twice, withing a fortnigh ...)
290 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
291 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
292 redundancy) to added Test/TestReadWriteReadCompare.cxx
293 * Test/CmakeList.txt: because the compare test of
294 Test/TestReadWriteReadCompare.cxx fails, the following images are
295 black listed: - 8BitsUncompressedColor.dcm
297 - US-PAL-8-10x-echo.dcm
298 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
299 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
300 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
301 and ad-hoc kludge. This kludge is now removed, and on encountering
302 such an image (OB field brain damaged) we set errno. Then in
303 ::FindDocLength() we "fix" the length as being ALL what remains
304 in the file (until EOF). We then proceed, hoping for the best...
305 This fixes a SegFault in ShowDicom when trying to write such an
307 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
308 (because TestWriteRead breaks on it, after a non conformal commit?).
309 ctest now runs properly, except for MakeDicomDir (which was allways
310 broken) and the Python related stuff (still not fixed).
312 2004-06-24 Jean-Pierre Roux
313 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
314 FIX : Test/TestReadWrite now iterates on all the file names
315 (instead of infinite loop)
316 ENH : Test/TestWriteRead now iterates on all the file names
318 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
319 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
321 2004-06-24 Jean-Pierre Roux
322 FIX : - now Write drops LUT Descriptors and LUTs (if any)
323 when SamplesPerPixel =3
324 - now Write is no longer confused by
325 'BitsAllocated = 12" and 'BitsStored=12"
326 - "UN" value representation Elements are now written correctly
327 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
328 ENH : - now gdcmHeader has its own Write methods
329 (in order to split the job that has not to be done
332 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
333 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
334 loop on the same image until memory went out.
335 Note: this means we still have gobs of memory loss in PrintDocument
336 * src/gdcmDocument.cxx: fixes problem on parsing on file
337 gdcmData/16BitsJpegLosslessGrayScale.dcm.
339 2004-06-24 Jean-Pierre Roux
340 FIX : Write - All the Sequences and Sequence Item are now written
341 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
342 is added a the end, when necessary.
343 - A lot of brain-damaged images, that were read correctly are
344 now written correctly
345 - length compatible BinEntry are now loaded correctly
346 (even for odd groups)
347 Note : only Explicit Value Representation was checked.
348 (question : is implicit VR really necessary for gdcm ?)
350 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
351 * DEVELOPPER: added a proposition of coding style.
352 * src/gdcmDocEntry.h: removed every inline declaration (for test of
355 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
356 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
357 Use the gdcmDocEntry::Print() and Write() instead.
358 * src/gdcmDocument.cxx: bug fix.
360 2004-06-22 Jean-Pierre Roux
361 FIX : gdcmDocument.cxx
362 - Now we do recognize the JpegLossLess format (there was a misstyping in
363 code 'beautyfication' :-(
364 - Now we automaticaticaly load the Luts, if any
366 2004-06-22 Jean-Pierre Roux
367 In order : to write Sequences, whatever their imbrication level,
368 : to allow user to create his own Sequences
369 a lot of modif where necessary (adding, moving, or virtualising methods)
371 WARNING : save your own sources *before* cvs up !
374 ADD virtual void Write(FILE *fp, FileType filetype);
377 ADD virtual void Write(FILE *fp, FileType filetype);
378 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
381 ADD virtual void Write (FILE *fp, FileType filetype)=0;
382 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
383 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
384 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
385 ADD std::string GetEntryByName(TagName name);
386 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
388 std::string vr = "unkn",
389 std::string fourth = "unkn",
390 std::string name = "unkn");
391 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
392 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
393 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
394 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
395 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
396 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
397 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
398 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
401 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
402 ADD virtual std::string GetEntryByName (TagName tagName);
403 ADD virtual std::string GetEntryVRByName (TagName tagName);
404 REM virtual bool Write(FILE *, FileType);
405 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
406 FILE *_fp, FileType type);
407 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
408 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
409 REM virtual bool WriteEntries(FILE *_fp,FileType type);
410 REM virtual std::string GetEntryByName (std::string tagName);
411 REM virtual std::string GetEntryVRByName (std::string tagName);
412 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
413 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
414 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
416 std::string vr = "unkn",
417 std::string fourth = "unkn",
418 std::string name = "unkn");
419 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
420 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
421 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
422 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
425 ADD virtual void Write(FILE *fp, FileType filetype);
428 ADD virtual void Write(FILE *fp,FileType filetype);
431 ADD virtual void Write(FILE *fp, FileType filetype);
432 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
433 REM std::string GetEntryByNumber(guint16 group, guint16 element);
434 REM std::string GetEntryByName(TagName name);
437 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
439 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
440 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
441 The default constructor invoked by the line
442 gdcmHeader *f1 = new gdcmHeader( header );
443 was gdcmHeader::gdcmHeader(bool) instead of the expected
444 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
445 Hence the parsing wasn't executed... See also below.
446 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
447 as explicit constructor didn't do the trick to fix the above problem.
448 Could anyone explain why ?
449 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
450 properly calls gdcmValEntry::Print() (that was weed out from
451 code related to gdcmBinEntry).
453 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
454 * In order to fix memory leaks:
455 - Test/TestWriteSimple.cxx: added cleaning of free store through
457 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
458 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
459 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
460 (through the call to ::AddDicomDirMeta()) or the destructor
461 would crash when deleting uninitialized ::metaElems].
462 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
463 - src/gdcmDocument.cxx:
464 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
466 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
467 was causing memory leaks.
468 - src/gdcmSQItem.cxx:
469 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
470 cleanly handled with polymophism: sorry but my milage is low).
471 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
472 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
473 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
474 This avoids SegFaulting.
475 - src/gdcmSQItem.h: coding style.
477 - Test/TestWriteSimple still severely sucks. The output image content
478 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
479 damaged when displayed with vtkgdcmViewer.
480 - on memory leaks: TestWriteSimple leaks really less (see entry
481 of 2004-06-18 in Changelog file for the call to valgrind).
482 - on segfaults: ctest now passes all the tests but one (no more
484 * Erroneous leading white fix:
485 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
486 white[s] (as opposed to from >> xxx, that removes it [them].
487 - src/gdcmTS.cxx: ditto.
488 - gdcmPython/testSuite.py: dirty related kludge removed.
489 * src/*: remaining references to gdcmParser removed.
490 * src/*[cxx|h]: added copy[way]left header.
493 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
494 * In order to fix writing of dicom files:
495 - Test/TestWriteSimple.cxx: a simpler example of writing.
496 - Test/CMakeLists.txt changed accordingly.
497 - src/gdcmDocument.cxx:
498 -- The destructor now recursilvely removes potential sequences.
499 -- Bug fix in ::IsJPEG2000()
500 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
501 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
503 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
504 to only declared) and build on top of
505 ::GetDocEntryByNumber(guint16, guint16).
506 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
507 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
508 for usage in destructor and treatement of promotion in
509 ::ReplaceOrCreateByNumber().
510 - src/gdcmSQItem.cxx: destructor should better handle his job.
511 Test/TestWriteSimple now runs (or at least it DOES something).
512 * We can now start hutting memory links. A good starting point is:
513 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
514 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
515 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
517 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
518 * Valgrind note: after Mathieu Malaterre teached me how to read
519 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
521 Using gcc, you can force the STL to use malloc and to free memory as
522 soon as possible by globally disabling memory caching.
523 With 3.2.2 and later, you should export the environment variable
524 GLIBCPP_FORCE_NEW before running your program.
525 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
526 simply vanish (it is still not clear to me, whether this means that
527 STL std::string leaks or if valgrind believes it leaks...).
528 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
529 running bin/gdcmTests makeDicomDir):
530 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
531 - Test/makeDicomDir.cxx now properly traps empty lists and returns
533 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
534 SegFaulting (I drowned in DicomDir related code when trying to
535 understand why the list is empty...).
536 * src/gdcmDocument.h: first BSD license header try.
537 * Doc/License.txt added.
539 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
540 * src/gdcmDocument.[h|cxx]:
541 - Clean up of the Transfer related predicates. They are now all based
542 on new method isGivenTransferSyntax, that (should) handle properly
544 - general clean up, simplification, and coding style.
545 - Specific clean up of Parse7FE0() (umproperly named actually).
546 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
548 2004-06-14 Jean-Pierre Roux
550 - fix the display of Sequence Delimitor (SQDepthLevel pb)
551 - fix the display of SQItem ordinal number
552 - add the GetSQItemByOrdinalNumber method
553 - remove some useless never written private methods
555 2004-06-14 Jean-Pierre Roux
557 - adding a constructor taking a gdcmDocEntry as an input param
558 - ReplaceOrCreateByNumber now returns :
559 a gdcmBinEntry * if a Binary (void *) value is passed as a param
560 a gdcmValEntry * if a string value is passed as a param
562 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
563 according to the param type (no longer sets a gdcmDocEntry)
564 - GetValEntryByNumber, GetBinEntryByNumber added
565 - NewValEntryByNumber and NewBinEntryByNumber added
567 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
569 - GetSQItemNumber and SetSQItemNumber added, to provide
570 a (relative) Item identier inside a given Sequence
571 \warning : some pb remaining around this number
573 - AddEntry now takes the Item Number as a param
575 - adding a constructor taking a gdcmDocEntry as an input param
577 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
578 * Memory leak hunt with the following command:
579 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
580 --show-reachable=yes gdcmTests PrintDocument
581 It looks like many (all?) leaks are due to the STL (or a bad usage
582 of the STL. The lines producing the leaks now have a comment with
583 a "MEMORY LEAK" tag: you can retrieve them with
584 grep "MEMORY LEAK" src/*
585 Here are two typical examples which I can't help fixing:
590 char * test = "babo";
591 name = test; //// <--- valgrind detects 960 bytes lost in
592 //// call to std::string::operator=(char const*)
593 name.clear(); //// Doesn't help !
601 std::cout << "Type a bunch of characters followed by RETURN: ";
602 getline(std::cin, line); //// <--- valgrind dectects a loss
603 //// of 1320 bytes in call to
604 /// std::basic_istream<>& std::getline<>
610 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
611 * src/gdcmHeader.[cxx|h]:
612 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
613 and related, moved away to gdcmDocument.
614 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
615 the corresponding protected accessors of inherited class
616 gdcmDocument, removed ! As a consequence gdcmFile had to be
617 declared friend of class gdcmDocument (see below).
618 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
619 - Clean up of undefined or unused methods.
620 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
621 account the changes to gdcmHeader.h).
622 * src/gdcmDocument.h:
623 - gdcmFile is now a friend class (in order to take into account the
624 changes to gdcmHeader.h).
625 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
626 (see changes to gdcmHeader.h).
627 - Accessors (reading on the form GetEntry*) are now public.
628 - Clean up of undefined or unused methods.
629 * src/gdcmDocument.cxx:
630 - adaptation to changes to gdcmDocument.h
631 - ::OpenFile now writes a verbose message when file cannot be opened.
632 - some std::string properly set to VRKey
633 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
634 references to gdcmDocument.
635 * Test/TestFindTags.cxx: changed accordingly to above changes.
636 * gdcmPython/testSuite.py: adapted to renaming of acr files in
637 cvs repository gdcmData.
639 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
640 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
641 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
642 conflicts with gdcmValEntry::voidArea.
643 * src/gdcmValEntry.cxx: unmatching comment wiped out.
644 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
645 Value representation between StringRepresentable and BinaryRepresentable.
646 * src/gdcmDocument.cxx:
647 - method ParseDES: proper indentation restored and usage of
648 gdcmVR::IsVROfGdcmStringRepresentable wired in.
649 - method LoadDocEntry: the fingerprint left in the SetValue() of
650 unloaded entries (length > MaxSizeLoadEntry) had curiously been
651 removed. Reverting to previous code segment with the proper
652 dynamic_cast< gdcmValEntry* >.
653 Note: this was (partially) breaking the python test suite
654 (gdcmPython/testSuite.py) that made usage of the above
655 fingerprint to check presence of "Pixel Data".
656 * src/gdcmDocEntry.h: coding style.
657 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
658 now taken into account.
659 * gdcmPython/gdcm.i: adaptation to the new internal representation
660 of gdcm (exit gdcmParser, hello gdcmDocument).
661 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
663 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
664 anymore, but instead prints the loaded Python dictionary.
665 * .... alas, the python testSuite is still broken.
667 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
668 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
670 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
671 * src/gdcmUtil.h : export methods
673 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
674 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
676 * Initial addition of automatic python testing
677 * Initial addition of automatic image comparison
679 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
680 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
681 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
683 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
684 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
685 * Test/ShowDicom.cxx : bug fix for msvc compilation
686 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
688 2004-05-04 Jean-Pierre Roux
689 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
690 new concepts (and new classes) :
691 a 'gdcmDocument' is composed of a set of Doc Entries, that are
692 - elementary gdcmDocEntries (former gdcmHeaderEntries)
693 - Sequence Doc Entries (gdcmSeqEntries)
694 a Sequence is composed of Items.
695 Each item is a set of Doc Entries (this is recursive)
696 The non uniqueness of the 'Dicom tag' is due to this recursivity
697 (never taken into account)
698 Our unability to add a new 'entry' in the header
699 at the proper location (neither in the H-Table (map or multimap),
700 nor in the Chained List is also due to this recursivity.
701 Don't try, right now, to use/modify/compile these new sources :
703 We just commit all the stuff, 'as is', in order not to loose it.
705 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
706 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
708 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
709 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
710 file prefix (SetFilePrefix)
712 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
713 * Add a new test: ShowDicom, for now this is just the c++ version of
714 checkRead.sh, later it will be able to compare the image read against a
716 * Replace the DEBUG on the stack with a global entry in cmake interface:
717 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
719 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
720 * Add an example subdir, with a real example on how to read + write a
723 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
724 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
725 * Doc/CMakeLists.txt: the main page is now properly differentiated
726 between the developper and user version.
727 * Doc/doxygen.config.in: dropped search related obsolete flags
728 * src/gdcmParser.h, gdcmHeader.h: doxygenation
730 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
731 * DEVELOPPER: added some helpfull comments for compile/test/install
734 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
735 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
736 src directory, now generated in the build dir.
737 2. Tests as mentionned smarter
739 4. Add a new method in gdcmDict that return the PubDict by name
740 this is interesting for 3rd party lib like ITK,
741 where we could set the institution name / patient name...
743 * ENH: 1. Now the test suite is working for real
744 2. All binaries are now output in the gdcm-bin directory
745 (this was not true before)
747 2004-04-28 Jean-Pierre Roux
748 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
749 SeQuence indented printing of Dicom Header.
750 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
751 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
752 Computation of SQDepthLevel is now part of gdcmHeader constructor
753 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
754 tree-like structure of a Dicom Header.
755 * FIX Test code cleaning
757 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
758 * ENH: Adding automatic testing
759 1. Need a DartConfig.cmake to submit to public
760 2. Add a test driver gdcmTest.cxx
761 3. gdcmTestMain, an helper for the main test driver gdcmTest
762 4. Files in Test don't have a main anymore, this becomes interesting
763 when we add more and more tests, thus dsw don't have to load
765 * ENH: Adding a GDCM_DATA_ROOT for testing
766 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
767 one file instead of seven + some small cleanup
769 2004-04-22 Jean-Pierre Roux
770 * ENH Minor changes to the Print() methods.
771 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
772 Header printing. Example given with :
773 > PrintHeader fileName 2 new
774 (SQ based tree-like structure still to be done for the Header ...)
776 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
777 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
778 1. I have added some unsigned where needed
779 2. Some function parameter not used -> (void)
780 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
781 4. g++ don't like character '\' in comment
782 5. #define jpeg_create_decompress jCreaDecompress
783 this really need to be fixed
784 6. virtualize destructor of gdcmObject ... leakage
785 7. sscanf(g->first.c_str(),"%x",&gr_bid);
786 this also really need to be fixed
787 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
788 remove compression file
789 (as we only do decompression, right ?)
790 * ENH: Change malloc/calloc/free with c++ equivalent
792 2004-04-21 Jean-Pierre Roux
793 * FIX gdcmHeaderHelper::GetXSpacing
794 when a single value is found (bug ?), xpacing is now
795 defaulted to yspacing
797 2004-04-19 Jean-Pierre Roux
798 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
799 * ENH add parameters :
800 bool exception_on_error = false,
801 bool enable_sequences = false,
802 bool ignore_shadow = false
803 to the gdcmFile constructors to be full gdcmParser compliant
804 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
805 to allow reading of PAPYRUS 3.0 files
807 2004-04-06 Jean-Pierre Roux
808 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
810 2004-04-02 Jean-Pierre Roux
811 * ADD : Test/checksequence.sh, for a general recap on SQ pb
812 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
813 for Philips spurious Tag fffe|0000 while rewritting Dicom files
815 2004-03-30 Jean-Pierre Roux
816 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
817 for ACR file, written out as DICOM files (hope so...)
819 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
820 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
821 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
822 moved to base class gdcmParser and only the specialisation is kept
824 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
825 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
826 already does the job.
827 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
828 (to be consistent with gdcmParser::WriteEntries).
830 2004-03-30 Benoit Regrain
831 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
832 upate of the object's instance. It's passed to 2 in the unfavorable
833 case : one in the ExecuteInformation, one in the ExecuteData
835 2004-03-29 Jean-Pierre Roux
836 * ENH : Check on file type to be written moved
837 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
838 * FIX : gdcmObject::ResetBoundaries now stops properly
839 when end-of-list is reached
840 : gdcmVersion modified (as Benoit Regrain asked)
842 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
843 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
844 * src/gdcmUtil.cxx: added forgotten iostream include.
845 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
846 equivalent to ExplicitVR in existing code).
848 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
849 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
850 now contains all the gdcmGlobal related code.
851 * minor coding style and doxygenation changes.
853 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
854 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
855 now contains all the Debug related code.
856 * minor clean-up of includes in src/*.cxx
857 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
858 CreateCleanString) removed.
859 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
860 * Doc/DoxyMainPageUser.txt added.
861 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
862 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
865 2004-03-24 Jean-Pierre Roux
866 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
868 2004-03-23 Jean-Pierre Roux
869 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
870 big endian made volumes
871 * ENH Now gdcmParser constructor and destructor are protected to forbid
872 end user to instanciate class gdcmParser
873 (only gdcmHeader and gdcmDicomDir are meaningfull)
875 2004-03-22 Benoit Regrain
876 * FIX : src/gdcmDicomDir.cxx : make windows compilable
877 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
878 gdcmSerie to gdcmDicomDirSerie
880 2004-03-19 Jean-Pierre Roux
881 * ENH Now the tree-like structure describing a DICOMDIR comming from
882 an already existing DICOMDIR file is consistent with
883 the home-made tree-like structure build ex-nihilo
884 or build from the files held (recursively) in a Directory
885 functions gdcmDicomDir::CheckBoundaries()
886 gdcmObject::SetBoundaries() added
888 2004-03-17 Jean-Pierre Roux
889 * REM (Eric Boix bug) : removal of meaningless
890 gdcmDicomDirImage::NewImage function.
891 * FIX now file names and directory name are written properly in the
893 * FIX now gdcmDicomDir constructor may be call without any trick
896 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
897 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
898 of gdcmDicomDirImage::NewImage as empty function.
900 2004-02-28 Jean-Pierre Roux
901 * ENH add gdcmDicomDir:NewPatient
902 add gdcmDicomDirPatient:NewStudy
903 add gdcmDicomDirStudy:NewSerie
904 add gdcmDicomDirSerie:NewImage
905 to allow making gdcDicomDir object.
906 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
907 (as opposite to the gdcmHeader chained list)
909 2004-02-11 Benoit Regrain
910 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
911 when using from python
913 2004-02-10 Benoit Regrain
914 * FIX : bug fix in the gdcmDirList for the recursivity in directories
915 * FIX : in gdcmDicomDir when the directory is empty
916 * ENH : add callback and methods to get the progression of dicomDir
919 2004-02-06 Jean-Pierre Roux
920 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
921 - GDCM_META added to gdcmDicomDirType
922 - class gdcmMeta created
923 * ENH : - A brief summary is now displayed at the beginning of
924 'testDicomDir' to help disaster magnitude estimation
925 * REM : Now useless Test/explDICOMDIR.cxx
927 2004-02-05 Benoit Regrain
928 * ENH : add methods in gdcmObject to get the hash table or the list of
930 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
931 * FIX : wrapping python for TagHeaderEntryHT
933 2004-02-04 Benoit Regrain
934 * FIX : even length for some strings when writting the dicom dir
935 * FIX : sort the images in the dicom dir
936 * FIX : Bug fix for python use of dicom dir
937 * ADD : a python demo
939 2004-02-04 Jean-Pierre Roux
940 * FIX : Final solution (?) for icone embedded images
941 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
942 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
943 add groups 6002, 6004, 6006, to allow 'clean' parsing of
944 gdcmData/gdcm-MR-SIEMENS-16.acr1
945 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
946 to make full checking easier
948 2004-02-04 Benoit Regrain
949 * FIX : WriteEntries : coding style & logic in parameters
950 * FIX : Set the elements to create the DicomDir in a dictionary file
952 2004-02-03 Benoit Regrain
953 * gdcmDirList : to parse a hard drive directory in recursive (or not)
954 * gdcmDicomDir : add the load of directory
955 * Bug fix and print add-on
957 2004-02-03 Jean-Pierre Roux
958 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
959 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
960 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
961 * FIX gdcmParser.cxx : 'group length' elements are now considered
962 as integers, even for shadow groups, when file is Implicit VR
964 2004-02-02 Jean-Pierre Roux
965 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
967 of the last synonym :-(
968 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
970 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
971 * FIX taking into account the possible 7fe0,0010 multiplicity
972 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
973 to allow removal of references to 7fe0,0010, to deal with
974 ACR-NEMA images, when 0028,0200 is meaningfull
976 2004-01-31 Jean-Pierre Roux
977 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
978 no longer writes 'Un' on disk
979 * FIX SQ elements with actual length are now dealt with corectly
980 * FIX gdcmFile::WriteBase make the difference, for color images, between
981 the length (for Palette expanded images)
982 and Raw Length (non expanded image + Palette)
983 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
984 (that broke Write). Replaced by UL.
985 Aware user will reload the field if he
986 thinks it's necesssary
988 2004-01-30 Jean-Pierre Roux
989 * gdcmParser::CheckSwap() now defaults the filetype to ACR
990 when 'dirty Acr' is found, to be compliant with the new
991 IsReadable() methods.
993 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
994 (no DOUBLE images in kosher DICOM,
995 but so usefull for people that miss them ;-)
997 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
998 DICOMDIR related utilities (not checked as Windoze compliant)
1000 2004-01-28 Jean-Pierre Roux
1001 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1003 2004-01-27 Jean-Pierre Roux
1004 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1005 to allow skipping the shadow elements, to save memory space.
1006 The TRUE value for this param has to be used
1007 with a FALSE value for the 'enable_sequence' param.
1008 ('public elements' may be embedded in 'shadow Sequences')
1009 * gdcmHeader methods now deal with 'embedded icones images' in the header
1010 (even when an 'icone image sequence' is announced by the
1011 element (0x0088,0x0200), but there is NO icone at all ...
1013 * gdcmHeader sometimes Image Location value doesn't follow
1014 the supposed processor endianity (see gdcmData/cr172241.dcm).
1017 * gdcmHeader add the method
1018 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1019 to get *all* the Header Entries with the same tag.
1020 GetHeaderEntrySameName is probabely *useless*
1021 (no meaning : Name is *not* an identifier within the Dictionnary)
1023 2004-01-26 Benoit Regrain
1024 * Bug fix in the print of hexadecimal representations. Remove long fields
1025 in the print and add a third level of print to print them
1027 2004-01-23 Benoit Regrain
1028 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1029 * Bug fix on test suite after remove the strip made on not string fields
1030 * Split the IsReadable method between gdcmParser which test that the file
1031 is dicom and gdcmHeader which test that it's an image file
1033 2004-01-22 Benoit Regrain
1034 * DicomDir : clean code, add methods, set variables in protected or private
1035 * gdcmUtil : bug fix for the clean string method
1037 2004-01-19 Benoit Regrain
1038 * Add the use of shadow dictionaries
1039 * bug fix and coding style
1041 2004-01-19 Benoit Regrain
1042 * src/gdcmFile.cxx : bug fix concerning the close of file
1043 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1044 * Add the update of header entries using the shadow library
1046 2004-01-19 Benoit Regrain
1047 * removal of file gdcmHeader2.cxx
1048 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1049 inheriting from gdcmParser. This split is to prepare the integration
1050 of dicom dir parsing
1051 * bug fix under python
1053 2004-01-16 Jean-Pierre Roux
1054 * REM removal of class gdcmHeaderEntrySet
1055 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1056 * ADD add file gdcmHeader2.cxx
1057 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1059 2004-01-15 Benoit Regrain
1060 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1061 entries created while parsing the header. Thus, they will be destroyed
1062 when the gdcmDictSet will be destroyed
1063 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1066 2004-01-15 Benoit Regrain
1067 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1068 made a fatal error because of the memory release at the end of program.
1069 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1070 some memory and vtk seems to have some problems with that.
1071 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1073 2004-01-14 Benoit Regrain
1074 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1075 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1076 * src/*.[h|cxx] : make changes due to class name changes
1077 * gdcmPython/demo/*.py : bug fix due to method names
1079 2004-01-13 Benoit Regrain
1080 * src/*.[h|cxx] : coding style
1081 * vtk/*.[h|cxx] : coding style
1083 2004-01-13 Benoit Regrain
1084 * gdcmPython/testSuite.py : test the readable flag of file for tests
1085 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1086 It's lied to the stl compilation by MSVC (windows, always windows...)
1087 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1089 2004-01-12 Benoit Regrain
1090 * src/*.h : add comments
1091 * src/gdcmDictSet.h : set the method BuildDictPath in public
1092 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1093 directly setted in the source code
1094 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1097 2004-01-09 Benoit Regrain
1098 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1099 * setup.py : use a reference to gdcmVERSION
1101 2004-01-07 Benoit Regrain
1102 * Modification to compile with the distutils.
1105 2003-12-10 Benoit Regrain
1106 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1107 can use a gdcmHeaderHelper to load datas
1108 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1109 made in the source code
1111 2003-12-10 Benoit Regrain
1112 * Update Windows projects and .cvsignore files
1114 2003-11-12 Jean-Pierre Roux
1115 * ENH gdcmHeader constructor has one more parameter (default value : false)
1116 that allows the user to 'go inside' the SeQuences only
1118 gdcmElValSet:Print takes it into account
1120 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1121 * ENH: Update gdcmPython/CMakeLists
1122 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1123 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1125 2003-11-10 Jean-Pierre Roux
1126 * FIX : gdcmHeader::LoadElements is now based
1127 on the ListTag listElem member,
1128 not longer on the TagElValueHT tagHt member
1129 * ENH : PrintPubElVal shows (temporarily) both results,
1130 with the tagHt member and the listElem member.
1131 (it's easier to 'see' the problems when using Printheader)
1133 * FIX : old private member LgrElem is now splitted into
1134 ReadLength : Length actually found on disk (updated only
1135 if bug fixing is necessary), for internal
1137 UsableLength : Updated by FixFoundLength, to fix a bug
1138 or to allow Parser going on.
1139 Will allow to re-write a kosher header when a SeQuence
1140 with a length (not 0000) is found
1141 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1142 because gdcmElValSet::Add does not update ListElem
1145 2003-11-07 Jean-Pierre Roux
1146 * FIX misstyping in Transfert Syntax name table
1147 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1148 when they have an actual length (not 0000 nor FFFFF)
1149 (Nobody should care of it, but DICOMDIR explorers)
1151 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1152 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1154 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1155 * ENH: vtkGdcmReader now supports LUT !
1156 (vtkgdcmViewer for now is not able to use them though)
1158 2003-11-05 Jean-Pierre Roux
1159 * in testSuite.py : new files names for checking the package
1160 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1161 that returns the pixel area size to the *aware* (vtk) user
1162 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1164 2003-11-05 Benoit Regrain
1165 * in testSuite.py : Modify the rules for checking the paths
1166 : Explicit error messages
1167 * in __init__.py : Related modif
1169 2003-11-03 Jean-Pierre Roux
1170 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1171 to be used by aware (vtk) users that want to manage
1172 LUT (and no to turn the PALETTE image into an RGB pixels one)
1173 * GetPixelType now returns 8U for 24 Bits images
1174 (vtkGdcmReader compliant)
1176 2003-10-31 Jean-Pierre Roux
1177 * Removal of *all* gdcmData images and add them again
1178 in order to loose the 'history' of un-anonymised images
1180 2003-10-31 Jean-Pierre Roux
1181 * RMV : removal of useless jBitsInJsample.h
1182 for both 8 and 12 Bits JPEG Lossy Libraries
1184 2003-10-31 Jean-Pierre Roux
1185 * ENH : Add the functions gdcmFile::GetImageDataRaw
1186 gdcmFile::GetImageDataIntoVectorRaw
1187 that act as GetImageData and GetImageDataIntoVector
1188 except the making of an RGB Plane from Gray Plane + LUT
1189 Intended to aware (vtk) users who know how to manage
1192 GetLUTRGBA return a R,G,B,A LUT if any
1193 lgrTotaleRaw gives the 'Raw' length
1194 GetImageDataRaw returns the gray Plane
1195 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1196 (They stay Grey, just like with other Dicom viewers :-(
1198 2003-10-30 Jean-Pierre Roux
1199 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1201 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1202 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1203 being coherents dicom files.
1205 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1206 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1208 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1209 * ENH: Two steps is necessary to please VC++ compiler...
1210 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1211 * ENH: Add include dir to medcon lib
1212 * FIX: only one function is being exported for now !
1213 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1215 2003-10-29 Jean-Pierre Roux
1216 * adding gdcmHeader::GetLUTRGBA
1217 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1218 --> Mathieu, the modif u're waiting for is not yet committed
1219 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1221 2003-10-27 Jean-Pierre Roux
1222 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1223 00191113.dcm DermaColorLossLess.dcm
1224 MxTwinLossLess.dcm RadBWLossLess.dcm
1225 * ENH: For version prior to vtkImageViewer2 -r 1.19
1226 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1228 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1229 * Removal of ido stuff in CMakeLists.txt
1231 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1232 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1233 * FIX: remove a call to ->Modified ... see comments
1234 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1236 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1237 * FIX: Problem with path for libvtkgdcmPython
1238 * ENH: Try adding a search script for python site-package
1239 * RMV: Remove some file from medcon lib that are not necessary
1240 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1241 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1242 * FIX: More pragma disable fro VC++,
1243 I don't think I break something as it is also disable in VTK/ITK.
1244 But it fasten debug compilation time.
1246 2003-10-23 Jean-Pierre Roux
1247 * gdcm now deals with 16 Bits Run Length Encoded images
1248 (they are compressed as 2 planes images,
1249 one for the high Bytes, the other for low Bytes)
1251 2003-10-22 Jean-Pierre Roux
1252 * Now CheckRead takes into account :
1253 - the bugged 'Leonardo' Siemens images
1254 - the XA images, sent thru the burning VPRO station
1255 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1258 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1259 * FIX: When copying a Makefile.am to CMakeLists.txt
1260 one should remove the '\'
1262 2003-10-22 Jean-Pierre Roux
1263 * in gdcmData adding a bugged 'Leonardo' Siemens image
1264 (wrong lengths in header)
1265 OK with gdcm, KO with the other viewers :-)
1266 * add a GE dlx XA image, thru the VEPRO burning station
1269 2003-10-21 Jean-Pierre Roux
1270 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1271 for a brutal checking of vtkgdcmViewer compliance
1273 2003-10-21 Jean-Pierre Roux
1274 * add the files for 'xmedcon' Jpeg Lossless library
1275 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1277 2003-10-21 Jean-Pierre Roux
1278 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1280 2003-10-21 Jean-Pierre Roux
1281 * garbage Siemens 'Leonardo' images dealt with
1282 (the patch is easy to remove)
1283 * cosmetic changes to avoid warnings
1285 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1286 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1287 no need to press 'r' now.
1289 2003-10-20 Jean-Pierre Roux
1290 * upgrade of checkRead.sh checkWrite.sh according
1291 to new Jpeg Lossless decompressor
1292 * add US.3405.1.dcm, a genuine RGB medical file ...
1293 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1294 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1296 2003-10-15 Jean-Pierre Roux
1297 * general anonymisation in gdcmData
1298 * adding the 'color files' from
1299 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1300 * adding some well knowed bugged-header images
1301 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1302 waiting for their inclusion in Python testsuite
1304 2003-10-15 Jean-Pierre Roux
1305 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1306 no longer seg faults when file is not found
1308 2003-10-14 Jean-Pierre Roux
1309 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1312 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1313 * TODO: *.in file to genereate a UseGDCM later
1315 2003-10-14 Jean-Pierre Roux
1316 * Some supposed-to-be Dicom Images have no preamble.
1317 OpenFile takes it into account
1318 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1319 * Missing elements added in dicomV3.dic
1320 (just to be affraid : have a look at
1321 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1322 and do it again next year ;->
1324 2003-10-13 Jean-Pierre Roux
1325 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1326 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1327 But there are NOT. It's fixed !
1329 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1330 * FIX: "jpeglib.h" was not found on VC++
1331 * FIX: vtkgdcm was not being installed
1333 2003-10-10 Jean-Pierre Roux
1334 * ENH : OpenFile closes the file if it *really* doesn't look like
1335 an ACR-NEMA / DICOM one.
1336 * FIX : testWrite no longer writes an empty file if the source file
1337 is not gdcm Readable
1338 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1341 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1342 * FIX: CMake generate now documentation
1343 * ENH: out of source doc build !
1344 * ENH: Generate both user and dev documentation
1345 * ENH: Should work on windows too
1346 * ENH: Only one doxygen config.in file is needed
1347 * FIX: make install should be ok now on ùnix plateform
1348 * FIX: PATH to dictionary was wrong (missing /)
1349 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1351 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1352 * vtkGdcmReader is now able to read rgb dicom file.
1353 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1354 * added a gdcmViewer to vtk test, use mouse to control
1355 window level & window width
1357 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1358 * CMake-ification of gdcm, we have now two build system
1359 * FIX: on cygwin Wsock32 doesn't exist
1360 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1362 2003-10-06 Emanuel Ollart
1363 * FIX : compilation process wad broken.
1364 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1366 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1367 * change gdcmViewer -> vtkgdcmViewer
1368 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1370 2003-10-06 Jean-Pierre Roux
1371 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1372 ( e.g : well known GE images with a wrong elem length,
1373 : Philips MRI Images with a wrong Huffman table)
1374 * still to be done : allow the reading of bugged LEONARDO Siemens images
1376 2003-10-03 Jean-Pierre Roux
1377 * Odd length strings are padded with '\0' (not with spaces,
1378 to remain compliant with already defined strings,
1379 like Transfert Syntax UID and others)
1381 2003-10-03 Jean-Pierre Roux
1382 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1383 to allow displaying RGB images (not only by affim ;-)
1385 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1386 * vtkGdcmReader is now able to read rgb dicom file.
1387 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1389 2003-10-03 Jean-Pierre Roux
1390 * A few nasty patches to allow the reading of a lot of nasty images
1391 ( e.g : well known GE images with a wrong elem length,
1392 : Philips MRI Images with a wrong Huffman table)
1393 * still to be done : allow the reading of bugged LEONARDO Siemens images
1395 2003-10-03 Jean-Pierre Roux
1396 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1398 2003-10-03 Jean-Pierre Roux
1399 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1400 to allow displaying RGB images (not only by affim ;-)
1402 2003-10-03 Jean-Pierre Roux
1403 * gdcmFile::GetImageDataIntoVector now
1404 - deals with MultiFrames MultiFragments Run Length Encoded files
1405 - deals with YcBcR (YBR_FULL) files
1406 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1407 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1409 (no sample found :-(
1411 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1412 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1413 Two reasons: - clear things
1414 - third parties acces gdcm through header files, so won't
1415 suffer anymore VC++ complains
1417 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1418 * add argv[1] in testvtkGdcmReader.cxx
1421 2003-09-24 Jean-Pierre Roux
1422 * The lines are now eigthy characters long.for
1423 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1425 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1426 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1427 char* to std::string. Thus, the use of strdup becomes useless. (see
1428 previous commis of Malaterre)
1429 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1430 before the last Malaterre's commit.
1432 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1433 * This commit should fix the Debug building under VC++, the problem
1434 was mainly a mixture of debug and release lib being loaded at startup.
1435 * I also remove a depency to a specific C function: strdup. Because I had
1436 to force the link to msvcrtd (whereas strdup is in libc).
1438 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1439 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1440 located in the gdcmCommon.h file. All use of reference of tha has been
1441 changed to now use the variable GDCM_UNFOUND.
1443 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1445 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1446 Dicom dictionary. The test suite can now be run again. Note:
1447 I'm note very happy with the " (RET)" changes. I believe this
1448 RETAINED comment should be dropped when parsing the dictionary.
1449 - PACKAGER corrected
1451 - AUTHORS updated and now in alphabetical order
1452 * Makefile.am now exports gdcm.dsw for Windoze users.
1454 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1455 * cygwin complains about missing std:: in subdir Test/
1457 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1458 * remove some methods that are now in gdcmHeaderHelper
1460 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1461 * vtkGdcmReader set spacing and origin correctly
1463 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1464 * Fix a few delete/delete[] mismatch
1466 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1467 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1468 interpretation to data given by gdcmHeader. For instance there are
1469 heuristics to get informations (look at different places).
1470 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1471 sorting DICOM images based on different strategies.
1472 * modified Makefiles accordingly.
1474 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1475 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1476 when building in debug mode
1477 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1478 src/win32/gdcmdll.dsp
1479 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1481 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1482 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1485 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1486 * src/win32/libgdcmjpeg12.dsp was not dos format
1487 * src/win32/libgdcmjpeg12.dsp :
1488 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1489 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1491 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1492 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1494 * src/gdcmFile.cxx : bug fix in affectation type
1495 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1496 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1497 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1498 symbols... future problem ?
1500 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1501 * src/win32/libgdcmijpeg12.dsp was missing
1502 * modified gdcm.dsw accordingly
1504 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1505 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1507 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1508 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1509 commit of JPR (before his hollidays to facilitate our work).
1510 * setup.py : bug fix in code. Modifications made while the last commit
1511 of JPR. The code hasn't been tested before the commit... it's so
1512 useless to make that (for best programmer that is JPR) !!!
1514 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1515 * tagged the current version as Version0_3 (i.e. version 0.3)
1517 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1518 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1519 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1520 * *.dsp : modifications to use new libgdcmijpeg8 library
1521 * setup.py : bug fix on VTKPATH variable
1522 * PACKAGER : adding all concerning windows
1524 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1525 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1527 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1528 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1529 test suite reported error.
1530 * PACKAGER file added (describes what a packager must do when
1531 packaging a new release).
1532 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1533 * configure.in: upgraded version number to 0.3.0
1534 * fixing build of rpm (through rpm -ta):
1535 - Doc/Makefile.am exports proper doxygen files
1536 - src/jpeg/libijg8/Makefile.am exports the include files.
1538 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1539 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1540 * src/gdcmHeader.h : formatting code
1542 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1543 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1544 We were obtaining error message from vtk. Now, creation of file list
1545 is made in an internal list to prevent this problem.
1546 Bug fix when output is empty.
1547 Bug fix in update of progress value. Previous commit for this was a bad
1549 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1551 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1552 * src/gdcmHeader.h : added method to get the file name
1553 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1554 files. Added method to remove all files on the input
1555 Added FIXME comment concerning the bad parsing of header made by
1556 ExecuteInformation method (in ExecuteData method)
1558 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1559 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1560 when using make instal.
1561 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1562 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1564 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1565 * setup.py : adding include dir of jpeg lib to compile all sources
1566 * */Win32/*.dsp : JPR fix for windows compilation
1568 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1569 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1571 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1572 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1574 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1575 * setup.py is again effective on un*x (takes into account the
1576 addon of the jpeg library)
1577 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1578 * Doc/Doxy* updated (includes above enhancements)
1579 * INSTALL now points to web documentation
1581 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1582 * src/gdcmHeader.h doesn't make unnecessary reference to
1584 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1586 * src/gdcm*.[cxx|h] :
1587 - to allow compilation with gcc 3.x
1588 -- clean up of STL usage (added explicit usage of std::)
1589 -- small fixes on exceptions.
1590 Note: linking not tested !
1591 - clean of doxygen comments to avoid warnings at documentation
1593 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1594 dependent convertion).
1596 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1597 * Clean up of previous JPR garbage commit (not even commented in the
1599 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1600 - moved all jpeg related files from src to src/jpeg/libijg8, with
1601 addition/modification of Makefile.am and configure.in.
1602 - the testSuite is still brain damage (not guilty).
1604 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1605 * WrapVTK.py : modifications to get correctly vtk source files to
1607 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1608 (FileName -> Filename)
1610 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1611 * vtk/vtkGdcmReader.[cxx/h]:
1612 - UpdateProgress method should now be effective
1613 - removed the limitation on having only images loaded (as opposed
1615 - when building a stack of images/volume, a lesser number of
1616 gdcmHeader and gdcmFile instances should be used (hopefully
1617 accelerating things).
1618 - when building a stack of images/volumes, files which are not
1619 loadable (wrong path-filename, wrong permissions on existing file,
1620 or file not parsable by gdcm) are replaced with a black image
1621 in the stack (for the caller to notice the problem).
1623 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1624 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1626 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1627 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1628 between standard library (std) and vtk library (problems are found
1629 under Windows... thanks Windows !)
1631 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1632 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1634 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1636 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1637 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1639 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1640 * When compiling with distutils (see setup.py) the C++ compiler is
1641 called with different flags than the default ones (with automake).
1642 In order to fix all those warning, I compiled gdcm with the command
1643 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1644 and went for warning fixes:
1645 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1646 up from unused variables.
1647 - vtk/vtkGdcmReader.cxx: potential bug fix.
1648 * src/gdcmHeader.h: Doxygen warning cleanup
1650 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1651 * gdcmPython/gdcm.i:
1652 - typemaps correction to take into account the systematic replacement
1653 of "using namespace std" with std:: prefix e.g. std::list,
1654 std::string... (cf changes of 2003-05-21).
1655 - gdcmGlob global variable of type gdcmGlobal (defined in
1656 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1657 exported to Python a as cvar.
1658 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1659 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1660 gdcmDictSet.GetPubDictTagNames() and
1661 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1662 C++ static methods).
1663 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1664 with the above changes.
1666 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1667 * setup.py, manifest.in : bug fix under linux
1669 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1670 * Modification of setup.py to compile vtk part too. Then, we have 2
1671 wrappers which must work with same distutils. For that, we have a
1672 generic distutils in distusiltsWrapping.py ; with :
1673 - build_extWrap class to wrap generically all extensions,
1674 - ExtensionWrap base class for all wrapping extension that contains
1676 - Wrapper interface which wrap sources
1677 + In WrapSwig.py we have extension and wrapper for Swig
1678 + In WrapVTK.py we have extension and wrapper for VTK
1679 * MANIFEST.in : modifications to consider vtk directory and new python
1680 files for compilation
1682 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1683 * Added python wrappers of vtkGdcmReader vtk class (see the
1684 source in vtk/vtkGdcmReader.cxx) :
1685 - vtk/Makefile.am now builds a library
1686 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1687 python library (as opposed to _gdcm.so wich are the python
1688 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1689 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1691 - configure.in has an additional flag --enable-vtk that needs
1692 to be set to enable compilation of vtk related code, that is:
1693 + vtk/vtkGdcmReader.so and
1694 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1695 + gdcmPython/vtkgdcmPython.so (see above)
1696 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1697 be read when compressed or when HighBit + 1 != BitsStored),
1698 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1699 the usage of the python wrapper of vtkGdcmReader vtk class.
1700 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1701 * src/*.[h] all occurences of stl classes are now prefixed with
1702 std::, and all occurences of "using namespace std;" where removed.
1703 This is to avoid pollution of global namespace in included files.
1704 Apparently vtk does not avoid this pitfall: when using both
1705 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1706 collision of various stl members (principally cout...).
1707 * gdcmPython/testSuite.py now cleanly removes temprory generated
1709 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1710 comply with above changes)
1712 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1713 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1714 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1715 vtk data structure (an image Flip was required).
1716 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1717 * cosmetic changes in documentation.
1719 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1720 * src/gdcmHeader.cxx: the constructor no longer exits when an
1721 unexisting file is given as argument.
1722 * The subdirectory Data (containing all the images used for the
1723 test suite) is not part of this repository anymore. A new module
1724 containing those images is now available at
1725 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1726 with the name gdcmData.
1727 All the python scripts (including the package initialisation file
1728 gdcmPython/__init__.py) were adapated to take this change into
1729 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1731 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1732 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1733 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1734 demo of the usage of this class.
1735 Compilation of this vtk part is only done when using the --enable-vtk
1736 at configure (or autogen.sh) stage.
1738 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1739 * More memory link related corrections and documentation fixes.
1741 - maximum info is obtained with a command of the form:
1742 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1743 --show-reachable=yes PrintHeader
1744 - the remaining reachable blocks seem to come from the STL
1745 allocation scheme through the usage of map and list. It looks
1746 like this memory cannot be freed but it is not a memory leak
1747 (in fact further invocation to the STL would recollect the
1748 unused memory allthough it cannot explicitely be freed).
1749 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1750 of displaying an image parsed with gdcm and displayed with VTK.
1751 Note: some images don't seem to work e.g.
1752 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1753 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1754 Allthough this weakens the semantics, it is a ditch attempt to
1755 make gdcm more thread friendly.
1757 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1758 * Memory link hunt (by using valgrind through the command
1759 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1760 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1761 gdcmHeader::_dicom_vr.
1762 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1763 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1765 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1767 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1768 * src/Makefile.am now exports all the necessary include files at
1772 * UpdateGroupLength replaced by new one
1775 * UpdateGroupLength re-written using H-Table
1776 (named UpdateGroupLengthNew untill checks are over)
1778 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1779 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1780 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1782 - gdcmHeader::GetPubElValSet removed.
1783 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1784 UpdateGroupLength, WriteElements, Write.
1785 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1786 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1787 carried the same semantics.
1788 - src/gdcmHeaderIdo.cxx changed accordingly.
1789 - gdcmFile::WriteBase now regroups all the codes from previous
1790 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1791 - enum FileType moved to gdcmCommon.h
1792 * src/gdcmHeader.cxx AddDefault trashed
1793 * gdcmGetXSize added
1794 * getimageDataSize now calls gdcmGetXSize
1795 * Test/*.cxx changed to agree with above changes
1797 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1798 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1799 (to avoid double call by end user).
1800 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1801 by end user, since gdcmHeader::gdcmHeader now handles it.
1803 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1804 * gdcm/Doc many doxygen changes:
1805 - Doxyfile now has two different versions, DoxyfileUsers that generates
1806 the html.users end users oriented documentation and
1807 DoxyfileDeveloppers that generates the html.developper developper
1808 oriented documentation.
1809 - README changed accordingly
1810 - requirement.txt removed (old design info moved to TODO).
1811 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1812 DoxyMainPage.txt, DoxyPython.txt provide more information.
1813 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1814 be updated by simply regenerating the docs with doxygen and copying
1815 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1816 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1817 all the tests in the form "if (<map>.count() >1)" were removed.
1818 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1819 ill-formed documentation sections.
1820 * src/gdcmHeader.cxx: ditto
1822 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1823 * setup.py fixed for un*x (needed macro for stdint.h)
1824 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1825 un*ces with sh-utils test utility.
1826 * gdcmPython/demo/test.py renamed to PrintHeader.py
1827 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1828 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1829 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1830 * src/gdcm*.cxx JPR's bad inclusion fixed.
1832 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1833 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1834 * gdcmPython/demo/test.py changed accordingly.
1836 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1837 * gdcmPython/Makefile.am fixed linking against libstdc++
1838 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1839 * Swig subdir (historical tests of swig version 1.3.17++) removed
1840 * Test/testChangeEntete.cxx some lines commented out in order to make
1842 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1843 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1845 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1846 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1847 hence the user doesn't need this explicit call.
1848 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1849 i.e. LoadElements() call removed.
1850 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1851 - src/Makefile.am declares the proper flag for g++.
1852 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1853 for adding user defined new tags.
1854 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1855 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1856 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1858 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1859 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1860 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1861 src/Makefile.am : the project should properly compile and install
1862 with the autotools, included the python wrappers part.
1863 * gdcm.spec.in : added a spec file for RPM packaging.
1865 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1866 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1868 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1869 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1870 to exported to the environement (see gdcmPython/testSuite.py
1872 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1873 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1874 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1875 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1876 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1878 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1879 * gdcmPython/__init__.py doesn't crash anymore when running in
1880 in InstallMode or PreInstallMode but with an environement given
1881 value of GDCM_DICT_PATH.
1882 * src/gdcmDictSet.[cxx/h] coding style.
1884 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1885 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1886 * src/gdcm.h general comments moved to TODO, and README
1887 * src/gdcm.h should now be seen as a user commodity (including it
1888 should suffice to fully use gdcm). It is nowhere including within
1889 any of the kernel files src/*.cxx and src/*.h.
1891 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1892 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1893 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1895 * src/gdcm*.cxx only include their corresponding include file
1896 (as opposed to gdcm.h)
1897 * gdcmPython/gdcm.i changed accordingly
1898 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1899 the autogen.sh generated "make snapshot" command to work.
1900 * autogen.sh removed history related references to crea package.
1902 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1903 * distutilsSwigCPlusPlus.py work around some swig portability
1906 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1907 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1908 was done in a last ditch attempt to get setup.py _really_
1909 operationnal. The python/gdcmPython layaout add the advantage
1910 of hidding away the python related distutils specific files
1911 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1912 Alas, the src directory was out of scope (i.e. it's relative
1913 position to setup.py was ../src) which made things impossible to
1914 handle (see previous version of python/setup.py). Crossing fingers...
1916 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1917 * python/setup.py now works on Un*x. (harder than I thougth)
1918 * python/distutilsSwigCPlusPlus.py can now have include files
1919 among the list of sources.
1921 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1922 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1923 * modifications in MSVC projects
1925 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1926 * As stated by the first lines of Test/ExceptionAndPython/README, it
1927 looks like we can move back to original usage of exception within
1928 src/gdcm* and hence remove the errno stuff that was introduced
1929 as a quick and dirty fixture of this problem (added to the TODO).
1930 * Doc/Doxyfile configuration file for Doxygen and corresponding
1931 README file for usage added.
1932 * Test/testWrite.cxx added. This new test comes from a split of
1933 test.cxx that is now reverted to its original purpous i.e.
1934 testing the proper parsing of a Dicom related file.
1935 testWrite.cxx concentrates on testing the IO part of gdcm.
1936 * Test/bug1.cxx (containing a bug on WIn32) added.
1937 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1938 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1939 whose purpose is to publish the content of the TagNames of the
1940 Dicom public dictionnary were not accessible without an
1941 instance of class gdcmHeader.
1942 - those methods are now static methods of gdcmDictSet and hence
1943 require no instances at all to be invocated.
1944 - within gdcmDictSet this change required to change some method
1945 to class methods (i.e. are now static) among which SetDictPath
1946 (renamed to BuildDictPath) and LoadDefaultPubDict.
1947 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1948 the above changes by calling the new method classes of gdcmDictSet.
1949 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1950 the above to be effective.
1951 * python/gdcmPython: in order to wrap properly the above changes
1952 for Python, swig version now needs to be > 1.3.17.
1953 * python/gdcmPython/Makefile fixed to adapt itself to new
1954 configure/make shema introduced by Johan Montagnat (thanks for the
1955 contribution). Alas this Makefile cannot be turned into a proper
1956 Makefile.am without some heavy changes in the configure.in
1957 (for python dectection).
1958 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1959 now avoids publishing the empty entries.
1961 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1962 * python/setup.py : bug fix concerning install under windows
1963 ExtraPath reused :-P
1964 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1966 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1967 * Dicts/dicomV3.dic : remove double spaces !!!
1968 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1969 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1972 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1973 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1974 method. Doxygenation.
1975 * src/gdcm.h clean up of JPR spurious comments.
1977 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1978 * python/distutilsSwigCPlusPlus.py now properly collects the
1979 shadow classes generated by "swig -c++" (gdcm.py in our case)
1980 when using "python setup.py install".
1981 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1982 reexports the working classes.
1983 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1984 by the classical C errno scheme. This is to prevent an obscure
1985 behavior of the python wrappers when importing wxPython.wx prior
1986 to gdcmPython (which ended up in an abort call). An illustration
1987 of this oddity can be found in the Test/ExceptionAndPython
1988 subdir (see the README file). This problem probably due to
1989 an combination of g++ and dynamic loading.
1990 * added Test/ExceptionAndPython (see above)
1992 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1993 * Changed the layout of the python part to avoid bloating main
1994 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1995 i.e. the distutils arsenal. All the python related stuff is
1996 again in a python subdir, but the package itself is now in
1998 * setup.py was cleaned up:
1999 - pythonIncludePath removed
2000 - python setup.py bdist target is now functional.
2001 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2002 collision with other packages). gdcmPython/demo/*.py changed
2005 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2006 * python subdir moved to gdcmPython (preparation of distutils packaging).
2007 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2008 distutils installer is operational.
2009 * - gdcmPython/__init__.py now properly loads the swig generated
2010 shadow classes (from gdcm.py).
2011 - gdcmPython/demo/*.py changed to import the package gdcmPython
2012 instead of gdcmPython/demo/load.py.
2013 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2015 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2016 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2017 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2018 entries within the associated public Dicom dictionary resp. the same
2019 information but sorted by the fourth field (PAT, IMG, DIR) of the
2021 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2022 are now in the "???" group.
2023 - python/gdcm.i changed accordingly,
2024 - python/demo/printGroupedPublicDict.py added, that gives an example
2025 of the above new functionalities in Python.
2027 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2028 * src/gdcm.h, gdcmHeader.cxx:
2029 - historic references to glib's g_malloc and g_free (#defined)
2030 were definitively removed.
2031 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2032 * src/gdcmElValSet.cxx:
2033 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2034 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2035 - GetElValue(string) renamed to GetElValueByName.
2036 - Added GetElementByName(string).
2037 * src/gdcmHeader.cxx: added
2038 - GetPubElValRepByNumber(guint16, guint16)
2039 - GetPubElValRepByName(string)
2040 - GetShaElValRepByNumber(guint16, guint16)
2041 - GetShaElValRepByName(string)
2042 - GetShaElValByNumber(guint16, guint16)
2043 - GetShaElValRepByName(string)
2044 - GetElValRepByNumber(guint16, guint16)
2045 - GetElValRepByName(string)
2046 - GetElValByNumber(guint16, guint16)
2047 - GetElValRepByName(string)
2048 * Doc/requirements.txt added.
2050 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2051 * Test/Makefile building now depends on the one of libgdcm.so
2052 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2053 pixel data) aware which enables finding the address (offset) of
2054 the pixel data of JPEG encoded DICOM files. This leaves only a single
2055 file in the testSuite whose pixel data address (offset) is unknown.
2056 * python/testSuite.py changed accordingly.
2058 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2059 * VC++ has some strong limitations when working with the STL, as stated
2060 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2061 "Also note that some STL containers (map, set, queue, list, deque)
2062 cannot be exported. [...]
2063 Some STL classes contain nested classes. These classes can not
2065 This is caused by a designed limitation that once a template
2066 class is instantiated, it can not be re-instantiated and
2068 Since our usage of map<> is ubiquitous in gdcm, this "designed
2069 limitation" of VC++ is a pitfall.
2070 Hence the Python wrappers of gdcm cannot be incrementally linked
2071 against the c++ dynamic library. The dirty but only workaround is
2072 to forget about incremental link of dynamic libraries and to generate
2073 the Python wrappers library with the inclusions of the underlying C++
2075 The following modifications concern this matter on Win32/VC++:
2076 - wrapping python correct with standalone wrapped dll (don't use separate
2077 dll under windows !!!!)
2078 - python21_d debug mode enabled (ask Frog how to use it :-)
2079 - NO problem with having an STL member of class for example string in C++
2080 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2081 - Python test of dcmlib in Python is ok under windows on a large set
2083 * removed glib references
2084 * typedef's inserted in gdcm.i for correct swig type management
2086 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2087 * python/demo/*.py load.py extracted from test.py. Added explore.py
2088 that only displays required tags and testAll.py that parses all
2089 the files of the testsuite without using unittest.
2090 * python/testSuite.py other additional test on new files added.
2091 * Data/* new test files added accordingly to the testSuite.
2092 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2093 the vr in the file differs from the one of the dictionary.
2095 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2096 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2097 values, but limits itself to values which are below a user specified
2098 size (by default 1024 bytes).
2099 * python/gdcm.i : elements not loaded (because their size is above the
2100 user specified treshold) are exported with their TagKey as key of the
2101 python dictionary. This enables the testsuite to make some checks
2102 on the unloaded elements (since we have their offset and size).
2103 * python/testSuite.py
2104 - now tests for the existence and proper value of the pixel data
2105 - two new examples added.
2106 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2108 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2109 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2110 aware. See the strategy comments in gdcmHeader::FindeLength().
2111 * Test/test.cxx now accepts a filename as first argument.
2112 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2113 * python/testSuite.py changed to integrate test on above files.
2115 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2116 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2117 the vr was also RET.
2118 * python/testSuite.py more tests added.
2120 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2121 * python/testSuite.py unittest test suite added (uses Data)
2122 * Data/* dcm and acr files for the test suite.
2123 * glib dependance removed from un*x version. We now use ISO C99
2124 7.18 Integer types (see stdint.h)
2125 - python/Makefile, src/Makefile src/gdcm.h
2126 * src/ when an explicit vr (like dicom files) suddenly poped an
2127 implicit element we use to mark the underlying DictEntry of the
2128 concerned ElValue with "Implicit". This strategy was damageable
2129 too the public or provite dictionaries, since some of their vr
2130 would be changed. Since Header::FindLength heavily relies on the
2131 detection by Header::FindVR of falsely explicit elements, I
2132 added an extra ImplicitVr member to ElValue (boolean).
2133 The rest of the changes we the necessary adaptations.
2135 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2136 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2138 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2140 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2141 * Adaptation for porting to VC++:
2143 o forced to use std namespace (for string to be known)
2144 o all class use __declspec export style on WIN32
2145 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2146 (in stdlib.h on Win32 but in std:: for gcc)
2147 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2148 variable GDCM_DICT_PATH.
2149 * src/gdcmHeader.cxx verbose comments made discrete.
2151 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2152 * python/gdcm.i: added a typemap that converts a C++ hashing table
2153 to native Python dictionary.
2154 * python/demo/test.py:
2155 - now uses the native dictionary for exploration of gdcmHeader.
2156 - takes an optional filename argument (the file to parse).
2157 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2158 PubElVals hashing table.
2159 * Dicts/dicomV3.dic removed error prone trailing spaces.
2161 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2162 * Python wrapping process moved away from src/Makefile to
2163 newly created python/Makefile (as well as gdcm.i)
2164 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2165 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2166 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2167 from the environement variable GDCM_DICT_PATH (when existing).
2168 * src/gdcmDict::GetTag bug fix.
2170 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2171 * Straightforward temporary fixes for swig to build the python wrappers.
2172 src/Makefile now has a python working entry [by working we mean
2173 that we can import de shadow classes without errors].
2175 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2176 * hashtest.cxx removed (since allready in Test)
2177 * src/gdcmlib.h renamed to src/gdcm.h
2178 * src/dcm.i renamed to src/gdcm.i
2179 * src/Makefile prepared for python wrapping
2181 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2182 * src/gdcmHeader.cxx :
2183 - Parsing of header is now separated from loading of element values
2184 (see gdcmHeader::LoadElements).
2185 - general clean up of hopefully all file access (creation of
2186 ReadInt16 and ReadInt32)
2188 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2189 * src/gdcmHeader.cxx :
2190 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2192 - SetLgrElem renamed to SetLength
2193 - GetLgrElem renamed to GetLength
2194 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2195 * src/gdcmElValSet.cxx fixed both GetElValue methods
2196 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2197 due to IdoDude was cleaned out.
2199 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2200 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2201 concentrates on finding the value representation (when it exists).
2202 RecupLgr now only finds the element value length, and it avoids
2203 returning the unecessary skL (skipped length).
2204 Also, offsetCourant was simply removed (with taille_fich) since
2205 it was redundant with the File position internals (by using
2206 ftell and fseek). This also made skL (see above in RecupLgr) usage
2208 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2209 on the libido specificities which are handled through class
2211 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2214 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2215 * Truckload of changes. Parsing of header is barely functional
2216 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2218 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2219 * src/gdcmHeader.cxx many addons of low level methods
2221 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2222 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2223 and _IdDcmSWAP_LONG.
2225 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2226 * This corresponds to all the changes decided at the meeting of
2227 May 23 2002. Needless to say we are running late...