1 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
3 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
4 - more code moved away from File:: to PixelConvert::
5 - fat setup of PixelConverter set in place in File::Initialise.
7 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
8 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
9 namespace at the file system level. So now you should convert your examples
11 gdcmHeader -> gdcm::Header
12 It would be nice if people keep in mind to no open the namespace, since it
13 allows compilation on broken plateform which were defining common symbol in
14 the standart namespace (like LP, Unknown ...)
16 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
17 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
18 The JPEG fragments are now parsed at the same stage than the RLE
19 information. All code related to JPEG is now in gdcmPixelConvert:
20 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
21 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
22 export a gdcmFile:: method. Those are simply global functions
23 (for the time being this is better than having them attach to
24 either gdcmFile:: or gdcmPixelConvert::).
25 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
26 and stores the result in a gdcmJPEGFragmentsInfo.
27 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
28 code (among other stuff) moved away from gdcmFile:; to
31 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
32 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
33 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
34 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
35 clean up of RLE related code.
36 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
37 - src/gdcmRLE.cxx removed
38 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
39 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
40 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
41 * CLEANUP_ROUND (9) for gdcmPixelConvert
42 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
43 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
44 away from gdcmFile:: to gdcmPixelConvert::.
46 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
47 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
48 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
49 This is because Parse7Fe0 used to parse the pixels to compute the
50 length. This task was passed over to FindDocEntryLengthOB() a long
51 time ago, EXCEPT I had forgotten the OW case...
52 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
53 we just recylce the code for parsing RLE fragments and computing
55 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
56 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
57 with the retired Parse7Fe0().
58 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
59 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
61 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
62 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
63 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
64 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
65 - src/CMakeLists.txt: alphabetic order reodering + new entries.
66 * CLEANUP_ROUND (4) for gdcmPixelConvert
67 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
68 to return an unused length.
70 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
71 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
72 this should be cleanner from the plane view. The iostream are erally a pain
73 to use to do simple stuff.
75 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
76 * Redo the compilation of the ijg jpeg library. Now only one source is
77 necesseray. No need to rename file by hand what so ever. CMake handle the
78 copying of the file within different directory, configure header file to
79 modify some symbol. The only addition made to ijg wasd a mangle table so
80 that symbol are different wether we are within 8bits or 12bits.
82 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
83 * Added documentation of vtkgdcmReader on Website:
84 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
85 with it's binary name).
86 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
87 the Website to be more complete.
88 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
89 doxygenated documentation.
90 - Doc/DoxyVtkGdcmReaderExamples.txt added
91 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
92 DoxyVtkGdmReaderExamples.html )
93 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
94 * CLEANUP_ROUND (3) for gdcmPixelConvert
95 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
97 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
98 * CLEANUP_ROUND (2) for gdcmPixelConvert
99 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
101 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
102 * CLEANUP_ROUND for gdcmPixelConvert:
103 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
104 - src/gdcmPixelStuff[h|cxx] removed
105 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
106 - src/CMakeLists.txt changed accordingly
108 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
109 gdcmVersion.py moved to newly created ATTIC related
110 gdcmPython/SetupOldies/ directory.
111 * Autotools clean up:
112 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
113 - autogen.sh configure.in acinclude.m4 python.m4 removed
115 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
116 * src/*.cxx *.h Reference to License.htm fixed to License.html.
117 * Doc/CMakeLists.txt, doxygen.config.in: fix.
118 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
120 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
121 * TODO updated with Mathieu suggestions. I proposed a template for
122 describing TODO entries and used it for new entries.
123 * Added Doc/Website/CodingStyle.html, Developpers.html,
124 DeveloppersPython.html, GdcmDataCvs.html and
125 DownloadVersion0_1.html, DownloadVersion0_3.html.
126 * Some Doc/*.txt Doxygen files (which do not really concern the
127 documentation itself, but the website) moved to html and
128 placed in directory Doc/Website:
129 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
130 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
131 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
132 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
133 * CMakeLists.txt changed accordingly.
134 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
135 DeveloppersPython.html
136 * INSTALL nows refers to Doc/Website/Installation.html
138 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
139 * Added Doc/Website directory, that contains a first raw version
142 2004-09-23 Jean-Pierre Roux
143 * FIX In order not to be poluted any longer by casting problems,
144 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
145 we can now delete[] it safely
146 * VoidArea is now called BinArea (less confusing name),
147 and all the methods called ...VoidArea... are now ... BinArea...
148 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
150 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
151 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
152 clear) TagHT, which is an inherited member of gdcmElementSet. It is
153 up to the destructor of gdcmElementSet to clean up TagHt and it's
156 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
157 * Test/CMakeLists.txt: update to follow gdcmData renamings.
158 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
160 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
161 * ENH: added some utility method that builds a flat dictionnary
162 holding all the Dicom entries contained in the recursive structure
163 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
165 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
166 BuildFlatHashTable() that build a flat dictionary.
167 - src/gdcmElementSet.h: added a new private GetTag() accessor.
168 gdcmDocument is now a friend of gdcmElementSet.
169 - src/gdcmElementSet.cxx: clean up.
170 - Example/FlatHashTablePrint.cxx added.
171 - Example/CmakeLists.txt changed accordingly
173 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
174 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
175 moved away from gdcmDocEntrySet (since this class is an abstract class
176 acting like an interface). SQDepthLevel and BaseTagKey are now
178 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
179 and associated accessors. Doxygenation of the class.
180 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
182 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
183 Use SQDepthLevel accessor instead. ::Print() adapted.
184 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
185 - src/gdcmDocument.cxx changed accordingly.
187 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
188 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
189 - The following is the doxygen comment of the typedef declaration
190 of gdcmagKey in src/gdcmCommon.h:
191 gdcmTagKey is made to old an "universal" (as in URL, Universal
192 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
193 A dicom tag allways has a group and an element, but a set of tags
194 embeded in various (optionally nested) sequences and sharing
195 the same group and element all share the same (group, element)
196 "identifier". Hence the (group, element) cannot be used as an
197 identifier (in gdcm we shall refer to a "TagKey") of a tag.
198 In order to construct a proper tag identifier (i.e. a key) we
199 consider the following definition of a TagKey:
200 - let Group, Element be the string representation of the
201 group and element dicom tag members,
202 - let ItemNumber be the string representation of the integer
203 index of the considered item number of a sequence,
204 Let the key of a tag embeded in a sequence, noted SeqTag, be
206 /ItemNumber#Group|Element
207 where "/", "#" and "|" are characters acting as separators.
208 Then the general form of a gdcmTagKey is given by:
209 Group|Element<SeqTag>
210 where <SeqTag> means NO or many instances of SeqTag.
211 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
214 but the gdcmTagKey of a tag "embeded" is the first item of
215 a sequence, itself nested in the third item of a sequence is the
217 0004|1220/2#0008|0082/0#0008|0090
218 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
219 order to hold the new sequence compatible key. Previously, the
220 GetKey() method would look in the underlying gdcmDictEntry.
221 - src/gdcmDocEntry.cxx:
222 -- constructor now copies the underlying DictEntry key, in the local
224 -- ::Print: displays the member Key, instead of the (group, element).
225 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
226 - src/gdcmDocEntrySet.h:xi
227 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
228 -- now has a new BaseTagKey member.
230 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
231 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
233 This poses the problem with the semantics of the following lines
234 LoadEntryVoidArea(0x0028,0x1201); // R LUT
235 LoadEntryVoidArea(0x0028,0x1202); // G LUT
236 LoadEntryVoidArea(0x0028,0x1203); // B LUT
237 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
238 to the long FIXME note for what the problem is. Nevertheless in
239 order to get things working the dicom dictionary was altered !
240 Please fix things urgently...
241 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
242 information), see above note on moving the member VoidArea. Nevertheless
243 the following entries previously correctly set as US are now inproperly
245 0028 1201 OW IMG Red Palette Color Lookup Table Data
246 0028 1202 OW IMG Green Palette Color Lookup Table Data
247 0028 1203 OW IMG Blue Palette Color Lookup Table Data
248 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
249 of gdcmDocEntry moved to gdcmSeqEntry.
250 * src/gdcmSeqEntry.cxx: STYLE.
252 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
253 * Test/TestAllEntryVerify.cxx minor fix and added comments.
255 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
256 * gdcmPython/testSuite.py: all the test suite in python is now moved
257 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
258 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
259 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
261 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
262 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
263 to avoid inclusion recursion until STL is reached.
264 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
265 mecanism. errno.h is not included in gdcm anymore.
266 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
267 (gdcmFormatError now inherits from gdcmFormatUnexpected).
269 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
270 gdcmData/TestAllEntryVerifyReference.txt
271 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
272 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
273 exception_on_error parameter.
274 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
275 - vtk/vtkGdcmReader.cxx changed accordingly,
276 - Example/*.cxx and Test/*.cxx changed accordingly.
278 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
279 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
280 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
281 enable_sequences removed from gdcmHeader constructor and dependencies.
282 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
283 * gdcmPython/demo/PrintHeader.py: dummy fix.
284 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
285 skip_shadow removed from gdcmHeader constructor and dependencies.
286 * Example/*.cxx and Test/*.cxx changed accordingly.
288 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
289 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
290 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
292 2004-07-21 Jean-Pierre Roux
293 * FIX Now, Parsing and Printing a DICOMDIR do work!
294 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
296 2004-07-20 Jean-Pierre Roux
297 * FIX Some brain damaged headers have Zero-Lenght fields
298 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
300 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
301 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
302 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
303 variable (instance of gdcmDebug) by a definition macro, and the instance
304 is now in static in the gdcmDebug class
305 * src/gdcmSQItem.h : (FIXME) remove an undefined method
306 * Test/PrintAllDocument.cxx : bug fix in the result of the test
308 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
309 * WARNING: ctest now depends more tightly on gdcmData. You should
310 check out gdcmData properly for things to run smoothly...
311 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
312 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
313 we need the pixels not be loaded in order to use the ValEntry
314 that displays position and size).
315 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
316 This is a C++ based equivalent of gdcmPython/testSuite.py that should
317 be deprecated. If you have any doubts about the advantages of a
318 modern scripting language (read Python) versus grass root C++ (i.e.
319 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
320 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
321 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
322 Anyhow, consider documenting the gdcmData images in
323 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
325 * Test/CMakeLists.txt:
326 - now uses TestAllEntryVerify.cxx
327 - specific comments on oldACR00001.ima (now renamed in gdcmData
328 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
329 gdcmData/TestAllEntryVerifyReference.txt
332 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
333 * src/*.[h|cxx] : typedef clean up
334 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
335 - TagKey renamed to gdcmTagKey (for external usage)
336 - VRKey renamed to gdcmVRKey (for external usage)
337 - removal of typedef duplication.
338 - Removed all unecessary inline keyword from class inline definitions.
339 - Some method|function(void) declarations replaced with method|function().
340 * src/jpeg/libijg12/jdhuff12.c:
341 - printf polluting ctest removed.
342 - TAB removal for comminting
344 - TestAllReadCompareDicom.cxx: added a test that compares all the
345 images in gdcmDataImages.h with corresponding images in
346 gdcmData/BaselineDicom/. When baseline images are not present
347 this test creates them.
348 Note: we need to validate each reference image, but before that
349 I'd like to rename them with a more explicit name...
350 - CMakeLists.txt: changed accordingly.
351 * Example/*.cxx: examples now only include gdcm.h (as opposed to
352 including each header needed).
354 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
355 * Test/*.cxx and Example/*.cxx: moved some examples away from the
356 test suite to the Example directory. Are concerned:
361 - TestWriteSimple.cxx
362 * Test/CMakeLists.txt: added some comments on reasons for black listing
363 image gdcmData/oldACR00001.ima
365 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
366 * Test/CmakeList.txt: removed the following from black list (to be coherent
367 with removal from gdcmData):
368 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
369 - gdcm-MR-PHILIPS-16.dcm
371 Added the following because after last cvs update, they cause
372 ctest -R TestReadWriteReadCompare
374 - gdcm-MR-SIEMENS-16-1.acr
376 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
377 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
378 new comments in this file) we temporarily (sigh) move to a weaker
380 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
381 we don't need to black list the following images anymore:
382 - 8BitsUncompressedColor.dcm
384 - US-PAL-8-10x-echo.dcm
385 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
386 fixes and the beautified code ;-)
387 This fixes the bug introduced in version 1.42 (when beautifying)
388 that made the parsing of 8BitsRunLengthColor.dcm unproper.
389 Note: ctest was blind to this bug (this means we need to still
390 improve the test suite). The bug could be detected by using
391 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
393 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
394 and by displaying the (garbage) produced file temp.XDCM...
396 2004-06-29 Jean-Pierre Roux
397 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
398 - replace by uggly but working old code :-(
399 A lot of things should be OK again.
400 It's really urgent to have a test suite that *tests*,
401 to prevent Frog's beautifying sessions to break all the stuff
402 (twice, withing a fortnigh ...)
404 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
405 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
406 redundancy) to added Test/TestReadWriteReadCompare.cxx
407 * Test/CmakeList.txt: because the compare test of
408 Test/TestReadWriteReadCompare.cxx fails, the following images are
409 black listed: - 8BitsUncompressedColor.dcm
411 - US-PAL-8-10x-echo.dcm
412 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
413 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
414 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
415 and ad-hoc kludge. This kludge is now removed, and on encountering
416 such an image (OB field brain damaged) we set errno. Then in
417 ::FindDocLength() we "fix" the length as being ALL what remains
418 in the file (until EOF). We then proceed, hoping for the best...
419 This fixes a SegFault in ShowDicom when trying to write such an
421 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
422 (because TestWriteRead breaks on it, after a non conformal commit?).
423 ctest now runs properly, except for MakeDicomDir (which was allways
424 broken) and the Python related stuff (still not fixed).
426 2004-06-24 Jean-Pierre Roux
427 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
428 FIX : Test/TestReadWrite now iterates on all the file names
429 (instead of infinite loop)
430 ENH : Test/TestWriteRead now iterates on all the file names
432 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
433 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
435 2004-06-24 Jean-Pierre Roux
436 FIX : - now Write drops LUT Descriptors and LUTs (if any)
437 when SamplesPerPixel =3
438 - now Write is no longer confused by
439 'BitsAllocated = 12" and 'BitsStored=12"
440 - "UN" value representation Elements are now written correctly
441 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
442 ENH : - now gdcmHeader has its own Write methods
443 (in order to split the job that has not to be done
446 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
447 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
448 loop on the same image until memory went out.
449 Note: this means we still have gobs of memory loss in PrintDocument
450 * src/gdcmDocument.cxx: fixes problem on parsing on file
451 gdcmData/16BitsJpegLosslessGrayScale.dcm.
453 2004-06-24 Jean-Pierre Roux
454 FIX : Write - All the Sequences and Sequence Item are now written
455 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
456 is added a the end, when necessary.
457 - A lot of brain-damaged images, that were read correctly are
458 now written correctly
459 - length compatible BinEntry are now loaded correctly
460 (even for odd groups)
461 Note : only Explicit Value Representation was checked.
462 (question : is implicit VR really necessary for gdcm ?)
464 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
465 * DEVELOPPER: added a proposition of coding style.
466 * src/gdcmDocEntry.h: removed every inline declaration (for test of
469 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
470 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
471 Use the gdcmDocEntry::Print() and Write() instead.
472 * src/gdcmDocument.cxx: bug fix.
474 2004-06-22 Jean-Pierre Roux
475 FIX : gdcmDocument.cxx
476 - Now we do recognize the JpegLossLess format (there was a misstyping in
477 code 'beautyfication' :-(
478 - Now we automaticaticaly load the Luts, if any
480 2004-06-22 Jean-Pierre Roux
481 In order : to write Sequences, whatever their imbrication level,
482 : to allow user to create his own Sequences
483 a lot of modif where necessary (adding, moving, or virtualising methods)
485 WARNING : save your own sources *before* cvs up !
488 ADD virtual void Write(FILE *fp, FileType filetype);
491 ADD virtual void Write(FILE *fp, FileType filetype);
492 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
495 ADD virtual void Write (FILE *fp, FileType filetype)=0;
496 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
497 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
498 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
499 ADD std::string GetEntryByName(TagName name);
500 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
502 std::string vr = "unkn",
503 std::string fourth = "unkn",
504 std::string name = "unkn");
505 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
506 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
507 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
508 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
509 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
510 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
511 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
512 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
515 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
516 ADD virtual std::string GetEntryByName (TagName tagName);
517 ADD virtual std::string GetEntryVRByName (TagName tagName);
518 REM virtual bool Write(FILE *, FileType);
519 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
520 FILE *_fp, FileType type);
521 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
522 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
523 REM virtual bool WriteEntries(FILE *_fp,FileType type);
524 REM virtual std::string GetEntryByName (std::string tagName);
525 REM virtual std::string GetEntryVRByName (std::string tagName);
526 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
527 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
528 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
530 std::string vr = "unkn",
531 std::string fourth = "unkn",
532 std::string name = "unkn");
533 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
534 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
535 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
536 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
539 ADD virtual void Write(FILE *fp, FileType filetype);
542 ADD virtual void Write(FILE *fp,FileType filetype);
545 ADD virtual void Write(FILE *fp, FileType filetype);
546 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
547 REM std::string GetEntryByNumber(guint16 group, guint16 element);
548 REM std::string GetEntryByName(TagName name);
551 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
553 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
554 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
555 The default constructor invoked by the line
556 gdcmHeader *f1 = new gdcmHeader( header );
557 was gdcmHeader::gdcmHeader(bool) instead of the expected
558 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
559 Hence the parsing wasn't executed... See also below.
560 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
561 as explicit constructor didn't do the trick to fix the above problem.
562 Could anyone explain why ?
563 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
564 properly calls gdcmValEntry::Print() (that was weed out from
565 code related to gdcmBinEntry).
567 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
568 * In order to fix memory leaks:
569 - Test/TestWriteSimple.cxx: added cleaning of free store through
571 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
572 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
573 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
574 (through the call to ::AddDicomDirMeta()) or the destructor
575 would crash when deleting uninitialized ::metaElems].
576 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
577 - src/gdcmDocument.cxx:
578 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
580 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
581 was causing memory leaks.
582 - src/gdcmSQItem.cxx:
583 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
584 cleanly handled with polymophism: sorry but my milage is low).
585 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
586 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
587 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
588 This avoids SegFaulting.
589 - src/gdcmSQItem.h: coding style.
591 - Test/TestWriteSimple still severely sucks. The output image content
592 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
593 damaged when displayed with vtkgdcmViewer.
594 - on memory leaks: TestWriteSimple leaks really less (see entry
595 of 2004-06-18 in Changelog file for the call to valgrind).
596 - on segfaults: ctest now passes all the tests but one (no more
598 * Erroneous leading white fix:
599 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
600 white[s] (as opposed to from >> xxx, that removes it [them].
601 - src/gdcmTS.cxx: ditto.
602 - gdcmPython/testSuite.py: dirty related kludge removed.
603 * src/*: remaining references to gdcmParser removed.
604 * src/*[cxx|h]: added copy[way]left header.
607 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
608 * In order to fix writing of dicom files:
609 - Test/TestWriteSimple.cxx: a simpler example of writing.
610 - Test/CMakeLists.txt changed accordingly.
611 - src/gdcmDocument.cxx:
612 -- The destructor now recursilvely removes potential sequences.
613 -- Bug fix in ::IsJPEG2000()
614 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
615 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
617 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
618 to only declared) and build on top of
619 ::GetDocEntryByNumber(guint16, guint16).
620 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
621 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
622 for usage in destructor and treatement of promotion in
623 ::ReplaceOrCreateByNumber().
624 - src/gdcmSQItem.cxx: destructor should better handle his job.
625 Test/TestWriteSimple now runs (or at least it DOES something).
626 * We can now start hutting memory links. A good starting point is:
627 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
628 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
629 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
631 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
632 * Valgrind note: after Mathieu Malaterre teached me how to read
633 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
635 Using gcc, you can force the STL to use malloc and to free memory as
636 soon as possible by globally disabling memory caching.
637 With 3.2.2 and later, you should export the environment variable
638 GLIBCPP_FORCE_NEW before running your program.
639 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
640 simply vanish (it is still not clear to me, whether this means that
641 STL std::string leaks or if valgrind believes it leaks...).
642 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
643 running bin/gdcmTests makeDicomDir):
644 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
645 - Test/makeDicomDir.cxx now properly traps empty lists and returns
647 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
648 SegFaulting (I drowned in DicomDir related code when trying to
649 understand why the list is empty...).
650 * src/gdcmDocument.h: first BSD license header try.
651 * Doc/License.txt added.
653 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
654 * src/gdcmDocument.[h|cxx]:
655 - Clean up of the Transfer related predicates. They are now all based
656 on new method isGivenTransferSyntax, that (should) handle properly
658 - general clean up, simplification, and coding style.
659 - Specific clean up of Parse7FE0() (umproperly named actually).
660 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
662 2004-06-14 Jean-Pierre Roux
664 - fix the display of Sequence Delimitor (SQDepthLevel pb)
665 - fix the display of SQItem ordinal number
666 - add the GetSQItemByOrdinalNumber method
667 - remove some useless never written private methods
669 2004-06-14 Jean-Pierre Roux
671 - adding a constructor taking a gdcmDocEntry as an input param
672 - ReplaceOrCreateByNumber now returns :
673 a gdcmBinEntry * if a Binary (void *) value is passed as a param
674 a gdcmValEntry * if a string value is passed as a param
676 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
677 according to the param type (no longer sets a gdcmDocEntry)
678 - GetValEntryByNumber, GetBinEntryByNumber added
679 - NewValEntryByNumber and NewBinEntryByNumber added
681 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
683 - GetSQItemNumber and SetSQItemNumber added, to provide
684 a (relative) Item identier inside a given Sequence
685 \warning : some pb remaining around this number
687 - AddEntry now takes the Item Number as a param
689 - adding a constructor taking a gdcmDocEntry as an input param
691 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
692 * Memory leak hunt with the following command:
693 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
694 --show-reachable=yes gdcmTests PrintDocument
695 It looks like many (all?) leaks are due to the STL (or a bad usage
696 of the STL. The lines producing the leaks now have a comment with
697 a "MEMORY LEAK" tag: you can retrieve them with
698 grep "MEMORY LEAK" src/*
699 Here are two typical examples which I can't help fixing:
704 char * test = "babo";
705 name = test; //// <--- valgrind detects 960 bytes lost in
706 //// call to std::string::operator=(char const*)
707 name.clear(); //// Doesn't help !
715 std::cout << "Type a bunch of characters followed by RETURN: ";
716 getline(std::cin, line); //// <--- valgrind dectects a loss
717 //// of 1320 bytes in call to
718 /// std::basic_istream<>& std::getline<>
724 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
725 * src/gdcmHeader.[cxx|h]:
726 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
727 and related, moved away to gdcmDocument.
728 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
729 the corresponding protected accessors of inherited class
730 gdcmDocument, removed ! As a consequence gdcmFile had to be
731 declared friend of class gdcmDocument (see below).
732 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
733 - Clean up of undefined or unused methods.
734 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
735 account the changes to gdcmHeader.h).
736 * src/gdcmDocument.h:
737 - gdcmFile is now a friend class (in order to take into account the
738 changes to gdcmHeader.h).
739 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
740 (see changes to gdcmHeader.h).
741 - Accessors (reading on the form GetEntry*) are now public.
742 - Clean up of undefined or unused methods.
743 * src/gdcmDocument.cxx:
744 - adaptation to changes to gdcmDocument.h
745 - ::OpenFile now writes a verbose message when file cannot be opened.
746 - some std::string properly set to VRKey
747 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
748 references to gdcmDocument.
749 * Test/TestFindTags.cxx: changed accordingly to above changes.
750 * gdcmPython/testSuite.py: adapted to renaming of acr files in
751 cvs repository gdcmData.
753 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
754 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
755 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
756 conflicts with gdcmValEntry::voidArea.
757 * src/gdcmValEntry.cxx: unmatching comment wiped out.
758 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
759 Value representation between StringRepresentable and BinaryRepresentable.
760 * src/gdcmDocument.cxx:
761 - method ParseDES: proper indentation restored and usage of
762 gdcmVR::IsVROfGdcmStringRepresentable wired in.
763 - method LoadDocEntry: the fingerprint left in the SetValue() of
764 unloaded entries (length > MaxSizeLoadEntry) had curiously been
765 removed. Reverting to previous code segment with the proper
766 dynamic_cast< gdcmValEntry* >.
767 Note: this was (partially) breaking the python test suite
768 (gdcmPython/testSuite.py) that made usage of the above
769 fingerprint to check presence of "Pixel Data".
770 * src/gdcmDocEntry.h: coding style.
771 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
772 now taken into account.
773 * gdcmPython/gdcm.i: adaptation to the new internal representation
774 of gdcm (exit gdcmParser, hello gdcmDocument).
775 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
777 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
778 anymore, but instead prints the loaded Python dictionary.
779 * .... alas, the python testSuite is still broken.
781 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
782 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
784 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
785 * src/gdcmUtil.h : export methods
787 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
788 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
790 * Initial addition of automatic python testing
791 * Initial addition of automatic image comparison
793 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
794 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
795 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
797 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
798 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
799 * Test/ShowDicom.cxx : bug fix for msvc compilation
800 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
802 2004-05-04 Jean-Pierre Roux
803 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
804 new concepts (and new classes) :
805 a 'gdcmDocument' is composed of a set of Doc Entries, that are
806 - elementary gdcmDocEntries (former gdcmHeaderEntries)
807 - Sequence Doc Entries (gdcmSeqEntries)
808 a Sequence is composed of Items.
809 Each item is a set of Doc Entries (this is recursive)
810 The non uniqueness of the 'Dicom tag' is due to this recursivity
811 (never taken into account)
812 Our unability to add a new 'entry' in the header
813 at the proper location (neither in the H-Table (map or multimap),
814 nor in the Chained List is also due to this recursivity.
815 Don't try, right now, to use/modify/compile these new sources :
817 We just commit all the stuff, 'as is', in order not to loose it.
819 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
820 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
822 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
823 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
824 file prefix (SetFilePrefix)
826 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
827 * Add a new test: ShowDicom, for now this is just the c++ version of
828 checkRead.sh, later it will be able to compare the image read against a
830 * Replace the DEBUG on the stack with a global entry in cmake interface:
831 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
833 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
834 * Add an example subdir, with a real example on how to read + write a
837 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
838 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
839 * Doc/CMakeLists.txt: the main page is now properly differentiated
840 between the developper and user version.
841 * Doc/doxygen.config.in: dropped search related obsolete flags
842 * src/gdcmParser.h, gdcmHeader.h: doxygenation
844 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
845 * DEVELOPPER: added some helpfull comments for compile/test/install
848 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
849 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
850 src directory, now generated in the build dir.
851 2. Tests as mentionned smarter
853 4. Add a new method in gdcmDict that return the PubDict by name
854 this is interesting for 3rd party lib like ITK,
855 where we could set the institution name / patient name...
857 * ENH: 1. Now the test suite is working for real
858 2. All binaries are now output in the gdcm-bin directory
859 (this was not true before)
861 2004-04-28 Jean-Pierre Roux
862 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
863 SeQuence indented printing of Dicom Header.
864 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
865 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
866 Computation of SQDepthLevel is now part of gdcmHeader constructor
867 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
868 tree-like structure of a Dicom Header.
869 * FIX Test code cleaning
871 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
872 * ENH: Adding automatic testing
873 1. Need a DartConfig.cmake to submit to public
874 2. Add a test driver gdcmTest.cxx
875 3. gdcmTestMain, an helper for the main test driver gdcmTest
876 4. Files in Test don't have a main anymore, this becomes interesting
877 when we add more and more tests, thus dsw don't have to load
879 * ENH: Adding a GDCM_DATA_ROOT for testing
880 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
881 one file instead of seven + some small cleanup
883 2004-04-22 Jean-Pierre Roux
884 * ENH Minor changes to the Print() methods.
885 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
886 Header printing. Example given with :
887 > PrintHeader fileName 2 new
888 (SQ based tree-like structure still to be done for the Header ...)
890 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
891 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
892 1. I have added some unsigned where needed
893 2. Some function parameter not used -> (void)
894 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
895 4. g++ don't like character '\' in comment
896 5. #define jpeg_create_decompress jCreaDecompress
897 this really need to be fixed
898 6. virtualize destructor of gdcmObject ... leakage
899 7. sscanf(g->first.c_str(),"%x",&gr_bid);
900 this also really need to be fixed
901 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
902 remove compression file
903 (as we only do decompression, right ?)
904 * ENH: Change malloc/calloc/free with c++ equivalent
906 2004-04-21 Jean-Pierre Roux
907 * FIX gdcmHeaderHelper::GetXSpacing
908 when a single value is found (bug ?), xpacing is now
909 defaulted to yspacing
911 2004-04-19 Jean-Pierre Roux
912 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
913 * ENH add parameters :
914 bool exception_on_error = false,
915 bool enable_sequences = false,
916 bool ignore_shadow = false
917 to the gdcmFile constructors to be full gdcmParser compliant
918 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
919 to allow reading of PAPYRUS 3.0 files
921 2004-04-06 Jean-Pierre Roux
922 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
924 2004-04-02 Jean-Pierre Roux
925 * ADD : Test/checksequence.sh, for a general recap on SQ pb
926 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
927 for Philips spurious Tag fffe|0000 while rewritting Dicom files
929 2004-03-30 Jean-Pierre Roux
930 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
931 for ACR file, written out as DICOM files (hope so...)
933 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
934 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
935 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
936 moved to base class gdcmParser and only the specialisation is kept
938 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
939 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
940 already does the job.
941 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
942 (to be consistent with gdcmParser::WriteEntries).
944 2004-03-30 Benoit Regrain
945 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
946 upate of the object's instance. It's passed to 2 in the unfavorable
947 case : one in the ExecuteInformation, one in the ExecuteData
949 2004-03-29 Jean-Pierre Roux
950 * ENH : Check on file type to be written moved
951 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
952 * FIX : gdcmObject::ResetBoundaries now stops properly
953 when end-of-list is reached
954 : gdcmVersion modified (as Benoit Regrain asked)
956 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
957 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
958 * src/gdcmUtil.cxx: added forgotten iostream include.
959 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
960 equivalent to ExplicitVR in existing code).
962 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
963 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
964 now contains all the gdcmGlobal related code.
965 * minor coding style and doxygenation changes.
967 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
968 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
969 now contains all the Debug related code.
970 * minor clean-up of includes in src/*.cxx
971 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
972 CreateCleanString) removed.
973 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
974 * Doc/DoxyMainPageUser.txt added.
975 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
976 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
979 2004-03-24 Jean-Pierre Roux
980 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
982 2004-03-23 Jean-Pierre Roux
983 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
984 big endian made volumes
985 * ENH Now gdcmParser constructor and destructor are protected to forbid
986 end user to instanciate class gdcmParser
987 (only gdcmHeader and gdcmDicomDir are meaningfull)
989 2004-03-22 Benoit Regrain
990 * FIX : src/gdcmDicomDir.cxx : make windows compilable
991 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
992 gdcmSerie to gdcmDicomDirSerie
994 2004-03-19 Jean-Pierre Roux
995 * ENH Now the tree-like structure describing a DICOMDIR comming from
996 an already existing DICOMDIR file is consistent with
997 the home-made tree-like structure build ex-nihilo
998 or build from the files held (recursively) in a Directory
999 functions gdcmDicomDir::CheckBoundaries()
1000 gdcmObject::SetBoundaries() added
1002 2004-03-17 Jean-Pierre Roux
1003 * REM (Eric Boix bug) : removal of meaningless
1004 gdcmDicomDirImage::NewImage function.
1005 * FIX now file names and directory name are written properly in the
1007 * FIX now gdcmDicomDir constructor may be call without any trick
1010 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1011 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1012 of gdcmDicomDirImage::NewImage as empty function.
1014 2004-02-28 Jean-Pierre Roux
1015 * ENH add gdcmDicomDir:NewPatient
1016 add gdcmDicomDirPatient:NewStudy
1017 add gdcmDicomDirStudy:NewSerie
1018 add gdcmDicomDirSerie:NewImage
1019 to allow making gdcDicomDir object.
1020 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1021 (as opposite to the gdcmHeader chained list)
1023 2004-02-11 Benoit Regrain
1024 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1025 when using from python
1027 2004-02-10 Benoit Regrain
1028 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1029 * FIX : in gdcmDicomDir when the directory is empty
1030 * ENH : add callback and methods to get the progression of dicomDir
1033 2004-02-06 Jean-Pierre Roux
1034 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1035 - GDCM_META added to gdcmDicomDirType
1036 - class gdcmMeta created
1037 * ENH : - A brief summary is now displayed at the beginning of
1038 'testDicomDir' to help disaster magnitude estimation
1039 * REM : Now useless Test/explDICOMDIR.cxx
1041 2004-02-05 Benoit Regrain
1042 * ENH : add methods in gdcmObject to get the hash table or the list of
1044 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1045 * FIX : wrapping python for TagHeaderEntryHT
1047 2004-02-04 Benoit Regrain
1048 * FIX : even length for some strings when writting the dicom dir
1049 * FIX : sort the images in the dicom dir
1050 * FIX : Bug fix for python use of dicom dir
1051 * ADD : a python demo
1053 2004-02-04 Jean-Pierre Roux
1054 * FIX : Final solution (?) for icone embedded images
1055 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1056 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1057 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1058 gdcmData/gdcm-MR-SIEMENS-16.acr1
1059 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1060 to make full checking easier
1062 2004-02-04 Benoit Regrain
1063 * FIX : WriteEntries : coding style & logic in parameters
1064 * FIX : Set the elements to create the DicomDir in a dictionary file
1066 2004-02-03 Benoit Regrain
1067 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1068 * gdcmDicomDir : add the load of directory
1069 * Bug fix and print add-on
1071 2004-02-03 Jean-Pierre Roux
1072 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1073 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1074 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1075 * FIX gdcmParser.cxx : 'group length' elements are now considered
1076 as integers, even for shadow groups, when file is Implicit VR
1078 2004-02-02 Jean-Pierre Roux
1079 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1081 of the last synonym :-(
1082 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1084 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1085 * FIX taking into account the possible 7fe0,0010 multiplicity
1086 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1087 to allow removal of references to 7fe0,0010, to deal with
1088 ACR-NEMA images, when 0028,0200 is meaningfull
1090 2004-01-31 Jean-Pierre Roux
1091 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1092 no longer writes 'Un' on disk
1093 * FIX SQ elements with actual length are now dealt with corectly
1094 * FIX gdcmFile::WriteBase make the difference, for color images, between
1095 the length (for Palette expanded images)
1096 and Raw Length (non expanded image + Palette)
1097 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1098 (that broke Write). Replaced by UL.
1099 Aware user will reload the field if he
1100 thinks it's necesssary
1102 2004-01-30 Jean-Pierre Roux
1103 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1104 when 'dirty Acr' is found, to be compliant with the new
1105 IsReadable() methods.
1107 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1108 (no DOUBLE images in kosher DICOM,
1109 but so usefull for people that miss them ;-)
1111 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1112 DICOMDIR related utilities (not checked as Windoze compliant)
1114 2004-01-28 Jean-Pierre Roux
1115 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1117 2004-01-27 Jean-Pierre Roux
1118 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1119 to allow skipping the shadow elements, to save memory space.
1120 The TRUE value for this param has to be used
1121 with a FALSE value for the 'enable_sequence' param.
1122 ('public elements' may be embedded in 'shadow Sequences')
1123 * gdcmHeader methods now deal with 'embedded icones images' in the header
1124 (even when an 'icone image sequence' is announced by the
1125 element (0x0088,0x0200), but there is NO icone at all ...
1127 * gdcmHeader sometimes Image Location value doesn't follow
1128 the supposed processor endianity (see gdcmData/cr172241.dcm).
1131 * gdcmHeader add the method
1132 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1133 to get *all* the Header Entries with the same tag.
1134 GetHeaderEntrySameName is probabely *useless*
1135 (no meaning : Name is *not* an identifier within the Dictionnary)
1137 2004-01-26 Benoit Regrain
1138 * Bug fix in the print of hexadecimal representations. Remove long fields
1139 in the print and add a third level of print to print them
1141 2004-01-23 Benoit Regrain
1142 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1143 * Bug fix on test suite after remove the strip made on not string fields
1144 * Split the IsReadable method between gdcmParser which test that the file
1145 is dicom and gdcmHeader which test that it's an image file
1147 2004-01-22 Benoit Regrain
1148 * DicomDir : clean code, add methods, set variables in protected or private
1149 * gdcmUtil : bug fix for the clean string method
1151 2004-01-19 Benoit Regrain
1152 * Add the use of shadow dictionaries
1153 * bug fix and coding style
1155 2004-01-19 Benoit Regrain
1156 * src/gdcmFile.cxx : bug fix concerning the close of file
1157 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1158 * Add the update of header entries using the shadow library
1160 2004-01-19 Benoit Regrain
1161 * removal of file gdcmHeader2.cxx
1162 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1163 inheriting from gdcmParser. This split is to prepare the integration
1164 of dicom dir parsing
1165 * bug fix under python
1167 2004-01-16 Jean-Pierre Roux
1168 * REM removal of class gdcmHeaderEntrySet
1169 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1170 * ADD add file gdcmHeader2.cxx
1171 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1173 2004-01-15 Benoit Regrain
1174 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1175 entries created while parsing the header. Thus, they will be destroyed
1176 when the gdcmDictSet will be destroyed
1177 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1180 2004-01-15 Benoit Regrain
1181 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1182 made a fatal error because of the memory release at the end of program.
1183 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1184 some memory and vtk seems to have some problems with that.
1185 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1187 2004-01-14 Benoit Regrain
1188 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1189 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1190 * src/*.[h|cxx] : make changes due to class name changes
1191 * gdcmPython/demo/*.py : bug fix due to method names
1193 2004-01-13 Benoit Regrain
1194 * src/*.[h|cxx] : coding style
1195 * vtk/*.[h|cxx] : coding style
1197 2004-01-13 Benoit Regrain
1198 * gdcmPython/testSuite.py : test the readable flag of file for tests
1199 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1200 It's lied to the stl compilation by MSVC (windows, always windows...)
1201 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1203 2004-01-12 Benoit Regrain
1204 * src/*.h : add comments
1205 * src/gdcmDictSet.h : set the method BuildDictPath in public
1206 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1207 directly setted in the source code
1208 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1211 2004-01-09 Benoit Regrain
1212 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1213 * setup.py : use a reference to gdcmVERSION
1215 2004-01-07 Benoit Regrain
1216 * Modification to compile with the distutils.
1219 2003-12-10 Benoit Regrain
1220 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1221 can use a gdcmHeaderHelper to load datas
1222 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1223 made in the source code
1225 2003-12-10 Benoit Regrain
1226 * Update Windows projects and .cvsignore files
1228 2003-11-12 Jean-Pierre Roux
1229 * ENH gdcmHeader constructor has one more parameter (default value : false)
1230 that allows the user to 'go inside' the SeQuences only
1232 gdcmElValSet:Print takes it into account
1234 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1235 * ENH: Update gdcmPython/CMakeLists
1236 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1237 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1239 2003-11-10 Jean-Pierre Roux
1240 * FIX : gdcmHeader::LoadElements is now based
1241 on the ListTag listElem member,
1242 not longer on the TagElValueHT tagHt member
1243 * ENH : PrintPubElVal shows (temporarily) both results,
1244 with the tagHt member and the listElem member.
1245 (it's easier to 'see' the problems when using Printheader)
1247 * FIX : old private member LgrElem is now splitted into
1248 ReadLength : Length actually found on disk (updated only
1249 if bug fixing is necessary), for internal
1251 UsableLength : Updated by FixFoundLength, to fix a bug
1252 or to allow Parser going on.
1253 Will allow to re-write a kosher header when a SeQuence
1254 with a length (not 0000) is found
1255 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1256 because gdcmElValSet::Add does not update ListElem
1259 2003-11-07 Jean-Pierre Roux
1260 * FIX misstyping in Transfert Syntax name table
1261 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1262 when they have an actual length (not 0000 nor FFFFF)
1263 (Nobody should care of it, but DICOMDIR explorers)
1265 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1266 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1268 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1269 * ENH: vtkGdcmReader now supports LUT !
1270 (vtkgdcmViewer for now is not able to use them though)
1272 2003-11-05 Jean-Pierre Roux
1273 * in testSuite.py : new files names for checking the package
1274 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1275 that returns the pixel area size to the *aware* (vtk) user
1276 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1278 2003-11-05 Benoit Regrain
1279 * in testSuite.py : Modify the rules for checking the paths
1280 : Explicit error messages
1281 * in __init__.py : Related modif
1283 2003-11-03 Jean-Pierre Roux
1284 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1285 to be used by aware (vtk) users that want to manage
1286 LUT (and no to turn the PALETTE image into an RGB pixels one)
1287 * GetPixelType now returns 8U for 24 Bits images
1288 (vtkGdcmReader compliant)
1290 2003-10-31 Jean-Pierre Roux
1291 * Removal of *all* gdcmData images and add them again
1292 in order to loose the 'history' of un-anonymised images
1294 2003-10-31 Jean-Pierre Roux
1295 * RMV : removal of useless jBitsInJsample.h
1296 for both 8 and 12 Bits JPEG Lossy Libraries
1298 2003-10-31 Jean-Pierre Roux
1299 * ENH : Add the functions gdcmFile::GetImageDataRaw
1300 gdcmFile::GetImageDataIntoVectorRaw
1301 that act as GetImageData and GetImageDataIntoVector
1302 except the making of an RGB Plane from Gray Plane + LUT
1303 Intended to aware (vtk) users who know how to manage
1306 GetLUTRGBA return a R,G,B,A LUT if any
1307 lgrTotaleRaw gives the 'Raw' length
1308 GetImageDataRaw returns the gray Plane
1309 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1310 (They stay Grey, just like with other Dicom viewers :-(
1312 2003-10-30 Jean-Pierre Roux
1313 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1315 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1316 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1317 being coherents dicom files.
1319 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1320 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1322 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1323 * ENH: Two steps is necessary to please VC++ compiler...
1324 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1325 * ENH: Add include dir to medcon lib
1326 * FIX: only one function is being exported for now !
1327 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1329 2003-10-29 Jean-Pierre Roux
1330 * adding gdcmHeader::GetLUTRGBA
1331 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1332 --> Mathieu, the modif u're waiting for is not yet committed
1333 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1335 2003-10-27 Jean-Pierre Roux
1336 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1337 00191113.dcm DermaColorLossLess.dcm
1338 MxTwinLossLess.dcm RadBWLossLess.dcm
1339 * ENH: For version prior to vtkImageViewer2 -r 1.19
1340 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1342 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1343 * Removal of ido stuff in CMakeLists.txt
1345 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1346 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1347 * FIX: remove a call to ->Modified ... see comments
1348 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1350 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1351 * FIX: Problem with path for libvtkgdcmPython
1352 * ENH: Try adding a search script for python site-package
1353 * RMV: Remove some file from medcon lib that are not necessary
1354 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1355 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1356 * FIX: More pragma disable fro VC++,
1357 I don't think I break something as it is also disable in VTK/ITK.
1358 But it fasten debug compilation time.
1360 2003-10-23 Jean-Pierre Roux
1361 * gdcm now deals with 16 Bits Run Length Encoded images
1362 (they are compressed as 2 planes images,
1363 one for the high Bytes, the other for low Bytes)
1365 2003-10-22 Jean-Pierre Roux
1366 * Now CheckRead takes into account :
1367 - the bugged 'Leonardo' Siemens images
1368 - the XA images, sent thru the burning VPRO station
1369 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1372 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1373 * FIX: When copying a Makefile.am to CMakeLists.txt
1374 one should remove the '\'
1376 2003-10-22 Jean-Pierre Roux
1377 * in gdcmData adding a bugged 'Leonardo' Siemens image
1378 (wrong lengths in header)
1379 OK with gdcm, KO with the other viewers :-)
1380 * add a GE dlx XA image, thru the VEPRO burning station
1383 2003-10-21 Jean-Pierre Roux
1384 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1385 for a brutal checking of vtkgdcmViewer compliance
1387 2003-10-21 Jean-Pierre Roux
1388 * add the files for 'xmedcon' Jpeg Lossless library
1389 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1391 2003-10-21 Jean-Pierre Roux
1392 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1394 2003-10-21 Jean-Pierre Roux
1395 * garbage Siemens 'Leonardo' images dealt with
1396 (the patch is easy to remove)
1397 * cosmetic changes to avoid warnings
1399 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1400 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1401 no need to press 'r' now.
1403 2003-10-20 Jean-Pierre Roux
1404 * upgrade of checkRead.sh checkWrite.sh according
1405 to new Jpeg Lossless decompressor
1406 * add US.3405.1.dcm, a genuine RGB medical file ...
1407 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1408 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1410 2003-10-15 Jean-Pierre Roux
1411 * general anonymisation in gdcmData
1412 * adding the 'color files' from
1413 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1414 * adding some well knowed bugged-header images
1415 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1416 waiting for their inclusion in Python testsuite
1418 2003-10-15 Jean-Pierre Roux
1419 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1420 no longer seg faults when file is not found
1422 2003-10-14 Jean-Pierre Roux
1423 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1426 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1427 * TODO: *.in file to genereate a UseGDCM later
1429 2003-10-14 Jean-Pierre Roux
1430 * Some supposed-to-be Dicom Images have no preamble.
1431 OpenFile takes it into account
1432 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1433 * Missing elements added in dicomV3.dic
1434 (just to be affraid : have a look at
1435 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1436 and do it again next year ;->
1438 2003-10-13 Jean-Pierre Roux
1439 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1440 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1441 But there are NOT. It's fixed !
1443 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1444 * FIX: "jpeglib.h" was not found on VC++
1445 * FIX: vtkgdcm was not being installed
1447 2003-10-10 Jean-Pierre Roux
1448 * ENH : OpenFile closes the file if it *really* doesn't look like
1449 an ACR-NEMA / DICOM one.
1450 * FIX : testWrite no longer writes an empty file if the source file
1451 is not gdcm Readable
1452 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1455 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1456 * FIX: CMake generate now documentation
1457 * ENH: out of source doc build !
1458 * ENH: Generate both user and dev documentation
1459 * ENH: Should work on windows too
1460 * ENH: Only one doxygen config.in file is needed
1461 * FIX: make install should be ok now on ùnix plateform
1462 * FIX: PATH to dictionary was wrong (missing /)
1463 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1465 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1466 * vtkGdcmReader is now able to read rgb dicom file.
1467 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1468 * added a gdcmViewer to vtk test, use mouse to control
1469 window level & window width
1471 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1472 * CMake-ification of gdcm, we have now two build system
1473 * FIX: on cygwin Wsock32 doesn't exist
1474 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1476 2003-10-06 Emanuel Ollart
1477 * FIX : compilation process wad broken.
1478 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1480 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1481 * change gdcmViewer -> vtkgdcmViewer
1482 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1484 2003-10-06 Jean-Pierre Roux
1485 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1486 ( e.g : well known GE images with a wrong elem length,
1487 : Philips MRI Images with a wrong Huffman table)
1488 * still to be done : allow the reading of bugged LEONARDO Siemens images
1490 2003-10-03 Jean-Pierre Roux
1491 * Odd length strings are padded with '\0' (not with spaces,
1492 to remain compliant with already defined strings,
1493 like Transfert Syntax UID and others)
1495 2003-10-03 Jean-Pierre Roux
1496 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1497 to allow displaying RGB images (not only by affim ;-)
1499 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1500 * vtkGdcmReader is now able to read rgb dicom file.
1501 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1503 2003-10-03 Jean-Pierre Roux
1504 * A few nasty patches to allow the reading of a lot of nasty images
1505 ( e.g : well known GE images with a wrong elem length,
1506 : Philips MRI Images with a wrong Huffman table)
1507 * still to be done : allow the reading of bugged LEONARDO Siemens images
1509 2003-10-03 Jean-Pierre Roux
1510 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1512 2003-10-03 Jean-Pierre Roux
1513 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1514 to allow displaying RGB images (not only by affim ;-)
1516 2003-10-03 Jean-Pierre Roux
1517 * gdcmFile::GetImageDataIntoVector now
1518 - deals with MultiFrames MultiFragments Run Length Encoded files
1519 - deals with YcBcR (YBR_FULL) files
1520 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1521 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1523 (no sample found :-(
1525 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1526 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1527 Two reasons: - clear things
1528 - third parties acces gdcm through header files, so won't
1529 suffer anymore VC++ complains
1531 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1532 * add argv[1] in testvtkGdcmReader.cxx
1535 2003-09-24 Jean-Pierre Roux
1536 * The lines are now eigthy characters long.for
1537 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1539 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1540 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1541 char* to std::string. Thus, the use of strdup becomes useless. (see
1542 previous commis of Malaterre)
1543 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1544 before the last Malaterre's commit.
1546 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1547 * This commit should fix the Debug building under VC++, the problem
1548 was mainly a mixture of debug and release lib being loaded at startup.
1549 * I also remove a depency to a specific C function: strdup. Because I had
1550 to force the link to msvcrtd (whereas strdup is in libc).
1552 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1553 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1554 located in the gdcmCommon.h file. All use of reference of tha has been
1555 changed to now use the variable GDCM_UNFOUND.
1557 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1559 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1560 Dicom dictionary. The test suite can now be run again. Note:
1561 I'm note very happy with the " (RET)" changes. I believe this
1562 RETAINED comment should be dropped when parsing the dictionary.
1563 - PACKAGER corrected
1565 - AUTHORS updated and now in alphabetical order
1566 * Makefile.am now exports gdcm.dsw for Windoze users.
1568 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1569 * cygwin complains about missing std:: in subdir Test/
1571 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1572 * remove some methods that are now in gdcmHeaderHelper
1574 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1575 * vtkGdcmReader set spacing and origin correctly
1577 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1578 * Fix a few delete/delete[] mismatch
1580 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1581 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1582 interpretation to data given by gdcmHeader. For instance there are
1583 heuristics to get informations (look at different places).
1584 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1585 sorting DICOM images based on different strategies.
1586 * modified Makefiles accordingly.
1588 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1589 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1590 when building in debug mode
1591 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1592 src/win32/gdcmdll.dsp
1593 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1595 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1596 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1599 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1600 * src/win32/libgdcmjpeg12.dsp was not dos format
1601 * src/win32/libgdcmjpeg12.dsp :
1602 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1603 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1605 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1606 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1608 * src/gdcmFile.cxx : bug fix in affectation type
1609 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1610 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1611 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1612 symbols... future problem ?
1614 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1615 * src/win32/libgdcmijpeg12.dsp was missing
1616 * modified gdcm.dsw accordingly
1618 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1619 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1621 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1622 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1623 commit of JPR (before his hollidays to facilitate our work).
1624 * setup.py : bug fix in code. Modifications made while the last commit
1625 of JPR. The code hasn't been tested before the commit... it's so
1626 useless to make that (for best programmer that is JPR) !!!
1628 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1629 * tagged the current version as Version0_3 (i.e. version 0.3)
1631 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1632 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1633 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1634 * *.dsp : modifications to use new libgdcmijpeg8 library
1635 * setup.py : bug fix on VTKPATH variable
1636 * PACKAGER : adding all concerning windows
1638 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1639 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1641 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1642 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1643 test suite reported error.
1644 * PACKAGER file added (describes what a packager must do when
1645 packaging a new release).
1646 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1647 * configure.in: upgraded version number to 0.3.0
1648 * fixing build of rpm (through rpm -ta):
1649 - Doc/Makefile.am exports proper doxygen files
1650 - src/jpeg/libijg8/Makefile.am exports the include files.
1652 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1653 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1654 * src/gdcmHeader.h : formatting code
1656 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1657 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1658 We were obtaining error message from vtk. Now, creation of file list
1659 is made in an internal list to prevent this problem.
1660 Bug fix when output is empty.
1661 Bug fix in update of progress value. Previous commit for this was a bad
1663 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1665 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1666 * src/gdcmHeader.h : added method to get the file name
1667 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1668 files. Added method to remove all files on the input
1669 Added FIXME comment concerning the bad parsing of header made by
1670 ExecuteInformation method (in ExecuteData method)
1672 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1673 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1674 when using make instal.
1675 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1676 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1678 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1679 * setup.py : adding include dir of jpeg lib to compile all sources
1680 * */Win32/*.dsp : JPR fix for windows compilation
1682 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1683 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1685 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1686 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1688 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1689 * setup.py is again effective on un*x (takes into account the
1690 addon of the jpeg library)
1691 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1692 * Doc/Doxy* updated (includes above enhancements)
1693 * INSTALL now points to web documentation
1695 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1696 * src/gdcmHeader.h doesn't make unnecessary reference to
1698 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1700 * src/gdcm*.[cxx|h] :
1701 - to allow compilation with gcc 3.x
1702 -- clean up of STL usage (added explicit usage of std::)
1703 -- small fixes on exceptions.
1704 Note: linking not tested !
1705 - clean of doxygen comments to avoid warnings at documentation
1707 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1708 dependent convertion).
1710 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1711 * Clean up of previous JPR garbage commit (not even commented in the
1713 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1714 - moved all jpeg related files from src to src/jpeg/libijg8, with
1715 addition/modification of Makefile.am and configure.in.
1716 - the testSuite is still brain damage (not guilty).
1718 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1719 * WrapVTK.py : modifications to get correctly vtk source files to
1721 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1722 (FileName -> Filename)
1724 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1725 * vtk/vtkGdcmReader.[cxx/h]:
1726 - UpdateProgress method should now be effective
1727 - removed the limitation on having only images loaded (as opposed
1729 - when building a stack of images/volume, a lesser number of
1730 gdcmHeader and gdcmFile instances should be used (hopefully
1731 accelerating things).
1732 - when building a stack of images/volumes, files which are not
1733 loadable (wrong path-filename, wrong permissions on existing file,
1734 or file not parsable by gdcm) are replaced with a black image
1735 in the stack (for the caller to notice the problem).
1737 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1738 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1740 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1741 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1742 between standard library (std) and vtk library (problems are found
1743 under Windows... thanks Windows !)
1745 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1746 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1748 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1750 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1751 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1753 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1754 * When compiling with distutils (see setup.py) the C++ compiler is
1755 called with different flags than the default ones (with automake).
1756 In order to fix all those warning, I compiled gdcm with the command
1757 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1758 and went for warning fixes:
1759 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1760 up from unused variables.
1761 - vtk/vtkGdcmReader.cxx: potential bug fix.
1762 * src/gdcmHeader.h: Doxygen warning cleanup
1764 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1765 * gdcmPython/gdcm.i:
1766 - typemaps correction to take into account the systematic replacement
1767 of "using namespace std" with std:: prefix e.g. std::list,
1768 std::string... (cf changes of 2003-05-21).
1769 - gdcmGlob global variable of type gdcmGlobal (defined in
1770 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1771 exported to Python a as cvar.
1772 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1773 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1774 gdcmDictSet.GetPubDictTagNames() and
1775 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1776 C++ static methods).
1777 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1778 with the above changes.
1780 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1781 * setup.py, manifest.in : bug fix under linux
1783 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1784 * Modification of setup.py to compile vtk part too. Then, we have 2
1785 wrappers which must work with same distutils. For that, we have a
1786 generic distutils in distusiltsWrapping.py ; with :
1787 - build_extWrap class to wrap generically all extensions,
1788 - ExtensionWrap base class for all wrapping extension that contains
1790 - Wrapper interface which wrap sources
1791 + In WrapSwig.py we have extension and wrapper for Swig
1792 + In WrapVTK.py we have extension and wrapper for VTK
1793 * MANIFEST.in : modifications to consider vtk directory and new python
1794 files for compilation
1796 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1797 * Added python wrappers of vtkGdcmReader vtk class (see the
1798 source in vtk/vtkGdcmReader.cxx) :
1799 - vtk/Makefile.am now builds a library
1800 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1801 python library (as opposed to _gdcm.so wich are the python
1802 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1803 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1805 - configure.in has an additional flag --enable-vtk that needs
1806 to be set to enable compilation of vtk related code, that is:
1807 + vtk/vtkGdcmReader.so and
1808 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1809 + gdcmPython/vtkgdcmPython.so (see above)
1810 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1811 be read when compressed or when HighBit + 1 != BitsStored),
1812 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1813 the usage of the python wrapper of vtkGdcmReader vtk class.
1814 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1815 * src/*.[h] all occurences of stl classes are now prefixed with
1816 std::, and all occurences of "using namespace std;" where removed.
1817 This is to avoid pollution of global namespace in included files.
1818 Apparently vtk does not avoid this pitfall: when using both
1819 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1820 collision of various stl members (principally cout...).
1821 * gdcmPython/testSuite.py now cleanly removes temprory generated
1823 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1824 comply with above changes)
1826 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1827 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1828 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1829 vtk data structure (an image Flip was required).
1830 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1831 * cosmetic changes in documentation.
1833 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1834 * src/gdcmHeader.cxx: the constructor no longer exits when an
1835 unexisting file is given as argument.
1836 * The subdirectory Data (containing all the images used for the
1837 test suite) is not part of this repository anymore. A new module
1838 containing those images is now available at
1839 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1840 with the name gdcmData.
1841 All the python scripts (including the package initialisation file
1842 gdcmPython/__init__.py) were adapated to take this change into
1843 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1845 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1846 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1847 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1848 demo of the usage of this class.
1849 Compilation of this vtk part is only done when using the --enable-vtk
1850 at configure (or autogen.sh) stage.
1852 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1853 * More memory link related corrections and documentation fixes.
1855 - maximum info is obtained with a command of the form:
1856 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1857 --show-reachable=yes PrintHeader
1858 - the remaining reachable blocks seem to come from the STL
1859 allocation scheme through the usage of map and list. It looks
1860 like this memory cannot be freed but it is not a memory leak
1861 (in fact further invocation to the STL would recollect the
1862 unused memory allthough it cannot explicitely be freed).
1863 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1864 of displaying an image parsed with gdcm and displayed with VTK.
1865 Note: some images don't seem to work e.g.
1866 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1867 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1868 Allthough this weakens the semantics, it is a ditch attempt to
1869 make gdcm more thread friendly.
1871 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1872 * Memory link hunt (by using valgrind through the command
1873 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1874 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1875 gdcmHeader::_dicom_vr.
1876 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1877 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1879 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1881 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1882 * src/Makefile.am now exports all the necessary include files at
1886 * UpdateGroupLength replaced by new one
1889 * UpdateGroupLength re-written using H-Table
1890 (named UpdateGroupLengthNew untill checks are over)
1892 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1893 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1894 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1896 - gdcmHeader::GetPubElValSet removed.
1897 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1898 UpdateGroupLength, WriteElements, Write.
1899 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1900 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1901 carried the same semantics.
1902 - src/gdcmHeaderIdo.cxx changed accordingly.
1903 - gdcmFile::WriteBase now regroups all the codes from previous
1904 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1905 - enum FileType moved to gdcmCommon.h
1906 * src/gdcmHeader.cxx AddDefault trashed
1907 * gdcmGetXSize added
1908 * getimageDataSize now calls gdcmGetXSize
1909 * Test/*.cxx changed to agree with above changes
1911 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1912 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1913 (to avoid double call by end user).
1914 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1915 by end user, since gdcmHeader::gdcmHeader now handles it.
1917 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1918 * gdcm/Doc many doxygen changes:
1919 - Doxyfile now has two different versions, DoxyfileUsers that generates
1920 the html.users end users oriented documentation and
1921 DoxyfileDeveloppers that generates the html.developper developper
1922 oriented documentation.
1923 - README changed accordingly
1924 - requirement.txt removed (old design info moved to TODO).
1925 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1926 DoxyMainPage.txt, DoxyPython.txt provide more information.
1927 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1928 be updated by simply regenerating the docs with doxygen and copying
1929 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1930 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1931 all the tests in the form "if (<map>.count() >1)" were removed.
1932 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1933 ill-formed documentation sections.
1934 * src/gdcmHeader.cxx: ditto
1936 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1937 * setup.py fixed for un*x (needed macro for stdint.h)
1938 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1939 un*ces with sh-utils test utility.
1940 * gdcmPython/demo/test.py renamed to PrintHeader.py
1941 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1942 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1943 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1944 * src/gdcm*.cxx JPR's bad inclusion fixed.
1946 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1947 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1948 * gdcmPython/demo/test.py changed accordingly.
1950 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1951 * gdcmPython/Makefile.am fixed linking against libstdc++
1952 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1953 * Swig subdir (historical tests of swig version 1.3.17++) removed
1954 * Test/testChangeEntete.cxx some lines commented out in order to make
1956 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1957 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1959 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1960 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1961 hence the user doesn't need this explicit call.
1962 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1963 i.e. LoadElements() call removed.
1964 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1965 - src/Makefile.am declares the proper flag for g++.
1966 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1967 for adding user defined new tags.
1968 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1969 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1970 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1972 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1973 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1974 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1975 src/Makefile.am : the project should properly compile and install
1976 with the autotools, included the python wrappers part.
1977 * gdcm.spec.in : added a spec file for RPM packaging.
1979 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1980 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1982 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1983 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1984 to exported to the environement (see gdcmPython/testSuite.py
1986 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1987 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1988 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1989 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1990 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1992 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1993 * gdcmPython/__init__.py doesn't crash anymore when running in
1994 in InstallMode or PreInstallMode but with an environement given
1995 value of GDCM_DICT_PATH.
1996 * src/gdcmDictSet.[cxx/h] coding style.
1998 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1999 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2000 * src/gdcm.h general comments moved to TODO, and README
2001 * src/gdcm.h should now be seen as a user commodity (including it
2002 should suffice to fully use gdcm). It is nowhere including within
2003 any of the kernel files src/*.cxx and src/*.h.
2005 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2006 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2007 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2009 * src/gdcm*.cxx only include their corresponding include file
2010 (as opposed to gdcm.h)
2011 * gdcmPython/gdcm.i changed accordingly
2012 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2013 the autogen.sh generated "make snapshot" command to work.
2014 * autogen.sh removed history related references to crea package.
2016 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2017 * distutilsSwigCPlusPlus.py work around some swig portability
2020 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2021 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2022 was done in a last ditch attempt to get setup.py _really_
2023 operationnal. The python/gdcmPython layaout add the advantage
2024 of hidding away the python related distutils specific files
2025 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2026 Alas, the src directory was out of scope (i.e. it's relative
2027 position to setup.py was ../src) which made things impossible to
2028 handle (see previous version of python/setup.py). Crossing fingers...
2030 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2031 * python/setup.py now works on Un*x. (harder than I thougth)
2032 * python/distutilsSwigCPlusPlus.py can now have include files
2033 among the list of sources.
2035 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2036 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2037 * modifications in MSVC projects
2039 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2040 * As stated by the first lines of Test/ExceptionAndPython/README, it
2041 looks like we can move back to original usage of exception within
2042 src/gdcm* and hence remove the errno stuff that was introduced
2043 as a quick and dirty fixture of this problem (added to the TODO).
2044 * Doc/Doxyfile configuration file for Doxygen and corresponding
2045 README file for usage added.
2046 * Test/testWrite.cxx added. This new test comes from a split of
2047 test.cxx that is now reverted to its original purpous i.e.
2048 testing the proper parsing of a Dicom related file.
2049 testWrite.cxx concentrates on testing the IO part of gdcm.
2050 * Test/bug1.cxx (containing a bug on WIn32) added.
2051 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2052 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2053 whose purpose is to publish the content of the TagNames of the
2054 Dicom public dictionnary were not accessible without an
2055 instance of class gdcmHeader.
2056 - those methods are now static methods of gdcmDictSet and hence
2057 require no instances at all to be invocated.
2058 - within gdcmDictSet this change required to change some method
2059 to class methods (i.e. are now static) among which SetDictPath
2060 (renamed to BuildDictPath) and LoadDefaultPubDict.
2061 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2062 the above changes by calling the new method classes of gdcmDictSet.
2063 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2064 the above to be effective.
2065 * python/gdcmPython: in order to wrap properly the above changes
2066 for Python, swig version now needs to be > 1.3.17.
2067 * python/gdcmPython/Makefile fixed to adapt itself to new
2068 configure/make shema introduced by Johan Montagnat (thanks for the
2069 contribution). Alas this Makefile cannot be turned into a proper
2070 Makefile.am without some heavy changes in the configure.in
2071 (for python dectection).
2072 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2073 now avoids publishing the empty entries.
2075 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2076 * python/setup.py : bug fix concerning install under windows
2077 ExtraPath reused :-P
2078 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2080 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2081 * Dicts/dicomV3.dic : remove double spaces !!!
2082 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2083 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2086 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2087 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2088 method. Doxygenation.
2089 * src/gdcm.h clean up of JPR spurious comments.
2091 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2092 * python/distutilsSwigCPlusPlus.py now properly collects the
2093 shadow classes generated by "swig -c++" (gdcm.py in our case)
2094 when using "python setup.py install".
2095 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2096 reexports the working classes.
2097 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2098 by the classical C errno scheme. This is to prevent an obscure
2099 behavior of the python wrappers when importing wxPython.wx prior
2100 to gdcmPython (which ended up in an abort call). An illustration
2101 of this oddity can be found in the Test/ExceptionAndPython
2102 subdir (see the README file). This problem probably due to
2103 an combination of g++ and dynamic loading.
2104 * added Test/ExceptionAndPython (see above)
2106 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2107 * Changed the layout of the python part to avoid bloating main
2108 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2109 i.e. the distutils arsenal. All the python related stuff is
2110 again in a python subdir, but the package itself is now in
2112 * setup.py was cleaned up:
2113 - pythonIncludePath removed
2114 - python setup.py bdist target is now functional.
2115 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2116 collision with other packages). gdcmPython/demo/*.py changed
2119 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2120 * python subdir moved to gdcmPython (preparation of distutils packaging).
2121 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2122 distutils installer is operational.
2123 * - gdcmPython/__init__.py now properly loads the swig generated
2124 shadow classes (from gdcm.py).
2125 - gdcmPython/demo/*.py changed to import the package gdcmPython
2126 instead of gdcmPython/demo/load.py.
2127 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2129 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2130 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2131 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2132 entries within the associated public Dicom dictionary resp. the same
2133 information but sorted by the fourth field (PAT, IMG, DIR) of the
2135 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2136 are now in the "???" group.
2137 - python/gdcm.i changed accordingly,
2138 - python/demo/printGroupedPublicDict.py added, that gives an example
2139 of the above new functionalities in Python.
2141 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2142 * src/gdcm.h, gdcmHeader.cxx:
2143 - historic references to glib's g_malloc and g_free (#defined)
2144 were definitively removed.
2145 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2146 * src/gdcmElValSet.cxx:
2147 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2148 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2149 - GetElValue(string) renamed to GetElValueByName.
2150 - Added GetElementByName(string).
2151 * src/gdcmHeader.cxx: added
2152 - GetPubElValRepByNumber(guint16, guint16)
2153 - GetPubElValRepByName(string)
2154 - GetShaElValRepByNumber(guint16, guint16)
2155 - GetShaElValRepByName(string)
2156 - GetShaElValByNumber(guint16, guint16)
2157 - GetShaElValRepByName(string)
2158 - GetElValRepByNumber(guint16, guint16)
2159 - GetElValRepByName(string)
2160 - GetElValByNumber(guint16, guint16)
2161 - GetElValRepByName(string)
2162 * Doc/requirements.txt added.
2164 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2165 * Test/Makefile building now depends on the one of libgdcm.so
2166 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2167 pixel data) aware which enables finding the address (offset) of
2168 the pixel data of JPEG encoded DICOM files. This leaves only a single
2169 file in the testSuite whose pixel data address (offset) is unknown.
2170 * python/testSuite.py changed accordingly.
2172 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2173 * VC++ has some strong limitations when working with the STL, as stated
2174 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2175 "Also note that some STL containers (map, set, queue, list, deque)
2176 cannot be exported. [...]
2177 Some STL classes contain nested classes. These classes can not
2179 This is caused by a designed limitation that once a template
2180 class is instantiated, it can not be re-instantiated and
2182 Since our usage of map<> is ubiquitous in gdcm, this "designed
2183 limitation" of VC++ is a pitfall.
2184 Hence the Python wrappers of gdcm cannot be incrementally linked
2185 against the c++ dynamic library. The dirty but only workaround is
2186 to forget about incremental link of dynamic libraries and to generate
2187 the Python wrappers library with the inclusions of the underlying C++
2189 The following modifications concern this matter on Win32/VC++:
2190 - wrapping python correct with standalone wrapped dll (don't use separate
2191 dll under windows !!!!)
2192 - python21_d debug mode enabled (ask Frog how to use it :-)
2193 - NO problem with having an STL member of class for example string in C++
2194 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2195 - Python test of dcmlib in Python is ok under windows on a large set
2197 * removed glib references
2198 * typedef's inserted in gdcm.i for correct swig type management
2200 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2201 * python/demo/*.py load.py extracted from test.py. Added explore.py
2202 that only displays required tags and testAll.py that parses all
2203 the files of the testsuite without using unittest.
2204 * python/testSuite.py other additional test on new files added.
2205 * Data/* new test files added accordingly to the testSuite.
2206 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2207 the vr in the file differs from the one of the dictionary.
2209 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2210 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2211 values, but limits itself to values which are below a user specified
2212 size (by default 1024 bytes).
2213 * python/gdcm.i : elements not loaded (because their size is above the
2214 user specified treshold) are exported with their TagKey as key of the
2215 python dictionary. This enables the testsuite to make some checks
2216 on the unloaded elements (since we have their offset and size).
2217 * python/testSuite.py
2218 - now tests for the existence and proper value of the pixel data
2219 - two new examples added.
2220 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2222 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2223 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2224 aware. See the strategy comments in gdcmHeader::FindeLength().
2225 * Test/test.cxx now accepts a filename as first argument.
2226 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2227 * python/testSuite.py changed to integrate test on above files.
2229 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2230 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2231 the vr was also RET.
2232 * python/testSuite.py more tests added.
2234 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2235 * python/testSuite.py unittest test suite added (uses Data)
2236 * Data/* dcm and acr files for the test suite.
2237 * glib dependance removed from un*x version. We now use ISO C99
2238 7.18 Integer types (see stdint.h)
2239 - python/Makefile, src/Makefile src/gdcm.h
2240 * src/ when an explicit vr (like dicom files) suddenly poped an
2241 implicit element we use to mark the underlying DictEntry of the
2242 concerned ElValue with "Implicit". This strategy was damageable
2243 too the public or provite dictionaries, since some of their vr
2244 would be changed. Since Header::FindLength heavily relies on the
2245 detection by Header::FindVR of falsely explicit elements, I
2246 added an extra ImplicitVr member to ElValue (boolean).
2247 The rest of the changes we the necessary adaptations.
2249 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2250 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2252 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2254 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2255 * Adaptation for porting to VC++:
2257 o forced to use std namespace (for string to be known)
2258 o all class use __declspec export style on WIN32
2259 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2260 (in stdlib.h on Win32 but in std:: for gcc)
2261 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2262 variable GDCM_DICT_PATH.
2263 * src/gdcmHeader.cxx verbose comments made discrete.
2265 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2266 * python/gdcm.i: added a typemap that converts a C++ hashing table
2267 to native Python dictionary.
2268 * python/demo/test.py:
2269 - now uses the native dictionary for exploration of gdcmHeader.
2270 - takes an optional filename argument (the file to parse).
2271 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2272 PubElVals hashing table.
2273 * Dicts/dicomV3.dic removed error prone trailing spaces.
2275 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2276 * Python wrapping process moved away from src/Makefile to
2277 newly created python/Makefile (as well as gdcm.i)
2278 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2279 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2280 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2281 from the environement variable GDCM_DICT_PATH (when existing).
2282 * src/gdcmDict::GetTag bug fix.
2284 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2285 * Straightforward temporary fixes for swig to build the python wrappers.
2286 src/Makefile now has a python working entry [by working we mean
2287 that we can import de shadow classes without errors].
2289 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2290 * hashtest.cxx removed (since allready in Test)
2291 * src/gdcmlib.h renamed to src/gdcm.h
2292 * src/dcm.i renamed to src/gdcm.i
2293 * src/Makefile prepared for python wrapping
2295 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2296 * src/gdcmHeader.cxx :
2297 - Parsing of header is now separated from loading of element values
2298 (see gdcmHeader::LoadElements).
2299 - general clean up of hopefully all file access (creation of
2300 ReadInt16 and ReadInt32)
2302 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2303 * src/gdcmHeader.cxx :
2304 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2306 - SetLgrElem renamed to SetLength
2307 - GetLgrElem renamed to GetLength
2308 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2309 * src/gdcmElValSet.cxx fixed both GetElValue methods
2310 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2311 due to IdoDude was cleaned out.
2313 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2314 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2315 concentrates on finding the value representation (when it exists).
2316 RecupLgr now only finds the element value length, and it avoids
2317 returning the unecessary skL (skipped length).
2318 Also, offsetCourant was simply removed (with taille_fich) since
2319 it was redundant with the File position internals (by using
2320 ftell and fseek). This also made skL (see above in RecupLgr) usage
2322 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2323 on the libido specificities which are handled through class
2325 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2328 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2329 * Truckload of changes. Parsing of header is barely functional
2330 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2332 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2333 * src/gdcmHeader.cxx many addons of low level methods
2335 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2336 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2337 and _IdDcmSWAP_LONG.
2339 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2340 * This corresponds to all the changes decided at the meeting of
2341 May 23 2002. Needless to say we are running late...