1 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * gdcm/Doc many doxygen changes:
3 - Doxyfile now has two different versions, DoxyfileUsers that generates
4 the html.users end users oriented documentation and DoxyfileDeveloppers
5 that generates the html.developper developper oriented documentation.
6 - README changed accordingly
7 - requirement.txt removed (old design info moved to TODO).
8 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt, DoxyMainPage.txt,
9 DoxyPython.txt provide more information.
10 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
11 be updated by simply regenerating the docs with doxygen and copying
12 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
13 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence all
14 the tests in the form "if (<map>.count() >1)" were removed.
15 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
16 ill-formed documentation sections.
17 * src/gdcmHeader.cxx: ditto
19 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
20 * setup.py fixed for un*x (needed macro for stdint.h)
21 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
22 un*ces with sh-utils test utility.
23 * gdcmPython/demo/test.py renamed to PrintHeader.py
24 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
25 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
26 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
27 * src/gdcm*.cxx JPR's bad inclusion fixed.
29 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
30 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
31 * gdcmPython/demo/test.py changed accordingly.
33 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
34 * gdcmPython/Makefile.am fixed linking against libstdc++
35 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
36 * Swig subdir (historical tests of swig version 1.3.17++) removed
37 * Test/testChangeEntete.cxx some lines commented out in order to make
39 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
40 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
42 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
43 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
44 hence the user doesn't need this explicit call.
45 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
46 i.e. LoadElements() call removed.
47 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
48 - src/Makefile.am declares the proper flag for g++.
49 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
50 for adding user defined new tags.
51 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
52 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
53 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
55 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
56 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
57 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
58 src/Makefile.am : the project should properly compile and install
59 with the autotools, included the python wrappers part.
60 * gdcm.spec.in : added a spec file for RPM packaging.
62 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
63 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
65 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
66 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
67 to exported to the environement (see gdcmPython/testSuite.py
69 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
70 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
71 ElValue class renamed to gdcmElValue for obvious consistency reasons.
72 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
73 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
75 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
76 * gdcmPython/__init__.py doesn't crash anymore when running in
77 in InstallMode or PreInstallMode but with an environement given
78 value of GDCM_DICT_PATH.
79 * src/gdcmDictSet.[cxx/h] coding style.
81 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
82 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
83 * src/gdcm.h general comments moved to TODO, and README
84 * src/gdcm.h should now be seen as a user commodity (including it
85 should suffice to fully use gdcm). It is nowhere including within
86 any of the kernel files src/*.cxx and src/*.h.
88 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
89 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
90 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
92 * src/gdcm*.cxx only include their corresponding include file
93 (as opposed to gdcm.h)
94 * gdcmPython/gdcm.i changed accordingly
95 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
96 the autogen.sh generated "make snapshot" command to work.
97 * autogen.sh removed history related references to crea package.
99 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
100 * distutilsSwigCPlusPlus.py work around some swig portability
103 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
104 * Eventually, python/gdcmPython was renamed to gdcmPython. This
105 was done in a last ditch attempt to get setup.py _really_
106 operationnal. The python/gdcmPython layaout add the advantage
107 of hidding away the python related distutils specific files
108 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
109 Alas, the src directory was out of scope (i.e. it's relative
110 position to setup.py was ../src) which made things impossible to
111 handle (see previous version of python/setup.py). Crossing fingers...
113 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
114 * python/setup.py now works on Un*x. (harder than I thougth)
115 * python/distutilsSwigCPlusPlus.py can now have include files
116 among the list of sources.
118 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
119 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
120 * modifications in MSVC projects
122 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
123 * As stated by the first lines of Test/ExceptionAndPython/README, it
124 looks like we can move back to original usage of exception within
125 src/gdcm* and hence remove the errno stuff that was introduced
126 as a quick and dirty fixture of this problem (added to the TODO).
127 * Doc/Doxyfile configuration file for Doxygen and corresponding
128 README file for usage added.
129 * Test/testWrite.cxx added. This new test comes from a split of
130 test.cxx that is now reverted to its original purpous i.e.
131 testing the proper parsing of a Dicom related file.
132 testWrite.cxx concentrates on testing the IO part of gdcm.
133 * Test/bug1.cxx (containing a bug on WIn32) added.
134 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
135 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
136 whose purpose is to publish the content of the TagNames of the
137 Dicom public dictionnary were not accessible without an
138 instance of class gdcmHeader.
139 - those methods are now static methods of gdcmDictSet and hence
140 require no instances at all to be invocated.
141 - within gdcmDictSet this change required to change some method
142 to class methods (i.e. are now static) among which SetDictPath
143 (renamed to BuildDictPath) and LoadDefaultPubDict.
144 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
145 the above changes by calling the new method classes of gdcmDictSet.
146 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
147 the above to be effective.
148 * python/gdcmPython: in order to wrap properly the above changes
149 for Python, swig version now needs to be > 1.3.17.
150 * python/gdcmPython/Makefile fixed to adapt itself to new
151 configure/make shema introduced by Johan Montagnat (thanks for the
152 contribution). Alas this Makefile cannot be turned into a proper
153 Makefile.am without some heavy changes in the configure.in
154 (for python dectection).
155 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
156 now avoids publishing the empty entries.
158 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
159 * python/setup.py : bug fix concerning install under windows
161 * gdcm.dsw : bug fix concerning path for libraries for python !!!
163 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
164 * Dicts/dicomV3.dic : remove double spaces !!!
165 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
166 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
169 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
170 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
171 method. Doxygenation.
172 * src/gdcm.h clean up of JPR spurious comments.
174 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
175 * python/distutilsSwigCPlusPlus.py now properly collects the
176 shadow classes generated by "swig -c++" (gdcm.py in our case)
177 when using "python setup.py install".
178 * python/gdcmPython/__init__.py imports gdcm.py and only manually
179 reexports the working classes.
180 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
181 by the classical C errno scheme. This is to prevent an obscure
182 behavior of the python wrappers when importing wxPython.wx prior
183 to gdcmPython (which ended up in an abort call). An illustration
184 of this oddity can be found in the Test/ExceptionAndPython
185 subdir (see the README file). This problem probably due to
186 an combination of g++ and dynamic loading.
187 * added Test/ExceptionAndPython (see above)
189 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
190 * Changed the layout of the python part to avoid bloating main
191 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
192 i.e. the distutils arsenal. All the python related stuff is
193 again in a python subdir, but the package itself is now in
195 * setup.py was cleaned up:
196 - pythonIncludePath removed
197 - python setup.py bdist target is now functional.
198 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
199 collision with other packages). gdcmPython/demo/*.py changed
201 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
202 * python subdir moved to gdcmPython (preparation of distutils packaging).
203 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
204 distutils installer is operational.
205 * - gdcmPython/__init__.py now properly loads the swig generated
206 shadow classes (from gdcm.py).
207 - gdcmPython/demo/*.py changed to import the package gdcmPython
208 instead of gdcmPython/demo/load.py.
209 - gdcmPython/testSuite.py changed to import the package gdcmPython.
212 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
213 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
214 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
215 entries within the associated public Dicom dictionary resp. the same
216 information but sorted by the fourth field (PAT, IMG, DIR) of the
218 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
219 are now in the "???" group.
220 - python/gdcm.i changed accordingly,
221 - python/demo/printGroupedPublicDict.py added, that gives an example
222 of the above new functionalities in Python.
224 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
225 * src/gdcm.h, gdcmHeader.cxx:
226 - historic references to glib's g_malloc and g_free (#defined)
227 were definitively removed.
228 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
229 * src/gdcmElValSet.cxx:
230 - GetElement(guint32, guint32) renamed to GetElementByNumber.
231 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
232 - GetElValue(string) renamed to GetElValueByName.
233 - Added GetElementByName(string).
234 * src/gdcmHeader.cxx: added
235 - GetPubElValRepByNumber(guint16, guint16)
236 - GetPubElValRepByName(string)
237 - GetShaElValRepByNumber(guint16, guint16)
238 - GetShaElValRepByName(string)
239 - GetShaElValByNumber(guint16, guint16)
240 - GetShaElValRepByName(string)
241 - GetElValRepByNumber(guint16, guint16)
242 - GetElValRepByName(string)
243 - GetElValByNumber(guint16, guint16)
244 - GetElValRepByName(string)
245 * Doc/requirements.txt added.
247 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
248 * Test/Makefile building now depends on the one of libgdcm.so
249 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
250 pixel data) aware which enables finding the address (offset) of
251 the pixel data of JPEG encoded DICOM files. This leaves only a single
252 file in the testSuite whose pixel data address (offset) is unknown.
253 * python/testSuite.py changed accordingly.
255 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
256 * VC++ has some strong limitations when working with the STL, as stated
257 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
258 "Also note that some STL containers (map, set, queue, list, deque)
259 cannot be exported. [...]
260 Some STL classes contain nested classes. These classes can not
262 This is caused by a designed limitation that once a template
263 class is instantiated, it can not be re-instantiated and
265 Since our usage of map<> is ubiquitous in gdcm, this "designed
266 limitation" of VC++ is a pitfall.
267 Hence the Python wrappers of gdcm cannot be incrementally linked
268 against the c++ dynamic library. The dirty but only workaround is
269 to forget about incremental link of dynamic libraries and to generate
270 the Python wrappers library with the inclusions of the underlying C++
272 The following modifications concern this matter on Win32/VC++:
273 - wrapping python correct with standalone wrapped dll (don't use separate
274 dll under windows !!!!)
275 - python21_d debug mode enabled (ask Frog how to use it :-)
276 - NO problem with having an STL member of class for example string in C++
277 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
278 - Python test of dcmlib in Python is ok under windows on a large set
280 * removed glib references
281 * typedef's inserted in gdcm.i for correct swig type management
283 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
284 * python/demo/*.py load.py extracted from test.py. Added explore.py
285 that only displays required tags and testAll.py that parses all
286 the files of the testsuite without using unittest.
287 * python/testSuite.py other additional test on new files added.
288 * Data/* new test files added accordingly to the testSuite.
289 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
290 the vr in the file differs from the one of the dictionary.
292 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
293 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
294 values, but limits itself to values which are below a user specified
295 size (by default 1024 bytes).
296 * python/gdcm.i : elements not loaded (because their size is above the
297 user specified treshold) are exported with their TagKey as key of the
298 python dictionary. This enables the testsuite to make some checks
299 on the unloaded elements (since we have their offset and size).
300 * python/testSuite.py
301 - now tests for the existence and proper value of the pixel data
302 - two new examples added.
303 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
305 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
306 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
307 aware. See the strategy comments in gdcmHeader::FindeLength().
308 * Test/test.cxx now accepts a filename as first argument.
309 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
310 * python/testSuite.py changed to integrate test on above files.
312 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
313 * Dicts/dicomV3.dic removed all the trailing (RET) when the
315 * python/testSuite.py more tests added.
317 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
318 * python/testSuite.py unittest test suite added (uses Data)
319 * Data/* dcm and acr files for the test suite.
320 * glib dependance removed from un*x version. We now use ISO C99
321 7.18 Integer types (see stdint.h)
322 - python/Makefile, src/Makefile src/gdcm.h
323 * src/ when an explicit vr (like dicom files) suddenly poped an
324 implicit element we use to mark the underlying DictEntry of the
325 concerned ElValue with "Implicit". This strategy was damageable
326 too the public or provite dictionaries, since some of their vr
327 would be changed. Since Header::FindLength heavily relies on the
328 detection by Header::FindVR of falsely explicit elements, I
329 added an extra ImplicitVr member to ElValue (boolean).
330 The rest of the changes we the necessary adaptations.
332 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
333 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
335 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
337 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
338 * Adaptation for porting to VC++:
340 o forced to use std namespace (for string to be known)
341 o all class use __declspec export style on WIN32
342 - src/gdcmUtil.cxx new Exit method that wraps the exit call
343 (in stdlib.h on Win32 but in std:: for gcc)
344 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
345 variable GDCM_DICT_PATH.
346 * src/gdcmHeader.cxx verbose comments made discrete.
348 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
349 * python/gdcm.i: added a typemap that converts a C++ hashing table
350 to native Python dictionary.
351 * python/demo/test.py:
352 - now uses the native dictionary for exploration of gdcmHeader.
353 - takes an optional filename argument (the file to parse).
354 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
355 PubElVals hashing table.
356 * Dicts/dicomV3.dic removed error prone trailing spaces.
358 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
359 * Python wrapping process moved away from src/Makefile to
360 newly created python/Makefile (as well as gdcm.i)
361 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
362 * src/gdcmHeader::FindLength only looks for current vr when necessary.
363 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
364 from the environement variable GDCM_DICT_PATH (when existing).
365 * src/gdcmDict::GetTag bug fix.
367 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
368 * Straightforward temporary fixes for swig to build the python wrappers.
369 src/Makefile now has a python working entry [by working we mean
370 that we can import de shadow classes without errors].
372 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
373 * hashtest.cxx removed (since allready in Test)
374 * src/gdcmlib.h renamed to src/gdcm.h
375 * src/dcm.i renamed to src/gdcm.i
376 * src/Makefile prepared for python wrapping
378 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
379 * src/gdcmHeader.cxx :
380 - Parsing of header is now separated from loading of element values
381 (see gdcmHeader::LoadElements).
382 - general clean up of hopefully all file access (creation of
383 ReadInt16 and ReadInt32)
385 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
386 * src/gdcmHeader.cxx :
387 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
389 - SetLgrElem renamed to SetLength
390 - GetLgrElem renamed to GetLength
391 - ~gdcmHeader() made virtual to pesky warning messages at compile.
392 * src/gdcmElValSet.cxx fixed both GetElValue methods
393 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
394 due to IdoDude was cleaned out.
396 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
397 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
398 concentrates on finding the value representation (when it exists).
399 RecupLgr now only finds the element value length, and it avoids
400 returning the unecessary skL (skipped length).
401 Also, offsetCourant was simply removed (with taille_fich) since
402 it was redundant with the File position internals (by using
403 ftell and fseek). This also made skL (see above in RecupLgr) usage
405 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
406 on the libido specificities which are handled through class
408 * Test/implicit_vr.dcm dicom v3 in implicit value representation
411 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
412 * Truckload of changes. Parsing of header is barely functional
413 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
415 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
416 * src/gdcmHeader.cxx many addons of low level methods
418 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
419 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
422 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
423 * This corresponds to all the changes decided at the meeting of
424 May 23 2002. Needless to say we are running late...