1 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * gdcmPython/__init__.py doesn't crash anymore when running in
3 in InstallMode or PreInstallMode but with an environement given
4 value of GDCM_DICT_PATH.
5 * src/gdcmDictSet.[cxx/h] coding style.
7 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
8 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
9 * src/gdcm.h general comments moved to TODO, and README
10 * src/gdcm.h should now be seen as a user commodity (including it
11 should suffice to fully use gdcm). It is nowhere including within
12 any of the kernel files src/*.cxx and src/*.h.
14 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
15 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
16 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
18 * src/gdcm*.cxx only include their corresponding include file
19 (as opposed to gdcm.h)
20 * gdcmPython/gdcm.i changed accordingly
21 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
22 the autogen.sh generated "make snapshot" command to work.
23 * autogen.sh removed history related references to crea package.
25 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
26 * distutilsSwigCPlusPlus.py work around some swig portability
29 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
30 * Eventually, python/gdcmPython was renamed to gdcmPython. This
31 was done in a last ditch attempt to get setup.py _really_
32 operationnal. The python/gdcmPython layaout add the advantage
33 of hidding away the python related distutils specific files
34 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
35 Alas, the src directory was out of scope (i.e. it's relative
36 position to setup.py was ../src) which made things impossible to
37 handle (see previous version of python/setup.py). Crossing fingers...
39 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
40 * python/setup.py now works on Un*x. (harder than I thougth)
41 * python/distutilsSwigCPlusPlus.py can now have include files
42 among the list of sources.
44 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
45 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
46 * modifications in MSVC projects
48 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
49 * As stated by the first lines of Test/ExceptionAndPython/README, it
50 looks like we can move back to original usage of exception within
51 src/gdcm* and hence remove the errno stuff that was introduced
52 as a quick and dirty fixture of this problem (added to the TODO).
53 * Doc/Doxyfile configuration file for Doxygen and corresponding
54 README file for usage added.
55 * Test/testWrite.cxx added. This new test comes from a split of
56 test.cxx that is now reverted to its original purpous i.e.
57 testing the proper parsing of a Dicom related file.
58 testWrite.cxx concentrates on testing the IO part of gdcm.
59 * Test/bug1.cxx (containing a bug on WIn32) added.
60 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
61 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
62 whose purpose is to publish the content of the TagNames of the
63 Dicom public dictionnary were not accessible without an
64 instance of class gdcmHeader.
65 - those methods are now static methods of gdcmDictSet and hence
66 require no instances at all to be invocated.
67 - within gdcmDictSet this change required to change some method
68 to class methods (i.e. are now static) among which SetDictPath
69 (renamed to BuildDictPath) and LoadDefaultPubDict.
70 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
71 the above changes by calling the new method classes of gdcmDictSet.
72 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
73 the above to be effective.
74 * python/gdcmPython: in order to wrap properly the above changes
75 for Python, swig version now needs to be > 1.3.17.
76 * python/gdcmPython/Makefile fixed to adapt itself to new
77 configure/make shema introduced by Johan Montagnat (thanks for the
78 contribution). Alas this Makefile cannot be turned into a proper
79 Makefile.am without some heavy changes in the configure.in
80 (for python dectection).
81 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
82 now avoids publishing the empty entries.
84 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
85 * python/setup.py : bug fix concerning install under windows
87 * gdcm.dsw : bug fix concerning path for libraries for python !!!
89 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
90 * Dicts/dicomV3.dic : remove double spaces !!!
91 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
92 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
95 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
96 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
98 * src/gdcm.h clean up of JPR spurious comments.
100 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
101 * python/distutilsSwigCPlusPlus.py now properly collects the
102 shadow classes generated by "swig -c++" (gdcm.py in our case)
103 when using "python setup.py install".
104 * python/gdcmPython/__init__.py imports gdcm.py and only manually
105 reexports the working classes.
106 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
107 by the classical C errno scheme. This is to prevent an obscure
108 behavior of the python wrappers when importing wxPython.wx prior
109 to gdcmPython (which ended up in an abort call). An illustration
110 of this oddity can be found in the Test/ExceptionAndPython
111 subdir (see the README file). This problem probably due to
112 an combination of g++ and dynamic loading.
113 * added Test/ExceptionAndPython (see above)
115 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
116 * Changed the layout of the python part to avoid bloating main
117 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
118 i.e. the distutils arsenal. All the python related stuff is
119 again in a python subdir, but the package itself is now in
121 * setup.py was cleaned up:
122 - pythonIncludePath removed
123 - python setup.py bdist target is now functional.
124 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
125 collision with other packages). gdcmPython/demo/*.py changed
127 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
128 * python subdir moved to gdcmPython (preparation of distutils packaging).
129 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
130 distutils installer is operational.
131 * - gdcmPython/__init__.py now properly loads the swig generated
132 shadow classes (from gdcm.py).
133 - gdcmPython/demo/*.py changed to import the package gdcmPython
134 instead of gdcmPython/demo/load.py.
135 - gdcmPython/testSuite.py changed to import the package gdcmPython.
138 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
139 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
140 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
141 entries within the associated public Dicom dictionary resp. the same
142 information but sorted by the fourth field (PAT, IMG, DIR) of the
144 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
145 are now in the "???" group.
146 - python/gdcm.i changed accordingly,
147 - python/demo/printGroupedPublicDict.py added, that gives an example
148 of the above new functionalities in Python.
150 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
151 * src/gdcm.h, gdcmHeader.cxx:
152 - historic references to glib's g_malloc and g_free (#defined)
153 were definitively removed.
154 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
155 * src/gdcmElValSet.cxx:
156 - GetElement(guint32, guint32) renamed to GetElementByNumber.
157 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
158 - GetElValue(string) renamed to GetElValueByName.
159 - Added GetElementByName(string).
160 * src/gdcmHeader.cxx: added
161 - GetPubElValRepByNumber(guint16, guint16)
162 - GetPubElValRepByName(string)
163 - GetShaElValRepByNumber(guint16, guint16)
164 - GetShaElValRepByName(string)
165 - GetShaElValByNumber(guint16, guint16)
166 - GetShaElValRepByName(string)
167 - GetElValRepByNumber(guint16, guint16)
168 - GetElValRepByName(string)
169 - GetElValByNumber(guint16, guint16)
170 - GetElValRepByName(string)
171 * Doc/requirements.txt added.
173 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
174 * Test/Makefile building now depends on the one of libgdcm.so
175 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
176 pixel data) aware which enables finding the address (offset) of
177 the pixel data of JPEG encoded DICOM files. This leaves only a single
178 file in the testSuite whose pixel data address (offset) is unknown.
179 * python/testSuite.py changed accordingly.
181 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
182 * VC++ has some strong limitations when working with the STL, as stated
183 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
184 "Also note that some STL containers (map, set, queue, list, deque)
185 cannot be exported. [...]
186 Some STL classes contain nested classes. These classes can not
188 This is caused by a designed limitation that once a template
189 class is instantiated, it can not be re-instantiated and
191 Since our usage of map<> is ubiquitous in gdcm, this "designed
192 limitation" of VC++ is a pitfall.
193 Hence the Python wrappers of gdcm cannot be incrementally linked
194 against the c++ dynamic library. The dirty but only workaround is
195 to forget about incremental link of dynamic libraries and to generate
196 the Python wrappers library with the inclusions of the underlying C++
198 The following modifications concern this matter on Win32/VC++:
199 - wrapping python correct with standalone wrapped dll (don't use separate
200 dll under windows !!!!)
201 - python21_d debug mode enabled (ask Frog how to use it :-)
202 - NO problem with having an STL member of class for example string in C++
203 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
204 - Python test of dcmlib in Python is ok under windows on a large set
206 * removed glib references
207 * typedef's inserted in gdcm.i for correct swig type management
209 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
210 * python/demo/*.py load.py extracted from test.py. Added explore.py
211 that only displays required tags and testAll.py that parses all
212 the files of the testsuite without using unittest.
213 * python/testSuite.py other additional test on new files added.
214 * Data/* new test files added accordingly to the testSuite.
215 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
216 the vr in the file differs from the one of the dictionary.
218 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
219 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
220 values, but limits itself to values which are below a user specified
221 size (by default 1024 bytes).
222 * python/gdcm.i : elements not loaded (because their size is above the
223 user specified treshold) are exported with their TagKey as key of the
224 python dictionary. This enables the testsuite to make some checks
225 on the unloaded elements (since we have their offset and size).
226 * python/testSuite.py
227 - now tests for the existence and proper value of the pixel data
228 - two new examples added.
229 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
231 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
232 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
233 aware. See the strategy comments in gdcmHeader::FindeLength().
234 * Test/test.cxx now accepts a filename as first argument.
235 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
236 * python/testSuite.py changed to integrate test on above files.
238 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
239 * Dicts/dicomV3.dic removed all the trailing (RET) when the
241 * python/testSuite.py more tests added.
243 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
244 * python/testSuite.py unittest test suite added (uses Data)
245 * Data/* dcm and acr files for the test suite.
246 * glib dependance removed from un*x version. We now use ISO C99
247 7.18 Integer types (see stdint.h)
248 - python/Makefile, src/Makefile src/gdcm.h
249 * src/ when an explicit vr (like dicom files) suddenly poped an
250 implicit element we use to mark the underlying DictEntry of the
251 concerned ElValue with "Implicit". This strategy was damageable
252 too the public or provite dictionaries, since some of their vr
253 would be changed. Since Header::FindLength heavily relies on the
254 detection by Header::FindVR of falsely explicit elements, I
255 added an extra ImplicitVr member to ElValue (boolean).
256 The rest of the changes we the necessary adaptations.
258 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
259 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
261 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
263 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
264 * Adaptation for porting to VC++:
266 o forced to use std namespace (for string to be known)
267 o all class use __declspec export style on WIN32
268 - src/gdcmUtil.cxx new Exit method that wraps the exit call
269 (in stdlib.h on Win32 but in std:: for gcc)
270 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
271 variable GDCM_DICT_PATH.
272 * src/gdcmHeader.cxx verbose comments made discrete.
274 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
275 * python/gdcm.i: added a typemap that converts a C++ hashing table
276 to native Python dictionary.
277 * python/demo/test.py:
278 - now uses the native dictionary for exploration of gdcmHeader.
279 - takes an optional filename argument (the file to parse).
280 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
281 PubElVals hashing table.
282 * Dicts/dicomV3.dic removed error prone trailing spaces.
284 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
285 * Python wrapping process moved away from src/Makefile to
286 newly created python/Makefile (as well as gdcm.i)
287 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
288 * src/gdcmHeader::FindLength only looks for current vr when necessary.
289 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
290 from the environement variable GDCM_DICT_PATH (when existing).
291 * src/gdcmDict::GetTag bug fix.
293 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
294 * Straightforward temporary fixes for swig to build the python wrappers.
295 src/Makefile now has a python working entry [by working we mean
296 that we can import de shadow classes without errors].
298 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
299 * hashtest.cxx removed (since allready in Test)
300 * src/gdcmlib.h renamed to src/gdcm.h
301 * src/dcm.i renamed to src/gdcm.i
302 * src/Makefile prepared for python wrapping
304 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
305 * src/gdcmHeader.cxx :
306 - Parsing of header is now separated from loading of element values
307 (see gdcmHeader::LoadElements).
308 - general clean up of hopefully all file access (creation of
309 ReadInt16 and ReadInt32)
311 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
312 * src/gdcmHeader.cxx :
313 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
315 - SetLgrElem renamed to SetLength
316 - GetLgrElem renamed to GetLength
317 - ~gdcmHeader() made virtual to pesky warning messages at compile.
318 * src/gdcmElValSet.cxx fixed both GetElValue methods
319 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
320 due to IdoDude was cleaned out.
322 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
323 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
324 concentrates on finding the value representation (when it exists).
325 RecupLgr now only finds the element value length, and it avoids
326 returning the unecessary skL (skipped length).
327 Also, offsetCourant was simply removed (with taille_fich) since
328 it was redundant with the File position internals (by using
329 ftell and fseek). This also made skL (see above in RecupLgr) usage
331 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
332 on the libido specificities which are handled through class
334 * Test/implicit_vr.dcm dicom v3 in implicit value representation
337 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
338 * Truckload of changes. Parsing of header is barely functional
339 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
341 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
342 * src/gdcmHeader.cxx many addons of low level methods
344 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
345 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
348 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
349 * This corresponds to all the changes decided at the meeting of
350 May 23 2002. Needless to say we are running late...