1 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
3 to avoid inclusion recursion until STL is reached.
4 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
5 mecanism. errno.h is not included in gdcm anymore.
6 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
7 (gdcmFormatError now inherits from gdcmFormatUnexpected).
9 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
10 gdcmData/TestAllEntryVerifyReference.txt
11 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
12 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
13 exception_on_error parameter.
14 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
15 - vtk/vtkGdcmReader.cxx changed accordingly,
16 - Example/*.cxx and Test/*.cxx changed accordingly.
18 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
19 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
20 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
21 enable_sequences removed from gdcmHeader constructor and dependencies.
22 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
23 * gdcmPython/demo/PrintHeader.py: dummy fix.
24 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
25 skip_shadow removed from gdcmHeader constructor and dependencies.
26 * Example/*.cxx and Test/*.cxx changed accordingly.
28 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
29 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
30 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
32 2004-07-21 Jean-Pierre Roux
33 * FIX Now, Parsing and Printing a DICOMDIR do work!
34 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
36 2004-07-20 Jean-Pierre Roux
37 * FIX Some brain damaged headers have Zero-Lenght fields
38 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
40 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
41 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
42 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
43 variable (instance of gdcmDebug) by a definition macro, and the instance
44 is now in static in the gdcmDebug class
45 * src/gdcmSQItem.h : (FIXME) remove an undefined method
46 * Test/PrintAllDocument.cxx : bug fix in the result of the test
48 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
49 * WARNING: ctest now depends more tightly on gdcmData. You should
50 check out gdcmData properly for things to run smoothly...
51 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
52 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
53 we need the pixels not be loaded in order to use the ValEntry
54 that displays position and size).
55 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
56 This is a C++ based equivalent of gdcmPython/testSuite.py that should
57 be deprecated. If you have any doubts about the advantages of a
58 modern scripting language (read Python) versus grass root C++ (i.e.
59 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
60 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
61 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
62 Anyhow, consider documenting the gdcmData images in
63 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
65 * Test/CMakeLists.txt:
66 - now uses TestAllEntryVerify.cxx
67 - specific comments on oldACR00001.ima (now renamed in gdcmData
68 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
69 gdcmData/TestAllEntryVerifyReference.txt
72 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
73 * src/*.[h|cxx] : typedef clean up
74 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
75 - TagKey renamed to gdcmTagKey (for external usage)
76 - VRKey renamed to gdcmVRKey (for external usage)
77 - removal of typedef duplication.
78 - Removed all unecessary inline keyword from class inline definitions.
79 - Some method|function(void) declarations replaced with method|function().
80 * src/jpeg/libijg12/jdhuff12.c:
81 - printf polluting ctest removed.
82 - TAB removal for comminting
84 - TestAllReadCompareDicom.cxx: added a test that compares all the
85 images in gdcmDataImages.h with corresponding images in
86 gdcmData/BaselineDicom/. When baseline images are not present
87 this test creates them.
88 Note: we need to validate each reference image, but before that
89 I'd like to rename them with a more explicit name...
90 - CMakeLists.txt: changed accordingly.
91 * Example/*.cxx: examples now only include gdcm.h (as opposed to
92 including each header needed).
94 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
95 * Test/*.cxx and Example/*.cxx: moved some examples away from the
96 test suite to the Example directory. Are concerned:
101 - TestWriteSimple.cxx
102 * Test/CMakeLists.txt: added some comments on reasons for black listing
103 image gdcmData/oldACR00001.ima
105 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
106 * Test/CmakeList.txt: removed the following from black list (to be coherent
107 with removal from gdcmData):
108 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
109 - gdcm-MR-PHILIPS-16.dcm
111 Added the following because after last cvs update, they cause
112 ctest -R TestReadWriteReadCompare
114 - gdcm-MR-SIEMENS-16-1.acr
116 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
117 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
118 new comments in this file) we temporarily (sigh) move to a weaker
120 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
121 we don't need to black list the following images anymore:
122 - 8BitsUncompressedColor.dcm
124 - US-PAL-8-10x-echo.dcm
125 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
126 fixes and the beautified code ;-)
127 This fixes the bug introduced in version 1.42 (when beautifying)
128 that made the parsing of 8BitsRunLengthColor.dcm unproper.
129 Note: ctest was blind to this bug (this means we need to still
130 improve the test suite). The bug could be detected by using
131 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
133 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
134 and by displaying the (garbage) produced file temp.XDCM...
136 2004-06-29 Jean-Pierre Roux
137 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
138 - replace by uggly but working old code :-(
139 A lot of things should be OK again.
140 It's really urgent to have a test suite that *tests*,
141 to prevent Frog's beautifying sessions to break all the stuff
142 (twice, withing a fortnigh ...)
144 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
145 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
146 redundancy) to added Test/TestReadWriteReadCompare.cxx
147 * Test/CmakeList.txt: because the compare test of
148 Test/TestReadWriteReadCompare.cxx fails, the following images are
149 black listed: - 8BitsUncompressedColor.dcm
151 - US-PAL-8-10x-echo.dcm
152 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
153 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
154 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
155 and ad-hoc kludge. This kludge is now removed, and on encountering
156 such an image (OB field brain damaged) we set errno. Then in
157 ::FindDocLength() we "fix" the length as being ALL what remains
158 in the file (until EOF). We then proceed, hoping for the best...
159 This fixes a SegFault in ShowDicom when trying to write such an
161 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
162 (because TestWriteRead breaks on it, after a non conformal commit?).
163 ctest now runs properly, except for MakeDicomDir (which was allways
164 broken) and the Python related stuff (still not fixed).
166 2004-06-24 Jean-Pierre Roux
167 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
168 FIX : Test/TestReadWrite now iterates on all the file names
169 (instead of infinite loop)
170 ENH : Test/TestWriteRead now iterates on all the file names
172 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
173 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
175 2004-06-24 Jean-Pierre Roux
176 FIX : - now Write drops LUT Descriptors and LUTs (if any)
177 when SamplesPerPixel =3
178 - now Write is no longer confused by
179 'BitsAllocated = 12" and 'BitsStored=12"
180 - "UN" value representation Elements are now written correctly
181 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
182 ENH : - now gdcmHeader has its own Write methods
183 (in order to split the job that has not to be done
186 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
187 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
188 loop on the same image until memory went out.
189 Note: this means we still have gobs of memory loss in PrintDocument
190 * src/gdcmDocument.cxx: fixes problem on parsing on file
191 gdcmData/16BitsJpegLosslessGrayScale.dcm.
193 2004-06-24 Jean-Pierre Roux
194 FIX : Write - All the Sequences and Sequence Item are now written
195 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
196 is added a the end, when necessary.
197 - A lot of brain-damaged images, that were read correctly are
198 now written correctly
199 - length compatible BinEntry are now loaded correctly
200 (even for odd groups)
201 Note : only Explicit Value Representation was checked.
202 (question : is implicit VR really necessary for gdcm ?)
204 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
205 * DEVELOPPER: added a proposition of coding style.
206 * src/gdcmDocEntry.h: removed every inline declaration (for test of
209 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
210 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
211 Use the gdcmDocEntry::Print() and Write() instead.
212 * src/gdcmDocument.cxx: bug fix.
214 2004-06-22 Jean-Pierre Roux
215 FIX : gdcmDocument.cxx
216 - Now we do recognize the JpegLossLess format (there was a misstyping in
217 code 'beautyfication' :-(
218 - Now we automaticaticaly load the Luts, if any
220 2004-06-22 Jean-Pierre Roux
221 In order : to write Sequences, whatever their imbrication level,
222 : to allow user to create his own Sequences
223 a lot of modif where necessary (adding, moving, or virtualising methods)
225 WARNING : save your own sources *before* cvs up !
228 ADD virtual void Write(FILE *fp, FileType filetype);
231 ADD virtual void Write(FILE *fp, FileType filetype);
232 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
235 ADD virtual void Write (FILE *fp, FileType filetype)=0;
236 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
237 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
238 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
239 ADD std::string GetEntryByName(TagName name);
240 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
242 std::string vr = "unkn",
243 std::string fourth = "unkn",
244 std::string name = "unkn");
245 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
246 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
247 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
248 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
249 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
250 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
251 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
252 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
255 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
256 ADD virtual std::string GetEntryByName (TagName tagName);
257 ADD virtual std::string GetEntryVRByName (TagName tagName);
258 REM virtual bool Write(FILE *, FileType);
259 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
260 FILE *_fp, FileType type);
261 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
262 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
263 REM virtual bool WriteEntries(FILE *_fp,FileType type);
264 REM virtual std::string GetEntryByName (std::string tagName);
265 REM virtual std::string GetEntryVRByName (std::string tagName);
266 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
267 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
268 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
270 std::string vr = "unkn",
271 std::string fourth = "unkn",
272 std::string name = "unkn");
273 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
274 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
275 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
276 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
279 ADD virtual void Write(FILE *fp, FileType filetype);
282 ADD virtual void Write(FILE *fp,FileType filetype);
285 ADD virtual void Write(FILE *fp, FileType filetype);
286 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
287 REM std::string GetEntryByNumber(guint16 group, guint16 element);
288 REM std::string GetEntryByName(TagName name);
291 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
293 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
294 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
295 The default constructor invoked by the line
296 gdcmHeader *f1 = new gdcmHeader( header );
297 was gdcmHeader::gdcmHeader(bool) instead of the expected
298 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
299 Hence the parsing wasn't executed... See also below.
300 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
301 as explicit constructor didn't do the trick to fix the above problem.
302 Could anyone explain why ?
303 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
304 properly calls gdcmValEntry::Print() (that was weed out from
305 code related to gdcmBinEntry).
307 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
308 * In order to fix memory leaks:
309 - Test/TestWriteSimple.cxx: added cleaning of free store through
311 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
312 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
313 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
314 (through the call to ::AddDicomDirMeta()) or the destructor
315 would crash when deleting uninitialized ::metaElems].
316 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
317 - src/gdcmDocument.cxx:
318 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
320 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
321 was causing memory leaks.
322 - src/gdcmSQItem.cxx:
323 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
324 cleanly handled with polymophism: sorry but my milage is low).
325 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
326 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
327 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
328 This avoids SegFaulting.
329 - src/gdcmSQItem.h: coding style.
331 - Test/TestWriteSimple still severely sucks. The output image content
332 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
333 damaged when displayed with vtkgdcmViewer.
334 - on memory leaks: TestWriteSimple leaks really less (see entry
335 of 2004-06-18 in Changelog file for the call to valgrind).
336 - on segfaults: ctest now passes all the tests but one (no more
338 * Erroneous leading white fix:
339 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
340 white[s] (as opposed to from >> xxx, that removes it [them].
341 - src/gdcmTS.cxx: ditto.
342 - gdcmPython/testSuite.py: dirty related kludge removed.
343 * src/*: remaining references to gdcmParser removed.
344 * src/*[cxx|h]: added copy[way]left header.
347 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
348 * In order to fix writing of dicom files:
349 - Test/TestWriteSimple.cxx: a simpler example of writing.
350 - Test/CMakeLists.txt changed accordingly.
351 - src/gdcmDocument.cxx:
352 -- The destructor now recursilvely removes potential sequences.
353 -- Bug fix in ::IsJPEG2000()
354 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
355 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
357 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
358 to only declared) and build on top of
359 ::GetDocEntryByNumber(guint16, guint16).
360 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
361 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
362 for usage in destructor and treatement of promotion in
363 ::ReplaceOrCreateByNumber().
364 - src/gdcmSQItem.cxx: destructor should better handle his job.
365 Test/TestWriteSimple now runs (or at least it DOES something).
366 * We can now start hutting memory links. A good starting point is:
367 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
368 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
369 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
371 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
372 * Valgrind note: after Mathieu Malaterre teached me how to read
373 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
375 Using gcc, you can force the STL to use malloc and to free memory as
376 soon as possible by globally disabling memory caching.
377 With 3.2.2 and later, you should export the environment variable
378 GLIBCPP_FORCE_NEW before running your program.
379 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
380 simply vanish (it is still not clear to me, whether this means that
381 STL std::string leaks or if valgrind believes it leaks...).
382 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
383 running bin/gdcmTests makeDicomDir):
384 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
385 - Test/makeDicomDir.cxx now properly traps empty lists and returns
387 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
388 SegFaulting (I drowned in DicomDir related code when trying to
389 understand why the list is empty...).
390 * src/gdcmDocument.h: first BSD license header try.
391 * Doc/License.txt added.
393 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
394 * src/gdcmDocument.[h|cxx]:
395 - Clean up of the Transfer related predicates. They are now all based
396 on new method isGivenTransferSyntax, that (should) handle properly
398 - general clean up, simplification, and coding style.
399 - Specific clean up of Parse7FE0() (umproperly named actually).
400 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
402 2004-06-14 Jean-Pierre Roux
404 - fix the display of Sequence Delimitor (SQDepthLevel pb)
405 - fix the display of SQItem ordinal number
406 - add the GetSQItemByOrdinalNumber method
407 - remove some useless never written private methods
409 2004-06-14 Jean-Pierre Roux
411 - adding a constructor taking a gdcmDocEntry as an input param
412 - ReplaceOrCreateByNumber now returns :
413 a gdcmBinEntry * if a Binary (void *) value is passed as a param
414 a gdcmValEntry * if a string value is passed as a param
416 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
417 according to the param type (no longer sets a gdcmDocEntry)
418 - GetValEntryByNumber, GetBinEntryByNumber added
419 - NewValEntryByNumber and NewBinEntryByNumber added
421 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
423 - GetSQItemNumber and SetSQItemNumber added, to provide
424 a (relative) Item identier inside a given Sequence
425 \warning : some pb remaining around this number
427 - AddEntry now takes the Item Number as a param
429 - adding a constructor taking a gdcmDocEntry as an input param
431 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
432 * Memory leak hunt with the following command:
433 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
434 --show-reachable=yes gdcmTests PrintDocument
435 It looks like many (all?) leaks are due to the STL (or a bad usage
436 of the STL. The lines producing the leaks now have a comment with
437 a "MEMORY LEAK" tag: you can retrieve them with
438 grep "MEMORY LEAK" src/*
439 Here are two typical examples which I can't help fixing:
444 char * test = "babo";
445 name = test; //// <--- valgrind detects 960 bytes lost in
446 //// call to std::string::operator=(char const*)
447 name.clear(); //// Doesn't help !
455 std::cout << "Type a bunch of characters followed by RETURN: ";
456 getline(std::cin, line); //// <--- valgrind dectects a loss
457 //// of 1320 bytes in call to
458 /// std::basic_istream<>& std::getline<>
464 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
465 * src/gdcmHeader.[cxx|h]:
466 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
467 and related, moved away to gdcmDocument.
468 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
469 the corresponding protected accessors of inherited class
470 gdcmDocument, removed ! As a consequence gdcmFile had to be
471 declared friend of class gdcmDocument (see below).
472 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
473 - Clean up of undefined or unused methods.
474 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
475 account the changes to gdcmHeader.h).
476 * src/gdcmDocument.h:
477 - gdcmFile is now a friend class (in order to take into account the
478 changes to gdcmHeader.h).
479 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
480 (see changes to gdcmHeader.h).
481 - Accessors (reading on the form GetEntry*) are now public.
482 - Clean up of undefined or unused methods.
483 * src/gdcmDocument.cxx:
484 - adaptation to changes to gdcmDocument.h
485 - ::OpenFile now writes a verbose message when file cannot be opened.
486 - some std::string properly set to VRKey
487 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
488 references to gdcmDocument.
489 * Test/TestFindTags.cxx: changed accordingly to above changes.
490 * gdcmPython/testSuite.py: adapted to renaming of acr files in
491 cvs repository gdcmData.
493 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
494 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
495 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
496 conflicts with gdcmValEntry::voidArea.
497 * src/gdcmValEntry.cxx: unmatching comment wiped out.
498 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
499 Value representation between StringRepresentable and BinaryRepresentable.
500 * src/gdcmDocument.cxx:
501 - method ParseDES: proper indentation restored and usage of
502 gdcmVR::IsVROfGdcmStringRepresentable wired in.
503 - method LoadDocEntry: the fingerprint left in the SetValue() of
504 unloaded entries (length > MaxSizeLoadEntry) had curiously been
505 removed. Reverting to previous code segment with the proper
506 dynamic_cast< gdcmValEntry* >.
507 Note: this was (partially) breaking the python test suite
508 (gdcmPython/testSuite.py) that made usage of the above
509 fingerprint to check presence of "Pixel Data".
510 * src/gdcmDocEntry.h: coding style.
511 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
512 now taken into account.
513 * gdcmPython/gdcm.i: adaptation to the new internal representation
514 of gdcm (exit gdcmParser, hello gdcmDocument).
515 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
517 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
518 anymore, but instead prints the loaded Python dictionary.
519 * .... alas, the python testSuite is still broken.
521 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
522 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
524 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
525 * src/gdcmUtil.h : export methods
527 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
528 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
530 * Initial addition of automatic python testing
531 * Initial addition of automatic image comparison
533 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
534 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
535 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
537 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
538 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
539 * Test/ShowDicom.cxx : bug fix for msvc compilation
540 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
542 2004-05-04 Jean-Pierre Roux
543 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
544 new concepts (and new classes) :
545 a 'gdcmDocument' is composed of a set of Doc Entries, that are
546 - elementary gdcmDocEntries (former gdcmHeaderEntries)
547 - Sequence Doc Entries (gdcmSeqEntries)
548 a Sequence is composed of Items.
549 Each item is a set of Doc Entries (this is recursive)
550 The non uniqueness of the 'Dicom tag' is due to this recursivity
551 (never taken into account)
552 Our unability to add a new 'entry' in the header
553 at the proper location (neither in the H-Table (map or multimap),
554 nor in the Chained List is also due to this recursivity.
555 Don't try, right now, to use/modify/compile these new sources :
557 We just commit all the stuff, 'as is', in order not to loose it.
559 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
560 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
562 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
563 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
564 file prefix (SetFilePrefix)
566 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
567 * Add a new test: ShowDicom, for now this is just the c++ version of
568 checkRead.sh, later it will be able to compare the image read against a
570 * Replace the DEBUG on the stack with a global entry in cmake interface:
571 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
573 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
574 * Add an example subdir, with a real example on how to read + write a
577 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
578 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
579 * Doc/CMakeLists.txt: the main page is now properly differentiated
580 between the developper and user version.
581 * Doc/doxygen.config.in: dropped search related obsolete flags
582 * src/gdcmParser.h, gdcmHeader.h: doxygenation
584 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
585 * DEVELOPPER: added some helpfull comments for compile/test/install
588 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
589 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
590 src directory, now generated in the build dir.
591 2. Tests as mentionned smarter
593 4. Add a new method in gdcmDict that return the PubDict by name
594 this is interesting for 3rd party lib like ITK,
595 where we could set the institution name / patient name...
597 * ENH: 1. Now the test suite is working for real
598 2. All binaries are now output in the gdcm-bin directory
599 (this was not true before)
601 2004-04-28 Jean-Pierre Roux
602 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
603 SeQuence indented printing of Dicom Header.
604 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
605 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
606 Computation of SQDepthLevel is now part of gdcmHeader constructor
607 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
608 tree-like structure of a Dicom Header.
609 * FIX Test code cleaning
611 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
612 * ENH: Adding automatic testing
613 1. Need a DartConfig.cmake to submit to public
614 2. Add a test driver gdcmTest.cxx
615 3. gdcmTestMain, an helper for the main test driver gdcmTest
616 4. Files in Test don't have a main anymore, this becomes interesting
617 when we add more and more tests, thus dsw don't have to load
619 * ENH: Adding a GDCM_DATA_ROOT for testing
620 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
621 one file instead of seven + some small cleanup
623 2004-04-22 Jean-Pierre Roux
624 * ENH Minor changes to the Print() methods.
625 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
626 Header printing. Example given with :
627 > PrintHeader fileName 2 new
628 (SQ based tree-like structure still to be done for the Header ...)
630 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
631 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
632 1. I have added some unsigned where needed
633 2. Some function parameter not used -> (void)
634 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
635 4. g++ don't like character '\' in comment
636 5. #define jpeg_create_decompress jCreaDecompress
637 this really need to be fixed
638 6. virtualize destructor of gdcmObject ... leakage
639 7. sscanf(g->first.c_str(),"%x",&gr_bid);
640 this also really need to be fixed
641 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
642 remove compression file
643 (as we only do decompression, right ?)
644 * ENH: Change malloc/calloc/free with c++ equivalent
646 2004-04-21 Jean-Pierre Roux
647 * FIX gdcmHeaderHelper::GetXSpacing
648 when a single value is found (bug ?), xpacing is now
649 defaulted to yspacing
651 2004-04-19 Jean-Pierre Roux
652 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
653 * ENH add parameters :
654 bool exception_on_error = false,
655 bool enable_sequences = false,
656 bool ignore_shadow = false
657 to the gdcmFile constructors to be full gdcmParser compliant
658 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
659 to allow reading of PAPYRUS 3.0 files
661 2004-04-06 Jean-Pierre Roux
662 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
664 2004-04-02 Jean-Pierre Roux
665 * ADD : Test/checksequence.sh, for a general recap on SQ pb
666 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
667 for Philips spurious Tag fffe|0000 while rewritting Dicom files
669 2004-03-30 Jean-Pierre Roux
670 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
671 for ACR file, written out as DICOM files (hope so...)
673 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
674 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
675 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
676 moved to base class gdcmParser and only the specialisation is kept
678 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
679 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
680 already does the job.
681 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
682 (to be consistent with gdcmParser::WriteEntries).
684 2004-03-30 Benoit Regrain
685 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
686 upate of the object's instance. It's passed to 2 in the unfavorable
687 case : one in the ExecuteInformation, one in the ExecuteData
689 2004-03-29 Jean-Pierre Roux
690 * ENH : Check on file type to be written moved
691 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
692 * FIX : gdcmObject::ResetBoundaries now stops properly
693 when end-of-list is reached
694 : gdcmVersion modified (as Benoit Regrain asked)
696 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
697 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
698 * src/gdcmUtil.cxx: added forgotten iostream include.
699 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
700 equivalent to ExplicitVR in existing code).
702 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
703 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
704 now contains all the gdcmGlobal related code.
705 * minor coding style and doxygenation changes.
707 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
708 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
709 now contains all the Debug related code.
710 * minor clean-up of includes in src/*.cxx
711 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
712 CreateCleanString) removed.
713 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
714 * Doc/DoxyMainPageUser.txt added.
715 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
716 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
719 2004-03-24 Jean-Pierre Roux
720 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
722 2004-03-23 Jean-Pierre Roux
723 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
724 big endian made volumes
725 * ENH Now gdcmParser constructor and destructor are protected to forbid
726 end user to instanciate class gdcmParser
727 (only gdcmHeader and gdcmDicomDir are meaningfull)
729 2004-03-22 Benoit Regrain
730 * FIX : src/gdcmDicomDir.cxx : make windows compilable
731 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
732 gdcmSerie to gdcmDicomDirSerie
734 2004-03-19 Jean-Pierre Roux
735 * ENH Now the tree-like structure describing a DICOMDIR comming from
736 an already existing DICOMDIR file is consistent with
737 the home-made tree-like structure build ex-nihilo
738 or build from the files held (recursively) in a Directory
739 functions gdcmDicomDir::CheckBoundaries()
740 gdcmObject::SetBoundaries() added
742 2004-03-17 Jean-Pierre Roux
743 * REM (Eric Boix bug) : removal of meaningless
744 gdcmDicomDirImage::NewImage function.
745 * FIX now file names and directory name are written properly in the
747 * FIX now gdcmDicomDir constructor may be call without any trick
750 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
751 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
752 of gdcmDicomDirImage::NewImage as empty function.
754 2004-02-28 Jean-Pierre Roux
755 * ENH add gdcmDicomDir:NewPatient
756 add gdcmDicomDirPatient:NewStudy
757 add gdcmDicomDirStudy:NewSerie
758 add gdcmDicomDirSerie:NewImage
759 to allow making gdcDicomDir object.
760 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
761 (as opposite to the gdcmHeader chained list)
763 2004-02-11 Benoit Regrain
764 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
765 when using from python
767 2004-02-10 Benoit Regrain
768 * FIX : bug fix in the gdcmDirList for the recursivity in directories
769 * FIX : in gdcmDicomDir when the directory is empty
770 * ENH : add callback and methods to get the progression of dicomDir
773 2004-02-06 Jean-Pierre Roux
774 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
775 - GDCM_META added to gdcmDicomDirType
776 - class gdcmMeta created
777 * ENH : - A brief summary is now displayed at the beginning of
778 'testDicomDir' to help disaster magnitude estimation
779 * REM : Now useless Test/explDICOMDIR.cxx
781 2004-02-05 Benoit Regrain
782 * ENH : add methods in gdcmObject to get the hash table or the list of
784 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
785 * FIX : wrapping python for TagHeaderEntryHT
787 2004-02-04 Benoit Regrain
788 * FIX : even length for some strings when writting the dicom dir
789 * FIX : sort the images in the dicom dir
790 * FIX : Bug fix for python use of dicom dir
791 * ADD : a python demo
793 2004-02-04 Jean-Pierre Roux
794 * FIX : Final solution (?) for icone embedded images
795 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
796 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
797 add groups 6002, 6004, 6006, to allow 'clean' parsing of
798 gdcmData/gdcm-MR-SIEMENS-16.acr1
799 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
800 to make full checking easier
802 2004-02-04 Benoit Regrain
803 * FIX : WriteEntries : coding style & logic in parameters
804 * FIX : Set the elements to create the DicomDir in a dictionary file
806 2004-02-03 Benoit Regrain
807 * gdcmDirList : to parse a hard drive directory in recursive (or not)
808 * gdcmDicomDir : add the load of directory
809 * Bug fix and print add-on
811 2004-02-03 Jean-Pierre Roux
812 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
813 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
814 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
815 * FIX gdcmParser.cxx : 'group length' elements are now considered
816 as integers, even for shadow groups, when file is Implicit VR
818 2004-02-02 Jean-Pierre Roux
819 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
821 of the last synonym :-(
822 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
824 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
825 * FIX taking into account the possible 7fe0,0010 multiplicity
826 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
827 to allow removal of references to 7fe0,0010, to deal with
828 ACR-NEMA images, when 0028,0200 is meaningfull
830 2004-01-31 Jean-Pierre Roux
831 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
832 no longer writes 'Un' on disk
833 * FIX SQ elements with actual length are now dealt with corectly
834 * FIX gdcmFile::WriteBase make the difference, for color images, between
835 the length (for Palette expanded images)
836 and Raw Length (non expanded image + Palette)
837 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
838 (that broke Write). Replaced by UL.
839 Aware user will reload the field if he
840 thinks it's necesssary
842 2004-01-30 Jean-Pierre Roux
843 * gdcmParser::CheckSwap() now defaults the filetype to ACR
844 when 'dirty Acr' is found, to be compliant with the new
845 IsReadable() methods.
847 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
848 (no DOUBLE images in kosher DICOM,
849 but so usefull for people that miss them ;-)
851 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
852 DICOMDIR related utilities (not checked as Windoze compliant)
854 2004-01-28 Jean-Pierre Roux
855 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
857 2004-01-27 Jean-Pierre Roux
858 * gdcmParser constructor has a new boolean param,'ignore_shadow',
859 to allow skipping the shadow elements, to save memory space.
860 The TRUE value for this param has to be used
861 with a FALSE value for the 'enable_sequence' param.
862 ('public elements' may be embedded in 'shadow Sequences')
863 * gdcmHeader methods now deal with 'embedded icones images' in the header
864 (even when an 'icone image sequence' is announced by the
865 element (0x0088,0x0200), but there is NO icone at all ...
867 * gdcmHeader sometimes Image Location value doesn't follow
868 the supposed processor endianity (see gdcmData/cr172241.dcm).
871 * gdcmHeader add the method
872 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
873 to get *all* the Header Entries with the same tag.
874 GetHeaderEntrySameName is probabely *useless*
875 (no meaning : Name is *not* an identifier within the Dictionnary)
877 2004-01-26 Benoit Regrain
878 * Bug fix in the print of hexadecimal representations. Remove long fields
879 in the print and add a third level of print to print them
881 2004-01-23 Benoit Regrain
882 * Bug fix on field having a VR = 'UI'. Assume that is a string field
883 * Bug fix on test suite after remove the strip made on not string fields
884 * Split the IsReadable method between gdcmParser which test that the file
885 is dicom and gdcmHeader which test that it's an image file
887 2004-01-22 Benoit Regrain
888 * DicomDir : clean code, add methods, set variables in protected or private
889 * gdcmUtil : bug fix for the clean string method
891 2004-01-19 Benoit Regrain
892 * Add the use of shadow dictionaries
893 * bug fix and coding style
895 2004-01-19 Benoit Regrain
896 * src/gdcmFile.cxx : bug fix concerning the close of file
897 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
898 * Add the update of header entries using the shadow library
900 2004-01-19 Benoit Regrain
901 * removal of file gdcmHeader2.cxx
902 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
903 inheriting from gdcmParser. This split is to prepare the integration
905 * bug fix under python
907 2004-01-16 Jean-Pierre Roux
908 * REM removal of class gdcmHeaderEntrySet
909 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
910 * ADD add file gdcmHeader2.cxx
911 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
913 2004-01-15 Benoit Regrain
914 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
915 entries created while parsing the header. Thus, they will be destroyed
916 when the gdcmDictSet will be destroyed
917 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
920 2004-01-15 Benoit Regrain
921 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
922 made a fatal error because of the memory release at the end of program.
923 The problem was in vtkGdcmReader::ExecuteData where we were allocate
924 some memory and vtk seems to have some problems with that.
925 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
927 2004-01-14 Benoit Regrain
928 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
929 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
930 * src/*.[h|cxx] : make changes due to class name changes
931 * gdcmPython/demo/*.py : bug fix due to method names
933 2004-01-13 Benoit Regrain
934 * src/*.[h|cxx] : coding style
935 * vtk/*.[h|cxx] : coding style
937 2004-01-13 Benoit Regrain
938 * gdcmPython/testSuite.py : test the readable flag of file for tests
939 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
940 It's lied to the stl compilation by MSVC (windows, always windows...)
941 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
943 2004-01-12 Benoit Regrain
944 * src/*.h : add comments
945 * src/gdcmDictSet.h : set the method BuildDictPath in public
946 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
947 directly setted in the source code
948 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
951 2004-01-09 Benoit Regrain
952 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
953 * setup.py : use a reference to gdcmVERSION
955 2004-01-07 Benoit Regrain
956 * Modification to compile with the distutils.
959 2003-12-10 Benoit Regrain
960 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
961 can use a gdcmHeaderHelper to load datas
962 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
963 made in the source code
965 2003-12-10 Benoit Regrain
966 * Update Windows projects and .cvsignore files
968 2003-11-12 Jean-Pierre Roux
969 * ENH gdcmHeader constructor has one more parameter (default value : false)
970 that allows the user to 'go inside' the SeQuences only
972 gdcmElValSet:Print takes it into account
974 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
975 * ENH: Update gdcmPython/CMakeLists
976 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
977 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
979 2003-11-10 Jean-Pierre Roux
980 * FIX : gdcmHeader::LoadElements is now based
981 on the ListTag listElem member,
982 not longer on the TagElValueHT tagHt member
983 * ENH : PrintPubElVal shows (temporarily) both results,
984 with the tagHt member and the listElem member.
985 (it's easier to 'see' the problems when using Printheader)
987 * FIX : old private member LgrElem is now splitted into
988 ReadLength : Length actually found on disk (updated only
989 if bug fixing is necessary), for internal
991 UsableLength : Updated by FixFoundLength, to fix a bug
992 or to allow Parser going on.
993 Will allow to re-write a kosher header when a SeQuence
994 with a length (not 0000) is found
995 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
996 because gdcmElValSet::Add does not update ListElem
999 2003-11-07 Jean-Pierre Roux
1000 * FIX misstyping in Transfert Syntax name table
1001 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1002 when they have an actual length (not 0000 nor FFFFF)
1003 (Nobody should care of it, but DICOMDIR explorers)
1005 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1006 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1008 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1009 * ENH: vtkGdcmReader now supports LUT !
1010 (vtkgdcmViewer for now is not able to use them though)
1012 2003-11-05 Jean-Pierre Roux
1013 * in testSuite.py : new files names for checking the package
1014 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1015 that returns the pixel area size to the *aware* (vtk) user
1016 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1018 2003-11-05 Benoit Regrain
1019 * in testSuite.py : Modify the rules for checking the paths
1020 : Explicit error messages
1021 * in __init__.py : Related modif
1023 2003-11-03 Jean-Pierre Roux
1024 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1025 to be used by aware (vtk) users that want to manage
1026 LUT (and no to turn the PALETTE image into an RGB pixels one)
1027 * GetPixelType now returns 8U for 24 Bits images
1028 (vtkGdcmReader compliant)
1030 2003-10-31 Jean-Pierre Roux
1031 * Removal of *all* gdcmData images and add them again
1032 in order to loose the 'history' of un-anonymised images
1034 2003-10-31 Jean-Pierre Roux
1035 * RMV : removal of useless jBitsInJsample.h
1036 for both 8 and 12 Bits JPEG Lossy Libraries
1038 2003-10-31 Jean-Pierre Roux
1039 * ENH : Add the functions gdcmFile::GetImageDataRaw
1040 gdcmFile::GetImageDataIntoVectorRaw
1041 that act as GetImageData and GetImageDataIntoVector
1042 except the making of an RGB Plane from Gray Plane + LUT
1043 Intended to aware (vtk) users who know how to manage
1046 GetLUTRGBA return a R,G,B,A LUT if any
1047 lgrTotaleRaw gives the 'Raw' length
1048 GetImageDataRaw returns the gray Plane
1049 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1050 (They stay Grey, just like with other Dicom viewers :-(
1052 2003-10-30 Jean-Pierre Roux
1053 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1055 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1056 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1057 being coherents dicom files.
1059 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1060 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1062 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1063 * ENH: Two steps is necessary to please VC++ compiler...
1064 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1065 * ENH: Add include dir to medcon lib
1066 * FIX: only one function is being exported for now !
1067 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1069 2003-10-29 Jean-Pierre Roux
1070 * adding gdcmHeader::GetLUTRGBA
1071 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1072 --> Mathieu, the modif u're waiting for is not yet committed
1073 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1075 2003-10-27 Jean-Pierre Roux
1076 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1077 00191113.dcm DermaColorLossLess.dcm
1078 MxTwinLossLess.dcm RadBWLossLess.dcm
1079 * ENH: For version prior to vtkImageViewer2 -r 1.19
1080 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1082 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1083 * Removal of ido stuff in CMakeLists.txt
1085 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1086 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1087 * FIX: remove a call to ->Modified ... see comments
1088 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1090 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1091 * FIX: Problem with path for libvtkgdcmPython
1092 * ENH: Try adding a search script for python site-package
1093 * RMV: Remove some file from medcon lib that are not necessary
1094 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1095 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1096 * FIX: More pragma disable fro VC++,
1097 I don't think I break something as it is also disable in VTK/ITK.
1098 But it fasten debug compilation time.
1100 2003-10-23 Jean-Pierre Roux
1101 * gdcm now deals with 16 Bits Run Length Encoded images
1102 (they are compressed as 2 planes images,
1103 one for the high Bytes, the other for low Bytes)
1105 2003-10-22 Jean-Pierre Roux
1106 * Now CheckRead takes into account :
1107 - the bugged 'Leonardo' Siemens images
1108 - the XA images, sent thru the burning VPRO station
1109 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1112 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1113 * FIX: When copying a Makefile.am to CMakeLists.txt
1114 one should remove the '\'
1116 2003-10-22 Jean-Pierre Roux
1117 * in gdcmData adding a bugged 'Leonardo' Siemens image
1118 (wrong lengths in header)
1119 OK with gdcm, KO with the other viewers :-)
1120 * add a GE dlx XA image, thru the VEPRO burning station
1123 2003-10-21 Jean-Pierre Roux
1124 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1125 for a brutal checking of vtkgdcmViewer compliance
1127 2003-10-21 Jean-Pierre Roux
1128 * add the files for 'xmedcon' Jpeg Lossless library
1129 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1131 2003-10-21 Jean-Pierre Roux
1132 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1134 2003-10-21 Jean-Pierre Roux
1135 * garbage Siemens 'Leonardo' images dealt with
1136 (the patch is easy to remove)
1137 * cosmetic changes to avoid warnings
1139 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1140 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1141 no need to press 'r' now.
1143 2003-10-20 Jean-Pierre Roux
1144 * upgrade of checkRead.sh checkWrite.sh according
1145 to new Jpeg Lossless decompressor
1146 * add US.3405.1.dcm, a genuine RGB medical file ...
1147 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1148 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1150 2003-10-15 Jean-Pierre Roux
1151 * general anonymisation in gdcmData
1152 * adding the 'color files' from
1153 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1154 * adding some well knowed bugged-header images
1155 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1156 waiting for their inclusion in Python testsuite
1158 2003-10-15 Jean-Pierre Roux
1159 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1160 no longer seg faults when file is not found
1162 2003-10-14 Jean-Pierre Roux
1163 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1166 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1167 * TODO: *.in file to genereate a UseGDCM later
1169 2003-10-14 Jean-Pierre Roux
1170 * Some supposed-to-be Dicom Images have no preamble.
1171 OpenFile takes it into account
1172 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1173 * Missing elements added in dicomV3.dic
1174 (just to be affraid : have a look at
1175 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1176 and do it again next year ;->
1178 2003-10-13 Jean-Pierre Roux
1179 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1180 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1181 But there are NOT. It's fixed !
1183 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1184 * FIX: "jpeglib.h" was not found on VC++
1185 * FIX: vtkgdcm was not being installed
1187 2003-10-10 Jean-Pierre Roux
1188 * ENH : OpenFile closes the file if it *really* doesn't look like
1189 an ACR-NEMA / DICOM one.
1190 * FIX : testWrite no longer writes an empty file if the source file
1191 is not gdcm Readable
1192 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1195 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1196 * FIX: CMake generate now documentation
1197 * ENH: out of source doc build !
1198 * ENH: Generate both user and dev documentation
1199 * ENH: Should work on windows too
1200 * ENH: Only one doxygen config.in file is needed
1201 * FIX: make install should be ok now on ùnix plateform
1202 * FIX: PATH to dictionary was wrong (missing /)
1203 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1205 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1206 * vtkGdcmReader is now able to read rgb dicom file.
1207 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1208 * added a gdcmViewer to vtk test, use mouse to control
1209 window level & window width
1211 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1212 * CMake-ification of gdcm, we have now two build system
1213 * FIX: on cygwin Wsock32 doesn't exist
1214 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1216 2003-10-06 Emanuel Ollart
1217 * FIX : compilation process wad broken.
1218 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1220 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1221 * change gdcmViewer -> vtkgdcmViewer
1222 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1224 2003-10-06 Jean-Pierre Roux
1225 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1226 ( e.g : well known GE images with a wrong elem length,
1227 : Philips MRI Images with a wrong Huffman table)
1228 * still to be done : allow the reading of bugged LEONARDO Siemens images
1230 2003-10-03 Jean-Pierre Roux
1231 * Odd length strings are padded with '\0' (not with spaces,
1232 to remain compliant with already defined strings,
1233 like Transfert Syntax UID and others)
1235 2003-10-03 Jean-Pierre Roux
1236 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1237 to allow displaying RGB images (not only by affim ;-)
1239 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1240 * vtkGdcmReader is now able to read rgb dicom file.
1241 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1243 2003-10-03 Jean-Pierre Roux
1244 * A few nasty patches to allow the reading of a lot of nasty images
1245 ( e.g : well known GE images with a wrong elem length,
1246 : Philips MRI Images with a wrong Huffman table)
1247 * still to be done : allow the reading of bugged LEONARDO Siemens images
1249 2003-10-03 Jean-Pierre Roux
1250 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1252 2003-10-03 Jean-Pierre Roux
1253 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1254 to allow displaying RGB images (not only by affim ;-)
1256 2003-10-03 Jean-Pierre Roux
1257 * gdcmFile::GetImageDataIntoVector now
1258 - deals with MultiFrames MultiFragments Run Length Encoded files
1259 - deals with YcBcR (YBR_FULL) files
1260 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1261 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1263 (no sample found :-(
1265 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1266 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1267 Two reasons: - clear things
1268 - third parties acces gdcm through header files, so won't
1269 suffer anymore VC++ complains
1271 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1272 * add argv[1] in testvtkGdcmReader.cxx
1275 2003-09-24 Jean-Pierre Roux
1276 * The lines are now eigthy characters long.for
1277 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1279 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1280 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1281 char* to std::string. Thus, the use of strdup becomes useless. (see
1282 previous commis of Malaterre)
1283 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1284 before the last Malaterre's commit.
1286 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1287 * This commit should fix the Debug building under VC++, the problem
1288 was mainly a mixture of debug and release lib being loaded at startup.
1289 * I also remove a depency to a specific C function: strdup. Because I had
1290 to force the link to msvcrtd (whereas strdup is in libc).
1292 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1293 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1294 located in the gdcmCommon.h file. All use of reference of tha has been
1295 changed to now use the variable GDCM_UNFOUND.
1297 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1299 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1300 Dicom dictionary. The test suite can now be run again. Note:
1301 I'm note very happy with the " (RET)" changes. I believe this
1302 RETAINED comment should be dropped when parsing the dictionary.
1303 - PACKAGER corrected
1305 - AUTHORS updated and now in alphabetical order
1306 * Makefile.am now exports gdcm.dsw for Windoze users.
1308 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1309 * cygwin complains about missing std:: in subdir Test/
1311 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1312 * remove some methods that are now in gdcmHeaderHelper
1314 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1315 * vtkGdcmReader set spacing and origin correctly
1317 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1318 * Fix a few delete/delete[] mismatch
1320 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1321 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1322 interpretation to data given by gdcmHeader. For instance there are
1323 heuristics to get informations (look at different places).
1324 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1325 sorting DICOM images based on different strategies.
1326 * modified Makefiles accordingly.
1328 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1329 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1330 when building in debug mode
1331 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1332 src/win32/gdcmdll.dsp
1333 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1335 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1336 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1339 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1340 * src/win32/libgdcmjpeg12.dsp was not dos format
1341 * src/win32/libgdcmjpeg12.dsp :
1342 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1343 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1345 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1346 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1348 * src/gdcmFile.cxx : bug fix in affectation type
1349 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1350 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1351 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1352 symbols... future problem ?
1354 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1355 * src/win32/libgdcmijpeg12.dsp was missing
1356 * modified gdcm.dsw accordingly
1358 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1359 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1361 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1362 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1363 commit of JPR (before his hollidays to facilitate our work).
1364 * setup.py : bug fix in code. Modifications made while the last commit
1365 of JPR. The code hasn't been tested before the commit... it's so
1366 useless to make that (for best programmer that is JPR) !!!
1368 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1369 * tagged the current version as Version0_3 (i.e. version 0.3)
1371 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1372 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1373 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1374 * *.dsp : modifications to use new libgdcmijpeg8 library
1375 * setup.py : bug fix on VTKPATH variable
1376 * PACKAGER : adding all concerning windows
1378 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1379 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1381 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1382 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1383 test suite reported error.
1384 * PACKAGER file added (describes what a packager must do when
1385 packaging a new release).
1386 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1387 * configure.in: upgraded version number to 0.3.0
1388 * fixing build of rpm (through rpm -ta):
1389 - Doc/Makefile.am exports proper doxygen files
1390 - src/jpeg/libijg8/Makefile.am exports the include files.
1392 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1393 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1394 * src/gdcmHeader.h : formatting code
1396 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1397 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1398 We were obtaining error message from vtk. Now, creation of file list
1399 is made in an internal list to prevent this problem.
1400 Bug fix when output is empty.
1401 Bug fix in update of progress value. Previous commit for this was a bad
1403 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1405 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1406 * src/gdcmHeader.h : added method to get the file name
1407 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1408 files. Added method to remove all files on the input
1409 Added FIXME comment concerning the bad parsing of header made by
1410 ExecuteInformation method (in ExecuteData method)
1412 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1413 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1414 when using make instal.
1415 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1416 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1418 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1419 * setup.py : adding include dir of jpeg lib to compile all sources
1420 * */Win32/*.dsp : JPR fix for windows compilation
1422 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1423 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1425 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1426 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1428 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1429 * setup.py is again effective on un*x (takes into account the
1430 addon of the jpeg library)
1431 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1432 * Doc/Doxy* updated (includes above enhancements)
1433 * INSTALL now points to web documentation
1435 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1436 * src/gdcmHeader.h doesn't make unnecessary reference to
1438 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1440 * src/gdcm*.[cxx|h] :
1441 - to allow compilation with gcc 3.x
1442 -- clean up of STL usage (added explicit usage of std::)
1443 -- small fixes on exceptions.
1444 Note: linking not tested !
1445 - clean of doxygen comments to avoid warnings at documentation
1447 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1448 dependent convertion).
1450 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1451 * Clean up of previous JPR garbage commit (not even commented in the
1453 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1454 - moved all jpeg related files from src to src/jpeg/libijg8, with
1455 addition/modification of Makefile.am and configure.in.
1456 - the testSuite is still brain damage (not guilty).
1458 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1459 * WrapVTK.py : modifications to get correctly vtk source files to
1461 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1462 (FileName -> Filename)
1464 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1465 * vtk/vtkGdcmReader.[cxx/h]:
1466 - UpdateProgress method should now be effective
1467 - removed the limitation on having only images loaded (as opposed
1469 - when building a stack of images/volume, a lesser number of
1470 gdcmHeader and gdcmFile instances should be used (hopefully
1471 accelerating things).
1472 - when building a stack of images/volumes, files which are not
1473 loadable (wrong path-filename, wrong permissions on existing file,
1474 or file not parsable by gdcm) are replaced with a black image
1475 in the stack (for the caller to notice the problem).
1477 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1478 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1480 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1481 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1482 between standard library (std) and vtk library (problems are found
1483 under Windows... thanks Windows !)
1485 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1486 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1488 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1490 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1491 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1493 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1494 * When compiling with distutils (see setup.py) the C++ compiler is
1495 called with different flags than the default ones (with automake).
1496 In order to fix all those warning, I compiled gdcm with the command
1497 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1498 and went for warning fixes:
1499 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1500 up from unused variables.
1501 - vtk/vtkGdcmReader.cxx: potential bug fix.
1502 * src/gdcmHeader.h: Doxygen warning cleanup
1504 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1505 * gdcmPython/gdcm.i:
1506 - typemaps correction to take into account the systematic replacement
1507 of "using namespace std" with std:: prefix e.g. std::list,
1508 std::string... (cf changes of 2003-05-21).
1509 - gdcmGlob global variable of type gdcmGlobal (defined in
1510 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1511 exported to Python a as cvar.
1512 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1513 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1514 gdcmDictSet.GetPubDictTagNames() and
1515 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1516 C++ static methods).
1517 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1518 with the above changes.
1520 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1521 * setup.py, manifest.in : bug fix under linux
1523 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1524 * Modification of setup.py to compile vtk part too. Then, we have 2
1525 wrappers which must work with same distutils. For that, we have a
1526 generic distutils in distusiltsWrapping.py ; with :
1527 - build_extWrap class to wrap generically all extensions,
1528 - ExtensionWrap base class for all wrapping extension that contains
1530 - Wrapper interface which wrap sources
1531 + In WrapSwig.py we have extension and wrapper for Swig
1532 + In WrapVTK.py we have extension and wrapper for VTK
1533 * MANIFEST.in : modifications to consider vtk directory and new python
1534 files for compilation
1536 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1537 * Added python wrappers of vtkGdcmReader vtk class (see the
1538 source in vtk/vtkGdcmReader.cxx) :
1539 - vtk/Makefile.am now builds a library
1540 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1541 python library (as opposed to _gdcm.so wich are the python
1542 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1543 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1545 - configure.in has an additional flag --enable-vtk that needs
1546 to be set to enable compilation of vtk related code, that is:
1547 + vtk/vtkGdcmReader.so and
1548 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1549 + gdcmPython/vtkgdcmPython.so (see above)
1550 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1551 be read when compressed or when HighBit + 1 != BitsStored),
1552 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1553 the usage of the python wrapper of vtkGdcmReader vtk class.
1554 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1555 * src/*.[h] all occurences of stl classes are now prefixed with
1556 std::, and all occurences of "using namespace std;" where removed.
1557 This is to avoid pollution of global namespace in included files.
1558 Apparently vtk does not avoid this pitfall: when using both
1559 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1560 collision of various stl members (principally cout...).
1561 * gdcmPython/testSuite.py now cleanly removes temprory generated
1563 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1564 comply with above changes)
1566 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1567 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1568 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1569 vtk data structure (an image Flip was required).
1570 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1571 * cosmetic changes in documentation.
1573 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1574 * src/gdcmHeader.cxx: the constructor no longer exits when an
1575 unexisting file is given as argument.
1576 * The subdirectory Data (containing all the images used for the
1577 test suite) is not part of this repository anymore. A new module
1578 containing those images is now available at
1579 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1580 with the name gdcmData.
1581 All the python scripts (including the package initialisation file
1582 gdcmPython/__init__.py) were adapated to take this change into
1583 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1585 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1586 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1587 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1588 demo of the usage of this class.
1589 Compilation of this vtk part is only done when using the --enable-vtk
1590 at configure (or autogen.sh) stage.
1592 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1593 * More memory link related corrections and documentation fixes.
1595 - maximum info is obtained with a command of the form:
1596 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1597 --show-reachable=yes PrintHeader
1598 - the remaining reachable blocks seem to come from the STL
1599 allocation scheme through the usage of map and list. It looks
1600 like this memory cannot be freed but it is not a memory leak
1601 (in fact further invocation to the STL would recollect the
1602 unused memory allthough it cannot explicitely be freed).
1603 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1604 of displaying an image parsed with gdcm and displayed with VTK.
1605 Note: some images don't seem to work e.g.
1606 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1607 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1608 Allthough this weakens the semantics, it is a ditch attempt to
1609 make gdcm more thread friendly.
1611 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1612 * Memory link hunt (by using valgrind through the command
1613 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1614 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1615 gdcmHeader::_dicom_vr.
1616 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1617 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1619 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1621 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1622 * src/Makefile.am now exports all the necessary include files at
1626 * UpdateGroupLength replaced by new one
1629 * UpdateGroupLength re-written using H-Table
1630 (named UpdateGroupLengthNew untill checks are over)
1632 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1633 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1634 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1636 - gdcmHeader::GetPubElValSet removed.
1637 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1638 UpdateGroupLength, WriteElements, Write.
1639 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1640 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1641 carried the same semantics.
1642 - src/gdcmHeaderIdo.cxx changed accordingly.
1643 - gdcmFile::WriteBase now regroups all the codes from previous
1644 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1645 - enum FileType moved to gdcmCommon.h
1646 * src/gdcmHeader.cxx AddDefault trashed
1647 * gdcmGetXSize added
1648 * getimageDataSize now calls gdcmGetXSize
1649 * Test/*.cxx changed to agree with above changes
1651 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1652 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1653 (to avoid double call by end user).
1654 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1655 by end user, since gdcmHeader::gdcmHeader now handles it.
1657 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1658 * gdcm/Doc many doxygen changes:
1659 - Doxyfile now has two different versions, DoxyfileUsers that generates
1660 the html.users end users oriented documentation and
1661 DoxyfileDeveloppers that generates the html.developper developper
1662 oriented documentation.
1663 - README changed accordingly
1664 - requirement.txt removed (old design info moved to TODO).
1665 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1666 DoxyMainPage.txt, DoxyPython.txt provide more information.
1667 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1668 be updated by simply regenerating the docs with doxygen and copying
1669 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1670 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1671 all the tests in the form "if (<map>.count() >1)" were removed.
1672 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1673 ill-formed documentation sections.
1674 * src/gdcmHeader.cxx: ditto
1676 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1677 * setup.py fixed for un*x (needed macro for stdint.h)
1678 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1679 un*ces with sh-utils test utility.
1680 * gdcmPython/demo/test.py renamed to PrintHeader.py
1681 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1682 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1683 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1684 * src/gdcm*.cxx JPR's bad inclusion fixed.
1686 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1687 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1688 * gdcmPython/demo/test.py changed accordingly.
1690 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1691 * gdcmPython/Makefile.am fixed linking against libstdc++
1692 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1693 * Swig subdir (historical tests of swig version 1.3.17++) removed
1694 * Test/testChangeEntete.cxx some lines commented out in order to make
1696 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1697 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1699 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1700 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1701 hence the user doesn't need this explicit call.
1702 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1703 i.e. LoadElements() call removed.
1704 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1705 - src/Makefile.am declares the proper flag for g++.
1706 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1707 for adding user defined new tags.
1708 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1709 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1710 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1712 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1713 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1714 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1715 src/Makefile.am : the project should properly compile and install
1716 with the autotools, included the python wrappers part.
1717 * gdcm.spec.in : added a spec file for RPM packaging.
1719 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1720 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1722 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1723 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1724 to exported to the environement (see gdcmPython/testSuite.py
1726 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1727 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1728 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1729 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1730 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1732 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1733 * gdcmPython/__init__.py doesn't crash anymore when running in
1734 in InstallMode or PreInstallMode but with an environement given
1735 value of GDCM_DICT_PATH.
1736 * src/gdcmDictSet.[cxx/h] coding style.
1738 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1739 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1740 * src/gdcm.h general comments moved to TODO, and README
1741 * src/gdcm.h should now be seen as a user commodity (including it
1742 should suffice to fully use gdcm). It is nowhere including within
1743 any of the kernel files src/*.cxx and src/*.h.
1745 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1746 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1747 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1749 * src/gdcm*.cxx only include their corresponding include file
1750 (as opposed to gdcm.h)
1751 * gdcmPython/gdcm.i changed accordingly
1752 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1753 the autogen.sh generated "make snapshot" command to work.
1754 * autogen.sh removed history related references to crea package.
1756 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1757 * distutilsSwigCPlusPlus.py work around some swig portability
1760 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1761 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1762 was done in a last ditch attempt to get setup.py _really_
1763 operationnal. The python/gdcmPython layaout add the advantage
1764 of hidding away the python related distutils specific files
1765 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1766 Alas, the src directory was out of scope (i.e. it's relative
1767 position to setup.py was ../src) which made things impossible to
1768 handle (see previous version of python/setup.py). Crossing fingers...
1770 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1771 * python/setup.py now works on Un*x. (harder than I thougth)
1772 * python/distutilsSwigCPlusPlus.py can now have include files
1773 among the list of sources.
1775 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1776 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1777 * modifications in MSVC projects
1779 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1780 * As stated by the first lines of Test/ExceptionAndPython/README, it
1781 looks like we can move back to original usage of exception within
1782 src/gdcm* and hence remove the errno stuff that was introduced
1783 as a quick and dirty fixture of this problem (added to the TODO).
1784 * Doc/Doxyfile configuration file for Doxygen and corresponding
1785 README file for usage added.
1786 * Test/testWrite.cxx added. This new test comes from a split of
1787 test.cxx that is now reverted to its original purpous i.e.
1788 testing the proper parsing of a Dicom related file.
1789 testWrite.cxx concentrates on testing the IO part of gdcm.
1790 * Test/bug1.cxx (containing a bug on WIn32) added.
1791 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1792 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1793 whose purpose is to publish the content of the TagNames of the
1794 Dicom public dictionnary were not accessible without an
1795 instance of class gdcmHeader.
1796 - those methods are now static methods of gdcmDictSet and hence
1797 require no instances at all to be invocated.
1798 - within gdcmDictSet this change required to change some method
1799 to class methods (i.e. are now static) among which SetDictPath
1800 (renamed to BuildDictPath) and LoadDefaultPubDict.
1801 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1802 the above changes by calling the new method classes of gdcmDictSet.
1803 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1804 the above to be effective.
1805 * python/gdcmPython: in order to wrap properly the above changes
1806 for Python, swig version now needs to be > 1.3.17.
1807 * python/gdcmPython/Makefile fixed to adapt itself to new
1808 configure/make shema introduced by Johan Montagnat (thanks for the
1809 contribution). Alas this Makefile cannot be turned into a proper
1810 Makefile.am without some heavy changes in the configure.in
1811 (for python dectection).
1812 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1813 now avoids publishing the empty entries.
1815 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1816 * python/setup.py : bug fix concerning install under windows
1817 ExtraPath reused :-P
1818 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1820 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1821 * Dicts/dicomV3.dic : remove double spaces !!!
1822 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1823 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1826 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1827 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1828 method. Doxygenation.
1829 * src/gdcm.h clean up of JPR spurious comments.
1831 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1832 * python/distutilsSwigCPlusPlus.py now properly collects the
1833 shadow classes generated by "swig -c++" (gdcm.py in our case)
1834 when using "python setup.py install".
1835 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1836 reexports the working classes.
1837 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1838 by the classical C errno scheme. This is to prevent an obscure
1839 behavior of the python wrappers when importing wxPython.wx prior
1840 to gdcmPython (which ended up in an abort call). An illustration
1841 of this oddity can be found in the Test/ExceptionAndPython
1842 subdir (see the README file). This problem probably due to
1843 an combination of g++ and dynamic loading.
1844 * added Test/ExceptionAndPython (see above)
1846 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1847 * Changed the layout of the python part to avoid bloating main
1848 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1849 i.e. the distutils arsenal. All the python related stuff is
1850 again in a python subdir, but the package itself is now in
1852 * setup.py was cleaned up:
1853 - pythonIncludePath removed
1854 - python setup.py bdist target is now functional.
1855 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1856 collision with other packages). gdcmPython/demo/*.py changed
1859 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1860 * python subdir moved to gdcmPython (preparation of distutils packaging).
1861 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1862 distutils installer is operational.
1863 * - gdcmPython/__init__.py now properly loads the swig generated
1864 shadow classes (from gdcm.py).
1865 - gdcmPython/demo/*.py changed to import the package gdcmPython
1866 instead of gdcmPython/demo/load.py.
1867 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1869 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1870 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1871 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1872 entries within the associated public Dicom dictionary resp. the same
1873 information but sorted by the fourth field (PAT, IMG, DIR) of the
1875 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1876 are now in the "???" group.
1877 - python/gdcm.i changed accordingly,
1878 - python/demo/printGroupedPublicDict.py added, that gives an example
1879 of the above new functionalities in Python.
1881 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1882 * src/gdcm.h, gdcmHeader.cxx:
1883 - historic references to glib's g_malloc and g_free (#defined)
1884 were definitively removed.
1885 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1886 * src/gdcmElValSet.cxx:
1887 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1888 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
1889 - GetElValue(string) renamed to GetElValueByName.
1890 - Added GetElementByName(string).
1891 * src/gdcmHeader.cxx: added
1892 - GetPubElValRepByNumber(guint16, guint16)
1893 - GetPubElValRepByName(string)
1894 - GetShaElValRepByNumber(guint16, guint16)
1895 - GetShaElValRepByName(string)
1896 - GetShaElValByNumber(guint16, guint16)
1897 - GetShaElValRepByName(string)
1898 - GetElValRepByNumber(guint16, guint16)
1899 - GetElValRepByName(string)
1900 - GetElValByNumber(guint16, guint16)
1901 - GetElValRepByName(string)
1902 * Doc/requirements.txt added.
1904 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1905 * Test/Makefile building now depends on the one of libgdcm.so
1906 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
1907 pixel data) aware which enables finding the address (offset) of
1908 the pixel data of JPEG encoded DICOM files. This leaves only a single
1909 file in the testSuite whose pixel data address (offset) is unknown.
1910 * python/testSuite.py changed accordingly.
1912 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
1913 * VC++ has some strong limitations when working with the STL, as stated
1914 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
1915 "Also note that some STL containers (map, set, queue, list, deque)
1916 cannot be exported. [...]
1917 Some STL classes contain nested classes. These classes can not
1919 This is caused by a designed limitation that once a template
1920 class is instantiated, it can not be re-instantiated and
1922 Since our usage of map<> is ubiquitous in gdcm, this "designed
1923 limitation" of VC++ is a pitfall.
1924 Hence the Python wrappers of gdcm cannot be incrementally linked
1925 against the c++ dynamic library. The dirty but only workaround is
1926 to forget about incremental link of dynamic libraries and to generate
1927 the Python wrappers library with the inclusions of the underlying C++
1929 The following modifications concern this matter on Win32/VC++:
1930 - wrapping python correct with standalone wrapped dll (don't use separate
1931 dll under windows !!!!)
1932 - python21_d debug mode enabled (ask Frog how to use it :-)
1933 - NO problem with having an STL member of class for example string in C++
1934 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
1935 - Python test of dcmlib in Python is ok under windows on a large set
1937 * removed glib references
1938 * typedef's inserted in gdcm.i for correct swig type management
1940 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1941 * python/demo/*.py load.py extracted from test.py. Added explore.py
1942 that only displays required tags and testAll.py that parses all
1943 the files of the testsuite without using unittest.
1944 * python/testSuite.py other additional test on new files added.
1945 * Data/* new test files added accordingly to the testSuite.
1946 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
1947 the vr in the file differs from the one of the dictionary.
1949 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1950 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
1951 values, but limits itself to values which are below a user specified
1952 size (by default 1024 bytes).
1953 * python/gdcm.i : elements not loaded (because their size is above the
1954 user specified treshold) are exported with their TagKey as key of the
1955 python dictionary. This enables the testsuite to make some checks
1956 on the unloaded elements (since we have their offset and size).
1957 * python/testSuite.py
1958 - now tests for the existence and proper value of the pixel data
1959 - two new examples added.
1960 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
1962 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1963 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
1964 aware. See the strategy comments in gdcmHeader::FindeLength().
1965 * Test/test.cxx now accepts a filename as first argument.
1966 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
1967 * python/testSuite.py changed to integrate test on above files.
1969 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1970 * Dicts/dicomV3.dic removed all the trailing (RET) when the
1971 the vr was also RET.
1972 * python/testSuite.py more tests added.
1974 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1975 * python/testSuite.py unittest test suite added (uses Data)
1976 * Data/* dcm and acr files for the test suite.
1977 * glib dependance removed from un*x version. We now use ISO C99
1978 7.18 Integer types (see stdint.h)
1979 - python/Makefile, src/Makefile src/gdcm.h
1980 * src/ when an explicit vr (like dicom files) suddenly poped an
1981 implicit element we use to mark the underlying DictEntry of the
1982 concerned ElValue with "Implicit". This strategy was damageable
1983 too the public or provite dictionaries, since some of their vr
1984 would be changed. Since Header::FindLength heavily relies on the
1985 detection by Header::FindVR of falsely explicit elements, I
1986 added an extra ImplicitVr member to ElValue (boolean).
1987 The rest of the changes we the necessary adaptations.
1989 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1990 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
1992 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
1994 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1995 * Adaptation for porting to VC++:
1997 o forced to use std namespace (for string to be known)
1998 o all class use __declspec export style on WIN32
1999 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2000 (in stdlib.h on Win32 but in std:: for gcc)
2001 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2002 variable GDCM_DICT_PATH.
2003 * src/gdcmHeader.cxx verbose comments made discrete.
2005 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2006 * python/gdcm.i: added a typemap that converts a C++ hashing table
2007 to native Python dictionary.
2008 * python/demo/test.py:
2009 - now uses the native dictionary for exploration of gdcmHeader.
2010 - takes an optional filename argument (the file to parse).
2011 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2012 PubElVals hashing table.
2013 * Dicts/dicomV3.dic removed error prone trailing spaces.
2015 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2016 * Python wrapping process moved away from src/Makefile to
2017 newly created python/Makefile (as well as gdcm.i)
2018 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2019 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2020 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2021 from the environement variable GDCM_DICT_PATH (when existing).
2022 * src/gdcmDict::GetTag bug fix.
2024 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2025 * Straightforward temporary fixes for swig to build the python wrappers.
2026 src/Makefile now has a python working entry [by working we mean
2027 that we can import de shadow classes without errors].
2029 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2030 * hashtest.cxx removed (since allready in Test)
2031 * src/gdcmlib.h renamed to src/gdcm.h
2032 * src/dcm.i renamed to src/gdcm.i
2033 * src/Makefile prepared for python wrapping
2035 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2036 * src/gdcmHeader.cxx :
2037 - Parsing of header is now separated from loading of element values
2038 (see gdcmHeader::LoadElements).
2039 - general clean up of hopefully all file access (creation of
2040 ReadInt16 and ReadInt32)
2042 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2043 * src/gdcmHeader.cxx :
2044 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2046 - SetLgrElem renamed to SetLength
2047 - GetLgrElem renamed to GetLength
2048 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2049 * src/gdcmElValSet.cxx fixed both GetElValue methods
2050 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2051 due to IdoDude was cleaned out.
2053 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2054 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2055 concentrates on finding the value representation (when it exists).
2056 RecupLgr now only finds the element value length, and it avoids
2057 returning the unecessary skL (skipped length).
2058 Also, offsetCourant was simply removed (with taille_fich) since
2059 it was redundant with the File position internals (by using
2060 ftell and fseek). This also made skL (see above in RecupLgr) usage
2062 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2063 on the libido specificities which are handled through class
2065 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2068 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2069 * Truckload of changes. Parsing of header is barely functional
2070 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2072 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2073 * src/gdcmHeader.cxx many addons of low level methods
2075 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2076 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2077 and _IdDcmSWAP_LONG.
2079 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2080 * This corresponds to all the changes decided at the meeting of
2081 May 23 2002. Needless to say we are running late...