1 2004-09-23 Jean-Pierre Roux
2 * FIX In order not to be poluted any longer by casting problems,
3 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
4 we can now delete[] it safely
5 * VoidArea is now called BinArea (less confusing name),
6 and all the methods called ...VoidArea... are now ... BinArea...
7 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
9 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
10 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
11 clear) TagHT, which is an inherited member of gdcmElementSet. It is
12 up to the destructor of gdcmElementSet to clean up TagHt and it's
15 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
16 * Test/CMakeLists.txt: update to follow gdcmData renamings.
17 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
19 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
20 * ENH: added some utility method that builds a flat dictionnary
21 holding all the Dicom entries contained in the recursive structure
22 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
24 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
25 BuildFlatHashTable() that build a flat dictionary.
26 - src/gdcmElementSet.h: added a new private GetTag() accessor.
27 gdcmDocument is now a friend of gdcmElementSet.
28 - src/gdcmElementSet.cxx: clean up.
29 - Example/FlatHashTablePrint.cxx added.
30 - Example/CmakeLists.txt changed accordingly
32 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
33 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
34 moved away from gdcmDocEntrySet (since this class is an abstract class
35 acting like an interface). SQDepthLevel and BaseTagKey are now
37 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
38 and associated accessors. Doxygenation of the class.
39 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
41 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
42 Use SQDepthLevel accessor instead. ::Print() adapted.
43 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
44 - src/gdcmDocument.cxx changed accordingly.
46 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
47 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
48 - The following is the doxygen comment of the typedef declaration
49 of gdcmagKey in src/gdcmCommon.h:
50 gdcmTagKey is made to old an "universal" (as in URL, Universal
51 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
52 A dicom tag allways has a group and an element, but a set of tags
53 embeded in various (optionally nested) sequences and sharing
54 the same group and element all share the same (group, element)
55 "identifier". Hence the (group, element) cannot be used as an
56 identifier (in gdcm we shall refer to a "TagKey") of a tag.
57 In order to construct a proper tag identifier (i.e. a key) we
58 consider the following definition of a TagKey:
59 - let Group, Element be the string representation of the
60 group and element dicom tag members,
61 - let ItemNumber be the string representation of the integer
62 index of the considered item number of a sequence,
63 Let the key of a tag embeded in a sequence, noted SeqTag, be
65 /ItemNumber#Group|Element
66 where "/", "#" and "|" are characters acting as separators.
67 Then the general form of a gdcmTagKey is given by:
69 where <SeqTag> means NO or many instances of SeqTag.
70 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
73 but the gdcmTagKey of a tag "embeded" is the first item of
74 a sequence, itself nested in the third item of a sequence is the
76 0004|1220/2#0008|0082/0#0008|0090
77 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
78 order to hold the new sequence compatible key. Previously, the
79 GetKey() method would look in the underlying gdcmDictEntry.
80 - src/gdcmDocEntry.cxx:
81 -- constructor now copies the underlying DictEntry key, in the local
83 -- ::Print: displays the member Key, instead of the (group, element).
84 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
85 - src/gdcmDocEntrySet.h:xi
86 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
87 -- now has a new BaseTagKey member.
89 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
90 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
92 This poses the problem with the semantics of the following lines
93 LoadEntryVoidArea(0x0028,0x1201); // R LUT
94 LoadEntryVoidArea(0x0028,0x1202); // G LUT
95 LoadEntryVoidArea(0x0028,0x1203); // B LUT
96 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
97 to the long FIXME note for what the problem is. Nevertheless in
98 order to get things working the dicom dictionary was altered !
99 Please fix things urgently...
100 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
101 information), see above note on moving the member VoidArea. Nevertheless
102 the following entries previously correctly set as US are now inproperly
104 0028 1201 OW IMG Red Palette Color Lookup Table Data
105 0028 1202 OW IMG Green Palette Color Lookup Table Data
106 0028 1203 OW IMG Blue Palette Color Lookup Table Data
107 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
108 of gdcmDocEntry moved to gdcmSeqEntry.
109 * src/gdcmSeqEntry.cxx: STYLE.
111 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
112 * Test/TestAllEntryVerify.cxx minor fix and added comments.
114 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
115 * gdcmPython/testSuite.py: all the test suite in python is now moved
116 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
117 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
118 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
120 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
121 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
122 to avoid inclusion recursion until STL is reached.
123 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
124 mecanism. errno.h is not included in gdcm anymore.
125 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
126 (gdcmFormatError now inherits from gdcmFormatUnexpected).
128 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
129 gdcmData/TestAllEntryVerifyReference.txt
130 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
131 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
132 exception_on_error parameter.
133 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
134 - vtk/vtkGdcmReader.cxx changed accordingly,
135 - Example/*.cxx and Test/*.cxx changed accordingly.
137 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
138 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
139 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
140 enable_sequences removed from gdcmHeader constructor and dependencies.
141 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
142 * gdcmPython/demo/PrintHeader.py: dummy fix.
143 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
144 skip_shadow removed from gdcmHeader constructor and dependencies.
145 * Example/*.cxx and Test/*.cxx changed accordingly.
147 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
148 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
149 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
151 2004-07-21 Jean-Pierre Roux
152 * FIX Now, Parsing and Printing a DICOMDIR do work!
153 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
155 2004-07-20 Jean-Pierre Roux
156 * FIX Some brain damaged headers have Zero-Lenght fields
157 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
159 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
160 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
161 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
162 variable (instance of gdcmDebug) by a definition macro, and the instance
163 is now in static in the gdcmDebug class
164 * src/gdcmSQItem.h : (FIXME) remove an undefined method
165 * Test/PrintAllDocument.cxx : bug fix in the result of the test
167 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
168 * WARNING: ctest now depends more tightly on gdcmData. You should
169 check out gdcmData properly for things to run smoothly...
170 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
171 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
172 we need the pixels not be loaded in order to use the ValEntry
173 that displays position and size).
174 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
175 This is a C++ based equivalent of gdcmPython/testSuite.py that should
176 be deprecated. If you have any doubts about the advantages of a
177 modern scripting language (read Python) versus grass root C++ (i.e.
178 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
179 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
180 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
181 Anyhow, consider documenting the gdcmData images in
182 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
184 * Test/CMakeLists.txt:
185 - now uses TestAllEntryVerify.cxx
186 - specific comments on oldACR00001.ima (now renamed in gdcmData
187 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
188 gdcmData/TestAllEntryVerifyReference.txt
191 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
192 * src/*.[h|cxx] : typedef clean up
193 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
194 - TagKey renamed to gdcmTagKey (for external usage)
195 - VRKey renamed to gdcmVRKey (for external usage)
196 - removal of typedef duplication.
197 - Removed all unecessary inline keyword from class inline definitions.
198 - Some method|function(void) declarations replaced with method|function().
199 * src/jpeg/libijg12/jdhuff12.c:
200 - printf polluting ctest removed.
201 - TAB removal for comminting
203 - TestAllReadCompareDicom.cxx: added a test that compares all the
204 images in gdcmDataImages.h with corresponding images in
205 gdcmData/BaselineDicom/. When baseline images are not present
206 this test creates them.
207 Note: we need to validate each reference image, but before that
208 I'd like to rename them with a more explicit name...
209 - CMakeLists.txt: changed accordingly.
210 * Example/*.cxx: examples now only include gdcm.h (as opposed to
211 including each header needed).
213 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
214 * Test/*.cxx and Example/*.cxx: moved some examples away from the
215 test suite to the Example directory. Are concerned:
220 - TestWriteSimple.cxx
221 * Test/CMakeLists.txt: added some comments on reasons for black listing
222 image gdcmData/oldACR00001.ima
224 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
225 * Test/CmakeList.txt: removed the following from black list (to be coherent
226 with removal from gdcmData):
227 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
228 - gdcm-MR-PHILIPS-16.dcm
230 Added the following because after last cvs update, they cause
231 ctest -R TestReadWriteReadCompare
233 - gdcm-MR-SIEMENS-16-1.acr
235 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
236 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
237 new comments in this file) we temporarily (sigh) move to a weaker
239 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
240 we don't need to black list the following images anymore:
241 - 8BitsUncompressedColor.dcm
243 - US-PAL-8-10x-echo.dcm
244 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
245 fixes and the beautified code ;-)
246 This fixes the bug introduced in version 1.42 (when beautifying)
247 that made the parsing of 8BitsRunLengthColor.dcm unproper.
248 Note: ctest was blind to this bug (this means we need to still
249 improve the test suite). The bug could be detected by using
250 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
252 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
253 and by displaying the (garbage) produced file temp.XDCM...
255 2004-06-29 Jean-Pierre Roux
256 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
257 - replace by uggly but working old code :-(
258 A lot of things should be OK again.
259 It's really urgent to have a test suite that *tests*,
260 to prevent Frog's beautifying sessions to break all the stuff
261 (twice, withing a fortnigh ...)
263 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
264 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
265 redundancy) to added Test/TestReadWriteReadCompare.cxx
266 * Test/CmakeList.txt: because the compare test of
267 Test/TestReadWriteReadCompare.cxx fails, the following images are
268 black listed: - 8BitsUncompressedColor.dcm
270 - US-PAL-8-10x-echo.dcm
271 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
272 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
273 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
274 and ad-hoc kludge. This kludge is now removed, and on encountering
275 such an image (OB field brain damaged) we set errno. Then in
276 ::FindDocLength() we "fix" the length as being ALL what remains
277 in the file (until EOF). We then proceed, hoping for the best...
278 This fixes a SegFault in ShowDicom when trying to write such an
280 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
281 (because TestWriteRead breaks on it, after a non conformal commit?).
282 ctest now runs properly, except for MakeDicomDir (which was allways
283 broken) and the Python related stuff (still not fixed).
285 2004-06-24 Jean-Pierre Roux
286 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
287 FIX : Test/TestReadWrite now iterates on all the file names
288 (instead of infinite loop)
289 ENH : Test/TestWriteRead now iterates on all the file names
291 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
292 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
294 2004-06-24 Jean-Pierre Roux
295 FIX : - now Write drops LUT Descriptors and LUTs (if any)
296 when SamplesPerPixel =3
297 - now Write is no longer confused by
298 'BitsAllocated = 12" and 'BitsStored=12"
299 - "UN" value representation Elements are now written correctly
300 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
301 ENH : - now gdcmHeader has its own Write methods
302 (in order to split the job that has not to be done
305 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
306 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
307 loop on the same image until memory went out.
308 Note: this means we still have gobs of memory loss in PrintDocument
309 * src/gdcmDocument.cxx: fixes problem on parsing on file
310 gdcmData/16BitsJpegLosslessGrayScale.dcm.
312 2004-06-24 Jean-Pierre Roux
313 FIX : Write - All the Sequences and Sequence Item are now written
314 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
315 is added a the end, when necessary.
316 - A lot of brain-damaged images, that were read correctly are
317 now written correctly
318 - length compatible BinEntry are now loaded correctly
319 (even for odd groups)
320 Note : only Explicit Value Representation was checked.
321 (question : is implicit VR really necessary for gdcm ?)
323 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
324 * DEVELOPPER: added a proposition of coding style.
325 * src/gdcmDocEntry.h: removed every inline declaration (for test of
328 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
329 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
330 Use the gdcmDocEntry::Print() and Write() instead.
331 * src/gdcmDocument.cxx: bug fix.
333 2004-06-22 Jean-Pierre Roux
334 FIX : gdcmDocument.cxx
335 - Now we do recognize the JpegLossLess format (there was a misstyping in
336 code 'beautyfication' :-(
337 - Now we automaticaticaly load the Luts, if any
339 2004-06-22 Jean-Pierre Roux
340 In order : to write Sequences, whatever their imbrication level,
341 : to allow user to create his own Sequences
342 a lot of modif where necessary (adding, moving, or virtualising methods)
344 WARNING : save your own sources *before* cvs up !
347 ADD virtual void Write(FILE *fp, FileType filetype);
350 ADD virtual void Write(FILE *fp, FileType filetype);
351 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
354 ADD virtual void Write (FILE *fp, FileType filetype)=0;
355 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
356 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
357 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
358 ADD std::string GetEntryByName(TagName name);
359 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
361 std::string vr = "unkn",
362 std::string fourth = "unkn",
363 std::string name = "unkn");
364 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
365 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
366 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
367 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
368 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
369 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
370 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
371 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
374 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
375 ADD virtual std::string GetEntryByName (TagName tagName);
376 ADD virtual std::string GetEntryVRByName (TagName tagName);
377 REM virtual bool Write(FILE *, FileType);
378 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
379 FILE *_fp, FileType type);
380 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
381 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
382 REM virtual bool WriteEntries(FILE *_fp,FileType type);
383 REM virtual std::string GetEntryByName (std::string tagName);
384 REM virtual std::string GetEntryVRByName (std::string tagName);
385 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
386 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
387 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
389 std::string vr = "unkn",
390 std::string fourth = "unkn",
391 std::string name = "unkn");
392 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
393 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
394 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
395 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
398 ADD virtual void Write(FILE *fp, FileType filetype);
401 ADD virtual void Write(FILE *fp,FileType filetype);
404 ADD virtual void Write(FILE *fp, FileType filetype);
405 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
406 REM std::string GetEntryByNumber(guint16 group, guint16 element);
407 REM std::string GetEntryByName(TagName name);
410 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
412 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
413 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
414 The default constructor invoked by the line
415 gdcmHeader *f1 = new gdcmHeader( header );
416 was gdcmHeader::gdcmHeader(bool) instead of the expected
417 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
418 Hence the parsing wasn't executed... See also below.
419 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
420 as explicit constructor didn't do the trick to fix the above problem.
421 Could anyone explain why ?
422 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
423 properly calls gdcmValEntry::Print() (that was weed out from
424 code related to gdcmBinEntry).
426 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
427 * In order to fix memory leaks:
428 - Test/TestWriteSimple.cxx: added cleaning of free store through
430 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
431 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
432 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
433 (through the call to ::AddDicomDirMeta()) or the destructor
434 would crash when deleting uninitialized ::metaElems].
435 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
436 - src/gdcmDocument.cxx:
437 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
439 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
440 was causing memory leaks.
441 - src/gdcmSQItem.cxx:
442 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
443 cleanly handled with polymophism: sorry but my milage is low).
444 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
445 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
446 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
447 This avoids SegFaulting.
448 - src/gdcmSQItem.h: coding style.
450 - Test/TestWriteSimple still severely sucks. The output image content
451 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
452 damaged when displayed with vtkgdcmViewer.
453 - on memory leaks: TestWriteSimple leaks really less (see entry
454 of 2004-06-18 in Changelog file for the call to valgrind).
455 - on segfaults: ctest now passes all the tests but one (no more
457 * Erroneous leading white fix:
458 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
459 white[s] (as opposed to from >> xxx, that removes it [them].
460 - src/gdcmTS.cxx: ditto.
461 - gdcmPython/testSuite.py: dirty related kludge removed.
462 * src/*: remaining references to gdcmParser removed.
463 * src/*[cxx|h]: added copy[way]left header.
466 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
467 * In order to fix writing of dicom files:
468 - Test/TestWriteSimple.cxx: a simpler example of writing.
469 - Test/CMakeLists.txt changed accordingly.
470 - src/gdcmDocument.cxx:
471 -- The destructor now recursilvely removes potential sequences.
472 -- Bug fix in ::IsJPEG2000()
473 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
474 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
476 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
477 to only declared) and build on top of
478 ::GetDocEntryByNumber(guint16, guint16).
479 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
480 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
481 for usage in destructor and treatement of promotion in
482 ::ReplaceOrCreateByNumber().
483 - src/gdcmSQItem.cxx: destructor should better handle his job.
484 Test/TestWriteSimple now runs (or at least it DOES something).
485 * We can now start hutting memory links. A good starting point is:
486 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
487 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
488 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
490 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
491 * Valgrind note: after Mathieu Malaterre teached me how to read
492 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
494 Using gcc, you can force the STL to use malloc and to free memory as
495 soon as possible by globally disabling memory caching.
496 With 3.2.2 and later, you should export the environment variable
497 GLIBCPP_FORCE_NEW before running your program.
498 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
499 simply vanish (it is still not clear to me, whether this means that
500 STL std::string leaks or if valgrind believes it leaks...).
501 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
502 running bin/gdcmTests makeDicomDir):
503 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
504 - Test/makeDicomDir.cxx now properly traps empty lists and returns
506 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
507 SegFaulting (I drowned in DicomDir related code when trying to
508 understand why the list is empty...).
509 * src/gdcmDocument.h: first BSD license header try.
510 * Doc/License.txt added.
512 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
513 * src/gdcmDocument.[h|cxx]:
514 - Clean up of the Transfer related predicates. They are now all based
515 on new method isGivenTransferSyntax, that (should) handle properly
517 - general clean up, simplification, and coding style.
518 - Specific clean up of Parse7FE0() (umproperly named actually).
519 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
521 2004-06-14 Jean-Pierre Roux
523 - fix the display of Sequence Delimitor (SQDepthLevel pb)
524 - fix the display of SQItem ordinal number
525 - add the GetSQItemByOrdinalNumber method
526 - remove some useless never written private methods
528 2004-06-14 Jean-Pierre Roux
530 - adding a constructor taking a gdcmDocEntry as an input param
531 - ReplaceOrCreateByNumber now returns :
532 a gdcmBinEntry * if a Binary (void *) value is passed as a param
533 a gdcmValEntry * if a string value is passed as a param
535 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
536 according to the param type (no longer sets a gdcmDocEntry)
537 - GetValEntryByNumber, GetBinEntryByNumber added
538 - NewValEntryByNumber and NewBinEntryByNumber added
540 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
542 - GetSQItemNumber and SetSQItemNumber added, to provide
543 a (relative) Item identier inside a given Sequence
544 \warning : some pb remaining around this number
546 - AddEntry now takes the Item Number as a param
548 - adding a constructor taking a gdcmDocEntry as an input param
550 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
551 * Memory leak hunt with the following command:
552 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
553 --show-reachable=yes gdcmTests PrintDocument
554 It looks like many (all?) leaks are due to the STL (or a bad usage
555 of the STL. The lines producing the leaks now have a comment with
556 a "MEMORY LEAK" tag: you can retrieve them with
557 grep "MEMORY LEAK" src/*
558 Here are two typical examples which I can't help fixing:
563 char * test = "babo";
564 name = test; //// <--- valgrind detects 960 bytes lost in
565 //// call to std::string::operator=(char const*)
566 name.clear(); //// Doesn't help !
574 std::cout << "Type a bunch of characters followed by RETURN: ";
575 getline(std::cin, line); //// <--- valgrind dectects a loss
576 //// of 1320 bytes in call to
577 /// std::basic_istream<>& std::getline<>
583 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
584 * src/gdcmHeader.[cxx|h]:
585 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
586 and related, moved away to gdcmDocument.
587 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
588 the corresponding protected accessors of inherited class
589 gdcmDocument, removed ! As a consequence gdcmFile had to be
590 declared friend of class gdcmDocument (see below).
591 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
592 - Clean up of undefined or unused methods.
593 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
594 account the changes to gdcmHeader.h).
595 * src/gdcmDocument.h:
596 - gdcmFile is now a friend class (in order to take into account the
597 changes to gdcmHeader.h).
598 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
599 (see changes to gdcmHeader.h).
600 - Accessors (reading on the form GetEntry*) are now public.
601 - Clean up of undefined or unused methods.
602 * src/gdcmDocument.cxx:
603 - adaptation to changes to gdcmDocument.h
604 - ::OpenFile now writes a verbose message when file cannot be opened.
605 - some std::string properly set to VRKey
606 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
607 references to gdcmDocument.
608 * Test/TestFindTags.cxx: changed accordingly to above changes.
609 * gdcmPython/testSuite.py: adapted to renaming of acr files in
610 cvs repository gdcmData.
612 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
613 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
614 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
615 conflicts with gdcmValEntry::voidArea.
616 * src/gdcmValEntry.cxx: unmatching comment wiped out.
617 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
618 Value representation between StringRepresentable and BinaryRepresentable.
619 * src/gdcmDocument.cxx:
620 - method ParseDES: proper indentation restored and usage of
621 gdcmVR::IsVROfGdcmStringRepresentable wired in.
622 - method LoadDocEntry: the fingerprint left in the SetValue() of
623 unloaded entries (length > MaxSizeLoadEntry) had curiously been
624 removed. Reverting to previous code segment with the proper
625 dynamic_cast< gdcmValEntry* >.
626 Note: this was (partially) breaking the python test suite
627 (gdcmPython/testSuite.py) that made usage of the above
628 fingerprint to check presence of "Pixel Data".
629 * src/gdcmDocEntry.h: coding style.
630 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
631 now taken into account.
632 * gdcmPython/gdcm.i: adaptation to the new internal representation
633 of gdcm (exit gdcmParser, hello gdcmDocument).
634 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
636 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
637 anymore, but instead prints the loaded Python dictionary.
638 * .... alas, the python testSuite is still broken.
640 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
641 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
643 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
644 * src/gdcmUtil.h : export methods
646 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
647 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
649 * Initial addition of automatic python testing
650 * Initial addition of automatic image comparison
652 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
653 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
654 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
656 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
657 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
658 * Test/ShowDicom.cxx : bug fix for msvc compilation
659 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
661 2004-05-04 Jean-Pierre Roux
662 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
663 new concepts (and new classes) :
664 a 'gdcmDocument' is composed of a set of Doc Entries, that are
665 - elementary gdcmDocEntries (former gdcmHeaderEntries)
666 - Sequence Doc Entries (gdcmSeqEntries)
667 a Sequence is composed of Items.
668 Each item is a set of Doc Entries (this is recursive)
669 The non uniqueness of the 'Dicom tag' is due to this recursivity
670 (never taken into account)
671 Our unability to add a new 'entry' in the header
672 at the proper location (neither in the H-Table (map or multimap),
673 nor in the Chained List is also due to this recursivity.
674 Don't try, right now, to use/modify/compile these new sources :
676 We just commit all the stuff, 'as is', in order not to loose it.
678 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
679 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
681 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
682 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
683 file prefix (SetFilePrefix)
685 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
686 * Add a new test: ShowDicom, for now this is just the c++ version of
687 checkRead.sh, later it will be able to compare the image read against a
689 * Replace the DEBUG on the stack with a global entry in cmake interface:
690 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
692 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
693 * Add an example subdir, with a real example on how to read + write a
696 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
697 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
698 * Doc/CMakeLists.txt: the main page is now properly differentiated
699 between the developper and user version.
700 * Doc/doxygen.config.in: dropped search related obsolete flags
701 * src/gdcmParser.h, gdcmHeader.h: doxygenation
703 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
704 * DEVELOPPER: added some helpfull comments for compile/test/install
707 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
708 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
709 src directory, now generated in the build dir.
710 2. Tests as mentionned smarter
712 4. Add a new method in gdcmDict that return the PubDict by name
713 this is interesting for 3rd party lib like ITK,
714 where we could set the institution name / patient name...
716 * ENH: 1. Now the test suite is working for real
717 2. All binaries are now output in the gdcm-bin directory
718 (this was not true before)
720 2004-04-28 Jean-Pierre Roux
721 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
722 SeQuence indented printing of Dicom Header.
723 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
724 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
725 Computation of SQDepthLevel is now part of gdcmHeader constructor
726 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
727 tree-like structure of a Dicom Header.
728 * FIX Test code cleaning
730 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
731 * ENH: Adding automatic testing
732 1. Need a DartConfig.cmake to submit to public
733 2. Add a test driver gdcmTest.cxx
734 3. gdcmTestMain, an helper for the main test driver gdcmTest
735 4. Files in Test don't have a main anymore, this becomes interesting
736 when we add more and more tests, thus dsw don't have to load
738 * ENH: Adding a GDCM_DATA_ROOT for testing
739 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
740 one file instead of seven + some small cleanup
742 2004-04-22 Jean-Pierre Roux
743 * ENH Minor changes to the Print() methods.
744 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
745 Header printing. Example given with :
746 > PrintHeader fileName 2 new
747 (SQ based tree-like structure still to be done for the Header ...)
749 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
750 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
751 1. I have added some unsigned where needed
752 2. Some function parameter not used -> (void)
753 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
754 4. g++ don't like character '\' in comment
755 5. #define jpeg_create_decompress jCreaDecompress
756 this really need to be fixed
757 6. virtualize destructor of gdcmObject ... leakage
758 7. sscanf(g->first.c_str(),"%x",&gr_bid);
759 this also really need to be fixed
760 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
761 remove compression file
762 (as we only do decompression, right ?)
763 * ENH: Change malloc/calloc/free with c++ equivalent
765 2004-04-21 Jean-Pierre Roux
766 * FIX gdcmHeaderHelper::GetXSpacing
767 when a single value is found (bug ?), xpacing is now
768 defaulted to yspacing
770 2004-04-19 Jean-Pierre Roux
771 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
772 * ENH add parameters :
773 bool exception_on_error = false,
774 bool enable_sequences = false,
775 bool ignore_shadow = false
776 to the gdcmFile constructors to be full gdcmParser compliant
777 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
778 to allow reading of PAPYRUS 3.0 files
780 2004-04-06 Jean-Pierre Roux
781 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
783 2004-04-02 Jean-Pierre Roux
784 * ADD : Test/checksequence.sh, for a general recap on SQ pb
785 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
786 for Philips spurious Tag fffe|0000 while rewritting Dicom files
788 2004-03-30 Jean-Pierre Roux
789 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
790 for ACR file, written out as DICOM files (hope so...)
792 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
793 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
794 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
795 moved to base class gdcmParser and only the specialisation is kept
797 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
798 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
799 already does the job.
800 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
801 (to be consistent with gdcmParser::WriteEntries).
803 2004-03-30 Benoit Regrain
804 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
805 upate of the object's instance. It's passed to 2 in the unfavorable
806 case : one in the ExecuteInformation, one in the ExecuteData
808 2004-03-29 Jean-Pierre Roux
809 * ENH : Check on file type to be written moved
810 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
811 * FIX : gdcmObject::ResetBoundaries now stops properly
812 when end-of-list is reached
813 : gdcmVersion modified (as Benoit Regrain asked)
815 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
816 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
817 * src/gdcmUtil.cxx: added forgotten iostream include.
818 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
819 equivalent to ExplicitVR in existing code).
821 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
822 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
823 now contains all the gdcmGlobal related code.
824 * minor coding style and doxygenation changes.
826 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
827 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
828 now contains all the Debug related code.
829 * minor clean-up of includes in src/*.cxx
830 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
831 CreateCleanString) removed.
832 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
833 * Doc/DoxyMainPageUser.txt added.
834 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
835 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
838 2004-03-24 Jean-Pierre Roux
839 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
841 2004-03-23 Jean-Pierre Roux
842 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
843 big endian made volumes
844 * ENH Now gdcmParser constructor and destructor are protected to forbid
845 end user to instanciate class gdcmParser
846 (only gdcmHeader and gdcmDicomDir are meaningfull)
848 2004-03-22 Benoit Regrain
849 * FIX : src/gdcmDicomDir.cxx : make windows compilable
850 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
851 gdcmSerie to gdcmDicomDirSerie
853 2004-03-19 Jean-Pierre Roux
854 * ENH Now the tree-like structure describing a DICOMDIR comming from
855 an already existing DICOMDIR file is consistent with
856 the home-made tree-like structure build ex-nihilo
857 or build from the files held (recursively) in a Directory
858 functions gdcmDicomDir::CheckBoundaries()
859 gdcmObject::SetBoundaries() added
861 2004-03-17 Jean-Pierre Roux
862 * REM (Eric Boix bug) : removal of meaningless
863 gdcmDicomDirImage::NewImage function.
864 * FIX now file names and directory name are written properly in the
866 * FIX now gdcmDicomDir constructor may be call without any trick
869 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
870 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
871 of gdcmDicomDirImage::NewImage as empty function.
873 2004-02-28 Jean-Pierre Roux
874 * ENH add gdcmDicomDir:NewPatient
875 add gdcmDicomDirPatient:NewStudy
876 add gdcmDicomDirStudy:NewSerie
877 add gdcmDicomDirSerie:NewImage
878 to allow making gdcDicomDir object.
879 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
880 (as opposite to the gdcmHeader chained list)
882 2004-02-11 Benoit Regrain
883 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
884 when using from python
886 2004-02-10 Benoit Regrain
887 * FIX : bug fix in the gdcmDirList for the recursivity in directories
888 * FIX : in gdcmDicomDir when the directory is empty
889 * ENH : add callback and methods to get the progression of dicomDir
892 2004-02-06 Jean-Pierre Roux
893 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
894 - GDCM_META added to gdcmDicomDirType
895 - class gdcmMeta created
896 * ENH : - A brief summary is now displayed at the beginning of
897 'testDicomDir' to help disaster magnitude estimation
898 * REM : Now useless Test/explDICOMDIR.cxx
900 2004-02-05 Benoit Regrain
901 * ENH : add methods in gdcmObject to get the hash table or the list of
903 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
904 * FIX : wrapping python for TagHeaderEntryHT
906 2004-02-04 Benoit Regrain
907 * FIX : even length for some strings when writting the dicom dir
908 * FIX : sort the images in the dicom dir
909 * FIX : Bug fix for python use of dicom dir
910 * ADD : a python demo
912 2004-02-04 Jean-Pierre Roux
913 * FIX : Final solution (?) for icone embedded images
914 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
915 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
916 add groups 6002, 6004, 6006, to allow 'clean' parsing of
917 gdcmData/gdcm-MR-SIEMENS-16.acr1
918 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
919 to make full checking easier
921 2004-02-04 Benoit Regrain
922 * FIX : WriteEntries : coding style & logic in parameters
923 * FIX : Set the elements to create the DicomDir in a dictionary file
925 2004-02-03 Benoit Regrain
926 * gdcmDirList : to parse a hard drive directory in recursive (or not)
927 * gdcmDicomDir : add the load of directory
928 * Bug fix and print add-on
930 2004-02-03 Jean-Pierre Roux
931 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
932 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
933 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
934 * FIX gdcmParser.cxx : 'group length' elements are now considered
935 as integers, even for shadow groups, when file is Implicit VR
937 2004-02-02 Jean-Pierre Roux
938 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
940 of the last synonym :-(
941 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
943 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
944 * FIX taking into account the possible 7fe0,0010 multiplicity
945 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
946 to allow removal of references to 7fe0,0010, to deal with
947 ACR-NEMA images, when 0028,0200 is meaningfull
949 2004-01-31 Jean-Pierre Roux
950 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
951 no longer writes 'Un' on disk
952 * FIX SQ elements with actual length are now dealt with corectly
953 * FIX gdcmFile::WriteBase make the difference, for color images, between
954 the length (for Palette expanded images)
955 and Raw Length (non expanded image + Palette)
956 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
957 (that broke Write). Replaced by UL.
958 Aware user will reload the field if he
959 thinks it's necesssary
961 2004-01-30 Jean-Pierre Roux
962 * gdcmParser::CheckSwap() now defaults the filetype to ACR
963 when 'dirty Acr' is found, to be compliant with the new
964 IsReadable() methods.
966 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
967 (no DOUBLE images in kosher DICOM,
968 but so usefull for people that miss them ;-)
970 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
971 DICOMDIR related utilities (not checked as Windoze compliant)
973 2004-01-28 Jean-Pierre Roux
974 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
976 2004-01-27 Jean-Pierre Roux
977 * gdcmParser constructor has a new boolean param,'ignore_shadow',
978 to allow skipping the shadow elements, to save memory space.
979 The TRUE value for this param has to be used
980 with a FALSE value for the 'enable_sequence' param.
981 ('public elements' may be embedded in 'shadow Sequences')
982 * gdcmHeader methods now deal with 'embedded icones images' in the header
983 (even when an 'icone image sequence' is announced by the
984 element (0x0088,0x0200), but there is NO icone at all ...
986 * gdcmHeader sometimes Image Location value doesn't follow
987 the supposed processor endianity (see gdcmData/cr172241.dcm).
990 * gdcmHeader add the method
991 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
992 to get *all* the Header Entries with the same tag.
993 GetHeaderEntrySameName is probabely *useless*
994 (no meaning : Name is *not* an identifier within the Dictionnary)
996 2004-01-26 Benoit Regrain
997 * Bug fix in the print of hexadecimal representations. Remove long fields
998 in the print and add a third level of print to print them
1000 2004-01-23 Benoit Regrain
1001 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1002 * Bug fix on test suite after remove the strip made on not string fields
1003 * Split the IsReadable method between gdcmParser which test that the file
1004 is dicom and gdcmHeader which test that it's an image file
1006 2004-01-22 Benoit Regrain
1007 * DicomDir : clean code, add methods, set variables in protected or private
1008 * gdcmUtil : bug fix for the clean string method
1010 2004-01-19 Benoit Regrain
1011 * Add the use of shadow dictionaries
1012 * bug fix and coding style
1014 2004-01-19 Benoit Regrain
1015 * src/gdcmFile.cxx : bug fix concerning the close of file
1016 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1017 * Add the update of header entries using the shadow library
1019 2004-01-19 Benoit Regrain
1020 * removal of file gdcmHeader2.cxx
1021 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1022 inheriting from gdcmParser. This split is to prepare the integration
1023 of dicom dir parsing
1024 * bug fix under python
1026 2004-01-16 Jean-Pierre Roux
1027 * REM removal of class gdcmHeaderEntrySet
1028 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1029 * ADD add file gdcmHeader2.cxx
1030 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1032 2004-01-15 Benoit Regrain
1033 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1034 entries created while parsing the header. Thus, they will be destroyed
1035 when the gdcmDictSet will be destroyed
1036 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1039 2004-01-15 Benoit Regrain
1040 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1041 made a fatal error because of the memory release at the end of program.
1042 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1043 some memory and vtk seems to have some problems with that.
1044 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1046 2004-01-14 Benoit Regrain
1047 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1048 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1049 * src/*.[h|cxx] : make changes due to class name changes
1050 * gdcmPython/demo/*.py : bug fix due to method names
1052 2004-01-13 Benoit Regrain
1053 * src/*.[h|cxx] : coding style
1054 * vtk/*.[h|cxx] : coding style
1056 2004-01-13 Benoit Regrain
1057 * gdcmPython/testSuite.py : test the readable flag of file for tests
1058 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1059 It's lied to the stl compilation by MSVC (windows, always windows...)
1060 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1062 2004-01-12 Benoit Regrain
1063 * src/*.h : add comments
1064 * src/gdcmDictSet.h : set the method BuildDictPath in public
1065 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1066 directly setted in the source code
1067 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1070 2004-01-09 Benoit Regrain
1071 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1072 * setup.py : use a reference to gdcmVERSION
1074 2004-01-07 Benoit Regrain
1075 * Modification to compile with the distutils.
1078 2003-12-10 Benoit Regrain
1079 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1080 can use a gdcmHeaderHelper to load datas
1081 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1082 made in the source code
1084 2003-12-10 Benoit Regrain
1085 * Update Windows projects and .cvsignore files
1087 2003-11-12 Jean-Pierre Roux
1088 * ENH gdcmHeader constructor has one more parameter (default value : false)
1089 that allows the user to 'go inside' the SeQuences only
1091 gdcmElValSet:Print takes it into account
1093 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1094 * ENH: Update gdcmPython/CMakeLists
1095 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1096 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1098 2003-11-10 Jean-Pierre Roux
1099 * FIX : gdcmHeader::LoadElements is now based
1100 on the ListTag listElem member,
1101 not longer on the TagElValueHT tagHt member
1102 * ENH : PrintPubElVal shows (temporarily) both results,
1103 with the tagHt member and the listElem member.
1104 (it's easier to 'see' the problems when using Printheader)
1106 * FIX : old private member LgrElem is now splitted into
1107 ReadLength : Length actually found on disk (updated only
1108 if bug fixing is necessary), for internal
1110 UsableLength : Updated by FixFoundLength, to fix a bug
1111 or to allow Parser going on.
1112 Will allow to re-write a kosher header when a SeQuence
1113 with a length (not 0000) is found
1114 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1115 because gdcmElValSet::Add does not update ListElem
1118 2003-11-07 Jean-Pierre Roux
1119 * FIX misstyping in Transfert Syntax name table
1120 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1121 when they have an actual length (not 0000 nor FFFFF)
1122 (Nobody should care of it, but DICOMDIR explorers)
1124 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1125 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1127 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1128 * ENH: vtkGdcmReader now supports LUT !
1129 (vtkgdcmViewer for now is not able to use them though)
1131 2003-11-05 Jean-Pierre Roux
1132 * in testSuite.py : new files names for checking the package
1133 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1134 that returns the pixel area size to the *aware* (vtk) user
1135 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1137 2003-11-05 Benoit Regrain
1138 * in testSuite.py : Modify the rules for checking the paths
1139 : Explicit error messages
1140 * in __init__.py : Related modif
1142 2003-11-03 Jean-Pierre Roux
1143 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1144 to be used by aware (vtk) users that want to manage
1145 LUT (and no to turn the PALETTE image into an RGB pixels one)
1146 * GetPixelType now returns 8U for 24 Bits images
1147 (vtkGdcmReader compliant)
1149 2003-10-31 Jean-Pierre Roux
1150 * Removal of *all* gdcmData images and add them again
1151 in order to loose the 'history' of un-anonymised images
1153 2003-10-31 Jean-Pierre Roux
1154 * RMV : removal of useless jBitsInJsample.h
1155 for both 8 and 12 Bits JPEG Lossy Libraries
1157 2003-10-31 Jean-Pierre Roux
1158 * ENH : Add the functions gdcmFile::GetImageDataRaw
1159 gdcmFile::GetImageDataIntoVectorRaw
1160 that act as GetImageData and GetImageDataIntoVector
1161 except the making of an RGB Plane from Gray Plane + LUT
1162 Intended to aware (vtk) users who know how to manage
1165 GetLUTRGBA return a R,G,B,A LUT if any
1166 lgrTotaleRaw gives the 'Raw' length
1167 GetImageDataRaw returns the gray Plane
1168 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1169 (They stay Grey, just like with other Dicom viewers :-(
1171 2003-10-30 Jean-Pierre Roux
1172 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1174 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1175 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1176 being coherents dicom files.
1178 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1179 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1181 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1182 * ENH: Two steps is necessary to please VC++ compiler...
1183 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1184 * ENH: Add include dir to medcon lib
1185 * FIX: only one function is being exported for now !
1186 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1188 2003-10-29 Jean-Pierre Roux
1189 * adding gdcmHeader::GetLUTRGBA
1190 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1191 --> Mathieu, the modif u're waiting for is not yet committed
1192 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1194 2003-10-27 Jean-Pierre Roux
1195 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1196 00191113.dcm DermaColorLossLess.dcm
1197 MxTwinLossLess.dcm RadBWLossLess.dcm
1198 * ENH: For version prior to vtkImageViewer2 -r 1.19
1199 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1201 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1202 * Removal of ido stuff in CMakeLists.txt
1204 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1205 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1206 * FIX: remove a call to ->Modified ... see comments
1207 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1209 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1210 * FIX: Problem with path for libvtkgdcmPython
1211 * ENH: Try adding a search script for python site-package
1212 * RMV: Remove some file from medcon lib that are not necessary
1213 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1214 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1215 * FIX: More pragma disable fro VC++,
1216 I don't think I break something as it is also disable in VTK/ITK.
1217 But it fasten debug compilation time.
1219 2003-10-23 Jean-Pierre Roux
1220 * gdcm now deals with 16 Bits Run Length Encoded images
1221 (they are compressed as 2 planes images,
1222 one for the high Bytes, the other for low Bytes)
1224 2003-10-22 Jean-Pierre Roux
1225 * Now CheckRead takes into account :
1226 - the bugged 'Leonardo' Siemens images
1227 - the XA images, sent thru the burning VPRO station
1228 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1231 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1232 * FIX: When copying a Makefile.am to CMakeLists.txt
1233 one should remove the '\'
1235 2003-10-22 Jean-Pierre Roux
1236 * in gdcmData adding a bugged 'Leonardo' Siemens image
1237 (wrong lengths in header)
1238 OK with gdcm, KO with the other viewers :-)
1239 * add a GE dlx XA image, thru the VEPRO burning station
1242 2003-10-21 Jean-Pierre Roux
1243 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1244 for a brutal checking of vtkgdcmViewer compliance
1246 2003-10-21 Jean-Pierre Roux
1247 * add the files for 'xmedcon' Jpeg Lossless library
1248 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1250 2003-10-21 Jean-Pierre Roux
1251 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1253 2003-10-21 Jean-Pierre Roux
1254 * garbage Siemens 'Leonardo' images dealt with
1255 (the patch is easy to remove)
1256 * cosmetic changes to avoid warnings
1258 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1259 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1260 no need to press 'r' now.
1262 2003-10-20 Jean-Pierre Roux
1263 * upgrade of checkRead.sh checkWrite.sh according
1264 to new Jpeg Lossless decompressor
1265 * add US.3405.1.dcm, a genuine RGB medical file ...
1266 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1267 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1269 2003-10-15 Jean-Pierre Roux
1270 * general anonymisation in gdcmData
1271 * adding the 'color files' from
1272 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1273 * adding some well knowed bugged-header images
1274 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1275 waiting for their inclusion in Python testsuite
1277 2003-10-15 Jean-Pierre Roux
1278 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1279 no longer seg faults when file is not found
1281 2003-10-14 Jean-Pierre Roux
1282 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1285 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1286 * TODO: *.in file to genereate a UseGDCM later
1288 2003-10-14 Jean-Pierre Roux
1289 * Some supposed-to-be Dicom Images have no preamble.
1290 OpenFile takes it into account
1291 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1292 * Missing elements added in dicomV3.dic
1293 (just to be affraid : have a look at
1294 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1295 and do it again next year ;->
1297 2003-10-13 Jean-Pierre Roux
1298 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1299 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1300 But there are NOT. It's fixed !
1302 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1303 * FIX: "jpeglib.h" was not found on VC++
1304 * FIX: vtkgdcm was not being installed
1306 2003-10-10 Jean-Pierre Roux
1307 * ENH : OpenFile closes the file if it *really* doesn't look like
1308 an ACR-NEMA / DICOM one.
1309 * FIX : testWrite no longer writes an empty file if the source file
1310 is not gdcm Readable
1311 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1314 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1315 * FIX: CMake generate now documentation
1316 * ENH: out of source doc build !
1317 * ENH: Generate both user and dev documentation
1318 * ENH: Should work on windows too
1319 * ENH: Only one doxygen config.in file is needed
1320 * FIX: make install should be ok now on ùnix plateform
1321 * FIX: PATH to dictionary was wrong (missing /)
1322 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1324 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1325 * vtkGdcmReader is now able to read rgb dicom file.
1326 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1327 * added a gdcmViewer to vtk test, use mouse to control
1328 window level & window width
1330 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1331 * CMake-ification of gdcm, we have now two build system
1332 * FIX: on cygwin Wsock32 doesn't exist
1333 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1335 2003-10-06 Emanuel Ollart
1336 * FIX : compilation process wad broken.
1337 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1339 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1340 * change gdcmViewer -> vtkgdcmViewer
1341 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1343 2003-10-06 Jean-Pierre Roux
1344 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1345 ( e.g : well known GE images with a wrong elem length,
1346 : Philips MRI Images with a wrong Huffman table)
1347 * still to be done : allow the reading of bugged LEONARDO Siemens images
1349 2003-10-03 Jean-Pierre Roux
1350 * Odd length strings are padded with '\0' (not with spaces,
1351 to remain compliant with already defined strings,
1352 like Transfert Syntax UID and others)
1354 2003-10-03 Jean-Pierre Roux
1355 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1356 to allow displaying RGB images (not only by affim ;-)
1358 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1359 * vtkGdcmReader is now able to read rgb dicom file.
1360 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1362 2003-10-03 Jean-Pierre Roux
1363 * A few nasty patches to allow the reading of a lot of nasty images
1364 ( e.g : well known GE images with a wrong elem length,
1365 : Philips MRI Images with a wrong Huffman table)
1366 * still to be done : allow the reading of bugged LEONARDO Siemens images
1368 2003-10-03 Jean-Pierre Roux
1369 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1371 2003-10-03 Jean-Pierre Roux
1372 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1373 to allow displaying RGB images (not only by affim ;-)
1375 2003-10-03 Jean-Pierre Roux
1376 * gdcmFile::GetImageDataIntoVector now
1377 - deals with MultiFrames MultiFragments Run Length Encoded files
1378 - deals with YcBcR (YBR_FULL) files
1379 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1380 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1382 (no sample found :-(
1384 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1385 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1386 Two reasons: - clear things
1387 - third parties acces gdcm through header files, so won't
1388 suffer anymore VC++ complains
1390 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1391 * add argv[1] in testvtkGdcmReader.cxx
1394 2003-09-24 Jean-Pierre Roux
1395 * The lines are now eigthy characters long.for
1396 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1398 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1399 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1400 char* to std::string. Thus, the use of strdup becomes useless. (see
1401 previous commis of Malaterre)
1402 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1403 before the last Malaterre's commit.
1405 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1406 * This commit should fix the Debug building under VC++, the problem
1407 was mainly a mixture of debug and release lib being loaded at startup.
1408 * I also remove a depency to a specific C function: strdup. Because I had
1409 to force the link to msvcrtd (whereas strdup is in libc).
1411 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1412 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1413 located in the gdcmCommon.h file. All use of reference of tha has been
1414 changed to now use the variable GDCM_UNFOUND.
1416 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1418 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1419 Dicom dictionary. The test suite can now be run again. Note:
1420 I'm note very happy with the " (RET)" changes. I believe this
1421 RETAINED comment should be dropped when parsing the dictionary.
1422 - PACKAGER corrected
1424 - AUTHORS updated and now in alphabetical order
1425 * Makefile.am now exports gdcm.dsw for Windoze users.
1427 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1428 * cygwin complains about missing std:: in subdir Test/
1430 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1431 * remove some methods that are now in gdcmHeaderHelper
1433 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1434 * vtkGdcmReader set spacing and origin correctly
1436 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1437 * Fix a few delete/delete[] mismatch
1439 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1440 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1441 interpretation to data given by gdcmHeader. For instance there are
1442 heuristics to get informations (look at different places).
1443 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1444 sorting DICOM images based on different strategies.
1445 * modified Makefiles accordingly.
1447 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1448 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1449 when building in debug mode
1450 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1451 src/win32/gdcmdll.dsp
1452 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1454 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1455 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1458 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1459 * src/win32/libgdcmjpeg12.dsp was not dos format
1460 * src/win32/libgdcmjpeg12.dsp :
1461 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1462 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1464 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1465 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1467 * src/gdcmFile.cxx : bug fix in affectation type
1468 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1469 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1470 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1471 symbols... future problem ?
1473 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1474 * src/win32/libgdcmijpeg12.dsp was missing
1475 * modified gdcm.dsw accordingly
1477 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1478 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1480 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1481 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1482 commit of JPR (before his hollidays to facilitate our work).
1483 * setup.py : bug fix in code. Modifications made while the last commit
1484 of JPR. The code hasn't been tested before the commit... it's so
1485 useless to make that (for best programmer that is JPR) !!!
1487 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1488 * tagged the current version as Version0_3 (i.e. version 0.3)
1490 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1491 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1492 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1493 * *.dsp : modifications to use new libgdcmijpeg8 library
1494 * setup.py : bug fix on VTKPATH variable
1495 * PACKAGER : adding all concerning windows
1497 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1498 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1500 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1501 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1502 test suite reported error.
1503 * PACKAGER file added (describes what a packager must do when
1504 packaging a new release).
1505 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1506 * configure.in: upgraded version number to 0.3.0
1507 * fixing build of rpm (through rpm -ta):
1508 - Doc/Makefile.am exports proper doxygen files
1509 - src/jpeg/libijg8/Makefile.am exports the include files.
1511 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1512 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1513 * src/gdcmHeader.h : formatting code
1515 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1516 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1517 We were obtaining error message from vtk. Now, creation of file list
1518 is made in an internal list to prevent this problem.
1519 Bug fix when output is empty.
1520 Bug fix in update of progress value. Previous commit for this was a bad
1522 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1524 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1525 * src/gdcmHeader.h : added method to get the file name
1526 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1527 files. Added method to remove all files on the input
1528 Added FIXME comment concerning the bad parsing of header made by
1529 ExecuteInformation method (in ExecuteData method)
1531 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1532 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1533 when using make instal.
1534 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1535 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1537 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1538 * setup.py : adding include dir of jpeg lib to compile all sources
1539 * */Win32/*.dsp : JPR fix for windows compilation
1541 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1542 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1544 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1545 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1547 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1548 * setup.py is again effective on un*x (takes into account the
1549 addon of the jpeg library)
1550 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1551 * Doc/Doxy* updated (includes above enhancements)
1552 * INSTALL now points to web documentation
1554 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1555 * src/gdcmHeader.h doesn't make unnecessary reference to
1557 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1559 * src/gdcm*.[cxx|h] :
1560 - to allow compilation with gcc 3.x
1561 -- clean up of STL usage (added explicit usage of std::)
1562 -- small fixes on exceptions.
1563 Note: linking not tested !
1564 - clean of doxygen comments to avoid warnings at documentation
1566 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1567 dependent convertion).
1569 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1570 * Clean up of previous JPR garbage commit (not even commented in the
1572 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1573 - moved all jpeg related files from src to src/jpeg/libijg8, with
1574 addition/modification of Makefile.am and configure.in.
1575 - the testSuite is still brain damage (not guilty).
1577 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1578 * WrapVTK.py : modifications to get correctly vtk source files to
1580 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1581 (FileName -> Filename)
1583 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1584 * vtk/vtkGdcmReader.[cxx/h]:
1585 - UpdateProgress method should now be effective
1586 - removed the limitation on having only images loaded (as opposed
1588 - when building a stack of images/volume, a lesser number of
1589 gdcmHeader and gdcmFile instances should be used (hopefully
1590 accelerating things).
1591 - when building a stack of images/volumes, files which are not
1592 loadable (wrong path-filename, wrong permissions on existing file,
1593 or file not parsable by gdcm) are replaced with a black image
1594 in the stack (for the caller to notice the problem).
1596 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1597 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1599 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1600 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1601 between standard library (std) and vtk library (problems are found
1602 under Windows... thanks Windows !)
1604 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1605 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1607 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1609 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1610 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1612 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1613 * When compiling with distutils (see setup.py) the C++ compiler is
1614 called with different flags than the default ones (with automake).
1615 In order to fix all those warning, I compiled gdcm with the command
1616 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1617 and went for warning fixes:
1618 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1619 up from unused variables.
1620 - vtk/vtkGdcmReader.cxx: potential bug fix.
1621 * src/gdcmHeader.h: Doxygen warning cleanup
1623 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1624 * gdcmPython/gdcm.i:
1625 - typemaps correction to take into account the systematic replacement
1626 of "using namespace std" with std:: prefix e.g. std::list,
1627 std::string... (cf changes of 2003-05-21).
1628 - gdcmGlob global variable of type gdcmGlobal (defined in
1629 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1630 exported to Python a as cvar.
1631 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1632 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1633 gdcmDictSet.GetPubDictTagNames() and
1634 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1635 C++ static methods).
1636 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1637 with the above changes.
1639 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1640 * setup.py, manifest.in : bug fix under linux
1642 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1643 * Modification of setup.py to compile vtk part too. Then, we have 2
1644 wrappers which must work with same distutils. For that, we have a
1645 generic distutils in distusiltsWrapping.py ; with :
1646 - build_extWrap class to wrap generically all extensions,
1647 - ExtensionWrap base class for all wrapping extension that contains
1649 - Wrapper interface which wrap sources
1650 + In WrapSwig.py we have extension and wrapper for Swig
1651 + In WrapVTK.py we have extension and wrapper for VTK
1652 * MANIFEST.in : modifications to consider vtk directory and new python
1653 files for compilation
1655 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1656 * Added python wrappers of vtkGdcmReader vtk class (see the
1657 source in vtk/vtkGdcmReader.cxx) :
1658 - vtk/Makefile.am now builds a library
1659 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1660 python library (as opposed to _gdcm.so wich are the python
1661 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1662 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1664 - configure.in has an additional flag --enable-vtk that needs
1665 to be set to enable compilation of vtk related code, that is:
1666 + vtk/vtkGdcmReader.so and
1667 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1668 + gdcmPython/vtkgdcmPython.so (see above)
1669 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1670 be read when compressed or when HighBit + 1 != BitsStored),
1671 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1672 the usage of the python wrapper of vtkGdcmReader vtk class.
1673 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1674 * src/*.[h] all occurences of stl classes are now prefixed with
1675 std::, and all occurences of "using namespace std;" where removed.
1676 This is to avoid pollution of global namespace in included files.
1677 Apparently vtk does not avoid this pitfall: when using both
1678 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1679 collision of various stl members (principally cout...).
1680 * gdcmPython/testSuite.py now cleanly removes temprory generated
1682 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1683 comply with above changes)
1685 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1686 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1687 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1688 vtk data structure (an image Flip was required).
1689 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1690 * cosmetic changes in documentation.
1692 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1693 * src/gdcmHeader.cxx: the constructor no longer exits when an
1694 unexisting file is given as argument.
1695 * The subdirectory Data (containing all the images used for the
1696 test suite) is not part of this repository anymore. A new module
1697 containing those images is now available at
1698 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1699 with the name gdcmData.
1700 All the python scripts (including the package initialisation file
1701 gdcmPython/__init__.py) were adapated to take this change into
1702 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1704 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1705 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1706 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1707 demo of the usage of this class.
1708 Compilation of this vtk part is only done when using the --enable-vtk
1709 at configure (or autogen.sh) stage.
1711 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1712 * More memory link related corrections and documentation fixes.
1714 - maximum info is obtained with a command of the form:
1715 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1716 --show-reachable=yes PrintHeader
1717 - the remaining reachable blocks seem to come from the STL
1718 allocation scheme through the usage of map and list. It looks
1719 like this memory cannot be freed but it is not a memory leak
1720 (in fact further invocation to the STL would recollect the
1721 unused memory allthough it cannot explicitely be freed).
1722 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1723 of displaying an image parsed with gdcm and displayed with VTK.
1724 Note: some images don't seem to work e.g.
1725 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1726 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1727 Allthough this weakens the semantics, it is a ditch attempt to
1728 make gdcm more thread friendly.
1730 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1731 * Memory link hunt (by using valgrind through the command
1732 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1733 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1734 gdcmHeader::_dicom_vr.
1735 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1736 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1738 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1740 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1741 * src/Makefile.am now exports all the necessary include files at
1745 * UpdateGroupLength replaced by new one
1748 * UpdateGroupLength re-written using H-Table
1749 (named UpdateGroupLengthNew untill checks are over)
1751 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1752 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1753 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1755 - gdcmHeader::GetPubElValSet removed.
1756 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1757 UpdateGroupLength, WriteElements, Write.
1758 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1759 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1760 carried the same semantics.
1761 - src/gdcmHeaderIdo.cxx changed accordingly.
1762 - gdcmFile::WriteBase now regroups all the codes from previous
1763 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1764 - enum FileType moved to gdcmCommon.h
1765 * src/gdcmHeader.cxx AddDefault trashed
1766 * gdcmGetXSize added
1767 * getimageDataSize now calls gdcmGetXSize
1768 * Test/*.cxx changed to agree with above changes
1770 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1771 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1772 (to avoid double call by end user).
1773 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1774 by end user, since gdcmHeader::gdcmHeader now handles it.
1776 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1777 * gdcm/Doc many doxygen changes:
1778 - Doxyfile now has two different versions, DoxyfileUsers that generates
1779 the html.users end users oriented documentation and
1780 DoxyfileDeveloppers that generates the html.developper developper
1781 oriented documentation.
1782 - README changed accordingly
1783 - requirement.txt removed (old design info moved to TODO).
1784 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1785 DoxyMainPage.txt, DoxyPython.txt provide more information.
1786 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1787 be updated by simply regenerating the docs with doxygen and copying
1788 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1789 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1790 all the tests in the form "if (<map>.count() >1)" were removed.
1791 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1792 ill-formed documentation sections.
1793 * src/gdcmHeader.cxx: ditto
1795 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1796 * setup.py fixed for un*x (needed macro for stdint.h)
1797 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1798 un*ces with sh-utils test utility.
1799 * gdcmPython/demo/test.py renamed to PrintHeader.py
1800 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1801 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1802 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1803 * src/gdcm*.cxx JPR's bad inclusion fixed.
1805 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1806 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1807 * gdcmPython/demo/test.py changed accordingly.
1809 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1810 * gdcmPython/Makefile.am fixed linking against libstdc++
1811 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1812 * Swig subdir (historical tests of swig version 1.3.17++) removed
1813 * Test/testChangeEntete.cxx some lines commented out in order to make
1815 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1816 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1818 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1819 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1820 hence the user doesn't need this explicit call.
1821 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1822 i.e. LoadElements() call removed.
1823 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1824 - src/Makefile.am declares the proper flag for g++.
1825 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1826 for adding user defined new tags.
1827 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1828 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1829 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1831 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1832 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1833 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1834 src/Makefile.am : the project should properly compile and install
1835 with the autotools, included the python wrappers part.
1836 * gdcm.spec.in : added a spec file for RPM packaging.
1838 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1839 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1841 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1842 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1843 to exported to the environement (see gdcmPython/testSuite.py
1845 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1846 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1847 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1848 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1849 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1851 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1852 * gdcmPython/__init__.py doesn't crash anymore when running in
1853 in InstallMode or PreInstallMode but with an environement given
1854 value of GDCM_DICT_PATH.
1855 * src/gdcmDictSet.[cxx/h] coding style.
1857 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1858 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1859 * src/gdcm.h general comments moved to TODO, and README
1860 * src/gdcm.h should now be seen as a user commodity (including it
1861 should suffice to fully use gdcm). It is nowhere including within
1862 any of the kernel files src/*.cxx and src/*.h.
1864 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1865 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1866 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1868 * src/gdcm*.cxx only include their corresponding include file
1869 (as opposed to gdcm.h)
1870 * gdcmPython/gdcm.i changed accordingly
1871 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1872 the autogen.sh generated "make snapshot" command to work.
1873 * autogen.sh removed history related references to crea package.
1875 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1876 * distutilsSwigCPlusPlus.py work around some swig portability
1879 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1880 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1881 was done in a last ditch attempt to get setup.py _really_
1882 operationnal. The python/gdcmPython layaout add the advantage
1883 of hidding away the python related distutils specific files
1884 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1885 Alas, the src directory was out of scope (i.e. it's relative
1886 position to setup.py was ../src) which made things impossible to
1887 handle (see previous version of python/setup.py). Crossing fingers...
1889 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1890 * python/setup.py now works on Un*x. (harder than I thougth)
1891 * python/distutilsSwigCPlusPlus.py can now have include files
1892 among the list of sources.
1894 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1895 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1896 * modifications in MSVC projects
1898 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1899 * As stated by the first lines of Test/ExceptionAndPython/README, it
1900 looks like we can move back to original usage of exception within
1901 src/gdcm* and hence remove the errno stuff that was introduced
1902 as a quick and dirty fixture of this problem (added to the TODO).
1903 * Doc/Doxyfile configuration file for Doxygen and corresponding
1904 README file for usage added.
1905 * Test/testWrite.cxx added. This new test comes from a split of
1906 test.cxx that is now reverted to its original purpous i.e.
1907 testing the proper parsing of a Dicom related file.
1908 testWrite.cxx concentrates on testing the IO part of gdcm.
1909 * Test/bug1.cxx (containing a bug on WIn32) added.
1910 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1911 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1912 whose purpose is to publish the content of the TagNames of the
1913 Dicom public dictionnary were not accessible without an
1914 instance of class gdcmHeader.
1915 - those methods are now static methods of gdcmDictSet and hence
1916 require no instances at all to be invocated.
1917 - within gdcmDictSet this change required to change some method
1918 to class methods (i.e. are now static) among which SetDictPath
1919 (renamed to BuildDictPath) and LoadDefaultPubDict.
1920 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1921 the above changes by calling the new method classes of gdcmDictSet.
1922 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1923 the above to be effective.
1924 * python/gdcmPython: in order to wrap properly the above changes
1925 for Python, swig version now needs to be > 1.3.17.
1926 * python/gdcmPython/Makefile fixed to adapt itself to new
1927 configure/make shema introduced by Johan Montagnat (thanks for the
1928 contribution). Alas this Makefile cannot be turned into a proper
1929 Makefile.am without some heavy changes in the configure.in
1930 (for python dectection).
1931 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1932 now avoids publishing the empty entries.
1934 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1935 * python/setup.py : bug fix concerning install under windows
1936 ExtraPath reused :-P
1937 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1939 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1940 * Dicts/dicomV3.dic : remove double spaces !!!
1941 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1942 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1945 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1946 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1947 method. Doxygenation.
1948 * src/gdcm.h clean up of JPR spurious comments.
1950 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1951 * python/distutilsSwigCPlusPlus.py now properly collects the
1952 shadow classes generated by "swig -c++" (gdcm.py in our case)
1953 when using "python setup.py install".
1954 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1955 reexports the working classes.
1956 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1957 by the classical C errno scheme. This is to prevent an obscure
1958 behavior of the python wrappers when importing wxPython.wx prior
1959 to gdcmPython (which ended up in an abort call). An illustration
1960 of this oddity can be found in the Test/ExceptionAndPython
1961 subdir (see the README file). This problem probably due to
1962 an combination of g++ and dynamic loading.
1963 * added Test/ExceptionAndPython (see above)
1965 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1966 * Changed the layout of the python part to avoid bloating main
1967 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1968 i.e. the distutils arsenal. All the python related stuff is
1969 again in a python subdir, but the package itself is now in
1971 * setup.py was cleaned up:
1972 - pythonIncludePath removed
1973 - python setup.py bdist target is now functional.
1974 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1975 collision with other packages). gdcmPython/demo/*.py changed
1978 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1979 * python subdir moved to gdcmPython (preparation of distutils packaging).
1980 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1981 distutils installer is operational.
1982 * - gdcmPython/__init__.py now properly loads the swig generated
1983 shadow classes (from gdcm.py).
1984 - gdcmPython/demo/*.py changed to import the package gdcmPython
1985 instead of gdcmPython/demo/load.py.
1986 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1988 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1989 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1990 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1991 entries within the associated public Dicom dictionary resp. the same
1992 information but sorted by the fourth field (PAT, IMG, DIR) of the
1994 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1995 are now in the "???" group.
1996 - python/gdcm.i changed accordingly,
1997 - python/demo/printGroupedPublicDict.py added, that gives an example
1998 of the above new functionalities in Python.
2000 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2001 * src/gdcm.h, gdcmHeader.cxx:
2002 - historic references to glib's g_malloc and g_free (#defined)
2003 were definitively removed.
2004 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2005 * src/gdcmElValSet.cxx:
2006 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2007 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2008 - GetElValue(string) renamed to GetElValueByName.
2009 - Added GetElementByName(string).
2010 * src/gdcmHeader.cxx: added
2011 - GetPubElValRepByNumber(guint16, guint16)
2012 - GetPubElValRepByName(string)
2013 - GetShaElValRepByNumber(guint16, guint16)
2014 - GetShaElValRepByName(string)
2015 - GetShaElValByNumber(guint16, guint16)
2016 - GetShaElValRepByName(string)
2017 - GetElValRepByNumber(guint16, guint16)
2018 - GetElValRepByName(string)
2019 - GetElValByNumber(guint16, guint16)
2020 - GetElValRepByName(string)
2021 * Doc/requirements.txt added.
2023 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2024 * Test/Makefile building now depends on the one of libgdcm.so
2025 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2026 pixel data) aware which enables finding the address (offset) of
2027 the pixel data of JPEG encoded DICOM files. This leaves only a single
2028 file in the testSuite whose pixel data address (offset) is unknown.
2029 * python/testSuite.py changed accordingly.
2031 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2032 * VC++ has some strong limitations when working with the STL, as stated
2033 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2034 "Also note that some STL containers (map, set, queue, list, deque)
2035 cannot be exported. [...]
2036 Some STL classes contain nested classes. These classes can not
2038 This is caused by a designed limitation that once a template
2039 class is instantiated, it can not be re-instantiated and
2041 Since our usage of map<> is ubiquitous in gdcm, this "designed
2042 limitation" of VC++ is a pitfall.
2043 Hence the Python wrappers of gdcm cannot be incrementally linked
2044 against the c++ dynamic library. The dirty but only workaround is
2045 to forget about incremental link of dynamic libraries and to generate
2046 the Python wrappers library with the inclusions of the underlying C++
2048 The following modifications concern this matter on Win32/VC++:
2049 - wrapping python correct with standalone wrapped dll (don't use separate
2050 dll under windows !!!!)
2051 - python21_d debug mode enabled (ask Frog how to use it :-)
2052 - NO problem with having an STL member of class for example string in C++
2053 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2054 - Python test of dcmlib in Python is ok under windows on a large set
2056 * removed glib references
2057 * typedef's inserted in gdcm.i for correct swig type management
2059 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2060 * python/demo/*.py load.py extracted from test.py. Added explore.py
2061 that only displays required tags and testAll.py that parses all
2062 the files of the testsuite without using unittest.
2063 * python/testSuite.py other additional test on new files added.
2064 * Data/* new test files added accordingly to the testSuite.
2065 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2066 the vr in the file differs from the one of the dictionary.
2068 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2069 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2070 values, but limits itself to values which are below a user specified
2071 size (by default 1024 bytes).
2072 * python/gdcm.i : elements not loaded (because their size is above the
2073 user specified treshold) are exported with their TagKey as key of the
2074 python dictionary. This enables the testsuite to make some checks
2075 on the unloaded elements (since we have their offset and size).
2076 * python/testSuite.py
2077 - now tests for the existence and proper value of the pixel data
2078 - two new examples added.
2079 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2081 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2082 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2083 aware. See the strategy comments in gdcmHeader::FindeLength().
2084 * Test/test.cxx now accepts a filename as first argument.
2085 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2086 * python/testSuite.py changed to integrate test on above files.
2088 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2089 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2090 the vr was also RET.
2091 * python/testSuite.py more tests added.
2093 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2094 * python/testSuite.py unittest test suite added (uses Data)
2095 * Data/* dcm and acr files for the test suite.
2096 * glib dependance removed from un*x version. We now use ISO C99
2097 7.18 Integer types (see stdint.h)
2098 - python/Makefile, src/Makefile src/gdcm.h
2099 * src/ when an explicit vr (like dicom files) suddenly poped an
2100 implicit element we use to mark the underlying DictEntry of the
2101 concerned ElValue with "Implicit". This strategy was damageable
2102 too the public or provite dictionaries, since some of their vr
2103 would be changed. Since Header::FindLength heavily relies on the
2104 detection by Header::FindVR of falsely explicit elements, I
2105 added an extra ImplicitVr member to ElValue (boolean).
2106 The rest of the changes we the necessary adaptations.
2108 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2109 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2111 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2113 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2114 * Adaptation for porting to VC++:
2116 o forced to use std namespace (for string to be known)
2117 o all class use __declspec export style on WIN32
2118 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2119 (in stdlib.h on Win32 but in std:: for gcc)
2120 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2121 variable GDCM_DICT_PATH.
2122 * src/gdcmHeader.cxx verbose comments made discrete.
2124 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2125 * python/gdcm.i: added a typemap that converts a C++ hashing table
2126 to native Python dictionary.
2127 * python/demo/test.py:
2128 - now uses the native dictionary for exploration of gdcmHeader.
2129 - takes an optional filename argument (the file to parse).
2130 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2131 PubElVals hashing table.
2132 * Dicts/dicomV3.dic removed error prone trailing spaces.
2134 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2135 * Python wrapping process moved away from src/Makefile to
2136 newly created python/Makefile (as well as gdcm.i)
2137 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2138 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2139 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2140 from the environement variable GDCM_DICT_PATH (when existing).
2141 * src/gdcmDict::GetTag bug fix.
2143 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2144 * Straightforward temporary fixes for swig to build the python wrappers.
2145 src/Makefile now has a python working entry [by working we mean
2146 that we can import de shadow classes without errors].
2148 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2149 * hashtest.cxx removed (since allready in Test)
2150 * src/gdcmlib.h renamed to src/gdcm.h
2151 * src/dcm.i renamed to src/gdcm.i
2152 * src/Makefile prepared for python wrapping
2154 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2155 * src/gdcmHeader.cxx :
2156 - Parsing of header is now separated from loading of element values
2157 (see gdcmHeader::LoadElements).
2158 - general clean up of hopefully all file access (creation of
2159 ReadInt16 and ReadInt32)
2161 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2162 * src/gdcmHeader.cxx :
2163 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2165 - SetLgrElem renamed to SetLength
2166 - GetLgrElem renamed to GetLength
2167 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2168 * src/gdcmElValSet.cxx fixed both GetElValue methods
2169 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2170 due to IdoDude was cleaned out.
2172 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2173 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2174 concentrates on finding the value representation (when it exists).
2175 RecupLgr now only finds the element value length, and it avoids
2176 returning the unecessary skL (skipped length).
2177 Also, offsetCourant was simply removed (with taille_fich) since
2178 it was redundant with the File position internals (by using
2179 ftell and fseek). This also made skL (see above in RecupLgr) usage
2181 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2182 on the libido specificities which are handled through class
2184 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2187 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2188 * Truckload of changes. Parsing of header is barely functional
2189 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2191 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2192 * src/gdcmHeader.cxx many addons of low level methods
2194 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2195 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2196 and _IdDcmSWAP_LONG.
2198 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2199 * This corresponds to all the changes decided at the meeting of
2200 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob