1 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
3 displayed on Win32 when a brutal abort() occurs (because of uncatched
4 exception). See TODO new entry of this commit for more on this.
5 * TODO added new entry.
6 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
7 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
8 - HandleColor is no longer called from gdcmFile.cxx
9 - gdcmPixelConvert.cxx clean up on method arguments and internal
10 variable names for semantical coherence.
12 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
13 * Finished lossless transition, not only do we now read all lossless jpeg
14 images, without the need of the Cornwell lib, but we do read them properly now
15 * To reduce code (well to avoid code duplication), I defined a common place
16 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
17 redefine symbols. This is not prefect but this the best solution I found for a
18 compilation time jpeg option.
20 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
21 * Update jpeg ijg lib to support lossless jpeg implementation
22 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
24 * Also added a special copyright for dcmtk since we use their bugfixes.
27 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
28 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
29 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
30 matters, as stated in warning note at begining of %include section).
31 * src/gdcmDicomDir*.[cxx|h]: coding style
32 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
33 * src/gdcmJpeg8.cxx: doxygen fix.
34 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
35 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
36 from File:: to PixelConvert::.
38 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
39 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
40 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
41 - more code moved away from File:: to PixelConvert::
42 - fat setup of PixelConverter set in place in File::Initialise.
44 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
45 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
46 namespace at the file system level. So now you should convert your examples
48 gdcmHeader -> gdcm::Header
49 It would be nice if people keep in mind to no open the namespace, since it
50 allows compilation on broken plateform which were defining common symbol in
51 the standart namespace (like LP, Unknown ...)
53 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
54 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
55 The JPEG fragments are now parsed at the same stage than the RLE
56 information. All code related to JPEG is now in gdcmPixelConvert:
57 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
58 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
59 export a gdcmFile:: method. Those are simply global functions
60 (for the time being this is better than having them attach to
61 either gdcmFile:: or gdcmPixelConvert::).
62 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
63 and stores the result in a gdcmJPEGFragmentsInfo.
64 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
65 code (among other stuff) moved away from gdcmFile:; to
68 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
69 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
70 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
71 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
72 clean up of RLE related code.
73 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
74 - src/gdcmRLE.cxx removed
75 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
76 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
77 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
78 * CLEANUP_ROUND (9) for gdcmPixelConvert
79 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
80 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
81 away from gdcmFile:: to gdcmPixelConvert::.
83 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
84 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
85 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
86 This is because Parse7Fe0 used to parse the pixels to compute the
87 length. This task was passed over to FindDocEntryLengthOB() a long
88 time ago, EXCEPT I had forgotten the OW case...
89 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
90 we just recylce the code for parsing RLE fragments and computing
92 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
93 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
94 with the retired Parse7Fe0().
95 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
96 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
98 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
99 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
100 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
101 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
102 - src/CMakeLists.txt: alphabetic order reodering + new entries.
103 * CLEANUP_ROUND (4) for gdcmPixelConvert
104 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
105 to return an unused length.
107 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
108 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
109 this should be cleanner from the plane view. The iostream are erally a pain
110 to use to do simple stuff.
112 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
113 * Redo the compilation of the ijg jpeg library. Now only one source is
114 necesseray. No need to rename file by hand what so ever. CMake handle the
115 copying of the file within different directory, configure header file to
116 modify some symbol. The only addition made to ijg wasd a mangle table so
117 that symbol are different wether we are within 8bits or 12bits.
119 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
120 * Added documentation of vtkgdcmReader on Website:
121 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
122 with it's binary name).
123 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
124 the Website to be more complete.
125 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
126 doxygenated documentation.
127 - Doc/DoxyVtkGdcmReaderExamples.txt added
128 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
129 DoxyVtkGdmReaderExamples.html )
130 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
131 * CLEANUP_ROUND (3) for gdcmPixelConvert
132 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
134 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
135 * CLEANUP_ROUND (2) for gdcmPixelConvert
136 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
138 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
139 * CLEANUP_ROUND for gdcmPixelConvert:
140 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
141 - src/gdcmPixelStuff[h|cxx] removed
142 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
143 - src/CMakeLists.txt changed accordingly
145 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
146 gdcmVersion.py moved to newly created ATTIC related
147 gdcmPython/SetupOldies/ directory.
148 * Autotools clean up:
149 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
150 - autogen.sh configure.in acinclude.m4 python.m4 removed
152 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
153 * src/*.cxx *.h Reference to License.htm fixed to License.html.
154 * Doc/CMakeLists.txt, doxygen.config.in: fix.
155 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
157 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
158 * TODO updated with Mathieu suggestions. I proposed a template for
159 describing TODO entries and used it for new entries.
160 * Added Doc/Website/CodingStyle.html, Developpers.html,
161 DeveloppersPython.html, GdcmDataCvs.html and
162 DownloadVersion0_1.html, DownloadVersion0_3.html.
163 * Some Doc/*.txt Doxygen files (which do not really concern the
164 documentation itself, but the website) moved to html and
165 placed in directory Doc/Website:
166 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
167 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
168 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
169 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
170 * CMakeLists.txt changed accordingly.
171 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
172 DeveloppersPython.html
173 * INSTALL nows refers to Doc/Website/Installation.html
175 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
176 * Added Doc/Website directory, that contains a first raw version
179 2004-09-23 Jean-Pierre Roux
180 * FIX In order not to be poluted any longer by casting problems,
181 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
182 we can now delete[] it safely
183 * VoidArea is now called BinArea (less confusing name),
184 and all the methods called ...VoidArea... are now ... BinArea...
185 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
187 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
188 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
189 clear) TagHT, which is an inherited member of gdcmElementSet. It is
190 up to the destructor of gdcmElementSet to clean up TagHt and it's
193 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
194 * Test/CMakeLists.txt: update to follow gdcmData renamings.
195 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
197 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
198 * ENH: added some utility method that builds a flat dictionnary
199 holding all the Dicom entries contained in the recursive structure
200 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
202 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
203 BuildFlatHashTable() that build a flat dictionary.
204 - src/gdcmElementSet.h: added a new private GetTag() accessor.
205 gdcmDocument is now a friend of gdcmElementSet.
206 - src/gdcmElementSet.cxx: clean up.
207 - Example/FlatHashTablePrint.cxx added.
208 - Example/CmakeLists.txt changed accordingly
210 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
211 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
212 moved away from gdcmDocEntrySet (since this class is an abstract class
213 acting like an interface). SQDepthLevel and BaseTagKey are now
215 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
216 and associated accessors. Doxygenation of the class.
217 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
219 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
220 Use SQDepthLevel accessor instead. ::Print() adapted.
221 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
222 - src/gdcmDocument.cxx changed accordingly.
224 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
225 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
226 - The following is the doxygen comment of the typedef declaration
227 of gdcmagKey in src/gdcmCommon.h:
228 gdcmTagKey is made to old an "universal" (as in URL, Universal
229 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
230 A dicom tag allways has a group and an element, but a set of tags
231 embeded in various (optionally nested) sequences and sharing
232 the same group and element all share the same (group, element)
233 "identifier". Hence the (group, element) cannot be used as an
234 identifier (in gdcm we shall refer to a "TagKey") of a tag.
235 In order to construct a proper tag identifier (i.e. a key) we
236 consider the following definition of a TagKey:
237 - let Group, Element be the string representation of the
238 group and element dicom tag members,
239 - let ItemNumber be the string representation of the integer
240 index of the considered item number of a sequence,
241 Let the key of a tag embeded in a sequence, noted SeqTag, be
243 /ItemNumber#Group|Element
244 where "/", "#" and "|" are characters acting as separators.
245 Then the general form of a gdcmTagKey is given by:
246 Group|Element<SeqTag>
247 where <SeqTag> means NO or many instances of SeqTag.
248 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
251 but the gdcmTagKey of a tag "embeded" is the first item of
252 a sequence, itself nested in the third item of a sequence is the
254 0004|1220/2#0008|0082/0#0008|0090
255 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
256 order to hold the new sequence compatible key. Previously, the
257 GetKey() method would look in the underlying gdcmDictEntry.
258 - src/gdcmDocEntry.cxx:
259 -- constructor now copies the underlying DictEntry key, in the local
261 -- ::Print: displays the member Key, instead of the (group, element).
262 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
263 - src/gdcmDocEntrySet.h:xi
264 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
265 -- now has a new BaseTagKey member.
267 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
268 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
270 This poses the problem with the semantics of the following lines
271 LoadEntryVoidArea(0x0028,0x1201); // R LUT
272 LoadEntryVoidArea(0x0028,0x1202); // G LUT
273 LoadEntryVoidArea(0x0028,0x1203); // B LUT
274 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
275 to the long FIXME note for what the problem is. Nevertheless in
276 order to get things working the dicom dictionary was altered !
277 Please fix things urgently...
278 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
279 information), see above note on moving the member VoidArea. Nevertheless
280 the following entries previously correctly set as US are now inproperly
282 0028 1201 OW IMG Red Palette Color Lookup Table Data
283 0028 1202 OW IMG Green Palette Color Lookup Table Data
284 0028 1203 OW IMG Blue Palette Color Lookup Table Data
285 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
286 of gdcmDocEntry moved to gdcmSeqEntry.
287 * src/gdcmSeqEntry.cxx: STYLE.
289 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
290 * Test/TestAllEntryVerify.cxx minor fix and added comments.
292 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
293 * gdcmPython/testSuite.py: all the test suite in python is now moved
294 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
295 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
296 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
298 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
299 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
300 to avoid inclusion recursion until STL is reached.
301 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
302 mecanism. errno.h is not included in gdcm anymore.
303 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
304 (gdcmFormatError now inherits from gdcmFormatUnexpected).
306 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
307 gdcmData/TestAllEntryVerifyReference.txt
308 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
309 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
310 exception_on_error parameter.
311 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
312 - vtk/vtkGdcmReader.cxx changed accordingly,
313 - Example/*.cxx and Test/*.cxx changed accordingly.
315 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
316 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
317 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
318 enable_sequences removed from gdcmHeader constructor and dependencies.
319 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
320 * gdcmPython/demo/PrintHeader.py: dummy fix.
321 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
322 skip_shadow removed from gdcmHeader constructor and dependencies.
323 * Example/*.cxx and Test/*.cxx changed accordingly.
325 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
326 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
327 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
329 2004-07-21 Jean-Pierre Roux
330 * FIX Now, Parsing and Printing a DICOMDIR do work!
331 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
333 2004-07-20 Jean-Pierre Roux
334 * FIX Some brain damaged headers have Zero-Lenght fields
335 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
337 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
338 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
339 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
340 variable (instance of gdcmDebug) by a definition macro, and the instance
341 is now in static in the gdcmDebug class
342 * src/gdcmSQItem.h : (FIXME) remove an undefined method
343 * Test/PrintAllDocument.cxx : bug fix in the result of the test
345 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
346 * WARNING: ctest now depends more tightly on gdcmData. You should
347 check out gdcmData properly for things to run smoothly...
348 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
349 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
350 we need the pixels not be loaded in order to use the ValEntry
351 that displays position and size).
352 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
353 This is a C++ based equivalent of gdcmPython/testSuite.py that should
354 be deprecated. If you have any doubts about the advantages of a
355 modern scripting language (read Python) versus grass root C++ (i.e.
356 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
357 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
358 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
359 Anyhow, consider documenting the gdcmData images in
360 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
362 * Test/CMakeLists.txt:
363 - now uses TestAllEntryVerify.cxx
364 - specific comments on oldACR00001.ima (now renamed in gdcmData
365 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
366 gdcmData/TestAllEntryVerifyReference.txt
369 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
370 * src/*.[h|cxx] : typedef clean up
371 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
372 - TagKey renamed to gdcmTagKey (for external usage)
373 - VRKey renamed to gdcmVRKey (for external usage)
374 - removal of typedef duplication.
375 - Removed all unecessary inline keyword from class inline definitions.
376 - Some method|function(void) declarations replaced with method|function().
377 * src/jpeg/libijg12/jdhuff12.c:
378 - printf polluting ctest removed.
379 - TAB removal for comminting
381 - TestAllReadCompareDicom.cxx: added a test that compares all the
382 images in gdcmDataImages.h with corresponding images in
383 gdcmData/BaselineDicom/. When baseline images are not present
384 this test creates them.
385 Note: we need to validate each reference image, but before that
386 I'd like to rename them with a more explicit name...
387 - CMakeLists.txt: changed accordingly.
388 * Example/*.cxx: examples now only include gdcm.h (as opposed to
389 including each header needed).
391 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
392 * Test/*.cxx and Example/*.cxx: moved some examples away from the
393 test suite to the Example directory. Are concerned:
398 - TestWriteSimple.cxx
399 * Test/CMakeLists.txt: added some comments on reasons for black listing
400 image gdcmData/oldACR00001.ima
402 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
403 * Test/CmakeList.txt: removed the following from black list (to be coherent
404 with removal from gdcmData):
405 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
406 - gdcm-MR-PHILIPS-16.dcm
408 Added the following because after last cvs update, they cause
409 ctest -R TestReadWriteReadCompare
411 - gdcm-MR-SIEMENS-16-1.acr
413 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
414 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
415 new comments in this file) we temporarily (sigh) move to a weaker
417 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
418 we don't need to black list the following images anymore:
419 - 8BitsUncompressedColor.dcm
421 - US-PAL-8-10x-echo.dcm
422 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
423 fixes and the beautified code ;-)
424 This fixes the bug introduced in version 1.42 (when beautifying)
425 that made the parsing of 8BitsRunLengthColor.dcm unproper.
426 Note: ctest was blind to this bug (this means we need to still
427 improve the test suite). The bug could be detected by using
428 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
430 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
431 and by displaying the (garbage) produced file temp.XDCM...
433 2004-06-29 Jean-Pierre Roux
434 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
435 - replace by uggly but working old code :-(
436 A lot of things should be OK again.
437 It's really urgent to have a test suite that *tests*,
438 to prevent Frog's beautifying sessions to break all the stuff
439 (twice, withing a fortnigh ...)
441 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
442 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
443 redundancy) to added Test/TestReadWriteReadCompare.cxx
444 * Test/CmakeList.txt: because the compare test of
445 Test/TestReadWriteReadCompare.cxx fails, the following images are
446 black listed: - 8BitsUncompressedColor.dcm
448 - US-PAL-8-10x-echo.dcm
449 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
450 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
451 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
452 and ad-hoc kludge. This kludge is now removed, and on encountering
453 such an image (OB field brain damaged) we set errno. Then in
454 ::FindDocLength() we "fix" the length as being ALL what remains
455 in the file (until EOF). We then proceed, hoping for the best...
456 This fixes a SegFault in ShowDicom when trying to write such an
458 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
459 (because TestWriteRead breaks on it, after a non conformal commit?).
460 ctest now runs properly, except for MakeDicomDir (which was allways
461 broken) and the Python related stuff (still not fixed).
463 2004-06-24 Jean-Pierre Roux
464 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
465 FIX : Test/TestReadWrite now iterates on all the file names
466 (instead of infinite loop)
467 ENH : Test/TestWriteRead now iterates on all the file names
469 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
470 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
472 2004-06-24 Jean-Pierre Roux
473 FIX : - now Write drops LUT Descriptors and LUTs (if any)
474 when SamplesPerPixel =3
475 - now Write is no longer confused by
476 'BitsAllocated = 12" and 'BitsStored=12"
477 - "UN" value representation Elements are now written correctly
478 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
479 ENH : - now gdcmHeader has its own Write methods
480 (in order to split the job that has not to be done
483 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
484 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
485 loop on the same image until memory went out.
486 Note: this means we still have gobs of memory loss in PrintDocument
487 * src/gdcmDocument.cxx: fixes problem on parsing on file
488 gdcmData/16BitsJpegLosslessGrayScale.dcm.
490 2004-06-24 Jean-Pierre Roux
491 FIX : Write - All the Sequences and Sequence Item are now written
492 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
493 is added a the end, when necessary.
494 - A lot of brain-damaged images, that were read correctly are
495 now written correctly
496 - length compatible BinEntry are now loaded correctly
497 (even for odd groups)
498 Note : only Explicit Value Representation was checked.
499 (question : is implicit VR really necessary for gdcm ?)
501 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
502 * DEVELOPPER: added a proposition of coding style.
503 * src/gdcmDocEntry.h: removed every inline declaration (for test of
506 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
507 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
508 Use the gdcmDocEntry::Print() and Write() instead.
509 * src/gdcmDocument.cxx: bug fix.
511 2004-06-22 Jean-Pierre Roux
512 FIX : gdcmDocument.cxx
513 - Now we do recognize the JpegLossLess format (there was a misstyping in
514 code 'beautyfication' :-(
515 - Now we automaticaticaly load the Luts, if any
517 2004-06-22 Jean-Pierre Roux
518 In order : to write Sequences, whatever their imbrication level,
519 : to allow user to create his own Sequences
520 a lot of modif where necessary (adding, moving, or virtualising methods)
522 WARNING : save your own sources *before* cvs up !
525 ADD virtual void Write(FILE *fp, FileType filetype);
528 ADD virtual void Write(FILE *fp, FileType filetype);
529 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
532 ADD virtual void Write (FILE *fp, FileType filetype)=0;
533 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
534 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
535 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
536 ADD std::string GetEntryByName(TagName name);
537 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
539 std::string vr = "unkn",
540 std::string fourth = "unkn",
541 std::string name = "unkn");
542 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
543 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
544 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
545 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
546 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
547 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
548 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
549 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
552 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
553 ADD virtual std::string GetEntryByName (TagName tagName);
554 ADD virtual std::string GetEntryVRByName (TagName tagName);
555 REM virtual bool Write(FILE *, FileType);
556 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
557 FILE *_fp, FileType type);
558 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
559 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
560 REM virtual bool WriteEntries(FILE *_fp,FileType type);
561 REM virtual std::string GetEntryByName (std::string tagName);
562 REM virtual std::string GetEntryVRByName (std::string tagName);
563 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
564 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
565 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
567 std::string vr = "unkn",
568 std::string fourth = "unkn",
569 std::string name = "unkn");
570 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
571 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
572 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
573 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
576 ADD virtual void Write(FILE *fp, FileType filetype);
579 ADD virtual void Write(FILE *fp,FileType filetype);
582 ADD virtual void Write(FILE *fp, FileType filetype);
583 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
584 REM std::string GetEntryByNumber(guint16 group, guint16 element);
585 REM std::string GetEntryByName(TagName name);
588 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
590 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
591 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
592 The default constructor invoked by the line
593 gdcmHeader *f1 = new gdcmHeader( header );
594 was gdcmHeader::gdcmHeader(bool) instead of the expected
595 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
596 Hence the parsing wasn't executed... See also below.
597 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
598 as explicit constructor didn't do the trick to fix the above problem.
599 Could anyone explain why ?
600 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
601 properly calls gdcmValEntry::Print() (that was weed out from
602 code related to gdcmBinEntry).
604 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
605 * In order to fix memory leaks:
606 - Test/TestWriteSimple.cxx: added cleaning of free store through
608 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
609 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
610 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
611 (through the call to ::AddDicomDirMeta()) or the destructor
612 would crash when deleting uninitialized ::metaElems].
613 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
614 - src/gdcmDocument.cxx:
615 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
617 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
618 was causing memory leaks.
619 - src/gdcmSQItem.cxx:
620 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
621 cleanly handled with polymophism: sorry but my milage is low).
622 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
623 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
624 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
625 This avoids SegFaulting.
626 - src/gdcmSQItem.h: coding style.
628 - Test/TestWriteSimple still severely sucks. The output image content
629 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
630 damaged when displayed with vtkgdcmViewer.
631 - on memory leaks: TestWriteSimple leaks really less (see entry
632 of 2004-06-18 in Changelog file for the call to valgrind).
633 - on segfaults: ctest now passes all the tests but one (no more
635 * Erroneous leading white fix:
636 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
637 white[s] (as opposed to from >> xxx, that removes it [them].
638 - src/gdcmTS.cxx: ditto.
639 - gdcmPython/testSuite.py: dirty related kludge removed.
640 * src/*: remaining references to gdcmParser removed.
641 * src/*[cxx|h]: added copy[way]left header.
644 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
645 * In order to fix writing of dicom files:
646 - Test/TestWriteSimple.cxx: a simpler example of writing.
647 - Test/CMakeLists.txt changed accordingly.
648 - src/gdcmDocument.cxx:
649 -- The destructor now recursilvely removes potential sequences.
650 -- Bug fix in ::IsJPEG2000()
651 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
652 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
654 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
655 to only declared) and build on top of
656 ::GetDocEntryByNumber(guint16, guint16).
657 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
658 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
659 for usage in destructor and treatement of promotion in
660 ::ReplaceOrCreateByNumber().
661 - src/gdcmSQItem.cxx: destructor should better handle his job.
662 Test/TestWriteSimple now runs (or at least it DOES something).
663 * We can now start hutting memory links. A good starting point is:
664 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
665 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
666 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
668 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
669 * Valgrind note: after Mathieu Malaterre teached me how to read
670 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
672 Using gcc, you can force the STL to use malloc and to free memory as
673 soon as possible by globally disabling memory caching.
674 With 3.2.2 and later, you should export the environment variable
675 GLIBCPP_FORCE_NEW before running your program.
676 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
677 simply vanish (it is still not clear to me, whether this means that
678 STL std::string leaks or if valgrind believes it leaks...).
679 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
680 running bin/gdcmTests makeDicomDir):
681 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
682 - Test/makeDicomDir.cxx now properly traps empty lists and returns
684 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
685 SegFaulting (I drowned in DicomDir related code when trying to
686 understand why the list is empty...).
687 * src/gdcmDocument.h: first BSD license header try.
688 * Doc/License.txt added.
690 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
691 * src/gdcmDocument.[h|cxx]:
692 - Clean up of the Transfer related predicates. They are now all based
693 on new method isGivenTransferSyntax, that (should) handle properly
695 - general clean up, simplification, and coding style.
696 - Specific clean up of Parse7FE0() (umproperly named actually).
697 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
699 2004-06-14 Jean-Pierre Roux
701 - fix the display of Sequence Delimitor (SQDepthLevel pb)
702 - fix the display of SQItem ordinal number
703 - add the GetSQItemByOrdinalNumber method
704 - remove some useless never written private methods
706 2004-06-14 Jean-Pierre Roux
708 - adding a constructor taking a gdcmDocEntry as an input param
709 - ReplaceOrCreateByNumber now returns :
710 a gdcmBinEntry * if a Binary (void *) value is passed as a param
711 a gdcmValEntry * if a string value is passed as a param
713 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
714 according to the param type (no longer sets a gdcmDocEntry)
715 - GetValEntryByNumber, GetBinEntryByNumber added
716 - NewValEntryByNumber and NewBinEntryByNumber added
718 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
720 - GetSQItemNumber and SetSQItemNumber added, to provide
721 a (relative) Item identier inside a given Sequence
722 \warning : some pb remaining around this number
724 - AddEntry now takes the Item Number as a param
726 - adding a constructor taking a gdcmDocEntry as an input param
728 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
729 * Memory leak hunt with the following command:
730 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
731 --show-reachable=yes gdcmTests PrintDocument
732 It looks like many (all?) leaks are due to the STL (or a bad usage
733 of the STL. The lines producing the leaks now have a comment with
734 a "MEMORY LEAK" tag: you can retrieve them with
735 grep "MEMORY LEAK" src/*
736 Here are two typical examples which I can't help fixing:
741 char * test = "babo";
742 name = test; //// <--- valgrind detects 960 bytes lost in
743 //// call to std::string::operator=(char const*)
744 name.clear(); //// Doesn't help !
752 std::cout << "Type a bunch of characters followed by RETURN: ";
753 getline(std::cin, line); //// <--- valgrind dectects a loss
754 //// of 1320 bytes in call to
755 /// std::basic_istream<>& std::getline<>
761 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
762 * src/gdcmHeader.[cxx|h]:
763 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
764 and related, moved away to gdcmDocument.
765 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
766 the corresponding protected accessors of inherited class
767 gdcmDocument, removed ! As a consequence gdcmFile had to be
768 declared friend of class gdcmDocument (see below).
769 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
770 - Clean up of undefined or unused methods.
771 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
772 account the changes to gdcmHeader.h).
773 * src/gdcmDocument.h:
774 - gdcmFile is now a friend class (in order to take into account the
775 changes to gdcmHeader.h).
776 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
777 (see changes to gdcmHeader.h).
778 - Accessors (reading on the form GetEntry*) are now public.
779 - Clean up of undefined or unused methods.
780 * src/gdcmDocument.cxx:
781 - adaptation to changes to gdcmDocument.h
782 - ::OpenFile now writes a verbose message when file cannot be opened.
783 - some std::string properly set to VRKey
784 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
785 references to gdcmDocument.
786 * Test/TestFindTags.cxx: changed accordingly to above changes.
787 * gdcmPython/testSuite.py: adapted to renaming of acr files in
788 cvs repository gdcmData.
790 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
791 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
792 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
793 conflicts with gdcmValEntry::voidArea.
794 * src/gdcmValEntry.cxx: unmatching comment wiped out.
795 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
796 Value representation between StringRepresentable and BinaryRepresentable.
797 * src/gdcmDocument.cxx:
798 - method ParseDES: proper indentation restored and usage of
799 gdcmVR::IsVROfGdcmStringRepresentable wired in.
800 - method LoadDocEntry: the fingerprint left in the SetValue() of
801 unloaded entries (length > MaxSizeLoadEntry) had curiously been
802 removed. Reverting to previous code segment with the proper
803 dynamic_cast< gdcmValEntry* >.
804 Note: this was (partially) breaking the python test suite
805 (gdcmPython/testSuite.py) that made usage of the above
806 fingerprint to check presence of "Pixel Data".
807 * src/gdcmDocEntry.h: coding style.
808 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
809 now taken into account.
810 * gdcmPython/gdcm.i: adaptation to the new internal representation
811 of gdcm (exit gdcmParser, hello gdcmDocument).
812 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
814 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
815 anymore, but instead prints the loaded Python dictionary.
816 * .... alas, the python testSuite is still broken.
818 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
819 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
821 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
822 * src/gdcmUtil.h : export methods
824 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
825 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
827 * Initial addition of automatic python testing
828 * Initial addition of automatic image comparison
830 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
831 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
832 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
834 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
835 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
836 * Test/ShowDicom.cxx : bug fix for msvc compilation
837 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
839 2004-05-04 Jean-Pierre Roux
840 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
841 new concepts (and new classes) :
842 a 'gdcmDocument' is composed of a set of Doc Entries, that are
843 - elementary gdcmDocEntries (former gdcmHeaderEntries)
844 - Sequence Doc Entries (gdcmSeqEntries)
845 a Sequence is composed of Items.
846 Each item is a set of Doc Entries (this is recursive)
847 The non uniqueness of the 'Dicom tag' is due to this recursivity
848 (never taken into account)
849 Our unability to add a new 'entry' in the header
850 at the proper location (neither in the H-Table (map or multimap),
851 nor in the Chained List is also due to this recursivity.
852 Don't try, right now, to use/modify/compile these new sources :
854 We just commit all the stuff, 'as is', in order not to loose it.
856 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
857 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
859 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
860 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
861 file prefix (SetFilePrefix)
863 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
864 * Add a new test: ShowDicom, for now this is just the c++ version of
865 checkRead.sh, later it will be able to compare the image read against a
867 * Replace the DEBUG on the stack with a global entry in cmake interface:
868 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
870 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
871 * Add an example subdir, with a real example on how to read + write a
874 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
875 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
876 * Doc/CMakeLists.txt: the main page is now properly differentiated
877 between the developper and user version.
878 * Doc/doxygen.config.in: dropped search related obsolete flags
879 * src/gdcmParser.h, gdcmHeader.h: doxygenation
881 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
882 * DEVELOPPER: added some helpfull comments for compile/test/install
885 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
886 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
887 src directory, now generated in the build dir.
888 2. Tests as mentionned smarter
890 4. Add a new method in gdcmDict that return the PubDict by name
891 this is interesting for 3rd party lib like ITK,
892 where we could set the institution name / patient name...
894 * ENH: 1. Now the test suite is working for real
895 2. All binaries are now output in the gdcm-bin directory
896 (this was not true before)
898 2004-04-28 Jean-Pierre Roux
899 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
900 SeQuence indented printing of Dicom Header.
901 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
902 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
903 Computation of SQDepthLevel is now part of gdcmHeader constructor
904 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
905 tree-like structure of a Dicom Header.
906 * FIX Test code cleaning
908 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
909 * ENH: Adding automatic testing
910 1. Need a DartConfig.cmake to submit to public
911 2. Add a test driver gdcmTest.cxx
912 3. gdcmTestMain, an helper for the main test driver gdcmTest
913 4. Files in Test don't have a main anymore, this becomes interesting
914 when we add more and more tests, thus dsw don't have to load
916 * ENH: Adding a GDCM_DATA_ROOT for testing
917 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
918 one file instead of seven + some small cleanup
920 2004-04-22 Jean-Pierre Roux
921 * ENH Minor changes to the Print() methods.
922 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
923 Header printing. Example given with :
924 > PrintHeader fileName 2 new
925 (SQ based tree-like structure still to be done for the Header ...)
927 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
928 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
929 1. I have added some unsigned where needed
930 2. Some function parameter not used -> (void)
931 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
932 4. g++ don't like character '\' in comment
933 5. #define jpeg_create_decompress jCreaDecompress
934 this really need to be fixed
935 6. virtualize destructor of gdcmObject ... leakage
936 7. sscanf(g->first.c_str(),"%x",&gr_bid);
937 this also really need to be fixed
938 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
939 remove compression file
940 (as we only do decompression, right ?)
941 * ENH: Change malloc/calloc/free with c++ equivalent
943 2004-04-21 Jean-Pierre Roux
944 * FIX gdcmHeaderHelper::GetXSpacing
945 when a single value is found (bug ?), xpacing is now
946 defaulted to yspacing
948 2004-04-19 Jean-Pierre Roux
949 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
950 * ENH add parameters :
951 bool exception_on_error = false,
952 bool enable_sequences = false,
953 bool ignore_shadow = false
954 to the gdcmFile constructors to be full gdcmParser compliant
955 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
956 to allow reading of PAPYRUS 3.0 files
958 2004-04-06 Jean-Pierre Roux
959 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
961 2004-04-02 Jean-Pierre Roux
962 * ADD : Test/checksequence.sh, for a general recap on SQ pb
963 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
964 for Philips spurious Tag fffe|0000 while rewritting Dicom files
966 2004-03-30 Jean-Pierre Roux
967 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
968 for ACR file, written out as DICOM files (hope so...)
970 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
971 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
972 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
973 moved to base class gdcmParser and only the specialisation is kept
975 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
976 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
977 already does the job.
978 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
979 (to be consistent with gdcmParser::WriteEntries).
981 2004-03-30 Benoit Regrain
982 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
983 upate of the object's instance. It's passed to 2 in the unfavorable
984 case : one in the ExecuteInformation, one in the ExecuteData
986 2004-03-29 Jean-Pierre Roux
987 * ENH : Check on file type to be written moved
988 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
989 * FIX : gdcmObject::ResetBoundaries now stops properly
990 when end-of-list is reached
991 : gdcmVersion modified (as Benoit Regrain asked)
993 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
994 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
995 * src/gdcmUtil.cxx: added forgotten iostream include.
996 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
997 equivalent to ExplicitVR in existing code).
999 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1000 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1001 now contains all the gdcmGlobal related code.
1002 * minor coding style and doxygenation changes.
1004 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1005 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1006 now contains all the Debug related code.
1007 * minor clean-up of includes in src/*.cxx
1008 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1009 CreateCleanString) removed.
1010 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1011 * Doc/DoxyMainPageUser.txt added.
1012 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1013 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1014 src/gdcmDirList.cxx)
1016 2004-03-24 Jean-Pierre Roux
1017 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1019 2004-03-23 Jean-Pierre Roux
1020 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1021 big endian made volumes
1022 * ENH Now gdcmParser constructor and destructor are protected to forbid
1023 end user to instanciate class gdcmParser
1024 (only gdcmHeader and gdcmDicomDir are meaningfull)
1026 2004-03-22 Benoit Regrain
1027 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1028 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1029 gdcmSerie to gdcmDicomDirSerie
1031 2004-03-19 Jean-Pierre Roux
1032 * ENH Now the tree-like structure describing a DICOMDIR comming from
1033 an already existing DICOMDIR file is consistent with
1034 the home-made tree-like structure build ex-nihilo
1035 or build from the files held (recursively) in a Directory
1036 functions gdcmDicomDir::CheckBoundaries()
1037 gdcmObject::SetBoundaries() added
1039 2004-03-17 Jean-Pierre Roux
1040 * REM (Eric Boix bug) : removal of meaningless
1041 gdcmDicomDirImage::NewImage function.
1042 * FIX now file names and directory name are written properly in the
1044 * FIX now gdcmDicomDir constructor may be call without any trick
1047 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1048 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1049 of gdcmDicomDirImage::NewImage as empty function.
1051 2004-02-28 Jean-Pierre Roux
1052 * ENH add gdcmDicomDir:NewPatient
1053 add gdcmDicomDirPatient:NewStudy
1054 add gdcmDicomDirStudy:NewSerie
1055 add gdcmDicomDirSerie:NewImage
1056 to allow making gdcDicomDir object.
1057 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1058 (as opposite to the gdcmHeader chained list)
1060 2004-02-11 Benoit Regrain
1061 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1062 when using from python
1064 2004-02-10 Benoit Regrain
1065 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1066 * FIX : in gdcmDicomDir when the directory is empty
1067 * ENH : add callback and methods to get the progression of dicomDir
1070 2004-02-06 Jean-Pierre Roux
1071 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1072 - GDCM_META added to gdcmDicomDirType
1073 - class gdcmMeta created
1074 * ENH : - A brief summary is now displayed at the beginning of
1075 'testDicomDir' to help disaster magnitude estimation
1076 * REM : Now useless Test/explDICOMDIR.cxx
1078 2004-02-05 Benoit Regrain
1079 * ENH : add methods in gdcmObject to get the hash table or the list of
1081 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1082 * FIX : wrapping python for TagHeaderEntryHT
1084 2004-02-04 Benoit Regrain
1085 * FIX : even length for some strings when writting the dicom dir
1086 * FIX : sort the images in the dicom dir
1087 * FIX : Bug fix for python use of dicom dir
1088 * ADD : a python demo
1090 2004-02-04 Jean-Pierre Roux
1091 * FIX : Final solution (?) for icone embedded images
1092 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1093 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1094 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1095 gdcmData/gdcm-MR-SIEMENS-16.acr1
1096 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1097 to make full checking easier
1099 2004-02-04 Benoit Regrain
1100 * FIX : WriteEntries : coding style & logic in parameters
1101 * FIX : Set the elements to create the DicomDir in a dictionary file
1103 2004-02-03 Benoit Regrain
1104 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1105 * gdcmDicomDir : add the load of directory
1106 * Bug fix and print add-on
1108 2004-02-03 Jean-Pierre Roux
1109 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1110 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1111 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1112 * FIX gdcmParser.cxx : 'group length' elements are now considered
1113 as integers, even for shadow groups, when file is Implicit VR
1115 2004-02-02 Jean-Pierre Roux
1116 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1118 of the last synonym :-(
1119 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1121 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1122 * FIX taking into account the possible 7fe0,0010 multiplicity
1123 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1124 to allow removal of references to 7fe0,0010, to deal with
1125 ACR-NEMA images, when 0028,0200 is meaningfull
1127 2004-01-31 Jean-Pierre Roux
1128 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1129 no longer writes 'Un' on disk
1130 * FIX SQ elements with actual length are now dealt with corectly
1131 * FIX gdcmFile::WriteBase make the difference, for color images, between
1132 the length (for Palette expanded images)
1133 and Raw Length (non expanded image + Palette)
1134 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1135 (that broke Write). Replaced by UL.
1136 Aware user will reload the field if he
1137 thinks it's necesssary
1139 2004-01-30 Jean-Pierre Roux
1140 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1141 when 'dirty Acr' is found, to be compliant with the new
1142 IsReadable() methods.
1144 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1145 (no DOUBLE images in kosher DICOM,
1146 but so usefull for people that miss them ;-)
1148 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1149 DICOMDIR related utilities (not checked as Windoze compliant)
1151 2004-01-28 Jean-Pierre Roux
1152 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1154 2004-01-27 Jean-Pierre Roux
1155 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1156 to allow skipping the shadow elements, to save memory space.
1157 The TRUE value for this param has to be used
1158 with a FALSE value for the 'enable_sequence' param.
1159 ('public elements' may be embedded in 'shadow Sequences')
1160 * gdcmHeader methods now deal with 'embedded icones images' in the header
1161 (even when an 'icone image sequence' is announced by the
1162 element (0x0088,0x0200), but there is NO icone at all ...
1164 * gdcmHeader sometimes Image Location value doesn't follow
1165 the supposed processor endianity (see gdcmData/cr172241.dcm).
1168 * gdcmHeader add the method
1169 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1170 to get *all* the Header Entries with the same tag.
1171 GetHeaderEntrySameName is probabely *useless*
1172 (no meaning : Name is *not* an identifier within the Dictionnary)
1174 2004-01-26 Benoit Regrain
1175 * Bug fix in the print of hexadecimal representations. Remove long fields
1176 in the print and add a third level of print to print them
1178 2004-01-23 Benoit Regrain
1179 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1180 * Bug fix on test suite after remove the strip made on not string fields
1181 * Split the IsReadable method between gdcmParser which test that the file
1182 is dicom and gdcmHeader which test that it's an image file
1184 2004-01-22 Benoit Regrain
1185 * DicomDir : clean code, add methods, set variables in protected or private
1186 * gdcmUtil : bug fix for the clean string method
1188 2004-01-19 Benoit Regrain
1189 * Add the use of shadow dictionaries
1190 * bug fix and coding style
1192 2004-01-19 Benoit Regrain
1193 * src/gdcmFile.cxx : bug fix concerning the close of file
1194 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1195 * Add the update of header entries using the shadow library
1197 2004-01-19 Benoit Regrain
1198 * removal of file gdcmHeader2.cxx
1199 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1200 inheriting from gdcmParser. This split is to prepare the integration
1201 of dicom dir parsing
1202 * bug fix under python
1204 2004-01-16 Jean-Pierre Roux
1205 * REM removal of class gdcmHeaderEntrySet
1206 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1207 * ADD add file gdcmHeader2.cxx
1208 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1210 2004-01-15 Benoit Regrain
1211 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1212 entries created while parsing the header. Thus, they will be destroyed
1213 when the gdcmDictSet will be destroyed
1214 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1217 2004-01-15 Benoit Regrain
1218 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1219 made a fatal error because of the memory release at the end of program.
1220 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1221 some memory and vtk seems to have some problems with that.
1222 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1224 2004-01-14 Benoit Regrain
1225 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1226 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1227 * src/*.[h|cxx] : make changes due to class name changes
1228 * gdcmPython/demo/*.py : bug fix due to method names
1230 2004-01-13 Benoit Regrain
1231 * src/*.[h|cxx] : coding style
1232 * vtk/*.[h|cxx] : coding style
1234 2004-01-13 Benoit Regrain
1235 * gdcmPython/testSuite.py : test the readable flag of file for tests
1236 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1237 It's lied to the stl compilation by MSVC (windows, always windows...)
1238 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1240 2004-01-12 Benoit Regrain
1241 * src/*.h : add comments
1242 * src/gdcmDictSet.h : set the method BuildDictPath in public
1243 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1244 directly setted in the source code
1245 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1248 2004-01-09 Benoit Regrain
1249 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1250 * setup.py : use a reference to gdcmVERSION
1252 2004-01-07 Benoit Regrain
1253 * Modification to compile with the distutils.
1256 2003-12-10 Benoit Regrain
1257 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1258 can use a gdcmHeaderHelper to load datas
1259 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1260 made in the source code
1262 2003-12-10 Benoit Regrain
1263 * Update Windows projects and .cvsignore files
1265 2003-11-12 Jean-Pierre Roux
1266 * ENH gdcmHeader constructor has one more parameter (default value : false)
1267 that allows the user to 'go inside' the SeQuences only
1269 gdcmElValSet:Print takes it into account
1271 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1272 * ENH: Update gdcmPython/CMakeLists
1273 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1274 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1276 2003-11-10 Jean-Pierre Roux
1277 * FIX : gdcmHeader::LoadElements is now based
1278 on the ListTag listElem member,
1279 not longer on the TagElValueHT tagHt member
1280 * ENH : PrintPubElVal shows (temporarily) both results,
1281 with the tagHt member and the listElem member.
1282 (it's easier to 'see' the problems when using Printheader)
1284 * FIX : old private member LgrElem is now splitted into
1285 ReadLength : Length actually found on disk (updated only
1286 if bug fixing is necessary), for internal
1288 UsableLength : Updated by FixFoundLength, to fix a bug
1289 or to allow Parser going on.
1290 Will allow to re-write a kosher header when a SeQuence
1291 with a length (not 0000) is found
1292 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1293 because gdcmElValSet::Add does not update ListElem
1296 2003-11-07 Jean-Pierre Roux
1297 * FIX misstyping in Transfert Syntax name table
1298 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1299 when they have an actual length (not 0000 nor FFFFF)
1300 (Nobody should care of it, but DICOMDIR explorers)
1302 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1303 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1305 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1306 * ENH: vtkGdcmReader now supports LUT !
1307 (vtkgdcmViewer for now is not able to use them though)
1309 2003-11-05 Jean-Pierre Roux
1310 * in testSuite.py : new files names for checking the package
1311 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1312 that returns the pixel area size to the *aware* (vtk) user
1313 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1315 2003-11-05 Benoit Regrain
1316 * in testSuite.py : Modify the rules for checking the paths
1317 : Explicit error messages
1318 * in __init__.py : Related modif
1320 2003-11-03 Jean-Pierre Roux
1321 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1322 to be used by aware (vtk) users that want to manage
1323 LUT (and no to turn the PALETTE image into an RGB pixels one)
1324 * GetPixelType now returns 8U for 24 Bits images
1325 (vtkGdcmReader compliant)
1327 2003-10-31 Jean-Pierre Roux
1328 * Removal of *all* gdcmData images and add them again
1329 in order to loose the 'history' of un-anonymised images
1331 2003-10-31 Jean-Pierre Roux
1332 * RMV : removal of useless jBitsInJsample.h
1333 for both 8 and 12 Bits JPEG Lossy Libraries
1335 2003-10-31 Jean-Pierre Roux
1336 * ENH : Add the functions gdcmFile::GetImageDataRaw
1337 gdcmFile::GetImageDataIntoVectorRaw
1338 that act as GetImageData and GetImageDataIntoVector
1339 except the making of an RGB Plane from Gray Plane + LUT
1340 Intended to aware (vtk) users who know how to manage
1343 GetLUTRGBA return a R,G,B,A LUT if any
1344 lgrTotaleRaw gives the 'Raw' length
1345 GetImageDataRaw returns the gray Plane
1346 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1347 (They stay Grey, just like with other Dicom viewers :-(
1349 2003-10-30 Jean-Pierre Roux
1350 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1352 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1353 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1354 being coherents dicom files.
1356 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1357 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1359 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1360 * ENH: Two steps is necessary to please VC++ compiler...
1361 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1362 * ENH: Add include dir to medcon lib
1363 * FIX: only one function is being exported for now !
1364 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1366 2003-10-29 Jean-Pierre Roux
1367 * adding gdcmHeader::GetLUTRGBA
1368 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1369 --> Mathieu, the modif u're waiting for is not yet committed
1370 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1372 2003-10-27 Jean-Pierre Roux
1373 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1374 00191113.dcm DermaColorLossLess.dcm
1375 MxTwinLossLess.dcm RadBWLossLess.dcm
1376 * ENH: For version prior to vtkImageViewer2 -r 1.19
1377 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1379 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1380 * Removal of ido stuff in CMakeLists.txt
1382 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1383 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1384 * FIX: remove a call to ->Modified ... see comments
1385 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1387 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1388 * FIX: Problem with path for libvtkgdcmPython
1389 * ENH: Try adding a search script for python site-package
1390 * RMV: Remove some file from medcon lib that are not necessary
1391 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1392 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1393 * FIX: More pragma disable fro VC++,
1394 I don't think I break something as it is also disable in VTK/ITK.
1395 But it fasten debug compilation time.
1397 2003-10-23 Jean-Pierre Roux
1398 * gdcm now deals with 16 Bits Run Length Encoded images
1399 (they are compressed as 2 planes images,
1400 one for the high Bytes, the other for low Bytes)
1402 2003-10-22 Jean-Pierre Roux
1403 * Now CheckRead takes into account :
1404 - the bugged 'Leonardo' Siemens images
1405 - the XA images, sent thru the burning VPRO station
1406 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1409 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1410 * FIX: When copying a Makefile.am to CMakeLists.txt
1411 one should remove the '\'
1413 2003-10-22 Jean-Pierre Roux
1414 * in gdcmData adding a bugged 'Leonardo' Siemens image
1415 (wrong lengths in header)
1416 OK with gdcm, KO with the other viewers :-)
1417 * add a GE dlx XA image, thru the VEPRO burning station
1420 2003-10-21 Jean-Pierre Roux
1421 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1422 for a brutal checking of vtkgdcmViewer compliance
1424 2003-10-21 Jean-Pierre Roux
1425 * add the files for 'xmedcon' Jpeg Lossless library
1426 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1428 2003-10-21 Jean-Pierre Roux
1429 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1431 2003-10-21 Jean-Pierre Roux
1432 * garbage Siemens 'Leonardo' images dealt with
1433 (the patch is easy to remove)
1434 * cosmetic changes to avoid warnings
1436 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1437 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1438 no need to press 'r' now.
1440 2003-10-20 Jean-Pierre Roux
1441 * upgrade of checkRead.sh checkWrite.sh according
1442 to new Jpeg Lossless decompressor
1443 * add US.3405.1.dcm, a genuine RGB medical file ...
1444 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1445 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1447 2003-10-15 Jean-Pierre Roux
1448 * general anonymisation in gdcmData
1449 * adding the 'color files' from
1450 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1451 * adding some well knowed bugged-header images
1452 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1453 waiting for their inclusion in Python testsuite
1455 2003-10-15 Jean-Pierre Roux
1456 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1457 no longer seg faults when file is not found
1459 2003-10-14 Jean-Pierre Roux
1460 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1463 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1464 * TODO: *.in file to genereate a UseGDCM later
1466 2003-10-14 Jean-Pierre Roux
1467 * Some supposed-to-be Dicom Images have no preamble.
1468 OpenFile takes it into account
1469 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1470 * Missing elements added in dicomV3.dic
1471 (just to be affraid : have a look at
1472 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1473 and do it again next year ;->
1475 2003-10-13 Jean-Pierre Roux
1476 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1477 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1478 But there are NOT. It's fixed !
1480 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1481 * FIX: "jpeglib.h" was not found on VC++
1482 * FIX: vtkgdcm was not being installed
1484 2003-10-10 Jean-Pierre Roux
1485 * ENH : OpenFile closes the file if it *really* doesn't look like
1486 an ACR-NEMA / DICOM one.
1487 * FIX : testWrite no longer writes an empty file if the source file
1488 is not gdcm Readable
1489 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1492 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1493 * FIX: CMake generate now documentation
1494 * ENH: out of source doc build !
1495 * ENH: Generate both user and dev documentation
1496 * ENH: Should work on windows too
1497 * ENH: Only one doxygen config.in file is needed
1498 * FIX: make install should be ok now on ùnix plateform
1499 * FIX: PATH to dictionary was wrong (missing /)
1500 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1502 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1503 * vtkGdcmReader is now able to read rgb dicom file.
1504 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1505 * added a gdcmViewer to vtk test, use mouse to control
1506 window level & window width
1508 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1509 * CMake-ification of gdcm, we have now two build system
1510 * FIX: on cygwin Wsock32 doesn't exist
1511 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1513 2003-10-06 Emanuel Ollart
1514 * FIX : compilation process wad broken.
1515 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1517 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1518 * change gdcmViewer -> vtkgdcmViewer
1519 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1521 2003-10-06 Jean-Pierre Roux
1522 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1523 ( e.g : well known GE images with a wrong elem length,
1524 : Philips MRI Images with a wrong Huffman table)
1525 * still to be done : allow the reading of bugged LEONARDO Siemens images
1527 2003-10-03 Jean-Pierre Roux
1528 * Odd length strings are padded with '\0' (not with spaces,
1529 to remain compliant with already defined strings,
1530 like Transfert Syntax UID and others)
1532 2003-10-03 Jean-Pierre Roux
1533 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1534 to allow displaying RGB images (not only by affim ;-)
1536 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1537 * vtkGdcmReader is now able to read rgb dicom file.
1538 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1540 2003-10-03 Jean-Pierre Roux
1541 * A few nasty patches to allow the reading of a lot of nasty images
1542 ( e.g : well known GE images with a wrong elem length,
1543 : Philips MRI Images with a wrong Huffman table)
1544 * still to be done : allow the reading of bugged LEONARDO Siemens images
1546 2003-10-03 Jean-Pierre Roux
1547 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1549 2003-10-03 Jean-Pierre Roux
1550 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1551 to allow displaying RGB images (not only by affim ;-)
1553 2003-10-03 Jean-Pierre Roux
1554 * gdcmFile::GetImageDataIntoVector now
1555 - deals with MultiFrames MultiFragments Run Length Encoded files
1556 - deals with YcBcR (YBR_FULL) files
1557 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1558 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1560 (no sample found :-(
1562 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1563 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1564 Two reasons: - clear things
1565 - third parties acces gdcm through header files, so won't
1566 suffer anymore VC++ complains
1568 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1569 * add argv[1] in testvtkGdcmReader.cxx
1572 2003-09-24 Jean-Pierre Roux
1573 * The lines are now eigthy characters long.for
1574 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1576 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1577 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1578 char* to std::string. Thus, the use of strdup becomes useless. (see
1579 previous commis of Malaterre)
1580 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1581 before the last Malaterre's commit.
1583 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1584 * This commit should fix the Debug building under VC++, the problem
1585 was mainly a mixture of debug and release lib being loaded at startup.
1586 * I also remove a depency to a specific C function: strdup. Because I had
1587 to force the link to msvcrtd (whereas strdup is in libc).
1589 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1590 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1591 located in the gdcmCommon.h file. All use of reference of tha has been
1592 changed to now use the variable GDCM_UNFOUND.
1594 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1596 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1597 Dicom dictionary. The test suite can now be run again. Note:
1598 I'm note very happy with the " (RET)" changes. I believe this
1599 RETAINED comment should be dropped when parsing the dictionary.
1600 - PACKAGER corrected
1602 - AUTHORS updated and now in alphabetical order
1603 * Makefile.am now exports gdcm.dsw for Windoze users.
1605 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1606 * cygwin complains about missing std:: in subdir Test/
1608 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1609 * remove some methods that are now in gdcmHeaderHelper
1611 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1612 * vtkGdcmReader set spacing and origin correctly
1614 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1615 * Fix a few delete/delete[] mismatch
1617 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1618 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1619 interpretation to data given by gdcmHeader. For instance there are
1620 heuristics to get informations (look at different places).
1621 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1622 sorting DICOM images based on different strategies.
1623 * modified Makefiles accordingly.
1625 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1626 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1627 when building in debug mode
1628 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1629 src/win32/gdcmdll.dsp
1630 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1632 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1633 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1636 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1637 * src/win32/libgdcmjpeg12.dsp was not dos format
1638 * src/win32/libgdcmjpeg12.dsp :
1639 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1640 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1642 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1643 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1645 * src/gdcmFile.cxx : bug fix in affectation type
1646 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1647 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1648 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1649 symbols... future problem ?
1651 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1652 * src/win32/libgdcmijpeg12.dsp was missing
1653 * modified gdcm.dsw accordingly
1655 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1656 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1658 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1659 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1660 commit of JPR (before his hollidays to facilitate our work).
1661 * setup.py : bug fix in code. Modifications made while the last commit
1662 of JPR. The code hasn't been tested before the commit... it's so
1663 useless to make that (for best programmer that is JPR) !!!
1665 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1666 * tagged the current version as Version0_3 (i.e. version 0.3)
1668 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1669 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1670 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1671 * *.dsp : modifications to use new libgdcmijpeg8 library
1672 * setup.py : bug fix on VTKPATH variable
1673 * PACKAGER : adding all concerning windows
1675 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1676 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1678 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1679 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1680 test suite reported error.
1681 * PACKAGER file added (describes what a packager must do when
1682 packaging a new release).
1683 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1684 * configure.in: upgraded version number to 0.3.0
1685 * fixing build of rpm (through rpm -ta):
1686 - Doc/Makefile.am exports proper doxygen files
1687 - src/jpeg/libijg8/Makefile.am exports the include files.
1689 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1690 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1691 * src/gdcmHeader.h : formatting code
1693 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1694 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1695 We were obtaining error message from vtk. Now, creation of file list
1696 is made in an internal list to prevent this problem.
1697 Bug fix when output is empty.
1698 Bug fix in update of progress value. Previous commit for this was a bad
1700 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1702 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1703 * src/gdcmHeader.h : added method to get the file name
1704 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1705 files. Added method to remove all files on the input
1706 Added FIXME comment concerning the bad parsing of header made by
1707 ExecuteInformation method (in ExecuteData method)
1709 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1710 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1711 when using make instal.
1712 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1713 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1715 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1716 * setup.py : adding include dir of jpeg lib to compile all sources
1717 * */Win32/*.dsp : JPR fix for windows compilation
1719 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1720 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1722 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1723 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1725 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1726 * setup.py is again effective on un*x (takes into account the
1727 addon of the jpeg library)
1728 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1729 * Doc/Doxy* updated (includes above enhancements)
1730 * INSTALL now points to web documentation
1732 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1733 * src/gdcmHeader.h doesn't make unnecessary reference to
1735 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1737 * src/gdcm*.[cxx|h] :
1738 - to allow compilation with gcc 3.x
1739 -- clean up of STL usage (added explicit usage of std::)
1740 -- small fixes on exceptions.
1741 Note: linking not tested !
1742 - clean of doxygen comments to avoid warnings at documentation
1744 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1745 dependent convertion).
1747 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1748 * Clean up of previous JPR garbage commit (not even commented in the
1750 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1751 - moved all jpeg related files from src to src/jpeg/libijg8, with
1752 addition/modification of Makefile.am and configure.in.
1753 - the testSuite is still brain damage (not guilty).
1755 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1756 * WrapVTK.py : modifications to get correctly vtk source files to
1758 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1759 (FileName -> Filename)
1761 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1762 * vtk/vtkGdcmReader.[cxx/h]:
1763 - UpdateProgress method should now be effective
1764 - removed the limitation on having only images loaded (as opposed
1766 - when building a stack of images/volume, a lesser number of
1767 gdcmHeader and gdcmFile instances should be used (hopefully
1768 accelerating things).
1769 - when building a stack of images/volumes, files which are not
1770 loadable (wrong path-filename, wrong permissions on existing file,
1771 or file not parsable by gdcm) are replaced with a black image
1772 in the stack (for the caller to notice the problem).
1774 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1775 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1777 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1778 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1779 between standard library (std) and vtk library (problems are found
1780 under Windows... thanks Windows !)
1782 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1783 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1785 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1787 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1788 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1790 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1791 * When compiling with distutils (see setup.py) the C++ compiler is
1792 called with different flags than the default ones (with automake).
1793 In order to fix all those warning, I compiled gdcm with the command
1794 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1795 and went for warning fixes:
1796 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1797 up from unused variables.
1798 - vtk/vtkGdcmReader.cxx: potential bug fix.
1799 * src/gdcmHeader.h: Doxygen warning cleanup
1801 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1802 * gdcmPython/gdcm.i:
1803 - typemaps correction to take into account the systematic replacement
1804 of "using namespace std" with std:: prefix e.g. std::list,
1805 std::string... (cf changes of 2003-05-21).
1806 - gdcmGlob global variable of type gdcmGlobal (defined in
1807 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1808 exported to Python a as cvar.
1809 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1810 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1811 gdcmDictSet.GetPubDictTagNames() and
1812 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1813 C++ static methods).
1814 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1815 with the above changes.
1817 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1818 * setup.py, manifest.in : bug fix under linux
1820 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1821 * Modification of setup.py to compile vtk part too. Then, we have 2
1822 wrappers which must work with same distutils. For that, we have a
1823 generic distutils in distusiltsWrapping.py ; with :
1824 - build_extWrap class to wrap generically all extensions,
1825 - ExtensionWrap base class for all wrapping extension that contains
1827 - Wrapper interface which wrap sources
1828 + In WrapSwig.py we have extension and wrapper for Swig
1829 + In WrapVTK.py we have extension and wrapper for VTK
1830 * MANIFEST.in : modifications to consider vtk directory and new python
1831 files for compilation
1833 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1834 * Added python wrappers of vtkGdcmReader vtk class (see the
1835 source in vtk/vtkGdcmReader.cxx) :
1836 - vtk/Makefile.am now builds a library
1837 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1838 python library (as opposed to _gdcm.so wich are the python
1839 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1840 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1842 - configure.in has an additional flag --enable-vtk that needs
1843 to be set to enable compilation of vtk related code, that is:
1844 + vtk/vtkGdcmReader.so and
1845 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1846 + gdcmPython/vtkgdcmPython.so (see above)
1847 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1848 be read when compressed or when HighBit + 1 != BitsStored),
1849 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1850 the usage of the python wrapper of vtkGdcmReader vtk class.
1851 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1852 * src/*.[h] all occurences of stl classes are now prefixed with
1853 std::, and all occurences of "using namespace std;" where removed.
1854 This is to avoid pollution of global namespace in included files.
1855 Apparently vtk does not avoid this pitfall: when using both
1856 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1857 collision of various stl members (principally cout...).
1858 * gdcmPython/testSuite.py now cleanly removes temprory generated
1860 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1861 comply with above changes)
1863 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1864 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1865 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1866 vtk data structure (an image Flip was required).
1867 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1868 * cosmetic changes in documentation.
1870 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1871 * src/gdcmHeader.cxx: the constructor no longer exits when an
1872 unexisting file is given as argument.
1873 * The subdirectory Data (containing all the images used for the
1874 test suite) is not part of this repository anymore. A new module
1875 containing those images is now available at
1876 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1877 with the name gdcmData.
1878 All the python scripts (including the package initialisation file
1879 gdcmPython/__init__.py) were adapated to take this change into
1880 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1882 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1883 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1884 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1885 demo of the usage of this class.
1886 Compilation of this vtk part is only done when using the --enable-vtk
1887 at configure (or autogen.sh) stage.
1889 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1890 * More memory link related corrections and documentation fixes.
1892 - maximum info is obtained with a command of the form:
1893 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1894 --show-reachable=yes PrintHeader
1895 - the remaining reachable blocks seem to come from the STL
1896 allocation scheme through the usage of map and list. It looks
1897 like this memory cannot be freed but it is not a memory leak
1898 (in fact further invocation to the STL would recollect the
1899 unused memory allthough it cannot explicitely be freed).
1900 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1901 of displaying an image parsed with gdcm and displayed with VTK.
1902 Note: some images don't seem to work e.g.
1903 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1904 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1905 Allthough this weakens the semantics, it is a ditch attempt to
1906 make gdcm more thread friendly.
1908 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1909 * Memory link hunt (by using valgrind through the command
1910 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1911 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1912 gdcmHeader::_dicom_vr.
1913 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1914 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1916 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1918 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1919 * src/Makefile.am now exports all the necessary include files at
1923 * UpdateGroupLength replaced by new one
1926 * UpdateGroupLength re-written using H-Table
1927 (named UpdateGroupLengthNew untill checks are over)
1929 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1930 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1931 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1933 - gdcmHeader::GetPubElValSet removed.
1934 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1935 UpdateGroupLength, WriteElements, Write.
1936 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1937 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1938 carried the same semantics.
1939 - src/gdcmHeaderIdo.cxx changed accordingly.
1940 - gdcmFile::WriteBase now regroups all the codes from previous
1941 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1942 - enum FileType moved to gdcmCommon.h
1943 * src/gdcmHeader.cxx AddDefault trashed
1944 * gdcmGetXSize added
1945 * getimageDataSize now calls gdcmGetXSize
1946 * Test/*.cxx changed to agree with above changes
1948 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1949 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1950 (to avoid double call by end user).
1951 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1952 by end user, since gdcmHeader::gdcmHeader now handles it.
1954 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1955 * gdcm/Doc many doxygen changes:
1956 - Doxyfile now has two different versions, DoxyfileUsers that generates
1957 the html.users end users oriented documentation and
1958 DoxyfileDeveloppers that generates the html.developper developper
1959 oriented documentation.
1960 - README changed accordingly
1961 - requirement.txt removed (old design info moved to TODO).
1962 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1963 DoxyMainPage.txt, DoxyPython.txt provide more information.
1964 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1965 be updated by simply regenerating the docs with doxygen and copying
1966 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1967 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1968 all the tests in the form "if (<map>.count() >1)" were removed.
1969 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1970 ill-formed documentation sections.
1971 * src/gdcmHeader.cxx: ditto
1973 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1974 * setup.py fixed for un*x (needed macro for stdint.h)
1975 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1976 un*ces with sh-utils test utility.
1977 * gdcmPython/demo/test.py renamed to PrintHeader.py
1978 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1979 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1980 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1981 * src/gdcm*.cxx JPR's bad inclusion fixed.
1983 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1984 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1985 * gdcmPython/demo/test.py changed accordingly.
1987 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1988 * gdcmPython/Makefile.am fixed linking against libstdc++
1989 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1990 * Swig subdir (historical tests of swig version 1.3.17++) removed
1991 * Test/testChangeEntete.cxx some lines commented out in order to make
1993 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1994 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1996 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1997 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1998 hence the user doesn't need this explicit call.
1999 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2000 i.e. LoadElements() call removed.
2001 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2002 - src/Makefile.am declares the proper flag for g++.
2003 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2004 for adding user defined new tags.
2005 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2006 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2007 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2009 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2010 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2011 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2012 src/Makefile.am : the project should properly compile and install
2013 with the autotools, included the python wrappers part.
2014 * gdcm.spec.in : added a spec file for RPM packaging.
2016 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2017 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2019 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2020 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2021 to exported to the environement (see gdcmPython/testSuite.py
2023 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2024 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2025 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2026 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2027 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2029 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2030 * gdcmPython/__init__.py doesn't crash anymore when running in
2031 in InstallMode or PreInstallMode but with an environement given
2032 value of GDCM_DICT_PATH.
2033 * src/gdcmDictSet.[cxx/h] coding style.
2035 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2036 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2037 * src/gdcm.h general comments moved to TODO, and README
2038 * src/gdcm.h should now be seen as a user commodity (including it
2039 should suffice to fully use gdcm). It is nowhere including within
2040 any of the kernel files src/*.cxx and src/*.h.
2042 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2043 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2044 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2046 * src/gdcm*.cxx only include their corresponding include file
2047 (as opposed to gdcm.h)
2048 * gdcmPython/gdcm.i changed accordingly
2049 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2050 the autogen.sh generated "make snapshot" command to work.
2051 * autogen.sh removed history related references to crea package.
2053 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2054 * distutilsSwigCPlusPlus.py work around some swig portability
2057 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2058 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2059 was done in a last ditch attempt to get setup.py _really_
2060 operationnal. The python/gdcmPython layaout add the advantage
2061 of hidding away the python related distutils specific files
2062 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2063 Alas, the src directory was out of scope (i.e. it's relative
2064 position to setup.py was ../src) which made things impossible to
2065 handle (see previous version of python/setup.py). Crossing fingers...
2067 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2068 * python/setup.py now works on Un*x. (harder than I thougth)
2069 * python/distutilsSwigCPlusPlus.py can now have include files
2070 among the list of sources.
2072 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2073 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2074 * modifications in MSVC projects
2076 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2077 * As stated by the first lines of Test/ExceptionAndPython/README, it
2078 looks like we can move back to original usage of exception within
2079 src/gdcm* and hence remove the errno stuff that was introduced
2080 as a quick and dirty fixture of this problem (added to the TODO).
2081 * Doc/Doxyfile configuration file for Doxygen and corresponding
2082 README file for usage added.
2083 * Test/testWrite.cxx added. This new test comes from a split of
2084 test.cxx that is now reverted to its original purpous i.e.
2085 testing the proper parsing of a Dicom related file.
2086 testWrite.cxx concentrates on testing the IO part of gdcm.
2087 * Test/bug1.cxx (containing a bug on WIn32) added.
2088 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2089 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2090 whose purpose is to publish the content of the TagNames of the
2091 Dicom public dictionnary were not accessible without an
2092 instance of class gdcmHeader.
2093 - those methods are now static methods of gdcmDictSet and hence
2094 require no instances at all to be invocated.
2095 - within gdcmDictSet this change required to change some method
2096 to class methods (i.e. are now static) among which SetDictPath
2097 (renamed to BuildDictPath) and LoadDefaultPubDict.
2098 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2099 the above changes by calling the new method classes of gdcmDictSet.
2100 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2101 the above to be effective.
2102 * python/gdcmPython: in order to wrap properly the above changes
2103 for Python, swig version now needs to be > 1.3.17.
2104 * python/gdcmPython/Makefile fixed to adapt itself to new
2105 configure/make shema introduced by Johan Montagnat (thanks for the
2106 contribution). Alas this Makefile cannot be turned into a proper
2107 Makefile.am without some heavy changes in the configure.in
2108 (for python dectection).
2109 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2110 now avoids publishing the empty entries.
2112 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2113 * python/setup.py : bug fix concerning install under windows
2114 ExtraPath reused :-P
2115 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2117 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2118 * Dicts/dicomV3.dic : remove double spaces !!!
2119 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2120 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2123 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2124 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2125 method. Doxygenation.
2126 * src/gdcm.h clean up of JPR spurious comments.
2128 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2129 * python/distutilsSwigCPlusPlus.py now properly collects the
2130 shadow classes generated by "swig -c++" (gdcm.py in our case)
2131 when using "python setup.py install".
2132 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2133 reexports the working classes.
2134 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2135 by the classical C errno scheme. This is to prevent an obscure
2136 behavior of the python wrappers when importing wxPython.wx prior
2137 to gdcmPython (which ended up in an abort call). An illustration
2138 of this oddity can be found in the Test/ExceptionAndPython
2139 subdir (see the README file). This problem probably due to
2140 an combination of g++ and dynamic loading.
2141 * added Test/ExceptionAndPython (see above)
2143 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2144 * Changed the layout of the python part to avoid bloating main
2145 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2146 i.e. the distutils arsenal. All the python related stuff is
2147 again in a python subdir, but the package itself is now in
2149 * setup.py was cleaned up:
2150 - pythonIncludePath removed
2151 - python setup.py bdist target is now functional.
2152 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2153 collision with other packages). gdcmPython/demo/*.py changed
2156 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2157 * python subdir moved to gdcmPython (preparation of distutils packaging).
2158 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2159 distutils installer is operational.
2160 * - gdcmPython/__init__.py now properly loads the swig generated
2161 shadow classes (from gdcm.py).
2162 - gdcmPython/demo/*.py changed to import the package gdcmPython
2163 instead of gdcmPython/demo/load.py.
2164 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2166 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2167 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2168 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2169 entries within the associated public Dicom dictionary resp. the same
2170 information but sorted by the fourth field (PAT, IMG, DIR) of the
2172 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2173 are now in the "???" group.
2174 - python/gdcm.i changed accordingly,
2175 - python/demo/printGroupedPublicDict.py added, that gives an example
2176 of the above new functionalities in Python.
2178 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2179 * src/gdcm.h, gdcmHeader.cxx:
2180 - historic references to glib's g_malloc and g_free (#defined)
2181 were definitively removed.
2182 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2183 * src/gdcmElValSet.cxx:
2184 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2185 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2186 - GetElValue(string) renamed to GetElValueByName.
2187 - Added GetElementByName(string).
2188 * src/gdcmHeader.cxx: added
2189 - GetPubElValRepByNumber(guint16, guint16)
2190 - GetPubElValRepByName(string)
2191 - GetShaElValRepByNumber(guint16, guint16)
2192 - GetShaElValRepByName(string)
2193 - GetShaElValByNumber(guint16, guint16)
2194 - GetShaElValRepByName(string)
2195 - GetElValRepByNumber(guint16, guint16)
2196 - GetElValRepByName(string)
2197 - GetElValByNumber(guint16, guint16)
2198 - GetElValRepByName(string)
2199 * Doc/requirements.txt added.
2201 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2202 * Test/Makefile building now depends on the one of libgdcm.so
2203 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2204 pixel data) aware which enables finding the address (offset) of
2205 the pixel data of JPEG encoded DICOM files. This leaves only a single
2206 file in the testSuite whose pixel data address (offset) is unknown.
2207 * python/testSuite.py changed accordingly.
2209 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2210 * VC++ has some strong limitations when working with the STL, as stated
2211 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2212 "Also note that some STL containers (map, set, queue, list, deque)
2213 cannot be exported. [...]
2214 Some STL classes contain nested classes. These classes can not
2216 This is caused by a designed limitation that once a template
2217 class is instantiated, it can not be re-instantiated and
2219 Since our usage of map<> is ubiquitous in gdcm, this "designed
2220 limitation" of VC++ is a pitfall.
2221 Hence the Python wrappers of gdcm cannot be incrementally linked
2222 against the c++ dynamic library. The dirty but only workaround is
2223 to forget about incremental link of dynamic libraries and to generate
2224 the Python wrappers library with the inclusions of the underlying C++
2226 The following modifications concern this matter on Win32/VC++:
2227 - wrapping python correct with standalone wrapped dll (don't use separate
2228 dll under windows !!!!)
2229 - python21_d debug mode enabled (ask Frog how to use it :-)
2230 - NO problem with having an STL member of class for example string in C++
2231 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2232 - Python test of dcmlib in Python is ok under windows on a large set
2234 * removed glib references
2235 * typedef's inserted in gdcm.i for correct swig type management
2237 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2238 * python/demo/*.py load.py extracted from test.py. Added explore.py
2239 that only displays required tags and testAll.py that parses all
2240 the files of the testsuite without using unittest.
2241 * python/testSuite.py other additional test on new files added.
2242 * Data/* new test files added accordingly to the testSuite.
2243 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2244 the vr in the file differs from the one of the dictionary.
2246 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2247 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2248 values, but limits itself to values which are below a user specified
2249 size (by default 1024 bytes).
2250 * python/gdcm.i : elements not loaded (because their size is above the
2251 user specified treshold) are exported with their TagKey as key of the
2252 python dictionary. This enables the testsuite to make some checks
2253 on the unloaded elements (since we have their offset and size).
2254 * python/testSuite.py
2255 - now tests for the existence and proper value of the pixel data
2256 - two new examples added.
2257 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2259 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2260 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2261 aware. See the strategy comments in gdcmHeader::FindeLength().
2262 * Test/test.cxx now accepts a filename as first argument.
2263 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2264 * python/testSuite.py changed to integrate test on above files.
2266 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2267 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2268 the vr was also RET.
2269 * python/testSuite.py more tests added.
2271 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2272 * python/testSuite.py unittest test suite added (uses Data)
2273 * Data/* dcm and acr files for the test suite.
2274 * glib dependance removed from un*x version. We now use ISO C99
2275 7.18 Integer types (see stdint.h)
2276 - python/Makefile, src/Makefile src/gdcm.h
2277 * src/ when an explicit vr (like dicom files) suddenly poped an
2278 implicit element we use to mark the underlying DictEntry of the
2279 concerned ElValue with "Implicit". This strategy was damageable
2280 too the public or provite dictionaries, since some of their vr
2281 would be changed. Since Header::FindLength heavily relies on the
2282 detection by Header::FindVR of falsely explicit elements, I
2283 added an extra ImplicitVr member to ElValue (boolean).
2284 The rest of the changes we the necessary adaptations.
2286 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2287 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2289 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2291 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2292 * Adaptation for porting to VC++:
2294 o forced to use std namespace (for string to be known)
2295 o all class use __declspec export style on WIN32
2296 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2297 (in stdlib.h on Win32 but in std:: for gcc)
2298 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2299 variable GDCM_DICT_PATH.
2300 * src/gdcmHeader.cxx verbose comments made discrete.
2302 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2303 * python/gdcm.i: added a typemap that converts a C++ hashing table
2304 to native Python dictionary.
2305 * python/demo/test.py:
2306 - now uses the native dictionary for exploration of gdcmHeader.
2307 - takes an optional filename argument (the file to parse).
2308 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2309 PubElVals hashing table.
2310 * Dicts/dicomV3.dic removed error prone trailing spaces.
2312 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2313 * Python wrapping process moved away from src/Makefile to
2314 newly created python/Makefile (as well as gdcm.i)
2315 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2316 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2317 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2318 from the environement variable GDCM_DICT_PATH (when existing).
2319 * src/gdcmDict::GetTag bug fix.
2321 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2322 * Straightforward temporary fixes for swig to build the python wrappers.
2323 src/Makefile now has a python working entry [by working we mean
2324 that we can import de shadow classes without errors].
2326 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2327 * hashtest.cxx removed (since allready in Test)
2328 * src/gdcmlib.h renamed to src/gdcm.h
2329 * src/dcm.i renamed to src/gdcm.i
2330 * src/Makefile prepared for python wrapping
2332 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2333 * src/gdcmHeader.cxx :
2334 - Parsing of header is now separated from loading of element values
2335 (see gdcmHeader::LoadElements).
2336 - general clean up of hopefully all file access (creation of
2337 ReadInt16 and ReadInt32)
2339 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2340 * src/gdcmHeader.cxx :
2341 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2343 - SetLgrElem renamed to SetLength
2344 - GetLgrElem renamed to GetLength
2345 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2346 * src/gdcmElValSet.cxx fixed both GetElValue methods
2347 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2348 due to IdoDude was cleaned out.
2350 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2351 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2352 concentrates on finding the value representation (when it exists).
2353 RecupLgr now only finds the element value length, and it avoids
2354 returning the unecessary skL (skipped length).
2355 Also, offsetCourant was simply removed (with taille_fich) since
2356 it was redundant with the File position internals (by using
2357 ftell and fseek). This also made skL (see above in RecupLgr) usage
2359 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2360 on the libido specificities which are handled through class
2362 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2365 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2366 * Truckload of changes. Parsing of header is barely functional
2367 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2369 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2370 * src/gdcmHeader.cxx many addons of low level methods
2372 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2373 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2374 and _IdDcmSWAP_LONG.
2376 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2377 * This corresponds to all the changes decided at the meeting of
2378 May 23 2002. Needless to say we are running late...