1 2005-05-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Adding potential support for mpeg and jpeg2000 through two new lin
4 - libmpeg2 from the MPEG consortium
5 Also adding intial work to use this lib.
7 2005-04-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
8 * Testing/TestAllReadCompareDicom.cxx : update the test printed results and
11 2005-04-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
12 * FIX : Numerical exception on borland (cannot divide by 0, doh !)
13 But this is a case where we should really signify the user there is
14 few chance the serie is really a serie...
16 2005-04-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
17 * FIX : on X, the python part is correctly installed. All files are
18 installed in gdcm sub-directory
20 2005-04-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
21 * Builder/ : add something to facilitate the RPM creation of gdcm
23 2005-04-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
24 * Fix gdcmDirList::IsDirectory. Apparently borland did not like the ending
26 * Also fix compilation on gcc 3.3.5 does not have ios::failure either ...
28 2005-04-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
29 * vtk/vtkGdcmWriter fix bug when writing spacing. The Y spacing comes first
31 * Fix compilation on gcc 2.96 (which does not have ios::failure)
33 2005-04-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
34 * src/gdcmDictGroupName.[h|cxx] : add a correlation between a group (number)
35 and it's representation name (for the NIH)
37 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
38 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
39 conversion of YBR to RGB pixels. So, now, the conversion is made using
42 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
44 format) to replace 'at-run' dicom files generated by the
45 TestAllReadCompareDicom test
47 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
50 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
51 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
53 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
54 * Testing/TestMAkeIcon.cxx : complete the test
56 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
57 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memroy leaks
59 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
63 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
64 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
66 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
67 * Test/ : accelerate tests (it's not very significant accelerations).
68 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
70 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
71 * Testing/TestSequence.cxx : add test for sequences of images... test that
72 we have the same serie or the same study UID
74 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
75 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
77 * src/gdcmDict.h : remove commented code
78 * src/gdcmDocument.cxx : initialize values
79 * src/gdcmFile.cxx : bug fix when reading values
80 * gdcmPython/demo/ : change file names. Remove useless files
82 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
83 * src/gdcmFile.cxx : remove the default array of initialization.
84 The static array contained pointers to non-static values (comming from
85 strings). To have coherences, when creating files, these values can't be
86 static. So, the array can't be static, too ! To simplify, the array have
87 been replaced by repeted lines to insert values in the File
89 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
90 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
91 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
93 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
94 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
95 (Dicom Element) into the Sequence Item
97 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
98 * src/*.cxx : first parss to normalize file organisation
100 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
101 * src/gdcmDirList.[h|cxx] : add method to find a directory
102 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
104 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
105 * Finish cleaning up my JPEG mess. Should be ok now.
106 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
107 contained within the RLE* class(doh!)
109 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
110 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
111 * SerieHeader::AddFileName() creates as many Coherent Files lists
112 (same Serie UID) as it founds different Serie UID
113 amongst the files instead of discarting any file
114 that doesn't match with the first one he found.
115 * SerieHeader::OrderGdcmFileList has now one parameter :
116 the Coherent Files list the user wants to sort
117 * SerieHeader::GetFirstCoherentFileList() |
118 * SerieHeader::GetLastCoherentFileList() | allow to parse
119 the set of Coherent Files lists
120 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
121 compatibility (it returns the *first* Coherent Files list,
122 since there was only one before)
123 * Test/TestSerieHeader gets gdcmData as a default root directory
125 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
126 * Remove friend between DocEntry and File classes
127 * Remove friend between PixelReadConverter and RLEFramesInfo,
130 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
131 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
132 0002|0000. The value was incorrect.
134 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
135 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
137 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
138 * src/gdcmUtil.cxx : compilation fix on Win32
139 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
140 variable, to be easy found. Add methods to change the default UID.
141 Amelioration of the CreateUniqueUID to use the correct default UID.
142 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
145 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * Test/TestVR.cxx : fix memory leaks
148 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
149 * Rewrite the base 256 to base 10 conversion, using string operation only.
150 This allows us to get rid of the problematic 64bits integer type (does not
151 always exist on target platform).
153 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
154 * Add construct and destructor to class gdcm::Debug to close the debug file
156 * Don't let uset to open twice the same file
157 * gdcm has now an official UID prefix,
158 supplied by http://www.medicalconnections.co.uk
159 1.2.826.0.1.3680043.2.1143
160 (Thx to Mathieu for providing URL)
161 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
162 to be able to perform some more tests
163 * gdcm::ContentEntry : Contructors and Destructor are now protected,
164 in order to be sure no user will try to use them.
165 (at user level, only the children classes are meaningfull)
167 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
168 * move RLEInfo & JPEGInfo from Document to File
170 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
171 * FIX : remove so many friend between classes
173 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
174 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
175 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
177 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
178 In order to avoid missbehaviour :
179 . gdcm::DocEntry is now specialized in
180 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
181 - gdcm::ContentEntry (Dicom entry with a 'content')
182 . gdcm::ContentEntry is specialized in
183 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
184 characters value, or integers)
185 - gdcm::BinEntry (Dicom entry with a non strig representable value
186 (user hasn't any longer to thing about the precedence of his dynamic_casts)
188 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
189 * Test/VTKTest*.cxx : bug fix under linux
191 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
192 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
193 use with python. Some methods are moved from Document to ElementSet or
194 DocEntrySet. The equivalent methods to ElementSet have been added to
195 SQItem and are virtual in DocEntrySet. Methods that may have the same code
196 in SQItem and ElementSet is directly placed in DocEntrySet
198 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
199 * Test/VTKTest*.cxx : remove the show variable in each test method because
200 it's useless (the viewer variable replace this variable)
202 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
203 * src/gdcmDocument.cxx : bug fix on potential memory leak
204 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
205 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
206 Add ClearXxx methods to remove all the content of the list or map
207 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
209 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
210 * methods ReplaceOrCreate renamed as Insert
211 (nobody will be any longer confused by 'CreateOrReplace')
213 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
214 * Grealty simplify the JPEg decompression, no need to differenciate based on
215 the JPEG possible type (with/without fragment, with/without multiple frame).
216 Everything is done throught the JPEG IO Suspension mechanism in IJG
218 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
219 * Stage 3 of normalization :
220 in order to avoid any missunderstanding while reading method names :
221 - All the methods xxxEntry now deal with dicom Entries
222 - Methods GetEntry splitted into
225 - Method SetEntry renamed as SetEntryValue
226 - Method SetEntryBinArea let as it was
228 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
229 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
230 - Position correctly the entry points for JPEG2000 and JPEG-LS
231 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
233 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
234 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
235 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
236 with other method names
237 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
238 * Test/TestDicomDirElement.cxx : add new test
240 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
241 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
242 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
243 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
244 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
245 So can't you use __int64 in ostream at all.
247 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
248 * bug fix for compilation on MSVC6
249 * gdcmPython/gdcm.i : rename of classes missed
251 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
252 * Stage 2 of names normalization :
253 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
254 (easy to understand ...)
255 - gdcm::FileHelper replaces old class gdcm::File
257 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
258 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
259 type and not a string. So, there remove problems on the format of the
262 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
263 * Add Example/TestPapyrus.cxx
264 - reads a Papyrus file (gdcm::Header compliant),
265 - gets the pixels of all the images, using low level iterators
266 - writes an multiframes Dicom image.
267 (Just to show it's *possible* to do that)
268 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
271 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
272 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
273 Thus, DicomDirXXX are created with a flad that indicates if the created
274 object is empty or not (when not empty, the DicomDirElement is used to
277 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
278 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
279 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
281 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
282 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
284 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
285 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
286 Remove all access to the hash-tables or lists in the objects.
288 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
289 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
290 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
291 be complient with all the gdcm source code
293 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
294 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
297 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
298 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
301 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
302 * Test/ : rename VTK tests to have a best name for the tests
303 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
304 GetFirstEntry/GetNextEntry use
306 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
307 * In SerieHeader::ImagePositionPatientOrdering()
308 // a Dicom 'Serie' may contain scout views
309 // and images may have differents directions.
310 // -> More than one may have the same 'pos'
311 // Sorting has then NO meaning !
312 Thx to Eduardo Davila for reporting bug.
314 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
315 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
316 test. Now it's on image content and not on the resulting visualisation...
317 might solve the problem on linux when using the OpenGL drivers
319 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
320 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
321 DicomDirSerie, DicomDirImage
322 Dict, DictSet classes :
323 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
324 -remove InitTraversal method.
325 * UPD Test programs + Example programs
327 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
328 * remove useless and never updated keyword \ingroup
329 * Solve pb when structure (list, map, ...) is empty.
330 Thx to Benoit for reporting bug
332 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
333 * Taking into account of 'Transfer Syntax' value
334 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
337 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
338 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
339 is no memory access violation
340 * gdcmPython/demo : add python demos using VTK
342 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
343 * FIX 'Dictionnary' is now spelt 'Dictionary'
344 'wether' is now spelt 'whether'
345 'archieve' is now spelt 'archive' ;-)
347 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
348 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
349 related methods, in order not to expose internal mechanisms
352 * REM methods that exposed internal mechanisms :
353 DicomDir::GetDicomDirPatients()
354 DicomDirPatient::GetDicomDirStudies()
355 DicomDirStudy::GetDicomDirSeries()
356 DicomDirSerie::GetDicomDirImages()
357 * UPD Test programs :
361 * UPD Example program
363 * ADD DictSet methods
367 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
368 * Removed the Print/indent/default parameter mess. There is absolutely no
369 reason to have to methods, moreover with the second taking the ostream as
370 *SECOND* parameter. This was clearly a bad hack to get things compile.
372 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
373 * Complete rewrite of the GetMacAddress code. Now the code is *much*
374 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
375 Unfortunately the main code does not work on SunOS, thus provide a specific
376 code for this platform only (and Win32 of course). Since this seems to be
377 working, change CreateUniqueUID to use GetMACAddress instead of the
378 problematic GctestetIPAddress
380 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
381 * Unfortunately to be able to test gdcmDirList I had to break the API
382 a little. Now the class is not a std::list anymore but has a member
383 std::vector (more ITK compatible). Allow unit testing on Win32 and
386 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
387 * Update SerieHeader to take into account a Serie Instance UID to properly
390 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
391 * ENH - Comment out Mathieu's (dangerous) Super Hack
392 for dealing with BIGENDIAN processors
393 - Move equivalent stuff to BinEntry::WriteContent
394 When necessary, 16 Bits Pixels are swapped in a small buffer
395 and then written. This avoid allocating a huge buffer, in
396 PixelWriteConvertor, and avoid modifying the Pixel Area.
398 Probabely, the same operation will have to be done when we want
399 to write image with Big Endian Transfert Syntax,
400 and we are working on Little Endian Processor
402 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
403 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
405 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
406 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
407 all the dict content.
408 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
410 * Test/TestDict.cxx : add a new test for the dict classes
412 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
413 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
414 file. Debug is yanked if compiled with NDEBUG
416 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
417 * src/gdcmDictSet.h : set the default output to the os variable
418 * src/gdcmDictEntry.[h|cxx] : add the Print method
419 * gdcmPython/demo/ : add a new test
421 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
422 * merging of Test/PrintDicomDir and Test/TestDicomDir
423 * removal of now redundant Test/PrintDicomDir
424 * enhancement of Example/PrintDicomDir
426 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
427 * Now, python test might work on systems
428 * Add the PrintDicomDir test
430 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
431 * FIX : First entry following group 0002 was lost for
432 Explicit Big Endian Transfer Syntax files
433 (group and elem not swaped)
435 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
436 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
437 Big Endian Transfer Syntax supposed the group following 0002
438 begins always by element 0000 (element 0000 is *optional*)
439 To avoid further troubles, let's be pessimistic, and use
440 Document::HandleOutOfGroup0002() method
441 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
442 (related pb not yet solved)
444 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
445 * Bug fix for the python part use
446 * Now, PrintHeader.py pass... but outside the ctest use. shit !
448 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
449 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
451 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
452 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
453 a string and should ask the global TS dict what are the propreties of
456 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
457 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
458 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
459 to swap the Swap Code, at parsing time, when we come out of group 0002
460 and Transfer Syntax is Big Endian
461 We should be able to read now 'true DICOM" Big Endian coded images
462 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
463 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
465 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
466 * Hopefully fix the bug on MacOSX and static global initialization.
467 This is the only -minor- patch I found that both please MacOSX and VS6.
468 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
469 but this would require a lot of change. Another approach would be that Global
470 create those string and GDCM_UNFOUND becomes a pointer to a string (which
471 gdcm::Global would destroy at exit).
473 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
474 * Fix bug on MacOSX with static initialization in a multy threaded
475 environment. static const string in a header file used to be ill
476 initialized provoquing the freeze of any tests. patch should solve this
479 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
480 * According to Benoit's suggestion, and without any objection from anybody
481 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
482 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
483 - method gdcmDicomDirObject::GetEntry() renamed as
484 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
486 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
487 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
488 you debug/warning message just as c++ streams which make them very convinient
489 to use. Once this is stabilize I will change the ostringstrem to be
490 redirected to a file (ofstream).
491 * Properly support C99 extension: __FUNCTION__ which allow us to display
492 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
494 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
495 * Removal of useless and dangerous methods :
496 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
497 GetDocEntryByName, GetEntryByName, GetDictEntryByName
498 * Removal of usless methods :
499 Dict::PrintByName, Dict::GetDictEntryByName
500 * Commenting out of probabely useless methods :
501 Dict::GetDictEntryNames()
502 Dict::GetDictEntryNamesByCategory()
503 DictSet::GetPubDictEntryNames()
504 DictSet::GetPubDictEntryNamesByCategory()
505 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
506 * ENH : Use dicomTS.dic as described in 2004 version
507 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
508 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
509 Add Accessors on VM (Value Multiplicity), and VM related methods
510 * ADD : Add a list of 'Dicom Attribute types', as found in
511 http://medical.nema.org/dicom/2004/04_15PU.PDF
513 * ADD : Add dicomGroupNameAbbreviations.dic
514 should be used to write a method to replace the former
515 Dict::GetDictEntryNamesByCategory()
517 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
518 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
519 to read in the file... and only it ! Length is the efective length of the
520 data in the DocEntry structure
522 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
523 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
524 And now use a static function call instead, with a global variable. i
525 This is much closer to the VTK approach. Hopefully should be bulletproof
526 and easier to use...hopefully
528 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
529 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
531 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
532 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
534 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
535 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
536 ValEntry, BinEntry, SeqEntry creation or replace
538 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
539 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
540 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
542 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
543 when specifying the VR
544 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
545 * src/gdcmDocEntry.cxx : amelioration of print
547 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
548 * ADD : Add the method Util::IsCurrentProcessorBigEndian
549 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
550 * ADD Method Document::ComputeGroupLength
551 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
552 in order to allow further VR modification by user
553 * REM : removal of once-called method File::WriteBase
554 integration of its code in formerly one-line method File::Write
556 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
557 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
558 replace the different values "??", "Unkn", "Unknown".
559 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
560 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
561 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
562 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
564 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
565 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
567 * Set the gdcm::Base class to some Printable classes
569 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
570 * src/gdcmFile.[h|cxx] : add the Print method
571 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
572 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
573 * src/gdcmDocument.h : remove the PrintLevel informations
574 * Example/PrintFile.cxx : use the new gdcm::File::Print
576 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
577 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
578 problems when compiling with the python wrapping
580 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
581 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
582 writting in ImplicitVR
584 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
585 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
586 JPEG decompression, especially when dicom frames are split into several
587 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
588 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
590 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
591 * src/gdcmHeader.cxx : change the initialisation of default header.
592 Now, this header is readable by gdm, e-film, DicomWorks
594 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
595 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
596 Rename Decompressed to Raw
597 * Use the API changes in gdcm::File.
598 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
601 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
602 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
603 each added entry in the header. Replace the 'Planes' field by the 'Number
606 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
607 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
608 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
610 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
611 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
612 At this time, this image isn't readable by e-film... waiting JPR help to
615 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
616 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
617 DocEntry. Now use methods of the Document !
619 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
620 * Test/ShowDicomSeq.cxx : bug fix
622 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
623 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
624 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
625 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
626 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
628 * Test/TestCopyRescaleDicom.cxx : remove unused variable
629 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
630 containing found sequences
632 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
633 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
635 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
636 Some fields in BinEntry must be copied to not seg fault when making the :
637 gdcm::File *copy = new gdcm::File( copyH );
638 and tests are now made on good variables
640 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
641 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
642 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
644 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
645 * Add vtkGdcmWriter example and test
647 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
648 * Test/TestUtil.cxx : reformat the source code
649 * vtk/vtkGdcmReader.cxx : remove and change prints
650 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
652 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
653 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
655 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
656 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
657 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
659 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
660 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
661 by an eof to prevent all bad read of the file... and in this case, the
664 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
665 * Example/Volume2Dicom.cxx : comment unused variables
666 * Test/PrintDicomDir.cxx : comment unused variables
667 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
668 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
669 method that is redondant with AddEntry.
670 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
673 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
674 * Bug fix due my last commit (compilation under Windows).
675 * Example/Volume2Dicom : bug fix in the file and reformatting source code
676 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
678 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
680 - Remove printf / sprintf
681 - include iostream AFTER gdcm so we don't get warnings
682 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
684 - Also remove tons of include from header files, hopefully this should
685 speeup the compilation time, since it was becoming a dog slow.
686 - Remove gdcm.h as it include way too many files and slow down compilation
687 (plus it is not up to date)
688 - remove 'using namespace std' this is BAD !
690 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
691 * Remove memory leaks on the DicomDir
692 * Remove some useless data in DicomDirObject
693 * Add usefull methods in SQItem, to be complient withe the ElementSet
695 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
696 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
698 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
699 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
700 future, with convertion)
701 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
702 and ImageDataSize values. Remove the method to get the PixelReadConverter
703 from the output of the class
705 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
706 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
708 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
709 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
710 and vtkErrorMacro use.
711 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
713 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
714 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
716 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
717 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
718 The string leaves only in the fonction. So when we make a .c_str(), we
719 get the pointeur on the first element, element that will be destroyed
720 immediately after thee instruction.
721 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
722 file has been opened : the test must be made on the content of the
723 pointer and not directly on the pointer !
726 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
727 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
728 the python part recompiles
730 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
731 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
732 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
733 X session is killed (for my computer... it seems to not be identic on
736 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
737 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
738 avoid problems (otherwise, the difference test between the visible image
739 and the reference is incorrect. If the reference is greater than the
740 screen resolution, it's produce errors).
741 Can be used for only one image. Can be used with a visible flag.
742 * vtk/vtkGdcmReader.cxx : remove commented codes.
743 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
744 under windows at compilation
745 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
747 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
749 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
750 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
751 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
752 tests on the image size X, Y, Z
754 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
755 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
756 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
757 between the class name and the file name
759 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
760 * src/ : fix compilation warnings for the Write method (2 different
761 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
762 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
763 variable... create a static method in gdcm::Document to access to
764 this variable content.
766 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
767 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
768 file, to be accessed by other files (like gdcmFile). Remove commented
769 code. Move the change of the header to the gdcmFile, using the
771 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
772 To be sure of that (and simplify calls), the Write of the header now
773 gets a file name and not a file pointer (std::ifstream).
774 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
775 DocEntryArchive. Remove all open of the written file
777 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
778 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
780 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
781 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
782 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
784 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
785 some corresponding methods. Write correctly the file and check before
787 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
788 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
789 is now on RGB data (as before my last commit
790 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
792 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
793 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
794 Add a print information of the type of the entry
795 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
796 It was in the gdcmFile, and all write have been regrouped
797 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
798 Write correctly all dicom files (in decompressed mode only at this time)
799 * Test/ : test on files are now made using Raw data and not color data if
801 * Example/PrintFile.cxx : add more printings
803 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
804 * Amelioration of code, remove some code copy. For the loading of
805 BinEntry (in gdcmDocument), add the test to verify if the file is already
808 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
809 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
810 remove a DocEntry in the header (push an empty DocEntry)
811 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
812 lines. Bug fix in the initialization of the PixelConvert and the
814 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
815 use in TestCopyDicom (now this test can run under windows... but fails)
816 * Test/TestCopyDicom.cxx : amelioration of the test :
817 - test the pixels written
818 - add test points to quickly find where is the error
819 - can set a file name input and output in arguments
820 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
821 amelioration of the test output
823 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
824 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
825 all replaced DocEntry's
826 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
827 Now, each needed DocEntry to modify is duplicated, modified and inserted
828 to the header using DocEntryArchive. Thus, after save, we can restore the
829 header initial state.
831 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
832 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
834 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
835 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
836 correct to copy it. The DictEntry is specified at the DocEntry creation,
837 then, it musn't change in the time.
838 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
839 header correctly. At this time, the change is only made for the first
840 level of the Document. In the future, it might consider sequences.
841 The change is made by replacing a DocEntry by an other that is created
842 outside the class. The old value is kept. When we restore the header
843 status, the added DocEntry is deleted and replaced by the old value.
844 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
845 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
846 set the write type to explicit VR, implicit VR or ACR. Add methods to set
847 the write mode to native, decompressed or RGB (but not used at this time)
849 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
850 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
851 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
853 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
854 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
855 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
857 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
858 set because already copied when copying the BinEntry's of the header
859 * Test/TestAllReadCompareDicom.cxx : remove warnings
861 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
862 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
863 Two problems appear when doing it :
864 - with the gdcmFile : when the GetImageData method is called, the pixels
865 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
866 data (pixels). And each structure destruct the data when it's
867 destructed. So we have two destructions for the same data. To solve it,
868 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
869 data or not. If it doesn't own data, then they will not destroyed by
871 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
872 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
873 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
874 create a double destruction of the same DocEntry's. So, to solve it,
875 the TagHT is simply cleared and the DicomDir* elements are destroyed.
876 * TODO : add an entry concerning memory leaks in the DicomDir
878 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
879 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
880 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
883 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
884 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
885 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
886 after it have been deleted
888 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
889 * FIX: src/* fix the doxygen warnings.
890 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
891 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
892 was erroneously defined with a size of 15 instead of 16. [many thanks
893 to Jean Michel Rouet for pointing out this bug].
895 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
896 1. Finish merging JMR patch for writting DICOM from scratch
897 2. Fix -hopefully- bug with MONOCHROME and space vs null character
898 3. Use const ref when possible
899 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
900 5. A few more comments
901 6. CreateUniqueUID can now be called without parameter"
903 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
904 * ENH: Slightly bigger patch:
905 1. Getting toward full integration of JMR patch for writting dicom from scratch
906 2. Update Test to test part of this patch: CreateUniqueUID
907 3. File was not close properly in gdcmDict
908 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
909 5. Use of const ref instead of copy (speed issue)
910 6. Remove temporary (duplicate) string in TranslateToKey
911 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
912 8. Do not repeat virtual in subclasses
913 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
915 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
916 * Apply first patch toward better string comparison when dealing with broken
917 DICOM files. Essentially the string could be padded with a space instead
918 of a null character as defined by standard
920 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
921 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
922 because never used... and in the same time, that's remove some memory leaks
924 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
925 * src/gdcmFile.cxx : now delete the PixelConvert instance.
926 * In examples and tests : change the type of image data variables from void*
927 to uint8_t*. Remmove all delete on image data variables
929 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
930 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
931 Verify the file pointer value before open the file, and if it's not null,
932 a verbose message is generated.
933 Close correctly the file when the file isn't considered dicom-like. The
934 correctly close is a call to CloseFile.
935 When closing the file pointer, test if its not null to close the file.
936 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
937 file. For an uncompressed image, the copied data correspond in the least
938 case to the image size (calculated) or the image size specified in the
939 header. A verbose is generated if these two size mismatch
941 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
942 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
943 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
944 break under windows (with msvc6 compilation).
946 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
947 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
948 compiling with MSVC6)
950 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
951 * Bugs fix for the Windows build with VC6
952 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
953 needed (only for projects required VTK). If the VTK is included in all
954 projects, there is conflicts with the jpeg lib of vtk when compiling the
955 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
956 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
957 when compiling the gdcm_wrap.cxx file (created by the compilation of the
959 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
960 (like it's already made for the cout use). Otherwise, conflict with the
963 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
964 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
966 - comments on the DicomDir::Method related usage added.
967 - now that we use the namespace gdcm, a lot of internal classes do
968 NOT need to be wrapped anymore.
969 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
970 DicomDir::Method) new example added.
972 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
973 * Improve string manipulation. I now inforce the notion of 'DicomString'
974 A DicomString can contain as many \0 as they want
975 and it is *always* of even length.
976 We only support odd length for very rare case.
977 And in the near future this should be removed.
979 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
980 * /binary_write/ gdcm source. Now even on big endian we are writting
981 little endian. This should -heopfully- fix some tests
983 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
984 * Now the dictionary is compiled into gdcm lib. This is a default
985 behavior, thus any dic file specified is picked before failback to
986 the one comiled into lib
988 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
989 * Change internals for gdcmDict. Don't use any 'new' any more.
990 This should definitely solve any leak problem, and we should be
991 as fast as before, as long as don't modify too much the dictionary.
993 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
994 * STYLE: ivars should start with a capital letter.
995 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
996 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
998 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
999 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
1000 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
1001 new 2004 dictionaries added (thanks to JPR).
1002 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
1003 * CLEANUP_ROUND (15) for gdcmPixelConvert
1004 - RLEFrame::NumberFragments is now of type unsigned int
1005 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
1006 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
1009 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1010 * Initial work in gathering all transfer syntax accessors. clearly
1011 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
1012 ivars, but only one transfersyntax (class) ivar with equivalent method on
1015 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1016 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
1017 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
1018 discussed (plus I didn't like having a 2000 lines patch not commited)
1020 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1021 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
1022 * CLEANUP_ROUND (14) for gdcmPixelConvert
1023 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
1024 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
1025 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
1026 CloseFile() anymore.
1027 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
1028 anymore and hence avoids storing a copy of PixelConvert::Decompressed
1029 into File::Pixel_Data.
1031 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1032 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
1033 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
1034 * CLEANUP_ROUND (13) for gdcmPixelConvert
1035 Substituted File::ParsePixelData() with PixelConvert::Print() new
1037 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1038 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1039 method to those classes.
1040 - src/gdcmFile.[cxx|h]:
1041 -- Added a ::Print() method.
1042 -- PixelConverter is now a reference instead of a member.
1043 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1044 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1046 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1047 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1048 collaboration diagram and inheritance diagram should be generated with
1050 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1051 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1052 pointlessly wrapped (see
1053 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1054 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1055 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1056 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1057 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1058 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1059 -- File::Initialise: PixelConverter setup moved away to
1060 PixelConverter::GrabInformationsFromHeader()
1061 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1062 interpretation moved away to PixelConverter::BuildRGBImage()
1064 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1065 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1066 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1068 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1069 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1070 displayed on Win32 when a brutal abort() occurs (because of uncatched
1071 exception). See TODO new entry of this commit for more on this.
1072 * TODO added new entry.
1073 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1074 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1075 - HandleColor is no longer called from gdcmFile.cxx
1076 - gdcmPixelConvert.cxx clean up on method arguments and internal
1077 variable names for semantical coherence.
1079 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1080 * Finished lossless transition, not only do we now read all lossless jpeg
1081 images, without the need of the Cornwell lib, but we do read them properly now
1082 * To reduce code (well to avoid code duplication), I defined a common place
1083 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1084 redefine symbols. This is not perfect but this the best solution I found for a
1085 compilation time jpeg option.
1087 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1088 * Update jpeg ijg lib to support lossless jpeg implementation
1089 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1091 * Also added a special copyright for dcmtk since we use their bugfixes.
1094 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1095 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1096 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1097 matters, as stated in warning note at beginning of %include section).
1098 * src/gdcmDicomDir*.[cxx|h]: coding style
1099 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1100 * src/gdcmJpeg8.cxx: doxygen fix.
1101 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1102 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1103 from File:: to PixelConvert::.
1105 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1106 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1107 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1108 - more code moved away from File:: to PixelConvert::
1109 - fat setup of PixelConverter set in place in File::Initialise.
1111 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1112 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1113 namespace at the file system level. So now you should convert your examples
1115 gdcmHeader -> gdcm::Header
1116 It would be nice if people keep in mind to no open the namespace, since it
1117 allows compilation on broken plateform which were defining common symbol in
1118 the standart namespace (like LP, Unknown ...)
1120 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1121 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1122 The JPEG fragments are now parsed at the same stage than the RLE
1123 information. All code related to JPEG is now in gdcmPixelConvert:
1124 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1125 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1126 export a gdcmFile:: method. Those are simply global functions
1127 (for the time being this is better than having them attach to
1128 either gdcmFile:: or gdcmPixelConvert::).
1129 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1130 and stores the result in a gdcmJPEGFragmentsInfo.
1131 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1132 code (among other stuff) moved away from gdcmFile:; to
1135 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1136 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1137 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1138 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1139 clean up of RLE related code.
1140 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1141 - src/gdcmRLE.cxx removed
1142 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1143 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1144 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1145 * CLEANUP_ROUND (9) for gdcmPixelConvert
1146 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1147 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1148 away from gdcmFile:: to gdcmPixelConvert::.
1150 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1151 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1152 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1153 This is because Parse7Fe0 used to parse the pixels to compute the
1154 length. This task was passed over to FindDocEntryLengthOB() a long
1155 time ago, EXCEPT I had forgotten the OW case...
1156 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1157 we just recylce the code for parsing RLE fragments and computing
1159 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1160 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1161 with the retired Parse7Fe0().
1162 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1163 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1165 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1166 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1167 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1168 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1169 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1170 * CLEANUP_ROUND (4) for gdcmPixelConvert
1171 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1172 to return an unused length.
1174 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1175 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1176 this should be cleanner from the plane view. The iostream are erally a pain
1177 to use to do simple stuff.
1179 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1180 * Redo the compilation of the ijg jpeg library. Now only one source is
1181 necesseray. No need to rename file by hand what so ever. CMake handle the
1182 copying of the file within different directory, configure header file to
1183 modify some symbol. The only addition made to ijg wasd a mangle table so
1184 that symbol are different whether we are within 8bits or 12bits.
1186 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1187 * Added documentation of vtkgdcmReader on Website:
1188 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1189 with it's binary name).
1190 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1191 the Website to be more complete.
1192 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1193 doxygenated documentation.
1194 - Doc/DoxyVtkGdcmReaderExamples.txt added
1195 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1196 DoxyVtkGdmReaderExamples.html )
1197 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1198 * CLEANUP_ROUND (3) for gdcmPixelConvert
1199 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1201 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1202 * CLEANUP_ROUND (2) for gdcmPixelConvert
1203 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1205 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1206 * CLEANUP_ROUND for gdcmPixelConvert:
1207 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1208 - src/gdcmPixelStuff[h|cxx] removed
1209 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1210 - src/CMakeLists.txt changed accordingly
1211 * GDCMHOME clean up:
1212 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1213 gdcmVersion.py moved to newly created ATTIC related
1214 gdcmPython/SetupOldies/ directory.
1215 * Autotools clean up:
1216 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1217 - autogen.sh configure.in acinclude.m4 python.m4 removed
1219 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1220 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1221 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1222 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1224 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1225 * TODO updated with Mathieu suggestions. I proposed a template for
1226 describing TODO entries and used it for new entries.
1227 * Added Doc/Website/CodingStyle.html, Developpers.html,
1228 DeveloppersPython.html, GdcmDataCvs.html and
1229 DownloadVersion0_1.html, DownloadVersion0_3.html.
1230 * Some Doc/*.txt Doxygen files (which do not really concern the
1231 documentation itself, but the website) moved to html and
1232 placed in directory Doc/Website:
1233 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1234 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1235 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1236 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1237 * CMakeLists.txt changed accordingly.
1238 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1239 DeveloppersPython.html
1240 * INSTALL nows refers to Doc/Website/Installation.html
1242 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1243 * Added Doc/Website directory, that contains a first raw version
1246 2004-09-23 Jean-Pierre Roux
1247 * FIX In order not to be poluted any longer by casting problems,
1248 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1249 we can now delete[] it safely
1250 * VoidArea is now called BinArea (less confusing name),
1251 and all the methods called ...VoidArea... are now ... BinArea...
1252 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1254 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1255 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1256 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1257 up to the destructor of gdcmElementSet to clean up TagHt and it's
1260 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1261 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1262 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1264 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1265 * ENH: added some utility method that builds a flat dictionary
1266 holding all the Dicom entries contained in the recursive structure
1267 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1268 an example of usage.
1269 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1270 BuildFlatHashTable() that build a flat dictionary.
1271 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1272 gdcmDocument is now a friend of gdcmElementSet.
1273 - src/gdcmElementSet.cxx: clean up.
1274 - Example/FlatHashTablePrint.cxx added.
1275 - Example/CmakeLists.txt changed accordingly
1277 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1278 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1279 moved away from gdcmDocEntrySet (since this class is an abstract class
1280 acting like an interface). SQDepthLevel and BaseTagKey are now
1282 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1283 and associated accessors. Doxygenation of the class.
1284 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1286 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1287 Use SQDepthLevel accessor instead. ::Print() adapted.
1288 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1289 - src/gdcmDocument.cxx changed accordingly.
1291 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1292 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1293 - The following is the doxygen comment of the typedef declaration
1294 of gdcmTagKey in src/gdcmCommon.h:
1295 gdcmTagKey is made to old an "universal" (as in URL, Universal
1296 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1297 A dicom tag always has a group and an element, but a set of tags
1298 embeded in various (optionally nested) sequences and sharing
1299 the same group and element all share the same (group, element)
1300 "identifier". Hence the (group, element) cannot be used as an
1301 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1302 In order to construct a proper tag identifier (i.e. a key) we
1303 consider the following definition of a TagKey:
1304 - let Group, Element be the string representation of the
1305 group and element dicom tag members,
1306 - let ItemNumber be the string representation of the integer
1307 index of the considered item number of a sequence,
1308 Let the key of a tag embeded in a sequence, noted SeqTag, be
1310 /ItemNumber#Group|Element
1311 where "/", "#" and "|" are characters acting as separators.
1312 Then the general form of a gdcmTagKey is given by:
1313 Group|Element<SeqTag>
1314 where <SeqTag> means NO or many instances of SeqTag.
1315 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1318 but the gdcmTagKey of a tag "embeded" is the first item of
1319 a sequence, itself nested in the third item of a sequence is the
1321 0004|1220/2#0008|0082/0#0008|0090
1322 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1323 order to hold the new sequence compatible key. Previously, the
1324 GetKey() method would look in the underlying gdcmDictEntry.
1325 - src/gdcmDocEntry.cxx:
1326 -- constructor now copies the underlying DictEntry key, in the local
1328 -- ::Print: displays the member Key, instead of the (group, element).
1329 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1330 - src/gdcmDocEntrySet.h:xi
1331 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1332 -- now has a new BaseTagKey member.
1334 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1335 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1337 This poses the problem with the semantics of the following lines
1338 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1339 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1340 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1341 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1342 to the long FIXME note for what the problem is. Nevertheless in
1343 order to get things working the dicom dictionary was altered !
1344 Please fix things urgently...
1345 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1346 information), see above note on moving the member VoidArea. Nevertheless
1347 the following entries previously correctly set as US are now inproperly
1349 0028 1201 OW IMG Red Palette Color Lookup Table Data
1350 0028 1202 OW IMG Green Palette Color Lookup Table Data
1351 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1352 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1353 of gdcmDocEntry moved to gdcmSeqEntry.
1354 * src/gdcmSeqEntry.cxx: STYLE.
1356 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1357 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1359 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1360 * gdcmPython/testSuite.py: all the test suite in python is now moved
1361 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1362 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1363 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1365 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1366 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1367 to avoid inclusion recursion until STL is reached.
1368 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1369 mecanism. errno.h is not included in gdcm anymore.
1370 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1371 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1373 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1374 gdcmData/TestAllEntryVerifyReference.txt
1375 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1376 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1377 exception_on_error parameter.
1378 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1379 - vtk/vtkGdcmReader.cxx changed accordingly,
1380 - Example/*.cxx and Test/*.cxx changed accordingly.
1382 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1383 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1384 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1385 enable_sequences removed from gdcmHeader constructor and dependencies.
1386 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1387 * gdcmPython/demo/PrintHeader.py: dummy fix.
1388 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1389 skip_shadow removed from gdcmHeader constructor and dependencies.
1390 * Example/*.cxx and Test/*.cxx changed accordingly.
1392 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1393 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1394 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1396 2004-07-21 Jean-Pierre Roux
1397 * FIX Now, Parsing and Printing a DICOMDIR do work!
1398 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1400 2004-07-20 Jean-Pierre Roux
1401 * FIX Some brain damaged headers have Zero-Lenght fields
1402 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1404 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1405 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1406 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1407 variable (instance of gdcmDebug) by a definition macro, and the instance
1408 is now in static in the gdcmDebug class
1409 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1410 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1412 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1413 * WARNING: ctest now depends more tightly on gdcmData. You should
1414 check out gdcmData properly for things to run smoothly...
1415 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1416 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1417 we need the pixels not be loaded in order to use the ValEntry
1418 that displays position and size).
1419 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1420 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1421 be deprecated. If you have any doubts about the advantages of a
1422 modern scripting language (read Python) versus grass root C++ (i.e.
1423 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1424 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1425 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1426 Anyhow, consider documenting the gdcmData images in
1427 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1429 * Test/CMakeLists.txt:
1430 - now uses TestAllEntryVerify.cxx
1431 - specific comments on oldACR00001.ima (now renamed in gdcmData
1432 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1433 gdcmData/TestAllEntryVerifyReference.txt
1436 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1437 * src/*.[h|cxx] : typedef clean up
1438 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1439 - TagKey renamed to gdcmTagKey (for external usage)
1440 - VRKey renamed to gdcmVRKey (for external usage)
1441 - removal of typedef duplication.
1442 - Removed all unecessary inline keyword from class inline definitions.
1443 - Some method|function(void) declarations replaced with method|function().
1444 * src/jpeg/libijg12/jdhuff12.c:
1445 - printf polluting ctest removed.
1446 - TAB removal for comminting
1448 - TestAllReadCompareDicom.cxx: added a test that compares all the
1449 images in gdcmDataImages.h with corresponding images in
1450 gdcmData/BaselineDicom/. When baseline images are not present
1451 this test creates them.
1452 Note: we need to validate each reference image, but before that
1453 I'd like to rename them with a more explicit name...
1454 - CMakeLists.txt: changed accordingly.
1455 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1456 including each header needed).
1458 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1459 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1460 test suite to the Example directory. Are concerned:
1465 - TestWriteSimple.cxx
1466 * Test/CMakeLists.txt: added some comments on reasons for black listing
1467 image gdcmData/oldACR00001.ima
1469 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1470 * Test/CmakeList.txt: removed the following from black list (to be coherent
1471 with removal from gdcmData):
1472 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1473 - gdcm-MR-PHILIPS-16.dcm
1475 Added the following because after last cvs update, they cause
1476 ctest -R TestReadWriteReadCompare
1478 - gdcm-MR-SIEMENS-16-1.acr
1480 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1481 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1482 new comments in this file) we temporarily (sigh) move to a weaker
1484 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1485 we don't need to black list the following images anymore:
1486 - 8BitsUncompressedColor.dcm
1488 - US-PAL-8-10x-echo.dcm
1489 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1490 fixes and the beautified code ;-)
1491 This fixes the bug introduced in version 1.42 (when beautifying)
1492 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1493 Note: ctest was blind to this bug (this means we need to still
1494 improve the test suite). The bug could be detected by using
1495 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1497 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1498 and by displaying the (garbage) produced file temp.XDCM...
1500 2004-06-29 Jean-Pierre Roux
1501 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1502 - replace by uggly but working old code :-(
1503 A lot of things should be OK again.
1504 It's really urgent to have a test suite that *tests*,
1505 to prevent Frog's beautifying sessions to break all the stuff
1506 (twice, withing a fortnigh ...)
1508 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1509 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1510 redundancy) to added Test/TestReadWriteReadCompare.cxx
1511 * Test/CmakeList.txt: because the compare test of
1512 Test/TestReadWriteReadCompare.cxx fails, the following images are
1513 black listed: - 8BitsUncompressedColor.dcm
1515 - US-PAL-8-10x-echo.dcm
1516 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1517 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1518 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1519 and ad-hoc kludge. This kludge is now removed, and on encountering
1520 such an image (OB field brain damaged) we set errno. Then in
1521 ::FindDocLength() we "fix" the length as being ALL what remains
1522 in the file (until EOF). We then proceed, hoping for the best...
1523 This fixes a SegFault in ShowDicom when trying to write such an
1525 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1526 (because TestWriteRead breaks on it, after a non conformal commit?).
1527 ctest now runs properly, except for MakeDicomDir (which was always
1528 broken) and the Python related stuff (still not fixed).
1530 2004-06-24 Jean-Pierre Roux
1531 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1532 FIX : Test/TestReadWrite now iterates on all the file names
1533 (instead of infinite loop)
1534 ENH : Test/TestWriteRead now iterates on all the file names
1536 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1537 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1539 2004-06-24 Jean-Pierre Roux
1540 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1541 when SamplesPerPixel =3
1542 - now Write is no longer confused by
1543 'BitsAllocated = 12" and 'BitsStored=12"
1544 - "UN" value representation Elements are now written correctly
1545 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1546 ENH : - now gdcmHeader has its own Write methods
1547 (in order to split the job that has not to be done
1550 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1551 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1552 loop on the same image until memory went out.
1553 Note: this means we still have gobs of memory loss in PrintDocument
1554 * src/gdcmDocument.cxx: fixes problem on parsing on file
1555 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1557 2004-06-24 Jean-Pierre Roux
1558 FIX : Write - All the Sequences and Sequence Item are now written
1559 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1560 is added a the end, when necessary.
1561 - A lot of brain-damaged images, that were read correctly are
1562 now written correctly
1563 - length compatible BinEntry are now loaded correctly
1564 (even for odd groups)
1565 Note : only Explicit Value Representation was checked.
1566 (question : is implicit VR really necessary for gdcm ?)
1568 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1569 * DEVELOPPER: added a proposition of coding style.
1570 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1573 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1574 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1575 Use the gdcmDocEntry::Print() and Write() instead.
1576 * src/gdcmDocument.cxx: bug fix.
1578 2004-06-22 Jean-Pierre Roux
1579 FIX : gdcmDocument.cxx
1580 - Now we do recognize the JpegLossLess format (there was a misstyping in
1581 code 'beautyfication' :-(
1582 - Now we automaticaticaly load the Luts, if any
1584 2004-06-22 Jean-Pierre Roux
1585 In order : to write Sequences, whatever their imbrication level,
1586 : to allow user to create his own Sequences
1587 a lot of modif where necessary (adding, moving, or virtualising methods)
1589 WARNING : save your own sources *before* cvs up !
1592 ADD virtual void Write(FILE *fp, FileType filetype);
1595 ADD virtual void Write(FILE *fp, FileType filetype);
1596 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1599 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1600 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1601 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1602 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1603 ADD std::string GetEntryByName(TagName name);
1604 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1606 std::string vr = "unkn",
1607 std::string fourth = "unkn",
1608 std::string name = "unkn");
1609 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1610 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1611 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1612 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1613 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1614 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1615 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1616 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1619 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1620 ADD virtual std::string GetEntryByName (TagName tagName);
1621 ADD virtual std::string GetEntryVRByName (TagName tagName);
1622 REM virtual bool Write(FILE *, FileType);
1623 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1624 FILE *_fp, FileType type);
1625 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1626 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1627 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1628 REM virtual std::string GetEntryByName (std::string tagName);
1629 REM virtual std::string GetEntryVRByName (std::string tagName);
1630 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1631 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1632 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1634 std::string vr = "unkn",
1635 std::string fourth = "unkn",
1636 std::string name = "unkn");
1637 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1638 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1639 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1640 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1643 ADD virtual void Write(FILE *fp, FileType filetype);
1646 ADD virtual void Write(FILE *fp,FileType filetype);
1649 ADD virtual void Write(FILE *fp, FileType filetype);
1650 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1651 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1652 REM std::string GetEntryByName(TagName name);
1655 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1657 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1658 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1659 The default constructor invoked by the line
1660 gdcmHeader *f1 = new gdcmHeader( header );
1661 was gdcmHeader::gdcmHeader(bool) instead of the expected
1662 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1663 Hence the parsing wasn't executed... See also below.
1664 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1665 as explicit constructor didn't do the trick to fix the above problem.
1666 Could anyone explain why ?
1667 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1668 properly calls gdcmValEntry::Print() (that was weed out from
1669 code related to gdcmBinEntry).
1671 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1672 * In order to fix memory leaks:
1673 - Test/TestWriteSimple.cxx: added cleaning of free store through
1675 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1676 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1677 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1678 (through the call to ::AddDicomDirMeta()) or the destructor
1679 would crash when deleting uninitialized ::metaElems].
1680 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1681 - src/gdcmDocument.cxx:
1682 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1683 from dynamic stores.
1684 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1685 was causing memory leaks.
1686 - src/gdcmSQItem.cxx:
1687 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1688 cleanly handled with polymophism: sorry but my milage is low).
1689 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1690 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1691 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1692 This avoids SegFaulting.
1693 - src/gdcmSQItem.h: coding style.
1695 - Test/TestWriteSimple still severely sucks. The output image content
1696 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1697 damaged when displayed with vtkgdcmViewer.
1698 - on memory leaks: TestWriteSimple leaks really less (see entry
1699 of 2004-06-18 in Changelog file for the call to valgrind).
1700 - on segfaults: ctest now passes all the tests but one (no more
1702 * Erroneous leading white fix:
1703 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1704 white[s] (as opposed to from >> xxx, that removes it [them].
1705 - src/gdcmTS.cxx: ditto.
1706 - gdcmPython/testSuite.py: dirty related kludge removed.
1707 * src/*: remaining references to gdcmParser removed.
1708 * src/*[cxx|h]: added copy[way]left header.
1711 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1712 * In order to fix writing of dicom files:
1713 - Test/TestWriteSimple.cxx: a simpler example of writing.
1714 - Test/CMakeLists.txt changed accordingly.
1715 - src/gdcmDocument.cxx:
1716 -- The destructor now recursilvely removes potential sequences.
1717 -- Bug fix in ::IsJPEG2000()
1718 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1719 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1721 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1722 to only declared) and build on top of
1723 ::GetDocEntryByNumber(guint16, guint16).
1724 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1725 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1726 for usage in destructor and treatement of promotion in
1727 ::ReplaceOrCreateByNumber().
1728 - src/gdcmSQItem.cxx: destructor should better handle his job.
1729 Test/TestWriteSimple now runs (or at least it DOES something).
1730 * We can now start hutting memory links. A good starting point is:
1731 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1732 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1733 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1735 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1736 * Valgrind note: after Mathieu Malaterre teached me how to read
1737 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1739 Using gcc, you can force the STL to use malloc and to free memory as
1740 soon as possible by globally disabling memory caching.
1741 With 3.2.2 and later, you should export the environment variable
1742 GLIBCPP_FORCE_NEW before running your program.
1743 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1744 simply vanish (it is still not clear to me, whether this means that
1745 STL std::string leaks or if valgrind believes it leaks...).
1746 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1747 running bin/gdcmTests makeDicomDir):
1748 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1749 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1751 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1752 SegFaulting (I drowned in DicomDir related code when trying to
1753 understand why the list is empty...).
1754 * src/gdcmDocument.h: first BSD license header try.
1755 * Doc/License.txt added.
1757 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1758 * src/gdcmDocument.[h|cxx]:
1759 - Clean up of the Transfer related predicates. They are now all based
1760 on new method isGivenTransferSyntax, that (should) handle properly
1761 the padding problem.
1762 - general clean up, simplification, and coding style.
1763 - Specific clean up of Parse7FE0() (umproperly named actually).
1764 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1766 2004-06-14 Jean-Pierre Roux
1768 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1769 - fix the display of SQItem ordinal number
1770 - add the GetSQItemByOrdinalNumber method
1771 - remove some useless never written private methods
1773 2004-06-14 Jean-Pierre Roux
1775 - adding a constructor taking a gdcmDocEntry as an input param
1776 - ReplaceOrCreateByNumber now returns :
1777 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1778 a gdcmValEntry * if a string value is passed as a param
1780 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1781 according to the param type (no longer sets a gdcmDocEntry)
1782 - GetValEntryByNumber, GetBinEntryByNumber added
1783 - NewValEntryByNumber and NewBinEntryByNumber added
1785 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1787 - GetSQItemNumber and SetSQItemNumber added, to provide
1788 a (relative) Item identier inside a given Sequence
1789 \warning : some pb remaining around this number
1791 - AddEntry now takes the Item Number as a param
1793 - adding a constructor taking a gdcmDocEntry as an input param
1795 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1796 * Memory leak hunt with the following command:
1797 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1798 --show-reachable=yes gdcmTests PrintDocument
1799 It looks like many (all?) leaks are due to the STL (or a bad usage
1800 of the STL. The lines producing the leaks now have a comment with
1801 a "MEMORY LEAK" tag: you can retrieve them with
1802 grep "MEMORY LEAK" src/*
1803 Here are two typical examples which I can't help fixing:
1808 char * test = "babo";
1809 name = test; //// <--- valgrind detects 960 bytes lost in
1810 //// call to std::string::operator=(char const*)
1811 name.clear(); //// Doesn't help !
1819 std::cout << "Type a bunch of characters followed by RETURN: ";
1820 getline(std::cin, line); //// <--- valgrind dectects a loss
1821 //// of 1320 bytes in call to
1822 /// std::basic_istream<>& std::getline<>
1828 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1829 * src/gdcmHeader.[cxx|h]:
1830 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1831 and related, moved away to gdcmDocument.
1832 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1833 the corresponding protected accessors of inherited class
1834 gdcmDocument, removed ! As a consequence gdcmFile had to be
1835 declared friend of class gdcmDocument (see below).
1836 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1837 - Clean up of undefined or unused methods.
1838 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1839 account the changes to gdcmHeader.h).
1840 * src/gdcmDocument.h:
1841 - gdcmFile is now a friend class (in order to take into account the
1842 changes to gdcmHeader.h).
1843 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1844 (see changes to gdcmHeader.h).
1845 - Accessors (reading on the form GetEntry*) are now public.
1846 - Clean up of undefined or unused methods.
1847 * src/gdcmDocument.cxx:
1848 - adaptation to changes to gdcmDocument.h
1849 - ::OpenFile now writes a verbose message when file cannot be opened.
1850 - some std::string properly set to VRKey
1851 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1852 references to gdcmDocument.
1853 * Test/TestFindTags.cxx: changed accordingly to above changes.
1854 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1855 cvs repository gdcmData.
1857 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1858 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1859 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1860 conflicts with gdcmValEntry::voidArea.
1861 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1862 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1863 Value representation between StringRepresentable and BinaryRepresentable.
1864 * src/gdcmDocument.cxx:
1865 - method ParseDES: proper indentation restored and usage of
1866 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1867 - method LoadDocEntry: the fingerprint left in the SetValue() of
1868 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1869 removed. Reverting to previous code segment with the proper
1870 dynamic_cast< gdcmValEntry* >.
1871 Note: this was (partially) breaking the python test suite
1872 (gdcmPython/testSuite.py) that made usage of the above
1873 fingerprint to check presence of "Pixel Data".
1874 * src/gdcmDocEntry.h: coding style.
1875 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1876 now taken into account.
1877 * gdcmPython/gdcm.i: adaptation to the new internal representation
1878 of gdcm (exit gdcmParser, hello gdcmDocument).
1879 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1881 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1882 anymore, but instead prints the loaded Python dictionary.
1883 * .... alas, the python testSuite is still broken.
1885 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1886 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1888 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1889 * src/gdcmUtil.h : export methods
1891 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1892 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1894 * Initial addition of automatic python testing
1895 * Initial addition of automatic image comparison
1897 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1898 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1899 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1901 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1902 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1903 * Test/ShowDicom.cxx : bug fix for msvc compilation
1904 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1906 2004-05-04 Jean-Pierre Roux
1907 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1908 new concepts (and new classes) :
1909 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1910 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1911 - Sequence Doc Entries (gdcmSeqEntries)
1912 a Sequence is composed of Items.
1913 Each item is a set of Doc Entries (this is recursive)
1914 The non uniqueness of the 'Dicom tag' is due to this recursivity
1915 (never taken into account)
1916 Our unability to add a new 'entry' in the header
1917 at the proper location (neither in the H-Table (map or multimap),
1918 nor in the Chained List is also due to this recursivity.
1919 Don't try, right now, to use/modify/compile these new sources :
1920 nothing is finished.
1921 We just commit all the stuff, 'as is', in order not to loose it.
1923 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1924 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1926 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1927 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1928 file prefix (SetFilePrefix)
1930 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1931 * Add a new test: ShowDicom, for now this is just the c++ version of
1932 checkRead.sh, later it will be able to compare the image read against a
1934 * Replace the DEBUG on the stack with a global entry in cmake interface:
1935 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1937 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1938 * Add an example subdir, with a real example on how to read + write a
1941 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1942 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1943 * Doc/CMakeLists.txt: the main page is now properly differentiated
1944 between the developper and user version.
1945 * Doc/doxygen.config.in: dropped search related obsolete flags
1946 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1948 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1949 * DEVELOPPER: added some helpfull comments for compile/test/install
1952 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1953 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1954 src directory, now generated in the build dir.
1955 2. Tests as mentionned smarter
1957 4. Add a new method in gdcmDict that return the PubDict by name
1958 this is interesting for 3rd party lib like ITK,
1959 where we could set the institution name / patient name...
1961 * ENH: 1. Now the test suite is working for real
1962 2. All binaries are now output in the gdcm-bin directory
1963 (this was not true before)
1965 2004-04-28 Jean-Pierre Roux
1966 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1967 SeQuence indented printing of Dicom Header.
1968 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1969 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1970 Computation of SQDepthLevel is now part of gdcmHeader constructor
1971 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1972 tree-like structure of a Dicom Header.
1973 * FIX Test code cleaning
1975 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1976 * ENH: Adding automatic testing
1977 1. Need a DartConfig.cmake to submit to public
1978 2. Add a test driver gdcmTest.cxx
1979 3. gdcmTestMain, an helper for the main test driver gdcmTest
1980 4. Files in Test don't have a main anymore, this becomes interesting
1981 when we add more and more tests, thus dsw don't have to load
1983 * ENH: Adding a GDCM_DATA_ROOT for testing
1984 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1985 one file instead of seven + some small cleanup
1987 2004-04-22 Jean-Pierre Roux
1988 * ENH Minor changes to the Print() methods.
1989 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1990 Header printing. Example given with :
1991 > PrintHeader fileName 2 new
1992 (SQ based tree-like structure still to be done for the Header ...)
1994 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1995 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1996 1. I have added some unsigned where needed
1997 2. Some function parameter not used -> (void)
1998 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1999 4. g++ don't like character '\' in comment
2000 5. #define jpeg_create_decompress jCreaDecompress
2001 this really need to be fixed
2002 6. virtualize destructor of gdcmObject ... leakage
2003 7. sscanf(g->first.c_str(),"%x",&gr_bid);
2004 this also really need to be fixed
2005 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
2006 remove compression file
2007 (as we only do decompression, right ?)
2008 * ENH: Change malloc/calloc/free with c++ equivalent
2010 2004-04-21 Jean-Pierre Roux
2011 * FIX gdcmHeaderHelper::GetXSpacing
2012 when a single value is found (bug ?), xpacing is now
2013 defaulted to yspacing
2015 2004-04-19 Jean-Pierre Roux
2016 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
2017 * ENH add parameters :
2018 bool exception_on_error = false,
2019 bool enable_sequences = false,
2020 bool ignore_shadow = false
2021 to the gdcmFile constructors to be full gdcmParser compliant
2022 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
2023 to allow reading of PAPYRUS 3.0 files
2025 2004-04-06 Jean-Pierre Roux
2026 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
2028 2004-04-02 Jean-Pierre Roux
2029 * ADD : Test/checksequence.sh, for a general recap on SQ pb
2030 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
2031 for Philips spurious Tag fffe|0000 while rewritting Dicom files
2033 2004-03-30 Jean-Pierre Roux
2034 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
2035 for ACR file, written out as DICOM files (hope so...)
2037 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2038 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2039 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2040 moved to base class gdcmParser and only the specialisation is kept
2042 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2043 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2044 already does the job.
2045 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2046 (to be consistent with gdcmParser::WriteEntries).
2048 2004-03-30 Benoit Regrain
2049 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2050 upate of the object's instance. It's passed to 2 in the unfavorable
2051 case : one in the ExecuteInformation, one in the ExecuteData
2053 2004-03-29 Jean-Pierre Roux
2054 * ENH : Check on file type to be written moved
2055 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2056 * FIX : gdcmObject::ResetBoundaries now stops properly
2057 when end-of-list is reached
2058 : gdcmVersion modified (as Benoit Regrain asked)
2060 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2061 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2062 * src/gdcmUtil.cxx: added forgotten iostream include.
2063 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2064 equivalent to ExplicitVR in existing code).
2066 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2067 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2068 now contains all the gdcmGlobal related code.
2069 * minor coding style and doxygenation changes.
2071 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2072 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2073 now contains all the Debug related code.
2074 * minor clean-up of includes in src/*.cxx
2075 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2076 CreateCleanString) removed.
2077 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2078 * Doc/DoxyMainPageUser.txt added.
2079 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2080 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2081 src/gdcmDirList.cxx)
2083 2004-03-24 Jean-Pierre Roux
2084 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2086 2004-03-23 Jean-Pierre Roux
2087 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2088 big endian made volumes
2089 * ENH Now gdcmParser constructor and destructor are protected to forbid
2090 end user to instanciate class gdcmParser
2091 (only gdcmHeader and gdcmDicomDir are meaningfull)
2093 2004-03-22 Benoit Regrain
2094 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2095 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2096 gdcmSerie to gdcmDicomDirSerie
2098 2004-03-19 Jean-Pierre Roux
2099 * ENH Now the tree-like structure describing a DICOMDIR comming from
2100 an already existing DICOMDIR file is consistent with
2101 the home-made tree-like structure build ex-nihilo
2102 or build from the files held (recursively) in a Directory
2103 functions gdcmDicomDir::CheckBoundaries()
2104 gdcmObject::SetBoundaries() added
2106 2004-03-17 Jean-Pierre Roux
2107 * REM (Eric Boix bug) : removal of meaningless
2108 gdcmDicomDirImage::NewImage function.
2109 * FIX now file names and directory name are written properly in the
2111 * FIX now gdcmDicomDir constructor may be call without any trick
2114 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2115 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2116 of gdcmDicomDirImage::NewImage as empty function.
2118 2004-02-28 Jean-Pierre Roux
2119 * ENH add gdcmDicomDir:NewPatient
2120 add gdcmDicomDirPatient:NewStudy
2121 add gdcmDicomDirStudy:NewSerie
2122 add gdcmDicomDirSerie:NewImage
2123 to allow making gdcDicomDir object.
2124 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2125 (as opposite to the gdcmHeader chained list)
2127 2004-02-11 Benoit Regrain
2128 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2129 when using from python
2131 2004-02-10 Benoit Regrain
2132 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2133 * FIX : in gdcmDicomDir when the directory is empty
2134 * ENH : add callback and methods to get the progression of dicomDir
2137 2004-02-06 Jean-Pierre Roux
2138 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2139 - GDCM_META added to gdcmDicomDirType
2140 - class gdcmMeta created
2141 * ENH : - A brief summary is now displayed at the beginning of
2142 'testDicomDir' to help disaster magnitude estimation
2143 * REM : Now useless Test/explDICOMDIR.cxx
2145 2004-02-05 Benoit Regrain
2146 * ENH : add methods in gdcmObject to get the hash table or the list of
2148 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2149 * FIX : wrapping python for TagHeaderEntryHT
2151 2004-02-04 Benoit Regrain
2152 * FIX : even length for some strings when writting the dicom dir
2153 * FIX : sort the images in the dicom dir
2154 * FIX : Bug fix for python use of dicom dir
2155 * ADD : a python demo
2157 2004-02-04 Jean-Pierre Roux
2158 * FIX : Final solution (?) for icone embedded images
2159 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2160 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2161 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2162 gdcmData/gdcm-MR-SIEMENS-16.acr1
2163 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2164 to make full checking easier
2166 2004-02-04 Benoit Regrain
2167 * FIX : WriteEntries : coding style & logic in parameters
2168 * FIX : Set the elements to create the DicomDir in a dictionary file
2170 2004-02-03 Benoit Regrain
2171 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2172 * gdcmDicomDir : add the load of directory
2173 * Bug fix and print add-on
2175 2004-02-03 Jean-Pierre Roux
2176 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2177 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2178 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2179 * FIX gdcmParser.cxx : 'group length' elements are now considered
2180 as integers, even for shadow groups, when file is Implicit VR
2182 2004-02-02 Jean-Pierre Roux
2183 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2185 of the last synonym :-(
2186 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2188 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2189 * FIX taking into account the possible 7fe0,0010 multiplicity
2190 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2191 to allow removal of references to 7fe0,0010, to deal with
2192 ACR-NEMA images, when 0028,0200 is meaningfull
2194 2004-01-31 Jean-Pierre Roux
2195 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2196 no longer writes 'Un' on disk
2197 * FIX SQ elements with actual length are now dealt with corectly
2198 * FIX gdcmFile::WriteBase make the difference, for color images, between
2199 the length (for Palette expanded images)
2200 and Raw Length (non expanded image + Palette)
2201 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2202 (that broke Write). Replaced by UL.
2203 Aware user will reload the field if he
2204 thinks it's necesssary
2206 2004-01-30 Jean-Pierre Roux
2207 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2208 when 'dirty Acr' is found, to be compliant with the new
2209 IsReadable() methods.
2211 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2212 (no DOUBLE images in kosher DICOM,
2213 but so usefull for people that miss them ;-)
2215 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2216 DICOMDIR related utilities (not checked as Windoze compliant)
2218 2004-01-28 Jean-Pierre Roux
2219 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2221 2004-01-27 Jean-Pierre Roux
2222 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2223 to allow skipping the shadow elements, to save memory space.
2224 The TRUE value for this param has to be used
2225 with a FALSE value for the 'enable_sequence' param.
2226 ('public elements' may be embedded in 'shadow Sequences')
2227 * gdcmHeader methods now deal with 'embedded icones images' in the header
2228 (even when an 'icone image sequence' is announced by the
2229 element (0x0088,0x0200), but there is NO icone at all ...
2231 * gdcmHeader sometimes Image Location value doesn't follow
2232 the supposed processor endianity (see gdcmData/cr172241.dcm).
2235 * gdcmHeader add the method
2236 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2237 to get *all* the Header Entries with the same tag.
2238 GetHeaderEntrySameName is probabely *useless*
2239 (no meaning : Name is *not* an identifier within the Dictionary)
2241 2004-01-26 Benoit Regrain
2242 * Bug fix in the print of hexadecimal representations. Remove long fields
2243 in the print and add a third level of print to print them
2245 2004-01-23 Benoit Regrain
2246 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2247 * Bug fix on test suite after remove the strip made on not string fields
2248 * Split the IsReadable method between gdcmParser which test that the file
2249 is dicom and gdcmHeader which test that it's an image file
2251 2004-01-22 Benoit Regrain
2252 * DicomDir : clean code, add methods, set variables in protected or private
2253 * gdcmUtil : bug fix for the clean string method
2255 2004-01-19 Benoit Regrain
2256 * Add the use of shadow dictionaries
2257 * bug fix and coding style
2259 2004-01-19 Benoit Regrain
2260 * src/gdcmFile.cxx : bug fix concerning the close of file
2261 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2262 * Add the update of header entries using the shadow library
2264 2004-01-19 Benoit Regrain
2265 * removal of file gdcmHeader2.cxx
2266 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2267 inheriting from gdcmParser. This split is to prepare the integration
2268 of dicom dir parsing
2269 * bug fix under python
2271 2004-01-16 Jean-Pierre Roux
2272 * REM removal of class gdcmHeaderEntrySet
2273 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2274 * ADD add file gdcmHeader2.cxx
2275 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2277 2004-01-15 Benoit Regrain
2278 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2279 entries created while parsing the header. Thus, they will be destroyed
2280 when the gdcmDictSet will be destroyed
2281 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2284 2004-01-15 Benoit Regrain
2285 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2286 made a fatal error because of the memory release at the end of program.
2287 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2288 some memory and vtk seems to have some problems with that.
2289 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2291 2004-01-14 Benoit Regrain
2292 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2293 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2294 * src/*.[h|cxx] : make changes due to class name changes
2295 * gdcmPython/demo/*.py : bug fix due to method names
2297 2004-01-13 Benoit Regrain
2298 * src/*.[h|cxx] : coding style
2299 * vtk/*.[h|cxx] : coding style
2301 2004-01-13 Benoit Regrain
2302 * gdcmPython/testSuite.py : test the readable flag of file for tests
2303 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2304 It's lied to the stl compilation by MSVC (windows, always windows...)
2305 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2307 2004-01-12 Benoit Regrain
2308 * src/*.h : add comments
2309 * src/gdcmDictSet.h : set the method BuildDictPath in public
2310 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2311 directly setted in the source code
2312 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2315 2004-01-09 Benoit Regrain
2316 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2317 * setup.py : use a reference to gdcmVERSION
2319 2004-01-07 Benoit Regrain
2320 * Modification to compile with the distutils.
2323 2003-12-10 Benoit Regrain
2324 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2325 can use a gdcmHeaderHelper to load data
2326 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2327 made in the source code
2329 2003-12-10 Benoit Regrain
2330 * Update Windows projects and .cvsignore files
2332 2003-11-12 Jean-Pierre Roux
2333 * ENH gdcmHeader constructor has one more parameter (default value : false)
2334 that allows the user to 'go inside' the SeQuences only
2336 gdcmElValSet:Print takes it into account
2338 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2339 * ENH: Update gdcmPython/CMakeLists
2340 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2341 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2343 2003-11-10 Jean-Pierre Roux
2344 * FIX : gdcmHeader::LoadElements is now based
2345 on the ListTag listElem member,
2346 not longer on the TagElValueHT tagHt member
2347 * ENH : PrintPubElVal shows (temporarily) both results,
2348 with the tagHt member and the listElem member.
2349 (it's easier to 'see' the problems when using Printheader)
2351 * FIX : old private member LgrElem is now splitted into
2352 ReadLength : Length actually found on disk (updated only
2353 if bug fixing is necessary), for internal
2355 UsableLength : Updated by FixFoundLength, to fix a bug
2356 or to allow Parser going on.
2357 Will allow to re-write a kosher header when a SeQuence
2358 with a length (not 0000) is found
2359 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2360 because gdcmElValSet::Add does not update ListElem
2363 2003-11-07 Jean-Pierre Roux
2364 * FIX misstyping in Transfert Syntax name table
2365 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2366 when they have an actual length (not 0000 nor FFFFF)
2367 (Nobody should care of it, but DICOMDIR explorers)
2369 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2370 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2372 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2373 * ENH: vtkGdcmReader now supports LUT !
2374 (vtkgdcmViewer for now is not able to use them though)
2376 2003-11-05 Jean-Pierre Roux
2377 * in testSuite.py : new files names for checking the package
2378 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2379 that returns the pixel area size to the *aware* (vtk) user
2380 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2382 2003-11-05 Benoit Regrain
2383 * in testSuite.py : Modify the rules for checking the paths
2384 : Explicit error messages
2385 * in __init__.py : Related modif
2387 2003-11-03 Jean-Pierre Roux
2388 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2389 to be used by aware (vtk) users that want to manage
2390 LUT (and no to turn the PALETTE image into an RGB pixels one)
2391 * GetPixelType now returns 8U for 24 Bits images
2392 (vtkGdcmReader compliant)
2394 2003-10-31 Jean-Pierre Roux
2395 * Removal of *all* gdcmData images and add them again
2396 in order to loose the 'history' of un-anonymised images
2398 2003-10-31 Jean-Pierre Roux
2399 * RMV : removal of useless jBitsInJsample.h
2400 for both 8 and 12 Bits JPEG Lossy Libraries
2402 2003-10-31 Jean-Pierre Roux
2403 * ENH : Add the functions gdcmFile::GetImageDataRaw
2404 gdcmFile::GetImageDataIntoVectorRaw
2405 that act as GetImageData and GetImageDataIntoVector
2406 except the making of an RGB Plane from Gray Plane + LUT
2407 Intended to aware (vtk) users who know how to manage
2410 GetLUTRGBA return a R,G,B,A LUT if any
2411 lgrTotaleRaw gives the 'Raw' length
2412 GetImageDataRaw returns the gray Plane
2413 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2414 (They stay Grey, just like with other Dicom viewers :-(
2416 2003-10-30 Jean-Pierre Roux
2417 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2419 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2420 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2421 being coherents dicom files.
2423 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2424 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2426 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2427 * ENH: Two steps is necessary to please VC++ compiler...
2428 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2429 * ENH: Add include dir to medcon lib
2430 * FIX: only one function is being exported for now !
2431 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2433 2003-10-29 Jean-Pierre Roux
2434 * adding gdcmHeader::GetLUTRGBA
2435 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2436 --> Mathieu, the modif u're waiting for is not yet committed
2437 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2439 2003-10-27 Jean-Pierre Roux
2440 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2441 00191113.dcm DermaColorLossLess.dcm
2442 MxTwinLossLess.dcm RadBWLossLess.dcm
2443 * ENH: For version prior to vtkImageViewer2 -r 1.19
2444 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2446 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2447 * Removal of ido stuff in CMakeLists.txt
2449 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2450 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2451 * FIX: remove a call to ->Modified ... see comments
2452 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2454 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2455 * FIX: Problem with path for libvtkgdcmPython
2456 * ENH: Try adding a search script for python site-package
2457 * RMV: Remove some file from medcon lib that are not necessary
2458 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2459 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2460 * FIX: More pragma disable fro VC++,
2461 I don't think I break something as it is also disable in VTK/ITK.
2462 But it fasten debug compilation time.
2464 2003-10-23 Jean-Pierre Roux
2465 * gdcm now deals with 16 Bits Run Length Encoded images
2466 (they are compressed as 2 planes images,
2467 one for the high Bytes, the other for low Bytes)
2469 2003-10-22 Jean-Pierre Roux
2470 * Now CheckRead takes into account :
2471 - the bugged 'Leonardo' Siemens images
2472 - the XA images, sent thru the burning VPRO station
2473 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2476 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2477 * FIX: When copying a Makefile.am to CMakeLists.txt
2478 one should remove the '\'
2480 2003-10-22 Jean-Pierre Roux
2481 * in gdcmData adding a bugged 'Leonardo' Siemens image
2482 (wrong lengths in header)
2483 OK with gdcm, KO with the other viewers :-)
2484 * add a GE dlx XA image, thru the VEPRO burning station
2487 2003-10-21 Jean-Pierre Roux
2488 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2489 for a brutal checking of vtkgdcmViewer compliance
2491 2003-10-21 Jean-Pierre Roux
2492 * add the files for 'xmedcon' Jpeg Lossless library
2493 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2495 2003-10-21 Jean-Pierre Roux
2496 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2498 2003-10-21 Jean-Pierre Roux
2499 * garbage Siemens 'Leonardo' images dealt with
2500 (the patch is easy to remove)
2501 * cosmetic changes to avoid warnings
2503 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2504 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2505 no need to press 'r' now.
2507 2003-10-20 Jean-Pierre Roux
2508 * upgrade of checkRead.sh checkWrite.sh according
2509 to new Jpeg Lossless decompressor
2510 * add US.3405.1.dcm, a genuine RGB medical file ...
2511 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2512 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2514 2003-10-15 Jean-Pierre Roux
2515 * general anonymisation in gdcmData
2516 * adding the 'color files' from
2517 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2518 * adding some well knowed bugged-header images
2519 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2520 waiting for their inclusion in Python testsuite
2522 2003-10-15 Jean-Pierre Roux
2523 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2524 no longer seg faults when file is not found
2526 2003-10-14 Jean-Pierre Roux
2527 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2530 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2531 * TODO: *.in file to genereate a UseGDCM later
2533 2003-10-14 Jean-Pierre Roux
2534 * Some supposed-to-be Dicom Images have no preamble.
2535 OpenFile takes it into account
2536 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2537 * Missing elements added in dicomV3.dic
2538 (just to be affraid : have a look at
2539 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2540 and do it again next year ;->
2542 2003-10-13 Jean-Pierre Roux
2543 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2544 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2545 But there are NOT. It's fixed !
2547 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2548 * FIX: "jpeglib.h" was not found on VC++
2549 * FIX: vtkgdcm was not being installed
2551 2003-10-10 Jean-Pierre Roux
2552 * ENH : OpenFile closes the file if it *really* doesn't look like
2553 an ACR-NEMA / DICOM one.
2554 * FIX : testWrite no longer writes an empty file if the source file
2555 is not gdcm Readable
2556 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2559 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2560 * FIX: CMake generate now documentation
2561 * ENH: out of source doc build !
2562 * ENH: Generate both user and dev documentation
2563 * ENH: Should work on windows too
2564 * ENH: Only one doxygen config.in file is needed
2565 * FIX: make install should be ok now on ùnix plateform
2566 * FIX: PATH to dictionary was wrong (missing /)
2567 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2569 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2570 * vtkGdcmReader is now able to read rgb dicom file.
2571 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2572 * added a gdcmViewer to vtk test, use mouse to control
2573 window level & window width
2575 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2576 * CMake-ification of gdcm, we have now two build system
2577 * FIX: on cygwin Wsock32 doesn't exist
2578 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2580 2003-10-06 Emanuel Ollart
2581 * FIX : compilation process wad broken.
2582 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2584 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2585 * change gdcmViewer -> vtkgdcmViewer
2586 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2588 2003-10-06 Jean-Pierre Roux
2589 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2590 ( e.g : well known GE images with a wrong elem length,
2591 : Philips MRI Images with a wrong Huffman table)
2592 * still to be done : allow the reading of bugged LEONARDO Siemens images
2594 2003-10-03 Jean-Pierre Roux
2595 * Odd length strings are padded with '\0' (not with spaces,
2596 to remain compliant with already defined strings,
2597 like Transfert Syntax UID and others)
2599 2003-10-03 Jean-Pierre Roux
2600 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2601 to allow displaying RGB images (not only by affim ;-)
2603 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2604 * vtkGdcmReader is now able to read rgb dicom file.
2605 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2607 2003-10-03 Jean-Pierre Roux
2608 * A few nasty patches to allow the reading of a lot of nasty images
2609 ( e.g : well known GE images with a wrong elem length,
2610 : Philips MRI Images with a wrong Huffman table)
2611 * still to be done : allow the reading of bugged LEONARDO Siemens images
2613 2003-10-03 Jean-Pierre Roux
2614 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2616 2003-10-03 Jean-Pierre Roux
2617 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2618 to allow displaying RGB images (not only by affim ;-)
2620 2003-10-03 Jean-Pierre Roux
2621 * gdcmFile::GetImageDataIntoVector now
2622 - deals with MultiFrames MultiFragments Run Length Encoded files
2623 - deals with YcBcR (YBR_FULL) files
2624 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2625 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2627 (no sample found :-(
2629 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2630 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2631 Two reasons: - clear things
2632 - third parties acces gdcm through header files, so won't
2633 suffer anymore VC++ complains
2635 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2636 * add argv[1] in testvtkGdcmReader.cxx
2639 2003-09-24 Jean-Pierre Roux
2640 * The lines are now eigthy characters long.for
2641 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2643 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2644 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2645 char* to std::string. Thus, the use of strdup becomes useless. (see
2646 previous commis of Malaterre)
2647 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2648 before the last Malaterre's commit.
2650 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2651 * This commit should fix the Debug building under VC++, the problem
2652 was mainly a mixture of debug and release lib being loaded at startup.
2653 * I also remove a depency to a specific C function: strdup. Because I had
2654 to force the link to msvcrtd (whereas strdup is in libc).
2656 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2657 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2658 located in the gdcmCommon.h file. All use of reference of tha has been
2659 changed to now use the variable GDCM_UNFOUND.
2661 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2663 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2664 Dicom dictionary. The test suite can now be run again. Note:
2665 I'm note very happy with the " (RET)" changes. I believe this
2666 RETAINED comment should be dropped when parsing the dictionary.
2667 - PACKAGER corrected
2669 - AUTHORS updated and now in alphabetical order
2670 * Makefile.am now exports gdcm.dsw for Windoze users.
2672 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2673 * cygwin complains about missing std:: in subdir Test/
2675 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2676 * remove some methods that are now in gdcmHeaderHelper
2678 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2679 * vtkGdcmReader set spacing and origin correctly
2681 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2682 * Fix a few delete/delete[] mismatch
2684 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2685 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2686 interpretation to data given by gdcmHeader. For instance there are
2687 heuristics to get informations (look at different places).
2688 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2689 sorting DICOM images based on different strategies.
2690 * modified Makefiles accordingly.
2692 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2693 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2694 when building in debug mode
2695 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2696 src/win32/gdcmdll.dsp
2697 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2699 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2700 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2703 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2704 * src/win32/libgdcmjpeg12.dsp was not dos format
2705 * src/win32/libgdcmjpeg12.dsp :
2706 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2707 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2709 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2710 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2712 * src/gdcmFile.cxx : bug fix in affectation type
2713 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2714 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2715 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2716 symbols... future problem ?
2718 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2719 * src/win32/libgdcmijpeg12.dsp was missing
2720 * modified gdcm.dsw accordingly
2722 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2723 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2725 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2726 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2727 commit of JPR (before his hollidays to facilitate our work).
2728 * setup.py : bug fix in code. Modifications made while the last commit
2729 of JPR. The code hasn't been tested before the commit... it's so
2730 useless to make that (for best programmer that is JPR) !!!
2732 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2733 * tagged the current version as Version0_3 (i.e. version 0.3)
2735 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2736 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2737 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2738 * *.dsp : modifications to use new libgdcmijpeg8 library
2739 * setup.py : bug fix on VTKPATH variable
2740 * PACKAGER : adding all concerning windows
2742 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2743 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2745 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2746 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2747 test suite reported error.
2748 * PACKAGER file added (describes what a packager must do when
2749 packaging a new release).
2750 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2751 * configure.in: upgraded version number to 0.3.0
2752 * fixing build of rpm (through rpm -ta):
2753 - Doc/Makefile.am exports proper doxygen files
2754 - src/jpeg/libijg8/Makefile.am exports the include files.
2756 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2757 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2758 * src/gdcmHeader.h : formatting code
2760 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2761 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2762 We were obtaining error message from vtk. Now, creation of file list
2763 is made in an internal list to prevent this problem.
2764 Bug fix when output is empty.
2765 Bug fix in update of progress value. Previous commit for this was a bad
2767 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2769 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2770 * src/gdcmHeader.h : added method to get the file name
2771 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2772 files. Added method to remove all files on the input
2773 Added FIXME comment concerning the bad parsing of header made by
2774 ExecuteInformation method (in ExecuteData method)
2776 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2777 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2778 when using make instal.
2779 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2780 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2782 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2783 * setup.py : adding include dir of jpeg lib to compile all sources
2784 * */Win32/*.dsp : JPR fix for windows compilation
2786 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2787 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2789 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2790 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2792 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2793 * setup.py is again effective on un*x (takes into account the
2794 addon of the jpeg library)
2795 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2796 * Doc/Doxy* updated (includes above enhancements)
2797 * INSTALL now points to web documentation
2799 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2800 * src/gdcmHeader.h doesn't make unnecessary reference to
2802 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2804 * src/gdcm*.[cxx|h] :
2805 - to allow compilation with gcc 3.x
2806 -- clean up of STL usage (added explicit usage of std::)
2807 -- small fixes on exceptions.
2808 Note: linking not tested !
2809 - clean of doxygen comments to avoid warnings at documentation
2811 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2812 dependent convertion).
2814 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2815 * Clean up of previous JPR garbage commit (not even commented in the
2817 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2818 - moved all jpeg related files from src to src/jpeg/libijg8, with
2819 addition/modification of Makefile.am and configure.in.
2820 - the testSuite is still brain damage (not guilty).
2822 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2823 * WrapVTK.py : modifications to get correctly vtk source files to
2825 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2826 (FileName -> Filename)
2828 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2829 * vtk/vtkGdcmReader.[cxx/h]:
2830 - UpdateProgress method should now be effective
2831 - removed the limitation on having only images loaded (as opposed
2833 - when building a stack of images/volume, a lesser number of
2834 gdcmHeader and gdcmFile instances should be used (hopefully
2835 accelerating things).
2836 - when building a stack of images/volumes, files which are not
2837 loadable (wrong path-filename, wrong permissions on existing file,
2838 or file not parsable by gdcm) are replaced with a black image
2839 in the stack (for the caller to notice the problem).
2841 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2842 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2844 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2845 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2846 between standard library (std) and vtk library (problems are found
2847 under Windows... thanks Windows !)
2849 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2850 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2852 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2854 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2855 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2857 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2858 * When compiling with distutils (see setup.py) the C++ compiler is
2859 called with different flags than the default ones (with automake).
2860 In order to fix all those warning, I compiled gdcm with the command
2861 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2862 and went for warning fixes:
2863 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2864 up from unused variables.
2865 - vtk/vtkGdcmReader.cxx: potential bug fix.
2866 * src/gdcmHeader.h: Doxygen warning cleanup
2868 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2869 * gdcmPython/gdcm.i:
2870 - typemaps correction to take into account the systematic replacement
2871 of "using namespace std" with std:: prefix e.g. std::list,
2872 std::string... (cf changes of 2003-05-21).
2873 - gdcmGlob global variable of type gdcmGlobal (defined in
2874 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2875 exported to Python a as cvar.
2876 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2877 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2878 gdcmDictSet.GetPubDictTagNames() and
2879 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2880 C++ static methods).
2881 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2882 with the above changes.
2884 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2885 * setup.py, manifest.in : bug fix under linux
2887 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2888 * Modification of setup.py to compile vtk part too. Then, we have 2
2889 wrappers which must work with same distutils. For that, we have a
2890 generic distutils in distusiltsWrapping.py ; with :
2891 - build_extWrap class to wrap generically all extensions,
2892 - ExtensionWrap base class for all wrapping extension that contains
2894 - Wrapper interface which wrap sources
2895 + In WrapSwig.py we have extension and wrapper for Swig
2896 + In WrapVTK.py we have extension and wrapper for VTK
2897 * MANIFEST.in : modifications to consider vtk directory and new python
2898 files for compilation
2900 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2901 * Added python wrappers of vtkGdcmReader vtk class (see the
2902 source in vtk/vtkGdcmReader.cxx) :
2903 - vtk/Makefile.am now builds a library
2904 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2905 python library (as opposed to _gdcm.so wich are the python
2906 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2907 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2909 - configure.in has an additional flag --enable-vtk that needs
2910 to be set to enable compilation of vtk related code, that is:
2911 + vtk/vtkGdcmReader.so and
2912 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2913 + gdcmPython/vtkgdcmPython.so (see above)
2914 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2915 be read when compressed or when HighBit + 1 != BitsStored),
2916 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2917 the usage of the python wrapper of vtkGdcmReader vtk class.
2918 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2919 * src/*.[h] all occurences of stl classes are now prefixed with
2920 std::, and all occurences of "using namespace std;" where removed.
2921 This is to avoid pollution of global namespace in included files.
2922 Apparently vtk does not avoid this pitfall: when using both
2923 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2924 collision of various stl members (principally cout...).
2925 * gdcmPython/testSuite.py now cleanly removes temprory generated
2927 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2928 comply with above changes)
2930 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2931 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2932 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2933 vtk data structure (an image Flip was required).
2934 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2935 * cosmetic changes in documentation.
2937 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2938 * src/gdcmHeader.cxx: the constructor no longer exits when an
2939 unexisting file is given as argument.
2940 * The subdirectory Data (containing all the images used for the
2941 test suite) is not part of this repository anymore. A new module
2942 containing those images is now available at
2943 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2944 with the name gdcmData.
2945 All the python scripts (including the package initialisation file
2946 gdcmPython/__init__.py) were adapated to take this change into
2947 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2949 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2950 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2951 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2952 demo of the usage of this class.
2953 Compilation of this vtk part is only done when using the --enable-vtk
2954 at configure (or autogen.sh) stage.
2956 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2957 * More memory link related corrections and documentation fixes.
2959 - maximum info is obtained with a command of the form:
2960 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2961 --show-reachable=yes PrintHeader
2962 - the remaining reachable blocks seem to come from the STL
2963 allocation scheme through the usage of map and list. It looks
2964 like this memory cannot be freed but it is not a memory leak
2965 (in fact further invocation to the STL would recollect the
2966 unused memory allthough it cannot explicitely be freed).
2967 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2968 of displaying an image parsed with gdcm and displayed with VTK.
2969 Note: some images don't seem to work e.g.
2970 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2971 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2972 Allthough this weakens the semantics, it is a ditch attempt to
2973 make gdcm more thread friendly.
2975 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2976 * Memory link hunt (by using valgrind through the command
2977 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2978 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2979 gdcmHeader::_dicom_vr.
2980 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2981 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2983 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2985 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2986 * src/Makefile.am now exports all the necessary include files at
2990 * UpdateGroupLength replaced by new one
2993 * UpdateGroupLength re-written using H-Table
2994 (named UpdateGroupLengthNew untill checks are over)
2996 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2997 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2998 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
3000 - gdcmHeader::GetPubElValSet removed.
3001 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
3002 UpdateGroupLength, WriteElements, Write.
3003 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
3004 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
3005 carried the same semantics.
3006 - src/gdcmHeaderIdo.cxx changed accordingly.
3007 - gdcmFile::WriteBase now regroups all the codes from previous
3008 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
3009 - enum FileType moved to gdcmCommon.h
3010 * src/gdcmHeader.cxx AddDefault trashed
3011 * gdcmGetXSize added
3012 * getimageDataSize now calls gdcmGetXSize
3013 * Test/*.cxx changed to agree with above changes
3015 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3016 * src/gdcmHeader.h: LoadElements() is not a public method anymore
3017 (to avoid double call by end user).
3018 * Test/*.cxx LoadElements() doesn't need to be called explicitely
3019 by end user, since gdcmHeader::gdcmHeader now handles it.
3021 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3022 * gdcm/Doc many doxygen changes:
3023 - Doxyfile now has two different versions, DoxyfileUsers that generates
3024 the html.users end users oriented documentation and
3025 DoxyfileDeveloppers that generates the html.developper developper
3026 oriented documentation.
3027 - README changed accordingly
3028 - requirement.txt removed (old design info moved to TODO).
3029 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
3030 DoxyMainPage.txt, DoxyPython.txt provide more information.
3031 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
3032 be updated by simply regenerating the docs with doxygen and copying
3033 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
3034 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
3035 all the tests in the form "if (<map>.count() >1)" were removed.
3036 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3037 ill-formed documentation sections.
3038 * src/gdcmHeader.cxx: ditto
3040 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3041 * setup.py fixed for un*x (needed macro for stdint.h)
3042 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3043 un*ces with sh-utils test utility.
3044 * gdcmPython/demo/test.py renamed to PrintHeader.py
3045 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3046 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3047 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3048 * src/gdcm*.cxx JPR's bad inclusion fixed.
3050 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3051 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3052 * gdcmPython/demo/test.py changed accordingly.
3054 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3055 * gdcmPython/Makefile.am fixed linking against libstdc++
3056 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3057 * Swig subdir (historical tests of swig version 1.3.17++) removed
3058 * Test/testChangeEntete.cxx some lines commented out in order to make
3060 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3061 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3063 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3064 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3065 hence the user doesn't need this explicit call.
3066 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3067 i.e. LoadElements() call removed.
3068 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3069 - src/Makefile.am declares the proper flag for g++.
3070 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3071 for adding user defined new tags.
3072 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3073 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3074 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3076 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3077 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3078 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3079 src/Makefile.am : the project should properly compile and install
3080 with the autotools, included the python wrappers part.
3081 * gdcm.spec.in : added a spec file for RPM packaging.
3083 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3084 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3086 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3087 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3088 to exported to the environement (see gdcmPython/testSuite.py
3090 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3091 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3092 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3093 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3094 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3096 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3097 * gdcmPython/__init__.py doesn't crash anymore when running in
3098 in InstallMode or PreInstallMode but with an environment given
3099 value of GDCM_DICT_PATH.
3100 * src/gdcmDictSet.[cxx/h] coding style.
3102 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3103 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3104 * src/gdcm.h general comments moved to TODO, and README
3105 * src/gdcm.h should now be seen as a user commodity (including it
3106 should suffice to fully use gdcm). It is nowhere including within
3107 any of the kernel files src/*.cxx and src/*.h.
3109 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3110 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3111 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3113 * src/gdcm*.cxx only include their corresponding include file
3114 (as opposed to gdcm.h)
3115 * gdcmPython/gdcm.i changed accordingly
3116 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3117 the autogen.sh generated "make snapshot" command to work.
3118 * autogen.sh removed history related references to crea package.
3120 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3121 * distutilsSwigCPlusPlus.py work around some swig portability
3124 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3125 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3126 was done in a last ditch attempt to get setup.py _really_
3127 operationnal. The python/gdcmPython layaout add the advantage
3128 of hidding away the python related distutils specific files
3129 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3130 Alas, the src directory was out of scope (i.e. it's relative
3131 position to setup.py was ../src) which made things impossible to
3132 handle (see previous version of python/setup.py). Crossing fingers...
3134 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3135 * python/setup.py now works on Un*x. (harder than I thougth)
3136 * python/distutilsSwigCPlusPlus.py can now have include files
3137 among the list of sources.
3139 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3140 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3141 * modifications in MSVC projects
3143 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3144 * As stated by the first lines of Test/ExceptionAndPython/README, it
3145 looks like we can move back to original usage of exception within
3146 src/gdcm* and hence remove the errno stuff that was introduced
3147 as a quick and dirty fixture of this problem (added to the TODO).
3148 * Doc/Doxyfile configuration file for Doxygen and corresponding
3149 README file for usage added.
3150 * Test/testWrite.cxx added. This new test comes from a split of
3151 test.cxx that is now reverted to its original purpous i.e.
3152 testing the proper parsing of a Dicom related file.
3153 testWrite.cxx concentrates on testing the IO part of gdcm.
3154 * Test/bug1.cxx (containing a bug on WIn32) added.
3155 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3156 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3157 whose purpose is to publish the content of the TagNames of the
3158 Dicom public dictionary were not accessible without an
3159 instance of class gdcmHeader.
3160 - those methods are now static methods of gdcmDictSet and hence
3161 require no instances at all to be invocated.
3162 - within gdcmDictSet this change required to change some method
3163 to class methods (i.e. are now static) among which SetDictPath
3164 (renamed to BuildDictPath) and LoadDefaultPubDict.
3165 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3166 the above changes by calling the new method classes of gdcmDictSet.
3167 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3168 the above to be effective.
3169 * python/gdcmPython: in order to wrap properly the above changes
3170 for Python, swig version now needs to be > 1.3.17.
3171 * python/gdcmPython/Makefile fixed to adapt itself to new
3172 configure/make shema introduced by Johan Montagnat (thanks for the
3173 contribution). Alas this Makefile cannot be turned into a proper
3174 Makefile.am without some heavy changes in the configure.in
3175 (for python dectection).
3176 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3177 now avoids publishing the empty entries.
3179 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3180 * python/setup.py : bug fix concerning install under windows
3181 ExtraPath reused :-P
3182 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3184 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3185 * Dicts/dicomV3.dic : remove double spaces !!!
3186 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3187 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3190 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3191 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3192 method. Doxygenation.
3193 * src/gdcm.h clean up of JPR spurious comments.
3195 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3196 * python/distutilsSwigCPlusPlus.py now properly collects the
3197 shadow classes generated by "swig -c++" (gdcm.py in our case)
3198 when using "python setup.py install".
3199 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3200 reexports the working classes.
3201 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3202 by the classical C errno scheme. This is to prevent an obscure
3203 behavior of the python wrappers when importing wxPython.wx prior
3204 to gdcmPython (which ended up in an abort call). An illustration
3205 of this oddity can be found in the Test/ExceptionAndPython
3206 subdir (see the README file). This problem probably due to
3207 an combination of g++ and dynamic loading.
3208 * added Test/ExceptionAndPython (see above)
3210 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3211 * Changed the layout of the python part to avoid bloating main
3212 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3213 i.e. the distutils arsenal. All the python related stuff is
3214 again in a python subdir, but the package itself is now in
3216 * setup.py was cleaned up:
3217 - pythonIncludePath removed
3218 - python setup.py bdist target is now functional.
3219 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3220 collision with other packages). gdcmPython/demo/*.py changed
3223 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3224 * python subdir moved to gdcmPython (preparation of distutils packaging).
3225 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3226 distutils installer is operational.
3227 * - gdcmPython/__init__.py now properly loads the swig generated
3228 shadow classes (from gdcm.py).
3229 - gdcmPython/demo/*.py changed to import the package gdcmPython
3230 instead of gdcmPython/demo/load.py.
3231 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3233 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3234 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3235 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3236 entries within the associated public Dicom dictionary resp. the same
3237 information but sorted by the fourth field (PAT, IMG, DIR) of the
3239 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3240 are now in the "???" group.
3241 - python/gdcm.i changed accordingly,
3242 - python/demo/printGroupedPublicDict.py added, that gives an example
3243 of the above new functionalities in Python.
3245 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3246 * src/gdcm.h, gdcmHeader.cxx:
3247 - historic references to glib's g_malloc and g_free (#defined)
3248 were definitively removed.
3249 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3250 * src/gdcmElValSet.cxx:
3251 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3252 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3253 - GetElValue(string) renamed to GetElValueByName.
3254 - Added GetElementByName(string).
3255 * src/gdcmHeader.cxx: added
3256 - GetPubElValRepByNumber(guint16, guint16)
3257 - GetPubElValRepByName(string)
3258 - GetShaElValRepByNumber(guint16, guint16)
3259 - GetShaElValRepByName(string)
3260 - GetShaElValByNumber(guint16, guint16)
3261 - GetShaElValRepByName(string)
3262 - GetElValRepByNumber(guint16, guint16)
3263 - GetElValRepByName(string)
3264 - GetElValByNumber(guint16, guint16)
3265 - GetElValRepByName(string)
3266 * Doc/requirements.txt added.
3268 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3269 * Test/Makefile building now depends on the one of libgdcm.so
3270 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3271 pixel data) aware which enables finding the address (offset) of
3272 the pixel data of JPEG encoded DICOM files. This leaves only a single
3273 file in the testSuite whose pixel data address (offset) is unknown.
3274 * python/testSuite.py changed accordingly.
3276 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3277 * VC++ has some strong limitations when working with the STL, as stated
3278 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3279 "Also note that some STL containers (map, set, queue, list, deque)
3280 cannot be exported. [...]
3281 Some STL classes contain nested classes. These classes can not
3283 This is caused by a designed limitation that once a template
3284 class is instantiated, it can not be re-instantiated and
3286 Since our usage of map<> is ubiquitous in gdcm, this "designed
3287 limitation" of VC++ is a pitfall.
3288 Hence the Python wrappers of gdcm cannot be incrementally linked
3289 against the c++ dynamic library. The dirty but only workaround is
3290 to forget about incremental link of dynamic libraries and to generate
3291 the Python wrappers library with the inclusions of the underlying C++
3293 The following modifications concern this matter on Win32/VC++:
3294 - wrapping python correct with standalone wrapped dll (don't use separate
3295 dll under windows !!!!)
3296 - python21_d debug mode enabled (ask Frog how to use it :-)
3297 - NO problem with having an STL member of class for example string in C++
3298 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3299 - Python test of dcmlib in Python is ok under windows on a large set
3301 * removed glib references
3302 * typedef's inserted in gdcm.i for correct swig type management
3304 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3305 * python/demo/*.py load.py extracted from test.py. Added explore.py
3306 that only displays required tags and testAll.py that parses all
3307 the files of the testsuite without using unittest.
3308 * python/testSuite.py other additional test on new files added.
3309 * Data/* new test files added accordingly to the testSuite.
3310 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3311 the vr in the file differs from the one of the dictionary.
3313 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3314 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3315 values, but limits itself to values which are below a user specified
3316 size (by default 1024 bytes).
3317 * python/gdcm.i : elements not loaded (because their size is above the
3318 user specified treshold) are exported with their TagKey as key of the
3319 python dictionary. This enables the testsuite to make some checks
3320 on the unloaded elements (since we have their offset and size).
3321 * python/testSuite.py
3322 - now tests for the existence and proper value of the pixel data
3323 - two new examples added.
3324 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3326 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3327 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3328 aware. See the strategy comments in gdcmHeader::FindLength().
3329 * Test/test.cxx now accepts a filename as first argument.
3330 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3331 * python/testSuite.py changed to integrate test on above files.
3333 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3334 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3335 the vr was also RET.
3336 * python/testSuite.py more tests added.
3338 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3339 * python/testSuite.py unittest test suite added (uses Data)
3340 * Data/* dcm and acr files for the test suite.
3341 * glib dependance removed from un*x version. We now use ISO C99
3342 7.18 Integer types (see stdint.h)
3343 - python/Makefile, src/Makefile src/gdcm.h
3344 * src/ when an explicit vr (like dicom files) suddenly poped an
3345 implicit element we use to mark the underlying DictEntry of the
3346 concerned ElValue with "Implicit". This strategy was damageable
3347 too the public or provite dictionaries, since some of their vr
3348 would be changed. Since Header::FindLength heavily relies on the
3349 detection by Header::FindVR of falsely explicit elements, I
3350 added an extra ImplicitVr member to ElValue (boolean).
3351 The rest of the changes we the necessary adaptations.
3353 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3354 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3356 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3358 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3359 * Adaptation for porting to VC++:
3361 o forced to use std namespace (for string to be known)
3362 o all class use __declspec export style on WIN32
3363 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3364 (in stdlib.h on Win32 but in std:: for gcc)
3365 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3366 variable GDCM_DICT_PATH.
3367 * src/gdcmHeader.cxx verbose comments made discrete.
3369 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3370 * python/gdcm.i: added a typemap that converts a C++ hashing table
3371 to native Python dictionary.
3372 * python/demo/test.py:
3373 - now uses the native dictionary for exploration of gdcmHeader.
3374 - takes an optional filename argument (the file to parse).
3375 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3376 PubElVals hashing table.
3377 * Dicts/dicomV3.dic removed error prone trailing spaces.
3379 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3380 * Python wrapping process moved away from src/Makefile to
3381 newly created python/Makefile (as well as gdcm.i)
3382 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3383 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3384 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3385 from the environement variable GDCM_DICT_PATH (when existing).
3386 * src/gdcmDict::GetTag bug fix.
3388 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3389 * Straightforward temporary fixes for swig to build the python wrappers.
3390 src/Makefile now has a python working entry [by working we mean
3391 that we can import the shadow classes without errors].
3393 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3394 * hashtest.cxx removed (since already in Test)
3395 * src/gdcmlib.h renamed to src/gdcm.h
3396 * src/dcm.i renamed to src/gdcm.i
3397 * src/Makefile prepared for python wrapping
3399 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3400 * src/gdcmHeader.cxx :
3401 - Parsing of header is now separated from loading of element values
3402 (see gdcmHeader::LoadElements).
3403 - general clean up of hopefully all file access (creation of
3404 ReadInt16 and ReadInt32)
3406 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3407 * src/gdcmHeader.cxx :
3408 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3410 - SetLgrElem renamed to SetLength
3411 - GetLgrElem renamed to GetLength
3412 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3413 * src/gdcmElValSet.cxx fixed both GetElValue methods
3414 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3415 due to IdoDude was cleaned out.
3417 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3418 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3419 concentrates on finding the value representation (when it exists).
3420 RecupLgr now only finds the element value length, and it avoids
3421 returning the unecessary skL (skipped length).
3422 Also, offsetCourant was simply removed (with taille_fich) since
3423 it was redundant with the File position internals (by using
3424 ftell and fseek). This also made skL (see above in RecupLgr) usage
3426 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3427 on the libido specificities which are handled through class
3429 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3432 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3433 * Truckload of changes. Parsing of header is barely functional
3434 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3436 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3437 * src/gdcmHeader.cxx many addons of low level methods
3439 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3440 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3441 and _IdDcmSWAP_LONG.
3443 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3444 * This corresponds to all the changes decided at the meeting of
3445 May 23 2002. Needless to say we are running late...