1 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Improve string manipulation. I now inforce the notion of 'DicomString'
3 A DicomString can contain as many \0 as they want
4 and it is *always* of even length.
5 We only support odd length for very rare case.
6 And in the near future this should be removed.
8 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
9 * /binary_write/ gdcm source. Now even on big endian we are writting
10 little endian. This should -heopfully- fix some tests
12 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
13 * Now the dictionary is compiled into gdcm lib. This is a default
14 behavior, thus any dic file specified is picked before failback to
15 the one comiled into lib
17 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
18 * Change internals for gdcmDict. Don't use any 'new' any more.
19 This should definitely solve any leak problem, and we should be
20 as fast as before, as long as don't modify too much the dictionary.
22 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
23 * STYLE: ivars should start with a capital letter.
24 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
25 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
27 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
28 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
29 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
30 new 2004 dictionaries added (thanks to JPR).
31 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
32 * CLEANUP_ROUND (15) for gdcmPixelConvert
33 - RLEFrame::NumberFragments is now of type unsigned int
34 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
35 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
38 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
39 * Initial work in gathering all transfer syntax accessors. clearly
40 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
41 ivars, but only one transfersyntax (class) ivar with equivalent method on
44 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
45 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
46 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
47 discussed (plus I didn't like having a 2000 lines patch not commited)
49 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
50 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
51 * CLEANUP_ROUND (14) for gdcmPixelConvert
52 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
53 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
54 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
56 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
57 anymore and hence avoids storing a copy of PixelConvert::Decompressed
58 into File::Pixel_Data.
60 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
61 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
62 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
63 * CLEANUP_ROUND (13) for gdcmPixelConvert
64 Substituted File::ParsePixelData() with PixelConvert::Print() new
66 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
67 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
68 method to those classes.
69 - src/gdcmFile.[cxx|h]:
70 -- Added a ::Print() method.
71 -- PixelConverter is now a reference instead of a member.
72 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
73 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
75 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
76 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
77 collaboration diagram and inheritance diagram should be generated with
79 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
80 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
81 pointlessly wrapped (see
82 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
83 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
84 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
85 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
86 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
87 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
88 -- File::Initialise: PixelConverter setup moved away to
89 PixelConverter::GrabInformationsFromHeader()
90 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
91 interpretation moved away to PixelConverter::BuildRGBImage()
93 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
94 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
95 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
97 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
98 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
99 displayed on Win32 when a brutal abort() occurs (because of uncatched
100 exception). See TODO new entry of this commit for more on this.
101 * TODO added new entry.
102 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
103 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
104 - HandleColor is no longer called from gdcmFile.cxx
105 - gdcmPixelConvert.cxx clean up on method arguments and internal
106 variable names for semantical coherence.
108 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
109 * Finished lossless transition, not only do we now read all lossless jpeg
110 images, without the need of the Cornwell lib, but we do read them properly now
111 * To reduce code (well to avoid code duplication), I defined a common place
112 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
113 redefine symbols. This is not prefect but this the best solution I found for a
114 compilation time jpeg option.
116 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
117 * Update jpeg ijg lib to support lossless jpeg implementation
118 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
120 * Also added a special copyright for dcmtk since we use their bugfixes.
123 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
124 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
125 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
126 matters, as stated in warning note at begining of %include section).
127 * src/gdcmDicomDir*.[cxx|h]: coding style
128 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
129 * src/gdcmJpeg8.cxx: doxygen fix.
130 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
131 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
132 from File:: to PixelConvert::.
134 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
135 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
136 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
137 - more code moved away from File:: to PixelConvert::
138 - fat setup of PixelConverter set in place in File::Initialise.
140 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
141 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
142 namespace at the file system level. So now you should convert your examples
144 gdcmHeader -> gdcm::Header
145 It would be nice if people keep in mind to no open the namespace, since it
146 allows compilation on broken plateform which were defining common symbol in
147 the standart namespace (like LP, Unknown ...)
149 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
150 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
151 The JPEG fragments are now parsed at the same stage than the RLE
152 information. All code related to JPEG is now in gdcmPixelConvert:
153 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
154 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
155 export a gdcmFile:: method. Those are simply global functions
156 (for the time being this is better than having them attach to
157 either gdcmFile:: or gdcmPixelConvert::).
158 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
159 and stores the result in a gdcmJPEGFragmentsInfo.
160 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
161 code (among other stuff) moved away from gdcmFile:; to
164 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
165 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
166 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
167 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
168 clean up of RLE related code.
169 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
170 - src/gdcmRLE.cxx removed
171 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
172 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
173 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
174 * CLEANUP_ROUND (9) for gdcmPixelConvert
175 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
176 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
177 away from gdcmFile:: to gdcmPixelConvert::.
179 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
180 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
181 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
182 This is because Parse7Fe0 used to parse the pixels to compute the
183 length. This task was passed over to FindDocEntryLengthOB() a long
184 time ago, EXCEPT I had forgotten the OW case...
185 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
186 we just recylce the code for parsing RLE fragments and computing
188 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
189 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
190 with the retired Parse7Fe0().
191 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
192 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
194 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
195 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
196 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
197 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
198 - src/CMakeLists.txt: alphabetic order reodering + new entries.
199 * CLEANUP_ROUND (4) for gdcmPixelConvert
200 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
201 to return an unused length.
203 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
204 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
205 this should be cleanner from the plane view. The iostream are erally a pain
206 to use to do simple stuff.
208 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
209 * Redo the compilation of the ijg jpeg library. Now only one source is
210 necesseray. No need to rename file by hand what so ever. CMake handle the
211 copying of the file within different directory, configure header file to
212 modify some symbol. The only addition made to ijg wasd a mangle table so
213 that symbol are different wether we are within 8bits or 12bits.
215 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
216 * Added documentation of vtkgdcmReader on Website:
217 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
218 with it's binary name).
219 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
220 the Website to be more complete.
221 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
222 doxygenated documentation.
223 - Doc/DoxyVtkGdcmReaderExamples.txt added
224 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
225 DoxyVtkGdmReaderExamples.html )
226 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
227 * CLEANUP_ROUND (3) for gdcmPixelConvert
228 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
230 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
231 * CLEANUP_ROUND (2) for gdcmPixelConvert
232 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
234 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
235 * CLEANUP_ROUND for gdcmPixelConvert:
236 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
237 - src/gdcmPixelStuff[h|cxx] removed
238 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
239 - src/CMakeLists.txt changed accordingly
241 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
242 gdcmVersion.py moved to newly created ATTIC related
243 gdcmPython/SetupOldies/ directory.
244 * Autotools clean up:
245 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
246 - autogen.sh configure.in acinclude.m4 python.m4 removed
248 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
249 * src/*.cxx *.h Reference to License.htm fixed to License.html.
250 * Doc/CMakeLists.txt, doxygen.config.in: fix.
251 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
253 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
254 * TODO updated with Mathieu suggestions. I proposed a template for
255 describing TODO entries and used it for new entries.
256 * Added Doc/Website/CodingStyle.html, Developpers.html,
257 DeveloppersPython.html, GdcmDataCvs.html and
258 DownloadVersion0_1.html, DownloadVersion0_3.html.
259 * Some Doc/*.txt Doxygen files (which do not really concern the
260 documentation itself, but the website) moved to html and
261 placed in directory Doc/Website:
262 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
263 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
264 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
265 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
266 * CMakeLists.txt changed accordingly.
267 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
268 DeveloppersPython.html
269 * INSTALL nows refers to Doc/Website/Installation.html
271 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
272 * Added Doc/Website directory, that contains a first raw version
275 2004-09-23 Jean-Pierre Roux
276 * FIX In order not to be poluted any longer by casting problems,
277 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
278 we can now delete[] it safely
279 * VoidArea is now called BinArea (less confusing name),
280 and all the methods called ...VoidArea... are now ... BinArea...
281 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
283 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
284 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
285 clear) TagHT, which is an inherited member of gdcmElementSet. It is
286 up to the destructor of gdcmElementSet to clean up TagHt and it's
289 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
290 * Test/CMakeLists.txt: update to follow gdcmData renamings.
291 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
293 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
294 * ENH: added some utility method that builds a flat dictionnary
295 holding all the Dicom entries contained in the recursive structure
296 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
298 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
299 BuildFlatHashTable() that build a flat dictionary.
300 - src/gdcmElementSet.h: added a new private GetTag() accessor.
301 gdcmDocument is now a friend of gdcmElementSet.
302 - src/gdcmElementSet.cxx: clean up.
303 - Example/FlatHashTablePrint.cxx added.
304 - Example/CmakeLists.txt changed accordingly
306 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
307 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
308 moved away from gdcmDocEntrySet (since this class is an abstract class
309 acting like an interface). SQDepthLevel and BaseTagKey are now
311 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
312 and associated accessors. Doxygenation of the class.
313 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
315 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
316 Use SQDepthLevel accessor instead. ::Print() adapted.
317 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
318 - src/gdcmDocument.cxx changed accordingly.
320 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
321 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
322 - The following is the doxygen comment of the typedef declaration
323 of gdcmagKey in src/gdcmCommon.h:
324 gdcmTagKey is made to old an "universal" (as in URL, Universal
325 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
326 A dicom tag allways has a group and an element, but a set of tags
327 embeded in various (optionally nested) sequences and sharing
328 the same group and element all share the same (group, element)
329 "identifier". Hence the (group, element) cannot be used as an
330 identifier (in gdcm we shall refer to a "TagKey") of a tag.
331 In order to construct a proper tag identifier (i.e. a key) we
332 consider the following definition of a TagKey:
333 - let Group, Element be the string representation of the
334 group and element dicom tag members,
335 - let ItemNumber be the string representation of the integer
336 index of the considered item number of a sequence,
337 Let the key of a tag embeded in a sequence, noted SeqTag, be
339 /ItemNumber#Group|Element
340 where "/", "#" and "|" are characters acting as separators.
341 Then the general form of a gdcmTagKey is given by:
342 Group|Element<SeqTag>
343 where <SeqTag> means NO or many instances of SeqTag.
344 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
347 but the gdcmTagKey of a tag "embeded" is the first item of
348 a sequence, itself nested in the third item of a sequence is the
350 0004|1220/2#0008|0082/0#0008|0090
351 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
352 order to hold the new sequence compatible key. Previously, the
353 GetKey() method would look in the underlying gdcmDictEntry.
354 - src/gdcmDocEntry.cxx:
355 -- constructor now copies the underlying DictEntry key, in the local
357 -- ::Print: displays the member Key, instead of the (group, element).
358 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
359 - src/gdcmDocEntrySet.h:xi
360 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
361 -- now has a new BaseTagKey member.
363 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
364 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
366 This poses the problem with the semantics of the following lines
367 LoadEntryVoidArea(0x0028,0x1201); // R LUT
368 LoadEntryVoidArea(0x0028,0x1202); // G LUT
369 LoadEntryVoidArea(0x0028,0x1203); // B LUT
370 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
371 to the long FIXME note for what the problem is. Nevertheless in
372 order to get things working the dicom dictionary was altered !
373 Please fix things urgently...
374 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
375 information), see above note on moving the member VoidArea. Nevertheless
376 the following entries previously correctly set as US are now inproperly
378 0028 1201 OW IMG Red Palette Color Lookup Table Data
379 0028 1202 OW IMG Green Palette Color Lookup Table Data
380 0028 1203 OW IMG Blue Palette Color Lookup Table Data
381 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
382 of gdcmDocEntry moved to gdcmSeqEntry.
383 * src/gdcmSeqEntry.cxx: STYLE.
385 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
386 * Test/TestAllEntryVerify.cxx minor fix and added comments.
388 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
389 * gdcmPython/testSuite.py: all the test suite in python is now moved
390 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
391 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
392 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
394 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
395 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
396 to avoid inclusion recursion until STL is reached.
397 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
398 mecanism. errno.h is not included in gdcm anymore.
399 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
400 (gdcmFormatError now inherits from gdcmFormatUnexpected).
402 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
403 gdcmData/TestAllEntryVerifyReference.txt
404 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
405 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
406 exception_on_error parameter.
407 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
408 - vtk/vtkGdcmReader.cxx changed accordingly,
409 - Example/*.cxx and Test/*.cxx changed accordingly.
411 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
412 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
413 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
414 enable_sequences removed from gdcmHeader constructor and dependencies.
415 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
416 * gdcmPython/demo/PrintHeader.py: dummy fix.
417 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
418 skip_shadow removed from gdcmHeader constructor and dependencies.
419 * Example/*.cxx and Test/*.cxx changed accordingly.
421 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
422 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
423 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
425 2004-07-21 Jean-Pierre Roux
426 * FIX Now, Parsing and Printing a DICOMDIR do work!
427 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
429 2004-07-20 Jean-Pierre Roux
430 * FIX Some brain damaged headers have Zero-Lenght fields
431 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
433 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
434 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
435 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
436 variable (instance of gdcmDebug) by a definition macro, and the instance
437 is now in static in the gdcmDebug class
438 * src/gdcmSQItem.h : (FIXME) remove an undefined method
439 * Test/PrintAllDocument.cxx : bug fix in the result of the test
441 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
442 * WARNING: ctest now depends more tightly on gdcmData. You should
443 check out gdcmData properly for things to run smoothly...
444 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
445 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
446 we need the pixels not be loaded in order to use the ValEntry
447 that displays position and size).
448 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
449 This is a C++ based equivalent of gdcmPython/testSuite.py that should
450 be deprecated. If you have any doubts about the advantages of a
451 modern scripting language (read Python) versus grass root C++ (i.e.
452 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
453 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
454 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
455 Anyhow, consider documenting the gdcmData images in
456 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
458 * Test/CMakeLists.txt:
459 - now uses TestAllEntryVerify.cxx
460 - specific comments on oldACR00001.ima (now renamed in gdcmData
461 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
462 gdcmData/TestAllEntryVerifyReference.txt
465 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
466 * src/*.[h|cxx] : typedef clean up
467 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
468 - TagKey renamed to gdcmTagKey (for external usage)
469 - VRKey renamed to gdcmVRKey (for external usage)
470 - removal of typedef duplication.
471 - Removed all unecessary inline keyword from class inline definitions.
472 - Some method|function(void) declarations replaced with method|function().
473 * src/jpeg/libijg12/jdhuff12.c:
474 - printf polluting ctest removed.
475 - TAB removal for comminting
477 - TestAllReadCompareDicom.cxx: added a test that compares all the
478 images in gdcmDataImages.h with corresponding images in
479 gdcmData/BaselineDicom/. When baseline images are not present
480 this test creates them.
481 Note: we need to validate each reference image, but before that
482 I'd like to rename them with a more explicit name...
483 - CMakeLists.txt: changed accordingly.
484 * Example/*.cxx: examples now only include gdcm.h (as opposed to
485 including each header needed).
487 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
488 * Test/*.cxx and Example/*.cxx: moved some examples away from the
489 test suite to the Example directory. Are concerned:
494 - TestWriteSimple.cxx
495 * Test/CMakeLists.txt: added some comments on reasons for black listing
496 image gdcmData/oldACR00001.ima
498 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
499 * Test/CmakeList.txt: removed the following from black list (to be coherent
500 with removal from gdcmData):
501 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
502 - gdcm-MR-PHILIPS-16.dcm
504 Added the following because after last cvs update, they cause
505 ctest -R TestReadWriteReadCompare
507 - gdcm-MR-SIEMENS-16-1.acr
509 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
510 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
511 new comments in this file) we temporarily (sigh) move to a weaker
513 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
514 we don't need to black list the following images anymore:
515 - 8BitsUncompressedColor.dcm
517 - US-PAL-8-10x-echo.dcm
518 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
519 fixes and the beautified code ;-)
520 This fixes the bug introduced in version 1.42 (when beautifying)
521 that made the parsing of 8BitsRunLengthColor.dcm unproper.
522 Note: ctest was blind to this bug (this means we need to still
523 improve the test suite). The bug could be detected by using
524 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
526 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
527 and by displaying the (garbage) produced file temp.XDCM...
529 2004-06-29 Jean-Pierre Roux
530 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
531 - replace by uggly but working old code :-(
532 A lot of things should be OK again.
533 It's really urgent to have a test suite that *tests*,
534 to prevent Frog's beautifying sessions to break all the stuff
535 (twice, withing a fortnigh ...)
537 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
538 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
539 redundancy) to added Test/TestReadWriteReadCompare.cxx
540 * Test/CmakeList.txt: because the compare test of
541 Test/TestReadWriteReadCompare.cxx fails, the following images are
542 black listed: - 8BitsUncompressedColor.dcm
544 - US-PAL-8-10x-echo.dcm
545 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
546 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
547 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
548 and ad-hoc kludge. This kludge is now removed, and on encountering
549 such an image (OB field brain damaged) we set errno. Then in
550 ::FindDocLength() we "fix" the length as being ALL what remains
551 in the file (until EOF). We then proceed, hoping for the best...
552 This fixes a SegFault in ShowDicom when trying to write such an
554 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
555 (because TestWriteRead breaks on it, after a non conformal commit?).
556 ctest now runs properly, except for MakeDicomDir (which was allways
557 broken) and the Python related stuff (still not fixed).
559 2004-06-24 Jean-Pierre Roux
560 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
561 FIX : Test/TestReadWrite now iterates on all the file names
562 (instead of infinite loop)
563 ENH : Test/TestWriteRead now iterates on all the file names
565 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
566 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
568 2004-06-24 Jean-Pierre Roux
569 FIX : - now Write drops LUT Descriptors and LUTs (if any)
570 when SamplesPerPixel =3
571 - now Write is no longer confused by
572 'BitsAllocated = 12" and 'BitsStored=12"
573 - "UN" value representation Elements are now written correctly
574 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
575 ENH : - now gdcmHeader has its own Write methods
576 (in order to split the job that has not to be done
579 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
580 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
581 loop on the same image until memory went out.
582 Note: this means we still have gobs of memory loss in PrintDocument
583 * src/gdcmDocument.cxx: fixes problem on parsing on file
584 gdcmData/16BitsJpegLosslessGrayScale.dcm.
586 2004-06-24 Jean-Pierre Roux
587 FIX : Write - All the Sequences and Sequence Item are now written
588 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
589 is added a the end, when necessary.
590 - A lot of brain-damaged images, that were read correctly are
591 now written correctly
592 - length compatible BinEntry are now loaded correctly
593 (even for odd groups)
594 Note : only Explicit Value Representation was checked.
595 (question : is implicit VR really necessary for gdcm ?)
597 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
598 * DEVELOPPER: added a proposition of coding style.
599 * src/gdcmDocEntry.h: removed every inline declaration (for test of
602 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
603 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
604 Use the gdcmDocEntry::Print() and Write() instead.
605 * src/gdcmDocument.cxx: bug fix.
607 2004-06-22 Jean-Pierre Roux
608 FIX : gdcmDocument.cxx
609 - Now we do recognize the JpegLossLess format (there was a misstyping in
610 code 'beautyfication' :-(
611 - Now we automaticaticaly load the Luts, if any
613 2004-06-22 Jean-Pierre Roux
614 In order : to write Sequences, whatever their imbrication level,
615 : to allow user to create his own Sequences
616 a lot of modif where necessary (adding, moving, or virtualising methods)
618 WARNING : save your own sources *before* cvs up !
621 ADD virtual void Write(FILE *fp, FileType filetype);
624 ADD virtual void Write(FILE *fp, FileType filetype);
625 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
628 ADD virtual void Write (FILE *fp, FileType filetype)=0;
629 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
630 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
631 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
632 ADD std::string GetEntryByName(TagName name);
633 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
635 std::string vr = "unkn",
636 std::string fourth = "unkn",
637 std::string name = "unkn");
638 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
639 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
640 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
641 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
642 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
643 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
644 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
645 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
648 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
649 ADD virtual std::string GetEntryByName (TagName tagName);
650 ADD virtual std::string GetEntryVRByName (TagName tagName);
651 REM virtual bool Write(FILE *, FileType);
652 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
653 FILE *_fp, FileType type);
654 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
655 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
656 REM virtual bool WriteEntries(FILE *_fp,FileType type);
657 REM virtual std::string GetEntryByName (std::string tagName);
658 REM virtual std::string GetEntryVRByName (std::string tagName);
659 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
660 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
661 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
663 std::string vr = "unkn",
664 std::string fourth = "unkn",
665 std::string name = "unkn");
666 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
667 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
668 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
669 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
672 ADD virtual void Write(FILE *fp, FileType filetype);
675 ADD virtual void Write(FILE *fp,FileType filetype);
678 ADD virtual void Write(FILE *fp, FileType filetype);
679 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
680 REM std::string GetEntryByNumber(guint16 group, guint16 element);
681 REM std::string GetEntryByName(TagName name);
684 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
686 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
687 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
688 The default constructor invoked by the line
689 gdcmHeader *f1 = new gdcmHeader( header );
690 was gdcmHeader::gdcmHeader(bool) instead of the expected
691 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
692 Hence the parsing wasn't executed... See also below.
693 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
694 as explicit constructor didn't do the trick to fix the above problem.
695 Could anyone explain why ?
696 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
697 properly calls gdcmValEntry::Print() (that was weed out from
698 code related to gdcmBinEntry).
700 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
701 * In order to fix memory leaks:
702 - Test/TestWriteSimple.cxx: added cleaning of free store through
704 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
705 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
706 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
707 (through the call to ::AddDicomDirMeta()) or the destructor
708 would crash when deleting uninitialized ::metaElems].
709 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
710 - src/gdcmDocument.cxx:
711 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
713 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
714 was causing memory leaks.
715 - src/gdcmSQItem.cxx:
716 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
717 cleanly handled with polymophism: sorry but my milage is low).
718 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
719 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
720 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
721 This avoids SegFaulting.
722 - src/gdcmSQItem.h: coding style.
724 - Test/TestWriteSimple still severely sucks. The output image content
725 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
726 damaged when displayed with vtkgdcmViewer.
727 - on memory leaks: TestWriteSimple leaks really less (see entry
728 of 2004-06-18 in Changelog file for the call to valgrind).
729 - on segfaults: ctest now passes all the tests but one (no more
731 * Erroneous leading white fix:
732 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
733 white[s] (as opposed to from >> xxx, that removes it [them].
734 - src/gdcmTS.cxx: ditto.
735 - gdcmPython/testSuite.py: dirty related kludge removed.
736 * src/*: remaining references to gdcmParser removed.
737 * src/*[cxx|h]: added copy[way]left header.
740 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
741 * In order to fix writing of dicom files:
742 - Test/TestWriteSimple.cxx: a simpler example of writing.
743 - Test/CMakeLists.txt changed accordingly.
744 - src/gdcmDocument.cxx:
745 -- The destructor now recursilvely removes potential sequences.
746 -- Bug fix in ::IsJPEG2000()
747 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
748 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
750 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
751 to only declared) and build on top of
752 ::GetDocEntryByNumber(guint16, guint16).
753 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
754 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
755 for usage in destructor and treatement of promotion in
756 ::ReplaceOrCreateByNumber().
757 - src/gdcmSQItem.cxx: destructor should better handle his job.
758 Test/TestWriteSimple now runs (or at least it DOES something).
759 * We can now start hutting memory links. A good starting point is:
760 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
761 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
762 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
764 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
765 * Valgrind note: after Mathieu Malaterre teached me how to read
766 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
768 Using gcc, you can force the STL to use malloc and to free memory as
769 soon as possible by globally disabling memory caching.
770 With 3.2.2 and later, you should export the environment variable
771 GLIBCPP_FORCE_NEW before running your program.
772 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
773 simply vanish (it is still not clear to me, whether this means that
774 STL std::string leaks or if valgrind believes it leaks...).
775 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
776 running bin/gdcmTests makeDicomDir):
777 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
778 - Test/makeDicomDir.cxx now properly traps empty lists and returns
780 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
781 SegFaulting (I drowned in DicomDir related code when trying to
782 understand why the list is empty...).
783 * src/gdcmDocument.h: first BSD license header try.
784 * Doc/License.txt added.
786 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
787 * src/gdcmDocument.[h|cxx]:
788 - Clean up of the Transfer related predicates. They are now all based
789 on new method isGivenTransferSyntax, that (should) handle properly
791 - general clean up, simplification, and coding style.
792 - Specific clean up of Parse7FE0() (umproperly named actually).
793 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
795 2004-06-14 Jean-Pierre Roux
797 - fix the display of Sequence Delimitor (SQDepthLevel pb)
798 - fix the display of SQItem ordinal number
799 - add the GetSQItemByOrdinalNumber method
800 - remove some useless never written private methods
802 2004-06-14 Jean-Pierre Roux
804 - adding a constructor taking a gdcmDocEntry as an input param
805 - ReplaceOrCreateByNumber now returns :
806 a gdcmBinEntry * if a Binary (void *) value is passed as a param
807 a gdcmValEntry * if a string value is passed as a param
809 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
810 according to the param type (no longer sets a gdcmDocEntry)
811 - GetValEntryByNumber, GetBinEntryByNumber added
812 - NewValEntryByNumber and NewBinEntryByNumber added
814 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
816 - GetSQItemNumber and SetSQItemNumber added, to provide
817 a (relative) Item identier inside a given Sequence
818 \warning : some pb remaining around this number
820 - AddEntry now takes the Item Number as a param
822 - adding a constructor taking a gdcmDocEntry as an input param
824 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
825 * Memory leak hunt with the following command:
826 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
827 --show-reachable=yes gdcmTests PrintDocument
828 It looks like many (all?) leaks are due to the STL (or a bad usage
829 of the STL. The lines producing the leaks now have a comment with
830 a "MEMORY LEAK" tag: you can retrieve them with
831 grep "MEMORY LEAK" src/*
832 Here are two typical examples which I can't help fixing:
837 char * test = "babo";
838 name = test; //// <--- valgrind detects 960 bytes lost in
839 //// call to std::string::operator=(char const*)
840 name.clear(); //// Doesn't help !
848 std::cout << "Type a bunch of characters followed by RETURN: ";
849 getline(std::cin, line); //// <--- valgrind dectects a loss
850 //// of 1320 bytes in call to
851 /// std::basic_istream<>& std::getline<>
857 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
858 * src/gdcmHeader.[cxx|h]:
859 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
860 and related, moved away to gdcmDocument.
861 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
862 the corresponding protected accessors of inherited class
863 gdcmDocument, removed ! As a consequence gdcmFile had to be
864 declared friend of class gdcmDocument (see below).
865 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
866 - Clean up of undefined or unused methods.
867 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
868 account the changes to gdcmHeader.h).
869 * src/gdcmDocument.h:
870 - gdcmFile is now a friend class (in order to take into account the
871 changes to gdcmHeader.h).
872 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
873 (see changes to gdcmHeader.h).
874 - Accessors (reading on the form GetEntry*) are now public.
875 - Clean up of undefined or unused methods.
876 * src/gdcmDocument.cxx:
877 - adaptation to changes to gdcmDocument.h
878 - ::OpenFile now writes a verbose message when file cannot be opened.
879 - some std::string properly set to VRKey
880 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
881 references to gdcmDocument.
882 * Test/TestFindTags.cxx: changed accordingly to above changes.
883 * gdcmPython/testSuite.py: adapted to renaming of acr files in
884 cvs repository gdcmData.
886 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
887 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
888 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
889 conflicts with gdcmValEntry::voidArea.
890 * src/gdcmValEntry.cxx: unmatching comment wiped out.
891 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
892 Value representation between StringRepresentable and BinaryRepresentable.
893 * src/gdcmDocument.cxx:
894 - method ParseDES: proper indentation restored and usage of
895 gdcmVR::IsVROfGdcmStringRepresentable wired in.
896 - method LoadDocEntry: the fingerprint left in the SetValue() of
897 unloaded entries (length > MaxSizeLoadEntry) had curiously been
898 removed. Reverting to previous code segment with the proper
899 dynamic_cast< gdcmValEntry* >.
900 Note: this was (partially) breaking the python test suite
901 (gdcmPython/testSuite.py) that made usage of the above
902 fingerprint to check presence of "Pixel Data".
903 * src/gdcmDocEntry.h: coding style.
904 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
905 now taken into account.
906 * gdcmPython/gdcm.i: adaptation to the new internal representation
907 of gdcm (exit gdcmParser, hello gdcmDocument).
908 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
910 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
911 anymore, but instead prints the loaded Python dictionary.
912 * .... alas, the python testSuite is still broken.
914 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
915 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
917 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
918 * src/gdcmUtil.h : export methods
920 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
921 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
923 * Initial addition of automatic python testing
924 * Initial addition of automatic image comparison
926 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
927 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
928 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
930 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
931 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
932 * Test/ShowDicom.cxx : bug fix for msvc compilation
933 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
935 2004-05-04 Jean-Pierre Roux
936 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
937 new concepts (and new classes) :
938 a 'gdcmDocument' is composed of a set of Doc Entries, that are
939 - elementary gdcmDocEntries (former gdcmHeaderEntries)
940 - Sequence Doc Entries (gdcmSeqEntries)
941 a Sequence is composed of Items.
942 Each item is a set of Doc Entries (this is recursive)
943 The non uniqueness of the 'Dicom tag' is due to this recursivity
944 (never taken into account)
945 Our unability to add a new 'entry' in the header
946 at the proper location (neither in the H-Table (map or multimap),
947 nor in the Chained List is also due to this recursivity.
948 Don't try, right now, to use/modify/compile these new sources :
950 We just commit all the stuff, 'as is', in order not to loose it.
952 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
953 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
955 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
956 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
957 file prefix (SetFilePrefix)
959 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
960 * Add a new test: ShowDicom, for now this is just the c++ version of
961 checkRead.sh, later it will be able to compare the image read against a
963 * Replace the DEBUG on the stack with a global entry in cmake interface:
964 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
966 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
967 * Add an example subdir, with a real example on how to read + write a
970 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
971 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
972 * Doc/CMakeLists.txt: the main page is now properly differentiated
973 between the developper and user version.
974 * Doc/doxygen.config.in: dropped search related obsolete flags
975 * src/gdcmParser.h, gdcmHeader.h: doxygenation
977 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
978 * DEVELOPPER: added some helpfull comments for compile/test/install
981 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
982 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
983 src directory, now generated in the build dir.
984 2. Tests as mentionned smarter
986 4. Add a new method in gdcmDict that return the PubDict by name
987 this is interesting for 3rd party lib like ITK,
988 where we could set the institution name / patient name...
990 * ENH: 1. Now the test suite is working for real
991 2. All binaries are now output in the gdcm-bin directory
992 (this was not true before)
994 2004-04-28 Jean-Pierre Roux
995 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
996 SeQuence indented printing of Dicom Header.
997 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
998 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
999 Computation of SQDepthLevel is now part of gdcmHeader constructor
1000 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1001 tree-like structure of a Dicom Header.
1002 * FIX Test code cleaning
1004 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1005 * ENH: Adding automatic testing
1006 1. Need a DartConfig.cmake to submit to public
1007 2. Add a test driver gdcmTest.cxx
1008 3. gdcmTestMain, an helper for the main test driver gdcmTest
1009 4. Files in Test don't have a main anymore, this becomes interesting
1010 when we add more and more tests, thus dsw don't have to load
1012 * ENH: Adding a GDCM_DATA_ROOT for testing
1013 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1014 one file instead of seven + some small cleanup
1016 2004-04-22 Jean-Pierre Roux
1017 * ENH Minor changes to the Print() methods.
1018 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1019 Header printing. Example given with :
1020 > PrintHeader fileName 2 new
1021 (SQ based tree-like structure still to be done for the Header ...)
1023 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1024 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1025 1. I have added some unsigned where needed
1026 2. Some function parameter not used -> (void)
1027 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1028 4. g++ don't like character '\' in comment
1029 5. #define jpeg_create_decompress jCreaDecompress
1030 this really need to be fixed
1031 6. virtualize destructor of gdcmObject ... leakage
1032 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1033 this also really need to be fixed
1034 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1035 remove compression file
1036 (as we only do decompression, right ?)
1037 * ENH: Change malloc/calloc/free with c++ equivalent
1039 2004-04-21 Jean-Pierre Roux
1040 * FIX gdcmHeaderHelper::GetXSpacing
1041 when a single value is found (bug ?), xpacing is now
1042 defaulted to yspacing
1044 2004-04-19 Jean-Pierre Roux
1045 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1046 * ENH add parameters :
1047 bool exception_on_error = false,
1048 bool enable_sequences = false,
1049 bool ignore_shadow = false
1050 to the gdcmFile constructors to be full gdcmParser compliant
1051 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1052 to allow reading of PAPYRUS 3.0 files
1054 2004-04-06 Jean-Pierre Roux
1055 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1057 2004-04-02 Jean-Pierre Roux
1058 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1059 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1060 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1062 2004-03-30 Jean-Pierre Roux
1063 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1064 for ACR file, written out as DICOM files (hope so...)
1066 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1067 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1068 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1069 moved to base class gdcmParser and only the specialisation is kept
1071 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1072 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1073 already does the job.
1074 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1075 (to be consistent with gdcmParser::WriteEntries).
1077 2004-03-30 Benoit Regrain
1078 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1079 upate of the object's instance. It's passed to 2 in the unfavorable
1080 case : one in the ExecuteInformation, one in the ExecuteData
1082 2004-03-29 Jean-Pierre Roux
1083 * ENH : Check on file type to be written moved
1084 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1085 * FIX : gdcmObject::ResetBoundaries now stops properly
1086 when end-of-list is reached
1087 : gdcmVersion modified (as Benoit Regrain asked)
1089 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1090 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1091 * src/gdcmUtil.cxx: added forgotten iostream include.
1092 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1093 equivalent to ExplicitVR in existing code).
1095 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1096 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1097 now contains all the gdcmGlobal related code.
1098 * minor coding style and doxygenation changes.
1100 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1101 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1102 now contains all the Debug related code.
1103 * minor clean-up of includes in src/*.cxx
1104 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1105 CreateCleanString) removed.
1106 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1107 * Doc/DoxyMainPageUser.txt added.
1108 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1109 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1110 src/gdcmDirList.cxx)
1112 2004-03-24 Jean-Pierre Roux
1113 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1115 2004-03-23 Jean-Pierre Roux
1116 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1117 big endian made volumes
1118 * ENH Now gdcmParser constructor and destructor are protected to forbid
1119 end user to instanciate class gdcmParser
1120 (only gdcmHeader and gdcmDicomDir are meaningfull)
1122 2004-03-22 Benoit Regrain
1123 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1124 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1125 gdcmSerie to gdcmDicomDirSerie
1127 2004-03-19 Jean-Pierre Roux
1128 * ENH Now the tree-like structure describing a DICOMDIR comming from
1129 an already existing DICOMDIR file is consistent with
1130 the home-made tree-like structure build ex-nihilo
1131 or build from the files held (recursively) in a Directory
1132 functions gdcmDicomDir::CheckBoundaries()
1133 gdcmObject::SetBoundaries() added
1135 2004-03-17 Jean-Pierre Roux
1136 * REM (Eric Boix bug) : removal of meaningless
1137 gdcmDicomDirImage::NewImage function.
1138 * FIX now file names and directory name are written properly in the
1140 * FIX now gdcmDicomDir constructor may be call without any trick
1143 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1144 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1145 of gdcmDicomDirImage::NewImage as empty function.
1147 2004-02-28 Jean-Pierre Roux
1148 * ENH add gdcmDicomDir:NewPatient
1149 add gdcmDicomDirPatient:NewStudy
1150 add gdcmDicomDirStudy:NewSerie
1151 add gdcmDicomDirSerie:NewImage
1152 to allow making gdcDicomDir object.
1153 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1154 (as opposite to the gdcmHeader chained list)
1156 2004-02-11 Benoit Regrain
1157 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1158 when using from python
1160 2004-02-10 Benoit Regrain
1161 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1162 * FIX : in gdcmDicomDir when the directory is empty
1163 * ENH : add callback and methods to get the progression of dicomDir
1166 2004-02-06 Jean-Pierre Roux
1167 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1168 - GDCM_META added to gdcmDicomDirType
1169 - class gdcmMeta created
1170 * ENH : - A brief summary is now displayed at the beginning of
1171 'testDicomDir' to help disaster magnitude estimation
1172 * REM : Now useless Test/explDICOMDIR.cxx
1174 2004-02-05 Benoit Regrain
1175 * ENH : add methods in gdcmObject to get the hash table or the list of
1177 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1178 * FIX : wrapping python for TagHeaderEntryHT
1180 2004-02-04 Benoit Regrain
1181 * FIX : even length for some strings when writting the dicom dir
1182 * FIX : sort the images in the dicom dir
1183 * FIX : Bug fix for python use of dicom dir
1184 * ADD : a python demo
1186 2004-02-04 Jean-Pierre Roux
1187 * FIX : Final solution (?) for icone embedded images
1188 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1189 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1190 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1191 gdcmData/gdcm-MR-SIEMENS-16.acr1
1192 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1193 to make full checking easier
1195 2004-02-04 Benoit Regrain
1196 * FIX : WriteEntries : coding style & logic in parameters
1197 * FIX : Set the elements to create the DicomDir in a dictionary file
1199 2004-02-03 Benoit Regrain
1200 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1201 * gdcmDicomDir : add the load of directory
1202 * Bug fix and print add-on
1204 2004-02-03 Jean-Pierre Roux
1205 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1206 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1207 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1208 * FIX gdcmParser.cxx : 'group length' elements are now considered
1209 as integers, even for shadow groups, when file is Implicit VR
1211 2004-02-02 Jean-Pierre Roux
1212 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1214 of the last synonym :-(
1215 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1217 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1218 * FIX taking into account the possible 7fe0,0010 multiplicity
1219 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1220 to allow removal of references to 7fe0,0010, to deal with
1221 ACR-NEMA images, when 0028,0200 is meaningfull
1223 2004-01-31 Jean-Pierre Roux
1224 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1225 no longer writes 'Un' on disk
1226 * FIX SQ elements with actual length are now dealt with corectly
1227 * FIX gdcmFile::WriteBase make the difference, for color images, between
1228 the length (for Palette expanded images)
1229 and Raw Length (non expanded image + Palette)
1230 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1231 (that broke Write). Replaced by UL.
1232 Aware user will reload the field if he
1233 thinks it's necesssary
1235 2004-01-30 Jean-Pierre Roux
1236 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1237 when 'dirty Acr' is found, to be compliant with the new
1238 IsReadable() methods.
1240 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1241 (no DOUBLE images in kosher DICOM,
1242 but so usefull for people that miss them ;-)
1244 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1245 DICOMDIR related utilities (not checked as Windoze compliant)
1247 2004-01-28 Jean-Pierre Roux
1248 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1250 2004-01-27 Jean-Pierre Roux
1251 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1252 to allow skipping the shadow elements, to save memory space.
1253 The TRUE value for this param has to be used
1254 with a FALSE value for the 'enable_sequence' param.
1255 ('public elements' may be embedded in 'shadow Sequences')
1256 * gdcmHeader methods now deal with 'embedded icones images' in the header
1257 (even when an 'icone image sequence' is announced by the
1258 element (0x0088,0x0200), but there is NO icone at all ...
1260 * gdcmHeader sometimes Image Location value doesn't follow
1261 the supposed processor endianity (see gdcmData/cr172241.dcm).
1264 * gdcmHeader add the method
1265 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1266 to get *all* the Header Entries with the same tag.
1267 GetHeaderEntrySameName is probabely *useless*
1268 (no meaning : Name is *not* an identifier within the Dictionnary)
1270 2004-01-26 Benoit Regrain
1271 * Bug fix in the print of hexadecimal representations. Remove long fields
1272 in the print and add a third level of print to print them
1274 2004-01-23 Benoit Regrain
1275 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1276 * Bug fix on test suite after remove the strip made on not string fields
1277 * Split the IsReadable method between gdcmParser which test that the file
1278 is dicom and gdcmHeader which test that it's an image file
1280 2004-01-22 Benoit Regrain
1281 * DicomDir : clean code, add methods, set variables in protected or private
1282 * gdcmUtil : bug fix for the clean string method
1284 2004-01-19 Benoit Regrain
1285 * Add the use of shadow dictionaries
1286 * bug fix and coding style
1288 2004-01-19 Benoit Regrain
1289 * src/gdcmFile.cxx : bug fix concerning the close of file
1290 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1291 * Add the update of header entries using the shadow library
1293 2004-01-19 Benoit Regrain
1294 * removal of file gdcmHeader2.cxx
1295 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1296 inheriting from gdcmParser. This split is to prepare the integration
1297 of dicom dir parsing
1298 * bug fix under python
1300 2004-01-16 Jean-Pierre Roux
1301 * REM removal of class gdcmHeaderEntrySet
1302 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1303 * ADD add file gdcmHeader2.cxx
1304 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1306 2004-01-15 Benoit Regrain
1307 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1308 entries created while parsing the header. Thus, they will be destroyed
1309 when the gdcmDictSet will be destroyed
1310 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1313 2004-01-15 Benoit Regrain
1314 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1315 made a fatal error because of the memory release at the end of program.
1316 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1317 some memory and vtk seems to have some problems with that.
1318 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1320 2004-01-14 Benoit Regrain
1321 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1322 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1323 * src/*.[h|cxx] : make changes due to class name changes
1324 * gdcmPython/demo/*.py : bug fix due to method names
1326 2004-01-13 Benoit Regrain
1327 * src/*.[h|cxx] : coding style
1328 * vtk/*.[h|cxx] : coding style
1330 2004-01-13 Benoit Regrain
1331 * gdcmPython/testSuite.py : test the readable flag of file for tests
1332 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1333 It's lied to the stl compilation by MSVC (windows, always windows...)
1334 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1336 2004-01-12 Benoit Regrain
1337 * src/*.h : add comments
1338 * src/gdcmDictSet.h : set the method BuildDictPath in public
1339 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1340 directly setted in the source code
1341 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1344 2004-01-09 Benoit Regrain
1345 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1346 * setup.py : use a reference to gdcmVERSION
1348 2004-01-07 Benoit Regrain
1349 * Modification to compile with the distutils.
1352 2003-12-10 Benoit Regrain
1353 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1354 can use a gdcmHeaderHelper to load datas
1355 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1356 made in the source code
1358 2003-12-10 Benoit Regrain
1359 * Update Windows projects and .cvsignore files
1361 2003-11-12 Jean-Pierre Roux
1362 * ENH gdcmHeader constructor has one more parameter (default value : false)
1363 that allows the user to 'go inside' the SeQuences only
1365 gdcmElValSet:Print takes it into account
1367 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1368 * ENH: Update gdcmPython/CMakeLists
1369 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1370 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1372 2003-11-10 Jean-Pierre Roux
1373 * FIX : gdcmHeader::LoadElements is now based
1374 on the ListTag listElem member,
1375 not longer on the TagElValueHT tagHt member
1376 * ENH : PrintPubElVal shows (temporarily) both results,
1377 with the tagHt member and the listElem member.
1378 (it's easier to 'see' the problems when using Printheader)
1380 * FIX : old private member LgrElem is now splitted into
1381 ReadLength : Length actually found on disk (updated only
1382 if bug fixing is necessary), for internal
1384 UsableLength : Updated by FixFoundLength, to fix a bug
1385 or to allow Parser going on.
1386 Will allow to re-write a kosher header when a SeQuence
1387 with a length (not 0000) is found
1388 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1389 because gdcmElValSet::Add does not update ListElem
1392 2003-11-07 Jean-Pierre Roux
1393 * FIX misstyping in Transfert Syntax name table
1394 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1395 when they have an actual length (not 0000 nor FFFFF)
1396 (Nobody should care of it, but DICOMDIR explorers)
1398 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1399 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1401 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1402 * ENH: vtkGdcmReader now supports LUT !
1403 (vtkgdcmViewer for now is not able to use them though)
1405 2003-11-05 Jean-Pierre Roux
1406 * in testSuite.py : new files names for checking the package
1407 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1408 that returns the pixel area size to the *aware* (vtk) user
1409 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1411 2003-11-05 Benoit Regrain
1412 * in testSuite.py : Modify the rules for checking the paths
1413 : Explicit error messages
1414 * in __init__.py : Related modif
1416 2003-11-03 Jean-Pierre Roux
1417 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1418 to be used by aware (vtk) users that want to manage
1419 LUT (and no to turn the PALETTE image into an RGB pixels one)
1420 * GetPixelType now returns 8U for 24 Bits images
1421 (vtkGdcmReader compliant)
1423 2003-10-31 Jean-Pierre Roux
1424 * Removal of *all* gdcmData images and add them again
1425 in order to loose the 'history' of un-anonymised images
1427 2003-10-31 Jean-Pierre Roux
1428 * RMV : removal of useless jBitsInJsample.h
1429 for both 8 and 12 Bits JPEG Lossy Libraries
1431 2003-10-31 Jean-Pierre Roux
1432 * ENH : Add the functions gdcmFile::GetImageDataRaw
1433 gdcmFile::GetImageDataIntoVectorRaw
1434 that act as GetImageData and GetImageDataIntoVector
1435 except the making of an RGB Plane from Gray Plane + LUT
1436 Intended to aware (vtk) users who know how to manage
1439 GetLUTRGBA return a R,G,B,A LUT if any
1440 lgrTotaleRaw gives the 'Raw' length
1441 GetImageDataRaw returns the gray Plane
1442 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1443 (They stay Grey, just like with other Dicom viewers :-(
1445 2003-10-30 Jean-Pierre Roux
1446 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1448 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1449 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1450 being coherents dicom files.
1452 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1453 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1455 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1456 * ENH: Two steps is necessary to please VC++ compiler...
1457 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1458 * ENH: Add include dir to medcon lib
1459 * FIX: only one function is being exported for now !
1460 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1462 2003-10-29 Jean-Pierre Roux
1463 * adding gdcmHeader::GetLUTRGBA
1464 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1465 --> Mathieu, the modif u're waiting for is not yet committed
1466 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1468 2003-10-27 Jean-Pierre Roux
1469 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1470 00191113.dcm DermaColorLossLess.dcm
1471 MxTwinLossLess.dcm RadBWLossLess.dcm
1472 * ENH: For version prior to vtkImageViewer2 -r 1.19
1473 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1475 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1476 * Removal of ido stuff in CMakeLists.txt
1478 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1479 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1480 * FIX: remove a call to ->Modified ... see comments
1481 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1483 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1484 * FIX: Problem with path for libvtkgdcmPython
1485 * ENH: Try adding a search script for python site-package
1486 * RMV: Remove some file from medcon lib that are not necessary
1487 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1488 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1489 * FIX: More pragma disable fro VC++,
1490 I don't think I break something as it is also disable in VTK/ITK.
1491 But it fasten debug compilation time.
1493 2003-10-23 Jean-Pierre Roux
1494 * gdcm now deals with 16 Bits Run Length Encoded images
1495 (they are compressed as 2 planes images,
1496 one for the high Bytes, the other for low Bytes)
1498 2003-10-22 Jean-Pierre Roux
1499 * Now CheckRead takes into account :
1500 - the bugged 'Leonardo' Siemens images
1501 - the XA images, sent thru the burning VPRO station
1502 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1505 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1506 * FIX: When copying a Makefile.am to CMakeLists.txt
1507 one should remove the '\'
1509 2003-10-22 Jean-Pierre Roux
1510 * in gdcmData adding a bugged 'Leonardo' Siemens image
1511 (wrong lengths in header)
1512 OK with gdcm, KO with the other viewers :-)
1513 * add a GE dlx XA image, thru the VEPRO burning station
1516 2003-10-21 Jean-Pierre Roux
1517 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1518 for a brutal checking of vtkgdcmViewer compliance
1520 2003-10-21 Jean-Pierre Roux
1521 * add the files for 'xmedcon' Jpeg Lossless library
1522 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1524 2003-10-21 Jean-Pierre Roux
1525 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1527 2003-10-21 Jean-Pierre Roux
1528 * garbage Siemens 'Leonardo' images dealt with
1529 (the patch is easy to remove)
1530 * cosmetic changes to avoid warnings
1532 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1533 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1534 no need to press 'r' now.
1536 2003-10-20 Jean-Pierre Roux
1537 * upgrade of checkRead.sh checkWrite.sh according
1538 to new Jpeg Lossless decompressor
1539 * add US.3405.1.dcm, a genuine RGB medical file ...
1540 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1541 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1543 2003-10-15 Jean-Pierre Roux
1544 * general anonymisation in gdcmData
1545 * adding the 'color files' from
1546 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1547 * adding some well knowed bugged-header images
1548 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1549 waiting for their inclusion in Python testsuite
1551 2003-10-15 Jean-Pierre Roux
1552 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1553 no longer seg faults when file is not found
1555 2003-10-14 Jean-Pierre Roux
1556 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1559 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1560 * TODO: *.in file to genereate a UseGDCM later
1562 2003-10-14 Jean-Pierre Roux
1563 * Some supposed-to-be Dicom Images have no preamble.
1564 OpenFile takes it into account
1565 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1566 * Missing elements added in dicomV3.dic
1567 (just to be affraid : have a look at
1568 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1569 and do it again next year ;->
1571 2003-10-13 Jean-Pierre Roux
1572 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1573 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1574 But there are NOT. It's fixed !
1576 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1577 * FIX: "jpeglib.h" was not found on VC++
1578 * FIX: vtkgdcm was not being installed
1580 2003-10-10 Jean-Pierre Roux
1581 * ENH : OpenFile closes the file if it *really* doesn't look like
1582 an ACR-NEMA / DICOM one.
1583 * FIX : testWrite no longer writes an empty file if the source file
1584 is not gdcm Readable
1585 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1588 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1589 * FIX: CMake generate now documentation
1590 * ENH: out of source doc build !
1591 * ENH: Generate both user and dev documentation
1592 * ENH: Should work on windows too
1593 * ENH: Only one doxygen config.in file is needed
1594 * FIX: make install should be ok now on ùnix plateform
1595 * FIX: PATH to dictionary was wrong (missing /)
1596 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1598 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1599 * vtkGdcmReader is now able to read rgb dicom file.
1600 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1601 * added a gdcmViewer to vtk test, use mouse to control
1602 window level & window width
1604 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1605 * CMake-ification of gdcm, we have now two build system
1606 * FIX: on cygwin Wsock32 doesn't exist
1607 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1609 2003-10-06 Emanuel Ollart
1610 * FIX : compilation process wad broken.
1611 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1613 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1614 * change gdcmViewer -> vtkgdcmViewer
1615 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1617 2003-10-06 Jean-Pierre Roux
1618 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1619 ( e.g : well known GE images with a wrong elem length,
1620 : Philips MRI Images with a wrong Huffman table)
1621 * still to be done : allow the reading of bugged LEONARDO Siemens images
1623 2003-10-03 Jean-Pierre Roux
1624 * Odd length strings are padded with '\0' (not with spaces,
1625 to remain compliant with already defined strings,
1626 like Transfert Syntax UID and others)
1628 2003-10-03 Jean-Pierre Roux
1629 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1630 to allow displaying RGB images (not only by affim ;-)
1632 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1633 * vtkGdcmReader is now able to read rgb dicom file.
1634 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1636 2003-10-03 Jean-Pierre Roux
1637 * A few nasty patches to allow the reading of a lot of nasty images
1638 ( e.g : well known GE images with a wrong elem length,
1639 : Philips MRI Images with a wrong Huffman table)
1640 * still to be done : allow the reading of bugged LEONARDO Siemens images
1642 2003-10-03 Jean-Pierre Roux
1643 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1645 2003-10-03 Jean-Pierre Roux
1646 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1647 to allow displaying RGB images (not only by affim ;-)
1649 2003-10-03 Jean-Pierre Roux
1650 * gdcmFile::GetImageDataIntoVector now
1651 - deals with MultiFrames MultiFragments Run Length Encoded files
1652 - deals with YcBcR (YBR_FULL) files
1653 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1654 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1656 (no sample found :-(
1658 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1659 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1660 Two reasons: - clear things
1661 - third parties acces gdcm through header files, so won't
1662 suffer anymore VC++ complains
1664 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1665 * add argv[1] in testvtkGdcmReader.cxx
1668 2003-09-24 Jean-Pierre Roux
1669 * The lines are now eigthy characters long.for
1670 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1672 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1673 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1674 char* to std::string. Thus, the use of strdup becomes useless. (see
1675 previous commis of Malaterre)
1676 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1677 before the last Malaterre's commit.
1679 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1680 * This commit should fix the Debug building under VC++, the problem
1681 was mainly a mixture of debug and release lib being loaded at startup.
1682 * I also remove a depency to a specific C function: strdup. Because I had
1683 to force the link to msvcrtd (whereas strdup is in libc).
1685 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1686 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1687 located in the gdcmCommon.h file. All use of reference of tha has been
1688 changed to now use the variable GDCM_UNFOUND.
1690 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1692 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1693 Dicom dictionary. The test suite can now be run again. Note:
1694 I'm note very happy with the " (RET)" changes. I believe this
1695 RETAINED comment should be dropped when parsing the dictionary.
1696 - PACKAGER corrected
1698 - AUTHORS updated and now in alphabetical order
1699 * Makefile.am now exports gdcm.dsw for Windoze users.
1701 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1702 * cygwin complains about missing std:: in subdir Test/
1704 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1705 * remove some methods that are now in gdcmHeaderHelper
1707 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1708 * vtkGdcmReader set spacing and origin correctly
1710 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1711 * Fix a few delete/delete[] mismatch
1713 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1714 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1715 interpretation to data given by gdcmHeader. For instance there are
1716 heuristics to get informations (look at different places).
1717 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1718 sorting DICOM images based on different strategies.
1719 * modified Makefiles accordingly.
1721 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1722 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1723 when building in debug mode
1724 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1725 src/win32/gdcmdll.dsp
1726 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1728 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1729 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1732 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1733 * src/win32/libgdcmjpeg12.dsp was not dos format
1734 * src/win32/libgdcmjpeg12.dsp :
1735 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1736 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1738 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1739 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1741 * src/gdcmFile.cxx : bug fix in affectation type
1742 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1743 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1744 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1745 symbols... future problem ?
1747 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1748 * src/win32/libgdcmijpeg12.dsp was missing
1749 * modified gdcm.dsw accordingly
1751 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1752 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1754 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1755 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1756 commit of JPR (before his hollidays to facilitate our work).
1757 * setup.py : bug fix in code. Modifications made while the last commit
1758 of JPR. The code hasn't been tested before the commit... it's so
1759 useless to make that (for best programmer that is JPR) !!!
1761 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1762 * tagged the current version as Version0_3 (i.e. version 0.3)
1764 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1765 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1766 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1767 * *.dsp : modifications to use new libgdcmijpeg8 library
1768 * setup.py : bug fix on VTKPATH variable
1769 * PACKAGER : adding all concerning windows
1771 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1772 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1774 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1775 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1776 test suite reported error.
1777 * PACKAGER file added (describes what a packager must do when
1778 packaging a new release).
1779 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1780 * configure.in: upgraded version number to 0.3.0
1781 * fixing build of rpm (through rpm -ta):
1782 - Doc/Makefile.am exports proper doxygen files
1783 - src/jpeg/libijg8/Makefile.am exports the include files.
1785 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1786 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1787 * src/gdcmHeader.h : formatting code
1789 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1790 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1791 We were obtaining error message from vtk. Now, creation of file list
1792 is made in an internal list to prevent this problem.
1793 Bug fix when output is empty.
1794 Bug fix in update of progress value. Previous commit for this was a bad
1796 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1798 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1799 * src/gdcmHeader.h : added method to get the file name
1800 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1801 files. Added method to remove all files on the input
1802 Added FIXME comment concerning the bad parsing of header made by
1803 ExecuteInformation method (in ExecuteData method)
1805 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1806 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1807 when using make instal.
1808 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1809 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1811 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1812 * setup.py : adding include dir of jpeg lib to compile all sources
1813 * */Win32/*.dsp : JPR fix for windows compilation
1815 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1816 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1818 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1819 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1821 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1822 * setup.py is again effective on un*x (takes into account the
1823 addon of the jpeg library)
1824 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1825 * Doc/Doxy* updated (includes above enhancements)
1826 * INSTALL now points to web documentation
1828 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1829 * src/gdcmHeader.h doesn't make unnecessary reference to
1831 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1833 * src/gdcm*.[cxx|h] :
1834 - to allow compilation with gcc 3.x
1835 -- clean up of STL usage (added explicit usage of std::)
1836 -- small fixes on exceptions.
1837 Note: linking not tested !
1838 - clean of doxygen comments to avoid warnings at documentation
1840 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1841 dependent convertion).
1843 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1844 * Clean up of previous JPR garbage commit (not even commented in the
1846 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1847 - moved all jpeg related files from src to src/jpeg/libijg8, with
1848 addition/modification of Makefile.am and configure.in.
1849 - the testSuite is still brain damage (not guilty).
1851 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1852 * WrapVTK.py : modifications to get correctly vtk source files to
1854 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1855 (FileName -> Filename)
1857 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1858 * vtk/vtkGdcmReader.[cxx/h]:
1859 - UpdateProgress method should now be effective
1860 - removed the limitation on having only images loaded (as opposed
1862 - when building a stack of images/volume, a lesser number of
1863 gdcmHeader and gdcmFile instances should be used (hopefully
1864 accelerating things).
1865 - when building a stack of images/volumes, files which are not
1866 loadable (wrong path-filename, wrong permissions on existing file,
1867 or file not parsable by gdcm) are replaced with a black image
1868 in the stack (for the caller to notice the problem).
1870 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1871 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1873 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1874 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1875 between standard library (std) and vtk library (problems are found
1876 under Windows... thanks Windows !)
1878 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1879 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1881 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1883 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1884 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1886 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1887 * When compiling with distutils (see setup.py) the C++ compiler is
1888 called with different flags than the default ones (with automake).
1889 In order to fix all those warning, I compiled gdcm with the command
1890 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1891 and went for warning fixes:
1892 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1893 up from unused variables.
1894 - vtk/vtkGdcmReader.cxx: potential bug fix.
1895 * src/gdcmHeader.h: Doxygen warning cleanup
1897 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1898 * gdcmPython/gdcm.i:
1899 - typemaps correction to take into account the systematic replacement
1900 of "using namespace std" with std:: prefix e.g. std::list,
1901 std::string... (cf changes of 2003-05-21).
1902 - gdcmGlob global variable of type gdcmGlobal (defined in
1903 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1904 exported to Python a as cvar.
1905 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1906 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1907 gdcmDictSet.GetPubDictTagNames() and
1908 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1909 C++ static methods).
1910 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1911 with the above changes.
1913 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1914 * setup.py, manifest.in : bug fix under linux
1916 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1917 * Modification of setup.py to compile vtk part too. Then, we have 2
1918 wrappers which must work with same distutils. For that, we have a
1919 generic distutils in distusiltsWrapping.py ; with :
1920 - build_extWrap class to wrap generically all extensions,
1921 - ExtensionWrap base class for all wrapping extension that contains
1923 - Wrapper interface which wrap sources
1924 + In WrapSwig.py we have extension and wrapper for Swig
1925 + In WrapVTK.py we have extension and wrapper for VTK
1926 * MANIFEST.in : modifications to consider vtk directory and new python
1927 files for compilation
1929 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1930 * Added python wrappers of vtkGdcmReader vtk class (see the
1931 source in vtk/vtkGdcmReader.cxx) :
1932 - vtk/Makefile.am now builds a library
1933 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1934 python library (as opposed to _gdcm.so wich are the python
1935 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1936 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1938 - configure.in has an additional flag --enable-vtk that needs
1939 to be set to enable compilation of vtk related code, that is:
1940 + vtk/vtkGdcmReader.so and
1941 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1942 + gdcmPython/vtkgdcmPython.so (see above)
1943 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1944 be read when compressed or when HighBit + 1 != BitsStored),
1945 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1946 the usage of the python wrapper of vtkGdcmReader vtk class.
1947 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1948 * src/*.[h] all occurences of stl classes are now prefixed with
1949 std::, and all occurences of "using namespace std;" where removed.
1950 This is to avoid pollution of global namespace in included files.
1951 Apparently vtk does not avoid this pitfall: when using both
1952 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1953 collision of various stl members (principally cout...).
1954 * gdcmPython/testSuite.py now cleanly removes temprory generated
1956 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1957 comply with above changes)
1959 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1960 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1961 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1962 vtk data structure (an image Flip was required).
1963 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1964 * cosmetic changes in documentation.
1966 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1967 * src/gdcmHeader.cxx: the constructor no longer exits when an
1968 unexisting file is given as argument.
1969 * The subdirectory Data (containing all the images used for the
1970 test suite) is not part of this repository anymore. A new module
1971 containing those images is now available at
1972 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1973 with the name gdcmData.
1974 All the python scripts (including the package initialisation file
1975 gdcmPython/__init__.py) were adapated to take this change into
1976 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1978 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1979 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1980 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1981 demo of the usage of this class.
1982 Compilation of this vtk part is only done when using the --enable-vtk
1983 at configure (or autogen.sh) stage.
1985 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1986 * More memory link related corrections and documentation fixes.
1988 - maximum info is obtained with a command of the form:
1989 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1990 --show-reachable=yes PrintHeader
1991 - the remaining reachable blocks seem to come from the STL
1992 allocation scheme through the usage of map and list. It looks
1993 like this memory cannot be freed but it is not a memory leak
1994 (in fact further invocation to the STL would recollect the
1995 unused memory allthough it cannot explicitely be freed).
1996 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1997 of displaying an image parsed with gdcm and displayed with VTK.
1998 Note: some images don't seem to work e.g.
1999 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2000 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2001 Allthough this weakens the semantics, it is a ditch attempt to
2002 make gdcm more thread friendly.
2004 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2005 * Memory link hunt (by using valgrind through the command
2006 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2007 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2008 gdcmHeader::_dicom_vr.
2009 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2010 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2012 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2014 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2015 * src/Makefile.am now exports all the necessary include files at
2019 * UpdateGroupLength replaced by new one
2022 * UpdateGroupLength re-written using H-Table
2023 (named UpdateGroupLengthNew untill checks are over)
2025 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2026 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2027 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2029 - gdcmHeader::GetPubElValSet removed.
2030 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2031 UpdateGroupLength, WriteElements, Write.
2032 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2033 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2034 carried the same semantics.
2035 - src/gdcmHeaderIdo.cxx changed accordingly.
2036 - gdcmFile::WriteBase now regroups all the codes from previous
2037 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2038 - enum FileType moved to gdcmCommon.h
2039 * src/gdcmHeader.cxx AddDefault trashed
2040 * gdcmGetXSize added
2041 * getimageDataSize now calls gdcmGetXSize
2042 * Test/*.cxx changed to agree with above changes
2044 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2045 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2046 (to avoid double call by end user).
2047 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2048 by end user, since gdcmHeader::gdcmHeader now handles it.
2050 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2051 * gdcm/Doc many doxygen changes:
2052 - Doxyfile now has two different versions, DoxyfileUsers that generates
2053 the html.users end users oriented documentation and
2054 DoxyfileDeveloppers that generates the html.developper developper
2055 oriented documentation.
2056 - README changed accordingly
2057 - requirement.txt removed (old design info moved to TODO).
2058 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2059 DoxyMainPage.txt, DoxyPython.txt provide more information.
2060 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2061 be updated by simply regenerating the docs with doxygen and copying
2062 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2063 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2064 all the tests in the form "if (<map>.count() >1)" were removed.
2065 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2066 ill-formed documentation sections.
2067 * src/gdcmHeader.cxx: ditto
2069 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2070 * setup.py fixed for un*x (needed macro for stdint.h)
2071 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2072 un*ces with sh-utils test utility.
2073 * gdcmPython/demo/test.py renamed to PrintHeader.py
2074 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2075 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2076 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2077 * src/gdcm*.cxx JPR's bad inclusion fixed.
2079 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2080 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2081 * gdcmPython/demo/test.py changed accordingly.
2083 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2084 * gdcmPython/Makefile.am fixed linking against libstdc++
2085 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2086 * Swig subdir (historical tests of swig version 1.3.17++) removed
2087 * Test/testChangeEntete.cxx some lines commented out in order to make
2089 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2090 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2092 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2093 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2094 hence the user doesn't need this explicit call.
2095 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2096 i.e. LoadElements() call removed.
2097 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2098 - src/Makefile.am declares the proper flag for g++.
2099 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2100 for adding user defined new tags.
2101 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2102 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2103 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2105 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2106 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2107 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2108 src/Makefile.am : the project should properly compile and install
2109 with the autotools, included the python wrappers part.
2110 * gdcm.spec.in : added a spec file for RPM packaging.
2112 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2113 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2115 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2116 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2117 to exported to the environement (see gdcmPython/testSuite.py
2119 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2120 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2121 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2122 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2123 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2125 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2126 * gdcmPython/__init__.py doesn't crash anymore when running in
2127 in InstallMode or PreInstallMode but with an environement given
2128 value of GDCM_DICT_PATH.
2129 * src/gdcmDictSet.[cxx/h] coding style.
2131 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2132 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2133 * src/gdcm.h general comments moved to TODO, and README
2134 * src/gdcm.h should now be seen as a user commodity (including it
2135 should suffice to fully use gdcm). It is nowhere including within
2136 any of the kernel files src/*.cxx and src/*.h.
2138 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2139 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2140 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2142 * src/gdcm*.cxx only include their corresponding include file
2143 (as opposed to gdcm.h)
2144 * gdcmPython/gdcm.i changed accordingly
2145 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2146 the autogen.sh generated "make snapshot" command to work.
2147 * autogen.sh removed history related references to crea package.
2149 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2150 * distutilsSwigCPlusPlus.py work around some swig portability
2153 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2154 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2155 was done in a last ditch attempt to get setup.py _really_
2156 operationnal. The python/gdcmPython layaout add the advantage
2157 of hidding away the python related distutils specific files
2158 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2159 Alas, the src directory was out of scope (i.e. it's relative
2160 position to setup.py was ../src) which made things impossible to
2161 handle (see previous version of python/setup.py). Crossing fingers...
2163 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2164 * python/setup.py now works on Un*x. (harder than I thougth)
2165 * python/distutilsSwigCPlusPlus.py can now have include files
2166 among the list of sources.
2168 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2169 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2170 * modifications in MSVC projects
2172 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2173 * As stated by the first lines of Test/ExceptionAndPython/README, it
2174 looks like we can move back to original usage of exception within
2175 src/gdcm* and hence remove the errno stuff that was introduced
2176 as a quick and dirty fixture of this problem (added to the TODO).
2177 * Doc/Doxyfile configuration file for Doxygen and corresponding
2178 README file for usage added.
2179 * Test/testWrite.cxx added. This new test comes from a split of
2180 test.cxx that is now reverted to its original purpous i.e.
2181 testing the proper parsing of a Dicom related file.
2182 testWrite.cxx concentrates on testing the IO part of gdcm.
2183 * Test/bug1.cxx (containing a bug on WIn32) added.
2184 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2185 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2186 whose purpose is to publish the content of the TagNames of the
2187 Dicom public dictionnary were not accessible without an
2188 instance of class gdcmHeader.
2189 - those methods are now static methods of gdcmDictSet and hence
2190 require no instances at all to be invocated.
2191 - within gdcmDictSet this change required to change some method
2192 to class methods (i.e. are now static) among which SetDictPath
2193 (renamed to BuildDictPath) and LoadDefaultPubDict.
2194 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2195 the above changes by calling the new method classes of gdcmDictSet.
2196 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2197 the above to be effective.
2198 * python/gdcmPython: in order to wrap properly the above changes
2199 for Python, swig version now needs to be > 1.3.17.
2200 * python/gdcmPython/Makefile fixed to adapt itself to new
2201 configure/make shema introduced by Johan Montagnat (thanks for the
2202 contribution). Alas this Makefile cannot be turned into a proper
2203 Makefile.am without some heavy changes in the configure.in
2204 (for python dectection).
2205 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2206 now avoids publishing the empty entries.
2208 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2209 * python/setup.py : bug fix concerning install under windows
2210 ExtraPath reused :-P
2211 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2213 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2214 * Dicts/dicomV3.dic : remove double spaces !!!
2215 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2216 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2219 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2220 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2221 method. Doxygenation.
2222 * src/gdcm.h clean up of JPR spurious comments.
2224 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2225 * python/distutilsSwigCPlusPlus.py now properly collects the
2226 shadow classes generated by "swig -c++" (gdcm.py in our case)
2227 when using "python setup.py install".
2228 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2229 reexports the working classes.
2230 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2231 by the classical C errno scheme. This is to prevent an obscure
2232 behavior of the python wrappers when importing wxPython.wx prior
2233 to gdcmPython (which ended up in an abort call). An illustration
2234 of this oddity can be found in the Test/ExceptionAndPython
2235 subdir (see the README file). This problem probably due to
2236 an combination of g++ and dynamic loading.
2237 * added Test/ExceptionAndPython (see above)
2239 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2240 * Changed the layout of the python part to avoid bloating main
2241 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2242 i.e. the distutils arsenal. All the python related stuff is
2243 again in a python subdir, but the package itself is now in
2245 * setup.py was cleaned up:
2246 - pythonIncludePath removed
2247 - python setup.py bdist target is now functional.
2248 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2249 collision with other packages). gdcmPython/demo/*.py changed
2252 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2253 * python subdir moved to gdcmPython (preparation of distutils packaging).
2254 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2255 distutils installer is operational.
2256 * - gdcmPython/__init__.py now properly loads the swig generated
2257 shadow classes (from gdcm.py).
2258 - gdcmPython/demo/*.py changed to import the package gdcmPython
2259 instead of gdcmPython/demo/load.py.
2260 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2262 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2263 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2264 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2265 entries within the associated public Dicom dictionary resp. the same
2266 information but sorted by the fourth field (PAT, IMG, DIR) of the
2268 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2269 are now in the "???" group.
2270 - python/gdcm.i changed accordingly,
2271 - python/demo/printGroupedPublicDict.py added, that gives an example
2272 of the above new functionalities in Python.
2274 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2275 * src/gdcm.h, gdcmHeader.cxx:
2276 - historic references to glib's g_malloc and g_free (#defined)
2277 were definitively removed.
2278 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2279 * src/gdcmElValSet.cxx:
2280 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2281 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2282 - GetElValue(string) renamed to GetElValueByName.
2283 - Added GetElementByName(string).
2284 * src/gdcmHeader.cxx: added
2285 - GetPubElValRepByNumber(guint16, guint16)
2286 - GetPubElValRepByName(string)
2287 - GetShaElValRepByNumber(guint16, guint16)
2288 - GetShaElValRepByName(string)
2289 - GetShaElValByNumber(guint16, guint16)
2290 - GetShaElValRepByName(string)
2291 - GetElValRepByNumber(guint16, guint16)
2292 - GetElValRepByName(string)
2293 - GetElValByNumber(guint16, guint16)
2294 - GetElValRepByName(string)
2295 * Doc/requirements.txt added.
2297 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2298 * Test/Makefile building now depends on the one of libgdcm.so
2299 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2300 pixel data) aware which enables finding the address (offset) of
2301 the pixel data of JPEG encoded DICOM files. This leaves only a single
2302 file in the testSuite whose pixel data address (offset) is unknown.
2303 * python/testSuite.py changed accordingly.
2305 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2306 * VC++ has some strong limitations when working with the STL, as stated
2307 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2308 "Also note that some STL containers (map, set, queue, list, deque)
2309 cannot be exported. [...]
2310 Some STL classes contain nested classes. These classes can not
2312 This is caused by a designed limitation that once a template
2313 class is instantiated, it can not be re-instantiated and
2315 Since our usage of map<> is ubiquitous in gdcm, this "designed
2316 limitation" of VC++ is a pitfall.
2317 Hence the Python wrappers of gdcm cannot be incrementally linked
2318 against the c++ dynamic library. The dirty but only workaround is
2319 to forget about incremental link of dynamic libraries and to generate
2320 the Python wrappers library with the inclusions of the underlying C++
2322 The following modifications concern this matter on Win32/VC++:
2323 - wrapping python correct with standalone wrapped dll (don't use separate
2324 dll under windows !!!!)
2325 - python21_d debug mode enabled (ask Frog how to use it :-)
2326 - NO problem with having an STL member of class for example string in C++
2327 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2328 - Python test of dcmlib in Python is ok under windows on a large set
2330 * removed glib references
2331 * typedef's inserted in gdcm.i for correct swig type management
2333 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2334 * python/demo/*.py load.py extracted from test.py. Added explore.py
2335 that only displays required tags and testAll.py that parses all
2336 the files of the testsuite without using unittest.
2337 * python/testSuite.py other additional test on new files added.
2338 * Data/* new test files added accordingly to the testSuite.
2339 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2340 the vr in the file differs from the one of the dictionary.
2342 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2343 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2344 values, but limits itself to values which are below a user specified
2345 size (by default 1024 bytes).
2346 * python/gdcm.i : elements not loaded (because their size is above the
2347 user specified treshold) are exported with their TagKey as key of the
2348 python dictionary. This enables the testsuite to make some checks
2349 on the unloaded elements (since we have their offset and size).
2350 * python/testSuite.py
2351 - now tests for the existence and proper value of the pixel data
2352 - two new examples added.
2353 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2355 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2356 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2357 aware. See the strategy comments in gdcmHeader::FindeLength().
2358 * Test/test.cxx now accepts a filename as first argument.
2359 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2360 * python/testSuite.py changed to integrate test on above files.
2362 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2363 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2364 the vr was also RET.
2365 * python/testSuite.py more tests added.
2367 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2368 * python/testSuite.py unittest test suite added (uses Data)
2369 * Data/* dcm and acr files for the test suite.
2370 * glib dependance removed from un*x version. We now use ISO C99
2371 7.18 Integer types (see stdint.h)
2372 - python/Makefile, src/Makefile src/gdcm.h
2373 * src/ when an explicit vr (like dicom files) suddenly poped an
2374 implicit element we use to mark the underlying DictEntry of the
2375 concerned ElValue with "Implicit". This strategy was damageable
2376 too the public or provite dictionaries, since some of their vr
2377 would be changed. Since Header::FindLength heavily relies on the
2378 detection by Header::FindVR of falsely explicit elements, I
2379 added an extra ImplicitVr member to ElValue (boolean).
2380 The rest of the changes we the necessary adaptations.
2382 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2383 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2385 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2387 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2388 * Adaptation for porting to VC++:
2390 o forced to use std namespace (for string to be known)
2391 o all class use __declspec export style on WIN32
2392 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2393 (in stdlib.h on Win32 but in std:: for gcc)
2394 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2395 variable GDCM_DICT_PATH.
2396 * src/gdcmHeader.cxx verbose comments made discrete.
2398 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2399 * python/gdcm.i: added a typemap that converts a C++ hashing table
2400 to native Python dictionary.
2401 * python/demo/test.py:
2402 - now uses the native dictionary for exploration of gdcmHeader.
2403 - takes an optional filename argument (the file to parse).
2404 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2405 PubElVals hashing table.
2406 * Dicts/dicomV3.dic removed error prone trailing spaces.
2408 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2409 * Python wrapping process moved away from src/Makefile to
2410 newly created python/Makefile (as well as gdcm.i)
2411 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2412 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2413 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2414 from the environement variable GDCM_DICT_PATH (when existing).
2415 * src/gdcmDict::GetTag bug fix.
2417 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2418 * Straightforward temporary fixes for swig to build the python wrappers.
2419 src/Makefile now has a python working entry [by working we mean
2420 that we can import de shadow classes without errors].
2422 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2423 * hashtest.cxx removed (since allready in Test)
2424 * src/gdcmlib.h renamed to src/gdcm.h
2425 * src/dcm.i renamed to src/gdcm.i
2426 * src/Makefile prepared for python wrapping
2428 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2429 * src/gdcmHeader.cxx :
2430 - Parsing of header is now separated from loading of element values
2431 (see gdcmHeader::LoadElements).
2432 - general clean up of hopefully all file access (creation of
2433 ReadInt16 and ReadInt32)
2435 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2436 * src/gdcmHeader.cxx :
2437 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2439 - SetLgrElem renamed to SetLength
2440 - GetLgrElem renamed to GetLength
2441 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2442 * src/gdcmElValSet.cxx fixed both GetElValue methods
2443 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2444 due to IdoDude was cleaned out.
2446 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2447 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2448 concentrates on finding the value representation (when it exists).
2449 RecupLgr now only finds the element value length, and it avoids
2450 returning the unecessary skL (skipped length).
2451 Also, offsetCourant was simply removed (with taille_fich) since
2452 it was redundant with the File position internals (by using
2453 ftell and fseek). This also made skL (see above in RecupLgr) usage
2455 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2456 on the libido specificities which are handled through class
2458 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2461 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2462 * Truckload of changes. Parsing of header is barely functional
2463 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2465 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2466 * src/gdcmHeader.cxx many addons of low level methods
2468 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2469 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2470 and _IdDcmSWAP_LONG.
2472 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2473 * This corresponds to all the changes decided at the meeting of
2474 May 23 2002. Needless to say we are running late...