1 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
4 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
5 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
6 test suite reported error.
7 * PACKAGER file added (describes what a packager must do when
8 packaging a new release).
9 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
10 * configure.in: upgraded version number to 0.3.0
11 * fixing build of rpm (through rpm -ta):
12 - Doc/Makefile.am exports proper doxygen files
13 - src/jpeg/libijg8/Makefile.am exports the include files.
15 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
16 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
17 * src/gdcmHeader.h : formatting code
19 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
21 We were obtaining error message from vtk. Now, creation of file list
22 is made in an internal list to prevent this problem.
23 Bug fix when output is empty.
24 Bug fix in update of progress value. Previous commit for this was a bad
26 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
28 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
29 * src/gdcmHeader.h : added method to get the file name
30 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
31 files. Added method to remove all files on the input
32 Added FIXME comment concerning the bad parsing of header made by
33 ExecuteInformation method (in ExecuteData method)
35 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
36 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
37 when using make instal.
38 * src/gdcmFile.cxx : bug fix under Window after JPR commit
39 RQ : the JPR doesn't appear in the ChangeLog... normal for him
41 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
42 * setup.py : adding include dir of jpeg lib to compile all sources
43 * */Win32/*.dsp : JPR fix for windows compilation
45 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
46 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
48 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
49 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
51 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
52 * setup.py is again effective on un*x (takes into account the
53 addon of the jpeg library)
54 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
55 * Doc/Doxy* updated (includes above enhancements)
56 * INSTALL now points to web documentation
58 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
59 * src/gdcmHeader.h doesn't make unnecessary reference to
61 * gdcmPython/Makefile.am now avoids calling the wrappers for the
64 - to allow compilation with gcc 3.x
65 -- clean up of STL usage (added explicit usage of std::)
66 -- small fixes on exceptions.
67 Note: linking not tested !
68 - clean of doxygen comments to avoid warnings at documentation
70 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
71 dependent convertion).
73 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
74 * Clean up of previous JPR garbage commit (not even commented in the
76 - Test/Makefile.am removed the reference to unexisting testTS.cxx
77 - moved all jpeg related files from src to src/jpeg/libijg8, with
78 addition/modification of Makefile.am and configure.in.
79 - the testSuite is still brain damage (not guilty).
81 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
82 * WrapVTK.py : modifications to get correctly vtk source files to
84 * vtk/vtkGdcmReader.cxx : modification for an already existing name
85 (FileName -> Filename)
87 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
88 * vtk/vtkGdcmReader.[cxx/h]:
89 - UpdateProgress method should now be effective
90 - removed the limitation on having only images loaded (as opposed
92 - when building a stack of images/volume, a lesser number of
93 gdcmHeader and gdcmFile instances should be used (hopefully
95 - when building a stack of images/volumes, files which are not
96 loadable (wrong path-filename, wrong permissions on existing file,
97 or file not parsable by gdcm) are replaced with a black image
98 in the stack (for the caller to notice the problem).
100 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
101 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
103 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
104 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
105 between standard library (std) and vtk library (problems are found
106 under Windows... thanks Windows !)
108 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
109 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
111 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
113 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
114 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
116 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
117 * When compiling with distutils (see setup.py) the C++ compiler is
118 called with different flags than the default ones (with automake).
119 In order to fix all those warning, I compiled gdcm with the command
120 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
121 and went for warning fixes:
122 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
123 up from unused variables.
124 - vtk/vtkGdcmReader.cxx: potential bug fix.
125 * src/gdcmHeader.h: Doxygen warning cleanup
127 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
129 - typemaps correction to take into account the systematic replacement
130 of "using namespace std" with std:: prefix e.g. std::list,
131 std::string... (cf changes of 2003-05-21).
132 - gdcmGlob global variable of type gdcmGlobal (defined in
133 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
134 exported to Python a as cvar.
135 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
136 and GetPubDictTagNamesByCategory() as a replacement for deprecated
137 gdcmDictSet.GetPubDictTagNames() and
138 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
140 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
141 with the above changes.
143 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
144 * setup.py, manifest.in : bug fix under linux
146 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
147 * Modification of setup.py to compile vtk part too. Then, we have 2
148 wrappers which must work with same distutils. For that, we have a
149 generic distutils in distusiltsWrapping.py ; with :
150 - build_extWrap class to wrap generically all extensions,
151 - ExtensionWrap base class for all wrapping extension that contains
153 - Wrapper interface which wrap sources
154 + In WrapSwig.py we have extension and wrapper for Swig
155 + In WrapVTK.py we have extension and wrapper for VTK
156 * MANIFEST.in : modifications to consider vtk directory and new python
157 files for compilation
159 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
160 * Added python wrappers of vtkGdcmReader vtk class (see the
161 source in vtk/vtkGdcmReader.cxx) :
162 - vtk/Makefile.am now builds a library
163 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
164 python library (as opposed to _gdcm.so wich are the python
165 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
166 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
168 - configure.in has an additional flag --enable-vtk that needs
169 to be set to enable compilation of vtk related code, that is:
170 + vtk/vtkGdcmReader.so and
171 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
172 + gdcmPython/vtkgdcmPython.so (see above)
173 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
174 be read when compressed or when HighBit + 1 != BitsStored),
175 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
176 the usage of the python wrapper of vtkGdcmReader vtk class.
177 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
178 * src/*.[h] all occurences of stl classes are now prefixed with
179 std::, and all occurences of "using namespace std;" where removed.
180 This is to avoid pollution of global namespace in included files.
181 Apparently vtk does not avoid this pitfall: when using both
182 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
183 collision of various stl members (principally cout...).
184 * gdcmPython/testSuite.py now cleanly removes temprory generated
186 * gdcmPython/gdcm.i now declares a typemap for std::string (to
187 comply with above changes)
189 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
190 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
191 * vtk/vtkGdcmReader.cxx now properly inports the image in the
192 vtk data structure (an image Flip was required).
193 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
194 * cosmetic changes in documentation.
196 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
197 * src/gdcmHeader.cxx: the constructor no longer exits when an
198 unexisting file is given as argument.
199 * The subdirectory Data (containing all the images used for the
200 test suite) is not part of this repository anymore. A new module
201 containing those images is now available at
202 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
203 with the name gdcmData.
204 All the python scripts (including the package initialisation file
205 gdcmPython/__init__.py) were adapated to take this change into
206 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
208 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
209 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
210 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
211 demo of the usage of this class.
212 Compilation of this vtk part is only done when using the --enable-vtk
213 at configure (or autogen.sh) stage.
215 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
216 * More memmory link related corrections and documentation fixes.
218 - maximum info is obtained with a command of the form:
219 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
220 --show-reachable=yes PrintHeader
221 - the remaining reachable blocks seem to come from the STL
222 allocation scheme through the usage of map and list. It looks
223 like this memory cannot be freed but it is not a memory leak
224 (in fact further invocation to the STL would recollect the
225 unused memory allthough it cannot explicitely be freed).
226 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
227 of displaying an image parsed with gdcm and displayed with VTK.
228 Note: some images don't seem to work e.g.
229 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
230 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
231 Allthough this weakens the semantics, it is a ditch attempt to
232 make gdcm more thread friendly.
234 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
235 * Memory link hunt (by using valgrind through the command
236 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
237 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
238 gdcmHeader::_dicom_vr.
239 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
240 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
242 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
244 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
245 * src/Makefile.am now exports all the necessary include files at
249 * UpdateGroupLength replaced by new one
252 * UpdateGroupLength re-written using H-Table
253 (named UpdateGroupLengthNew untill checks are over)
255 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
256 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
257 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
259 - gdcmHeader::GetPubElValSet removed.
260 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
261 UpdateGroupLength, WriteElements, Write.
262 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
263 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
264 carried the same semantics.
265 - src/gdcmHeaderIdo.cxx changed accordingly.
266 - gdcmFile::WriteBase now regroups all the codes from previous
267 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
268 - enum FileType moved to gdcmCommon.h
269 * src/gdcmHeader.cxx AddDefault trashed
271 * getimageDataSize now calls gdcmGetXSize
272 * Test/*.cxx changed to agree with above changes
274 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
275 * src/gdcmHeader.h: LoadElements() is not a public method anymore
276 (to avoid double call by end user).
277 * Test/*.cxx LoadElements() doesn't need to be called explicitely
278 by end user, since gdcmHeader::gdcmHeader now handles it.
280 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
281 * gdcm/Doc many doxygen changes:
282 - Doxyfile now has two different versions, DoxyfileUsers that generates
283 the html.users end users oriented documentation and
284 DoxyfileDeveloppers that generates the html.developper developper
285 oriented documentation.
286 - README changed accordingly
287 - requirement.txt removed (old design info moved to TODO).
288 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
289 DoxyMainPage.txt, DoxyPython.txt provide more information.
290 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
291 be updated by simply regenerating the docs with doxygen and copying
292 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
293 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
294 all the tests in the form "if (<map>.count() >1)" were removed.
295 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
296 ill-formed documentation sections.
297 * src/gdcmHeader.cxx: ditto
299 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
300 * setup.py fixed for un*x (needed macro for stdint.h)
301 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
302 un*ces with sh-utils test utility.
303 * gdcmPython/demo/test.py renamed to PrintHeader.py
304 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
305 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
306 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
307 * src/gdcm*.cxx JPR's bad inclusion fixed.
309 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
310 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
311 * gdcmPython/demo/test.py changed accordingly.
313 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
314 * gdcmPython/Makefile.am fixed linking against libstdc++
315 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
316 * Swig subdir (historical tests of swig version 1.3.17++) removed
317 * Test/testChangeEntete.cxx some lines commented out in order to make
319 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
320 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
322 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
323 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
324 hence the user doesn't need this explicit call.
325 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
326 i.e. LoadElements() call removed.
327 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
328 - src/Makefile.am declares the proper flag for g++.
329 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
330 for adding user defined new tags.
331 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
332 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
333 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
335 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
336 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
337 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
338 src/Makefile.am : the project should properly compile and install
339 with the autotools, included the python wrappers part.
340 * gdcm.spec.in : added a spec file for RPM packaging.
342 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
343 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
345 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
346 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
347 to exported to the environement (see gdcmPython/testSuite.py
349 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
350 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
351 ElValue class renamed to gdcmElValue for obvious consistency reasons.
352 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
353 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
355 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
356 * gdcmPython/__init__.py doesn't crash anymore when running in
357 in InstallMode or PreInstallMode but with an environement given
358 value of GDCM_DICT_PATH.
359 * src/gdcmDictSet.[cxx/h] coding style.
361 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
362 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
363 * src/gdcm.h general comments moved to TODO, and README
364 * src/gdcm.h should now be seen as a user commodity (including it
365 should suffice to fully use gdcm). It is nowhere including within
366 any of the kernel files src/*.cxx and src/*.h.
368 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
369 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
370 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
372 * src/gdcm*.cxx only include their corresponding include file
373 (as opposed to gdcm.h)
374 * gdcmPython/gdcm.i changed accordingly
375 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
376 the autogen.sh generated "make snapshot" command to work.
377 * autogen.sh removed history related references to crea package.
379 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
380 * distutilsSwigCPlusPlus.py work around some swig portability
383 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
384 * Eventually, python/gdcmPython was renamed to gdcmPython. This
385 was done in a last ditch attempt to get setup.py _really_
386 operationnal. The python/gdcmPython layaout add the advantage
387 of hidding away the python related distutils specific files
388 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
389 Alas, the src directory was out of scope (i.e. it's relative
390 position to setup.py was ../src) which made things impossible to
391 handle (see previous version of python/setup.py). Crossing fingers...
393 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
394 * python/setup.py now works on Un*x. (harder than I thougth)
395 * python/distutilsSwigCPlusPlus.py can now have include files
396 among the list of sources.
398 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
399 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
400 * modifications in MSVC projects
402 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
403 * As stated by the first lines of Test/ExceptionAndPython/README, it
404 looks like we can move back to original usage of exception within
405 src/gdcm* and hence remove the errno stuff that was introduced
406 as a quick and dirty fixture of this problem (added to the TODO).
407 * Doc/Doxyfile configuration file for Doxygen and corresponding
408 README file for usage added.
409 * Test/testWrite.cxx added. This new test comes from a split of
410 test.cxx that is now reverted to its original purpous i.e.
411 testing the proper parsing of a Dicom related file.
412 testWrite.cxx concentrates on testing the IO part of gdcm.
413 * Test/bug1.cxx (containing a bug on WIn32) added.
414 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
415 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
416 whose purpose is to publish the content of the TagNames of the
417 Dicom public dictionnary were not accessible without an
418 instance of class gdcmHeader.
419 - those methods are now static methods of gdcmDictSet and hence
420 require no instances at all to be invocated.
421 - within gdcmDictSet this change required to change some method
422 to class methods (i.e. are now static) among which SetDictPath
423 (renamed to BuildDictPath) and LoadDefaultPubDict.
424 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
425 the above changes by calling the new method classes of gdcmDictSet.
426 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
427 the above to be effective.
428 * python/gdcmPython: in order to wrap properly the above changes
429 for Python, swig version now needs to be > 1.3.17.
430 * python/gdcmPython/Makefile fixed to adapt itself to new
431 configure/make shema introduced by Johan Montagnat (thanks for the
432 contribution). Alas this Makefile cannot be turned into a proper
433 Makefile.am without some heavy changes in the configure.in
434 (for python dectection).
435 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
436 now avoids publishing the empty entries.
438 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
439 * python/setup.py : bug fix concerning install under windows
441 * gdcm.dsw : bug fix concerning path for libraries for python !!!
443 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
444 * Dicts/dicomV3.dic : remove double spaces !!!
445 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
446 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
449 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
450 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
451 method. Doxygenation.
452 * src/gdcm.h clean up of JPR spurious comments.
454 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
455 * python/distutilsSwigCPlusPlus.py now properly collects the
456 shadow classes generated by "swig -c++" (gdcm.py in our case)
457 when using "python setup.py install".
458 * python/gdcmPython/__init__.py imports gdcm.py and only manually
459 reexports the working classes.
460 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
461 by the classical C errno scheme. This is to prevent an obscure
462 behavior of the python wrappers when importing wxPython.wx prior
463 to gdcmPython (which ended up in an abort call). An illustration
464 of this oddity can be found in the Test/ExceptionAndPython
465 subdir (see the README file). This problem probably due to
466 an combination of g++ and dynamic loading.
467 * added Test/ExceptionAndPython (see above)
469 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
470 * Changed the layout of the python part to avoid bloating main
471 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
472 i.e. the distutils arsenal. All the python related stuff is
473 again in a python subdir, but the package itself is now in
475 * setup.py was cleaned up:
476 - pythonIncludePath removed
477 - python setup.py bdist target is now functional.
478 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
479 collision with other packages). gdcmPython/demo/*.py changed
481 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
482 * python subdir moved to gdcmPython (preparation of distutils packaging).
483 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
484 distutils installer is operational.
485 * - gdcmPython/__init__.py now properly loads the swig generated
486 shadow classes (from gdcm.py).
487 - gdcmPython/demo/*.py changed to import the package gdcmPython
488 instead of gdcmPython/demo/load.py.
489 - gdcmPython/testSuite.py changed to import the package gdcmPython.
492 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
493 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
494 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
495 entries within the associated public Dicom dictionary resp. the same
496 information but sorted by the fourth field (PAT, IMG, DIR) of the
498 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
499 are now in the "???" group.
500 - python/gdcm.i changed accordingly,
501 - python/demo/printGroupedPublicDict.py added, that gives an example
502 of the above new functionalities in Python.
504 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
505 * src/gdcm.h, gdcmHeader.cxx:
506 - historic references to glib's g_malloc and g_free (#defined)
507 were definitively removed.
508 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
509 * src/gdcmElValSet.cxx:
510 - GetElement(guint32, guint32) renamed to GetElementByNumber.
511 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
512 - GetElValue(string) renamed to GetElValueByName.
513 - Added GetElementByName(string).
514 * src/gdcmHeader.cxx: added
515 - GetPubElValRepByNumber(guint16, guint16)
516 - GetPubElValRepByName(string)
517 - GetShaElValRepByNumber(guint16, guint16)
518 - GetShaElValRepByName(string)
519 - GetShaElValByNumber(guint16, guint16)
520 - GetShaElValRepByName(string)
521 - GetElValRepByNumber(guint16, guint16)
522 - GetElValRepByName(string)
523 - GetElValByNumber(guint16, guint16)
524 - GetElValRepByName(string)
525 * Doc/requirements.txt added.
527 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
528 * Test/Makefile building now depends on the one of libgdcm.so
529 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
530 pixel data) aware which enables finding the address (offset) of
531 the pixel data of JPEG encoded DICOM files. This leaves only a single
532 file in the testSuite whose pixel data address (offset) is unknown.
533 * python/testSuite.py changed accordingly.
535 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
536 * VC++ has some strong limitations when working with the STL, as stated
537 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
538 "Also note that some STL containers (map, set, queue, list, deque)
539 cannot be exported. [...]
540 Some STL classes contain nested classes. These classes can not
542 This is caused by a designed limitation that once a template
543 class is instantiated, it can not be re-instantiated and
545 Since our usage of map<> is ubiquitous in gdcm, this "designed
546 limitation" of VC++ is a pitfall.
547 Hence the Python wrappers of gdcm cannot be incrementally linked
548 against the c++ dynamic library. The dirty but only workaround is
549 to forget about incremental link of dynamic libraries and to generate
550 the Python wrappers library with the inclusions of the underlying C++
552 The following modifications concern this matter on Win32/VC++:
553 - wrapping python correct with standalone wrapped dll (don't use separate
554 dll under windows !!!!)
555 - python21_d debug mode enabled (ask Frog how to use it :-)
556 - NO problem with having an STL member of class for example string in C++
557 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
558 - Python test of dcmlib in Python is ok under windows on a large set
560 * removed glib references
561 * typedef's inserted in gdcm.i for correct swig type management
563 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
564 * python/demo/*.py load.py extracted from test.py. Added explore.py
565 that only displays required tags and testAll.py that parses all
566 the files of the testsuite without using unittest.
567 * python/testSuite.py other additional test on new files added.
568 * Data/* new test files added accordingly to the testSuite.
569 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
570 the vr in the file differs from the one of the dictionary.
572 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
573 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
574 values, but limits itself to values which are below a user specified
575 size (by default 1024 bytes).
576 * python/gdcm.i : elements not loaded (because their size is above the
577 user specified treshold) are exported with their TagKey as key of the
578 python dictionary. This enables the testsuite to make some checks
579 on the unloaded elements (since we have their offset and size).
580 * python/testSuite.py
581 - now tests for the existence and proper value of the pixel data
582 - two new examples added.
583 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
585 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
586 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
587 aware. See the strategy comments in gdcmHeader::FindeLength().
588 * Test/test.cxx now accepts a filename as first argument.
589 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
590 * python/testSuite.py changed to integrate test on above files.
592 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
593 * Dicts/dicomV3.dic removed all the trailing (RET) when the
595 * python/testSuite.py more tests added.
597 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
598 * python/testSuite.py unittest test suite added (uses Data)
599 * Data/* dcm and acr files for the test suite.
600 * glib dependance removed from un*x version. We now use ISO C99
601 7.18 Integer types (see stdint.h)
602 - python/Makefile, src/Makefile src/gdcm.h
603 * src/ when an explicit vr (like dicom files) suddenly poped an
604 implicit element we use to mark the underlying DictEntry of the
605 concerned ElValue with "Implicit". This strategy was damageable
606 too the public or provite dictionaries, since some of their vr
607 would be changed. Since Header::FindLength heavily relies on the
608 detection by Header::FindVR of falsely explicit elements, I
609 added an extra ImplicitVr member to ElValue (boolean).
610 The rest of the changes we the necessary adaptations.
612 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
613 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
615 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
617 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
618 * Adaptation for porting to VC++:
620 o forced to use std namespace (for string to be known)
621 o all class use __declspec export style on WIN32
622 - src/gdcmUtil.cxx new Exit method that wraps the exit call
623 (in stdlib.h on Win32 but in std:: for gcc)
624 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
625 variable GDCM_DICT_PATH.
626 * src/gdcmHeader.cxx verbose comments made discrete.
628 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
629 * python/gdcm.i: added a typemap that converts a C++ hashing table
630 to native Python dictionary.
631 * python/demo/test.py:
632 - now uses the native dictionary for exploration of gdcmHeader.
633 - takes an optional filename argument (the file to parse).
634 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
635 PubElVals hashing table.
636 * Dicts/dicomV3.dic removed error prone trailing spaces.
638 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
639 * Python wrapping process moved away from src/Makefile to
640 newly created python/Makefile (as well as gdcm.i)
641 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
642 * src/gdcmHeader::FindLength only looks for current vr when necessary.
643 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
644 from the environement variable GDCM_DICT_PATH (when existing).
645 * src/gdcmDict::GetTag bug fix.
647 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
648 * Straightforward temporary fixes for swig to build the python wrappers.
649 src/Makefile now has a python working entry [by working we mean
650 that we can import de shadow classes without errors].
652 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
653 * hashtest.cxx removed (since allready in Test)
654 * src/gdcmlib.h renamed to src/gdcm.h
655 * src/dcm.i renamed to src/gdcm.i
656 * src/Makefile prepared for python wrapping
658 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
659 * src/gdcmHeader.cxx :
660 - Parsing of header is now separated from loading of element values
661 (see gdcmHeader::LoadElements).
662 - general clean up of hopefully all file access (creation of
663 ReadInt16 and ReadInt32)
665 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
666 * src/gdcmHeader.cxx :
667 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
669 - SetLgrElem renamed to SetLength
670 - GetLgrElem renamed to GetLength
671 - ~gdcmHeader() made virtual to pesky warning messages at compile.
672 * src/gdcmElValSet.cxx fixed both GetElValue methods
673 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
674 due to IdoDude was cleaned out.
676 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
677 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
678 concentrates on finding the value representation (when it exists).
679 RecupLgr now only finds the element value length, and it avoids
680 returning the unecessary skL (skipped length).
681 Also, offsetCourant was simply removed (with taille_fich) since
682 it was redundant with the File position internals (by using
683 ftell and fseek). This also made skL (see above in RecupLgr) usage
685 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
686 on the libido specificities which are handled through class
688 * Test/implicit_vr.dcm dicom v3 in implicit value representation
691 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
692 * Truckload of changes. Parsing of header is barely functional
693 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
695 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
696 * src/gdcmHeader.cxx many addons of low level methods
698 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
699 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
702 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
703 * This corresponds to all the changes decided at the meeting of
704 May 23 2002. Needless to say we are running late...