1 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
3 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
4 be complient with all the gdcm source code
6 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
10 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
14 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
15 * Test/ : rename VTK tests to have a best name for the tests
16 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
17 GetFirstEntry/GetNextEntry use
19 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
21 test. Now it's on image content and not on the resulting visualisation...
22 might solve the problem on linux when using the OpenGL drivers
24 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
25 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
26 DicomDirSerie, DicomDirImage
27 Dict, DictSet classes :
28 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
29 -remove InitTraversal method.
30 * UPD Test programs + Example programs
32 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
33 remove useless and never updated keyword \ingroup
35 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
36 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
37 is no memory access violation
38 * gdcmPython/demo : add python demos using VTK
40 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
41 * FIX 'Dictionnary' is now spelt 'Dictionary'
42 'wether' is now spelt 'whether'
43 'archieve' is now spelt 'archive' ;-)
45 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
46 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
47 related methods, in order not to expose internal mechanisms
50 * REM methods that exposed internal mechanisms :
51 DicomDir::GetDicomDirPatients()
52 DicomDirPatient::GetDicomDirStudies()
53 DicomDirStudy::GetDicomDirSeries()
54 DicomDirSerie::GetDicomDirImages()
65 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
66 * Removed the Print/indent/default parameter mess. There is absolutely no
67 reason to have to methods, moreover with the second taking the ostream as
68 *SECOND* parameter. This was clearly a bad hack to get things compile.
70 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
71 * Complete rewrite of the GetMacAddress code. Now the code is *much*
72 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
73 Unfortunately the main code does not work on SunOS, thus provide a specific
74 code for this platform only (and Win32 of course). Since this seems to be
75 working, change CreateUniqueUID to use GetMACAddress instead of the
76 problematic GctestetIPAddress
78 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
79 * Unfortunately to be able to test gdcmDirList I had to break the API
80 a little. Now the class is not a std::list anymore but has a member
81 std::vector (more ITK compatible). Allow unit testing on Win32 and
84 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
85 * Update SerieHeader to take into account a Serie Instance UID to properly
88 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
89 * ENH - Comment out Mathieu's (dangerous) Super Hack
90 for dealing with BIGENDIAN processors
91 - Move equivalent stuff to BinEntry::WriteContent
92 When necessary, 16 Bits Pixels are swapped in a small buffer
93 and then written. This avoid allocating a huge buffer, in
94 PixelWriteConvertor, and avoid modifying the Pixel Area.
96 Probabely, the same operation will have to be done when we want
97 to write image with Big Endian Transfert Syntax,
98 and we are working on Little Endian Processor
100 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
101 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
103 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
104 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
105 all the dict content.
106 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
108 * Test/TestDict.cxx : add a new test for the dict classes
110 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
111 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
112 file. Debug is yanked if compiled with NDEBUG
114 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
115 * src/gdcmDictSet.h : set the default output to the os variable
116 * src/gdcmDictEntry.[h|cxx] : add the Print method
117 * gdcmPython/demo/ : add a new test
119 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
120 * merging of Test/PrintDicomDir and Test/TestDicomDir
121 * removal of now redundant Test/PrintDicomDir
122 * enhancement of Example/PrintDicomDir
124 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
125 * Now, python test might work on systems
126 * Add the PrintDicomDir test
128 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
129 * FIX : First entry following group 0002 was lost for
130 Explicit Big Endian Transfer Syntax files
131 (group and elem not swaped)
133 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
134 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
135 Big Endian Transfer Syntax supposed the group following 0002
136 begins always by element 0000 (element 0000 is *optional*)
137 To avoid further troubles, let's be pessimistic, and use
138 Document::HandleOutOfGroup0002() method
139 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
140 (related pb not yet solved)
142 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
143 * Bug fix for the python part use
144 * Now, PrintHeader.py pass... but outside the ctest use. shit !
146 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
147 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
149 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
150 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
151 a string and should ask the global TS dict what are the propreties of
154 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
155 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
156 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
157 to swap the Swap Code, at parsing time, when we come out of group 0002
158 and Transfer Syntax is Big Endian
159 We should be able to read now 'true DICOM" Big Endian coded images
160 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
161 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
163 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
164 * Hopefully fix the bug on MacOSX and static global initialization.
165 This is the only -minor- patch I found that both please MacOSX and VS6.
166 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
167 but this would require a lot of change. Another approach would be that Global
168 create those string and GDCM_UNFOUND becomes a pointer to a string (which
169 gdcm::Global would destroy at exit).
171 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
172 * Fix bug on MacOSX with static initialization in a multy threaded
173 environment. static const string in a header file used to be ill
174 initialized provoquing the freeze of any tests. patch should solve this
177 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
178 * According to Benoit's suggestion, and without any objection from anybody
179 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
180 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
181 - method gdcmDicomDirObject::GetEntry() renamed as
182 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
184 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
185 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
186 you debug/warning message just as c++ streams which make them very convinient
187 to use. Once this is stabilize I will change the ostringstrem to be
188 redirected to a file (ofstream).
189 * Properly support C99 extension: __FUNCTION__ which allow us to display
190 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
192 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
193 * Removal of useless and dangerous methods :
194 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
195 GetDocEntryByName, GetEntryByName, GetDictEntryByName
196 * Removal of usless methods :
197 Dict::PrintByName, Dict::GetDictEntryByName
198 * Commenting out of probabely useless methods :
199 Dict::GetDictEntryNames()
200 Dict::GetDictEntryNamesByCategory()
201 DictSet::GetPubDictEntryNames()
202 DictSet::GetPubDictEntryNamesByCategory()
203 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
204 * ENH : Use dicomTS.dic as described in 2004 version
205 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
206 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
207 Add Accessors on VM (Value Multiplicity), and VM related methods
208 * ADD : Add a list of 'Dicom Attribute types', as found in
209 http://medical.nema.org/dicom/2004/04_15PU.PDF
211 * ADD : Add dicomGroupNameAbbreviations.dic
212 should be used to write a method to replace the former
213 Dict::GetDictEntryNamesByCategory()
215 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
216 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
217 to read in the file... and only it ! Length is the efective length of the
218 data in the DocEntry structure
220 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
221 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
222 And now use a static function call instead, with a global variable. i
223 This is much closer to the VTK approach. Hopefully should be bulletproof
224 and easier to use...hopefully
226 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
227 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
229 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
230 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
232 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
233 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
234 ValEntry, BinEntry, SeqEntry creation or replace
236 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
237 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
238 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
240 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
241 when specifying the VR
242 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
243 * src/gdcmDocEntry.cxx : amelioration of print
245 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
246 * ADD : Add the method Util::IsCurrentProcessorBigEndian
247 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
248 * ADD Method Document::ComputeGroupLength
249 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
250 in order to allow further VR modification by user
251 * REM : removal of once-called method File::WriteBase
252 integration of its code in formerly one-line method File::Write
254 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
255 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
256 replace the different values "??", "Unkn", "Unknown".
257 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
258 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
259 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
260 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
262 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
263 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
265 * Set the gdcm::Base class to some Printable classes
267 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
268 * src/gdcmFile.[h|cxx] : add the Print method
269 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
270 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
271 * src/gdcmDocument.h : remove the PrintLevel informations
272 * Example/PrintFile.cxx : use the new gdcm::File::Print
274 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
275 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
276 problems when compiling with the python wrapping
278 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
279 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
280 writting in ImplicitVR
282 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
283 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
284 JPEG decompression, especially when dicom frames are split into several
285 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
286 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
288 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
289 * src/gdcmHeader.cxx : change the initialisation of default header.
290 Now, this header is readable by gdm, e-film, DicomWorks
292 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
293 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
294 Rename Decompressed to Raw
295 * Use the API changes in gdcm::File.
296 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
299 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
300 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
301 each added entry in the header. Replace the 'Planes' field by the 'Number
304 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
305 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
306 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
308 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
309 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
310 At this time, this image isn't readable by e-film... waiting JPR help to
313 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
314 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
315 DocEntry. Now use methods of the Document !
317 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
318 * Test/ShowDicomSeq.cxx : bug fix
320 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
321 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
322 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
323 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
324 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
326 * Test/TestCopyRescaleDicom.cxx : remove unused variable
327 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
328 containing found sequences
330 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
331 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
333 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
334 Some fields in BinEntry must be copied to not seg fault when making the :
335 gdcm::File *copy = new gdcm::File( copyH );
336 and tests are now made on good variables
338 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
339 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
340 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
342 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
343 * Add vtkGdcmWriter example and test
345 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
346 * Test/TestUtil.cxx : reformat the source code
347 * vtk/vtkGdcmReader.cxx : remove and change prints
348 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
350 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
351 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
353 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
354 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
355 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
357 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
358 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
359 by an eof to prevent all bad read of the file... and in this case, the
362 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
363 * Example/Volume2Dicom.cxx : comment unused variables
364 * Test/PrintDicomDir.cxx : comment unused variables
365 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
366 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
367 method that is redondant with AddEntry.
368 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
371 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
372 * Bug fix due my last commit (compilation under Windows).
373 * Example/Volume2Dicom : bug fix in the file and reformatting source code
374 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
376 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
378 - Remove printf / sprintf
379 - include iostream AFTER gdcm so we don't get warnings
380 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
382 - Also remove tons of include from header files, hopefully this should
383 speeup the compilation time, since it was becoming a dog slow.
384 - Remove gdcm.h as it include way too many files and slow down compilation
385 (plus it is not up to date)
386 - remove 'using namespace std' this is BAD !
388 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
389 * Remove memory leaks on the DicomDir
390 * Remove some useless data in DicomDirObject
391 * Add usefull methods in SQItem, to be complient withe the ElementSet
393 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
394 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
396 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
397 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
398 future, with convertion)
399 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
400 and ImageDataSize values. Remove the method to get the PixelReadConverter
401 from the output of the class
403 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
404 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
406 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
407 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
408 and vtkErrorMacro use.
409 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
411 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
412 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
414 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
415 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
416 The string leaves only in the fonction. So when we make a .c_str(), we
417 get the pointeur on the first element, element that will be destroyed
418 immediately after thee instruction.
419 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
420 file has been opened : the test must be made on the content of the
421 pointer and not directly on the pointer !
424 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
425 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
426 the python part recompiles
428 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
429 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
430 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
431 X session is killed (for my computer... it seems to not be identic on
434 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
435 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
436 avoid problems (otherwise, the difference test between the visible image
437 and the reference is incorrect. If the reference is greater than the
438 screen resolution, it's produce errors).
439 Can be used for only one image. Can be used with a visible flag.
440 * vtk/vtkGdcmReader.cxx : remove commented codes.
441 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
442 under windows at compilation
443 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
445 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
447 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
448 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
449 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
450 tests on the image size X, Y, Z
452 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
453 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
454 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
455 between the class name and the file name
457 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
458 * src/ : fix compilation warnings for the Write method (2 different
459 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
460 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
461 variable... create a static method in gdcm::Document to access to
462 this variable content.
464 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
465 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
466 file, to be accessed by other files (like gdcmFile). Remove commented
467 code. Move the change of the header to the gdcmFile, using the
469 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
470 To be sure of that (and simplify calls), the Write of the header now
471 gets a file name and not a file pointer (std::ifstream).
472 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
473 DocEntryArchive. Remove all open of the written file
475 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
476 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
478 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
479 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
480 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
482 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
483 some corresponding methods. Write correctly the file and check before
485 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
486 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
487 is now on RGB data (as before my last commit
488 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
490 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
491 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
492 Add a print information of the type of the entry
493 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
494 It was in the gdcmFile, and all write have been regrouped
495 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
496 Write correctly all dicom files (in decompressed mode only at this time)
497 * Test/ : test on files are now made using Raw data and not color data if
499 * Example/PrintFile.cxx : add more printings
501 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
502 * Amelioration of code, remove some code copy. For the loading of
503 BinEntry (in gdcmDocument), add the test to verify if the file is already
506 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
507 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
508 remove a DocEntry in the header (push an empty DocEntry)
509 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
510 lines. Bug fix in the initialization of the PixelConvert and the
512 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
513 use in TestCopyDicom (now this test can run under windows... but fails)
514 * Test/TestCopyDicom.cxx : amelioration of the test :
515 - test the pixels written
516 - add test points to quickly find where is the error
517 - can set a file name input and output in arguments
518 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
519 amelioration of the test output
521 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
522 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
523 all replaced DocEntry's
524 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
525 Now, each needed DocEntry to modify is duplicated, modified and inserted
526 to the header using DocEntryArchive. Thus, after save, we can restore the
527 header initial state.
529 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
530 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
532 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
533 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
534 correct to copy it. The DictEntry is specified at the DocEntry creation,
535 then, it musn't change in the time.
536 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
537 header correctly. At this time, the change is only made for the first
538 level of the Document. In the future, it might consider sequences.
539 The change is made by replacing a DocEntry by an other that is created
540 outside the class. The old value is kept. When we restore the header
541 status, the added DocEntry is deleted and replaced by the old value.
542 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
543 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
544 set the write type to explicit VR, implicit VR or ACR. Add methods to set
545 the write mode to native, decompressed or RGB (but not used at this time)
547 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
548 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
549 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
551 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
552 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
553 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
555 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
556 set because already copied when copying the BinEntry's of the header
557 * Test/TestAllReadCompareDicom.cxx : remove warnings
559 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
560 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
561 Two problems appear when doing it :
562 - with the gdcmFile : when the GetImageData method is called, the pixels
563 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
564 data (pixels). And each structure destruct the data when it's
565 destructed. So we have two destructions for the same data. To solve it,
566 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
567 data or not. If it doesn't own data, then they will not destroyed by
569 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
570 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
571 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
572 create a double destruction of the same DocEntry's. So, to solve it,
573 the TagHT is simply cleared and the DicomDir* elements are destroyed.
574 * TODO : add an entry concerning memory leaks in the DicomDir
576 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
577 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
578 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
581 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
582 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
583 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
584 after it have been deleted
586 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
587 * FIX: src/* fix the doxygen warnings.
588 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
589 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
590 was erroneously defined with a size of 15 instead of 16. [many thanks
591 to Jean Michel Rouet for pointing out this bug].
593 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
594 1. Finish merging JMR patch for writting DICOM from scratch
595 2. Fix -hopefully- bug with MONOCHROME and space vs null character
596 3. Use const ref when possible
597 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
598 5. A few more comments
599 6. CreateUniqueUID can now be called without parameter"
601 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
602 * ENH: Slightly bigger patch:
603 1. Getting toward full integration of JMR patch for writting dicom from scratch
604 2. Update Test to test part of this patch: CreateUniqueUID
605 3. File was not close properly in gdcmDict
606 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
607 5. Use of const ref instead of copy (speed issue)
608 6. Remove temporary (duplicate) string in TranslateToKey
609 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
610 8. Do not repeat virtual in subclasses
611 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
613 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
614 * Apply first patch toward better string comparison when dealing with broken
615 DICOM files. Essentially the string could be padded with a space instead
616 of a null character as defined by standard
618 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
619 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
620 because never used... and in the same time, that's remove some memory leaks
622 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
623 * src/gdcmFile.cxx : now delete the PixelConvert instance.
624 * In examples and tests : change the type of image data variables from void*
625 to uint8_t*. Remmove all delete on image data variables
627 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
628 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
629 Verify the file pointer value before open the file, and if it's not null,
630 a verbose message is generated.
631 Close correctly the file when the file isn't considered dicom-like. The
632 correctly close is a call to CloseFile.
633 When closing the file pointer, test if its not null to close the file.
634 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
635 file. For an uncompressed image, the copied data correspond in the least
636 case to the image size (calculated) or the image size specified in the
637 header. A verbose is generated if these two size mismatch
639 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
640 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
641 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
642 break under windows (with msvc6 compilation).
644 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
645 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
646 compiling with MSVC6)
648 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
649 * Bugs fix for the Windows build with VC6
650 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
651 needed (only for projects required VTK). If the VTK is included in all
652 projects, there is conflicts with the jpeg lib of vtk when compiling the
653 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
654 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
655 when compiling the gdcm_wrap.cxx file (created by the compilation of the
657 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
658 (like it's already made for the cout use). Otherwise, conflict with the
661 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
662 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
664 - comments on the DicomDir::Method related usage added.
665 - now that we use the namespace gdcm, a lot of internal classes do
666 NOT need to be wrapped anymore.
667 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
668 DicomDir::Method) new example added.
670 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
671 * Improve string manipulation. I now inforce the notion of 'DicomString'
672 A DicomString can contain as many \0 as they want
673 and it is *always* of even length.
674 We only support odd length for very rare case.
675 And in the near future this should be removed.
677 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
678 * /binary_write/ gdcm source. Now even on big endian we are writting
679 little endian. This should -heopfully- fix some tests
681 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
682 * Now the dictionary is compiled into gdcm lib. This is a default
683 behavior, thus any dic file specified is picked before failback to
684 the one comiled into lib
686 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
687 * Change internals for gdcmDict. Don't use any 'new' any more.
688 This should definitely solve any leak problem, and we should be
689 as fast as before, as long as don't modify too much the dictionary.
691 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
692 * STYLE: ivars should start with a capital letter.
693 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
694 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
696 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
697 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
698 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
699 new 2004 dictionaries added (thanks to JPR).
700 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
701 * CLEANUP_ROUND (15) for gdcmPixelConvert
702 - RLEFrame::NumberFragments is now of type unsigned int
703 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
704 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
707 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
708 * Initial work in gathering all transfer syntax accessors. clearly
709 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
710 ivars, but only one transfersyntax (class) ivar with equivalent method on
713 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
714 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
715 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
716 discussed (plus I didn't like having a 2000 lines patch not commited)
718 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
719 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
720 * CLEANUP_ROUND (14) for gdcmPixelConvert
721 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
722 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
723 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
725 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
726 anymore and hence avoids storing a copy of PixelConvert::Decompressed
727 into File::Pixel_Data.
729 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
730 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
731 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
732 * CLEANUP_ROUND (13) for gdcmPixelConvert
733 Substituted File::ParsePixelData() with PixelConvert::Print() new
735 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
736 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
737 method to those classes.
738 - src/gdcmFile.[cxx|h]:
739 -- Added a ::Print() method.
740 -- PixelConverter is now a reference instead of a member.
741 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
742 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
744 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
745 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
746 collaboration diagram and inheritance diagram should be generated with
748 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
749 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
750 pointlessly wrapped (see
751 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
752 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
753 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
754 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
755 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
756 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
757 -- File::Initialise: PixelConverter setup moved away to
758 PixelConverter::GrabInformationsFromHeader()
759 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
760 interpretation moved away to PixelConverter::BuildRGBImage()
762 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
763 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
764 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
766 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
767 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
768 displayed on Win32 when a brutal abort() occurs (because of uncatched
769 exception). See TODO new entry of this commit for more on this.
770 * TODO added new entry.
771 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
772 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
773 - HandleColor is no longer called from gdcmFile.cxx
774 - gdcmPixelConvert.cxx clean up on method arguments and internal
775 variable names for semantical coherence.
777 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
778 * Finished lossless transition, not only do we now read all lossless jpeg
779 images, without the need of the Cornwell lib, but we do read them properly now
780 * To reduce code (well to avoid code duplication), I defined a common place
781 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
782 redefine symbols. This is not perfect but this the best solution I found for a
783 compilation time jpeg option.
785 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
786 * Update jpeg ijg lib to support lossless jpeg implementation
787 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
789 * Also added a special copyright for dcmtk since we use their bugfixes.
792 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
793 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
794 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
795 matters, as stated in warning note at begining of %include section).
796 * src/gdcmDicomDir*.[cxx|h]: coding style
797 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
798 * src/gdcmJpeg8.cxx: doxygen fix.
799 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
800 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
801 from File:: to PixelConvert::.
803 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
804 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
805 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
806 - more code moved away from File:: to PixelConvert::
807 - fat setup of PixelConverter set in place in File::Initialise.
809 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
810 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
811 namespace at the file system level. So now you should convert your examples
813 gdcmHeader -> gdcm::Header
814 It would be nice if people keep in mind to no open the namespace, since it
815 allows compilation on broken plateform which were defining common symbol in
816 the standart namespace (like LP, Unknown ...)
818 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
819 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
820 The JPEG fragments are now parsed at the same stage than the RLE
821 information. All code related to JPEG is now in gdcmPixelConvert:
822 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
823 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
824 export a gdcmFile:: method. Those are simply global functions
825 (for the time being this is better than having them attach to
826 either gdcmFile:: or gdcmPixelConvert::).
827 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
828 and stores the result in a gdcmJPEGFragmentsInfo.
829 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
830 code (among other stuff) moved away from gdcmFile:; to
833 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
834 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
835 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
836 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
837 clean up of RLE related code.
838 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
839 - src/gdcmRLE.cxx removed
840 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
841 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
842 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
843 * CLEANUP_ROUND (9) for gdcmPixelConvert
844 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
845 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
846 away from gdcmFile:: to gdcmPixelConvert::.
848 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
849 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
850 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
851 This is because Parse7Fe0 used to parse the pixels to compute the
852 length. This task was passed over to FindDocEntryLengthOB() a long
853 time ago, EXCEPT I had forgotten the OW case...
854 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
855 we just recylce the code for parsing RLE fragments and computing
857 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
858 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
859 with the retired Parse7Fe0().
860 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
861 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
863 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
864 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
865 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
866 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
867 - src/CMakeLists.txt: alphabetic order reodering + new entries.
868 * CLEANUP_ROUND (4) for gdcmPixelConvert
869 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
870 to return an unused length.
872 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
873 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
874 this should be cleanner from the plane view. The iostream are erally a pain
875 to use to do simple stuff.
877 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
878 * Redo the compilation of the ijg jpeg library. Now only one source is
879 necesseray. No need to rename file by hand what so ever. CMake handle the
880 copying of the file within different directory, configure header file to
881 modify some symbol. The only addition made to ijg wasd a mangle table so
882 that symbol are different whether we are within 8bits or 12bits.
884 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
885 * Added documentation of vtkgdcmReader on Website:
886 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
887 with it's binary name).
888 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
889 the Website to be more complete.
890 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
891 doxygenated documentation.
892 - Doc/DoxyVtkGdcmReaderExamples.txt added
893 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
894 DoxyVtkGdmReaderExamples.html )
895 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
896 * CLEANUP_ROUND (3) for gdcmPixelConvert
897 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
899 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
900 * CLEANUP_ROUND (2) for gdcmPixelConvert
901 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
903 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
904 * CLEANUP_ROUND for gdcmPixelConvert:
905 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
906 - src/gdcmPixelStuff[h|cxx] removed
907 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
908 - src/CMakeLists.txt changed accordingly
910 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
911 gdcmVersion.py moved to newly created ATTIC related
912 gdcmPython/SetupOldies/ directory.
913 * Autotools clean up:
914 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
915 - autogen.sh configure.in acinclude.m4 python.m4 removed
917 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
918 * src/*.cxx *.h Reference to License.htm fixed to License.html.
919 * Doc/CMakeLists.txt, doxygen.config.in: fix.
920 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
922 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
923 * TODO updated with Mathieu suggestions. I proposed a template for
924 describing TODO entries and used it for new entries.
925 * Added Doc/Website/CodingStyle.html, Developpers.html,
926 DeveloppersPython.html, GdcmDataCvs.html and
927 DownloadVersion0_1.html, DownloadVersion0_3.html.
928 * Some Doc/*.txt Doxygen files (which do not really concern the
929 documentation itself, but the website) moved to html and
930 placed in directory Doc/Website:
931 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
932 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
933 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
934 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
935 * CMakeLists.txt changed accordingly.
936 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
937 DeveloppersPython.html
938 * INSTALL nows refers to Doc/Website/Installation.html
940 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
941 * Added Doc/Website directory, that contains a first raw version
944 2004-09-23 Jean-Pierre Roux
945 * FIX In order not to be poluted any longer by casting problems,
946 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
947 we can now delete[] it safely
948 * VoidArea is now called BinArea (less confusing name),
949 and all the methods called ...VoidArea... are now ... BinArea...
950 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
952 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
953 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
954 clear) TagHT, which is an inherited member of gdcmElementSet. It is
955 up to the destructor of gdcmElementSet to clean up TagHt and it's
958 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
959 * Test/CMakeLists.txt: update to follow gdcmData renamings.
960 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
962 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
963 * ENH: added some utility method that builds a flat dictionary
964 holding all the Dicom entries contained in the recursive structure
965 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
967 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
968 BuildFlatHashTable() that build a flat dictionary.
969 - src/gdcmElementSet.h: added a new private GetTag() accessor.
970 gdcmDocument is now a friend of gdcmElementSet.
971 - src/gdcmElementSet.cxx: clean up.
972 - Example/FlatHashTablePrint.cxx added.
973 - Example/CmakeLists.txt changed accordingly
975 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
976 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
977 moved away from gdcmDocEntrySet (since this class is an abstract class
978 acting like an interface). SQDepthLevel and BaseTagKey are now
980 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
981 and associated accessors. Doxygenation of the class.
982 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
984 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
985 Use SQDepthLevel accessor instead. ::Print() adapted.
986 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
987 - src/gdcmDocument.cxx changed accordingly.
989 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
990 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
991 - The following is the doxygen comment of the typedef declaration
992 of gdcmTagKey in src/gdcmCommon.h:
993 gdcmTagKey is made to old an "universal" (as in URL, Universal
994 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
995 A dicom tag always has a group and an element, but a set of tags
996 embeded in various (optionally nested) sequences and sharing
997 the same group and element all share the same (group, element)
998 "identifier". Hence the (group, element) cannot be used as an
999 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1000 In order to construct a proper tag identifier (i.e. a key) we
1001 consider the following definition of a TagKey:
1002 - let Group, Element be the string representation of the
1003 group and element dicom tag members,
1004 - let ItemNumber be the string representation of the integer
1005 index of the considered item number of a sequence,
1006 Let the key of a tag embeded in a sequence, noted SeqTag, be
1008 /ItemNumber#Group|Element
1009 where "/", "#" and "|" are characters acting as separators.
1010 Then the general form of a gdcmTagKey is given by:
1011 Group|Element<SeqTag>
1012 where <SeqTag> means NO or many instances of SeqTag.
1013 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1016 but the gdcmTagKey of a tag "embeded" is the first item of
1017 a sequence, itself nested in the third item of a sequence is the
1019 0004|1220/2#0008|0082/0#0008|0090
1020 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1021 order to hold the new sequence compatible key. Previously, the
1022 GetKey() method would look in the underlying gdcmDictEntry.
1023 - src/gdcmDocEntry.cxx:
1024 -- constructor now copies the underlying DictEntry key, in the local
1026 -- ::Print: displays the member Key, instead of the (group, element).
1027 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1028 - src/gdcmDocEntrySet.h:xi
1029 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1030 -- now has a new BaseTagKey member.
1032 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1033 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1035 This poses the problem with the semantics of the following lines
1036 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1037 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1038 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1039 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1040 to the long FIXME note for what the problem is. Nevertheless in
1041 order to get things working the dicom dictionary was altered !
1042 Please fix things urgently...
1043 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1044 information), see above note on moving the member VoidArea. Nevertheless
1045 the following entries previously correctly set as US are now inproperly
1047 0028 1201 OW IMG Red Palette Color Lookup Table Data
1048 0028 1202 OW IMG Green Palette Color Lookup Table Data
1049 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1050 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1051 of gdcmDocEntry moved to gdcmSeqEntry.
1052 * src/gdcmSeqEntry.cxx: STYLE.
1054 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1055 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1057 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1058 * gdcmPython/testSuite.py: all the test suite in python is now moved
1059 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1060 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1061 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1063 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1064 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1065 to avoid inclusion recursion until STL is reached.
1066 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1067 mecanism. errno.h is not included in gdcm anymore.
1068 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1069 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1071 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1072 gdcmData/TestAllEntryVerifyReference.txt
1073 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1074 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1075 exception_on_error parameter.
1076 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1077 - vtk/vtkGdcmReader.cxx changed accordingly,
1078 - Example/*.cxx and Test/*.cxx changed accordingly.
1080 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1081 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1082 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1083 enable_sequences removed from gdcmHeader constructor and dependencies.
1084 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1085 * gdcmPython/demo/PrintHeader.py: dummy fix.
1086 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1087 skip_shadow removed from gdcmHeader constructor and dependencies.
1088 * Example/*.cxx and Test/*.cxx changed accordingly.
1090 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1091 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1092 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1094 2004-07-21 Jean-Pierre Roux
1095 * FIX Now, Parsing and Printing a DICOMDIR do work!
1096 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1098 2004-07-20 Jean-Pierre Roux
1099 * FIX Some brain damaged headers have Zero-Lenght fields
1100 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1102 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1103 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1104 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1105 variable (instance of gdcmDebug) by a definition macro, and the instance
1106 is now in static in the gdcmDebug class
1107 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1108 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1110 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1111 * WARNING: ctest now depends more tightly on gdcmData. You should
1112 check out gdcmData properly for things to run smoothly...
1113 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1114 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1115 we need the pixels not be loaded in order to use the ValEntry
1116 that displays position and size).
1117 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1118 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1119 be deprecated. If you have any doubts about the advantages of a
1120 modern scripting language (read Python) versus grass root C++ (i.e.
1121 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1122 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1123 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1124 Anyhow, consider documenting the gdcmData images in
1125 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1127 * Test/CMakeLists.txt:
1128 - now uses TestAllEntryVerify.cxx
1129 - specific comments on oldACR00001.ima (now renamed in gdcmData
1130 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1131 gdcmData/TestAllEntryVerifyReference.txt
1134 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1135 * src/*.[h|cxx] : typedef clean up
1136 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1137 - TagKey renamed to gdcmTagKey (for external usage)
1138 - VRKey renamed to gdcmVRKey (for external usage)
1139 - removal of typedef duplication.
1140 - Removed all unecessary inline keyword from class inline definitions.
1141 - Some method|function(void) declarations replaced with method|function().
1142 * src/jpeg/libijg12/jdhuff12.c:
1143 - printf polluting ctest removed.
1144 - TAB removal for comminting
1146 - TestAllReadCompareDicom.cxx: added a test that compares all the
1147 images in gdcmDataImages.h with corresponding images in
1148 gdcmData/BaselineDicom/. When baseline images are not present
1149 this test creates them.
1150 Note: we need to validate each reference image, but before that
1151 I'd like to rename them with a more explicit name...
1152 - CMakeLists.txt: changed accordingly.
1153 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1154 including each header needed).
1156 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1157 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1158 test suite to the Example directory. Are concerned:
1163 - TestWriteSimple.cxx
1164 * Test/CMakeLists.txt: added some comments on reasons for black listing
1165 image gdcmData/oldACR00001.ima
1167 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1168 * Test/CmakeList.txt: removed the following from black list (to be coherent
1169 with removal from gdcmData):
1170 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1171 - gdcm-MR-PHILIPS-16.dcm
1173 Added the following because after last cvs update, they cause
1174 ctest -R TestReadWriteReadCompare
1176 - gdcm-MR-SIEMENS-16-1.acr
1178 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1179 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1180 new comments in this file) we temporarily (sigh) move to a weaker
1182 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1183 we don't need to black list the following images anymore:
1184 - 8BitsUncompressedColor.dcm
1186 - US-PAL-8-10x-echo.dcm
1187 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1188 fixes and the beautified code ;-)
1189 This fixes the bug introduced in version 1.42 (when beautifying)
1190 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1191 Note: ctest was blind to this bug (this means we need to still
1192 improve the test suite). The bug could be detected by using
1193 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1195 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1196 and by displaying the (garbage) produced file temp.XDCM...
1198 2004-06-29 Jean-Pierre Roux
1199 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1200 - replace by uggly but working old code :-(
1201 A lot of things should be OK again.
1202 It's really urgent to have a test suite that *tests*,
1203 to prevent Frog's beautifying sessions to break all the stuff
1204 (twice, withing a fortnigh ...)
1206 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1207 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1208 redundancy) to added Test/TestReadWriteReadCompare.cxx
1209 * Test/CmakeList.txt: because the compare test of
1210 Test/TestReadWriteReadCompare.cxx fails, the following images are
1211 black listed: - 8BitsUncompressedColor.dcm
1213 - US-PAL-8-10x-echo.dcm
1214 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1215 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1216 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1217 and ad-hoc kludge. This kludge is now removed, and on encountering
1218 such an image (OB field brain damaged) we set errno. Then in
1219 ::FindDocLength() we "fix" the length as being ALL what remains
1220 in the file (until EOF). We then proceed, hoping for the best...
1221 This fixes a SegFault in ShowDicom when trying to write such an
1223 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1224 (because TestWriteRead breaks on it, after a non conformal commit?).
1225 ctest now runs properly, except for MakeDicomDir (which was always
1226 broken) and the Python related stuff (still not fixed).
1228 2004-06-24 Jean-Pierre Roux
1229 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1230 FIX : Test/TestReadWrite now iterates on all the file names
1231 (instead of infinite loop)
1232 ENH : Test/TestWriteRead now iterates on all the file names
1234 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1235 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1237 2004-06-24 Jean-Pierre Roux
1238 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1239 when SamplesPerPixel =3
1240 - now Write is no longer confused by
1241 'BitsAllocated = 12" and 'BitsStored=12"
1242 - "UN" value representation Elements are now written correctly
1243 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1244 ENH : - now gdcmHeader has its own Write methods
1245 (in order to split the job that has not to be done
1248 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1249 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1250 loop on the same image until memory went out.
1251 Note: this means we still have gobs of memory loss in PrintDocument
1252 * src/gdcmDocument.cxx: fixes problem on parsing on file
1253 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1255 2004-06-24 Jean-Pierre Roux
1256 FIX : Write - All the Sequences and Sequence Item are now written
1257 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1258 is added a the end, when necessary.
1259 - A lot of brain-damaged images, that were read correctly are
1260 now written correctly
1261 - length compatible BinEntry are now loaded correctly
1262 (even for odd groups)
1263 Note : only Explicit Value Representation was checked.
1264 (question : is implicit VR really necessary for gdcm ?)
1266 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1267 * DEVELOPPER: added a proposition of coding style.
1268 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1271 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1272 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1273 Use the gdcmDocEntry::Print() and Write() instead.
1274 * src/gdcmDocument.cxx: bug fix.
1276 2004-06-22 Jean-Pierre Roux
1277 FIX : gdcmDocument.cxx
1278 - Now we do recognize the JpegLossLess format (there was a misstyping in
1279 code 'beautyfication' :-(
1280 - Now we automaticaticaly load the Luts, if any
1282 2004-06-22 Jean-Pierre Roux
1283 In order : to write Sequences, whatever their imbrication level,
1284 : to allow user to create his own Sequences
1285 a lot of modif where necessary (adding, moving, or virtualising methods)
1287 WARNING : save your own sources *before* cvs up !
1290 ADD virtual void Write(FILE *fp, FileType filetype);
1293 ADD virtual void Write(FILE *fp, FileType filetype);
1294 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1297 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1298 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1299 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1300 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1301 ADD std::string GetEntryByName(TagName name);
1302 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1304 std::string vr = "unkn",
1305 std::string fourth = "unkn",
1306 std::string name = "unkn");
1307 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1308 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1309 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1310 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1311 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1312 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1313 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1314 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1317 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1318 ADD virtual std::string GetEntryByName (TagName tagName);
1319 ADD virtual std::string GetEntryVRByName (TagName tagName);
1320 REM virtual bool Write(FILE *, FileType);
1321 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1322 FILE *_fp, FileType type);
1323 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1324 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1325 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1326 REM virtual std::string GetEntryByName (std::string tagName);
1327 REM virtual std::string GetEntryVRByName (std::string tagName);
1328 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1329 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1330 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1332 std::string vr = "unkn",
1333 std::string fourth = "unkn",
1334 std::string name = "unkn");
1335 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1336 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1337 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1338 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1341 ADD virtual void Write(FILE *fp, FileType filetype);
1344 ADD virtual void Write(FILE *fp,FileType filetype);
1347 ADD virtual void Write(FILE *fp, FileType filetype);
1348 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1349 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1350 REM std::string GetEntryByName(TagName name);
1353 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1355 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1356 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1357 The default constructor invoked by the line
1358 gdcmHeader *f1 = new gdcmHeader( header );
1359 was gdcmHeader::gdcmHeader(bool) instead of the expected
1360 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1361 Hence the parsing wasn't executed... See also below.
1362 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1363 as explicit constructor didn't do the trick to fix the above problem.
1364 Could anyone explain why ?
1365 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1366 properly calls gdcmValEntry::Print() (that was weed out from
1367 code related to gdcmBinEntry).
1369 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1370 * In order to fix memory leaks:
1371 - Test/TestWriteSimple.cxx: added cleaning of free store through
1373 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1374 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1375 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1376 (through the call to ::AddDicomDirMeta()) or the destructor
1377 would crash when deleting uninitialized ::metaElems].
1378 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1379 - src/gdcmDocument.cxx:
1380 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1381 from dynamic stores.
1382 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1383 was causing memory leaks.
1384 - src/gdcmSQItem.cxx:
1385 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1386 cleanly handled with polymophism: sorry but my milage is low).
1387 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1388 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1389 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1390 This avoids SegFaulting.
1391 - src/gdcmSQItem.h: coding style.
1393 - Test/TestWriteSimple still severely sucks. The output image content
1394 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1395 damaged when displayed with vtkgdcmViewer.
1396 - on memory leaks: TestWriteSimple leaks really less (see entry
1397 of 2004-06-18 in Changelog file for the call to valgrind).
1398 - on segfaults: ctest now passes all the tests but one (no more
1400 * Erroneous leading white fix:
1401 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1402 white[s] (as opposed to from >> xxx, that removes it [them].
1403 - src/gdcmTS.cxx: ditto.
1404 - gdcmPython/testSuite.py: dirty related kludge removed.
1405 * src/*: remaining references to gdcmParser removed.
1406 * src/*[cxx|h]: added copy[way]left header.
1409 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1410 * In order to fix writing of dicom files:
1411 - Test/TestWriteSimple.cxx: a simpler example of writing.
1412 - Test/CMakeLists.txt changed accordingly.
1413 - src/gdcmDocument.cxx:
1414 -- The destructor now recursilvely removes potential sequences.
1415 -- Bug fix in ::IsJPEG2000()
1416 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1417 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1419 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1420 to only declared) and build on top of
1421 ::GetDocEntryByNumber(guint16, guint16).
1422 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1423 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1424 for usage in destructor and treatement of promotion in
1425 ::ReplaceOrCreateByNumber().
1426 - src/gdcmSQItem.cxx: destructor should better handle his job.
1427 Test/TestWriteSimple now runs (or at least it DOES something).
1428 * We can now start hutting memory links. A good starting point is:
1429 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1430 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1431 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1433 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1434 * Valgrind note: after Mathieu Malaterre teached me how to read
1435 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1437 Using gcc, you can force the STL to use malloc and to free memory as
1438 soon as possible by globally disabling memory caching.
1439 With 3.2.2 and later, you should export the environment variable
1440 GLIBCPP_FORCE_NEW before running your program.
1441 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1442 simply vanish (it is still not clear to me, whether this means that
1443 STL std::string leaks or if valgrind believes it leaks...).
1444 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1445 running bin/gdcmTests makeDicomDir):
1446 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1447 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1449 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1450 SegFaulting (I drowned in DicomDir related code when trying to
1451 understand why the list is empty...).
1452 * src/gdcmDocument.h: first BSD license header try.
1453 * Doc/License.txt added.
1455 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1456 * src/gdcmDocument.[h|cxx]:
1457 - Clean up of the Transfer related predicates. They are now all based
1458 on new method isGivenTransferSyntax, that (should) handle properly
1459 the padding problem.
1460 - general clean up, simplification, and coding style.
1461 - Specific clean up of Parse7FE0() (umproperly named actually).
1462 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1464 2004-06-14 Jean-Pierre Roux
1466 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1467 - fix the display of SQItem ordinal number
1468 - add the GetSQItemByOrdinalNumber method
1469 - remove some useless never written private methods
1471 2004-06-14 Jean-Pierre Roux
1473 - adding a constructor taking a gdcmDocEntry as an input param
1474 - ReplaceOrCreateByNumber now returns :
1475 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1476 a gdcmValEntry * if a string value is passed as a param
1478 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1479 according to the param type (no longer sets a gdcmDocEntry)
1480 - GetValEntryByNumber, GetBinEntryByNumber added
1481 - NewValEntryByNumber and NewBinEntryByNumber added
1483 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1485 - GetSQItemNumber and SetSQItemNumber added, to provide
1486 a (relative) Item identier inside a given Sequence
1487 \warning : some pb remaining around this number
1489 - AddEntry now takes the Item Number as a param
1491 - adding a constructor taking a gdcmDocEntry as an input param
1493 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1494 * Memory leak hunt with the following command:
1495 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1496 --show-reachable=yes gdcmTests PrintDocument
1497 It looks like many (all?) leaks are due to the STL (or a bad usage
1498 of the STL. The lines producing the leaks now have a comment with
1499 a "MEMORY LEAK" tag: you can retrieve them with
1500 grep "MEMORY LEAK" src/*
1501 Here are two typical examples which I can't help fixing:
1506 char * test = "babo";
1507 name = test; //// <--- valgrind detects 960 bytes lost in
1508 //// call to std::string::operator=(char const*)
1509 name.clear(); //// Doesn't help !
1517 std::cout << "Type a bunch of characters followed by RETURN: ";
1518 getline(std::cin, line); //// <--- valgrind dectects a loss
1519 //// of 1320 bytes in call to
1520 /// std::basic_istream<>& std::getline<>
1526 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1527 * src/gdcmHeader.[cxx|h]:
1528 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1529 and related, moved away to gdcmDocument.
1530 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1531 the corresponding protected accessors of inherited class
1532 gdcmDocument, removed ! As a consequence gdcmFile had to be
1533 declared friend of class gdcmDocument (see below).
1534 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1535 - Clean up of undefined or unused methods.
1536 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1537 account the changes to gdcmHeader.h).
1538 * src/gdcmDocument.h:
1539 - gdcmFile is now a friend class (in order to take into account the
1540 changes to gdcmHeader.h).
1541 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1542 (see changes to gdcmHeader.h).
1543 - Accessors (reading on the form GetEntry*) are now public.
1544 - Clean up of undefined or unused methods.
1545 * src/gdcmDocument.cxx:
1546 - adaptation to changes to gdcmDocument.h
1547 - ::OpenFile now writes a verbose message when file cannot be opened.
1548 - some std::string properly set to VRKey
1549 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1550 references to gdcmDocument.
1551 * Test/TestFindTags.cxx: changed accordingly to above changes.
1552 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1553 cvs repository gdcmData.
1555 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1556 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1557 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1558 conflicts with gdcmValEntry::voidArea.
1559 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1560 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1561 Value representation between StringRepresentable and BinaryRepresentable.
1562 * src/gdcmDocument.cxx:
1563 - method ParseDES: proper indentation restored and usage of
1564 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1565 - method LoadDocEntry: the fingerprint left in the SetValue() of
1566 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1567 removed. Reverting to previous code segment with the proper
1568 dynamic_cast< gdcmValEntry* >.
1569 Note: this was (partially) breaking the python test suite
1570 (gdcmPython/testSuite.py) that made usage of the above
1571 fingerprint to check presence of "Pixel Data".
1572 * src/gdcmDocEntry.h: coding style.
1573 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1574 now taken into account.
1575 * gdcmPython/gdcm.i: adaptation to the new internal representation
1576 of gdcm (exit gdcmParser, hello gdcmDocument).
1577 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1579 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1580 anymore, but instead prints the loaded Python dictionary.
1581 * .... alas, the python testSuite is still broken.
1583 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1584 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1586 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1587 * src/gdcmUtil.h : export methods
1589 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1590 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1592 * Initial addition of automatic python testing
1593 * Initial addition of automatic image comparison
1595 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1596 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1597 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1599 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1600 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1601 * Test/ShowDicom.cxx : bug fix for msvc compilation
1602 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1604 2004-05-04 Jean-Pierre Roux
1605 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1606 new concepts (and new classes) :
1607 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1608 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1609 - Sequence Doc Entries (gdcmSeqEntries)
1610 a Sequence is composed of Items.
1611 Each item is a set of Doc Entries (this is recursive)
1612 The non uniqueness of the 'Dicom tag' is due to this recursivity
1613 (never taken into account)
1614 Our unability to add a new 'entry' in the header
1615 at the proper location (neither in the H-Table (map or multimap),
1616 nor in the Chained List is also due to this recursivity.
1617 Don't try, right now, to use/modify/compile these new sources :
1618 nothing is finished.
1619 We just commit all the stuff, 'as is', in order not to loose it.
1621 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1622 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1624 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1625 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1626 file prefix (SetFilePrefix)
1628 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1629 * Add a new test: ShowDicom, for now this is just the c++ version of
1630 checkRead.sh, later it will be able to compare the image read against a
1632 * Replace the DEBUG on the stack with a global entry in cmake interface:
1633 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1635 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1636 * Add an example subdir, with a real example on how to read + write a
1639 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1640 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1641 * Doc/CMakeLists.txt: the main page is now properly differentiated
1642 between the developper and user version.
1643 * Doc/doxygen.config.in: dropped search related obsolete flags
1644 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1646 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1647 * DEVELOPPER: added some helpfull comments for compile/test/install
1650 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1651 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1652 src directory, now generated in the build dir.
1653 2. Tests as mentionned smarter
1655 4. Add a new method in gdcmDict that return the PubDict by name
1656 this is interesting for 3rd party lib like ITK,
1657 where we could set the institution name / patient name...
1659 * ENH: 1. Now the test suite is working for real
1660 2. All binaries are now output in the gdcm-bin directory
1661 (this was not true before)
1663 2004-04-28 Jean-Pierre Roux
1664 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1665 SeQuence indented printing of Dicom Header.
1666 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1667 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1668 Computation of SQDepthLevel is now part of gdcmHeader constructor
1669 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1670 tree-like structure of a Dicom Header.
1671 * FIX Test code cleaning
1673 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1674 * ENH: Adding automatic testing
1675 1. Need a DartConfig.cmake to submit to public
1676 2. Add a test driver gdcmTest.cxx
1677 3. gdcmTestMain, an helper for the main test driver gdcmTest
1678 4. Files in Test don't have a main anymore, this becomes interesting
1679 when we add more and more tests, thus dsw don't have to load
1681 * ENH: Adding a GDCM_DATA_ROOT for testing
1682 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1683 one file instead of seven + some small cleanup
1685 2004-04-22 Jean-Pierre Roux
1686 * ENH Minor changes to the Print() methods.
1687 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1688 Header printing. Example given with :
1689 > PrintHeader fileName 2 new
1690 (SQ based tree-like structure still to be done for the Header ...)
1692 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1693 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1694 1. I have added some unsigned where needed
1695 2. Some function parameter not used -> (void)
1696 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1697 4. g++ don't like character '\' in comment
1698 5. #define jpeg_create_decompress jCreaDecompress
1699 this really need to be fixed
1700 6. virtualize destructor of gdcmObject ... leakage
1701 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1702 this also really need to be fixed
1703 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1704 remove compression file
1705 (as we only do decompression, right ?)
1706 * ENH: Change malloc/calloc/free with c++ equivalent
1708 2004-04-21 Jean-Pierre Roux
1709 * FIX gdcmHeaderHelper::GetXSpacing
1710 when a single value is found (bug ?), xpacing is now
1711 defaulted to yspacing
1713 2004-04-19 Jean-Pierre Roux
1714 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1715 * ENH add parameters :
1716 bool exception_on_error = false,
1717 bool enable_sequences = false,
1718 bool ignore_shadow = false
1719 to the gdcmFile constructors to be full gdcmParser compliant
1720 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1721 to allow reading of PAPYRUS 3.0 files
1723 2004-04-06 Jean-Pierre Roux
1724 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1726 2004-04-02 Jean-Pierre Roux
1727 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1728 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1729 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1731 2004-03-30 Jean-Pierre Roux
1732 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1733 for ACR file, written out as DICOM files (hope so...)
1735 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1736 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1737 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1738 moved to base class gdcmParser and only the specialisation is kept
1740 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1741 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1742 already does the job.
1743 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1744 (to be consistent with gdcmParser::WriteEntries).
1746 2004-03-30 Benoit Regrain
1747 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1748 upate of the object's instance. It's passed to 2 in the unfavorable
1749 case : one in the ExecuteInformation, one in the ExecuteData
1751 2004-03-29 Jean-Pierre Roux
1752 * ENH : Check on file type to be written moved
1753 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1754 * FIX : gdcmObject::ResetBoundaries now stops properly
1755 when end-of-list is reached
1756 : gdcmVersion modified (as Benoit Regrain asked)
1758 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1759 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1760 * src/gdcmUtil.cxx: added forgotten iostream include.
1761 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1762 equivalent to ExplicitVR in existing code).
1764 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1765 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1766 now contains all the gdcmGlobal related code.
1767 * minor coding style and doxygenation changes.
1769 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1770 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1771 now contains all the Debug related code.
1772 * minor clean-up of includes in src/*.cxx
1773 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1774 CreateCleanString) removed.
1775 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1776 * Doc/DoxyMainPageUser.txt added.
1777 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1778 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1779 src/gdcmDirList.cxx)
1781 2004-03-24 Jean-Pierre Roux
1782 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1784 2004-03-23 Jean-Pierre Roux
1785 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1786 big endian made volumes
1787 * ENH Now gdcmParser constructor and destructor are protected to forbid
1788 end user to instanciate class gdcmParser
1789 (only gdcmHeader and gdcmDicomDir are meaningfull)
1791 2004-03-22 Benoit Regrain
1792 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1793 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1794 gdcmSerie to gdcmDicomDirSerie
1796 2004-03-19 Jean-Pierre Roux
1797 * ENH Now the tree-like structure describing a DICOMDIR comming from
1798 an already existing DICOMDIR file is consistent with
1799 the home-made tree-like structure build ex-nihilo
1800 or build from the files held (recursively) in a Directory
1801 functions gdcmDicomDir::CheckBoundaries()
1802 gdcmObject::SetBoundaries() added
1804 2004-03-17 Jean-Pierre Roux
1805 * REM (Eric Boix bug) : removal of meaningless
1806 gdcmDicomDirImage::NewImage function.
1807 * FIX now file names and directory name are written properly in the
1809 * FIX now gdcmDicomDir constructor may be call without any trick
1812 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1813 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1814 of gdcmDicomDirImage::NewImage as empty function.
1816 2004-02-28 Jean-Pierre Roux
1817 * ENH add gdcmDicomDir:NewPatient
1818 add gdcmDicomDirPatient:NewStudy
1819 add gdcmDicomDirStudy:NewSerie
1820 add gdcmDicomDirSerie:NewImage
1821 to allow making gdcDicomDir object.
1822 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1823 (as opposite to the gdcmHeader chained list)
1825 2004-02-11 Benoit Regrain
1826 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1827 when using from python
1829 2004-02-10 Benoit Regrain
1830 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1831 * FIX : in gdcmDicomDir when the directory is empty
1832 * ENH : add callback and methods to get the progression of dicomDir
1835 2004-02-06 Jean-Pierre Roux
1836 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1837 - GDCM_META added to gdcmDicomDirType
1838 - class gdcmMeta created
1839 * ENH : - A brief summary is now displayed at the beginning of
1840 'testDicomDir' to help disaster magnitude estimation
1841 * REM : Now useless Test/explDICOMDIR.cxx
1843 2004-02-05 Benoit Regrain
1844 * ENH : add methods in gdcmObject to get the hash table or the list of
1846 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1847 * FIX : wrapping python for TagHeaderEntryHT
1849 2004-02-04 Benoit Regrain
1850 * FIX : even length for some strings when writting the dicom dir
1851 * FIX : sort the images in the dicom dir
1852 * FIX : Bug fix for python use of dicom dir
1853 * ADD : a python demo
1855 2004-02-04 Jean-Pierre Roux
1856 * FIX : Final solution (?) for icone embedded images
1857 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1858 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1859 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1860 gdcmData/gdcm-MR-SIEMENS-16.acr1
1861 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1862 to make full checking easier
1864 2004-02-04 Benoit Regrain
1865 * FIX : WriteEntries : coding style & logic in parameters
1866 * FIX : Set the elements to create the DicomDir in a dictionary file
1868 2004-02-03 Benoit Regrain
1869 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1870 * gdcmDicomDir : add the load of directory
1871 * Bug fix and print add-on
1873 2004-02-03 Jean-Pierre Roux
1874 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1875 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1876 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1877 * FIX gdcmParser.cxx : 'group length' elements are now considered
1878 as integers, even for shadow groups, when file is Implicit VR
1880 2004-02-02 Jean-Pierre Roux
1881 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1883 of the last synonym :-(
1884 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1886 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1887 * FIX taking into account the possible 7fe0,0010 multiplicity
1888 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1889 to allow removal of references to 7fe0,0010, to deal with
1890 ACR-NEMA images, when 0028,0200 is meaningfull
1892 2004-01-31 Jean-Pierre Roux
1893 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1894 no longer writes 'Un' on disk
1895 * FIX SQ elements with actual length are now dealt with corectly
1896 * FIX gdcmFile::WriteBase make the difference, for color images, between
1897 the length (for Palette expanded images)
1898 and Raw Length (non expanded image + Palette)
1899 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1900 (that broke Write). Replaced by UL.
1901 Aware user will reload the field if he
1902 thinks it's necesssary
1904 2004-01-30 Jean-Pierre Roux
1905 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1906 when 'dirty Acr' is found, to be compliant with the new
1907 IsReadable() methods.
1909 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1910 (no DOUBLE images in kosher DICOM,
1911 but so usefull for people that miss them ;-)
1913 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1914 DICOMDIR related utilities (not checked as Windoze compliant)
1916 2004-01-28 Jean-Pierre Roux
1917 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1919 2004-01-27 Jean-Pierre Roux
1920 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1921 to allow skipping the shadow elements, to save memory space.
1922 The TRUE value for this param has to be used
1923 with a FALSE value for the 'enable_sequence' param.
1924 ('public elements' may be embedded in 'shadow Sequences')
1925 * gdcmHeader methods now deal with 'embedded icones images' in the header
1926 (even when an 'icone image sequence' is announced by the
1927 element (0x0088,0x0200), but there is NO icone at all ...
1929 * gdcmHeader sometimes Image Location value doesn't follow
1930 the supposed processor endianity (see gdcmData/cr172241.dcm).
1933 * gdcmHeader add the method
1934 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1935 to get *all* the Header Entries with the same tag.
1936 GetHeaderEntrySameName is probabely *useless*
1937 (no meaning : Name is *not* an identifier within the Dictionary)
1939 2004-01-26 Benoit Regrain
1940 * Bug fix in the print of hexadecimal representations. Remove long fields
1941 in the print and add a third level of print to print them
1943 2004-01-23 Benoit Regrain
1944 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1945 * Bug fix on test suite after remove the strip made on not string fields
1946 * Split the IsReadable method between gdcmParser which test that the file
1947 is dicom and gdcmHeader which test that it's an image file
1949 2004-01-22 Benoit Regrain
1950 * DicomDir : clean code, add methods, set variables in protected or private
1951 * gdcmUtil : bug fix for the clean string method
1953 2004-01-19 Benoit Regrain
1954 * Add the use of shadow dictionaries
1955 * bug fix and coding style
1957 2004-01-19 Benoit Regrain
1958 * src/gdcmFile.cxx : bug fix concerning the close of file
1959 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1960 * Add the update of header entries using the shadow library
1962 2004-01-19 Benoit Regrain
1963 * removal of file gdcmHeader2.cxx
1964 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1965 inheriting from gdcmParser. This split is to prepare the integration
1966 of dicom dir parsing
1967 * bug fix under python
1969 2004-01-16 Jean-Pierre Roux
1970 * REM removal of class gdcmHeaderEntrySet
1971 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1972 * ADD add file gdcmHeader2.cxx
1973 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1975 2004-01-15 Benoit Regrain
1976 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1977 entries created while parsing the header. Thus, they will be destroyed
1978 when the gdcmDictSet will be destroyed
1979 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1982 2004-01-15 Benoit Regrain
1983 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1984 made a fatal error because of the memory release at the end of program.
1985 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1986 some memory and vtk seems to have some problems with that.
1987 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1989 2004-01-14 Benoit Regrain
1990 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1991 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1992 * src/*.[h|cxx] : make changes due to class name changes
1993 * gdcmPython/demo/*.py : bug fix due to method names
1995 2004-01-13 Benoit Regrain
1996 * src/*.[h|cxx] : coding style
1997 * vtk/*.[h|cxx] : coding style
1999 2004-01-13 Benoit Regrain
2000 * gdcmPython/testSuite.py : test the readable flag of file for tests
2001 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2002 It's lied to the stl compilation by MSVC (windows, always windows...)
2003 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2005 2004-01-12 Benoit Regrain
2006 * src/*.h : add comments
2007 * src/gdcmDictSet.h : set the method BuildDictPath in public
2008 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2009 directly setted in the source code
2010 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2013 2004-01-09 Benoit Regrain
2014 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2015 * setup.py : use a reference to gdcmVERSION
2017 2004-01-07 Benoit Regrain
2018 * Modification to compile with the distutils.
2021 2003-12-10 Benoit Regrain
2022 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2023 can use a gdcmHeaderHelper to load data
2024 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2025 made in the source code
2027 2003-12-10 Benoit Regrain
2028 * Update Windows projects and .cvsignore files
2030 2003-11-12 Jean-Pierre Roux
2031 * ENH gdcmHeader constructor has one more parameter (default value : false)
2032 that allows the user to 'go inside' the SeQuences only
2034 gdcmElValSet:Print takes it into account
2036 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2037 * ENH: Update gdcmPython/CMakeLists
2038 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2039 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2041 2003-11-10 Jean-Pierre Roux
2042 * FIX : gdcmHeader::LoadElements is now based
2043 on the ListTag listElem member,
2044 not longer on the TagElValueHT tagHt member
2045 * ENH : PrintPubElVal shows (temporarily) both results,
2046 with the tagHt member and the listElem member.
2047 (it's easier to 'see' the problems when using Printheader)
2049 * FIX : old private member LgrElem is now splitted into
2050 ReadLength : Length actually found on disk (updated only
2051 if bug fixing is necessary), for internal
2053 UsableLength : Updated by FixFoundLength, to fix a bug
2054 or to allow Parser going on.
2055 Will allow to re-write a kosher header when a SeQuence
2056 with a length (not 0000) is found
2057 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2058 because gdcmElValSet::Add does not update ListElem
2061 2003-11-07 Jean-Pierre Roux
2062 * FIX misstyping in Transfert Syntax name table
2063 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2064 when they have an actual length (not 0000 nor FFFFF)
2065 (Nobody should care of it, but DICOMDIR explorers)
2067 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2068 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2070 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2071 * ENH: vtkGdcmReader now supports LUT !
2072 (vtkgdcmViewer for now is not able to use them though)
2074 2003-11-05 Jean-Pierre Roux
2075 * in testSuite.py : new files names for checking the package
2076 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2077 that returns the pixel area size to the *aware* (vtk) user
2078 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2080 2003-11-05 Benoit Regrain
2081 * in testSuite.py : Modify the rules for checking the paths
2082 : Explicit error messages
2083 * in __init__.py : Related modif
2085 2003-11-03 Jean-Pierre Roux
2086 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2087 to be used by aware (vtk) users that want to manage
2088 LUT (and no to turn the PALETTE image into an RGB pixels one)
2089 * GetPixelType now returns 8U for 24 Bits images
2090 (vtkGdcmReader compliant)
2092 2003-10-31 Jean-Pierre Roux
2093 * Removal of *all* gdcmData images and add them again
2094 in order to loose the 'history' of un-anonymised images
2096 2003-10-31 Jean-Pierre Roux
2097 * RMV : removal of useless jBitsInJsample.h
2098 for both 8 and 12 Bits JPEG Lossy Libraries
2100 2003-10-31 Jean-Pierre Roux
2101 * ENH : Add the functions gdcmFile::GetImageDataRaw
2102 gdcmFile::GetImageDataIntoVectorRaw
2103 that act as GetImageData and GetImageDataIntoVector
2104 except the making of an RGB Plane from Gray Plane + LUT
2105 Intended to aware (vtk) users who know how to manage
2108 GetLUTRGBA return a R,G,B,A LUT if any
2109 lgrTotaleRaw gives the 'Raw' length
2110 GetImageDataRaw returns the gray Plane
2111 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2112 (They stay Grey, just like with other Dicom viewers :-(
2114 2003-10-30 Jean-Pierre Roux
2115 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2117 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2118 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2119 being coherents dicom files.
2121 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2122 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2124 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2125 * ENH: Two steps is necessary to please VC++ compiler...
2126 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2127 * ENH: Add include dir to medcon lib
2128 * FIX: only one function is being exported for now !
2129 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2131 2003-10-29 Jean-Pierre Roux
2132 * adding gdcmHeader::GetLUTRGBA
2133 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2134 --> Mathieu, the modif u're waiting for is not yet committed
2135 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2137 2003-10-27 Jean-Pierre Roux
2138 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2139 00191113.dcm DermaColorLossLess.dcm
2140 MxTwinLossLess.dcm RadBWLossLess.dcm
2141 * ENH: For version prior to vtkImageViewer2 -r 1.19
2142 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2144 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2145 * Removal of ido stuff in CMakeLists.txt
2147 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2148 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2149 * FIX: remove a call to ->Modified ... see comments
2150 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2152 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2153 * FIX: Problem with path for libvtkgdcmPython
2154 * ENH: Try adding a search script for python site-package
2155 * RMV: Remove some file from medcon lib that are not necessary
2156 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2157 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2158 * FIX: More pragma disable fro VC++,
2159 I don't think I break something as it is also disable in VTK/ITK.
2160 But it fasten debug compilation time.
2162 2003-10-23 Jean-Pierre Roux
2163 * gdcm now deals with 16 Bits Run Length Encoded images
2164 (they are compressed as 2 planes images,
2165 one for the high Bytes, the other for low Bytes)
2167 2003-10-22 Jean-Pierre Roux
2168 * Now CheckRead takes into account :
2169 - the bugged 'Leonardo' Siemens images
2170 - the XA images, sent thru the burning VPRO station
2171 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2174 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2175 * FIX: When copying a Makefile.am to CMakeLists.txt
2176 one should remove the '\'
2178 2003-10-22 Jean-Pierre Roux
2179 * in gdcmData adding a bugged 'Leonardo' Siemens image
2180 (wrong lengths in header)
2181 OK with gdcm, KO with the other viewers :-)
2182 * add a GE dlx XA image, thru the VEPRO burning station
2185 2003-10-21 Jean-Pierre Roux
2186 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2187 for a brutal checking of vtkgdcmViewer compliance
2189 2003-10-21 Jean-Pierre Roux
2190 * add the files for 'xmedcon' Jpeg Lossless library
2191 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2193 2003-10-21 Jean-Pierre Roux
2194 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2196 2003-10-21 Jean-Pierre Roux
2197 * garbage Siemens 'Leonardo' images dealt with
2198 (the patch is easy to remove)
2199 * cosmetic changes to avoid warnings
2201 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2202 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2203 no need to press 'r' now.
2205 2003-10-20 Jean-Pierre Roux
2206 * upgrade of checkRead.sh checkWrite.sh according
2207 to new Jpeg Lossless decompressor
2208 * add US.3405.1.dcm, a genuine RGB medical file ...
2209 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2210 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2212 2003-10-15 Jean-Pierre Roux
2213 * general anonymisation in gdcmData
2214 * adding the 'color files' from
2215 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2216 * adding some well knowed bugged-header images
2217 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2218 waiting for their inclusion in Python testsuite
2220 2003-10-15 Jean-Pierre Roux
2221 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2222 no longer seg faults when file is not found
2224 2003-10-14 Jean-Pierre Roux
2225 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2228 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2229 * TODO: *.in file to genereate a UseGDCM later
2231 2003-10-14 Jean-Pierre Roux
2232 * Some supposed-to-be Dicom Images have no preamble.
2233 OpenFile takes it into account
2234 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2235 * Missing elements added in dicomV3.dic
2236 (just to be affraid : have a look at
2237 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2238 and do it again next year ;->
2240 2003-10-13 Jean-Pierre Roux
2241 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2242 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2243 But there are NOT. It's fixed !
2245 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2246 * FIX: "jpeglib.h" was not found on VC++
2247 * FIX: vtkgdcm was not being installed
2249 2003-10-10 Jean-Pierre Roux
2250 * ENH : OpenFile closes the file if it *really* doesn't look like
2251 an ACR-NEMA / DICOM one.
2252 * FIX : testWrite no longer writes an empty file if the source file
2253 is not gdcm Readable
2254 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2257 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2258 * FIX: CMake generate now documentation
2259 * ENH: out of source doc build !
2260 * ENH: Generate both user and dev documentation
2261 * ENH: Should work on windows too
2262 * ENH: Only one doxygen config.in file is needed
2263 * FIX: make install should be ok now on ùnix plateform
2264 * FIX: PATH to dictionary was wrong (missing /)
2265 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2267 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2268 * vtkGdcmReader is now able to read rgb dicom file.
2269 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2270 * added a gdcmViewer to vtk test, use mouse to control
2271 window level & window width
2273 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2274 * CMake-ification of gdcm, we have now two build system
2275 * FIX: on cygwin Wsock32 doesn't exist
2276 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2278 2003-10-06 Emanuel Ollart
2279 * FIX : compilation process wad broken.
2280 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2282 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2283 * change gdcmViewer -> vtkgdcmViewer
2284 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2286 2003-10-06 Jean-Pierre Roux
2287 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2288 ( e.g : well known GE images with a wrong elem length,
2289 : Philips MRI Images with a wrong Huffman table)
2290 * still to be done : allow the reading of bugged LEONARDO Siemens images
2292 2003-10-03 Jean-Pierre Roux
2293 * Odd length strings are padded with '\0' (not with spaces,
2294 to remain compliant with already defined strings,
2295 like Transfert Syntax UID and others)
2297 2003-10-03 Jean-Pierre Roux
2298 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2299 to allow displaying RGB images (not only by affim ;-)
2301 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2302 * vtkGdcmReader is now able to read rgb dicom file.
2303 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2305 2003-10-03 Jean-Pierre Roux
2306 * A few nasty patches to allow the reading of a lot of nasty images
2307 ( e.g : well known GE images with a wrong elem length,
2308 : Philips MRI Images with a wrong Huffman table)
2309 * still to be done : allow the reading of bugged LEONARDO Siemens images
2311 2003-10-03 Jean-Pierre Roux
2312 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2314 2003-10-03 Jean-Pierre Roux
2315 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2316 to allow displaying RGB images (not only by affim ;-)
2318 2003-10-03 Jean-Pierre Roux
2319 * gdcmFile::GetImageDataIntoVector now
2320 - deals with MultiFrames MultiFragments Run Length Encoded files
2321 - deals with YcBcR (YBR_FULL) files
2322 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2323 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2325 (no sample found :-(
2327 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2328 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2329 Two reasons: - clear things
2330 - third parties acces gdcm through header files, so won't
2331 suffer anymore VC++ complains
2333 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2334 * add argv[1] in testvtkGdcmReader.cxx
2337 2003-09-24 Jean-Pierre Roux
2338 * The lines are now eigthy characters long.for
2339 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2341 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2342 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2343 char* to std::string. Thus, the use of strdup becomes useless. (see
2344 previous commis of Malaterre)
2345 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2346 before the last Malaterre's commit.
2348 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2349 * This commit should fix the Debug building under VC++, the problem
2350 was mainly a mixture of debug and release lib being loaded at startup.
2351 * I also remove a depency to a specific C function: strdup. Because I had
2352 to force the link to msvcrtd (whereas strdup is in libc).
2354 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2355 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2356 located in the gdcmCommon.h file. All use of reference of tha has been
2357 changed to now use the variable GDCM_UNFOUND.
2359 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2361 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2362 Dicom dictionary. The test suite can now be run again. Note:
2363 I'm note very happy with the " (RET)" changes. I believe this
2364 RETAINED comment should be dropped when parsing the dictionary.
2365 - PACKAGER corrected
2367 - AUTHORS updated and now in alphabetical order
2368 * Makefile.am now exports gdcm.dsw for Windoze users.
2370 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2371 * cygwin complains about missing std:: in subdir Test/
2373 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2374 * remove some methods that are now in gdcmHeaderHelper
2376 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2377 * vtkGdcmReader set spacing and origin correctly
2379 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2380 * Fix a few delete/delete[] mismatch
2382 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2383 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2384 interpretation to data given by gdcmHeader. For instance there are
2385 heuristics to get informations (look at different places).
2386 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2387 sorting DICOM images based on different strategies.
2388 * modified Makefiles accordingly.
2390 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2391 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2392 when building in debug mode
2393 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2394 src/win32/gdcmdll.dsp
2395 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2397 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2398 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2401 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2402 * src/win32/libgdcmjpeg12.dsp was not dos format
2403 * src/win32/libgdcmjpeg12.dsp :
2404 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2405 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2407 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2408 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2410 * src/gdcmFile.cxx : bug fix in affectation type
2411 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2412 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2413 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2414 symbols... future problem ?
2416 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2417 * src/win32/libgdcmijpeg12.dsp was missing
2418 * modified gdcm.dsw accordingly
2420 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2421 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2423 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2424 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2425 commit of JPR (before his hollidays to facilitate our work).
2426 * setup.py : bug fix in code. Modifications made while the last commit
2427 of JPR. The code hasn't been tested before the commit... it's so
2428 useless to make that (for best programmer that is JPR) !!!
2430 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2431 * tagged the current version as Version0_3 (i.e. version 0.3)
2433 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2434 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2435 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2436 * *.dsp : modifications to use new libgdcmijpeg8 library
2437 * setup.py : bug fix on VTKPATH variable
2438 * PACKAGER : adding all concerning windows
2440 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2441 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2443 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2444 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2445 test suite reported error.
2446 * PACKAGER file added (describes what a packager must do when
2447 packaging a new release).
2448 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2449 * configure.in: upgraded version number to 0.3.0
2450 * fixing build of rpm (through rpm -ta):
2451 - Doc/Makefile.am exports proper doxygen files
2452 - src/jpeg/libijg8/Makefile.am exports the include files.
2454 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2455 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2456 * src/gdcmHeader.h : formatting code
2458 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2459 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2460 We were obtaining error message from vtk. Now, creation of file list
2461 is made in an internal list to prevent this problem.
2462 Bug fix when output is empty.
2463 Bug fix in update of progress value. Previous commit for this was a bad
2465 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2467 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2468 * src/gdcmHeader.h : added method to get the file name
2469 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2470 files. Added method to remove all files on the input
2471 Added FIXME comment concerning the bad parsing of header made by
2472 ExecuteInformation method (in ExecuteData method)
2474 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2475 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2476 when using make instal.
2477 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2478 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2480 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2481 * setup.py : adding include dir of jpeg lib to compile all sources
2482 * */Win32/*.dsp : JPR fix for windows compilation
2484 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2485 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2487 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2488 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2490 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2491 * setup.py is again effective on un*x (takes into account the
2492 addon of the jpeg library)
2493 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2494 * Doc/Doxy* updated (includes above enhancements)
2495 * INSTALL now points to web documentation
2497 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2498 * src/gdcmHeader.h doesn't make unnecessary reference to
2500 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2502 * src/gdcm*.[cxx|h] :
2503 - to allow compilation with gcc 3.x
2504 -- clean up of STL usage (added explicit usage of std::)
2505 -- small fixes on exceptions.
2506 Note: linking not tested !
2507 - clean of doxygen comments to avoid warnings at documentation
2509 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2510 dependent convertion).
2512 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2513 * Clean up of previous JPR garbage commit (not even commented in the
2515 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2516 - moved all jpeg related files from src to src/jpeg/libijg8, with
2517 addition/modification of Makefile.am and configure.in.
2518 - the testSuite is still brain damage (not guilty).
2520 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2521 * WrapVTK.py : modifications to get correctly vtk source files to
2523 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2524 (FileName -> Filename)
2526 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2527 * vtk/vtkGdcmReader.[cxx/h]:
2528 - UpdateProgress method should now be effective
2529 - removed the limitation on having only images loaded (as opposed
2531 - when building a stack of images/volume, a lesser number of
2532 gdcmHeader and gdcmFile instances should be used (hopefully
2533 accelerating things).
2534 - when building a stack of images/volumes, files which are not
2535 loadable (wrong path-filename, wrong permissions on existing file,
2536 or file not parsable by gdcm) are replaced with a black image
2537 in the stack (for the caller to notice the problem).
2539 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2540 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2542 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2543 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2544 between standard library (std) and vtk library (problems are found
2545 under Windows... thanks Windows !)
2547 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2548 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2550 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2552 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2553 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2555 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2556 * When compiling with distutils (see setup.py) the C++ compiler is
2557 called with different flags than the default ones (with automake).
2558 In order to fix all those warning, I compiled gdcm with the command
2559 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2560 and went for warning fixes:
2561 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2562 up from unused variables.
2563 - vtk/vtkGdcmReader.cxx: potential bug fix.
2564 * src/gdcmHeader.h: Doxygen warning cleanup
2566 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2567 * gdcmPython/gdcm.i:
2568 - typemaps correction to take into account the systematic replacement
2569 of "using namespace std" with std:: prefix e.g. std::list,
2570 std::string... (cf changes of 2003-05-21).
2571 - gdcmGlob global variable of type gdcmGlobal (defined in
2572 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2573 exported to Python a as cvar.
2574 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2575 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2576 gdcmDictSet.GetPubDictTagNames() and
2577 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2578 C++ static methods).
2579 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2580 with the above changes.
2582 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2583 * setup.py, manifest.in : bug fix under linux
2585 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2586 * Modification of setup.py to compile vtk part too. Then, we have 2
2587 wrappers which must work with same distutils. For that, we have a
2588 generic distutils in distusiltsWrapping.py ; with :
2589 - build_extWrap class to wrap generically all extensions,
2590 - ExtensionWrap base class for all wrapping extension that contains
2592 - Wrapper interface which wrap sources
2593 + In WrapSwig.py we have extension and wrapper for Swig
2594 + In WrapVTK.py we have extension and wrapper for VTK
2595 * MANIFEST.in : modifications to consider vtk directory and new python
2596 files for compilation
2598 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2599 * Added python wrappers of vtkGdcmReader vtk class (see the
2600 source in vtk/vtkGdcmReader.cxx) :
2601 - vtk/Makefile.am now builds a library
2602 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2603 python library (as opposed to _gdcm.so wich are the python
2604 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2605 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2607 - configure.in has an additional flag --enable-vtk that needs
2608 to be set to enable compilation of vtk related code, that is:
2609 + vtk/vtkGdcmReader.so and
2610 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2611 + gdcmPython/vtkgdcmPython.so (see above)
2612 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2613 be read when compressed or when HighBit + 1 != BitsStored),
2614 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2615 the usage of the python wrapper of vtkGdcmReader vtk class.
2616 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2617 * src/*.[h] all occurences of stl classes are now prefixed with
2618 std::, and all occurences of "using namespace std;" where removed.
2619 This is to avoid pollution of global namespace in included files.
2620 Apparently vtk does not avoid this pitfall: when using both
2621 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2622 collision of various stl members (principally cout...).
2623 * gdcmPython/testSuite.py now cleanly removes temprory generated
2625 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2626 comply with above changes)
2628 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2629 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2630 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2631 vtk data structure (an image Flip was required).
2632 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2633 * cosmetic changes in documentation.
2635 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2636 * src/gdcmHeader.cxx: the constructor no longer exits when an
2637 unexisting file is given as argument.
2638 * The subdirectory Data (containing all the images used for the
2639 test suite) is not part of this repository anymore. A new module
2640 containing those images is now available at
2641 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2642 with the name gdcmData.
2643 All the python scripts (including the package initialisation file
2644 gdcmPython/__init__.py) were adapated to take this change into
2645 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2647 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2648 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2649 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2650 demo of the usage of this class.
2651 Compilation of this vtk part is only done when using the --enable-vtk
2652 at configure (or autogen.sh) stage.
2654 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2655 * More memory link related corrections and documentation fixes.
2657 - maximum info is obtained with a command of the form:
2658 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2659 --show-reachable=yes PrintHeader
2660 - the remaining reachable blocks seem to come from the STL
2661 allocation scheme through the usage of map and list. It looks
2662 like this memory cannot be freed but it is not a memory leak
2663 (in fact further invocation to the STL would recollect the
2664 unused memory allthough it cannot explicitely be freed).
2665 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2666 of displaying an image parsed with gdcm and displayed with VTK.
2667 Note: some images don't seem to work e.g.
2668 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2669 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2670 Allthough this weakens the semantics, it is a ditch attempt to
2671 make gdcm more thread friendly.
2673 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2674 * Memory link hunt (by using valgrind through the command
2675 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2676 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2677 gdcmHeader::_dicom_vr.
2678 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2679 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2681 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2683 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2684 * src/Makefile.am now exports all the necessary include files at
2688 * UpdateGroupLength replaced by new one
2691 * UpdateGroupLength re-written using H-Table
2692 (named UpdateGroupLengthNew untill checks are over)
2694 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2695 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2696 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2698 - gdcmHeader::GetPubElValSet removed.
2699 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2700 UpdateGroupLength, WriteElements, Write.
2701 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2702 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2703 carried the same semantics.
2704 - src/gdcmHeaderIdo.cxx changed accordingly.
2705 - gdcmFile::WriteBase now regroups all the codes from previous
2706 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2707 - enum FileType moved to gdcmCommon.h
2708 * src/gdcmHeader.cxx AddDefault trashed
2709 * gdcmGetXSize added
2710 * getimageDataSize now calls gdcmGetXSize
2711 * Test/*.cxx changed to agree with above changes
2713 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2714 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2715 (to avoid double call by end user).
2716 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2717 by end user, since gdcmHeader::gdcmHeader now handles it.
2719 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2720 * gdcm/Doc many doxygen changes:
2721 - Doxyfile now has two different versions, DoxyfileUsers that generates
2722 the html.users end users oriented documentation and
2723 DoxyfileDeveloppers that generates the html.developper developper
2724 oriented documentation.
2725 - README changed accordingly
2726 - requirement.txt removed (old design info moved to TODO).
2727 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2728 DoxyMainPage.txt, DoxyPython.txt provide more information.
2729 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2730 be updated by simply regenerating the docs with doxygen and copying
2731 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2732 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2733 all the tests in the form "if (<map>.count() >1)" were removed.
2734 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2735 ill-formed documentation sections.
2736 * src/gdcmHeader.cxx: ditto
2738 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2739 * setup.py fixed for un*x (needed macro for stdint.h)
2740 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2741 un*ces with sh-utils test utility.
2742 * gdcmPython/demo/test.py renamed to PrintHeader.py
2743 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2744 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2745 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2746 * src/gdcm*.cxx JPR's bad inclusion fixed.
2748 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2749 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2750 * gdcmPython/demo/test.py changed accordingly.
2752 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2753 * gdcmPython/Makefile.am fixed linking against libstdc++
2754 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2755 * Swig subdir (historical tests of swig version 1.3.17++) removed
2756 * Test/testChangeEntete.cxx some lines commented out in order to make
2758 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2759 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2761 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2762 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2763 hence the user doesn't need this explicit call.
2764 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2765 i.e. LoadElements() call removed.
2766 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2767 - src/Makefile.am declares the proper flag for g++.
2768 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2769 for adding user defined new tags.
2770 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2771 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2772 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2774 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2775 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2776 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2777 src/Makefile.am : the project should properly compile and install
2778 with the autotools, included the python wrappers part.
2779 * gdcm.spec.in : added a spec file for RPM packaging.
2781 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2782 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2784 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2785 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2786 to exported to the environement (see gdcmPython/testSuite.py
2788 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2789 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2790 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2791 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2792 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2794 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2795 * gdcmPython/__init__.py doesn't crash anymore when running in
2796 in InstallMode or PreInstallMode but with an environment given
2797 value of GDCM_DICT_PATH.
2798 * src/gdcmDictSet.[cxx/h] coding style.
2800 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2801 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2802 * src/gdcm.h general comments moved to TODO, and README
2803 * src/gdcm.h should now be seen as a user commodity (including it
2804 should suffice to fully use gdcm). It is nowhere including within
2805 any of the kernel files src/*.cxx and src/*.h.
2807 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2808 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2809 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2811 * src/gdcm*.cxx only include their corresponding include file
2812 (as opposed to gdcm.h)
2813 * gdcmPython/gdcm.i changed accordingly
2814 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2815 the autogen.sh generated "make snapshot" command to work.
2816 * autogen.sh removed history related references to crea package.
2818 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2819 * distutilsSwigCPlusPlus.py work around some swig portability
2822 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2823 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2824 was done in a last ditch attempt to get setup.py _really_
2825 operationnal. The python/gdcmPython layaout add the advantage
2826 of hidding away the python related distutils specific files
2827 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2828 Alas, the src directory was out of scope (i.e. it's relative
2829 position to setup.py was ../src) which made things impossible to
2830 handle (see previous version of python/setup.py). Crossing fingers...
2832 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2833 * python/setup.py now works on Un*x. (harder than I thougth)
2834 * python/distutilsSwigCPlusPlus.py can now have include files
2835 among the list of sources.
2837 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2838 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2839 * modifications in MSVC projects
2841 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2842 * As stated by the first lines of Test/ExceptionAndPython/README, it
2843 looks like we can move back to original usage of exception within
2844 src/gdcm* and hence remove the errno stuff that was introduced
2845 as a quick and dirty fixture of this problem (added to the TODO).
2846 * Doc/Doxyfile configuration file for Doxygen and corresponding
2847 README file for usage added.
2848 * Test/testWrite.cxx added. This new test comes from a split of
2849 test.cxx that is now reverted to its original purpous i.e.
2850 testing the proper parsing of a Dicom related file.
2851 testWrite.cxx concentrates on testing the IO part of gdcm.
2852 * Test/bug1.cxx (containing a bug on WIn32) added.
2853 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2854 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2855 whose purpose is to publish the content of the TagNames of the
2856 Dicom public dictionary were not accessible without an
2857 instance of class gdcmHeader.
2858 - those methods are now static methods of gdcmDictSet and hence
2859 require no instances at all to be invocated.
2860 - within gdcmDictSet this change required to change some method
2861 to class methods (i.e. are now static) among which SetDictPath
2862 (renamed to BuildDictPath) and LoadDefaultPubDict.
2863 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2864 the above changes by calling the new method classes of gdcmDictSet.
2865 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2866 the above to be effective.
2867 * python/gdcmPython: in order to wrap properly the above changes
2868 for Python, swig version now needs to be > 1.3.17.
2869 * python/gdcmPython/Makefile fixed to adapt itself to new
2870 configure/make shema introduced by Johan Montagnat (thanks for the
2871 contribution). Alas this Makefile cannot be turned into a proper
2872 Makefile.am without some heavy changes in the configure.in
2873 (for python dectection).
2874 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2875 now avoids publishing the empty entries.
2877 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2878 * python/setup.py : bug fix concerning install under windows
2879 ExtraPath reused :-P
2880 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2882 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2883 * Dicts/dicomV3.dic : remove double spaces !!!
2884 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2885 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2888 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2889 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2890 method. Doxygenation.
2891 * src/gdcm.h clean up of JPR spurious comments.
2893 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2894 * python/distutilsSwigCPlusPlus.py now properly collects the
2895 shadow classes generated by "swig -c++" (gdcm.py in our case)
2896 when using "python setup.py install".
2897 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2898 reexports the working classes.
2899 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2900 by the classical C errno scheme. This is to prevent an obscure
2901 behavior of the python wrappers when importing wxPython.wx prior
2902 to gdcmPython (which ended up in an abort call). An illustration
2903 of this oddity can be found in the Test/ExceptionAndPython
2904 subdir (see the README file). This problem probably due to
2905 an combination of g++ and dynamic loading.
2906 * added Test/ExceptionAndPython (see above)
2908 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2909 * Changed the layout of the python part to avoid bloating main
2910 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2911 i.e. the distutils arsenal. All the python related stuff is
2912 again in a python subdir, but the package itself is now in
2914 * setup.py was cleaned up:
2915 - pythonIncludePath removed
2916 - python setup.py bdist target is now functional.
2917 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2918 collision with other packages). gdcmPython/demo/*.py changed
2921 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2922 * python subdir moved to gdcmPython (preparation of distutils packaging).
2923 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2924 distutils installer is operational.
2925 * - gdcmPython/__init__.py now properly loads the swig generated
2926 shadow classes (from gdcm.py).
2927 - gdcmPython/demo/*.py changed to import the package gdcmPython
2928 instead of gdcmPython/demo/load.py.
2929 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2931 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2932 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2933 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2934 entries within the associated public Dicom dictionary resp. the same
2935 information but sorted by the fourth field (PAT, IMG, DIR) of the
2937 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2938 are now in the "???" group.
2939 - python/gdcm.i changed accordingly,
2940 - python/demo/printGroupedPublicDict.py added, that gives an example
2941 of the above new functionalities in Python.
2943 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2944 * src/gdcm.h, gdcmHeader.cxx:
2945 - historic references to glib's g_malloc and g_free (#defined)
2946 were definitively removed.
2947 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2948 * src/gdcmElValSet.cxx:
2949 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2950 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2951 - GetElValue(string) renamed to GetElValueByName.
2952 - Added GetElementByName(string).
2953 * src/gdcmHeader.cxx: added
2954 - GetPubElValRepByNumber(guint16, guint16)
2955 - GetPubElValRepByName(string)
2956 - GetShaElValRepByNumber(guint16, guint16)
2957 - GetShaElValRepByName(string)
2958 - GetShaElValByNumber(guint16, guint16)
2959 - GetShaElValRepByName(string)
2960 - GetElValRepByNumber(guint16, guint16)
2961 - GetElValRepByName(string)
2962 - GetElValByNumber(guint16, guint16)
2963 - GetElValRepByName(string)
2964 * Doc/requirements.txt added.
2966 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2967 * Test/Makefile building now depends on the one of libgdcm.so
2968 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2969 pixel data) aware which enables finding the address (offset) of
2970 the pixel data of JPEG encoded DICOM files. This leaves only a single
2971 file in the testSuite whose pixel data address (offset) is unknown.
2972 * python/testSuite.py changed accordingly.
2974 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2975 * VC++ has some strong limitations when working with the STL, as stated
2976 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2977 "Also note that some STL containers (map, set, queue, list, deque)
2978 cannot be exported. [...]
2979 Some STL classes contain nested classes. These classes can not
2981 This is caused by a designed limitation that once a template
2982 class is instantiated, it can not be re-instantiated and
2984 Since our usage of map<> is ubiquitous in gdcm, this "designed
2985 limitation" of VC++ is a pitfall.
2986 Hence the Python wrappers of gdcm cannot be incrementally linked
2987 against the c++ dynamic library. The dirty but only workaround is
2988 to forget about incremental link of dynamic libraries and to generate
2989 the Python wrappers library with the inclusions of the underlying C++
2991 The following modifications concern this matter on Win32/VC++:
2992 - wrapping python correct with standalone wrapped dll (don't use separate
2993 dll under windows !!!!)
2994 - python21_d debug mode enabled (ask Frog how to use it :-)
2995 - NO problem with having an STL member of class for example string in C++
2996 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2997 - Python test of dcmlib in Python is ok under windows on a large set
2999 * removed glib references
3000 * typedef's inserted in gdcm.i for correct swig type management
3002 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3003 * python/demo/*.py load.py extracted from test.py. Added explore.py
3004 that only displays required tags and testAll.py that parses all
3005 the files of the testsuite without using unittest.
3006 * python/testSuite.py other additional test on new files added.
3007 * Data/* new test files added accordingly to the testSuite.
3008 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3009 the vr in the file differs from the one of the dictionary.
3011 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3012 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3013 values, but limits itself to values which are below a user specified
3014 size (by default 1024 bytes).
3015 * python/gdcm.i : elements not loaded (because their size is above the
3016 user specified treshold) are exported with their TagKey as key of the
3017 python dictionary. This enables the testsuite to make some checks
3018 on the unloaded elements (since we have their offset and size).
3019 * python/testSuite.py
3020 - now tests for the existence and proper value of the pixel data
3021 - two new examples added.
3022 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3024 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3025 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3026 aware. See the strategy comments in gdcmHeader::FindeLength().
3027 * Test/test.cxx now accepts a filename as first argument.
3028 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3029 * python/testSuite.py changed to integrate test on above files.
3031 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3032 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3033 the vr was also RET.
3034 * python/testSuite.py more tests added.
3036 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3037 * python/testSuite.py unittest test suite added (uses Data)
3038 * Data/* dcm and acr files for the test suite.
3039 * glib dependance removed from un*x version. We now use ISO C99
3040 7.18 Integer types (see stdint.h)
3041 - python/Makefile, src/Makefile src/gdcm.h
3042 * src/ when an explicit vr (like dicom files) suddenly poped an
3043 implicit element we use to mark the underlying DictEntry of the
3044 concerned ElValue with "Implicit". This strategy was damageable
3045 too the public or provite dictionaries, since some of their vr
3046 would be changed. Since Header::FindLength heavily relies on the
3047 detection by Header::FindVR of falsely explicit elements, I
3048 added an extra ImplicitVr member to ElValue (boolean).
3049 The rest of the changes we the necessary adaptations.
3051 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3052 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3054 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3056 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3057 * Adaptation for porting to VC++:
3059 o forced to use std namespace (for string to be known)
3060 o all class use __declspec export style on WIN32
3061 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3062 (in stdlib.h on Win32 but in std:: for gcc)
3063 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3064 variable GDCM_DICT_PATH.
3065 * src/gdcmHeader.cxx verbose comments made discrete.
3067 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3068 * python/gdcm.i: added a typemap that converts a C++ hashing table
3069 to native Python dictionary.
3070 * python/demo/test.py:
3071 - now uses the native dictionary for exploration of gdcmHeader.
3072 - takes an optional filename argument (the file to parse).
3073 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3074 PubElVals hashing table.
3075 * Dicts/dicomV3.dic removed error prone trailing spaces.
3077 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3078 * Python wrapping process moved away from src/Makefile to
3079 newly created python/Makefile (as well as gdcm.i)
3080 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3081 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3082 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3083 from the environement variable GDCM_DICT_PATH (when existing).
3084 * src/gdcmDict::GetTag bug fix.
3086 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3087 * Straightforward temporary fixes for swig to build the python wrappers.
3088 src/Makefile now has a python working entry [by working we mean
3089 that we can import de shadow classes without errors].
3091 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3092 * hashtest.cxx removed (since already in Test)
3093 * src/gdcmlib.h renamed to src/gdcm.h
3094 * src/dcm.i renamed to src/gdcm.i
3095 * src/Makefile prepared for python wrapping
3097 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3098 * src/gdcmHeader.cxx :
3099 - Parsing of header is now separated from loading of element values
3100 (see gdcmHeader::LoadElements).
3101 - general clean up of hopefully all file access (creation of
3102 ReadInt16 and ReadInt32)
3104 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3105 * src/gdcmHeader.cxx :
3106 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3108 - SetLgrElem renamed to SetLength
3109 - GetLgrElem renamed to GetLength
3110 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3111 * src/gdcmElValSet.cxx fixed both GetElValue methods
3112 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3113 due to IdoDude was cleaned out.
3115 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3116 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3117 concentrates on finding the value representation (when it exists).
3118 RecupLgr now only finds the element value length, and it avoids
3119 returning the unecessary skL (skipped length).
3120 Also, offsetCourant was simply removed (with taille_fich) since
3121 it was redundant with the File position internals (by using
3122 ftell and fseek). This also made skL (see above in RecupLgr) usage
3124 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3125 on the libido specificities which are handled through class
3127 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3130 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3131 * Truckload of changes. Parsing of header is barely functional
3132 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3134 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3135 * src/gdcmHeader.cxx many addons of low level methods
3137 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3138 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3139 and _IdDcmSWAP_LONG.
3141 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3142 * This corresponds to all the changes decided at the meeting of
3143 May 23 2002. Needless to say we are running late...