1 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
3 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
4 * CLEANUP_ROUND (13) for gdcmPixelConvert
5 Substituted File::ParsePixelData() with PixelConvert::Print() new
7 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
8 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
9 method to those classes.
10 - src/gdcmFile.[cxx|h]:
11 -- Added a ::Print() method.
12 -- PixelConverter is now a reference instead of a member.
13 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
14 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
16 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
17 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
18 collaboration diagram and inheritance diagram should be generated with
20 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
21 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
22 pointlessly wrapped (see
23 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
24 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
25 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
26 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
27 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
28 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
29 -- File::Initialise: PixelConverter setup moved away to
30 PixelConverter::GrabInformationsFromHeader()
31 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
32 interpretation moved away to PixelConverter::BuildRGBImage()
34 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
35 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
36 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
38 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
39 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
40 displayed on Win32 when a brutal abort() occurs (because of uncatched
41 exception). See TODO new entry of this commit for more on this.
42 * TODO added new entry.
43 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
44 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
45 - HandleColor is no longer called from gdcmFile.cxx
46 - gdcmPixelConvert.cxx clean up on method arguments and internal
47 variable names for semantical coherence.
49 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
50 * Finished lossless transition, not only do we now read all lossless jpeg
51 images, without the need of the Cornwell lib, but we do read them properly now
52 * To reduce code (well to avoid code duplication), I defined a common place
53 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
54 redefine symbols. This is not prefect but this the best solution I found for a
55 compilation time jpeg option.
57 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
58 * Update jpeg ijg lib to support lossless jpeg implementation
59 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
61 * Also added a special copyright for dcmtk since we use their bugfixes.
64 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
65 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
66 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
67 matters, as stated in warning note at begining of %include section).
68 * src/gdcmDicomDir*.[cxx|h]: coding style
69 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
70 * src/gdcmJpeg8.cxx: doxygen fix.
71 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
72 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
73 from File:: to PixelConvert::.
75 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
76 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
77 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
78 - more code moved away from File:: to PixelConvert::
79 - fat setup of PixelConverter set in place in File::Initialise.
81 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
82 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
83 namespace at the file system level. So now you should convert your examples
85 gdcmHeader -> gdcm::Header
86 It would be nice if people keep in mind to no open the namespace, since it
87 allows compilation on broken plateform which were defining common symbol in
88 the standart namespace (like LP, Unknown ...)
90 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
91 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
92 The JPEG fragments are now parsed at the same stage than the RLE
93 information. All code related to JPEG is now in gdcmPixelConvert:
94 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
95 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
96 export a gdcmFile:: method. Those are simply global functions
97 (for the time being this is better than having them attach to
98 either gdcmFile:: or gdcmPixelConvert::).
99 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
100 and stores the result in a gdcmJPEGFragmentsInfo.
101 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
102 code (among other stuff) moved away from gdcmFile:; to
105 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
106 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
107 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
108 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
109 clean up of RLE related code.
110 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
111 - src/gdcmRLE.cxx removed
112 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
113 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
114 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
115 * CLEANUP_ROUND (9) for gdcmPixelConvert
116 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
117 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
118 away from gdcmFile:: to gdcmPixelConvert::.
120 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
121 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
122 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
123 This is because Parse7Fe0 used to parse the pixels to compute the
124 length. This task was passed over to FindDocEntryLengthOB() a long
125 time ago, EXCEPT I had forgotten the OW case...
126 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
127 we just recylce the code for parsing RLE fragments and computing
129 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
130 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
131 with the retired Parse7Fe0().
132 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
133 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
135 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
136 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
137 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
138 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
139 - src/CMakeLists.txt: alphabetic order reodering + new entries.
140 * CLEANUP_ROUND (4) for gdcmPixelConvert
141 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
142 to return an unused length.
144 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
145 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
146 this should be cleanner from the plane view. The iostream are erally a pain
147 to use to do simple stuff.
149 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
150 * Redo the compilation of the ijg jpeg library. Now only one source is
151 necesseray. No need to rename file by hand what so ever. CMake handle the
152 copying of the file within different directory, configure header file to
153 modify some symbol. The only addition made to ijg wasd a mangle table so
154 that symbol are different wether we are within 8bits or 12bits.
156 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
157 * Added documentation of vtkgdcmReader on Website:
158 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
159 with it's binary name).
160 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
161 the Website to be more complete.
162 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
163 doxygenated documentation.
164 - Doc/DoxyVtkGdcmReaderExamples.txt added
165 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
166 DoxyVtkGdmReaderExamples.html )
167 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
168 * CLEANUP_ROUND (3) for gdcmPixelConvert
169 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
171 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
172 * CLEANUP_ROUND (2) for gdcmPixelConvert
173 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
175 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
176 * CLEANUP_ROUND for gdcmPixelConvert:
177 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
178 - src/gdcmPixelStuff[h|cxx] removed
179 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
180 - src/CMakeLists.txt changed accordingly
182 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
183 gdcmVersion.py moved to newly created ATTIC related
184 gdcmPython/SetupOldies/ directory.
185 * Autotools clean up:
186 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
187 - autogen.sh configure.in acinclude.m4 python.m4 removed
189 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
190 * src/*.cxx *.h Reference to License.htm fixed to License.html.
191 * Doc/CMakeLists.txt, doxygen.config.in: fix.
192 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
194 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
195 * TODO updated with Mathieu suggestions. I proposed a template for
196 describing TODO entries and used it for new entries.
197 * Added Doc/Website/CodingStyle.html, Developpers.html,
198 DeveloppersPython.html, GdcmDataCvs.html and
199 DownloadVersion0_1.html, DownloadVersion0_3.html.
200 * Some Doc/*.txt Doxygen files (which do not really concern the
201 documentation itself, but the website) moved to html and
202 placed in directory Doc/Website:
203 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
204 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
205 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
206 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
207 * CMakeLists.txt changed accordingly.
208 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
209 DeveloppersPython.html
210 * INSTALL nows refers to Doc/Website/Installation.html
212 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
213 * Added Doc/Website directory, that contains a first raw version
216 2004-09-23 Jean-Pierre Roux
217 * FIX In order not to be poluted any longer by casting problems,
218 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
219 we can now delete[] it safely
220 * VoidArea is now called BinArea (less confusing name),
221 and all the methods called ...VoidArea... are now ... BinArea...
222 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
224 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
225 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
226 clear) TagHT, which is an inherited member of gdcmElementSet. It is
227 up to the destructor of gdcmElementSet to clean up TagHt and it's
230 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
231 * Test/CMakeLists.txt: update to follow gdcmData renamings.
232 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
234 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
235 * ENH: added some utility method that builds a flat dictionnary
236 holding all the Dicom entries contained in the recursive structure
237 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
239 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
240 BuildFlatHashTable() that build a flat dictionary.
241 - src/gdcmElementSet.h: added a new private GetTag() accessor.
242 gdcmDocument is now a friend of gdcmElementSet.
243 - src/gdcmElementSet.cxx: clean up.
244 - Example/FlatHashTablePrint.cxx added.
245 - Example/CmakeLists.txt changed accordingly
247 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
248 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
249 moved away from gdcmDocEntrySet (since this class is an abstract class
250 acting like an interface). SQDepthLevel and BaseTagKey are now
252 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
253 and associated accessors. Doxygenation of the class.
254 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
256 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
257 Use SQDepthLevel accessor instead. ::Print() adapted.
258 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
259 - src/gdcmDocument.cxx changed accordingly.
261 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
262 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
263 - The following is the doxygen comment of the typedef declaration
264 of gdcmagKey in src/gdcmCommon.h:
265 gdcmTagKey is made to old an "universal" (as in URL, Universal
266 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
267 A dicom tag allways has a group and an element, but a set of tags
268 embeded in various (optionally nested) sequences and sharing
269 the same group and element all share the same (group, element)
270 "identifier". Hence the (group, element) cannot be used as an
271 identifier (in gdcm we shall refer to a "TagKey") of a tag.
272 In order to construct a proper tag identifier (i.e. a key) we
273 consider the following definition of a TagKey:
274 - let Group, Element be the string representation of the
275 group and element dicom tag members,
276 - let ItemNumber be the string representation of the integer
277 index of the considered item number of a sequence,
278 Let the key of a tag embeded in a sequence, noted SeqTag, be
280 /ItemNumber#Group|Element
281 where "/", "#" and "|" are characters acting as separators.
282 Then the general form of a gdcmTagKey is given by:
283 Group|Element<SeqTag>
284 where <SeqTag> means NO or many instances of SeqTag.
285 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
288 but the gdcmTagKey of a tag "embeded" is the first item of
289 a sequence, itself nested in the third item of a sequence is the
291 0004|1220/2#0008|0082/0#0008|0090
292 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
293 order to hold the new sequence compatible key. Previously, the
294 GetKey() method would look in the underlying gdcmDictEntry.
295 - src/gdcmDocEntry.cxx:
296 -- constructor now copies the underlying DictEntry key, in the local
298 -- ::Print: displays the member Key, instead of the (group, element).
299 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
300 - src/gdcmDocEntrySet.h:xi
301 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
302 -- now has a new BaseTagKey member.
304 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
305 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
307 This poses the problem with the semantics of the following lines
308 LoadEntryVoidArea(0x0028,0x1201); // R LUT
309 LoadEntryVoidArea(0x0028,0x1202); // G LUT
310 LoadEntryVoidArea(0x0028,0x1203); // B LUT
311 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
312 to the long FIXME note for what the problem is. Nevertheless in
313 order to get things working the dicom dictionary was altered !
314 Please fix things urgently...
315 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
316 information), see above note on moving the member VoidArea. Nevertheless
317 the following entries previously correctly set as US are now inproperly
319 0028 1201 OW IMG Red Palette Color Lookup Table Data
320 0028 1202 OW IMG Green Palette Color Lookup Table Data
321 0028 1203 OW IMG Blue Palette Color Lookup Table Data
322 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
323 of gdcmDocEntry moved to gdcmSeqEntry.
324 * src/gdcmSeqEntry.cxx: STYLE.
326 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
327 * Test/TestAllEntryVerify.cxx minor fix and added comments.
329 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
330 * gdcmPython/testSuite.py: all the test suite in python is now moved
331 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
332 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
333 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
335 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
336 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
337 to avoid inclusion recursion until STL is reached.
338 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
339 mecanism. errno.h is not included in gdcm anymore.
340 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
341 (gdcmFormatError now inherits from gdcmFormatUnexpected).
343 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
344 gdcmData/TestAllEntryVerifyReference.txt
345 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
346 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
347 exception_on_error parameter.
348 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
349 - vtk/vtkGdcmReader.cxx changed accordingly,
350 - Example/*.cxx and Test/*.cxx changed accordingly.
352 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
353 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
354 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
355 enable_sequences removed from gdcmHeader constructor and dependencies.
356 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
357 * gdcmPython/demo/PrintHeader.py: dummy fix.
358 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
359 skip_shadow removed from gdcmHeader constructor and dependencies.
360 * Example/*.cxx and Test/*.cxx changed accordingly.
362 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
363 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
364 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
366 2004-07-21 Jean-Pierre Roux
367 * FIX Now, Parsing and Printing a DICOMDIR do work!
368 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
370 2004-07-20 Jean-Pierre Roux
371 * FIX Some brain damaged headers have Zero-Lenght fields
372 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
374 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
375 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
376 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
377 variable (instance of gdcmDebug) by a definition macro, and the instance
378 is now in static in the gdcmDebug class
379 * src/gdcmSQItem.h : (FIXME) remove an undefined method
380 * Test/PrintAllDocument.cxx : bug fix in the result of the test
382 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
383 * WARNING: ctest now depends more tightly on gdcmData. You should
384 check out gdcmData properly for things to run smoothly...
385 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
386 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
387 we need the pixels not be loaded in order to use the ValEntry
388 that displays position and size).
389 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
390 This is a C++ based equivalent of gdcmPython/testSuite.py that should
391 be deprecated. If you have any doubts about the advantages of a
392 modern scripting language (read Python) versus grass root C++ (i.e.
393 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
394 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
395 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
396 Anyhow, consider documenting the gdcmData images in
397 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
399 * Test/CMakeLists.txt:
400 - now uses TestAllEntryVerify.cxx
401 - specific comments on oldACR00001.ima (now renamed in gdcmData
402 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
403 gdcmData/TestAllEntryVerifyReference.txt
406 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
407 * src/*.[h|cxx] : typedef clean up
408 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
409 - TagKey renamed to gdcmTagKey (for external usage)
410 - VRKey renamed to gdcmVRKey (for external usage)
411 - removal of typedef duplication.
412 - Removed all unecessary inline keyword from class inline definitions.
413 - Some method|function(void) declarations replaced with method|function().
414 * src/jpeg/libijg12/jdhuff12.c:
415 - printf polluting ctest removed.
416 - TAB removal for comminting
418 - TestAllReadCompareDicom.cxx: added a test that compares all the
419 images in gdcmDataImages.h with corresponding images in
420 gdcmData/BaselineDicom/. When baseline images are not present
421 this test creates them.
422 Note: we need to validate each reference image, but before that
423 I'd like to rename them with a more explicit name...
424 - CMakeLists.txt: changed accordingly.
425 * Example/*.cxx: examples now only include gdcm.h (as opposed to
426 including each header needed).
428 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
429 * Test/*.cxx and Example/*.cxx: moved some examples away from the
430 test suite to the Example directory. Are concerned:
435 - TestWriteSimple.cxx
436 * Test/CMakeLists.txt: added some comments on reasons for black listing
437 image gdcmData/oldACR00001.ima
439 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
440 * Test/CmakeList.txt: removed the following from black list (to be coherent
441 with removal from gdcmData):
442 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
443 - gdcm-MR-PHILIPS-16.dcm
445 Added the following because after last cvs update, they cause
446 ctest -R TestReadWriteReadCompare
448 - gdcm-MR-SIEMENS-16-1.acr
450 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
451 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
452 new comments in this file) we temporarily (sigh) move to a weaker
454 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
455 we don't need to black list the following images anymore:
456 - 8BitsUncompressedColor.dcm
458 - US-PAL-8-10x-echo.dcm
459 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
460 fixes and the beautified code ;-)
461 This fixes the bug introduced in version 1.42 (when beautifying)
462 that made the parsing of 8BitsRunLengthColor.dcm unproper.
463 Note: ctest was blind to this bug (this means we need to still
464 improve the test suite). The bug could be detected by using
465 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
467 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
468 and by displaying the (garbage) produced file temp.XDCM...
470 2004-06-29 Jean-Pierre Roux
471 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
472 - replace by uggly but working old code :-(
473 A lot of things should be OK again.
474 It's really urgent to have a test suite that *tests*,
475 to prevent Frog's beautifying sessions to break all the stuff
476 (twice, withing a fortnigh ...)
478 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
479 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
480 redundancy) to added Test/TestReadWriteReadCompare.cxx
481 * Test/CmakeList.txt: because the compare test of
482 Test/TestReadWriteReadCompare.cxx fails, the following images are
483 black listed: - 8BitsUncompressedColor.dcm
485 - US-PAL-8-10x-echo.dcm
486 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
487 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
488 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
489 and ad-hoc kludge. This kludge is now removed, and on encountering
490 such an image (OB field brain damaged) we set errno. Then in
491 ::FindDocLength() we "fix" the length as being ALL what remains
492 in the file (until EOF). We then proceed, hoping for the best...
493 This fixes a SegFault in ShowDicom when trying to write such an
495 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
496 (because TestWriteRead breaks on it, after a non conformal commit?).
497 ctest now runs properly, except for MakeDicomDir (which was allways
498 broken) and the Python related stuff (still not fixed).
500 2004-06-24 Jean-Pierre Roux
501 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
502 FIX : Test/TestReadWrite now iterates on all the file names
503 (instead of infinite loop)
504 ENH : Test/TestWriteRead now iterates on all the file names
506 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
507 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
509 2004-06-24 Jean-Pierre Roux
510 FIX : - now Write drops LUT Descriptors and LUTs (if any)
511 when SamplesPerPixel =3
512 - now Write is no longer confused by
513 'BitsAllocated = 12" and 'BitsStored=12"
514 - "UN" value representation Elements are now written correctly
515 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
516 ENH : - now gdcmHeader has its own Write methods
517 (in order to split the job that has not to be done
520 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
521 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
522 loop on the same image until memory went out.
523 Note: this means we still have gobs of memory loss in PrintDocument
524 * src/gdcmDocument.cxx: fixes problem on parsing on file
525 gdcmData/16BitsJpegLosslessGrayScale.dcm.
527 2004-06-24 Jean-Pierre Roux
528 FIX : Write - All the Sequences and Sequence Item are now written
529 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
530 is added a the end, when necessary.
531 - A lot of brain-damaged images, that were read correctly are
532 now written correctly
533 - length compatible BinEntry are now loaded correctly
534 (even for odd groups)
535 Note : only Explicit Value Representation was checked.
536 (question : is implicit VR really necessary for gdcm ?)
538 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
539 * DEVELOPPER: added a proposition of coding style.
540 * src/gdcmDocEntry.h: removed every inline declaration (for test of
543 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
544 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
545 Use the gdcmDocEntry::Print() and Write() instead.
546 * src/gdcmDocument.cxx: bug fix.
548 2004-06-22 Jean-Pierre Roux
549 FIX : gdcmDocument.cxx
550 - Now we do recognize the JpegLossLess format (there was a misstyping in
551 code 'beautyfication' :-(
552 - Now we automaticaticaly load the Luts, if any
554 2004-06-22 Jean-Pierre Roux
555 In order : to write Sequences, whatever their imbrication level,
556 : to allow user to create his own Sequences
557 a lot of modif where necessary (adding, moving, or virtualising methods)
559 WARNING : save your own sources *before* cvs up !
562 ADD virtual void Write(FILE *fp, FileType filetype);
565 ADD virtual void Write(FILE *fp, FileType filetype);
566 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
569 ADD virtual void Write (FILE *fp, FileType filetype)=0;
570 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
571 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
572 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
573 ADD std::string GetEntryByName(TagName name);
574 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
576 std::string vr = "unkn",
577 std::string fourth = "unkn",
578 std::string name = "unkn");
579 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
580 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
581 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
582 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
583 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
584 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
585 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
586 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
589 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
590 ADD virtual std::string GetEntryByName (TagName tagName);
591 ADD virtual std::string GetEntryVRByName (TagName tagName);
592 REM virtual bool Write(FILE *, FileType);
593 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
594 FILE *_fp, FileType type);
595 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
596 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
597 REM virtual bool WriteEntries(FILE *_fp,FileType type);
598 REM virtual std::string GetEntryByName (std::string tagName);
599 REM virtual std::string GetEntryVRByName (std::string tagName);
600 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
601 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
602 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
604 std::string vr = "unkn",
605 std::string fourth = "unkn",
606 std::string name = "unkn");
607 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
608 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
609 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
610 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
613 ADD virtual void Write(FILE *fp, FileType filetype);
616 ADD virtual void Write(FILE *fp,FileType filetype);
619 ADD virtual void Write(FILE *fp, FileType filetype);
620 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
621 REM std::string GetEntryByNumber(guint16 group, guint16 element);
622 REM std::string GetEntryByName(TagName name);
625 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
627 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
628 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
629 The default constructor invoked by the line
630 gdcmHeader *f1 = new gdcmHeader( header );
631 was gdcmHeader::gdcmHeader(bool) instead of the expected
632 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
633 Hence the parsing wasn't executed... See also below.
634 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
635 as explicit constructor didn't do the trick to fix the above problem.
636 Could anyone explain why ?
637 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
638 properly calls gdcmValEntry::Print() (that was weed out from
639 code related to gdcmBinEntry).
641 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
642 * In order to fix memory leaks:
643 - Test/TestWriteSimple.cxx: added cleaning of free store through
645 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
646 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
647 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
648 (through the call to ::AddDicomDirMeta()) or the destructor
649 would crash when deleting uninitialized ::metaElems].
650 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
651 - src/gdcmDocument.cxx:
652 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
654 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
655 was causing memory leaks.
656 - src/gdcmSQItem.cxx:
657 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
658 cleanly handled with polymophism: sorry but my milage is low).
659 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
660 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
661 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
662 This avoids SegFaulting.
663 - src/gdcmSQItem.h: coding style.
665 - Test/TestWriteSimple still severely sucks. The output image content
666 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
667 damaged when displayed with vtkgdcmViewer.
668 - on memory leaks: TestWriteSimple leaks really less (see entry
669 of 2004-06-18 in Changelog file for the call to valgrind).
670 - on segfaults: ctest now passes all the tests but one (no more
672 * Erroneous leading white fix:
673 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
674 white[s] (as opposed to from >> xxx, that removes it [them].
675 - src/gdcmTS.cxx: ditto.
676 - gdcmPython/testSuite.py: dirty related kludge removed.
677 * src/*: remaining references to gdcmParser removed.
678 * src/*[cxx|h]: added copy[way]left header.
681 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
682 * In order to fix writing of dicom files:
683 - Test/TestWriteSimple.cxx: a simpler example of writing.
684 - Test/CMakeLists.txt changed accordingly.
685 - src/gdcmDocument.cxx:
686 -- The destructor now recursilvely removes potential sequences.
687 -- Bug fix in ::IsJPEG2000()
688 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
689 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
691 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
692 to only declared) and build on top of
693 ::GetDocEntryByNumber(guint16, guint16).
694 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
695 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
696 for usage in destructor and treatement of promotion in
697 ::ReplaceOrCreateByNumber().
698 - src/gdcmSQItem.cxx: destructor should better handle his job.
699 Test/TestWriteSimple now runs (or at least it DOES something).
700 * We can now start hutting memory links. A good starting point is:
701 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
702 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
703 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
705 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
706 * Valgrind note: after Mathieu Malaterre teached me how to read
707 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
709 Using gcc, you can force the STL to use malloc and to free memory as
710 soon as possible by globally disabling memory caching.
711 With 3.2.2 and later, you should export the environment variable
712 GLIBCPP_FORCE_NEW before running your program.
713 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
714 simply vanish (it is still not clear to me, whether this means that
715 STL std::string leaks or if valgrind believes it leaks...).
716 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
717 running bin/gdcmTests makeDicomDir):
718 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
719 - Test/makeDicomDir.cxx now properly traps empty lists and returns
721 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
722 SegFaulting (I drowned in DicomDir related code when trying to
723 understand why the list is empty...).
724 * src/gdcmDocument.h: first BSD license header try.
725 * Doc/License.txt added.
727 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
728 * src/gdcmDocument.[h|cxx]:
729 - Clean up of the Transfer related predicates. They are now all based
730 on new method isGivenTransferSyntax, that (should) handle properly
732 - general clean up, simplification, and coding style.
733 - Specific clean up of Parse7FE0() (umproperly named actually).
734 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
736 2004-06-14 Jean-Pierre Roux
738 - fix the display of Sequence Delimitor (SQDepthLevel pb)
739 - fix the display of SQItem ordinal number
740 - add the GetSQItemByOrdinalNumber method
741 - remove some useless never written private methods
743 2004-06-14 Jean-Pierre Roux
745 - adding a constructor taking a gdcmDocEntry as an input param
746 - ReplaceOrCreateByNumber now returns :
747 a gdcmBinEntry * if a Binary (void *) value is passed as a param
748 a gdcmValEntry * if a string value is passed as a param
750 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
751 according to the param type (no longer sets a gdcmDocEntry)
752 - GetValEntryByNumber, GetBinEntryByNumber added
753 - NewValEntryByNumber and NewBinEntryByNumber added
755 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
757 - GetSQItemNumber and SetSQItemNumber added, to provide
758 a (relative) Item identier inside a given Sequence
759 \warning : some pb remaining around this number
761 - AddEntry now takes the Item Number as a param
763 - adding a constructor taking a gdcmDocEntry as an input param
765 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
766 * Memory leak hunt with the following command:
767 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
768 --show-reachable=yes gdcmTests PrintDocument
769 It looks like many (all?) leaks are due to the STL (or a bad usage
770 of the STL. The lines producing the leaks now have a comment with
771 a "MEMORY LEAK" tag: you can retrieve them with
772 grep "MEMORY LEAK" src/*
773 Here are two typical examples which I can't help fixing:
778 char * test = "babo";
779 name = test; //// <--- valgrind detects 960 bytes lost in
780 //// call to std::string::operator=(char const*)
781 name.clear(); //// Doesn't help !
789 std::cout << "Type a bunch of characters followed by RETURN: ";
790 getline(std::cin, line); //// <--- valgrind dectects a loss
791 //// of 1320 bytes in call to
792 /// std::basic_istream<>& std::getline<>
798 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
799 * src/gdcmHeader.[cxx|h]:
800 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
801 and related, moved away to gdcmDocument.
802 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
803 the corresponding protected accessors of inherited class
804 gdcmDocument, removed ! As a consequence gdcmFile had to be
805 declared friend of class gdcmDocument (see below).
806 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
807 - Clean up of undefined or unused methods.
808 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
809 account the changes to gdcmHeader.h).
810 * src/gdcmDocument.h:
811 - gdcmFile is now a friend class (in order to take into account the
812 changes to gdcmHeader.h).
813 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
814 (see changes to gdcmHeader.h).
815 - Accessors (reading on the form GetEntry*) are now public.
816 - Clean up of undefined or unused methods.
817 * src/gdcmDocument.cxx:
818 - adaptation to changes to gdcmDocument.h
819 - ::OpenFile now writes a verbose message when file cannot be opened.
820 - some std::string properly set to VRKey
821 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
822 references to gdcmDocument.
823 * Test/TestFindTags.cxx: changed accordingly to above changes.
824 * gdcmPython/testSuite.py: adapted to renaming of acr files in
825 cvs repository gdcmData.
827 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
828 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
829 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
830 conflicts with gdcmValEntry::voidArea.
831 * src/gdcmValEntry.cxx: unmatching comment wiped out.
832 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
833 Value representation between StringRepresentable and BinaryRepresentable.
834 * src/gdcmDocument.cxx:
835 - method ParseDES: proper indentation restored and usage of
836 gdcmVR::IsVROfGdcmStringRepresentable wired in.
837 - method LoadDocEntry: the fingerprint left in the SetValue() of
838 unloaded entries (length > MaxSizeLoadEntry) had curiously been
839 removed. Reverting to previous code segment with the proper
840 dynamic_cast< gdcmValEntry* >.
841 Note: this was (partially) breaking the python test suite
842 (gdcmPython/testSuite.py) that made usage of the above
843 fingerprint to check presence of "Pixel Data".
844 * src/gdcmDocEntry.h: coding style.
845 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
846 now taken into account.
847 * gdcmPython/gdcm.i: adaptation to the new internal representation
848 of gdcm (exit gdcmParser, hello gdcmDocument).
849 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
851 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
852 anymore, but instead prints the loaded Python dictionary.
853 * .... alas, the python testSuite is still broken.
855 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
856 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
858 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
859 * src/gdcmUtil.h : export methods
861 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
862 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
864 * Initial addition of automatic python testing
865 * Initial addition of automatic image comparison
867 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
868 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
869 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
871 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
872 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
873 * Test/ShowDicom.cxx : bug fix for msvc compilation
874 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
876 2004-05-04 Jean-Pierre Roux
877 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
878 new concepts (and new classes) :
879 a 'gdcmDocument' is composed of a set of Doc Entries, that are
880 - elementary gdcmDocEntries (former gdcmHeaderEntries)
881 - Sequence Doc Entries (gdcmSeqEntries)
882 a Sequence is composed of Items.
883 Each item is a set of Doc Entries (this is recursive)
884 The non uniqueness of the 'Dicom tag' is due to this recursivity
885 (never taken into account)
886 Our unability to add a new 'entry' in the header
887 at the proper location (neither in the H-Table (map or multimap),
888 nor in the Chained List is also due to this recursivity.
889 Don't try, right now, to use/modify/compile these new sources :
891 We just commit all the stuff, 'as is', in order not to loose it.
893 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
894 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
896 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
897 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
898 file prefix (SetFilePrefix)
900 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
901 * Add a new test: ShowDicom, for now this is just the c++ version of
902 checkRead.sh, later it will be able to compare the image read against a
904 * Replace the DEBUG on the stack with a global entry in cmake interface:
905 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
907 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
908 * Add an example subdir, with a real example on how to read + write a
911 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
912 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
913 * Doc/CMakeLists.txt: the main page is now properly differentiated
914 between the developper and user version.
915 * Doc/doxygen.config.in: dropped search related obsolete flags
916 * src/gdcmParser.h, gdcmHeader.h: doxygenation
918 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
919 * DEVELOPPER: added some helpfull comments for compile/test/install
922 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
923 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
924 src directory, now generated in the build dir.
925 2. Tests as mentionned smarter
927 4. Add a new method in gdcmDict that return the PubDict by name
928 this is interesting for 3rd party lib like ITK,
929 where we could set the institution name / patient name...
931 * ENH: 1. Now the test suite is working for real
932 2. All binaries are now output in the gdcm-bin directory
933 (this was not true before)
935 2004-04-28 Jean-Pierre Roux
936 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
937 SeQuence indented printing of Dicom Header.
938 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
939 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
940 Computation of SQDepthLevel is now part of gdcmHeader constructor
941 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
942 tree-like structure of a Dicom Header.
943 * FIX Test code cleaning
945 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
946 * ENH: Adding automatic testing
947 1. Need a DartConfig.cmake to submit to public
948 2. Add a test driver gdcmTest.cxx
949 3. gdcmTestMain, an helper for the main test driver gdcmTest
950 4. Files in Test don't have a main anymore, this becomes interesting
951 when we add more and more tests, thus dsw don't have to load
953 * ENH: Adding a GDCM_DATA_ROOT for testing
954 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
955 one file instead of seven + some small cleanup
957 2004-04-22 Jean-Pierre Roux
958 * ENH Minor changes to the Print() methods.
959 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
960 Header printing. Example given with :
961 > PrintHeader fileName 2 new
962 (SQ based tree-like structure still to be done for the Header ...)
964 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
965 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
966 1. I have added some unsigned where needed
967 2. Some function parameter not used -> (void)
968 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
969 4. g++ don't like character '\' in comment
970 5. #define jpeg_create_decompress jCreaDecompress
971 this really need to be fixed
972 6. virtualize destructor of gdcmObject ... leakage
973 7. sscanf(g->first.c_str(),"%x",&gr_bid);
974 this also really need to be fixed
975 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
976 remove compression file
977 (as we only do decompression, right ?)
978 * ENH: Change malloc/calloc/free with c++ equivalent
980 2004-04-21 Jean-Pierre Roux
981 * FIX gdcmHeaderHelper::GetXSpacing
982 when a single value is found (bug ?), xpacing is now
983 defaulted to yspacing
985 2004-04-19 Jean-Pierre Roux
986 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
987 * ENH add parameters :
988 bool exception_on_error = false,
989 bool enable_sequences = false,
990 bool ignore_shadow = false
991 to the gdcmFile constructors to be full gdcmParser compliant
992 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
993 to allow reading of PAPYRUS 3.0 files
995 2004-04-06 Jean-Pierre Roux
996 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
998 2004-04-02 Jean-Pierre Roux
999 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1000 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1001 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1003 2004-03-30 Jean-Pierre Roux
1004 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1005 for ACR file, written out as DICOM files (hope so...)
1007 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1008 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1009 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1010 moved to base class gdcmParser and only the specialisation is kept
1012 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1013 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1014 already does the job.
1015 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1016 (to be consistent with gdcmParser::WriteEntries).
1018 2004-03-30 Benoit Regrain
1019 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1020 upate of the object's instance. It's passed to 2 in the unfavorable
1021 case : one in the ExecuteInformation, one in the ExecuteData
1023 2004-03-29 Jean-Pierre Roux
1024 * ENH : Check on file type to be written moved
1025 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1026 * FIX : gdcmObject::ResetBoundaries now stops properly
1027 when end-of-list is reached
1028 : gdcmVersion modified (as Benoit Regrain asked)
1030 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1031 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1032 * src/gdcmUtil.cxx: added forgotten iostream include.
1033 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1034 equivalent to ExplicitVR in existing code).
1036 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1037 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1038 now contains all the gdcmGlobal related code.
1039 * minor coding style and doxygenation changes.
1041 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1042 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1043 now contains all the Debug related code.
1044 * minor clean-up of includes in src/*.cxx
1045 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1046 CreateCleanString) removed.
1047 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1048 * Doc/DoxyMainPageUser.txt added.
1049 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1050 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1051 src/gdcmDirList.cxx)
1053 2004-03-24 Jean-Pierre Roux
1054 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1056 2004-03-23 Jean-Pierre Roux
1057 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1058 big endian made volumes
1059 * ENH Now gdcmParser constructor and destructor are protected to forbid
1060 end user to instanciate class gdcmParser
1061 (only gdcmHeader and gdcmDicomDir are meaningfull)
1063 2004-03-22 Benoit Regrain
1064 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1065 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1066 gdcmSerie to gdcmDicomDirSerie
1068 2004-03-19 Jean-Pierre Roux
1069 * ENH Now the tree-like structure describing a DICOMDIR comming from
1070 an already existing DICOMDIR file is consistent with
1071 the home-made tree-like structure build ex-nihilo
1072 or build from the files held (recursively) in a Directory
1073 functions gdcmDicomDir::CheckBoundaries()
1074 gdcmObject::SetBoundaries() added
1076 2004-03-17 Jean-Pierre Roux
1077 * REM (Eric Boix bug) : removal of meaningless
1078 gdcmDicomDirImage::NewImage function.
1079 * FIX now file names and directory name are written properly in the
1081 * FIX now gdcmDicomDir constructor may be call without any trick
1084 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1085 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1086 of gdcmDicomDirImage::NewImage as empty function.
1088 2004-02-28 Jean-Pierre Roux
1089 * ENH add gdcmDicomDir:NewPatient
1090 add gdcmDicomDirPatient:NewStudy
1091 add gdcmDicomDirStudy:NewSerie
1092 add gdcmDicomDirSerie:NewImage
1093 to allow making gdcDicomDir object.
1094 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1095 (as opposite to the gdcmHeader chained list)
1097 2004-02-11 Benoit Regrain
1098 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1099 when using from python
1101 2004-02-10 Benoit Regrain
1102 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1103 * FIX : in gdcmDicomDir when the directory is empty
1104 * ENH : add callback and methods to get the progression of dicomDir
1107 2004-02-06 Jean-Pierre Roux
1108 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1109 - GDCM_META added to gdcmDicomDirType
1110 - class gdcmMeta created
1111 * ENH : - A brief summary is now displayed at the beginning of
1112 'testDicomDir' to help disaster magnitude estimation
1113 * REM : Now useless Test/explDICOMDIR.cxx
1115 2004-02-05 Benoit Regrain
1116 * ENH : add methods in gdcmObject to get the hash table or the list of
1118 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1119 * FIX : wrapping python for TagHeaderEntryHT
1121 2004-02-04 Benoit Regrain
1122 * FIX : even length for some strings when writting the dicom dir
1123 * FIX : sort the images in the dicom dir
1124 * FIX : Bug fix for python use of dicom dir
1125 * ADD : a python demo
1127 2004-02-04 Jean-Pierre Roux
1128 * FIX : Final solution (?) for icone embedded images
1129 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1130 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1131 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1132 gdcmData/gdcm-MR-SIEMENS-16.acr1
1133 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1134 to make full checking easier
1136 2004-02-04 Benoit Regrain
1137 * FIX : WriteEntries : coding style & logic in parameters
1138 * FIX : Set the elements to create the DicomDir in a dictionary file
1140 2004-02-03 Benoit Regrain
1141 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1142 * gdcmDicomDir : add the load of directory
1143 * Bug fix and print add-on
1145 2004-02-03 Jean-Pierre Roux
1146 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1147 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1148 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1149 * FIX gdcmParser.cxx : 'group length' elements are now considered
1150 as integers, even for shadow groups, when file is Implicit VR
1152 2004-02-02 Jean-Pierre Roux
1153 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1155 of the last synonym :-(
1156 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1158 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1159 * FIX taking into account the possible 7fe0,0010 multiplicity
1160 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1161 to allow removal of references to 7fe0,0010, to deal with
1162 ACR-NEMA images, when 0028,0200 is meaningfull
1164 2004-01-31 Jean-Pierre Roux
1165 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1166 no longer writes 'Un' on disk
1167 * FIX SQ elements with actual length are now dealt with corectly
1168 * FIX gdcmFile::WriteBase make the difference, for color images, between
1169 the length (for Palette expanded images)
1170 and Raw Length (non expanded image + Palette)
1171 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1172 (that broke Write). Replaced by UL.
1173 Aware user will reload the field if he
1174 thinks it's necesssary
1176 2004-01-30 Jean-Pierre Roux
1177 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1178 when 'dirty Acr' is found, to be compliant with the new
1179 IsReadable() methods.
1181 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1182 (no DOUBLE images in kosher DICOM,
1183 but so usefull for people that miss them ;-)
1185 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1186 DICOMDIR related utilities (not checked as Windoze compliant)
1188 2004-01-28 Jean-Pierre Roux
1189 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1191 2004-01-27 Jean-Pierre Roux
1192 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1193 to allow skipping the shadow elements, to save memory space.
1194 The TRUE value for this param has to be used
1195 with a FALSE value for the 'enable_sequence' param.
1196 ('public elements' may be embedded in 'shadow Sequences')
1197 * gdcmHeader methods now deal with 'embedded icones images' in the header
1198 (even when an 'icone image sequence' is announced by the
1199 element (0x0088,0x0200), but there is NO icone at all ...
1201 * gdcmHeader sometimes Image Location value doesn't follow
1202 the supposed processor endianity (see gdcmData/cr172241.dcm).
1205 * gdcmHeader add the method
1206 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1207 to get *all* the Header Entries with the same tag.
1208 GetHeaderEntrySameName is probabely *useless*
1209 (no meaning : Name is *not* an identifier within the Dictionnary)
1211 2004-01-26 Benoit Regrain
1212 * Bug fix in the print of hexadecimal representations. Remove long fields
1213 in the print and add a third level of print to print them
1215 2004-01-23 Benoit Regrain
1216 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1217 * Bug fix on test suite after remove the strip made on not string fields
1218 * Split the IsReadable method between gdcmParser which test that the file
1219 is dicom and gdcmHeader which test that it's an image file
1221 2004-01-22 Benoit Regrain
1222 * DicomDir : clean code, add methods, set variables in protected or private
1223 * gdcmUtil : bug fix for the clean string method
1225 2004-01-19 Benoit Regrain
1226 * Add the use of shadow dictionaries
1227 * bug fix and coding style
1229 2004-01-19 Benoit Regrain
1230 * src/gdcmFile.cxx : bug fix concerning the close of file
1231 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1232 * Add the update of header entries using the shadow library
1234 2004-01-19 Benoit Regrain
1235 * removal of file gdcmHeader2.cxx
1236 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1237 inheriting from gdcmParser. This split is to prepare the integration
1238 of dicom dir parsing
1239 * bug fix under python
1241 2004-01-16 Jean-Pierre Roux
1242 * REM removal of class gdcmHeaderEntrySet
1243 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1244 * ADD add file gdcmHeader2.cxx
1245 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1247 2004-01-15 Benoit Regrain
1248 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1249 entries created while parsing the header. Thus, they will be destroyed
1250 when the gdcmDictSet will be destroyed
1251 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1254 2004-01-15 Benoit Regrain
1255 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1256 made a fatal error because of the memory release at the end of program.
1257 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1258 some memory and vtk seems to have some problems with that.
1259 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1261 2004-01-14 Benoit Regrain
1262 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1263 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1264 * src/*.[h|cxx] : make changes due to class name changes
1265 * gdcmPython/demo/*.py : bug fix due to method names
1267 2004-01-13 Benoit Regrain
1268 * src/*.[h|cxx] : coding style
1269 * vtk/*.[h|cxx] : coding style
1271 2004-01-13 Benoit Regrain
1272 * gdcmPython/testSuite.py : test the readable flag of file for tests
1273 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1274 It's lied to the stl compilation by MSVC (windows, always windows...)
1275 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1277 2004-01-12 Benoit Regrain
1278 * src/*.h : add comments
1279 * src/gdcmDictSet.h : set the method BuildDictPath in public
1280 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1281 directly setted in the source code
1282 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1285 2004-01-09 Benoit Regrain
1286 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1287 * setup.py : use a reference to gdcmVERSION
1289 2004-01-07 Benoit Regrain
1290 * Modification to compile with the distutils.
1293 2003-12-10 Benoit Regrain
1294 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1295 can use a gdcmHeaderHelper to load datas
1296 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1297 made in the source code
1299 2003-12-10 Benoit Regrain
1300 * Update Windows projects and .cvsignore files
1302 2003-11-12 Jean-Pierre Roux
1303 * ENH gdcmHeader constructor has one more parameter (default value : false)
1304 that allows the user to 'go inside' the SeQuences only
1306 gdcmElValSet:Print takes it into account
1308 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1309 * ENH: Update gdcmPython/CMakeLists
1310 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1311 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1313 2003-11-10 Jean-Pierre Roux
1314 * FIX : gdcmHeader::LoadElements is now based
1315 on the ListTag listElem member,
1316 not longer on the TagElValueHT tagHt member
1317 * ENH : PrintPubElVal shows (temporarily) both results,
1318 with the tagHt member and the listElem member.
1319 (it's easier to 'see' the problems when using Printheader)
1321 * FIX : old private member LgrElem is now splitted into
1322 ReadLength : Length actually found on disk (updated only
1323 if bug fixing is necessary), for internal
1325 UsableLength : Updated by FixFoundLength, to fix a bug
1326 or to allow Parser going on.
1327 Will allow to re-write a kosher header when a SeQuence
1328 with a length (not 0000) is found
1329 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1330 because gdcmElValSet::Add does not update ListElem
1333 2003-11-07 Jean-Pierre Roux
1334 * FIX misstyping in Transfert Syntax name table
1335 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1336 when they have an actual length (not 0000 nor FFFFF)
1337 (Nobody should care of it, but DICOMDIR explorers)
1339 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1340 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1342 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1343 * ENH: vtkGdcmReader now supports LUT !
1344 (vtkgdcmViewer for now is not able to use them though)
1346 2003-11-05 Jean-Pierre Roux
1347 * in testSuite.py : new files names for checking the package
1348 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1349 that returns the pixel area size to the *aware* (vtk) user
1350 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1352 2003-11-05 Benoit Regrain
1353 * in testSuite.py : Modify the rules for checking the paths
1354 : Explicit error messages
1355 * in __init__.py : Related modif
1357 2003-11-03 Jean-Pierre Roux
1358 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1359 to be used by aware (vtk) users that want to manage
1360 LUT (and no to turn the PALETTE image into an RGB pixels one)
1361 * GetPixelType now returns 8U for 24 Bits images
1362 (vtkGdcmReader compliant)
1364 2003-10-31 Jean-Pierre Roux
1365 * Removal of *all* gdcmData images and add them again
1366 in order to loose the 'history' of un-anonymised images
1368 2003-10-31 Jean-Pierre Roux
1369 * RMV : removal of useless jBitsInJsample.h
1370 for both 8 and 12 Bits JPEG Lossy Libraries
1372 2003-10-31 Jean-Pierre Roux
1373 * ENH : Add the functions gdcmFile::GetImageDataRaw
1374 gdcmFile::GetImageDataIntoVectorRaw
1375 that act as GetImageData and GetImageDataIntoVector
1376 except the making of an RGB Plane from Gray Plane + LUT
1377 Intended to aware (vtk) users who know how to manage
1380 GetLUTRGBA return a R,G,B,A LUT if any
1381 lgrTotaleRaw gives the 'Raw' length
1382 GetImageDataRaw returns the gray Plane
1383 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1384 (They stay Grey, just like with other Dicom viewers :-(
1386 2003-10-30 Jean-Pierre Roux
1387 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1389 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1390 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1391 being coherents dicom files.
1393 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1394 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1396 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1397 * ENH: Two steps is necessary to please VC++ compiler...
1398 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1399 * ENH: Add include dir to medcon lib
1400 * FIX: only one function is being exported for now !
1401 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1403 2003-10-29 Jean-Pierre Roux
1404 * adding gdcmHeader::GetLUTRGBA
1405 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1406 --> Mathieu, the modif u're waiting for is not yet committed
1407 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1409 2003-10-27 Jean-Pierre Roux
1410 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1411 00191113.dcm DermaColorLossLess.dcm
1412 MxTwinLossLess.dcm RadBWLossLess.dcm
1413 * ENH: For version prior to vtkImageViewer2 -r 1.19
1414 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1416 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1417 * Removal of ido stuff in CMakeLists.txt
1419 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1420 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1421 * FIX: remove a call to ->Modified ... see comments
1422 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1424 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1425 * FIX: Problem with path for libvtkgdcmPython
1426 * ENH: Try adding a search script for python site-package
1427 * RMV: Remove some file from medcon lib that are not necessary
1428 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1429 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1430 * FIX: More pragma disable fro VC++,
1431 I don't think I break something as it is also disable in VTK/ITK.
1432 But it fasten debug compilation time.
1434 2003-10-23 Jean-Pierre Roux
1435 * gdcm now deals with 16 Bits Run Length Encoded images
1436 (they are compressed as 2 planes images,
1437 one for the high Bytes, the other for low Bytes)
1439 2003-10-22 Jean-Pierre Roux
1440 * Now CheckRead takes into account :
1441 - the bugged 'Leonardo' Siemens images
1442 - the XA images, sent thru the burning VPRO station
1443 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1446 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1447 * FIX: When copying a Makefile.am to CMakeLists.txt
1448 one should remove the '\'
1450 2003-10-22 Jean-Pierre Roux
1451 * in gdcmData adding a bugged 'Leonardo' Siemens image
1452 (wrong lengths in header)
1453 OK with gdcm, KO with the other viewers :-)
1454 * add a GE dlx XA image, thru the VEPRO burning station
1457 2003-10-21 Jean-Pierre Roux
1458 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1459 for a brutal checking of vtkgdcmViewer compliance
1461 2003-10-21 Jean-Pierre Roux
1462 * add the files for 'xmedcon' Jpeg Lossless library
1463 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1465 2003-10-21 Jean-Pierre Roux
1466 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1468 2003-10-21 Jean-Pierre Roux
1469 * garbage Siemens 'Leonardo' images dealt with
1470 (the patch is easy to remove)
1471 * cosmetic changes to avoid warnings
1473 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1474 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1475 no need to press 'r' now.
1477 2003-10-20 Jean-Pierre Roux
1478 * upgrade of checkRead.sh checkWrite.sh according
1479 to new Jpeg Lossless decompressor
1480 * add US.3405.1.dcm, a genuine RGB medical file ...
1481 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1482 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1484 2003-10-15 Jean-Pierre Roux
1485 * general anonymisation in gdcmData
1486 * adding the 'color files' from
1487 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1488 * adding some well knowed bugged-header images
1489 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1490 waiting for their inclusion in Python testsuite
1492 2003-10-15 Jean-Pierre Roux
1493 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1494 no longer seg faults when file is not found
1496 2003-10-14 Jean-Pierre Roux
1497 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1500 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1501 * TODO: *.in file to genereate a UseGDCM later
1503 2003-10-14 Jean-Pierre Roux
1504 * Some supposed-to-be Dicom Images have no preamble.
1505 OpenFile takes it into account
1506 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1507 * Missing elements added in dicomV3.dic
1508 (just to be affraid : have a look at
1509 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1510 and do it again next year ;->
1512 2003-10-13 Jean-Pierre Roux
1513 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1514 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1515 But there are NOT. It's fixed !
1517 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1518 * FIX: "jpeglib.h" was not found on VC++
1519 * FIX: vtkgdcm was not being installed
1521 2003-10-10 Jean-Pierre Roux
1522 * ENH : OpenFile closes the file if it *really* doesn't look like
1523 an ACR-NEMA / DICOM one.
1524 * FIX : testWrite no longer writes an empty file if the source file
1525 is not gdcm Readable
1526 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1529 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1530 * FIX: CMake generate now documentation
1531 * ENH: out of source doc build !
1532 * ENH: Generate both user and dev documentation
1533 * ENH: Should work on windows too
1534 * ENH: Only one doxygen config.in file is needed
1535 * FIX: make install should be ok now on ùnix plateform
1536 * FIX: PATH to dictionary was wrong (missing /)
1537 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1539 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1540 * vtkGdcmReader is now able to read rgb dicom file.
1541 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1542 * added a gdcmViewer to vtk test, use mouse to control
1543 window level & window width
1545 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1546 * CMake-ification of gdcm, we have now two build system
1547 * FIX: on cygwin Wsock32 doesn't exist
1548 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1550 2003-10-06 Emanuel Ollart
1551 * FIX : compilation process wad broken.
1552 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1554 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1555 * change gdcmViewer -> vtkgdcmViewer
1556 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1558 2003-10-06 Jean-Pierre Roux
1559 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1560 ( e.g : well known GE images with a wrong elem length,
1561 : Philips MRI Images with a wrong Huffman table)
1562 * still to be done : allow the reading of bugged LEONARDO Siemens images
1564 2003-10-03 Jean-Pierre Roux
1565 * Odd length strings are padded with '\0' (not with spaces,
1566 to remain compliant with already defined strings,
1567 like Transfert Syntax UID and others)
1569 2003-10-03 Jean-Pierre Roux
1570 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1571 to allow displaying RGB images (not only by affim ;-)
1573 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1574 * vtkGdcmReader is now able to read rgb dicom file.
1575 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1577 2003-10-03 Jean-Pierre Roux
1578 * A few nasty patches to allow the reading of a lot of nasty images
1579 ( e.g : well known GE images with a wrong elem length,
1580 : Philips MRI Images with a wrong Huffman table)
1581 * still to be done : allow the reading of bugged LEONARDO Siemens images
1583 2003-10-03 Jean-Pierre Roux
1584 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1586 2003-10-03 Jean-Pierre Roux
1587 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1588 to allow displaying RGB images (not only by affim ;-)
1590 2003-10-03 Jean-Pierre Roux
1591 * gdcmFile::GetImageDataIntoVector now
1592 - deals with MultiFrames MultiFragments Run Length Encoded files
1593 - deals with YcBcR (YBR_FULL) files
1594 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1595 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1597 (no sample found :-(
1599 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1600 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1601 Two reasons: - clear things
1602 - third parties acces gdcm through header files, so won't
1603 suffer anymore VC++ complains
1605 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1606 * add argv[1] in testvtkGdcmReader.cxx
1609 2003-09-24 Jean-Pierre Roux
1610 * The lines are now eigthy characters long.for
1611 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1613 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1614 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1615 char* to std::string. Thus, the use of strdup becomes useless. (see
1616 previous commis of Malaterre)
1617 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1618 before the last Malaterre's commit.
1620 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1621 * This commit should fix the Debug building under VC++, the problem
1622 was mainly a mixture of debug and release lib being loaded at startup.
1623 * I also remove a depency to a specific C function: strdup. Because I had
1624 to force the link to msvcrtd (whereas strdup is in libc).
1626 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1627 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1628 located in the gdcmCommon.h file. All use of reference of tha has been
1629 changed to now use the variable GDCM_UNFOUND.
1631 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1633 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1634 Dicom dictionary. The test suite can now be run again. Note:
1635 I'm note very happy with the " (RET)" changes. I believe this
1636 RETAINED comment should be dropped when parsing the dictionary.
1637 - PACKAGER corrected
1639 - AUTHORS updated and now in alphabetical order
1640 * Makefile.am now exports gdcm.dsw for Windoze users.
1642 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1643 * cygwin complains about missing std:: in subdir Test/
1645 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1646 * remove some methods that are now in gdcmHeaderHelper
1648 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1649 * vtkGdcmReader set spacing and origin correctly
1651 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1652 * Fix a few delete/delete[] mismatch
1654 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1655 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1656 interpretation to data given by gdcmHeader. For instance there are
1657 heuristics to get informations (look at different places).
1658 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1659 sorting DICOM images based on different strategies.
1660 * modified Makefiles accordingly.
1662 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1663 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1664 when building in debug mode
1665 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1666 src/win32/gdcmdll.dsp
1667 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1669 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1670 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1673 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1674 * src/win32/libgdcmjpeg12.dsp was not dos format
1675 * src/win32/libgdcmjpeg12.dsp :
1676 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1677 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1679 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1680 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1682 * src/gdcmFile.cxx : bug fix in affectation type
1683 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1684 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1685 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1686 symbols... future problem ?
1688 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1689 * src/win32/libgdcmijpeg12.dsp was missing
1690 * modified gdcm.dsw accordingly
1692 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1693 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1695 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1696 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1697 commit of JPR (before his hollidays to facilitate our work).
1698 * setup.py : bug fix in code. Modifications made while the last commit
1699 of JPR. The code hasn't been tested before the commit... it's so
1700 useless to make that (for best programmer that is JPR) !!!
1702 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1703 * tagged the current version as Version0_3 (i.e. version 0.3)
1705 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1706 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1707 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1708 * *.dsp : modifications to use new libgdcmijpeg8 library
1709 * setup.py : bug fix on VTKPATH variable
1710 * PACKAGER : adding all concerning windows
1712 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1713 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1715 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1716 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1717 test suite reported error.
1718 * PACKAGER file added (describes what a packager must do when
1719 packaging a new release).
1720 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1721 * configure.in: upgraded version number to 0.3.0
1722 * fixing build of rpm (through rpm -ta):
1723 - Doc/Makefile.am exports proper doxygen files
1724 - src/jpeg/libijg8/Makefile.am exports the include files.
1726 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1727 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1728 * src/gdcmHeader.h : formatting code
1730 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1731 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1732 We were obtaining error message from vtk. Now, creation of file list
1733 is made in an internal list to prevent this problem.
1734 Bug fix when output is empty.
1735 Bug fix in update of progress value. Previous commit for this was a bad
1737 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1739 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1740 * src/gdcmHeader.h : added method to get the file name
1741 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1742 files. Added method to remove all files on the input
1743 Added FIXME comment concerning the bad parsing of header made by
1744 ExecuteInformation method (in ExecuteData method)
1746 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1747 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1748 when using make instal.
1749 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1750 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1752 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1753 * setup.py : adding include dir of jpeg lib to compile all sources
1754 * */Win32/*.dsp : JPR fix for windows compilation
1756 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1757 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1759 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1760 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1762 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1763 * setup.py is again effective on un*x (takes into account the
1764 addon of the jpeg library)
1765 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1766 * Doc/Doxy* updated (includes above enhancements)
1767 * INSTALL now points to web documentation
1769 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1770 * src/gdcmHeader.h doesn't make unnecessary reference to
1772 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1774 * src/gdcm*.[cxx|h] :
1775 - to allow compilation with gcc 3.x
1776 -- clean up of STL usage (added explicit usage of std::)
1777 -- small fixes on exceptions.
1778 Note: linking not tested !
1779 - clean of doxygen comments to avoid warnings at documentation
1781 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1782 dependent convertion).
1784 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1785 * Clean up of previous JPR garbage commit (not even commented in the
1787 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1788 - moved all jpeg related files from src to src/jpeg/libijg8, with
1789 addition/modification of Makefile.am and configure.in.
1790 - the testSuite is still brain damage (not guilty).
1792 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1793 * WrapVTK.py : modifications to get correctly vtk source files to
1795 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1796 (FileName -> Filename)
1798 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1799 * vtk/vtkGdcmReader.[cxx/h]:
1800 - UpdateProgress method should now be effective
1801 - removed the limitation on having only images loaded (as opposed
1803 - when building a stack of images/volume, a lesser number of
1804 gdcmHeader and gdcmFile instances should be used (hopefully
1805 accelerating things).
1806 - when building a stack of images/volumes, files which are not
1807 loadable (wrong path-filename, wrong permissions on existing file,
1808 or file not parsable by gdcm) are replaced with a black image
1809 in the stack (for the caller to notice the problem).
1811 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1812 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1814 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1815 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1816 between standard library (std) and vtk library (problems are found
1817 under Windows... thanks Windows !)
1819 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1820 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1822 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1824 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1825 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1827 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1828 * When compiling with distutils (see setup.py) the C++ compiler is
1829 called with different flags than the default ones (with automake).
1830 In order to fix all those warning, I compiled gdcm with the command
1831 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1832 and went for warning fixes:
1833 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1834 up from unused variables.
1835 - vtk/vtkGdcmReader.cxx: potential bug fix.
1836 * src/gdcmHeader.h: Doxygen warning cleanup
1838 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1839 * gdcmPython/gdcm.i:
1840 - typemaps correction to take into account the systematic replacement
1841 of "using namespace std" with std:: prefix e.g. std::list,
1842 std::string... (cf changes of 2003-05-21).
1843 - gdcmGlob global variable of type gdcmGlobal (defined in
1844 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1845 exported to Python a as cvar.
1846 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1847 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1848 gdcmDictSet.GetPubDictTagNames() and
1849 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1850 C++ static methods).
1851 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1852 with the above changes.
1854 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1855 * setup.py, manifest.in : bug fix under linux
1857 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1858 * Modification of setup.py to compile vtk part too. Then, we have 2
1859 wrappers which must work with same distutils. For that, we have a
1860 generic distutils in distusiltsWrapping.py ; with :
1861 - build_extWrap class to wrap generically all extensions,
1862 - ExtensionWrap base class for all wrapping extension that contains
1864 - Wrapper interface which wrap sources
1865 + In WrapSwig.py we have extension and wrapper for Swig
1866 + In WrapVTK.py we have extension and wrapper for VTK
1867 * MANIFEST.in : modifications to consider vtk directory and new python
1868 files for compilation
1870 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1871 * Added python wrappers of vtkGdcmReader vtk class (see the
1872 source in vtk/vtkGdcmReader.cxx) :
1873 - vtk/Makefile.am now builds a library
1874 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1875 python library (as opposed to _gdcm.so wich are the python
1876 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1877 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1879 - configure.in has an additional flag --enable-vtk that needs
1880 to be set to enable compilation of vtk related code, that is:
1881 + vtk/vtkGdcmReader.so and
1882 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1883 + gdcmPython/vtkgdcmPython.so (see above)
1884 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1885 be read when compressed or when HighBit + 1 != BitsStored),
1886 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1887 the usage of the python wrapper of vtkGdcmReader vtk class.
1888 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1889 * src/*.[h] all occurences of stl classes are now prefixed with
1890 std::, and all occurences of "using namespace std;" where removed.
1891 This is to avoid pollution of global namespace in included files.
1892 Apparently vtk does not avoid this pitfall: when using both
1893 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1894 collision of various stl members (principally cout...).
1895 * gdcmPython/testSuite.py now cleanly removes temprory generated
1897 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1898 comply with above changes)
1900 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1901 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1902 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1903 vtk data structure (an image Flip was required).
1904 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1905 * cosmetic changes in documentation.
1907 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1908 * src/gdcmHeader.cxx: the constructor no longer exits when an
1909 unexisting file is given as argument.
1910 * The subdirectory Data (containing all the images used for the
1911 test suite) is not part of this repository anymore. A new module
1912 containing those images is now available at
1913 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1914 with the name gdcmData.
1915 All the python scripts (including the package initialisation file
1916 gdcmPython/__init__.py) were adapated to take this change into
1917 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1919 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1920 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1921 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1922 demo of the usage of this class.
1923 Compilation of this vtk part is only done when using the --enable-vtk
1924 at configure (or autogen.sh) stage.
1926 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1927 * More memory link related corrections and documentation fixes.
1929 - maximum info is obtained with a command of the form:
1930 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1931 --show-reachable=yes PrintHeader
1932 - the remaining reachable blocks seem to come from the STL
1933 allocation scheme through the usage of map and list. It looks
1934 like this memory cannot be freed but it is not a memory leak
1935 (in fact further invocation to the STL would recollect the
1936 unused memory allthough it cannot explicitely be freed).
1937 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1938 of displaying an image parsed with gdcm and displayed with VTK.
1939 Note: some images don't seem to work e.g.
1940 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1941 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1942 Allthough this weakens the semantics, it is a ditch attempt to
1943 make gdcm more thread friendly.
1945 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1946 * Memory link hunt (by using valgrind through the command
1947 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1948 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1949 gdcmHeader::_dicom_vr.
1950 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1951 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1953 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1955 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1956 * src/Makefile.am now exports all the necessary include files at
1960 * UpdateGroupLength replaced by new one
1963 * UpdateGroupLength re-written using H-Table
1964 (named UpdateGroupLengthNew untill checks are over)
1966 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1967 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1968 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1970 - gdcmHeader::GetPubElValSet removed.
1971 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1972 UpdateGroupLength, WriteElements, Write.
1973 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1974 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1975 carried the same semantics.
1976 - src/gdcmHeaderIdo.cxx changed accordingly.
1977 - gdcmFile::WriteBase now regroups all the codes from previous
1978 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1979 - enum FileType moved to gdcmCommon.h
1980 * src/gdcmHeader.cxx AddDefault trashed
1981 * gdcmGetXSize added
1982 * getimageDataSize now calls gdcmGetXSize
1983 * Test/*.cxx changed to agree with above changes
1985 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1986 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1987 (to avoid double call by end user).
1988 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1989 by end user, since gdcmHeader::gdcmHeader now handles it.
1991 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1992 * gdcm/Doc many doxygen changes:
1993 - Doxyfile now has two different versions, DoxyfileUsers that generates
1994 the html.users end users oriented documentation and
1995 DoxyfileDeveloppers that generates the html.developper developper
1996 oriented documentation.
1997 - README changed accordingly
1998 - requirement.txt removed (old design info moved to TODO).
1999 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2000 DoxyMainPage.txt, DoxyPython.txt provide more information.
2001 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2002 be updated by simply regenerating the docs with doxygen and copying
2003 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2004 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2005 all the tests in the form "if (<map>.count() >1)" were removed.
2006 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2007 ill-formed documentation sections.
2008 * src/gdcmHeader.cxx: ditto
2010 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2011 * setup.py fixed for un*x (needed macro for stdint.h)
2012 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2013 un*ces with sh-utils test utility.
2014 * gdcmPython/demo/test.py renamed to PrintHeader.py
2015 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2016 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2017 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2018 * src/gdcm*.cxx JPR's bad inclusion fixed.
2020 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2021 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2022 * gdcmPython/demo/test.py changed accordingly.
2024 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2025 * gdcmPython/Makefile.am fixed linking against libstdc++
2026 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2027 * Swig subdir (historical tests of swig version 1.3.17++) removed
2028 * Test/testChangeEntete.cxx some lines commented out in order to make
2030 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2031 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2033 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2034 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2035 hence the user doesn't need this explicit call.
2036 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2037 i.e. LoadElements() call removed.
2038 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2039 - src/Makefile.am declares the proper flag for g++.
2040 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2041 for adding user defined new tags.
2042 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2043 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2044 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2046 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2047 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2048 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2049 src/Makefile.am : the project should properly compile and install
2050 with the autotools, included the python wrappers part.
2051 * gdcm.spec.in : added a spec file for RPM packaging.
2053 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2054 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2056 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2057 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2058 to exported to the environement (see gdcmPython/testSuite.py
2060 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2061 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2062 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2063 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2064 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2066 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2067 * gdcmPython/__init__.py doesn't crash anymore when running in
2068 in InstallMode or PreInstallMode but with an environement given
2069 value of GDCM_DICT_PATH.
2070 * src/gdcmDictSet.[cxx/h] coding style.
2072 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2073 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2074 * src/gdcm.h general comments moved to TODO, and README
2075 * src/gdcm.h should now be seen as a user commodity (including it
2076 should suffice to fully use gdcm). It is nowhere including within
2077 any of the kernel files src/*.cxx and src/*.h.
2079 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2080 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2081 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2083 * src/gdcm*.cxx only include their corresponding include file
2084 (as opposed to gdcm.h)
2085 * gdcmPython/gdcm.i changed accordingly
2086 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2087 the autogen.sh generated "make snapshot" command to work.
2088 * autogen.sh removed history related references to crea package.
2090 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2091 * distutilsSwigCPlusPlus.py work around some swig portability
2094 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2095 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2096 was done in a last ditch attempt to get setup.py _really_
2097 operationnal. The python/gdcmPython layaout add the advantage
2098 of hidding away the python related distutils specific files
2099 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2100 Alas, the src directory was out of scope (i.e. it's relative
2101 position to setup.py was ../src) which made things impossible to
2102 handle (see previous version of python/setup.py). Crossing fingers...
2104 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2105 * python/setup.py now works on Un*x. (harder than I thougth)
2106 * python/distutilsSwigCPlusPlus.py can now have include files
2107 among the list of sources.
2109 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2110 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2111 * modifications in MSVC projects
2113 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2114 * As stated by the first lines of Test/ExceptionAndPython/README, it
2115 looks like we can move back to original usage of exception within
2116 src/gdcm* and hence remove the errno stuff that was introduced
2117 as a quick and dirty fixture of this problem (added to the TODO).
2118 * Doc/Doxyfile configuration file for Doxygen and corresponding
2119 README file for usage added.
2120 * Test/testWrite.cxx added. This new test comes from a split of
2121 test.cxx that is now reverted to its original purpous i.e.
2122 testing the proper parsing of a Dicom related file.
2123 testWrite.cxx concentrates on testing the IO part of gdcm.
2124 * Test/bug1.cxx (containing a bug on WIn32) added.
2125 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2126 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2127 whose purpose is to publish the content of the TagNames of the
2128 Dicom public dictionnary were not accessible without an
2129 instance of class gdcmHeader.
2130 - those methods are now static methods of gdcmDictSet and hence
2131 require no instances at all to be invocated.
2132 - within gdcmDictSet this change required to change some method
2133 to class methods (i.e. are now static) among which SetDictPath
2134 (renamed to BuildDictPath) and LoadDefaultPubDict.
2135 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2136 the above changes by calling the new method classes of gdcmDictSet.
2137 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2138 the above to be effective.
2139 * python/gdcmPython: in order to wrap properly the above changes
2140 for Python, swig version now needs to be > 1.3.17.
2141 * python/gdcmPython/Makefile fixed to adapt itself to new
2142 configure/make shema introduced by Johan Montagnat (thanks for the
2143 contribution). Alas this Makefile cannot be turned into a proper
2144 Makefile.am without some heavy changes in the configure.in
2145 (for python dectection).
2146 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2147 now avoids publishing the empty entries.
2149 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2150 * python/setup.py : bug fix concerning install under windows
2151 ExtraPath reused :-P
2152 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2154 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2155 * Dicts/dicomV3.dic : remove double spaces !!!
2156 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2157 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2160 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2161 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2162 method. Doxygenation.
2163 * src/gdcm.h clean up of JPR spurious comments.
2165 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2166 * python/distutilsSwigCPlusPlus.py now properly collects the
2167 shadow classes generated by "swig -c++" (gdcm.py in our case)
2168 when using "python setup.py install".
2169 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2170 reexports the working classes.
2171 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2172 by the classical C errno scheme. This is to prevent an obscure
2173 behavior of the python wrappers when importing wxPython.wx prior
2174 to gdcmPython (which ended up in an abort call). An illustration
2175 of this oddity can be found in the Test/ExceptionAndPython
2176 subdir (see the README file). This problem probably due to
2177 an combination of g++ and dynamic loading.
2178 * added Test/ExceptionAndPython (see above)
2180 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2181 * Changed the layout of the python part to avoid bloating main
2182 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2183 i.e. the distutils arsenal. All the python related stuff is
2184 again in a python subdir, but the package itself is now in
2186 * setup.py was cleaned up:
2187 - pythonIncludePath removed
2188 - python setup.py bdist target is now functional.
2189 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2190 collision with other packages). gdcmPython/demo/*.py changed
2193 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2194 * python subdir moved to gdcmPython (preparation of distutils packaging).
2195 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2196 distutils installer is operational.
2197 * - gdcmPython/__init__.py now properly loads the swig generated
2198 shadow classes (from gdcm.py).
2199 - gdcmPython/demo/*.py changed to import the package gdcmPython
2200 instead of gdcmPython/demo/load.py.
2201 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2203 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2204 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2205 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2206 entries within the associated public Dicom dictionary resp. the same
2207 information but sorted by the fourth field (PAT, IMG, DIR) of the
2209 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2210 are now in the "???" group.
2211 - python/gdcm.i changed accordingly,
2212 - python/demo/printGroupedPublicDict.py added, that gives an example
2213 of the above new functionalities in Python.
2215 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2216 * src/gdcm.h, gdcmHeader.cxx:
2217 - historic references to glib's g_malloc and g_free (#defined)
2218 were definitively removed.
2219 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2220 * src/gdcmElValSet.cxx:
2221 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2222 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2223 - GetElValue(string) renamed to GetElValueByName.
2224 - Added GetElementByName(string).
2225 * src/gdcmHeader.cxx: added
2226 - GetPubElValRepByNumber(guint16, guint16)
2227 - GetPubElValRepByName(string)
2228 - GetShaElValRepByNumber(guint16, guint16)
2229 - GetShaElValRepByName(string)
2230 - GetShaElValByNumber(guint16, guint16)
2231 - GetShaElValRepByName(string)
2232 - GetElValRepByNumber(guint16, guint16)
2233 - GetElValRepByName(string)
2234 - GetElValByNumber(guint16, guint16)
2235 - GetElValRepByName(string)
2236 * Doc/requirements.txt added.
2238 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2239 * Test/Makefile building now depends on the one of libgdcm.so
2240 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2241 pixel data) aware which enables finding the address (offset) of
2242 the pixel data of JPEG encoded DICOM files. This leaves only a single
2243 file in the testSuite whose pixel data address (offset) is unknown.
2244 * python/testSuite.py changed accordingly.
2246 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2247 * VC++ has some strong limitations when working with the STL, as stated
2248 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2249 "Also note that some STL containers (map, set, queue, list, deque)
2250 cannot be exported. [...]
2251 Some STL classes contain nested classes. These classes can not
2253 This is caused by a designed limitation that once a template
2254 class is instantiated, it can not be re-instantiated and
2256 Since our usage of map<> is ubiquitous in gdcm, this "designed
2257 limitation" of VC++ is a pitfall.
2258 Hence the Python wrappers of gdcm cannot be incrementally linked
2259 against the c++ dynamic library. The dirty but only workaround is
2260 to forget about incremental link of dynamic libraries and to generate
2261 the Python wrappers library with the inclusions of the underlying C++
2263 The following modifications concern this matter on Win32/VC++:
2264 - wrapping python correct with standalone wrapped dll (don't use separate
2265 dll under windows !!!!)
2266 - python21_d debug mode enabled (ask Frog how to use it :-)
2267 - NO problem with having an STL member of class for example string in C++
2268 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2269 - Python test of dcmlib in Python is ok under windows on a large set
2271 * removed glib references
2272 * typedef's inserted in gdcm.i for correct swig type management
2274 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2275 * python/demo/*.py load.py extracted from test.py. Added explore.py
2276 that only displays required tags and testAll.py that parses all
2277 the files of the testsuite without using unittest.
2278 * python/testSuite.py other additional test on new files added.
2279 * Data/* new test files added accordingly to the testSuite.
2280 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2281 the vr in the file differs from the one of the dictionary.
2283 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2284 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2285 values, but limits itself to values which are below a user specified
2286 size (by default 1024 bytes).
2287 * python/gdcm.i : elements not loaded (because their size is above the
2288 user specified treshold) are exported with their TagKey as key of the
2289 python dictionary. This enables the testsuite to make some checks
2290 on the unloaded elements (since we have their offset and size).
2291 * python/testSuite.py
2292 - now tests for the existence and proper value of the pixel data
2293 - two new examples added.
2294 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2296 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2297 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2298 aware. See the strategy comments in gdcmHeader::FindeLength().
2299 * Test/test.cxx now accepts a filename as first argument.
2300 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2301 * python/testSuite.py changed to integrate test on above files.
2303 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2304 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2305 the vr was also RET.
2306 * python/testSuite.py more tests added.
2308 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2309 * python/testSuite.py unittest test suite added (uses Data)
2310 * Data/* dcm and acr files for the test suite.
2311 * glib dependance removed from un*x version. We now use ISO C99
2312 7.18 Integer types (see stdint.h)
2313 - python/Makefile, src/Makefile src/gdcm.h
2314 * src/ when an explicit vr (like dicom files) suddenly poped an
2315 implicit element we use to mark the underlying DictEntry of the
2316 concerned ElValue with "Implicit". This strategy was damageable
2317 too the public or provite dictionaries, since some of their vr
2318 would be changed. Since Header::FindLength heavily relies on the
2319 detection by Header::FindVR of falsely explicit elements, I
2320 added an extra ImplicitVr member to ElValue (boolean).
2321 The rest of the changes we the necessary adaptations.
2323 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2324 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2326 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2328 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2329 * Adaptation for porting to VC++:
2331 o forced to use std namespace (for string to be known)
2332 o all class use __declspec export style on WIN32
2333 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2334 (in stdlib.h on Win32 but in std:: for gcc)
2335 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2336 variable GDCM_DICT_PATH.
2337 * src/gdcmHeader.cxx verbose comments made discrete.
2339 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2340 * python/gdcm.i: added a typemap that converts a C++ hashing table
2341 to native Python dictionary.
2342 * python/demo/test.py:
2343 - now uses the native dictionary for exploration of gdcmHeader.
2344 - takes an optional filename argument (the file to parse).
2345 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2346 PubElVals hashing table.
2347 * Dicts/dicomV3.dic removed error prone trailing spaces.
2349 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2350 * Python wrapping process moved away from src/Makefile to
2351 newly created python/Makefile (as well as gdcm.i)
2352 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2353 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2354 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2355 from the environement variable GDCM_DICT_PATH (when existing).
2356 * src/gdcmDict::GetTag bug fix.
2358 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2359 * Straightforward temporary fixes for swig to build the python wrappers.
2360 src/Makefile now has a python working entry [by working we mean
2361 that we can import de shadow classes without errors].
2363 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2364 * hashtest.cxx removed (since allready in Test)
2365 * src/gdcmlib.h renamed to src/gdcm.h
2366 * src/dcm.i renamed to src/gdcm.i
2367 * src/Makefile prepared for python wrapping
2369 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2370 * src/gdcmHeader.cxx :
2371 - Parsing of header is now separated from loading of element values
2372 (see gdcmHeader::LoadElements).
2373 - general clean up of hopefully all file access (creation of
2374 ReadInt16 and ReadInt32)
2376 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2377 * src/gdcmHeader.cxx :
2378 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2380 - SetLgrElem renamed to SetLength
2381 - GetLgrElem renamed to GetLength
2382 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2383 * src/gdcmElValSet.cxx fixed both GetElValue methods
2384 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2385 due to IdoDude was cleaned out.
2387 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2388 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2389 concentrates on finding the value representation (when it exists).
2390 RecupLgr now only finds the element value length, and it avoids
2391 returning the unecessary skL (skipped length).
2392 Also, offsetCourant was simply removed (with taille_fich) since
2393 it was redundant with the File position internals (by using
2394 ftell and fseek). This also made skL (see above in RecupLgr) usage
2396 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2397 on the libido specificities which are handled through class
2399 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2402 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2403 * Truckload of changes. Parsing of header is barely functional
2404 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2406 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2407 * src/gdcmHeader.cxx many addons of low level methods
2409 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2410 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2411 and _IdDcmSWAP_LONG.
2413 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2414 * This corresponds to all the changes decided at the meeting of
2415 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob